OK; now, the commenting out of most of the crtclient, is that a good way to approach this? It seems like libnetwork really wants to move the interface inside the container.

I’ll try the EPCreate stuff but I get the feeling I’ll be reading the same state for Join, which should make things easy.

Anyway I’ll retool and submit for another pass hopefully by Monday morning.

-Erik

> On Jun 5, 2015, at 12:31 PM, Madhav Puri <notifications@github.com> wrote:
>
> @erikh <https://github.com/erikh>, Overall I think this is the right structure!
>
> As this is an early implementation, I mostly have a comment around using netmaster/netplugin for posting the configuration states. I realize you might already be aware of this but thought I will share so we are on same page .
>
> Right now you are managing the ovs specific configuration state (we usually refer it as concrete or network-function's configuration) directly as part of the Create/Delete requests. We actually want to create/delete the configuration state that is understood by the netmaster instead (we usually refer it as logical configuration). This can be achieved by invoking netdcli, as netmaster is not a daemon yet. This will ensure that we make use of all the logic built around resource management (like allocation of IPs, vlans etc) for networks and endpoints and also to correctly trigger the Netplugin. For instance checkout one implementation of (now outdated version) driverapi.CreateEndpoint() at https://github.com/contiv/netplugin/blob/master/mgmtfn/pslibnet/libnetdriver.go#L76 <https://github.com/contiv/netplugin/blob/master/mgmtfn/pslibnet/libnetdriver.go#L76>.
>
> Following is one way I think we can hook up libnetwork events with netmaster configuration. But there might be other ways as well so please feel free to suggest/correct if I missed something. Note that some changes might be needed in a way we invoke netmaster once we move to a multi-host environment, but we can take them up later once we have basic integration working.
>
> Driver Init (or main()): Here we can possibly push the logical config pertaining to the initializing the driver itself. For instance for vlan-based networks we need to push this configuration today to add host's data-path netdevice to the ovs bridge:
> # netdcli -add-cfg - <<EOF
> {
> "Hosts" : [{
>         "Name"                      : "host1",
>         "Intf"                      : "eth1"
>     }]
> }
> EOF
> Network Create: Here we can push the network's logical configuration (derived from the labels/options passed by libnetwork). Note that network and tenant names shall come from labels passed by libnetwork to the driver. I am also assuming that Tenant was created before hand with it's logical configuration pushed separately by calling 'netdcli'. So equivalent netcdli calls from shell it will be:
> # netdcli -add-cfg - <<EOF
>  {
>    "Tenants" : [{
>         "Name"                      : "tenant-one",
>         "Networks"  : [
>         {
>             "Name"                  : "orange"
>         }]
>    }]
> }
> EOF
> Endpoint Create/Join: Here we can push the endpoint's logical configuration, mostly it will be container's name or uuid. And return back the interface name, IP etc as assigned by the netplugin/netmaster by reading it using netdcli again. So equivalent netcdli calls from shell it will be:
> # netdcli -add-cfg - <<EOF
> {
>     "Tenants" : [{
>         "Name"                      : "tenant-one",
>         "Networks"  : [
>         {
>             "Name"                  : "orange",
>             "Endpoints" : [{
>                 "Container"         : "myContainer1",
>                 "Host"              : "host1"
>             }]
>        }]
>     }]
> }
> EOF
>
> #netdcli -oper get -construct endpoint orange-myContainer1
> For delete events netdcli can be invoked with -del-cfg flag
>
> /cc @shaleman <https://github.com/shaleman> @jainvipin <https://github.com/jainvipin>
> —
> Reply to this email directly or view it on GitHub <https://github.com/erikh/netplugin/commit/4cd37421467d4471a87c1a11f2292e81ed4aba9e#commitcomment-11547804>.
>


Nice cleanup. :)


My PR originally overlooked this as well. This commit fixes an issue that languages other than English would have run in to.


1. We can call this inside state resolve block
2. We need error message alert to notify user of error while trying to retrieve immunization list.


yeah, having an empty serviceName can and should be a hard error before we cut 2.0.0 imo


OK!


Why?


We need error message alert to notify user of error while retrieving immunization settings


Proper devres support for the fpga_manager would make this remove() totally unnecessary :)


He , did it is ososangre.
5 cze 2015 21:50 "assassina" <notifications@github.com> napisał(a):

> I was expecting the author of the commit to say anything before we proceed
> to any rollback, but he didn't say anything until now.
> I might have some time at this weekend. So, is it unanimous that a
> rollback is required? Should I do that at the next days?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opentibia/server/commit/b06bf832a0d36c2c91169553d79afd8c7e0fb1f3#commitcomment-11548085>
> .
>


Why revert this?


This is related to the comment above on plugins/Goals/Goals.php:L233


No, I mean that there are already 3 functions in the master branch (`getColorCameraParams`, `getIrCameraParams` and `getSerialNumber`) which seem to be more or less identical to the functions from this PR, but it's still open...


This example makes it much more intuitive! :+1:


It is the same person, but github does not show it.


We need error message alert to notify user of error while trying to retrieve immunization settings.


should we have a check that consul's version supports atlas here?


OK. Question to self: shouldn't pylint catch this?


Users needs to be notified that an error occurred while saving summary record, currently when a save fails, nothing happens.


Little note, otherwise looking good, I haven't tried this with consul 0.5.x I'm assuming it works from this commit?


Fixed in 672371be0ecf5b88fab52c503b553549d07ed2cd. Thanks!


cool. This is something that would have ended being requested.


Just store the base URL, then build a `:params => {}` hash to pass into `http.rb`


Introduces this bug, when AUTOTEST_PATH is not set:

      $ ./run -h
      Traceback (most recent call last):
        File "./run", line 976, in <module>
          app = VirtTestApp()
        File "./run", line 483, in __init__
          self.system_setup()
        File "./run", line 468, in system_setup
          _import_autotest_modules()
        File "./run", line 102, in _import_autotest_modules
          autotest_dir = os.path.expanduser(os.environ.get('AUTOTEST_PATH'))
        File "/usr/lib64/python2.7/posixpath.py", line 261, in expanduser
          if not path.startswith('~'):
      AttributeError: 'NoneType' object has no attribute 'startswith'


The build failing here doesnt really make any sense... the migration scrips are definitely there.


Just because I didn't write the original validation function. I've rewritten it using str.translate though.


A stupid optimization here:

```
   def _set_paths(self):
      if self.args.paths:
         return self.args.paths
      return [data_dir.get_test_dir()]
```


Pull request with fix: https://github.com/autotest/virt-test/pull/2213


:+1: ya pone marcadores azules y rojos :smile:


Instantiate your `FetchTimer` object outside the server block, then use it inside the block several times. And only make one.


I'm not sure that we need logging yet. Since we already return the success/failure to the user, I don't think we gain much by logging it on the backend too. If a large file is uploaded, this will result in a large number of lines spamming the logs.

Error logging is beneficial to track information that would be otherwise be hidden from the user. But since they'll know exactly what happened, we can probably skip the `log` calls here.


@clebergnu I thought it should, but it seems I was wrong.


Dynamically store and pull your timezones ( in all lowercase symbols ) rather than explicitly pulling them, so you can add/remove timezones easily.


I have rewritten SDX2 decoding, so that it decodes only during readBuffer(), which of course requires me to return a RewindableStream only.

But makeAIFFStream() is supposed to return a SeekableAudioStream, which I don't think is possible without decoding everything.


Only provide this information if the URI is `/` and return `404` for everything else.


Looks like you need the vocatives for these two.


Haven't heard anything about it. Do you have the latest version of atom installed?


OK, I can do that.


makes sense, I will remove the logging.


Vocative?


This goes inside the server block. Otherwise, every time you pageload you will taint the data.


Feel free to ignore this: when "decorator" shows up in Python code I immediately think of, you know what. Maybe "output_style" mapping?


This becomes a constant ( `ZONES` ), and becomes a `Hash`, see comment below.


Pull from `ZONES` constant you make above.


Trailing σ here; I think it should be removed.


I love refactors! Great work!


I thought about cpuid, but as you list, it is NOT portable.

How could we determine the commit hash ?


In fact I modify this later, so there's nothing left in the final result, making it not worth it to change things.


This is really powerful. Nice stuff!


Do not commit local paths. Use local configurations to override the local path, but leave the `Gemfile` pulling from the repository with the appropriate information, i.e. `github:` and `branch:` and `submodules: true`


Need newline at end of file.


In the end, this turns into

    def get_type_label_mapping(self):
        """
        Get label mapping for display in test listing.

        :return: Dict {TestClass: 'TEST_LABEL_STRING'}
        """
        return {test.SimpleTest: 'SIMPLE',
                test.BuggyTest: 'BUGGY',
                test.NotATest: 'NOT_A_TEST',
                test.MissingTest: 'MISSING',
                BrokenSymlink: 'BROKEN_SYMLINK',
                AccessDeniedPath: 'ACCESS_DENIED',
                test.Test: 'INSTRUMENTED'}


Thanks @oliviertassinari - I've cleaned up the code with: https://github.com/callemall/material-ui/commit/683e5beffc274065ba08595bc7ce950b59c6498c


Yes, you've hit the other "fun" part here. Now that we support rtti, you should use make AIFF return an AudioStream pointer and adapt calling code to use dynamic_cast to RewindableAudioStream or SeekableAudioStream (whichever is appropriate).

Alternatively, implement seeking by starting from the beginning and decoding until you get to the right sample. Not nice either.


So I don't think it's worth changing this here.


wtf?


Yep, found it. Please disregard.


Always at `Gemfile.lock` to your `.gitignore` ... and `.DS_Store`, etc. Always use `.gitignore` or you will be electrocuted by 37 lightening bolts. That's on top of the 99 you're due for if you don't change your username.


@tsteur I tested using `Translate::findTranslationKeyForTranslation($report->getCategory())` instead of `$report->getCategoryKey()` in plugins/Goals/Goals.php:L182, but found a problem. The method would search for the string "Referrers", and return the key "Goals_CategoryTextReferrers_Referrers" instead of "Referrers_Referrers".

Adding logic to detect and fix this mismatch (that possibly doesn't arise in some other languages?) seemed to be a bit clunky compared to the very straightforward `Report::getCategoryKey()` method, though I am always open to suggestions :)


`celluloid/current`


Why do you remove map code and use the old code?


whoops, I'm sorry :( I'm looking into your PR


It would be useful to note the framerate here, because users might not know what the correlation between resolution and framerate is. `576i (50 Hz)` / `480i (60 Hz)` / `480p (60 Hz)`


y u no leave it as value object within Scripting?


Don't mean to intrude on this if it's still WIP but instead of using `map` over each record you could use `destroy_all`. This is looking good though! :+1:


Yep, I was reckless here. This looks good.


this is only a comment


We may be doing this with plugin types, but wouldn't just checking the subclass like it's done bellow be enough and really accurate? I can't think of a reason, so that's why I'm asking.

BTW, that's me thinking of a "Writing Plugins Guide"...


i vote for removing BufferPool altogether but not strongly enough to hold this up.


Bootstrap project


This member is never used.


PullLogicFromPlantComponents (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.41%25-red.svg)


LGTM! Even though it was a quick review, which after so many other reviews is OK.


In context, I think `ready` in `window ready` refers to received segments, which doesn't seem like a great place to get our advertised receive window from (since our ability to process the incoming data should inform this, rather than the remote end's ability to process incoming data).


if you log in, you will see networkId being displayed for persons.


OK, brave and bold stuff.


Initialization race. I want stuff connecting signalRelay already at initialization, but Scripting is only initialized once initializations are done, so addObjects can do the job. The alternative could have been calling addObjects separately from knossos main after everything's finished, you can alter it if you want.


Sure, that's something that didn't occur to me at first, but makes sense. This in turn reflects other parts of the code where we do that. I suggest changing/fixing this on another PR, though.


OK! Nice.


Looks great!


In fact, giving credit where credit is due, @ldoktor already mentioned that in one of his early reviews. I still stand by my position that we are in better position to fix that all at once in the codebase.


That’s not correct. Every member variable is already initialized when the scripting ctor is entered.


Neat


rax retry tests


OK, so we are all in agreement. What about writing a card about it? I'm doing some functional test to hopefully merge it afterwards.


why not just add `.` as a valid character?


63 is an odd throwback to 1990s DNS technology, we should support the full 253 bytes.


Duplicate line?


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 53](https://teamcity.labkey.org/viewLog.html?buildId=253755&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 0 Build time: 00:03:41
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

```


Should restoring the autoconnect setting be in a finally block?


why not get rid of the loop (using `.` as valid character) and `return hostname.translate(hostname_allowed_chars_tbl) == ''`


All right, I'm on it.


Why not create 2 makeAIFFStream()s. One for seekable streams. One for rewindable streams. And the seekable one wouldn't return a stream in case it's for example SDX2?

And later one could for example create indexing code, so that even SDX2 would be somewhat seekable.


that's the good point with the new architecture. And if we choose to change the cursor or whatever, it should be easy ^^


teste


Should we keep this around since the entire method body has been commented out?


Šitam nevajadzētu krist git repozitorijā, tev kaut kas interesants ar to .gitignore un to kas tika iekomitots pirms .gitignore papildināšanas....


I've tried to almost only use a find/replace to make reviewing as easy as possible


Wrong choice of words: I want initialization of globals - which as you said happens before Scripting - to already connect SignalRelay signals.


Yes. Now that I've done it, it seems so natural...


Each label can apparently only be 63 octets long, with the total a maximum of 253. Does any other software support labels longer than 63 bytes? We could just put `.` in the allowed_chars table, would be easier but we won't be properly validating the names.


Because that's a hack. dynamic_cast is the proper solution as long as the AudioStream class hierarchy remains the same as it is today.


An altogether different alternative would be to properly expose everything to python and give up on SignalRelay. That would take more thought and I give it up at the moment.


Wow such c++
many pointers
much calloc
wow


duplicated


Thanks a lot!


The path `/tmp` does not exist in Nix build chroot environment. The proper location can be found in the environment variable `$TMPDIR`. This is also what POSIX mandates: https://en.wikipedia.org/wiki/TMPDIR.


I don't think it really matters.  I'd rather not burn the CPU validating that all the label parts are right.


I'm not seeing that locally.


This will get rid of those pesky hidden bytes (coloring, etc).


PullLogicFromPlantComponents (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.48%25-red.svg)


btw this commit does not compile


Should have args indeed, see #340.


Out of curiosity, why xMLObject and not XMLObject or xmlObject?


I do and pushed a fix.


I forgot a mainwindow.cpp change, since I'm committing it soon with another change, I don't recommit only for this fix.


Remove this comment and the function `redraw_all` (which seems to be not called anymore from anywhere?). Or move the code below into this function.


But seeking won't work when a RewindableAudio class gets casted to a SeekableAudio class?!


Wrong guotes used around "commit"?


That's why it's dynamic_cast and not static_cast.


Ir zbis, bet no koda strukturēšanas viedokļa elegantāk būtu šādi:
```ruby
class User < AR::Base
  def self.authenticate(username, password)
    if user = find_by(username: username)
      if user.valid_password?(password)
        user
      end
    end
  end

  def valid_password?(password)
    encrypted_password == Digest::SHA512.hexdigest("#{password}#{salt}")
  end
end
```

tad kontrolierī būtu vnk:
```ruby
def create
  if @user = User.authenticate(params[:session][:username], params[:session][:password])
    session[:user_id] = @user.id
    redirect_to diaries_path
  else
    render 'new'
  end
end
```


Merging lm branch


Maybe not for this PR, but we should make `options` a hash or (if that's not possible for some reasons) at least define constants for the indices. How the hell am I supposed to know what option 2 is? Might also cause problem when reordering options.


PullLogicFromPlantComponents (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


It sets the location of the return statement to end of main. This breaks code coverage, e.g. test a20.

I put the change here https://github.com/ldc-developers/ldc/commit/227f16bcce930fabfe223b434baee6ce2cd8521d, but this is ugly.


Also for https://github.com/mattlo/angular-logger/issues/1


Seen that - just fixed while you were writing :)


Very true, whoops. Good thing I didn't upload to hackage yet ;)


See above about logging.


pašaizverošie tagi jāraksta vai nu šādi `<br>` vai nu šādi `<br/>`, bet ne šādi `</br>`


What if this is _not_ part of an `"language"` field?


This allows any version of Julia - are you testing with anything prior to the first 0.3 release? If you just list `julia 0.3` that means 0.3 is a lower bound and there won't be an upper bound. Which is probably what most people think the `-` means, but it's a bit counter-intuitive.


When you fill-up the wrapper remove the __attribute__((unused)). It helps to compiled without error (not used variable are considered like an error)


@vlj .You are quicker than mine and i just done this morning and plan to submit pull . Heeee


Looks good, thanks Rob


Is this still current when I create the project I get a separate main activity fragment with a single fragment inside as such I've changed
ListView listView = (ListView) rootView.findViewById(R.id.listview_forecast);
 To
ListView listView = (ListView) getActivity().findViewById(R.id.listview_forecast);
Which causes a force close


Da fak is this? Var jau redzēt ka no konsoles vnk iepeistots :trollface:


note the matrix comes from issue #162.


nja, vel nesaprotu kādēļ gits grib šos komitot, bet tev arī vajadzēja paskatīties, ko tu pūt iekšā komitā, nevar vnk vienmēr taisīt `git add .`, jākomito tikai derīgas lietas.


I am not sure about vec_ctf because it converts to floating point here we are trying to do a bit bit operation and flush the sign bit. To check with the test.


I like that you're accounting for the image scaling. I've been trying to figure out how to go about scaling the bitmap.


The SQL_MYSQL_TEST_SERVER variable shouldn't have been in this commit.
The MySQL tests are enabled in commit https://github.com/pwdng/freeradius-server/commit/918405105a21a3eb207e83b4462fa70b0a15fa78
With both commits, both tests will be run.


You're missing an `e` at the end of `if you don't supply on.`


Is this for the motivational black border?


NPE!! I will fix it


Well during animation, its not exactly UI thread running.

It crashes a whole lot without wait though.

On Fri, Jun 5, 2015 at 1:24 AM, Maciej Witowski <notifications@github.com>
wrote:

> Is wait() really the best option here? I'm not sure if you know but
> Espresso works in a way that it always wait for UI thread to become idle
> before going to the assert commands (the main purpose for this is not to
> have use "wait" kind of methods).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Wootric/WootricSDK-Android/commit/378e1cf67feb9913529929443851fbb159915eea#commitcomment-11536771>
> .
>


vnk padomā ko šitā rindiņa dara - mums ir atlasīts current user no db jau, davai atlasām vēlreiz. Kāda jēga? tad jau vismaz šādi labāk, lai nav no DB vēlreiz jāatlasa - `@user = @current_user`, bet nu vispār jau man šķiet, ka tev nekas neliedz izmantot vnk `@current_user`


var arī šādi `@school_diary_record = @current_user.school_diray_records.build(school_diary_params)`


^ Change it to any key you want?


@Myoldmopar I find this file ordering very confusing + it leaves out the `13-EncyclopaedicRefs.md` file


is this where an os-specific ifdef is needed?


pirms save jau nu nav jēgas lietotāja `id` uzsetot sesijā, jo nesaglabātam lietotājam vispār `id` vēl ir `nil`.


I don't know why, my answer was lost and I just saw that now :(
So I will take the time to write a good answer again....

I’d like to do some optimization of existing code. Mostly it is cleanup and
> refactoring it should not affect any functionality.
>
>
You could go but I never did it because I don't want to break the pull
requests waiting. If you want to do it, do very short refactoring one at a
time and even with that, I can't guarentee you that they will be merged
quickly (or simply merged!). But it's a good idea...

> I also like to propose to separate tfs bridge functionality to independent
> library and use executable with comfigurations and help as point of access
> to this library. In the future this library can be used independently in
> other applications. For instance I’d like to develop a plugin for Git
> Extensions to use tfs for git
>

Making git-tfs a library will be a huge work and I am not sure it worth it
:(
I already thought about it and I arrived at the conclusion that nearly no
one will want to use git-tfs (which should be a temporary use) in its
software.

I think that with GitExtensions, you gave the ONLY one software that could
find an advantage at that.
But because GitExtensions use the native git executable (and do not still
use the libgit2sharp library), it could also use the executable of git-tfs
also without too much problem.
We even have a GitExtension plugin for git-tfs:
https://github.com/git-tfs/git-tfs-gitextensions-plugin
You could contribute and improve it if you want. There is no more an active
maintener but I fix it not some long ago...
Personally, I have always prefered to use GitExtensions scripts with 3
commands for 'git tfs fetch', 'git tfs pull -r' and 'git tfs rcheckin' and
felt it more convenient (it's one click away if you put it in the toolbar!)


compilar


inmi


Uu īstenībā var vēl labāk -> `<%= @current_user.try(:username) %>`, ja @current_user ir nil, tad arī rezultāts būs nil.


Nē nu paņemšu forku un salabošu šito :)


why not keep the type hint, but allow null
`public function setUser(UserInterface $user = null)`


Kurš tev ieteica haml? Anyways, tagad mēs swičojam uz slim -> http://slim-lang.com/, tipaa mazliet ātrāks un labāk atbalsta rails fīčas


inline styling is bad!


What about this?

```
x = (1, 2, 3)
x.count(2)
```

Why can't I use a list as a key in a dictionary?


I can never find my relation either... but dying from it gives her way to much credit... ;-)


Forgot to remove commented-out code (I really need to stop doing this)

b47de921f9b1ad2d4c02d86e6edbfc27d9738508


Viena lieta ko der apskatīties ir layout, lai nav visos viewos jāraksta:
```
+!!!
+%html
+  %head
+    %meta{:charset => "utf-8"}
+    %title schooldiary
+  %body
```


Kas ieteica likt mysql un kādēļ?


nice :+1:


Where should we login?


I'm struggling to remember what this code added.


Add a space after `function` and remove the surrounding whitespace inside the parens.


No idea why this was here.  `git rm` candidate?


This might be useful, but I don't know why you're putting in here... if you want this "extendMethod" idea included, I'd create a separate PR for it.


I'd be surprised if we didn't have this in Sufia already.


I have no idea how that even happened. Software is just destined for failure?


I think this will break for things that are not `create`... why do you assume that `self` is being returned? It could be any type or nothing at all.


Indeed. I'll fix tomorrow.

Thanks,
Volodya

On Fri, Jun 5, 2015 at 9:09 PM Daniel James <notifications@github.com>
wrote:

> This change broke the documentation build. I have things like this in my
> user-config.jam:
>
> using gcc : : ccache g++ --std=c++11 ;
>
> So now I'm getting errors like:
>
> sh: 1: ccache g++ --std=c++11: not found
>
> It's easy enough to fix my configuration, but I imagine other people might
> have a similar problem.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/boostorg/build/commit/831e37cedb1aeefb53f20afd600618a7946241e9#commitcomment-11546352>
> .
>


Agree, could find a better place. First I wanted to see whether you like the whole concept.


Shouldn't this be `self`?


This too


Should we try to remove the file once we're done w/ it?


True, will fix it.


I guess not, considering extendMethod calls this function using .apply()


This commit removes index.js, but I think that was meant to be part of 8414a8ac17a0c8ace983e2226cbc213b8ded2782


Thanks for this fix, @matthewayne

```
pip install --upgrade git+git://github.com/evernote/evernote-sdk-python.git
```

worked like a charm to get the update for me.


or rather, below.


This change is necessary due to the move from paperclip to carrierwave. We did the same in Sufia:

https://github.com/projecthydra/sufia/commit/d1e70750c772d83a4c4b904572de51e4bb80ac7c#diff-7b60e62f2cde5994b4c4f5ac64992bdb

My fault. :unamused:


fixes #1


PullLogicFromPlantComponents (Myoldmopar) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.48%25-red.svg)


This commit should be rejected.


Nice update thank you :)


Commit message: - "_place"


Thank you.


Not sure where to report this, but this commit appears to cause the NotImplementedError on line 44 of gis_tests/tests.py to be raised by test_valid_version_numbers and test_no_version_number.


Weird, this one's been in Sufia forever.


Can look for more info here: https://www.mankier.com/1/ansible-galaxy


Can I please have your username thanks


Indeed. ;)


It is, but my point is that I've only ever seen \x## used within strings and I don't want to have to try to handle parsing things like

"\xaa\"\\" "\x01"


trying it now...  found where this ends up.  Great fix.


> I was  also thinking about compiling Vanir for Codina if anyone is
interested,  but that's just a loose idea.

@mkaluza,
I think that I will at least need your help with vanir :D
It has booted properly(although I messed up with proprietary blobs - they weren't added in package, so added them manually). STE multimedia fix seems to be completely missaplied (camera, audio and hardware video decoding doesn't work at all). There are device tree https://github.com/ChronoMonochrome/android_device_samsung_u8500-common and https://github.com/ChronoMonochrome/android_device_samsung_codina , these are patches that I've used https://github.com/ChronoMonochrome/android_device_samsung_codina/tree/vanir-kk44/patches
Btw, did you apply any patches to your build (I mostly mean fixes from TC / Meticulus etc)? I have seen that multimedia fix for frameworks/av was already applied, apparently it doesn't work for some reason - later I'll try revert it and manually re-apply.


> It's breaking change (for example, for Grunt tasks). At least it had to be mentioned in changelog.

In general, the changelog only includes changes to the language itself—changes to the underlying Ruby API aren't usually included unless they're very major.

> Besides, is there any particular reason to cut down default path?

The default import path changed when running Sass normally as of 3.4; this is just making the API consistent. In general, it seems very strange that Sass imports would rely on the working directory of the command that invoked Sass, and having it on there by default caused a lot of problems with directory-watching.

>  If someones forgets to override `:load_paths => []`, it will result in errors about missing Sass files during `@import` in case of relative paths.

Relative imports don't use the load path; they're relative to the file that contains the import.


Document why you're doing this.


Should have been added by Sufia's "upgrade400" generator.


Please don’t remove 0.10, it’s still supported both by PEG.js and Travis CI.


será possível algum tipo de assembly assim?


It is not a valid case : see FastBoard contructor from FEN. If the posiiton comes from FEN with an EP position, i add the previous double pawn push as the last move


LGTM.


f


Unfortunatelly, the "encode" built-in function is no longer present in python 3.
I tried to simply delete this conversion, but the unicode error pops while reading the file, and there is no proper way to report the error there...

In other news, I just created the pull request #142 that enables python 3.2 testing in travis.


Presence of question is checked. Field author removed


Ok, I pushed to the branch --force to the PR should be updated as desired.


PullLogicFromPlantComponents (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.48%25-red.svg)


corrected


what I mean is, in the main routine:

```
interactor.begin_section(...)
execute_section(...)
interactor.finalize(...)
```

i.e. remove the finalize completely from Processing.py!


> the commenting out of most of the crtclient, is that a good way to approach this?

I think we can use the `-native-integration` of netplugin binary. IIRC it was introduced with a similar purpose to not call into crt-client apis for environments that take care of managing network-namespaces themselves.


Great use of filters here, I love it when markup is this meaningful and declarative


Good idea but I’d rather see this changed in `package.json` so that `npm test` runs `make hint` too.


You do not make a difference between Promotion and Promotion with capture if you use PROMOTION_TYPE_MAGIC. I'm surprised the tests still work


Ich denke/hoffe wird so auch passen nutze das Plugin kaum, der Vorschlag kam von einem User.


@AbdealiJK you can just do `assert 1 == 2` IIRC


PullLogicFromPlantComponents (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (644 of 644 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.32%25-green.svg)


looks good!


Please no badges in README.md. It should be an intro, not development dashboard.


think u can just do </br>


This is a draft. Feel free to edit as you wish, or delete. I have it in dropbox too.


Either all or no values in the list should be quoted.


I'd probably check to see if ENT:IsNPC() first though, even though it doesnt matter to most lol


What does this do? Does this get called for each number that is printed?


Added after Sufia 4.0.0, and wasn't related to the 6.0.0 work, so this was not included in an upgrade generator. Could be a good candidate for an upgrade500 generator to ease the upgrade path?


\o/ YAY! Great job.


do u want to keep this if not remove it


I think you mean QUEEN_SIDE_CASTLING here


Ok, updated the PR again w/ all these fixes.


i`am here


You need to get the extension out of the hosted context by adding "SAFARI" to [this function](https://github.com/sammyshj/privly-applications/commit/76f276564b5348c16fb31464f767a4d2b622e199#diff-1bdd735388d0e57a47212db41f25b3f4L91).


ok. I see the error comming when running perft test. (The perft test is running well tough)


delete


That should be all for me I guess. I'll send the email to Viktor & Etienne tomorrow after you've send me the last version of the slides. :wink:


@AbdealiJK Actually those brackets are a bit dangerous because if you *had* written `(1==2,)` it would be a tuple or if you had multiple elements and as it would be nonempty that assert would yield true in every case. E.g. if you do `assert(False, msg)` that *looks* like a function call but I think that assert won't yield an AssertionError because you're asserting that the `bool` conversion of a nonempty tuple is True.

Example from python interactive command line:

```
>>> assert(False, "msg")
<stdin>:1: SyntaxWarning: assertion is always true, perhaps remove parentheses?
```


use temple master


Going through the signalRelay?
I get that it is necessary for data manipulation to know when loader is finished, but i think it just looks wrong this way. (it has nothing to do in a toolbar, especially not so prominent)
Apart from that, Knossos is unusable now, try to drag around the dataset a bit…


Ah yes you are right..


Attempting to fix travis build. Update `.travis.yml` to use `pip install` instead of `setup.py install`


Ah, good catch!


I'm going to have to adjust to that new reality. I used to be able to push emergency fixes etc, but that won't be possible anymore, given the time it takes for a new version to be approved.

So I will have to wait longer to post updates in the Chrome store, and I will pick the best most recent stable release in [Releases](https://github.com/gorhill/uBlock/releases), not the latest one. This will reduce the likelihood of publishing a version which may have something important broken in it.

I consider #300 was such a breakage.

So I will continue to push releases in [Releases](https://github.com/gorhill/uBlock/releases) without restricting my pace, but for the Chrome store I will pick the one which has proven the most stable, so the Chrome store won't be anymore in sync with [Releases](https://github.com/gorhill/uBlock/releases).


Oui moi aussi 😊
J'essayerai d'être là demain aprèm
Le 5 juin 2015 10:51, "Valentin VERGEZ" <notifications@github.com> a écrit :

> J'espère au moins que tu t'en débarrassera avant la fin de ton stage ! [image:
> :wink:]
> Y'a du monde demain à Polytech ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PyroTeam/robocup-pkg/commit/f9ce8e3a8708cd048b9a28f4ad19e0cbc9229ce5#commitcomment-11537220>
> .
>


Random thought: in the emacs/readline way of doing things, Ctrl-D means "EOF" when there's no other input on the line, but "delete forward" when there is. Do we care at all about that second thing? If we're only doing to use it for password entry then I can't imagine we do, but if we want to use it for other fields then maybe?


This is neat, and simple. Hadn't thought of that! Thanks.


This should return "SAFARI", https://github.com/privly/privly-applications/blob/master/shared/javascripts/network_service.js#L94
Am I right?


looks like cairocffi 0.7 needs cffi>=1.1.0


Done.


Possibly `jQuery.grep` (like Ruby `filter/select_all`) could read a bit clearer. Though this isn't hard to read. http://api.jquery.com/jquery.grep/


Thanks Tony. I agree (and my intention to specify that was in the commit message). Done.


Sorry, still one tiny issue: No newline at the end of file.


No, make a SAFARI version of [this](https://github.com/privly/privly-applications/blob/master/shared/javascripts/network_service.js#L100).


`isAuthoredByYou` already checks for this.


no me gusta tu function


@eyakubovich , why not to check whether next hop matches already existing peer? Why did you decide to update the next hop without checking it?


Mmmm....


now the comment above doesn't match anymore...


Debeira decir perro


Mmmmm...


Oh, no, sorry, didn't realize the line below checked for it *not* being authored by you.


Fixed.


@kimo72 :fire:


Not sure I understand exactly what happens here but it seems src/main/java, src/main/resources and  src/main/webapp  seem to be treated equally, when in fact the 1st 2 should be mapped to WEB-INF/classes


On Fri, Jun 05, 2015 at 02:38:59PM -0700, Craig Barnes wrote:
> looks like cairocffi 0.7 needs cffi>=1.1.0

Yup, it was just tagged, need to review/merge #673 and it should be
resolved.

> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/qtile/qtile/commit/c8335bd33bd1d0e44a233ba8946962c38b124451#commitcomment-11549720


It's done. Local testing showed that it is now working nicely

@bgruening I pushed a new image up to docker hub. Please use qiaoy/iobio-galaxy.bam_iobio_io:rproxy to test. here is the start-up script that is much cleaner

```bash
#!/bin/bash
#
# Example script to launch the container while providing
# the to-be-visualized bam file on the commandline

# The following env vars will be honored by the container startup script

export PUB_HOSTNAME=$(hostname -f)
export PUB_HTTP_PORT=8080

# Launch the container

docker run -it \
        -p $PUB_HTTP_PORT:80 \
        -v ${1}:/input/bamfile.bam:ro \
        -v ${1}.bai:/input/bamfile.bam.bai:ro \
        -e PUB_HOSTNAME \
        -e PUB_HTTP_PORT \
        --rm qiaoy/iobio-galaxy.bam_iobio_io:rproxy
```


LGTM


My Angular is rusty but I guess this means we get a n*n type thing where it loops over all comments and then again for each of those. Probably not a problem – I guess you verified it's not perceivably slower?


Il n'y a pas une erreur de copier/coller ici : la ligne suivante identique avec cette fois-ci un return. La ligne en question ne semble pas nécessaire ou alors j'ai raté un truc


If you like, you could use `Hash#values_at`.


:P


Congratulations! :tada:


Saying that "it will overwrite any ordering you have specified" isn't quite right.

As of 966a29c2 (Django 1.9), the system check framework raises an error if you set `order_with_respect_to` and `ordering` for the same model.


OK.


in python there is a difference between
```python
if VAR:
```
and
```python
if VAR is not None:
```
or
```python
if VAR is None:
```
namly the second version is more efficient for the compiler if you know your only looking  for None, this is why i have it this way


@eyakubovich , does it make sense to use mutex when updating `routes` or that variable is safe in Go/C combination?


Should "but down" be "put down"?
oh the irony. Sorry not trying to be a typo Nazi :)


looking at this i do agree it is duplicated, but wow, a pull request to remove an extra else? come on


@JackMc this is failing for me on docker-py 1.1.0. Do we need a version upgrade in setup.py?


Awesome that you were able to add this with so little code (and so long after we last used Angular). :sparkles: :tada:


# -*- coding: utf-8 -*-
from selenium import webdriver
import unittest

links_landing_titles = {
    " Contact" : "contact"

    }

class SauceLabsHeaders(unittest.TestCase):
    def setUp(self):
        self.driver = webdriver.Firefox()
        self.driver.implicitly_wait(30)
        self.base_url = "https://www.deanza.edu/"
        self.verificationErrors = []

    def test_sauce_labs_headers(self):
        driver = self.driver

        for link in links_landing_titles:
            driver.get(self.base_url)
            driver.find_element_by_link_text(link).click()
            expected_title = links_landing_titles[link]
            try: self.assertRegexpMatches(driver.title, expected_title)
            except AssertionError as e: self.verificationErrors.append(str(e))

    def tearDown(self):
        self.driver.quit()
        self.assertEqual([], self.verificationErrors)

if __name__ == "__main__":
    unittest.main()


I may be mistaken, but is it possible that the `taps` list contain non-successive indices, for instance `[-4, -1]`, and taking the length is not correct? Or has some other step before taken care of that already?


Any reason for not sticking with:

```
version = avocado.version.VERSION
release = avocado.version.VERSION
```


This is actually a really cool idea instead of having to modify build repo.


Oh, nevermind. Locally it'd be fine, but not on Travis (until we have proper naming and PyPI support).


Since we don't CAP in standard randbats do we even need randbat sets? XD

CAP randbats new meta


Oh, it may certainly be sub-par.

We’re actually just searching, in roughly this order for a given $PATH:

1. Classloaders
2. src/main/resources
3. src/main/webapp
4. target/classes

The reason for a lot of the complexity is that the Undertow HttpHandler does not have access to the deployment’s own classloader, (TCCL is org.wildfly.extension.io or some such).

The goal of a StaticDeployment is only/exactly to search static content.  To mix static into a servlet/jaxrs deployment, I reckon I need to do further work, or at least get what’s supposed to work to actually work.

	-Bob

> On Jun 5, 2015, at 5:43 PM, Fred Bricon <notifications@github.com> wrote:
>
> Not sure I understand exactly what happens here but it seems src/main/java, src/main/resources and src/main/webapp seem to be treated equally, when in fact the 1st 2 should be mapped to WEB-INF/classes
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wildfly-swarm/wildfly-swarm/commit/5fd38de2330070a6fa0e8941fd101dbaa4c08933#commitcomment-11549770>.
>


GPLv2+ OK.


> If it is I suppose we could just temporarily switch to gnu++14 and bother the resident cocoapods contributors for a fix.

Since this is a global setting affecting the app as well as other pods, I'd think the correct solution would be:
* Remove CLANG_CXX_LANGUAGE_STANDARD from Realm's pod.
* If Realm's C++ headers use C++ 11 features and we strive to be user friendly, add something like this to the headers:

```
#if __cplusplus < 201103L
#error Realm requires C++ 11 features; please enable it
#endif
```

Alternatively or additionally, you may use clang's feature-checking macros:
http://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-macros

But really, the above should suffice, without enforcing one particular standard on the entire project.


why would you change it to this?
```python
if not testing or './testing' == os.curdir:
```
this part
```python
or './testing' == os.curdir
```
makes ZERO sense, because `os.curdir` is merely a shortcut for your operating systems way to specify your current dir, so lets say on linux `os.curdir == '.'` 100% of the time, you will never find an instance where `os.curdir`  is equal to anything but `'.'`, i appreicate you trying to help, but please look into this kind of stuff first


Thanks, I will do this tomorrow! Nice improvement!


OK, looks good.


OK.


@kbenne can you run through this commit and then run the sdd regression tests before delivering a package to CEC?


The public headers are pure obj-c with no C++ at all.


looks good


Ah that makes sense! Great if you to honor that.

On Friday, June 5, 2015, James Socol <notifications@github.com> wrote:

> Because 1.4 is a long-term-support (LTS) version, and 1.5 is not, and this
> change is from several months before 1.8 came out.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jsocol/django-waffle/commit/de83fb2174cfdbe691ebeb44eca4060c7d981080#commitcomment-11547748>
> .
>


PrevNonExist?


I didnt say you copied everything I said there is code straight out of my project. Also this does not follow the GPLs requirements but now we use a custom license.  Since you are banned from the org here is a link to our new one: http://redstonelamp.net/files/LICENSE.txt


@cs09g all your doing here is shifting lines around, im not sure how you can say "removing duplicated code" when your removing 4 lines and adding 5. i am not going to merge this.


Good gist to hide/show the FAB, but I noticed that you used withLayer() method which is available only from API 16 (JB).


if this is never changed, you could consider:

`final Map<String, Image> _images = {}`

which is a little nicer than creating it in the constructor.


Except it didn't seem to change behavior in my built App.  I did apply it, then rebooted.

in /etc/default/grub
now

GRUB_DISTRIBUTOR=`lsb_release -i -s 2> /dev/null || echo Debian`
GRUB_CMDLINE_LINUX_DEFAULT="consoleblank=0"
GRUB_CMDLINE_LINUX=""


`are` -> `could be` / `might be` / similar


select


The controllerState and controllerCommand are not mapped to the right content.


Looks OK.


So it's just needed to build the library? Isn't there a way to specify build settings which are only used while building the library?


I had a look at this ticket during the Django sprints. I wasn't sure about the old text "almost always used" and similarly I'm not sure about the use of "usually" in the new text.

From my tests, the field must be a foreign key or a many to many field. Does it make sense for it to be a many-to-many field? If not, maybe we should add a check to prevent it.


What changed here? I can't tell. Not sure why it had to be wrapped to 2 lines


@ikonst there's an open CocoaPods pull request to add that functionality right now


Not vulnerable to the same issue that was introduced (and fixed) on virt-test! Good! :+1:


Yeah ... :D Not ready for submission yet ;-) WIP


Compiler flags can be set for just the pod, but the language version set in CLANG_CXX_LANGUAGE_STANDARD trumps that, and that currently can't be set per-pod. https://github.com/CocoaPods/CocoaPods/pull/3573 is the PR @segiddins mentioned that'd make that possible.


CBECC (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Actually, there are a number of different important optimizations that can be made.
ASCII strings can be easily compared with UTF8 and Latin1, just by memcmp.
ASCII and Latin1 can also be compared via a widening operation with UTF16, UCS2, and UTF32.
(unfortunately, the vectorizing stuff in LLVM apparently cann't handle those sorts of loops with an early exit,
but that is something that I used to write special code with SSE or AVX to make just about as fast as memcmp).
UCS2 also can be compared via widening to UTF32.  For UCS2 and UTF16, at least equality would work, but < and > wouldn't.
Similar optimizations can be done for conversions also (one of us would need to extend check_string... now I'm thinking it needs a first argument, your encoding type, which I love!


`_safeInstanceOf` is attached statically to `Base`:
https://github.com/rackerlabs/barricade/blob/master/src/base.js#L119

Therefore, you should be able to get rid of `callee` and just use `this`.


Sorry, I really don't like to keep things broken. So I've pushed the fix directly.


great code, well done chap


This isn't exactly what we mean here - we only want to register for push if we have a people record, or we'll create one.


It does work, I've tested it manually in another playbook. It was impractical to get a set of testing credentials for Atlas to use in the TestKitchen tests which is why they only ensure that the config gets applied correctly.


Be sure to check push notification behavior (maybe write a test to determine when we do and don't register for push?)


If you move the assignment to where `clsRef` is declared, you could then do `if (!clsRef)`


No spaces around the conditional expression! `if (expression) {`


I am running the tests now and will merge it.


> Compiler flags can be set for just the pod
How? (curious)

> but the language version set in CLANG_CXX_LANGUAGE_STANDARD trumps that

We set `CLANG_CXX_LANGUAGE_STANDARD' => 'compiler-default'` in the code above. If it indeed trumps the flags, then setting the flags (also in the code above) wouldn't make sense.


the important modif..


Nicely organized.


Great thoughts @ScottPJones. I've added you both as collaborators here, so feel free to push and pull at will. I'm really just throwing some ideas around at this point and wanted to do a quick sanity test. The initial performance benchmarks are good with concatenation being 3x faster, but I haven't figured out a good way to compare substring-ing. I'm thinking that there may be a small subset of functionality here that might be even great to integrate quickly with SQLite and ODBC since I deal so much with 3rd party library strings and whatnot; it's incredibly efficient to be able to cheaply build strings from pointers and lengths rather than having to make copies (from the recent mailing list about the facebook kaggle competition data, SQLite can load the CSV in about 20 seconds where our own `readcsv` and even R solutions were taking minutes/hours.


closes #121


Would it be possible to split out the encoding type, as a *real* small PR, that might get put in Base, that hopefully TPTB could approve really quickly?  The whole change will take some time, and should be in a package, for now at least (much easier to debug and update) [but I'd love to see this sort of stuff as part of Base...], but the simple addition of a nice type system to indicate encoding, separating it from the storage, would be good to have for lots of things to build upon.


Typo here. Should be `trusty`


This line should not have been part of this commit. @adrienlauer do you think this line should be revert ?


The logging situation in Node continues to be a source of endless sadness :(


Nice! I'll have another chance to work on more code tonight, so I can start using this.


def occupation_HHI_dict (dictionary, tract_number, categories_list):
‘’’ Given a data dictionary, a tract_number and a list of occupation categories, return a dictionary mapping the occupation_HHI to each census tract’’’


ok


@tomdale I think from all the recent conversation about this topic, this has been the way to mostly everyone agrees too. 1.13 lands with the new pass-around action syntax, I think it'll be easier to do some of these things.

I would love to see `targetObject` and `target` normalized...


You mean the default format...


the resp.Node.Dir must be true, right?


* RPMs built OK.
* Docs built OK.
* Successful mix of avocado and virt tests:

```
$ ./scripts/avocado run sleeptest type_specific.io-github-autotest-qemu.migrate.default.tcp
JOB ID     : e08e5502694a51024e5c295782c06ca5fdc34bf5
JOB LOG    : /home/cleber/avocado/job-results/job-2015-06-05T19.13-e08e550/job.log
JOB HTML   : /home/cleber/avocado/job-results/job-2015-06-05T19.13-e08e550/html/results.html
TESTS      : 2
(1/2) sleeptest.py: PASS (1.00 s)
(2/2) type_specific.io-github-autotest-qemu.migrate.default.tcp: PASS (94.89 s)
PASS       : 2
ERROR      : 0
FAIL       : 0
SKIP       : 0
WARN       : 0
INTERRUPT  : 0
TIME       : 95.89 s
```

Haven't hit any usability issue. This is some fine work. Well done.


That seems to do the job!  I originally put in the --gnu switch when I first encountered the bug but there seems to be an issue with parallel v. 20141022. I dropped it and went with 20130922 and all works fine. Might be worth testing it using the more recent version 20141022.


Thanks!


# -*- coding: utf-8 -*-
from selenium import webdriver
import unittest

links_landing_titles = {
    " Contact" : "Contact"

    }

class SauceLabsHeaders(unittest.TestCase):
    def setUp(self):
        self.driver = webdriver.Firefox()
        self.driver.implicitly_wait(30)
        self.base_url = "https://www.deanza.edu/"
        self.verificationErrors = []

    def test_sauce_labs_headers(self):
        driver = self.driver

        for link in links_landing_titles:
            driver.get(self.base_url)
            driver.find_element_by_link_text(link).click()
            expected_title = links_landing_titles[link]
            try: self.assertRegexpMatches(driver.title, expected_title)
            except AssertionError as e: self.verificationErrors.append(str(e))

    def tearDown(self):
        self.driver.quit()
        self.assertEqual([], self.verificationErrors)

if __name__ == "__main__":
    unittest.main()


Thanks for many stubs! By the way, please make sure that your files have newline at the ends of files.


Finally this modification is fine according to the comments on seedstack/distribution#2.


the clipping bitmap is smart solution!


Sure. Because I also want python notified.
Joergen wanted it in the toolbar, but you're right, performance sucks.
I commit a more humble feature now.


This change breaks makeRequiredPRFFiles.py, which is still passing in alpha.


rax retry tests


LGTM.


Why not:

```
if self.tdl.arch in ["aarch64", "armv7l"]:
   mods = { 'arch': self.tdl.arch, 'machine': 'virt' }
```
?


If we really want a progress bar, i think it should reside in the status bar.
There is also the option to only show an is-finished element, optionally with more information in a tooltip.
And you can also notify python, but currently it’s loader→python→mainwindow where it should be 2 connections instead.


Hi,
::TEXT breaks in Redshift with type regproc and error "Invalid operation: cannot cast type regproc to character varying", the full query is:

SELECT a.typname, a.oid,
CASE WHEN a.typreceive::TEXT='array_recv' THEN 'a' ELSE a.typtype END AS type,
CASE WHEN a.typreceive::TEXT='array_recv' THEN a.typelem ELSE 0 END AS elemoid,
CASE WHEN a.typreceive::TEXT='array_recv' OR a.typtype='r' THEN 1 ELSE 0 END AS ord
FROM pg_type AS a LEFT OUTER JOIN pg_type AS b ON (b.oid = a.typelem)
WHERE a.typtype IN ('b', 'r', 'e') AND (b.typtype IS NULL OR b.typtype IN ('b', 'r', 'e'))ORDER BY ord

Should I submit an issue?


Not sure how GIT got it wrong, not Diego but Fang changed myuw_mobile/data/category_links_import.csv.


Well, this one was not mandatory, it compiled fine without it, but explicitly defining it is probably better.


Hi Vidal,

I'm glad my code was of some help to you. Thanks a lot for taking the time
to leave me a message.

Avoiding AWT classes for the basic decoding makes sense not only for Google
App Engine, but also for Android, where most parts of the AWT are not
available either. So your feedback is highly appreciated.

I had a quick look at your code and reimplemented mine in a similar way.
However, I noticed that the problem of using System.arrayCopy instead of
Graphics2D.drawImage is that you overwrite the previous frame or background
completely. That's okay for non transparent images, but for GIFs with
transparency a call of GifDecoder.getFrame(1) might only return the non
transparent pixels of the second frame with no visible background.

Basically the whole logic of alpha compositing is missing. In case
Graphics2D.drawImage is hardware accelerated, reimplementing that logic in
software would probably cost a decent amount of performance.

Are you using some alternative GAE classes to do the drawing afterwards? Or
have you just not come across the issue with transparent images yet?

I'd be happy to hear from you again.

A solution for GAE and Android would be great, I'd like to provide
different branches of my decoder then.

Best regards,
Dhyan
Am 04.06.2015 23:05 schrieb "Vidar Wahlberg" <notifications@github.com>:

> Hi there. Sorry about leaving a comment that's not really about this
> commit, but about the class in general. I couldn't find an easy way to
> contact you, so I hope this message reaches you.
> I needed a GIF decoder for an application that is to run on Google App
> Engine. While Java supplies ImageIO in the JDK that class (and some others)
> are not whitelisted for use in GAE. Then I came across this project that
> nearly solved my problem. There are some classes in your GifDecoder that
> too are blacklisted at GAE, but I managed to rewrite the code so those
> classes (Graphics2D, BufferedImage and DataBufferInt) are no longer needed.
> Maybe this is not making much sense to you, but I just wanted to let you
> know that I've modified your code a bit, and if it's of any interest to you
> then you can find it here:
> https://github.com/canidae/FlyWithMe/blob/4.0/android/server/src/main/java/net/exent/flywithme/server/utils/gif/GifDecoder.java
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DhyanB/Open-Imaging/commit/39d80ccbba8239c4f70d18edaeed1a3e38a3b786#commitcomment-11530087>
> .
>


should fix #2


As I said, I'm soon committing something else, since you'd also comment there, let's wait till then.
I can also notify python, but as long as Loader::Worker is not exposed to python, that would entail emitting two different signals instead of one, I'm not sure it's better.


fixed


PullLogicFromPlantComponents (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Great! Yes this also works with at least Kwikset and Schlage locks


wait, where'd this come from?


:+1: great!


This statement is about identifying the user not the location.  However we should note this possibility.


how can `loopIndex` and `datasetIndex` ever be different?


My local pep8 says:
myuw_mobile/dao/card_display_dates.py:162:19: E127 continuation line over-indented for visual indent.


AtomicReferenceArray?


This seems very problematic that we are no relying on including other files and the src. Factories shouldn't need the library


This commit will need to remove the import-rados testing from test/ceph_objectstore_tool.py.  Or better yet replace it with rados import, since you'll have pg exports created during this test.


This still does not handle the case where a Redis server instance is listening on a specific interface (e.g. not `0.0.0.0` or `127.0.0.1`)


any reason not to use `jams.util.import_lab` here?  I thought all the isophonics data was in .lab format.  If the builtin JAMS parser doesn't work, we should fix it.


i think this results in a cleaner and more JS-y API than something like bookshelf, which has you wrap stuff in extra functions so they can bind the relation methods to it


also, magic strings suck ass


this is brilliant


No, I want to do that. For now, I simply removed mir_eval. In the next step, I will use that function.


not really. see usage.


Wait, what does this part mean? And is this too abstract ( "environment" ) for beginners?


Should fix #3


Nevermind, doesn't crash (except when maximized), but nothing is shown because it throws a resources.cfg not found exception. At least theres that.


Yeah I agree, downcasts in user code is worse than generics in our code...  (why identity is saddled with all those generics :/)


Image of Ubuntu 14 with OpenJDK 6:

![visicut-ubuntu14-openjdk6-1024-full](https://cloud.githubusercontent.com/assets/8248300/8016511/8509ef1e-0be4-11e5-92e5-720561240b8e.png)


cool commit bro


spacing issue was causing the istanbul command to just not run


i will destroy you!


Thanks, I'll reintroduce it.


Yeah I'll remove the superfluous comment above the `partialChain` instantiation.


Good shit!


forgot to remove variable placed for tripping the linter


`AtomicReferenceArray` does not guard against false sharing. This approach isn't perfect, but is simple, portable, and reduces the severity. Its very easy to observe the difference by running both through a benchmark.

It wouldn't hurt to pad manually, but last time I tried the difference was negligible. A benchmark to assert that is probably worth adding, though.


What was the point of this. I dont think getWindowSize() works. Why cant you use the the JUCE functions?


Yeah

> On Jun 4, 2015, at 10:58 PM, Andy Goldstein <notifications@github.com> wrote:
>
> @smarterclayton do these conversions for ISImage and ISTag between v1beta3 and internal look correct, now that I've de-embedded Image?
>
> —
> Reply to this email directly or view it on GitHub.
>


I think that would be too harsh since it's quite possible that a sample covariance is very badly conditioned.  Perhaps a better approach would be to not try the factorising at this stage, and just **always** do the regularisation.  In any case, this might be worth opening a separate ticket for.  I won't let it hold up this PR, though.


@nigel-sampson, temporary I've end up with custom Caliburn build from Windows 10 branch and it works just fine as expected, thanks! Seems like for the future it would be nice to have some extension points (in binding scope class, as your snipped) to add similar binding support to other (future) controls easily from the main project side without Caliburn's own code modification.


A wip implementation of startPtpd to ensure ptpd is running during performance tests


CBECC (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This code introduced this bug:

https://voat.co/v/ideasforvoat/comments/112603


Shouldn't one of these be `.next()`? Having it be finish and done is confusing.


``` Dill emphasizes relying on DOM attributes, rather than text, as attributes tend to be more stable.```

Maybe this could go into a section like 'philosophies' right under the overview section. I feel like there are a number of items that might go under this section.


Looks like an oversight, as examples use next and done below.


Done


This overview should explain the advantages dill gives over using capybara.


I confess I don't follow: what do you mean by "false sharing," how exactly
does the array of AtomicReferences behave differently (I believed that to
be strictly superior?), and what are you referring to by "reduces the
severity"?

On Fri, Jun 5, 2015 at 3:43 PM Ben Manes <notifications@github.com> wrote:

> AtomicReferenceArray does not guard against false sharing. This approach
> isn't perfect, but is simple, portable, and reduces the severity. Its very
> easy to observe the difference by running both through a benchmark.
>
> It wouldn't hurt to pad manually, but last time I tried the difference was
> negligible. A benchmark to assert that is probably worth adding, though.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ben-manes/guava/commit/0f286172945f7f23d1c2b8f297f9816e918c6bc3#commitcomment-11550575>
> .
>


This one is interesting because it's basically acting like a listener. Reminds me of Rack, where you create 'middleware' that is actually just checking path info to serve up a response, as opposed to messing with the request/response.


One thought I had on pre-reply is that the language _might_ suggest it's only for like `response.reply`, but it's really for any outgoing message from the bot.


Este tipo de descripción de lo que hace el programa debería ir más bien en el README y tambien incluir como se corre el programa...


No es necesario el sleep.... el chiste es que imprima todo.


Thanks! (And no need.)


need fixed space in regexp


ok


> As a user, if I use string state names in my app, I'm going to use them consistently, both in transitionTo() calls, hooks, and elsewhere.

That's not relevant to the point I'm making.  My argument is that I'd like somebody to be able to respond to some stackoverflow question with a $transition$ recipe like the redirect I pasted above.   They shouldn't know nor care if the asking user prefers strings or object refs.  In those situations, I would then have to point people to the internal `$to()` over the public `to()`.  Additionally, things like ui-sref always use state object, so "string reference" users (the majority) will end up having to check anyway to cover those cases.

Like I mentioned before, I think StateParams is a *good* abstraction and I don't see why we shouldn't expose it, or at least expose the instances of it as part of the api.

I'd also like StateReference to provide the normalized state name (something like `name: function() { return definition ? definition.name : identifier; }`).  Have the consumers explicitly choose what they want when using $transition$.

Interested in hearing your further thoughts.


ok, solo era para parte visual. je


Como harías para validar que el programa funciona, sin tener que entrar y abrir la página para comparar que es lo que esperas "manualmente"?

Lo primero creo que sería hacer una función que encapsule el comportamiento y despues hacer validaciones ... no se si en php existe algo como assert, pero sería un buen comienzo....

Ahora si usas algún framework de pruebas sería bueno tambien, pero desconozco cuales existan.


I don't see how this is related to the bug described. Nothing in messaging controller was changed that can be related to the bug. Which line?


hw_file1 file name changed to modified


Sorry to keep nitpicking this PR, but I think this function should take an error that should be filled in below with the specific errors. You can always prefix it in the caller if you want. See for example, https://github.com/endlessm/ostree/blob/endless-upstream-rebase/src/libostree/ostree-repo-static-delta-processing.c#L113.


Perhaps, or we could keep it and use it when we implement algorithms that use second order information.


I wonder why `scope` would have worked the same as `$scope`. Isn't it DI'ed ?


Perhaps, but I don't think that should be done in this pull request.


Is it needed in this file?


No, if it is zero then no output is written.  I'll clarify that.


Do not use all-uppercase letters for normal variables


Well, there are two issues but this is the main one. Post replies don't have a comment id, this code changed the query logic which now doesn't pull mentions generated by submissions as they have no valid commentID.


It would be nice to get the 3rd arg set based on a --no-overwrite option.  This could be implemented later.


We set it up so it works, we passed the window size into the camera on resize. It is for matts gimbal3D, because he has a pointer to the camera as a member variable. In the future, I'm hoping we can get the camera out of gimbal3D.


SRGS komponenta teď generuje přímo kód s inline gramatikou, žádný grxml soubor se nevytváří. Takže outputFile už není potřeba.


rozwiązane dodając odpowiedni constraint w schemacie


Actually, this might be the only bug.


Indentation should be 4 spaces.


I had to change the previous commits with the path /data/something  because the basespace file system which overrides the union mount system has the same hierarchy, and overwrites this.  So this needed change.  The example.R line 17 is the most significant change that was needed.  This allows for user specified input WITHIN an R script to be customized, and then called in parellel.


Yup, this is the submit that is causing that bug, unfortunately, 100% of it.


@rrnewton Any ideas about this?


Please use `kubectl stop -f`. That kills the pods as well.
`delete` only removes the replication controller.


Yeah, it is. I kind of like `finish` and `next` but I was trying to be consistent with #803 (`done` and `next`)` and failed. `finish` has consistency with `Response`, my opinion is pretty strong about that one vs `done`.


I see, so the mentions are generated and stored, just not rendered. Good catch.


thanks ma man


Yeah, it's a weird case, but it only short-circuits if it's a `verify`, so it's not a true endpoint.

Passing a message off to be re-received is weird too but worked really well against my hooks branch.


False sharing is a cache coherency performance degradation due to cache lines being invalidated by modifications to independent variables. Padding attempts to isolate the hot variables into their own cache line so that the effects are write contention not exacerbated.

Assuming a 32-bit JVM with 64-byte cache lines, each reference is 4 bytes. An AtomicReferenceArray would allow 16 elements in the line. Due to object padding, an AtomicReference takes 16 bytes meaning that only 4 are in the line. That is a 4x difference in the likelihood of false sharing.

Explicit padding to further reduce false sharing may be more beneficial for Guava than CLHM/Caffeine. In those libraries the ring buffers are striped by the number of CPUs, which reduces the probability of contention. Guava's per segment assignment isn't as tolerant, so manually padding may have an impact. However, such a low-level optimization is atypical for the Guava team to consider so I'd suspect it wouldn't be adopted.

Of course the benchmark is easy enough to write so that the issue can be decided based on data.


This just removed the first occurrence of '\n' and replaces it with NULL.
This will truncate the string if '\n' is not the last character - is this the intended behaviour?


LOL


@nicklockwood Thanks for clearing these out. Adding support for a new prop looks much simpler now.


Does this fix a compiler failure in the last commit?


Yeah that was a tricky find but what's funny is we have a lot of submission mentions that were never delivered... but no one's the wiser. ;) Phantom mentions.


Got yesterday my RPi2.
It took no 2 hours until a kernel oops arrived with this 3.19 kernel config. It happens during watching a 720p mkv video.


>Most high performance processors, such as UltraSPARC processors, insert a cache buffer between slow memory and the high speed registers of the CPU. Accessing a memory location causes a slice of actual memory (a cache line) containing the memory location requested to be copied into the cache. Subsequent references to the same memory location or those around it can probably be satisfied out of the cache until the system determines it is necessary to maintain the coherency between cache and memory.

>However, simultaneous updates of individual elements in the same cache line coming from different processors invalidates entire cache lines, even though these updates are logically independent of each other. Each update of an individual element of a cache line marks the line as invalid. Other processors accessing a different element in the same line see the line marked as invalid. They are forced to fetch a more recent copy of the line from memory or elsewhere, even though the element accessed has not been modified. This is because cache coherency is maintained on a cache-line basis, and not for individual elements. As a result there will be an increase in interconnect traffic and overhead. Also, while the cache-line update is in progress, access to the elements in the line is inhibited.

>This situation is called false sharing. If this occurs frequently, performance and scalability of an OpenMP application will suffer significantly.

>False sharing degrades performance when all of the following conditions occur.

>Shared data is modified by multiple processors.

>Multiple processors update data within the same cache line.

>This updating occurs very frequently (for example, in a tight loop).

>Note that shared data that is read-only in a loop does not lead to false sharing.

http://docs.oracle.com/cd/E19205-01/819-5270/aewcy/index.html


Do any of the other tests break by adding this to all test commits?


You're right, I fixed it here: https://github.com/sephii/django/commit/94150f3371beaca5760732abffa3085ffa5d64b5

@claudep any input on this? Should I create a new pull request for the fix?


This is where i am having issues


@ldlsegovia No revisé bien esto antes de mezclar pero en modo de desarrollo yo quisiera que rails se comporte como normalmente lo haría (o sea, que se lance una excepción) porque hay gemas de soporte que funcionan a un nivel más bajo de rack que capturan errores y hacen algo con ellos, como `pry-rescue`, `better-errors`, `web-console`, entre otras, que manejan errores inesperados en modo de desarrollo mucho mejor de lo que un log y una respuesta puede lograr. ¿Qué opinas de simplemente dejarlo explotar? Dado que lo más importante del error (el backtrace) de todos modos va en el log, no estoy muy seguro de la utilidad de esto (sobre todo si implica perder la oportunidad de que otras herramientas de debug funcionen correctamente).


testing


I am having issues here


The test works in my machine, I think it's because the test run on travis CI is headless, but I thinkk you are right, the swing should be manipulated on the EDT, I don't think if it will affect the result in this case.


please write using inlineCallbacks, it will be much easier to maintain

```
@defer.inlineCallbacks
def test_expose_property_from_step(self):
        # this step tests both the property being exposed and
        # also the postMetrics method
        fake_storage_service = fakemetrics.FakeMetricsStorageService()
        step = fakemetrics.FakeBuildStep()
        self.setupStep(step)

        self.master.config.metricsServices = [fake_storage_service]
        self.master.metrics_service.reconfigServiceWithBuildbotConfig(self.master.config)

       yield self.runStep()

        self.master.metrics_service.postProperties(self.properties, "TestBuilder")

        self.assertEqual([
            ("test", "value", {"builder_name": "TestBuilder"})
        ], fake_db_service.stored_data)
 ```


for example, since you are not using inlinecallback, this call is actually run BEFORE runStep() is executed


see how it is complicate to add a method that will be executed after runStep()

using inlinecallbacks make the code more natural, "hidding" the deferred mecanical in a more logical code flow


Yeah, they'd been bugging me for a while. They haven't been needed since long before we open sourced, but old habits die hard :-)


Thanks for the fix.


Thanks this is helpful for me, I am still a bit of a newbie here with this stuff! Everytime I learn something it changes!


Just remove it instead of commenting it out


Something to fix for PC version, compilation error .


startBuild probably returns a deferred, so here you don't propagate it to the reactor main loop. To do so, you should return this deferred + all addCallbacks to this methods.

Again => inlineCallbacks.
```
    @defer.inlineCallbacks
    def test_postProperties(self):
        # test whether the properties set by steps are
        # going through
        b = self.build
        step = fakemetrics.FakeBuildStep()
        props = {}
        def metrics_postProperties(properties, b):
            props.update(properties)

        self.master.metrics_service.postProperties = metrics_postProperties

        b.setStepFactories([FakeStepFactory(step)])
        yield b.startBuild(FakeBuildStatus(), None, self.slavebuilder)

        # now we check whether "test" was sent
        self.assertEqual(props.get("test"), (10, "test"))
```

Same code without inlineCallbacks:

```
    def test_postProperties(self):
        # test whether the properties set by steps are
        # going through
        b = self.build
        step = fakemetrics.FakeBuildStep()
        props = {}
        def metrics_postProperties(properties, b):
            props.update(properties)

        self.master.metrics_service.postProperties = metrics_postProperties

        b.setStepFactories([FakeStepFactory(step)])
        d = b.startBuild(FakeBuildStatus(), None, self.slavebuilder)

        # decorator to add a callback after the execution of the deferred method.
        @d.addCallbacks()
        def check(res):
          # now we check whether "test" was sent
          self.assertEqual(props.get("test"), (10, "test"))

       return d
  ```

Theory: http://en.wikipedia.org/wiki/Futures_and_promises
Other doc: http://twistedmatrix.com/documents/10.2.0/api/twisted.internet.defer.inlineCallbacks.html
Excelent overview: http://jaredgrubb.blogspot.fr/2013/03/twisted-recipes-for-deferinlinecallbacks.html


Any changes in games? :)


Yes, this is always a kernel function name so it shouldn't have and newline characters in it until the end.
--
Tayler Hetherington
Sent from my N5
On 5 Jun 2015 4:16 pm, tgrogers <notifications@github.com> wrote:This just removed the first occurrence of '\n' and replaces it with NULL.
This will truncate the string if '\n' is not the last character - is this the intended behaviour?

—Reply to this email directly or view it on GitHub.


Why did you move this? i think it should stay on the method as before


Yes, I accidentally submitted the previous commit without compiling yet (copy paste error from my validated changes in the master branch).
--
Tayler Hetherington
Sent from my N5
On 5 Jun 2015 4:17 pm, tgrogers <notifications@github.com> wrote:Does this fix a compiler failure in the last commit?

—Reply to this email directly or view it on GitHub.


testing comments


En efecte, mai me n'havien fet cap de tant bona


This whole section should be removed since the web ui is now built into the api server. Simply needs to say access the web ui at `http://localhost:8080/ui/`


Can you add some comments here to say what is happening?


Don't hard code the text, can you use message codes to support translation?


Same here, translate this


I think this section should be at the very top. Many people will wind up here simply looking for how to access the web ui. The header should also be something like "Accessing the web ui". Noting that the rest of the readme is geared towards development of the ui would be good too.


Same for this jsp, translate the text


Looks good in general, just added a few comments


You don't have to use {} when passing hash as controller. You can do MoneyHistory.create(money_before: money_before, user: ...)


This PR makes the package *uninstallable* via composer until illuminate/routing 5.1 has been tagged.  At this time (05JUN15), it has not.

```
Your requirements could not be resolved to an installable set of packages.

Problem 1
    - Installation request for dingo/api 0.9.*@dev -> satisfiable by dingo/api[0.9.x-dev].
    - dingo/api 0.9.x-dev requires illuminate/routing 5.1.* -> no matching package found.
```


rax retry tests


Not sure, haven't found any yet, but there will be one obscure game that has always had issues which is suddenly fixed :p


Shadow Man 2 looks far more glitchy these days. Cannot say if it was this or another recent commit though.
https://i.imgur.com/Swzs8Qd.png


My firts commit


no need for the ! that was removed in an earlier PR by Duke


Use DirectX instead of OpenGL ;)


This should be `java7-runtime-headless` here, `java-runtime-headless` doesn't exist and no JDK package provides it. This means the package produced doesn't work with the openjdk-8-jre package.


Yea, was gonna say "false alert" but you were quicker :p


Typo: The "inventor" not "invertor"


So this game triggers a genuine GSdx OGl bug. Might keep a note of that :p


I like.
Thanks.
★★★★★


:+1:
But you create in thic commit service and specs. Not only specs ;)


dmginfo ~= damageinfo


Thanks :)


Looks like the game uses bilinear filtering, but OpenGL I don't think actually does it on many games at the moment, Baldurs gate has a distinct lack of texture filtering as well (look at the muddy road when you talk to the caravaneer at the beginning)


"You deftly land on the %s, striking a pose!" ;)


That didn't work, the event is not triggered, not sure why.


пробовал создавать полигон через создание полилинии - пытался привести полилинию к полигону через dynamic_cast, не получилось. Поэтому вернулся к такому созданию.


да, сначала конструктор был первым, в процессе переместился :)


Fluentd's forward protocol (it uses 24224 as default port) does data transferring only over TCP.


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 52](https://teamcity.labkey.org/viewLog.html?buildId=253664&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 2 (1 new), passed: 24 Build time: 00:31:08
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


This commit is causing this error.

>Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter provider on >Openldap_database[dc=my-domain,dc=com] at >/etc/puppet/environments/ist/modules/openldap/manifests/server/database.pp:47


Hi there.
Wondering why there are two "iniWatch" functions? Did you forget to remove the one in the default task method?


Is it worth keeping code.google.com/p/go.tools/...?


All suggested changes have been implemented.


Поправить то смогу, но это поломает подсчет точек... изначально был XList< Point >, но я не смог разобраться почему в таком случае не увеличивается счетчик точек. А вот если создавать лист указателей, то подсчет точек происходит адекватно.


> If it looks wrong, it's spelled wrong.

:clap:
Though I like jsDOM.  :laughing:


вы неправильно пытались потому что :)
dynamic_cast -- не вариант


> но я не смог разобраться почему в таком случае не увеличивается счетчик точек

потому что у вас нет конструктора копий у Shape-а (с инкрементом sm_сounter), вы попались в ловушку, и не смогли найти из неё правильный выход


@pankajagarwal I'm not sure the problem comes from this particular line but more from the fact that either slapdcat and/or ldapmodify is not available, and thus the old provider for openldap_database is not enable.
Could you please add `include ::openldap::client::utils` in your manifest to test?


**English:** when you does a rebase the references to `@dimen/activity_vertical_margin` and `@dimen/activity_horizontal_margin` be lost. This folder was sent to the repository?

**Portuguese:** ao fazer o *rebase* perder-se as referências para `@dimen/activity_vertical_margin` e `@dimen/activity_horizontal_margin`. Essa pasta foi enviada para o repositório?


если вы про "m_center.~Point();", то это так уничтожаются точка центра окружности. Другого метода не нашёл. Опять же, если вообще не вызывать деструктор точки, то она остается в памяти и входит в общее число точек.


it's actually not required as you have somethis for this in .. "manifests/server/slapdconf.pp"

  openldap::server::database { 'dc=my-domain,dc=com':
    ensure => absent,
  }


can we leave this in?  We might bring it back


group have not total_price~


may crash if new hero (hero1/hero2 not defined)


AWS has a partner that does self-paced labs. Some of the sessions are free, most you have to pay for: https://qwiklab.com

I see Udemy has a course: https://www.udemy.com/amazon-web-services-for-web-hosting-cloud-computing/

But probably the most valuable thing I've done thus far is just start using the services and troubleshooting when I get stuck.


need this


need~


из-за того, что лист содержит указатели, передается указатель на точку. По честному сначала хотел передавать Point const & point, но не получилось взять указатель на эту точку, чтобы вставить в лист.


I think that we shouldn't do early return here. Formatting tag string from with template is not most important for this method, but just one of some process.


got it


fixed.


You are so right bro, keep up the great work :point_right: :o:


я так задание понял, на добавление исключительных ситуаций... "взятие первого элемента из пустого списка"


got it.


done


@pankajagarwal well this is weird, I have acceptance tests running fine on Centos7 : https://travis-ci.org/camptocamp/puppet-openldap/jobs/64529939


same error after using the include ...
Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid parameter provider on Openldap_database[dc=my-domain,dc=com] at /etc/puppet/environments/ist/modules/openldap/manifests/server/database.pp:47 on node


self isn't necessary for either of these cases


да, согласен, надо было через T & GetFirst()


I believe this method is no longer used


@mcanevet I'll get you the details during the weekend.


That change will only ship with 2.1 though, so we should wait until then before adding it back.


да я привык к такому стилю, вроде как лучше видно.


#CodeFury

![van damme fury](https://cloud.githubusercontent.com/assets/163977/7998942/b51b85b0-0b11-11e5-90d1-194f188e463d.jpg)


In my case the IPN script from the Paybox module of magavenue calls validateOrder() as it should, but module_name is empty. I didn't investigated why, and if it has to expected/tolerated.
Still, I think that checking _payment_method_ in order to grab consistently the _ChoixPaiement_ isn't a bad choice.


а там сначала реализация другая была, потом она была заменена на Clear, а потом clear закомментировал из-за вывода полигона - этот clear ломал вывод точек, принадлежащих полигону.


update issue #25


у Visual Studio 2013 не нормальный компилятор :)


+1
Cool fix ! Thx !


учту


Might want to look at your governors again bro.


да, должен признать, ловушек в вашем задании предостаточно :) над многими моментами пришлось попыхтеть. Ну а так как опыта немного, то и правильный выход не смог найти.


How could I use `Editor.require('app://engine-framework/src/index');` if editor removed?


Yeah, the actual skip is missing. I'll add it once I rebased the other PR onto this.


please read the last section about editor init in page-init.js


Thanks Dan Its Fixed!


This is for elastic/infra#215.  Produces stuff like https://packages.elasticsearch.org/infra/elasticsearch-1.6-201506041c252f5.tar.gz.


Basically cause Editor.require defined during editor-init.js, so I can not use Editor.require( '...editor-init.js' ) before editor init. I have to get the script I want to make sure editor-init.js can be require properly.


CC: @muckachina

hopefully this will fix/mitigate that "Report mystery: files not going to the Transfer list on desktop"


OK, now that I am testing building this on a live system rather than with ebuild and having removed `sage-baselayout` there are some issues at build time. I won't be able to touch them before  5hours from now. I am blocked in `sage/interfaces/maxima.py` building the html documentation (sage itself build fine). A quick and dirty work around is probably to define `SAGE_LOCAL` to `${S}` just before the call to python building the doc.


aaaaaaaaaa


Fix issue#6


The hardware scaling done in the gl-branch is still not perfect though. Yes, it is able to scale to any screen resolution, but it does linear filtering between horizontal (and vertical) pixels, unlike the software scaling that does filter only between pixels vertically, so the end result in the gl-branch is a much more blurry screen. At 1920x1080, I could see that it was blurry between pixels, so you should add more filtering options.

An option to do nearest-neighbor scaling would be good enough at 1920x1080. It's not too bad. (DosBox does it and it looks good at this resolution). At least, it looks better to me that the current hardware scaling done in the gl-branch.
Another option to do linear scaling, only vertically like the current software scaler does would be mandatory.

Sorry if I sound too critical about the GL renderer, I know it's not there yet and that there's still a lot of work to be done before it becomes perfect.


You'll need to remove line 19 (use Slim::Web::ImageProxy), and add "require Slim::Web::ImageProxy inside this "if CAN_IMAGEPROXY" statement. Otherwise older LMS versions won't load the plugin as they can't find the module.


Ah, sorry I didn't realize this was on `master`.


this block could be written in so many different ways... I've chose the block that most similar to optimist syntax...

the previous code renders as follows
![screen shot 2015-06-05 at 5 44 39 am](https://cloud.githubusercontent.com/assets/347712/7999063/5d6ad5cc-0b4e-11e5-9bd9-f3572a335203.png)

while the following equivalent code will renders it as follows
```
    .option('port', {
      alias: 'p',
      describe: 'internal http server port',
      required: true
    })
```
![screen shot 2015-06-05 at 5 46 08 am](https://cloud.githubusercontent.com/assets/347712/7999092/941acf14-0b4e-11e5-9f60-9dc160b69b27.png)
notice how the --port came first...

and if I added the required true to the previous code instead of chaining it after the option... the error will be
`Missing required arguments: p` instead of `Missing required arguments: port` which might be a little bit confusing

so basically this code is written this way because it's how I thought it looks best when called from terminal :smile:


With this rails gem I can use a generator to create an improved boilerplate layout compatible with the front end framework of my choice.


Yo -- I now get a compile error here:
```c++
    NTDeleteUniqueOperation(const T& past, std::unique_ptr<T>& current){
c:\cplusplus\juce\modules\juce_icarus\utils\NTJuceUtils.h(34): error C2061: syntax error: identifier 'unique_ptr'
```


adding <memory> include maybe?>


嗯，有卵用


Yes, this is good.


관계 없는 커밋이 섞여있네요. 제거하는 것이 좋겠습니다.


I noticed PASSWORD_DEFAULT and PASSWORD_BCRYPT return different values for the same input. Seeing how PASSWORD_DEFAULT will evolve over time, and may not be bcrypt in the future (maybe scrypt will take over), perhaps we should use PASSWORD_BCRYPT with the bcrypt name and add in PASSWORD_DEFAULT under another name?


gfd


> On May 29, 2015, at 10:10 PM, Amneet Bhalla <notifications@github.com> wrote:
>
> IBAMR is getting built with libmesh@github (after a minor change to configure_libmesh.m4), but examples need to be updated. Could you try it out, ex0 maybe?
>
> Minor changes with libMesh to make it work with PETSc@bitbucket
>
Please try pulling libMesh --- there are commits from June 2 adding support for PETSc "3.6".
> diff --git a/src/base/libmesh.C b/src/base/libmesh.C
> index cd39cd4..62b5f72 100644
> --- a/src/base/libmesh.C
> +++ b/src/base/libmesh.C
> @@ -320,7 +320,9 @@ void libmesh_terminate_handler()
> MPI_Initialized (&mpi_initialized);
>
> if (mpi_initialized)
>
> MPI_Abort(libMesh::GLOBAL_COMM_WORLD, 1);
> {
> //MPI_Abort(libMesh::GLOBAL_COMM_WORLD, 1);
> }
> else
> #endif
> // The system terminate_handler may do useful things like printing
> diff --git a/src/numerics/petsc_matrix.C b/src/numerics/petsc_matrix.C
> index d87de09..d38879f 100644
> --- a/src/numerics/petsc_matrix.C
> +++ b/src/numerics/petsc_matrix.C
> @@ -32,7 +32,7 @@
>
> #if !PETSC_VERSION_LESS_THAN(3,5,0)
> #include "libmesh/ignore_warnings.h"
> -#include "petsc-private/matimpl.h"
> +#include "petsc/private/matimpl.h"
> #include "libmesh/restore_warnings.h"
> #endif
>
> diff --git a/src/solvers/petscdmlibmesh.C b/src/solvers/petscdmlibmesh.C
> index 25a4808..ca56ce3 100644
> --- a/src/solvers/petscdmlibmesh.C
> +++ b/src/solvers/petscdmlibmesh.C
> @@ -2,7 +2,7 @@
> // This only works with petsc-3.3 and above.
> #if !PETSC_VERSION_LESS_THAN(3,3,0)
>
> -#include
> +#include
> #include "libmesh/petscdmlibmesh.h"
>
> #undef FUNCT
> diff --git a/src/solvers/petscdmlibmeshimpl.C b/src/solvers/petscdmlibmeshimpl.C
> index b4bc4cb..78a0f35 100644
> --- a/src/solvers/petscdmlibmeshimpl.C
> +++ b/src/solvers/petscdmlibmeshimpl.C
> @@ -5,7 +5,7 @@
> #if !PETSC_VERSION_LESS_THAN(3,3,0)
>
> // PETSc includes
> -#include
> +#include
>
> // Local Includes
> #include "libmesh/libmesh_common.h"
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/IBAMR/IBAMR/commit/fbc6998bd4849a11f239e8138376ab2e52a0509a#commitcomment-11437944>.
>


Did the linter do this?


the linter gave me a warning that ORCIDFromEmail wasn't defined. Went in and added 'helpers'


Generated application layout compatible with bootstrap 3.


under 5000 individuals and under 700 organizations merged away.


Thanks! I will check both out.


fixed bug in GLW_figure_maps


I didn't use skin in blizzard frame, What's wrong with scrollbars?
Maybe you can reference AddOnSkins function.
```
local ScrollBarElements = {
	'BG',
	'Track',
	'Top',
	'Bottom',
	'Middle',
}

function AS:SkinScrollBar(Frame)
	local ScrollUpButton = Frame:GetName() and _G[Frame:GetName().."ScrollUpButton"] or Frame.ScrollUpButton
	local ScrollDownButton = Frame:GetName() and _G[Frame:GetName().."ScrollDownButton"] or Frame.ScrollDownButton

	for _, object in pairs(ScrollBarElements) do
		if Frame:GetName() and _G[Frame:GetName()..object] then
			_G[Frame:GetName()..object]:SetTexture(nil)
		end
	end

	if ScrollUpButton and ScrollDownButton then
		AS:StripTextures(ScrollUpButton)
		AS:SetTemplate(ScrollUpButton, "Default", true)

		AS:StripTextures(ScrollDownButton)
		AS:SetTemplate(ScrollDownButton, "Default", true)

		if not ScrollUpButton.Text then
			ScrollUpButton.Text = ScrollUpButton:CreateFontString(nil, "OVERLAY")
			ScrollUpButton.Text:SetFont([[Fonts\ARIALN.TTF]], 12)
			ScrollUpButton.Text:SetText("▲")
			ScrollUpButton.Text:SetPoint("CENTER", 1, 0)

			ScrollUpButton:HookScript('OnShow', function(self)
				if not self:IsEnabled() then
					self.Text:SetTextColor(.3, .3, .3)
				end
			end)

			ScrollUpButton:HookScript('OnDisable', function(self)
				self.Text:SetTextColor(.3, .3, .3)
			end)

			ScrollUpButton:HookScript('OnEnable', function(self)
				self.Text:SetTextColor(1, 1, 1)
			end)

			ScrollUpButton:HookScript('OnEnter', function(self)
				self:SetBackdropBorderColor(Color.r, Color.g, Color.b)
				self.Text:SetTextColor(Color.r, Color.g, Color.b)
			end)
			ScrollUpButton:HookScript('OnLeave', function(self)
				self:SetBackdropBorderColor(unpack(AS.BorderColor))
				self.Text:SetTextColor(1, 1, 1)
			end)
		end

		if not ScrollDownButton.Text then
			ScrollDownButton.Text = ScrollDownButton:CreateFontString(nil, "OVERLAY")
			ScrollDownButton.Text:SetFont([[Fonts\ARIALN.TTF]], 12)
			ScrollDownButton.Text:SetText("▼")
			ScrollDownButton.Text:SetPoint("CENTER", 1, 0)

			ScrollDownButton:HookScript('OnShow', function(self)
				if not self:IsEnabled() then
					self.Text:SetTextColor(.3, .3, .3)
				end
			end)

			ScrollDownButton:HookScript('OnDisable', function(self)
				self.Text:SetTextColor(.3, .3, .3)
			end)

			ScrollDownButton:HookScript('OnEnable', function(self)
				self.Text:SetTextColor(1, 1, 1)
			end)

			ScrollDownButton:HookScript('OnEnter', function(self)
				self:SetBackdropBorderColor(Color.r, Color.g, Color.b)
				self.Text:SetTextColor(Color.r, Color.g, Color.b)
			end)

			ScrollDownButton:HookScript('OnLeave', function(self)
				self:SetBackdropBorderColor(unpack(AS.BorderColor))
				self.Text:SetTextColor(1, 1, 1)
			end)
		end

		if not Frame.TrackBG then
			Frame.TrackBG = CreateFrame("Frame", nil, Frame)
			Frame.TrackBG:Point("TOPLEFT", ScrollUpButton, "BOTTOMLEFT", 0, -1)
			Frame.TrackBG:Point("BOTTOMRIGHT", ScrollDownButton, "TOPRIGHT", 0, 1)
			AS:SetTemplate(Frame.TrackBG, "Transparent")
		end

		if Frame:GetThumbTexture() then
			Frame:GetThumbTexture():SetTexture(nil)
			if not Frame.ThumbBG then
				Frame.ThumbBG = CreateFrame("Frame", nil, Frame)
				Frame.ThumbBG:Point("TOPLEFT", Frame:GetThumbTexture(), "TOPLEFT", 2, -3)
				Frame.ThumbBG:Point("BOTTOMRIGHT", Frame:GetThumbTexture(), "BOTTOMRIGHT", -2, 3)
				AS:SetTemplate(Frame.ThumbBG, "Default", true)

				if Frame.ThumbBG then
					Frame.ThumbBG:SetFrameLevel(Frame.TrackBG:GetFrameLevel())
				end
			end
		end
	end
end
```


Is always calling ltrim() more efficient than executing the original piece of code?


리뷰 반영하기 전 `next` 브랜치와 sync-up을 해야할 것 같아서 rebase를 했는데, 그 때 섞여들어온 모양입니다. 제거해놓겠습니다.


Oh. Interesting. Needs more tests!


dfdfdfd


Forestry's leaf code hurts my brain.  A lot. ;_;

I thiiiink I sort of maybe figured out how to add custom leaves.  Possibly.


只有 `cmd.size() - 1` 个管道，关多了……


Error in commit message. Example should be as follows:

e.g., initialMap = fromList [("a", 1), ("b", 2)]

Post to localhost:8080/packages/vote/a
Map now holds: [("a", 2), ("b", 2)]
(a increases by one)

Post to localhost:8080/packages/vote/b
Map now holds: [("a", 2), ("b", 3)]
(b increases by one)


Initial comment


I think you have to include memory


try it now


I will test this function, afternoon,


Note-the example.png is from within the docker container. this does run.  the key change here is that the paths were manually changed under example.R.    What is needed is a function to encapsulate the manual install.


What does this fix, if anything?  Seems to work fine the original way...

https://github.com/SlimRoms/device_samsung_msm8660-common/blob/lp5.1/camera/CameraWrapper.cpp#L59


Trying to break Thomas' record of the earliest mail ? Oh no, it's the earliest review ! Congrats :)

-----Original Message-----
From: Lucas Ponce [notifications@github.com]
Received: vendredi, 05 juin 2015, 5:33
To: hawkular/hawkular-alerts [hawkular-alerts@noreply.github.com]
Subject: Re: [hawkular-alerts] Remove the snapshot dep on Hawkular-Dist for i-tests. Use the first (5568f77)

+1
Cool fix ! Thx !

---
Reply to this email directly or view it on GitHub:
https://github.com/hawkular/hawkular-alerts/commit/5568f77bff0687bdfe8422212aaa7e3eab20d9f4#commitcomment-11534362