1: D100 Missing docstring in public module
23:1: I101 Imported names are in the wrong order. Should be cPickle, calendar, cgi, commands, datetime, os, random, time
23:16: E401 multiple imports on one line
23:1: E402 module level import not at top of file
24:1: E402 module level import not at top of file
25:1: I101 Imported names are in the wrong order. Should be CFG_BIBCIRCULATION_ILL_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CLAIMED, CFG_BIBCIRCULATION_ITEM_STATUS_IN_PROCESS, CFG_BIBCIRCULATION_ITEM_STATUS_NOT_ARRIVED, CFG_BIBCIRCULATION_ITEM_STATUS_ON_LOAN, CFG_BIBCIRCULATION_ITEM_STATUS_ON_ORDER, CFG_BIBCIRCULATION_ITEM_STATUS_ON_SHELF, CFG_BIBCIRCULATION_ITEM_STATUS_OPTIONAL, CFG_BIBCIRCULATION_REQUEST_STATUS_DONE, CFG_BINDIR, CFG_CERN_SITE, CFG_SITE_NAME, CFG_SITE_URL, CFG_TMPDIR
25:1: I201 Missing newline before sections or imports.
25:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: I101 Imported names are in the wrong order. Should be get_collection_reclist, get_most_popular_field_values, perform_request_search, search_pattern
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.utils.url
42:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
49:1: I101 Imported names are in the wrong order. Should be book_information_from_MARC, book_title_from_MARC
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.utils should be before from invenio.legacy.dbquery
49:1: E402 module level import not at top of file
51:1: I101 Imported names are in the wrong order. Should be get_borrower_data, get_id_bibrec
51:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.db_layer should be before from invenio.legacy.bibcirculation.utils
51:1: E402 module level import not at top of file
54:1: I101 Imported names are in the wrong order. Should be convert_datestruct_to_dategui, convert_datetext_to_datestruct
54:1: E402 module level import not at top of file
55:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.date
55:1: E402 module level import not at top of file
58:38: E261 at least two spaces before inline comment
63:1: E302 expected 2 blank lines, found 1
63: D401 First line should be in imperative mood ('Return', not 'Returns')
63: D400 First line should end with a period (not 'r')
63: D205 1 blank line required between summary line and description (found 0)
87:25: E128 continuation line under-indented for visual indent
91:29: E128 continuation line under-indented for visual indent
91:61: E251 unexpected spaces around keyword / parameter equals
92:29: E128 continuation line under-indented for visual indent
93:29: E128 continuation line under-indented for visual indent
104:27: E128 continuation line under-indented for visual indent
107: D401 First line should be in imperative mood ('Return', not 'Returns')
107: D202 No blank lines allowed after function docstring (found 1)
129:29: E128 continuation line under-indented for visual indent
130:29: E128 continuation line under-indented for visual indent
144: D210 No whitespaces allowed surrounding docstring text
144: D209 Multi-line docstring closing quotes should be on a separate line
144: D400 First line should end with a period (not 's')
144: D205 1 blank line required between summary line and description (found 0)
153:29: E128 continuation line under-indented for visual indent
154:29: E126 continuation line over-indented for hanging indent
160:27: E128 continuation line under-indented for visual indent
163: D401 First line should be in imperative mood ('Return', not 'Returns')
163: D202 No blank lines allowed after function docstring (found 1)
163: D400 First line should end with a period (not 't')
163: D205 1 blank line required between summary line and description (found 0)
182:17: E128 continuation line under-indented for visual indent
183:29: E128 continuation line under-indented for visual indent
186: D401 First line should be in imperative mood ('Return', not 'Returns')
186: D400 First line should end with a period (not 't')
186: D205 1 blank line required between summary line and description (found 0)
208:13: E128 continuation line under-indented for visual indent
211:13: E128 continuation line under-indented for visual indent
211:44: E251 unexpected spaces around keyword / parameter equals
212:13: E128 continuation line under-indented for visual indent
216: D401 First line should be in imperative mood ('Return', not 'Returns')
216: D400 First line should end with a period (not 'n')
216: D205 1 blank line required between summary line and description (found 0)
236:21: E128 continuation line under-indented for visual indent
237:21: E128 continuation line under-indented for visual indent
241:21: E128 continuation line under-indented for visual indent
242:21: E128 continuation line under-indented for visual indent
246:25: E128 continuation line under-indented for visual indent
248:25: E128 continuation line under-indented for visual indent
257: D401 First line should be in imperative mood ('Return', not 'Returns')
257: D400 First line should end with a period (not 't')
257: D205 1 blank line required between summary line and description (found 0)
280:17: E128 continuation line under-indented for visual indent
300:27: E128 continuation line under-indented for visual indent
303: D401 First line should be in imperative mood ('Return', not 'Returns')
303: D400 First line should end with a period (not 't')
303: D205 1 blank line required between summary line and description (found 0)
321:13: E128 continuation line under-indented for visual indent
324: D401 First line should be in imperative mood ('Return', not 'Returns')
324: D400 First line should end with a period (not 'r')
324: D205 1 blank line required between summary line and description (found 0)
346:17: E128 continuation line under-indented for visual indent
350:17: E128 continuation line under-indented for visual indent
357: D400 First line should end with a period (not ':')
357: D205 1 blank line required between summary line and description (found 0)
428:37: E126 continuation line over-indented for hanging indent
429:10: E261 at least two spaces before inline comment
466: D400 First line should end with a period (not ':')
466: D205 1 blank line required between summary line and description (found 0)
575:62: E502 the backslash is redundant between brackets
576:23: E128 continuation line under-indented for visual indent
587:13: E128 continuation line under-indented for visual indent
588:13: E128 continuation line under-indented for visual indent
589:13: E128 continuation line under-indented for visual indent
590:13: E128 continuation line under-indented for visual indent
596:13: E128 continuation line under-indented for visual indent
597:13: E128 continuation line under-indented for visual indent
598:13: E128 continuation line under-indented for visual indent
599:13: E128 continuation line under-indented for visual indent
600:13: E128 continuation line under-indented for visual indent
605: D400 First line should end with a period (not ':')
605: D205 1 blank line required between summary line and description (found 0)
673: D400 First line should end with a period (not ':')
673: D205 1 blank line required between summary line and description (found 0)
699: D401 First line should be in imperative mood ('Return', not 'Returns')
699: D400 First line should end with a period (not 's')
717:17: E128 continuation line under-indented for visual indent
719:17: E128 continuation line under-indented for visual indent
723:17: E128 continuation line under-indented for visual indent
724:17: E128 continuation line under-indented for visual indent
728:25: E128 continuation line under-indented for visual indent
730:25: E128 continuation line under-indented for visual indent
739: D400 First line should end with a period (not ':')
739: D205 1 blank line required between summary line and description (found 0)
837: D400 First line should end with a period (not ':')
837: D205 1 blank line required between summary line and description (found 0)
866:21: E127 continuation line over-indented for visual indent
897: D401 First line should be in imperative mood ('Return', not 'Returns')
897: D400 First line should end with a period (not 't')
897: D205 1 blank line required between summary line and description (found 0)
943:19: E128 continuation line under-indented for visual indent
948:19: E128 continuation line under-indented for visual indent
948:66: E225 missing whitespace around operator
952:25: E128 continuation line under-indented for visual indent
954:25: E128 continuation line under-indented for visual indent
963: D400 First line should end with a period (not ':')
963: D205 1 blank line required between summary line and description (found 0)
1014: D202 No blank lines allowed after function docstring (found 1)
1014: D400 First line should end with a period (not ':')
1014: D205 1 blank line required between summary line and description (found 0)
1079: D400 First line should end with a period (not ':')
1079: D205 1 blank line required between summary line and description (found 0)
1122:57: E128 continuation line under-indented for visual indent
1137:9: E128 continuation line under-indented for visual indent
1140: D400 First line should end with a period (not ':')
1140: D205 1 blank line required between summary line and description (found 0)
1199: D400 First line should end with a period (not ':')
1199: D205 1 blank line required between summary line and description (found 0)
1235: D400 First line should end with a period (not ':')
1235: D205 1 blank line required between summary line and description (found 0)
1281:1: E302 expected 2 blank lines, found 1
1342: D400 First line should end with a period (not 'n')
1342: D205 1 blank line required between summary line and description (found 0)
1354:10: E261 at least two spaces before inline comment
1354:11: E262 inline comment should start with '# '
1376:83: E502 the backslash is redundant between brackets
1376:82: E211 whitespace before '('
1377:21: E128 continuation line under-indented for visual indent
1379:82: E502 the backslash is redundant between brackets
1379:81: E211 whitespace before '('
1380:21: E128 continuation line under-indented for visual indent
1382:82: E502 the backslash is redundant between brackets
1382:81: E211 whitespace before '('
1383:21: E128 continuation line under-indented for visual indent
1386:82: E502 the backslash is redundant between brackets
1386:81: E211 whitespace before '('
1387:21: E128 continuation line under-indented for visual indent
1394:1: E302 expected 2 blank lines, found 1
1394: D401 First line should be in imperative mood ('Build', not 'Builds')
1394: D400 First line should end with a period (not 'r')
1394: D205 1 blank line required between summary line and description (found 0)
1446:1: E302 expected 2 blank lines, found 1
1446: D205 1 blank line required between summary line and description (found 0)
1456:13: E127 continuation line over-indented for visual indent
1459:1: E302 expected 2 blank lines, found 1
1459: D401 First line should be in imperative mood ('Fetche', not 'Fetches')
1459: D400 First line should end with a period (not 't')
1459: D205 1 blank line required between summary line and description (found 0)
1471:15: E711 comparison to None should be 'if cond is None:'
1471:15: E225 missing whitespace around operator
1471:32: E225 missing whitespace around operator
1475:5: B901 blind except: statement
1493:1: E302 expected 2 blank lines, found 1
1493: D401 First line should be in imperative mood ('Return', not 'Returns')
1493: D205 1 blank line required between summary line and description (found 0)
1510:77: E502 the backslash is redundant between brackets
1511:25: E127 continuation line over-indented for visual indent
1515:81: E502 the backslash is redundant between brackets
1516:25: E127 continuation line over-indented for visual indent
1526:1: E302 expected 2 blank lines, found 1
1526: D401 First line should be in imperative mood ('Return', not 'Returns')
1526: D400 First line should end with a period (not 'n')
1526: D205 1 blank line required between summary line and description (found 0)
1560:33: E128 continuation line under-indented for visual indent
1561:28: E211 whitespace before '('
1567:33: E128 continuation line under-indented for visual indent
1568:28: E211 whitespace before '('
1576:28: E211 whitespace before '('
1585:33: E128 continuation line under-indented for visual indent
1590:77: E502 the backslash is redundant between brackets
1590:76: E211 whitespace before '('
1591:21: E128 continuation line under-indented for visual indent
1593:1: E302 expected 2 blank lines, found 1
1593: D400 First line should end with a period (not 't')
1593: D205 1 blank line required between summary line and description (found 0)
1606:13: E127 continuation line over-indented for visual indent
1608:1: E302 expected 2 blank lines, found 1
1608:33: E211 whitespace before '('
1608: D401 First line should be in imperative mood ('Return', not 'Returns')
1608: D205 1 blank line required between summary line and description (found 0)
1617:73: E502 the backslash is redundant between brackets
1617:72: E211 whitespace before '('
1618:21: E128 continuation line under-indented for visual indent
1621:1: E302 expected 2 blank lines, found 1
1621: D401 First line should be in imperative mood ('Return', not 'Returns')
1621: D400 First line should end with a period (not 'r')
1621: D205 1 blank line required between summary line and description (found 0)
1635:1: E303 too many blank lines (3)
1637:1: E302 expected 2 blank lines, found 3
1637: D401 First line should be in imperative mood ('Create', not 'Creates')
1637: D400 First line should end with a period (not 's')
1642: D210 No whitespaces allowed surrounding docstring text
1642: D401 First line should be in imperative mood ('Return', not 'Returns')
1642: D400 First line should end with a period (not 'g')
1647: D401 First line should be in imperative mood ('Return', not 'Returns')
1647: D400 First line should end with a period (not ')')
1652: D401 First line should be in imperative mood ('Return', not 'Returns')
1658: D210 No whitespaces allowed surrounding docstring text
1658: D401 First line should be in imperative mood ('Return', not 'Returns')
1658: D400 First line should end with a period (not 'g')
1664:1: E302 expected 2 blank lines, found 1
1664: D401 First line should be in imperative mood ('Return', not 'Returns')
1664: D400 First line should end with a period (not 'n')
1664: D205 1 blank line required between summary line and description (found 0)
1697:12: E713 test for membership should be 'not in'
1704:34: E127 continuation line over-indented for visual indent
1707:34: E127 continuation line over-indented for visual indent
1710:34: E127 continuation line over-indented for visual indent
1723: D400 First line should end with a period (not 'y')
1723: D205 1 blank line required between summary line and description (found 0)
1756:26: E127 continuation line over-indented for visual indent
1761:114: E261 at least two spaces before inline comment
1765:16: E713 test for membership should be 'not in'
1769:49: E502 the backslash is redundant between brackets
1770:42: E127 continuation line over-indented for visual indent
1772:48: E502 the backslash is redundant between brackets
1773:42: E127 continuation line over-indented for visual indent
1775:53: E502 the backslash is redundant between brackets
1776:42: E127 continuation line over-indented for visual indent
1790:21: E126 continuation line over-indented for hanging indent
1809: D400 First line should end with a period (not 'g')
1809: D205 1 blank line required between summary line and description (found 0)
1823: D400 First line should end with a period (not 'g')
1823: D205 1 blank line required between summary line and description (found 0)
1840:1: E302 expected 2 blank lines, found 1
1840: D401 First line should be in imperative mood ('Return', not 'Returns')
1840: D202 No blank lines allowed after function docstring (found 1)
1840: D400 First line should end with a period (not 'r')
1883: D401 First line should be in imperative mood ('Create', not 'Creates')
1883: D400 First line should end with a period (not 'd')
1883: D205 1 blank line required between summary line and description (found 0)
1897:5: B901 blind except: statement
1950:1: E302 expected 2 blank lines, found 1
1950: D401 First line should be in imperative mood ('Create', not 'Creates')
1978: D401 First line should be in imperative mood ('Create', not 'Creates')
1978: D400 First line should end with a period (not 't')
1989:21: E128 continuation line under-indented for visual indent
1997:21: E126 continuation line over-indented for hanging indent
2036:37: E128 continuation line under-indented for visual indent
2045: D401 First line should be in imperative mood ('Create', not 'Creates')
2045: D400 First line should end with a period (not 'y')
2093:35: E127 continuation line over-indented for visual indent
2117: D401 First line should be in imperative mood ('Create', not 'Creates')
2117: D400 First line should end with a period (not 'y')
2143:25: E128 continuation line under-indented for visual indent
2168:21: E128 continuation line under-indented for visual indent
2168:60: E225 missing whitespace around operator
2169:21: E126 continuation line over-indented for hanging indent
2207:18: E222 multiple spaces after operator
2225:9: E116 unexpected indentation (comment)
2243:9: E116 unexpected indentation (comment)
2307:62: E203 whitespace before ':'
2311: D210 No whitespaces allowed surrounding docstring text
2311: D401 First line should be in imperative mood ('Return', not 'Returns')
2311: D400 First line should end with a period (not 'a')
2326: D401 First line should be in imperative mood ('Create', not 'Creates')
2363: D401 First line should be in imperative mood ('Create', not 'Creates')
2386:46: E502 the backslash is redundant between brackets
2387:21: E128 continuation line under-indented for visual indent
2413:1: E302 expected 2 blank lines, found 1
2413: D401 First line should be in imperative mood ('Return', not 'Returns')
2413: D400 First line should end with a period (not 'y')
2419: D401 First line should be in imperative mood ('Return', not 'Returns')
2419: D400 First line should end with a period (not 'y')
2431: D401 First line should be in imperative mood ('Return', not 'Returns')
2431: D400 First line should end with a period (not 'y')
2439:14: E128 continuation line under-indented for visual indent
2444: D401 First line should be in imperative mood ('Return', not 'Returns')
2444: D400 First line should end with a period (not 'y')
2449: D401 First line should be in imperative mood ('Return', not 'Returns')
2449: D400 First line should end with a period (not 'y')
2454: D401 First line should be in imperative mood ('Return', not 'Returns')
2454: D400 First line should end with a period (not 'y')
2459: D401 First line should be in imperative mood ('Return', not 'Returns')
2459: D400 First line should end with a period (not 'y')
2466: D401 First line should be in imperative mood ('Return', not 'Returns')
2466: D400 First line should end with a period (not 'y')
2474: D401 First line should be in imperative mood ('Return', not 'Returns')
2474: D400 First line should end with a period (not 'y')
2482: D401 First line should be in imperative mood ('Return', not 'Returns')
2482: D400 First line should end with a period (not 'y')
2490: D401 First line should be in imperative mood ('Return', not 'Returns')
2490: D400 First line should end with a period (not 's')
2494:10: E128 continuation line under-indented for visual indent
2498:1: E302 expected 2 blank lines, found 1
2498: D401 First line should be in imperative mood ('Export', not 'Exports')
2511: D401 First line should be in imperative mood ('Export', not 'Exports')
2521:66: E502 the backslash is redundant between brackets
2522:18: E128 continuation line under-indented for visual indent
2526: D401 First line should be in imperative mood ('Export', not 'Exports')
2546:68: E502 the backslash is redundant between brackets
2556:1: E302 expected 2 blank lines, found 1
2556: D400 First line should end with a period (not 'a')
2556: D205 1 blank line required between summary line and description (found 0)
2565:64: E502 the backslash is redundant between brackets
2566:25: E127 continuation line over-indented for visual indent
2569: D400 First line should end with a period (not ',')
2569: D205 1 blank line required between summary line and description (found 0)
2624:13: E128 continuation line under-indented for visual indent
2625:13: E128 continuation line under-indented for visual indent
2626:13: E128 continuation line under-indented for visual indent
2627:13: E128 continuation line under-indented for visual indent
2628:13: E128 continuation line under-indented for visual indent
2629:13: E124 closing bracket does not match visual indentation
2629:13: E125 continuation line with same indent as next logical line
2645:13: E125 continuation line with same indent as next logical line
2651: D401 First line should be in imperative mood ('Return', not 'Returns')
2677:27: E128 continuation line under-indented for visual indent
2680: D401 First line should be in imperative mood ('Return', not 'Returns')
2680: D400 First line should end with a period (not ',')
2680: D205 1 blank line required between summary line and description (found 0)
2724:1: E302 expected 2 blank lines, found 1
2724: D401 First line should be in imperative mood ('Transform', not 'Transforms')
2724: D400 First line should end with a period (not 'e')
2724: D200 One-line docstring should fit on one line with quotes (found 3)
2731: D401 First line should be in imperative mood ('Run', not 'Runs')
2731: D400 First line should end with a period (not 's')
2731: D205 1 blank line required between summary line and description (found 0)
2745: D401 First line should be in imperative mood ('Return', not 'Returns')
2745: D400 First line should end with a period (not 'n')
2751: D401 First line should be in imperative mood ('Return', not 'Returns')
2751: D400 First line should end with a period (not 'm')
2760:13: E127 continuation line over-indented for visual indent
2763: D401 First line should be in imperative mood ('Return', not 'Returns')
2763: D400 First line should end with a period (not 'm')
2767:9: E125 continuation line with same indent as next logical line
2772: D401 First line should be in imperative mood ('Return', not 'Returns')
2772: D400 First line should end with a period (not 't')
2780: D401 First line should be in imperative mood ('Return', not 'Returns')
2780: D400 First line should end with a period (not 's')
2784:33: E713 test for membership should be 'not in'
2784:54: E261 at least two spaces before inline comment
2789: D401 First line should be in imperative mood ('Return', not 'Returns')
2789: D400 First line should end with a period (not 'm')
2797: D400 First line should end with a period (not 'e')
2797: D200 One-line docstring should fit on one line with quotes (found 3)
2809:1: E302 expected 2 blank lines, found 1
2815:1: E302 expected 2 blank lines, found 1
2820:1: E302 expected 2 blank lines, found 1
2827:1: E302 expected 2 blank lines, found 1
2833:1: E302 expected 2 blank lines, found 1
2846:1: E302 expected 2 blank lines, found 1
2851:37: E128 continuation line under-indented for visual indent
2853:10: E128 continuation line under-indented for visual indent
2854:10: E128 continuation line under-indented for visual indent
2855:10: E128 continuation line under-indented for visual indent
2856:10: E128 continuation line under-indented for visual indent
2857:10: E128 continuation line under-indented for visual indent
2858:10: E128 continuation line under-indented for visual indent


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
152:58: E203 whitespace before ','
210:15: E126 continuation line over-indented for hanging indent
213:1: E402 module level import not at top of file
247:17: E203 whitespace before ':'
248:22: E203 whitespace before ':'
249:20: E203 whitespace before ':'
250:18: E203 whitespace before ':'
251:24: E203 whitespace before ':'
252:22: E203 whitespace before ':'
253:19: E203 whitespace before ':'
254:20: E203 whitespace before ':'
255:23: E203 whitespace before ':'
256:18: E203 whitespace before ':'
257:17: E203 whitespace before ':'
258:19: E203 whitespace before ':'
259:20: E203 whitespace before ':'
260:21: E203 whitespace before ':'
261:19: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:17: E203 whitespace before ':'
264:24: E203 whitespace before ':'
265:23: E203 whitespace before ':'
266:21: E203 whitespace before ':'
267:37: E203 whitespace before ':'
281:4: E131 continuation line unaligned for hanging indent
310:1: W391 blank line at end of file


1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
25:1: I100 Imports statements are in the wrong order. import logging should be before import sys
25:1: F401 'logging' imported but unused
27:1: I100 Imports statements are in the wrong order. import re should be before import urllib2
31:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_FULLTEXT_INDEX_LOCAL_FILES_ONLY, CFG_BIBINDEX_SPLASH_PAGES, CFG_SOLR_URL, CFG_XAPIAN_ENABLED
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
32:6: E126 continuation line over-indented for hanging indent
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.miscutil.solrutils_bibindex_indexer should be before from invenio.utils.html
39:1: I101 Imported names are in the wrong order. Should be BibRecDocs, InvenioBibDocFileError, bibdocfile_url_p, bibdocfile_url_to_bibdoc, download_url
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.miscutil.xapianutils_bibindex_indexer
40:6: E126 continuation line over-indented for hanging indent
44:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibsched.bibtask
45:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.ext.logging
45:1: I201 Missing newline before sections or imports.
46:1: I201 Missing newline before sections or imports.
48:29: E261 at least two spaces before inline comment
51: D203 1 blank line required before class docstring (found 0)
51: D208 Docstring is over-indented
51: D200 One-line docstring should fit on one line with quotes (found 3)
56:41: E251 unexpected spaces around keyword / parameter equals
56:43: E251 unexpected spaces around keyword / parameter equals
56:66: E251 unexpected spaces around keyword / parameter equals
56:68: E251 unexpected spaces around keyword / parameter equals
56:94: E251 unexpected spaces around keyword / parameter equals
56:96: E251 unexpected spaces around keyword / parameter equals
56:123: E251 unexpected spaces around keyword / parameter equals
56:125: E251 unexpected spaces around keyword / parameter equals
56: D102 Missing docstring in public method
59:49: E127 continuation line over-indented for visual indent
60:49: E127 continuation line over-indented for visual indent
61:49: E127 continuation line over-indented for visual indent
63: D401 First line should be in imperative mood ('Allow', not 'Allows')
63: D400 First line should end with a period (not 'g')
67: D400 First line should end with a period (not 'r')
72:5: E303 too many blank lines (2)
72: D401 First line should be in imperative mood ('Return', not 'Returns')
72: D400 First line should end with a period (not 'y')
72: D205 1 blank line required between summary line and description (found 0)
72: D208 Docstring is over-indented
100:28: E713 test for membership should be 'not in'
152:66: E261 at least two spaces before inline comment
170:29: F821 undefined name 'file_converter_logger'
170:60: F821 undefined name 'old_logging_level'
179:5: E303 too many blank lines (2)
179: D102 Missing docstring in public method
183:5: E303 too many blank lines (2)
183: D102 Missing docstring in public method
186: D102 Missing docstring in public method
188:1: W391 blank line at end of file


4: L102 copyright year is outdated, expected 2015 but got 2012
30:1: I100 Imports statements are in the wrong order. import time should be before import urllib2
31:1: I100 Imports statements are in the wrong order. import os should be before import time
34:1: I100 Imports statements are in the wrong order. import tempfile should be before import urllib
35:1: I100 Imports statements are in the wrong order. import shutil should be before import tempfile
42:1: I101 Imported names are in the wrong order. Should be CFG_BIBUPLOAD_FFT_ALLOWED_LOCAL_PATHS, CFG_TMPSHAREDDIR
42:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.url
42:1: E402 module level import not at top of file
49: D203 1 blank line required before class docstring (found 0)
49: D204 1 blank line required after class docstring (found 0)
51: D102 Missing docstring in public method
56: D203 1 blank line required before class docstring (found 0)
56: D204 1 blank line required after class docstring (found 0)
61: D400 First line should end with a period (not 'e')
61: D205 1 blank line required between summary line and description (found 0)
121: D400 First line should end with a period (not 'a')
121: D205 1 blank line required between summary line and description (found 0)
217: D401 First line should be in imperative mood ('Finalize', not 'Finalizes')
217: D400 First line should end with a period (not 't')
217: D205 1 blank line required between summary line and description (found 0)
252: D401 First line should be in imperative mood ('Copie', not 'Copies')
301: D209 Multi-line docstring closing quotes should be on a separate line
301: D400 First line should end with a period (not 't')
301: D205 1 blank line required between summary line and description (found 0)
323: D401 First line should be in imperative mood ('Open', not 'Opens')
323: D400 First line should end with a period (not 'd')
323: D205 1 blank line required between summary line and description (found 0)


has worked hard over the last 10 years to address the tech community's toxic lack of diversity.


You got a typo: `deploied` vs. (correct) `deployed`. Also, please be a bit more specific and shorter with your description. Thanks.


This seems to me to be a pretty close parallel to stuff that happens in the Linux kernel in particular


This will be the first of many Travis PR's, I can feel it.


«скорость» → «скорость работы» или «эффективность»


Is it possible / any value to keep vendor packages isolated?  Currently each contributor follows their own preference.  So some are in library, others in interface - both of which should be internal components.  Autoloader will be ideal integration point to centrally load openemr's interface to vendor packages.


Please initialize logger first. Theoritically `Preferences` could use it in the future.


Is there a History file of some sort that needs updating?


Why used string interpolation in controller?? Please specify.


Good catch!


For all its problems in this area, science is demonstrably more inclusive than tech, so I hope that we can import the good parts of open without also adopting the bad.


@AnkurGel
The code written for the terminal application : https://gist.github.com/sinstein/b20c59a3c460c39be3cf
Made changes for unit tests. Did not do a very good job.


Why include the examples in the dist?


@udalov
I have tried to extract common code, please take a look at https://github.com/JetBrains/kotlin/commit/a7c7a83cfea89e0961eb0a9dac31cce8168950e3


Looks good. Could you apply some styling please?

```patch
diff --git a/client/app/styles/main.less b/client/app/styles/main.less
index 6a06eb6..136962a 100644
--- a/client/app/styles/main.less
+++ b/client/app/styles/main.less
@@ -63,6 +63,15 @@ body {
   z-index: 20;
   color: @text-tertiary-color;
   font-size: 85%;
+
+  a {
+    color: @text-secondary-color;
+
+    &:hover {
+      color: @text-color;
+    }
+  }
+
 }

 .logo {
```


Great. I'll back it out on my next commit and we'll deal with the name when it's time.


Thanks @Tobias-Fischer!
I didn't go through the code inside the ELAS files after downloading the two versions (with and without OpenMP). Now I'll check that all the files are the same except for `elas.cpp` and I will follow your suggestion.


It was 58 chars long. XD


Remove ```put s```


Писать надо в прошедшем времени, так как работа уже выполнена: «Применение классов типов, представленных в предыдущем подразделе, позволи**ло** получить абстрактный код…».


Thanks @mgruner  for info.
We will use it in future test.

Regards
Zoran


Maybe. I use this code to figure out how use the available functions and believe it would be useful to others who need to go into this territory. It's not meant to be production. I frequently need to copy the images back to my local computer to look at them, which is easier when their names are meaningful.


Just a bit more on this - the list of personas focusses entirely on the dominant, aggressive, implicitly male voices and why them dominating is bad. Balance it out with the unheard voices and why that is bad.


Use width instead of ```  ```


That is true. Reverting here in a minute


We need `const` pointers sometimes. For example, `mpc_add(mpc_ptr, mpc_srcptr, mpc_srcptr, mpc_rnd_t)` where second and third arguments are const pointers (`mpc_srcptr`)


Yes!


This isn't easy. For example, I'm a long-time participant in Software Carpentry, which lives at the intersection of science and open source.  20% of its instructors are women, but participation in its mailing lists is overwhelming male, despite many attempts to make them more inclusive.  And that's just one example of a more general phenomenon: I know many people who won't touch public discussion forums like these with a ten-foot pole.


«Необходимо» тут не очень подходит (необходимо чтобы что: чтобы написать диплом?). Лучше говорить: «в данной работе исследованы другие концепции». Можно смягчать слово исследованы: «рассматривается возможность применения других концепций» и т. п.


@radeklos   This looks good.  Thanks for sending the PR.

Can you please bump the version number and then i'll get this merged for you.


@sindresorhus Next reminder to publish those dotfiles lol :p

@addyosmani I use a slightly customised version of [this one](https://github.com/alrra/dotfiles/blob/master/git/gitconfig#L25). If many updates need to happen to a PR I use this snippet to pull a PR:

```
pr  = "!f() { git fetch -fu ${2:-origin} refs/pull/$1/head:pr/$1 && git checkout pr/$1; }; f"
```

and then rebase and merge it upon the main branch.

_But pretty sure Sindre has a better setup ;)_


Move all placeholder in to en.yml with proper hierarchy.


I also investigated this, how can this happen? Strange


Just "This", not "And this"


What does the commenters' tenuredness have to do with it?


I'm not sure either, but the idea was that this is a per-file option.
Consider the case where andromeda is called with multiple files. Then
the line limit would apply to... presumably the last file?

It's possible to add a command-line flag and then fold over all but the
last file without limit.


but if we do that for extend, why do we have to explicitly mention .jade here and in inheritance.extend.mixins.block.jade ?


I'd remove the "Hmm."


Great !!


Ouch.

I wonder, since the dummy joints/links are leafs that go nowhere, that is:

``` ascii
root-> ... base_link -> joint_0 -> link_1 -> joint_1 -> link_2 -> ... tip
                            \                     \
                        joint_0_stiffness        joint_1_stiffness
                              \                       \
                             dummy_link_1            dummy_link_2
```

If you actually get the chain first with `if(!kdl_tree_.getChain(root_name, tip_name, kdl_chain_))`, then you can work with `kdl_chain_.getNrOfJoints()` without the division.

What do you think?


You mean creating `src` and `include` subdirectories inside `elas_src` directory?


pimmel


Move static values into en.yml


Hello Jim.
I want to implement a similar functionality on "common" chords annotations (actually a Harmony in MuseScore jargon)
Did you have a look at linked staves to keep some kind of link between the source annotation (FB or Harmony) and the generated notes... eg to update/remove the later when the former is modified?
B.


jsdoc is a structured way to specify types and contract of a function. Not everyone uses it, but lots of tools understand it. I would recommend using it when creating new APIs.


Нельзя ли до начала описания _конкретных_ подходов к комбинированию обозначить _общую_ проблему этого самого комбинирования? Возможно, с каким-то простым примером. Чёткое описание проблемы это чрезвычайно важный элемент текста. Иначе создаётся впечатление, что вы просто описываете какие-то непонятные никому не нужные штуки.


Why you remove many code from this PR?


pardon me, but "not_update_created" is not English I understand

do you mean "do_not_update_createdAt_property_on_existing_component" ?


This has also to be done for the rpi-cec3 target (-DHAVE_RPI_API)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.260](http://teamcity.monogame.net/viewLog.html?buildId=8194&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:20:39


Any way this architecture can be adapted for current code as well?  Instead of classes, it would be specific files that are needed for specific features - e.g. any functionality using LBF elements requires options.inc which in turn should be using formatting etc...  It will make existing code easier to understand.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.261](http://teamcity.monogame.net/viewLog.html?buildId=8198&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Document the default behavior if not passed?


I don't think this is quite right. I think you need to use the 3-arg version.


КОМБИНИРОВАНИЕ ВЫЧИСЛИТЕЛЬН**ЫЙ** ЭФФЕКТОВ


better change the function name, since it could be misleading.


rax retry tests


It's handled as a default case ->
```
arg32->ret = TEEC_ERROR_COMMUNICATION;
arg32->ret_origin = TEEC_ORIGIN_COMMS;
```

we could've handled it as the `TEESMC_RETURN_EBUSY` case instead, but then we could end up with the process blocked forever in the driver.


Here's the scenario I see:

In both hat A and hat B a user wants to log into Facebook.  E.g., in each case there's a service that uses Facebook logins.  The user logs in on hat A.  Now on hat B, the user invokes the Facebook login, gets the login page.  If saved passwords are automatically sync'd, then the login information is auto-filled, or if there is multiple accounts there is some option to select the account (I guess currently that's just when you start to type the other username).

By hitting "login" the user has opted in to importing the login to hat B.  If they want to use a different account, it's also quite easy to do so.  We aren't sharing cookies or anything, so they will have to log in on each hat.  If you didn't even want the user of hat B to know the login you used on hat A or have it available, then this wouldn't work – but I'm assuming that it's the "same" person using all the instances, and you'd still use Private Mode if you want to have that kind of protection.


Include links to http://producingoss.com/en/setting-tone.html, http://producingoss.com/en/difficult-people.html, http://producingoss.com/en/common-pitfalls.html, and to producingoss.com more generally.


correct typo


@tonghuix 不太明白什么意思，我这个翻译这章之前并没有人翻译；ProGit 第一版并没有参考，参考的话是需要等到我翻译计划的 version 2 里执行。


Took me a couple of reads to understand (?) this point.


Yes :+1:. The way it is right now, you tell cmake that the whole directory should be used to search for header files, even though the source files are in the same folder. Usually this shouldn't cause any trouble, but it is better style if these folders are separate. If the separation causes any trouble, leave it as is though (my point of view).
Thanks!


@pitr-ch this is the kind of caching we need to add for all metaprogramming operations


This commit LGTM


The thing is that, if you call a link `world`, and then spawn the model to gazebo, it fixes it without even asking you.

I wish not that in general, since this is a matter of calibration: find where the robot is in the world. I'd avoid the link world.


Why give up on one and not the others? I think point-scoring can be policed as much as anything else.


Опять-таки вы очень легко ставите квантор всеобщности: общепринятый, признанные… Это плохо. И стилистически и без ссылок просто несостоятельно.


oops :)


this is a test file.


Please remove "on UpdateOrCreate"


`(58 <= 50) is False` Xuan! :rainbow: :octopus:


Yes, that is useful. Sorry I deleted somewhere.


values of ```disable_with``` should be proper. Here this button is use for saving and sending an email. So message should be ```Saving and Sending email```.
@AmitPatel-BoTreeConsulting & @SubhashShah-BTC - Please correct me/any suggestions?


This commit LGTM.


yes because @baccia made some modifications to them that are not yet into blacklight; we should make a pull req but we will still need to wait


lgtm


That just means that the line is temporary and needs to be deleted or altered before merging.


определён статически и закодирова**л**


By convention, this method should be named `test_topic`.


Actually I think the test name should end with "on create" instead, to make it clear that it is exercising the case when a new record is created, as opposed to updating an existing record.

Could you please add a test for the update case too? "triggers `persist` hook on update"


XD


Conclusion: yes, there's a cost to doing this - it takes time to police, and to socialize people, and rules of any kind may drive some people away.  But *not* having or enforcing rules drives people away too, in greater numbers and with less justice, and the cost of not policing or socializing people is, in the long run, far less than the reward of giving everyone a real voice.


Cause I want to seperate dispatcher and judge VM into two PR.


Use ```width``` instead of ``` ```


A weird combination of PubSubHubbub (!), some unexpected infrastructure
conflict issues with the ansible code that meant our servers weren't
properly updating, and a default configuration change at Amazon's end. Kind
of thorny.

On Tue, Jun 9, 2015 at 2:35 AM, Marcus Povey <notifications@github.com>
wrote:

> What was the issue?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/idno/Known/commit/c490e85584bc9a3ebe663b5b4b442ad7dca5bef2#commitcomment-11584279>
> .
>

--
Ben Werdmuller
<http://goog_1933028737>
benwerd.com | werd.io

+1 (312) 488-9373


Thank you very much for this Martin! (just in time before wicket-6.20.0 cutoff ;) )


lol


Arrrgghhhh - it must be -DHAVE_IMX_API=1 and - of course - -DHAVE_RPI_API=1


else if ( ($2 == ib) || ($2 == IB) ) then


It was my intent to make this very reusable for chord generation.
I did look very briefly st linked staffs fut didn't understand the code.

I will take another look.
The questions of the user interface, the determination of the destination
staff, the function to insert notes, and the function to calculate which
notes to add are 4 different issues in my mind. In my first try I was
primarily interested in #4 of that list of tasks.
On Jun 9, 2015 6:05 PM, "Berteh" <notifications@github.com> wrote:

> Hello Jim.
> I want to implement a similar functionality on "common" chords annotations
> (actually a Harmony in MuseScore jargon)
> Did you have a look at linked staves to keep some kind of link between the
> source annotation (FB or Harmony) and the generated notes... eg to
> update/remove the later when the former is modified?
> B.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/musescore/MuseScore/commit/dbebb61a1ca2fc6a9bd25b526e077dcf02276a60#commitcomment-11592427>
> .
>


Except for the testcase method name quibble, this commit LGTM.


Do you mean another drive letter? Try running `wmic logicaldisk get caption` at run-time (see http://superuser.com/questions/139899/see-available-drives-from-windows-cli).


This commit LGTM (I ~~guess~~see we are updating regression tests later).


Final thought.  Is there any mechanism to handle UI related dependencies?  Specifically scripts and stylesheets have their own dependencies and need a mechanism to prevent multiple loading - specially jQuery versions.


You can also use some environment variables, like `%WINDOWS%` or `%HOME%` (IIRC)


1) Remove ```.span_display_align```. Use bootstrap class ```pull-right```
2) Remove related css from custom.css


This commit LGTM. That edge case, if triggered, would presumably be an error on the back-end API.


Сокращения типа «и т.п.» обычно не допускаются в научных работах на русском (несмотря на латинское etc. в английском). Лучше заменить на «и тому подобное».


I meant something like C:\Windows


This commit LGTM


Ideally in the future we could make addData.filePriorities hold boost::uint8_t instead, so we can just do: QVector::toStdVector().


Needs to change


needs to change, also would call this "apiserver(ready)":


TeamCity YaccConstructor :: YC.Core General Build [Build 438](http://teamcity.codebetter.com/viewLog.html?buildId=192945&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


Давайте тут авторитет заменим на сущность? То, что она глобальная и внешняя уже делает её авторитетной :)


Thanks, it worked, made some other changes too


You're right, I'll fix.


why nullable ?


You know what? next time you need insight/help/coffee please do not look my way.


@fishcakez, there is a problem with `Logger.add_backend/2`.
We can't use this function as it translates to
```elixir
GenEvent.add_handler(Logger, Logger.Config.translate_backend(backend), backend)
```
and thus we gonna receive backend module itself here.


We should just make it non-optional in the signature then (and let the interpreter raise a `TypeError`).


Ну, авторитет ладно, но сом тут причём? Аторитет любит рыбу?


Necesite tocar "procesos/inscriptos.php". Agregue campo "fecha_pago" al JSON.


Maybe `APPVEYOR_BUILD_FOLDER` then? It seems to be the only [documented AppVeyor env var](http://www.appveyor.com/docs/environment-variables) that points to a path.


TeamCity YaccConstructor :: YC.Core General Build [Build 438](http://teamcity.codebetter.com/viewLog.html?buildId=192945&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: Error during Nuget update. ..\tools\Build.Tools\NuGet\NuGet.exe install "Z:\Builds\work\4138ce7c6332a78c\src\FsYARD\packages.config" -OutputDirectory "..\src\packages" -ConfigFile "..\src\NuGet.config"   at FSI_0002.Packaging.restor... Build time: 00:02:18


additionally the cost may be/is balanced out by the increased diversity in contributors (and thus thoughts/opinions/support/development).

Ideally also once the initial moderation process is bootstrapped the community will be capable of policing/filtering itself.


文言などを修正。未確定事項は、未確定事項として記述した。リンクを修正した。


I think we can have something like this:
```elixir
def init(__MODULE__) do
  init({nil, []})
end
```


I suppose that it's a common convention to use ```get{Name}``` instead of ```get()``` to allow a class to implements multiple Holder interfaces ?


Yes; the change it reverted was the unintentional one.


I wonder if this is safe...
filePriorities will be destoyed at the end of the function.
However, since I intend to drop support of 0.16.x for v3.3.0 this is low prio.


The two settings (defined in `elas.h`) differ for few parameters, among which `add_corners`, to consider or not the corners in the computation of the disparity map, and `ipol_gap_width`, which is set to 3000 in "ROBOTICS" and to 3 in "MIDDLEBURY" and is the radius (in pixel) of the interpolation of the disparity values found in the key points. If it's low, the map is full of black holes and looks more similar to the usual one provided by SGBM. If it's too high, the map starts to be full of horizontal lines because the disparity is extended to almost all pixels in a row. I chose the "MIDDLEBURY" but then I removed the corners and set `ipol_gap_width` to 40, an empirical value found by trial and test on our robot. I think that this can be something that could be tested individually, given that the `elasWrapper` provides an interface to do that. If you believe it's useful, we can improve the interface to add the possibility of tuning these and maybe also others parameters.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1162 of 1162 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Sure, should I create a new PR with this commit only?


Planets on F7 disappear quite a lot. I load a game on G5, then set a course to a distant planet. I set the ANA to least jumps. Check F7, all good. All planets on route shown. Then switch to quickest route. Switch to F7. Sometimes a planet or two of the route do not appear. Launch, once in space go F7. There is a very good chance that many planets on the route are now gone from the info screen. Sometimes, after toying with it a bit, it seems to fix itself, but it is remarkably easy to get it to "lose" a okabet or two on the info screen. Tested with 64 and 32 bit Windows )7/Vista respectively) and Intel and NVidia graphics.


А можно было бы что-то про копроизведение в первой части написать? В смысле определение и пример в конкретной категории, например, множеств, чтобы было видно, что это обычное размеченное произведение? Такого рода простые примеры к теме копроизведение есть почти в любой книге по теоркату.


Может быть переведённый? Наверное, вы аутсорсили эту часть текста в Африку?


Not sure I understand the 'That file is currently not available any more'. It still exists. You need the doctype to maintain a valid document


test


looks good it will be merged to the code collective!


Подмечается замените, если можно.


was it broken?


OK - maybe I didn't update composer or clear cache or something.  As long as when you are done this test runs then we are in good shape.


Другое важным отличие. ШТОАААА?!


do we need util.format here? otherwise %s appear in the output as it is.


@tapmodo I am having the same issue as @maxiruani, the project needs a new release so the bower.json file is created properly.


Where will this memory be freed?


The data seed will always run with fixtures or another sqlite always updating service.  So you can assume that whatever we choose the DB will be seeded with fixtures and only the fixtures for every test section.


Here you can use `var` as well


with grey


The length of "req->headers" should be checked so that buf[2048] doesn't overflow without warning.


Are type arguments needed both times here and in JVM index supertypes?


were we able to test this commands? any server error that we need to follow up with server team?


Please remove this comment from subclasses :)


The constant seems oddly named, from what I can tell from the code I've just glanced at its the number attempts to make a filename for the blob. I think it should be renamed to something more in keeping with it's use


I like the `secure` field, and `secure_sent` is a good catch.
Could you check the size of `headers` somehow?


Ok


rax retry tests


This commit LGTM


будет рассмотрены


This commit LGTM.


Собственно, вот этот коммит и есть самая крупная правка форматирования.


I'm unsure if its wise to allow adding a `:capture` backend directly
because it will just collect all the logs forever. Do we even need to
document its existence? If not we can document the application env in
`Logger.CaptureLog`. What do you think? Your suggested work around seems
fine though if you want that feature.

On 9 June 2015 at 17:19, Aleksei Magusev <notifications@github.com> wrote:

> I think we can have something like this:
>
> def init(__MODULE__) do
>   init({nil, []})end
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elixir-lang/elixir/commit/ab278831fecf52e2ed14a8a93c0ec0f6f18bcb00#commitcomment-11592727>
> .
>


Wait, what are you doing @scottkellum? This does not work.


crossWithHuge is a bad idea here, because Flink thinks that input would be small and broadcast it


Yes. 1.8.1+ support, thank you!


Also, this is a dumb way of adding support for new domains. Filed #19 to address this.


Can you add a unit test and an explanation to the README.

Also not sure about the variable name `loose` - maybe `usageNotRequired`? Or `usageRequired` and default to true?


The RPC call itself is called `Mutate`, it's fine with me if you'd prefer to call it `Mutation` though. I think `Mutate` makes slightly more sense though.
Mutate: to change; alter
Mutation: the act or process of changing


I don't think this should be at the warning level, maybe info or debug


Oh I see how it happens in the success case (when you call `g_variant_new_from_data`), but I think it will end up leaked in the error paths.


```<h2>```? Sería mas bien un párrafo, no?


Great, thank you!


Great commit, keep up the good work


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.261](http://teamcity.monogame.net/viewLog.html?buildId=8198&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:26:04


My bad, the tests broke because of a backbone update and I was going to get them running again before publishing. Fixing now.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16030/testReport/) for this commit**


why are you specifying the error types twice? (here and in ModelDrivenForms component)


@melvin, when you review this one, please check it carefully, I'm not 100% sure about it. I tried to do it with APNAP but it was working strangely, so I opted to do it this way. It should be simultaneous for both players, I can't think of a problematic situation right now, but it could definitely exist. Then again I think there are many things that should be simultaneous that are being done this way for the time being, so it could be OK. Anyway, I'm not sure about anything, so please review when you can. Thanks!


Адавайте напишем: излжоением первого раздела статьи [..] и приводится здесь для удобства последующего изложения?


After a quick discussion with Marc Sabatella linked staves should not be considered for this purpose, as they constraint their content to be the same as the source staff... that is not the case between melody and realized chords.

do you plan to work on a UI for this?   item 4 is indeed done for you, well done!


That assumes the data seed will always return static data and not use
something like Faker no? So it ties to a specific implementation?

--
*Victor Passapera*
*Software Architect*

On Tue, Jun 9, 2015 at 9:24 AM, Jonathan Johnson <notifications@github.com>
wrote:

> The data seed will always run with fixtures or another sqlite always
> updating service. So you can assume that whatever we choose the DB will be
> seeded with fixtures and only the fixtures for every test section.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ilios/ilios/commit/2ebd7510b15237250bec321800228a4faa315dd5#commitcomment-11592818>
> .
>


it is better to compare the difference between the perplexity of the last iteration with the current calculated perplexity, because if this delta doesn't change, we won't come closer. This saves a lot of iterations


@nickihm is this up on the web server?


This is bad.
Sorry about that.
Both tests now pass locally


I've also added this:
```
+        "org.apache.http.NoHttpResponseException": 32,
+        "java.io.InterruptedIOException": 32,


Я рекомендую имена писать так: Имя Фамилия (Name Surname).


I'm guessing that this is just a PoC. Otherwise this should come from an external definition, just like what we do with ng-messages in v1. no?


I don't really care for the clash between using `client.topic(...)` and instantiating `pubsub.Subscription` directly.  I think we should either drop `client.topic` (or at least not document it here), or else add a `Topic.subscription` factory and use it here.


едиснтвенным — ой, вы даже не пробежались спелл-чекреом? Тогда я на сегодня заканчиваю ;)


Un ```<form>``` ha de tener siempre un atributo ```action```


Comment out require, it is forcing eager evaluation


Also, the if block says !LEGACY_APIS_ENABLED, yet this is a call to a legacy endpoint, the new API would look more like:
/json/users?_action=idFromSession // to get the username
/json/users/<username>?_fields=uid //btw why is uid hardcoded in the attributenames parameter, and why isn't it hardcoded when retrieving it from the response?


I wonder if the message queue should be a separate service, not that it's anything to do with me of course... but I might do it that way in a hosted so that this sort of thing wouldn't bubble up to the front end, and messages could be retried.

IIRC there was a ticket for a message queue system somewhere.


I wouldn't guess that the root 'Ad Hoc Groups' group needs to be managed in this interface itself.


Personally, I see no point in having `:capture` backend as true Logger backend, and what makes answer easier is the fact that there is no public API to get its state. Let's go with application env doc in the `Logger.CaptureLog` then.


@tseaver This was suggested by @jgeewax and I also agreed with it.


See above.


@HugoGiraudel just poking around, well aware it’s incomplete and it’s reverted now.


It looks to me that this block is wrong; `error` is a `GError **` and it will always be `!= NULL`, even if an error happened. What should be checked is `(*error) != NULL`, but since the error double pointer is passed into the function, and could be `NULL`, you might end up crashing the application.
I suggest using a local `GError *` and then using `g_propagate_error()` when returning out of the function.


El ```<input>```debería llevar un  ```<label>```asociado


Remove this lazy as the kinesisClient isn't getting serialized in a bad way


This is a good question: I don't have an answer. @JoelKatz?


If it ain't broke, don't fix it!


[새 댓글 달기] 버튼 클릭시 아래와 같이 처리가 됩니다.
ImproperlyConfigured at /blog/5/comments/new/
TemplateResponseMixin requires either a definition of 'template_name' or an implementation of 'get_template_names()'

뭐가 문제일까요?


You can't send just an attribute update - from an API call perspective, attributes are relatively meaningless by themselves. AttributeDefinitions are primarily required when creating new indexes via the API so as a result they are actually sent during creation and in the GSI update logic [here](https://github.com/johnewart/terraform/commit/f458521be9fd630257d17ecb9af03f53d31995dd#diff-95faf2d593168e51c15a1a500b90b028R349).

The only way to "remove" an attribute from a table is to delete all data in that attribute, "adding" attributes is done by creating an index. The attributes definition in the definitions provide a consistent way to look at the attributes as a human. I had thought about only putting attribute type definition in the GSI / LSI descriptions but it would require duplicate name/type data when referring to the same key in multiple indexes so it seems to make more sense to keep them.


@abonas @simon3z
Not final, but a step in the right direction


Any idea why this is so carefully guarded?


Nice man, that is a very creative syntax :D
I've added the `cells` code manually in a new commit.
Cheers dude


You're ahead of me in this effort, so you might be seeing something I don't yet... but I would expect that the only groups that should pass through this method are PAGS groups with exactly 1 testGroup.


Good catch, didn't notice that!


maybe better would be something like ```#define AHB_CLK STM32_HCLK``` because the AHB clock can vary depending on your settings (see https://github.com/mabl/ChibiOS/blob/1804611c43765b6d7328448d7b60cf165de6ed16/os/hal/platforms/STM32F4xx/hal_lld.h#L1425).


* TODO: rewrite this as it is doing way too much and is very messy now


// FIXME: Handle this situation as it is then unclear what went wrong


-n is used twice here


* TODO: refactor these 2 functions


It seems no, because one file can contain two or more metadata sections, some of them with valid ABI version, and the others with invalid ABI.


It will be removed.


This is an add command so --quiet is not required


They didn't either in their implementation ;)


remove WhiteSpace


fixes #31


rename url to urlString


You told me that this sig was wrong, but you didn't fix it.


The addition of parentGroup here (throughout this method) is a really good change.  I'm beginning to wonder if the additional 'Ad Hoc Groups' group is really adding anything of value.  Let's ping James on this point, but I'm leaning toward just removing it.


please use --frontend-ip-name, sorry if i named this like 'fontend-ip' in design doc


Ja fast känns som att det går emot att vi använder angular. Vill man sätta cookie eller annat så borde man ju göra ett AJAX request via Angular.


References: https://github.com/exceptionless/Exceptionless.Net/issues/11


1670-HeatPumpWaterHeater (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2124 of 2214 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-95.93%25-yellow.svg)


frontend-port-name


Given that we _will_ be doing etags in 4.1.  A 412 indicates conflict when If-Matches.

A 409 to my mind is only when the server is erroring without the If-Matches header. I don't have a problem adding it.

A second bullet should be added to indicate that a 409 is only allowed when If-Matches is NOT provided (use 412 instead). A 409 indicates the server has detected a conflict and can NEVER proceed with the data as submitted.


"True" or "true" both work.  Boolean is case insensitive.
http://docs.oracle.com/javase/7/docs/api/java/lang/Boolean.html#valueOf%28java.lang.String%29

But I am not totally sure why I changed it.


You forgot to break this.


Ah, I was looking for something like that, but couldn't find it...
I guess it would be best to replace AHB_CLK with STM32_HCLK in arch/chibios/sys_time_arch.c then (so we don't need that define at all), right?
@gautierhattenberger any objections?


remove space after { and before } here and below


drom -> from


remove extra space line


:+1:

Some tools provide very handy auto-complete and error information if you include good jsdocs. I'm sure there's even a Sublime plugin for it :smile:.


add space before ||


When all the ad hoc groups would live under a well known parent, I thought there was a need to also create branches that were managed via the this UI. I imagined a root like 'Ad Hoc Groups' and children named 'District 1 Ad Hoc Groups', etc. Then tenant admins could create further groups for organizing the actual ad hoc groups that had the tests. We can certainly live without it and have the super-admins handle creation of any needed hierarchy.


It will be good to also monitor the size of `metadataWaitingQueue`.


line's too long


It would be nice to have this separation.


A better name is frontIpName instead of settingsName


maybe you wanted to name it "getOwner"?


I just noticed in another	context:

In the definition of the `GlyphSet` the last line should be:
```js
return GlyphSet;
```

I forgot this.


Looks great ! .. Good job :D


I also agree that the well known group is no longer needed. As long as we have a way to identify ad hoc groups (see email for change request), we can intersperse them anywhere.


fatal?


hm.. probably better keep AHB_CLK? as it would be nicer to not have stm32 specific parts in arch/chibios...


please, ignore the tab issues, i will fix all of them when i finish the import.


please fix this giving them their respective properties


This doesn't make sense, this function doesn't have ID


Even if it could be helpful to tune any single parameter, I'm pretty sure the settings @GiuliaP chose are fine in our context. I would give a go to this then. Later, we can rethink about it.


This too.


check for isNaN(id)


So here's a wrinkle -- probably you should be able to create one of these as a child of another PAGS group _OR_ a database group.  That won't work at present... maybe that's something I can tackle and add today.


Hydra Hatchling fix


Hi, I don't see what I posted last night.  This site looks different on my office computer than on my laptop.  So I may be repeating myself.   I don't see that the license for the medical card is lifetime now.   Could you at least make it 4 years like our drivers licenses.   I could see them hitting us for a fee every year to stick it to us.   Also, I saw in a draft that we would have temp licenses for out of state card holders.   That appears to be gone now.   How about we have a clause that honors out of state  card holders if they are not Oklahoma residents, but they have to get a Oklahoma card if they become a resident.


OK.


I would suggest to raise an issue for this, we ought to handle SSL better.


Makes sense! Thanks for the explanation.


Or even better, can we go for "ROBOTICS" but then stick to the empirical values you found out, @GiuliaP, unless there are other things preventing this? At least we make clear that we work with ... robots :smirk:


TeamCity YaccConstructor :: YC.Core General Build [Build 439](http://teamcity.codebetter.com/viewLog.html?buildId=192948&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


1670-HeatPumpWaterHeater (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I missed one :) (change 'f' to 'p')


i think i wanted to be it like "&.*;". But i also just like regex :)


Thanks for the patch!

I'm thinking about including your changes as a separate file in `syntax/tex_conceal.vim`, and then including it via `runtime syntax/tex_conceal.vim`. What do you think?

Alternately I can leave it in the way it is. But given how large (and independent) the change is, it might make sense to include it as a separate file.

GI


I know it is only two tests, but shouldn't this be extracted to a function as before?


move 40 as a constant with the clear name


TeamCity YaccConstructor :: YC.Core General Build [Build 439](http://teamcity.codebetter.com/viewLog.html?buildId=192948&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: Error during Nuget update. ..\tools\Build.Tools\NuGet\NuGet.exe install "Z:\Builds\work\4138ce7c6332a78c\src\FsYARD\packages.config" -OutputDirectory "..\src\packages" -ConfigFile "..\src\NuGet.config"   at FSI_0002.Packaging.restor... Build time: 00:01:36


can we avoid the 'else'?

 if (options.frontendIp) {
   if (!utils.findFirstCaseIgnore(config.frontendIPConfigurations, {name: options.frontendIp})) {
     throw new Error(util.format($('Frontend ip with name "%s" not found for an application gateway "%s'), options.frontendIp, gatewayName));
  }
  httpListener.frontendIP = options.frontendIP;
 }


We're only taking one position, so there's no need to remove more than one. I think.


why do you compose validators like this?

it feels dirty to monkey-patch the control and also this gives you very little power to control the order in which validators run.


@jacksontj We are working on our returner to do this (`local_cache` returner doesn't matche our needs).
I was able to hack what we need using `return` in `/etc/salt/minion` and `ext_job_cache` in `/etc/salt/master` and `/etc/salt/minion` and scheduler + my own returner ;)

The only problem with this is… `return` in `/etc/salt/minion` is undocumented… but as I saw if source code it should works (and it probably worked since always).
I guessed it from `salt-call --return myreturner state.highstate`, and code says that salt-call loads `/etc/salt/minion` to load config, and then parse commandline arguments to apply cli config (that's why `return` in minion config it works).

I just want to be sure this will be documented and will work later too…


wrong syntax. read more about matchers


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16031/testReport/) for this commit**


IMHO it is probably slightly valuable to have a parent for ad-hoc groups.  It would make finding them much easier, possibly for re-use but also for general administration questions (how many PAGS groups do we have, what are they and to help answer what are we doing with them, etc.). It keeps options open for the future.  Plus when creating normal PAGS groups I see the UI specifying a parent there as well (PAGS Root) so I see it as consistent.


please refer above, we can remove the unnecessary else


<iframe src="https://onedrive.live.com/embed?cid=1E851383E18FC9EF&resid=1e851383e18fc9ef%21522&authkey=AEN1WFS9DCSoiPo" width="98" height="120" frameborder="0" scrolling="no"></iframe>


Message should contain e.getMessage. ERROR is not saying to user good info


Ah. Okay. :x


Agree with Peter, it should be an option. The only reason it was left like that was lack of time


but it's not justified include re library and make things more complex just because you like regex :smile:


we have four GPUs per host, and with `initQuda(0);` this will not work. On our cluster the automatically chosen device numbers works like a charm, also in scalar build. In fact, in the queuing system we do not directly have access to the device number before hand.

The `InitGPU` thing allows to set the GPU device number, and also the automatic mode.


initialize it in cycle


toString call without checking null


Hallo


The writer that "causes" the error not seeing it is a problem. I just removed this behavior with the separate thread and channels and replaced it with a mutex around the write function. I think this is conceptually simpler, and will actually have the synchronous behavior we want.


can we avoid else in line 419 and the if block in 423 altogether by using:

```bash
if (utils.findFirstCaseIgnore(config.httpListeners, {name: httpListenerName})) {
  throw new Error(util.format($('An http listener with name "%s" already exists for an application gateway "%s"'), httpListenerName, gatewayName))
}
```


wrong usage of legth


You can also remove unused methods: `attr_name_or_map`


Damn man that's pretty rude. Ive cooperated with all of your requests and also routinely promote your work and server all over the web.  Often in the past you've come off as pompous and rude, especially when I offer advice and/or ask for help, which I've ignored.  I don't appreciate how passive aggressive you are on a consistent basis with your comments, just come out and ask politely and I'll comply or help when I can.  Its pretty childish to end a relationship with a community as small as ours (BECTI).  I've been very cordial with you for a while, my hesitation with your requests are typically a response in HOW you ask.  Act like a professional and I'll have no problem editing out  things you don't like.


Hi Invite me alatis
:)


we could either have a method on the control that adds a validator or could we use DI get hold of all the validators specified on the current element and provide the list to the control constructor?


yup, have already done


due to the above refactoring, we can just declare 'httpListener ' here only


I am not sure, but I don't know how to avoid using type argument both times in that case.


Is there a prettier way to build these links?


shouldn't it be `p_stddev.c`?


<!DOCTYPE html>

		<meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
		<title>Sneaky Snake!!</title>
		<meta name="author" content="Kevin L. Spohn">

		<link rel="stylesheet" href="../css/vendor/normalize.css">
		<link rel="stylesheet" href="css/styles.css" />

<canvas id="screen" width="400" height="400">Canvas not working!</canvas>

			<select id="speed">
				<option value="slow">Slow</option>
				<option value="medium">Medium</option>
				<option value="fast">Fast</option>
				<option value="super">Super Duper Fast</option>
				<option value="dontDoIt">Don't Do It!</option>
			</select>
			<button onclick="game()">Go</button>

High Scores

				 -

				 -

				 -

				 -

				 -


HTML File


I'm not sure about the 2nd sentence added to this comment.  Maybe just "Changes to name or parent are not supported."


@miminar what do you think?


Is the restriction of all PAGS groups under PAGS Root a technical issue or more of convention?


The generic name could come with informative comments, at least in the beginning of the chain (np.load). Subsequent changes (removing encapsulation, changing data format, etc) I am involved on [data analysis](https://github.com/cpicanco/validation_project/blob/master/python_scripts/data_pool.py#L660)(needs a lot of stylistic improvements and separate the issues) right now, and while importing the data I was thinking in pull request with some refactoring suggestion.  But I think ask you in the first place is the best.


@willmtemple You need to update the man page.
Just add docker.io


please refer CMT1


please refer CMT2


Again -- are we really going to manage any empty groups (w/o a testGroup) through this method?


@jtnord maybe put this question to meeting?


Class RedirectIfAuthenticated does not have a Docblock comment.


Class VerifyCsrfToken does not have a Docblock comment.


Class EncryptCookies does not have a Docblock comment.


Class Authenticate does not have a Docblock comment.


good catch on needing this; I'd prefer it if we just pass some initial state into the `ExpandoLink` constructor and handle this within the `initialize` method, i.e.

```
new ExpandoLink({
  el: $thing[0],
  expanded: true,
});
```

and then in the `initialize`, something like:

```
if (this.options.expanded) {
  this.expand();
}
```


Use strcpy_trunc() which is defined in GNU.h, microsoft warnings don't lie about unsafety but *_s functions are not portable.


* TODO: rewrite this as it is doing way too much and is very messy now


// FIXME: Handle this situation as it is then unclear what went wrong


* TODO: refactor these 2 functions


I did.


So where do i go to accept it ?


@mandric, I don't think we need to push a build just for this, but please include this in the next Release build. Thanks.


...`[\*+`...will do ;)


These 2 look like legacy APIs to me, they might be deprecated later in OpenAM


Hey, @ArcticLight, since it turned out that the ScalaTest plugin _wasn't_ the cause of the CI issues, can we switch back to it, please?

The ScalaTest default runner reports test output much nicer than JUnit does – when a ScalaTest `Matcher` fails, JUnit doesn't show ScalaTest's nice report that tells you what the matcher expected and what it got. Also, I think that the way ScalaTest prints out the test of the spec is much prettier, and it tells you what tests have failed before the whole suite finishes executing, which is nice (considering that our test suite now takes a non-trivial amount of time to run).

It would mean we wouldn't be able to collect JaCoCo coverage, but it seems like [that's okay with you](https://github.com/MeteorCode/Pathway/issues/28#issuecomment-108148928).


if (_.isEmpty(list) || _.isEmpty(attributes)) { ..

will this work?


It says no unread nofications and when i click that i con i have no invites .


Oops, my bad.


On the top of your page you should see a box-like icon. Click it.


You're referring to about 4 lines of code here, two of which are inside a loop in the second case. Not worth it IMHO


Never mind that. Idk then.


Thanks!


Some of the OT APIs have a `remove` method on them. Won't this remove any context that has that method mixed in from [here](https://github.com/ottypes/text/blob/9ef1309a7ea4bf194fd8161e197eef7edc4f7dbd/lib/api.js#L34), for example?


Where do i go to accept it ?????


I was looking at this line... I just had a student that got an error because of this line because he didn't append the float 'f' after 5, and so Java performed integer division (which forgets about the remainder and rounds down) and so had problems with this assignment. I guess if you saw the congratulations message, everything is good! My apologies.


Class RedirectIfAuthenticated does not have a Docblock comment.


I found it man :)


Class VerifyCsrfToken does not have a Docblock comment.


Class EncryptCookies does not have a Docblock comment.


Class Authenticate does not have a Docblock comment.


This function does not allow removing cards from the deck once they have been pulled. Therefore the same card can be pulled twice.


Yay!


would prefer that this be called something like ShellCommands instead of MafiaMain because it seems confusing compared to like GameManagement.java, as that one functions more like a main


Making this method public gives me a bad feeling.  This method is only necessary (iirc) because the DAO improperly returns a Set< IPersonAttributesGroupDefinition> when it should simply return a (single) IPersonAttributesGroupDefinition (or null).


Invite me again pls


Okay.


This function allows the same card to be pulled twice unlike a actual deck.


Would the post increment make number return before incrementing?


When you copy pointer, you don't copy underlying data. And the function has wrong definition, it must be
`vm::ptr<const CellSailSoundAdapterFuncs> pCallbacks`


@sroegner If you can make a PR which the rest of us can review from now on that would be great. We're requesting everyone does that to keep the commits to master to a minimum since it can create problems when everyone is doing so.


Il faut ajouter un z à "déplacer"


Ii joined :)


Yes!


In Java, what do we normally reserve all cap variables with underscores for? Are those to be used with normal ints?


"as the fingerprint"


What do we do on here ?


Have you hosted this anywhere ?


This one is strange, you could just define `pSelf->arg` as `vm::ptr<u32>` and simply copy its value: `pSelf->arg = pArg;`


I'm trying to get some more quality graphic designers and programmers.


Ajouter un "z" au lieu du "r" à "déplacer"


This is up as 7.0.1


So do we just chat on here ?


Sawy, I removed this string because the story body is no longer a "description", but a full article. Plus, I removed the placeholder attribute from the body input control.


What do you mean?


thanks for reporting


Trying to grok all this from GitHub is hard. I will need time to load this in a project. Is this Java 8 syntax? If so guess you will be edumacating me about some of the syntax.

Are you writing out to Excel? I am not sure why you have all those formatting statements in your output.


Oh so is this an company?


:+1: from my end


So what do we do on GitHub ???


We should always use `on` to bind parameter values to queries. Technically, there isn't a risk of SQL injection here because `id` must be numeric, but we should always follow that practice. e.g.

```
SQL("SELECT * FROM books WHERE id = {id}")
    .on("id" -> id)
    .as(parser.singleOpt)
```


Commit 3


Cachhupin yes


Alatis lets get proffesional people and not let aanyone join


To Cachhupin: Yes, it is.


Oh go ahead and merge. Did you include sample xls(x) files in the repo? Can't see from here. If not then I will file an issue


To XxForcexX: Yep.


is this check backwards? shouldn't it be

```
if (e.target.tagName !== 'DIV') {
  return;
}
```

also, the same check here would work above, right?  if so, maybe we could pull this out into a function, e.g.

```
function isResExpando(elem) {
  // temporary fix for RES http://redd.it/392zol
  return elem.tagName !== 'DIV';
}
```

then we could replace both checks with:

```
if (isResExpando(e.target)) { return; }
```


What do we do here ?


uhhhh doctor and vigilante look OK, get @HarrisLin to QA them too after you submit a new pull request! ty


I think that GitHub is sort of a coding website for HTML and such, so I'm testing it out.


Oh xD I didnt know. GitHibs a website where you can share code with each other while working on it- e.g., my company, ShadowBox is working on a HTML website, so we can all work on it.


Thats what I've been told xD


Where do we got to  do code ?


Hey how do u do code ???


Something I haven't mentioned yet would be that we typically don't use `return` in Scala. The return value of a method is the last expression within the method body. So normally we shouldn't assign the `result` to a val at all, and we could then remove `return result`. e.g.
```
def create(book: Book): Option[Book] = {
    DB.withConnection { implicit c =>
        SQL("INSERT INTO books(title, author, meta) values ({title}, {author}, {meta})")
            .on(
                  "title" -> book.title,
                  "author" -> book.author,
                  "meta" -> book.meta
              ).executeInsert()
              .map(id => book.copy(id = Some(id)))
     }
}
```


With pull requests, I think.


I dont know :( Ik HTML but Furious- is the expert from my company.


Looking good. One tiny thing however: All of JOML uses 4 spaces instead of tabulators.
If you can change that in your code to conform to that, I'd be glad!


[SRC_URI += "http://downloads.formuler.info/linux-${PV}.tar.gz \]   unfortunately this url is not working


f


Oh ok- slow internet


I know HTML and CSS too.


Nice


The "more valid patch" worked for APNs connections but caused some odd side effects in other uses of SSL.

Why is _this_ patch "unsafe"?  I'd really like to get my head around the risks.


In this block I see the use of OPENAM_SESSION_VALIDATION which I would consider a Legacy API, that's why it was considered to use the OPENAM_SESSION_URI instead of the OPENAM_SESSION_VALIDATION even when it would be easier to use it.


I really like this instant chat thing.


Scratch should totally adopt it.


The disappearing planets is probably the texture caching/pregeneration not being fast enough. Since we disabled pre-generation because of crash problems (and it was never designed to cycle through planets that fast anyway) the planet textures might not be generated properly.

I did turn the miniature planet texture size down a bit to speed things up; possibly we also need to look at the texture cache size (which is currently hardcoded to start culling unused textures if >50 are loaded, which could probably be a fair bit larger on more powerful systems)


That makes a lot of sense. Just pushed a commit that does this.


Im relearning HTML because last time I did it was when I was 10 so Im using CodeAcademy


And that should be a thing


Whoops, didn't mean to commit this. No harm done, I suppose.


I always have to check my messages or refresh the page :/


I am using CodeAcademy too. (In fact, my other tab is CodeAcademy.)


hpwh_residential (nmerket) - x86_64-MacOS-10.9-clang: OK (1665 of 1672 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


I don't have to refresh. Odd.


Yes, this is what I was referring


I can see the reason for the rename, but bear in mind that this will mean OXPs wishing to be both 1.82 and 1.84 compatible will need to specify both entries, so we'll need to both document and announce this well in advance.


Really lol? Same


Yeah, I also have to relearn a bit.


+1 :)


'cipher' => MCRYPT_RIJNDAEL_128, // FIXME: See if we can update this to the recommended 'AES-256-CBC'


 yeah, this way
 - user loads one thing with two requests, thus allocating resources for each.
 - you'd do authentication in both, another overhead.
 - and its not a good design pattern, its just a sidebar with static UI, why load it using AJAX?


Cool


ok thats cool


This is<b>bold</b>.


Whoops.


I finished my HTML course and Im going through the CSS course


Omg, same here!


Serious :O


I'am learning C#


Another thing I haven't mentioned yet is that Scala has multi-line string literals, using triple quotes. So we can format this nicely using them:

```
SQL("""
    UPDATE books SET
    title = {title},
    author = {author},
    meta = {meta}
    WHERE id = {id}
""")...
```


yeah, but sidebar should not need authentication separately once its loaded directly via php


Italic, Bold, Normal.


Nice!


I believe we should do:
if use_efl
#include native_app_window_efl.h
#else // crosswalk aura-based impl
#include native_app_window_tizen.h
#endif


I'm also learning the iOS language.


Regarding Peter's comment about the uid, some logic need to be changed also if you want to allow users to be able to login with email address for example. This was something that needed some fixing. Maybe an additional option where we prompt the admins what is being used to add the users and what is the OpenAM using for authentication, etc


Theres an iOS language?


do we know why this is NULL?


dmrndk


Never knew that xD


I know a bit of c++ but do we have to program on scratch ??


Bold


Did you mean `options` here, or does `arguments` magically pass all parameters to the parent function?


r+ with comments


Furious used to be Sonicxspriter- He says he can easily convert a scratch file to Java- I could ask him to.


[frontend-port-name]


We could also avoid assigning to a val and using `return` by using a pattern match. (This is how we'd structure an update that returns `Option[A]`)
```
def update(book: Book): Option[Book] = {
    DB.withConnection { implicit c =>
        SQL("UPDATE ....")
            .on(...)
            .executeUpdate() match {
                case 0 => None
                case _ => Some(book)
            }
     }
}
```


OK.


What we gonna program on ???/


Correct. It's magic.


Nitpick: I like to lowercase the types in SQL. That's what mysqldump does, so we tend to do it that way.


Unless I can join 2 companies (Which idk is easy) I cant really have an opininion xD


This is a common design pattern for inheritance chains using JS prototypes.


Okay, I just went ahead and did it – ec1070e105d6973d09b1e5f74fedd0ba7c9782c1


Alatis what we gonna program on ???


Un ```<form>``` ha de tener siempre un atributo ```action```


Funny enough, I went to your profiles before chatting to ask whether you wanted to join ShadowBox xD


`n` should be initialized:
> If *n is non-zero, the application shall  ensure that *lineptr either points to an object of size at least *n bytes, or is a null pointer.
implies that `n` is being read.


Only meaningful thing that changed on Mono was turning off LLVM.. what's the error message?

cc @lethalman


the lat/long aren't a part of the form object, so you shouldn't be testing them here -- this is only for fields that are part of the form.


Why for testing?


It would be helpful with a jsdoc comment about this new variable, something like

```js
  /**
  * @param {Object} event the native scroll event coming from the scrollable parent.
  */
  _handleScroll: function() {
    ...
  }
```


Cool!


Is there a difference from what you have here and doing `this.props.onEnter(event)`?


`free(ret)`


Yeah, it is easy to convert a scratch project to java. Just zip the file then edit the json.


We could also potentially check that some other properties were parsed from the result set. Like the title, author, etc. We don't have to do it in *every* test, because it would be tedious, but one test checking the properties once would be good. When we get into more complicated models that have other models/lists of other models nested inside them, it becomes important to test that everything was mapped correctly.


You can join to organizations.


Alatis what we gonna program on scratch or where ???


I don't know what we are programing on yet.


OR maybe leave the parameter as mandatory to fill, instead of defining a default value. Leaving the wrong default might lead to problems for many people that do not understand cookies and domains.


Use HTML tags to make text <b>bold</b>.


http://hydra.nixos.org/build/22994852/log

```
* Assertion at tramp-amd64.c:1115, condition `code - buf <= tramp_size' not met
````


Falta el ```<label>``` asociado a este ```<input>```


<NICEE>


Don't believe you have to add HttpServletRequest to the method sig if you don't need it.


<Nice>


oops.. A SQUIRL!!


Cool


Like this: <.b>Bold<./b> With out the dots.


i = italic


<b>Bold</b>


U for underline


<u>Underline</u>


Typo, "appplication"...

BTW: There are also same typos in integration-cli/docker_cli_start_volume_driver_unix_test.go


I'm thinking there should be a Spring Security annotation here too.  (We should move all AuthZ to that framework, but REST APIs can implement it already.)


ok, will have a build out shortly because of the bugs reported today.


Surprisingly doesnt work, although on regular HTML it does :/


argh, you wiped out my fix


<.b>Bold<./b>


Without the dots.


When can this happen, if an empty string is 0?


Nitpick on style: I'd like multi-line stuff to look more like this (if wrapping is necessary):

```
val book = Book.empty.copy(
    id = Some(6L),
    title = "The Grapes of Wrath",
    author = "John Steinbeck",
    meta = 90990
)
 val result = Book.create(book)
result must beSome
```


Weird that the underline doesn't work...


Nice!


This is really weird, we have something similar for bcolz and it just works. :TM:


Ikr


Alatis lol i know what to do but i wanted to play around :8ball:


If we allow C++11 now (do we? @marinier @mazina @bazald ) why not use std::unordered_set for this.  You're just using it as a container to check against and not requiring any order for traversal (you're not even doing a traversal) so it's constant time insert/lookup vs log(n) now.  For large, successive, queries, might that matter?


Oh, okay.


I believe something in here broke the websocket interface. I now get json responses without the first key like `{:12345,"v.altitude":4567.23}`


<a = href "scratch.mit.edu"> Does links work? </a>


sorry :(


Yes


Apparently yes. xD


<b>Nice</b>


<a = href "http://www.codecademy.com/learn"> CODEACADEMY </a>


I will look for members :100:


Go here.


wtf


fixed, thanks!


Your profile?


Lol, yes.


Ok lol


I realize I'm late in reviewing this, but why was this removed?


Maybe coloured text?


These structs and functions are only used within DECAF. They are not supposed to be used by plugins. So they should be moved to DECAF_main_internal.h.


Nitpick: I would indent the `on` and `as` that follows `SQL`


this is genius. :+1:


I kind of doubt you can put CSS in.


Hmmm?


Nope


So whats the company name ?????/ SHall i make a studiou on scratch ????/


@thanhdut Test it. Test it with (). Consider `number + 1` which is much more simple to read - ie. refactor/maintain.


env is not used, so should be removed.


But Idk how to do colour correctly so it might not have worked xD


Nah. No studios yet. Company name: DragonCanister.


Should this be a usort?


Let me try the color.


I would offer to make a logo but thats entirely up to you.


I'm making one right now.


And colour the screen :D


Okay Alatis u make a studiuo like skybounds remember ???


This says "if the message equals false (0/false/emptystring) and it's not actually just the number 0, run"
so if message was empty and it WAS 0, it wouldn't run.


there is no meaningful update in this file. so should be removed from the request.


Are you able to reproduce? Builds fine for me locally on the pre-merge dotnet branch.


why 'form'?


if a line is commented out, just remove it from the source code.


@tchap Is there no way to make this generic? Looks like a lot of repetition.


It was added into the "DDF Settings" section at the top of the file.


Sounds good


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1671 of 1678 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Colour?


Wish that this API could be implemented without importing & leveraging code written for a specific portlet.  Ideally we split the logic out to a UI-agnostic service layer.  (Which, incidentally, would ideally handle permissions checking... which we can't do using Spring Security... catch 22.)

This approach ties the JSON expected by this URL to the AdHocPagsForm.  If we change the form, we may break this API.


Right -- it's only for testing that I changed it to public. I wanted a quick way to dump the group def object as json.


No estoy seguro de que has querido hacer con el ```<br>```  y el "-" pero semánticamente no tiene mucho sentido. Si sólo es decorativo, deberías intentar conseguir el mismo efecto con CSS


Okay. I've set my IDE to use spaces in place of tabulators.


Trying to do coloured text- Codeacademy doesnt like to teach you how to make it :/


Nice. The indentation of the file was off and now the `<div>`s are mismatched -- can we restore the second `</div>` (for `.container-fluid`), and fix the indentation for line 2 and the main content?


@oerdnj I created this repo for any side-effects from the main packaging work: additional scripts created, documentation, any notes, etc., and to use Github's comments on commits to discuss changes. This way I think we can keep a good record of the what, when, why, etc.


Interestingly enough, I've notice I get an email for every comment thats happened :/


lol


It's not in 1.82!  I just added chart_info_color and then decided to change it.


Ik it's annoying


Turn off emails in settings.


For me, that's sharing the Password Manager, rather than the passwords. Fixed accordingly.


`self._meta['players'].update(players)` ?


Yeah I should xD


Lol.


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The form did not have have all the details, like members. I wanted to see when members were added.


Just add back this space (' ').


My email sent me an email saying 'Turn off email in settings.' xD


rofl


Lol


hi


For now this is fine, but could you create an issue in GitHub to remove these attributes completely after this is merged?


Looking good!
Just two very minor comments.


say something


![screen shot 2015-06-09 at 10 44 05 am](https://cloud.githubusercontent.com/assets/12816699/8065155/7d86b76a-0e94-11e5-98d5-4efea2eabe05.png)


@tchap Okay, this looks weird. I read about the switch statements in the reference and am not sure what this code does.
I'd guess that it skips those reviewed/testing/etc. labels, in effect removing them. But in that case that's hell of a weird syntax...


For colored text.


With div or nah?


Must be in your CSS page.


Div.


Oh OK


![screen shot 2015-06-09 at 10 45 12 am](https://cloud.githubusercontent.com/assets/12816699/8065168/a0988490-0e94-11e5-8e20-5e0f3a6b078d.png)


Right. I use request to find the IPerson object for the user. There is the Principal object that can be directly passed into the methods, but I did not find time to investigate how to map Principal to IPerson for the permissions checks in the helper class. It would be great if we switched to something more standard.


Html is simple


Well i do it on visualstudious


My reading was that they are even more privileged than just white guys, they are tenured white guys.


Is there a reason we don't enable the container-based infrastructure too?


I had 83 mails cause of this thing lol


Yeah. I used to use Coda 2 but now I use CodeAcademy's function know as Codebit.


That's a lot. :P


1679-DualDuct (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2135 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.48%25-yellow.svg)


![7874](https://cloud.githubusercontent.com/assets/12785542/8065209/ea31e658-0ed7-11e5-861e-177ed5fcc191.png)
Someone randomly added me to their circles like whut xD


:lock:


Lol, wut?


Got it.


![screen shot 2015-06-09 at 10 47 46 am](https://cloud.githubusercontent.com/assets/12816699/8065231/fbd5f13a-0e94-11e5-8d34-49f73f8cfa1a.png)
Working on this.


s/suppored/supported/


I just opened my thing and it came up with this like lol huh?


Though, at the cost of clarity.


WHAT THE HELL I HAT PEOPLE WHO ADD YOU TO UR CIRCLES WHEN THEY DONT KNOW YOU !! :-1:


Ikr


Alatis so we do it on codeacdmey ???


PR to drop Xcode 5 support: https://github.com/facebook/xctool/pull/526


Ah, yes. One thing that has been nagging at me about PAGS is the lack of a "service" facade. Since we are not using the form anywhere else, I was considering a move to ditch the form. I was just too focused on move quickly.


Were this files necessary?
They can get from updated kRO...
we just need lua's and translation images


Ah so is codebit like a codeacademy ting


Like 1.4 Scratch


Codebit is on code academy.


Good catch


thanks - I'm blind


It looks a lot more like a harder 1.4 Scratch :/


There's something missing here.  Perhaps you meant "are because of contention..." ?


The way the positioning xD


sure i will do that . missed the div


Here are your codebits: http://www.codecademy.com/Cachhupin/codebits/


So where do we program ??


I think on CodeAcademy then share it here.


It looks like createItem() isn't handling null unit pointers properly. Should be fixed in the next release.


How do I find you- You just found ME :O


Could you also cover cases like: `aaa {issues}`, `aaa ${fsasfsaf` `aaa `${xy{z}w}`...?