@leahpadgett DWMR. Looks good Leah. :+1:  Press on!


As stated above, version 2.1.0 has never been in master and has not been released, so 2.1.0-SNAPSHOT will be preserved


This is unclear. Why would I want this file to be created? How do I use it?


You should remove that line.


add master


I can't even find the Gen 2 `AfterMoveSecondarySelf`... where did it go? @JOIMer! This is probably why switch-in poison doesn't work properly anymore.


JavaScript developers never use .jar files in their workflow. Please suggest a workflow that uses techniques familiar to JS developers.


Why are args split here?


@efinit DWMR (done with my review). Looks good. Press on!


# fuel rel --rel 1 --sync-deployment-tasks
No tasks found for release Juno on Ubuntu 14.04.1 of version 2014.2.2-6.1
No tasks found for release Juno on CentOS 6.5 of version 2014.2.2-6.1

It anyway tries to sync all releases.


@tomekwi np. was just a starter :smile: btw. let me know when you need feedback/review or a feature. I am happy to jump in.


We generally have helper methods below the method that uses them.


OK, the \#MixerLink makes sense... but still don't see the point for styling (cropping it's size?!) this way...
Please, test it...because IMO removing it fixes the "content bigger than widget" issue and I don't see any cons of that solution.


- Better to externalize <version/> tags in <properties/> tag

- I would rather use parent version:
<version>${parent.version}</version>
Because in this case a later switch to new release may be done easily by:
mvn versions:set -DnewVersion=1.0.1-SNAPSHOT


The FilterPromise provides a convenient link of Filter and Filterable. It is an observer of both, firing an update whenever one of them changed - directly providing the newly filtered list (as Iterable over FilterPromise) or optionally again as Filterable itself.


Would be better to `import os.path` if using only `os.path.xxx` stuff.


It matters to me, and I'm sure it matters to the developers who named their products a certain way.

GL needs to be in upper case because that's the proper name of the API. And specifically in this case because 'GL' is an acronym that stands for something.


Nice patch. :) Please consider publishing this as a new release to NPM.


OK, accepted


Accepted


how i can use this test for fruture use


Should have two empty lines after a class.


Use LOGGER as a constant.


On the other hand, there's no way to represent a "one past the last" uint256 (since that would require 257 bits).


You shouldn't throw an exception if you encounter an invalid file in the user's project. I recommend to do `Log.warn` instead


I think we can maybe turn off qual threshold for both illumina and nanopore (given appropriate tests) meaning the app could natively handle both ont and illumina without passing any additional arguments. 10 was quite low for illumina data to begin with.

Thought on this @iqbal-lab?


i think this might be wrong, didn't you mean:
ifTrue($this->hasSubject && $this->getSubject()->getId() !== null)


The above code is Java, which is replaced with Scala.  How would an individual using Java configure Pac4J?


@abhidixit just noticed this one. Should use snprintf()


Ces fichiers ne sont utilisés que par l'appli course_dashboard. Par souci d'ordre, je préfère les déplacer.


This blog clearly explains KMP algorithm: http://blog.sina.com.cn/s/blog_64f7baa40101dsz5.html


I think it would be much more interesting to show an example where this meta info file is actually important and required.


`当你想针对某一个仓库使用不同的名字与邮箱地址时` ==> `如果你想针对某些特定的项目用不同的用户名和邮箱地址来覆盖之前设定的参数，...`

Mark 一下，添加翻译对照  `e-mail`  `override`

e-mail => 邮箱
override => 覆盖

ref:https://github.com/archermind/git/blob/master/po/zh_CN.po


What is the correct fix here? This one is definitely not the right one (eps is always 0).


Given that IntelliJ IDEA Community Edition does not include any support for JavaScript, I would not recommend using it for Kotlin/JS development. (I know that it will somewhat work, but, for example, the debugger will not be available.)


This looks identical to the stm32f4xx_prefix.c file. If it is in fact, identical, then I think that it would be better to rename stm32f4xx_prefix.c to just be stm32_prefix.c and not have duplicate files.


@Slayer95 what about an 'unbanlist'? It would be very useful for this, suspect tests, and OMs.


"js-file" -> "JS file" here and elsewhere


The check was to see if the button **wasn't** pressed :). I don't think think the player should start moving until the path is complete. What do you guys think?


The inspect in this case look's more like DEBUG level of logging.

INFO are really general things.
- Potential issue if use a lot of INFO logs in production is that the server will consume some resources(CPU, MEM, ...) that probably are not required for that case.


how about the duration? isn't the issuer said the duration is longer than normal Safety Wall & Pneuma duration?


Another solution would be to just check whether there I anything after equal sign. Then, without showing to user, moving everything to the left side to obtain ax^2+bx+c=0 , so everything becomes as it was before.
However, in the future we will have formulas such as ax^2+bx+c=d , so your thought is better than mine.


How is `IndexOffset` used here? Is it with respects to 1-based indexing? i.e. `Face{3,Int,0}` would use 1 based, and `Face{3,Int,-1}` would start at 0?


this 指代完全  `配置这些参数` or  `上述工作`


`django-registration-redux` doesn't use semver? Why not specify its version?


The qual threshold is most useful
a) to remove totally shit data
b) to keep mem use under control when doing whole-genome analysis (not in silico oligos) which I think we will do for gram negatives
Happy to discard for InSilico Oligos I guess, but I would favour using 10 for Illumina when WG.
In which case no code cleaniness is gained


A good approach for description may be:
{@link com.adswizz.service.PersonService}


I'll fix it.


A reasonable question.

db_type is needed because otherwise the migration won't create the field at all.

get_internal_type is something I saw in a bunch of the online examples. It is also cross-platform (db_type is platform-specific). I'm not sure what if anything breaks if I take this away.

Here are the docs: https://docs.djangoproject.com/en/1.8/howto/custom-model-fields/#emulating-built-in-field-types

I struggle to understand them.


Again from my point of view here is better to keep ${parent.version}


I don't like that the index is just copied from the JVM one. This is too error-prone, see for example the note I left. The only difference between the two indices is how the ABI version is obtained from the file contents. Please decouple the existing index from that logic and create two instances of it, with different behavior (also with different name and version).


I don't see how this is related?


asprintf() returns -1, not a negative errno. Hence you should turn this into "return log_oom()", and throw away the r when returning.


looks 我认为指的是可以指定 git diff 输出是否带颜色之类的内容，即可以定制输出的样式，所以我认为是外观。


I'm tracking the bug, apparently rpcs3 doesn't copy all the indexes in indexed draw.


These last three seem to be something else.


@ayushranjan-planetria - given my limited expertise, I'd say it looks very good :)


OK, alternative is to get a quick estimate of mean read length and if the reads are longer than illumina turn threshold off.

I think it would be a major advantage to handle both illumina and nanopore data cleanly without needing an additional parameter.


Naming convention, the builder class is already defined inside PersonDTO, from my point of view this one should be renamed to: *Builder*


Please cast to (void) to indicate to compiler/static checkers that we really don't care about the return value.


Looks good otherwise.


Thanks for inspiration.
The ducking funktion does really need a rework.
I will remove the if condition in line 149 completly. Only the else condition  (line 152) has to stay.
The values I will keep at the old value.
Be aware to set the addition value to a to high factor, the if conditon was for staying at lower value for a tenth second before start growing up to 100%.


I actually just copied the license header from the initial Groovy view. I'll have a look again.


Looks good Gris!


typo 'converts https maps to https'


Same as above: Builder name


抱歉，这一版翻译的时候还是按照我原有的想法，我想把整个书翻译一遍，不想参考任何其他资料，然后在初步翻译完成的情况下进行三方合并，即最新英文原版、中文第一版、我翻译的版本，进行仔细推敲，这样之后再提 Pull Request，我不知道我应不应该撤消本次 Pull Request，等待三方合并完再提？


By all means do this in your own fork, but don't include it in a PR.


@ayushranjan-planetria - should I make a post on stackoverflow describing the problem+solution and asking for advice or can you do that or is that unnecessary? Since:
> Ayush Ranjan: the event is only assigned when we open the Edit window and removed when its closed ... I will be also testing its performance in profiler


It is a mistake on my part, to Android_808 said:

QDBUS_EXPORT shoulds be Q_DBUS_EXPORT

I will do testing to see if it is good in scratchbox


attributes description


Did this before I realized Bloc had a specific way they wanted us to do this, step by step. I do think this is essentially successful in the checkpoint's goals, however.


When there are some upstream causes, the . is between the cause representation and the "originated by". It looked a bit weird. Since the "originated by" is on another line, maybe we can accept this final "."


This line introduced a bug: Go to the editor - type "Hello World" - double click "World" - click bold: word turns bold - click bold again - nothing happens. Always happens to the last word in the paragraph.
When deleting the return statement, it works fine, but I have no idea if it ruins something else.


看样我还需要将 Git 自带的翻译看一下，确定一下术语。


I'm sorry, I was unaware it would also be used in the PR. I'll undo this asap.


I just copied the wording for the core `Cause.Upstream` but I can do this of course.


fix_double_oa_equipment (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Reverting, test complete.


Ops! Fixed now.


You can simply do:

if (packageVersion("knitr") < "1.10.12") stop("knitr must be version 1.10.12 or higher")

The fix allowing chunks to be quoted was introduced on April 19th (https://github.com/yihui/knitr/commit/3f52d476c5dca3eae657cc1ec6174bd3216b510d) with version 1.9.20 (https://github.com/yihui/knitr/commit/75a8ec05bc3750f996c1016febe2bd45cf5978ad)


gooo


OK (not to taking it on). Do we know how often we expect to migrate the
site? Just thinking that Bootstrap doesn't seem to go for backwards
compatibility so are we going to need to upgrade again in 2 years time?


yup, that's correct!


Just out of curiosity, is there a reason for not cherry-picking these commits directly from their origins?


Well, it's broken right now as far as I can see.


you're initializing this file variable here as an empty string... File holds a file object, never a string. The initial empty string is never used by your code, so a simple `var file;` will do.

That leads me to my next point: you create this `file` variable outside of the scope of where it's used (`input.change`)... but you aren't using it anywhere else. So it has a wider scope than is needed, which translates into memory inefficiency (the file object resides in RAM for the duration of the program, when it doesn't need to)

I recommend removing this variable altogether and changing line#45 to have `var file = ...`


Agreed.


Also, if all quals <20, is nanopore


Read length a better predictor though


I did a bit of quick testing on my work computer this morning, and it seems at first glance that KT-7961 is **valid**. Prior to Maven 3.0.4, execution order was arbitrary, and supposedly it was fixed in 3.0.4 to run in the order that the plugins are defined in the POM. However, I have not been able to get the code to run correctly using 3.0.5, 3.2.1, or 3.3.3 on my work computer. A bit more digging turns up [MNG-5478](https://issues.apache.org/jira/browse/MNG-5478), which suggests that this might still not be working correctly.

I still plan to see if I can reproduce this at home (where I think I have a working version of everything), and figure out if there was something different that caused it to work correctly, if it was a fluke, or if things aren't working right and I just somehow wasn't hit by this bug.


Better to create a GenericRepository<T,T> that extends RedisTemplate<String, String> and will implement a generic interface for CRUD.


我觉得这个地方有待商榷，原文的意思是说名字与邮箱在提交后就固化为提交的一部分，如果想要修改，只有撤消提交并重新提交，也就是说提交一旦生成即不可改变。


So no thresholds are tech specific now?


hfdhfdh


当你的用户信息已经设置完毕，你可以开始设置默认的文本编辑器了，这个编辑器会在 Git 需要你输入信息的时候被用到。

__从句翻译__ 还是分成两句比较易读


我还没想到更好的翻译，抱歉，准备在三方合并时进行修改这个地方。


"newValue" instead of "objValue" ;)


@Raesu DWMR. Well done here. Press on.


Why *defaul* access? Should be: "private" or "protected"?


good work


Sources have to exist already. They float around in non-connected state, see hal.h


its awful, its bad etiquette, but unfortunately when you get 30-50 kb/s when trying to fetch a repository, it becomes necessary with the only hope that the credits you give reflect the original origin .. its awful in every count..


You want to suggest another alias?


Do not leave commented code in a commit. Never. This is why we use a versioning system (git) you can always go back...


slf4j LOGGER may be used also as:
LOGGER.debug("Get score by key {}", key);


The backtick (`) at the end of the change is too much. Seems to be an copy and paste mistake from the configure script.


See above.


Here is also the backtick (`) too much.


из-за этого, бля, что ли ???


We noticed the same thing, and are looking into it.


Proper OBJ-to-OBJ and OBJ-to-BG priorities are coming soon, but this means most GBC are fully playable (not LoZ:Oracle games, those require some APU stuff to be done).


Just to be sure: This app is not running in production anywhere right? I just want to point out that we are binding a public port for a service for which we disclose the root password a couple of lines later.

Just making sure...


Thanks, this is immensely helpful.


Continue statement are forbidden by MISRA-C:2004 14.5


Can we use camel case here or is this a convention you are following?


Neither of those will be in 2.2.0 if that's what you mean. Both need more work and I just want to get the release out.


Not a good idea to reuse a domain name you don't own. Some mail servers might check that the sender's IP correspond to the IP mapped to the MX entry in mozilla.org's DNS, see it's not the same IP and raise the email's spam score. Let it be configurable instead?


I just copied the addContrib.js and used it as a template.


fail


I added a --ont argument to set qual thresholds to 0. It's the only change you need to make nanopore to work.

Will set ont flag automatically if read length is > 250.


I think the current parameter names are also okay.


恩，这都是小事，关键是从句的翻译，如果挤在一句中文里，不太容易读懂。


Because of the other mixins to blocks, those need to be applied after `MixinBlock`.


This comment looks out of date.


FWIW, this won't catch requests, which start with the HTTP verb. Does it make sense to combine this with https://github.com/mitmproxy/mitmproxy/blob/c59f045bd9c855dca78cb4b78ec69c1c40b4776a/libmproxy/proxy/primitives.py#L85?


This is because jit-crash-categorize doesn't actually use any of the SymbolSupplier code, but links http_symbol_supplier.o (in EXTRA_OBJS), so the linker complains about missing symbols unless I reorder EXTRA_OBJS to be before BREAKPAD_LIBS.


Why to use this method if the OBJECT_KEY is a constant?


Did just that, thanks for the reminder.


Just pushed this.  All the examples worked for me, so I don't think there
should be problems.  Default is still affine.

2015-06-07 21:02 GMT-04:00 Ben Kandel <ben.kandel@sbcglobal.net>:

> shoot--sorry about that.  the basic examples i ran worked ok when i first
> committed.  my most recent log had a lot of errors and documentation
> issues, but the reasons aren't immediately obvious to me. i'll check that
> out.
>
> 2015-06-07 20:45 GMT-04:00 stnava <notifications@github.com>:
>
>> ok - good plan ... with transform type == affine as default
>>
>> note: there were some example failures for your rigid commit ...
>>
>>
>> brian
>>
>>
>>
>> On Sun, Jun 7, 2015 at 8:36 PM, bkandel <notifications@github.com> wrote:
>>
>> > right, that's what i'm worried about. we could conceivably have the
>> > "moreaccurate" part determine sampling, and have a separate
>> "transformtype"
>> > argument that controls the class of transform.
>> >
>> >
>> > 2015-06-07 20:24 GMT-04:00 stnava <notifications@github.com>:
>> >
>> > > that sounds reasonable ... but need to maintain backward compatibility
>> > >
>> > >
>> > > brian
>> > >
>> > >
>> > >
>> > > On Sun, Jun 7, 2015 at 8:13 PM, bkandel <notifications@github.com>
>> > wrote:
>> > >
>> > > > agreed. just not sure how to phrase it. should we perhaps rename
>> > > > "moreaccurate" to "transformtype" and make it more explicit?
>> > > >
>> > > > 2015-06-07 10:21 GMT-04:00 stnava <notifications@github.com>:
>> > > >
>> > > > > this should be probably be a user choice - i.e. either rigid or
>> > affine
>> > > > > .... affine distortion is quite common ...
>> > > > >
>> > > > > —
>> > > > > Reply to this email directly or view it on GitHub
>> > > > > <
>> > > >
>> > >
>> >
>> https://github.com/stnava/ANTsR/commit/7952e7c612fcbf783388cfebbf7c152b03ef7236#commitcomment-11557213
>> > > > >
>> > > > > .
>> > > > >
>> > > >
>> > > > —
>> > > > Reply to this email directly or view it on GitHub
>> > > > <
>> > >
>> >
>> https://github.com/stnava/ANTsR/commit/7952e7c612fcbf783388cfebbf7c152b03ef7236#commitcomment-11559229
>> > > >
>> > >
>> > > > .
>> > > >
>> > >
>> > > —
>> > > Reply to this email directly or view it on GitHub
>> > > <
>> >
>> https://github.com/stnava/ANTsR/commit/7952e7c612fcbf783388cfebbf7c152b03ef7236#commitcomment-11559261
>> > >
>> >
>> > > .
>> > >
>> >
>> > —
>> > Reply to this email directly or view it on GitHub
>> > <
>> https://github.com/stnava/ANTsR/commit/7952e7c612fcbf783388cfebbf7c152b03ef7236#commitcomment-11559289
>> >
>>
>> > .
>> >
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/stnava/ANTsR/commit/7952e7c612fcbf783388cfebbf7c152b03ef7236#commitcomment-11559303>
>> .
>>
>
>


Some example syntax comment would help...


Ok, thank you.


cool, thanks!


So if I don't use --ont but all reads >1000bp, it will just assume it is ONT? Good.


> i cannot able to get the resource suggested by you[CloudFerry/devlab/]...

As I noted previously, you should checkout `devel` branch of the repo to have it.

> code in this section CloudFerry/tests/cloudferrylib/os/[actions compute identity image init.py network storage]

You're looking at the unit tests. All the logic is in `cloudferrylib` folder.


haven't finished yet.


Bad link.


1000bp is a bit high. Mean read length for our nanopore runs so far ~450 - 500 bp.


But that's the idea, yeah.


Yeah, I think I was using that convention when I had defined those variables as static, but later I though it might not be a good idea to make the variable static since you should be able to define different configurations for different jobs. I can change this.


The reason why I added this is, that I was tracking down a test failure in pathod - which does not yet support HTTP/2. After figuring that out I decided to print some kind of warning...
I think the more suitable approach would be to deny any requests if TLS & ALPN failed.
Currently ALPN (or even TLS) is NOT enforced - which is probably against the RFC.


This is definitely not for production. That's only for local development. That's why there's a RSA key pair as well.


Apparently all index in index buffer are zeroed after index 256


This looks wrong: I am pretty sure we should continue to warn if ipv6 is built as kernel module. However, we should stop warning when it is not available at all (i.e. neither built-in nor as kmod). Currently the "warn" boolean controls both cases. I figure we should split this up into two bool:1, so that we can handle this nicely.

Also, I think we should always log the warning, however do this at different log levels depending on the bools: LOG_WARNING if the bools are on, and LOG_DEBUG otherwise.


@networm 你速度确实很快，但是你的翻译我读起来还是有点费劲的。可能这样中英文对照起来看，容易带入主观情绪，也许你merge之后，我就不会提这么多comment了，不过 __从句翻译__ 上，我们还是可以多多借鉴别人的经验的。今天太晚了，我看的也累了，明天我带着ref来找你讨论。


Cuberite biomes?


Ugh. Referenced the wrong project here.

Fixes atom/atom#6899


Wrong.


Printing in this way is not future proof, please consider something like ``print("WARNING: This looks like an HTTP/1 connection!", file=sys.stderr)``


It's a bit dangerous for local development as well if the machine running it is not behind a firewall that blocks the port. The gate to the container is wide open and there are possibly ways to escalate to the host machine.


Hi,

I think there is an error here, according to the implementation of `isSingleton`, the correct implementation of `mkSingle` should be:

```idris
mkSingle : (x : Bool) -> isSingleton x
mkSingle True = 0
mkSingle False = []
```
Same thing for the `sum` function, `True` and `False` should be inverted.


An alternate less verbose version to consider:

    journal_.debug << description;
        << "   order in: " << format_amount (flow.order.in);

    if (! isXRP (issue_in ()))
        journal_.debug << " (issuer: " << format_amount (flow.issuers.in) << ")";

    journal_.debug << "  order out: " << format_amount (flow.order.out);

    if (! isXRP (issue_out ()))
        journal_.debug << " (issuer: " << format_amount (flow.issuers.out) << ")";


We are. The difference is that we are not using `transformList` because we want to gather the `PROPERTY_VARIABLE_DECLARATION` .


If this catch block is catching any kind of exception and re-throwing it, what's the point of the catch block? Removing the catch should mean the same behaviour as having it.


... that's good or bad? :)


Yes, the names are ad hoc. Roughnum should really be RoughReal, and the two new number types can then be Complex (actually ComplexRational or GaussianRational, but those are mouthfuls) and RoughComplex.

Rough[Nn]um can still be retained for the union of RoughReal and RoughComplex.


So rather than duplicate the code, I would be inclined to change the #if 0 of the original to be #if MICROPY_HW_REPL_UART and have the PHOTON board put
```
#define MICROPY_HW_REPL_UART PYB_UART1
```
in the board/PHOTON/mpconfigboard.h file (and replace the PYB_UART_6 with MICROPY_HW_REPL_UART)


@tonghuix @devbean 想听听你们的意见

Thanks


It still applies.


isto é um comentario


Just to be annoying :), here Iterator.range(0, numberOfPoints) would probably be a more lazy version


Ack. Will add some examples and improve the comment


Ooops. When I looked at the diff I thought I fixed a bug ;-)


This plugin doesn't seem to be working on my test sites or your demos since the latest YouTube API changes. Any ideas?


Better to create Errors per layer and to handle them on extremities.
Example:
Controller -> Service -> DAO -> DTO deserializer

- Domain object throw a SerializationException, you catch it and throw a DAOException(e); where e - SerializationException
- DAO layer throw an exception up;
- Service layer throw it up with new ServiceException(e);
- Controller throw exception;

NEXT:
- Create an ServiceExceptionHandler that will manage all application exceptions as for example:
```
@Component
@Provider
public class ServiceExceptionHandler implements ExceptionMapper<ServiceException> {
    @Override
    public Response toResponse(BusinessException exception) {
        // A simple example of response...
        Response.Status badRequest = Response.Status.CONFLICT;
        ErrorResponse errorResponse = new ErrorResponse(badRequest.getStatusCode(), exception.getMessage());

        return Response.status(badRequest)
                .entity(errorResponse)
                .type(MediaType.APPLICATION_JSON)
                .build();
    }
}
```


Wouldn't this be better to try with option space instead? The whole point of interpret-only was to save storage space which is very limited on data partition. IIRC, speed vs. interpret-only difference with only gapps installed was around 400MB which is like 36% of whole storage space available.


I can do this in its own PR if you prefer? It is something I found when I found the invalid ParseTree due to createRestParameter in ParseTreeFactory. The rest param needs to be wrapped in a FormalParameter and the formal parameter is the one that has the type annotatation.


不是默认啊，目前只支持这个值


menu 组件肯定要的啊，ad 有这个的设计


cool


I like the 3 different alternatives; the meaning of the method doesn't require you to read the argument list.
Now getting the right verb; "process" is a bit too generic, "validate" sounds right, "handle" could be a bit more accurate bit probably misleading regarding to the rest of MVC.


They should be considering the opacity. Was this with the accessibility-dev-tools extension? Might be out of date.


Hey, don't merge directly into master, submit a pull request!


ack


So the `TypedMemberVariableTransformer` is not a typed version of `MemberVariableTransformer`?  I could understand "Member variable with types only make sense when type assertions are enabled", so much so I would not need a comment.  But as it stands I also see a `MemberVariableTransformer` below which contradicts the comment.


MY BAD!


Can you elaborate on this? What do you mean by "do the wrong thing"?


$ mvn archetype:generate -DgroupId=com.jpaul -DartifactId=LaunchjerLaser -DarchetypeArtifactId=maven-archetype-webapp -DinteractiveMode=false


Hmm, yes, though it's been having some troubles with my chrome I think. Whenever I run the audit with "reload and audit" it hangs forever. Whenever I say "audit current state" almost all the audits show up in the "not applicable" area.


LOGGER.debug("Get score by key: {} ", key);


Yes validate works with how this is described in terms of validation and validators (e.g. https://www.mnot.net/cache_docs/#VALIDATE).


@josericardo what do you mean by old behavior? The settings instance wasn't copied, as I remember. Regarding the name, if we leave ``new_instance`` one who will be reading that code could think that method creates new instance, but that's not completely true.


Ah ok, makes sense now.


@OwnDroid why though?


Does this actually work without any delay between the drones? I've got pretty much the same thing and I can't seem to get the drones to respond at the same time.


could already use pre-computed idxClosestPoint here


Well, bad, IMO. Too large. The the mixer button doesn't look like a button, it looks like a section title.


These 2 tests will fail on Saturdays and Sundays because they use DateTime.Today (markets closed).
The problem can be solved using a fixed date (like in my last PR)

https://github.com/StefanoRaggi/Lean/commit/2433121313607d594e1aa7f1ab0bef47b83f3eb3


I think that would probably be appropriate, but IDK.


Yes, me too. Sorry for being unclear. ;)


https://github.com/mpokwsths/flo_kernel/commit/60a7ee5e471e11cc392fbed188e1f32d24a7b16b

Unfortunately, it appears to have no affect to mpdecision for this device and may be causing some sleep issues reported.


@ocornut For non-fixed width font under DX9. You can remove this change and try imgui's test window inside bgfx with DX9 and you'll see the problem.


I agree this could be cleared up.

If we are using typeAssertions we should use TypedMemberVariableTransformer. Here is the logic in pseudo code.

```js
if (memberVariables) {
  if (typeAssertions) {
    append(TypedMemberVariableTransformer);
  } else {
    append(MemberVariableTransformer);
  }
}
```


tricky one. Could be done wit a BFS on the grid graph starting from the nearest neighbour


Thanks, fixed https://github.com/gdestuynder/audisp-json/commit/d054df6fb3c52741b65e6be83a61bdc93048afba#diff-3e500443761e68bd33851ebcdb8e7d86


This was my bad, thanks @loganm


Commenting on something already merged isn't going to get that merge to change.


What you're saying is that someone could use root influxdb access to somehow exploit influxdb to get full container access and then exploit docker to get access to my machine ?


oh, you're right! I missed that redundancy.


@JordanCheney fyi


No, that was correct ...


What does DataLocation return on Windows?


No that was also correct.


Ah nvmd, didn't see you reverted this in the next commit.


I've been too hasty on this one.


Hi Iris and Tong,

To know the status of encryption, crypto-js could work. There is a object :
encrypted in that. we can do test by something like alert(typeof encrypted)
to check the status.

Also, in cryptocat, otr.js could help .

On Mon, Jun 8, 2015 at 4:14 AM, Tong Hui <notifications@github.com> wrote:

> I checked https://irischat.herokuapp.com/ and don't know how behavior
> logic working? and how to turn 'unencrypted' to 'encrypted'.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/beijinglug/lets-chat/commit/e2f0f01e6076a0975353b6080780af606353d0ff#commitcomment-11559001>
> .
>

--
Heena Mahour
Google Code In KDE admin team | Season of KDE admin team | Google Summer of
code developer | Google Code In mentor | Season of KDE developer | Women
who code delhi co-founder and organizer ( heena@womenwhocode.com )
http://heenamahour.blogspot.in


The hash code changed if an Event object was instantiated e.g. with an integer as the source depth, was then written to a catalogue and reread again. Hence, I think it's more safe to validate before returning the hash.


Ok here is the PR that fixes it https://github.com/RPCS3/rpcs3/pull/1116


@dmak78 You should update your bundler, which will keep us from overwriting each others' Gemfile.lock


1: M111 unrecognized component name: legacy


31:1: I100 Imports statements are in the wrong order. from invenio.base.utils should be before import pkg_resources
42:1: E303 too many blank lines (4)
83:5: E266 too many leading '#' for block comment


Just a few things I want to work on


47:1: I201 Missing newline before sections or imports.
49:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug.utils
52:1: F401 'CFG_BIBFORMAT_CACHED_FORMATS' imported but unused
52:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
52:1: F401 'CFG_BIBFORMAT_DISABLE_I18N_FOR_CACHED_FORMATS' imported but unused
68:1: F401 'CFG_BIBFORMAT_OUTPUTS_PATH' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_TEMPLATE_EXTENSION' imported but unused
68:1: F401 'CFG_BIBFORMAT_TEMPLATES_DIR' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_OUTPUT_EXTENSION' imported but unused
78:27: E261 at least two spaces before inline comment
79:28: E114 indentation is not a multiple of four (comment)
79:28: E116 unexpected indentation (comment)
80:28: E114 indentation is not a multiple of four (comment)
80:28: E116 unexpected indentation (comment)
81:28: E114 indentation is not a multiple of four (comment)
81:28: E116 unexpected indentation (comment)
84:28: E114 indentation is not a multiple of four (comment)
84:28: E116 unexpected indentation (comment)
98:33: E225 missing whitespace around operator
183:1: E731 do not assign a lambda expression, use a def
186: D203 1 blank line required before class docstring (found 0)
190: D401 First line should be in imperative mood ('Return', not 'Returns')
190: D400 First line should end with a period (not 's')
204: D401 First line should be in imperative mood ('Format', not 'Formats')
204: D400 First line should end with a period (not 'f')
204: D205 1 blank line required between summary line and description (found 0)
251:45: W503 line break before binary operator
251:45: E127 continuation line over-indented for visual indent
263:8: W503 line break before binary operator
267:41: F841 local variable 'exc' is assigned to but never used
342:82: E225 missing whitespace around operator
353: D401 First line should be in imperative mood ('Return', not 'Returns')
353: D202 No blank lines allowed after function docstring (found 1)
353: D400 First line should end with a period (not 'g')
353: D205 1 blank line required between summary line and description (found 0)
374:64: E261 at least two spaces before inline comment
374:65: E262 inline comment should start with '# '
381:38: E261 at least two spaces before inline comment
381:39: E262 inline comment should start with '# '
382:48: E261 at least two spaces before inline comment
382:49: E262 inline comment should start with '# '
385:24: E127 continuation line over-indented for visual indent
394: D103 Missing docstring in public function
397: D400 First line should end with a period (not 's')
397: D200 One-line docstring should fit on one line with quotes (found 3)
410: D210 No whitespaces allowed surrounding docstring text
410: D400 First line should end with a period (not 'a')
410: D205 1 blank line required between summary line and description (found 0)
495: D401 First line should be in imperative mood ('Filter', not 'Filters')
505: D401 First line should be in imperative mood ('Searche', not 'Searches')
505: D400 First line should end with a period (not 's')
505: D205 1 blank line required between summary line and description (found 0)
531:9: E303 too many blank lines (2)
545:5: E303 too many blank lines (2)
549: D401 First line should be in imperative mood ('Return', not 'Returns')
589:28: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
603:1: E302 expected 2 blank lines, found 1
603: D203 1 blank line required before class docstring (found 0)
603: D204 1 blank line required after class docstring (found 0)
603: D400 First line should end with a period (not 'n')
603: D205 1 blank line required between summary line and description (found 0)
634:15: E261 at least two spaces before inline comment
636: D401 First line should be in imperative mood ('Create', not 'Creates')
668:31: E261 at least two spaces before inline comment
693: D401 First line should be in imperative mood ('Return', not 'Returns')
693: D400 First line should end with a period (not 'e')
708: D401 First line should be in imperative mood ('Return', not 'Returns')
708: D400 First line should end with a period (not 'd')
731: D401 First line should be in imperative mood ('Return', not 'Returns')
731: D400 First line should end with a period (not 'e')
731: D205 1 blank line required between summary line and description (found 0)
769: D401 First line should be in imperative mood ('Return', not 'Returns')
769: D202 No blank lines allowed after function docstring (found 1)
878:36: E127 continuation line over-indented for visual indent
881: D401 First line should be in imperative mood ('Return', not 'Returns')
938:33: E127 continuation line over-indented for visual indent
949:60: E251 unexpected spaces around keyword / parameter equals
951:54: E251 unexpected spaces around keyword / parameter equals
961:37: E127 continuation line over-indented for visual indent
972:64: E251 unexpected spaces around keyword / parameter equals
974:58: E251 unexpected spaces around keyword / parameter equals


27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. import sys should be before import pkg_resources
28:1: I201 Missing newline before sections or imports.
28:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
33:1: E402 module level import not at top of file
34:1: I101 Imported names are in the wrong order. Should be ImportPathRegistry, ModuleAutoDiscoveryRegistry, PkgResourcesDirDiscoveryRegistry, RegistryProxy
34:1: I100 Imports statements are in the wrong order. from flask_registry should be before from invenio.testsuite
34:1: I201 Missing newline before sections or imports.
34:1: F401 'PkgResourcesDirDiscoveryRegistry' imported but unused
34:1: E402 module level import not at top of file
53:1: E731 do not assign a lambda expression, use a def
104:13: F841 local variable 'unknown_output' is assigned to but never used
160:5: E303 too many blank lines (2)
215:80: E261 at least two spaces before inline comment
215:81: E262 inline comment should start with '# '
233:80: E261 at least two spaces before inline comment
233:81: E262 inline comment should start with '# '
252:1: E302 expected 2 blank lines, found 1
348:60: E203 whitespace before ','
349:55: E203 whitespace before ','
349:60: E203 whitespace before ','
350:55: E203 whitespace before ','
350:60: E203 whitespace before ','
351:55: E203 whitespace before ','
351:60: E203 whitespace before ','
352:55: E203 whitespace before ','
352:60: E203 whitespace before ','
353:55: E203 whitespace before ','
353:60: E203 whitespace before ','
354:55: E203 whitespace before ','
354:60: E203 whitespace before ','
355:55: E203 whitespace before ','
355:60: E203 whitespace before ','
356:60: E203 whitespace before ','
359:55: E203 whitespace before ','
359:60: E203 whitespace before ','
360:55: E203 whitespace before ','
360:60: E203 whitespace before ','
361:55: E203 whitespace before ','
361:60: E203 whitespace before ','
362:55: E203 whitespace before ','
362:60: E203 whitespace before ','
363:55: E203 whitespace before ','
363:60: E203 whitespace before ','
364:55: E203 whitespace before ','
364:60: E203 whitespace before ','
365:55: E203 whitespace before ','
365:60: E203 whitespace before ','
366:55: E203 whitespace before ','
366:60: E203 whitespace before ','
367:55: E203 whitespace before ','
367:60: E203 whitespace before ','
368:55: E203 whitespace before ','
368:60: E203 whitespace before ','
369:55: E203 whitespace before ','
370:55: E203 whitespace before ','
370:60: E203 whitespace before ','
371:55: E203 whitespace before ','
371:60: E203 whitespace before ','
372:55: E203 whitespace before ','
372:60: E203 whitespace before ','
374:55: E203 whitespace before ','
374:60: E203 whitespace before ','
375:55: E203 whitespace before ','
375:60: E203 whitespace before ','
381:1: E302 expected 2 blank lines, found 1
452:9: E303 too many blank lines (2)
663:1: E303 too many blank lines (4)


I'll be more careful ! Sorry for that.


This looks like an OS X path. I'm guessing this will need to be tweaked for staging/production?


What if we rename ``FronteraSettings`` to ``BaseSettings`` so it will serve the purpose of abstract class with ``.new_instance`` factory method. What do you think?
I don't like the idea of having ``FronteraSettings`` and ``Settings`` they all in frontera package and such name will confuse people.


I suggest adding some `Get()` method to `Option`. Explicit casts like this are somewhat odd and my suggested change is a good alternative following DRY style.


@dmak78 Why the switch from https to http here?


la(o !== updated)


Nice fix


I really like this addition, but I think the whitespace "normalization" isn't safe since it would also strip out whitespace that might matter, like within a string. E.g. you might want to treat following two snippets as the same:

```
$string = "Hello World";
```
and

```
$string = "HelloWorld";
```

I think stripping out the whitespace needs to be a little more conservative. Not sure if traversing the file line by line and only trimming whitespace at the beginning and at the end of the line would do the trick (actually you might miss additional irrelevant whitespace in between this way...)


Why is this taking pointer references instead of just iterating via `auto& group` ?


all hail clang!


Yes awesome catch! I'll merge it in, thank you!


I told AH that the test was incorrect. He sent in https://github.com/hjr3/halo-sample-cart/commit/572a6e350ac1a6e6430ece08de14631a30cc4d83 to fix it. This does pass all behat tests, but is obviously broken.


Whoops, missed that, thanks!


Testing this with -p -c 10 -M and it retunred history password stats.


It might be worth trying to solve this using the PHP Tokenizer like in `getFileContentWithoutComments()` which then again would only work for PHP files.

Or checking out how the whitespace sensitivity works in the (git) diff command...


I will concede that is a fair point.  I would think it would be "good enough" in that there should not or would not be many meaningful whitespace modifications when comparing a Magento instance to the vanilla versions of it's files, but if we want complete accuracy I could take another stab at it.  I think for perfect accuracy I'd have to tokenize it, yeah.


Updated this on site


Why not store true references to the groups instead? Using pointers suggests mutability, which is not necessary here though.


Part of my commit note is incorrect:

> There are two unused methods in the calculator (`#calculate_reduced_rate_payment` and `#reduced_rate_multiplier`) that mean I can't get 100% coverage. I'll remove them outside of this branch.

They are indeed used and I've now improved the set of responses (see a00db23cb3fb581d000801b114ac7d625b77b3dd) so that I can exercise these methods.


wait. more changes to be commited


You didn't have any code that actually went through this did you? I think you should leave this as a pass.


Ansible version change is because I forgot about #125.


This needs some tests please. Testing should include selecting exectime from system.connections.


@lemire yeah, instead of the run time detection, i'd rather suggest going by compile time enablement. Maybe through some makefile option or alike. If we had some emulation layer, that could enable users to still compile an SSE2 capable lib. I hold the same opinion that games with cpuid are not reliable enough.

The only question - in how far it's important to not to loose those 20% of the potential machines. We could maintain our own emulation layer, or even require some external like http://sseplus.sourceforge.net/ , or even bundle some.

@yjh0502 performance is a good thing, however not a competition to compatibility. Fe a couple of months ago I made a bug using the LZCNT intrinsic, on the processors where it's not present, it kinda "works", but in completely unexpected way :)

Cheers.


Even though paragraphs don't have a text-indent added to them in epub.css, some e-readers will automatically add them in, so these lines serve as a fallback to override them.


I think that works, max(maxToken) should be inclusive IIRC. (but not necessarily for minToken I guess, since it is not used for partitioning.)
Though I find it more understandable to assign range right inclusive (```(minToken, e]```, ```(e, maxToken]```) since the node's token range is assigned that way.


@ScottPJones, review the chapter on [parametric types](http://docs.julialang.org/en/latest/manual/types/#man-parametric-types); @tkelman is right here, having `bitstype Char{E <: Encoding} 32 end` defined would be the way to go, which effectively makes `Char` an abstract type with each `Char{ASCII}`, `Char{UTF8}`, concrete types of it.


I'll suggest that, instead running the tests against a real server, to use "server databases" (XML files on disk representing a server) and DbProxy, as we do in XenAdminTests project.


new Random().nextInt(3) => retourne 0,1,2
*2 => retourn 0,2,4


No Reason. temporary fix for something. will switch it back.


We can probably bring it back, if you think it is a good idea. but we should consider making a generalized ``flush`` to call.


Thanks for your questions! We have found some instances of section tags not working correctly in different ePub readers. We have div[data-type="chapter"] here to give better CSS support across more devices.


I'd keep these here,  but do ``host=None``, ``port=None`` and use the values as the defaults of the ``os.environ.get``


@anegrin , you may want to delete this fork and create a new one. Then, in future, do not change the master branch, but use exclusively a branch for your work (this can be one permanent branch you use). Git/github workflow is far from perfect, but usually, keeping things in a branch works fine.

I'm not a fan of keeping gitignore within the repo, but as light-admin does so, you can add circle.yml to it, thus your config file is kept out of the repo.


Yes, I'll do that.


Thanks @StefanoRaggi, merged in: https://github.com/QuantConnect/Lean/commit/9227767437bdb312a309f06d4f019567e22a0e78


Consider:
if (i < ui)
    return -1;
if (i == ui)
    return 0;
return 1;


going to revert this tomorrow, I don't want a solution like #8232 just for a different background


this was a mistake looking at the code it didn't make any sense now, I try to correct it.


No strong thoughts on my end.  I've found this convenient in the past when you can't fit everything in a with block.  It might make sense to wait though.


What's the rationale for the do{ } while(0)?


@davidfowl Yup, @stephentoub is right here -- this is the approach we are taking in general with other algorithm-heavy libraries (globalization, crypto) for cross-plat as well.  It is really about how to be smart about our investments.  Rewriting thousands of lines of portable C++ code in C# or building unique features that set us apart


Why is setup.py required to run nose?


This was also a temporary fix for my personal machine and shouldnt have been committed. Will remove and recommit.


This looks like a fix for the previous patch. Can you send a V2 that merges them?


Not a makefile expert, I added them due to reading the docs, and possible having trouble with make docs. Any that don't seem necessary would be fine to kill.


I'm not sure if that's what you are asking for, but I've posted the server and client configs bellow. The setup is very similar to the examples in http://logstashbook.com/

Linux server logstash config

	input {
	  redis {
	    host => "127.0.0.1"
	    type => "squid"
	    data_type => "list"
	    key => "squid"
	  }
	}

	filter {
	  if [type] == "squid" {
	    grok {
		    patterns_dir => ["/etc/logstash/patterns"]
		    match => ["message", "%{CUSTOMSQUID}"]
		    add_tag => ["squid", "customsquid", "grokked"]
	    }
	     mutate {
	       convert => [ "httpcode", "integer" ]
	       convert => [ "httpreplysize", "integer" ]
	       gsub => [ "username", "^myaddomain%5C", "" ]
	       add_tag => [ "mutated" ]
	     }
	  }
	}

	output {
	  elasticsearch {
	    cluster => "logstash001"
	  }
	}

Windows log shipper

	input {
	  file {
	    type => "squid"
	    path => ["C:\squid\var\logs\access.log"]
	  }
	}
	output {
	  redis {
	    host => "192.168.0.100"
	    data_type => "list"
	    key => "squid"
	  }
	}


Aha! You're right. I'll set the sender address as a line command argument. Thanks!


Looks like you meant "Canola"


I definitely liked your idea and I been working on implementing it based
on your code. It is just that deadlocks have made this feature harder to
implement than I thought...


Lets remove $module_list from here and doxygen. Lets also remove $cache_backend from doxygen.


asdfasf asd asdf


Lets remove the code instead of commenting out.


Without first initializing plist[i] for all patches outside of the main loop, plist[j] (lines 554-555 inside the main loop) will seg. fault.


@ginxwar This plugin allows the app to open a web browser where the user can register for a strabo account. [login.html#L18](https://github.com/StraboSpot/strabo-mobile/blob/master/www/templates/login.html#L18) Eventually we should do the registration directly from the app.


terraform is failing to deploy with issue below:
>There are warnings and/or errors related to your configuration. Please
fix these before continuing.

>Errors:

>  * module root: module dc2-keypair: required variable region not set

don't you have to remove also related to 'region' configuration code below?

https://github.com/CiscoCloud/microservices-infrastructure/blob/master/terraform/openstack/keypair/main.tf

>diff --git a/terraform/openstack/keypair/main.tf b/terraform/openstack/keypair/main.tf
index 56c1e61..c3ac626 100644
--- a/terraform/openstack/keypair/main.tf
+++ b/terraform/openstack/keypair/main.tf
@@ -1,7 +1,6 @@
 variable auth_url {}
 variable tenant_id {}
 variable tenant_name {}
-variable region {}
 variable keypair_name {}
 variable public_key {}

>@@ -12,7 +11,6 @@ provider "openstack" {
 }

 >resource "openstack_compute_keypair_v2" "keypair" {
-  region        = "${ var.region }"
   name          = "${ var.keypair_name }"
   public_key    = "${ file(var.public_key) }"
 }


It works.
Btw, i'm thinking of another approach for mb links on discogs, the current one doesn't work well with discogs "labels" vs MB places, and i found few performance issues i would like to solve (and pjax events don't work...)
Still experimenting in https://github.com/zas/musicbrainz-userscripts/tree/mblink_key


I don't actually remember why I did this. I'll remove this while doing the cleanup work.


That makes the size of all of them 32 bits, which is not what you'd really want.
`CharA` (`ASCII`) would be a 7-bit value stored in `UInt8` `(typemax(CharA) -> 127)`,
`Char8` (`Latin1`, `Binary`) would be 8-bit values stored in `UInt8`
`Char16` (`UCS2`) would be 16-bits stored in `UInt16` `(0-0xd7ff, 0xe000-0xffff)`
`CharU` (`UTF8`, `UTF16`, `UTF32`) would be 21-bit values stored in `UInt32`, `(0-0xd7ff, 0xe000-0x10ffff)`


Well, it's embarrassing that I couldn't even think of that.
Keep up the nice kernel work, I'll be always cheering you :)


 `null` is literally nothing. It does not have a data type, value and it does not have a place in the system's memory. The keyword `null` in php is just a representation of nothing. You cannot 'set' something to null because there is no entity that can be used for setting. The `isset()` function takes an entity and checks if it's set or not. If the entity is set, it returns a true value. If not, it returns nothing (null). By this definition, `$foo = null; isset($foo);` would return nothing so `if(isset($foo))` would be false. If you tried to `echo $foo;` after setting it to `null`, it would actually throw a php warning.

Let's take a look at this entire method. The first thing I notice is the method allows for two arguments to be passed in (`$id` and `$userId`). However, the default values for the two arguments is `null`. Default arguments should be used when a method allows for empty arguments and you wish to specify a default behavior. In your case, `findByHunt()` requires an `$id` in order to function correctly. In this case, `$id = null` doesn't make sense. This method should check to see if `$id` is set and if it's not, it should return an error. Also, when calling a method and passing in a empty argument, the value for that argument is already null. So with this in mind `$foo = null` never makes sense ;)


![pipelines - go 2015-06-08 18-32-50](https://cloud.githubusercontent.com/assets/947622/8039951/483565c0-0e0d-11e5-8b12-71ba4cbee731.png)


:+1: ... thanks


Looks like the value from config.h does not propagate through the entire codebase, so without further adjustments having it in `AM_CXXFLAGS` is still required.

Btw followup on make check: just realized that I was running them with cmake-generated Makefiles, so the nice output is thanks to cmake.


minimal code churn.


Was the `weakMap` option not sufficient?


Willl do.


typo ;)


I tried here a new way to pass my array between service and controller.
But this is not working as expected: explication with in-line comments.


Consider moving this number to a model constant so we don't have it twice when we tweak it (hard to match up that many zeros).


I've noticed some lags when you get a big amount of apps in card view at least. SlimLauncher is more fluid in this case, but the vertical and folded stuff is very laggy for now, I hardly think someone uses it though. Only con I see in Nova are the animation speeds overlay, initial scheme(there's and old camera icon messing the whole set and some deprecated widgets) and the free version limits. I'll test Trebuchet a bit more when I get some time.


Why did you change this to 0.13.17 ?


Fair enough, I'll open a PU with my revision(s). Thanks!


Three comments:

1. "His" and "his" are missing

2. There are problems concerning "B" as this is used for "Bb" in german notation and thus is ambiguous. I would opt for a global way to set different name-sets for different local conventions.

3. In addition the list should be extended to allow (at least) for double flats and double sharps.


Err.. If changeOnFly is set it calls updateResultImage(). The first thing updateResultImage() does is call updateAreaCoords(). So...


Yeah, I couldn't get it work.


You know I'm generally in favor of breaking up logic.  But this really isn't that hard, and replacing one line with five seems like inflation to me.  :-P


1:  I broadcast an event when the data is loaded.


Note, the assignment:

    plist [i] = patch ;

on line 506 is not needed if we keep the new "initialize all patches in plist first" loop.  If we want to get rid of the this new initialization loop, we'll need to initialize plist[j] within iteration i before referencing plist[j].


Hi Chris,

This will fault on ARM platforms because of the longword alignment. Since we use imx_usb on our boards, this is kind of a deal killer.

Are you in a position to test on an ARM board? I suspect that just replacing some of the assignments of the .addr field with memcpy will allow this to work.


2: When the event happen, I call a function in my controller.


there is no system ROLE_JOURNAL_MANAGER role.


I will admit that this commit was not thought trough, I use these note
names for myself. But I'm from Iceland where B=H and Bb=B. But I know most
germans and northern europeans can think in the american/english/jazz
system as well.

So I will actually withdraw this commit request if there's no support for
it.

2015-06-08 16:40 GMT+00:00 ormf <notifications@github.com>:

> Three comments:
>
>    1.
>
>    "His" and "his" are missing
>    2.
>
>    There are problems concerning "B" as this is used for "Bb" in german
>    notation and thus is ambiguous. I would opt for a global way to set
>    different name-sets for different local conventions.
>    3.
>
>    In addition the list should be extended to allow (at least) for double
>    flats and double sharps.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hlolli/overtone/commit/96a64a501a4838b9f12c02084bc78118f6ce6745#commitcomment-11571201>
> .
>


In a dev environment, it is convenient to map InfluxDB's ports to your machine so that you can access the Web UI.

My laptop isn't exposed to the internet.


True, but its a double ternary.


in this case I would avoid catching NumberFormatException and let it throw (e.g. wrap RuntimeException around it) just to make usage more clear.


Was directed here after having an error in the "pip3 list" command. Thought it might help others to say that I found this on line 299.
Installed python-pip3 on ubuntu 15.04 server with apt-get.
Found the file at /usr/lib/python3/dist-packages/pip/__init__.py


3: I try to get the list of task (now that it is loaded) in my controller.
But for this I need to use a `timeout` to wait 1 ms, else `getlist()` return an empy array.


silly hack to just get it up, looks like we'll have native ssh in windows soon though :)


Is the new `sienna` color missing?


driven looks better that drven


If you download the latest stable from this link, you won't know its version 1.33.17.
Maybe just change the output filename to xmlrpc-c.tgz or something similar.


I've not yet used CloudChannels as input to CloudFlow.  But my intuition (I may be wrong!) is that this will ultimately need to be a bulk operation where a set of results are collected in a single Receive. Some performance notes on Azure queues seemed to indicate bulk receive was necessary. It seems that CloudFlow is well set up to benefit from bulk-receive?


Why did you change it anyway ?


Because is stable, on my try.
Tried with my system that is Ubuntu server 14.10, Debian 7 on virtualbox & ubuntu server 14.04 lts on virtualbox.


La dismissione e' stata completata con l'allineamento di Database Schema Updater
(92361b16f01ecfebdc71a8e094a5cd3a552b9c0d).


I'm not calling `terminal_failures` multiple times, but I am calling `parse` multiple times with the same instance. https://github.com/sds/propose/blob/ae01d8f1c73466834470431df959dadb18652c8c/lib/propose/parser.rb#L15-L20

This seems like something that should be possible, no?


@balupton The article on the nodejs blog says peerDependencies need to be [lenient](http://blog.nodejs.org/2013/02/07/peer-dependencies/). Is there any reason this plugin can only work with docpad 6.0.0 and not 6.x?


The first error you showing is simply because you don't have "main" function defined (or it is defined not in global namespace).

The second is namespace problem.  Instead of using namespace, just enclose your code in ns3 names (like ndnSIM examples). This would solve the problem.


Are we not supporting BC 6 at all?


Needs moar description


Updated w/ model constant.


Modifica annullata (e69d14dcaa5adb781832dceb74ca0297e0879385).


Ok, renamed it to BaseSettings :) I also moved some docs that were in the FrontierManager to the BaseSettings.


space between } and else


Shouldn't that be `>= 31`?


We can if you want, will require a bit of hackery to make it work. But if you think we need to we can.


please sir,  i cant download this class notes (some)


4: With the `timeout()` everything works fine here.
But without it, `fireBaseTask` is indeed defined but empty when the code runs (`n = 0` and any `fireBaseTask[i].status` is undefined)


Just say anythin three messages


@Freddrickk something like that. I'm not saying that there's actually this possiblity, but if there is, then you're exposing it.

@aviau yes. the problem isn't really the public mapping, it's more the disclosed root password of that public service.


@cwebber: great, thank you!


Es werde Licht


Fixed here: https://github.com/SparkDevNetwork/Rock/commit/03423b1d8d36a04f988f49d41fffa4f9671e10d5


What do you mean exactly ?


Old behaviour: if you passed a Settings instance to the Settings' constructor it would copy it's attributes and you would have a new Settings object, not the one you passed as an argument, right?

https://github.com/scrapinghub/frontera/blob/master/frontera/settings/__init__.py#L41


Done: https://github.com/01org/ozone-wayland/commit/5cf1b19d98a3adc61643390a6079d97b58ed3383


I have not personally tested this, but Ian Brennan did and he reported his findings on the Deltaprintr forum here... http://www.deltaprintr.com/forums/index.php?threads/experimenting-with-overheating-the-hotend.320/


What's the reason for this limitation?  Do only some aggregation functions not work with formula fields?


Yep you are absolutely correct. It is a good opportunity with the rename/refactoring of CloudChannel to CloudQueue to add bulk receive/send methods.


should be += ?


Maybe, but the version that is downloaded and installed is 0.13.4..
Libtorrent versions follow rtorrent..  9.2, 9.3, 9.4 and so on.. You cant just skip versions.


Also, on the "bit dangerous" side, we'll have to make sure that we don't forget one of these holes before going in production. In the heat of things, these are easy to overlook.


You do realize that by doing a live compression of a few lines of javascript on every page load is much slower than actually leaving it uncompressed right? CPU cycles used for that compression are way more expensive than a few KB of bandwidth. Where that compression would've mattered was in combining several files into one not minifying a few KB of in-lined code.

A proper implementation of such a feature for multiple files and types compression with cache function could've been done first by implementing the url() function that was talked about some time ago, that function could've detected files by extension, grabbed them, combine and cache them, then on the next page loads the cache would've been used.


@balupton The article on the nodejs blog says peerDependencies need to be [lenient](http://blog.nodejs.org/2013/02/07/peer-dependencies/). Is there any reason this plugin can only work with docpad 6.0.0 and not 6.x?


@ScottPJones, I agree that the `Encoding` idea sounds great (I mean, I *did* come up with it.... :) ), but let's not rush anything. I know you like to push at a good pace, but let's let things simmer a bit before being too hasty at cramming things in Base. Particularly with design decisions like this (as opposed to bug fixes, performance patches, etc.), we should really take some time to think through possible use cases of a separate `Encoding` type and *all* the corners of the current codebase it could/would touch. I hate the idea of having an isolated `Encoding` type that is used by a small family of methods while the larger string codebase exists without it.
I think there's starting to be some good momentum for a string overhaul (kicked off by @StefanKarpinski's ByteVec PR), so with a big, probably breaking change in strings on the horizon, that would be a great time to factor in an `Encoding` type and maybe `Char{E<:Encoding}` as a part of the overhaul. Those are the exact things that hopefully we can play with in this repo and do a proof-of-concept of how things could look. Having the start of a great, simple, and performant string redesign that someone could play with would go a long ways to getting it into Base.


Please also add this to docs/source/compiler.md


This change seems not to be needed as `newcap` default seems to be `false` already: Running `make hint` with this change in yields the same result as without it (no errors).

In general I only try to list deviations from the default config in `.jshintrc`.


Does kehaar do error handling? What if this throws an exception? Where does the exception get caught and logged? Does a response message get sent?


> Why is `damage === 0` for spread moves but `=== false` for everything else?

This sounds like a bug.


This is pretty silly, but how else would I avoid the "no assert" error?


I'd support an `unbanlist`.


Recommend reconciling this with the literal copy in JobsManagerBase - i.e., lets define it in one place


Wat?


As the commit message says, this is to prevent it from auto-enabling when `"use strict";` is present. To test, add `"use strict";` to the top of lib/parse.js and run `make hint`.


Switch-in poison doesn't work, what? Let me check my repo.


waaaaaa


r+


Why did you add the `verticalScrollbarWidth` here?


I don't follow this description. To make TLK work with ARM TF you have to set SPD=tlkd. This was never an option? In fact, the `tlk-dispatcher.md` does not have the right command. Support for TLKD will be included only if SPD=tlkd is specified with any platform.

To support another TOS, you might need another dispatcher. In that case you need the `SPD=another dispatcher` in your command line. I don't think that with the Nvidia port, SPD defaults to TLKD. It defaults to`none`.

Am I missing something?


I wanted to make something where the controllers doesn't have a direct access to the data and have only the data concerning them.

The `getList` method seems a good way to architecture it ... but needing a `setTimeout()` to call it properly after loading the data doesn't look that good.

I'll continue to dig this matter.


Done :)


Use your super long explanatory powers in a form where users get to benefit from it :)


Looking good other than my one question.


不错哦~


This test passes without any of the validations in `GoogleProvider:get()`


this.get('content').changeTimeStamp(post, dateTime);


Excuse me...I have realized just now that i was talking about another thing, is a typo error..
I am talking about xmlrpc-c...
Sorry again mate. i just fix it in some minutes.


This line is not needed.


This passes without any of the validations in the `GoogleProvider:get()`


mind including only the minified versions ?
;)


Are you going to continue work with this or should we merge so that thus won't rot in the branch?


Haha no problem mate :) .. Your doing a good job.


return (this.get('selectedPostsCount') === 1);
Replace this line with Line 504.


No way to call shfix_session_behaviour because need shfixrun=1 & only can be change manually from 0 to 1....

A normal user doesn't benefict of shfix xD... &
an advanced user doesn't need this because know that have to change to default Android shell :)


saw approval from MonsieurNicolas
at https://github.com/jedmccaleb/stellar-core/commit/7fd1bb3322b1e49096a3fddae631940798ef5d5b


merging jedmccaleb/stellar-core/fetch = 7fd1bb33 into auto


jedmccaleb/stellar-core/fetch = 7fd1bb33 merged ok, testing candidate = 9c257ac1


This test requires the first validation in `GoogleProvider::get()`

```
if (substr($href, 0 - strlen(self::PATH)) != self::PATH)
{
    $href = $href.'/'.self::PATH;
}
```


Oh, after looking again I meant `AfterSwitchInSelf` which you removed in https://github.com/Zarel/Pokemon-Showdown/commit/4f246f7032bda7de13146a8e2d5480c64c204c64 for some reason.


TeamCity YaccConstructor :: YC.Core General Build [Build 434](http://teamcity.codebetter.com/viewLog.html?buildId=192880&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


Nice catch. I'll return text if ply isn't valid then.


It looks much better, thank you. One question: did we remove note about the OpenStack security groups from the docs in purpose? In the past we had something like [this](https://github.com/CiscoCloud/microservices-infrastructure/commit/f577edcf3fdbedf635c3b44cd1f66a8a4c80e2ad).

By my public key I meant the following [line](https://github.com/CiscoCloud/microservices-infrastructure/blob/master/terraform/openstack.sample.tf#L6).
I set the variable with my public ssh key, but it appeared that it should be a path to the ssh key, not the key itself. Sorry, I just should have checked the terraform docs.


lol


@cpennington

1. 2 are used to fetch the bookmarked block itself using `get_item()`.
2. 2 queries are used by `path_to_location()`.
3. Since `path_to_location()` returns `UsageKeys`, 2 queries are used per ancestor when calling `get_item(ancestor_usage_key)` to fetch the ancestor block.

I am not fully familiar with the internals of `get_item()`. Do you know of any way to reduce any of these queries?

But also consider that once the cache is filled up, `get_path()` will not get called at all when bookmarking blocks which only have a single path to them: https://github.com/edx/edx-platform/blob/a5076d7b0ee476f9a39bdafb5c996654c0367025/openedx/core/djangoapps/bookmarks/models.py#L144

So only in rare cases will queries in (2) and (3) happen.


Need to configure 'web' and 'web-tls' for tests.
Tests need to prove http requests are forwarded to https.


@westcripp can you help me find out why the trigger isn't showing in it's settings? And the complete circle bar isn't sowing either...
https://github.com/OwnROM/android_packages_apps_Settings/commit/0fb1d0aa6599974494d6be6ad78028dfc53505fd


These two tests requires the second validation in `GoogleProvider::get()`

```
if (!(stripos($href, 'http') === 0) and !(stripos($href, Directory::PATH) === 0))
{
    $href = Directory::PATH.'/'.$href;
}
```


Sorry why? apache2-utils is not installed first of this check


Sorry, I'm quite busy with my work life, but I'm watching you guys :smile: I had to stop here and make a comment.

Please don't compress client side scripts *dynamically, on each requests* using server side tools :disappointed: If we are including this, I'd appreciate if at least this could create a static file somewhere on ftp.

Also, why not keep both pre-compiled versions (minified, non-minified) in ftp and switch with a simple click?

Also nowadays these stuff is handled more with asset management tools such as gulp, grunt etc, which can both concat, minify and build assets such as css, js etc. This can't be easier.

An example gulp file for my latest laravel example app, which downloads assets like bootstrap, font awesome, jquery etc. from npm repositories, copies fonts , merges css and js files with app's specific ones, minifies them and copies to public folder, can't be easier to integrate, took me maybe 2 hours to understand gulp:

https://github.com/Ardakilic/WhatTheTag/blob/master/gulpfile.js


Should $rootScope.$digest() be added to verifyNoOutstandingRequest() as well?


TeamCity YaccConstructor :: YC.Core General Build [Build 434](http://teamcity.codebetter.com/viewLog.html?buildId=192880&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: Error during Nuget update. ..\tools\Build.Tools\NuGet\NuGet.exe install "Z:\Builds\work\4138ce7c6332a78c\src\FsYARD\packages.config" -OutputDirectory "..\src\packages" -ConfigFile "..\src\NuGet.config"   at FSI_0002.Packaging.restor... Build time: 00:03:00


Delete this file!


Should be part of another PR no?


I don't think that's how the OnPlayerChat hook works. Shouldn't you call the base class's method which will call chat.AddText?


tested and working


This line was bugged, it wouldn't create a Settings objects, as it previously was. Fixed.


For some reason, when I delete the file in site-static, it doesn't show on the commit. Git rm doesn't know that there is a file existing there. Even when it is deleted manually, it doesn't show up.


Yeah, just noticed that too — sorry for the noise. JSHint is really weird here having the default different in strict and non-strict modes while not mentioning strict mode at all at the [`newcap` option docs](http://jshint.com/docs/options/#newcap).


I'm thinking this has to do with the fact that the site-static files aren't used (to my knowledge) in the site.


Yeah. I'm just going to skip everything in the hook if the player isn't valid and call baseclass.


There's no need to convert back and forth between time.Time and unix int64.


Cause subversion package is not need never than for this line


This query now has a syntax error (missing AND).


I meant I'm going to not modify the text in the TTT OnPlayerChat hook


Sorry.. What I meant was that I dont like the  debconf-apt-progress part :) .. Unnecessary ncurses graphics.


Let’s keep the code in `peg$subclass` and `subclass` unchanged when the `validthis` option suppresses the warning anyway. I find it more readable & idiomatic that way.


resolved via 1f253d32bf71eef5c5881978fa1054c3a2dcf7be


@weltling  I agree. We could make it a compile-time option.


Okay.. I like it. But you should properly fix the static version issue.


Sorry :) Next time, for sure!


The options are alphabetically sorted, please keep them that way (also applies to your first commit).


Fixed here: 075021c


@rnaveiras How can I insert here a innodb status message, without breaking the log? (as it will very likely contain whitespaces or K=V, substrings)


The option `public_read_write` is generally not recommended, and should make a note of it.
http://docs.aws.amazon.com/AmazonS3/latest/dev/acl-overview.html#canned-acl


@hsoft Disclosed? This is the default password for InfluxDB.

I am open to suggestions. What would you do?


It was working before (AR and STRIP are set properly).  But there were 2 warning messages being emitted about "Excpect not found".  The AC_PATH_PROG started out with a comment, BUT that was jammed onto a assignment, and the shell did not know how to react.

https://github.com/magnumripper/JohnTheRipper/commit/8bff8a623639cd496bfc46a71b2e52e8bdc35079


:+1: this looks good.  I would like to test it at some point to make sure there is no race condition, but this looks like it should work just fine.  If you have a sandbox for this at some point, let me know and I test.


You can remove the artwork by setting the background in the grub settings.
Or would you prefer to store pngs on nixpkgs like we were before?

On Mon, Jun 8, 2015, 09:30 lethalman <notifications@github.com> wrote:

> going to revert this tomorrow, I don't want a solution like #8232
> <https://github.com/NixOS/nixpkgs/pull/8232> just for a different
> background
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/1e98da6d992522ae26bc37bb670b09805f44b762#commitcomment-11571039>
> .
>


Great, thank you Steve! The pull request is already corrected and
rebased on the current master, ditto for tests.

I also wrote VPI functions to scale time to/from simulator time units:
https://github.com/orsonmmz/iverilog/commits/time_vpi
https://github.com/orsonmmz/ivtest/commits/time_vpi_test

They are not yet used by vhdlpp, as neither I nor I think anyone else
would take advantage of them right now. If you think they are worth
merging then go ahead, otherwise they will sit there waiting for the
moment they are eventually useful.

Regards,
Orson

On 06/08/2015 05:31 PM, Stephen Williams wrote:
>
> the solution, I think, is to use the gn_system_verion() test to know
> if you are in SystemVerilog, set the reg_flag to true only if
> gn_system_version() is false. I'd accept that patch.
>
> On 06/08/2015 04:40 AM, Maciej Sumiński wrote:
>> I have reread the standard carefully, and I think it is correct to
>> accept "input wire time" ports. Below you can find my reasoning
>> with references to the SV-2012 standard:
>
>> * Grammar rules that permit "input wire time" port declaration:
>
>> net_port_header ::= [ port_direction ] net_port_type
>
>> port_direction ::= input | output | inout | ref
>
>> net_port_type ::= [ net_type ] data_type_or_implicit (...)
>
>> net_type ::= supply0 | supply1 | tri | triand | trior | trireg |
>> tri0 | tri1 | uwire | wire | wand | wor
>
>> data_type_or_implicit ::= data_type | implicit_data_type
>
>> data_type ::= integer_vector_type [ signing ] { packed_dimension }
>> | integer_atom_type signing
>
>> integer_atom_type ::= byte | shortint | int | longint | integer |
>> time
>
>> * Data type
>
>> Table 6-8 in point 6.11 describes time as "4-state data type,
>> 64-bit unsigned integer", which sounds to me as equivalent of
>> "logic unsigned [63:0]", as you have also noticed. Port declared
>> with "input wire logic unsigned [63:0]" is accepted by Icarus and
>> works as expected.
>
>> Regarding the doubts about changing the meaning of "time" type,
>> here is what Verilog-2005 says: "Almost all of the data types in
>> the Verilog HDL store all four basic values." (4.1) "The time
>> variables shall behave the same as a reg of at least 64 bits, with
>> the least significant bit being bit 0. (...) In contrast, integer
>> variables shall be treated as signed regs with the least
>> significant bit being zero." (4.8)
>
>> It seems to me that time is also defined as 4-state data type of
>> 64-bit width, equal to 64-bit unsigned integer in SystemVerilog.
>
>> Also, if time is a particular integer type, then there is an
>> example in the standard that uses "input wire integer" (very end of
>> 23.2.2.3 point):
>
>> |module mh22 (input wire integer p_a, .p_b(s_b), p_c); logic [5:0]
>> s_b; |
>
>> I am going to leave the final decision up to you, as logic
>> unsigned [63:0] will also work for me. Perhaps the reg_flag should
>> be based on the used standard?
>
>> — Reply to this email directly or view it on GitHub
>> <https://github.com/orsonmmz/iverilog/commit/83849fdb8aebf4a6b954a9d1633ba88c2270a1dd#commitcomment-11565326>.
>
>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/orsonmmz/iverilog/commit/83849fdb8aebf4a6b954a9d1633ba88c2270a1dd#commitcomment-11569775
>


Software Requirement
1. Download "Wamp Server" Link-> http://www.wampserver.com/en/ for windows platform and For Linux Install "LAMP


Have the init script generate a password and then set it somewhere that is *not* in the repo.


After show is called? or after the window is actually on the screen?
I was using this, just to open the door to initialize `FigureManager` without any `Figure`.


or, bind it to 127.0.0.1:8086? I'm not sure how that works with docker-compose though.


Thanks :)


I might be able to lash up a test rig using my phone or something.
On Jun 8, 2015 9:41 AM, "Eric Nelson" <notifications@github.com> wrote:

> Hi Chris,
>
> This will fault on ARM platforms because of the longword alignment. Since
> we use imx_usb on our boards, this is kind of a deal killer.
>
> Are you in a position to test on an ARM board? I suspect that just
> replacing some of the assignments of the .addr field with memcpy will allow
> this to work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ckuethe/imx_usb_loader/commit/28837c95fb61806ac6791cd32b8ae1c91c29a768#commitcomment-11571256>
> .
>


TeamCity Azmq :: Build (Windows) [Build 126](https://78.46.71.115/viewLog.html?buildId=488&buildTypeId=Azmq_Build&guest=1) is now running


TeamCity Azmq :: Build (OSX) [Build 80](https://78.46.71.115/viewLog.html?buildId=489&buildTypeId=Azmq_BuildOsx&guest=1) is now running


TeamCity Azmq :: Build (Linux) [Build 96](https://78.46.71.115/viewLog.html?buildId=487&buildTypeId=Azmq_BuildLinux&guest=1) is now running


Hmm? This is wrong. set_consume() only frees the passed parameter on failure. But on failure we return from the function early or continue immediately to the next iteration. I don't see anything to fix...


lil nature boy


这回好了


TeamCity Azmq :: Build (Linux) [Build 96](https://78.46.71.115/viewLog.html?buildId=487&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:03:00


nice


TeamCity Azmq :: Build (OSX) [Build 80](https://78.46.71.115/viewLog.html?buildId=489&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:03:02


We should make a note that bucket policies are, however, required as well.

Plus, a link to this page would be helpful. http://docs.aws.amazon.com/AmazonS3/latest/dev/example-walkthroughs-managing-access-example3.html


OK, but do you understand that having `Encodings` and my new & improved `check` function, instead of what's currently in #11575, will help fix a number of other Unicode related bugs?
There are a number of problems that have come from conflating the encoding and way it is put in storage...


@magnumripper yep, my bad. I am lucky when it comes to force-pushing ;)

@frank-dittrich yep, known.


TeamCity Azmq :: Build (Windows) [Build 126](https://78.46.71.115/viewLog.html?buildId=488&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:03:40


TeamCity Azmq :: Build (OSX) [Build 81](https://78.46.71.115/viewLog.html?buildId=491&buildTypeId=Azmq_BuildOsx&guest=1) is now running


TeamCity Azmq :: Build (Linux) [Build 97](https://78.46.71.115/viewLog.html?buildId=490&buildTypeId=Azmq_BuildLinux&guest=1) is now running


TeamCity Azmq :: Build (Windows) [Build 127](https://78.46.71.115/viewLog.html?buildId=492&buildTypeId=Azmq_Build&guest=1) is now running


i ll accept this pull request.
therefore, there is a test that should be done later (and i created an issue for it):
    https://github.com/unix-thrust/beurk/issues/58


Updates gphoto2 location. Gonzalo's version tries to pull an obsolete version of libusb.


TeamCity Azmq :: Build (Linux) [Build 97](https://78.46.71.115/viewLog.html?buildId=490&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:14


TeamCity Azmq :: Build (OSX) [Build 81](https://78.46.71.115/viewLog.html?buildId=491&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:16


TeamCity Azmq :: Build (Windows) [Build 127](https://78.46.71.115/viewLog.html?buildId=492&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:16


Hey fmoo,

Thanks for the feedback. Will update with the requested feedback. Do you like the idea of keeping the prop name `defaultSelected`?

WRT just checking direct object reference, the getInitialState function explicitly creates a new array (https://github.com/amplii/react-typeahead/blob/master/src/tokenizer/index.js#L36). I also wanted to check for differences because it's possible people will be updating the different props besides defaultSelected and don't want to accidentally remove all of the selected items. Doing a shallow array diff should solve this.

I don't think the performance hit will be too bad. IMO if there are 1,000 tokens, the UI will look terrible and the app dev should probably come up with a different design paradigm. Even diffing 1,000 items is super fast: https://jsperf.com/array-compare-n-items-2. My laptop was able to compare lists of 1,000 items ~30,000 times in .05 seconds. It was able to diff 1,000,000 items 300 times in .05 seconds.


That is supposed to be done in the modern gen engine with an `if (this.gen <= 2)`


Popover content loads right away and no more dirty manual CSS needed for positioning it,


I don't think this is such a huge deal, especially since we only use `log_flow` with string literals. I'm inclined to roll back the templetization and revert the argument to an `std::string` or even a `char const*`.


Правильнее создавать configuration внутри get_agent_config() и возвращать с помощью return:
configuration = get_agent_config()


Wanted to fill in the answer for posterity: When scrolled to the right, we still want the tiles, lines, and highlights to extend underneath the vertical scrollbar to the edge of the window in case it's transparent. Hence we add its width.


The docker image we are using for InfluxDB does not support changing the password.

In production, we won't run InfluxDB inside a container so we will edit the docker-compose.yml to include the actual password.


Что мешает сразу привести к int это значение в get_agent_config()?


It's worth noting that when `publish` becomes a thing, this will also take down a published project. Probably not worth including right now though..


@retlehs I would appreciate if you could review this commit (fixes -- https://meta.discourse.org/t/links-in-imported-blog-comments-are-relative-broken/29282?u=techapj)


Django reports an import error when the settings.py file has an error as well as when it is not found.

Try this:

```
 (develop %=)(pgd)jmt@cyan:~/git/osuosl/pgd$ docker-compose run web bash
[root@4f700425c3db pgd]# python manage.py shell
Python 2.7.5 (default, Jun 17 2014, 18:11:42)
[GCC 4.8.2 20140120 (Red Hat 4.8.2-16)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> import pgd.settings
>>>
```

Tell me what you get!


Well, last time I checked it had a static ip assigned at the router level. Let's hope no one will change :smile:


Hi Hlöðver,

Am Montag, den 08. Juni 2015 um 09:43:12 Uhr (-0700) schrieb Hlöðver Sigurðsson:
>
> So I will actually withdraw this commit request if there's no support for
> it.

 why withdrawing? I think it is a useful suggestion and feature and no
big deal to implement anyway. I'd suggest, you just leave it there and
we wait and see what happens ;-)

--
Orm


Don't we have restrictions on which files we'll accept into a project? This would be a good place to enforce that.


similar creature towards wall-flowers, but more smelly


s/downlaod/download/


Вместо этого просто task["state"] = "Running"


Здесь просто вывести состояние задания (Waiting или Running, не важно)


Shouldn't this be automated? At the very least, the raw data itself can be stored somewhere (say, in some `info.txt`), and then `sets.dart` can read it somehow. (You could have a top-level `info.txt`, or put one in each set's directory; in the latter case, Dart should scan the directory for subdirectories and register as sets anything with an `info.txt`.)


This looks great. Will be nice to have testable code fragments and this sets up a good framework for it.


Are there restrictions on which files we'll accept? Anyway, this is not going to be taken in the PUT/POST so the client doesn't really have control over this, the server determines what the mime type is.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/65921180


Thank you; I also caught this and patched with https://github.com/kurttheviking/ipnation/commit/d7c7384fb267c1215043c9bcb62652d7eb823079


@SinghAsDev @junrao Can you tell me which mvn depenency for running this example ?

I'm using:
    <dependency>
            <groupId>org.apache.kafka</groupId>
            <artifactId>kafka-clients</artifactId>
            <version>0.8.2.1</version>
        </dependency>
        <dependency>
            <groupId>org.apache.kafka</groupId>
            <artifactId>kafka_2.10</artifactId>
            <version>0.8.2.1</version>
        </dependency>

and getting the following exception:

Exception in thread "main" org.apache.kafka.common.config.ConfigException: Invalid value org.apache.kafka.common.serialization.IntegerSerializer for configuration key.serializer: Class org.apache.kafka.common.serialization.IntegerSerializer could not be found.


I just pushed a new commit that makes this load every proto file in the specified directory.


I'm not sure I follow your comments:

> new & improved check function
as @tkelman mentioned, I'm not sure we're really seeing a huge improvement by putting two methods together with a big `if E <: UTF8` to split most of the method in two. It smells of a need for further refactoring into other methods and use of dispatch.

> will help fix a number of other Unicode related bugs?
You mean, your PR here has fixes that are not included in JuliaLang/julia#11575? Why can't they be included there?

> There are a number of problems that have come from conflating the encoding and way it is put in storage...
Can you expound on this point? What's an example of a specific case where the encoding and way it is stored? I'm not doubting, but I just don't what this problem looks like necessarily. How does the new `Encoding` type specifically address these issues?


Nice!


I just pushed a new commit that removes it.


Line 39 should actually read:
RecordType.getSObjectType().getDescribe().getName() };
I messed up when I transferred my changes in since I typed it instead of copy/pasting it. I missed the parenthesis after getSObjectType. If you use RecordType.SObjectType that is actually a field, not the SObjectType of RecordType.


Yes, they're intended to be inclusive. I'll make a note about this in the readme. The thinking is that the end date is the last day that the reporter had an opinion. To me at least, that feels more intuitive.


I thought I had taken care of that one. Guess not. Commit https://github.com/CiscoCloud/microservices-infrastructure/commit/f8da7e5


Переименуйте vina_run, это же теперь универсальная функция.


was this intentional?


@roconnor Arg, that's my fault. Probably a left-over from the package I based this on.
I'll remove you in a new PR.


I install the package into
/usr/lib/freecad/Mod/plugins/WorkFeature
and run it with
import sys;sys.path.append('/usr/lib/freecad/Mod/plugins/WorkFeature');import WorkFeature;reload(WorkFeature);m=WorkFeature.WorkFeatureTab()


since family isn't used as a key in the map, you can remove both this overrides at all


I moved the period to the end of the sentence. I'm not sure if you wanted it removed completely, but I thought that would be inconsistent with line 13.


This line isn't Python3 compatible.


how do I bind to this event?


* Indent discrepancies was due to github's 8 space tabs policy; thanks for pointing it out. I've replaced all tabs with spaces for consistency.
* I've added a few more backticks than you asked to comments I hadn't touched before so weren't in the diffs, for consistency again.


I implemented this now, but I think it is dangerous. By this every user of the API can crash your instance ...


This causes an error when building/installing Mongrel 2 from the tarball.

https://github.com/zedshaw/mongrel2/archive/1.9.2.tar.gz

In the tarball there is no Git repository at the project's root directory.


fast-forwarding master to auto = 9c257ac1


Does not seem to be necessary.


Those are needed? why?


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Necessary?


what it should be then?


Turned ON Spark's Shuffle service


Не имеет смысла использовать update(), он нужен когда надо добавить в словарь сразу несколько ключей.

task["Reason"] = "Command not found" # выглядит читабельнее


I'm not sure why you wanted a period here and at line 20, since the rest of the website never uses periods in the playpens.


Не имеет смысла использовать update(), он нужен когда надо добавить в словарь сразу несколько ключей.


...but that's just about styling.... try it with lxde/lxqt-common@0eaa9fd


@hargup this was a debug print, right?


Oh nice! I'll try it as soon as I get my replacement thermistor.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7447/testReport/) for this commit**


`Family` is used as key in `Engine`. The `equals()` implementation could indeed be removed, but that is not an improvement.


task["State"] = "Failed"


@Ghazi-Bouabene  this was intentionally left unimplemented. As you say, it could be implemented with a bfs. However, to make this clean, we should introduce neighbors to a cell, etc. This requires another level of discussion, which I would not like to add to this pull request. But I will open an issue, such that we don't forget about it.


Is there a usecase for one-way references?


looks good


It shows error in the PreviousTime execution and terminates abruptly. So that portion is commented.


Fabrice, I second what Andy said, we don't use uppercase for normal variables like this, even if const. All uppercase is reserved for module *global* constants.


Recommend using Path.GetDirectoryName for stuff like this


Поправьте отступ в блоке внутри except


@jpfr they are in the XML files...

@jpfr @ichrispa i'd like the generator to use only userland functions
okay hmm i propose the following:
https://gist.github.com/Stasik0/1787dee45a9d3e517777


remove extra line


Which 2 queries are called for `get_item`?


@teg everything that depends on shared now depends on libidn due to moving the dns routines into shared, which call libidn if it is used.


Зачем что-то возвращать?


No, this PR does not have any extra fixes.
This PR (placed in #11575) and merged into Base, would allow me to deal easily with the code that tries to look for a BOM, and possibly do a byte-swap operation.  The current code is inconsistent between UTF-16 and UTF-32, and I pointed out elsewhere that this would help me be able to fix #11463, #11501, and #11502.


`EmailIntegrationTest.testEmailImages` again


oh, i see. yes! i will move it.


module_name is renamed to model_name in Django 1.8 https://docs.djangoproject.com/en/1.8/internals/deprecation/


@hfaham is working on it


@goru97 As far as I know, 2 query params with the same value may not work. "sum" maps to Counter_Value and also SUM (that returns the TimerRollup sum). Can we get rid of Counter_value altogether and return
```
((CounterRollup) rollup).getCount();
```

for Sum instead?


I'd prefer if at least the warn_if_unavailable check would:

Always log, at least at level LOG_DEBUG. So that warn_if_unavailable would only choose between LOG_DEBUG and LOG_ERROR, but not remove the warning entirely.

Also, I think if the error we get is != ENOENT, then we should always log at LOG_ERROR, even if war_in_unavailable is false...


should we handle this TODO before pushing changes to master?


dfsfsf


Yes, I can get used to it. GTM.enfim


"Type predicate is..."


rax retry tests


There doesn't seem to be an earlier check to make sure that the code really is RA/Dec and not GLON/GLAT. I suppose there never was so this patch isn't making things worse.


> Do you want me to add comments to the code?

Yes, please.

- Chris


Please ignore


Nit: I'd simplify StopWatcher to just "Stop". Same for any Start method


I moved this line to join with other CC variables.


I would just take a BindingPattern for the parameter


hi
 pasa me un bin q jale en xoom para pagar mis estudios xd gracias


It's necessary only export the variable.


Jacek, Fabrice is actually following our conventions, if you look at
"3-3. Named constants (including enumeration values) MUST be all uppercase using underscore to separate words."
and if you believe that this represents constant then it must be upper case. I do disagree with that requirement, but it is a strong requirement :) In other conventions all-capital means (bad) macros.


The $('#site-nonfx').hide() was to hide the current CTA on the page seen below:
![screen shot 2015-06-08 at 10 51 32 am](https://cloud.githubusercontent.com/assets/9794516/8041336/5aa7c3c4-0dcc-11e5-9cfd-c47ce0aaa973.png)


This is ok, but it show that we shouldn't have tried that optimization at the first place. Do you have an idea why this is now triggered, but wasn't in the past? I'll do another review of this PR in case it help me understand what is going on.


Best I can do is 5. Also the range limit is 8.
So 95 1 tile away, 55 8 tiles away, that's close to what I wanted originally.


Space before paren


Just re-write it as:
`className={classNames(this.props.className, this.getBsClassSet())}>`

there is no need in an additional line: `let classes = this.getBsClassSet();` L#152


I accidentally deleted the comment, so...

"""
Not quite. It's something I noticed even before I started tinkering with debugging. It's a fix for
https://github.com/boundarydevices/imx_usb_loader/commit/3250175b2e6ec138f68a3e7a16ac80161dd85527#diff-f98eb6afc4d66afe840df4d83b818aabR53

AFAICT, those the R_OK and access() macros shouldn't be inside DEBUG.
"""


>Can you expound on this point? What's an example of a specific case where the encoding and way it is stored?

For example, there are currently methods to convert to `UTF16String` / `UTF32String`, from `Vector{UInt8}`,
which assume that they will find either `UTF16LE` or `UTF16BE` for `UTF16String`, and `UTF32LE` or `UTF32BE` for `UTF32String`.  That totally misses that you may really have a `UTF16` (either endian) or a `UTF8` stored in the `Vector{UInt8}` that needs to be converted to a `UTF32String`.
The other thing that my new code handles is to handle not just `Vector{UInt8}`, but also `AbstractVector` and `AbstractArray` [I haven't had a chance to try what you suggested about just being able to say `AbstractArray{UInt8}`, the old code actually does a reshape in some cases with `AbstractArray`...,
so I assume that there must have been *some* reason they kept those separate...]


Font-size extremadamente pequeño :/


We haven't released this change yet. So, it's only available in trunk.


Procura no fijar alturas a los contenedores. Esto es una web, no algo para enviar a imprenta.


Можно добавить в error значение process.returncode


The code is good, but the name misleading. Can you use

`node = var.owner`

to be more clear.


I think more cleary about `_remap`.
How about like below?
```php
		if ($method === '_remap')
		{
			return (! method_exists($class, '_remap'));
		}
```


This variables are internal to golang and I have not used them.


I forgot you included this change in this PR, that explain the last commit. So all is good. I'll merge this PR after the name change I did in another commit.


It's up to you, but if you broke it out to a normal function, you would pass `typePredicate` and `typePredicateNode` as arguments, and hasReportedError would be the return value.


weird. that was a mistake :grimacing: either of ya'll wanna make a PR?


Estás siendo demasiado específico.. Recuerda que porque SASS permita anidar no se trata de anidarlo todo.


df


Approved. Seems to be fine.


I think we should use element.offsetParent != null for this.
Please see: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetParent


Utiliza mejor copys en minúsculas y pasa a mayúsculas mediante "text-transform":uppercase;


remove these two lines


This should be labeled "LSST headers"


Or better yet, for all three error messages, "A type predicate is..." and "A type predicate cannot..."


remove this line


Good fix! Can we get these changes merged in upstream? (i.e. into the CodeCore repo this was forked from)


Tienes una etiqueta más semántica para tal efecto llamada HEADER


@mhebing: http://www.ddionrails.org doesn't go anywhere: did you mean http://ddionrails.org

If you can fix that and update the PR then I'll merge it!


Hi maximebiloe ,

Sorry for troubling you so much and now I got your point completely.

While testing on my website I found that two vochers are compatible with each other when both have cart_rule_restriction field set to 0.
Other scenario is , voucher with cart_rule_restriction to 1 is combinable with other voucher having cart_rule_restriction set to 0 when the latter one is present in the former combinable voucher list.

Thanks


My vote is even shorter :) - 0ms would be ideal.


I WILL DESTROY YOU


let's put 3rd argument on separate line


`return;` looks unnecessary.


El FORM necesita un atributo "action" obligatoriamente


could we "handle log correctly" before closing this ticket?


Merge #2981.


What is x for?


Прежде чем делать chmod, надо проверить, что исполняемый файл лежит в папке задания (был загружен вместе с заданием). Если command ведет на файл, лежащий вне этой папки (программа установлена на машине отдельно), то делать chmod не надо.


Issue: an overlay sticker is technically a part: https://github.com/cubing/wca-documents-extra/blob/master/style-guide.md#definitions

@KitClement I think the clearest think would be to add: "Exception: An overlay sticker (see Regulation 3l)."


I have renames the js file as text file also to avoid any email block.

Please disable the browser security and test this application.


Ok. I am happy that this issue is fixed then. Thanks for the feedback.


there's no need for this regex anymore. The regex on the line above takes care of ensuring we're working with a URL and also captures into `$+{domain}`.


Adivina que! También hay otra etiqueta FOOTER para indicar a los crawlers que vas a colocar contenido en el footer de la página :smiley:


@azturner So for this to work, we need a top-level location that's designated as a LocationType: Campus?


Nothing, it's pretending to do work just adding up all of the bytes


You can simply `return $+{domiain};`


Agrupa propiedades


It seems strange that you're passing ListJobNames to the watcher. Is this just a vestige of the refactoring - can ListJobNames be removed from the manager class since it's not used there anymore?