@RogerTangos Did you mean to change the permissions on `src/browser/static/lib/jquery-terminal/css/jquery.terminal.css` to make it executable?


Ok, I'll remove it here and from my best practices :)


bonjour


Actually remove `get_file` and the `utils` module altogether. There is no reason to support remote files since this is all being driven by the command line. It is easy for the user to download the file first.


I'm not sure I can see when someone would not have entered/left dates - they all do, don't they?


Yeah, right my fault. I forgot to flush the currently displayed sample.


/ !!!!! \
Quand il n'y a pas d'accolade, le if ne porte que sur la ligne suivante, il faut faire très attention à ça.


Sorry, set the default value for `delimiter` to `None`, so that is will indicate a *sniff* is needed.


I'm a bit confused about the shadowing issue you mention. Perhaps you've run into a problem before that I haven't run into. Can you be more specific or give me an example of how this can go wrong?


I need to double-check something though because I remember thinking about it and about a possible problem before forgetting completely.


很好的建议，我没这么做过，试着拆了一下，貌似还不错。


Please use `git pull --rebase` and avoid using a GUI for Git to avoid those kind of useless merges.


You need to deal with max length names.  Use util/namer.go


no "ad" for advertisement


Hasta donde yo sé las clases se nombran siempre en singular...

2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <notifications@github.com>:

> En realidad la convención es:
> En controllers: "si es un solo recurso es singular, si son varios es
> plural". Nosotros tenemos varias melodías.
> En rutas: siempre plural.
>
> Source:
> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754>
> .
>


Link to issue #17


Do you think you could add a unit test to demonstrate the defect to guard against future regression?


That will avoid broker allocation without needs.


Mediawiki extensions are always being worked on, that is fine. For deployment they usually don't get versioned releases, each week a branch is cut. The result is somewhat in the direction of continuous deployment.
However that means master should not be broken. Is anything currently broken on master?


Please make sure your project can compile for everyone before pushing.
Also, make sure you actually track files.


Yes, I considered that. However, it means that the user needs to call `super.setUp()` themselves. I thought maybe one would just want to write the extra piece of logic; I rather avoid suggesting people to follow conventions and preconfigure for it.


Igual aguantame que me olvidé de correr los tests... Me olvido que el CI te
buchonea todo :(
¿En teoría no debería buildear sólo cuando hay commits contra master?

El 12 de junio de 2015, 14:45, Javier Sorella <javiersorella@gmail.com>
escribió:

> Hasta donde yo sé las clases se nombran siempre en singular...
>
> 2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <notifications@github.com>:
>
>> En realidad la convención es:
>> En controllers: "si es un solo recurso es singular, si son varios es
>> plural". Nosotros tenemos varias melodías.
>> En rutas: siempre plural.
>>
>> Source:
>> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754>
>> .
>>
>
>


XMLDBException one, just give back that command wasn't executed because of missing resource parameter.


insta*n*ce


Jajaj, buildea siempre, pero solo avisa cuando lo rompés (igual eso se
puede configurar :P)

El 12 de junio de 2015, 14:47, JSorella <notifications@github.com> escribió:

> Igual aguantame que me olvidé de correr los tests... Me olvido que el CI te
> buchonea todo :(
> ¿En teoría no debería buildear sólo cuando hay commits contra master?
>
> El 12 de junio de 2015, 14:45, Javier Sorella <javiersorella@gmail.com>
> escribió:
>
>
> > Hasta donde yo sé las clases se nombran siempre en singular...
> >
> > 2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <notifications@github.com>:
> >
> >> En realidad la convención es:
> >> En controllers: "si es un solo recurso es singular, si son varios es
> >> plural". Nosotros tenemos varias melodías.
> >> En rutas: siempre plural.
> >>
> >> Source:
> >>
> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754
> >
> >> .
> >>
> >
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658863>
> .
>


The dialect contains the quote character (the delimiter too).


Oh, rats! Saw the release increment and grabbed it before realizing this patch didn't go in. Think it'll be today or next week? Thanks!


set stuff looks good


Question: what did you have in mind for usage of `set_root_cache!` and related methods?


A perfect example how bugs can creep in unnoticed. ><


`~1.0` would still work fine...


not at all. Just switched it back go 644.

Albert Carter

Programmer
Big Data Initiative
CSAIL, MIT

On Fri, Jun 12, 2015 at 1:40 PM, Justin Anderson <notifications@github.com>
wrote:

> @RogerTangos <https://github.com/RogerTangos> Did you mean to change the
> permissions on
> src/browser/static/lib/jquery-terminal/css/jquery.terminal.css to make it
> executable?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abhardwaj/datahub/commit/fa5d6459742e7ba149b93ad8792e089e11422ea1#commitcomment-11658763>
> .
>


Done.


@MikeZTaylor you need to make sure that you don't change the indentation anymore. The index.html files are very hard to code review since all the content of the files appear as changed(I doubt you've changed everything). Please contact me Monday morning so we can get this sorted. Thanks, enjoy your weekend!


Removing `utils` requires all of the code that detects the dialect and instantiates the CSV reader to be put in the `with open()` block below.


Just use `filepath.Join` and you can get rid of the if helpers.File ..


I wonder if an image describing the architecture would be helpful here, as well as break up the Readme.


angular.js scopes are a good example because they illustrate it in a way that really frustrates people and is easy to identify:

```js
<p>{{someText}}</p>
<div ng-if="showEditor">
  <!-- Context object here (within div[ng-if] prototypically inherits
        from outer parent scope --- So ng-model will shadow the
        outer `someText` value in this scope, which is not what
        the author wants, probably! -->
  <input type="text" ng-model="someText"><br>
</div>
```

It's all about making sure the receiver of `[[Set]]` is what you expect it to be, and accessors will make that work properly. Data properties in the prototype chain are generally frowned upon


Fix indent formatting for the constructor.


Remove the `newline` parameter.


Document what the header maps to for a data dictionary.


It is hardcoded intentionally, there won't be any more release on the fork.
As soon as phpseclib releases, the fork will be dropped.


thank god...you are the best..
i thought that will cause us big trouble..
thanks very very much...
i will try to see the merge conflict.
thanks again


This commit on it's own would be worthy of a pull request (and would make your end-result diff easier to review)


My only concern was that this if statement was to prevent duplicates being added to currently selected vocabulary when the refresh button was clicked. but I guess the backend handles this because a 500 response is thrown.


@RogerTangos Isn't `[\w|\W]+` the same as `.+`?


Document what the purpose of this condition is.


yield svc.postStatsValue(prop_name,...)


Nit: Define GKE -- it's not obvious that GKE maps to Google Container Engine


Thank you!


this methods needs to be an inlinecallbacks or return a defered


looks way better, please move the inline style(padding) to the less files and I am +1


switched from a to b?


same here => inlinecallbakcs


This is not required with the latest source code. It's already done:

https://github.com/inverse-inc/sogo/blob/master/SoObjects/SOGo/SOGoUserManager.m#L511


This would be worthy of a pull requests on its own (but I'm going to ask you to add a test for it)


No need to separate the above line from this one:

```python
w.writerow((
    ...
))
```

Also note that I used a tuple which are immutable sequences (lighter weight and faster than lists). Always use tuples when you know the sequence won't be mutated later in the code.


Nit: s/at the time of this writing/at this point in time

It's just a little awkward.


We're trying to move away from `source_under_test` since it doesn't scale for larger projects.  Instead, we have rules specify what their tests are these days.


Document what this means (the entity identifier).


Because unicode is ♥


yield...


Hi,

I was getting some Yaks initially and now I get empty Yaks. Is there anything I could do?


Ok, the –ea in the command line makes all the difference! Now it runs as you said it would run. Green error pixels greatly reduced. No more flickering stuff and runs a tad more smooth than usual but still not at 60 FPS. Somewhere in the mid 50ies.


No worries. If you check the addTerm function, you'll see that it already included a hasTerm check.


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (646 of 646 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.32%25-green.svg)


cmake output:
-- Architecture: AMD64
-- Architecture-specific source files: arch/x86/x86.c;arch/x86/fill_window_sse.c;arch/x86/deflate_quick.c;arch/x86/crc_folding.c
--
-- The following features have been enabled:

 * CMAKE_BUILD_TYPE , Build type: Release (selected)
 * WITH_GZFILEOP , Compile with support for gzFile-related functions
 * WITH_OPTIM , Build with optimisation
 * WITH_NEW_STRATEGIES , Use new strategies
 * SSE2 , Use the SSE2 instruction set, using "-march=native"
 * SSE4_CRC , Support CRC hash generation using the SSE4.2 instruction set, using "-march=native"
 * SSE2DEFLATE , Support SSE2-accelerated quick decompression
 * PCLMUL_CRC , Support CRC hash generation using PCLMULQDQ, using "-march=native -march=native"

-- The following features have been disabled:

 * ZLIB_COMPAT , Provide a zlib-compatible API

-- Configuring done
-- Generating done
-- Build files have been written to: C:/build/git/zlib-ng


Looks like this handler did not get a correct class name *HasFeatureHandler" vs "HasOneHandler".


don't install this update..


hpwh_residential (nmerket) - Win64-Windows-7-VisualStudio-12: OK (1671 of 1678 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


It was in the release that went out today. There actually ended up being two because the polling stuff revealed a bug. So `0.100.1` ought to have the new handling of True and False env variables.


OK


test for Git


hpwh_residential (nmerket) - i386-Windows-7-VisualStudio-12: OK (1671 of 1678 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


what the hell


Merging Tucker's work with mine.


@drsnyder I think `consul.service.consul:8500` should be passed as a param from config of the service that will use this resolver.


I am not sure why we are seeing this file twice with two different class names?


Naja, ich hatte ```clean``` gewählt, da es eine unsauber Eingabe (nicht CSV) in eine potentiell sauber (escapter wert) umwandelt. Aber das sind semantische Feinheiten ...
Hauptsache, am Ende funktionierts, oder?


Same situation here, same file, different set of changes?


Sure, fine.


will re-add this test once the reason for the instability has been figured out


@aronatkins Here's your new minimum packrat version.


My local directory duplicated the files and ended one set with ~.
I'll remove the duplicates.

On Fri, Jun 12, 2015 at 11:01 AM, Scott Brisko <notifications@github.com>
wrote:

> Same situation here, same file, different set of changes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elementaltech/yard-activerecord/commit/a00362e0e9e57ede4a65f28ded2d1281bb6ee3b3#commitcomment-11659144>
> .
>


TankDeadband (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Well, I hate to be picky, given the amount of work you already put there, but we'd need at least one comment explaining what utf8 stands for in this context to users...


that's right @edgarsilva some functions will provide a val and structureId, but other will only provide the structureId. i will do what you are suggesting.


It is great that you went through and made a list of all the custom validations we have, but what we need is something that is general enough to handle documenting the custom validations without us having to keep a list updated, which will probably not happen that often, or possibly not at all. Do we need to have the validation names in order for the documentation generation to discover them? Could this be solved with handling the known built-in Rails validation types as they are now and making something that can generically handle the non-built ins?


this is benched everytime, probably want to do this in the constructor


Yeah, I was going to ask to add this option. I'm glad to see it's already here.


I meant "fields", not "filers".


Che tengo un quilombito con el npm.... pongo "npm start" y me tira este
error:

npm ERR! weird error 8
npm WARN This failure might be due to the use of legacy binary "node"
npm WARN For further explanations, please read
/usr/share/doc/nodejs/README.Debian

,...por lo que estuve leyendo, tendría que ver con el proxy que tengo
acá.... ¿tiene sentido que sea eso?

El 12 de junio de 2015, 14:48, Rodrigo Alfonso <notifications@github.com>
escribió:

> Jajaj, buildea siempre, pero solo avisa cuando lo rompés (igual eso se
> puede configurar :P)
>
>
> El 12 de junio de 2015, 14:47, JSorella <notifications@github.com>
> escribió:
>
> > Igual aguantame que me olvidé de correr los tests... Me olvido que el CI
> te
> > buchonea todo :(
> > ¿En teoría no debería buildear sólo cuando hay commits contra master?
> >
> > El 12 de junio de 2015, 14:45, Javier Sorella <javiersorella@gmail.com>
> > escribió:
> >
> >
> > > Hasta donde yo sé las clases se nombran siempre en singular...
> > >
> > > 2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <notifications@github.com>:
> > >
> > >> En realidad la convención es:
> > >> En controllers: "si es un solo recurso es singular, si son varios es
> > >> plural". Nosotros tenemos varias melodías.
> > >> En rutas: siempre plural.
> > >>
> > >> Source:
> > >>
> >
> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
> > >>
> > >> —
> > >> Reply to this email directly or view it on GitHub
> > >> <
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754
> > >
> > >> .
> > >>
> > >
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658863
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658883>
> .
>


Da kommts jetzt also auf den Blickwinkel an.
>  Hauptsache, am Ende funktionierts, oder?

:stuck_out_tongue:


Took these numbers from system integration tests :)


I see the code references 3 as a possible verbosity value. Therefore the docstring is probably incorrect.


Actually, `#pluck` [isn't](https://github.com/jashkenas/backbone/blob/adf13ce85298a3739e2aad540784f80dfd35c41e/backbone.js#L995-L997) implemented with this. Want to open a PR?


Following the other comment, this line can be replaced by:
phio.on( _range=boundaryfaces(m_mesh), _expr=-h()/100.);
The idea of what's going on is more clear like that. The internal dof are set to h() while the boundary are set to a negative value close to 0.


(tells that the stat service won't do anything if no storage backend are configured by the user, and that it will not fail)


I think this has been fixed in the recent version...
does it occur on the current ipa320/indigo_dev, too?


I plugged this in for now but agree that there should be a way to document
custom validations without updating a list of all of them. I'll keep
working on that way; in the mean time I just wanted to make something that
would make validations show up.

On Fri, Jun 12, 2015 at 11:05 AM, Scott Brisko <notifications@github.com>
wrote:

> It is great that you went through and made a list of all the custom
> validations we have, but what we need is something that is general enough
> to handle documenting the custom validations without us having to keep a
> list updated, which will probably not happen that often, or possibly not at
> all. Do we need to have the validation names in order for the documentation
> generation to discover them? Could this be solved with handling the known
> built-in Rails validation types as they are now and making something that
> can generically handle the non-built ins?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elementaltech/yard-activerecord/commit/a00362e0e9e57ede4a65f28ded2d1281bb6ee3b3#commitcomment-11659193>
> .
>


Markdown is rendered inline.  Needs newline and no indent.


a comment


Yeah, I like this.


OK


Leftovers... probably won't need them. I'll remove them shortly.


each samples are sent to every connected storage backend (and then, they will be filtered independently)


Nit: s/at the time of this writing/at this point in time

The wording is a bit awkward.


This is a comment on the commit


Weird error 8 jaja

Ehm, eso no creo que tenga que ver con un proxy. Tal vez tengas una versión
vieja de node como dice el error...
Ni idea :/

El 12 de junio de 2015, 15:06, JSorella <notifications@github.com> escribió:

> Che tengo un quilombito con el npm.... pongo "npm start" y me tira este
> error:
>
> npm ERR! weird error 8
> npm WARN This failure might be due to the use of legacy binary "node"
> npm WARN For further explanations, please read
> /usr/share/doc/nodejs/README.Debian
>
> ,...por lo que estuve leyendo, tendría que ver con el proxy que tengo
> acá.... ¿tiene sentido que sea eso?
>
> El 12 de junio de 2015, 14:48, Rodrigo Alfonso <notifications@github.com>
> escribió:
>
>
> > Jajaj, buildea siempre, pero solo avisa cuando lo rompés (igual eso se
> > puede configurar :P)
> >
> >
> > El 12 de junio de 2015, 14:47, JSorella <notifications@github.com>
> > escribió:
> >
> > > Igual aguantame que me olvidé de correr los tests... Me olvido que el
> CI
> > te
> > > buchonea todo :(
> > > ¿En teoría no debería buildear sólo cuando hay commits contra master?
> > >
> > > El 12 de junio de 2015, 14:45, Javier Sorella <javiersorella@gmail.com
> >
> > > escribió:
> > >
> > >
> > > > Hasta donde yo sé las clases se nombran siempre en singular...
> > > >
> > > > 2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <notifications@github.com
> >:
> > > >
> > > >> En realidad la convención es:
> > > >> En controllers: "si es un solo recurso es singular, si son varios es
> > > >> plural". Nosotros tenemos varias melodías.
> > > >> En rutas: siempre plural.
> > > >>
> > > >> Source:
> > > >>
> > >
> >
> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
> > > >>
> > > >> —
> > > >> Reply to this email directly or view it on GitHub
> > > >> <
> > >
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754
> > > >
> > > >> .
> > > >>
> > > >
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658863
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658883
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11659208>
> .
>


yield this method


should be inlinecallbakcs


This is not defined, so it will be session scope.  You should also check for null-ness.


крестики нолики


tells it returns a deferred


And you should also have an array of listeners, in case there are multiple.


This commit makes `saveCommonChunk` work with following multiple vars selection example

```
data(WorldBank)

wb.all <-
  list(scatter=ggplot()+
         geom_point(aes(life.expectancy, fertility.rate, clickSelects=country,
                        showSelected=year, colour=region, size=population,
                        tooltip=paste(country, "population", population),
                        key=country), # key aesthetic for animated transitions!
                    data=WorldBank)+
         geom_text(aes(life.expectancy, fertility.rate, label=country,
                       showSelected=country, showSelected2=year,
                       key=country), #also use key here!
                   data=WorldBank, chunk_vars=c("year", "country"))+
         scale_size_animint(breaks=10^(5:9))+
         make_text(WorldBank, 55, 9, "year"),
       ts=ggplot()+
         make_tallrect(WorldBank, "year")+
         geom_line(aes(year, life.expectancy, group=country, colour=region,
                       clickSelects=country),
                   data=WorldBank, size=4, alpha=3/5),
       time=list(variable="year",ms=3000),
       bar=ggplot()+
         theme_animint(height=2400)+
         geom_bar(aes(country, life.expectancy, fill=region,
                      showSelected=year, clickSelects=country),
                  data=WorldBank, stat="identity", position="identity")+
         coord_flip(),
       duration=list(year=1000),
       first=list(year=1975, country="United States"),
       title="World Bank data (single selection)")
animint2dir(wb.all, "WorldBank-all")
```

It reduces the output file size from `50.5` MB to `49.3` MB . It can determine whether common data exists for chunks. If yes, a `*chunk_common.tsv` will be produced. Moreover, the new chunk-saving methods simplify `saveChunks`.

Next I will write tests for `saveCommonChunk` and modify `animint.js` to make the new chunks can be rendered by the renderer.


Great job with all these flags! I was impressed seeing all these `--without` switches in our scripts! :-)


On 12/06/15 10:04 -0700, Ken Gaillot wrote:
> 'newly introduced terms'
> _emphasis_

Since I've hardly contributed to the docs so far, not sure if it is
appropriate to argue, but I really like the semantic separation
(declarative approach, "this word should be emphasized per the context
and target format rules") rather than consumption form (procedural
approach, "this word should be in italics regardless").
Furthermore, emphasized-in-emphasized is entirely valid expectation
(also see, e.g, LaTeX), whereas italics-in-italics makes no sense.

Also for newly introduced terms, DocBook defines firstterm:
http://docbook.org/tdg/en/html/firstterm.html
and AsciiDoc is flexible enough so we can have our own shared set
of markups with possibly the one for firstterm being included (and
possibly more, DocBook recognizes command, package, filename, ...).

So I would be in favor of having emphasis expressed in native AsciiDoc
form (single quotes), and newly introduced terms either resolved to
that as well (I already used that in pull request #731), or see
the firstterm proposal above.

--
Jan


Nit: period should go inside the close parenthesis, since the whole sentence is enclosed.


I don't know if there are lot of drawing/chart in bb documentation, but a good drawing is always more meaningful than text :)


If I could downvote this commit, I would.

I appreciate the reasons you're doing this, but damn.


MeRtics ?

=> Metrics


Just a suggestion...you could replace this check with something like:

```javascript
mstestconfig = mstestconfig || {};
```

That way you can remove this check all together and focus on checking the required parameters like you are doing on the subsequent lines. This is more of a style choice though, I see it used often in node and have adopted it myself (for good or bad I guess)


@mattloughran-okta Looks good to me


This line is a bit repetitive.  Do you think you could DRY this up a bit using a `let` or `before` block?


Merge with build


You may shorten this whole thing down so it matches the teeworlds code convention:
(Leave out the curly brackets `{ }` for single-line if-clauses)
```c++
if(Event.m_Flags&IInput::FLAG_PRESS && Event.m_Key == KEY_LSHIFT)
	m_ReverseTAB = true;
else if(Event.m_Flags&IInput::FLAG_RELEASE && Event.m_Key == KEY_LSHIFT)
	m_ReverseTAB = false;
```


@jjallaire @jmcphers FYI: This is the min version of rsconnect required for robust hashing.


maybe move this unit test into a dedicated test class so people understand this doesn't cover a mandatory thing


Is there a default location where it is *usually* located on a machine? It might be good to set a default value in the case that a value for this field is not provided. This would allow a "happy path" case where the user doesn't have to be explicit when they have a default setup.


@rzarzynski the object and account case look different from the bucket case. E.g., I don't see any cors handling, could it be that it was missed?


hahaha of course this line looks bad now :)  but whatever.


Sooo, I think it's the simplest fix I can think of right now :)


so then amend it ...please


Without calling logger.open() logger remains inoperational


Great. Thanks.


I'm not exactly sure what led to the negative quote-to-bind times, but we found out that the underwriters can issue multiple quotes per submission, with the last quote being recorded as the "quoted date." Maybe the software was set, for whatever reason, to allow them to send a quote after the policy had been bound.


Markdown is rendered inline. Needs newline and no indent.


Great....sort of.


Done in 7647f35b7bb5dcfec20f012950fb66d899aac023.


I've just tested the improved output, IMO it's looking awesome.


Ah damn, I could've sworn I've used that before.


Same kind of question here...could you make a reasonable assumption here like maybe "find all dll files that end .test or .unittest" or some common convention like that? Not sure if this is helpful, but I think about test runners like `mocha` or linters like `jshint` that just allow me to run the command with no parameters and it assumes reasonable and documented defaults.


Yeah, I think I didn't understand the context of this patch.


There ought to be a way to way this buffer copy...


Yeah, it totally was there: https://github.com/jashkenas/backbone/blob/1.0.0/backbone.js#L840-L843

Did we kill it?


`a markdown AST`

Documentation seems to be not correct if I understood you: the format is dependend on the `loadformatter` isn't it?


This was lazy because there is one use case, in producer.clear, where the serializer is not used:
https://github.com/locationtech/geomesa/blob/master/geomesa-kafka/geomesa-kafka-datastore/src/main/scala/org/locationtech/geomesa/kafka/KafkaProducerFeatureStore.scala#L79

Clear is probably not used enough to be concerned about the probably low initlization cost.


comment on a commit


Nice usage of the ternary operator


Huh, nice catch!


merge try


Bah, good catch. Thanks.


What about who.ini ?

Also how about source_complete returning the list of missing files and include them in the error?


Ah, yep, that'd be cool. Will open a pull. (good catch!)


Instead of "drop if" maybe "TODO: Remove once..." but that's just semantics and preferences about messages.  Other than that, I haven't seen anything worth nacking.


This is not set within this same scope, which means it's going to be undefined.


Does the mstest runner support a commonly used reporting format like `xunit-style` results or maybe event `json`? It might be more forward-safe to use those output formats than parsing stdout. I don't know if this runner supports that though.


Is this only for Chrome because this will definitely not work on Core Linux.  -1, please fix with build config checks.


Sounds good.


done


I would like you to clarify for this class need?

> 12 июня 2015, в 21:14, Nick Brachet <notifications@github.com> написал(а):
>
> Without calling logger.open() logger remains inoperational
>
> —
> Reply to this email directly or view it on GitHub.
>


Fixed mac_address assigned error. Similar to cdrom iso.


I suppose that I should be brief on the commit blurb and more verbose here.  Live and learn :smile:


develop (axelstudios) - i386-Windows-7-VisualStudio-12: OK (2186 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.78%25-yellow.svg)


A mi tampoco me cierra lo del proxy, me baso en algo que vi en
stackoverflow... Preguntando acá dentro me dijeron que seguramente tenga
que ver con algún moño que me mandé con los permisos

El 12 de junio de 2015, 15:10, Rodrigo Alfonso <notifications@github.com>
escribió:

> Weird error 8 jaja
>
> Ehm, eso no creo que tenga que ver con un proxy. Tal vez tengas una versión
> vieja de node como dice el error...
> Ni idea :/
>
>
> El 12 de junio de 2015, 15:06, JSorella <notifications@github.com>
> escribió:
>
> > Che tengo un quilombito con el npm.... pongo "npm start" y me tira este
> > error:
> >
> > npm ERR! weird error 8
> > npm WARN This failure might be due to the use of legacy binary "node"
> > npm WARN For further explanations, please read
> > /usr/share/doc/nodejs/README.Debian
> >
> > ,...por lo que estuve leyendo, tendría que ver con el proxy que tengo
> > acá.... ¿tiene sentido que sea eso?
> >
> > El 12 de junio de 2015, 14:48, Rodrigo Alfonso <notifications@github.com
> >
> > escribió:
> >
> >
> > > Jajaj, buildea siempre, pero solo avisa cuando lo rompés (igual eso se
> > > puede configurar :P)
> > >
> > >
> > > El 12 de junio de 2015, 14:47, JSorella <notifications@github.com>
> > > escribió:
> > >
> > > > Igual aguantame que me olvidé de correr los tests... Me olvido que el
> > CI
> > > te
> > > > buchonea todo :(
> > > > ¿En teoría no debería buildear sólo cuando hay commits contra master?
> > > >
> > > > El 12 de junio de 2015, 14:45, Javier Sorella <
> javiersorella@gmail.com
> > >
> > > > escribió:
> > > >
> > > >
> > > > > Hasta donde yo sé las clases se nombran siempre en singular...
> > > > >
> > > > > 2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <
> notifications@github.com
> > >:
> > > > >
> > > > >> En realidad la convención es:
> > > > >> En controllers: "si es un solo recurso es singular, si son varios
> es
> > > > >> plural". Nosotros tenemos varias melodías.
> > > > >> En rutas: siempre plural.
> > > > >>
> > > > >> Source:
> > > > >>
> > > >
> > >
> >
> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
> > > > >>
> > > > >> —
> > > > >> Reply to this email directly or view it on GitHub
> > > > >> <
> > > >
> > >
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754
> > > > >
> > > > >> .
> > > > >>
> > > > >
> > > > >
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658863
> > > >
> > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658883
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11659208
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11659290>
> .
>


We'd need to add `cb` to the `2` path in the switch (which is still fine, since `modelMethods` only has 0s and 1s). Looks like we can fold `where` and `findWhere` with that as well.


Sí, ya tenías medio mal instalado node. Probá borrando todo y volviéndolo a
instalar.
Creo que hay un comando que es npm implode para borrar todo al carajo (?)

El 12 de junio de 2015, 15:20, JSorella <notifications@github.com> escribió:

> A mi tampoco me cierra lo del proxy, me baso en algo que vi en
> stackoverflow... Preguntando acá dentro me dijeron que seguramente tenga
> que ver con algún moño que me mandé con los permisos
>
> El 12 de junio de 2015, 15:10, Rodrigo Alfonso <notifications@github.com>
> escribió:
>
>
> > Weird error 8 jaja
> >
> > Ehm, eso no creo que tenga que ver con un proxy. Tal vez tengas una
> versión
> > vieja de node como dice el error...
> > Ni idea :/
> >
> >
> > El 12 de junio de 2015, 15:06, JSorella <notifications@github.com>
> > escribió:
> >
> > > Che tengo un quilombito con el npm.... pongo "npm start" y me tira este
> > > error:
> > >
> > > npm ERR! weird error 8
> > > npm WARN This failure might be due to the use of legacy binary "node"
> > > npm WARN For further explanations, please read
> > > /usr/share/doc/nodejs/README.Debian
> > >
> > > ,...por lo que estuve leyendo, tendría que ver con el proxy que tengo
> > > acá.... ¿tiene sentido que sea eso?
> > >
> > > El 12 de junio de 2015, 14:48, Rodrigo Alfonso <
> notifications@github.com
> > >
> > > escribió:
> > >
> > >
> > > > Jajaj, buildea siempre, pero solo avisa cuando lo rompés (igual eso
> se
> > > > puede configurar :P)
> > > >
> > > >
> > > > El 12 de junio de 2015, 14:47, JSorella <notifications@github.com>
> > > > escribió:
> > > >
> > > > > Igual aguantame que me olvidé de correr los tests... Me olvido que
> el
> > > CI
> > > > te
> > > > > buchonea todo :(
> > > > > ¿En teoría no debería buildear sólo cuando hay commits contra
> master?
> > > > >
> > > > > El 12 de junio de 2015, 14:45, Javier Sorella <
> > javiersorella@gmail.com
> > > >
> > > > > escribió:
> > > > >
> > > > >
> > > > > > Hasta donde yo sé las clases se nombran siempre en singular...
> > > > > >
> > > > > > 2015-06-12 14:40 GMT-03:00 Rodrigo Alfonso <
> > notifications@github.com
> > > >:
> > > > > >
> > > > > >> En realidad la convención es:
> > > > > >> En controllers: "si es un solo recurso es singular, si son
> varios
> > es
> > > > > >> plural". Nosotros tenemos varias melodías.
> > > > > >> En rutas: siempre plural.
> > > > > >>
> > > > > >> Source:
> > > > > >>
> > > > >
> > > >
> > >
> >
> http://stackoverflow.com/questions/18570158/handling-singular-and-plural-controllers-routes
> > > > > >>
> > > > > >> —
> > > > > >> Reply to this email directly or view it on GitHub
> > > > > >> <
> > > > >
> > > >
> > >
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658754
> > > > > >
> > > > > >> .
> > > > > >>
> > > > > >
> > > > > >
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub
> > > > > <
> > > >
> > >
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658863
> > > > >
> > > >
> > > > > .
> > > > >
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11658883
> > > >
> > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11659208
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11659290
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rodri042/scoremonkey-server/commit/e8e6301134b47cd59a7e5322e9494a78c4384d9f#commitcomment-11659496>
> .
>


I think you either need to delete the trailing `;then` or the `then` on the line below. In bash `;` marks the end of a statement, so `if … ; then` is equivalent to `if …` followed by a `then` on a new line


You are going backwards? the current NPM version is 2.3.0

![image](https://cloud.githubusercontent.com/assets/887639/8137030/6ddc4448-110e-11e5-878c-cb349a43c3a1.png)


Mach einfach :smile:
Am Ende haben wir mehr Kommentar als Code o.O


Specify that this is output?


Logging output for debugging and info.
Without it it will be impossible to be diagnose any transport issue.


i was just kind of messing with stuff - i'll probably roll back a lot of things before making a PR


Danke. Damn bisi usegfunde ha, dass da so en krux Char dine isch!

Ha süsch no komischi meldige bim builde, aber es duet ja! :100:


check lastOffsets.length rather than relying on IndexOutOfBoundsException


開心檔案跟開啟救黨的FileDialog是一樣的  可是我們在寫程式時差別在一個是判斷檔案有沒有被改過需不需要存完開心的;或著開啟已經打好的檔案


Try squashing the commits and then amending it.


This should be done now


Yeah. Until there's other parsers available though it's not really untrue. Fixed in 0c8ef18aa503fa780452b9367110cb6aa97c73dd.


@addyosmani What's up with this? It's on the wrong place and adds no value isn't it?


try is basically free in the normal case where there is no exception - should be cheaper than checking the length every time.


My CentOS 6.6 has `/sys/kernel/mm/redhat_transparent_hugepage/defrag`... which version are you using that doesn't? Maybe they dropped the symlink from transparent_hugepage to redhat_transparent_hugepage in CentOS 7...


Thanks for the pre-compiled version! And yeah, I posted here since there was no issues section. I'll post a more detailed issue later this weekend.

Cheers


@liulessv5 Submissions are welcome! If you do a pull request I will gladly merge it.


why so many double spaces? :)


We only want to print this message once.


First, thank you for detailed explanation.  I believe it is vital to
have a common set of well-defined (and sometimes, like in the beginner's
section, at least semi-precise to replace the previous void, prepared
for further refinement) terms.

On 12/06/15 09:25 -0700, Ken Gaillot wrote:
> * "Node" is the generic term for any full-stack or pacemaker_remote node.

Looks like this one is directly actionable: would it be OK to add
a footnote, perhaps with a link to referring to the Pacemaker Remote
document?

--
Jan


SHIT ARE THIS WORKING?


Should you mention that the ID/strings will be different?


Probably should make optional params to `make_tab` a map for keyword args...


Link to the [labels documentation](https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/labels.md).


Ok, but can you explain why an array is better than params, so in the future I can see for myself what to use


Thanks! it worked


Nit: link to Step One?


Haha, I actually took that method directly from the Dog class, so I don't
know who wrote it.
I will take all the credit though.

On Fri, Jun 12, 2015 at 11:16 AM, Michael Lustig <notifications@github.com>
wrote:

> Nice usage of the ternary operator
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659417>
> .
>


but... IdMap has no logical relation to MongoID :)


Ok, compro.


Yes, definitely a bug.


It's clearer. Everytime you have more than one parameter where order is not extremely obvious, they always win. You have to remember names rather than order, and it's easier.


I made the experience, that you could let the pkg_jem.xml.
It needs only the change of jem.xml


@alexmarsev: This should fix the problem. Note that the old definition of end-of-stream = no sample are in used has been changed to all scheduled samples have been rendered.


Merge Fast-Fix
![icon-pointer-flag](https://cloud.githubusercontent.com/assets/11885793/8137286/75a157e0-10ff-11e5-8bfc-f9179ce8a812.png)


updated to this version and it does seem to load a big quicker indeed.


lower the debug level maybe 10?


Hahahaha fair enough. I just emailed Stan about that typo. Hopefully, we'll
get you to to down in Bloc history with that edit..
On Jun 12, 2015 2:32 PM, "Christophe Pouliot" <notifications@github.com>
wrote:

> Haha, I actually took that method directly from the Dog class, so I don't
> know who wrote it.
> I will take all the credit though.
>
>
>
> On Fri, Jun 12, 2015 at 11:16 AM, Michael Lustig <notifications@github.com
> >
> wrote:
>
> > Nice usage of the ternary operator
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659417
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659691>
> .
>


It's NOT related to the issue #28 but I think that this diff has also an error.
@shinnok
642 - if (m_ui->checkBox_IncrementalModeExternalName->isChecked())
592+ if (m_ui->incrementalModeTab->isVisible())


Insert "same" in front of "behavior"


It seems to want a blank line at the end of the file.


Sokrati, why are you compiling DbConnection by itself? Is it not compiled automatically when you compile MysqlToXls?


Here, there are many!
http://lmgtfy.com/?q=text+art+ascii+generator


LGTM. Next time, CountingLabelViewController and CircleChartViewController should not change :)


will need to return failure somehow


don't put the secret key in the log


this is the access key, I assume?


Sure :)


why 24?


There is no need to check for output.length


why GSS_C_NO_BUFFER ? to avoid having to free the buffer ?


For some reason the tests fail without extending Component.


Closing period should be inside closing parenthesis.


What was the "bug" fixed?


No. It was giving me an error. The other file could not find it in the
package.

On 12 June 2015 at 19:36, sergutsan <notifications@github.com> wrote:

> Sokrati, why are you compiling DbConnection by itself? Is it not compiled
> automatically when you compile MysqlToXls?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mavrikis/it2l-data-analysis/commit/664fc5cef57b173f3b002238adace8c4e61cba78#commitcomment-11659766>
> .
>


TY!  https://twitter.com/pythonnerd/status/609428566124679168

On Fri, Jun 12, 2015 at 12:04 PM, José Padilla <notifications@github.com>
wrote:

> @davidrenne <https://github.com/davidrenne> documentation is generated
> from Markdown files. Check out the Pagination
> <https://github.com/tomchristie/django-rest-framework/blob/master/docs/api-guide/pagination.md>
> section. You might also be interested in checking out contributing
> guidelines
> <http://www.django-rest-framework.org/topics/contributing/#documentation>
> regarding docs.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tomchristie/django-rest-framework/commit/73feaf6299827607eab94ce96b77b73671880626#commitcomment-11657105>
> .
>


mb


Got it, thanks


Good, I'd like my name on the home page please.

On Fri, Jun 12, 2015 at 11:36 AM, Michael Lustig <notifications@github.com>
wrote:

> Hahahaha fair enough. I just emailed Stan about that typo. Hopefully, we'll
> get you to to down in Bloc history with that edit..
> On Jun 12, 2015 2:32 PM, "Christophe Pouliot" <notifications@github.com>
> wrote:
>
>
> > Haha, I actually took that method directly from the Dog class, so I don't
> > know who wrote it.
> > I will take all the credit though.
> >
> >
> >
> > On Fri, Jun 12, 2015 at 11:16 AM, Michael Lustig <
> notifications@github.com
> > >
> > wrote:
> >
> > > Nice usage of the ternary operator
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659417
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659691
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659753>
> .
>


Thanks! I sent it already, as soon as I get an answer I'll let you know.


constants are generally uppercased. Change it to DELTA


This breaks all classes making them almost empty because that equality is always false


@RJVB This is how it actually works: 12a25a5e322c731e6bda864e56f3a5c12684cf65


@rpatterson I think this is kind of backwards in terms of which packages depend on that. I think the correct would be p.a.contenttypes depend on p.a.stagingbehavior, and not the other way around. It already happens whis way for versioningbehavior and lockingbehavior. I think we should follow this pattern.


Errrm, I think it's going to take a few projects to even make that a remote
possibility. But one can dream!
On Jun 12, 2015 2:41 PM, "Christophe Pouliot" <notifications@github.com>
wrote:

> Good, I'd like my name on the home page please.
>
> On Fri, Jun 12, 2015 at 11:36 AM, Michael Lustig <notifications@github.com
> >
> wrote:
>
> > Hahahaha fair enough. I just emailed Stan about that typo. Hopefully,
> we'll
> > get you to to down in Bloc history with that edit..
> > On Jun 12, 2015 2:32 PM, "Christophe Pouliot" <notifications@github.com>
> > wrote:
> >
> >
> > > Haha, I actually took that method directly from the Dog class, so I
> don't
> > > know who wrote it.
> > > I will take all the credit though.
> > >
> > >
> > >
> > > On Fri, Jun 12, 2015 at 11:16 AM, Michael Lustig <
> > notifications@github.com
> > > >
> > > wrote:
> > >
> > > > Nice usage of the ternary operator
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659417
> > > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659691
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659753
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/moxuz/bloc-exercises/commit/2cfb6672acecf59f3eb739de79d2fdbe9803c363#commitcomment-11659835>
> .
>


Write a comment why delta is 32. It's used only in this class so it should be a private variable.


This change moved the translation jump behavior to when restoring from a savedInstanceState (for example, on rotation). Have you noticed this?


:shipit:


true, I'll fix this in the next version


On Fri, Jun 12, 2015 at 9:38 PM, simo5 <notifications@github.com> wrote:

> why GSS_C_NO_BUFFER ? to avoid having to free the buffer ?
>
Yes, but mainly because I suspected we might hide the previous buffer by
using 'output' again without freeing.


string secret_key_utf8_k(secret_k, n);
otherwise it might overrun reading the buffer when constructing the string (assuming secret_k is not null terminated).


The getItem method is the solution. For every column name I check using this method to see if there is a key in the map. If yes I get the value and insert it into the excel file otherwise I skip a cell and repeat the process.


Sorry, I think there us some confusion. 1) The `lastModificationTime` is checked before the broker is allocated. 2) I can't check if the document exists before allocating a broker for obvious reasons.

So I think this already does what you want!


A comment on the new version


This supports https://www.youtube.com/testtube player but still doesnt support flash. i have however copied the style of change made to the Spotify controller in hopes of trying to detect the flash player, this commit makes the controller ALWAYS think it's html5 so that needs to be fixed.


oh sure... I can count only to 2...


Yes, I know. But I hadn't tried to update then to a 2.1.5 so it's more safe.


On Friday June 12 2015 11:41:54 Mika Lindqvist wrote:
> @RJVB This is how it actually works: 12a25a5e322c731e6bda864e56f3a5c12684cf65

That's strange: as you could see from your previous message, SSE2FLAG etc. are set to NATIVEFLAG, so I don't understand how your version is actually different!
NB: my code works correctly on the AMD C60. I'll see if I can get my hands on an i5 .

R.


2 minor comments. Feel free to merge once it's green.


Works fine. But please make sure ``stepForward`` is always true at the EOS.


Period goes inside parenthesis.


I prefer not to throw an exception here, I much prefer trying to keep the rule `() => ()`. It allows more composable code, otherwise users will need a try/catch etc. In this way, *if* they want to check the existence of a document they can call `fn:doc-available` first.


also the supportsPrevious seems to work the first time you load a video or if you completely refresh a page, but if you load a playlist where supportsPrevious is true and then navigate to another video where supportsPrevious would be false the script never rechecks to see if supportsPrevious should be reevaluated and will continue to show the previous button. so maybe we need to add something about "if the page location changes, reinitialize the controller". this might already be in place, but something isnt working the way it should.


Add GoldenGate user exit into Nosql tables


The cmake output lies, because the actual variable set is after the tests ;) My CPU is Wolfdale, which was released year before all the instructions were implemented.


to my last comment:
maybe add an element to be watched?


I did notice that issue: here is my most recent commit: https://github.com/codecov/codecov-bash/blob/f90ea4e266b373d56eb450a8f3fd857c07f7c1c5/codecov#L361


Keep getting Error: [$injector:unpr] Unknown provider: MethodServiceProvider <- MethodService.


Oh, the comment is misleading, actually. I stored the self (thus node) and compared `node __eq__ node` which is actually safer, than only path. OK, let me remove this patch and adjust the environmental view instead...


should be `--name`


Thanks, it struck me suddenly, such an easy implementation to list all values and without duplicates.


Jeffry,

Let me know if there any more adjustments you'd like.  Also, are there any
other parts of the Linq2Couchbase project that you'd like some help with?
I find it fascinating, but I don't want to overlap with work other people
are doing.

Thanks,
Brant

On Thu, Jun 11, 2015 at 1:38 PM, Jeffry Morris <notifications@github.com>
wrote:

> @brantburnett <https://github.com/brantburnett>
>
> Yes, I like it! Ideally we would make it an optional feature; I am trying
> to think of future features that it may conflict with it (they may or may
> not exist).
>
> This is great :)
>
> -Jeff
>
> -Jeff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/brantburnett/Linq2Couchbase/commit/431c6fc0671ac3baab8d79698ff74f6064dc0fd4#commitcomment-11639179>
> .
>

--
Thanks,
Brant Burnett
CenterEdge Software
(336) 598-5934
http://centeredgesoftware.com


I know I shouldn't do this, but this was just a minor fix.


`from json import dumps`??


@jmunhoz a good start. I didn't go over all of it, but see my comments.


CSS Masks not supported by: IE (8,9,10,11), Firefox (37,38), Chrome (42,43), Safari (8), iOS Safari (7.0-7.1,8.1-8.3), Opera Mini (5.0-8.0), Android Browser (4.2-4.3,4.4,4.4.3-4.4.4), Chrome for Android (42), UC Browser for Android (9.9)


CSS Filter Effects not supported by: IE (8,9,10,11), Opera Mini (5.0-8.0), Android Browser (4.2-4.3)


CSS outline not supported by: Opera Mini (5.0-8.0)


Здесь беда.
"No module named '_speedups'"  - ругается, если импортировать модуль.
Если же раскомментировать строчку выше(а эту - #), то импорт проходит нормально, а запуск тула черезе command-line нет.
Где ступил, не понятно.


Interesting and good to know.


:thumbsup:


Problem is that we are currently working on new features on *master*, that do not work completely yet. Nevertheless, we want to have a first version deployed before all of the planned functionalities are implemented. Therefore we created the branch *v1* that only includes the features, which are working. Also Code-Review was based only on *v1*, so far.


@aboe76 Please don't do this, just hit me/iggy/murrdoc up on IRC! We'll merge it quick for fixes!


Well, it depends on where the user is working. I can change it to the actual paths from the .sh files if you want.


Speak with you, wish you a happy birthday, add `Has()` and `Value()`, as well as `Map()` + `Reduce()` + `Filter()` (ref. fe687c7) into the global namespace in some `Bricks/puff.h`, to complement `Bricks/template/weed.h`.


Should this be:

```
from h.api.nipsa.views import user_index
from h.api.nipsa.views import user_create
from h.api.nipsa.views import user_delete
from h.api.nipsa.views import user_read
```

Again I'd argue for an exception here.


:+1: done!


no problem… I saw this commit linked from the issue #8 and just wanted to make sure I didn’t lead you astray. :+1:


:+1: done!

I also removed it in the last, third, place, by employing `Map()` instead.


Yep ;-)


Good idea, done in fe687c7


I think this way (using "onload") it doesnt change when next item in playlist is a different album?


Overall these are great improvements. Aside for grammatical comments, I'd make sure that you're linking to documentation at various points along the way, and I'd suggest inserting imagery for each step, illustrating what part of the architecture you are addressing.


Fixes #19


Published to http://ui.edev.d2l.com/69_9ff35507c0504360c47b9c8606d8f644f2f4cd04


Interesting ... I got 8 emails for this commit but I only see 1 comment? @darkwing - did you force-push a bunch of commits with incompatible changes on top of the same file?


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1162 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.79%25-green.svg)


ok


Is this too heavy handed of a way of setting a default? I found that adding the ```paginates_per``` line as noted in the kaminari readme to the models didn't seem to do anything. Maybe this has something to do with the use with the api-pagination gem?


Not sure what that's about, but I didn't force push anything.  Filed a bug here:  https://github.com/mdn/YouShouldUse/issues/50


Doh


@gravyboat that's why I apologized directly, I knew it was wrong, but only realized it afterwards.
sorry.


I wasn't sure if I needed to test all the headers, or all the combinations of page/no page/per_page/no per_page/both/neither, but figured this was a good place to start. On some level this feels like just testing whether the gem works.


no need to push empty vector here. instead you can adjust index in _white_pawn_moves_list function.
(same for black pawn move)


Dude i fucked up and removed a button can you help me with that its the top right one that supposed to say "Contactanos" and leaves us at the contact part of the page


@aboe76 No worries it happens! I just like to notate it so if others come by and see this PR and think it is okay to push to master they will see it isn't, but know who to contact, sorry if it came off a bit harsh.


watch out for that pole!


Looks like asciidoc is getting rid of treating single-quotes as markup (https://github.com/asciidoctor/asciidoctor/issues/717) so I guess we need to prefer underscores for emphasis and new terms. Personally I'd rather not create any custom markup, to minimize the learning curve. We do get community contributions.


@cdent - I didn't see the $ENVIRON bools here; am I looking in the wrong place?


provider* controller added


Well that's a good question and I was wondering about this too. What I'm sure of is that EVR-CP always worked that way and it should be fine. Sync renderer is less clear. It feels really unlikely that it happens but maybe I should just check this exactly where it was checked before to be safe. What do you think?


Now the divs will always be displayed, which will cause the _Patient information_ to be visible even if there's no data in it. First check if there's anything to display using `__hasDataToDisplay`.


Actually, I'm not sure `pluck` would work here, since its implementation in Underscore relies on `_.property`. Same with `where` and `findWhere`. They have to be special-cased for now.

I'll switch up the example.


lack comment about projectPath parameter


Like it's [done for phenotypes](https://github.com/phenotips/phenotips/blob/master/components/patient-data/ui/src/main/resources/PhenoTips/UIX_Field__phenotype.xml#L718-L723).


I think pacemaker_remote is too complicated for an intro. Currently the shared intro is used in Clusters From Scratch and Pacemaker Explained. Clusters From Scratch really doesn't need any reference to pacemaker_remote, where it would just be confusing to a beginner. Pacemaker Explained could have more information (after the intro).


It doesn't matter much at this point, but this response field ends up having even more possible meanings in v4. May consider just calling it "target" in anticipation of later versions.


Never mind, I committed a fix  : b10ca27


@gravyboat, no it isn't harsh, You are right, and I know it. :+1:


@MadsTorgersen, @kuhlenh


I see the enum is already named target.


Yeah, I think `TestUtils` makes some assumptions about what qualifies as “composite component”.
I'm okay with extending `Component` for the sake of the tests. :-)


On Fri, Jun 12, 2015 at 9:38 PM, simo5 <notifications@github.com> wrote:

> There is no need to check for output.length
>

I removed it and rebased.


Could we add a flag to control whether that logic is used?


Intentionally omitting type drop?


you should use `@RouterConfig` here's an example https://github.com/gdi2290/angular2-example-falcor/blob/86cb84407d326654c094a2dcb129fc90f2f80d06/src/app/App.ts#L226


develop (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Add space around ->.
Other functions are using a, b, ... for variable names.  But if you still prefer "a" and "w", that is fine.


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Thanks for this - the super call nodes were ancient and pretty bad.


Ignore all the nonsense commented out in this script, I'm trying to figure out docopts for bash.


The line you're looking for is [here in master](https://github.com/cdent/gabbi/blob/master/gabbi/case.py#L158) and was part of [this commit](https://github.com/cdent/gabbi/blob/d27a28f4fc5cebfe25ec30a2bdad378ca1eea63b/gabbi/case.py#L158).

That makes sense?


Need `tags.Copy()` here to prevent something changing `dp.Tags`, which will also change `tags`.


such view. so cache.


Plenty. What kinds of object should they be? Do they become type parameters of other types? If we stick them in Base now, I would bet cold hard cash on us not getting it 100% right and causing future breakage for people who used them.


Does anybody have a clue as to what this means?

I was just tinkering with stuff, and this site popped out.

I used an app to make an app, then I uploaded that app into the cloud, which led me to another app, that got me here.

It got me pretty confused, I hope the paths have been noted.


On Friday June 12 2015 11:41:54 Mika Lindqvist wrote:
> @RJVB This is how it actually works: 12a25a5e322c731e6bda864e56f3a5c12684cf65

OK, this is getting weirder. On my Core i7-2620M under OS X, building the pclmul test code saved as pcmul.c :

Using gcc 4.9.2 from MacPorts
%> gcc-mp-4.9 -O3 -msse4 -mpclmul pcmul.c -o pcmul
/var/folders/j1/1439ppj08xj8h6006s6drbq00000gs/T//ccultA0j.s:10:no such instruction: `pclmulqdq $16, %xmm0,%xmm0'
(Normal, that's probably an outdated assembler having issues with the instructionset)

Here's your error, which begins to reek of an issue with gcc's immintrin.h :
%> gcc-mp-4.9 -O3 -msse4 pcmul.c -o pcmul
In file included from /Volumes/Debian/MP9/lib/gcc49/gcc/x86_64-apple-darwin13/4.9.2/include/immintrin.h:39:0,
                 from pcmul.c:1:
pcmul.c: In function 'main':
/opt/local/lib/gcc49/gcc/x86_64-apple-darwin13/4.9.2/include/wmmintrin.h:116:1: error: inlining failed in call to always_inline '_mm_clmulepi64_si128': target specific option mismatch
 _mm_clmulepi64_si128 (__m128i __X, __m128i __Y, const int __I)
 ^
pcmul.c:8:11: error: called from here
   __m128i c = _mm_clmulepi64_si128(a, b, 0x10);
           ^
Exit 1

The preprocessed code with gcc-4.9.2 is identical to the input code:
int main(void)
{
  __m128i a = _mm_setzero_si128();
  __m128i b = _mm_setzero_si128();
  __m128i c = _mm_clmulepi64_si128(a, b, 0x10);
  unsigned int d = _mm_extract_epi32(c, 2);
  (void)c;
  return (int) d;
}

Using Apple's clang:
%>  clang -O3 -msse4 pcmul.c -o pcmul
In file included from pcmul.c:3:
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/6.0/include/wmmintrin.h:30:3: error:
      "AES/PCLMUL instructions not enabled"
# error "AES/PCLMUL instructions not enabled"
  ^
pcmul.c:8:15: warning: implicit declaration of function '_mm_clmulepi64_si128' is invalid in C99 [-Wimplicit-function-declaration]
  __m128i c = _mm_clmulepi64_si128(a, b, 0x10);
              ^
pcmul.c:8:11: error: initializing '__m128i' with an expression of incompatible type 'int'
  __m128i c = _mm_clmulepi64_si128(a, b, 0x10);
          ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 2 errors generated.

%> clang -O3 -msse4 -mpclmul pcmul.c -o pcmul && pcmul
%> clang -O3 -march=native pcmul.c -o pcmul && pcmul

those last two commands . With this compiler and CPU, -march=native expands to simply -target-cpu corei7-avx
and I get this preprocessed code:

int main(void)
{
  __m128i a = _mm_setzero_si128();
  __m128i b = _mm_setzero_si128();
  __m128i c = ((__m128i)__builtin_ia32_pclmulqdq128((__v2di)(__m128i)(a), (__v2di)(__m128i)(b), (char)(0x10)));
  unsigned int d = (__extension__ ({ __v4si __a = (__v4si)(c); __a[(2) & 3];}));
  (void)c;
  return (int) d;
}

which shows that testing for the SSE4.1 intrinsic is a bit of a moot point here, but it also suggests an alternative to the _mm_extract_epi32() call.

what amazes me is that the resulting executable executes despite invoking __builtin_ia32_pclmulqdq128 . Would that PCLMUL intrinsic have an equivalent in AVX for instance?!


This is totally not working for me.


wait, is this already in master?


Discussed this with Ryan, we added an improved synchronous version in the async branch. It seemed best to do async in production but synchronous in test.


Should this OBJ_CONSTRUCT be the "else" block to the "if"?  I.e., doesn't REQUEST_ALLOC give you a constructed request?

(same question for the send block in pml_ob1_isend.c, too)


Should this be OPAL_UNLIKELY'ed?


Just use docopt for Python. The bash script should anyway since it is merely a proxy for executing the Python script. To establish another convention, the entry point script for a generator should be named `main`. Ensure the proper shebang is defined at the top of the script `#!/usr/bin/env python3` in this case.


Of course Skin1980


If you're not sure of ``stepForward`` logic, then _I think_ it's better to put it where it was before. Precise EOS timing is done by the audio renderer anyway. But I'm not sure it's longer safe in light of recent changes. No silver bullet here.


Per convention, move the `time` import above the `unicode_csv` one.


Also, I know we have lame MPI_THREAD_MULTIPLE support here on v1.8, but it does at least somewhat exist -- if multiple threads invoke MPI_SEND concurrently, won't this explode?


Hi octovinh,

Thank you for the information. Yes, I will submit a pull request once the test is complete and also, send my resume to Ms. Sara.

Have a great day ahead.


Remove this docstring since it is invalid and the usage will be contained in the docopt usage string anyway.


Always one space after each comment `#`.


The header is not being skipped here, remove comment.


Yeah, @ScottPJones, I don't think it's a matter of not understanding *what* `Encodings` are, but *how* we're going to use them exactly. Like I mentioned above, adding them right away would cause a little weirdness because we have `UTF8String`,`UTF16String`,etc. and with `Encodings`, we'd have `UTF8`,`UTF16`,etc.

Like I said before, this is a much better change to introduce with a larger overhaul where it can be grafted in all the various corners that encodings touch (as opposed to using it just for a `check_string` function).


Ah, gotcha.

Related question: For broccoli-plugin, I'm considering turning a bunch of `getFoo()` methods into `get` accessors. In your opinion, is this generally reasonable, or a bad idea? (I haven't really used accessors in JavaScript, so if there's some pitfall, I'd rather like to find out now before I API-design myself into a corner. 😃)


Let's rename this file as ReplicatedTableConfiguredTable to be consistent with the other class names.


в переменной ```userid``` хранится целое число (id) или сам объект User? Она должна называться соответствующе.


There is no need to get the fields manually. Per the `csv.DictReader` documentation:

>  If the fieldnames parameter is omitted, the values in the first row of the csvfile will be used as the fieldnames.


Purely reading at the code, it's not impossible that the sample is dropped for one reason or another just at that precise time. In that case it wouldn't have `stepForward == true` so yeah, it feels better to keep the checks exactly at the same place than before.


А почему бы не сравнивать просто ```comment_author```? Это можно в джанге, и читаться будет легче.


Let me know if there are any other things I should change before merge.


Set default encoding to `utf-8`.


поля необязательно начинать с ```comment_```. Мы же и так в классе Comment.


To be honest, I just didn't think about providing better feedback. After all, this is a debug command that works on the selected NPC or player, so if you get that message it should be pretty obvious what creature we're talking about...


Remove this since it is not relevant (redundantly attempting to get the fields).


Add line above for clarity.


вот здесь аккуратно!

А что если в БД есть два юзера с одним и тем же username? Будет работать?


Could you please remove the extra parentheses, they aren't needed


Move the comment above the for loop to set the context of what is going on at each iteration.


Not sure if you are aware, but this commit appears to have broken compatibility with Android Auto, again.


@hollywoodheinz I know this was a while ago but if you're still having button activation problems put in a breakpoint and see what happens


?? Remove. I strongly recommend adding the test case for the test file you've included. That would immediately catch most of the issues I commented on.


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The command line "gcc-mp-4.9 -O3 -msse4 -mpclmul pcmul.c -o pcmul" is wrong... It's missing assembler option... Should be "-Wa,-q" for OS/X as far as I know.


You forgot to add:
"var clickRate = 20; // change to number of desired clicks per second"


Needs work before its ready to test.


backported for 14.07 branch - can you please test this?
see e0de429982408d599141ab51615bc60844b33dd4


Yep, good catch. Thanks.


Add box-sizing: border-box; to elements that are being tricky in different browsers.


We're talking MPI, I think that I will simply remove the if by allocating the request during the PML OB1 initialization. Support for thread multiple will come shortly.


Love the new additions.


We need it constructed before each use.


HelloWorld.md
## This is a markdown file


You are hardwiring the *wrong* path:

     fatal error: '/Users/rjhala/research/liquid/liquidhaskell/./dist/build/autogen/cabal_macros.h' file not found

it should be

    dist/dist-sandbox-4c189dae/build/autogen

In general, better to not hardwire paths but extract them from the .cabal file ... ?


Why not vector?


see line 261


Ugly. Better to use array.


You might also want to change that on the github.io page for the same :
http://daler.github.io/sphinxdoc-test/includeme.html#initial-creation-and-commit-workflow

On Sat, Jun 13, 2015 at 1:09 AM Ryan Dale <notifications@github.com> wrote:

> Yep, good catch. Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NightFury13/sphinxdoc-test/commit/8d1473d4934ce332a61ed28c1fdfd99226ed40c7#commitcomment-11660662>
> .
>


Ok, I see it, but how I confirm it?


Application from Nathan Aguirre


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2191 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.01%25-yellow.svg)


Ah, sorry.


No, thank @MarcLandis. ;) I only ran something like `git log --grep "ext4"` on the cm-11 branch.


Go ahead my brother from another mother :)


I measure a small disadvantage when using ```ConcurrentHashMap```: ~ 3%. It may just be noise. There shouldn't be a problem with this implementation unless there are dynamic changes to the map while other threads are trying to parse. The only concurrency issue would be having a reference to a stale collection of parsers which shouldn't happen if parsers are registered on startup. If they are being registered at other times the behavior would be undefined regardless of the underlying map implementation, it would just be 'less' undefined with the concurrent map as threads may cache the reference to an old map for a few more cycles.


no_raw_loops (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Imho there is a reason to separate it to functions a la:

*define prices
*define profits
*merchant loop

and may be even split the last to funcitons too


Of course. Should I rebase and create a new PR or just push commit ontop of this?


A new commit on top of this is fine, thanks


Thanks, will revert this once there is a fix.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/47203dad360be67d2ddf243e43fc52d1af6e2005/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/47203dad360be67d2ddf243e43fc52d1af6e2005/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/47203dad360be67d2ddf243e43fc52d1af6e2005/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/47203dad360be67d2ddf243e43fc52d1af6e2005/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/47203dad360be67d2ddf243e43fc52d1af6e2005/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Also detach it on the dispose


no_raw_loops (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Given the function's name, that's rather unexpected, but it's good to know. But let's not discuss the function naming here.

There are plenty of possibilities. That GUID string, the creature's name as suggested [here](https://github.com/cmangos/mangos-wotlk/commit/84c79d80d3c0bde24f9e3599a476660b7c4c2bf0#commitcomment-11627618), etc. But let's not forget this is part of a debug command that works on the selected NPC or player, so it should be pretty obvious what creature we're talking about.

So I don't mind something better, and whatever you choose is fine for me.


hah, that `boxUpString` method is great :+1:


develop (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


There are 2 things that come to mind

* the accessors perform reasonably fast (such that `foo.bar` doesn't need to do anything super-expensive)
* the accessors return consistent values (such that `foo.bar === foo.bar`)


much version


Wondering if this is redundant? How do we have tuples if not v3+?


ack, thanks for the details!


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (647 of 647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.33%25-green.svg)


Voy a descargarlo entonces...


We have a pretty strict <br>. :stuck_out_tongue_winking_eye:


tengo que clonar el repositorio verdad?


Brant -

I'll take a deeper look this afternoon, but thus far it looks good.

There is definitely room for you to work on the Linq2Couchbase project; I am a bit behind on the project management side at the moment, but will open some tickets. If you wanted you could always start with Any(), since you indicated it wasn't supported yet. Myself and others that have worked on the project have found the learning curve a bit steep, so always nice to start with something rather simple (seemingly, but you'll find it more challenging I suspect once you get past the basic use-cases).

Note that I plan on refactoring the internals and structure of the project soon; I am not convinced the current structure will scale to the development needs of a full feature Linq provider. There is not whole lot of documentation on building a linq provider with ReLinq, so a few steps forward and a few back are in order.

Here is a partial list of features and the mapping between Linq and N1QL: https://docs.google.com/document/d/1hPNZ-qTKpVzQsFwg_1uUueltzNL1wA75L5F-hYF92Cw/edit

It's very much a WIP and comments and suggestions are encouraged.

Thanks,

Jeff


Get rid of this!


Better to have computation requirements outside the sequences testing each type


Is `SymbolFlags.None` in? Consider using that.


Sound good! Done


Good point, not as critical though.

Disclaimer: I haven't touched this for like 5 yrs, there are probably better ways of doing this by now!


vreau sa te abonezi la acest eveniment..cum testezi ca merge?


It looks like I'm not the only one who didn't realize that GetGuidStr() already includes a prefix for the object's type :smile:


It won't reply, removing the preview and reply fixes this, but with it it makes this error
    TypeError: argument 3 must be impossible<bad format char>, not bool


You probably want `rm -f` there, not `rm -rf`. `${CT_PREFIX_DIR}/lib{32,64}` specifically appeared to be unnecessary for the toolchain, in my testing, so my branch didn't alter the post-build removal. I didn't try removing the symlinks entirely but I was sticking with putting the libc stub and startfiles in lib/32 so creating lib32 as a symlink was necessary for my branch.


denumirea variabilelor nu este ok


no_raw_loops (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Sure!


Looks like a start, but where are my local updates?


This is in reference to https://github.com/mistifyio/crosstool-ng/commit/99aaef2dcd8ea738ca2c264c45a7a4c193018eb0


PGS


clasa asta tot nu e generica


@flexiondotorg: another ruin of my work :-/ https://github.com/mate-desktop/debian-packages/commit/93ec285bf9e0212dd4d82c0d4a73d36fdf9768eb


Seems like this could go on the previous line. Is it really > 80 characters?

In ruby, if you break one thing onto the next line you have to break all of them. But then the indenting is a little grosser. In ruby it would look like:
```
blah
  .select()
  .where(...)
  .then(functino () {

  }
);
```


Thanks!

On Thursday, June 11, 2015, Chuck Lauer Vose <notifications@github.com>
wrote:

> { on the previous line usually.
> https://github.com/airbnb/javascript#blocks
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Zillabot/authme/commit/685bd21e8dc12f175db866a2b5a8b008dadb4cb2#commitcomment-11646453>
> .
>


something


It may be a bug with CM. AOSP doesnt seem to have that bug. Good work on all this though! You seem to be learning pretty fast


Made this change to the comments in pwrap.sub because I implemented the feature mentioned in the comment.


Maybe, I will check. Then every time we need them, we have to compute from the CAS


What exactly would the application code look like?


I feel like objects usually start on a new line but I can't find a reference for this in the styleguide:
```
.insert(
{
  username: username
  ...
});


Nah, ignore me. Unless I have a link you should ignore me.


Yes but if wasn't your commits or OptiPop members commits I was years away... I love this. But I'm still very noob. Only 3 months...  How long do you play with Android stuff?

Btw were you able to build with llvm 3.6?


Some of these links seems a little random / general, for instance "customization" links to matching accuracy - presumably you mean "customization of links" or something? I'm not sure, it just seems a little strange to me.


Why don't you use an argument for `shape[0]`?


I'm not 100% sure, but I think you could just do [...](#portion-you-want-to-link). That would significantly cut down on these links.


@sungjin-oscar-park  README.md 문서 내에 "@sungjin-oscar-park가"에서 조사를 띄워쓰기를 했는데, 사용자 인식이 여전히 안되네요. 한번 확인해 주세요.
- ez


You already mentioned the docs portal.


Same note about short links.


This should have ``` around it.


The name of this method can be just `to_arabic`.


Hi dbongs,

I have added the new code to retrieve all airports from a particular city. Please let me know how it goes. Thanks.

Thanks & Regards
Vivekjyoti Pramanik


Ive been flashing ROMs for three years, started building nightlies and slightly customized ROMs 2 years ago, and I started actually getting into development about 9~10 months ago


2 space tabs: https://github.com/airbnb/javascript#whitespace


I havent even attempted LLVM. I uploaded it for other people to try. I may give it a shot though.


Could someone more familiar with the PS2 internals comment on this approach? Is it safe to assume that when a new executable boots, it will have to re-read memory card contents from scratch anyway, so we can safely clear the ejection timeout? Is there some driver or part of the BIOS that could possible cache memory card reads between different executables if nothing has realized yet that the memory card has been ejected and re-inserted with different contents?


プロフィール追加されているユーザの詳細ページにも飛べなかったので、修正する。


looks like the iframe#main doesnt work, even with the safer selection (safer selection is still a good idea though)
so unfortunately the larger pull might be the only option for now, other than separating the controllers into separate files and having them call the other files using the if statement structure in the big pull i made


They don't have .jbuilder files yet. Although, it's good!


84691154_AutomateBuildingOfDocs (lefticus) - i386-Windows-7-VisualStudio-12: OK (1674 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Niceeeeeee :D well my cv is really only 3 months HeHehe development will only come after exames. I need to study C and Java. My knowledge is very basic. You got hangouts? Mind to share?


like this (some fake code just to get the point across)
`if (!!new.controller) load SpotifyNewController.js
if (!new.controller) load SpotifyOldController.js`


First commit


@oblitum, it's a start.


Yeah. The `express-generator` package generates this file with 4-space tabs. :(


Yup, https://plus.google.com/+JoeMaples


Fixed for all four(+1).


Fixed.


@chrisatomix I'm fine with one pull request containing all of the changes. Whichever you prefer.
Thanks!


Just said hello :p Hehe thanks! Already following your work over the hybrid toolchains. Step on right direction for sabermod toolchains. At least seemed to be..


`if (auto II = dyn_cast<IntrinsicInst>(&I))`


You can do this. As well as when u lunch device instead of userdebug u can use eng so debugging will be enabled by default :)


Thanks vatsal for info. ;)


@artstorm I much prefer this approach. It will make it simpler to handle merges etc. I actually think we should keep migrations separate as we will be running migrations (an the incremental changes) against the production database, but we wont be running the test cases.

We also might use the seeders to seed production data that is defined with a config file for example.

We should probably use the [Model Factories](http://laravel.com/docs/master/testing#model-factories) pattern to handle getting the values for models to post to the API.


Also, I'm hoping to document the API using Apiary, so there may be some adjustment to how we get values for the model factories as we might have a common fixtures location so the apiary docs and api tests can use the same json fixtures.


I think we need more consideration for error handling.
If first one in futures failed, then we never know the result of other flush results.
It can leave flushed but orphan SSTables on disk.
Shouldn't we do "all or nothing" flush here?


This commit shifts my NavBar buttons to the right when Legacy Menu is disabled.....


Just cheering from the sidelines, this field will be a real coup for this framework.


I don't think I've seen the spinner it goes by so fast :)


Plus css animation for the win.


rax retry tests


I couldn't find the unbalanced parentheses myself but saw this in the error log:

19:16:06 T:7216   ERROR: unmatched parentheses in IsEmpty(Container(510).ListItem.mpaa))
19:16:06 T:7216   ERROR: unmatched parentheses in IsEmpty(ListItem.mpaa))

also - was playing around with some skin utility and noticed this in the font check...

+--------------+
|  Font Check  |
+--------------+
Not Defined: Reg - [DialogExtendedProgressBar.xml : Line 190]
Not Defined: Reg - [DialogKaiToast.xml : Line 198]
Not Defined: Reg - [Includes.xml : Line 776]
Not Defined: Reg26_textbox - [IncludesWeather.xml : Line 1277]
Not Defined: Reg26_textbox - [IncludesWeather.xml : Line 1316]
Not Defined: font24 - [IncludesWeather.xml : Line 2236]
Not Defined: font24 - [IncludesWeather.xml : Line 2275]
Not Defined: font24 - [IncludesWeather.xml : Line 2314]
Not Defined: font24 - [IncludesWeather.xml : Line 2353]
Not Defined: font24 - [IncludesWeather.xml : Line 2392]
Not Defined: reg20 - [SearchDialog.xml : Line 684]
Not Defined: reg20 - [SearchDialog.xml : Line 723]
Not Defined: font15_title - [VideoFullScreen.xml : Line 83]
Not Defined: font15 - [VideoFullScreen.xml : Line 98]


@vongillern Exactly, I was thinking these bits would be registered globally, in one spot perhaps, and then they'd be available everywhere. I didn't do that in my tests, just because I can't let that registration bleed through the other tests. But that's the idea.

Perhaps this code could save you a little time in parsing the table manually. The method overrides will do that parsing work for you. You could even have the value retriever look up the object from your test database, which would be loaded from previous steps.

I think I know what you mean about the comparison stuff. The funny thing is that I don't really use tables in specs anymore. I've found that they're a little too detailed for my taste, and putting that detail in English sometimes multiplies the complexity. But that's just my opinion, and I still want to keep this feature going. :)

Thank you very much for your opinion and your time!

—
Sent from Mailbox

On Thu, Jun 11, 2015 at 4:05 PM, vongillern <notifications@github.com>
wrote:

> I like it in theory, but I'm not sure that I would use it. To be sure, I encounter this issue a lot but I typically handle it with custom code because there is always something that makes it a special snowflake. The most common scenario is with relationships among entities. If Employee has a Company property, in the Table for "Given I have Employees", I will add a CompanyId field that doesn't get populated via the table.CreateSet call. I'll then iterate one by one knowing that they come out in the same order. I'll dig into table.Rows[i] to pull out the CompanyId, parse it as an int, then do a lookup. (I'm typically looking up the company by asking the company repo's mock instance). The more I think about it, maybe I would use this as the code would be cleaner in the step definition. As long as the value retriever is stateful (which it is), it'd work nicely. I would probably try to work it such that I register all of my value retrievers globally and scope them to the scenario context.
>   i think doing that would make the magic completely invisible in the step definition.
> I don't use the value comparer but that is mostly because I had homebrewed a solution prior to knowing about assist's capabilities. It is a nice to have, but I think it is easier to rationalize about your comparison if you're always thinking within the frame of the entity instead of the entity and how the table maps to the entity.
> All in all, nice work, I look forward to converting some stuff sooner rather than later!
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/techtalk/SpecFlow/commit/4cab9cdd0d5073ed13e24099610a0052334326d5#commitcomment-11643165


Valen, en este caso sirve porque solo hay una restricción de integridad, la PK, pero en caso que existan varias (p.ej: UK o FK, ahí no serviría)


That's causing unreasonably difficult conflicts, so I'll fix it when I go through the docs.


lo mismo que en el insert


I didn't realize this, but "our representatives" is still there. I meant to change that.


I18n::InvalidLocaleData: can not load translations from /tmp/build_a693254a8fb8b6967ed8c42615ea51af/producerun-producerun-76b4a99/config/locales/catarse_bootstrap/views/projects/edit.pt.yml: #<Psych::SyntaxError: (/tmp/build_a693254a8fb8b6967ed8c42615ea51af/producerun-producerun-76b4a99/config/locales/catarse_bootstrap/views/projects/edit.pt.yml): did not find expected key while parsing a block mapping at line 49 column 9>


The purpose of this migration file is convert all individual assignments to one-member-team assignment. And once we have already used this file to change the DB. This file can be commented. Otherwise it will be a problem during ```rake db:migrate```. Since we do migration first, then dump the data. When rails cannot find these assignment ids in DB during migration, there will be an error.


> Can you use Pathname for those objects. They support directories joining, globbing, file reading. Everything you need, basically :)

It's really useful :)


esta excepción la podrían tirar ambos métodos.


84691154_AutomateBuildingOfDocs (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Siguiendo con el comentario, pondría un try/catch junto con un fail en el catch para verificar no falla en el delete


@martianboy Please use === here.


Oops, add_directory, yes?


resorce でいいのでは？


新しくmigration書いて、email に変更しようか。


Forgot to update ``__sub__`` and ``__isub__`` here; causes bug #93 :)


Use std::unique_lock<std::mutex>


Muy prolijo Valen :+1:


emailのバリデーションも必要じゃないかな？


rax retry tests


@RemieRichards  @DaedalusGame

I added rand() to the spawns because things like getting attacked (which makes a popup for organs hit) caused a bunch of overlapping popups to spawn. I did it here and not in the actual popup datum because these seem to be the only situations where a bunch spawn at once.


phoneよりもtelの方が一般的だね。
こちらもmigrationで変更しなおしてみよう。


Does it solve the bug really?
I didn't find the difference.


Merge branch 'master' of github.com:Jacky-Li/interview
first merge


how did this even happen?


Most likely a coder in need of coffee


@madhuracj, I am not able to completely understand the use of this condition. Can you please help?


Closes #2


Why?


Seems complicated when we've already issued the single thread edict.  I guess it doesn't hurt...


or booze. I always code best after a litre of rum.


Hi @spcui thanks for your advice. But maybe it is not a good idea, as different release have different packages. So it is hard to add such thing in the error.


Maybe use a `std::set` instead? It auto-sorts and there is no risk to create duplicates.


@dmfenton right here


@philipmuir should we bump version to 0.3.0 or 0.2.1 and update rubygems?


This commit appears to reference the file: dlg_repl_profile.h which does not exist?


@flexiondotorg: will probably break this build in Trusty. The transition to ```libsystemd-dev``` is relevant only in Debian Testing and latest Ubuntu releases.


I wonder if I should use a test template/generator for these tests to catch a broader range of lengths with less code.


@flexiondotorg: this dependency is useless, I've already removed it in https://github.com/mate-desktop/debian-packages/commit/16363c3d06b67ce05921d70c80fa0f89d421044a


nu e asincrona


Please add insightful comment for future helpless hackers.


Looks good to me, did it work ok?


@flexiondotorg: I don't see cdbs usage anywhere.


no_raw_loops (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


WDYM?

This 2 lines of code will work in any project in case if you've included header in MyStack.cpp.

However it would be good to provide std::swap specialization in MyStack.h in order to implement std::swap(stack1, stack2) using MyStack::swap


Interesting. Is using router.config() not the recommended approach then now? I guess it makes sense to decorate a given component with a route rather than putting it directly inside. Let's you focus on the code in side of it. Thanks for the info (link above doesn't seem to work but I'll track it down).


This variable is not being used anywhere, and TPL_EDITOR_CONTENT doesn't accept any key called `addOption`. Maybe you forgot to add something here?


дополнили чертеж для закиба крепления


@flexiondotorg: polkit is not used here, that's why I've removed it in https://github.com/mate-desktop/debian-packages/commit/4687eb51c164bfaf859fdd0b0bbfd4cb6eb98324


No need to use `instance` here and on the next line, you can just use `this` directly. We only use `instance` for anonymous functions, as in that case it's necessary.


uh, idk what happened here


@flexiondotorg: useless stuff, see https://github.com/mate-desktop/debian-packages/commit/186b7e8c3727978f9f5298fcd385d407c5771dbe


needs comma


The indentation for this and other similar calls is not following the usual pattern. It should either be an argument per line, or all arguments on the same line except for the object.

So for example, either this:
```
node = A.Node.create(A.Lang.sub(TPL_EDITOR, {
  required: instance.get('strings').required
}));
```

Or this:
```
node = A.Node.create(A.Lang.sub(
  TPL_EDITOR,
  {
    required: instance.get('strings').required
  }
));
```

The first one would be preferred in this case, since it's more concise.


Again, no need for `instance`


Olá mundo!


@flexiondotorg: this implies build-dep on ```dh-python```.


This should probably be `writeOnce`, otherwise we'll need to handle changes to it.


@DinhNguyenCat : I still don't like this, although I agree that your other code should prevent the "read to much" problem. Can we use a std::string constructor that takes a length here?


Ah, friggin typo xD


I am in favor of accessors, and I definitely agree that the items @caitp listed are important.


Thanks. I'll look into it at #4. Prolly easiest to conditionally set the font based on the OS being used...


Oh, I see now that this is overriding TPL_EDITOR_CONTENT, and so that's why aui-data-editor setting its `addOption`.  It feels weird though, since subclasses could want to have any other template keys, but aui-data-editor shouldn't need to know about how each subclass overrides its TPL_EDITOR_CONTENT variable. It'd be best to call the template by passing the whole `strings` attr instead on aui-data-editor, and have subclasses redefine the attribute with the extra keys they want. That way sub classes can add more keys without having to change the super class.


Odd.

By the way, it doesn't look like you are building your changes to Battle Factory.
Do you want me to go ahead and do it every couple of days?


I don't know, if still feels right to return a promise from renderThreads ?


It seems like `TITLE_LAYOUT` is not going to be used anymore, maybe it can be removed from the code?


This will print `()` in Python 2.


This should be `untitledPage` instead of `untitlePage`, otherwise it feels like a verb.


It works when you first click select, but when you go back to the rotopaint node to make a change, the roto node doesn't release it interaction.


The title of this commit is wrong. There's no --tree-view option (same for the PR title).


By convention in rails people use the "restful" `resources` macro for this

i.e.;

```ruby
resources :bookmarks
```

That would be the equivalent of doing all this:

```ruby
get 'bookmarks' => 'bookmarks#index'
get 'bookmarks/new' => 'bookmarks#new'
get 'bookmarks/:id/edit' => 'bookmarks#edit'
post 'bookmarks' => 'bookmarks#create'
put 'bookmarks/:id' => 'bookmarks#update'
delete 'bookmarks/:id' => 'bookmarks#destroy'
```

So obviously, in this case that would be way too many methods.

You can specify the CRUD methods you want to implement by passing `:only` or `:except`.

```ruby
resources :bookmarks, only: [:index, :create, :destroy]
```

That would be the equivalent of doing all this CRUD:

```ruby
get 'bookmarks' => 'bookmarks#index'
post 'bookmarks' => 'bookmarks#create'
delete 'bookmarks/:id' => 'bookmarks#destroy'
```

Rails docs [here](http://api.rubyonrails.org/classes/ActionDispatch/Routing/Mapper/Resources.html).


The reason this doesn't work is apparently some name bug.


Linear::iterator, not basic_bucket::iterator


The __launchy__  gem gives us `save_and_open_page`


Concatenating strings like this will still be bad for localization, as some countries may not work well with having to have a preposition like **of** in the middle of the phrase. It may need to be at the beginning or at the end instead for example. Also, some countries may not like to use parentheses, and these are not offering a way of being translated here.

It would be best in this case if you had a single `strings` attr key for the placeholder, and that string could be a template itself. For example, the default value of the placeholder string could be `Untitled Page ({activePageNumber} of {pagesQuantity})', and it could be translated to something more suitable to other languages. You'll just need to render it as a template then.


Can you move the assignment inside the 'if' and add a space before the opening brace?


i wasn't sure whether to put this in chathamist or in here.  i like your suggestion, we can do a default in here.


good idea


this was a nice touch :)


This section seems to be out of place and redundant.


On Friday June 12 2015 12:37:22 Mika Lindqvist wrote:
> The command line "gcc-mp-4.9 -O3 -msse4 -mpclmul pcmul.c -o pcmul" is wrong... It's missing assembler option... Should be "-Wa,-q" for OS/X as far as I know.

Thanks, I wasn't aware of that option, which just makes gcc use clang as assembler. Makes sense, but doesn't change anything otherwise.


Why provide a Long explanation if it's the same as the short one? I see many other commands only have short form.


develop (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Instead of a follow-up commit, remove it here from this commit.


shouldn't it be ``which mount`` instead?


This would be a breaking change. Keeping it at `true` would not others to change if they don't need it.


LGTM :+1: