can't it run both? :(

2015-06-17 18:06 GMT+02:00 AbdealiJK <notifications@github.com>:

> The /.*/ and master will clash.
> When circleci runs on master, it wont know which one to run and will
> randomly choose one to run
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/854a43484a4827cbe471e23b22f670927a1eaaf0#commitcomment-11728539>
> .
>


Thanks Alden. The reference to a color was already set but forgot to update and add it to xml.


Yes, the main point here is to remove the headers to speed up compilation.
There are also some macros that are defined when you include iostream, so we could check for them and define the stream operator if iostream was already included. However, we need to figure out if C++ I/O is what we will do, as this is not clear to me yet. The solution you propose seems very good too.


I see your point, even though I don't quite see you would install suhosin as deb, and php from a custom build. Dotdeb uses the same package names, btw - and I would expect that any maintainer using different package names would mark that their package provides php5-common (for compatibility with other packages requiring php5).

How would you feel about making it a cli option?


Up to now only two player mode. I am currently working on a one player mode using Monte Carlo.


No - it'll give a warning ... try it out with another branch
It seems logical - can't deploy multiple times


this variable (`scenarioOptions`) does not seem to change across iterations of the while loop, right ? If so, it should be defined outside of the loop.


I don't think we should check this, it doesn't matter if we managed to successfully load the unit or not, we should still allow access either way.


Otherwise looks fine.


@micky387  wanted to build another rom for this device, will these dependencies be okay?
https://github.com/OwnROM-Devices/android_device_samsung_tbltexx


done - plus added to a few other new files I missed


No please, do not do this. Remove this hardcoded libs already and either use

    <dependency id="android.support.v4" url="https://github.com/MobileChromeApps/cordova-plugin-android-support-v4" />

or switch to cordova-android@4+ already and use

    <framework src="com.android.support:support-v4:+" />

Anything but make those hardcodes disappear do not let them live.

Sorry to tell that, but this commit is just wrong, introducing exactly the same issues that it solved.
Imagine a plugin using android-support-v4:

    Failed to install 'com.imaginedplugin.withandroid.support.v4':Error: Uh oh!
    "/path/platforms/android/libs/android-support-v4.jar" already exists!


Sorry yaar, there was some issue so I just copy pasted code from where it was working. Ye galti se delete ho gaya :cry:


`dont` isn't proper spelling. In our more official docs we don't generally even use `don't` but `do not`. The explanation could also use same kind of wording as the earlier examples.


Hmm, should this rather be `NOT t1` without a leading space?


well you can deploy multiple things...

2015-06-17 18:09 GMT+02:00 AbdealiJK <notifications@github.com>:

> No - it'll give a warning ... try it out with another branch
> It seems logical - can't deploy multiple times
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/854a43484a4827cbe471e23b22f670927a1eaaf0#commitcomment-11728601>
> .
>


For example:
```
ComplexD c = new ComplexD(1, 2);
Console.WriteLine(ComplexD.Abs(c));
```
is now:
```
ComplexD c = new ComplexD(1, 2);
Console.WriteLine(c.Abs);
```


Yeah, especially with the way TLSv1.3 is going, that will be necessary, I'll rework that.


I think the reason string should be omitted, different servers represent it differently


Test


Hi,

Are there any plans to bring Mogwai back to life and up to date with TinkerPop3?  It sounds like a really useful tool, especially now that Titan is on TP3.

Thanks!


ok


you can remove the "else":

```
if args.scenario is not None:
    scenarioOptions[args.scenario][1]()
# Let the user choose other scenario after the one choosed by command line
# or if none was given on the command line
UserInteractor.getMenu(scenarioOptions)
```


I was just removing unnecessary long emulation in javascript. I had performance issues of the scroll panel in wp8 and I tried several things without success. I left this one in since I did not think it could hurt. I can revert if you like?


Can you explain why this is necessary?


@mikemcquaid This bottle seems to be non-existent. Don't know if that's a known thing:

```
==> Downloading https://homebrew.bintray.com/bottles/cairo-1.14.2_1.yosemite.bottle.1.tar.gz
/usr/bin/curl -fLA Homebrew 0.9.5 (Ruby 2.0.0-481; OS X 10.10.4) https://homebrew.bintray.com/bottles/cairo-1.14.2_1.yosemite.bottle.1.tar.gz -C 0 -o /usr/local/var/homebrew/cache/cairo-1.14.2_1.yosemite.bottle.1.tar.gz.incomplete
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "cairo"
Download failed: https://homebrew.bintray.com/bottles/cairo-1.14.2_1.yosemite.bottle.1.tar.gz
```


No, I don't really care. That's just the name that I'd use, but fVec works just as well. The rationale I have for fData is that the same name can be used inside the Quaternion and Point implementations, since it's general, while fVec is explicitly for a vector. There's also fCoords, fVal, etc. The idea was just to make the code comply with the conventions.

I just have a comment on your commits: when you make a separate commit for something I did here, it makes it harder to merge these commits into your branch, as I will have to manually rewrite everything.
For something like the name of the variable, I'd like to ask that you comment here mentioning your preferred name and I (or you) can fix it here on top of the already existing commits, so we can do a fast-forward later.


改的不错～


What happens if there are multiple `NOT`s like in `NOTfooNOTbar`?


Forgot to manually publish it, on it.


Es lo típico que escribes y lo tienes muy claro, pero si el que lo lee no conoce el sistema, se hace esas preguntas, llevas toda la razón.
Quería que fuese enlazada con la frase anterior, en plan que se notaría el cambio en los valores usuales por algún lado. Pero si no ha quedado claro lo reescribo mejor. ¡Muchas gracias!


* TODO: Check for input, make sure it is a valid gitlab hook, check repo and branch are correct


* TODO: rewrite this as it is doing way too much and is very messy now.


* FIXME: Handle the failure as it is unclear what went wrong


Done.


It makes large diffs because current code does not respect the conventions. There is no way around it. Since it's just formatting, I don't see a problem with the diff size. Why do you think large diffs are problematic?


Perfect. We can follow up then :)
In the meanwhile, we are preparing and update for PAdES + timestamp support.


Why add `1` to the average time? To avoid division by zero?
Plus the last `1` needs spacing.


在 ChatViewController.m 中的138行处的[self.view layoutIfNedded]后面加上[self scrollToLast]，是点击键盘时tableview会一起向上


no need for this return - the fall-thru will do the same


this is undefined. @zachwise do you have uncommitted code?


Just added a fix for this: https://github.com/angular/material/commit/b1046bc08f5e57674bf85c04c8c980d0b6e36c67

Please let me know if this shows up anywhere else.


Sure, I have no objection, I just thought we might as well make the code fully compliant with conventions sooner rather than later. We can always change it again later if we need.


Unused import (HashMap)


+44358 Phuqr


cool!


Why do you need ```is_continuation``` for a ```FnASTType```? There shouldn't be any ambiguities at that spot, or am I wrong?


This commit was adding in the changes from the master branch, which newly included #58. I agree with your suggestion.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/13579/testReport/) for this commit**


y u fireball dis?


:fire: :fire: :fire: in any case thanks for fixing. *updates rpm*


why is an int and not a well?


Your are missing a "-" here. Change with add-apt


Assignment Branch Condition size for group_settings_batch_request! is too high. [17.49/15]<br>Method has too many lines. [12/10]


Assignment Branch Condition size for members_list_batch_request! is too high. [19.44/15]<br>Method has too many lines. [12/10]


Use `%` instead of `%Q`.<br>Use `%Q` only for strings that contain both single quotes and double quotes, or for dynamic strings that contain double quotes.


Extra empty line detected at method body end.


Ok, I will propose a solution to this in a later commit.


Unnecessary spacing detected.


Do not use `do` with multi-line `while`.


Extra blank line detected.


Unused method argument - `expected_group`. If it's necessary, use `_` or `_expected_group` as an argument name to indicate that it won't be used.


Unused block argument - `key`. If it's necessary, use `_` or `_key` as an argument name to indicate that it won't be used.


ugh, why can't the whole world have the same build environment i have


zz


This need to be on the same line. It is an unique command.


`${PROXY_URL_WS}` now available. https://github.com/bgruening/galaxy/pull/3/


OK it seems like this is mostly copy-pasted(you should not need to do much changes) from Adasecant2 class. Have you checked if it works or not?


No, everything is committed. It's working fine here.


No, actually it's good that you ask people. Giving some feedback is the least they can do if they use tools/plugins written by others.


I didn't understand this comment. Blockwise normalization should be done for each parameter separately, It should not create any problem.


@DomT4 can you get it now?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16432/testReport/) for this commit**


actually `this.message.updateDisplay` is undefined because the message is not a VCO.Message


yes but be sure your have this commit too
https://github.com/micky387/android_device_samsung_tblte-common/commit/33c9f66c81e94eb7a957b5bffa018cefb14e0a81


Removed try catch because it's seems weird to catch a *SQLException* from a function that is supposed to throw a *SQLException* **OR** *ConnectionException* and encapsulate it in a *ConnectionException*.

Also it's impossible to catch an *SQLException* when using **SimpleQueryManager::query()** since it uses the method **Connection::sendQueryWithParameters()**


For any reason I can't run Servlet inside a Tomcat Embed 8.0.23, so... I downgrade the version for 7.0.57.

:octocat:


No dice. Still a 404 here.


They never handle 418 errors :( Noobs!


Maybe rename 'log' to LOGGER. Then it is consistent with other classes in Dropwizard metrics. At some places they use 'LOG' also.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2153 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.29%25-yellow.svg)


Des que j'ai fini le rapport je viens t'aider avec ce code va :)


Well, we had this discussion after I made these commits. Not mixing types is much safer in my opinion. It's possible to allow some mixing by providing the right constructors and letting the compiler convert the input when needed, in a similar way to when you pass a float when a function takes a double parameter. I will make a new commit and we can discuss it further after that.


see https://github.com/NUKnightLab/TimelineJS3/blob/1fc4b7b22d08664bf91d8c2d9a570d92b58566b9/source/js/VCO.Timeline.js#L137


It should be see https://github.com/NUKnightLab/TimelineJS3/blob/master/source/js/VCO.Timeline.js#L223


you forgot the "else" here.


wait, how in the world did this ever work?


r+


To be more accurate:
```c++
 } else {
          showPiecesAvailability(false);
```


@SirEdBr atleast get the correct language!


@DomT4 Gah, the file is physically published on Bintray.


Note: For situations with heavy light it might be a good idea to set the following settings:
OMX_CAM_EXPOSURE_COMPENSATION = -10
OMX_CAM_SHARPNESS = 100
OMX_CAM_CONTRAST = 100


THIS IS A COMMENT THAT i WOULD LIKE TO SEE IF IT UPDATES


@JJ I need to access to the files to check the fitness, the oponnent and number of times with the help of @deantares here, could you add them to the repo?


how about
```
junit4=`find $dir -name junit4.jar -o -name junit.jar -quit`
```


`man 3 printf` says about length modifiers:

```
z      A following integer conversion corresponds to a size_t or ssize_t argument.  (Linux libc5 has Z with this meaning.  Don't use it.)
```

and (which might explain why MinGW also doesn't have the `z` length modifier):
```
The SUSv2 knows about only the length modifiers h (in hd, hi, ho, hx, hX, hn) and l (in ld, li, lo, lx, lX, ln, lc, ls) and L (in Le, LE, Lf, Lg, LG).
```


Inline this variable and static import the method


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/3631b9590777976ea53160574d95aa35aefc594f


merging graydon/stellar-core/loadgen-fixes = 3631b959 into auto


graydon/stellar-core/loadgen-fixes = 3631b959 merged ok, testing candidate = a3f445db


Makes sense to me. I will do that in another commit. The point here was only that sincos is not in std::, but in the global namespace.


Let's remove this comment since we'll support nested dispatches


Would it be possible to add a date to ensure it is being converted to a string in the way we expect it to? Could you also add it to the item at https://github.com/zyegfryed/godo/blob/c65185663ce1c14b16b3732bf263b3cc54caa2ed/droplets_test.go#L367 as well?


Add a fourth shard that is 120 bytes (larger than the limit)


var SIDEBAR_TITLE = 'Example Sidebar';
function onOpen(e) {
  SpreadsheetApp.getUi()
      .createAddonMenu()
      .addItem('Show sidebar', 'showSidebar')
      .addToUi();
}
function onInstall(e) {
  onOpen(e);
}
function showSidebar() {
  var ui = HtmlService.createTemplateFromFile('Sidebar')
      .evaluate()
      .setTitle(SIDEBAR_TITLE);
  SpreadsheetApp.getUi().showSidebar(ui);
}
function setActiveValue(value) {
  var cell = SpreadsheetApp.getActiveSheet().getActiveCell();
  cell.setValue(value);
}


COMMENTS HAVE BEEN UPDATED VIA STAR CENTRAL AND ARE IN VERIFICATION STAGE-AUTH94629((*&^49


This is doing `list.get(list.size())` which will always fail. Why do the tests not catch this?


Good Afternoon

I am getting Problem, I have Create My Sensor Template but when I save the Values From Temperature OID leaves also from the Humidity, when I regedit and Update the Template the Values goes on again, I have Installed the Version 4 of the OpenDCIM today and the configuration files are according to the Files Above, I need help


Frank, Zu is 'not' %Zu    It is a #define, that will be "zu" or "u" depending upon the compiler used.

Look closer at the quotes.


you need to get the result before calling rm ("$?" holds the return result from latest command)


You forgot to remove this definition -- you'll get a redefinition warning.


.gitignore


now that I read this properly, we need "sort -u" instead of "uniq" -- because I know developers won't ever sort this properly.


I added it because the syntax checker complained, and I needed it to compile the test too.


Make this a normal loop that starts from zero


My thoughts exactly..


`ResultSet` needs to be used in try-with-resources


I don't think `break` is what you want to do here. It will fail to compile if outside a loop, and in a loop it will give unexpected results.


Nicely done Ed and Vinnie improving the const correctness of these passed around closed `Ledger`s.  In unit tests the cost of making an extra `Ledger` copy will not be prohibitive.


Ok, thanks. Just don't forget :smiley_cat:


j


I think this means we go for 3) and get `${PROXY_URL_WS}`.


How about naming this class PrimitiveWrapper or ScalarWrapper?


Update from original - 2015-06-09


test for: https://code.djangoproject.com/ticket/9619


I think it is more idiomatic to do a `get()` and check if the value is null


I can fetch it manually by doing:

```
curl -I https://bintray.com/artifact/download/homebrew/bottles/cairo-1.14.2_1.yosemite.bottle.tar.gz
Location: https://dl.bintray.com/homebrew/bottles/cairo-1.14.2_1.yosemite.bottle.tar.gz?expiry=1434558778386&signature=jLQjlsj6odOg8yWIYuewLPVksJ%2BIyyXWh%2F5SVO0pUBmn4OT7aoWHwKHy%2BzWeLPcQ7n66ANlH%2BUK0zh9dpliBuQ%3D%3D
```

```
curl -O -L https://dl.bintray.com/homebrew/bottles/cairo-1.14.2_1.yosemite.bottle.tar.gz
```

But the checksum is off:

```
gsha256sum cairo-1.14.2_1.yosemite.bottle.tar.gz
23f042c4e3e41e5ec500c9a72dce20bd2eedbbd4facb7ff80bc30d1be75067df  cairo-1.14.2_1.yosemite.bottle.tar.gz
```


That's an unacceptable user experience.


i don't really understand this, is this equivalent to
```
EXTRA_CLASSPATH_JAR=$junit4_jar
```
?


Your own commit hooks make committing with tabs impossible.  This file uses tabs.  I'm unclear what you want.

The real fixes are around line 632, they deal with the junit jat finding..


ControllerDataManager.TYPE_SHOW ;)


You've commented on a commit that is more than 6 months old and not guaranteed to be current.  Please email the mailing list for help or join the IRC channel.


(same in all other places we use uniq)


Great!


Oh, wait. The bottle URL should be `cairo-1.14.2_1.yosemite.bottle.1.tar.gz` right because the revision of the formula is 1 and the revision of the bottle block is 1? In which case, I can't see that file on Bintray at all.


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (2183 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.64%25-yellow.svg)


@DrPheltRight At this point in the project, I used Leiningen, so `lein repl` was appropriate. Now, though, the command would be `boot repl`.


ah I see we use `|sort |uniq` previously -- this works too, both work


Add /* global __WEBPACK__ */ to prevent undefined from ESLint validation.


This documentation doesn't look accurate.


If you do a _fine grained_ pull request with only this change, I will consider merging it into master. A more elegant way of notifying a user of failure is mandatory though.


Nit: Remove whitespace.


This could result in a query with many thousands (or more) of shard IDs, which probably won't work. Take a look at how `DatabaseShardManager.replaceShardUuids` handles this with batching.


@PhilJay Thanks for adding this! There's a more direct way to do this though by just adding `Comparable` to the `Entry` class. Like this:
```java
public class Entry implements Comparable<Entry> {
    @Override
    public int compareTo(Entry entry) {
        return this.mXIndex - entry.getXIndex();
    }
}
```
That should also work (although I haven't tested it explicitly). The bonus would be that just sorting the `ArrayList` using `Collections.sort(mEntries)` would also work.


ControllerDataManager.TYPE_SHOW a la place de 1 ;)


mix liquid in **source** well?


Formatting


This looks misaligned.


Nit: Move it to the previous line to be consistent in code style.


Nit: There should be a single space after `if`


Nit: Move it to previous line to be consistent with code style.


No, I do not stricly need it. But it captures the *syntactic* difference between `fn (a, b, c)` and `fn (a, b, c) -> !`. I can remove that if you want.


A retirer la liste de News, il ne s'agit pas du même manager.


CONVERT TO TERNARY
&
READ COMMENTS ON TIME


Yes, it'd be. I actually did this in the CobbleWorks, but I did not touch the TelePad any more than necessary.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Verify that this is `> 0` or else the loop won't exit


sorry,i dont see you have an ownrom.dependencies.
Perfect.good luck


Nit: Remove whitespace.


Right, that's what "Refs #9619" means in the commit message.


Well, too much work for just reading ... maybe it's useful for later reply parsing ^^


@JJ changes on MADE section are ok to me


Nit: Remove whitespace. (line 338-339)


unable to login, do you have a demo account?


Why?


Nit: Remove spaces here - just use a line break.


Move the `if` to the end of the loop


Nit: Move to previous line to be consistent with code style.


Ah, that's a bummer that it won't show. This seems to be one of npm's rough edges. I'll try to get a better solution in place


That's interesting to put a second run() function. I don't know the impact of that, are we sure they are both executed? (I always used one only)


no http://www.yaml.org/YAML_for_ruby.html#strings
Only required if we are using £, :, interpolation e.t.c


````
    View() = default;
    View(View const&) = delete;
    View& operator=(View const&) = delete;
````

Especially for abstract base classes, default to non-copyable.  If that doesn't work, make the copying explicit, even if defaulted, as this is somewhat unusual.  In this case I tested that the copy members can be deleted and everything works fine.


This can be a for-each loop over the shards


That's really `jeff` and not `@jeff` ?


These two lines can be removed as well, in blocks case they are not really necessary.


Is it ok if this creates an empty compaction set?


I think, we should remove it. There a several spots in Impala, where the user can use syntactic sugar for sth and the AST does not reflect the syntactic sugar.


I agree. The proposed code misbehaves when doWork throws a minor problem such as a UserError but onShutdown throws a major problem such as ThreadDeath. The error gets masked (ie is not rethrown only printed).

I think we should enumerate all scenarios and see if we can come up with a scheme that works for all.

Let's say there are 2 methods, start and stop and each can have one of 3 possible outcomes: ok,exception,error

I think the desired semantics is that all stacktraces are printed but errors don't get masked by exceptions. It would be desirable that stop gets called regardless of the outcome of start (but we could relax to "stop gets called only if start ended on OK or exception").


Put the comment above


Je sais pas si c'est trop worth it de tenter la création de toute la gestion REST à la main. As tu regardé du côté de ça : http://programmerguru.com/android-tutorial/android-restful-webservice-tutorial-how-to-call-restful-webservice-in-android-part-3/ ?


It just looks like Photos also has different versions per DPI...


That is correct. We totally lack documentation for developers though!


Yes, that seems to be the case. I thought not having it could lead to undefined behaviour, but since we don't have pointers, even the default operator in this case could be fine, so we can just omit it altogether from the class. I will fix it.


We should not free response. At least this way. Responses are formed from cached data blocks and it has sense to store prepared skbs as well to minimize time for next responses.


Bah t'as quasiment fait le plus dur, un peu de refactoring, de la communication et ensuite c'est terminé pour toi (j'ai pas encore regardé le JSONParser cela dit ;) ).


Hrm, haven't seen this one before. It seems to be a bug in `screen` itself as 4.3 won't compile outside of nix either on darwin.

```
substituteInPlace utmp.c --replace "ut_tv.now" "ut_time"
```

seems to do the trick.


This might be simpler with `ComparisonChain` (not sure, would have to try)


Pero si por eso hice un branch nuevo. Registrofixes, esto no es máster.
On Jun 17, 2015 7:35 AM, "lhchavez" <notifications@github.com> wrote:

> intenta no meter commits temporales en esta rama porque recuerda que es la
> que (aún) usamos para deployment. commits rotos aunque sea por un rato
> dificultan acciones antipànico
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/omegaup/omegaup/commit/26ec7acf1aa09fa093a84c8669b1f545ac8489f5#commitcomment-11726600>
> .
>


I took a look inside the `Ledger` constructor being called.  It looks like the reason it takes a non-`const` `Ledger` is because it calls `updateHash()`, a non-`const` member.  I don't know `Ledger` hashes very well, but it seems counter intuitive that a `const` `Ledger` would need to have its hash updated.  We could potentially add an overload `Ledger (bool dummy, Ledger const& previous)` that replaces the call to `updateHash()` with `assert (prevLedger.mImmutable == true);`.  Then, over time, prune calls to the non-`const` overload.


Invert this so it returns if `!= 0`


Again, it's better if you return a copy than the mutable object.


`ShardCompactionManager` needs tests, especially covering `filterShardsWithTemporalMetadata()`


Please mention "acknowledged" - "acked" is very confusing for someone new


Ugh... Forgot again. Thanks...

—
Sent from Mailbox

On Wed, Jun 17, 2015 at 12:46 PM, Fábio Bernardo <notifications@github.com>
wrote:

> Again, it's better if you return a copy than the mutable object.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/makwanza/ios-exercises/commit/2acbee66e0de32a55fa6db742c93d13b968240f3#commitcomment-11729386


This revision is clean.


This repository is causing failures for the StyleCI analyzer ;) unrelated to this package actually.


:ok: :1234:


No need to do that. Just describe the game. I'll include that in results.
Anyway, data fiels are in other repo, included at the beginning of the file
in the R chunk.

2015-06-17 18:28 GMT+02:00 Pablo García Sánchez <notifications@github.com>:

> @JJ <https://github.com/JJ> I need to access to the files to check the
> fitness, the oponnent and number of times with the help of @deantares
> <https://github.com/deantares> here, could you add them to the repo?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/2015-ECTA/commit/963c8354905b171d21e0432de1c531036b49c9b7#commitcomment-11729015>
> .
>

--
JJ


Well, this actually solve my problem, and it's an update on another [plugin](https://github.com/Telerik-Verified-Plugins/PushNotification/commit/99a50a58f1f178ed954db47ab22754cbd6d5ac46).


Gah, it looks like there's some sort of bottling versioning bug here.


Question : Does this imply that if someone from outside write "@rultor merge" in the PR it will get merged ? Or does it check the access rights of the person who writes it ?


ack


siae doesn't need a host addr


Bad, it breaks Dark theme


ah una disculpa. GitHub no muestra la rama a la que pertenece el commit en
los correos :'(

Si estás en una rama, ni pidas disculpas :P Haz todo el puerquero temporal
que sea necesario.


You have a bug here, this would loop infinitely. Can you fix it?


It will check access rights, if someone with no permission asks I think it will ask me for confirmation from me.


Should this comment be updated?


Adding CO2 is a good idea but an abundance of 1% on Kerbin is way too high. Such a would would have severe Global warming Issues


Integer is confusing. When referring to discrete wells in a 384-plate  A1,A2,B1,B2 can translate to 0,1,24,25 but referring to them as quad starting points would translate to 0, 1, 2, 3.


You should check the case of the array being empty.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/67226227


Ah. Sounds good then.


ok


@HirenBhalani-BTC Same as above, you can put `params[:days] || 30`


You still need this array?


好的，已修复，Thanks！
https://github.com/leancloud/LeanMessage-Demo/commit/3cb677a25786bc2f7dab6b505f3d2617e9af0e4b


These should all be named spaced.  For example parquet.bloom.*


the .gitignore thing is quite annoying - i use IDEA :P


(doesn't matter :P)


Rubocop did this when it was run locally, not sure why.


Did you add the -b option with it? Those two are mutually exclusive now.
I'll find a way to warn users in the code eventually but for now I just
updated the documentation.

Though I now see a problem that this causes with output upload. So that has
to be fixed.

On Mon, Jun 15, 2015 at 3:42 PM, CoryFunk <notifications@github.com> wrote:

> Just tried this using the -L option and having the full path s3 location
> in a file and it failed to download anything from s3 because it appears to
> have assembled a wrong s3 address.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PriceLab/snapr_workflow/commit/c69cb411ce33a56bd05e7c15113c746da1382b87#commitcomment-11691054>
> .
>


fast-forwarding master to auto = a3f445db


maybe use `source` so that the original script is run in the same shell and we preserve env vars, etc?


@JJ ok, both are correct in the geneura.bib file. BTW, I prefer to use only a .bib file per paper, copying the necessary references to that .bib (even the ones in geneura.bib) so I can manage better the changes and only update one repo (for example, sometimes we have to shorten the conference name or delete editors of a reference to save space...). But it is just my way to do the things :)


Yes, this change is basically cosmetic.

As for the operators, the * operation can be confused with a dot product, and the division may contain a zero, which is not being checked and can cause problems ahead. Not having the * and / would be better, but if we do decide to have them, we need to put in an assert in the division operator and separate it from the rest. The more we mimic how we do algebra on paper in code, the easier it will be to read and write. I've used the * operator for the dot product in other code, and the ^ operator for the cross product. I have also seen other people use the | operator for the dot product, to write dot(a, b) as (a|b). In exterior algebra, dx ^ dy is similar to a vector product. Anyway, I will leave the decision to you here, but I'd rather use a function like the MultiplyByComponents() from the USolids interface rather than the * operator.


You can get rid of this entire block.


we fixed it in the develop branch. it looks a lot cleaner there


Looks fine to me.


Hi Pavel, you could use the function slurpTable() and filter results in Lua :hammer:


Yep...grrrr...

012 - universal (?)
015 - xhdpi
016 - xxhdpi


@HirenBhalani-BTC What we are trying to get here, do we need date or can we do `30.days.ago` ?


done. added tests too.


reack


done


Seems strange to capitalize `void`


Mehmet bahsettigim overlap problemi hala devam ediyor sanirim.

Senin cozdugun problemin disinda birde pointler olusturulduktan sonra browser buyukluguyle oynayinca problem oluyor. Mouse koordinatlari guncelken points koordinatlari browser degismeden onceki degerlerini koruyor.

Cozum olarak galiba o noktalarin browser boyutu degistikce yeniden cizilmesi gerekiyor.

Bu arada programin son haline bakamadim henuz, sadece ilk commitine bakabildim.


Capitalization


This was just me playing around with the different methods earlier today. I shouldn't have added it to this commit. Sorry.


Tamamdir. Halletmissin bile sanirim haha :D


Either multiple PRs or squash commits, whichever works!


``pf.types`` should be only ``types``. (good for uglify) (same in line 248).


Why is there no  `ICACHE_FLASH_ATTR` on `void transmit()`?


ack


I can't run/compile this commit due to an "Expected Variable or Procedure, not enum type" error with that last parameter.


`MetaView` can be copy constructed, and is derived from `View` how would this work?


Consider using `unwords` here.


The class should inform the calling class of the occurrence of any error.


State error


The ``w`` shorthand is now ``window``. (see: https://github.com/scottjehl/picturefill/blob/afarkas-pf3-proposal/src/picturefill.js#L6). But I actually don't see a reason to use ``window.Image``, why not simply Image. Or re-use the already in use ``image`` variable, that we created (free to use) (https://github.com/scottjehl/picturefill/blob/afarkas-pf3-proposal/src/picturefill.js#L18)


Thanks for doing this! This looks OK to me.


joptsimple.internal.Strings is not used anywhere.
I made this deprecated - it's easier to keep for porting. Later we'll inline it (I changed it to use the guava version of Strings)


I think there's danger here, we're creating a function that looks like part of an API (similarity to `getAccountRootIndex`) but its secretly doing user input validation and although it returns a `uint256` it can "fail" by returning all-bits-zero, which is different from every other function that starts with `get` and ends with `Index`. It needs reworking.


yok abi bitmedi henüz :) Araya birşey giriyor sürekli :(


Please see https://github.com/makwanza/ios-exercises/commit/2104bf04edf06ed03ca05291344e9f879ebf0b78 for the fix of this and other issues noted in this commit.


done


I don't think presenting a default-constructed `TicketContents` to mean "not present" or "invalid" is a good idea.


Is the `..` correct? Below the `$(pwd)` is added to the PATH. So `.` would make more sense I guess.


@HirenBhalani-BTC We can load the service using before filter,

``` ruby
before_filter: load_learning_report_service
...
def chart_by_learn
   @learn_chart = @learning_report_service.learning_report
   @tag_chart = @learning_report_service.tag_usage_report
end
...
private

def load_learning_report_service
  get_date
  @learning_report_service = LearningReportService.new(current_user, @date)
end
```


Cool.


memory leak in case of `retval != MAPI_E_SUCCESS` (old_idset and new_idset won't be freed). This happens as well in other parts of this function.


Following the command lines above, you are in kubernetes/.. now


`auto`


`auto` and assignment syntax


@bryanl done in [20712022a47f8912fab2591559a629fc279e4a9e].


обява_маркетинг.md

Мммм... Това какво означава?


This only blows up for incorrect quads in 96 well plates.


`ticketOwner_`
`ticketSeq_`


Missing indentation


great. just a very general comment: package names are written with lower-cases. so its fine to name it imagej.ops.views


should delete everything from here to the sentence before the image


Why?


Sorry, fixed!  That's what I get for naming variables and enums too closely :/


`auto const&`


should be a list in markdown style


This alias thing is really cool. Have you tested it locally?


@cmelion maybe it makes sense to define that global in eslintrc and remove inline comments with it?


You could reduce this to only 2 sentences pretty easily.


Add version number: `"underscore": "1.8.3"`


Do we want a golden files test with TheCrew to sniff out run-to-run variation?


`auto`


I'm confused.  You don't install tutorials.


inlined ArrayUtils.addAll


... and share the same network stack ... which allows to communicate via 127.0.0.1 within a pod.


That's what you get for not using the fully qualified names! :) Glad I started from scratch with that. Thanks for the quick fix, looking forward to trying this rotation stuff out.


could be simplified a lot


still missing a lot of explanations


I know that. The module param only needs to be added in thermal not in dcache.


It catches case where all input is on host but output is transferred to device. It is rarely the case as the inputs of BlockSparse usually contains at least one shared variable which is automatically a CudaNdArray when using the GPU. But still, we don't want to miss that case. :)


Aye, impacts the GTK+ bottle with the same formula & bottle revision situation as well:

```
~> brew fetch gtk+
==> Downloading https://homebrew.bintray.com/bottles/gtk+-2.24.28_1.yosemite.bottle.1.tar.gz

curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "gtk+"
Download failed: https://homebrew.bintray.com/bottles/gtk+-2.24.28_1.yosemite.bottle.1.tar.gz
```


`RIPPLE_TX_CHECKANDCONSUMETICKET_H_INCLUDED`


You don't explain what these functions actually do.


@HirenBhalani-BTC

Using ruby's shorthand,
- To implement getter-setter both - use `attr_accessor`
- To implement getter - use `attr_reader`
- To implement setter - use `attr_writer`

We can also implement these methods manually.

This is same as Java's `getName` and `setName` for `name` class attribute.

So, We should use `attr_reader` as following, because we want to assign the value only once. Once assigned, the instance variable should not be accessed directly, and should only be accessed via a getter method.

``` ruby
  attr_reader :user, :date
  ...
  def initialize(user, date)
  ..
  end
  ...
  ...
  def learning_report
    learn_time_data = LearnTime.report_of_learn_time(@user.id, date)
    links = user.total_links_after(@date)
    ...
  end
```


Oh! Thanks to your IDE. :)


all code belongs inbackticks


Seems like you're reproducing some of the functionality of `pattern-arrows` here. We should go over this.


What if something comes up about insecure comparisons with `strcmp`? Shouldn't we expect it with another way to double-check the password? :P


`tickerOwner_`, `ticketSeq_`, `ticketIndex_`


`auto`


There is no need for manual user intervention due to the `bash(1)` script introduced. This file will only change automatically.


`auto const sle =`


@HirenBhalani-BTC Line no 11 and line no 22, are duplicate. Rather, we should make it as constant and use at both the places.


`auto const&`?


Please avoid this kind of commit message. “Fix bug” is very generic and is not helpful: which bug are you fixing?
Punctuation is to be avoided in commit message titles (and remember the emotion you had when finally fixing this bug could be very different of the one you get when you realise this “gotcha!” commit actually introduced another regression  ;)  ).

The best way to handle such a commit message is to use the `fixup! <tree-ish>` syntax: this way, one knows which commit it is fixing and can infer which regression it is fixing.


Ok, will do.


:ok:


Why?


> Richard, would this similar commit also work for you?
> grondo@130bc91

Yup, that works too.


I'd like to understand this better


@HirenBhalani-BTC
- Follow the rule of encapsulation and data hiding, define only those methods as publich which needs to be called from outside using class instance.
- All other methods should be `private`.

Using OOP fundamentals will help keeping our code modular and manageable.


yeah, the quotes matter, otherwise we get an error telling that everything passed inside the env dict should be string.


I looked at IP addresses, and it is possible to look at the IP addresses for a given device, but this is complicated by NAT.  I think it may be necessary to register the server's expected fully qualified domain name.  Perhaps via an environment variable or a server specific config file?


@HirenBhalani-BTC Should be `private`


Nice solution, you came up with here! :+1:


Told ya :-)


Could use `class id`, e.g. `ticket::id`


Same note as previously about function names as verbs instead of nouns.


We can change that


oops!


@mpeven do we want to make this not "poc"? eventually it'll be in production


@HirenBhalani-BTC Rename it as `create_learn_time` . Naming conventions should be such that, developer should be able to understand the purpose of your code (Class / Method / Variable)


for anyone else that reads this please see issue https://github.com/angular/angular/issues/2584


there's a `cd ..` after the make.


are you sure. i see 7 invocations. and the method doest just do dupBytes


`advanceLedger` could take a "number of times" argument


Je k tomuhle nějaký opodstatněný důvod?


@HirenBhalani-BTC Method name should be `add_favourites`, as we are adding one more favourite to existing `link`.


inlined


What's the rationale here? That isn't implicit?


i have created the fixture how do i send to qlc+


Found a few small issues.

Right now this code just appends a new div to the end of the body when you change the question type. It would be better to create a question container and then append everything inside of that.

Each time you change a question you're just hiding the old div container instead of deleting it. Ideally you should delete the div container if you're not using it anymore. Hiding it still slows the page down.


@HirenBhalani-BTC Why we have used `destroy_all` ? What is contained inside `favourite` ? Shall it not be `favourite.destroy` ?


I have concerns about doing validation inside this function, it doesn't fit into our model of how we compute state item keys. And there is the issue of using all-bits-zero as a special return value, consider `boost::optional` instead. But really, the validation needs to happen in a separate function so it is explicit. Putting the validation in this low level routine creates problems for all the functions that call it.


OK, working now. Rotating complex text is really impressive, especially that you can resize the bounding box once rotated and the text re-wraps to match. That's bloody impressive. Performance is very good to.

Just one problem, the rotation handle falls outside of the canvas too easily. If I position something in the right side fo the canvas I have to zoom out to find the rotation node. The node should ideally be smart about where it places itself so that any selected object has the rotation node on-screen.


You are right. We talk about the downloaded examples, not the ones in kubernetes/examples.


@HirenBhalani-BTC This was a good refactoring, compared to old code where you were checking and creating the record separately.


@frenkield I implemented some weeks ago the code to download a set of files (model, results of a simulation, etc.) as a zip file. I was sending the file through the socket using (the same command you use for the compression):
```
wsOutbound.writeBinaryMessage(buffer);
```
When we merged your code, the download feature stopped working properly. The main problem was that [I was checking if the data was a Blob](https://github.com/openworm/org.geppetto.frontend/commit/6ed6962608aadb5e0ddfc2ded2432b6fd3d9f02d#diff-9d52d735f4178c88f72a710dd95ca517L90) and if so I considered it as a file and I open a 'save as' dialog. Due to this [bit of code](https://github.com/openworm/org.geppetto.frontend/blob/datamanager/src/main/webapp/js/websocket-handlers/GEPPETTO.MessageSocket.js#L64) you added, the file is not an instance of a blob anymore but an arraybuffer. After discussing with @tarelli how to solve the problem, I have added a byte at the beginning of the arraybuffer (0 for compressed message, 1 for files). So now the 'if' looks like [this](https://github.com/openworm/org.geppetto.frontend/commit/6ed6962608aadb5e0ddfc2ded2432b6fd3d9f02d#diff-9d52d735f4178c88f72a710dd95ca517R103). What do you think? Can you think about a better (and probably more elegant) way to solve this problem? Obviously the sendBinaryMessage function you developed and the one I did should be merged and some redundant code removed but I need a quick fix so I can go on with other stuff.


This fixes [bug 1174351](https://bugzilla.mozilla.org/show_bug.cgi?id=1174351).


`'fl': ['a', 'b', ...]` instead? Or is a single large comma-separated `fl` param what solr expects?


Functions declared inside the anonymous namespace are helper functions intended to be local to this file only.  I thought you would find this preferable to using a detail namespace inside of a *.cpp file (which is my preference given that we do unity builds).  The anonymous namespace still helps a bit in a unity build.


done


might want to normalize spacing between operators/operands
normal is a single space


Ve větvi guzzle je připraven přechod z pecl http na guzzle, které ale vyžaduje php 5.5


Commit message: Poster effect


```:payload "bar.example.com"```


Help me understand - if the name is unique then the anonymous namespace is not necessary. If the name is not unique then it will break in a unity build. What am I missing?


Fixed.


Suggest `msg` so that it's closely associated with `msg_len`


```:payload (json/generate-string "bar.example.com")```


General comment, not really related to this PR but I wonder how much value shrinkwrap is really giving us? It looks like it's changing minor versions on all of these dependencies needlessly.


你覺得這種垃圾我會同意嗎


Is now `check_heartbeat`


This is for defensive coding, if a NULL got passed in for some reason then it would cause a failure / crash eventually but it may be hard to diagnose. This way it fails immediately with a clear error message.


It is not a breaking change.  If this is called with just the 1st arg, then `disableAlertSafety` is undefined, which we check for in `_disableJavascriptAlertBoxSafetyTimeout`.

The reason it is here is that if you call `_disableJavascriptAlertBoxSafetyTimeout` before the init function, then the value is lost.  Since `_disableJavascriptAlertBoxSafetyTimeout` is most likely to be triggered from Obj-C while `init` is called from the other side of the bridge, it can be pretty unclear from the Obj-C side in what order things are happening.  This is the first place where it can be set and retained in the Javascript code.  Also, any messages in the queue would be sent using the speedup.  There is no other way to get those messages to use the faster bridge.


global in eslintrc sounds like the more scalable solution.


this won't handle the case of "Jon T Gautsch"- ruby has build in `.first` and `.last` methods on arrays though


typo


done


ぐえー


in ruby, explicit returns aren't required. whatever is returned in the last line of a block will be returned (in this case, `locals`)


Forgot to mention it in the commit message, this fixes https://github.com/magnumripper/JohnTheRipper/issues/1350


Sinon made me do it. :P


ack


@sgotti Cool! Thanks for the explanation!


With that kind of reasoning you should write everything in every possible way just to be sure... :P


Mistake: should be "current"


No unit tests


Fair.  This function is intended to be only a local helper function, as indicated by its presence in the anonymous namespace.  Would you prefer returning an `Optional` or `pair<uint256, bool>`?


Since we no longer are using the range slider should we drop the min and max values from the input? Seems unnecessary to have it at this point.


Well, these two methods are generally enough. The more you add the more paranoid you are.. :P


`(= types data)` ftw


Ops. I think I missed ICACHE_FLASH_ATTR .
Also need to update the comment:
//rc.send(0,267715,24,185,1,repeat)    --GPIO, code, bits, pulselen, protocol, repeat

Will clean up soon.


>It's used to hold an int, but also to hold an incoming message (that should be just an int). It's really just a buffer. This is likely getting refactored though, so we'll see if the name survives the refactoring. Comment has been updated.

Renew my request for rename to `parent_message_serialized` since that's now exclusively what it stores.


^gui


2015-06-17 18:55 GMT+02:00 Pablo García Sánchez <notifications@github.com>:

> @JJ <https://github.com/JJ> ok, both are correct in the geneura.bib file.
> BTW, I prefer to use only a .bib file per paper, copying the necessary
> references to that .bib (even the ones in geneura.bib) so I can manage
> better the changes and only update one repo (for example, sometimes we have
> to shorten the conference name or delete editors of a reference to save
> space...). But it is just my way to do the things :)
>
No, you shouldn't. The master file is known to be correct, can be updated
independently of the other files, and is an incentive for us to keep it
clean and updated.

--
JJ


I saw that later, but still it would be more intuitive!  Maybe something like "Please use `set-password` to properly set this value" or something...

 Also you could just remove this file from the repository since it is generated by the script.


Evet o problemi de fark ettim ama onun çözülebilmesi için noktaların yeniden çizilmesi yeterli olmuyor. Resizedan önce çizilen linelarında noktalara göre render edilmesi gerekiyor vs. Bu yüzden şimdilik workaround olarak resize eventinde dediğin gibi canvası temizleyip noktaları yeniden çizdiriyorum. Zaten kullanıcı ekran boyutunu başta ayarlamalı ya da hiç dokunmamalı(biz responsive design yapıyoruz zaten). Oyuna başladıktan sonra resize olayı mantıklı değil bence. Şu anki haliyle iyi sanki :dancer:


not in the guava Strings.


I think you should write
`bool valid(TicketContents const&)`
and then have
`getTicketIndex` simply assert on its invariants, so that callers never check the return value of `getTicketIndex`.


Ok, dík. Nezůstane pecl http jako paralelní alternativa? Pak by 5.5 mohlo být jen jako suggested...?


```'use strict';``` inside the IIFE


I think it is correct. Here is an example query url.

http://adsws-staging.elasticbeanstalk.com/v1/search/query?fl=title,abstract,bibcode,author,keyword,id,links_data,property,[citations],pub,aff,pubdate,doi&hl=true&hl.fl=title,abstract,body&q=author:"accomazzi"&rows=25&sort=date
desc&start=0


A massive code refactoring looms large in PD's future.  I am not looking forward to that day (but it sure will be nice to have it done... eventually!).

Thanks also for the feedback.  Improved rotation node positioning is on my to-do list, along with a number of other UI improvements (e.g. non-stupid cursors).  I haven't settled on a good solution for node placement yet, as there are a lot of caveats for where the node could/should appear.  Persistent right-hand side placement wouldn't be so bad if you could scroll past the edge of the canvas, so I may try to get that working first.

Do you know of any software that does a good job with this?  I'd love to see someone else's successful take on it.


Bu arada iconumuz güzelmiş :)


this should also contain the 'no-password' fragment.  it's a good cya for logging in on the console if things go bad.


Accepted and fixed.


Done.


another test


Sorry that I also write here, because maybe you both don't really like me, but could it be possible, that there is maybe something else missing? Maybe in freq_table.c or mach-msm/cpufreq.c?
I'm just asking, trying to help.
Have a good evening. Greetings


Ok ben passe moi les coordonnées je vais me débrouiller


#Was Here!


Можно использовать конструкцию `for ... else ...`:
```python
for ref_line in islice(reference, position, None):
    if mut_line[:5] == ref_line[:5]:
        position += 1
        break
else:
    new_lines.append(mut_line)
```


Mozna by slo nechat ve verzi 2.0 pecl http a php 5.3 a udelat verzi 3.0 s guzzle.


Fixed.


Extending the search I only find 3 uses.

Two of them input byte array is a single byte array for sure, so basically is asking to repeat a byte N times (covered by dupBytes.

The other is a fix sequence of four bytes 'A' 'C' 'G' 'T'
and four base quals  use to create fake artificial reads of arbitrary length depending on an input Cigar.

Just considering these use I would suppress this method for the first one entirely and move it to the invoking class in the last case.

Reasons:

1. one cannot understand what it does given its name at all.
2. Is not really a general useful utility... is custom made for a very particular situation, at least it is so for now.

That is based on what I can see. If your additional search results makes it look for useful and reusable lets keep it but
then.

a. change the name to something more descriptive.
b. add explanatory java-doc.
c. avoid NPE using Utils.nonNull, and check that the input length makes sense (0 or greater 0) throwing a IAE if not so.


Just a note that your save button doesn't do anything, and that I'm working on a more dynamic code which scans for the lines instead of using statically placed line numbers. :)


Fixed.

About the hotfix, we could release it as soon as we are done with the website changes.


Nice T-shirt, I too like it.


@calvinchengx Sorry, I'm only seeing your comments now. You simply need to add the following to your `configuration.nix`  :)

```
boot.initrd.availableKernelModules = [ "virtio_scsi" ];
```

The module can be `virtio_scsi` or `virtio-scsi`. Both work fine.

Once this pull request is available in your channel you will need to use `import = [ <nixpkgs/nixos/modules/profiles/qemu-guest.nix> ];`. That will set-up other modules for you as well as this one.


А зачем, кстати, разбивать строку на несколько? Это можно записать следующим образом:
```python
print('Usage:\n'
      'compare_vcf.py <reference_filename> <mutant_filename> <output_filename>')
```

Выглядит, вроде, чище. Здесь я пользуюсь тем, что в Python можно записывать строки подряд, без знака `+`. Если такая запись разбивается на несколько строк, главное, чтобы были скобки вокруг. Здесь эти скобки относятся к функции `print`


Sure.  The problem comes from the `checkSeq()` handling of a Ticket, which can produce a `tec` error.  But if any non-`tec` error is ever produced during other processing, that non-`tec` error needs to take precedence.  This structure allows various checks to produce `tec` errors without preventing other later checks from occurring.  Any `tec` errors are only returned if the transaction is found to be correctly signed.

There are other approaches I could have taken.  We could change the Ticket-related `tec` error to a non-`tec` error.  I could postpone the Ticket `tec` check.  I could know that only `checkSeq()` can produce a `tec` error, and only include the special handling there.  The approach that I coded up seems uniform and relatively low cost.


aqui era só colocar o ternário pra verificar uma string


Non breakable space, right? You might want to put a comment for that.


Небольшое улучшение ещё в том, чтобы записать сначала условие, по которому программа закончит исполнение, а остальной код можно писать без дополнительного отступа:
```python
if len(sys.argv) < 3:
    ...
    sys.exit(2)

... = sys.argv[1:3]
...
```


I can try it. I can even try it in this PR. @vinniefalco, would that conflict with anything you're doing?


Skills!


I don't suggest it, meddling with `getHash` will lead to pain. But feel free to try it locally, if anything as a learning exercise.


by my reading of the specter docs, this will narrow down the scope of the transformation as follows:

1. the report map (post initial `dash->underscore-keys`)
2. the `:resource_events` map
3. all key-value pairs in the `:resource_events` map
4. all individual keys and values in the `:resource_events` map

Meaning that this will run `dashes_underscores` on both the keys and values. Is this what you want?


develop (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2195 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.19%25-yellow.svg)


@Raesu Need `UIPinchGestureRecognizer` here.


Don't we run multiple cocoadoc builds at the same time?


So your preference is to change the three checks into an `assert`?  I can go with that.


Is this method really exposing `self.user_<username>` as the docstring suggests?


thanks :)


Yeah this is going to break things, since we can be mid-way though building another pod in a separate process: https://github.com/CocoaPods/cocoadocs.org/blob/master/server.rb#L90


very, very rarely, though it might just be better to kill the lib


Can we refactor most of the body of the `while` (1230-1281) to its own function? `child_process` is already almost 200 lines long and I don't want us to bloat it more.

Also, consider making 1239 `if (parent_message != SRV_QUEUE_HEARTBEAT)` and then move 1241 down to 1268.


For usage on highly-tuned microcontroller cores, we're hoping that this fibre switching will only cost a few cycles, and that this mechanism will be usable/benefitial precisely because of that. So I'm making sure that the fast-path doesn't have any unnecessary branching or unnecessary error-checking. In any case, the only reason this should fail should be if the parameters (or the state of those parameters) are wrong, and the fast-path code shouldn't be checking for programming bugs. Anyway, if we put error handling in then it affects the API, which means that all the "app"-side code is either more complicated or it's ignoring return codes. Yet there should be no legitimate/bug-free reason that a fibre switch can't occur.


I second that this is a breaking change; or if you prefer diplomacy, a grossly inflexible, opinionated choice. If the developer wants `ng-click` *not* to focus a clicked focusable element (whether that element is the one with `ng-click` or *any ancestor of it*, which is not uncommon at all and includes *most* dialog directives) we're well-prepared if not even accustomed to doing just that with `$event.target` or various other means. But, that should be up to the developer, not `ngTouch`; and it certainly shouldn't be something that silently breaks all inputs in dialogs (for instance) **a** only on mobile devices, and **b** only when with `ngTouch` is on the module. That's how you hurt adoption.


Думаю, что лучше использовать сравнение `filename is sys.stdout`, оно чуть больше передаёт семантику происходящего. Поведение при этом останется тем же.


It's not "very very rare". If two people submit a pod at the same time this is very likely.


@Raesu add NSLog(...); here to prove this is being fired via the pinch. Then call a method just as you did in `panFired:`. Pass the `recognizer.scale` value to the new method. In the new method use `scale` to `transform` the toolbar.


Повторяющийся кусок. В идеале стоит вынести в функцию (лучше внутреннюю, т.е. начинающуюся с `_`).


It works perfectly.

Thanks


This page says that for C90(C++98), that realloc may return NULL if the pointer size was 0 and that the buffer would have been de-allocated. For C99/C11(C++11) it indicates NULL only means failure.

http://www.cplusplus.com/reference/cstdlib/realloc/


What's `%link`?


Self-contained web page to exercise the Perseus Hopper API via XHR.
Follows the example of https://github.com/Geremia/LatinInflector among others on the web.
Still looking for better documentation of Perseus Hopper :(


It's more that with something like Amazon posting 12 at once when it's an issue, but we're rocking out at [one pod](https://status.cocoapods.org) per 5m ATM


Hmm, not sure we actually need to change the default method name to `test`. This probably has implications with the virt plugin, since it implements `runTest`.


What's our stance on debug/assert vs */exception ? Generally? Specifically?


Please note that this quick fix and used for my owen purpose and so only present in lightbox.js. Eventually I would add this as option.


Can you squash the commits and make the comments consistent.

Can you also create a test which causes the failure case and validates that we get the expected behaviour


much simpler code => less potential for errors => (side: less barrier for newbie)

I've found only two-three places in all `tools` where Promises usage gives benefits.
All other places 80% (IMHO) all are unnecessary complications.
At the same time code complication imposed by Promises usage is much more than benefits.
It's all of course IMHO
(you can view at it as `newbie point of view`)

As for exactly this particular case: factories generations:
there is no difference in speed at the end, but code is easier to understand. Again - IMHO.

That's my motives.

--
For example just compare:
```js
const bowerSrcRoot = path.join(repoRoot, 'tools', 'amd');

function buildBower() {
  console.log('Building: '.cyan + 'bower module'.green);

  const libDestination = path.join(bowerRoot, 'lib');

  rm('-rf', bowerRoot);
  mkdir('-p', libDestination);

  cp(path.join(bowerSrcRoot, 'README.md'), bowerRoot);
  cp(path.join(repoRoot, 'LICENSE'), bowerRoot);

  // bowerConfig
  const bowerTemplate = fs.readFileSync(path.join(bowerSrcRoot, 'bower.json'));
  const pkg = JSON.parse(fs.readFileSync(path.join(repoRoot, 'package.json')));
  const config = _.template(bowerTemplate)({ pkg });
  fs.writeFileSync(path.join(bowerRoot, 'bower.json'), config);

  const babelOptions = {
    __reactBootstrapDeprecationWarning: true,
    modules: 'amd'
  };

  return Promise.all([
    generateFactories(libDestination, babelOptions),
    buildFolder(srcRoot, libDestination, babelOptions)
  ])
  .then(() => console.log('Built: '.cyan + 'bower module'.green));
}
```
and
```js
[current implementation with heavy usage of Promises](https://github.com/react-bootstrap/react-bootstrap/blob/3a254a14f2d8a083ee76559533b8be02f2258921/tools/amd/build.js)


Good idea!


@afs  Did you have any problems with `jena-querybuilder` after this? It's looking for the full type URI in some tests...


flatten should preferably be standalone - there's little lost in

```javascript
for ( const item of this ) {
    yield * item;
}
```

vs reusing `flattenDeep`, and `flatten` will be faster.


no fixes the fc on AudioFX nothing more :(


`isTryNextHost` sounds better.


This commit lgtm +1


Yeah, I really like making the behavior configurable. Well done.


Fix #3797


Then create a new issue, and we can collect what might be needed in such a documentation for developers.


lgtm.


Will this need to be changed when new hardware is enabled?


About this commit:

1) Create new variable  ```DateShimParse```

2) Increase readability for ```DateShimParse``` (```Date.parse```)
```js
var DateShimParse = function parse(string) {

    var match, year, month, day, hour, minute, second, millisecond
       ,isLocalTime, signOffset, hourOffset, minuteOffset, result;

    if (match = isoDateExpression.exec(string)) {

        // parse months, days, hours, minutes, seconds, and milliseconds
        // provide default values if necessary
        // parse the UTC offset component
        year   = Number(match[1]);
        month  = Number(match[2] || 1) - 1;
        day    = Number(match[3] || 1) - 1;
        hour   = Number(match[4] || 0);
        minute = Number(match[5] || 0);
        second = Number(match[6] || 0);
        millisecond = Math.floor(
            Number(match[7] || 0) * 1e3
        );

        // When time zone is missed, local offset should be used
        // (ES 5.1 bug)
        // see https://bugs.ecmascript.org/show_bug.cgi?id=112
        isLocalTime = Boolean(match[4] && !match[8]);
        signOffset = match[9] === '-' ? 1 : -1;
        hourOffset = Number(match[10] || 0);
        minuteOffset = Number(match[11] || 0);

        if (
            hour < (minute > 0 || second > 0 || millisecond > 0 ? 24 : 25)
            && minute < 60
            && second < 60
            && millisecond < 1e3
            && month > -1
            && month < 12
            // detect invalid offsets
            && hourOffset < 24
            && minuteOffset < 60
            && day > -1
            && day < (dayFromMonth(year, month + 1) - dayFromMonth(year, month))
        )
        {
            // Get Days
            result = dayFromMonth(year, month) + day;

            result = /* Days     -> Hours        */ result * 24  + hour   + hourOffset   * signOffset;
            result = /* Hours    -> Minutes      */ result * 60  + minute + minuteOffset * signOffset;
            result = /* Minutes  -> Seconds      */ result * 60  + second;
            result = /* Seconds  -> Milliseconds */ result * 1e3 + millisecond;

            if (isLocalTime) result = toUTC(result);
            if (Math.abs(result) <= 864e13) return result;
        }
        return NaN;
    }
    return NativeDate.parse.apply(this, arguments);
}
```

3) Original ```Date.parse``` should be non-enumerable. To achieve this, ```defineProperties``` may be used:
```js
defineProperties(DateShim, { parse: DateShimParse }, true);
```


There seems to be a semantic inconsistency between the field name (`retryCurrent`) and this method's name.


> are you sure. i see 7 invocations. and the method doest just do dupBytes

Extending the search I only find 4 uses.

In two of them the input byte array is a single byte array for sure, so basically is asking to repeat a byte N times (already covered by dupBytes).

In the other 2 the inputs are 4 byte arrays fixed array  'A' 'C' 'G' 'T'  and some arbitrary qual values to generate
artificial reads given a cigar length. I guess all for testing.

Just considering these uses I would suppress the first two entirely (use dupBytes in any case), and for the other two I would move this method to that class and make it private.

Reasons:

1. one cannot understand what it does given its name at all.
2. Is not really a general useful utility... is custom made for a very particular situation, at least it is so for now.

That is based on what I can see. If your additional search results makes it look for useful and reusable lets keep it but
then.

a. change the name to something more descriptive.
b. add explanatory java-doc.
c. avoid NPE using Utils.nonNull, and check that the input length makes sense (0 or greater) throwing a IAE if not so.


Did you mean to commit the `exit` ?


I was thinking, it's unlikely that the user is going to shoot (him/her)self in the foot, but just in case, I feel like some validation has to be thrown in there. I mean, what if the user resolves to set `generic_exception_result` to `SPAM_AND_BACON`?


no need to keep track of the current ~~deepness~~ depth, you can just `yield * item::flattenDeep(depth - 1);` (`item` is a nicer identifier name than `x` and also consistent with the rest of the codebase)


Maybe reuse the same load balancing policy in SpeculativeExecutionsTest?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16438/testReport/) for this commit**


have you fixed signals problem?


I'd validate, and if the value passed is invalid, tell in the log that the value chosen was wrong, and that instead we're sticking with `ERROR`.


Hi,

I really need to know how to implement where queries? Is there already a
built in method??

Query modifications (optional)

To change query parameters you can create "ArrestDB_modify_query" function.
"$query" parameter is an array with this sections:

   - $query["SELECT"] : Select parameters, by default "*"
   - $query["TABLE"] : Query table, by default $table
   - $query["WHERE"] : Is an other array with all AND conditions.

Other sections are "ORDER BY", "LIMIT", "OFFSET".

Must return the "$query" array

//In this case only allows objects with "deleted=0"function
ArrestDB_modify_query($method,$table,$id,$query){
$query["WHERE"][]="deleted=0";    return $query;}

Note: If you are using "extends", this works for each level.

On Tue, Jun 16, 2015 at 9:25 AM, ilausuch <notifications@github.com> wrote:

> It still working for me. What is your request?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ilausuch/ArrestDB/commit/2fd016607043358b49ec0a6436799991ce644cba#commitcomment-11701361>
> .
>


If the patch is from Mircea there's no need to add another sign-off.


-1, Please don't include this patch


See comment in the patch that uses this value about validation. Probably we should stick to `FAIL` or `ERROR` as valid values.


Pisz po Naszemu czyli po Śląsku ;D


It's a placeholder. It's not a real class that I apply to any element. It's just a way for me to extend that anchor style. Check out "Extending placeholders" in https://css-tricks.com/the-extend-concept/


This approach will require you to start the `flattenDeep` function with

```javascript
if ( depth === 0 ) {
    yield this;
    return;
}
```


lgtm +1


How about we deleting this in Ruby instead of shelling out to delete a directory. Then move the directory to a variable instead of duplicating it twice on one line.

```ruby
cache_directory = (Pathname.new('~/Library/Caches/org.carthage.CarthageKit/dependencies') + @spec.name).expand_path
cache_directory.rmtree if cache_directory.exist?
```


`integer` is not a valid type in flow AFAIK :/


You can also just "setenforce off" (or something like that) here, I believe


Right. `$.isEmptyObject()` should work then?
http://api.jquery.com/jQuery.isEmptyObject/


fixes #1


in which directory?


ok. it has been fixed now.


IMO testing for more types of iterables is redundant - we should be treating them all the same, to us they're just iterables


Dude, we can still see it :)

You need to purge this file and re commit.


Fixes bug introduced by last commit


It appears the `MetaView` copy constructor does not copy the `View` base class, but instead default constructs it.


Remove double i18n call.


lgtm +1, I am relying on the tables to be cross checked against reference.


Call a function for each element in the intersection of two ***sorted*** sets.


Came to GitHub to look if someone had fixed this :+1:  Thanks


sure 3d09d69


@sophokles73

Thanks for getting back to me and sorry for my delayed response. Our use case is somewhat unique; I'll outline a high level here.

We have many devices on a mobile network that make very infrequent requests. They are battery powered and required to last a very long time, so power is our most precious resource. The largest consumer of power is the radio, and the less time it's active, and the less data that goes over the wire, the better. We're working towards avoiding full handshakes wherever possible, avoiding round trips and shaving bytes off of requests. The tradeoff is that having requests complete quickly is less important.

Because devices are on a mobile network and the radio isn't always connected we're assuming that worst case the device will be assigned a new IP every time it makes a request. This means a fresh handshake for each request. It also complicates the reverse proxy solution you describe.

In order to achieve an abbreviated handshake when the IP changes my plan is for each request, transmit a token unique to a device and use this to find the previous DTLSSession for that device in our custom SessionStore, and then update the store so SessionStore.get(InetSocketAddress address) resolves for the device's new address.

So while it seems costly to retrieve the session state from the database on every message, in our use case we would have to pay the price of a full handshake so the tradeoff seems worth it. Also since we're operating on a (3G or slower) cell network, a full handshake will probably have more latency than the cost of looking up session states on the server.

I think the current implementation prioritizes speed, but one of CoAP's great benefits is that it can be very low overhead. The update() method is indeed just a hook to make things slower, but for us we hope that is will ultimately help reduce power consumption on the client.

cc @kpalacz


Done


Yes, reverted all the patches for 10.06.2015.
https://github.com/nitrogen-project/android_frameworks_opt_telephony/commits/cm-12.1


Thank you for the idea and coding the first version.


@jennschiffer :shipit:


Frankly I am still considering that using String and TextUtils.isEmpty instead of a StringBuilder and judging its length would be a little bit better in this case since you are actually not modifying anything(you are using "delete and append" to do the replacement of new String which may be more expensive then just pass the String reference to a local member). And also, TextUtils.isEmpty can help you avoid some case like null pointer(append a null pointer to a StringBuilder will really make it shows "null"). Just a minor concern here.


The two repos in question are https://github.com/StyleCI/Config and https://github.com/StyleCI/Fixer. :)


Math.round test


Added your name: http://pcingola.github.io/BigDataScript/about.html


Template for task to calculate power of 2 for a large number


I pushed to an "x" branch, so it's not going anywhere, but it wasn't too bad. https://github.com/ximinez/rippled/commits/x-follows-ledger-const


why is it better doing it like this ?


Awesome, thanks so much! Making changes now. For the logical operators (`|` and `||`) there does seem to be a difference in how they evaluate (one evaluates element-wise, the other left-to-right), but I'm not sure how that difference in evaluation plays out in an if statement. The documentation suggests using `||` in `if` statements: ["The longer form is appropriate for programming control-flow and typically preferred in if clauses."](http://stat.ethz.ch/R-manual/R-patched/library/base/html/Logic.html) So I use their suggestion even if it works with `|`.

For the 3rd point, I definitely messed up (thanks for catching that). An explicit check for `NULL` is still necessary, it's just out of order. I think I had a comment about checking for `NULL` in if statements on your code somewhere. I've since refactored the function to this (`NULL` check should come first), and now it's a reusable function (I'll move it out to a different file):

```R
validate_true_false <- function(arg_list) {
  for (i in c(1:length(arg_list))) {
    a <- arg_list[[i]]
    if (is.null(a) || !(a %in% c(TRUE, FALSE))) {  # Changes
      err <- paste0("The argument '", names(arg_list)[[i]],
                "' must be TRUE or FALSE", collapse="")
      stop(err, call.=FALSE)
    }
  }
}

## And I changed c()
validate_true_false(c(condense=condense, scale=scale, browser=browser,
                        verbose=verbose, fast=fast))
## To list() so NULL variables get passed along in the list - they get
## removed from the vector when using c()
validate_true_false(list(condense=condense, scale=scale, browser=browser,
                        verbose=verbose, fast=fast))
```

If you don't check for `NULL` first you get this error:

```R
> radial_phylo(tcr, 'seqs', condense=NULL)
Error in if (!(a %in% c(TRUE, FALSE))) { : argument is of length zero
```

With the revised function:

```R
> radial_phylo(tcr, 'seqs', condense=NULL)
Error: The argument 'condense' must be TRUE or FALSE
```

I'm avoiding any traceback errors like the one above showing up if the user sets a variable to `NULL` and I later use that variable in an `if` statement. Since `NULL` has length zero, any `if` statement that uses a variable set to `NULL` will error.

I have a check to make sure the value the user gives for `verbose` is `TRUE\FALSE` in line 848, but I like to be explicit with `if(verbose == TRUE)` because of that issue with `if(verbose)` evaluating to `TRUE` if it's a numeric :smile:. I know if I start writing `if(verbose)` I'll forget that part about numerics lol.


@kristoferjoseph is the switch from negative to positive for `--half-gutter-width` intentional here? It breaks gutters.


From my perspective, three reasons:
 1. When I'm providing the details of an implementation, I wish to indicate to others that they are details and not part of the interface.  Putting the implementation inside of an anonymous namespace (or a detail namespace) is an idiomatic way to show intent to other programmers.  These idioms also have the advantage that the compiler gives them some teeth.

 2. When I'm providing functions for implementation details I'd like to be able to give them reasonable names without worrying about collisions.  The easiest way to do that in a unity build is to use a specialized detail namespace.  However you don't like those.  A less good approach, but one that adds less noise, is the anonymous namespace (which is my preference in non-unity build environments).  The anonymous namespace still provides value in a unity build, since the unity build still produces a number of translation units.

 3. It's true that most name collisions will cause a link error, but that is not universally true.  Since we're using namespaces, occasionally ADL will kick in and produce unexpected linking results.  Those issues withstanding, a link error due to a name collision is not a pretty thing.  It's nice to be able to localize names so that they are only visible where they are needed.


Usually you fork this repo, make the changes, commit, push to your repo and then create a pull request. This one you created here does not containt a fixture definition.


:) nothing?


For each workflow that has jobs to be scheduled in future, it adds a timer here with its start time.  Everytime, the new start time is set for a workflow (for example, a recurring job queue), the timer's start time should be updated even if the timer was created before.


This change seems to have caused a problem with jsx-typescript.  I'm not sure if the problem is here or with jsx-typescript.  I'm happy to dig into this issue if @jbrantly can tell me why this was removed.


Refactored into its own function, declined to move the communication code because it created a long-range dependency between the `if` and the `switch`.


Ah yeah, I've been building with "TARGET=debug-gcc" set. I have a small fix that I'll mail you in a moment. It's gcc-specific too (as you point out elsewhere), but that's a kind of intentional short-term thing. (I will get to that in due course...)


Good idea.


Uh-oh. Is still still broken?


Good news, the VirtTest class has its own init with its default `methodName`. So no changes are required there.


Nice line Sanjeevc.uid.


This is not the right solution. You should either use a loop or another method in NSArray that gives you all objects in the array.


yup I have no idea why, maybe the change was already in another commit :confused:


Why not just mark the functions `static`?


Is there any chance to backport this to 4.0? I can try to provide PR if it is welcomed.


yes. it can return a compaction set of 0 or more shards.


Hopefully nobody was using that. Having the order of arguments be different depending on which kind the controller actually is was very weird. I didn't change the order for `api.add_module()`


I know, I didn't add code for it yet :)


@artbear Ты конечно крут на расправу, только этот код не всегда будет работать при случайном выполнении тестов.


Yep. As mentioned in my email a few moments ago, I'm looking to only add abstractions for porting on an as-needed basis. And even on platforms with pthreads and thread-local storage, it will eventually be desirable to support a build where threading and thread-local storage is not used, in which case the "__thread" needs to be compiled out completely. (Ie. global variable, rather than thread-local storage.)


Use lowercase variables.


> Changing one directory up is necessary for the `mtheme/` prefix inside the archive. zip does not support prefixing as far as I can tell.

I think you are right with this. But don't you think it would be better to create a temporary directory called `mtheme`, copy the files there, zip it and delete it when the archive is created. You cannot be absolutely sure, that the repository is saved in a folder called `mtheme`.

Another thought: I would propose we save the CTAN archives in a separate folder (`ctan` or `downloads`) and keep all the archives we distributed as a reference there.


Is this meant to be here?


Yup, I mailed you a janitorial patch for these.


Okay then.  :)


What? :D


@cmelion okay, added issue, will adjust.


Nice.  But is there an example in the sample article?


This is test


увидел возврат


Never mind, I think at least the attribution stuff was added in a later commit.


This is intended. Or do you wish to hide the "Availability" bar when not available?


How about abstract these dtype arrays to constants in spec_helper?

I remember putting an `ALL_DTYPES` const there sometime back.


THANKS!!! :-) I've pushed a fix for this.


> avoid division by zero?

Yes, is it ok?


I know that Chrome does, but I'm not sure if it is desired behavior. Will check and follow up


You should change back to this but "examples" is a directory above the "nupic" package so should be:

```
opfDir = resource_filename("nupic", "../examples/opf")
```

And you can remove the nupicDir variable that isn't needed.


LGTM


I think this is addressed by #70 .


For what reason ever - MSVC14 does not provide test macros :(
I've added a workaround.


@thibaultCha this check properly parses multipart values. Removing it will break multipart.


I tried this ...
`        rm /var/lib/opkg/lock
        opkg install $i
        touch /var/lib/opkg/lock`
... before too.

It causes inconsistencies within the opkg database :(


I can go with the `valid` and `assert` sequence.

FWIW, here was my thinking regarding returning a `0` index.  Whoever gets the index back does no special processing.  They simply look in the ledger for that index.  A `0` index will not find anything, or at least certainly not a Ticket.  So returning a `0` required no extra processing by the caller.  That thinking may be flawed, however, since it may be expensive to look up a non-existent ledger entry.  In which case the `valid` `assert` sequence saves processing time.


Lol, if you added this, you added it in the wrong file, base_controller wasn't used anymore at the time you added this.


@luuuis It says on the [blog](https://blogs.dropbox.com/tech/2012/04/zxcvbn-realistic-password-strength-estimation/) that ie7+/opera/ff/safari/chrome are supported, but [IE7 and IE8 don't support Array.prototype.map](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map#Browser_compatibility)

The [demo](https://dl.dropboxusercontent.com/u/209/zxcvbn/test/index.html) is working in IE8 but it seems to be using an earlier version of the library.


1608-IGCrash (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Может лучше полностью вынести вызов исключения из метода `ВыполнитьТестовыйМетод` и вставить перед попыткой?


The issue is when you delete a workflow and recreate it again with future start time, it will not be scheduled.

The root cause is when we delete a workflow, we did not remove the timer created for that workflow before.  Next time, when you recreate the workflow again (with the same name), then the old timer for the workflow is still there, but with old starttime.

I have updated the changes as you commented.  Mostly, not only to check if there is a timer set for a workflow, but also update its start time.  Also, add code to try to remove the timer when the workflow is deleted.


I'm not sure that it makes sense to overload `userId` like this. Would it make sense instead to add a `userId` field to the  `ApiTokenOwner.grain` group? Then `ApiTokens.userId` would always just mean "user whose permissions to use for a UiView", and `ApiTokenOwner.grain.userId` would mean "user whose permissions to check upon restoring".


The main point of this that REQUIRE should match the oldest (release, if possible) version of Julia that the package developer is regularly testing against. There's a to-do to adjust Travis so we can continue testing packages against 0.3 even after 0.4.0 gets released, so it will be easier to support older versions in the future. I don't know if there's any easy way of installing Julia versions prior to roughly 0.3.1 on Travis any more.


I added this before the refactoring for version 0.2.1. Then you refactored `normalize_nested_params` and you  removed it. So I added it again. Then you refactored again the API by removing `base_controller` and now it's missing again.


I added a test case to make sure this doesn't break again in the future.


Fixed. I'll push later.


Turn this into a Doxygen style comment with description of parameters and return values. There is an example of the formatting in the eng. playbook.


Works for me.


Fixed.


base_controller wasn't needed as soon as the rest API was out, I only worked on app.lua so I never noticed any change, as simple as that


> Can't you freeze your package version on the previous Julia version and only have subsequent package versions not support previous Julia versions? I don't think we have a mechanism for this.

Pkg works like this already. If version 0.0.5 of a package supports Julia 0.3, but version 0.1.0 does not, then as long as version 0.1.0 of the package correctly lists `julia 0.4` (or `julia 0.4-` until 0.4.0 gets released), then users of Julia 0.3 will remain on version 0.0.5 of the package indefinitely - unless the package developer goes back and makes new 0.3-supporting releases, via a separate branch or something.


Erk, yes, could you just chop that line!


It depends whether any tags were published prior to bumping the minimum version in REQUIRE. If you have a package installed somehow (via clone perhaps) that does not have any tagged versions that support the version of Julia you're using, you get a big warning every time you try to `Pkg.update()`.


why does it need to be first ?


why?


This is the second refactor and that method wasn't there: https://github.com/Mashape/kong/pull/288/files I doubt it ever worked as base_controller was unused at the time you added it. And I only removed it once, because never noticed it, because base_controller was useless.


Did you run `Pkg.resolve()` or `Pkg.update()` or `Pkg.build` at any point after modifying REQUIRE? I'm not entirely sure on the mechanics of when the local version of a package's REQUIRE is used, versus the requirements listed for tagged versions in METADATA. It's all rather confusing, but I'm not sure how to make it any less so.


P.S.: Nur zur Info. Ich finde es ghört au nid da ane, aber de Joho isch geil uf vertikali und horizontali Sicht.


Is this ready? It looks done. :)


getPawnPseudoLegalMoves calls appendPawnPseudoLegalMoves so it's not faster ...


Now it never runs. Let's see. Imagine ```otherNumber``` is -4 and number is ```0```. ```i``` is always smaller than ```number``` so it never enters the loop.


:) Yeah. I wasn't joking. I guess it is something I got wrong, since I have always used servers located all over the place. But, something seemed to be wrong.


Here is my `hardware-configuration.nix` if you still need it:

```
# Do not modify this file!  It was generated by ‘nixos-generate-config’
# and may be overwritten by future invocations.  Please make changes
# to /etc/nixos/configuration.nix instead.
{ config, lib, pkgs, ... }:

{
  imports =
    [ <nixpkgs/nixos/modules/installer/scan/not-detected.nix>
    ];

  boot.initrd.availableKernelModules = [ "ata_piix" "virtio_pci" ];
  boot.kernelModules = [ ];
  boot.extraModulePackages = [ ];

  nix.maxJobs = 2;
}
```

It was generated by `nixos-install` like that.


Should not be float: left;

If you use z-index must be with position: <option>;
For example, could be:
position: fixed;
top: 0px;
left: 0px;
z-index: 10;


Not important at all, but I think this could be refactored in order to avoid repeating yourself.


@alxn it can be either case. we strip the `@` at the front, if it exists


@JMaverick16

I am not completely certain but it seems to me you are importing objects from other sources and modifying them.

Is this terrasync's KLSV?

Is the material GPL?

If yes, i think the sanest thing to do is add a note about this source of materials in the README.md

We should not copyright to ourselves the material that we did not make, and we may be cleaner by just acknowledging the extra-sources used in this

Let me know

@IAHM-COL


I could mark the functions `static`, but `struct TicketContents` can't be localized with a `static`.  `ripple::TicketContents` is too good a name to throw away as an implementation detail.  Using anonymous or detail namespaces works for both free functions and for structs/classes, so I don't have to think hard about the "best way to hide the name".  I can just go with an anonymous or detail namespace.  The other choice would be to mark the functions static and give `struct TicketContents` a longer name.  But, to me, that feels like I'm going to extra effort to avoid writing code in an idiomatic way.


I think this is just hiding the issue. What causes onAttach to be called in the first place is where it should be fixed I think.

Also it may catch something you don't want to catch. At least rethrow if the activity is not destroyed (`!isFinishing()` to be compatible; or maybe `getSupportFragmentManager().isDestroyed()`, but I'm not sure that's true already at the time).


This `post` variable refers to an error message - perhaps a better name for it could be something like `message` or `error`.

(Yes, I'm being nitpicky since the code in general looks really good!)


am fixing jenkins


What is it? It should be fine if `userdata` is null.


Two typos in this line, don't seem to be resolved in later commits


If parabox and linkbox both have the same index, could they conflict with each other.
Best to design them to be at different levels.


Debug purpose, this is note for self to remove.


This really seems like a compiler bug.  I checked and it isn't clang.  Can we file a bug report against whatever compiler is demanding this useless check?


:tada:


hanf_form.php needs to exist in the ./skeleton directory in order for us to handle the form.
Follow the form handling logic we made in the simpleform project folder, and print out the submitted form data :-)


wat


r+


For a small app like this, it's probably clearer to have split your POST and GET actions, but keep in mind that conventionally (and this would be more important for apps with many more routes) you would want to group your actions in a RESTful way (as in, group your resources together - all your User actions, all your Post actions, etc.)


Did you see my earlier comment about this block?

I think it would be safer to switch this if block to:
```
if (React.isValidElement(this.props.avatar)) {
  // clone
} else {
  // generate
}
```


↑ c/p


could you add an explanation to all commit messages that this is a temporary module and you intend to replace the old one with this?


обява_маркетинг.md

че разбира, че няма значение дали си инвестирал в нещо 8 часа, а дали има резултат от работата ти. Например можеш да загубиш 8 часа да продаваш init Lab в bgmamma или можеш за половин да таргетираш всички от open fest или SoftUni.


Looks like you misspelled!


saw approval from MonsieurNicolas
at https://github.com/jedmccaleb/stellar-core/commit/cee49475f8d110aea178230f09fc21fc44ddf90b


merging jedmccaleb/stellar-core/master = cee49475 into auto


jedmccaleb/stellar-core/master = cee49475 merged ok, testing candidate = c1dab23d


Also, remember to merge the original styles from the avatar element is one is passed in. You can see this for reference:
https://github.com/callemall/material-ui/blob/ace17cd023c3a140c76d8f84413f7984fb12febf/src/lists/list-item.jsx#L199


__func__ << " " << ...

(put a space in between so ou can read it)


Does it make sense to scrape /proc/vmstat to get pageouts? I've found that to be one of the most useful metrics for performance


can be removed.


why is kodekpl back?


ok. I will do so when refactoring/fixing after all commits are review


Does that work without referencing the package?


Fixed at 21:52


Códigos


scrutinizer wwon't like this for sure, it's just unavailable because they seem to have technical issues.


Comments...


It was kal, it allways makes him kodekPL when he merges.

> On Jun 17, 2015, at 1:50 PM, parkerkid <notifications@github.com> wrote:
>
> why is kodekpl back?
>
> —
> Reply to this email directly or view it on GitHub.
>


Name of first rep.


`dstfyu


I think if you don't put in an email in eclipse, it says you are kodekpl.


Using `auto` here will save you grief with P/R 1130.


hello


jsx-typescript is basically TypeScript 1.4. It has not been updated to 1.5, and probably will never be since TypeScript is getting native JSX support. I should probably remove/update the mention of jsx-typescript in the README. In any case, the latest bits here are for TS 1.5 and won't work with TS 1.4. If you need to use jsx-typescript, you should downgrade to ts-loader v0.3x


name


Closes #2


ok then

On Wednesday, June 17, 2015, Peter Zerangue <notifications@github.com>
wrote:
> I think if you don't put in an email in eclipse, it says you are kodekpl.
>
> —
> Reply to this email directly or view it on GitHub.<
https://ci4.googleusercontent.com/proxy/UQJp3UwnB9vv3GBjP9t2GkALFTq7HqiMLOMeZOWpkStjl315qoAgwUplFbcShjTMZ3-JPB_o9IZkmxuMbhxTTwumyLwQHGD9bv-IKE1rJWAs6kIAHHjjaEBdwJaO83glM5VDMEOBG9lhDE3gusiwoi-64AtyNQ=s0-d-e1-ft#https://github.com/notifications/beacon/AMEAenOvpEYxoHnwkm2plvjTvi-H-Okgks5oUbmWgaJpZM4FFnhj.gif
>


Sure. What exactly needs to be written from the mapreduce into the partition meta?
Should this be available to the user, in the MapReduceContext?


Looks great. I have a few comments but that can wait. And I want to study the code some more anyway.


I guess not, I'll fix it. I haven't compile them yet. That's my next step.


osc refs should be updated to oc


Merge with upstream


Fixed


you do not Need the bracket.
This is easier to reed ;)
`($treeType == 'file' || $treeType == 'page')`


Good catch!


a


Okay if so..Since the part of commit isn't altered i had marked a note


No, apparently you just have to remind me. :)


On second thought, it seems that the additional metadata should be specified as runtime arguments for the dataset. Similar to how the output partition key is set using FileSetArguments.setOutputPartitionKey()


Haha, what an obscure bug. I never would have guessed cardinal direction would interfere with CI. :D

> On 17 Jun 2015, at 19:38, Aravind SV <notifications@github.com> wrote:
>
> :) Yeah. I wasn't joking. I guess it is something I got wrong, since I have always used servers located all over the place. But, something seemed to be wrong.
>
> —
> Reply to this email directly or view it on GitHub.
>


:ship: :point_right: :hankey:


What is this supposed to be for?


would love a PR for this and the other change :smile_cat:


Thanks for asking, Karim.

It seems like the sync engine is sometimes skipping over UIDs (when in `polling` state). I worked this issue around with https://github.com/elasticsales/inbox/commit/8c97b2639e37342a9ae32cc3d62ab0730aaf1098, however we still have the case where the last few messages are missing and are only synced when anoter new messages comes in. I wonder if this is related to this (from inbox/mailsync/backends/imap/generic.py):

```(In Gmail, there is a small delay between changes happening on
the web client and those changes registering on a connected IMAP session,
though bizarrely the HIGHESTMODSEQ is updated immediately.)```

Is it possible that accounts report a HIGHESTMODSEQ but the changes aren't visible yet?

In any case, this needs either some more investigation for a proper fix, or periodically look at all UIDs even if there are no changes to the HIGHESTMODSEQ.

I posted a snippet in your Slack room which you can use to check if any accounts are affected by this problem.


With all do respect man, but you may face some troubles acting like this. Keeping original authorship in commits is the right way. This is one of the examples but you have some others as well


Version bump?


Nice test. Without the `delivermin` that should go through, and with it, it should fail. Maybe one more trivial change. Check that bob's balance is the same immediately before and after the transaction. We want to make sure that when a payment fails because of delivermin balances don't change. After that I'll test on the various platforms and give a thumbs up.


@nckx: The patch file itself is missing.


isnt ifdef around missing?


nice commit!


Good to go.  This is much more appropriate and flexible.  We've moved all of the Liferay configuration into downstream processes.  Awesome.


თუ რაიმე შენიშვნა გაქვთ დიზაინთან, დამიკომენტარეთ აქ და გავითვალისწინებ :]]


assim volta??


@cristianomatos

I will keep this in mind, its not my purpose to upset anybody...

Thanks for the warning


Looks like you misspelled "canola"!


Variável local iniciando com 2 underlines não é comum!


What's going on there?


So how will the final app's environment know to install Jekyll? Are we going to have to change that mechanism anyway so that it makes sure to install all the different static site generators?


no space between grade and (


please place a comment that empty `[]` aren't allowed


Indeed, i can't get it to work right on my system either when I go to specifically test it.


This changed the schema without adding a migration. I fixed it in 377515b6c2


Yea, I think we need a more general solution for this. For instance, for Hugo you need to find the binary that matches your system or build from source. Also, Travis was failing on the `gem install` command. Not sure why.


From #31


Views are less likely to leave their scope and accidentally outlive their referent if they can't be copy constructed.


@FernetMenta: Do you see a less ugly way to accomplish that?


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/67249269


hele, co to bylo za problém?


The new mobile project will be hosted at https://github.com/GijsTimmers/kotnetcli-mobile.


Yeah I can cherry pick it in.


so why don't you just do `bracketed.append((index, index2))` and then `return any(index <= position <= index2 for index, index2 in bracketed`?

I find that simpler.

Also I'd rather use `start` and `end` instead of index and index2...


Avoid hard code like this.


Add a test?


Лучше не использовать подобную конструкцию для импорта.


I don't get what you mean with that...


@DevGator ran: gem install sinatra-contrib to use cookies.


Do we really need a method manager?
Can't we just add all this stuff to the methode node itself?


ah got that. Maybe the comment can be better.


But it is more explicit (and the code style checks for brackets around arithmetic expressions btw.). :)


Так не определяется размер видео окна (пишет undefined) - dialog_width[640];dialog_height[480].
Если указать width[640];height[480] то размер видео окна меняется но 640 и 480 подставляются в размер иконки, при этом сама иконка размера не меняет.


That will be awesome, I can do a quick test in our application, if this solved our problem to confirm it works also for 4.x.


Good place to use `Keylet{type, mEntryIndex}`.


Можно это вынести в функцию настройки логгера


Looks good to me.


fast-forwarding master to auto = c1dab23d


Криво но работает. rtsp поток только на компе. на телефоне не получается запустить. Нужен транскодер видеопотока.


Can we eliminate `atomic_add_u64`? (Could the workers always count in their own local objects and let other processes do the aggregation e.g. parent process, snabbtop, etc?)


You could base your code on the `next` branch if you like: then dependencies like `core.shm` are already merged and you can use them without adding them onto your branch separately.


Thanks for pointing this out, @jordanpwood - not sure why I missed that.

And sorry for my comments ending up on the PR for merging into the main repo, too - strange that we had what I thought was a separate PR, but turns out they are linked.


Will still raise AttributeError in python 2.{6,7}