fast-forwarding 2.0 to borshop-integration-517-fix-test/zl/yz_pb-sure-up-and-remove-timeouts-for-2.0 = 1894727a


This looks a little bit risky to specify a dependency with such a wide range. For example, cordova `5.0.0` might not even have a base.js for all you know. Perhaps we should allow for patch & minor version upgrades with ^4.0.0.


doh, i added the api key file.... i'll get a new on and resubmit the pull request


Yep, that would be good


[heavywater] New heavywater-ruby created (version: 2.1.5-beta-beta11)

- https://fission.d2o.io/pipeline/job/344315ec-820e-4c06-83cc-000008c70000


This code causes regular ES6->ES5 transpilation to fail. We are not hotlinking any babel internal files.
Our commad line: `babel src --out-dir dist -s`
The `module.parent.filename` and `root` values at this point are respectively:
```
/Users/vasylboroviak/code/base-rest-client/node_modules/babel/bin/babel/index.js
/Users/vasylboroviak/code/base-rest-client/node_modules/babel/node_modules/babel-core
```

Please, unpublish the last babel from npm, or fix that.


Call the parameter scriptInitializerOpt, so that it's clear that the method is not binding field initializers only within the context of script initializer.


This description is probably your best bet, you just need to use jquery or some similar tool to pull a string description from each image. You can do this by setting an onclick event on each image in your gallery that sets a global variable with the description in it. Then you'll pull this description from the variable and deposit it in this <p> tag. That's my best suggestion.


I wouldn't put it this way.  Rather, the scales the style associates with a particular zoom level will be ones that work for Web Mercator or (depending on who is defining the zoom levels) WGS84, regardless of what projection the map is being displayed in.  Specifying `grid` just changes the mapping between zoom levels and scales to match those of the gridset.  The style will work in any projection (Web Mercator, WGS84, The projection of the specified grid, something else entirely) and will vary with scales (not zoom levels) identically regardless of which projection is used (Ignoring issues of scale distortion from the projection of course)

So if you don't specify a grid, and have a rule the applies to zoom level 4, then if you view the map in a completely different projection, but at a scale that's about the same as Web Mercator's zoom level 4, then the rule will apply.  Specifying zoom levels is nothing but syntactic sugar for specifying scale ranges, and specifying a gridset is just a convenience (at least in theory, although how long we have been trying to document this feature makes me wonder) for re-mapping that syntactic sugar to match other sets of zoom levels.


Good point. This actually works with MSVC but will break with GCC if __VA_ARGS__ is empty. Let me find a fix.


Upgrade to 5.6.10.


As for sequence of tables in raw database I suggest using the ones related to procedure f101_make_dataset(). It performs insert over three views f101_part_*, each of them doing a select over table bulk_f101_*. f101_part_* do two things: they make fields uniform (same set of fileds as in f101) and truncate dataset by date and regn list. For form 102 we need bulk tables bulk_f102_P and bulk_f102_P1 (the difference is number of fileds), and views f101_part_P and f101_part_P1, and assembly procedure f101_make_dataset().


SimpleLambdaExpression and ParenthesizedLambdaExpression are not the only nodes representing lambdas. See LambdaUitlities.


Dictionaries are not unbounded; problems are.
Besides, it's the *dual* problem that is unbounded! So the problem is infeasible.

You also need to exit the loop in this case!


I chose `Done` to match what we're using for [Deliverers](https://github.com/mozilla-services/heka/blob/dev/pipeline/plugin_runners.go#L120). These differ from the `Stop` methods elsewhere in that IIRC `Stop` is always called by Heka itself, whereas `Done` is meant to be called by the user's code to say "I'm done with this resource I created."


Missing Comma


If we bind the expressions first then we can ask the binder whether there was await or not, right? We wouldn't need another visitor that detects it.


@jefflembeck - thanks for the suggestion, but no dice. I tried:
```
npm cache clean
npm install
```
and this time put `"@filamentgroup/worker-farm": "1.2.0"` in my top-level `devDependencies` (removing grunticon and colorfy for the time being), but I still see the same error. I'll look into whether this might be a problem with the proxy that the linux box uses, but I'd be interested to hear if anyone else is having this problem with scoped packages.


valid/validated?


@eteq : after astroplan PR #11 gets merged, these are the methods I'll be looking to add.


I'd really prefer to avoid encouraging people to name gridsets as just an EPSG Code.  Conflating Gridset and CRS is a big part of what led to this confusion.  A good name for a representative custom gridset would be something like `StatsCanLCCQuad` (for a gridset that uses EPSG:3348 and a quad tree level progression)


1679-DualDuct (kbenne) - i386-Windows-7-VisualStudio-12: OK (2190 of 2216 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.83%25-yellow.svg)


Okay. Seems like globally installed `babel` was taking over the local one. Thanks


Not worked. Detect name: "Life +1" or "Life +1" (not started)
Really name: Life +1
Please fix extract MessageGameName


Also, when `showSwap` is False, the buttons are still far apart (see screenshot) vs closer together as in current version; hope this is okay.
![screen shot 2015-06-25 at 5 24 45 pm](https://cloud.githubusercontent.com/assets/7341/8368451/4821288a-1b5f-11e5-8ca4-a768579e29b2.png)


jajaja comentario "asdasd" no nos dice mucho que hiciste en este commit XD (soy re gorra ;P )


Shouldn't the return type be Compilation.SubmissionReturnType if the method isn't async? If it is async it should be Task<SubmissionReturnType>.


There are only hyperlink attributes mentioned here: https://github.com/diagrams/diagrams-doc/blob/master/doc/manual.rst#id71

Also typos: additional processing embedded


Yeah, marked as #2 and will fix in the future.


InstanceName => instanceName


Are proper names usually translated?


This comment doesn't make sense now. Script doesn't have any references to previous submissions.


sqlite_timeseries (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1677 of 1685 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.53%25-yellow.svg)


Returns all instances where the instance name matches `filter`. `filter` is a regular expression.


Adds the SSH key given to all instances. Returns whether the key was added or not.


We don't have a show view for sponsor. In my branch i link to 'edit_sponsor_path' and i restrict the use of the show sponsor on routes for that reason.


before.This => before. This


Actually just remove This construction is useful... part


Awesome! This is definitely a cleaner way to do it.


validated, sorry.


Can u give link?


When using the name of contributor, could you use either following formats?
 ```Name <mail@address>``` or
``` @github-account```.


Did it not compile?

Is it related to the PR at all, or just too small to bother separately (I don't care if it is)?

Agree it should broadcast to the forks, if it's useful. I think it won't be too hard to meld any copies later though, no biggie.


`preConfigure` runs always during a regular build
`preCheck` presumably only runs before the tests…

Yeah, the `preCheck` is not strictly necessary with `doCheck = false` but it's probably there just to link to the issue cleanly.


That's not how it works, event if the swap is smaller than the ram there is a big change you can still hibernate: https://wiki.archlinux.org/index.php/Power_management/Suspend_and_hibernate#About_swap_partition.2Ffile_size


throw ExceptionUtilities.UnexpectedValue(containerNode.Kind())


Let's explain why this line is here, e.g.

```
# This dd command works around an issue where ZIL records aren't created after
# freezing the pool unless a ZIL header already exists. Create a file synchronously
# to force ZFS to write one out.
```


Hey Bejond,
This fix seems has a bug：
see code address = 'http://' + val;, it possible to generate a url like http:// www.xxx.xxx


I'd prefer these not to be extension methods.


'Where' clause should not be here. Consider call a method from model.


Enumerating all members might be pretty expensive. Could we look up by name?


We need 3 times Qt::PreventContextMenu : for the 2 toolbars and for the menu at the top. They all allowed user to remove our toolsbars by error.


Are you sure it's safe to block message processing here? No deadlocks?


Put return type into separate line


No need to be sorry! :stuck_out_tongue: Just noticed that when skimming through.


This is the first commit made by TlVC, on TlVC. :smiley: :relieved:


This needs to be reviewed, it isn't the cause of the issue.


This needs to be reviewed, updates should occur once in engine/init.lua as the `update()` method is a shared func.


Whoops! I found out that in Python, only ** is used for powers and ^ is a
binary bitwise operator.
https://docs.python.org/2/reference/expressions.html#binary-bitwise-operations

I'll fix the program so that the square() function is correct.

On Wed, Jun 24, 2015 at 7:16 PM, Mipmap <notifications@github.com> wrote:

> Looks good!
>
> I wonder if ** and ^ are interchangeable? For example, for the square()
> function, could you do:
> return num1 ^ 2
> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/animals4all/Exercise02/commit/3ad507e733f39870dfb5f949306cc3569498dce8#commitcomment-11850023>
> .
>


oops :hankey: sorry about that.


lgtm


Why not `()` for this use?


Because I'm bad at typing. Will fix now.


also, clientURL should be able to include a prefix, so make sure something like http://127.0.0.1/kube-api/ works for clientURL, and reference that in the documentation as well


`object.get('isLoading')` identifies a place holder row


start a async loading process


Works in both, as far as I know.


return object without waiting loading process to finish


GW doesn't artifically limit service access, you just need to add the services to the base64 descriptor as well for .3DS RSFs. It might've been one of my changes since this one, but its working fine for me via .3DS.


`Log.hpp` and `Log.cpp` have not been pushed to the repo yet! I forgot to do it and the files are at my Desktop PC. I am currently on my laptop. Will be pushed as soon as I get on it or from vacation.


@tojofo it's a long shot, but any idea what this (quite restrictive) robots file was put in place?


Very nice, was thinking of doing this myself. :)


In my production environment, the github server gets a 404 error when calling for this file. I've checked the <script> tag in its respective index.html, and it's declared already. So I'm not sure what's happening. In the mean time, I'm going to change my file structure and move all HTML definitions to my blogBuilder.js since this file here isn't very useful, but just a experiment on a new method of developing a website.


Yes, I refreshed the image-fleecing branch now. :)


Sure but then we need to rebuild listconf.o (and thus ../run/john) unconditionally. I'm trying to avoid that.


saw approval from cmeiklejohn
at https://github.com/basho/yokozuna/commit/d31ec4fce402e3635a332b50651a845ef84f0ab6


merging basho/yokozuna/zl/test-fix/fix-regression-yz_schema_admin-develop = d31ec4fc into borshop-integration-518-zl/test-fix/fix-regression-yz_schema_admin-develop


basho/yokozuna/zl/test-fix/fix-regression-yz_schema_admin-develop = d31ec4fc merged ok, testing candidate = 815202eb


I had no idea, thought that was a hard limitation. Glad I was wrong!


No, so yeah here it will depend whether the name is just a name or if it carries meaning


lgtm


ehm isn't this exactly the same Oo


Oh didnt see the bracket


And the necessity of participating to bug triage ...


It didn't compile, because apparently `cprefix` does not apply to namespace members (or only to some kind maybe, like types -- I didn't check), so it created a reference to the non-existing function `geany_main_locale_init()`.

However, you only really need the change to the `Main` namespace, the others were also wrong but as the plugin wasn't using any name it wasn't important (just like `Main` before).


thanks!


@stgeorges ,
Thank you for finding the error.  I just put in some new code that should fix the error for all cases:
https://github.com/mostaphaRoudsari/ladybug/commit/6d8b785700fee3649272ff7147a493da2815e457
-Chris


May as well use IndexByte. UTF-8 is designed so that you can treat rune sequences as byte sequences without error if you're seeking ASCII characters.

Also, I think that this would be clearer:

```go
for {
  i := bytes.IndexByte(w.buffer, '\n')
  if i == -1 {
    break
  }
  w.Output(string(w.buffer[:i]))
  w.buffer = w.buffer[i+1:]
}
```


Thanks for reporting the issue. I'll take a look and submit a PR to address it if needed.


should be spelled "canola"


I discovered TM and LaunchBar do not exclude each other's use of double-shift. ;)

While editing in TM with multiple selections, if you type double-shift, it deselects the previous selection *and* invokes launchbar. Typing `esc` de-invokes launchbar, allowing continued editing. So to deselected two previous selections: `double-shift` + `esc` + `double-shift` + `esc`. It's not inconvenient.


Any particular reason this is exported? Nothing wrong with that exactly, just appears to signal some intent.


It seems the life cycle isn't being set here, as it is below - don't you need to call SetLifecycleTo(...) for each of the registrations?


Testing in progress


These calls are not redundant. If you do not care what cell was selected, do not provide a cell callback. There are use cases where you do not care what cell was clicked, only that a row was clicked. The same logic was applied to the hover event.


some peojects about PhpMyWind CMS


Life cycle needs to be set?


@kentcdodds is it normal for the non minified version to have all that binary data at the bottom? I'm not using that file but has me wondering.


Call this a lineWriter, perhaps?

My immediate reaction seeming bufferedWriter was "oh, implement it in terms of io.Pipe and bufio.Scanner", and then "hmm, maybe just bytes.Buffer". Both of those are overkill, of course. :)


These if statements can be combined.


I keep forgetting about this... This commit closes #204.


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1160


If you were being finnicky--or if you started executing programs that play terminal games--you might also want to spit out output on '\r', '\b', and other control codes. It's fine to wait until it's actually an issue, just occurred to me.


https://travis-ci.org/xuwei-k/scalaz/builds/68410963

```
[info] [core] 10401808 bytes
[success] Total time: 137 s, completed Jun 26, 2015 1:09:36 AM
The command "sbt core/jarSize" exited with 0.
0.20s$ git clean -fdx
Removing core/target/
Removing project/project/
Removing project/target/
The command "git clean -fdx" exited with 0.
178.38s$ sbt 'project core' 'set scalacOptions ++= List("-Ybackend:GenBCode", "-Ydelambdafy:method", "-target:jvm-1.8")' core/jarSize
Detected sbt version 0.13.8
Using jvm options defined in file /etc/sbt/jvmopts
# Executing command line:
/usr/lib/jvm/java-8-oracle/bin/java
-Xms2048M
-Xmx2048M
-Xss6M
-XX:MaxPermSize=512M
-jar
/home/travis/.sbt/launchers/0.13.8/sbt-launch.jar
"project core"
"set scalacOptions ++= List("-Ybackend:GenBCode", "-Ydelambdafy:method", "-target:jvm-1.8")"
core/jarSize
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512M; support was removed in 8.0
[info] Loading project definition from /home/travis/build/xuwei-k/scalaz/project
[info] Updating {file:/home/travis/build/xuwei-k/scalaz/project/}scalaz-build...
[info] Resolving com.jsuereth#sbt-pgp;1.0.0 ...
[info] Resolving com.jsuereth#pgp-library_2.10;1.0.0 ...
[info] Resolving org.scala-lang#scala-library;2.10.4 ...
[info] Resolving org.bouncycastle#bcpg-jdk15on;1.51 ...
[info] Resolving org.bouncycastle#bcprov-jdk15on;1.51 ...
[info] Resolving net.databinder#dispatch-http_2.10;0.8.10 ...
[info] Resolving net.databinder#dispatch-core_2.10;0.8.10 ...
[info] Resolving org.apache.httpcomponents#httpclient;4.1.3 ...
[info] Resolving org.apache.httpcomponents#httpcore;4.1.4 ...
[info] Resolving commons-logging#commons-logging;1.1.1 ...
[info] Resolving commons-codec#commons-codec;1.4 ...
[info] Resolving net.databinder#dispatch-futures_2.10;0.8.10 ...
[info] Resolving org.scala-lang#scala-actors;2.10.2 ...
[info] Resolving com.github.gseitz#sbt-release;1.0.1 ...
[info] Resolving com.typesafe.sbt#sbt-osgi;0.7.0 ...
[info] Resolving biz.aQute.bnd#bndlib;2.1.0 ...
[info] Resolving org.osgi#org.osgi.core;4.2.0 ...
[info] Resolving com.eed3si9n#sbt-buildinfo;0.4.0 ...
[info] Resolving com.eed3si9n#sbt-unidoc;0.3.3 ...
[info] Resolving org.scala-sbt#sbt;0.13.8 ...
[info] Resolving org.scala-sbt#main;0.13.8 ...
[info] Resolving org.scala-sbt#actions;0.13.8 ...
[info] Resolving org.scala-sbt#classpath;0.13.8 ...
[info] Resolving org.scala-lang#scala-compiler;2.10.4 ...
[info] Resolving org.scala-lang#scala-reflect;2.10.4 ...
[info] Resolving org.scala-sbt#launcher-interface;0.13.8 ...
[info] Resolving org.scala-sbt#interface;0.13.8 ...
[info] Resolving org.scala-sbt#io;0.13.8 ...
[info] Resolving org.scala-sbt#control;0.13.8 ...
[info] Resolving org.scala-sbt#completion;0.13.8 ...
[info] Resolving org.scala-sbt#collections;0.13.8 ...
[info] Resolving jline#jline;2.11 ...
[info] Resolving org.scala-sbt#api;0.13.8 ...
[info] Resolving org.scala-sbt#compiler-integration;0.13.8 ...
[info] Resolving org.scala-sbt#incremental-compiler;0.13.8 ...
[info] Resolving org.scala-sbt#logging;0.13.8 ...
[info] Resolving org.scala-sbt#process;0.13.8 ...
[info] Resolving org.scala-sbt#relation;0.13.8 ...
[info] Resolving org.scala-sbt#compile;0.13.8 ...
[info] Resolving org.scala-sbt#classfile;0.13.8 ...
[info] Resolving org.scala-sbt#persist;0.13.8 ...
[info] Resolving org.scala-tools.sbinary#sbinary_2.10;0.4.2 ...
[info] Resolving org.scala-sbt#compiler-ivy-integration;0.13.8 ...
[info] Resolving org.scala-sbt#ivy;0.13.8 ...
[info] Resolving org.scala-sbt#cross;0.13.8 ...
[info] Resolving org.scala-sbt.ivy#ivy;2.3.0-sbt-fccfbd44c9f64523b61398a0155784dcbaeae28f ...
[info] Resolving com.jcraft#jsch;0.1.46 ...
[info] Resolving org.scala-sbt#serialization_2.10;0.1.1 ...
[info] Resolving org.scala-lang.modules#scala-pickling_2.10;0.10.0 ...
[info] Resolving org.scalamacros#quasiquotes_2.10;2.0.1 ...
[info] Resolving org.json4s#json4s-core_2.10;3.2.10 ...
[info] Resolving org.json4s#json4s-ast_2.10;3.2.10 ...
[info] Resolving com.thoughtworks.paranamer#paranamer;2.6 ...
[info] Resolving org.spire-math#jawn-parser_2.10;0.6.0 ...
[info] Resolving org.spire-math#json4s-support_2.10;0.6.0 ...
[info] Resolving org.scala-sbt#run;0.13.8 ...
[info] Resolving org.scala-sbt#task-system;0.13.8 ...
[info] Resolving org.scala-sbt#tasks;0.13.8 ...
[info] Resolving org.scala-sbt#tracking;0.13.8 ...
[info] Resolving org.scala-sbt#cache;0.13.8 ...
[info] Resolving org.scala-sbt#testing;0.13.8 ...
[info] Resolving org.scala-sbt#test-agent;0.13.8 ...
[info] Resolving org.scala-sbt#test-interface;1.0 ...
[info] Resolving org.scala-sbt#main-settings;0.13.8 ...
[info] Resolving org.scala-sbt#apply-macro;0.13.8 ...
[info] Resolving org.scala-sbt#command;0.13.8 ...
[info] Resolving org.scala-sbt#logic;0.13.8 ...
[info] Resolving org.scala-sbt#compiler-interface;0.13.8 ...
[info] Resolving org.scala-sbt#precompiled-2_8_2;0.13.8 ...
[info] Resolving org.scala-sbt#precompiled-2_9_2;0.13.8 ...
[info] Resolving org.scala-sbt#precompiled-2_9_3;0.13.8 ...
[info] Resolving org.scala-lang#jline;2.10.4 ...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Compiling 4 Scala sources to /home/travis/build/xuwei-k/scalaz/project/target/scala-2.10/sbt-0.13/classes...
[info] Set current project to scalaz (in build file:/home/travis/build/xuwei-k/scalaz/)
[info] Set current project to scalaz-core (in build file:/home/travis/build/xuwei-k/scalaz/)
[info] Defining core/*:scalacOptions
[info] The new value will be used by core/compile:scalacOptions
[info] Reapplying settings...
[info] Set current project to scalaz-core (in build file:/home/travis/build/xuwei-k/scalaz/)
[warn] Credentials file /home/travis/.ivy2/.credentials does not exist
[info] Updating {file:/home/travis/build/xuwei-k/scalaz/}core...
[info] Resolving org.scala-lang#scala-library;2.11.7 ...
[info] Resolving org.scala-lang.modules#scala-java8-compat_2.11;0.5.0 ...
[info] Resolving org.spire-math#kind-projector_2.11;0.5.4 ...
[info] Resolving org.scala-lang#scala-compiler;2.11.6 ...
[info] Resolving org.scala-lang#scala-library;2.11.6 ...
[info] Resolving org.scala-lang#scala-reflect;2.11.6 ...
[info] Resolving org.scala-lang.modules#scala-xml_2.11;1.0.3 ...
[info] Resolving org.scala-lang.modules#scala-parser-combinators_2.11;1.0.3 ...
[info] Resolving org.scala-lang#scala-compiler;2.11.7 ...
[info] Resolving org.scala-lang#scala-reflect;2.11.7 ...
[info] Resolving org.scala-lang.modules#scala-xml_2.11;1.0.4 ...
[info] Resolving org.scala-lang.modules#scala-parser-combinators_2.11;1.0.4 ...
[info] Resolving jline#jline;2.12.1 ...
[info] Done updating.
[info] Compiling 249 Scala sources to /home/travis/build/xuwei-k/scalaz/core/target/scala-2.11/classes...
[info] Packaging /home/travis/build/xuwei-k/scalaz/core/target/scala-2.11/scalaz-core_2.11-7.2.0-SNAPSHOT.jar ...
[info] Done packaging.
[info] [core] 6686854 bytes
```


If there's an error, then the trailing output from stdout and stderr will get flushed after the error output. That might be confusing. I'd suggest manually flushing after `cmd.Run`. It's not the end of the world if they don't flush, so giving up the defer semantics is ok.


damn, getting fancy.


Actually, I thought that it was ok, but turns out that it's not a good thing to do. The best thing to do (I think) is no sourcemaps for the non-minified version and a separate sourcemap file for the minified version. Look at the `devtool` property in the webpack config.


[Err] 1054 - Unknown column 'PhaseId', 'PhaseGroup' in 'field list'

-INSERT INTO `creature` (`guid`, `id`, `map`, `SpawnMask`, `PhaseId`, `PhaseGroup`, `modelid`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `MovementType`) VALUES
-(@GUID, 20212, 642, 3, 0, 0, 0, 7.305609, -0.095246, 34.51022, 3.159046, 7200, 0, 0),
-(@GUID+1, 20213, 641, 3, 0, 0, 0, 11.69965, 0.034146, 20.62076, 3.211406, 7200, 0, 0);
+INSERT INTO `creature`
+(`guid`, `id`, `map`, `spawnMask`, `phaseMask`, `modelid`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `MovementType`) VALUES
+(@GUID, 20212, 642, 3, 0, 0, 7.305609, -0.095246, 34.51022, 3.159046, 7200, 0, 0),
+(@GUID+1, 20213, 641, 3, 0, 0, 11.69965, 0.034146, 20.62076, 3.211406, 7200, 0, 0);


should be key not "key"


removes -M flag from BWA MEM align


@mikechen163 TuShare的复权数据目前是基于sina提供的复权因子计算得来，可能跟其他的数据源会存在一些偏差，我按您提供的例子查了一下，收盘价跟腾讯财经的收盘价是一样的，也是27.46，但其它几个不一样。这个问题我以后多关注一下，看能不能找出一个解决方案。


```ruby
user = User.find_by_user_name(user)
return false unless (user && user.authenticate(password))
@current_user = user
true
```


Nice catch. The getUrl function should probably not just return self.options.url if it's set like it does not. getUrl should always be calculated.


```
git pull --rebase
```


Need to toggle `_hasInProgressLoading` in error case.


The only thing I would add would be that only coaches should be able to modify the training_plan on the form as well.

Added it here: https://github.com/o19s/thats-trackable/commit/d86bb342b0aeeb39d91868780aa890d16b52607f


sqlite_timeseries (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1677 of 1685 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.53%25-yellow.svg)


Well, I thought it made sense to be calculated if we are setting the path, but just returning self.options.url if was already calculated I think is fine


Well it's because base and settings are private source. There are Official builds for that device and I have a maintainer again who will be updating again


Yes, fixing.


kexec-internal.h is a good suggestion, will do.


Ouput is still there :-)


A couple of other notes for posterity or whatever:

- PhantomJS absolutely would not visit the URL https://www.paypal.com/us/cgi-bin/webscr?cmd=_history no matter what I did - even calling `open` without calling `wait` like `navit` does - it would hang indefinitely.


Isn't "wxImagePanel" a misnomer?


nice


Hmm, I catch the issue with middle patches before adding KEXEC_CORE changes. Just with #ifdef CONFIG_KEXEC but only enable CONFIG_KEXEC_FILE in .config

With the latest patchset it does not happen, but it should be actually a problem to be fixed with different patch description.


ISidedInventort extends IInventory, there's no need to add both.


I choose KEXEC_CORE because kexec common code not only means kexec_load syscall it also includes the core code for switching to 2nd kernel etc. Also KEXEC_CORE is shorter for replacing #ifdef

I can change to KEXEC_COMMON as well if you like


this is a xor, I would find it more readable as

if bool(pattern_matches) != bool(complement):

or

if bool(pattern_matches) ^ bool(complement):

T.


i need a master key for my 3ds xl

1193007810

Lilprincess@verizon.net


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16937/testReport/) for this commit**


Move this inside getString().


[Err] 1054 - Unknown column 'PhaseId', 'PhaseGroup' in 'field list'

-INSERT INTO `creature` (`guid`, `id`, `map`, `SpawnMask`, `PhaseId`, `PhaseGroup`, `modelid`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `MovementType`) VALUES
-(@GUID, 20212, 642, 3, 0, 0, 0, 7.305609, -0.095246, 34.51022, 3.159046, 7200, 0, 0),
-(@GUID+1, 20213, 641, 3, 0, 0, 0, 11.69965, 0.034146, 20.62076, 3.211406, 7200, 0, 0);
+INSERT INTO `creature`
+(`guid`, `id`, `map`, `spawnMask`, `phaseMask`, `modelid`, `position_x`, `position_y`, `position_z`, `orientation`, `spawntimesecs`, `spawndist`, `MovementType`) VALUES
+(@GUID, 20212, 642, 3, 0, 0, 7.305609, -0.095246, 34.51022, 3.159046, 7200, 0, 0),
+(@GUID+1, 20213, 641, 3, 0, 0, 11.69965, 0.034146, 20.62076, 3.211406, 7200, 0, 0);


Yes, without introducing KEXEC_CORE, we can not handle the generic part in kernel/kexec.c

And yes, I can remove the obj-$(CONFIG_CORE) changes in Makefile


In the long, long ago before time we were getting hammered by crawlers and google and the app wasn't SEO/search index friendly so we just wanted to boot them all.  I think they might even have been triggering weird URLs too but am not certain.


oh noes it's 2015 now!


This introduced an error in tutorial 3 )=

if read in from a .mkm file, most attributes like self.transition_state_names, etc. are stored internally as tuples rather than lists


Why just digits? What about punctuation like #$%&(^,.|/\()? Or non-ASCII characters?

Seems like you should either check that all characters are letters (either upper or lower case), or just ignore non-letter characters (print them unchanged).


Same method name as the above.


this does an unnecessary regexp search just for state information. I think that checking new_val == val could accomplish the same more efficiently


@eregon If there was a reason to use the `instanceof` check instead, feel free to revert.


The ascii art didn't turn out as good as it was in my head, thought it
might be better then explaining it, probably just made it worst.

On Thu, Jun 25, 2015 at 5:29 PM, SudiptaBiswas <notifications@github.com>
wrote:

> Gotcha. Will modify accordingly and probably I should add these stuff to
> Frameworks instead of Phase Field module.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/idaholab/moose/commit/ea2a8cbb5fe25ded5a85a9705387aca74cf41ff1#commitcomment-11872845>
> .
>


I'm lost here, I understood complement as anything not matching the provided regexp, however this unconditionally changes the val if complement is True


@maschall @macklinu this is worth knowing on heroku. check the commit message.


Thanks @tojofo.  @pblain, my guess is that it'd be safe to remove this now.


some inline comments in the code.

overall I think this is a useful and flexible rule covering many use cases.
T.


Resolves #336


Thanks @tojofo! @jkburges, would you be able to remove it?


x86 arch kexec_file code is about 800 lines, moving them to another file looks clearer so that it can be easier to read and understand the syscall related logic. I feel It is better than embedding thos #ifdef in other files.

The arch kexec_file code does not dependent other code like in general part so it will not introduce more kexec.h changes.

I'm not sure I understand "And in crash.c we could divide code between CONFIG_KEXEC and CONFIG_KEXEC_FILE." Do you means keep #ifdef CONFIG_KEXEC_FILE in crash.c

original kexec_load syscall does not have much things in arch code, it is mostly in kernel/kexec.c, only kexec_file_load need arch dependent code changes, it is reasonable to add kexec_file.c in arch/x86?


This is commented out by default.  I'm gonna leave it until we actually do something with this file.


These comments are added by default, they should be removed when this file is updated with any actual information.


typo on corresponds


I made plugins register the queries they are interested in so that there wouldn't need to be a virtual function call for every plugin on every request, a potentially non-trivial amount of overhead. Once I did that it made sense to make it convenient for plugins to register a direct pointer to the appropriate handler rather than force them to re-parse the query name in a catch-all handler.


should we check err == nil first,  then ErrSetAborted， else return err？


Presumably this will affect AWStats data?


This will get hit a lot with all the debug messages coming in, even though they won't be written out. Is this going to have any perf impact?


Ooops, nice catch. I'll fix.


final it lives


Thanks for the info, Jess!


If `InvalidRow` is raised, we want to show debug data if debug is enabled. See line 906-915


Looks like that the "return" isn't needed here anymore.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16944/testReport/) for this commit**


Is this `EMPTY_FIELD`?


@tisto @jensens Sorry, I completely forgot that. You absolutely are correct.


I think I got it \o/

```
nix-build -E '
    with (import <nixpkgs> {}).haskellngPackages;
    with import ./pkgs/default.nix {};
    fns.compileHaskell [aeson MissingH timeit] ./Main.hs'
```

I'm loving this!


On Ubuntu 14.04 + Matlab r2014a the `cout` was printing in the matlab terminal even before this change. For the system that was giving problems with the `<ostream>` an OS X something with Matlab r2012b, we actually never managed to compile the bindings for link problems, but we are investigating the problem.


drop that line pls


I do not get this trend. Why is it deemed helpful to sort properties by name? That's a super unintuitive way of editing CSS.


I have added a `addCustomPath.m` to my directory so we can share the script without any hardcoded path.


You should be more precise in your commit message.


Given that we block the wrist, the hand (`*_hand`) and the little link in the wrist  (`*_wrist_1`) can be considered part of the forearm, so I removed them from the regressor (requires the latest iDynTree).


should we really return a DB date time string here? IMO we should return a CDateTime and convert it to the DB datetime string where we need it.


Shouldn't that map be concurrent?


This looks same as that of `ConditionsMet`, no need to override this.


I think the minimum valid size for a read will be a block.

My latest VP2 blur addition (8 bits texture) creates some 0x0 reads due to others bugs in the texture cache (the sub RT stuff). I think if the texture cache was correct in the first place, those 0x0 reads would never appear.

However supporting sub-RT will likely complex and badly impact the perf. Instead to support RT/DSS as a single big buffer on the cache, we need to see it as a multiple-page buffer.

Another interesting idea, is to apply directly post-processing effect in the RT. For example let's take a green to alpha shuffling. Input texture/RT are at the same address
```
1/ do a lookup of the RT
2/ do a lookup of the src => hit RT
2a/ convert and scale down the texture (or copy the texture in native mode)
3/ do the effect with upscaling rendering which cause bad offset effect.
```
The future
```
1/ do a lookup of the RT
2/ flush the GPU cache (because we read RT directly)
3/ do the effect in full size directly (with a 1:1 pixel mapping)
```

Imagine the perf impact when post processing effect are often done by groups of 8+ (1 page of width) or 100+ (1 page of width and height) for a full frame


Hmm, why the extra curly brackets?


This error shows of the ECL-514 issue. If this will be thrown other methods depends on this Acls will throw 405 response.


Looks same as that of `ConditionsMet`


ReadCommandFlag -> ReadOnly


убрать type: model согласен

а вот если переместить spec в spec/classes, то файл перестает компилироваться. придется прописывать какие-то дополнительные require в spec файл.


@joren485 Hello, I just wanted to ask you, what payload are you using? I tried to get this to work and spent ages on searching for a solution, but every time I try to run the runpe I get an Access Violation error. I tried using all different kinds of files, but none work. Do you know why this is? Thanks for any help!


A small game in Python!


As mentioned in #6, it would be worth checking the schemeIdUri in SCTE DVS 1208 if you have a copy as SCTE 67 may not be the correct spec.

Thanks for fixing the value though!


I don't think these should be intptr_t, they should probably be uintptr_t.


The result of this function could be NULL in theory on memory shortage - maybe you could handle this? Although in this case it's unlikely to happen at all.


OK. I have disabled the redirect by default now as it doesn't appear to be necessary. It can be enabled with the option "-redirectoutput".


Test: Display more client dots than there are clients by changing the loop to e.g.
`for (var i = 0; i < clients + 8; i++)`

Expected result:
Nodes with 0 clients should still have 0 client dots.
Observed result:
Nodes with 0 clients have 8 client dots.


As it's a per-machine setting, this needs to be in the zone_config block, like so:
```
          errors << I18n.t("vagrant_google.config.auto_restart_invalid_on_preemptible") if \
            config.auto_restart == true
          errors << I18n.t("vagrant_google.config.on_host_maintenance_invalid_on_preemptible") unless \
            config.on_host_maintenance == "TERMINATE"
```
Otherwise, even a default Vagrantfile would still try to bring a machine up, for example:
```
...
    google.zone_config "europe-west1-d" do |zone1d|
        zone1d.name = "testing-vagrant"
        zone1d.image = "debian-7-wheezy-v20150127"
        zone1d.zone = "europe-west1-d"
        zone1d.preemptible = "true"
    end
...
```
`vagrant up` happily passes validation and brings a machine up :
```
Bringing machine 'default' up with 'google' provider...
==> default: Launching an instance with the following settings...
==> default:  -- Name:            testing-vagrant
==> default:  -- Type:            n1-standard-1
==> default:  -- Disk type:       pd-standard
==> default:  -- Disk size:       10 GB
==> default:  -- Disk name:
==> default:  -- Image:           debian-7-wheezy-v20150127
==> default:  -- Zone:            europe-west1-d
==> default:  -- Network:         default
==> default:  -- Metadata:        '{}'
==> default:  -- Tags:            '[]'
==> default:  -- IP Forward:
==> default:  -- External IP:
==> default:  -- Preemptible:     true
==> default:  -- Auto Restart:    true
==> default:  -- On Maintenance:  MIGRATE
==> default:  -- Autodelete Disk: true
==> default:  -- Scopes:
==> default: Waiting for instance to become "ready"...
```
(This will, of course, work now, since Fog haven't yet released a new version with your PR included, but when we do upgrade, it will trace back. This can be checked if you specify master git branch in gemfile.)

Since unit-tests pass either way, I would suggest looking at them to make sure they pick up the correct setting.


Please, remove whitespace.


Since this is UI, this needs to produce a formatted message, for example:
"auto_restart" option must be set to "false" for preemptible instances.


This file is included via the Lua ffi not by C code so including headers is not correct, needs some rework.


The only difference with `ConditionsMet.preg_month` is that it raises exceptions. Instead of copying all of it here, you can do this

```python
@property
@memoized
def preg_month(self):
  try:
    return super(FakeConditionsMet, self).preg_month
  except CaseOutOfRange:
    # do what you intend here
```


Same applies for `child_age`


I tried that at first. But it errored out on compile time, something about the compiler not knowing what CDateTime is at that point


I imagine the performance impact of doing it bit by bit will be huge, although there is a flush involved the full frame post effect would be much quicker.


Also, partially fixes #137.


in need to be closed?


Is this using the correct `L<...>` format here? Should the `GeoIP2` be at the end?


Why are there _ after the links?


ack


I can't think of anything sensible to do other than

    if (!vimg->mpi)
      abort();


What do you mean by "bit by bit"


what is dis commit message?


I realized that later, I changed it there: https://github.com/mastilver/node-annotation-parser/commit/6c2a1e6bed92b1e98357bc3d3039720fc772413b


Maybe an explanation of why it isnt in another process? in the commit message


is it efficient to recreate the ObjectWriter or can it be reused?


could you please provide the compiler message?


sure


mais teste


new version on wip/sils/cc PR


I have done this already but thanks :)


OK. I'll check with Alex Giladi. The fix should be up and running on the dev instance of the server now. Like http://vm2.dashif.org/livesim-dev/scte35_2/testpic_2s/Manifest.mpd


You could fix that on your branch and force-push. <sub>(Just saying...)</sub>

That said, I don't see why we should add `ng-app`. I mean it is obviously not a full application, but a chunk show-casing setting a controller and it might give the wrong impression that you can only specify `ngController` along with `ngApp`.


sorry i mean in sections (like killzone, mgs3 etc) unless im getting the wrong end of the stick there!


And removed the Mining Hardsuit RCD


Hab noch Settings Menu entfernt


It's actually `HMAC(MD5, UTF8.bytes(""), protobuf(Message))`

where `UTF8.bytes("") => the empty array` is xor-ed (i.e. it's not, because it's empty) with:

``` csharp
        private void UpdateIOPadBuffers () {
            if (m_inner == null)
                m_inner = new byte[BlockSizeValue];
            if (m_outer == null)
                m_outer = new byte[BlockSizeValue];

            int i;
            for (i=0; i < BlockSizeValue; i++) {
                m_inner[i] = 0x36;
                m_outer[i] = 0x5C;
            }
            for (i=0; i < KeyValue.Length; i++) {
                m_inner[i] ^= KeyValue[i];
                m_outer[i] ^= KeyValue[i];
            }
        }
```

And BlockSizeValue = 64 for MD5.


Bitte nächstes mal auch die andern activities anschaun, da hats die ActionBar komplett zerschossen :D


Adding the abort is fine too. mpv generally abort()s on all kinds of OOm situations. It only tries to handle big allocations gracefully, which includes image allocations. But in this specific case, mp_image_new_ref() will never actually allocate image data, but still could return failure in theory.


It seems like a bad idea to have this key enabled by default, and also be the same key used to reload shaders after editing.  Anybody using just F10 to reload for experimentation will also be constantly resetting their .ini preferences.

Probably benign, but the reload_config is not a feature I will use, I prefer to have clean experiments and don't mind relaunching a game.


I'm confused about what's going on here.
1. If this is a frame, then the initial definition should change.
2. If it is a frame, how do you add new processes to a task?
3. If it is a frame, then `exp_processes` is pointless.
4. One of the goals for using a template here is that when `exp_processes` happens, `process_name` is defined by from the attribute name. Is that not worth while?


better encapsulation should guaranty a state with non-empty line


Nice, maar er is wel een probleempje als je je venster kleiner maakt:
![image](https://cloud.githubusercontent.com/assets/2071542/8375595/007e32ca-1bff-11e5-8db4-12cda63791cc.png)

En op mijn OP1 is het probleem nog erger.


ack


You're right, in terms of type casting this one is optimal. My objections was more about design consideration, i.e. accessing outer environment directly within anonymous class leads to the extra coupling between components which I'd prefer to avoid :)


@dialelo: Is this sufficient?


I was pointed out once by @puiterwijk that ``%{_libexecdir}`` is designed to store executable meant to be run by the system and not the users


Congratulations.

Please indent correctly the patch before to commit.


I don't claim perfection. I'm sure if you have had a "missing semicolon" moment; or something. This just does not crash the script unless I've overlooked a super strict code option. Since I don't know, is there a super strict syntax option for shell scripts?

If you like this type of automation, checkout my latest ongoing work https://github.com/KellyLSB/mkdebdisk.img


Hum, I think we have a couple of misunderstanding. When I mean full size, I mean the upscaled size. So a game like MGS3 will loop ~140 times on the 3 steps. Texture flush is free (a single register write and current (future) GPU bandwidth is infinite for us) versus running thousand of shader to convert the image.

However you right, the best will be to replace the 140 small section with a single full frame draw. It would be a huge boost on performance (and avoid those texture cache issue). However this solution is a hack not the previous one :p


음 의미없는 코드 아닌가요?


Oops, forgot to update this line. I played around with this a bit.

2 - I override it. Should this be "?"?

3/4: That's worthwhile.


@tchap Obviously I was talking about the situation when you want them removed (or kept absent).

But okay, I guess the bigger issue here is that two different structures are conflated. First is the normal data that you need in your code. Obviously that needs to have a labels array there always.
But then there's the query you're sending to PT and from what I gather, this is not the same structure because fields can be ignored there and then they are not updated. So the problem is with this conversion between the two and it seems to me you're saying that the default JSON converter is doing a shitty job...


maybe it would be better to have situational versions, if upscale_multipler = 1 { do it properly } else { speed haxxx } :P


@maechler : sollen wir den Fix testen und ev. produktiv setzen? Oder könnte das negative Auswirkungen haben?


do you need it as a static member variable?


124 名前：login:Penguin [sage]： 2015/06/26(金) 19:25:02.73 ID:QVLhJ1gj
92さんの改変版2chproxy.plでも取れないレスがあった
BEのところが?##ってなってるやつ
(普通は?2BP(2000)ってなってるけど)

正規表現中の be\((\d+)\)[^>]を be\(([^\)]+)\)[^>]ってしたらいけた


This method of comparing versions could lead to bad situation when `"1.0.0.10" < "1.0.0.9"` - the lexicographical order!


@tchap Well, I get that. But the functions are not actually doing anything useful. So why is this approach needed at all?


2. Yes, go for `?:`
3/4. Your choice. If you prefer to have a frame, then rip out the `exp_processes` and shuffle all the uses to `processes`.

Other question: is there a useful distinction between a task and a job? I considered merging them, but I didn't know if having them separate di something useful I didn't recognise.


No tag for this release, sad panda.


@tchap Are you saying that each and every time you want to add a new error, you need to create a dumb wrapper and stupidly reimplement all the interface functions like this? Because that's crazy. Isn't there a better way to handle errors?


@oschihin
Ja bitte testen und evtl. produktiv setzen. Es sollte keine negativen Auswirkungen haben. Die einzige Änderung ist, dass der Rückgabewert von orderAndFilter nicht mehr in eine Variable gespeichert wird. Das gibt eine Notice, die geloggt wird.
Ich bin von diesem Tag https://github.com/swissbib/vufind/tree/RD1.3 ausgegangen. Wenn dieser live ist, dann sollten auch keine andere Änderungen mitkommen. Darauf gilt es zu achten.


Fixed, thanks for pointing this out.


That won't work for compilers targeting non-x86 cpus. Use ```CheckCXXCompilerFlag``` to ensure that the compiler supports it.


I believe the option should be up to the packager, not up to the user. So I suggest to just read it from partition.conf as a bool, without UI.


had to change this since in create_app_input.yaml it was "app_id" and the flow failed


ack


use DirectoryObserver enum with values to avoid the switch


Done.

There isn't a distinction that I'm aware of, though it's probably best to stick to what upstream does so the configs are more understandable to someone used to Aurora.


because order_by('distance')[0] gives us closest city from zip_code location point
https://github.com/coderholic/django-cities/issues/79


It does, but the geometry type does not end with "Z", which gives some headaches to SpatiaLite's WKT parser (see comment below).


Missing php dic


Fix that. I removed class structure and delete excess part


@bonzofenix, @cloud-dude,

In the  future, could you just have 1 "change" / PR - this addition of a vsphere template (whilst useful) doesn't really fit here.

Makes my life as a reviewer easier


I did some tests and apparently it's not robust enough. Probably we should do something similar to what the `decodeGeometryValue` function does, but in reverse order: take the output of `wktWriter.write(value)`, prepend the string `SRID=<srid>' to it and then run the query 'SELECT GeomFromEWKT(?, ?)`.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16948/testReport/) for this commit**


This is stupid. We can mount usb storage from recovery.


This commit introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=14736


NO!


Um... Turns out the memory leak is still there. I commented out the line than fixed most of it:
https://github.com/haved/3DSmithGameCpp/commit/06f17020628a7a8bf335fe54b09bdb88c7e714aa#diff-47093f1a77473b4bc0d6c69e17118a53R96


That came off a bit strong - make it `16px` max. `20px` helvetica looks foul.


ainda


Between this and the previous commit Firefox 3 compatibility should be restored.


This is the culprit. It should have been `ctx.getSelectedDriverConf()`


/giphy over reaction


Yes, despite taking advantage of typed arrays, we have a crapton of fallbacks that are spread out in this project just for browsers we won't use ever again, except for funzies.


Don't you wanna scope this as provided?


You just need enough of canvas2d that supports pixel manipulation and regular javascript support with a file loading api to run this.


This was intentionally changed so that it does not use default port.  This will break a previous fix.

The expected behaviour is that when the port is -1, the URI that is created will be created without a port. The difference is that some web requests will fail if an explicit port is defined.  We had a case where a harvester failed because the port number was set.


谢谢，提醒一下你的用户名和密码暴露了，先去修改密码， 然后在patch里面把用户名和密码这两行修改删掉吧


ack


I see more such typos in other .h files as well. Of course those are not relevant for the lib itself, but still.


i deleted some 'then's that did not appear to match to any 'if's
i also put bb_apg_2 for mount compatibility
Download->download (also for compatibility)(is not case sensitive so its okay)
did it fix your problem?


you've gotta teach me how to use meteor, bro lol


As usual, could request splitted lines as changes don't even fit github view :)


done


LGTM


nu mai baga codu aiurea


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/14092/testReport/) for this commit**


A nice way to write this is with `@Cached`:
```java
void triggerInheritedHook(VirtualFrame frame, RubyClass subClass, RubyClass superClass,
    @Cached("create(getContext())") CallDispatchHeadNode inheritedNode) {
```
But we need:
* CallDispatchHeadNode.create(RubyContext), should be easy.
* It must be in a @Specialization of course, so here they should be unified by having two CreateCast, one coercing the block to null if not provided, and one for `superclass` to default to Object.


ok


I will refactor these to minimize duplication


I think there can be arguments made either way... here's some for enabling this by default:

- If memory serves, in the Dying Light fix users were being actively encouraged to change the [Constants] section and restart the game to dial in the shadow offset, once this was implemented that advice changed to just edit and F10 - so, this setting seems useful for users, not just shaderhackers.

- In that same thread before this feature was implemented, confusion was expressed as to why F10 reloaded shaders but not the ini parameters.

- You can always disable reload_config live without restarting the game, but can't go the other way.

- If you aren't using key bindings the parameters are static and reload therefore won't change them... Unless of course you edited them - in which case you want them changed, because otherwise you wouldn't have just edited them.

- If someone defines some key bindings that change the parameters and find the config reload annoying they can disable the config reload without having to restart the game.

Here's an argument against it:
- After a reload the new ini settings will appear in the log file after any shader compile errors, so a shaderhacker may have to scroll up a little.


More task specification: we also need to assemble date (new field 'dt') in date format when importing the file (as 1st day of month after end quarter: 01-04-YYYY, 01-07-YYYY, 01-10-YYYY, 1-01-YYYY). Otherwise we cannot cut the dataset by date when migrating to final database.


Hi can you please provide a bit more details? Are you connecting to a kerberized cluster? What version? Did you have a valid ticket?


@AbdullahAlger yep sorry for the cryptic details.

Take a careful look at how the `down_vote_link_classes(post)` and `up_vote_link_classes(post)` helper methods are being used in the above `_voter.html.erb` partial template. Right now they won't be doing what's intended (i.e. inserting the `voted` css class when needed).

Consider checking this by running bloccit and doing a "View Source" on the generated HTML page that includes this partial.


@mbernat Sure, there is just a single `pivotal.Story` struct that is being encoded by the default `encoding/json` encoder. Obviously I could implement something special and add `MarshalJSON` method which is called by the encoder when present, so you can add custom marshalling, but I don't think that it's really worth it... Anyway, how would you distinguish `[]` vs. unset again? Like, add a special struct just for the scenario when you want to send empty label array?


The decryption module is now independent of the Encryption module


Great, could you just follow https://docs.djangoproject.com/en/1.8/internals/contributing/committing-code/#committing-guidelines for the commit message (no colon after Refs and past tense for the initial verb)?


@tchap Ah, that's ok. I thought `EnsureBranchSynchronized` also performs some operation but it's actually just an assertion.


Is there a good reason for `AccountsEvent` being mutable?


:+1: well done


So this is now failing on Django 1.6 due to the use of the atomic() context manager in the sql flush method

Given that mongodb (and other non rel databases AFAIK) don't support transactions, I was wondering if we should patch this to not use atomic() if the database feature atomic_transactions is set to false (it is by default but we can override in djangotoolbox or mongodb-engine).


@mbernat Yeah, it's stupid like that because of a name collision. I could just embed `errs.Error` and everything would work, but embedding `errs.Error` will then tell you that there is name collision with `Error() string` method. But I guess that I will try to change it, will just have to come up with a better name, other than `Error`...


@tchap Oh, I see. What confused me was the usage of `LocalBranchExists`, that made me think that `target` is remote in this case as well.


Here, I'd perhaps find it useful to learn from JavaDoc which values `AccountsEvent.getAction()` can return. Either enumerate the literals here, or if the set of possible values is given by some external service, point the reader to somewhere where those values are documented.


I don't think you need to set NAME_BAD and NAME_GOOD above.

write_terms() is already setting NAME_BAD and NAME_GOOD and it's an error if BISECT_TERMS exists and $cmd is not either NAME_BAD or NAME_GOOD.


else if don't match ?


why creating a temporary list? you can use just a counter


I understand, I never expected you to rewrite the code. Nevertheless, just for the future reference: seeing that you needed to return only a raw SAFEARRAY pointer, it could have been done even with the current (1) wxSafeArray implementation.

I.e. `MakeOneElementVariantSafeArray()` implemented like this
```cpp
#include <wx/msw/ole/safearray.h>

SAFEARRAY* MakeOneElementVariantSafeArray(const wxString& str)
{
    wxSafeArray<VT_VARIANT> safeArray;

    if ( safeArray.Create(1) )
    {
        long indices[2] = {0, 0};

        if ( safeArray.SetElement(indices, wxVariant(str)) )
            return safeArray.Detach();
    }

    return NULL;
}
```

1. See http://trac.wxwidgets.org/ticket/17043


why download_xxx has a command parameters?


Please add Image Cache and Base to translation....


The experiments are of type "xnat:subjectAssessorData". They are not necessarily imaging sessions. Imaging sessions are "xnat:imageSessionData" that extends the type "xnat:subjectAssessorData". Therefore, it is not good to put image session specific fields in the more generic subject assessor (experiment) type. A new C++ type could be introduced, let's say ctkXnatImageSession, that derives from ctkXnatExperiment and has the "xnat:imageSessionData" xsiType. The image session related properties could be declared in that.


This message could perhaps show the message that was received:
```java
@Message(id = 140000, value = "Event received by Accounts Message Listener: %s")
void eventReceived(AccountsEvent e);
```


@tchap So... why is it not implementing it? Sounds like a root cause error as actually a kind of error :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16953/testReport/) for this commit**


Antoine Renault
Guillaume Thiebaud


Defined in ExchangeBooking


@mbernat Fixed in b730c6c


It's existing code.  The diff just looks weird because I removed a lot of code above it and placed it into helpers below it.  But I can look at removing that.


Yes, you are right. It's a good point!


Assuming that makes it into Grafana 2.1.0, it'll be breaking semver - which IMO we'll need to hide from users. What do you think about having that be toggled by the `node['grafana']['version']` being less than 2.1?


It seems like it works now, due to the code now beeing in ```FileUtil```

When it's in ```File``` this happens
![error](https://cloud.githubusercontent.com/assets/5943908/8376327/5f26a3d2-1c06-11e5-9f52-68dccf8d8772.png)


Would stacktrace not be interesting in this case?
```java
@Message(id = 140001, value = "An error occurred while trying to process event")
+    void errorProcessingEvent(@Cause Throwable e);
```


This is enabled to have more space in /data by having less space in /system. This reduces first boot time.


Easy enough to do.  I was just trying to avoid specialization explosion.  Although it looks like only 4 new cases and they shouldn't grow.


Fixes #24


itertools.chain.from_iterable(map(get_slot_notes, slots))


Can't get relative paths to work properly..
Working:
```javascript
templateUrl: 'app/home/home.html',
styleUrls: ['app/home/home.css'],
```

Not working 1:
```javascript
templateUrl: 'home.html',
styleUrls: ['home.css'],
```

Not working 2:
```javascript
templateUrl: './home.html',
styleUrls: ['./home.css'],
```
<b>Error:</b> Failed to fetch url "http://localhost:49975/home.html"


job logs


@mbernat Well, `Error` is there to wrap kinda deeper errors which are accessible through `Err()` method. So basically you get something like `Error(task, Error(task, Error(task, error))` where this `error` is the last in the chain and it is just the plain Go `error`. That is how this code detects that we are at the end of this chain.


blob_uris in  can be null ?


Hi,

this repo is kept for reference but is not maintained. The dst
configuration is maintained in :
https://github.com/RobertCNelson/bb-kernel

branch v3.8.

Regards,

Jonathan Piat

2015-06-26 11:22 GMT+02:00 Martin <notifications@github.com>:

> What you did here is somewhat confusing. You modified the .dts file ending
> with version code A2 to including a version key with a value of "00A3".
> Additionally, you deleted the .dts file ending with version code A3.
>
> I suggest that we should rename the currently existing .dts file to
> BB-BONE-LOGIBONE-00A3.dts
> accoringsly.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fpga-logi/logi-kernel/commit/96cf6a60114a8afb5ab1e885f21fa5629fea9ce9#commitcomment-11878574>
> .
>


I can add an assert instead, but we didn't have any specs that caught the issue.  It came about when running 3rd party code and I don't think it's common practice to run with assertions enabled in that case, so the issue would go unnoticed.


There are several occurences of the `"java:/topic/HawkularAccountsEvents"` literal. Should we not introduce a constant somewhere?

The same holds for `"java:/HawkularBusConnectionFactory"`


it is actually scoped as provided in pom.xml (and the above is the api/pom.xml)


`System.out.println` ?


Commit 5c7bfb5c added 4 days after this commit changed it to `/\.#{Regexp.quote(host)}\z/`, which should also prevent accepting notrubygems.org target for rubygems.org.


agreed

On Fri, Jun 26, 2015 at 1:23 PM, Michael Lanyon <notifications@github.com>
wrote:

> Assuming that makes it into Grafana 2.1.0, it'll be breaking semver -
> which IMO we'll need to hide from users. What do you think about having
> that be toggled by the node['grafana']['version'] being less than 2.1?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kamaradclimber/chef-grafana/commit/cc38697eeae0685f58e2c8dea52c3ef37a7917cf#commitcomment-11880132>
> .
>

--
Grégoire


`List of parameters used to determine path priority when querying for params`


@louh I comment this to prevent changes being erase on zoom change. Please take a look


We could send a status back in the callbackCommand and maybe differentiate a bit more on what went wrong.


I'd prefer for each test to be self-contained and not call helpers like this.  I know it reduces code duplication, but it makes it harder to understand what each test does and harder to debug. This is actually a question of style and I would appreciate everyone's opinion, because it will affect how other scenario tests are factored.


Do not use `random:uniform` for nonces! Do not use stuff like that anywhere near cryptographic functions. You need [a cryptographically secure RNG](https://en.wikipedia.org/wiki/Cryptographically_secure_pseudorandom_number_generator). Try [crypto:strong_rand_bytes](http://www.erlang.org/doc/man/crypto.html#strong_rand_bytes-1).


The literals could perhaps be transformed to constants or fields of an enum.


TeamCity xBIM :: XbimExchange :: Build [Build 353](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1934&buildTypeId=XBIM_XbimExchange_Build) is now running


Its not really a status, it is a count of items.


I'll try to do it in the next few days


`still doesn't look`.


A constant for the literal?


TeamCity xBIM :: XbimExchange :: Build [Build 353](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1934&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:21


TeamCity xBIM :: XbimExchange :: Build [Build 354](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1935&buildTypeId=XBIM_XbimExchange_Build) is now running


a CDateTime instance which is invalid.


11: 25 - Missing semicolon.


19: 25 - Missing semicolon.


35: 25 - Missing semicolon.


40: 25 - Missing semicolon.


TeamCity xBIM :: XbimExchange :: Build [Build 354](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1935&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:15


TeamCity xBIM :: XbimExchange :: Build [Build 355](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1936&buildTypeId=XBIM_XbimExchange_Build) is now running


`excludedEvents` could be made `final`, could it not?


Nota bene: This contribution https://github.com/Subscribo/omnipay-subscribo-shared/commit/38c9307063704dcea2d2fa80c8ba0b24976e0c7a has been accepted before this CONTRIBUTING.md update


TeamCity xBIM :: XbimExchange :: Build [Build 355](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1936&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:15


TeamCity xBIM :: XbimExchange :: Build [Build 356](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1937&buildTypeId=XBIM_XbimExchange_Build) is now running


This looks wrong to me. When a new object is created through REST, XNAT replies back the new ID that it assigns to the object. This ID should be set into the ctkXnatObject. If you remove the negation then this won't happen.


expected, see #2383.
Working on adding support for this.


fyi: Related roles for each DvObject type
![role_permission_relationships_-_root_dataverse](https://cloud.githubusercontent.com/assets/1036060/8376463/96d1048e-1bd5-11e5-91f1-ca3c32bef07e.png)
@sekmiller @scolapasta


The `HashSet` should perhaps be made unmodifiable?


I suggest that something like the function at #19 at
http://stackoverflow.com/questions/2365411/python-convert-unicode-to-ascii-without-errors
should be used here and in many other places?

On 25 June 2015 at 08:56, John Cremona <john.cremona@gmail.com> wrote:

> Sounds good.  I will test it out tomorrow, expecting to merge it later.
>
>
> On 24 June 2015 at 21:01, John Jones <notifications@github.com> wrote:
>
>> Here is the bulk of the url which triggered the problem.
>>
>>
>> /NumberField/?natural=x%5E3+%2B+x%5E2+%E2%88%92+3%5Ex+%E2%88%92+1&search=Go
>>
>> I used a web converter to get x^3 + x^2 − 3^x − 1 for the polynomial. I
>> am giving both versions in case the converted one did not past properly.
>>
>> At first I thought the problem was the 3^x but we handle that ok. The
>> problem is the minus signs are not the kind you get from your keyboard.
>>
>> I just added another line. We replace those unicode dashes with ascii -,
>> and then strip any other unicode from the string. So, the function above
>> won't be found (it is not a polynomial), but it won't give a crash either.
>> If you change 3^x to 3x, then it will find what you want.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/jwj61/lmfdb/commit/03130061cd2c732568fa5209ce814534d4970c5f#commitcomment-11846799>
>> .
>>
>
>


`final` ?


TeamCity xBIM :: XbimExchange :: Build [Build 356](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1937&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Compilation error: Xbim.COBieLiteUK\Xbim.COBieLiteUK.csproj (new) Build time: 00:00:54


Should there be a second test which does the same thing but uses the "use remote polling" extension to confirm that with remote polling enabled it has the same behavior as with local polling?

Or have I misunderstood and the behavior in this case is intentionally different between remote polling and workspace based polling.


Fixed #281


Can't find anything about "angular2/src/http/interfaces"...
Am I missing something?


Is this comment correct?  The job does not seem to include any parameterized component that I can see.


Can you fix the indent?


Remove unneeded underscore for protected variables


Docblock ;)


It's needed 2 parameters insteadof 3


Will this call to build cause two builds to happen, one for the master branch and one for someBranch?  Should the test assert that the expected number of builds were executed?


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 8](https://bsr.ict.je-labs.com/viewLog.html?buildId=29932&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) is now running


Directly expression pass will be more beauty


i tried to as well
but net stopped working for an hour then yesterday :|


it showed 1800 MHz by default :3


redis uses read and write command

```
 * w: write command (may modify the key space).
 * r: read command  (will never modify the key space).
```


What a pity that the standard `URLEncoder` cannot write directly to `sb`


19: 25 - Missing semicolon.


35: 25 - Missing semicolon.


I'd really like to move to a client style integration like the gecko gem. It completely solves these issues


So no sql for the log?
```CLog::Log(LOGERROR, "%s unable to update dateadded for file (%s)", __FUNCTION__, strSQL.c_str());```


实际上是生成两个文件，一个用于保存文件名，一个保存下载地址


    {%- if not is_compilation %} data-disabled-until-change{% endif %}

would be nicer in my opinion


less is more :-)


Sometimes it is good to squash commits and force push the branch. I just commented the previous commit that you undid in this one. Or if you want to undo the entire commit, you can just revert and force push. It would make reviewing the code quicker.

Are you certain that map size is always 2? I believe that this code worked.


nice


Garvin - can you explain to me: how does the Standard attachment mode `$postattach[] = $attlink;` get into body here, while not being referenced or returned? Or is that just a "dummy" entry, while done before?
https://github.com/s9y/additional_plugins/blob/master/serendipity_event_popfetcher/serendipity_event_popfetcher.php#L838


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 8](https://bsr.ict.je-labs.com/viewLog.html?buildId=29932&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) outcome was **SUCCESS**
Summary: Running Build time: 00:05:33


Can add a comment as to what role 6 is here?  I generally try and use the strings version in the where clauses to make the code easier to read.  Maybe this filter needs to go in the caller of this routine?


39: 11 - Use '===' to compare with 'null'.


Initial commit.


Had to make these exact changes myself just now. Would be good if this got merged.


+1 for `_templates`. I was about to do this as well


`inputStream.close();` seems to be redundant to me. `reader.close()` called implicitly by `try(Closeable)` should also close the underlying `inputStream`, should it not?


Ok, not 100% sure what's going on, but I take it, that is works.


35: 25 - Missing semicolon.


Yes. I see that, but It not woking  on Linux(I have test on Fedora and Censtos for my project) when traslation the english to Vietnames or Germany


+1 :-)


Perhaps we could introduce a utility function that determines if a `Node` came from jsdom?

In which case we would also have to think about if we want to support importing or adopting node from a different jsdom module (either the same version or a mismatched version). This is something that might occur with npm, e.g. `myproject/node_modules/foo/node_modules/jsdom` and `myproject/node_modules/bar/node_modules/jsdom`.

If we decide not to support this, we could implement this check using something like:
```javascript
const IS_JSDOM_NODE = Symbol();
Node.prototype[IS_JSDOM_NODE] = true;
// ...
exports.isJsdomNode = function(node) {
    return Boolean(node[IS_JSDOM_NODE]);
};
```


11: 25 - Missing semicolon.


19: 25 - Missing semicolon.


40: 25 - Missing semicolon.


Can you have a look at https://github.com/biolab/orange3-datafusion/commit/eb9bb01cba4fdbdbbe796e6414726c33038af855#diff-c9fbb42c16303ca309be5c1dab3603e9R52; if there's a problem, it's there.


extra space?


Not being specialist in this area, what are the advantages of `HttpURLConnection` over Apache HTTP client or some other HTTP client? I wonder how this can be made HTTPS-compatible some day?

I remember that making timeouts to really work used to be a black magic with `HttpURLConnection`.


Shouldn't it be Red Hat?


spacing?


`System.out.println` again? I am starting to think that this is some Unix-style utility?


I had the concern of not introducing extra checks inside the function, since it's supposed to be fast. But I guess that isn't really critical.
So ok, I'll change it so that the verification is done in runtime.


`final`?


Yep, here is the update. Not very eloquent, but gets the message across I hope https://github.com/geodesign/django/commit/449efb2387ed2748a08e853ebdbccebf86ee895c


Fixed by f16e438b2473402be4889aa35df46ce709a3b02c.


Thanks I'll send v2


ACK. Sorry.


Actually, what is the purpose of this class? It does not seem to be doing anything?


名稱好像怪怪的，星期一再來想想怎樣能比較明確的表示這邊要做的事情


opened https://code.djangoproject.com/ticket/25028.


This is the part that was segfaulting. Had the index wrong. Added driver_indx to make it clear.


> (...) adding the parameter to detect as well (...)
Sorry, that wasn't clear to me. What would that mean?


11: 25 - Missing semicolon.


19: 25 - Missing semicolon.


35: 25 - Missing semicolon.


40: 25 - Missing semicolon.


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 9](https://bsr.ict.je-labs.com/viewLog.html?buildId=29935&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) is now running


@kkirsche I've commented in the main part of this thread that it looks like it is better just to have no reference to a specific radius, other than setting the zeros.   I am not a regular patch contributor, and was wondering if you might update your submission to reflect that concept.


No need


The real answer is to use a WeakSet branding mechanism. Since that's not great, checking for a magic property is reasonable. A symbol would indeed be more robust, but for now this kind of thing seems ... OK.

I think it'd be best to wait and address this overall branding story as part of a bigger generate-everything-from-Web IDL push. In the meantime I am kind of just adding ad-hoc checks as we go along...


39: 11 - Use '===' to compare with 'null'.


cc @nunoguedelha


the readme also says 0.0.9 whats going on


I changed the code here to
```javascript
var containerHeight = container ? container.offsetHeight : window.innerHeight;
var containerScrollHeight = container ?  container.scrollHeight : document.body.scrollHeight;

// Depending on the scroll direction check if we reached the top or bottom
var endCondition = distance < 0 ? currentLocation === 0 :
            (containerHeight + currentLocation) >= containerScrollHeight;
```
That fixes the access to container even though it might be null and scrolling upwards.


Coole Sache das. Kompiliert ohne Probleme. Drei Punkte:

1. Ich bin mir nicht sicher, ob das `git submodule init` Teil des Scripts sein sollte. Wenn nicht, dann müsste es aber noch mal in der Doku erwähnt werden.
2. Kannst du die Startseite vom Hyrise-Repo bitte noch entsprechend anpassen (Vagrant raus, Docker rein)?
3. Die Tests laufen bei mir nicht durch:

```
/home/dev/workspace/hyrise/build/units-io_debug --minimal
Something went wrong while fsyncing the log directory: Invalid argument
Something went wrong while fsyncing the log directory: Invalid argument
..FFFFFF...................................................
DumpTests.should_not_dump_other_tables_than_stores
(null):-1: Failure
C++ exception with description "locale::facet::_S_create_c_locale name not valid" thrown in SetUp().
DumpTests.should_not_dump_store_with_muliple_generations
(null):-1: Failure
C++ exception with description "locale::facet::_S_create_c_locale name not valid" thrown in SetUp().
DumpTests.simple_dump
(null):-1: Failure
C++ exception with description "locale::facet::_S_create_c_locale name not valid" thrown in SetUp().
DumpTests.simple_dump_load_all
(null):-1: Failure
C++ exception with description "locale::facet::_S_create_c_locale name not valid" thrown in SetUp().
DumpTests.simple_dump_load_header
(null):-1: Failure
C++ exception with description "locale::facet::_S_create_c_locale name not valid" thrown in SetUp().
DumpTests.simple_dump_should_not_dump_delta
(null):-1: Failure
C++ exception with description "locale::facet::_S_create_c_locale name not valid" thrown in SetUp().
```


nice, will this tool work well in android or ios ？


See a135c9dc1d80bce8365ad2a282f975eed8b6152d


2: 25 - Missing semicolon.


Yes that is the error that travis get.. but i sincerely don't know where it is the problem


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 9](https://bsr.ict.je-labs.com/viewLog.html?buildId=29935&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) outcome was **SUCCESS**
Summary: Running Build time: 00:05:33


Ok, let us stick to KEXEC_CORE for now. Should be easy to change it once we have something going, if need be.


does this leave _device uninitialized if not found?


Would like to see this clarified a bit more. It's not really clear that there are three distinct options to authorise to the API.

Maybe something like
> There are three different possibilities to authorise with the API. By default (...) . If no credentials are set, the env var (...), etc.


19: 25 - Missing semicolon.


35: 25 - Missing semicolon.


> the codebase is not uniform,

hm, yeah - unfortunately we still don't have a consistent style in our code.

>  but for new code we should follow what's in uncrustify_cpp.cfg

Thanks for the tip! :)
I wasn't aware we had that.


two types of authentication: using a token or a username/password combination.


Also what is What is CONFIG_KEXEC_CORE_JUMP?


This actually is so much shorter than the existing code, that I probably should rewrite it like this.

I don't understand why do we need 2 indices though: it's a one dimensional array so I would have thought a single "0" would be enough, am I missing something?


Очень мало проверок. Будет фейлиться и при дробных числах, и при отрицательных. Факториал определен только для неотрицательных целых чисел.


Hello,
I think this crashes the autocomplete since the **ui.autocomplete.js** file, which is loaded in line 40 *elgg_load_js('elgg.autocomplete');* is using the var **elgg.autocomplete.url** before being defined.
Maybe you should load this file with require also (in line 46)

Thanks!


А зачем обратный слеш перед Exception? Какая его роль здесь?


恩.. 是有一點  再想想好了。。


А зачем выражение взято в скобки?


Coloca a pasta de logs no `.gitignore`.


Coloca a pasta `tmp` no `.gitignore`.

Quando executamos o `rails new`, ele já vem com um `.gitignore` para boa parte dos casos.


$('.filter input[type="checkbox"]').styler(); - этот код не срабатывал, т.к. до него была ошибка в dropzone, его нужно было в if засунуть


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


30:1: I201 Missing newline before sections or imports.
31:1: I100 Imports statements are in the wrong order. import logging should be before from six
31:1: I201 Missing newline before sections or imports.
33:1: I201 Missing newline before sections or imports.
34:1: I101 Imported names are in the wrong order. Should be current_app, has_app_context
34:1: I100 Imports statements are in the wrong order. from flask should be before import six
34:1: I201 Missing newline before sections or imports.
35:1: I100 Imports statements are in the wrong order. from functools should be before from flask
35:1: I201 Missing newline before sections or imports.
35:1: F401 'wraps' imported but unused
36:1: I101 Imported names are in the wrong order. Should be find_modules, import_string
36:1: I201 Missing newline before sections or imports.
111:13: B901 blind except: statement
224:1: E302 expected 2 blank lines, found 1
228: D102 Missing docstring in public method
231: D102 Missing docstring in public method
239: D102 Missing docstring in public method
242: D102 Missing docstring in public method
246: D401 First line should be in imperative mood ('Run', not 'Runs')
298:23: E222 multiple spaces after operator


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: legacy


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: elasticsearch


1: M100 needs more reviewers
1: M101 signature is missing


32: D103 Missing docstring in public function
43: D103 Missing docstring in public function
47: D103 Missing docstring in public function


1: M111 unrecognized component name: elasticsearch


> All default credential providers only support retrieving the token.

It's rather unclear to me what you mean by this. Consider rephrasing?


32:1: I100 Imports statements are in the wrong order. from itertools should be before import pkg_resources


1: D210 No whitespaces allowed surrounding docstring text
1: D400 First line should end with a period (not 's')
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. import math should be before import time
26:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. import cgi should be before import shutil
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: I201 Missing newline before sections or imports.
32:1: E402 module level import not at top of file
36:1: I101 Imported names are in the wrong order. Should be datetime_format, run_sql
36:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from six
36:1: E402 module level import not at top of file
37:1: I101 Imported names are in the wrong order. Should be CFG_COMMENTSDIR, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBALERT_ALERT_ENGINE_EMAIL, CFG_WEBCOMMENT_ADMIN_NOTIFICATION_LEVEL, CFG_WEBCOMMENT_ALERT_ENGINE_EMAIL, CFG_WEBCOMMENT_ALLOW_COMMENTS, CFG_WEBCOMMENT_ALLOW_REVIEWS, CFG_WEBCOMMENT_ALLOW_SHORT_REVIEWS, CFG_WEBCOMMENT_DEFAULT_MODERATOR, CFG_WEBCOMMENT_EMAIL_REPLIES_TO, CFG_WEBCOMMENT_MAX_COMMENT_THREAD_DEPTH, CFG_WEBCOMMENT_NB_REPORTS_BEFORE_SEND_EMAIL_TO_ADMIN, CFG_WEBCOMMENT_RESTRICTION_DATAFIELD, CFG_WEBCOMMENT_ROUND_DATAFIELD, CFG_WEBCOMMENT_TIMELIMIT_PROCESSING_COMMENTS_IN_SECONDS
37:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.dbquery
37:1: E402 module level import not at top of file
56:1: E402 module level import not at top of file
59:1: I100 Imports statements are in the wrong order. from invenio.utils.html should be before from invenio.utils.mail
59:1: E402 module level import not at top of file
60:1: I101 Imported names are in the wrong order. Should be collect_user_info, get_email, get_user_info
60:1: I100 Imports statements are in the wrong order. from invenio.legacy.webuser should be before from invenio.utils.html
60:1: E402 module level import not at top of file
61:1: I101 Imported names are in the wrong order. Should be convert_datestruct_to_datetext, convert_datetext_to_dategui, datetext_default
61:1: E402 module level import not at top of file
62:29: E126 continuation line over-indented for hanging indent
64:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.utils.date
64:1: E402 module level import not at top of file
65:1: E402 module level import not at top of file
66:1: I101 Imported names are in the wrong order. Should be gettext_set_language, wash_language
66:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.ext.logging
66:1: E402 module level import not at top of file
67:1: E402 module level import not at top of file
68:1: I201 Missing newline before sections or imports.
68:1: E402 module level import not at top of file
71:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from .config
71:1: E402 module level import not at top of file
72:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, guess_primary_collection_of_a_record
72:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.modules.access.engine
72:1: E402 module level import not at top of file
75:1: E402 module level import not at top of file
76:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.collections.cache
76:1: E402 module level import not at top of file
77:1: E402 module level import not at top of file
81:1: B901 blind except: statement
85: D401 First line should be in imperative mood ('Return', not 'Returns')
85: D205 1 blank line required between summary line and description (found 0)
140:29: E271 multiple spaces after keyword
216:33: E261 at least two spaces before inline comment
217:15: E271 multiple spaces after keyword
218:49: E203 whitespace before ':'
220:49: E203 whitespace before ':'
220:51: E202 whitespace before ']'
221:14: E261 at least two spaces before inline comment
235:79: E261 at least two spaces before inline comment
242:8: E114 indentation is not a multiple of four (comment)
321:84: E502 the backslash is redundant between brackets
321:84: E251 unexpected spaces around keyword / parameter equals
323:88: E502 the backslash is redundant between brackets
323:88: E251 unexpected spaces around keyword / parameter equals
328:1: E302 expected 2 blank lines, found 1
328: D400 First line should end with a period (not 'w')
328: D205 1 blank line required between summary line and description (found 0)
354:1: E302 expected 2 blank lines, found 1
354: D210 No whitespaces allowed surrounding docstring text
354: D400 First line should end with a period (not 's')
354: D205 1 blank line required between summary line and description (found 0)
383:1: E302 expected 2 blank lines, found 1
383: D210 No whitespaces allowed surrounding docstring text
383: D400 First line should end with a period (not 's')
383: D205 1 blank line required between summary line and description (found 0)
406:1: E302 expected 2 blank lines, found 1
406: D210 No whitespaces allowed surrounding docstring text
406: D401 First line should be in imperative mood ('Check', not 'Checks')
406: D400 First line should end with a period (not 'd')
406: D205 1 blank line required between summary line and description (found 0)
428:1: E302 expected 2 blank lines, found 1
428: D400 First line should end with a period (not 'n')
428: D200 One-line docstring should fit on one line with quotes (found 3)
437:1: E302 expected 2 blank lines, found 1
437: D200 One-line docstring should fit on one line with quotes (found 3)
443:10: E222 multiple spaces after operator
445:49: E231 missing whitespace after ','
448:1: E302 expected 2 blank lines, found 1
448: D205 1 blank line required between summary line and description (found 0)
512:17: E127 continuation line over-indented for visual indent
512:18: E201 whitespace after '{'
512:44: E203 whitespace before ':'
513:44: E203 whitespace before ':'
514:44: E203 whitespace before ':'
515:44: E203 whitespace before ':'
516:44: E203 whitespace before ':'
517:44: E203 whitespace before ':'
518:80: E502 the backslash is redundant between brackets
518:44: E203 whitespace before ':'
519:47: E127 continuation line over-indented for visual indent
519:130: E502 the backslash is redundant between brackets
521:44: E203 whitespace before ':'
522:44: E203 whitespace before ':'
523:44: E203 whitespace before ':'
524:44: E203 whitespace before ':'
525:80: E502 the backslash is redundant between brackets
525:44: E203 whitespace before ':'
527:44: E203 whitespace before ':'
528:44: E203 whitespace before ':'
528:65: E225 missing whitespace around operator
528:84: E225 missing whitespace around operator
529:44: E203 whitespace before ':'
529:64: E261 at least two spaces before inline comment
529:65: E262 inline comment should start with '# '
530:17: E124 closing bracket does not match visual indentation
538:1: E302 expected 2 blank lines, found 1
538: D210 No whitespaces allowed surrounding docstring text
538: D401 First line should be in imperative mood ('Check', not 'Checks')
538: D400 First line should end with a period (not 't')
538: D205 1 blank line required between summary line and description (found 0)
560:1: E302 expected 2 blank lines, found 1
560: D400 First line should end with a period (not 'n')
560: D205 1 blank line required between summary line and description (found 0)
569:28: E127 continuation line over-indented for visual indent
570:24: E127 continuation line over-indented for visual indent
580: D400 First line should end with a period (not 'r')
580: D205 1 blank line required between summary line and description (found 0)
603:1: E302 expected 2 blank lines, found 1
603: D400 First line should end with a period (not 't')
603: D205 1 blank line required between summary line and description (found 0)
615:28: E127 continuation line over-indented for visual indent
616:24: E127 continuation line over-indented for visual indent
628:17: E225 missing whitespace around operator
633:1: E302 expected 2 blank lines, found 1
633: D400 First line should end with a period (not 't')
633: D205 1 blank line required between summary line and description (found 0)
654:1: E302 expected 2 blank lines, found 1
654: D400 First line should end with a period (not 'n')
654: D205 1 blank line required between summary line and description (found 0)
666:17: E225 missing whitespace around operator
679:1: E302 expected 2 blank lines, found 1
679: D400 First line should end with a period (not 'n')
679: D205 1 blank line required between summary line and description (found 0)
701:22: E201 whitespace after '{'
701:31: E203 whitespace before ':'
701:17: E222 multiple spaces after operator
702:31: E203 whitespace before ':'
703:31: E203 whitespace before ':'
704:31: E203 whitespace before ':'
705:31: E203 whitespace before ':'
706:31: E203 whitespace before ':'
707:21: E124 closing bracket does not match visual indentation
713:9: B901 blind except: statement
723:5: B901 blind except: statement
730:24: E127 continuation line over-indented for visual indent
731:24: E127 continuation line over-indented for visual indent
745:38: E203 whitespace before ':'
746:23: E122 continuation line missing indentation or outdented
746:38: E203 whitespace before ':'
747:1: E128 continuation line under-indented for visual indent
748:1: E128 continuation line under-indented for visual indent
749:23: E122 continuation line missing indentation or outdented
749:38: E203 whitespace before ':'
750:16: E128 continuation line under-indented for visual indent
751:16: E128 continuation line under-indented for visual indent
820:1: E302 expected 2 blank lines, found 1
820: D401 First line should be in imperative mood ('Return', not 'Returns')
820: D400 First line should end with a period (not 'm')
820: D205 1 blank line required between summary line and description (found 0)
852:1: E302 expected 2 blank lines, found 1
852: D400 First line should end with a period (not 'o')
852: D205 1 blank line required between summary line and description (found 0)
860:1: E302 expected 2 blank lines, found 1
860: D400 First line should end with a period (not 'n')
860: D205 1 blank line required between summary line and description (found 0)
885:5: F841 local variable 'msg_original' is assigned to but never used
971: D400 First line should end with a period (not 'd')
971: D205 1 blank line required between summary line and description (found 0)
982:35: E127 continuation line over-indented for visual indent
1000:1: E302 expected 2 blank lines, found 1
1000: D400 First line should end with a period (not 'r')
1000: D205 1 blank line required between summary line and description (found 0)
1015:9: B901 blind except: statement
1021:1: E302 expected 2 blank lines, found 1
1021: D401 First line should be in imperative mood ('Return', not 'Returns')
1021: D400 First line should end with a period (not ')')
1033:134: E502 the backslash is redundant between brackets
1033:36: E225 missing whitespace around operator
1033:55: E225 missing whitespace around operator
1038:1: E302 expected 2 blank lines, found 1
1038: D400 First line should end with a period (not 's')
1038: D205 1 blank line required between summary line and description (found 0)
1052:5: B901 blind except: statement
1056:1: E302 expected 2 blank lines, found 1
1070:5: B901 blind except: statement
1076:1: E302 expected 2 blank lines, found 1
1076: D401 First line should be in imperative mood ('Return', not 'Returns')
1076: D400 First line should end with a period (not 's')
1076: D205 1 blank line required between summary line and description (found 0)
1098:1: E302 expected 2 blank lines, found 1
1098: D401 First line should be in imperative mood ('Return', not 'Returns')
1146:24: E713 test for membership should be 'not in'
1148:58: E502 the backslash is redundant between brackets
1153:49: E502 the backslash is redundant between brackets
1155:49: E502 the backslash is redundant between brackets
1156:72: E202 whitespace before ')'
1158:1: E302 expected 2 blank lines, found 1
1158: D205 1 blank line required between summary line and description (found 0)
1205:25: E126 continuation line over-indented for hanging indent
1209:25: E126 continuation line over-indented for hanging indent
1276:1: E302 expected 2 blank lines, found 1
1276: D401 First line should be in imperative mood ('Return', not 'Returns')
1276: D400 First line should end with a period (not 'd')
1276: D205 1 blank line required between summary line and description (found 0)
1315:1: E302 expected 2 blank lines, found 1
1315: D400 First line should end with a period (not 'n')
1315: D205 1 blank line required between summary line and description (found 0)
1334:22: E231 missing whitespace after ':'
1334:29: E231 missing whitespace after ':'
1334:36: E231 missing whitespace after ':'
1334:43: E231 missing whitespace after ':'
1338:5: B901 blind except: statement
1377:1: E302 expected 2 blank lines, found 1
1377: D401 First line should be in imperative mood ('Get', not 'Gets')
1377: D205 1 blank line required between summary line and description (found 0)
1403:5: E266 too many leading '#' for block comment
1406:19: E261 at least two spaces before inline comment
1406:20: E262 inline comment should start with '# '
1411:13: E266 too many leading '#' for block comment
1420:13: E266 too many leading '#' for block comment
1425:10: E261 at least two spaces before inline comment
1425:11: E262 inline comment should start with '# '
1451:42: E261 at least two spaces before inline comment
1455:45: E261 at least two spaces before inline comment
1479:1: E302 expected 2 blank lines, found 1
1479: D400 First line should end with a period (not 'g')
1479: D200 One-line docstring should fit on one line with quotes (found 3)
1491:70: E502 the backslash is redundant between brackets
1492:17: F812 list comprehension redefines 'comment_round_name' from line 1486
1494:1: E302 expected 2 blank lines, found 1
1494: D400 First line should end with a period (not 'n')
1494: D205 1 blank line required between summary line and description (found 0)
1508:21: E222 multiple spaces after operator
1522:1: E302 expected 2 blank lines, found 1
1522: D400 First line should end with a period (not 'k')
1522: D205 1 blank line required between summary line and description (found 0)
1568:5: F841 local variable 'actions' is assigned to but never used
1571:5: E266 too many leading '#' for block comment
1625:67: E225 missing whitespace around operator
1752:1: E302 expected 2 blank lines, found 1
1752: D401 First line should be in imperative mood ('Send', not 'Sends')
1752: D400 First line should end with a period (not 'D')
1752: D200 One-line docstring should fit on one line with quotes (found 3)
1774:28: F841 local variable 'last_login' is assigned to but never used
1783:5: B901 blind except: statement
1810:10: E201 whitespace after '{'
1810:36: E203 whitespace before ':'
1810:51: E222 multiple spaces after operator
1812:36: E203 whitespace before ':'
1812:51: E222 multiple spaces after operator
1813:36: E203 whitespace before ':'
1814:36: E203 whitespace before ':'
1815:36: E203 whitespace before ':'
1816:36: E203 whitespace before ':'
1817:36: E203 whitespace before ':'
1818:36: E203 whitespace before ':'
1819:36: E203 whitespace before ':'
1820:36: E203 whitespace before ':'
1821:36: E203 whitespace before ':'
1821:60: E231 missing whitespace after ','
1822:36: E203 whitespace before ':'
1823:37: E203 whitespace before ':'
1824:36: E203 whitespace before ':'
1825:9: E124 closing bracket does not match visual indentation
1839:1: E302 expected 2 blank lines, found 1
1839: D400 First line should end with a period (not '0')
1839: D205 1 blank line required between summary line and description (found 0)
1851:5: B901 blind except: statement
1859:26: E231 missing whitespace after ','
1898:1: E302 expected 2 blank lines, found 1
1898: D202 No blank lines allowed after function docstring (found 1)
1898: D400 First line should end with a period (not 'e')
1898: D205 1 blank line required between summary line and description (found 0)
1940:1: E302 expected 2 blank lines, found 1
1940: D401 First line should be in imperative mood ('Return', not 'Returns')
1940: D400 First line should end with a period (not 'e')
1940: D205 1 blank line required between summary line and description (found 0)
1959:1: E302 expected 2 blank lines, found 1
1959: D400 First line should end with a period (not 'n')
1959: D205 1 blank line required between summary line and description (found 0)
1971:5: E266 too many leading '#' for block comment
1972:5: E266 too many leading '#' for block comment
1976:1: E302 expected 2 blank lines, found 1
1976: D400 First line should end with a period (not ',')
1976: D205 1 blank line required between summary line and description (found 0)
1997:15: E271 multiple spaces after keyword
2000:1: E302 expected 2 blank lines, found 1
2000: D400 First line should end with a period (not 'n')
2000: D205 1 blank line required between summary line and description (found 0)
2007:5: E266 too many leading '#' for block comment
2011:1: E302 expected 2 blank lines, found 1
2011: D400 First line should end with a period (not 'e')
2011: D205 1 blank line required between summary line and description (found 0)
2027:1: E302 expected 2 blank lines, found 1
2027: D400 First line should end with a period (not 's')
2027: D205 1 blank line required between summary line and description (found 0)
2034:5: E266 too many leading '#' for block comment
2035:5: E266 too many leading '#' for block comment
2039:1: E302 expected 2 blank lines, found 1
2039: D400 First line should end with a period (not 'e')
2039: D205 1 blank line required between summary line and description (found 0)
2082:1: E302 expected 2 blank lines, found 1
2082: D400 First line should end with a period (not 'e')
2082: D200 One-line docstring should fit on one line with quotes (found 3)
2094:1: E302 expected 2 blank lines, found 1
2094: D400 First line should end with a period (not 'e')
2108:1: E302 expected 2 blank lines, found 1
2143:120: E502 the backslash is redundant between brackets
2147:141: E502 the backslash is redundant between brackets
2150:131: E502 the backslash is redundant between brackets
2156:12: E127 continuation line over-indented for visual indent
2183:5: E303 too many blank lines (2)


42: D103 Missing docstring in public function
53: D103 Missing docstring in public function
59: D103 Missing docstring in public function


1: D100 Missing docstring in public module
21: D401 First line should be in imperative mood ('Searche', not 'Searches')
21: D400 First line should end with a period (not 'd')


41:1: I100 Imports statements are in the wrong order. from tempfile should be before from invenio.legacy.search_engine


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: elasticsearch
1: M191 must not end with a dot '.'


60: D103 Missing docstring in public function
72: D103 Missing docstring in public function
83: D103 Missing docstring in public function
89: D103 Missing docstring in public function