Sorry, I provided the wrong link. I was referring to the release tarball you mentioned.

I'm running **make clean macports** to compile Mongrel 2 on my environment, and is the **clean** goal that is failing.

```
$ make clean
fatal: Not a git repository (or any of the parent directories): .git
rm -rf build bin lib src/polarssl/library/aes.o src/polarssl/library/arc4.o src/polarssl/library/asn1parse.o src/polarssl/library/asn1write.o src/polarssl/library/base64.o src/polarssl/library/bignum.o src/polarssl/library/blowfish.o src/polarssl/library/camellia.o src/polarssl/library/certs.o src/polarssl/library/cipher.o src/polarssl/library/cipher_wrap.o src/polarssl/library/ctr_drbg.o src/polarssl/library/debug.o src/polarssl/library/des.o src/polarssl/library/dhm.o src/polarssl/library/ecdh.o src/polarssl/library/ecdsa.o src/polarssl/library/ecp.o src/polarssl/library/entropy.o src/polarssl/library/entropy_poll.o src/polarssl/library/error.o src/polarssl/library/gcm.o src/polarssl/library/havege.o src/polarssl/library/md.o src/polarssl/library/md2.o src/polarssl/library/md4.o src/polarssl/library/md5.o src/polarssl/library/md_wrap.o src/polarssl/library/memory.o src/polarssl/library/memory_buffer_alloc.o src/polarssl/library/net.o src/polarssl/library/oid.o src/polarssl/library/padlock.o src/polarssl/library/pbkdf2.o src/polarssl/library/pem.o src/polarssl/library/pk.o src/polarssl/library/pk_wrap.o src/polarssl/library/pkcs11.o src/polarssl/library/pkcs12.o src/polarssl/library/pkcs5.o src/polarssl/library/pkparse.o src/polarssl/library/pkwrite.o src/polarssl/library/rsa.o src/polarssl/library/sha1.o src/polarssl/library/sha256.o src/polarssl/library/sha512.o src/polarssl/library/ssl_cache.o src/polarssl/library/ssl_ciphersuites.o src/polarssl/library/ssl_cli.o src/polarssl/library/ssl_srv.o src/polarssl/library/ssl_tls.o src/polarssl/library/threading.o src/polarssl/library/timing.o src/polarssl/library/version.o src/polarssl/library/x509.o src/polarssl/library/x509_create.o src/polarssl/library/x509_crl.o src/polarssl/library/x509_crt.o src/polarssl/library/x509_csr.o src/polarssl/library/x509write_crt.o src/polarssl/library/x509write_csr.o src/polarssl/library/xtea.o src/adt/darray.o src/adt/dict.o src/adt/hash.o src/adt/list.o src/adt/radixmap.o src/adt/tst.o src/bstr/bsafe.o src/bstr/bstraux.o src/bstr/bstrlib.o src/config/config.o src/config/db.o src/config/module.o src/http11/http11_parser.o src/http11/httpclient_parser.o src/mem/halloc.o src/task/context.o src/task/fd.o src/task/net.o src/task/qlock.o src/task/rendez.o src/task/task.o src/bsd_specific.o src/cache.o src/connection.o src/control.o src/dbg.o src/dir.o src/filter.o src/handler.o src/handler_parser.o src/headers.o src/host.o src/io.o src/log.o src/logrotate.o src/mime.o src/mongrel2.o src/pattern.o src/proxy.o src/register.o src/request.o src/response.o src/routing.o src/server.o src/setting.o src/state.o src/superpoll.o src/tnetstrings.o src/unixy.o src/upload.o src/websocket.o src/xrequest.o src/state.o src/http11/http11_parser.o src/task/asm.o tests/bstr_tests tests/cache_tests tests/cert_tests tests/config_tests tests/connection_tests tests/darray_tests tests/db_tests tests/dict_tests tests/dir_tests tests/filter_tests tests/handler_parser_tests tests/handler_tests tests/hash_tests tests/host_tests tests/http11_tests tests/httpclient_tests tests/io_tests tests/list_tests tests/mime_tests tests/pattern_tests tests/proxy_tests tests/radixmap_tests tests/register_tests tests/request_tests tests/response_tests tests/routing_tests tests/server_tests tests/setting_tests tests/state_tests tests/superpoll_tests tests/tnetstrings_tests tests/tst_tests tests/unixy_tests tests/config.sqlite
rm -f tests/perf.log
rm -f tests/test.pid
rm -f tests/tests.log
rm -f tests/empty.sqlite
rm -f tools/lemon/lemon
rm -f tools/m2sh/tests/tests.log
find . \( -name "*.gcno" -o -name "*.gcda" \) -exec rm {} \;
git -C src/polarssl checkout include/polarssl/config.h
fatal: Not a git repository: ../../.git/modules/src/polarssl
make: *** [clean] Error 128
```


id? name?


:dancer: np. thanks!


Misunderstand of Java convention on my part I'm afraid! Will be fixed in the next commit.


another ack


@stefwalter this fixes the dialog issue you see while adding nodes.
Thanks for catching it


@Aktron: Please send him this pad: https://titanpad.com/copywrongs-hr and report back if it is finished.


Pasa el move, no los valores, ya que todos se obtienen del move.


ack after privacy fixing


80: D102 Missing docstring in public method
109: D209 Multi-line docstring closing quotes should be on a separate line
109: D203 1 blank line required before class docstring (found 0)
109: D400 First line should end with a period (not 'f')
109: D205 1 blank line required between summary line and description (found 0)
115: D102 Missing docstring in public method
150:10: E126 continuation line over-indented for hanging indent
157:10: E126 continuation line over-indented for hanging indent
175: D102 Missing docstring in public method
183: D210 No whitespaces allowed surrounding docstring text
183: D209 Multi-line docstring closing quotes should be on a separate line
183: D203 1 blank line required before class docstring (found 0)
183: D400 First line should end with a period (not 'l')
183: D205 1 blank line required between summary line and description (found 0)
215: D102 Missing docstring in public method
248: D102 Missing docstring in public method


24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. import sys should be before import time
27:1: E402 module level import not at top of file
29:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. from invenio.utils.date should be before from six
31:1: E402 module level import not at top of file
38:1: I101 Imported names are in the wrong order. Should be CFG_BIBRANK_SHOW_CITATION_LINKS, CFG_CACHEDIR, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_URL, CFG_WEBCOMMENT_ALLOW_COMMENTS, CFG_WEBCOMMENT_ALLOW_REVIEWS, CFG_WEBSEARCH_SHOW_COMMENT_COUNT, CFG_WEBSEARCH_SHOW_REVIEW_COUNT
38:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.date
38:1: E402 module level import not at top of file
39:6: E126 continuation line over-indented for hanging indent
50:1: I101 Imported names are in the wrong order. Should be addadminbox, createhiddenform, get_def_name, get_languages, get_name, modify_translations, tupletotable, write_outcome
50:1: E402 module level import not at top of file
51:6: E126 continuation line over-indented for hanging indent
59:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql
59:1: E402 module level import not at top of file
60:6: E126 continuation line over-indented for hanging indent
62:1: I101 Imported names are in the wrong order. Should be external_collection_apply_changes, external_collection_get_state, external_collection_get_update_state_list, external_collection_sort_engine_by_name, external_collections_dictionary
62:1: E402 module level import not at top of file
63:6: E126 continuation line over-indented for hanging indent
68:1: E402 module level import not at top of file
69:6: E126 continuation line over-indented for hanging indent
70:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch_external_collections.config should be before from invenio.legacy.websearch_external_collections.utils
70:1: E402 module level import not at top of file
73:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.websearch_external_collections.config
73:1: E402 module level import not at top of file
74:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.bibdocfile.api
74:1: E402 module level import not at top of file
76:1: E402 module level import not at top of file
77:1: E402 module level import not at top of file
78:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.local_config
78:1: E402 module level import not at top of file
79:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.ext.logging
79:1: I201 Missing newline before sections or imports.
79:1: E402 module level import not at top of file
80:1: I201 Missing newline before sections or imports.
80:1: E402 module level import not at top of file
81:1: E402 module level import not at top of file
83:1: E302 expected 2 blank lines, found 1
83:25: E251 unexpected spaces around keyword / parameter equals
83:27: E251 unexpected spaces around keyword / parameter equals
83: D202 No blank lines allowed after function docstring (found 1)
83: D400 First line should end with a period (not 'l')
90:1: E302 expected 2 blank lines, found 1
90: D200 One-line docstring should fit on one line with quotes (found 3)
98:1: E302 expected 2 blank lines, found 1
98: D209 Multi-line docstring closing quotes should be on a separate line
98: D400 First line should end with a period (not 'n')
98: D205 1 blank line required between summary line and description (found 0)
130:17: E221 multiple spaces before operator
155:41: F841 local variable 'e' is assigned to but never used
181:1: E302 expected 2 blank lines, found 1
181: D209 Multi-line docstring closing quotes should be on a separate line
181: D202 No blank lines allowed after function docstring (found 1)
181: D400 First line should end with a period (not 'n')
181: D205 1 blank line required between summary line and description (found 0)
190:5: F841 local variable 'rnk_dict' is assigned to but never used
199:15: E221 multiple spaces before operator
219:17: E221 multiple spaces before operator
225:172: E203 whitespace before ','
242:17: E221 multiple spaces before operator
249:172: E203 whitespace before ','
271:1: E302 expected 2 blank lines, found 1
271: D209 Multi-line docstring closing quotes should be on a separate line
271: D202 No blank lines allowed after function docstring (found 1)
271: D205 1 blank line required between summary line and description (found 0)
301:49: E225 missing whitespace around operator
306:5: F841 local variable 'tree' is assigned to but never used
318:75: E225 missing whitespace around operator
328:27: E225 missing whitespace around operator
339:18: E225 missing whitespace around operator
339:64: E225 missing whitespace around operator
356:1: E302 expected 2 blank lines, found 1
356: D209 Multi-line docstring closing quotes should be on a separate line
356: D202 No blank lines allowed after function docstring (found 1)
356: D205 1 blank line required between summary line and description (found 0)
388:1: E302 expected 2 blank lines, found 1
388: D209 Multi-line docstring closing quotes should be on a separate line
388: D202 No blank lines allowed after function docstring (found 1)
388: D205 1 blank line required between summary line and description (found 0)
393:11: E221 multiple spaces before operator
407:9: F841 local variable 'vir_sons' is assigned to but never used
444:1: E302 expected 2 blank lines, found 1
444: D209 Multi-line docstring closing quotes should be on a separate line
444: D202 No blank lines allowed after function docstring (found 1)
444: D205 1 blank line required between summary line and description (found 0)
459:5: F841 local variable 'fin_output' is assigned to but never used
468:30: E225 missing whitespace around operator
471:30: E225 missing whitespace around operator
477:30: E225 missing whitespace around operator
480:91: E231 missing whitespace after ','
480:30: E225 missing whitespace around operator
486:44: E225 missing whitespace around operator
486:112: E225 missing whitespace around operator
489:34: E225 missing whitespace around operator
508:48: E225 missing whitespace around operator
511:38: E225 missing whitespace around operator
521:36: E225 missing whitespace around operator
539:94: E225 missing whitespace around operator
544:55: E225 missing whitespace around operator
544:151: E225 missing whitespace around operator
565:44: E225 missing whitespace around operator
565:131: E225 missing whitespace around operator
568:44: E225 missing whitespace around operator
568:131: E225 missing whitespace around operator
574:29: F841 local variable 'e' is assigned to but never used
605:1: E302 expected 2 blank lines, found 1
605: D202 No blank lines allowed after function docstring (found 1)
605: D400 First line should end with a period (not 'y')
632:1: E302 expected 2 blank lines, found 1
632: D209 Multi-line docstring closing quotes should be on a separate line
632: D202 No blank lines allowed after function docstring (found 1)
632: D400 First line should end with a period (not 'x')
632: D205 1 blank line required between summary line and description (found 0)
637:5: F841 local variable 'col_dict' is assigned to but never used
659:15: E221 multiple spaces before operator
666:1: E302 expected 2 blank lines, found 1
666: D209 Multi-line docstring closing quotes should be on a separate line
666: D202 No blank lines allowed after function docstring (found 1)
666: D205 1 blank line required between summary line and description (found 0)
675:11: E221 multiple spaces before operator
681:5: F841 local variable 'col_dict' is assigned to but never used
682:5: F841 local variable 'pbx_dict' is assigned to but never used
687:13: E221 multiple spaces before operator
694:22: E126 continuation line over-indented for hanging indent
694:29: E221 multiple spaces before operator
714:72: E225 missing whitespace around operator
723:15: E221 multiple spaces before operator
731:15: E221 multiple spaces before operator
739:1: E302 expected 2 blank lines, found 1
739: D209 Multi-line docstring closing quotes should be on a separate line
739: D202 No blank lines allowed after function docstring (found 1)
739: D205 1 blank line required between summary line and description (found 0)
745:11: E221 multiple spaces before operator
752:13: F841 local variable 'pname' is assigned to but never used
758:5: F841 local variable 'col_dict' is assigned to but never used
764:13: E221 multiple spaces before operator
771:73: E221 multiple spaces before operator
787:15: E221 multiple spaces before operator
795:1: E302 expected 2 blank lines, found 1
795: D209 Multi-line docstring closing quotes should be on a separate line
795: D202 No blank lines allowed after function docstring (found 1)
795: D205 1 blank line required between summary line and description (found 0)
802:13: E221 multiple spaces before operator
803:11: E221 multiple spaces before operator
808:5: F841 local variable 'lang' is assigned to but never used
809:5: F841 local variable 'col_dict' is assigned to but never used
831:63: E225 missing whitespace around operator
880:15: E221 multiple spaces before operator
887:1: E302 expected 2 blank lines, found 1
887: D209 Multi-line docstring closing quotes should be on a separate line
887: D205 1 blank line required between summary line and description (found 0)
894:5: F841 local variable 'pbx_dict' is assigned to but never used
899:1: E302 expected 2 blank lines, found 1
899: D209 Multi-line docstring closing quotes should be on a separate line
899: D202 No blank lines allowed after function docstring (found 1)
899: D205 1 blank line required between summary line and description (found 0)
907:11: E221 multiple spaces before operator
917:8: E221 multiple spaces before operator
943:46: E225 missing whitespace around operator
943:85: E225 missing whitespace around operator
961:1: E302 expected 2 blank lines, found 1
961: D209 Multi-line docstring closing quotes should be on a separate line
961: D202 No blank lines allowed after function docstring (found 1)
961: D205 1 blank line required between summary line and description (found 0)
968:11: E221 multiple spaces before operator
996:1: E302 expected 2 blank lines, found 1
996: D209 Multi-line docstring closing quotes should be on a separate line
996: D202 No blank lines allowed after function docstring (found 1)
996: D205 1 blank line required between summary line and description (found 0)
1002:5: F841 local variable 'fmt_dict' is assigned to but never used
1007:1: E302 expected 2 blank lines, found 1
1007: D209 Multi-line docstring closing quotes should be on a separate line
1007: D202 No blank lines allowed after function docstring (found 1)
1007: D205 1 blank line required between summary line and description (found 0)
1012:5: F841 local variable 'fld_dict' is assigned to but never used
1024:1: E302 expected 2 blank lines, found 1
1024: D209 Multi-line docstring closing quotes should be on a separate line
1024: D202 No blank lines allowed after function docstring (found 1)
1024: D205 1 blank line required between summary line and description (found 0)
1029:5: F841 local variable 'name_1' is assigned to but never used
1030:5: F841 local variable 'name_2' is assigned to but never used
1035:1: E302 expected 2 blank lines, found 1
1035: D202 No blank lines allowed after function docstring (found 1)
1035: D205 1 blank line required between summary line and description (found 0)
1072:1: E302 expected 2 blank lines, found 1
1072: D202 No blank lines allowed after function docstring (found 1)
1072: D205 1 blank line required between summary line and description (found 0)
1095:31: E128 continuation line under-indented for visual indent
1096:31: E128 continuation line under-indented for visual indent
1097:31: E128 continuation line under-indented for visual indent
1098:31: E128 continuation line under-indented for visual indent
1099:31: E128 continuation line under-indented for visual indent
1100:31: E128 continuation line under-indented for visual indent
1101:31: E128 continuation line under-indented for visual indent
1103:31: E128 continuation line under-indented for visual indent
1104:31: E128 continuation line under-indented for visual indent
1105:31: E128 continuation line under-indented for visual indent
1106:31: E128 continuation line under-indented for visual indent
1107:31: E128 continuation line under-indented for visual indent
1108:31: E128 continuation line under-indented for visual indent
1109:31: E128 continuation line under-indented for visual indent
1128:1: E302 expected 2 blank lines, found 1
1128: D209 Multi-line docstring closing quotes should be on a separate line
1128: D202 No blank lines allowed after function docstring (found 1)
1128: D205 1 blank line required between summary line and description (found 0)
1144:11: E221 multiple spaces before operator
1181:1: E302 expected 2 blank lines, found 1
1181: D209 Multi-line docstring closing quotes should be on a separate line
1181: D202 No blank lines allowed after function docstring (found 1)
1181: D205 1 blank line required between summary line and description (found 0)
1188:11: E221 multiple spaces before operator
1190:5: F841 local variable 'col_dict' is assigned to but never used
1220:1: E302 expected 2 blank lines, found 1
1220: D202 No blank lines allowed after function docstring (found 1)
1220: D400 First line should end with a period (not 'y')
1220: D205 1 blank line required between summary line and description (found 0)
1227:11: E221 multiple spaces before operator
1247:1: E302 expected 2 blank lines, found 1
1247: D202 No blank lines allowed after function docstring (found 1)
1247: D400 First line should end with a period (not 'y')
1247: D205 1 blank line required between summary line and description (found 0)
1253:11: E221 multiple spaces before operator
1255:16: E222 multiple spaces after operator
1277:1: E302 expected 2 blank lines, found 1
1277: D209 Multi-line docstring closing quotes should be on a separate line
1277: D202 No blank lines allowed after function docstring (found 1)
1277: D205 1 blank line required between summary line and description (found 0)
1284:11: E221 multiple spaces before operator
1292:5: F841 local variable 'lang' is assigned to but never used
1293:10: E222 multiple spaces after operator
1294:5: F841 local variable 'col_dict' is assigned to but never used
1295:5: F841 local variable 'fld_dict' is assigned to but never used
1296:5: F841 local variable 'col_fld' is assigned to but never used
1297:14: E221 multiple spaces before operator
1298:5: F841 local variable 'fldv_dict' is assigned to but never used
1309:22: E221 multiple spaces before operator
1330:1: E302 expected 2 blank lines, found 1
1330: D209 Multi-line docstring closing quotes should be on a separate line
1330: D202 No blank lines allowed after function docstring (found 1)
1330: D205 1 blank line required between summary line and description (found 0)
1337:11: E221 multiple spaces before operator
1344:5: F841 local variable 'lang' is assigned to but never used
1345:10: E222 multiple spaces after operator
1346:5: F841 local variable 'col_dict' is assigned to but never used
1349:14: E221 multiple spaces before operator
1350:5: F841 local variable 'fldv_dict' is assigned to but never used
1354:9: E221 multiple spaces before operator
1377:15: E221 multiple spaces before operator
1390:1: E302 expected 2 blank lines, found 1
1390: D202 No blank lines allowed after function docstring (found 1)
1406:8: E221 multiple spaces before operator
1412:5: F841 local variable 'lang' is assigned to but never used
1414:5: F841 local variable 'fld_type_list' is assigned to but never used
1451:1: E302 expected 2 blank lines, found 1
1451: D202 No blank lines allowed after function docstring (found 1)
1467:8: E221 multiple spaces before operator
1473:5: F841 local variable 'lang' is assigned to but never used
1475:5: F841 local variable 'fld_type_list' is assigned to but never used
1512:1: E302 expected 2 blank lines, found 1
1512: D202 No blank lines allowed after function docstring (found 1)
1528:8: E221 multiple spaces before operator
1534:5: F841 local variable 'lang' is assigned to but never used
1536:5: F841 local variable 'fld_type_list' is assigned to but never used
1543:13: F841 local variable 'col_fld' is assigned to but never used
1574: D202 No blank lines allowed after function docstring (found 1)
1574: D400 First line should end with a period (not 'd')
1578:5: F841 local variable 'col_dict' is assigned to but never used
1590:8: E221 multiple spaces before operator
1595:5: F841 local variable 'lang' is assigned to but never used
1597:5: F841 local variable 'fld_type_list' is assigned to but never used
1636:1: E302 expected 2 blank lines, found 1
1636: D401 First line should be in imperative mood ('show', not 'shows')
1636: D209 Multi-line docstring closing quotes should be on a separate line
1636: D202 No blank lines allowed after function docstring (found 1)
1636: D400 First line should end with a period (not 'n')
1636: D205 1 blank line required between summary line and description (found 0)
1651:8: E221 multiple spaces before operator
1690:1: E302 expected 2 blank lines, found 1
1690: D103 Missing docstring in public function
1711:1: E302 expected 2 blank lines, found 1
1711: D202 No blank lines allowed after function docstring (found 1)
1737:1: E302 expected 2 blank lines, found 1
1737: D103 Missing docstring in public function
1762:1: E302 expected 2 blank lines, found 1
1762: D202 No blank lines allowed after function docstring (found 1)
1782:9: F841 local variable 'check' is assigned to but never used
1785:23: E231 missing whitespace after ':'
1786:23: E231 missing whitespace after ':'
1787:23: E231 missing whitespace after ':'
1797:1: E302 expected 2 blank lines, found 1
1800:5: F841 local variable 'changes' is assigned to but never used
1804:5: E303 too many blank lines (2)
1810:67: E502 the backslash is redundant between brackets
1812:2: E114 indentation is not a multiple of four (comment)
1812:2: E266 too many leading '#' for block comment
1828:78: E502 the backslash is redundant between brackets
1835: D209 Multi-line docstring closing quotes should be on a separate line
1835: D202 No blank lines allowed after function docstring (found 1)
1835: D205 1 blank line required between summary line and description (found 0)
1841:11: E221 multiple spaces before operator
1847:5: F841 local variable 'fmt_dict' is assigned to but never used
1848:5: F841 local variable 'col_dict' is assigned to but never used
1853:13: E221 multiple spaces before operator
1861:30: E221 multiple spaces before operator
1871:15: E221 multiple spaces before operator
1876:15: E221 multiple spaces before operator
1883:1: E302 expected 2 blank lines, found 1
1883: D209 Multi-line docstring closing quotes should be on a separate line
1883: D202 No blank lines allowed after function docstring (found 1)
1883: D205 1 blank line required between summary line and description (found 0)
1889:11: E221 multiple spaces before operator
1898:9: F841 local variable 'old_colNAME' is assigned to but never used
1903:5: F841 local variable 'col_dict' is assigned to but never used
1908:13: E221 multiple spaces before operator
1915:65: E221 multiple spaces before operator
1942:15: E221 multiple spaces before operator
1949:1: E302 expected 2 blank lines, found 1
1949: D202 No blank lines allowed after function docstring (found 1)
1949: D205 1 blank line required between summary line and description (found 0)
1956:11: E221 multiple spaces before operator
1982:1: E302 expected 2 blank lines, found 1
1982: D202 No blank lines allowed after function docstring (found 1)
1982: D200 One-line docstring should fit on one line with quotes (found 2)
1986:5: F841 local variable 'subtitle' is assigned to but never used
1990:5: F841 local variable 'output' is assigned to but never used
2001:227: E203 whitespace before ':'
2060:1: E302 expected 2 blank lines, found 1
2060: D401 First line should be in imperative mood ('Return', not 'Returns')
2060: D202 No blank lines allowed after function docstring (found 1)
2060: D400 First line should end with a period (not 'e')
2080:1: E302 expected 2 blank lines, found 1
2080: D401 First line should be in imperative mood ('Create', not 'Creates')
2080: D209 Multi-line docstring closing quotes should be on a separate line
2080: D202 No blank lines allowed after function docstring (found 1)
2080: D205 1 blank line required between summary line and description (found 0)
2092:9: F841 local variable 'move_from_id' is assigned to but never used
2121:37: F841 local variable 'e' is assigned to but never used
2196:187: E225 missing whitespace around operator
2196:267: E225 missing whitespace around operator
2196:277: E225 missing whitespace around operator
2196:375: E225 missing whitespace around operator
2196:484: E225 missing whitespace around operator
2211:1: E302 expected 2 blank lines, found 1
2211: D202 No blank lines allowed after function docstring (found 1)
2211: D400 First line should end with a period (not 'n')
2211: D205 1 blank line required between summary line and description (found 0)
2216:15: E225 missing whitespace around operator
2217:11: E221 multiple spaces before operator
2268:1: E302 expected 2 blank lines, found 1
2268: D209 Multi-line docstring closing quotes should be on a separate line
2268: D202 No blank lines allowed after function docstring (found 1)
2268: D205 1 blank line required between summary line and description (found 0)
2348:9: E271 multiple spaces after keyword
2368:1: E302 expected 2 blank lines, found 1
2368: D202 No blank lines allowed after function docstring (found 1)
2372:11: E221 multiple spaces before operator
2375:5: F841 local variable 'col_dict' is assigned to but never used
2389:5: B901 blind except: statement
2395:28: E128 continuation line under-indented for visual indent
2396:26: F841 local variable 'e' is assigned to but never used
2410:54: E225 missing whitespace around operator
2410:88: E225 missing whitespace around operator
2418:54: E225 missing whitespace around operator
2418:88: E225 missing whitespace around operator
2431:9: F841 local variable 'webcoll__update_time' is assigned to but never used
2432:54: E225 missing whitespace around operator
2432:88: E225 missing whitespace around operator
2442:54: E225 missing whitespace around operator
2442:88: E225 missing whitespace around operator
2461:1: E302 expected 2 blank lines, found 1
2461: D209 Multi-line docstring closing quotes should be on a separate line
2461: D202 No blank lines allowed after function docstring (found 1)
2461: D205 1 blank line required between summary line and description (found 0)
2466:11: E221 multiple spaces before operator
2484:1: E302 expected 2 blank lines, found 1
2484: D202 No blank lines allowed after function docstring (found 1)
2490:11: E221 multiple spaces before operator
2493:5: F841 local variable 'col_dict' is assigned to but never used
2495:13: E128 continuation line under-indented for visual indent
2497:27: E231 missing whitespace after ','
2498:13: E128 continuation line under-indented for visual indent
2499:5: F841 local variable 'rnk_list' is assigned to but never used
2510:56: E701 multiple statements on one line (colon)
2511:13: E701 multiple statements on one line (colon)
2560:1: E302 expected 2 blank lines, found 1
2560: D202 No blank lines allowed after function docstring (found 1)
2564:11: E221 multiple spaces before operator
2620:25: E126 continuation line over-indented for hanging indent
2620:36: E203 whitespace before ':'
2621:38: E203 whitespace before ':'
2634:29: E126 continuation line over-indented for hanging indent
2634:40: E203 whitespace before ':'
2635:42: E203 whitespace before ':'
2636:35: E203 whitespace before ':'
2637:39: E203 whitespace before ':'
2638:36: E203 whitespace before ':'
2639:33: E203 whitespace before ':'
2646:29: E126 continuation line over-indented for hanging indent
2646:40: E203 whitespace before ':'
2647:42: E203 whitespace before ':'
2660:29: E126 continuation line over-indented for hanging indent
2660:40: E203 whitespace before ':'
2661:42: E203 whitespace before ':'
2662:35: E203 whitespace before ':'
2663:39: E203 whitespace before ':'
2664:36: E203 whitespace before ':'
2665:33: E203 whitespace before ':'
2672:29: E126 continuation line over-indented for hanging indent
2672:40: E203 whitespace before ':'
2673:42: E203 whitespace before ':'
2681:25: E126 continuation line over-indented for hanging indent
2681:36: E203 whitespace before ':'
2682:38: E203 whitespace before ':'
2693:1: E302 expected 2 blank lines, found 1
2697:1: E302 expected 2 blank lines, found 1
2697: D401 First line should be in imperative mood ('Return', not 'Returns')
2697: D209 Multi-line docstring closing quotes should be on a separate line
2697: D202 No blank lines allowed after function docstring (found 1)
2697: D400 First line should end with a period (not 'n')
2697: D205 1 blank line required between summary line and description (found 0)
2717:17: F841 local variable 'score' is assigned to but never used
2731:29: F841 local variable 'e' is assigned to but never used
2735:1: E302 expected 2 blank lines, found 1
2735: D209 Multi-line docstring closing quotes should be on a separate line
2735: D202 No blank lines allowed after function docstring (found 1)
2735: D400 First line should end with a period (not ')')
2735: D205 1 blank line required between summary line and description (found 0)
2754:1: E302 expected 2 blank lines, found 1
2754: D202 No blank lines allowed after function docstring (found 1)
2754: D400 First line should end with a period (not 's')
2759:1: E302 expected 2 blank lines, found 1
2759:31: E251 unexpected spaces around keyword / parameter equals
2759:33: E251 unexpected spaces around keyword / parameter equals
2759: D401 First line should be in imperative mood ('Return', not 'Returns')
2759: D209 Multi-line docstring closing quotes should be on a separate line
2759: D202 No blank lines allowed after function docstring (found 1)
2759: D205 1 blank line required between summary line and description (found 0)
2780:1: E302 expected 2 blank lines, found 1
2780:42: E251 unexpected spaces around keyword / parameter equals
2780:44: E251 unexpected spaces around keyword / parameter equals
2780: D401 First line should be in imperative mood ('Return', not 'Returns')
2780: D209 Multi-line docstring closing quotes should be on a separate line
2780: D202 No blank lines allowed after function docstring (found 1)
2780: D205 1 blank line required between summary line and description (found 0)
2801:1: E302 expected 2 blank lines, found 1
2801: D401 First line should be in imperative mood ('Return', not 'Returns')
2801: D209 Multi-line docstring closing quotes should be on a separate line
2801: D202 No blank lines allowed after function docstring (found 1)
2801: D400 First line should end with a period (not 'n')
2801: D205 1 blank line required between summary line and description (found 0)
2811:1: E302 expected 2 blank lines, found 1
2811: D210 No whitespaces allowed surrounding docstring text
2811: D401 First line should be in imperative mood ('Return', not 'Returns')
2811: D209 Multi-line docstring closing quotes should be on a separate line
2811: D202 No blank lines allowed after function docstring (found 1)
2811: D400 First line should end with a period (not 'o')
2811: D205 1 blank line required between summary line and description (found 0)
2820:29: F841 local variable 'e' is assigned to but never used
2823:1: E302 expected 2 blank lines, found 1
2823: D401 First line should be in imperative mood ('Return', not 'Returns')
2823: D202 No blank lines allowed after function docstring (found 1)
2823: D400 First line should end with a period (not 's')
2829:1: E302 expected 2 blank lines, found 1
2829:25: E251 unexpected spaces around keyword / parameter equals
2829:27: E251 unexpected spaces around keyword / parameter equals
2829: D401 First line should be in imperative mood ('Return', not 'Returns')
2829: D202 No blank lines allowed after function docstring (found 1)
2829: D400 First line should end with a period (not 'e')
2841:1: E302 expected 2 blank lines, found 1
2841: D401 First line should be in imperative mood ('Return', not 'Returns')
2841: D202 No blank lines allowed after function docstring (found 1)
2841: D400 First line should end with a period (not 'x')
2853:1: E302 expected 2 blank lines, found 1
2853: D202 No blank lines allowed after function docstring (found 1)
2853: D400 First line should end with a period (not 's')
2862:1: E302 expected 2 blank lines, found 1
2862: D202 No blank lines allowed after function docstring (found 1)
2862: D400 First line should end with a period (not 's')
2869:1: E302 expected 2 blank lines, found 1
2869: D202 No blank lines allowed after function docstring (found 1)
2869: D400 First line should end with a period (not 's')
2876:1: E302 expected 2 blank lines, found 1
2876: D202 No blank lines allowed after function docstring (found 1)
2876: D400 First line should end with a period (not 's')
2883:1: E302 expected 2 blank lines, found 1
2883: D202 No blank lines allowed after function docstring (found 1)
2883: D400 First line should end with a period (not 'n')
2892:1: E302 expected 2 blank lines, found 1
2892: D202 No blank lines allowed after function docstring (found 1)
2892: D400 First line should end with a period (not 'n')
2901:1: E302 expected 2 blank lines, found 1
2901: D209 Multi-line docstring closing quotes should be on a separate line
2901: D202 No blank lines allowed after function docstring (found 1)
2901: D205 1 blank line required between summary line and description (found 0)
2920:1: E302 expected 2 blank lines, found 1
2920: D209 Multi-line docstring closing quotes should be on a separate line
2920: D202 No blank lines allowed after function docstring (found 1)
2920: D205 1 blank line required between summary line and description (found 0)
2943:1: E302 expected 2 blank lines, found 1
2943: D209 Multi-line docstring closing quotes should be on a separate line
2943: D202 No blank lines allowed after function docstring (found 1)
2943: D400 First line should end with a period (not 'n')
2943: D205 1 blank line required between summary line and description (found 0)
2949:9: F841 local variable 'res' is assigned to but never used
2955:1: E302 expected 2 blank lines, found 1
2955: D209 Multi-line docstring closing quotes should be on a separate line
2955: D202 No blank lines allowed after function docstring (found 1)
2955: D400 First line should end with a period (not 'n')
2955: D205 1 blank line required between summary line and description (found 0)
2961:9: F841 local variable 'res' is assigned to but never used
2967:1: E302 expected 2 blank lines, found 1
2967: D103 Missing docstring in public function
2972:9: F841 local variable 'res' is assigned to but never used
2978:1: E302 expected 2 blank lines, found 1
2978: D209 Multi-line docstring closing quotes should be on a separate line
2978: D202 No blank lines allowed after function docstring (found 1)
2978: D205 1 blank line required between summary line and description (found 0)
3000:1: E302 expected 2 blank lines, found 1
3000: D401 First line should be in imperative mood ('Remove', not 'Removes')
3000: D209 Multi-line docstring closing quotes should be on a separate line
3000: D202 No blank lines allowed after function docstring (found 1)
3000: D205 1 blank line required between summary line and description (found 0)
3007:9: F841 local variable 'res' is assigned to but never used
3013:1: E302 expected 2 blank lines, found 1
3013: D401 First line should be in imperative mood ('Remove', not 'Removes')
3013: D209 Multi-line docstring closing quotes should be on a separate line
3013: D202 No blank lines allowed after function docstring (found 1)
3013: D205 1 blank line required between summary line and description (found 0)
3019:9: F841 local variable 'res' is assigned to but never used
3025:1: E302 expected 2 blank lines, found 1
3025: D401 First line should be in imperative mood ('Remove', not 'Removes')
3025: D209 Multi-line docstring closing quotes should be on a separate line
3025: D202 No blank lines allowed after function docstring (found 1)
3025: D205 1 blank line required between summary line and description (found 0)
3039:9: F841 local variable 'res' is assigned to but never used
3045:1: E302 expected 2 blank lines, found 1
3045: D401 First line should be in imperative mood ('Delete', not 'Deletes')
3045: D209 Multi-line docstring closing quotes should be on a separate line
3045: D202 No blank lines allowed after function docstring (found 1)
3045: D400 First line should end with a period (not 'e')
3045: D205 1 blank line required between summary line and description (found 0)
3051:9: F841 local variable 'res' is assigned to but never used
3057:1: E302 expected 2 blank lines, found 1
3057: D401 First line should be in imperative mood ('Delete', not 'Deletes')
3057: D209 Multi-line docstring closing quotes should be on a separate line
3057: D202 No blank lines allowed after function docstring (found 1)
3057: D400 First line should end with a period (not 'x')
3057: D205 1 blank line required between summary line and description (found 0)
3063:9: F841 local variable 'res' is assigned to but never used
3069:1: E302 expected 2 blank lines, found 1
3069: D401 First line should be in imperative mood ('Delete', not 'Deletes')
3069: D209 Multi-line docstring closing quotes should be on a separate line
3069: D202 No blank lines allowed after function docstring (found 1)
3069: D400 First line should end with a period (not 't')
3069: D205 1 blank line required between summary line and description (found 0)
3076:9: F841 local variable 'res' is assigned to but never used
3082:1: E302 expected 2 blank lines, found 1
3082: D401 First line should be in imperative mood ('Delete', not 'Deletes')
3082: D209 Multi-line docstring closing quotes should be on a separate line
3082: D202 No blank lines allowed after function docstring (found 1)
3082: D400 First line should end with a period (not 'n')
3082: D205 1 blank line required between summary line and description (found 0)
3094:9: F841 local variable 'res' is assigned to but never used
3100:1: E302 expected 2 blank lines, found 1
3100: D209 Multi-line docstring closing quotes should be on a separate line
3100: D202 No blank lines allowed after function docstring (found 1)
3100: D205 1 blank line required between summary line and description (found 0)
3109:9: F841 local variable 'res' is assigned to but never used
3116:1: E302 expected 2 blank lines, found 1
3116: D209 Multi-line docstring closing quotes should be on a separate line
3116: D202 No blank lines allowed after function docstring (found 1)
3116: D400 First line should end with a period (not 'e')
3116: D205 1 blank line required between summary line and description (found 0)
3124:9: F841 local variable 'res' is assigned to but never used
3130:1: E302 expected 2 blank lines, found 1
3130: D209 Multi-line docstring closing quotes should be on a separate line
3130: D202 No blank lines allowed after function docstring (found 1)
3130: D400 First line should end with a period (not 'e')
3130: D205 1 blank line required between summary line and description (found 0)
3148:1: E302 expected 2 blank lines, found 1
3148: D103 Missing docstring in public function
3160:1: E302 expected 2 blank lines, found 1
3160: D401 First line should be in imperative mood ('Add', not 'Adds')
3160: D209 Multi-line docstring closing quotes should be on a separate line
3160: D400 First line should end with a period (not 'e')
3160: D205 1 blank line required between summary line and description (found 0)
3172:35: E231 missing whitespace after ','
3175:35: E231 missing whitespace after ','
3177:9: F841 local variable 'res' is assigned to but never used
3187:1: E302 expected 2 blank lines, found 1
3187: D209 Multi-line docstring closing quotes should be on a separate line
3187: D202 No blank lines allowed after function docstring (found 1)
3187: D205 1 blank line required between summary line and description (found 0)
3210:1: E302 expected 2 blank lines, found 1
3210: D209 Multi-line docstring closing quotes should be on a separate line
3210: D202 No blank lines allowed after function docstring (found 1)
3210: D205 1 blank line required between summary line and description (found 0)
3231:1: E302 expected 2 blank lines, found 1
3231: D209 Multi-line docstring closing quotes should be on a separate line
3231: D202 No blank lines allowed after function docstring (found 1)
3231: D205 1 blank line required between summary line and description (found 0)
3271:1: E302 expected 2 blank lines, found 1
3271: D209 Multi-line docstring closing quotes should be on a separate line
3271: D205 1 blank line required between summary line and description (found 0)
3279:9: F841 local variable 'res' is assigned to but never used
3285:1: E302 expected 2 blank lines, found 1
3285: D209 Multi-line docstring closing quotes should be on a separate line
3285: D202 No blank lines allowed after function docstring (found 1)
3285: D400 First line should end with a period (not 'x')
3285: D205 1 blank line required between summary line and description (found 0)
3303:13: F841 local variable 'res' is assigned to but never used
3309:1: E302 expected 2 blank lines, found 1
3309: D209 Multi-line docstring closing quotes should be on a separate line
3309: D202 No blank lines allowed after function docstring (found 1)
3309: D400 First line should end with a period (not 'e')
3309: D205 1 blank line required between summary line and description (found 0)
3322:13: F841 local variable 'res' is assigned to but never used
3328:1: E302 expected 2 blank lines, found 1
3328: D209 Multi-line docstring closing quotes should be on a separate line
3328: D202 No blank lines allowed after function docstring (found 1)
3328: D400 First line should end with a period (not 'e')
3328: D205 1 blank line required between summary line and description (found 0)
3341:13: F841 local variable 'res' is assigned to but never used
3347:1: E302 expected 2 blank lines, found 1
3347: D209 Multi-line docstring closing quotes should be on a separate line
3347: D202 No blank lines allowed after function docstring (found 1)
3347: D205 1 blank line required between summary line and description (found 0)
3359:9: F841 local variable 'res' is assigned to but never used
3365:1: E302 expected 2 blank lines, found 1
3365: D209 Multi-line docstring closing quotes should be on a separate line
3365: D202 No blank lines allowed after function docstring (found 1)
3365: D205 1 blank line required between summary line and description (found 0)
3377:9: F841 local variable 'res' is assigned to but never used
3383:1: E302 expected 2 blank lines, found 1
3383: D401 First line should be in imperative mood ('Return', not 'Returns')
3383: D400 First line should end with a period (not 'e')
3383: D205 1 blank line required between summary line and description (found 0)
3401:24: E203 whitespace before ':'
3403:24: E203 whitespace before ':'
3404:24: E203 whitespace before ':'
3405:24: E203 whitespace before ':'
3406:24: E203 whitespace before ':'
3407:24: E203 whitespace before ':'
3408:24: E203 whitespace before ':'
3409:24: E203 whitespace before ':'
3410:24: E203 whitespace before ':'
3411:24: E203 whitespace before ':'
3414:74: E502 the backslash is redundant between brackets
3421:50: E703 statement ends with a semicolon
3444:9: E266 too many leading '#' for block comment
3445:9: E266 too many leading '#' for block comment
3446:9: E266 too many leading '#' for block comment
3447:9: E266 too many leading '#' for block comment
3448:9: E266 too many leading '#' for block comment
3449:9: E266 too many leading '#' for block comment
3454:9: E266 too many leading '#' for block comment
3455:9: E266 too many leading '#' for block comment
3456:9: E266 too many leading '#' for block comment
3457:9: E266 too many leading '#' for block comment
3464:25: E261 at least two spaces before inline comment
3466:41: E713 test for membership should be 'not in'
3477:14: E222 multiple spaces after operator
3500:1: E303 too many blank lines (3)
3500: D401 First line should be in imperative mood ('return', not 'returns')
3500: D400 First line should end with a period (not 't')
3505:1: E302 expected 2 blank lines, found 1
3505: D401 First line should be in imperative mood ('Return', not 'Returns')
3505: D202 No blank lines allowed after function docstring (found 1)
3505: D400 First line should end with a period (not 's')
3505: D205 1 blank line required between summary line and description (found 0)
3518:21: E261 at least two spaces before inline comment
3518:22: E262 inline comment should start with '# '
3519:20: E261 at least two spaces before inline comment
3519:21: E262 inline comment should start with '# '
3520:33: E203 whitespace before ':'
3521:33: E203 whitespace before ':'
3522:33: E203 whitespace before ':'
3523:30: E203 whitespace before ':'
3524:29: E203 whitespace before ':'
3535:26: E261 at least two spaces before inline comment
3535:26: E262 inline comment should start with '# '


1: D100 Missing docstring in public module
20:1: E402 module level import not at top of file
21:1: I100 Imports statements are in the wrong order. import cgi should be before import urllib
21:1: E402 module level import not at top of file
23:1: E402 module level import not at top of file
24:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_CERN_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBSEARCH_MAX_RECORDS_IN_GROUPS, CFG_WEBSESSION_ADDRESS_ACTIVATION_EXPIRE_IN_DAYS, CFG_WEBSESSION_RESET_PASSWORD_EXPIRE_IN_DAYS
24:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
24:1: E402 module level import not at top of file
25:6: E126 continuation line over-indented for hanging indent
40:1: I101 Imported names are in the wrong order. Should be create_html_link, create_url, make_canonical_urlargd
40:1: E402 module level import not at top of file
41:1: I100 Imports statements are in the wrong order. from invenio.utils.html should be before from invenio.utils.url
41:1: F401 'nmtoken_from_string' imported but unused
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.html
42:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.websession.websession_config should be before from invenio.modules.apikeys.models
44:1: E402 module level import not at top of file
47: D101 Missing docstring in public class
69:17: E225 missing whitespace around operator
70:16: E126 continuation line over-indented for hanging indent
70:25: E203 whitespace before ':'
71:25: E203 whitespace before ':'
72:25: E203 whitespace before ':'
73:25: E203 whitespace before ':'
74:14: E126 continuation line over-indented for hanging indent
78: D102 Missing docstring in public method
79:9: F841 local variable '_' is assigned to but never used
87: D102 Missing docstring in public method
97:37: E203 whitespace before ':'
98:28: E203 whitespace before ':'
99:38: E203 whitespace before ':'
100:29: E203 whitespace before ':'
101:30: E203 whitespace before ':'
103:35: E203 whitespace before ':'
108:5: E303 too many blank lines (2)
108: D401 First line should be in imperative mood ('Display', not 'Displays')
108: D202 No blank lines allowed after function docstring (found 1)
108: D400 First line should end with a period (not 'r')
134:22: E126 continuation line over-indented for hanging indent
134:36: E203 whitespace before ':'
163:31: E126 continuation line over-indented for hanging indent
168:43: E203 whitespace before ':'
196:32: E203 whitespace before ':'
197:43: E203 whitespace before ':'
198:27: E203 whitespace before ':'
199:22: E203 whitespace before ':'
201:39: E203 whitespace before ':'
204:16: E126 continuation line over-indented for hanging indent
208: D401 First line should be in imperative mood ('Display', not 'Displays')
208: D202 No blank lines allowed after function docstring (found 1)
263:17: E126 continuation line over-indented for hanging indent
263:30: E203 whitespace before ':'
264:30: E203 whitespace before ':'
265:33: E203 whitespace before ':'
266:27: E203 whitespace before ':'
268:34: E203 whitespace before ':'
268:45: E225 missing whitespace around operator
269:34: E203 whitespace before ':'
269:45: E225 missing whitespace around operator
270:28: E203 whitespace before ':'
271:28: E203 whitespace before ':'
272:26: E203 whitespace before ':'
273:23: E203 whitespace before ':'
274:29: E203 whitespace before ':'
275:24: E203 whitespace before ':'
276:33: E203 whitespace before ':'
278:38: E203 whitespace before ':'
279:13: E121 continuation line under-indented for hanging indent
318:21: E126 continuation line over-indented for hanging indent
318:34: E203 whitespace before ':'
319:32: E203 whitespace before ':'
320:35: E203 whitespace before ':'
321:35: E203 whitespace before ':'
323:31: E203 whitespace before ':'
324:27: E203 whitespace before ':'
325:36: E203 whitespace before ':'
326:40: E203 whitespace before ':'
327:38: E203 whitespace before ':'
328:33: E203 whitespace before ':'
329:40: E203 whitespace before ':'
331:17: E121 continuation line under-indented for hanging indent
334:21: E128 continuation line under-indented for visual indent
334:34: E203 whitespace before ':'
336:139: E203 whitespace before ':'
337:35: E203 whitespace before ':'
340:30: E203 whitespace before ':'
340:96: E203 whitespace before ':'
344:5: E303 too many blank lines (2)
344: D400 First line should end with a period (not 'd')
362:11: E121 continuation line under-indented for hanging indent
362:26: E203 whitespace before ':'
363:32: E203 whitespace before ':'
364:32: E203 whitespace before ':'
365:37: E203 whitespace before ':'
366:21: E203 whitespace before ':'
367:21: E203 whitespace before ':'
368:28: E203 whitespace before ':'
374:5: E303 too many blank lines (2)
374: D102 Missing docstring in public method
382:11: E121 continuation line under-indented for hanging indent
382:26: E203 whitespace before ':'
383:31: E203 whitespace before ':'
387:27: E203 whitespace before ':'
388:27: E203 whitespace before ':'
389:26: E203 whitespace before ':'
394:26: E203 whitespace before ':'
395:30: E203 whitespace before ':'
401:5: E303 too many blank lines (2)
401: D102 Missing docstring in public method
409:11: E121 continuation line under-indented for hanging indent
409:26: E203 whitespace before ':'
410:26: E203 whitespace before ':'
413:23: E203 whitespace before ':'
414:19: E203 whitespace before ':'
417:23: E203 whitespace before ':'
418:19: E203 whitespace before ':'
423:30: E203 whitespace before ':'
429:5: E303 too many blank lines (2)
429:51: E251 unexpected spaces around keyword / parameter equals
429:53: E251 unexpected spaces around keyword / parameter equals
429:72: E251 unexpected spaces around keyword / parameter equals
429:74: E251 unexpected spaces around keyword / parameter equals
429:93: E251 unexpected spaces around keyword / parameter equals
429:95: E251 unexpected spaces around keyword / parameter equals
429: D102 Missing docstring in public method
441:11: E121 continuation line under-indented for hanging indent
441:26: E203 whitespace before ':'
442:36: E203 whitespace before ':'
443:27: E203 whitespace before ':'
444:30: E203 whitespace before ':'
445:25: E203 whitespace before ':'
446:28: E203 whitespace before ':'
452:25: E126 continuation line over-indented for hanging indent
452:35: E203 whitespace before ':'
453:28: E203 whitespace before ':'
454:21: E121 continuation line under-indented for hanging indent
460:17: E126 continuation line over-indented for hanging indent
460:34: E203 whitespace before ':'
461:39: E203 whitespace before ':'
463:13: E121 continuation line under-indented for hanging indent
466: D401 First line should be in imperative mood ('Display', not 'Displays')
466: D202 No blank lines allowed after function docstring (found 1)
479:256: E203 whitespace before ':'
479:280: E203 whitespace before ':'
479:302: E203 whitespace before ':'
501:20: E203 whitespace before ':'
502:19: E203 whitespace before ':'
503:11: E121 continuation line under-indented for hanging indent
507:45: E203 whitespace before ':'
508:46: E203 whitespace before ':'
509:45: E203 whitespace before ':'
511:46: E203 whitespace before ':'
515:15: E128 continuation line under-indented for visual indent
515:73: E201 whitespace after '{'
515:81: E203 whitespace before ':'
515:106: E202 whitespace before '}'
518:9: E303 too many blank lines (2)
520: D401 First line should be in imperative mood ('Display', not 'Displays')
520: D202 No blank lines allowed after function docstring (found 1)
520: D400 First line should end with a period (not 'n')
542:17: E126 continuation line over-indented for hanging indent
542:32: E203 whitespace before ':'
543:25: E128 continuation line under-indented for visual indent
544:15: E126 continuation line over-indented for hanging indent
552:22: E126 continuation line over-indented for hanging indent
552:26: E203 whitespace before ':'
553:37: E203 whitespace before ':'
554:38: E203 whitespace before ':'
555:20: E126 continuation line over-indented for hanging indent
560:11: E121 continuation line under-indented for hanging indent
560:15: E203 whitespace before ':'
561:26: E203 whitespace before ':'
562:27: E203 whitespace before ':'
568:9: E122 continuation line missing indentation or outdented
568:13: E203 whitespace before ':'
569:9: E122 continuation line missing indentation or outdented
569:23: E203 whitespace before ':'
570:9: E122 continuation line missing indentation or outdented
570:25: E203 whitespace before ':'
576:13: E122 continuation line missing indentation or outdented
576:17: E203 whitespace before ':'
577:13: E122 continuation line missing indentation or outdented
577:28: E203 whitespace before ':'
578:13: E122 continuation line missing indentation or outdented
578:31: E203 whitespace before ':'
583:11: E121 continuation line under-indented for hanging indent
583:15: E203 whitespace before ':'
584:24: E203 whitespace before ':'
585:27: E203 whitespace before ':'
592:15: E121 continuation line under-indented for hanging indent
592:27: E203 whitespace before ':'
593:30: E203 whitespace before ':'
594:13: E122 continuation line missing indentation or outdented
595:13: E122 continuation line missing indentation or outdented
604: D401 First line should be in imperative mood ('Display', not 'Displays')
604: D202 No blank lines allowed after function docstring (found 1)
604: D400 First line should end with a period (not 'e')
617:17: E225 missing whitespace around operator
619:19: E225 missing whitespace around operator
629: D401 First line should be in imperative mood ('Display', not 'Displays')
629: D202 No blank lines allowed after function docstring (found 1)
629: D400 First line should end with a period (not 'r')
652: D401 First line should be in imperative mood ('Display', not 'Displays')
652: D202 No blank lines allowed after function docstring (found 1)
652: D400 First line should end with a period (not 'e')
667:14: E225 missing whitespace around operator
678: D401 First line should be in imperative mood ('Display', not 'Displays')
678: D202 No blank lines allowed after function docstring (found 1)
678: D400 First line should end with a period (not 'e')
740:32: E128 continuation line under-indented for visual indent
746:36: E128 continuation line under-indented for visual indent
750:35: E222 multiple spaces after operator
751:36: E222 multiple spaces after operator
752:35: E128 continuation line under-indented for visual indent
757:33: E222 multiple spaces after operator
758:34: E222 multiple spaces after operator
765: D401 First line should be in imperative mood ('Display', not 'Displays')
765: D202 No blank lines allowed after function docstring (found 1)
765: D400 First line should end with a period (not 'd')
779:14: E225 missing whitespace around operator
780:15: E225 missing whitespace around operator
787:17: E203 whitespace before ':'
788:18: E203 whitespace before ':'
789:24: E203 whitespace before ':'
790:11: E121 continuation line under-indented for hanging indent
793: D202 No blank lines allowed after function docstring (found 1)
793: D400 First line should end with a period (not 't')
793: D205 1 blank line required between summary line and description (found 0)
812:17: E128 continuation line under-indented for visual indent
813:17: E128 continuation line under-indented for visual indent
814:33: E203 whitespace before ':'
814:34: E231 missing whitespace after ':'
815:30: E203 whitespace before ':'
816:35: E203 whitespace before ':'
819:21: E203 whitespace before ':'
820:19: E203 whitespace before ':'
821:17: E131 continuation line unaligned for hanging indent
822:25: E203 whitespace before ':'
823:24: E203 whitespace before ':'
825:20: E203 whitespace before ':'
826:21: E203 whitespace before ':'
830: D202 No blank lines allowed after function docstring (found 1)
830: D400 First line should end with a period (not 'e')
830: D205 1 blank line required between summary line and description (found 0)
849:17: E128 continuation line under-indented for visual indent
850:17: E128 continuation line under-indented for visual indent
851:33: E203 whitespace before ':'
851:34: E231 missing whitespace after ':'
852:30: E203 whitespace before ':'
853:35: E203 whitespace before ':'
856:21: E203 whitespace before ':'
857:19: E203 whitespace before ':'
858:17: E131 continuation line unaligned for hanging indent
859:25: E203 whitespace before ':'
860:33: E203 whitespace before ':'
862:20: E203 whitespace before ':'
863:21: E203 whitespace before ':'
867: D401 First line should be in imperative mood ('Display', not 'Displays')
867: D202 No blank lines allowed after function docstring (found 1)
867: D400 First line should end with a period (not 't')
881:14: E225 missing whitespace around operator
885: D401 First line should be in imperative mood ('Display', not 'Displays')
885: D202 No blank lines allowed after function docstring (found 1)
885: D400 First line should end with a period (not 't')
900: D401 First line should be in imperative mood ('Display', not 'Displays')
900: D202 No blank lines allowed after function docstring (found 1)
900: D400 First line should end with a period (not 't')
900: D205 1 blank line required between summary line and description (found 0)
905:9: F841 local variable '_' is assigned to but never used
909:22: E126 continuation line over-indented for hanging indent
909:26: E203 whitespace before ':'
914: D401 First line should be in imperative mood ('Display', not 'Displays')
914: D202 No blank lines allowed after function docstring (found 1)
914: D400 First line should end with a period (not 'r')
1004: D401 First line should be in imperative mood ('Display', not 'Displays')
1004: D202 No blank lines allowed after function docstring (found 1)
1004: D400 First line should end with a period (not 'k')
1050:22: E126 continuation line over-indented for hanging indent
1051:26: E203 whitespace before ':'
1052:33: E203 whitespace before ':'
1053:31: E203 whitespace before ':'
1054:29: E203 whitespace before ':'
1055:20: E126 continuation line over-indented for hanging indent
1059:21: E126 continuation line over-indented for hanging indent
1059:36: E203 whitespace before ':'
1060:25: E203 whitespace before ':'
1061:31: E203 whitespace before ':'
1062:16: E121 continuation line under-indented for hanging indent
1064:21: E126 continuation line over-indented for hanging indent
1064:36: E203 whitespace before ':'
1065:25: E203 whitespace before ':'
1066:29: E203 whitespace before ':'
1067:17: E121 continuation line under-indented for hanging indent
1070: D400 First line should end with a period (not 's')
1070: D205 1 blank line required between summary line and description (found 0)
1091: D400 First line should end with a period (not 'r')
1091: D205 1 blank line required between summary line and description (found 0)
1098:9: F841 local variable '_' is assigned to but never used
1107: D401 First line should be in imperative mood ('Display', not 'Displays')
1107: D202 No blank lines allowed after function docstring (found 1)
1107: D400 First line should end with a period (not 'l')
1111:52: E251 unexpected spaces around keyword / parameter equals
1111:54: E251 unexpected spaces around keyword / parameter equals
1132:9: F841 local variable '_' is assigned to but never used
1147:14: E225 missing whitespace around operator
1157:14: E225 missing whitespace around operator
1161:5: E303 too many blank lines (2)
1161: D202 No blank lines allowed after function docstring (found 1)
1180:9: E303 too many blank lines (2)
1181:102: E202 whitespace before ')'
1201:35: E225 missing whitespace around operator
1208:15: E225 missing whitespace around operator
1211:46: E203 whitespace before ':'
1212:44: E203 whitespace before ':'
1214:42: E231 missing whitespace after ':'
1215:43: E231 missing whitespace after ':'
1216:45: E231 missing whitespace after ':'
1218:49: E203 whitespace before ':'
1219:47: E203 whitespace before ':'
1221:45: E231 missing whitespace after ':'
1222:46: E231 missing whitespace after ':'
1223:48: E231 missing whitespace after ':'
1282:15: E225 missing whitespace around operator
1306:16: E127 continuation line over-indented for visual indent
1307:29: E231 missing whitespace after ':'
1308:16: E124 closing bracket does not match visual indentation
1312:5: E303 too many blank lines (2)
1345:15: E225 missing whitespace around operator
1359: D400 First line should end with a period (not ':')
1359: D205 1 blank line required between summary line and description (found 0)
1382:20: E225 missing whitespace around operator
1397:46: E231 missing whitespace after ','
1466:25: E203 whitespace before ':'
1469:28: E203 whitespace before ':'
1477:30: E231 missing whitespace after ':'
1478:31: E231 missing whitespace after ':'
1479:28: E231 missing whitespace after ':'
1481:30: E203 whitespace before ':'
1481:31: E231 missing whitespace after ':'
1484:16: E124 closing bracket does not match visual indentation
1487: D201 No blank lines allowed before function docstring (found 1)
1487: D205 1 blank line required between summary line and description (found 0)
1578:25: E203 whitespace before ':'
1582:25: E231 missing whitespace after ':'
1583:29: E231 missing whitespace after ':'
1586:31: E231 missing whitespace after ':'
1587:29: E203 whitespace before ':'
1587:30: E231 missing whitespace after ':'
1587:64: E231 missing whitespace after ','
1588:33: E203 whitespace before ':'
1589:16: E124 closing bracket does not match visual indentation
1592: D202 No blank lines allowed after function docstring (found 1)
1727:19: E203 whitespace before ':'
1728:26: E222 multiple spaces after operator
1733:37: E231 missing whitespace after ','
1733:23: E222 multiple spaces after operator
1734:13: E203 whitespace before ':'
1736:27: E203 whitespace before ':'
1737:27: E222 multiple spaces after operator
1745:38: E231 missing whitespace after ','
1745:23: E222 multiple spaces after operator
1746:13: E203 whitespace before ':'
1755:21: E203 whitespace before ':'
1756:30: E203 whitespace before ':'
1757:27: E203 whitespace before ':'
1765:9: E122 continuation line missing indentation or outdented
1765:73: E201 whitespace after '{'
1765:81: E203 whitespace before ':'
1766:65: E128 continuation line under-indented for visual indent
1766:78: E203 whitespace before ':'
1767:65: E124 closing bracket does not match visual indentation
1768:26: E128 continuation line under-indented for visual indent
1772:13: E128 continuation line under-indented for visual indent
1774:24: E231 missing whitespace after ':'
1775:30: E203 whitespace before ':'
1776:31: E203 whitespace before ':'
1776:32: E231 missing whitespace after ':'
1777:25: E231 missing whitespace after ':'
1778:24: E231 missing whitespace after ':'
1787:31: E231 missing whitespace after ':'
1788:21: E231 missing whitespace after ':'
1856:21: E222 multiple spaces after operator
1859:13: E203 whitespace before ':'
1865:25: E203 whitespace before ':'
1866:29: E203 whitespace before ':'
1867:25: E231 missing whitespace after ':'
1869:24: E203 whitespace before ':'
1870:31: E231 missing whitespace after ':'
1871:21: E203 whitespace before ':'
1871:22: E231 missing whitespace after ':'
1872:25: E203 whitespace before ':'
1877:5: E303 too many blank lines (2)
1877: D400 First line should end with a period (not 'p')
1877: D205 1 blank line required between summary line and description (found 0)
1908:11: E225 missing whitespace around operator
1909:19: E231 missing whitespace after ':'
1912:22: E231 missing whitespace after ':'
1914:15: E124 closing bracket does not match visual indentation
1917: D400 First line should end with a period (not 'e')
1917: D205 1 blank line required between summary line and description (found 0)
1948:11: E225 missing whitespace around operator
1949:19: E231 missing whitespace after ':'
1952:22: E231 missing whitespace after ':'
1954:15: E124 closing bracket does not match visual indentation
1957: D400 First line should end with a period (not 'y')
1957: D205 1 blank line required between summary line and description (found 0)
1971: D210 No whitespaces allowed surrounding docstring text
1971: D400 First line should end with a period (not 'u')
1971: D205 1 blank line required between summary line and description (found 0)
1976:20: E203 whitespace before ':'
1978:62: E225 missing whitespace around operator
1979:13: E203 whitespace before ':'
1986:54: E225 missing whitespace around operator
1991:5: E303 too many blank lines (2)
1991: D400 First line should end with a period (not 's')
1991: D205 1 blank line required between summary line and description (found 0)
1997:9: F841 local variable '_' is assigned to but never used
2009: D400 First line should end with a period (not ':')
2009: D205 1 blank line required between summary line and description (found 0)
2024:15: E271 multiple spaces after keyword
2026: D400 First line should end with a period (not ':')
2026: D205 1 blank line required between summary line and description (found 0)
2043: D400 First line should end with a period (not 'p')
2043: D205 1 blank line required between summary line and description (found 0)
2062: D400 First line should end with a period (not 'd')
2062: D205 1 blank line required between summary line and description (found 0)
2087: D400 First line should end with a period (not 'd')
2087: D205 1 blank line required between summary line and description (found 0)
2105: D400 First line should end with a period (not ')')
2105: D205 1 blank line required between summary line and description (found 0)
2123: D400 First line should end with a period (not 'e')
2123: D205 1 blank line required between summary line and description (found 0)
2171:19: E128 continuation line under-indented for visual indent


1: D400 First line should end with a period (not 'o')
1: D200 One-line docstring should fit on one line with quotes (found 3)
2: L102 copyright year is outdated, expected 2015 but got 2014
23:1: E402 module level import not at top of file
24:1: I100 Imports statements are in the wrong order. import cgi should be before import time
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. import sys should be before import urllib
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. import string should be before import sys
28:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I201 Missing newline before sections or imports.
31:1: E402 module level import not at top of file
32:1: I101 Imported names are in the wrong order. Should be CFG_BASE_URL, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_VERSION, CFG_WEBSTYLE_TEMPLATE_SKIN
32:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.ext.template
32:1: F401 'CFG_SITE_SECURE_URL' imported but unused
32:1: F401 'CFG_SITE_RECORD' imported but unused
32:1: F401 'CFG_VERSION' imported but unused
32:1: F401 'CFG_WEBSTYLE_TEMPLATE_SKIN' imported but unused
32:1: E402 module level import not at top of file
33:6: E126 continuation line over-indented for hanging indent
45:1: I101 Imported names are in the wrong order. Should be gettext_set_language, is_language_rtl, language_list_long
45:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
45:1: F401 'is_language_rtl' imported but unused
45:1: E402 module level import not at top of file
46:1: I101 Imported names are in the wrong order. Should be create_html_link, get_canonical_and_alternates_urls, make_canonical_urlargd
46:1: F401 'get_canonical_and_alternates_urls' imported but unused
46:1: E402 module level import not at top of file
47:30: E126 continuation line over-indented for hanging indent
48:1: I100 Imports statements are in the wrong order. from invenio.utils.date should be before from invenio.utils.url
48:1: F401 'convert_datestruct_to_dategui' imported but unused
48:1: E402 module level import not at top of file
49:31: E126 continuation line over-indented for hanging indent
50:1: I100 Imports statements are in the wrong order. from invenio.modules.formatter should be before from invenio.utils.date
50:1: E402 module level import not at top of file
51:1: E402 module level import not at top of file
52:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.utils.html
52:1: E402 module level import not at top of file
56: D101 Missing docstring in public class
58: D202 No blank lines allowed after function docstring (found 1)
58: D400 First line should end with a period (not 'y')
58: D208 Docstring is over-indented
110: D401 First line should be in imperative mood ('Create', not 'Creates')
110: D400 First line should end with a period (not 'e')
110: D208 Docstring is over-indented
199: D401 First line should be in imperative mood ('Create', not 'Creates')
199: D202 No blank lines allowed after function docstring (found 1)
199: D400 First line should end with a period (not 'r')
199: D208 Docstring is over-indented
260: D401 First line should be in imperative mood ('Create', not 'Creates')
260: D400 First line should end with a period (not 'r')
260: D208 Docstring is over-indented
289: D202 No blank lines allowed after function docstring (found 1)
289: D400 First line should end with a period (not 'e')
289: D205 1 blank line required between summary line and description (found 0)
289: D208 Docstring is over-indented
326:18: E126 continuation line over-indented for hanging indent
328:13: E266 too many leading '#' for block comment
329:13: E266 too many leading '#' for block comment
332: D401 First line should be in imperative mood ('Produce', not 'Produces')
332: D202 No blank lines allowed after function docstring (found 1)
332: D208 Docstring is over-indented
368:13: B901 blind except: statement
368:20: E261 at least two spaces before inline comment
388:21: B901 blind except: statement
390:34: E261 at least two spaces before inline comment
440:17: E126 continuation line over-indented for hanging indent
440:28: E203 whitespace before ':'
443:37: E502 the backslash is redundant between brackets
444:24: E131 continuation line unaligned for hanging indent
446:24: E203 whitespace before ':'
447:24: E203 whitespace before ':'
448:31: E502 the backslash is redundant between brackets
448:28: E203 whitespace before ':'
449:21: E131 continuation line unaligned for hanging indent
450:90: E225 missing whitespace around operator
451:28: E203 whitespace before ':'
452:28: E203 whitespace before ':'
453:28: E203 whitespace before ':'
454:28: E203 whitespace before ':'
455:28: E203 whitespace before ':'
456:28: E203 whitespace before ':'
457:28: E203 whitespace before ':'
458:28: E203 whitespace before ':'
459:29: E203 whitespace before ':'
460:62: E502 the backslash is redundant between brackets
460:28: E203 whitespace before ':'
460:37: E225 missing whitespace around operator
461:34: E131 continuation line unaligned for hanging indent
461:67: E502 the backslash is redundant between brackets
462:34: E131 continuation line unaligned for hanging indent
463:15: E126 continuation line over-indented for hanging indent
466: D401 First line should be in imperative mood ('Print', not 'Prints')
471:53: E251 unexpected spaces around keyword / parameter equals
471:55: E251 unexpected spaces around keyword / parameter equals
471:78: E251 unexpected spaces around keyword / parameter equals
471:80: E251 unexpected spaces around keyword / parameter equals
531:41: E231 missing whitespace after ':'
532:41: E231 missing whitespace after ':'
533:42: E231 missing whitespace after ':'
536:41: E231 missing whitespace after ':'
537:39: E231 missing whitespace after ':'
538:41: E231 missing whitespace after ':'
539:42: E231 missing whitespace after ':'
548:9: E303 too many blank lines (2)
570:9: E303 too many blank lines (2)
582:30: E231 missing whitespace after ':'
583:38: E231 missing whitespace after ':'
588: D401 First line should be in imperative mood ('Print', not 'Prints')
618:69: E502 the backslash is redundant between brackets
622:41: E231 missing whitespace after ','
632:21: E203 whitespace before ':'
633:19: E203 whitespace before ':'
634:17: E126 continuation line over-indented for hanging indent
643:5: E303 too many blank lines (2)
643: D401 First line should be in imperative mood ('Display', not 'Displays')
643: D400 First line should end with a period (not 'd')
643: D205 1 blank line required between summary line and description (found 0)
643: D208 Docstring is over-indented
661:9: F841 local variable '_' is assigned to but never used
684:9: E122 continuation line missing indentation or outdented
685:9: E122 continuation line missing indentation or outdented
685:13: E231 missing whitespace after ':'
686:9: E122 continuation line missing indentation or outdented
686:16: E231 missing whitespace after ':'
687:9: E122 continuation line missing indentation or outdented
688:9: E122 continuation line missing indentation or outdented
688:18: E231 missing whitespace after ':'
689:9: E122 continuation line missing indentation or outdented
704:21: E203 whitespace before ':'
705:22: E203 whitespace before ':'
706:22: E203 whitespace before ':'
707:21: E203 whitespace before ':'
708:93: E203 whitespace before ':'
712: D401 First line should be in imperative mood ('Produce', not 'Produces')
712: D202 No blank lines allowed after function docstring (found 1)
712: D400 First line should end with a period (not 't')
724:9: F841 local variable '_' is assigned to but never used
728: D401 First line should be in imperative mood ('Return', not 'Returns')
728: D202 No blank lines allowed after function docstring (found 1)


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
207:15: E126 continuation line over-indented for hanging indent
210:1: E402 module level import not at top of file
244:17: E203 whitespace before ':'
245:22: E203 whitespace before ':'
246:20: E203 whitespace before ':'
247:18: E203 whitespace before ':'
248:24: E203 whitespace before ':'
249:22: E203 whitespace before ':'
250:19: E203 whitespace before ':'
251:20: E203 whitespace before ':'
252:23: E203 whitespace before ':'
253:18: E203 whitespace before ':'
254:17: E203 whitespace before ':'
255:19: E203 whitespace before ':'
256:20: E203 whitespace before ':'
257:19: E203 whitespace before ':'
258:20: E203 whitespace before ':'
259:17: E203 whitespace before ':'
260:24: E203 whitespace before ':'
261:23: E203 whitespace before ':'
262:21: E203 whitespace before ':'
263:37: E203 whitespace before ':'
277:4: E131 continuation line unaligned for hanging indent
306:1: W391 blank line at end of file


[^;[:space:]]\+ should do it, right?


Yes, `packages_2` is the current correct version. `packages_3` is for development work I am doing.


lgtm acl


El picking_type_id no lo tengo en el move, paso esos dos valores?


I think there should be some protection against (or check for) this being used with an old version of crates (e.g. a user trying to install a new version of sherpa against the CIAO 4.7 libraries), where `is_varlen` is not an attribute. So, something like

    values = col.values
    try:
        if col.is_varlen():
            values = col.get_fixed_length_array()
    except AttributeError:
        pass

I re-ordered the check so that the try/except check covered as little code as possible, but this is just to show what I meant, and other options are possible.
            values = col.values


fixes #242


ack


This may have been nice as as override of valueOf(String)


The same point as for the previous `col.is_varlen()` call.


So the issue is here - you are passing buddy_id, but not designating that it is the buddy_id, therefore your controller can't find a parameter called buddy_id. What it thinks you are passing is the exclusion_id, which you need in order to make the call to that route. So really, you should be passing the exclusion id here.


OK, entonces esos dos valores.


minor: unrelated spacing change


You have three options which play a role,
1. "subtome" icon/none
2. subtome yes/no
3. xml icon/none
You have to play with *all* possible combinations of these three. Best to use is BP blue!

I did not want to shot your work on adding subtome. I waited for a reaction of opening issue #285 up again and the board thread and waited another day after for this suggested fix, since they all were somehow related. I just had some spare time to make this work and since you are assigned to the issue, noted you to test this up.

A) Needed the 'none' fix to xml icon too for BP
B) the fallback is 'empty'
C) I don't think so. Did you test that in BP blue with all combinations?


I understand your concern.  I could refactor this code block into a function and call that.

This may be an instance where powershell (v2 at least) shows that it's really a shell scripting language as opposed to an object based one like Java or C#.  There's no inheritance.


Pon al final `[:1]` para asegurar que sólo coges uno


Indeed, it is used.

WHere's the fixed patch? eitherway, thumbs up, please push this PR.


compile


ack anyways, assuming you're sure you connected the signals the right way as this is not tested here!


Good old SVN days :>


What I would do here is:

```
@exclusion = Exclusion.find(params[:id])
```


Sorry!  Thank you for the reminder....


You can do something like (3, 4, 0) <= sys.version_info <= (3, 4, 3) instead.


Ok. I'll fix it.


IKR, never had these troubles with SVN :P


Then here, you should make this something like this:

```
if current_user.exclusions.include?(@exclusion) && @exclusion.destroy
```


-= operator would be shorter


Looks good, thanks!


ack


same here, please keep this variable private.


![](http://i.imgur.com/uSWUqYz.png)
![](http://i.imgur.com/PE0DtWa.png)

The difference in MOBID_EMPERIUM, M....
ahh... i think i got... nvm


I thought it was decided to not use double underscore as it gets confusing with inbuild functions like `__init__`


That was the reason I noted it above!


Once you eventually add pundit (if you do), then you can restrict the deletion at that level instead.


Il manque la physique ! On ne peut plus se déplacer en l'air en faisant comme ça, il suffit de la rajouter dans le if state == 'walk' de la physique ;)


hey, why is there no id param and member?


unack :)


Great thanks!


Yes, or something like:

typedef MotionTpl<_Scalar,_Options>::Vector3 Vector3;
blabla
const Vector3 & w = nu.angular ();


I'd rather introduce id as a member and then pass it on construction


Yes, I thought about it too but right now we have only two formatters so I think that [rule of three](http://en.wikipedia.org/wiki/Rule_of_three_%28computer_programming%29) will be ok here.


Is this changing length to count to save a DB request? (Just curious).


Hang on, fields are not nullable. Fixing.


Instead of writing:
Matrix3 R = exp3(w);
it is more efficient to write:
Matrix3 R(exp3(w));


Is it part of flask-wtf or wtforms itself?


@lgebhardt :+1: Thanks!


I'll cherry pick the _check_cnpj_cpf refactor as your one is better reusing the existing code. Thanks.


I can't recall that, I'd at least use one underscore for this variable


That's interesting. I know Thoughtbot has a library for generating a completely static site, [middleman](https://github.com/middleman/middleman), but I wasn't aware of anything to generate static stuff in your rails site.


js and css modified to use "data-focus" attribute.


Does it not work for Windows now?


i.e. if you want use one or two, it doesn't matter that much in python, more like a signal "don't touch!"


@sakshij14275 @PoonamG  @BazingaG  Please don't feel sorry!


なんだこりや


ack - Code removal yayyyyy


Ah okay, just commented about that the old commit, that's nice :)


ouuukay, ack :D


Got it, thanks.


This theoretically fixes the Wi-Fi issue, meaning it's possible to start building with the Wi-Fi HAL again?


expandTildeInPath ( localPath, outputStyle )

localPath format:
 • posix path - a posix path (can start with a  tilde "~")
 • alias
 • path (text) with ":"  => (alias as text) produces this

outputStyle:
When outputStyle is true  : returns posix path
When outputStyle is false : returns alias


`this.end;` => `this.end();`... Fixed now though.


Got it.


![mpb6t](https://cloud.githubusercontent.com/assets/325535/8083769/efb49358-0f7e-11e5-8d69-19957c8aa6a9.jpg)

Seriously though... do give it a spin.


Thanks, that was much needed! :+1:


Dat moet dan molgenis breed denk ik eigenlijk, niet hier.


Echoing Scott's comment, I'd also like the motivation for `recentPositions_` documented or else it's likely to be removed when people notice it isn't used directly. Also, maybe `boost::flat_map` would be better than `std::map` for a container with only a couple elements.


uff, ack


hier könnte man bitte noch @notanormalnerd machen


I think moving `ConnectionStrategy` out of provider makes sense since it's not a provider-specific concern. I imagine most consumers will never user anything other than the default.


@chrisroos @floehopper what do you think?

Alternatives to this approach would be to:

1) create a subclass of the Date question that has this built in
2) implement `date_of_birth_question` [somewhere here](https://github.com/alphagov/smart-answers/blob/bdc2a07ba0ef04b47f752a9163fc6f53efe481e5/lib/smart_answer/flow.rb#L69-L71)
3) anything else?


This is the problematic change.


maybe this function should go into the base class?


:+1:

In the heat of the moment it didn't even occur to me!


resolved


Too specific for testing imo^^


not sure about that rename. I was quite happy with `owned`. What was the reason?


in how many classes do you use it?


Yes, that is what I was thinking too.  I didn't want to do so until we had a use for it - other than the special case of "none", setting to major or minor wouldn't actually do anything currently.  As it is, I was afraid it would mostly be a way for a user to shoot himself in the foot by setting the mode to "none" without realizing what it is for.

Eventually I could see major / minor being used to influence the pitch spelling algorithms somehow, although that's probably mostly relevant for MIDI import.  Are there other uses we envision for this?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16071/testReport/) for this commit**


The column width could still be left in or passed as an empty string.


Originally this was in the ScenarioModel, but I needed a reference to the ProjectModel, so I moved it in here. But I'll see if I can move some of the logic into better places.


ack


Please, have a look how it's done in other modules, e.g.
```c
#define 	LOGGER_ENABLE		LOGGER_DEMO_COAP
#if			LOGGER_ENABLE 	== 	TRUE
#define		LOGGER_SUBSYSTEM	"dCOAP"
#endif
#include	"logger.h"
```


does this help? https://github.com/plone/plone.app.z3cform/commit/513a87a6ec55a142f810fa818c65b4906a331e93


Why are you change media-tablet onto media-desktop and vice versa???


You should use:

if e.g. your syntax is:

module.type:plugin_id

```php

list($plugin_manager_id, $plugin_id) = explode(':', $exportable['factory_service']);

if (Drupal::hasService($plugin_manager_id)) {
  $plugin_manager = \Drupal::service($plugin_manager_id);
  if ($plugin_manager->hasDefinition($plugin_id)) {
    $object = $plugin_manager->createInstance($plugin_id);
  }
}
```


I've already modified this declaration in the next commit of this pull request


thanks


When `.group` is applied to an ActiveRelation query, it changes the behaviour of count from returning a number, to returning if I remember correctly, a `Hash`, which doesn't make for obvious reading in a test.


best decision ever!


Get will ignore files that change for no reason.


![didn't work](http://4codemonkeys.com/wp-content/uploads/2014/06/51023346.jpg)

seriously, I needed #69 to compile it here


2, `SearchForTest` and `UnescapedSearchForTest`


ok


IMHO catching precise exceptions should be preferred. In future this will also help in logging the errors properly.


![this is what I meant](http://cdn.meme.am/instances/500x/56430295.jpg)


**ok
* ok


test add page


@bmwiedemann @toabctl yes, that is the commit. I pushed it as different commit as per his suggestions.


Hah, right. That makes sense.
--
Paul Wilson
Cultivate | cultivatehq.com
Skype: merecomplexities
Phone: +44 7855 841103

> On 10 Jun 2015, at 14:51, Mark Connell <notifications@github.com> wrote:
>
> When .group is applied to an ActiveRelation query, it changes the behaviour of count from returning a number, to returning if I remember correctly, a Hash, which doesn't make for obvious reading in a test.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/moneyadviceservice/webfeeds/commit/68b76cf9085f86f79da7b53657f31a6135e74a86#commitcomment-11611758>.
>


"platform/util/StringUtils.h"


Add new task is not finally implemented then to add new task we should do next steps:
1. type in task-name;
2. type in _id of project;
3. choose date between today and tomorrow.


ok :(


test


ack


The correct approach would be to subclass `StringProcessingTest` to a `SearchForTestBase` (btw, maybe I should rename `StringProcessingTest` to `StringProcessingTestBase`...), define the function there, let these two tests derive from this class^^


Which part exactly? This: if [True for match in device_errors if match in result]: ?  I'm verifying it with a unit test.


I just want to comment on your commit message...

```
players now learn both version (alliance and horde) but only the version for their faction will appear in their mount collection (there are exceptions because some faction based mounts aren't included in that table
```
This is wrong. Even though I play mostly on Alliance side (on Retail) I do have a few Horde characters as well... Alliance side can see Horde mounts and vice versa (for example, race mounts). From my Alliance character, I can see that I have Black Skeletal Horse (undead mount) but I can't summon it and mount's icon has red-ish mask over it.

Statement that only mounts of your faction appear in the Mount Collection is invalid.

Image taken at the moment of the comment.
![mounts](https://cloud.githubusercontent.com/assets/817464/8084103/76c628c0-0f89-11e5-8551-327019287643.jpg)


You're assuming it supports reloading config which, according to the init script (`/etc/init.d/dnsmasq`), it does not.


Also fixes the clone-as-sudo problem, and all creation as sudo problems.
Because of the way i'm using Popen, I can do this without having to kill the process by sudo.


Yeah, it does. It was a mistake, its been corrected in the latest commit.


boxed_number_simplifications (lefticus) - x86_64-MacOS-10.9-clang-Debug: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good point, @DougBurke... thanks!


Actually, git is really powerful, including for correcting mistakes, though it does have some learning curve to it.

I'd suggest to use https://github.com/git-for-windows/git/releases and do everything manually from the command line and just keep finding guides when one doesn't know hot to complete a certain task, and after a while of banging your head against it, hopefully at some stage it'll become natural.

That's what I did. It took a while, but now I'm pretty comfortable with doing everything from the command line and reading guides on the rare cases I'm not sure how to complete a task.

GUI tools are sort of limited with git due to the so many things which git can do, though `gitk` (which comes with git-for-windows) is not too bad, and I'd probably recommend it over tortoise-git.


This plone.theme change might be breaking plone 4.3 installs(4.3.6). Looks like 2.1.4 should actually be plone 5 only?

This is, I think, the 4th package this has happened with. We need to be more careful about pulling in changes that were meant for plone 5. In this case, I'm not even sure how plone.theme ever even made it to the checkouts.cfg list for 4.3 branch.

In any case, I'm going to branch 2.x, pull back the changes on 2.x branch, get a 3.x release ready and setup the changes to the 5.0 and 4.3 buildout.

@tisto @esteele @tomgross


Did you consider to correct what makes ```m_YouAreDead != null``` in this situation, inseat of check if it occurs on some place an then correct ? Just a tip :)


To get the old behavior we'd have to: `relay = peerPosition (proposal) || relay;` (note it's important that `relay` is last or may short circuit).


I'm really sorry. This commit should read "use revised o-charts version v0.4.3"


I now realize it was getting messy with the separate functions. In the latest commit, time_commit returns is again a single function.
Also, thanks for the advice for doing away with rownames!


Could you leave it in place as fallback?


`layers[i].Identifier` was for WMTS layers ... there are not managed anymore


Oh, this searches not just the current file but the whole git repository with [ag](https://github.com/ggreer/the_silver_searcher).


Yup, this is for me.


spacing


Such commit, much wow.


reack


you might want to use just _ so that it is in line with other stubs


Окей, я розділю код на певні блоки


Please fix mispelled canola oil in directions.


Very Good


here too


and here


Nice, this should be compatible with 2.6!


and all this


I guess along with these it might be a good idea to ask for instance type and load balancing option


ок


list -> LIST


TeamCity DNN JavaScript Libraries :: CI [Build 2](http://teamcity.engagesoftware.com/viewLog.html?buildId=268&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


`yet to be created` => `此时还未被创建`

yet : 用于否定句中表示某事尚未发生但有可能发生


TeamCity DNN JavaScript Libraries :: CI [Build 2](http://teamcity.engagesoftware.com/viewLog.html?buildId=268&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:28


Why is this formatted differently than every other instantiation? Should `.next()` be on the following line for consistency?


You changes some occurences of `parentmost` to `topmost`, but left this one.


i guess you need to rename .original file to .war and use that as it will not have a tomcat instance embedded


FIX: tel bug


This should be alphabetical.


Looks good but at some point, we'll need to reconsider keeping our own repo for EL7 and how to branch rdo-update gerrit & CI to CBS ?


shouldnt this be retrieving the created bucket from createBucket method?


develop (lefticus) - x86_64-MacOS-10.9-clang: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


//cc @moollaza  @talsraviv  this should be all that is required.


v8 disables optimization for any method when the arguments variable is passed to other functions.  Source: https://code.google.com/p/v8/issues/detail?id=3037


It looks like there's a return statement missing here.


おそらくこれらのタグを挿入する部分はもう少し下のあたり（noteとかのあたりになるかと思います。）
*.vmファイルはテンプレートファイルになるため、書いてある位置にhtmlタグが生成されるようになります。


shouldnt this be deployed with prod profile?


Can you swap `type` and `id` for consistency?


Thank you! This fixed the issue.


Don't forget about the changes needed in this script ;)


Do I understand this right: They changed Lavas Def-ignore buff to and chance to ignore Def?


I like the functionality, only I'm not sure it's necessarily to store the providers_dir_empty in the module. I'd simply put the `os.listdir(...)` directly to the `if` check.

Additionally I don't see the point of custom exception. It's well described so generic `EnvironmentError` or `AssertionError` would do well.


That makes sense on Chars not having an encoding, but I'm really not buying the idea that we'd need 5 separate Char types. Like I said, the memory argument is certainly not worth the tradeoff of *5* separate types and all the code/codegen that would come with. And while the "auto-eliminated checks" sounds nice, it may be difficult to actually realize in simple, generic code. I'd love to see an actual use case where we can see the checks avoided, but my guess is that it may be trickier to achieve.

I think this calls for a step back to really consider the use of `Char` in general. Why do we really need it? *Do* we really need it? If Strings had a different internal representation, does that change the need for an individual `Char` type? This kind of goes back to my thoughts on the current situation with the `.data` internals of strings currently in Base; if we can avoid it, that could lead to much simpler code without limiting functionality too much.


Good!


`!!checkbox.checkboxradio( "instance")` is probably a little cleaner, but I could live with either.


do we need this to be a dependency for everyone? i guess not everyone would use this stub


Going by the change, it does seems so.


Sure, no problem, I'll amend the commit and add this too if you want it.

It's just that I get the feeling that this line in there because parted puts code there when initializing a new MBR that creates this signature and somebody decided that we should treat this as "No boot loader" which is not exactly what this is. This is a generic booting code. I think that only a zero string should be treated as "No boot loader".


I thought JSCS checked for the space before the curly brace. Do we need an update to JSCS?


No problem about F2FS. Was eventually going to add it anyway. As for the
fix, I'll try it later.

On Wed, Jun 10, 2015, 9:42 AM Tyler Dunn <notifications@github.com> wrote:

> This theoretically fixes the Wi-Fi issue, meaning it's possible to start
> building with the Wi-Fi HAL again?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZdrowyGosciu/kernel_lge_g2_msm8974-caf_lg-devs/commit/52da4a16b93fd65b9eed77863be0d5bef9c03cc5#commitcomment-11611543>
> .
>


spacing (and the line above)


...and I guess all over the place :-P


hmm it should ill have to check it out


updated


I haven't replaced it into `topmost`. It's  the diff that made you think I did. That change refers to the previous variable. parentmost is the same as bottommost in that context.


X-Real-IP is nowhere defined. Even X-Forwarded-For is not really nice, as it is user input. I don't like this change at that position. But well, I don't use circuits.web so I don't care much.


I don't have control over the PyPI management. I'll have to delegate to @joke2k


Should we check that the underlying control is actually disabled as well?


I would have defined this functino inside `Out-IniFile { Begin{ function writeKeys() }` so that it only exists inside the instance