The indexOf function (L238) does a linear search again, moreover, it will use the == operator to find the element, that is pointer comparison in this case. I think, it would be better to use an iterator to go through the list and use a simple assignment to replace the element. E.g. *it = child;


We still want this to work so it can auto pick topics based on new policies selected.


Cause docker sucks balls lol If i want to explain that I'll have to go through a lot of theory and practice to explain why simple is better than complicated and so on ... not my initial objective i recon ^^


This doesn't capture the differences quite as well as the piece on `weave run` in the proxy usage section. I suggest we move the latter here, and tweak it slightly.


thanks, looks better 497678746fd38038896d6fa24048a7d316765a2b ?


just noticed its using the old location for the config file. It is ~/.kube/config now. See the release notes for the RC2 at https://github.com/openshift/origin/releases


should remove the extra "


FUUUUUUCK! Are you sure you want to commit so many lines at once?


fwiw, I have a makefile that has all these embedded in them for development amongst the team until a better plan for sharing private keys is in place.


Please invert both this `if` and the one in the derived class' `Tick()`


add an aside: "don't worry if you don't understand the mapping - if you are interested, please check out this awesome article/picture explaining the mapping...."


We still want this so it can auto pick topics based on policy.


Very reasonable, I'll work on the change. While you're here, the most recent commit fixes the error message popping up on comments every time. I fixed it by returning an OK http status. Would it be better to return a Json value instead, or is this fine?


@flavour please see this...I tested in other language but internationalisation is not working for drop-down :(


Negative look ahead in the ignored_slug should do, rather than this?


@dbolkensteyn `keyvalue.substring is ok because of the `keyValue.startsWith` in the if condition. `indexOf('/')` possible error in case of bad format fixed in https://github.com/SonarCommunity/sonar-resharper/commit/7fb2c01403a415c302a921b2e1a0b1591cc252b0.


I'm not sure why we've been using extended paths here as the `**/*` version should indeed be equivalent for our needs. LGTM.


add:

ahhahahha
so 0.1 is actually   0.100000001
and 0.2 is actually 0.200000003
and 0.1 + 0.2 is not even 0.300000004....its 0.29999999999999993
 baahahaa

For those people who like music theory, you might want to think of floating point kind of like equal temperment for piano tuning. The intervals are not actually natural harmonics, but kind of a close-enough-so-we-can-play-piano-easier...


Linaro supports graphite now?  That's new to me.


Thanks @fsodogandji !


add coment: If you are unfamiliar with gdb and not get so distracted, you can skip to the line "ahahahaha"


`CreatesShroud` is still separate from `RevealsShroud` in this commit.


Great! That's an optimization killer. I was going to send a pull request soon anyway :P


should be ellipses, not just ..


Also you only need to disable it for the files that have the issues.  In this case your disabling for the entire Makefile here.  See my hammerhead kernel for changes.


Just to note in the merge that this is now covered by the ElectionMixin


Typo in commit


There's a Spanish .po file to update too.


!m @tshepang :)


どんな引数を渡すと、どんな結果が返ってくるのかが分かりづらいです。
理由1. 関数の内容がこの行の時点で分かりにくい(関数名・コメント)。
理由2. 関数からの返り値ではなく、参照渡しで値を操作しているため。


@d2bit please take an eye to this merging... at least the counter_cache seems fixed


Duly noted and thanks !

Another fix coming your way...


s/in/it


No issues! Merge!


done!


The only suggestion I have right now is to ensure that all menu items have a (hopefully unique) accelerator (the underscore/underline beneath a letter of the menu).


sorry, fixed that!


I'm afraid we havet to.

In order to get the wrapping shadow-worker async to properly resolve the proposed promise callback flexbox, we need to animate the children of a distant relative by a factor of node elements * available cpu threads.

There should be no side effects from this, as long as you dont return false in any css classes used for the dependency injection of event listener elements.


I proposed to replace
```require_relative '../lib/symengine'```
with
```
lib = File.expand_path('../lib', __FILE__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'symengine'
```
this way you add your lib to load path and can require without relative. You can also require other files from lib/symengine as ```require 'symengine/file_name'``` in this case.

In *.gemspec it's usually used to require file with version.


Good point, I've fixed that here: 07e45fbd09348b412


We can do the same for parsers:
~~~haskell
-- Delegate processing of one token to another parser
delegate' :: Alternative f => Parser t f a -> Parser t f (Parser t f a)
delegate' p = Parser
  { results = pure p
  , consume = \t -> delegate' (consume p t)
  }
~~~
And recover your version of delegate by
~~~haskell
delegate :: Alternative f => Parser t f a -> Parser t f (Parser t f a)
delegate p = fmap fst $ intersect (delegate' p) anyToken
~~~


Hello, as I was making new PR in order to take in account last evolutions on Transformation service, I integrated your comment regarding PathNotFoundException as well as your tests.


На эту строчку нет теста. Есил ее убрать, то тесты проходят.


I think I understand what this change does, but the commit message doesn't explain *why* you made it?  e.g. why do you want to ignore the value of `$tempestoptions`?


Why do you think that QXmlDefaultHandler is deprecated? Why is the other class better? Is it that the first is a SaX based parser and the other is DOM based, i.e. builds the whole data tree?


@arthure sure loves his numeric liberals :smile:


Thanks ;)


Surely this breaks compilation as it doesn't update `include/wx/generic/sashwin.h`?


Correct issue #1321


:boom:


I don't get what you mean. This line, containing `$prev_interval_max`, is inside the `rotate_higher_interval` subroutine, which starts at [line 4177](https://github.com/myrdd/rsnapshot/commit/c1259cdcd09ab33e2b59bcc9f47b11a4a086a5b3#diff-70276296f2bdcc3adb72b3d823d07361R4177).

When "rotating a higher interval", two things will be done:
 - `interval` will be rotated, eventually removing `interval.max`
 - `prev_interval.max` will be the new `interval.0`

The `prev_interval` won't be rotated, simply `prev_interval.max` „disappear“. And since `interval` is a *„higher“* interval, any actions in the subroutine will be only *renames*.

---

There's one corner case though, but it's catched in [line 4296](https://github.com/myrdd/rsnapshot/commit/c1259cdcd09ab33e2b59bcc9f47b11a4a086a5b3#diff-70276296f2bdcc3adb72b3d823d07361R4296). It means: in case the `prev_interval` is the *lowest* interval, it must have at least two snapshots. You mention hardlinking. If I understand correctly, that corner case is the only case where "rotating a higher interval" affects hardlinking.

By the way, I think that corner case should be catched earlier, that is, *before* the actual rotation is done. I suggest to create a unit test (or several) for it.


@arthurnn fyi


Thanks for the report. I'll have a look at the code. I'd rather support integers if it's possible (I'm sure it is).


Apologies, commit message should have read 'correct'. I will get this right next time!


broken


:smile:


this will only publish `index.js`, `Readme.md` to npm.


I get it now. Sorry for misinterpreting you. Please bear with me, as I am relatively new to Ruby.


That's what I meant with manually ;)


change `array($this, '_default')` to `[$this, '_default']`, if you want to i try pull request with this one and another comments, can i try?


It's Germanic


Since we don't want this problem to come back, you should install a specific version of postgresql, otherwise, this problem will reappear when a new version of postgresql is release.


yes, you're right, but it should suffice ... (hopefully)


Don't need extra parenthesis for defines.
`#define TUTTLE_EXPORT_PROCESSGRAPH_DOT (1)`


It's rare that I'm proud of a stub, but this one is well done.


Looks great!

A few nits above.


Maybe better to add a specific option, like TUTTLE_EXPERIMENTAL which is enabled by default in debug.


Can we trigger that? What can we do about it? Port it to libidn2 ?


By the way why did we remove it? It shouldn't be much of a size difference if we're not using polyfilled features.
@dariocravero


Thanks @vweng for the contribution. Before we can merge the pull request we have to look at all the usages of this method.


Very raw program. It woks


Maybe better to add an option TUTTLE_INIT_IMAGE_BUFFERS enabled by default in debug.


There is a chance to disable SPICE security on the oVirt side (not simple, it has to be disabled in oVirt engine and in all hosts in VDSM and libvirt) but in devel setups it is common. In this case the vm.getDisplaySecurePort() returns -1 and this stuff than should not be set to the url. e.g. you need something like this:
```java
String url = vm.getDisplayType().getProtocol() + "://" + vm.getDisplayAddress() + ":" + vm.getDisplayPort()
                + "?" + passwordPart;

        if (vm.getDisplaySecurePort() != -1) {
            url += "&" + tlsPortPart + "&" + certSubjectPart + "&" + caCertPathPart;
        }
```


Since these are project recommendations, how about renaming the file to something that includes `project`?


当たり判定


Shouldn't there be a 3 here?  ref issue #60 .


In regards to which line?


I think this should be optional, not forced. Though, it could be enabled by default.


@chris-allan Chris, can you confirm that we still need to replace '/' in column headers? If we do, then I'll need to find a workaround for handling urls. Thanks.


Rather than duplicating flow rules, how about you replace this and the following two lines with the following:
```
| (tin::tins, (OptionalT tout)::touts) ->
  rec_flow cx trace (tin, OptionalT tout);
  multiflow_partial cx trace ?strict (tins, touts)
```

Pleasantly, this would also ensure proper handling of undefined and optional stuff when they're passed around as tvars rather than concretely.


now is 'default' should be 4 (is like the standard now)


cxz


It does intentionally  http://google-opensource.blogspot.de/2015/03/farewell-to-google-code.html


replace the "(int i)"s by "()" or remove them altogether from the commit message so that it fits into 70 chars


I would change the message in "One row should be returned"


and here, if you need it: assertEquals("single row should be returned", false, rs.next());


this is not a data computation step, is it? it should not be under the "data computation" comment


why not a method "addFalsePositiveMeasure" method for consistency?


I don't think we should save npm-shrinkwrap.json in git, just generate it before publishing.


you really could make a static import of `FluentIterable.from`, shorter without damaging readability


This is how I would add the buttons for now. It is a bit bad that it has many redundant values but I have no better, easy idea how to do it (other than using a complex layout manager)


Do we need to do a check if the file has already been uploaded to the server?


How could I not have seen that :P


I wanted to emphasize _slowly_ ;-)


This code is not idempotent. Command should have ```changed_when: False  ``` for never info commands or ```changed_when ********** ```some logic to differentiate between conditions.

Can you please change that ?


this should be static and variable be uppercase


Need a check on CIs, as for the moment only 0.95 CIs are calculated


you could invert this test and avoid having the whole code of this method in a if


Looks good:)

Regarding testing this with the discovery document, please try to run the bin/generate.dart script with the discovery command. E.g.

$ mkdir /tmp/rest
$ dart bin/generate.dart discovery -i example/toyapi.dart > /tmp/rest/toyapi.json

and then run the generated discovery document through the discoveryapis_generator, like:

$ pub global activate discoveryapis_generator
$ pub global run discoveryapis package -i /tmp/rest -o /tmp/stubs

and validate the generated client stubs are correct. If not it might be a shortcoming in the discoveryapis_generator (if it doesn't support the param type boolean). We would have to fix that subsequently then.

Ideally we should also add two unittests in the rpc/test/src/generator/generator_test.dart file. One for the above case and one for generating a client within an existing package. The setup is a bit convoluted, so I can take a stab at that later (you are of course welcome to do it as well).


You've forgotten to change the -p to -t :smile:


`message` in this case is just a string. I think you need something more like
```javascript
return this.props.message.map(function(message, i){
  return (<span key={"message"+i} className="input-message">{message}</span>);
});
```


hmmm, not sure I understand this but I think there is no way to delete the CA file once loaded since:
- the only way how to get here is to not have the certificate stored to a file yet
- after this, you can not get here and can not delete the file anymore

Am I right? If yes, I would say it may be better to have some option to switch between the "SPICE CA management" mode of this dialog and the "REST's CA management" mode. Some radio button on top or similar.


Sorry for too fast pushing. `s/typical/typeclass/` stupid autocorrect.


this whole method could be written as a single FluentIterable method chain


!!! :+1:


Unfortunately I'm not familiar with building native extensions in ruby so I can only make assumptions on solving that issue. If I understood well you're trying to require a file from ext dir? Rubygems suggests to add extentions in gemspec this way:
```
Gem::Specification.new "gem_name", "1.0" do |s|
  # [...]
  s.extensions = %w[ext/my_malloc/extconf.rb]
end
```
http://guides.rubygems.org/gems-with-extensions/


I'd say you don't need the full name of the package here.


done in later commit


I think you forgot to update `snapshotDate` (it's still `2015-04-27`).


Oh, damn! Thanks for the hint!


As I recall, because `/` is used as a separator in HDF5 infrastructure. Creating columns with that with PyTables failed. Hard. What the status is now I'm unsure. The total number of reserved characters is unclear to me. Furthermore, having crazy characters in column names will cause __serious__ issues with the PyTables query infrastructure. I would strongly advise treating column names as we would variable names.

/cc @joshmoore, @manics


First published in 1970, according to the Goodreads link.


please change the message to: "Missing the Certificate Authority for SPICE, do you want to import it now?"


Hi, I'm grammar nazi, how is your day? this should be `ignore_nonexistent`, `no_existent` is wrong


@Muflone Your copyright/Full Name will be restore in the files you have contributed to in the next days.


you should use `size` rather than `toList` to process the whole iterable, it saves creating a useless ImmutableList object
other option: implement `SumVariationMeasure` as a predicate which always returns `false` and use `FluentIterable.findFirst`


Bah alors, ça fait ses bails de son coté maintenant ? Dis moi comment te contacté, qu'on discute un peu trou d'uc.


please add some toast here that the console can not be opened in this case


same as above


Ok


Fixed. Nice catch! Sorry.


Agree, but at least this will be ok until the last version of Debian


Ok, didn't know about that. I thought it is required regardless of anything else.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Also see the PR https://github.com/Toxaris/coalgebraic-parsing/pull/3


@levicole backed out the Ajax delete but still have some sort of routing or NoMethodError pointing to Users#show. Not sure what I'm missing.


typo on commit message, s/where/were/


It's YOWH + /v/ #2


@zyx0225 thanx for the patch, please see the comments


this will fail with ArrayOutOfBoundException if the PeriodHolder contains for example Period{index=3}


@antenore, I'd recommend to restore all the copyright info within the files as other people are also copyright owners.


Okay, I will fix the syntactic issues and add some unit tests.

>In high-performance scenarios, this is rarely the case though, so a more natural design would be to identify >records in your binary protocol which are a natural sequencing point.

The problem is that there is no natural sequencing point in the binary file. The end is determined by the length field, which I read-out during the parsing. Therefore, I don't know the packet length during the import. That's why I read the entire file.


Swig没法直接上模版不是么 @Fsu0413


this class actually does not care about the input being a `List`, it could take an `Iterable`


thx!


We were doing that before. Extconf.rb generated the `Makefile` for building the library `symengine.so`. But we did that from cmake, and it is working fine so we removed the dependency on `mkmf`, earlier which we used to require in `extconf.rb`. Now I am trying to require `symengine.rb`, which in turn tries to [require 'symengine/symengine'](https://github.com/abinashmeher999/symengine/blob/ruby_file_structure/src/ruby/lib/symengine.rb#L1) where the extensions are. I think this requires the `symengine.so` file itself.


Yeah, I wonder if we could accomplish that by merging this hot fix branch into 2.0, and then to 2.1, and then to develop.


Shadowing outer local variable - `hash`.<br>Use `each_with_object` instead of `inject`.


Method has too many lines. [11/10]


Line is too long. [118/100]


you should not expose a `count` method but do all that in the constructor or you should reset the class state before looping over the issues
as is, if `count` is called twice in a row, the state will be twice the real count for the Issue collection this object was created for


Avoid rescuing the `Exception` class. Perhaps you meant to rescue `StandardError`?


indeed


I would like to test these filters only available in debug, and comment them or make them available at any time.
I think that if something is experimental, it should not be on master/develop: it should be a git branch...


OK, so IIUC the test is:

1. call `show()` and wait for it to complete
2. call `showPrevious()`
3. while `showPrevious()` is running, do the `checkReverse()` test
4. after `showPrevious()` completes, test is complete

In that case the code seems to make sense.


I agree.


Please, don't put this kind of message, because it WILL happen and you know it.

Either put a real error of remove it. If the modify itself fails `db.modify_ldif` should raise an Exception, so I think this whole check (the "if") is not needed


No worries, all of us have made the same mistake in the past, and will make it a few times in the future :)


use static import of `DumbComponent.builder` to lighten the code a bit, if possible


In this change we would maybe need another id for that new button.


I discovered something else too. I printed the value of `lib` after doing `lib = File.expand_path('../lib', __FILE__)`. Guess what I found.
``` bash
lib=/home/abinashmeher999/gsoc/symengine/src/ruby/spec/lib
```


even for getting data from table


I hope you're right that the code isn't needed anymore, but the comment on the old code says:

```
// Workaround for FF transitionend randomly dropped.
```

If there's really a case where one of the `transitionend` events doesn't occur, I'm not sure what happens with your new code.


Use 'err' to be consistent with the rest of the file.


Top mesmo


Not me! No more mistakes. Ever again. Yep.


class
def
end
end


Arg !


you are missing the MeasureAssert I've created in another PR here, to shorten this code :)


@coderhaoxin Sorry. FIxed.


I will add support to create the assertion directly from an `Optional<Measure>` for convenience and even shorter code in your case


Is the problem here that the structure of the response from SF depends on the type of error?

I suspect if there's one top-level error then you get `{"errorCode":123,"message":"Blah"}`, if there are multiple errors you get `[{"errorCode":123,"message":"Blah"}, {"errorCode":124,"message":"Foo"}]`.

Even in the second case we shouldn't just be returning the message / code from first one and binning the rest. @arthurguy - could we just set:

```php
$this->error = json_decode($requestBody, true);
```

instead and not worry about trying to parse the response?

Or alternatively some nightmarish fallback:

```php
$this->errorCode = $error[0] ? $error[0]['errorCode'] : $error['errorCode'];
```


might make sense to unregister metrics last since extensions may still send / receive messages up until the node has been stopped?


@weberhofer yes, it'll be done in the next hours/days, don't worry, I see that I've caused some troubles with this commit

A note for everybody.

Remmina was, is and will be always of Vic Lee (aka @llyzs ).

The https://github.com/FreeRDP/Remmina/graphs/contributors doesn't say the whole story, that is written in the history of each file (and each Branch and Forks) since Remmina exists. That page is a picture of the main branch.

The Copyright notice 2014/2015 it's for me and Giovanni that have resurrected and kept alive Remmina since almost one year. Some contributions to the code doesn't make the whole project to anybody except Vic Lee, till he will decide otherwise.


use named parameters


Inject via DI


`addPeriod` takes a vararg, you could make a single `addPeriod` call


This closes #30


isn't this a good opportunity to add a `putIssues` override which takes a vararg of `Issue`?


This is the first commit that even went through. I am not sure why the delete didn't happen.


@dirkschumacher Please fix: `management` not `managagement`.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


should be static


If those are meant to be specified by subclasses, let's make them abstract.


FWIW, r=me for this very change.


ok


It's probably worth it to have a decorator, like:

```
def deprecate_method(func):

   @wraps(func)
    def the_func(*args, **kwargs):
        """ generate a warning message for a deprecated function, then call the function """
        warnings.warn("%s will be removed in a future version" % func.__name__, DeprecationWarning)
        return func(*args, **kwargs)

  return the_func
```

in storage_log module and use that for getting the warnings into the deprecated methods.


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/6d632f6aa4f56c0f5dcbdb2edf986500fc3f3e77/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/6d632f6aa4f56c0f5dcbdb2edf986500fc3f3e77/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/6d632f6aa4f56c0f5dcbdb2edf986500fc3f3e77/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/6d632f6aa4f56c0f5dcbdb2edf986500fc3f3e77/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/6d632f6aa4f56c0f5dcbdb2edf986500fc3f3e77/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


:raised_hands: Thanks to @Netmisa


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It could be and if you want me to update it, I will.

My git flow process is to use _01 until right up until a release when I change to the next number. That way, if I install locally, or make test distributions I don't have two 0.93 to confuse me.


kjdfkljdkfl


glfdşglfdlp


оформление не верное. Добавьте пробелы после двоеточия. И пробелы перед {


Something is wrong here - you are importing JFolder from the JFile location!


This should be in the same function that creates the builder.


Why the love? It's not my Answer.


import_pgp does not return anything now, I think you should remove the success_pub variable


for the record, I don't agree on this change, it weakens the bean's contract
in addition, you made public a which do not even enforce the constraints on the index value cleanly and its not even documented
also there is some code formatting issue


It is useful to avoid managing too much branches.
In all case, we cannot change the past, so it is better to do that explicitly with TUTTLE_EXPERIMENTAL.


I would suggest to use **jarSourceAndMavenUri.entrySet()** for more efficiency and avoid a get at every iteration.


# Principle
distance=1000;
if {  abs(pos.coords.longitude-target.longitude)<distance &&  abs(pos.coords.lattitude-target.lattitude)<distance) card.show(); }

# Resources
http://developer.getpebble.com/guides/js-apps/js-other/
http://developer.getpebble.com/docs/pebblejs/
http://stackoverflow.com/questions/tagged/cloudpebble


Excellent !
1) Yes
2) Yes
PS => OK when you want
PPS : mm interesting we might need to change the way we call the api then.

Can you add all those in the to do list (the classic google one) => I'll add this as pulses with deadline and owners afterwards.

Thanks rock, u rock


This was a merge test but very complicated.


Need to check return value from builder calls.


i forgot it, of course :)


I know it’s minor, but we are the 19th on june. ;)


Thankyou for finding this, getting recent builds of Jedis to work has been a total nightmare and I had no idea why!


и куда -$base-text-interval: 14px !default; дели?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Нет, давай лучше допишем в curl_httpclient обработку DELETE
вот сюда https://github.com/tornadoweb/tornado/blob/master/tornado/curl_httpclient.py#L391


ok


I had to use some obscure mailing list post to figure this out. Here's a link to save you some trouble: https://minimum.io/bungeecord-and-latest-jedis-caveat-classloading-nightmare/


@Mindbreaker1
No i believe first is normal bonus and second is "supported by pawn" bonus.


Similar to above


I'll go for the first option


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I know the @PyTables folks recently worked on allowing *more* use of `/`, but that won't apply to most installed versions. But using a slash in either the column *description* or a column *value* should be fine.


We are glad that you find jangouts useful for your business model. We would be even more glad if you keep a note about the original copyright holders.


right !


The mutex is already locked here.


this recurse inside checkConnect when we are called from checkConnect


The state?


Some of these descriptions are phrased as describing a noun. Others as a question. I myself do not care too much, but keep in mind that we like to be consistent.


Ok


I'm aware ;)


The "part with Alternative f" in my previous post was about the `pure` combinator for Automaton, which has to be very differend from the `pure` combinator for Parser.


that's probably ok because the database is already open on the second call.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


will that not be a problem because e is unknown in this scope?


Good catch


This clearly is the same as $self->{term}->[1], but if someone can elucidate why that's the case, I'd be grateful.


ok


I like how the code of this unit test turns up, short and clear :)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Obviously, you are not using .travis.yml locally, are you ? So this is the only thing that could explain the error… can you revert it back like before and see if test pass again locally ?


Not in master :)


Well, we needed something in the README b/c you can't run the site per the instructions. You should change the README to account for the makefile.


BTW, should not be **Sonata**AdminSearchBundle?


Should this comment by changed?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


No yet, because in fact issues will not be read from the report but from the "Tracked Issue" that Simon is working on!
So it will be refactored.


LOL!!


OK, published.


droljo


I should.


diste kipa


Travis is now using system installed phpunit.

BTW, I have the same phpunit version as required on your actual composer config and got the error.


LOL!


Not if you look at other bundles.


Yes, see e7b784d98354e1344befb77d3d9ce35b453c6c37


Thanks!


No, because it's redundant with inner !


No, because it would be redundant with inner !


This commit has two unrelated changes:

 (1) change the semantics of `delegate` and introduce a new `delegateOnce` with the old semantics
 (2) add a comonad-inspired interface to Parsers.

What is the point of change 1?


This seems to be the problem. vendor/bin/phpunit passes


Immer wenn ich dich aus meinem Fenster seh, Klapp ich meinen Laptop zu denn ich kann nicht wiederstehen


I think ArgSetting descriptions should have the first char upper cased. May I ask for why they aren't.
Since it used to be a mix, but they all seem to be lowercased now, I suppose there is so me I kind of rationale behind it.


Indeed, I try to learn and apply !


The point of (1) is to define the Cobind instance by `duplicate == delegate` and treat this one as primitive while `delegateOnce` is derived.


@rande told me he was using the system's phpunit to speed the builds, but now that we are using a cache, is it really worth it ?


Hi,
e107_handlers/np_class.php is used by the survey plugin...
require_once(e_HANDLER."np_class.php");

Should i change that to require_once(e_HANDLER."form_handler.php"); now?

Alex


Many message we currently send are short and concise. Could we avoid usage of "you want". There might be similar phrasing which should also be changed, but "you want"maws used many ti


Hey, TWRP ain't working. Can you fix it? And yeah, ik, I used twrp trees only, this was the only way to inform you :p


I reverted this pull request  ( #586 ), but we have to clean it because each Remmina files contains the Copyright notice with Me, Fabio and Giovanni.

I'll keep you in the loop.


part[2] makes an assumption about format of 'type' parameter, additional check for 'parts' size won't hurt.


Right, I haven't updated `snapshotDate` because the compiler needs to be built with the same snapshot as before. Notice that I haven't updated `snapshotHash*` either.


Торнадо следует HTTP спецификации. Давай тоже следовать.


This won't work, as the arguments dictionary always contains both of these keys, they're just set to the default value of `None` if they were not specified on the command line. The result is that every invocation of the module will result in this failure message.


true, it's an enum!


나무ㄴ...?


Sure, but couldn't we do that without changing names?


From my testing they don't return more than one error at a time and the error was always in an array hence the [0].

I have had to put a lot of messy error handling into code in the past which leads me to believe the errors being returned aren't very consistent and some extra handling may be needed.


@tbursztyka  Done, thanks!


нужно использовать FactoryGirl


Bylo by lepší vytvářet objekty nějak genericky pomocí jQuery.appendTo() například. Můžeš se inspirovat třebat tím co děláme v https://github.com/progma/prAk/blob/master/public/coffeescripts/course.js/pagedesign.coffee


Hi @andoma. Does this recent change affect / improve this other subtitles issue? ---> https://movian.tv/issues/2231

Is it worth for me to re-test the default subtitles setting on HTSP?


1. true.

2. I don't think it would be better to force using `==` instead of comparing identifiers. Please notice that
2.1 They actually do the same (identifiers comparison)
2.2 Creating `==` could create potentially some issues.

I also promote operator overloading, but in my opinion in this particular case would be better to leave it as is.


This approach will override .api_version already set, it also should follow the approach from the other functions in flow-builder, once you got the type, this function should fail (please check other functions).


Better solution is to use something like this.
foreach ($record['context'] as $key => $val) {
                $val = is_object($val)? (array) $val : $val;
                $message['context'][$key] = $val;
            }


well, it's still a nice-to-have in `BatchReportReaderRule` :)


\+ nettoyage code inutile


:+1: :


Fixes #1, tested on iPhone and iPad with iOS 8.


> This seems to be the problem. On my machine vendor/bin/phpunit passes, and phpunit does not

Yes, but it's not a solution. Please see: https://github.com/sonata-project/SonataAdminSearchBundle/pull/16#issuecomment-113506010

> @rande told me he was using the system's phpunit to speed the builds

Is not only about installation speed but also (and mostly IMO) dependencies issues.

Indeed, phpunit has a lot of dependencies. We can have risk to make conflict by including them.

I'm thinking of doing the same (separation) for cs-fixer, later.


I will leave it to Simon :)


shorter and better to look at: `new Double[5]`


I planned to implement more variants of delegate like `delegateOnce`, `delegateUntil`, `delegateWhile`, ... all based on the new `delegate`. Are you not happy with `delegate` as a primitive as it is defined in this commit?


@jimis: I put this back for now, it was happening very frequently for me (see commit message). Feel free to remove it if you find a way though.


@pana1990 what do you mean by other comments?


Indeed !


FYI I committed changes (52fa6651da38e344ad0b115ac6b86d84a2ff8401). If you don't agree please pass that commit.


I rewrote the commit (179b00b07c2c9930df4c61506de194497e711511) to include your suggestion.


Alteracao-favicon


In what branch did you commit this? There does not seem to be a pull request?


I see what you mean and it is a valid point indeed, reminds me of https://github.com/composer/composer/issues/4110


Lowercasing arg descriptions comes from cayoriins implemention in massivecore where all the descs are lowercase in the first letter. If we want to be consistent, it needs to be the same everywhere...sure we can change it though ^^


not sufficient to fix the bug. Will submit a new fix.


No, looks good to me. I just didn't understand the rationale for renaming things. Now I do.


what about creating the tree per iteration? That would help this benchmark focus on insert speed without potentially leading to slowdowns from lots of memory growth when run under many iterations.


:ok:


Thanks for pointing. I will fix it in my next push.


Because the Ledger integration has been done directly from the Coinkite cosigning page


small update


@chris5560 新版musl下不能正常运行？


@manupap1 Can I check your assumption here that Version_Micro <100 = Libav. Which assumes that everyone using ffmpeg is >0.8 I am looking to use the same function elsewhere and I just wanted to confirm my understanding of your logic is correct.


TeamCity xBIM :: XbimExchange :: Build [Build 351](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1890&buildTypeId=XBIM_XbimExchange_Build) is now running


Hahahaha! I knew that one of these would sneak into a commit one day. Oh well... ;-)


TeamCity Ybackend :: synteny/ybackend [Build 38](http://192.168.30.225:8111/viewLog.html?buildId=1363&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


`Processed` refers to when the order has been delivered I think, we could have another status Paid maybe?


Because babel throws if we don't have the package installed.


Sorry I see. :-)


Thanks!


Nope. The HTSP is no different.


=]
I won't throw you the first stone ;)


Awesome, I was just about to add this myself. :)


TeamCity xBIM :: XbimExchange :: Build [Build 351](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1890&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:31


Right. Need to compare truthy-ness. Fixed: e203087aaabea0c0cefe6ae3d1b072ecbde84cf8


Thinking ahead to the grid parser, the ``delegate p `intersect` ...`` pattern looks very useful. We want something like ``delegate p `intersect` replicateM n anyToken`` there to process one line of a column of length n.


extra div? the t-if can be done on the em, no?


This tackles #3.


updated.


I agree with using releases for the final push but I'd argue that keeping a change log makes it easy to quickly skim through changes and, more importantly, it's quite handy to build the next's release notes as you code. I know that we can draft a new release but at the end of the day it's an external step to our local environment (i.e., it's not a text file) so that makes it easier for us to forget about adding those as we go?


Ah, I thought it was used to construct the version of the resulting package. Thanks!


Its better to make this two separate `expect` calls so that if there's a failure, you can get a breakpoint on the condition that fails


ok


`jss::OfferSequence`?


On 06/19/2015 12:30 PM, romjerome wrote:
> Thanks.
>
> I am now building from a more recent "environment" (set of libs).
> Updated my local git repo (gramps42) with:
>
> diff --git a/debian/control b/debian/control
> index 3db9ea6..7b933b2 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -7,8 +7,8 @@ Build-Depends-Indep:
> gettext,
> intltool,
> libxml-parser-perl,
> - python-all,
> - python-setuptools
> + python3-all,
> + python3-setuptools
> Build-Depends:
> debhelper (>= 9.0.0)
> Standards-Version: 3.9.5
> diff --git a/debian/patches/0001-Correct-resource-path-in-setup.py.patch
> b/debian/patches/0001-Correct-resource-path-in-setup.py.patch
> deleted file mode 100644
> index d5067b3..0000000
> --- a/debian/patches/0001-Correct-resource-path-in-setup.py.patch
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -diff --git a/setup.py b/setup.py
> -index 3f702ae..9622d75 100644
> ---- a/setup.py
> -+++ b/setup.py
> -@@ -248,7 +248,7 @@ class install(_install):
> - 'utils', 'resource-path')
> - with io.open(resource_file, 'w', encoding='utf-8',
> - errors='strict') as fp:
> -- path = os.path.abspath(os.path.join(self.install_data, 'share'))
> -+ path = '/usr/share'
> - if sys.version_info[0] < 3:
> - path = unicode(path)
> - fp.write(path)
> diff --git a/debian/patches/0002-Disable-HTML-View.patch
> b/debian/patches/0002-Disable-HTML-View.patch
> deleted file mode 100644
> index 1a90722..0000000
> --- a/debian/patches/0002-Disable-HTML-View.patch
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -diff --git a/gramps/plugins/view/htmlrenderer.py
> b/gramps/plugins/view/htmlrenderer.py
> -index c41942a..8f35b16 100644
> ---- a/gramps/plugins/view/htmlrenderer.py
> -+++ b/gramps/plugins/view/htmlrenderer.py
> -@@ -122,11 +122,12 @@ user_pref("general.useragent.locale, %(lang)s);
> -
> - TOOLKIT = NOWEB
> -
> --try:
> -- from gi.repository import WebKit as webkit
> -- TOOLKIT = WEBKIT
> --except:
> -- pass
> -+#Disable webkit as it is causing a crash in Gramps 4.0.2
> -+#try:
> -+# from gi.repository import WebKit as webkit
> -+# TOOLKIT = WEBKIT
> -+#except:
> -+# pass
> -
> - #no interfaces present, raise Error so that options for GeoView do not
> show
> - if TOOLKIT == NOWEB :
> diff --git a/debian/patches/series b/debian/patches/series
> deleted file mode 100644
> index def1e53..0000000
> --- a/debian/patches/series
> +++ /dev/null
> @@ -1,2 +0,0 @@
> -0001-Correct-resource-path-in-setup.py.patch
> -0002-Disable-HTML-View.patch
> diff --git a/debian/rules b/debian/rules
> index 157ace8..a56c2bb 100755
> --- a/debian/rules
> +++ b/debian/rules
> @@ -3,9 +3,10 @@
> # Uncomment this to turn on verbose mode.
> export DH_VERBOSE=1
> export DH_OPTIONS=-v
> +export PYBUILD_NAME=gramps
>
> %:
> - dh $@ --with python3
> + dh $@ --with python3 --buildsystem=pybuild
>
> # Override auto test because upstream do not use the standard unittest
> discover
> override_dh_auto_test:
> @@ -18,12 +19,12 @@ override_dh_auto_build:
> override_dh_auto_install:
> #dh_auto_install
> # Remove duplicate copyright information
> - rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/COPYING
> + #rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/COPYING
> # Remove install file as it is not needed by package users
> - rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/INSTALL
> + #rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/INSTALL
> # Remove duplicate license information
> - rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/LICENSE
> - ln -s /usr/share/common-licenses/GPL-2
> $(CURDIR)/debian/gramps/usr/share/doc/gramps/COPYING
> + #rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/LICENSE
> + #ln -s /usr/share/common-licenses/GPL-2
> $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/COPYING
> python3 setup.py install --resourcepath=/usr/share
> --root=debian/python3-gramps --install-layout=deb
>
> # Make css style sheets and png icons non-executable
> @@ -31,6 +32,13 @@ override_dh_fixperms:
> dh_fixperms
> chmod a-x $(CURDIR)/debian/python3-gramps/usr/share/gramps/css/Web_*.css
>
> +# Fix clean target
> +override_dh_clean:
> + rm -rf data/tips.xml
> + rm -rf gramps/plugins/lib/holidays.xml
> + rm -rf po/.intltool-merge-cache
> + dh_clean
> +
> # Avoid compressing COPYING file so that it can appear in the "About" dialog
> override_dh_compress:
> dh_compress -X COPYING
>
> I still have the "lintian error" for the python script launcher. :-(

Probably can be ignored anyway if it works.

> There is also something else because the generated package is now
> missing the images!!! Is it related to the package name via pybuild?

Hmm, it is hard to say without the buildlog. Are you sure setup.py is
generating them? If you know the paths to them, you could try listing
them in debian/install incase they are built but not installed (although
pybuild should take care of that).
You could try dropping the python3-gramps package name and going back to
plain old gramps (but that would have to be changed in quite a few
places). If we only ship python3 for Gramps 4.2 then we don't need to
distinguish between the python versions.


delete this line?


> Hm, I did not find any indication in the Cube files that pointed to a device having this feature.

It might be part of every STM32. But it is not a property of the cortex IP from ARM. Therefore I think it should not be included with the core.


commit message a little weird.  replace "stress" by "emphasize".  Also, a more descriptive title would be good.


Actually, Tribemedia cannot claim copyright on the complete product, only on their contributions/changes.


Hello!


What's this for?


I've sent a reproducer upstream:
http://permalink.gmane.org/gmane.comp.gnu.libidn.general/573

libidn2 is for a different purpose (following different protocols), so moving to it would make no difference in that aspect. The only real solution would be to fix libidn...


Fixed. Thanks


I think this only works if you set your whitespace settings correctly in your gitconfig file…


Ack


TeamCity Ybackend :: synteny/ybackend [Build 38](http://192.168.30.225:8111/viewLog.html?buildId=1363&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 16; exit code 1 Build time: 00:10:48


Ack.


This will also need to work with any future alternative Tables backends, so best to keep it simple.


works


Implemented this as `delegateN` in 586426080abfee0f9adc37721a88d882cd626a36


"
There are some limitations to starting containers with `weave run`:

- containers are always started in the background, i.e. the equivalent of always supplying the `-d` option to `docker run`,
- the `--rm` option to `docker run`, for automatically removing containers after they stop, is not available,
- the weave network interface may not be available immediately on container startup


Removed


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 315](http://192.168.30.225:8111/viewLog.html?buildId=1365&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


I think we need to rename this function. If it's going to address highlights specifically, then `getYValsAtIndex` isn't appropriate anymore...


Should we also have ``while p q = fmap snd (p `intersect` q)``. Note that I choose `snd` there so that we can write:

~~~haskell
while (noneOf "\n\r") $ do
  something
  complicated
  which has (to be one) line
~~~

That is: Because of do notation, it is more convenient to have a simple parser as first argument and a complex parser as second argument. And I assume that often, we want to return the result of the complex parser and use the simple parser for some side condition. So it feels more practical to return the result of the second parser.


I recently noticed that KOReader had started doing obnoxious reboots when you exit it — something I do quite rarely. The reason is obvious:

```
PID   USER     TIME   COMMAND
    1 root       0:00 init
    2 root       0:00 [kthreadd]
    3 root       0:00 [ksoftirqd/0]
    4 root       0:00 [events/0]
    5 root       0:00 [khelper]
    8 root       0:00 [async/mgr]
    9 root       0:00 [pm]
   60 root       0:00 [usb_wakeup thre]
   61 root       0:00 [usb_wakeup thre]
  112 root       0:00 [sync_supers]
  114 root       0:00 [bdi-default]
  116 root       0:00 [kblockd/0]
  128 root       0:00 [mxc_spi.2]
  136 root       0:00 [khubd]
  151 root       0:00 [kmmcd]
  208 root       0:00 [swapper]
  212 root       0:00 [zq_calib]
  218 root       0:00 [kswapd0]
  265 root       0:00 [aio/0]
  275 root       0:00 [crypto/0]
  284 root       0:00 [EPDC Submit]
  286 root       0:00 [EPDC Interrupt]
  289 root       0:00 [tps65185_PWRGOO]
  291 root       0:00 [tps65185_INT]
  376 root       0:00 [kapmd]
  426 root       0:00 [kconservative/0]
  430 root       0:00 [mxc_chg]
  431 root       0:00 [pmic_battery.1]
  435 root       0:00 [esdhc_wq/0]
  437 root       0:00 [esdhc_wq/0]
  439 root       0:00 [esdhc_wq/0]
  458 root       0:00 [mmcqd]
  464 root       0:00 [jbd2/mmcblk0p1-]
  465 root       0:00 [ext4-dio-unwrit]
  466 root       0:00 {rcS} /bin/sh /etc/init.d/rcS
  470 root       0:00 [mmcqd]
  476 root       0:00 [flush-179:0]
  496 root       0:00 /sbin/udevd -d
  504 root       0:00 [EPDC Submit]
  519 root       0:00 /bin/dbus-daemon --session --print-address --fork
  520 messageb   0:00 /bin/dbus-daemon --system
  722 root       0:00 {sd} /bin/sh /usr/local/Kobo/udev/sd
  776 root       0:00 {plug} /bin/sh /usr/local/Kobo/udev/plug
  779 root       0:00 {plug} /bin/sh /usr/local/Kobo/udev/plug
  780 root       0:00 sh /mnt/onboard/.kobo/kbmenu/onstart/koreader_kobo.sh
  782 root       0:00 sh /mnt/onboard/.kobo/koreader/koreader.sh /mnt/onboard/.books
  783 root       0:00 ps -A
```

How about this instead?
```
if ! pgrep -f kbmenu > /dev/null 2>&1 ; then
```


Merge with upstream


@richardTowers - I really like the first solution you've proposed. For my purposes anyway, just returning the error as an array would be fine with me. I can find the errorCode key in there myself and do with it what I need to.


orgasm


looks good to me!


both "then" seem to be unnecessary


@CsabaSzabo Can you please make the Installation one section, and add the with/without cocoapods as a subsection? Thank you!


Please put the `super` call at the end of the method.


That's a very good point, @manics. For reference, the MongoDB naming restrictions:
 * http://docs.mongodb.org/manual/reference/limits/#naming-restrictions


Revert the default avatar initialization change.


I'm tempted, but I would probably have to use lambda because of the second argument.

now in turn that would take care of filterfalse


Place the `super` call after writing `outState` to the `Bundle`.


Just use the `mSelectedAvatar` with the current initialization.


Yes, that's exactly the test


Have changed the pin mux for the i2c1 config


Is the key derivation path for the "old" Export Key method incompatible with the "new" directly-via-coinkite method ?

The "old" method required the COINKITE_API_KEY and COINKITE_API_SECRET.

In my case it used the derivation path

    0xb11e'/0xccc0'

Attempting to cosign a "new" coinkite+ledger multisig, with the "old" ledger coinkite app fails.

I can see the Cosignature request correctly polls the API key via the Coinkite `API Debug Live Stream`

The details of the cosigners are all correct, when compared to the downloaded .json file, however the ledger wallet coinkite app fails. `INVALID TRANSACTION : The Ledger Nano is not a cosigner of this transaction. Impossible to continue.`

Whereas without unplugging my HW wallet, linking directly from Coinkite's cosign page works, without any trace on the `API Debug Live Stream`

There needs to be a downloadable, offline, open source method for users to co-sign a "new" Coinkite multisig transaction with a Nano, that does not necessarily require Chrome 38+

Otherwise could the "old" coinkite app be updated to at least be forwards compatible with "new" coinkite multisig vaults ?


@livingincode DWMR. Good work here. Lean into this!


I have just discovered another error case where neither of those will work!
I have made a change for that will push an update once I have tested it.

@cwramsey Do you have an example that will demonstrate the error you found?


TeamCity xBIM :: XbimWindowsUI :: Build [Build 8](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1894&buildTypeId=XBIM_XbimWindowsUI_Build) is now running


This change breaks my vanilla forum 2.2b1 install big time. PLease consider any side-effects of using this in older apache envs


how can we implement a combinator `until p q` that delegates to `p` until `q` is fully matched and then returns the state of `p` before the first match of `q` took place?

Example:
~~~
p = counting
q = string "##"
results $ results (parse "aaaa##" (until p q)) == 4
~~~


It's an override to tell Spring Boot to switch to Java 8. See http://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#using-boot-maven-java-version


@surayashivji DWMR. Press on!


maybe it should be "has_shell_window"?


TeamCity xBIM :: XbimWindowsUI :: Build [Build 8](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1894&buildTypeId=XBIM_XbimWindowsUI_Build) outcome was **FAILURE**
Summary: Compilation error: PluginBCF\xBIM BCF Plugin.csproj (new) Build time: 00:01:52


Can't you also check if this \*.so really exists? I think you can output it to travis log with something like ``` puts Dir["#{lib}/symengine/*"] ``` to see what files are in lib/symengine dir.


Good finding. Can you make a separate PR with just this commit to merge it ASAP? This cause tests on many PR to fail (@carriepl @lamblin)

If I don't have a reply in the next 30m, I'll do it. thanks.


:+1: :smile: thanks !


nice. thanks.


I believe this is correct.  I seem to recall using the same kind of checks elesewhere.

Reminds me we need to implement checking using the same method as the vlc project.... ugh, that's going to be a monster.

Example on CentOS 6:
```
ffmpeg version 0.10.15 Copyright (c) 2000-2014 the FFmpeg developers
  built on Aug 30 2014 15:49:19 with gcc 4.4.7 20120313 (Red Hat 4.4.7-3)
  libavutil      51. 35.100 / 51. 35.100
  libavcodec     53. 61.100 / 53. 61.100
  libavformat    53. 32.100 / 53. 32.100
  libavdevice    53.  4.100 / 53.  4.100
  libavfilter     2. 61.100 /  2. 61.100
  libswscale      2.  1.100 /  2.  1.100
  libswresample   0.  6.100 /  0.  6.100
  libpostproc    52.  0.100 / 52.  0.100
```

Example on Ubuntu 15.04
```
avconv 11.2-6:11.2-1
libavutil     54.  3. 0 / 54.  3. 0
libavcodec    56.  1. 0 / 56.  1. 0
libavformat   56.  1. 0 / 56.  1. 0
libavdevice   55.  0. 0 / 55.  0. 0
libavfilter    5.  0. 0 /  5.  0. 0
libavresample  2.  1. 0 /  2.  1. 0
libswscale     3.  0. 0 /  3.  0. 0
```


for info see: Retrospring/bugs#1


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 315](http://192.168.30.225:8111/viewLog.html?buildId=1365&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:36


Or try [QuickFile](quickfile.co.uk) as a free alternative. My accountant recommended it, and integrates very well with it.


This change make the test useless. I'll try to find another fix and make a PR to fix it.


Thanks! BitHub has sent payment of  $8.26USD for this commit.


Fix for  nyquist/dspprims.lsp  from rdb, which he will push upstream in due course.


Obviously these two tests are exactly same except the Tab


What version of Apache are you using?


not doin' it tbh.

let's stay readable:
```
    end_pos = None
    for match in re.finditer('\\)', pattern):
        if not _position_is_bracketed(pattern, match.start()):
            end_pos = match.start()
            break

    start_pos = None
    for match in reversed(re.finditer('\\(', pattern[:end_pos])):
        if not _position_is_bracketed(pattern, match.start()):
            start_pos = match.end()
            break
```


Thanks for sorting this out!


... and I don't understand the 2nd sentence at all. Maybe rephrase it?


need to remove listener (offWindowResize)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16554/testReport/) for this commit**


##this is a markdown file


You can cherry pick it.


But now it just doesn't need light in general?


Here there is a possibility of a conflict, and hence, you should, in this method, raise conflict exception, otherwise handle_conflicts is useless.

Maybe just keep it like this. This is because I'm anyway going to change the handle_conflicts decorator. Once I'm done, I'll fix this up.

As tempest tests are passing, seems like tempest guys have not written proper tests :)


I don't like this, you abused github's "fixed" functionality to close goof's PR. I hope there are rules for things like this in the future.

:angry:


Have you tested this? I once had Atom not include all of my snippets because there was a blank line in the file.


That was what cyanide requested.


not ok, need to be tested with new design


shoot, I did this way too early in the morning ;-)


In header files, definition should not include argument names, only types.


use o_web_client


Mkay. Still don't know why the original code never worked...
It should've


I think that is something we have to define:

Do we just want to see objects in the TreeBrowser that are already on the server? -> the check would be needed of course
Or do we also want to allow the offline creation of xnat objects and then  synchronise them to the server, e.g. with session->save() -> no check needed


%lu is the wrong type. Try %zu.


For which date it get date before 3 day ?? Need to pass stored first login date


check it ?


Indent should be in multiple of 4 spaces.


Yay! :+1:


if an exception is raised, ref will be none, and nonetype doesn't have method to_dict() :)


Souhlasim.


The use case is with averages which a lower value is better such us Pace/Swim Pace/xPace/xPace Swim. an alternative could be to have another type for these (AvgLow?) and remove this method.


Only minor: but I think this break is meant to be within the above curly_braces.


Use a char * and safe_strdup() to allocate the path instead of a fixed size buffer. Further, if you do that, you can remove safe_pid altogether and use pidfile != NULL has equivalent.

You do need to make sure that when the conf struct is allocated, pidfile is initialized to NULL.


Ok.


I think these incref's should be removed.  PyErr_Fetch already gives the call the caller the reference to the objects it returns.


@KrauseFx Yes, SSLv2 and v3 are considered insecure [1], and TLS should be used instead.

[1]https://blogs.akamai.com/2014/10/ssl-is-dead-long-live-tls.html


**jupi**
*suvi genije*


Ad 1, ok.
Ad 2, prijde mi, ze to je do zadani zbytecny detail?


@cindychangy DWMR (done with my review). Looks good. Press on!


Again, only minor... but I think you meant have a break here.


with this system we can add 62 flags before it hits the BIGINT limit

at which point we need to either store it as a string and then parse it later, or add a second column.


Nice solution.  Maybe we should have the PyExc type as a parameter.  It would allow the code to be more specific with its failure modes (i.e., TypeError when a value is incompatible with the schema, IOError when there's an I/O problem, etc.)


@cindychangy DWMR. Looks good. Lean into it!


Use safe_strdup and a pointer. Your code here has an off-by-one bug in it because strncpy does not guarantee that the NUL byte will be added at the end of the buffer if the optarg is exactly 255 bytes or longer.

Per the man page:

>        The strncpy() function is similar, except that at most n bytes of src
>       are copied.  Warning: If there is no null byte among the first n
>       bytes of src, the string placed in dest will not be null-terminated.


Why?

Remember your changelog needs to state the "why", not the "what". Even if both are obvious (to you), the "why" is what really matters. People can always see the "what" from the diff, not the "why".


Are we not removing the entry and instead just setting is_deleted() to false? I thought we decided otherwise. What does mdb implementation have?


Ok, but the intention was to load 1.1?


Maybe not good to call malloc() between fork and exec?


Lets leave it, you never know what metric might come along and surprise us :)


Pull request (https://github.com/collectiveaccess/providence/pull/209) accepted for this fix.


Ja myslel, ze ty limitations tu prave vypisujeme... :) To samozrejme muze byt v bakalarce napsane taky, ale zadani bych doporucoval drzet strucne a psat tam jen ty zasadni veci.


I need to look further but the generated .deb file is lighter (~3Mo)!
Images were into temp root (debian build) and I thought that
"3Mo means missing images", but they seem to be added... :-/

I will commit two changes on current gramps42 git repo:

diff --git a/debian/control b/debian/control
index 3db9ea6..309977d 100644
--- a/debian/control
+++ b/debian/control
@@ -7,15 +7,15 @@ Build-Depends-Indep:
  gettext,
  intltool,
  libxml-parser-perl,
- python-all,
- python-setuptools
+ python3-all,
+ python3-setuptools
 Build-Depends:
  debhelper (>= 9.0.0)
 Standards-Version: 3.9.5
 Vcs-Git: git://anonscm.debian.org/collab-maint/gramps.git
 Vcs-browser: http://anonscm.debian.org/gitweb/?p=collab-maint/gramps.git
 Homepage: http://www.gramps-project.org/
-X-Python-Version: >= 3.0
+X-Python-Version: >= 3.2

 Package: python3-gramps
 Architecture: all
diff --git a/debian/rules b/debian/rules
index 157ace8..4f38c19 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,7 +5,7 @@ export DH_VERBOSE=1
 export DH_OPTIONS=-v

 %:
-	dh $@ --with python3
+	dh $@ --with python3 --buildsystem=pybuild

 # Override auto test because upstream do not use the standard unittest discover
 override_dh_auto_test:
@@ -17,14 +17,14 @@ override_dh_auto_build:
 # Override of auto_install to remove information from package
 override_dh_auto_install:
 	#dh_auto_install
+	python3 setup.py install --resourcepath=/usr/share --root=debian/python3-gramps --install-layout=deb
 	# Remove duplicate copyright information
 	rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/COPYING
 	# Remove install file as it is not needed by package users
 	rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/INSTALL
 	# Remove duplicate license information
 	rm $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/LICENSE
-	ln -s /usr/share/common-licenses/GPL-2 $(CURDIR)/debian/gramps/usr/share/doc/gramps/COPYING
-	python3 setup.py install --resourcepath=/usr/share --root=debian/python3-gramps --install-layout=deb
+	ln -s /usr/share/common-licenses/GPL-2 $(CURDIR)/debian/python3-gramps/usr/share/doc/gramps/COPYING

 # Make css style sheets and png icons non-executable
 override_dh_fixperms:

and:

iff --git a/debian/patches/0001-Correct-resource-path-in-setup.py.patch b/debian/patches/0001-Correct-resource-path-in-setup.py.patch
deleted file mode 100644
index d5067b3..0000000
--- a/debian/patches/0001-Correct-resource-path-in-setup.py.patch
+++ /dev/null
@@ -1,13 +0,0 @@
-diff --git a/setup.py b/setup.py
-index 3f702ae..9622d75 100644
---- a/setup.py
-+++ b/setup.py
-@@ -248,7 +248,7 @@ class install(_install):
-                                      'utils', 'resource-path')
-         with io.open(resource_file, 'w', encoding='utf-8',
-                      errors='strict') as fp:
--            path = os.path.abspath(os.path.join(self.install_data, 'share'))
-+            path = '/usr/share'
-             if sys.version_info[0] < 3:
-                 path = unicode(path)
-             fp.write(path)
diff --git a/debian/patches/0002-Disable-HTML-View.patch b/debian/patches/0002-Disable-HTML-View.patch
deleted file mode 100644
index 1a90722..0000000
--- a/debian/patches/0002-Disable-HTML-View.patch
+++ /dev/null
@@ -1,22 +0,0 @@
-diff --git a/gramps/plugins/view/htmlrenderer.py b/gramps/plugins/view/htmlrenderer.py
-index c41942a..8f35b16 100644
---- a/gramps/plugins/view/htmlrenderer.py
-+++ b/gramps/plugins/view/htmlrenderer.py
-@@ -122,11 +122,12 @@ user_pref("general.useragent.locale, %(lang)s);
-
- TOOLKIT = NOWEB
-
--try:
--    from gi.repository import WebKit as webkit
--    TOOLKIT = WEBKIT
--except:
--    pass
-+#Disable webkit as it is causing a crash in Gramps 4.0.2
-+#try:
-+#    from gi.repository import WebKit as webkit
-+#    TOOLKIT = WEBKIT
-+#except:
-+#    pass
-
- #no interfaces present, raise Error so that options for GeoView do not show
- if TOOLKIT == NOWEB :
diff --git a/debian/patches/series b/debian/patches/series
deleted file mode 100644
index def1e53..0000000
--- a/debian/patches/series
+++ /dev/null
@@ -1,2 +0,0 @@
-0001-Correct-resource-path-in-setup.py.patch
-0002-Disable-HTML-View.patch
diff --git a/debian/source/local-options b/debian/source/local-options
deleted file mode 100644
index 4aceb10..0000000
--- a/debian/source/local-options
+++ /dev/null
@@ -1 +0,0 @@
-unapply-patches

Thanks!


TeamCity Ybackend :: synteny/ybackend [Build 39](http://192.168.30.225:8111/viewLog.html?buildId=1369&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


Maybe this will provide some more insight: https://github.com/CyanideX/Infernal-Skies/issues/13

Part of it was my mod, part of it was subsistence.


@thanhdut DWMR. Everything here is in order. Press on!


This commit breaks compatibility with 1.8.7 FWIW: https://travis-ci.org/rack/rack/jobs/67441044#L213

/cc @tenderlove


I'm not sure of what git/system you are using (I'm using Git for Windows).

Generally I'll do the following:
`./add_source.sh {whatever}.apk` (NOTE: This should remove the old apk from your file system)

`cd sources\all` (or arm, or arm64, etc)
`git add *`
`git commit -a -m "{whatever} vXX.YY.ZZ"` (NOTE: -a)
`git push`


TeamCity Jarvis Framework :: CI [Build 82](http://build.prxm.it:8811/viewLog.html?buildId=3123&buildTypeId=CqrsFramework_Ci) is now running


@thanhdut DWMR. Assignment 27 tick box - ticked. Press on.


Are you sure you are running the latest?  It loads as a 32 bit even on a 64 bit machine.

![screenshot - 6_19_2015 7_28_55 am](https://cloud.githubusercontent.com/assets/1055125/8254398/62c7ff74-1655-11e5-869e-80e45e33f758.png)

I don't know how to make it more 32 bit. Download the master zip and run it directly and let me know if this is still an issue.  Maybe some how you don't have the latest build?

If is is recognized on every system **but** XP as 32bit.  Then there is nothing I can do.  I will make the project available probably tonight publicly, and you can try and build it on an XP system.  Maybe XP doesn't support the latest .NET?

MS doesn't support XP anymore, but I think @weslly still only has an XP VM?  So maybe he can verify as well.  I'll make the project public and maybe you or he can build it on XP.  I will never have another XP system available to me, so I am afraid I can do know more.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16558/testReport/) for this commit**


TeamCity Jarvis Framework :: CI [Build 82](http://build.prxm.it:8811/viewLog.html?buildId=3123&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 119 Build time: 00:01:03


@thanhdut DWMR. Assignment 28. Tick. Done. Press on!


FIAP - Faculdade de Informática e Administração Paulista


I did the exact same thing. Not sure what happened. I am running Ubuntu
through VirtualBox

On Fri, Jun 19, 2015 at 8:39 AM, Nicholas Buse <notifications@github.com>
wrote:

> I'm not sure of what git/system you are using (I'm using Git for Windows).
>
> Generally I'll do the following:
> ./add_source.sh {whatever}.apk (NOTE: This should remove the old apk from
> your file system)
>
> cd sources\all (or arm, or arm64, etc)
> git add *
> git commit -a -m "{whatever} vXX.YY.ZZ" (NOTE: -a)
> git push
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opengapps/arm/commit/ac15f0447d5422838d436022b4d0ec9d176a33d7#commitcomment-11767975>
> .
>

--
<http://www.facebook.com/djalik>  <http://twitter.com/#!/DJAlik>
<http://www.linkedin.com/in/alexrusinov>
<http://plus.google.com/114580313768137070684>
<http://www.mixcloud.com/djalik/>
<http://psnprofiles.com/DJAlik>


### [Codacy](http://localhost:9000/app/nunomiguelt_6/JS-Tests/commit?cid=1) detected an issue:
#### Message: `Avoid unused parameters such as '$arg3'.`

#### Occurred on:
+ **Commit**:  57c31c39f12922328ba7446ba435a9ed3f332792
+ **File**:    [spa ces.php](https://github.com/nmatpt/JS-Tests/blob/57c31c39f12922328ba7446ba435a9ed3f332792/spa ces.php)
+ **LineNum**: [12](https://github.com/nmatpt/JS-Tests/blob/57c31c39f12922328ba7446ba435a9ed3f332792/spa ces.php#L12)
+ **Code**:    `    public function Gac($text, $arg3 = [])`

#### Currently on:
+ **Commit**:  65ea42952f005df10a833bb08bfff92fc280f200
+ **File**:    [spa ces.php](https://github.com/nmatpt/JS-Tests/blob/65ea42952f005df10a833bb08bfff92fc280f200/spa ces.php)
+ **LineNum**: [14](https://github.com/nmatpt/JS-Tests/blob/65ea42952f005df10a833bb08bfff92fc280f200/spa ces.php#L14)


need an explanation of what has changed


@thanhdut DWMR. Good good. :+1:


Ya, we should probably fix that.

On Fri, Jun 19, 2015 at 6:39 AM Zachary Scott <notifications@github.com>
wrote:

> This commit breaks compatibility with 1.8.7 FWIW:
> https://travis-ci.org/rack/rack/jobs/67441044#L213
>
> /cc @tenderlove <https://github.com/tenderlove>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rack/rack/commit/b83c497b38dd6a54d6f79e978f4b38253f11d3e1#commitcomment-11767970>
> .
>


适配


s/introduced/introduce/

s/anyone/you/ ?


Cool, thanks for the review, i'll make these changes after work tonight!


Can you please define the dimensions of y, w, x?

There should be a sum over data points in the gradient equation.

Can you also add the cost function in mathematical notation, copied and referenced from the SAG paper?


@rahulku4 please use our forums http://themeisle.com/forums/forum/zerif-lite/ or https://wordpress.org/support/theme/zerif-lite. Thank you!


this is fine if you don't like good software


s/usage/WeaveDNS usage


:ok:


I don't think we should use `$main_menu-bg` for something that's not the main menu. Really we could do with `$color_primary`?


you are right (and I think you have already pointed out to me...). I forget to change my boilerplates... how we can change the statement?


@leahpadgett DWMR.


hi,
I'm working on documentation and easyConfig system to do it more confortable.
You can ask for an object using ArrestDB::getObject($table,$id,$extends=null)
Or you can do your query using ArrestDB::getQuery($query,$extends=null)
where $query["TABLE"] and $query["WHERE"] must be defined. In $query["WHERE"] you only can define AND sentences but you can include OR statements and use all power of mysql and , for instance:

$res=ArrestDB::getQuery([
		    "TABLE"=>"MyTable",
		    "WHERE"=>["id in (1,2,3) or age>20"]
);


Cold and dry, but everything is my favourite colour
The two moons may be a problem for Wolfman
But the Mummy will appreciate the lack of humidity


yeah, I plan to come back an refactor this. At the moment, before #216 is merged none of the variables exist yet


Hrm - this could be very large (16-64KB for some allocators, or even larger).  Might want to turn this into a V(5)


unlock


I think just in practice we don't write errors here because we're returning them.  Is someplace eating this error?


@leahpadgett DWMR. If you want to position the label nicely, add constraints. One for width and one for height. Make the background color red or such while you adjust it. You'll also discover you need to set the background color of `contentView` once you're done with the constraints.


Here we can use `findById`.


gg


This block will always block for 10s in the event that another repair controller is running in an HA setup.  I'm less comfortable with the repair controller doing this loop than I am the core controllers init function doing a loop.


"If anywhere in `fetch_and_add` a crash happens, the `pthread_mutex_t` structure..."
sounds better IMHO, your call


@leahpadgett DWMR. Some things are not as simple as it might seem at first - ie. keyboard stuff. Over time everything gets easier because: we know about it, we expect such things, Apple improves the SDK.


| Lambda | Precision (Ex5) | MAP |
| ---- | ---- | ---- |
| 0 | 0.0245269759189 | 0.030426335971 |
| 0.1 | 0.367940359783 | 0.381743468406 |
| 0.2 | 0.380750066041 | 0.392039672027 |
| 0.3 | 0.383071405196 | 0.398003963223 |
| 0.4 | 0.386892473017 | 0.401547416747 |
| 0.5 | 0.3882899978 | 0.401555396434 |
| 0.6 | 0.385554740465 | 0.403348543386 |
| 0.7 | 0.384344048107 | 0.403469346751 |
| 0.8 |  0.379935442093 | 0.397364899759 |
| 0.9 | 0.363199712196 | 0.385846475976 |
| 1.0 | 0.00602658741854 | 0.011772548861


s/When were/When we were/


TeamCity Ybackend :: synteny/ybackend [Build 39](http://192.168.30.225:8111/viewLog.html?buildId=1369&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 82 Build time: 00:13:16


And I would prefer the name to reflect the value as well


there is no in master; use .openerp, .o_web_client {...} ?


@leahpadgett There are so many ways to animate objects. One of the best (easy to setup, easy to modify, easy to understand) is `UIDynamicBehavior` You would use it just like a Gesture Recognizer. Set it up. Assign it to an object. Done.


For strings `deep_copy` is a no-op...


so `format_dirname` will in fact modify its argument


and then return a new value.


@axelfontaine The condition baselineOnMigrate || nonEmptySchemas.isEmpty()) and then baselineOnMigrate && !nonEmptySchemas.isEmpty() looks odd to me. I thought that if I enable baseLineOnMigrate and have no schema, that it should run baseline. Or am I wrong?


@Jorgesolis1989  @hernandcb @sebas932
Muchachos, no entendí este commit... dice que se migraron los líderes de actividad... pero lo unico que veo es que se actualizaron los nombres y apellidos....

Qué pasó?


ftmfw


I think it would be more readable as:
```py
six.Py2 and sys.version_info >= (2, 7, 9) or \
sys.version_info >= (3, 2)
```


doesn't this block all processing in the meantime?


(sorry for the unsolicited review)
did you really mean to delete those 230+ lines of existing stuff?
the 2nd chunk I completely understand fixing the bug...


I add a new ingredient just to make something different


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16560/testReport/) for this commit**


Sounds like an excellent plan. Will work on that tonight/weekend.

Thanks!


@mlunoe
Then we there would be a repetition and also not really readable.
```
AppsEvents.DELETE_APP
```
vs.
```
AppsEvents.APPS_EVENTS_DELETE_APP
```


I suppose that is a mistake... not sure what happened there.


Isn't there a corresponding spec to remove from signatures controller?


this should rather be with the other "data computing" steps, don't you think?


@jeffrymorris,

I'm going to look at this some more this weekend.  The problem I was having
was related to running an ANY on the main item self, rather than a nested
array.  But I have some more ideas I'd like to try there, and I'd also like
to try making nested arrays work.  I'll let you know what I figure out.

Thanks,
Brant

On Thu, Jun 18, 2015 at 2:33 PM, Jeffry Morris <notifications@github.com>
wrote:

> @brantburnett <https://github.com/brantburnett> -
>
> I looked a bit deeper and N1QL supports ANY and EVERY as predicate
> filters: ANY returns true if any item matches the predicate and EVERY
> returns true if all match the predicate. Given this information, your
> implementation of ANY and ALL should use N1QL's ANY and EVERY.
>
> Here is an example of ANY (EVERY is basically the same):
> http://query.pub.couchbase.com/tutorial/#12
>
> That being said, I would be willing to take both (Where filtering and ANY)
> as pull requests and refactor them myself if you don't have the cycles to
> do so. IMO you did quite a bit and laid down a solid foundation for Where
> filtering, which the project and users will find useful.
>
> Thanks,
>
> -Jeff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/brantburnett/Linq2Couchbase/commit/431c6fc0671ac3baab8d79698ff74f6064dc0fd4#commitcomment-11753557>
> .
>

--
Thanks,
Brant Burnett
CenterEdge Software
(336) 598-5934
http://centeredgesoftware.com


Oh great thanks.

On Fri, Jun 19, 2015 at 10:45 AM, ilausuch <notifications@github.com> wrote:

> hi,
> I'm working on documentation and easyConfig system to do it more
> confortable.
> You can ask for an object using
> ArrestDB::getObject($table,$id,$extends=null)
> Or you can do your query using ArrestDB::getQuery($query,$extends=null)
> where $query["TABLE"] and $query["WHERE"] must be defined. In
> $query["WHERE"] you only can define AND sentences but you can include OR
> statements and use all power of mysql and , for instance:
>
> $res=ArrestDB::getQuery([
> "TABLE"=>"MyTable",
> "WHERE"=>["id in (1,2,3) or age>20"]
> );
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ilausuch/ArrestDB/commit/2fd016607043358b49ec0a6436799991ce644cba#commitcomment-11768113>
> .
>


Quite a lot *is* happening here


I don't think `periodically` makes sense here. It means 'at regular interval'.

`cycle though the 'value'` should be good enough


You are a faggot.


My comments:

1. You have created 2 totally separate main branches: string_validation and master. I would like you to create feature branch: feature/some_branch_name from the master branch, then cherry pick this commit there.
```bash
git checkout master
git pull
git checkout -b feature/console-script
git cherry-pick bbd027853cbb33c506de08d4729cabfb5918a03a
git push origin feature/console-script
```
Then you can remove string_validation branch.

2. 'First version' is not the best commit message. Commit message should shortly describe what was committed, for example 'console script implementation'


Could this be a Iterator insteads of a ListIterator


Crafting the command manually is not good.


Certainly the SDK could use more methods that help with authentication. I'm just trying to understand your use case better. I want to make sure that we don't duplicate any functionality nor provide so many different possible auth configurations that it becomes confusing.


Doesn't the previous commit mean we shouldn't be doing this (validating the creator signature) here anymore?


@tomka your QUnit tests for multi-view stacks and tilesources saved a lot of time in getting this refactor working. Thanks!


The indenting and placement of parentheses makes this difficult to read.


I think extracting it to method is too much, it could be initialized in `create` method ;)


Don't you think it would be better to return `nil` and let the view decide what to show in such case? It's kind of unexpected ;)


s/task it's then moved/task is then moved/


Why 0, 1, 2 instead of `sent`, `pending` and `friends`? Also, state machine can be helpful: https://github.com/aasm/aasm


Do you use it anywhere? ;)


Why is this needed? I don't see any impact on "x86_64-linux" – the *.mo files are installed the same.


I have fixed this on develop. Sorry, I haven't really been worrying about keeping master up-to-date since I figured you guys would all be on develop. Should I be?


Simpler: Just click 'Branch'


I would have used returns in case branches (I have those mutable variables, forget a break and you get a tricky bug)
it's in addition more concise


This line is indented too much, make it the same level as Mson.parse


Why is the example introducing the `integer_length` variable? Instead one could have written `println!("length is {} inches", length.0);` or if you want the `integer_length` variable, why not declare it using the tuple indexing: `let integer_length = length.0;`?


Urls have to be adopted to the new, renamed repositories.


This thing shouldn't be parsed.


> expire_callback only runs if there was previously a token. On new auths, it does not fire.

So you want the SDK to detect, when instantiated, that the user is not authenticated and automatically redirect to OAuth?


Crafting the command manually.


I don't understand why is it going to block. This is only reading data from etcd and ignores "notFoundError", so it will most likely return error only when etcd is unreachable.


This script is not, what I have been thinking of.
I was thinking about the console parameters, like:
```bash
ruby validation.rb param1 param2 other_param
```
and to use `ARGV` for it.


Indenting and placement on parentheses makes this really difficult to read.


2) YEEEES
thanks for polishing the world!


Why that "S"?


Regex can be simplified to:
```ruby
/\W+/
```


Usage of PowerMock does not belong to the best practices of unit testing. It's possible (and very desirable) to implement the tests without it.


The RollbarData construction is really elegant...but really hard to read. Is it better to create both rollbarserver and rollbarbody in the rollbardata constructor? .....especially since RollbarBody takes so many properties.


Ok, that's fair.


It's temporary.


Only downside is that this can create discrepancies in terms of the `length` of the array between browsers. Should we mark this style down somewhere? It's not something I think most people do.


I've learned that jspm init generates this file, and it seems to add a lot of stuff to it.


I think that in the end this goes to the server response, but it's not logged anywhere in the apiserver. Where do you suggest to move it? Other allocator methods that call it, or caller of the allocator itself?


Removed altogether


Task was about only prefixing, not suffixing.


Indenting anc placement of parentheses makes this difficult to read. Also only the last part should be clickable.


@justinthec


I just tested.  This works fine if you are using an ext4 filesystem.  Does not work for xfs or anything other than ext4.


Yes, indeed. Which makes me wonder whether the fix in the following commit would not be applicable here as well without this cost …


Jo.


Is this already included before? Probably not required then :smile:


To check it string starts or ends with some letters, you can use `.start_with?` and `end_with?` methods


I'm all for having a changelog, I just wanted to get your PR merged but didn't feel like writing it, and just having a stub looks weird. I'd merge an actual changelog imported from Releases page though. Is there a way to generate it?


Extra empty line detected at block body end.


Use `described_class` instead of `Mambu::Finders`


To add "file://" at the beginning of the URL which does not allow to append local serve to the beginning of the URL.


I made the implementation in MassiveCore. I didn't think too much about it. But just because I did that wrong doesn't mean this should be done wrong :P


`weave run`


This makes sense; what I'm saying is, was it really a size problem having it be a dependency?
(Although I remember people complaining on Slack about having issues because we depended on it, so maybe good riddance after all.)


@tenderlove is reverting an option?


I guess this should look at both ``response`` and ``response_summary``?  I think our rules allow for either to be populated.


What is the purpose of BoxUsersRestService interface? It's used nowhere, therefore I would suggest removing it at all.


jjjj


It's a bug fix, so I don't want to revert. I can fix compatibility on
Tuesday (unless you want to do it😉)

On Fri, Jun 19, 2015 at 7:04 AM Zachary Scott <notifications@github.com>
wrote:

> @tenderlove <https://github.com/tenderlove> is reverting an option?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rack/rack/commit/b83c497b38dd6a54d6f79e978f4b38253f11d3e1#commitcomment-11768525>
> .
>


Unless it's super less performant, what about using the named param interpolation style for the sql fragment?

``"signature_count = signature_count + 1, last_signed_at = :now, updated_at = :now", now: time``


If BoxUsersRestService interface was really needed, I suggested to annotate it and its methods with JAX-RS annotations instead of doing it in BoxUsersRestServiceImpl class.


There's no sense to use different paths for each of the Box REST service's methods. They have to be distinguished by the type of HTTP request (exception in our case is getting the current user which needs its own path), i.e. the requests to the resource should look like these:
	GET /users/current - to get the current user (this is correct)
	POST /users - to create a user (not POST /users/create)
	DELETE /users/ID - to delete the user (not DELETE /users/delete/ID)


This breaks the current behavior.  Can you do this in a way that adds the new functionality in a backwards compatible way.

2 ideas
1. Create another module.
2. Add a flag to the calling function that does the switch.

For simplicity purposes, I prefer option #1.


thanks!!!


Huh, that's the behavior you see with this patch applied? The intention (and what I see) is that your search query remains once you dismiss the search settings. This change i needed because https://github.com/mozilla/firefox-ios/commit/d40766b27d16da6f616fcd52aab0f53d38ff38fc#diff-661640cbb3c9eed28c240c4340d3280cR242 always sets the location bar text to the current URL on focus (so we were losing the entered search query).

If you're seeing different behavior than I am, we should address that.


Indeed TUTTLE_EXPERIMENTAL can be used in several files, so it will be too much branches.
So add a new define is a good and practical solution ;)


moet hier niet nog wat meer uitgesprongen worden?


Thanks! BitHub has sent payment of  $8.07USD for this commit.


It happens when your browser visits the main cache page.

On Fri, Jun 19, 2015, 00:08 Tony Kelman <notifications@github.com> wrote:

> who's been asking for this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/staticfloat/cache.julialang.org/commit/44f14704f5085fd7d1251aacae8e1e0ed6b82660#commitcomment-11762389>
> .
>


I agree with this change in principle, but please do update the documentation.  This will also be a major version number update to indicate a change in API, but you don't need to worry about that.


Why such a complicated architecture was chosen? Justify the decision to use EJB when the task can be solved without this technology.


@giorgioriccardi :+1:


the python 'with' statement opens a context manager. It's got some special sauce, so you don't have to use try / except clauses when doing file I/O. See http://effbot.org/zone/python-with-statement.htm


There are no Javadocs for at least public API in the code.


BIG :+1:  for no Rubocop offences


We still have gesture anywhere


vbnvnvn


nmm


@AbdullahAlger `@post_id` isn't defined, it'll be nil. Try `@post.id` which will not be nil. This should get you past the no route found error.


Using except without specifying the exact exceptions (e.g. except IOError) is fairly dangerous because it will catch all exceptions.

 From the docs: "The last except clause may omit the exception name(s), to serve as a wildcard. Use this with extreme caution, since it is easy to mask a real programming error in this way! It can also be used to print an error message and then re-raise the exception (allowing a caller to handle the exception as well):"
https://docs.python.org/2/tutorial/errors.html


As far as I remember, when we had it loading in `.babelrc` it was being compiled to the final asset :/


maybe, you can try at least.


I fixed this function as well. The hook is `hook_html_head_alter()`, so removed the ~~default~~.


Can you explain how this works with Nancy. How Nancy can pre-handle an exception and pass it to this method using the code:
<code>
 public void Initialize(IPipelines pipelines) {
            pipelines.OnError.AddItemToStartOfPipeline((ctx, err) => {
                var payload = _payloadFactory.GetPayload(ctx, err);
</code>


Not the most elegant solution, but works for now. 🎉


I can try, but can't think of a way to get a constant without looking up the tree. Any tips?


might miss


I feel like that would be too unrealistic. What if it was an add on to use redstone to power it when it's below the light level of 7, but it would use lots of it? Puts use of redstone, and is realistic because redstone is a small source of light.


I included this file to be able to asses the `$libraries` variable. Maybe there's another way to do this?


i guess numbers test fails because it's missing int128 support?

sizeof_jl_tagged_value_t = sizeof(void*)
sizeof_jl_value_t = 0 (or #undef)


🙈 Adding some html here … sorry.


When we show this screen in Settings it's pushed on to the navigation stack, not presented modally (via `presentViewController`). We add the Done button when its presented without a nav stack to pop off to.


New setting that makes it possible to use the full version of a library (instead of the minified version).


Looks like Stan commented that out with commit 1f29495
The assumption was that zmdc would manage this.
Perhaps we should take a look at zmdc.


Ah, parseInt has skipChar public, but not parseFloat. Right, I see now :-)


Oops lalala, you didnt see this :-)

Fixed in new commit


@eliotsykes

Yep, that's it.


为什么这里不直接返回$instance


Yes, indeed, that seems to work as well, thanks for the idea!


delete


I think the ones that will face this error will probably be Rubyists, because it doesn't happen to those who learned it already, so it probably makes sense :-)


We never style tags directly, and this tag is globally scoped to all footer elements (which will include any footers we have in our pattern library or anywhere else throughout the site).

Please ensure this styling is only scoped to `[library-class="main-content--footer"]` if it's for `all` instances of the main content's footer, or scope the styling to just when `[library-class="_library--stretch-container"]` if it should only happen when we have a stretched content area


Rather then use the 1001, why not try to use /proc/self/loginuid for both UID and GID.  I am not thrilled with the idea of selecting a default UID to run with, I would rather have the container fail. if loginuid and SUDO_UID are not available.


Since it selects template based on what is passed to the calling function  (template selection is not currently a calling function option but based on whether you've based a value in the text param) I'll go ahead and add support for a searchOptions param (#2)


We call `reloadData()` every time searchQuery is set (line 276 in this branch), so I hope it's not expensive! We have to do this here to update the UI with the potential changes to search settings (new default → new suggestions), etc.


And drops obsolete JS and CSS files


I would suggest using more descriptive commit messages :) Maybe about the content or purpose of the commit


@Frenzie: I don't use KSM, so, if it sounds good to you and handles all more or less current KSM versions, go for it ;).


Please add some spacing. `setting-get('rhythm') / 4`
For all of them


Yes, there are test use cases. I wouldn't bother pulling it out at this point.


So why we don't need it ?? ;)


I think the goal of git in these submissions is to show your workflow through the problem. Separating git commits is like showing your work instead of just writing the answer in Math class.

That said, we can use branches to separate assignments and then merge the branches into master (or PR them) in order to keep the final solution up to date!


This breaks the case when you're not using oauth -- oauth is left as {'oauth_dance': False} which then fails inside the JIRA constructor. :-(

Created Bug #91


you should explain the difference of these Input compared to the built-in input


If both odd and even are 50% width, you should just make the item's width 50%. What you're saying here is `"All odd items should have 50% width and all even items should have 50% width"`, or `"All items should have 50% width"`

Same for the 100% width below


is mixin definition still needed ?


nice


Well, I think that `transitionend` events can be dropped because we're hiding all the children that are not the `_visibleChild` and if they're not visible, the `transitionend` event doesn't occurs. This could happen on aggressive interactions, for example if a `showNext()` is executed too many times in a short time.
But as we're keeping always the `_visibleChild` visible, at least that animation will always end, and by executing the `afterTransitionHandle`, all the others children will be cleaned an hidden and after the Promise be resolved, the `visibleChild` will be cleaned as well.
or am I wrong?


Because it works after apache config file was corrected.


looks like some nasty stuff got committed here. You might want to remove it!


indent off


谢谢！


it will override type="number"


Thanks for fixing


Done here 266c737


Done here 6a24ccf


Done here 695af10


:-1:  :)


Generally speaking I think it's fine to repeat yourself in tests - it's nice to be explicit and not have to worry about the tests themselves being complex.  That said, if you had more than two of these, I'd probably make a helper function abstracting the commonalities.  What precisely are these testing?  That a user can view a tab if and only if the domain doesn't have a custom menu bar?  You could make helpers so your tests look like:
```python
def test_applications_tab_is_invisible(self):
    self.assertInvisibleWithCustomMenu(ApplicationsTab)
```
Or if you're really testing the same thing for each tab:
```python
def test_tabs_are_invisible(self):
    for tab in [ApplicationsTab, DashboardTab]:
        self.assertInvisibleWithCustomMenu(tab)
```
With just two test cases though, I'd probably leave as-is.


I think the -a was lacking. It was not explicit in the README, so I added it. In general the 'add *' should kind of force all updates anyhow.


These dependencies seem unnecessary; can we just try on forum putting in framework/cms? The version numbers could get us into trouble.


Could you refactor this to use event delegation instead of adding click events to each div?


rm ?


http://zincone-dylan-omdb-query.s3-website-us-west-2.amazonaws.com/ is one
for omdb. I still would like to meet just to make sure I have a good
understanding of the concept and how it all works. It makes sense in my
head, and omdb was much more clear for me as an example.

On Thu, Jun 18, 2015 at 1:35 PM, Jeff Dean <notifications@github.com> wrote:

> Cool - I looked at that latest commit here, and it still isn't showing a
> solid understanding of query strings. What's the link to your OMDB project?
> Grab me in person at some point and we can go over it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dzincone/omdb/commit/dd635f19b9ad46e0b87331981a07bdac4a3e019a#commitcomment-11754724>
> .
>

--
*Dylan Zincone*
*NoCo League Director*
*dylan@nocobasketball.com <dylan@nocobasketball.com>*
*719-304-6504*


We're still using .link and requestChange, so yes.


:exclamation: When you put this in a header file, it means you can now reference `std::SemanticContext` everywhere (or everywhere the header is included).


You meant "canola"?


:question: Can this be `SemanticContext const& x`?


@alexanderdean Do you think this is the right place to put this check (just before creating the jobflow)?


:thought_balloon: just delete the file?


Please ignore this file


For reference, here are the actual master values
  const int QueenContactCheck = 89;
  const int RookContactCheck  = 71;
  const int QueenCheck        = 50;
  const int RookCheck         = 37;
  const int BishopCheck       = 6;
  const int KnightCheck       = 14;

A QCC is most often a mate threat (especially if the King is in the corner, or king mobility is low)


There is no need in empty lines in methods. please remove them.
https://www.dropbox.com/s/50r0fyo6w45wt9x/Screenshot%202015-06-19%2017.30.45.png?dl=0
This is the example of well formatted code.


That's not the main wiki reference, that's the farm reference.


I think that's a good place for it Fred - it binds the check most closely to the thing that needs it to work!


Please, use Test.startTest() Test.stopTest() in all tests methods.


RIght now both hashes and ciphers/modes are hard coded. I foresee these being specified by the user in the program configuration (with defaults of course). As such, I don't see the crypto package returning what it used, more likely it will be told what to use. That information will then be stored in the links.


why this file is minimised?


:bulb: this isn't doing anything


updated in the latest version.


Unfortunately I couldn't find another way how to mock static method. Is that really possible to do using only JUnit?


It's automatic behaviour of angular-seed based app... I didn't manage yet to delete it.


...can rely on ^the^ consistent behavior of *all* jss recipes.


Providing particular dependency version would be better. Just remove `^`


This should be _repoChecks, and there are actually three checks contained in it. So it should be _repoChecks[repo.name].name_check.update_check_status(), as well as .url_check and .proxy_check.


Please, organize your code in test methods in next manner:
1) data preparation
2) test execution
3) assert statements
http://screenshot.net/2g6xrim
This is the example


:bulb: Throw by value, catch by reference. See C++ Coding Standards rule 73; google may provide you with duplicate text if you don't have a copy.

:memo: I *highly* recommend this book.


pip is not on a mac by default, so I usually give examples with easy_install... I guess I should do so here also.


Please, leave comments in English


Good point, thanks


I think we need to changed it back as it was.


In working through my PSU prez I have waffled back and forth between jssrecipes and jss-recipes. I think let's standardize on jss-recipes. (As it is here).


Ok so in the next release, right?
@giorgioriccardi :D


I think this was actuallu written by my teammeate at the workshop but I will look into that and fix it.


I would not use the term "snapshot" in the end-user message. It is a technical term.


Same here.


You could used *repositories* in your project composer.json to avoid renaming package and use your fork

```
"repositories": [
  {
	"type": "vcs",
	"url": "git@github.com:adenot/dialect.git"
  }
]
```


Looks good so far!


yep, I will stop for now for 3.3.27 ! :D


I'd recommand to add comments to the code. Here it would be "callback assigned to search form submit event"


Got it. That looks really better. Thanks, I'll fix that


This is just what a couple of us at work came up with for *our* categories.

How does this sound to you? What are we missing? What would you like to see as changes to make it usable by *most* organizations without feeling like they have to override every recipe.

Likewise, as ugly as it would be, should their be a prefix, i.e. `JSSImporter: Digital Media`?


fixed, thx <3


ES necesario dejar activos las imagenes


Well, I haven't actually *tested* it on any newer versions, but logically it should work.

As you can see on my slightly older version KOReader is launched with:
```
sh /mnt/onboard/.kobo/kbmenu/onstart/koreader_kobo.sh
```

On a newer version, it would be:
```
sh /mnt/onboard/.adds/kbmenu/onstart/start_koreader.sh
```

The 'ksmhome.sh' script, on the other hand, only exists in newer versions.


fixed


I'm wondering how these 2 tests could be refactored in order to not depend on database.


There is no need in check for isTest when sending http requests. Http request will have never been sent from test method. So, you should remove this logic from Html parser class. For testing this method in  unit test, use Mock for response formation


I agree, well .. We'll have like one week before reviewers will accept this version :D


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 556](http://build.prxm.it:8811/viewLog.html?buildId=3126&buildTypeId=Jarvis_DocumentStore_CI) is now running


:exclamation: This won't work as expected. You probably wanted to have this signature:

```cpp
template<typename T, std::size_t Size>
void Method(T (& data)[Size], int seed)
```

You can then use `Size` instead of `sizeof(data)/sizeof(data[0])`.


TeamCity Ybackend :: synteny/ybackend [Build 40](http://192.168.30.225:8111/viewLog.html?buildId=1373&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


Can we add a -Ycheck that would catch such issues in future?


Good point.  We should figure out a way to configure the app for the various environments.