Are you sure you want to return the error here and not raise it?


Example commandline usage...
http://www.cbica.upenn.edu/sbia/software/basis/standard/cmdline/cxx.html


We probably don't want a `SRVFAIL` here (in the sense of a DNS RCODE). We should probably use the appropriate HTTP error code which I think is 400:

https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_Client_Error

We can send this back to the client with the `http.Error()` function:

http://golang.org/pkg/net/http/#Error


Thanks for the commit. A question for my understanding:
Why is bindingChanged() necessary? What happens here?


@arussellsaw apparently you can do this.


The "Content-Type" will be "application/X-DNSoverHTTP", not "Content-Type".


I don't really understand this part... where does body come from?


s/protol/protocol/


Well, if you were returning an occurrence, then that method would make sense. But it looks like you're returning the next timer interval? For reference, [here is what I did in the SDK](https://github.com/Azure/azure-webjobs-sdk-extensions/blob/master/src/WebJobs.Extensions/Timers/Scheduling/CronSchedule.cs). My schedule class returns next occurrence, and the next timer interval is computed externally.


rpc_maas, no? Would you mind amending the commit message?


Hi;
can you explain to me how to use a playlist.sh or play.sh file?
thank you!


I should use a directives matching attribute name.


There was already a fix committed for this.


This change should be in the commit that introduces the change in the messages.


I think the nested objects will need to be IDs instead of objects since they recursively nest. e.g. `Person` has an `Activity` which has a `Person`.


Όχι presentation, αλλά final report.


Oh sorry.  Thanks for fixing.


WOT!? How could you even think of creating objects on render tick?


@bmorris3   Is the altaz() functionality not already included in the Observation object?  That is, could one not do, for instance, `obs.calc(sm,t).alt` if the Observation object is not already created (in which case, `an_observation_object.alt`)?


Good job, this is better I think!


Lets leave this until the PR. It really depends how dependency management gets handled between `ex_unit` and `logger`.  I ran tests and got a failure:
```
==> ex_unit (exunit)
.................................................................................................................................................

  1) test opportunistic logging (ExUnitTest)
     test/ex_unit_test.exs:142
     Assertion with =~ failed
     code: output =~ "The following output was logged:"
     lhs:  "\n\n  1) test prints output (ExUnitTest.TestOpportunisticLogging)\n     test/ex_unit_test.exs:148\n     Assertion with == failed\n     code: 1 == 2\n     lhs:  1\n     rhs:  2\n     stacktrace:\n       test/ex_unit_test.exs:150\n\n.\n\nFinished in 0.00 seconds\n2 tests, 1 failure\n\nRandomized with seed 0\n"
     rhs:  "The following output was logged:"
     stacktrace:
       test/ex_unit_test.exs:164

...
```


I don't think a prop is the right place for this. What would happen if the width were just `100%` in the CSS instead of `100px`? These things should probably be block-like.

I _think_ the reason I put that `100px` value on there was to quickly work around a bug in Firefox where large images with `max-width: 100%` would extend outside `flex`'d containers without an explicit width. Does that still hold with `100%`? I'm not sure I checked.

If that doesn't work, maybe the ImageSelector could be responsible for itself and check its parent on load and resize and update its size if it's too big.


I guess you want to add this same test for ``trim1``?


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 30](http://teamcity.otenv.com/viewLog.html?buildId=1346987&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) is now running


Thank you. It is simpler.
https://github.com/kenjis/ci-phpunit-test/commit/468055bc8bccae5f2c87cf73a67461376f0647a2


would be good to remove the odd capitalization


General comment: I think class/code comments would be very helpful for all the main components and methods, to make their responsibilities clear. Not sure what your code comment guidelines are for the Kudu codebase, but they would be very helpful.


this is the most flexible way of handling errors in trait functions. we would add an Error impl for ReceiveError when the associated types implement Error (we could also constrain the associated types to implement error).

if the associated types are too cumbersome to implement, we could also just have them return a &'static str, and use that in the Error impl for ReceiveError.


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 30](http://teamcity.otenv.com/viewLog.html?buildId=1346987&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) outcome was **SUCCESS**
Summary: Tests passed: 33 Build time: 0:0:0


autodeploy/.gitkeep is causing problems can you delete it please.
The autodeployer is trying to deploy it!!


add same in ``trim1``


Yep. r=me


I think so. I don't see how this ever worked.


Don't forget specify label without 'parent' word during release


Then it should probably be optional, because sometimes you want both submit hooks to run


This commit and the two before it were a mistake. I intended to commit to a different repository and instead committed to this one. I thought the changes I committed were a mistake so I reversed them, then realized that the reverse wasn't needed so reversed the reverse. The latest commit was correct.


Isn't this called SemiAutomatic?


Update


@mojavelinux this line is causing issues with the Debian package because the asciidoctor command line is run in /usr/bin and the lib/asciidoctor is somewhere else... Can we revert to `require asciidoctor` ?


Wouldn't it make sense to treat this ``axis is None`` the exact same way as in the other two functions?


From @chabgood's suggestions in pull request #79. I think the logic makes more sense to put in the idea/project models, rather than the IdeaVote/ProjectVote models. Also this way avoids querying the same table twice to get the user's vote.


It seems to be bad logic. Should be if (active == current) then activeSearchTab = 0


This was not referencing the instance. I believe it's because this method is static.

Reference: http://odetocode.com/blogs/scott/archive/2015/02/02/static-members-in-es6.aspx

Should we change bootstrap to not be static?

No preference on this.


(For Calendar bug fix code, same as above with relevant line numbers)

No.

Lines 1452-1455 and 1487 are only concerned with year and month.

Only the year and month elements of the value of $occurance calculated in the lines 1453 and 1487 (mktime) are ever inputs for further processing (and only in line 1461). The day component never becomes an input for anything at all (except explode function). So it is irrelevant.

(Also the only values of $nd that are important to lines 1453 and 1487 are 29, 30 and 30 since these will cause an overflow to the next month)


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 40](http://teamcity.otenv.com/viewLog.html?buildId=1346999&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


Could they above be simplified by making itemStack.Count a property?


What’s wrong with git@github.com:jonathantneal/closest.git or https://github.com/jonathantneal/closest.git as recommended by GitHub?


What does Jemalloc does anyway?


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 40](http://teamcity.otenv.com/viewLog.html?buildId=1346999&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1; exit code 2 Build time: 0:0:0


Good catch, and that's one less operation. :)  Thank you!


Merge aceito


Isn't this more using it as.. player.CanFireWhen or something


This scaling should be called from the PlayerTracker class, as that already handles all Circles, so an extra loop is redundant


Oh the irony..


Thanks for help, but why is the problem with order = 1? Order is intended only as a shortcut. Where is the problem?


LIcencia de Uso


lol


If I understand its use correctly, ain't `clip_should_set_selection` a better name?


@voiceofrae you've initialized `rssItemTable` but did not assign it to anything. I believe `DataSource` holds live references to `rssItemTable` and `rssFeedTable`. One way to complete this assignment is to place the following code in a separate method found in DataSource, then have BloclyActivity call it. :+1:


Well, it's not done yet. As you can see the png's are different from foxcast.svg. The current png's border is too small. This is not really in the style of the FF icons, that's why I am redesigning it, again.


`callbacks || this.callbacks()`


you need add c.Twitter to `func (c *Config) env(){...`

This is handles the override from ENV var.

It would also make sense to change Twitter.Threshold to something like Twitter.MinMagnitude as I'm sure we will tweet about volcano alert level changes when we have the messaging for volcanoes a bit more sorted.


Oh. Thank you!


Why do we need to save this? Is it because `&clipboard` could change during the global execution?


That depends on how this value will be set in the end. I'm not even sure it's set and checked at the right moment now, because of the changes in the codebase regarding clipboard handling. I might need to reintroduce a bunch of flags regarding which registers are handled too.


Yes, I'll do it (probably it can be also configured)


О, лицензия появилась!


Awesome!


I think that's the reason. This is also called from `ex_folddo` and `ex_listdo`, I'l have to check what is going on there too.


This resolves #2 by placing `wget` in the makefile build graph.


great, may you take a look on SMSG_PET_SPELLS_MESSAGE ? fixed all parts except vehicle part, like vehicle abilities or vehicle controlls.


¿```<footer>``` vacío?


Probably we want to use `http.Error()` for this too. The HTTP error code might be 400, or perhaps 415 (Unsupported media type).


FWIW, this variable name was very confusing to me when I was first reading the code, since we never actually search for anything?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


i have a quesstion, i am trying to use this library but i am getting next error:

Parse error: parse error, expecting T_STRING' orT_VARIABLE'

file: AbstractCapabilityProfile.php

function:

getInstance()

on line:

$profile = new static();

do you know about it?


Ohh, I see. Sorry, I missed it.


Even better would be:

     var fruitSummary = String.Format("I have {0} pieces of fruit.", apples + oranges);


I was actually thinking about rewriting the timer and using a TiProxy subclass instead, making the code more readable and scalable. There's no reason to write the timer using the low level JavaScriptCore C APIs. What do you think?


pendejo
shale con los comentarios


Ah, sorry, I can change it to something else... or i can make it count and make the parameter name something different.


The error is in reading the request, not the response.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


do you still need the reference (`&$note`) there? IMHO it would be cleaner to have different method that modifies notes.


Este ```float```sobra, ya estás flotando su contendor.


For some reason using `[self main]` doesn't work, I replaced that code with GCD's API
```
dispatch_async(dispatch_get_main_queue(), ^{ [self main]; });
```


that's fine too but to make this faster and easier, just remove the locks and do that in a new PR


Probably we should use `http.Error()` for this. I think error code 400 (Bad Request) is fine.


Woah, Ubisoft will be proud of the cinematic experience this mod will provide!


ow


`Collection` makes me think it's an entire set of things; i.e. "This is my 'Super Faves' Collection"

Perhpas it's `CollectionItems`?


Shouldn't it here be `all-disk-vocabs-recursive`?


This one is tricky, because it is hard to know if the error is due to some problem on the server or the client did not send it properly. I guess we can assume a client error, and use `http.Error()` and return code 400 (Bad Request).

I'm not sure we will ever get this error, but I suppose it is okay to check for.


Same here.


¿No hay ```:hover``` para el ```<a>```? ¿Cómo sabrá el usuario es un enlace?


Yeah, we could even make this unique experience even more exclusive by letting players put together parts of their own desire. This downloadable content would certainly allow players to form the mod to their own likings. And that for only €14,99!


It seems like you're trying to grab the keys here and reverse their order - you can accomplish the same thing with `@roman_nums_old.keys.reverse` (see http://ruby-doc.org/core-2.2.0/Array.html#method-i-reverse)


Cool. I'll do an npm release later today with this change.

Thanks for contributing!


Looks like this was added to the root of the repository rather than to `Casks/`.


This should definitely be `http.Error()`, with return code 400 (Bad Request).


Maybe something like arrIndex?


Wow! I'm throwing my money at the screen but nothing is happening!


Yep, here's what I get on CentOS release 6.6 after a `yum install jenkins`:

```
Running Transaction
  Installing : jenkins-1.617-1.1.noarch                                                                                1/1
Non-fatal POSTIN scriptlet failure in rpm package jenkins-1.617-1.1.noarch
/var/tmp/rpm-tmp.lEmlqZ: line 20: syntax error near unexpected token `"x"$JENKINS_INSTALL_SKIP_CHOWN'
/var/tmp/rpm-tmp.lEmlqZ: line 20: `if test ( "x"$JENKINS_INSTALL_SKIP_CHOWN != "xtrue" ); then'
warning: %post(jenkins-1.617-1.1.noarch) scriptlet failed, exit status 2
```

jenkins-1.616-1.1 installs just fine.


Updated to use the custom functions because I am thoughtful and considerate.


Bug in VCS?


this commit LGTM


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/ba492308f4f3284f045d7bed8c5ef64ebc0f50c7/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/ba492308f4f3284f045d7bed8c5ef64ebc0f50c7/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/ba492308f4f3284f045d7bed8c5ef64ebc0f50c7/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/ba492308f4f3284f045d7bed8c5ef64ebc0f50c7/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/ba492308f4f3284f045d7bed8c5ef64ebc0f50c7/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Okay, in this case we are finally at something that is a server failure!


Wrong indentation, should be one less tab here.


I don't think so. It works when I use this feature manually, but in tests it doesn't.


Este ```top:400``` no es una buena manera de resolver el posicionamiento del boton, seguro se podía hacer de una mejor manera


Why are you creating a new array with 3000 items in it? Is it just to ensure it loops for a long enough time? You could try using a `while` loop instead, which you could specify explicitly when to stop.


vamos con todo XD


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


upstream has a whole new set of modules coming in with either a later 1.9 release or the v2 release. It's built on Mondy's shade library.

https://github.com/ansible/ansible-modules-core/pull/1053  brings in group creation and rule creation modules.


It doesn't seem like `num` is ever used below. How does this method calculate the roman numeral from a value you pass to it?


So, the formatter does nothing ? :P Maybe you could give a more realistic example ?


These test runners are nice, it's really easy to verify them! Good work!


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-AddressSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Seems like this change is missing from the `_mocha` executable, which is used by a few tools directly to e.g. generate code coverage.


Delete this line.


It's a little faster to as-cast and get the length instead of getting the enumerator and disposing it (which is done by the for each). That's why we try the ICollection and String


This commit can not be made into a pull request that can be merged automatically. @stevelinton, @laurentbartholdi - I will now migrate the main FR's repo to GAP's VO and then try to apply the change manually.


Pour info, le coupable est @NoWiS-  https://github.com/TacOS-team/tacos/commit/822adb20626d802f73782e134b274ce93f19ea2b


The server error codes can be found here:

https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_Server_Error

There are two possible approaches:
1. Use `http.Error()` with an appropriate code (like 504 if we don't hear back from the DNS server in time), or
2. Send reply back with an encapsulated DNS packet with RCODE of SRVFAIL.

Looking through the code we only have a single case where we actually have a server failure (everything else is client caused). Because of that, I recommend not having the `SRVFAIL()` function at all, and just using `dns.Error()`. (Notes about this are in the code below.)


I use npm init for this. Think it's the most true way.


El ```left: 67%``` tampoco me convence. Deberías revisar todo el layout de este módulo, es muy frágil


Does the worker need a public IP?


While it maybe shouldn't be implemented in the same PR, a constraint to keep in mind might be to later be able to reuse the same flags to ensure code like
```
          if !empty(@+) && @+ != s:yr_prev_clipboard_plus
                let elem    = s:YRMRUElemFormat(
                            \   getreg('+')
                            \ , getregtype('+')
                            \ )
                let s:yr_prev_clipboard_plus = @+
```
Doesn't invoke the provider five (5) times. Of course this "getter" problem might be more elegantly solved with a true event-handling provider (or in this case, simply don't use YankRing, but I reckon other register manager plugins will have less extreme variants of the same problem)


Eliminar


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Fixed, thanks for code review!!


Fixed!


Die Funktion brauchst nicht, denn char* ist implizit zu std::string konvertierbar (std::string hat einen Konstruktor, der einen char* entgegen nimmt).


En clase hemos visto mejores maneras de centrar elementos. Dales un repaso.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Change to BOXAppUserSession or something that will clarify that this session is meant for AppUsers.


`std::cerr` ist hier schon richtig, du willst die Statusmeldung ja nicht mit in der CSV-Datei haben, oder? :wink:


if version type is internal allowing the update
fixes #11506


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This should be good aye?


Also, do you need to reverse the keys at every iteration of the array? If not, you can move the reversing code outside the loop (just above it) so you don't have to perform the operation more than once.


Remove this.


Thank you. Fixed now.


I'd just do something like:
    def id; @id; end
    def id=(val); @id = val; end

or `attr_accessor :id` here. This way rcd['ID'] or rcd['id'] always points to field value and not the airtable internal id.


I am not sure about that, I took the example from dragging. Are exceptions supposed to be used in that way, meaning when you are doing that action (sitting in this case) any action that has `exceptions[] = {"isNotSitting"}` will not be available when sitting?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


straightforward


I had no clue this library was so deteriorated. Think https://github.com/thephpleague/geotools might be a way better replacement. Thanks for noticing this!


Type arguments are probably not needed here? Also would be nice to replace `Void` with `Unit`


Using `nameError.getLabel()` in https://github.com/Munter/unexpected-dom/blob/master/lib/index.js#L598 should bring it back to "should equal", which is more precise in these cases.


This won't get hit on a failed run.  Should put it in a 'finally' block


`<meta charset>` is needed when you save page to a file. `.htaccess` may lead to critical issues, but I don't want to add "garbage" to clean web-project.


Should use os.path.join here too


For future record, it's best to set the record fields with whatever is returned from the server. E.g. computed fields that are defined in the table schema and will be returned by the server.


Ah, gotcha. I think we could sneak in a ClipboardSet event in this PR, since we are handling the cases where that would trigger anyway. That won't work for the case where the clipboard is set by a third app though.


A better name may be `backUpLowWatermark` and `restoreLowWatermark`, which is less confusing and better describes the intention of these methods.


well done @mairatma :+1:


Renaming a favorite with an empty name now works. But adding a favorite with an empty name produces a "successfully created" message, but the fav is not created.


We can create a response a similar way that we did on the client side, something like this:
```go
response_bytes, err := dnsResponse.Pack()
if err != nil {
    http.Error(w, "error packing reply", 500)
    _D("error in packing request, error message: %s", err)
    return
}
nwritten, err := w.Write(response_bytes)
// check error here...
```


This check is unnecessary since `Task` is already responsible for rolling back the wm if workunit fails.


Whilst creating files and moving them, I forgot to use the Git commands to create snapshots.


Okay, back to you Runxia. Sorry for the delay!


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Unsure why I put #58 it should have been #56


Just FYI, you shouldn't store password as plaintext. As in, you shouldn't be able to compare the entered password to the password in the database.. it should be encrypted using something like Bcrypt which essentially is a one-way hash. If you don't do this, and someone bad gains database access, they'll have all the passwords for your users right there. If you use something like Bcrypt, it becomes significantly harder for them to get passwords.

Then, when you want to see if it's the right password entered in to log in, you encrypt the handed-in password and compare it to the encrypted one you're storing in the DB.


I think you just need to remove the parens

```
[bash] if test ( foo != bar ); then echo hey; fi
-bash: syntax error near unexpected token `foo'
[bash] if test foo != bar; then echo hey; fi
hey
```

The parens are reserved for creating subshells and are not needed.


Please revert this change as we discussed, we need to guarantee that `actualHighWatermark` is never null, otherwise checkpoint is lost and we cannot afford to do that.


LGTM


Call self version of initWithAPIBaseURL:queueManager:.


Delete BOXSerialOAuth2Session.


You can declare a `var version: Int?` here, change it in the object literal, and return `mapOf(version, null)`, which will be clearer


Also `Ref` here can be replaced by a `var`


One solution is to add `this.workUnitState.setActualHighWatermark(this.lowWatermark)` in `KafkaExtractor`'s constructor, which can be used to roll back the watermark if the container fails.


Tags taxonomy is already defined in osha_taxonomies, please do not export twice!


Change you dictionary declaration to be:

 private static readonly Dictionary<String,Color> ColorsDictionary = new Dictionary<String, Color>(StringComparer.CurrentCultureIgnoreCase)

Then you don't need the loop.

Just do

if (ColorsDictionary.ContainsKey(name))
{
    return ColorsDictionary[name];
}
return Color.Black;


@theunraveler How can I verify this myself in a new app?


you want in those examples in the main readme for foundatio?


Was hältst von:
```c++
uint_32 countProcessed {0}, countIgnored {0};
```
`size_t` ist semantisch falsch (wars auch schon bei `count` :grin:). `count` und `maxLength` braucht wir auch nicht mehr.


En esta semana habíamos quedado en empezar de lleno con Ember CLI, a reserva de lo que opine @bhserna yo sugiero este temario:

  * Single Page Applications
  * EmberJS philosophy
  * Ember101:
      * Ember CLI
      * Routes
      * Models
      * Components
      * Controllers
      * Templates
      * Adapters
  * Connecting with an API


Nettes Tutorial, siehe auch: https://github.com/miloyip/rapidjson/blob/master/example/tutorial/tutorial.cpp


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


I think it probably wouldn't hurt to have a small readme on how to
hook up to something different. I've never heard of that library and
wasn't sure how I could hook it up to my logging implementation
(nlog).

On 6/8/15, Paul Welter <notifications@github.com> wrote:
> you want in those examples in the main readme for foundatio?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/exceptionless/Foundatio/commit/a6e9aab29e996c0e855ce3dfcbe0c729c992fee1#commitcomment-11576863

--
Thanks
-Blake Niemyjski


Das würd ich in ne eigene Klasse und Datei packen. Kann ich aber dann auch machen.


Checking for invalid slicing syntax


Should this method backup `getActualHighWatermark()` or `this.workunit.getLowWatermark()`? Or are they the same?


@jelbourn Would it make sense to turn the $$mdDateLocale properties into functions to make it easier to stub?


@danielytics I'm wondering if you can answer why this lib is handling a response type of `5`. Seems like both really large queries and changes feeds return a type of `3` which according to the protocol spec here https://github.com/rethinkdb/rethinkdb/blob/next/src/rdb_protocol/ql2.proto#L117 is a `SUCCESS_PARTIAL` which makes sense. Response type of `5` doesn't seem to be on that list at all. Vestige from the past?


I am a big fan that this is written out byte by byte.


optimization suggested by dirk-thomas before for another location


Yes, I just realized we can always restore to the low watermark and we don't even need the `backUpActualHighWatermark` method.


There definitely needs to be some research on our part into
OpenTransactions. Other than that it's just discovery of new arguments
for/against.

Looking at the wiki, it seems very heavily biased. There are very few
points made in the for camp, with none expanded on, and there are many more
on the con side, with repeats *and* explanations. This is not satisfactory
to me.

So while I do think we need to maintain a neutral stance, to do that we
need someone to counteract my pro-increase viewpoint, in case I mess up.
On Jun 8, 2015 11:20 AM, "Pindar" <notifications@github.com> wrote:

> point taken, just wading in here fwiw on the existing txt.
>
> I'll have a good block of time to work on this Wednesday (my time in HK =
> GMT+8) for a few hours from 3-5pm. Let me know if there's any specific area
> that I can work on/filter or scrape. My interest is primarily to figure out
> an analytical framework to view the different possible 'stakeholder' views
> so that we can figure out where more data is required and where the common
> interests might lie. I hope that we can eventually end up with a table.
>
> Cheers!
>
> p.
>
>
>
> On Mon, Jun 8, 2015 at 11:08 PM, Gabe Appleton <notifications@github.com>
> wrote:
>
> > For 2.3 it's not about hash rate. Otherwise excellent.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/EthanHeilman/BlockSizeDebate/commit/6289c5738cff2668f6c69c09eed4f855d410f45f#commitcomment-11569258
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EthanHeilman/BlockSizeDebate/commit/6289c5738cff2668f6c69c09eed4f855d410f45f#commitcomment-11569514>
> .
>


I'd considered that too, but all fields are optional and all repeated fields are 0 or more, so simple context could determine whether or not they're pulled and rendered. Using protobuf as a relational foundation seems kind of iffy to me for that reason.


mm hm


Using the lambda expression, I can also mediate from one argument (in the returned function) to two required by msgeval()


Added config option 'showTaskCode'


Either this needs to be converted to a quilt patch or you need to change the repository format from quilt to native in `debian/source/format`.


With quilt format, you can only change files in `debian/` or debuild will complain.


This setting is only for the instance that gets spun up to facilitate creating the AMI to aid with troubleshooting. Eventually, all of the instances created from these AMIs will have only private IPs.


Der Parameter sollte `const` sein, so lange du ihn nicht verändern willst. (so wie oben bei `const char*`)


Fixed.


Fixed both.


Right. `this.workunit.getLowWatermark()` never changes.


assertValidConfig(...)


opened PR https://github.com/jenkinsci/packaging/pull/3


Just to be clear, the 'showCode' is for printing on STDOUT (it has no effect on the HTML, which always shows the code).


It is created, I managed to see it in the big list. Anyway that's a minor issue, for now all efforts to the big issue and hotfix release this week. I'm inclined to release from master, please, let me know if I'm wrong.


Allocate few big memory chunks instead of many little ones. This provides a more efficient memory usage and a more performant code, reducing the number of allocations/deallocations too.


Merge branch 'test_#9' into develop for issue #9


Remove this code since it is already inside of `normalizeComponentDeclaration()`.


typo here: "its" Super-Circle.


The option has been re-added to current master.


We have to do it carefully so we don't break other assumptions. Can you file a new issue so we can discuss it and arrive at the right solution?


Added you as an owner, @kuraga. Thanks for your help


* Inconsistent capitalisation of "Circle
* an extra empty space in "a  Domain".

(I am trying to help. Do let me know if I annoy you, then I'll stop. :-))


esta bien que sea gift_item?? no va gift_request?


... I'unno.


Fixes #50


YUuppp. Feel free to rename the variable.


Noted!


Ehhh... it should be simplified, yes, but an item property, no. ItemStack's don't even track who owns them. I'm not sure what to do with this.


Minor issue, in deed. I created empty name, empty group (which did not
exist before) and empty description. Fav list then shows the "Favorites
group", but it cannot be expanded (seems empty). Upon next app start, the
group is gone again too. But no big issue.

Yes, I have tested all day and it seems that the big corruption issue is
fixed. In addition, if you have the issue already, updating with any of
today's nightlies fixes it again, so no need for a fresh install, good job!

I tested master all the way through, yes, I think we should create the
release from master! The only critical issue I still find for now is the
one with the route-recalculation, it can really be bad ...

Best,
Hardy

On Tue, Jun 9, 2015 at 12:01 AM, vshcherb <notifications@github.com> wrote:

> It is created, I managed to see it in the big list. Anyway that's a minor
> issue, for now all efforts to the big issue and hotfix release this week.
> I'm inclined to release from master, please, let me know if I'm wrong.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/osmandapp/Osmand/commit/ddae62466c0427cf85c9abc2cdb9301040332109#commitcomment-11577050>
> .
>


Oh ok, that makes sense. I think we should reset terminal_failures on each new parse. Does that make sense to you too?


Makes sense, thanks.


when i ran this test alone using mvn test -Des.node.mode=local -Dtests.class=org.elasticsearch.action.IndicesRequestTests "-Dtests.method=*Update*" -Dtests.filter="@slow"  -e, i managed to run it

but after committing i am not able to run the tests again and i am consistently getting

Ant BuildException has occured: The following files contain tabs or
                                        nocommits:
* core/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
around Ant part ...<fail if="validate.patternsFound">The following files contain tabs or... @ 24:37 in /Users/vedil/git/elasticsearch/target/antrun/build-main.xml


Fun story: our internal CI checks with python2.6 (what Buck's minimum requirement is) and python2.7.  Luckily, as long as I remove the `.pyc` files, we can actually make this work in a version-agnostic way.

I've fixed that locally, and will land it internally soon.


I'm reading that `nodeName` is slightly preferred over `tagName`, and jQuery also has `.is('iframe')` which feels a bit better overall


Use git cherry pick to clean up your commit history before making a PR: http://git-scm.com/docs/git-cherry-pick

Also you can amend commits, rebase, and generally make things look nice: http://git-scm.com/docs/git-cherry-pick

Then you don't have to do this.


Thanks - if it's what I think it is, then I fixed this bug in 7f47179.

(I'm surprised that it would produce broken symlinks rather than fail with error on `symlinkOrCopySync`. Maybe there's a second problem hiding somewhere in my code. It *looks* correct now, but perhaps I'm missing some issue.)


KillAllTheMemes is the place where we can show our hate for the memes. Because they are annoying.


The linux build servers are mine, and I'm currently working on a replacement for the Windows server (provided by someone else, but I have remote desktop access). OS X builds I've been told are just duplicates of each other and aren't actually new builds so I need to check that out too.


I'm pretty sure the same warning is not necessary in that scenario since the tooltip is not attached to a blur-close-able popup (but rather the cursor).


initial files uploaded


A ha! This is from when I was struggling with `blur` closing the popup before clicking the anchor, `#` should work now, I'll change and test.


It does cause symlinkOrCopySync to throw (via ENOENT on statSync, iirc)


There is a race condition here unless we use a transaction. What happens if a client gets enrolled twice?


what about using something like this:
```php
$full_path = sprintf(
    "%s://%s:%s@%s%s/%s",
    ($this->ssl) ? 'sftp' : 'ftp',
    $this->getUsername(),
    $this->getPassword(),
    $this->getHost(),
    $this->getRoot(),
    $path
);

if (is_dir($full_path) and ftp_chdir($connection, $path) === true) {
    $this->setConnectionRoot();
    return ['type' => 'dir', 'path' => $path];
}
```

to avoid this Warnings:
`PHP Warning:  ftp_chdir(): Failed to change directory.`


ame comment here. What happens if this happens twice?


Bruno, this orphans another class of the same name...
https://github.com/pkp/ojs/blob/master/classes/user/form/NotificationSettingsForm.inc.php


Hi.

No corresponding bug on Moodle.org. Sorry for that - I'm still learning
the workflow for Moodle patch submission and don't know what external
modules do what. I'll create one for this and the other patch as soon as
I get a chance (I'm on-site at a client for the next couple of months,
so am not as responsive as when I'm in the office, sorry).


That feels better, will change!


Lodash is used here for _.includes - which isn't necessary in this file, and looping thru keys of an object later on. That's a valid use case, but there's no need to actually loop thru those keys (as we'll see later), so this could be removed.


      _getQuestionProcess = function(data) {
        var a, result, text;
        text = Lib.strip(data.responseText);
        if (data.length === 0) {
            data = "風水:hong-suí";
        }
        a = data.split(":");
        return result = {
          question: a[0],
          qArr: a[0].split(""),
          pArr: a[1].split("-"),
          len: a[0].length,
          qIndex: Lib.getRandomInt(0, a[0].length - 1)
        };
      };

      _Data.prototype.getQuestion = function(callback) {
        return $.ajax({
          type: 'get',
          dataType: 'text',
          url: './../q/get_question/',
          success: function(data, status) {
            if (typeof callback === 'function') {
              return callback(_getQuestionProcess(data));
            }
          },
          error: function(e) {
            return console.warn("getQuestion, ajax error", e);
          }
        });
      };

      _getOptionProcess = function(data, ans) {
        var arr, i;
        if (data.length === 0) {
          data = "金,天,氣,不,錯,只,是,有,一,點,飄,雨";
          console.warn('getOption no response');
        }
        arr = data.split(',');
        while ((i = arr.indexOf(ans)) !== -1) {
          arr.splice(i, 1);
        }
        while ((i = arr.indexOf("")) !== -1) {
          arr.splice(i, 1);
        }
        arr = arr.slice(0, 19);
        arr.push(ans);
        return arr;
      };

      _Data.prototype.getOptionList = function(word, pronounce, callback) {
        return $.ajax({
          type: 'get',
          dataType: 'text',
          url: './../q/close_pronounce/' + pronounce,
          success: function(data, status) {
            var optionList, text;
            text = Lib.strip(data.responseText);
            optionList = _getOptionProcess(data, word);
            if (typeof callback === 'function') {
              return callback(optionList);
            }
          },
          error: function() {
            return console.warn("getOptionList , ajax error ", e);
          }
        });
      };


Please take a look at #159 for a more robust way to call proper R


This function could either use a more descriptive name, or a comment explaining that it escapes a string to remove any regex special characters, so it can be used in mongo queries. It's also only used in the duplicateUrlSearch, so it could be defined inside of it.


Not sure I have a real issue with it. But here are my 5 cents: I used it for support and debugging a whole lot. I used to tell users "Exit and do a fresh app start" before having them explain how to reproduce a problem, so I could disregard anything a user may accidentally have done before encountering the issue. This made reproducing things and debugging things a whole lot more predictable. If we do not offer an easy way for novice users to exit the app, our live has just become a bit harder ...


re: lines-too-long I was just concerned about slowness of fuzzy-compare trying to compare these very long lines.
Anyway, since the side-by-side diff is limited to `-W <max-width>` (<max-width> is currently set to 160 chars which is more than enough for all reference files so far and is nice to keep it this way).  The long lines will be truncated before the fuzzy diff compare. The question is whether this truncation will cause some unintended/spurious difference.  Maybe we should use a bigger `tail` skip arg, to just skip these long lines as well which will solve both the slowness issue and the 'might fail due to truncation' issue.


If we do this, please also update .travis.yml to add the latest node versions.


I take it that shread prescrives atomic ops. Should this be gshared then?


The first thing to note is this file is called userQueryHelper, which just contains a bunch of random functions associated with users. It could be better organized by being added to the model, or in a library directory with similar files. It's currently put into a 'helpers' directory, which is where all new code is being added. This is quickly getting out of control.


Here's my attempt to improve some of the performance issues: #49


This function is only used in one place, there's no need for it to be a function.


Fixes #4


Move to a separate file. Also I'd just call it ```LocalFunctionSymbol```.


Well, thank you dearly for anything that you manage to figure out.


The variable names in this file are never cased or used in a reliable way. Sometimes they begin with an underscore. This is not typical in javascript. Often they are cryptic acronyms. A much better variable name here would be `username`, since throughout the file `_un` is used for username. However, this function would really accept any string, so `_un` is a poor choice.


@pauldowman Quick review?


> removes spaces ( should be any)

not sure what this means.


You could still normalize even if returning an iter since the normalization is along axis 1.  The way things currently are, normalize is ignored if get_iter, which would be confusing


I know this was committed a long time ago, but is there any chance of reverting it? People don't like it http://openelec.tv/forum/128-addons/74426-how-to-install-distutils-removed-in-5-0-required-for-flexget#141561


See the final diff. The series of commits are rather messy, the final diff has this in a separate file called LocalFunctionSymbol (similar to LambdaSymbol).


`fn_e_cond` is a really poor choice in naming for what appears to error callback. why not `errorCallback`? `_un` and `_em` refer to username and email here. Those would be better names.


This method is in a transactions, that's what Configuration is for.

If we still end up in a race or trigger this twice some other way, we'll get multiple rows in the table for the same data. The matching unenroll/revoke methods will remove all entries. The multiple rows created some confusion however when debugging an issue and is just data cruft.


I wonder if this has changed in the past few years because aggregating a formula field seems to work for me, and I can't remember running into this limitation recently, but it does ring a bell.

The answers to a couple of questions on Salesforce SE also report that formulas work correctly in triggers, but like the author of the second question, I haven't been able to find documentation about this.

  1.  http://salesforce.stackexchange.com/questions/9147/formula-fields-and-trigger
  2.  http://salesforce.stackexchange.com/questions/8100/do-apex-triggers-have-access-to-formula-fields


For the sake of consistency, two `<arg>` substrings in the error message could also be replace by `<args>`


finally i ran by removing the rule for tabs from pom and got these test failures
Tests with failures (first 3 out of 4):
  - org.elasticsearch.versioning.SimpleVersioningTests.testInternalVersioning
  - org.elasticsearch.index.engine.InternalEngineTests.testVersioningCreateExistsExceptionWithFlush
  - org.elasticsearch.index.engine.InternalEngineTests.testRetryWithAutogeneratedIdsAndWrongOrderWorksAndNoDuplicateDocs
so probably this is not a good change, need to dig deeper :(


`_ERRCOND` not sure what this is but it's not standard at all. I think it's a string denoting an error code. `errorCode` would be a better name.


For the sake of consistency, two <arg> substrings in the error message could also be replace by <args>


Hi,
The interface is explained in the ezstream(1) manual. The playlist-logger.sh script is a (slightly contrived) and more complex example than play.sh.


Extra whitespace in here.


That parallel doesn't really apply here and isn't always the case. For example, our `.lead` class increases `font-size` and keeps a `line-height: 1.5`. The exact values here were created to achieve a consistent height of multiple elements (like inputs and buttons). That's what determined those values.


Resque.enqueue is a class method so you could just say ```allow(Resque).to receive(:enqueue)```
does this actually work here as is?


Yea i wrote this a while ago, been meaning to pull it out.


This function is only used in one place, there's no need for it to be a function. 'squash' string is not a standard coding word so at a glance you're not sure what the function does.


same comment as above


\facepalm


What do you think about this:

```
diff --git a/docs/source/WritingTests.rst b/docs/source/WritingTests.rst
index 6c245c5..a6e81d3 100644
--- a/docs/source/WritingTests.rst
+++ b/docs/source/WritingTests.rst
@@ -5,7 +5,7 @@ Writing Avocado Tests
 =====================

 We are going to write an Avocado test in Python and we are going to inherit from
-:class:`avocado.test.Test`. This makes this test a so-called instrumented test.
+:class:`avocado.Test`. This makes this test a so-called instrumented test.

 Basic example
 =============
@@ -27,11 +27,27 @@ does nothing besides sleeping for a while::
 This is about the simplest test you can write for Avocado, while still
 leveraging its API power.

-As can be seen, an Avocado test is a method that starts with ``test`` (so
-our method named simply ``test`` is indeed valid) in a class that inherits
-from :mod:`avocado.Test`. For the class name, you can pick any name you
-like, but we do recommend that it follows the CamelCase convention, for PEP8
-consistency.
+What is an Avocado Test
+-----------------------
+
+As can be seen in the example above, an Avocado test is a method that
+starts with ``test`` in a class that inherits from :mod:`avocado.Test`.
+
+Multiple tests and naming conventions
+-------------------------------------
+
+You can have multiple tests in a single class.
+
+To do so, just give the methods names that start with ``test``, say
+``test_foo``, ``test_bar`` and so on. We recommend you follow this naming
+style, as defined in the `PEP8 Function Names`_ section.
+
+For the class name, you can pick any name you like, but we also recommend
+that it follows the CamelCase convention, also known as CapWords, defined
+in the PEP 8 document under `Class Names`_.
+
+Convenience Attributes
+----------------------

 Note that the test class provides you with a number of convenience attributes:

@@ -757,3 +773,5 @@ It is also recommended that you take a look at the
 	 also have had such a test for `Autotest`_ for a long time.

 .. _Autotest: http://autotest.github.io
+.. _Class Names: https://www.python.org/dev/peps/pep-0008/
+.. _PEP8 Function Names: https://www.python.org/dev/peps/pep-0008/#function-names
```


Suggested:
/** Return: `true` if the value is defined */


Change of whitespace through the file has broken the diff tool here. You should never change whitespace in a file and make code changes in the same commit.


Perhaps its a typo and should be `4`?


fn_e_cond is a really poor choice in naming for what appears to error callback. why not errorCallback? _un and _em refer to username and email here. Those would be better names. There's no reason to add the underscore before parameters.


_ERRCOND is not a standard way to name a variable. The casing, underscore, and acronym usage is not typical. It's not a constant either. I think it's a string denoting an error code. errorCode would be a better name.


> Queries Users having starts-with-URL semantic on url property

This is kind of unclear, I'm not sure what it means.


Agree!


This is called a map in JS


tests well on Linux as well.


simple reddit crawler, adding comments later


@jcstringer why were the tokens added back in?


Ok, Doesn't seem to affect the issue I'm seeing. Will create another issue.


I would rather just create a fake `$$mdDateLocale` instance with whatever arbitrary properties.


FYI, there is no reason to use a "+" for multiline strings contained within parenthesis, i.e. the following is legal:

```python
mystr = (
    'once upon '
    'a time')
```


Just a question, why did you replace `string TrueCraftLaunchParams` with var?


Hmm, sure about this? Swagger-ui is only dependent on the generated swagger.json, no? Is something not being generated in there?


LGTM


Since this isn't `paranoia` or `rails` specific, I just wrote a little script that uses the `pg` gem to create multiple records with a unique index on a null field.

https://gist.github.com/theunraveler/366ba9c173003d106fdc

To run the script, do the following:

1. Create a `paranoia_null_unique` database (`psql -c "CREATE DATABASE paranoia_null_unique"`).
2. Install the `pg` gem (`gem install pg`).
3. Run the script (`./paranoia_null_unique.rb`).


!auth.isRoot()


These remaps conflict with the mapping of Shift + h and Shift + l (on line 349-350)


since we send the router to transition hooks, needed both Router and RoutingContext to have the `makePath` `makeHref` methods, so put them in the routing utils module.


users.forEach(callback) would be fine here - no need for `_.each`


-> "write succeeded so..." ?


I thought about putting this stuff in `routerContext` on real context instead, and then `RoutingContext` could just pass it through, but decided to only have context set in one place to minimize the work to answer the question "where the router set context?"


`sluggedUrl` doesn't really make sense as a name. In web coding, a slug refers to an url-friendly string generated from a human readable string. A more sensible variable name would just be `slug`. However, I think that the `determineUrl` function should be responsible for slugging. The name `determineUrl` just doesn't make sense here. A better name would be function `findAvailableSlug(username)`

Also, there's extra whitespace.


(also, this stuff belongs on Router I think because its deeply coupled to transitions and `nextLocation` etc.)


did you forget to push this file?


Repushed as requested


Brant -

This looks very interesting; could you provide a few unit tests that illustrates the usage?

Thanks!

-Jeff


Right! I'll just fix the commit message since this is soooo trivial. Thanks for spotting that.


I am not sure how or why this works, or what the purpose of this is. I've never seen promises used this way.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/13126/testReport/) for this commit**


Hello world, and welcome to my very first repository
greetings
ALE


This is the biggest issue in the file. It only checks for duplicate url's on the User collection. But it should be checking on the Channel collection. We shouldn't be using `user.url` anymore.


Insert another line.


Ah, perfect.

Btw, I meant to mention: The broccoli-plugin API will still change a bit; it's completely unreleased work-in-progress. You're welcome to use it of course, if you're prepared to update your code as you go. I'd suggest holding off on releasing code built on top of the unreleased broccoli-plugin into the wild though, as users might hit very confusing compatibility errors down the line.


We should get the version from somewhere central; don't repeat yourself.

Guarantee you I'll forget to update this...


This entire area is so needlessly complicated that it's hard to explain where to begin. First a Promise is created, then a query is executed. The results are processed and added to an array, then the Promise is resolved. After the promise is resolved, the array is converted to an object map. The results could have been added to the object map at the start, and no Promise callback was necessary since none of this code is asynchronous.


yeah, i could yield a pd.Series but it's easier to yield a dict and later work with that to make the DataFrame; or i could normalize with the dict itself but that adds a few lines...


Nonstard variable naming


Seems good now.


rax retry tests


Turns out that this is not right. Even with TypedMemberVariableTransformer we need to run MemberVariableTransformer. This should/could be improved to have one transformer do everything as needed.


Done: 4b49f6d0b04b04ad3922229a582178ca02c3ec3c.


right changing


suffixes.indexOf(suffix) > -1 would be the same here without needing to use lodash. includes is fine though.


XML Files will point to wrong location because the files were moved into large/small folders manually.


@mavericklou Since this change, I can't build latest drake, because c4 0.2.1-SNAPSHOT isn't in any maven repo. If you're going to be working on this for some extended period, can you publish a non-snapshot version, such as 0.2.1-alpha1, and update drake to depend on that instead?


Since go is pass by value only,  a pointer to unsafe.Pointer type pixels must be passed to the function otherwise the value of pixels will be unchanged in the caller's code block.


> I'd suggest holding off on releasing code built on top of the unreleased broccoli-plugin into the wild

Hm actually disregard that. It's obviously alpha code, but at least we can avoid the sorts of super-confusing errors I'm worried about by putting a feature flag on the first release.


sonora, I would disagree. Google provided a clear and a nice way to kill app from Android 4, but they didn't provide any API to developers! (which means something).

As I see many non-technical users (better to say not geeky users) are aware of the option of killing apps (may be because of other issues with system)


We aren't using broccoli-plugin, but we'd like to switch to using it eventually, if the api matures to be stable and sane


@mk01
todo: we have to think about a new naming of the packages. Both versions, one for RPi and one for i.MX6 are different but get the same name at the moment. May confusing in the future


isn't this condition `if i < length` always True?
well, at least that's the case for fixed-point values in range(-32768, 32768) and 'precisionBits' in range(1,17).


Please take a look at: https://docs.python.org/2/library/functions.html#property


thanks! just added.


FIXME : put the correct comments :)


This comment is confusing.


Thinking about this commit a bit more, it might be cleaner to have something like `createRouterContext` or `new RouterContext` and pass it all the stuff it needs to create an object with he public API we want, then we use it to send to the transition hooks in `Router` and `getChildContext` in `RoutingContext`.


Will throw an error, status is not defined


This code, aside from the variable names is likely functional. But I think the logic could be changed it make it a lot simpler and easier to read.


Is this not the same as just
if (   depth < 16 * ONE_PLY
      && moveCount >= FutilityMoveCounts[improving][depth] + SpNode)

Maybe you intended
if (   depth < 16 * ONE_PLY
    && moveCount >= (FutilityMoveCounts[improving][depth] + SpNode ? 2 : 0))


[![Seated Buddha](http://api.artsmia.org/images/5109/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5109)


[![The Buddha Manbaya](http://api.artsmia.org/images/33050/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33050)


[![Ceremonial Offering Vessel (Hsun ok)](http://api.artsmia.org/images/45723/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=45723)


[![Ceremonial Bell](http://api.artsmia.org/images/91540/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91540)


[![Upstream 2](http://api.artsmia.org/images/123068/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=123068)


[![Cosmetic case](http://api.artsmia.org/images/34448/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=34448)


[![Round box](http://api.artsmia.org/images/34453/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=34453)


[![Square box](http://api.artsmia.org/images/34454/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=34454)


[![Hunting Coat](http://api.artsmia.org/images/114602/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=114602)


[![Pair of Moccasins](http://api.artsmia.org/images/89735/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=89735)


[![Buffalo Hair Rope](http://api.artsmia.org/images/89934/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=89934)


[![Riding Quirt](http://api.artsmia.org/images/89935/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=89935)


[![Belt, from a three-piece set](http://api.artsmia.org/images/90895/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90895)


[![Pair of Leggings, from a three-piece costume](http://api.artsmia.org/images/90896/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90896)


[![Lance Case](http://api.artsmia.org/images/90951/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90951)


[![Saddle Blanket](http://api.artsmia.org/images/90964/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90964)


[![Elk Tooth Dress](http://api.artsmia.org/images/90965/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90965)


[![Gun Scabbard](http://api.artsmia.org/images/90966/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90966)


[![Forehead Ornament for a Horse](http://api.artsmia.org/images/90972/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90972)


[![Wedding Blanket](http://api.artsmia.org/images/91008/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91008)


[![Horse Crupper](http://api.artsmia.org/images/91011/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91011)


[![Awl Case with Awl](http://api.artsmia.org/images/94823/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=94823)


[![Hmong Veteran](http://api.artsmia.org/images/122964/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122964)


[![Hmong Veteran](http://api.artsmia.org/images/122965/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122965)


[![Hmong Veteran](http://api.artsmia.org/images/122967/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122967)


[![Hmong Veteran](http://api.artsmia.org/images/122966/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122966)


[![Hmong Veteran](http://api.artsmia.org/images/122969/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122969)


[![Hmong Veteran](http://api.artsmia.org/images/122970/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122970)


[![Hmong Veteran](http://api.artsmia.org/images/122971/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122971)


[![Portrait of Anika Psalmon, Mrs. Robin](http://api.artsmia.org/images/584/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=584)


[![The Church at Chailly](http://api.artsmia.org/images/1637/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1637)


[![Women's Monument, Union Buildings, Pretoria.](http://api.artsmia.org/images/119940/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119940)


[![Street traders and the colonnade of the Walter Sisulu Square of Dedication, Kliptown Sowto.](http://api.artsmia.org/images/120083/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120083)


[![On 16 August 2012 South African Police shot striking mineworkers of the Lonro platinum mines, killing 34 and wounding 78. Many of the casualties occurred here, on and around this koppie. Marikana, North-West Province.](http://api.artsmia.org/images/120084/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120084)


[![Memorial to Sister Dr. Mary Aidan Quinlan who was murdered and perhaps partially cannibalized on November 9, 1952 by a mob near Duncan Village. Catholic Church, Duncan Village, East London.](http://api.artsmia.org/images/120086/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120086)


[![A domestic worker's afternoon off. Sunninghill, Sandton, Johannesburg.](http://api.artsmia.org/images/120087/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120087)


[![Detail of a memorial to children "We are still here", consisting of copies of advertisements that appeared in the Cape Government Gazette. Longmarket pedestrian mall, Cape Town.](http://api.artsmia.org/images/120088/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120088)


[![A barber under his canopy and with a connection to electricity on Smit Street, Hillbrown, Johannesburg.](http://api.artsmia.org/images/120089/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120089)


[!["Unity is power: Let us be United". Carving in wild fig by Noria Mabasa, on the campus of the University of the Free State, Bloemfontein.](http://api.artsmia.org/images/120091/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120091)


[![Miriam Mazibuko waters the garden of her RDP house for which she waited eight years. It consists of one room. Her four children live with her in-laws. Extension 8, Far East Alexandra Township.](http://api.artsmia.org/images/120092/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120092)


[![Luke Kgatitsoe in his house, bulldozed in February 1984 by the government after the forced removal of the people of Magopa, black-owned farm, which had been declared a "black spot", Ventersdorp district, Transvaal.](http://api.artsmia.org/images/120094/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120094)


[![Kite flying near Phuthaditjhaba, in the apartheid Bantustan of Qwa Qwa.](http://api.artsmia.org/images/120095/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120095)


[![Remnant of a wild almond hedge planted in 1660 to keep the indigenous Khoi out of the first European settlement in South Africa. Kirstenbosch, Cape Town.](http://api.artsmia.org/images/120096/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120096)


[![A Transkei Family in their shelter, KTC squatter camp. The framework was wade of strips of Port Jackson bush. For privacy black sheet were used around the lower part of the shelter. For light, translucent plastic was used on the dome. Cape Town.](http://api.artsmia.org/images/120097/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120097)


[![Stairway to a storeroom, Meerlust wine farm, Stellenbosch, Cape.](http://api.artsmia.org/images/120099/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120099)


[![Bus stop, Derby Road, Lorentzcille, Johannesburg.](http://api.artsmia.org/images/120100/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120100)


[![Thirteen kilometers of this coastline were a White Group Area, Blouberstrand, Cape Town.](http://api.artsmia.org/images/120101/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120101)


[![Dutch Reformed Church, completed in 1984, Quellerina, Johannesburg. 3 November 1986](http://api.artsmia.org/images/120103/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120103)


[![Portrait of Anika Psalmon, Mrs. Robin](http://api.artsmia.org/images/584/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=584)


[![The Church at Chailly](http://api.artsmia.org/images/1637/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1637)


[![Seated Buddha](http://api.artsmia.org/images/5109/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=5109)


[![The Buddha Manbaya](http://api.artsmia.org/images/33050/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=33050)


[![Cosmetic case](http://api.artsmia.org/images/34448/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=34448)


[![Round box](http://api.artsmia.org/images/34453/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=34453)


[![Square box](http://api.artsmia.org/images/34454/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=34454)


[![Ceremonial Offering Vessel (Hsun ok)](http://api.artsmia.org/images/45723/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=45723)


[![Pair of Moccasins](http://api.artsmia.org/images/89735/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=89735)


[![Buffalo Hair Rope](http://api.artsmia.org/images/89934/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=89934)


PS: Test will still fail on `iojs`, waiting to merge bump-deps branch to fix this. I'll do this tomorrow.


[![Riding Quirt](http://api.artsmia.org/images/89935/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=89935)


[![Belt, from a three-piece set](http://api.artsmia.org/images/90895/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90895)


[![Pair of Leggings, from a three-piece costume](http://api.artsmia.org/images/90896/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90896)


[![Lance Case](http://api.artsmia.org/images/90951/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90951)


@vlj , or this one may be D3D12_ENCODE_SHADER_4_COMPONENT_MAPPING(4,4,4,5) that show black texture.

![vertex](https://cloud.githubusercontent.com/assets/3000282/8047205/ed3cbcd2-0e74-11e5-8e03-a0fe61f613b1.jpg)


[![Saddle Blanket](http://api.artsmia.org/images/90964/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90964)


[![Elk Tooth Dress](http://api.artsmia.org/images/90965/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90965)


[![Gun Scabbard](http://api.artsmia.org/images/90966/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90966)


[![Forehead Ornament for a Horse](http://api.artsmia.org/images/90972/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=90972)


[![Wedding Blanket](http://api.artsmia.org/images/91008/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91008)


[![Horse Crupper](http://api.artsmia.org/images/91011/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91011)


[![Ceremonial Bell](http://api.artsmia.org/images/91540/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=91540)


[![Awl Case with Awl](http://api.artsmia.org/images/94823/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=94823)


[![Hunting Coat](http://api.artsmia.org/images/114602/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=114602)


[![Women's Monument, Union Buildings, Pretoria.](http://api.artsmia.org/images/119940/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=119940)


[![Street traders and the colonnade of the Walter Sisulu Square of Dedication, Kliptown Sowto.](http://api.artsmia.org/images/120083/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120083)


[![On 16 August 2012 South African Police shot striking mineworkers of the Lonro platinum mines, killing 34 and wounding 78. Many of the casualties occurred here, on and around this koppie. Marikana, North-West Province.](http://api.artsmia.org/images/120084/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120084)


[![Memorial to Sister Dr. Mary Aidan Quinlan who was murdered and perhaps partially cannibalized on November 9, 1952 by a mob near Duncan Village. Catholic Church, Duncan Village, East London.](http://api.artsmia.org/images/120086/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120086)


[![A domestic worker's afternoon off. Sunninghill, Sandton, Johannesburg.](http://api.artsmia.org/images/120087/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120087)


[![Detail of a memorial to children "We are still here", consisting of copies of advertisements that appeared in the Cape Government Gazette. Longmarket pedestrian mall, Cape Town.](http://api.artsmia.org/images/120088/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120088)


[![A barber under his canopy and with a connection to electricity on Smit Street, Hillbrown, Johannesburg.](http://api.artsmia.org/images/120089/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120089)


[!["Unity is power: Let us be United". Carving in wild fig by Noria Mabasa, on the campus of the University of the Free State, Bloemfontein.](http://api.artsmia.org/images/120091/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120091)


[![Miriam Mazibuko waters the garden of her RDP house for which she waited eight years. It consists of one room. Her four children live with her in-laws. Extension 8, Far East Alexandra Township.](http://api.artsmia.org/images/120092/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120092)


[![Luke Kgatitsoe in his house, bulldozed in February 1984 by the government after the forced removal of the people of Magopa, black-owned farm, which had been declared a "black spot", Ventersdorp district, Transvaal.](http://api.artsmia.org/images/120094/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120094)


[![Kite flying near Phuthaditjhaba, in the apartheid Bantustan of Qwa Qwa.](http://api.artsmia.org/images/120095/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120095)


[![Remnant of a wild almond hedge planted in 1660 to keep the indigenous Khoi out of the first European settlement in South Africa. Kirstenbosch, Cape Town.](http://api.artsmia.org/images/120096/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120096)


[![A Transkei Family in their shelter, KTC squatter camp. The framework was wade of strips of Port Jackson bush. For privacy black sheet were used around the lower part of the shelter. For light, translucent plastic was used on the dome. Cape Town.](http://api.artsmia.org/images/120097/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120097)


[![Stairway to a storeroom, Meerlust wine farm, Stellenbosch, Cape.](http://api.artsmia.org/images/120099/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120099)


[![Bus stop, Derby Road, Lorentzcille, Johannesburg.](http://api.artsmia.org/images/120100/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120100)


[![Thirteen kilometers of this coastline were a White Group Area, Blouberstrand, Cape Town.](http://api.artsmia.org/images/120101/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120101)


[![Dutch Reformed Church, completed in 1984, Quellerina, Johannesburg. 3 November 1986](http://api.artsmia.org/images/120103/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120103)


[![Hmong Veteran](http://api.artsmia.org/images/122964/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122964)


[![Hmong Veteran](http://api.artsmia.org/images/122965/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122965)


[![Hmong Veteran](http://api.artsmia.org/images/122966/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122966)


[![Hmong Veteran](http://api.artsmia.org/images/122967/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122967)


[![Hmong Veteran](http://api.artsmia.org/images/122969/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122969)


[![Hmong Veteran](http://api.artsmia.org/images/122970/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122970)


[![Hmong Veteran](http://api.artsmia.org/images/122971/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122971)


[![Upstream 2](http://api.artsmia.org/images/123068/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=123068)


this commit and last one may solve the problem in intermittent error in [build](https://travis-ci.org/twstrike/Enigmail/builds/65914316#L4251)


ここは間違ってキーボードタイプしてしまったようですね。
プログラムが誤動作するといけないので元に戻しておきましょう。


More acronyms


@czue can we delete dca reports (now under `custom/_legacy/dca`)? Was trolling for calls to `case/by_owner`, looked up which domains were using dca reports, found only

```
"dca-malawi": "dca",
"eagles-fahu": "dca",
```
in the `DOMAIN_MODULE_CONFIG` doc on prod, and saw that those domains haven't submitted since 2014 and 2013, respectively. Someone should probably double-check my work too of course, but do you know of any reason we definitely couldn't remove this?


![screen shot 2015-06-08 at 5 28 17 pm](https://cloud.githubusercontent.com/assets/4607236/8047221/1f4cdef4-0e08-11e5-9737-b2d933275cf7.png)
![screen shot 2015-06-08 at 5 31 48 pm](https://cloud.githubusercontent.com/assets/4607236/8047222/1f4d6036-0e08-11e5-8134-29cde75df6dd.png)
![screen shot 2015-06-08 at 5 31 53 pm](https://cloud.githubusercontent.com/assets/4607236/8047223/1f4e1882-0e08-11e5-9eb9-cd71156be72f.png)


replace `!== pending` with `!== 'pending'`


This has the added benefit of documenting/learning the router. A `routingContext` or `navigator` or whatever the heck we call it goes to transition hooks, is available on context of route components, etc. instead of documenting each API individually, we just document and learn one thing.


Java の場合は、変数やメソッドは小文字から、クラスは大文字から始めるのが慣習となっています。他の人が見てもわかるプログラムにするために揃えておいたほうがよいでしょう。


hpwh_residential (nmerket) - x86_64-MacOS-10.9-clang: OK (1663 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Hmm, okay. But I'm not sure that you can execute a system file.


And the performance on these reports has got to be terrible... (see https://github.com/dimagi/commcare-hq/blob/6deb06417144b6717e74327abf233ef753b5d875/custom/_legacy/dca/reports.py#L183 for full code).


Please try to follow JavaScript naming guidelines - make it workingDirectory instead.


You mean `clearRequests` ? Or do you want to clear only the `rawData.request` ?


I am not comfortable about this happening around each one of the tests. Can we please contain it to the tests that modify the gpg directory?


URL のドメインのみを取得する処理は、今回は必要ないと思います。
サムネイルを取得する http://capture.heartrails.com/free の仕様を確認してみましょう。


This calls `User.findOne` but a user could have both a duplicate email address and username, but shared them with separate users. Depending on how it's consumed, there is a possibility it could cause issues. Again, the URL is being checked across the User table, when it should be Channel.


Everything before here in the conclusion needs to be deleted.


This is bad. Can you make the code not throw NullPointerException ? Casting NullPointerException to proper exception is very bad.


delete references; all links should be at appropriate locations within the text


This breaks the build with current libressl-portable git.

../lib/.libs/libcurl.so: undefined reference to `TLS_client_method'
collect2: error: ld returned 1 exit status

Libressl as of current git reports its OPENSSL_VERSION_NUMBER as 0x20000000L, but it lacks TLS_client_method.

I used a dirty workaround like
#if (OPENSSL_VERSION_NUMBER >= 0x10100000L && !defined(LIBRESSL_VERSION_NUMBER))

but I'm sure you can find a prettier way :)

Thank you.


Is it really necessary ? Isn't it the default status ?


nice catch, Kenny!


Changed the order of some sentences and cut out what to me appears a redundancy ("any Domain which the Circle is authorized to impact" already includes "any Domain controlled by the Circle itself").


I'm afraid it would not cleanup the tests dir every time if the test fails due to some runtime error, which was also the reason of that intermittent error. Any ideas?


URL は一行で入力できるデータとなっているので、ここでは TextArea ではなく TextField を使ったほうがよさそうです。


You should add ".idea/" and "*.iml" to your .gitignore to avoid polluting your git commits with these types of changes. Besides changing .gitignore you would also have to run "git rm -r .idea", "git rm nanodegree.iml", and "git rm app/app.iml".


We should always iterate over the global handlers list regardless of the message contents. The addressed handlers should be called only when `self.addresser.is_match(s)` returns true. To that end, I would refactor the dispatching into a function like `dispatch(handlers: Vec<Box<ChatHandler>>, msg: &str)` instead of having the loop at 112, and then the code around 105 would read like

```rust
// Maybe dispatch to addressed handlers
if self.addresser.is_match(msg_str) {
    dispatch(&self.addressed_handlers, msg_str);
}

// Always dispatch to global handlers
dispatch(&self.handlers, msg_str);
```


This is really lazy- it escapes the result of the user query for a regex just so it can compare it to the `escapedUn` string. It should just compare the result to the original username parameter. It's kind of hard to follow.


Thanks @jsquyres :+1:


It looks like you're trying to tie this in to the rshell assignment, but you're doing it in a VERY wordy manner.  I could say what you're saying in 3 sentences.

Replacing your conclusion with something much shorter will get you 100/100 if it's good; the ec offer still stands though for something a bit more expansive.

Whatever you submit next will be the final submission I'll use to enter your grade.


I appreciate it.  I had enough troubles trying to get my ideas out so I'm glad someone is paying attention to grammar and the like [😊]

Mary Pruce

VSE inc/Expert Link

See My Roles<http://www.frogroles.com/companies/expert-link/people/10202>

900 Wheeler Way suite A

Langhorne, PA 19047

ph: 215-953-8568 ext 332

cell: 860-329-9098

________________________________
From: Martin Röll <notifications@github.com>
Sent: Monday, June 8, 2015 6:07 PM
To: mpruce/Holacracy-Constitution
Cc: Mary Pruce
Subject: Re: [Holacracy-Constitution] Update Holacracy-Constitution.md (62c9773)

  *   Inconsistent capitalisation of "Circle
  *   an extra empty space in "a Domain".

(I am trying to help. Do let me know if I annoy you, then I'll stop. :-))

—
Reply to this email directly or view it on GitHub<https://github.com/mpruce/Holacracy-Constitution/commit/62c9773bdd834e97d7e3056195efbc5e85a8931e#commitcomment-11577132>.


what is this doing here?!


I don't think you actually have to do this. Retrofit's callbacks are already executed in the UI thread. See http://square.github.io/retrofit/javadoc/retrofit/Callback.html


The store has to be notified.


Which command + test file throws the errors? I'm not seeing them?

````
➜  jhannah-Air:bioperl6 git:(master) perl6 -v
This is perl6 version 2015.05-139-g2281689 built on MoarVM version 2015.05-49-g07fbd62
➜  jhannah-Air:bioperl6 git:(master) prove -e 'perl6' t/Annotation/Annotation.t
t/Annotation/Annotation.t .. ok
All tests successful.
Files=1, Tests=8,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.33 cusr  0.03 csys =  0.38 CPU)
Result: PASS
````


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 55](https://teamcity.labkey.org/viewLog.html?buildId=254127&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabkeyTrunk :: build Build time: 00:00:00


delete this section; just get straight to the point and the examples


Got as far as branching


Did not look like an API method, though the public interfaces of Jenkins plugins are so overgrown it is generally hard to tell what someone might be considering an API.


If I wanted this information, I'd read the man page.  Get to explaining the examples.


Indeed


What are we going to do with it?

I've read 30 lines, and I still don't know where you're going with this.


@alexanderGugel Hey just a curious question. What is the purpose of this commit, is it to reduce garbage collection? Is it something I should be doing my application code?
Keep up the good work!
cheers, Hein


Once you tell me what you're doing, you need to tell me why I should care.


Don't display large output like this; if the output is more than ~10 lines, you need to come up with a better example whose about is shorter.


[No](http://minecraft.gamepedia.com/Commands#Raw_JSON_text), it's `translate`, full text.


I appreciate it.  It was hard enough to get the idea out of my head.  Nice to see someone paying attention to grammar


Why do I care about these flags?  Again, if I just wanted to know what the flags did, then I'd read the man page.  You have to convince me that you're example is useful.


sorry about the hack... just did it to get the site back up


what if we embrace this convention instead, and rename this to `decodedJSON(forKey:)`


Ditto here. Maybe we name this `typeMismatch(forObject:)`


This commit was written for me.


Your commit has a lot of extra junk in it that needs to be removed.


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1669 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


First one was a commit that i have accidentally checkedout before the push so all changes ive made were wiped. But second one is the right one. Sorry about a bit late b/c github technical failure on my part


This is the first real-world example you've given.  (Although it's still not explained super well.)


There are some tests at https://github.com/NuGet/NuGetGallery/blob/96a15f5b19e23a46e60923204e29fb84eb8aaff2/tests/NuGetGallery.FunctionalTests/WebUITests/BasicPages/SecurityHeaderTest.cs#L29


You need to use a MUCH shorter file, and not talk about any options that you're not going to explicitly explain.


I foresee this going horribly if anybody ever uses a literal IPv6 address there. Maybe check for a braces around it? Users really SHOULDN'T be passing an IP here, but if they use the path-based buckets, we shouldn't just break it in case.


It's my fault, but the video for the site is different from the video you normally click on. You want to use https://www.youtube.com/embed/L2l1vaYiRD0 as the link.


The main thing you're missing is answering the question: why should I care?  Without that, I can't give you more than a 50 on the assignment.

I'm not going to enter your grade right now.  Instead, I'm going to give you a chance to rework this.  It's probably going to take a lot of work.


@eddwardo this is great, but it's not "function capturing". This is really more about pattern matching and guard clauses, yes?


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


s/utilize/use


Since `fmt` doesn't vary any more, and strings `lo` and `hi` are formatted using `fmt`, their len() is always the same, so it is no longer necessary to take the min() between them.
Am I missing something else?


delete "rather important"


functions are always in backticks


delete this sentence


That's very good.


@eddwardo why do you need to call `String.strip` if the String module is imported?


Thanks, Riba!

1) okay, I'll replace the load_components with use base

2) Yes, there's a good reason to always store UTC in the database. I'll update the docs to make this clear:

If the datetime is stored in any time zone that has Daylight Saving Time, then any datetime that occurs during the transition out of Daylight Saving Time (when the clock goes back one hour) will be ambiguous. DateTime handles this by always using the latest real time for the given clock time. See https://metacpan.org/pod/DateTime#Ambiguous-Local-Times.

If the actual datetime stored is the earliest real time for the given clock time, then the retrieved value will be one hour later than what was stored. (Yeah, I hate time zones and Daylight Saving Time...)

Also, I found out the hard way that DateTime::Format::SQLite::format_datetime always forces the datetimes to UTC. This is arguably a bug -- other database formatters (such as DateTime::Format::MySQL) don't change time zone in format_datetime.

3) good point. I'll update the code and tests to handle all combinations of nulls

4) it's a hack because it's a workaround for InflateColumn::DateTime::_pre_deflate_datetime, which doesn't clone the DateTime before setting time zone. I was going to file a bug and/or pull request, but haven't gotten to it yet.


false; all this function gives us is the pid


You're missing the `**` to close the bold formatting.


false; these are two separate functions


    URL のドメインのみを取得する処理は、今回は必要ないと思います。

すいません、とコメントしてたのですが、課題で必要なようですね。
次は、URL をリンク付きにする処理を加えてみましょう。


Sure thing.  Based on the readme it looks like tests that actually call to
Couchbase on the beer-sample bucket are fine?

Thanks,
Brant

On Monday, June 8, 2015, Jeffry Morris <notifications@github.com> wrote:

> Brant -
>
> This looks very interesting; could you provide a few unit tests that
> illustrates the usage?
>
> Thanks!
>
> -Jeff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/brantburnett/Linq2Couchbase/commit/431c6fc0671ac3baab8d79698ff74f6064dc0fd4#commitcomment-11577649>
> .
>

--
Thanks,
Brant Burnett
CenterEdge Software
(336) 598-5934
http://centeredgesoftware.com


@eddwardo would you mind doing PRs for future changes please? I think each of the recent changes could have used some review by me or @parroty or @theworkerant or @davetoxa. Thanks!


>allows us to retrieve

Throughout this writeup, it sounds like you're a peasant pretending to be British royalty.  Please don't do this.  Simple language only.  Change the above to just "retrieves".


This whole sentence would be better as:

> `getpwuid` returns information about a user.

This is 3x shorter and conveys the same information.


I added the proper environment variable that suppresses the end-of-file quotes.


I think you need the spell checker :) for the comment.


You'll want to use .with_server_config rather than load/unload.

```ruby
def rest(..)
   with_server_config do
     rest_client.request(...)
   end
end
```


This example doesn't convey any information not present in the type signature above.  Delete.


I ran the first command - I get this instead of No such file exception ----

java.nio.file.AccessDeniedException: c:\dwasfiles\sites\testjetty\VirtualDirectory0\site\wwwroot\bin\jetty-distribution-9.2.10.v20150310\etc\home-base-warning.xml
	at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:83)
	at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:90)
	at sun.nio.fs.WindowsLinkSupport.getRealPath(WindowsLinkSupport.java:259)
	at sun.nio.fs.WindowsPath.toRealPath(WindowsPath.java:836)
	at sun.nio.fs.WindowsPath.toRealPath(WindowsPath.java:44)
	at org.eclipse.jetty.start.FS.toRealPath(FS.java:164)
	at org.eclipse.jetty.start.StartArgs.addUniqueXmlFile(StartArgs.java:154)
	at org.eclipse.jetty.start.StartArgs.expandModules(StartArgs.java:433)
	at org.eclipse.jetty.start.Main.processCommandLine(Main.java:627)
	at org.eclipse.jetty.start.Main.main(Main.java:111)

I think I get this because I dont have access to c:\dwasfiles\sites and the getRealPath code looks for each segement or something like that. I do have full access to everything under c:\dwasfiles\sites\testjetty\VirtualDirectory0


Finally a real example!  This should be at the very top of the section.


Delete all these tabs.  Comments are a good idea, but the comments you have don't convey any information and need to be removed.


This comment is from another function above (squashString)- looks like it was moved to the wrong place.


This is already done by getView(). Just toggle the checked state and call `notifydatasetchanged()` to have the views refreshed.


I'm confused... the title is "Only activate public properties", this seem to be includeNonPublic ```true```


Your writing in this whole file is WAY to verbose.  Just show the example and explain it and do nothing else.


@andreasohlund - Auditing as its own behavior makes sense. But what is the advantage in separating the auditing the host info to its own behavior?


There is no syscall `Stat`.  You mean `stat`.  And again, this needs to be in backticks.

Minor mistakes like this are scattered all over your writeup.  This makes me think you didn't put very much time into proofreading.


No.  Start with the example.  That will explain the purpose.


lol "vital"


Hello Chris, thank you so much for creating this package, i was just wondering why you changed this part of the code, do you intend for an app to have just 1 model ? Please need clarification on this, thank you.


I got 'undefined UINT16_MAX' when attempted to build it on FreeBSD, where is it being defined? I just found references on .c files


:+1: :beers:


Razor is special :laughing:


@levicole DWMR. Nicely done. Good good. Press on.


How do I update OpenResty to 1.7.10.1?


Your still following the format of the man pages.  I can't give you more than a 50/100 for this.  You need to provide a good example and explain the example and do nothing else.

I'm not entering your grade at this point. Please resubmit by Friday at midnight.


I reverted the change to `MarketplacePermission.java`.


Only use `#`, not `===`


The bug refers to the use of `[Activate]` - which was replaced by things like `[ActionContext]`. That's where we want the behavior change.

This part is just the implementation of how `@inject` works, which is necessarily different, since we generate the code for you.


Subheadings need to have the appropriate number of `#`s


Is there another way to do this without introducing a new function? I know it is called twice below but maybe an anonymous lambda in the right place would avoid the need to name this.


I'm not sure yet of all the implications of having a separate object/class that isn't a React class. Let's stick with a component class for now and see how it shakes out.


Every programming language is text-based.  I think you mean something else.


AWK does not exist just for GNU/Linux.  Any Unix can run it.


reword


@thanhdut DWMR (done with my review). Press on.


You're not being more particular, your providing an example.  So you should say `For example` instead.

Never say "a variety of other things"


filenames go in backticks


teh


delete


@thanhdut DWMR. You can combine the work and the return on one line. ie. `return number++`


delete section header


This will resolve with true and not the link object - probably not what we want.


No passive voice


This is good, though.


1 sentence per line


Thanks for updating.
Also, `save` does not need an implementation so you could remove the todo:
````java
    @Override
    public void save() {
        /* not needed*/
    }
````


Your example doesn't use this feature, so don't explain it here.


Gotcha. Yeah, I can make this cleaner.


typo: Runing -> Running
but let's not waste too much time hacking around with the command line integration
we should use a gradle plugin, e.g.:
https://github.com/apache/samza/blob/master/gradle/rat.gradle
but currently only consumable by copying source?
or failing that we can hook into the ant integration:
http://creadur.apache.org/rat/apache-rat-tasks/
http://creadur.apache.org/rat/apidocs/org/apache/rat/anttasks/package-frame.html


thanks... just wonder if the commit comment wouldn't be better as "Activate public properties".  I'll back gently away from the sharp edges now.


NEVER SAY UTILIZING!!!!!!!!

Say use.


s/similarly to/like


backticks; you're missing them in lost of places


multiplication method name should probably be multiply.  we didn't name the other methods addition (add) or subtraction (subtract).

rigght is spelled incorrectly


rake has been added back in again. This causes problems for any Gemfile that requires a different version of rake


You didn't mention question mark above.


Only super users could create skills. Now only a user's skill correctly link to their profile


hpwh_residential (nmerket) - i386-Windows-7-VisualStudio-12: OK (1669 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


You could use the ternary operator for this like you did above.


attempt to clean the alert emails a little.
Going grom
https://www.evernote.com/l/AAWjow1bZcJJ5JOQPMnZY5Gy_3e7P2UV9gs
to
https://www.evernote.com/l/AAVa8Xcl1G9NA4tKskVSioCMBGWEEsZvV7I

@stondin - any thoughts?


@thanhdut Is this line really needed? FYI > https://github.com/Bloc/ios-exercises/wiki


@thanhdut DWMR. Good. Press on.


You should probably rewrite this example so that it doesn't use the ternary operator since the next section covers the basic idea


On Mon, Jun 08, 2015 at 01:12:10PM -0700, Lennart Poettering wrote:
> Hmm, you do have a point I guess, It indeed leaves open whether we should use the NUL byte.
I'm pretty sure that NUL byte should stay. The spec say it should
alway be there, even it is not necessary for auth.

> I do wonder though whether it could be considered problematic if we break compat with libdbus in this regard. Hence, we really should check what libdbus and gdbus do in this case... if they always use SO_PEERCRED then we should too. If they always use SCM_CREDS on the NUL byte, then we should too.

Simon McVittie in https://bugs.freedesktop.org/show_bug.cgi?id=69492#c1
> For D-Bus, what we ideally want is a way to determine the
> credentials that the peer process had at connect() time, without the
> peer process having to do anything special to get that information
> to us - for instance, Linux/OpenBSD SO_PEERCRED, Solaris
> getpeerucred() or the cross-platform getpeereid().
That makes the intent pretty clear. The code is full of conditional logic based
on what is available, but add_linux_security_label_to_credentials() seems
to prefer SO_PEERSEC. Similarly _dbus_read_credentials_socket() tries
getsockopt(client_fd.fd, SOL_SOCKET, SO_PEERCRED, ...) first.

@Simon: we're discussing the right way to gather peer credentials for a dbus connection:
https://github.com/systemd/systemd/pull/85
https://github.com/systemd/systemd/compare/master...keszybz:selinux-context


Awesome, thanks!!!


This should be per your own fork not a pull


@thanhdut DWMR. Succinct. Nice. Press on.


No one would actually want to do this.  How about instead you make a bar graph where you print out one `X` for each 10% in their grade?


Either change TabContents to something other than `CustomVBox` that exhibits the correct behavior, or find some other way to stick it in the FXML. This isn't good separation of concerns.


I fixed the example in another request


gradle-wrapper.properties is a generated file, so I would be inclined not to add the header - it will disappear next time we re-generate. If we uncomment *.properties, I'd explicitly add "wrapper" back into the exclusions since we exclude that directory from the source zip in any case


Argh, this breaks haml-rails when you use haml/master, as haml-rails still wants < 4.1.


DB query in this function doesn't have a time window (is it for the past hour?)


You need to explicitly point out that the `'` is why bash let's you enter multiple lines here.


@thanhdut DWMR. What happens if the dollar amount passed in to `- (NSString *) itemMaryCanPurchaseForDollars:(NSInteger)dollars` is not equal to one of the tested values? No need to tweak it - just think about it.


`^Z`?!?


Sorry wrong word. I wanted to say **un**necessary. I don't want you to uncrustify this file.
And for future reference the uncrustify config file can be found in the first post of #2192.


Yes.


Yes - the table only keeps the max value per site in the last hour.


The correct way to phrase this sentence is that AWK takes it's input from stdin.


This is a bash feature, not an AWK feature, so probably should not be mentioned here.


Wow, the flavor!


i think this broke OS X


delete this section; if these links are important, then you should place them at appropriate locations within the text


This was done to prevent ngModelAttributesTemplateManipulator from adding ng-required or required attributes.


The last line of your conclusion is the only line that provides new information.  You need to shorten this a lot.


@Raesu DWMR. Well done. Press on.


delete these files that you don't mention in your writeup


Make new validity checker work with expression properties.


Fixed it in a6b39ae63a0f189a1a7e19fffbf6113937117f50.


@SubJunk I hope that this commit is able to fix your problem reported in #566 (comment)


@whyrusleeping @jbenet

I'm letting this be for now, but being new to the codebase (and Go in general), I'm still curious what you think about the code. I pretty much copied over the code from ipfs_bootstrapd, and mixed it with the Decider that was already in place for webui and unrestricted access. I'm replacing the blocklist's Decider with one that takes into account both the old Decider and the blocklist.

The removal of ipfs_routingd is kind of unrelated, I assume it's obsolete as it doesn't run on the gateways anymore.


Overall your examples are very nice. Great job!  If you improve them the way I mentioned, you'd get 50/50 on the technical portion of the grade.

Your writing still needs a lot of polish.  But if you can clean it up you'll get full credit.


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (644 of 644 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.32%25-green.svg)


please also fix the AT and resubmit


@micwallace Oi, you seem to have ignored the .idea directory after you'd already included it in your repo.  You can run something like `git rm --cached -r .idea/` then commit and push to remove the .idea folder from the remote repo.  The .idea folder can, on occasion, have passwords in plaintext I believe. i.e. http://stackoverflow.com/a/19095988/784648


What's the reasoning behind it? Might be worth adding to the commit message. Is it because it gets outdated and doesn't make much sense because of the ifdefs?  What if we move the "optional" ones to the end and let the others enumerated?

The numbers are useful when you enable SCHED_DEBUG and want to know which task is overrunning.