No es más conveniente una nomenclatura que comience con YYYY-MM-DD? Así es fácil escanear por orden cronológico.


No, output and input aren't necessarily the same.


@mattlistro I think this is really interesting. Looks like me and you found a lot of the same points valuable. I think you really bring up a good point about a hiring a remote development team - I like that you say that if you hire someone remotely make sure they have experience working remotely. Great insight!


```
<span>Delete checked</span>
```
hardcode without multilang support


what if role != NULL but *role = NULL, do we still want to set the name to "" rather than this->getName()?


An easier and more flexible way of marking the containers would be to use a dictionary with the either the id or the row number as the key.  That way you could support multi selects with gaps.


Test must have assertions. You should receive a return value here and test your assertions.
Use readable and meaningful variable names, d1 should be called wordFrequency.


Actually chapters 1-8 (there is no chapter 9)


These are purely syntactic changes that break code in other places. It is best to avoid them and keep this change focused.


With an internalized arraybuffer, V8 is responsible for freeing the memory.  But there is nothing to free here, the memory it points to is an array embedded in the `Environment` instance.


please report back wether it works and how you use it. Thanks.


Wait. WTF was I thinking... NM me. Sorry.


Use clear and meaningful method names. countWords may be renamed to shouldCountDictionaryWordsInSentences


@igable investigate


Should be before line 18


> This probably isn't the way we want to do this. We probably want to pull this in from somewhere.

+1. Can we pull this from Github?


git variable maybe renamed to dictionary


@wushin what do you mean?


@erinzlomek I agree 100%. I'm launching a new site now and as much as I'm tempted to build out a whole platform with lots of functionality, we're starting with a landing page and sign up form as our MVP. We'll then perform the functionality manually before we build a scalable site to see if there is actual customer demand. Fingers crossed that there is and then we can make a larger investment.


same, before line 29


We don't always know that, right? Hence the use of `Optional`.


remove extra line


Oh ya, unload chunks ;)


@Jrubin16 I also found the discussion on hiring a developer especially useful, as I plan to start my own company after business school.  Knowing not only what type of developer to hire but also to maintain a fixed budget process instead of a fixed fee project will absolutely save time, money, and efficiency moving forward.  As a startup, all of these will be of the utmost importance, as resources will be tight and allocating them correctly will make or break the company.


remove if not needed.


@erinzlomek I think you make some really great points here. I am actually launching my own business and keep getting caught up in the mechanics of the website and not wanting to launch until the website is ready. Launching with a landing page just so that there is something there, so that I can show investors that people are interested in my service, is a great idea. Thanks for reminding me about this :+1:


I really think we should use the (probably more stable) pydeep version 0.2 from pypi.
Anyway, I just uploaded an experimental version of this script, 1/3 the size and quite clearer.
It still has a few issues, for example, the lack of debian testing repository in downloads.virtualbox.org =(


Submodule?


Maybe we can add an option to `wpcom_vip_require_lib()` to switch `$lib_dir` to the wpcom libs instead of VIP?


If you have this constructor and client code instantiates EntityDictionary using this constructor, then there will be consequences?


ResultList?

`ResultList.next()` returns the next set of results.


The DEBUG_MARK_QML macros should be outside of the loop


Rename this method to state it's functionality. May be called as wordFrequency?


Ouch - this will blow up the hierarchy import which relies on unique names!


Thanks Aaron!


@fabriciovaladao I love that you brought this up. I was really surprised by this process, actually. I thought that such technical people would have a much more complex framework to organize their processes. Using a sticky note seems so old fashioned. But upon further thought, it makes sense - it's a nimble way to approach a problem, and when building software, it's so important to be nimble too.


Declare set as Set<String> to avoid casting on line 22


Was supposed to say 'reindenting', not 'reinventing'... DYAC.


This may warrant its own patch or further explanation.

It is something I did notice during development, i.e. that the float32 is not precise enough for equities with large prices.


rmsauth_sample doesn't use crypto API and doesn't need -lrmscrypto


It was indeed.


Access modifier?


Ok, I'll test it on my clean VM shortly


Curious, any reason to use this instead of `np.nan`?


remove the commented out lines if not needed, if they serve as comments, fix the indentation of line 1038


That was easy ... just one line:
```
def publicipv4():
    try:
        import urllib2
        f = urllib2.urlopen("http://api.ipify.org", timeout=2)    # timeout 2 seconds, in case website is not accessible
        public_ipv4 = f.read()
        socket.inet_aton(public_ipv4)
    except:
        public_ipv4 = None
        pass
    return public_ipv4
```
@Safihre if you are in the hotspot again, can you try again?


Si @stefanmaric  es más fácil de entender. Se hará el cambio.
Gracias por tú colaboración .


hi


The commits are in the right order, although github sometimes has the habit of showing them out of order.


qa.php.net and downloads.php.net do not host actual releases so fall way down on the list.
Also, keep in mind our canonical releases are the release archives -- not the git tags. Besides the tags often being deleted and retagged before releases, the release archives and the content of the tags differ slightly.

Also, github is an mirror - not our upstream. Our upstream trees are on git.php.net.

I'm trying to plaster our PGP signatures and md5+sha256 hashes all over the place for actual releases.
That way people can double, triple, quadruple check the signature using variety of sources from different channels.
Doing so means it doesn't matter if the actual download is over http. If you verify the archive against the signatures, and verify the signatures over multiple sources then you are safe.

I am aware of our certificate is using weak signature. There is nothing I can do about that. I do not have the money to cough up for certificate myself. I am trying to reach out to Facebook (who initially sponsored the certificate), but it is difficult to get them to hear me :(
Still working on it.
I am still brainstorming ways to get http://www.php.net accessible over https. It is however difficult in practice as it is geo distributed to ~80 mirrors. Something like the cloudflares "keyless SSL" would be fantastic, but its infrastructure isn't fully open source... Still looking for alternatives :(


I wasn't sure if I was supposed to test the Devise Registration controller or not but I felt like giving it a shot just to get more RSpec practice.  I have a question about this spec though.  `expect(response).to have_http_status(:ok)` was failing because I was getting a `302` response instead.  I googled this response and it is a redirect.  I am assuming I am getting this response because a user is redirected back to `root` after signing up?

One more question.  When I change the current post request and provide an invalid hash such as, `email: ""`, the http response is `200`.  The 200 status code means success.  Why does the spec return 200 when I am inputing invalid data?


Important to ensure consistency of object upon it's construction. What if dict parameter is null?


No need to cast to Set


This needs to be compacted before going in. But before we talk about the details of that: I'm not convinced that we really can harmonize this node and rack level information across all resource managers. What we have here is one way of doing it, but what if Mesos or YARN evolve over time to expose another set of APIs for it?

One way to make this extensible and future-proof is to add a type parameter to the `EvaluatorDescriptor` to capture the type of the more detailed information available. That way, the runtimes could provide this information upstream, and add arbitrary fields in the future. Similarly, `EvaluatorRequest` can get an additional type parameter for runtime-specific information not captured by our generic API.

Another way would be to keep all this on the sides of REEF: We already allow users to file resource requests on side channels to the underlying RM. That way, you can file those resource requests directly to YARN today. In order to retrieve information about allocated Evaluators, each runtime could expose a catalog keyed off of the evaluator id.


I m amirhosein baharye


Yes, i could get rid of `has_translation` it was just for the sake of clarity ;)


words[] is incorrectly indented to the right


The impetus for this change is actually just development convenience/scope creep management: right now AdjustedArray only supports float64, so there's no point in generating float32s and then casting them to float64 later.  As you point out, it may be that that's the right data type anyway if there are precision concerns.

w/r/t giving this its own patch, I imagine that most of the FFC logic here is going to get rebased into a small number of commits.  I don't think the git history will ever show this with 32-bit floats when this all gets merged to master.


Thanks!


kafeie?


@kdandola This whole discussion was one of my favorite's in class as well! I think the allure of mobile really draws a lot of people to want to create an app. However, it really does not make sense for a lot of businesses. I'm working on my own venture, and even though our eventual goal is to be mobile, this class made me realize a responsive website was really the way to go. :100:


OK then.
Btw, swing by IRC when you can to hear an idea I have related to this PR.


Hi Vivek

can you please assist me with AirPriceReq in need to pass airSegmentList that i have recieved from lowfaresearch respond.


Why do we need this? Can this be installed with `pip`?

 I can not seem to find the package in CentOS or Ubuntu.


aDict maybe renamed to word and Object should be replaced with String, as we are iterating over a dictionary of strings


Surviving Rizon bullies 101


No need to cast here if you declare Set as a Set<String>


mr. mihandost im from simorgh


fugg


cd guides/cross-cloud-ubuntu


don't forget to change this back to 'it'.


you might be better off using StringArray rather than StructArrayOf<StringBuffer>. StringArrays are based on const char * elements. StringBuffers provide more functionality, but there doesn't seem to be a need in your code for the extra functionality.


hi


@fabriciovaladao I agree with Jess. I find that even though stickie seem simple they're very valuable. At my old job, we had an entire wall of stickies and it gave us a great opportunity to move cards around to truly understand what was important. This visual representation also made it easy to understand what items should be de-prioritized.


consider using StringArray  instead if it makes sense


ditto.


These line has been updated to

sudo curl -L git.io/weave -o /usr/local/bin/weave


move debug marks outside of loop


remove the 'debugger' statement.


Daca deja faci salvarea la OnPause de ce trebuie sa o mai faci si la OnDestroy? Se apeleaza una dupa alta. De fapt onDestroy nici nu prea se apeleaza!


mr. mihandost I m from simorgh


@fabriciovaladao  I love that you brought this up. I was really surprised by this process, actually. I thought that such technical people would have a much more complex framework to organize their processes. Using a sticky note seems so old fashioned. But upon further thought, it makes sense - it's a nimble way to approach a problem, and when building software, it's so important to be nimble too.


In f23 a minimal install has python3-firewall, which is the python3 library to drive firewalld. Before the switch the python3 i think it was installed by default, if firewalld was installed....

I would have guessed it was there in CentOS 7.   Guess I need more custom casing  :-(


Ramana valoarea de la seekebar dar nu si raza geofence-ului din jurul mei si POI-urile. Doar bara isi pastreaza valoarea.


Isn't it worth it to return a success/error here instead of just void? Other than that, ack.


consider using StringArrays if there's no need for StringBuffers.


I would add this try-catch block [here](https://github.com/AzureAD/rms-sdk-for-cpp/blob/dev/sdk/rmsauth_sdk/UnitTests/NonInteractiveTests.cpp#L183) to avoid linkage errors


Good point - this was copy-pasted from one of the component repos. I'll rewrite the paragraph.


Great! Thought the same thing! The simpler the better! :smile:


Wouldn't acceleration be m/s*s?


You should PR, this as the current state of the upstream is not nearly as up to date. lastly there is escomplex-coffee now as well.


How can this possibly be correct?


Multisaltos aun no implementados ni para peon ni para dama.


Looks right, thanks (ACK).


@mattbrailsford I found on one of the Carlsberg projects where we used the global event handlers. It is for a scenario where another project (website) is using a POCO from the core library, and needs to manipulate the property values further.

I'm sure there is an alternative solution for this, we can discuss further and/or open an issue.


Not especially.  It saves having to do the import, although looking at this now I think this nan might actually be a python float instead of a C float.  I'll change this.


I will incorporate the changes to the buildsystem but i will revert the changes to GFlow. After analyzing the changes i came to the conclusion that they remove features that I want to have in the library. Sorry.


You can move all of these actions into one and pass the filter param:
```
filter: function(category) {
  this.set(`is${category}Hidden`, !this.get(`is${category}Hidden`));
}
```

then call it like `{{action 'filter' 'AllEvents'}}`, `{{action 'filter' 'CultureEvents'}}`, ...

Note the use of the backticks which uses the ES6 string templates that will be polyfilled using the babel transpiler through ember-cli.


@jsierles - we could just remove side menu, I don't think we're using it anyways


typo here


@aradhnataneja I thought the user stories were really great too. It made me realize how important it is to break down different functionalities of a website by thinking about who is using them, why they need them and what they need them to do. Even something that sounds simple, like Facebook recognizing phonetical spelling, is actually much more complicated. Thanks for bring this up! :smile:


The compiler may do the optimization here, nullifying the comment.
Also, this also may not be the tightest loop and would be talking about shaving microseconds.

But in general, favoring multiplication (i.e. `* 0.001` instead) is a good habit since for most architectures multiplication is a few times faster than division (or at least that used to be the case.)


We may also need to update PA, as this changes the API's output.


@jbrien is this change still useful to you?


@Skippern
Using your crrent INT-1 plus my original CEVNI causes conflicts?
While testing some weeks ago, I saw your INT-1 notice board overpainted by my CEVNI-notmarks. This worked well for me ...


remove


@m6w6 This commit broke pecl_http in PHP 7 Alpha 2


review complete. Did not scrutinize the qml code.


@erinzlomek I found this especially important as well, being that I will be starting my own company in the future.  Being a perfectionist, I probably would have waited until the website was perfect, but after listening to the professor, I realize the importance of getting the website up quickly to gauge customer interest!


Thoughts about changing this to `to_col_dtype`?
That change would be relevant if we opened up day to `uint64` to allow larger date ranges.


Hi dbongs,

We can't use the AirSegmentList in AirPriceReq. We can use AirSegment in AirItinerary element in AirPriceReq. A sample code is already available for the same inside ConsoleApplication1. In TutorialOne.cs please check line 146 and we are passing AirSegments to run AirPriceReq. Please let me know how it goes. Thanks.

Regarding the MediaItem in HotelSearch, Could you please provide me the XML which you are using and what is the exact name of the Service, I mean is it HotelSearchAvailabilityReq or HotelMediaLinks or HotelDetails. Thanks.

Thanks & Regards
Vivekjyoti Pramanik


А я не говорю, что не честно. И штрафы тут ни при чём -- мы все тут для себя учимся. Вот об учёбе-то и речь. Часть материала знакомит нас с возможностями и прелестями github. Одна из прелестей -- возможность отследить историю и логику изменений -- кто, что, как, когда и зачем поменял в коде. И если бы у меня в команде кто-нибудь удалил бы файл из истории и положил бы на его место новый, [неизвестного происхождения](https://github.com/Kirjanovas/ProgrammingAssignment2/commit/5c0a8251c84e62dd4e0f8b33846769031a23c534) и без объяснения причин -- то нам пришлось бы это происшествие обсудить. На "боевом" проекте -- во избежание проблем с качеством, а на учебно-тернировочном -- просто чтобы инструментами пользоваться эффективно.

Удачи Вам на следующих курсах.


:+1: LGTM, haven't used the @dynamic annotation in awhile haha


what is this


1440-AWS (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2144 of 2202 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.37%25-yellow.svg)


Well spotted!  Fixed.


If the fraction 1 / 1000 is exactly-representable as a double (which it *looks* like it is from my testing locally), then the compiler can probably optimize this.  But you're right that it's probably a better idea to just do the multiplication.


This is a fairly fundamental change - many many places where we rely on the uniqueness of org names.

I would have preferred to leave the name unique (e.g. distinguish branches with equal names by suffixes), and instead introduce a "display_name" (that's how many other applications do it) which then doesn't need to be unique and is used for representation.

That would keep the simple way to refer to an organisation by name during imports (using the unique name) - while at the same time it allows non-unique names in the UI.


@alecive be aware of this change (not merged in master yet): it may affect https://github.com/alecive/gaze-stabilization.


Have you seen this? https://letsencrypt.org/ It's making great progress on the Github repo. Would be a great solution once it goes live on September 14, 2015.


How is `id` used? For sanity checking the written result? i.e. an easy way to check that results are ordered as expected etc.?


What is this for?


Na, I wouldn't change that, makes it more readable. I'd just get rid of the empty "if pass" and put it all in a single condition.


We could cut `id` from the file format I suppose.  It does seem nice to have it for sanity check purposes on the index-calculation logic.


I think this is cruft from an earlier iteration of the progressbar logic below (I was using either the progress bar or a no-op context manager, depending on whether show_progress was true, but then I refactored that logic out.)  Will remove.


Works ~2.0 won't be substituted if user doesn't exist per sh and bash, but will return an error with csh and tcsh.

```
Unknown user: 2.0.
```


What was the goal here? Are we killing sourcemaps on vendor files, or approaching it differently?


@kdandola This was a really interesting class for me as well - because I was under the assumption that everything is moving towards mobile and having mobile compatibility is of vital importance for a business. But, per the class session, it seemed like having a website with mobile compatibility was the first step. Great summary :+1: :computer:


I'm not sure I follow this comment.  The `'day'` column here is seconds since midnight 1970, which means that we can fit data until
```
In [52]: Timestamp(0) + Timedelta(seconds=iinfo(uint32).max)
Out[52]: Timestamp('2106-02-07 06:28:15')
```


what is "a"?


Could also be `overwrite`.


@Ewiseman try this out:
```html
<% if user.role == "management"  || user.role == "admin" %>
```


@Dirk-- I had conflicting rendering when using your style, it is generally not necessary to have it active as I rarely edits in Europe, so I can ignore it

I think rendering priority depends on how you stack the styles, but it should not be necessary to stack styles in a specific order to avoid conflicts. We should seek to that our styles works together independent on stacking/priority. I added `seamark:notice:system` to CEVNI for correctness and as a way to resolve clashes in rendering.

 I suggest we look at adding a separate generic definition that will be overridden by any of the specific renderings, and than start playing with z-index and other forms of forced priority.


This commit has an unfortunate side effect: the sre Python module has a limit to 100 named groups.
It is common (at least for me) to have more than 100 different tag patterns.

in Python 2.7 sre_compile.py:compile (which is called by re.compile):
```python
    if p.pattern.groups > 100:
        raise AssertionError(
            "sorry, but this version only supports 100 named groups"
            )
```


@maggiemoo The user-data/bootstrap would install the user-defined dependencies with the addition of the line we would append to install our client.js and invoke the client with the queue url.

1. bootstrap install use dependencies. i.e. R, gdal...
2. we append curl -o- http://...install-client.sh | bash to bootstrap
3. start instance with user-data which is the bootstrap script


@fabriciovaladao I wrote this comment already and I know you saw it, but since it's not showing for me, like Jess, I agree that even though stickies seem simple they really help with prioritization. At my old job we had a wall of sticky cards and it helped us to easily see what we should focus on and perhaps more valuable, what we could de-prioritize.


@fabriciovaladao I thought this was especially interesting as well!  Being able to clarify exactly what you need to a develop in a clear and concise way is of the utmost importance.  Moving forward, when I finally am going to start my own company I will absolutely be using this technique as I am not the most experienced when it comes to programming.  Using the 3 C's format, I hope to establish a solid connection with my development team.


ok, o scot la ondestroy


re-compiling on make install is a really annoying bug, did you report it?


@Ewiseman just noticed you've got some convenience methods on `User`, this would be preferable to my previous suggestion:

```html
<% if user.management?  || user.admin? %>
```


What if we make it 'sky:tool' with 'init', 'start', etc sub-commands.

Setup:
$ pub run sky:tool init

First run:
$ pub run sky:tool start my_app.dart --install


Okay, it should be a while before actual screen resolutions catch up to this.


Yes, thank you for the QA Nicholas :)


Anytime!


I have always wondered how people manage to work with teams with so different cultures and "work norms" (such as India). It seems it payoffs in some specific cases!


@antograssiot "fourni" (sans T) et "Référez-vous" (avec un trait d'union).

Otherwise good :+1:


Consider using existing convenience method here too on line 33.


You need to make sure you have the correct licence included with specified with your mod of this skin.

A credit would be nice...


I think that is because we are applying patches to a tarball. Using a git build might fix it.


I'm not sure how that will work behind our geodns. I haven't looked into it in details. Nothing I can do right now I guess?


It's there so others can use it in their apps, like noodler !
El El mié, 24 jun 2015 a las 19:30, Brent Vatne <notifications@github.com>
escribió:

> @jsierles <https://github.com/jsierles> - we could just remove side menu,
> I don't think we're using it anyways
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rnplay/rnplay-ios/commit/13057ba6416e89d1453359688ab77fc5349ae133#commitcomment-11843817>
> .
>


@Jrubin16 @mattlistro - It's exciting to hear about your startup and I'm sure this class was insightful on managing expectations for yourself and your developers. The limitations on budget will force you both to maximize the value. Good luck!! :moneybag: :moneybag:


This allows the removal to 'succeed' even if the path no longer exists, correct? (Handling a race condition if the exists check passes, but the file is removed before remove is called?)


I think this should take an array of Schema objects rather than Strings. I don't think there's a need to parse strings here.


Not tested it, but this seems to break the IPC repairing and cable recoloring, ghosts interacting with cables too, might want to test those.


I'll catch the obvious ones! :)


1440-AWS (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


reack


@camiximena I LOVED this as well! I have always wondered about how the internet works, so I was totally fascinated about this subject. To be honest, I really did not realize how much actual hardware goes into making the internet works. It also blows my mind how many IP addresses there! :dizzy_face:


Looks much nicer, in my opinion. :+1:

 Screenshots below for comparison.

Before:
![screen shot 2015-06-24 at 12 44 49 pm](https://cloud.githubusercontent.com/assets/1139621/8337171/f405f00a-1a6e-11e5-819a-38f211ff6004.png)

After:
![screen shot 2015-06-24 at 12 44 53 pm](https://cloud.githubusercontent.com/assets/1139621/8337170/f40337ac-1a6e-11e5-8b2d-faa4704666fd.png)


This will exit the whole program, which we probably don't want. Maybe just log.Error here?


@Ewiseman Typo on `"managment"`.


We could push this further and tokenize the statements and do a `for corp_action in ('splits', 'mergers', 'dividends')` but is fine as is.


@indirect This post is already [out](http://bundler.io/blog/2015/06/24/version-1-10-released.html), but I did not find bundler `v1.10.5`:

```
$ gem i bundler -v 1.10.5
ERROR:  Could not find a valid gem 'bundler' (= 1.10.5) in any repository
ERROR:  Possible alternatives: bundler
```

Did you forget to push the release to rubygems? Thank you.


Oh, I think we want to use our own log package here as well, as otherwise we won't report errors to Loggly...


What's the benefit of using `implicit` here? Why not call `avroSchemaKey` as a method?


@Ewiseman Try to add something extra to this test that checks the signed in user get the managment role. For example on the signed in page show the user's role, then check for that text in the test.


wondering why you need the [0]  should only be 1 input file right?


@kdandola This is pretty interesting. I'm developing a new site and I kinda want an app but not sure I have the resources. Thoughts on doing something with Phone Gap?


I don't think we generally want to advertise ourselves if we're not Lantern Pis -- no sense in letting everyone on the local network know we're running Lantern otherwise.


Sweet! The SDK switch has been a bit annoying (but Go/Appengine is still
beta, and endpoints still isn't officially mentioned for go, so I guess I
was asking for it in a big way ;)) this helps a lot though!

On Wed, Jun 24, 2015, 08:53 Ross Light <notifications@github.com> wrote:

> @campoy <https://github.com/campoy> is currently reviewing. I have tested
> this branch on several live App Engine apps and it works fine, if you want
> to use it early.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zombiezen/go-endpoints/commit/f1f8f40c9363e7d1f4631dc75dd6f2b22f656a0a#commitcomment-11841962>
> .
>


This require (and the other two) is quite problematic, in our experience.  We ran into an issue where new hosts coming up couldn't find packages that were in our repo because the `apt-get update` wasn't running before packages were installed.  A solution would be something like this in site.pp:

    Class['apt::update'] -> Package <| |>

However, the require here causes a dependency cycle if you do that.  apt::conf notifies Exec\['apt_update'\] (in apt::setting), so Package['unattended-upgrades'] gets chained before the apt update, but my spaceship operator up there wants to chain it after.

We ran into this problem with our own in-house unattended-upgrades module which had the exact same dependency (probably for the same reason :)).  The only way for a user of your module in our situation to work around this would be:

    Class['apt::update'] -> Package <| title != "unattended-upgrades" |>

which would work but is very hacky.

If you don't chain here, of course, you run the risk that the apt-periodic daily cron job runs after you've put down these config files but before the unattended-upgrades package is installed.  In practice, that's going to require some incredibly exact timing, and the result is just a failed cron job and not a failed puppet run.  We decided the risk was worthwhile.

It's occurred to us that perhaps we're doing something wrong with the above chaining, but we can't figure out what the "right" way to do it would be.  Any ideas?


@Ewiseman `role` isn't being used anywhere in the method. Use the `role` argument in the `create!` on line 6.


In this gtk+3.py file there's only one patch to apply, and seems not needed (gtk3 deprecated rc files in favour of css).


In the build tweaks settings


Ooh, fair!


This implementation looks good, was the other patch in the branch meant to start using the new paths module for the output of the writer?


for others' reference: https://github.com/JuliaLang/julia/pull/11801


Хорошей практикой считается писать:
```ruby
validates :name, presence: true, uniqueness: true
```


Registering schemas by their fingerprints doesn't necessarily require Kryo, that's just the only thing that we know supports it right now. This could be useful in general, so maybe we shouldn't add Kryo as the serializer at the same time.

In general for situations like this, I think it is better to validate assumptions if they are needed (e.g., Kryo is the serializer) than to make unexpected changes to the configuration.


Whoops! Thanks for catching this...


Thank u sir fr replying ..
Can you tell me that how to create a setting like dis os has optipop tweaks and add d customizations of quick setting into it ??


Thanks!


I don't think there should be a default for the schema. If there is no fingerprint and no schema, then the record is invalid and can't be serialized or deserialized.


Honestly I would probably just use JSON here if for no other reason than to avoid having to write custom serialization and deserialization @uaalto. The extra overhead is really nothing to consider on the local network.


I would change line 440 to "if (wait && wait_is_local)".


Is there a better name for this field? "serialized_record" maybe?


Nick,

Maybe a possible minor issue on XML attribute (gramps xml)?
Using "name" is maybe too confusing?

Looking at https://github.com/gramps-project/gramps/pull/38
we can see that XML schemas were not updated!

True, our XML schema(s) are currently only documentation files,
but one who would like to use them for validation might
have some problems.

I made tests on an experimental addons
https://github.com/gramps-project/addons-source/commit/65e819a9d08d5150617c6f96d749256f5d2010e2
Adding some comments for validating a gramps XML
via dtd file. :-(

eg,
```diff
+<!--
+<!ELEMENT name (daterange|datespan|dateval|datestr)?>
+-->```
because this element is already used.

Cosmetic, but could be a problem for 3rd party tools or on the future, no?

PS: https://travis-ci.org/gramps-project/addons-source/builds/68191360
What does it means? Same commit on master does not return failure!

--------------------------------------------
En date de : Mer 27.5.15, Nick Hall <notifications@github.com> a écrit :

 Objet: Re: [gramps] GEPS 036: Add date and language to place names (cc6820f)
 À: "gramps-project/gramps" <gramps@noreply.github.com>
 Date: Mercredi 27 mai 2015, 14h32

 The API is similar to that used
 for personal names.  I decided that using
 place.get_name and place.set_name
 was preferable to place.set_placename and
 place.set_placename.

 We don't allow
 person.set_primary_name(first_name='John',
 surname='Smith') either.  Not a bad idea
 though.

 —
 Reply to this email directly or view
 it on GitHub.


Respinning the test 9 days later, with ck=25 instead of ck=250.


good.


Why do you only use `goto_position_target_global_int` for the last command and not all of them?


Looks like the issue is in the annotations being assigned static values. [See lines 278-301 in ss.ca.R ](https://github.com/emilopezcano/SixSigma/blob/master/R/ss.ca.R#L278-L301).

You could add something like:
```
xST_density <- density(xST, bw = binwST)
```

and then in the annotations set:
```
 y = max(xST_density$y)
```


This might be pedantic but I like the following structure when introducing a list:-
ie from multiple terminals open; first item, second item, and last item.
So a semicolon to introduce a list and then all items (including the last two) separated by commas, even if there's an "and" between the last two to make things read better as you have done here.

This is all bringing back my technical grammatical and stylistic editing (dark) past.
N.B. not that I was any good at it you understand.

Also I quite like full stops at the end of sentences. :)


You can use codetroopers/ct-website image that is available on docker hub if you don't want to build it locally.


Nit: do you mean memoized instead of memorized?


Not particularly lol, we can figure it out later. LGTM, merge away.


Have you seen how much mana it costs? I can increase it, and reduce the time. Just ask.


@KrauseFx I think we can cut a release and I've updated the changelog with what's included.


```ruby
return handle_wrong_login_params unless account && user
```


r+


Don't add any more commits labeled [SUBMIT], Shravan. All commits henceforth will be considered submitted anyway.


LGTM :+1:


Avro Schema parsers shouldn't necessarily be reused. They keep track of the Schemas that have been already parsed and will use them to satisfy name references in Schemas that are parsed later. That's not typically something that we want to have happen to avoid name conflicts.


I would probably log an error here too...


At this point I don't know if you intentionally want derived classes to have copy semantics and not move semantics, or if this is just an oversight.  I recommend explicitly deleting or defaulting the two copy members.  Whichever way you choose you will have to explicitly default the default constructor if you want to continue to have that.  And it will be clear that you do not want move members in the base, unless you explicitly default them, but I see no reason to do that (no data members to move).


Error again I would say...


Если я не ошибаюсь, то такая форма find'а является нежелательной.
Лучше,
```ruby
find_by hash
```


I feel pretty sure this should be the preferred rst checker, certainly in the case that conf.py exists.

Would it be possible to configure the defaults such that rst2pseudoxml checker only runs when no conf.py is found?


Cool! thnx!


@camiximena I agree with Jess. I think the whole decentralized way the internet works is fascinating. I thought it was all centralized. Who knew?


When turning a String into bytes and back, we should always use an explicit character encoding. In this case, use UTF-8.


Right, I usually just used `cal` via Emacs with a `C-u M-! cal RET`


saw approval from graydon
at https://github.com/MonsieurNicolas/stellar-core/commit/9d6a27a26dea4e4787b3b552a23dec231fce9cbf


merging MonsieurNicolas/stellar-core/SQLiteBump = 9d6a27a2 into auto


MonsieurNicolas/stellar-core/SQLiteBump = 9d6a27a2 merged ok, testing candidate = ce95e200


It would be more user-friendly to not use -E by default.

It's good enough for the sphinx default behavior.


never use $ that is jquery; and never rely on dom, but on angular models instead.


Check for e one line up after the read? Seems like ```udpAddr.String()``` could easily fail otherwise. I would also log the error.


Uhm, changing to angular 1.4 is a big change. Have you tested this on a production ionic app?

I think this change has to be careful, please check [this ionic forum post](http://forum.ionicframework.com/t/angular-1-4-and-ionic/21458). It seems that ionic may be isn't still ready to go with angular 1.4


Also this code is essentially all written by you now.
I just deleted a few lines and changed dummy to pseudoxml.

Entirely up to you. I don't mind either way.


Why is the `if len(l) > 0` needed? Will this not drop empty lines from CMake?


Actually I've realised a mistake here. I will re-instate the code for bindResizeEvent as it was before.


Those are great additions, it's all becoming a little clearer to me.


Do we need this variable? Why not just check if it's us and break if it is?


Awesome!  was just about to fix because its impacting a different project ... Guess I will just upgrade instead


We can never get here without otherPeer being true, so no sense in checking it.


Because you're always serializing generics here, you should use `GenericData.get` instead of `ReflectData.get`.


OK cool ;)


reduce_dynamic_allocations (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Array keys + Enter, right? Consider adding a comment.


Log an error here..


@HannahVanGerven Thank you, very relevant! Being I consultant myself I recognize the applicability of these points for managing projects, even beyond software development!


Error


This worked perfectly for compiling against electron (using electron-rebuild to make things easier). Is there anything left to do? Otherwise it'd be great to see this merged into serialport so it works out of the box for Electron.


lines are looking misaligned due to TAB indent and 4SPACES indent.
4SPACES needs to be replaced by TAB. Will do it in next commit.


Great takeaways!!! Maybe you could add the names of the main app developing framework: Phone Gap and Titaniun Appcelerator as alternatives to app development. Other than that, LGTM :+1:


Why not `compress(schema)`?


Make sure to get the master version, fixed an escaping issue: https://github.com/henrik/dotfiles/blob/master/vim/plugin/elixir_runner.vim


1699_MeterTimestep (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Does this command do anything different than veh.commands.goto()? Do they both use SET_POSITION_TARGET_GLOBAL_INT? Are you just trying to show different ways to control the vehicle position?


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


In addition to my comments above about defaulting or deleting the copy members here, their implicit defaulting here is deprecated behavior that we should not depend on.


This operation is also expensive, so I recommend memoizing it as well.


@SCastro16 Very nice and to the point summary, thank you for this. This will really help in making the right hiring decisions!


Метод используется один раз. Думаю, что нет смысла выделять его в метод, нужно вернуть туда, где используется, иначе усложняет чтение кода


Though, now that I bothered to look, you can just do `M-x calendar`.  Which has a ridiculous amount of functionality...


@sunnywg Thanks for this example, really helps to understand such an abstract concept!


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sorry, I added a commit that should not have been there. Please remove the commit "fix library references". The pull request should have only been for 6bbfef4be732a88497a98d761ad32eb88ffaf95f.


We should use a "git@github.com:" url instead of https, otherwise it will ignore your RSA keys...


Good idea.   I'd like to see the implementation done in OpenSSL first before going that route, just so we know the API is locked down and that ATS code will match up.   At the moment all I've seen is pre-documentation, which may or may not be what actually gets implemented in OpenSSL.


@athom09 I needed the [0] because of the way I was defining the file option - apparently if you specify ``nargs`` argparse generates a list, even if you set nargs to 1.  I just tested, and if I remove the nargs option then it gives a value instead of a list. Thanks for prompting me to take another look, I'll clean that up.

BTW, may not be obvious but django 1.8 is finally using argparse instead of optparse for script parameters, and so far it seems pretty nice.


I like the framework @tschmid16, I would definitely apply it when making this decision. And fully agree with @HannahVanGerven


reduce_dynamic_allocations (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think it would be great if you could share the experience with `rescue_from` and **pudit**. how about your experience with **carrierwave** gem? Hope see you today night, have a Nice coding Ray


Does this registration pick up subclasses of `GenericRecord` and use the right serializer? If not, then there's no need because you can't instantiate it.


@velizd I remember this as one of my key insights from class as well.. Thanks for capturing this, very relevant!


If you remove the YouTube ID from the frontmatter, the site has no way to get a snapshot of the project programmatically, so there isn't an image displayed on the project list page. I'd recommend removing the manual embed instead.


ack


Ahh - sorry - should have done a clean and tested.
Got a fix with Rysnc working nicely.  Just testing.


Yup.


Fancy. Why not use `decompress(compress(schema))`?


@sonicshi Thanks for this, nice summary!


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think these utilities should be in terms of bytes rather than mixing in the Schema logic.


We should start using the type-safe `chrono` library for durations.  E.g. `std::chrono::milliseconds lastCloseConvergeTook_;`


full version


reack


@ofTheo cooooool. :)


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/68198108


Looks good.


Je moet alleen wel even ruby op een server draaien <3


Agreed.


We can use chrono for time stamps too.  Though I need to know exactly what the epoch is for the correct time stamp.  We really need a `ripple::clock::time_point` for time stamps based on jan/1/2000.


Right now all the writers take an explicit path.  If/when we implement Zipline functionality for loading FFC data from yahoo, that logic will probably load a path from this module.


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm accepting this patch, but please add some javadocs and tests.


Oh, that's right. Thanks.


the rack names and node names are "preferred".
if you give 1 as number, and several racks, it will just allocate the evaluator in one of the racks.
in case the relaxLocality flag is turned on, if there is no space in the racks you suggested, the evaluator will be allocated somewhere else. if the relaxLocality flag is disabled, then the allocations must be done in those racks.

the node names are not being used by now, but it will have a similar semantic of the racks. If passed a suggested node name, the resource manager should try to allocate the evaluator in that node.


@mattlistro This was the other takeaway I thought was really important from this class.  Knowing how location enters into the equation for developers is especially important, as I plan on developing my own company going forward. We'll have to chat more about this over lunch! :poultry_leg:


Is it possible that there'll be more snapshot autopart types in the future?  If so, this ought to move into a list in the class that we can extend in subclasses.


Now we are good.


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:laughing:


OK, just for curiosity, breaks any other places that I haven't changed?


We have deprecated copy members here.  Explicitly default or delete them.  Or remove the destructor, which will result in implicitly (but non-deprecated) defaulted copy members.  The defaulted copy members will be implicitly deleted if they are deleted in the base class.


ok I activated the remove trailing spaces in my netbeans again.
Don't know when it went to off.


We should also test the `check_precision()` function. Would it make sense to add tests like:
```
assert check_precision(x**QQ(2, 5), x, 4) == 10
```
? Because this 10 is arbitrary, but 4 is the number of terms that you want. It's just that you need to ask for 10 in this low level function.


re: CFLAGS - overriding CFLAGS is pretty much always a mistake in any project since it will inevitably be composed of many parameters and you only want to override a few. As with anything, you are expected to read the Makefile before attempting to use it. In this case, it *should* be obvious that all you wanted to change was the optimization parameters, thus all you needed to do was a commandline override: make OPT="-O3 -march=native -mtune=native"

If you find yourself manually editing Makefiles all the time, you're doing something wrong. Command line overrides should be sufficient in 99% of use cases.


I like this better than how I was doing it before. We don't really need the entire content of a line to report the error message (and can find it from the DOM if needed, I think.) It might be better to rename the property and methods to content or something.

Naming things is hard.


yes, i noticed that. Should change it back to optional


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


But it's 5/5 or?


```python
assert check_precision(..., x, 10) == 14
```


should be optional


```python
assert check_precision(..., x, 4) == 10
```


fast-forwarding master to auto = ce95e200


I'm a bit at unease to explicitly supporting two major versions of json.net as our CI will always restore the latest `7.*` version using this.


😍 Thanks!


also ich habe es jetzt in der Syntax gemacht und nicht den javadoc style angewendet. schau mal drüber bei manchen war ich mir nicht so sicher


I didn't review the entire thing. Just remember that Subscribe returns an IDisposable. Not sure if you want to remember it or not.


reduce_dynamic_allocations (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


```python
assert check_precision(..., x, 4) == 5
```


reduce_dynamic_allocations (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@harsha89 @surangak  I think the problem is to support other system values. I am in the process of implementing it.

I didn't close any pull reqs.


This seems rather complex for a unit test - would it be easier to add a compile-fail test or something?


Whoops


except we want strndupa here not strndup().. I'll fix it..


rapr?


is it really a breaking change though?  GitHub will keep redirecting traffic and are the URLs really used?  The name of the package itself didn't change (its still `bower install angular-validation-match` just the repo name lines up.)


因為英文語言檔所顯示為Ferrous而不是Nickel


hmm... i can try, maybe if I add the filename... not sure how much the compile-fail test actuall gets from the error


ping @mklucsarits, here's one more change to SOC-533.


In what case would `modulePath` be empty string? Even if it _could_ be empty string, you can't use a conditional or it will hang the loader.


Please don't sneak this change in there. If you need script after the page is loaded, let's discuss the best way to do that. Perhaps a different variable?


Thanks (in advance).


What's broken in the compression stuff?

Already noted use of OPT macro in my previous comment. As for the rest, it's the levelDB Makefile so I don't have much to say about it.


thanks!


TC_LOG_DEBUG("maps", "Player::CreateViewpoint: Player %s create seer %u (TypeId: %u).", GetName().c_str(), target->GetEntry(), target->GetTypeId());


This registers the `text!foo.mustache` module. Why does this not use `text.get()`?


Random newline


not needed anymore


Destructure so that `toGet.map(({ path }) => `${module.id}!${path}`)`


Sure, changed in 56e19eb.


reack


Crash. Simply crash. You can't define a shapeless recipe as a non-shapeless one.
I made this one non-shapeless so it's easier and I can use the fixed recipe.
https://github.com/Ombridride/minetest-minetestforfun-server/commit/8b18e4b1966efc3f9d95334b241c333f909977bf


I'd prefer that we refer to the service as "Facebook" and not "FB" where possible, so this function would instead be shareOnFacebook(text)


yes because path to the name of the file has changed from
`angular-validation-match/dist/angular-input-match.js`
to
`angular-validation-match/dist/angular-validation-match.js`

and in case somebody is using e.g. grunt or gulp he will get error that the file is not existing


I'm not sure if you fix the issues with this one in a later commit, but I was hoping to see you actually edit this commit to not include all the extra JS names, the specific version reference for jquery, the location of the file, etc.

Also, I think 'create.css' should either be part of bonecard.css or named bonecard-create.css.


We are closing in on [your location](https://www.google.com/maps/place/36%C2%B000'29.2%22N+95%C2%B056'32.8%22W/@36.008089,-95.94414,15z/data=!4m2!3m1!1s0x0:0x0). Be prepared to be searched! :D

In all seriousness, maybe these should be part of a config or something?


facebook_share_text instead of fb_share_text


getCanonicalUrl ends up prefixing the url with http://localhost, eg, `http://localhost/wiki/Category:NewTestCat?action=unwatch`. Garth ran into a similar issue in the past and suggested I change this to `getFullURL` which fixes the issue.

(If you're curious, getCanonicalUrl ends up calling GlobalFunctions::wfExpandUrl which ends up using a global called `$wgCanonicalServer` which is where that localhost is coming from. I'm not sure where that gets set, and didn't care to dig much deeper since `getFullUrl` works just fine, but that's where the problem lies. Could be an environment issue?)


#watchout


> Na, I wouldn't change that, makes it more readable. I'd just get rid of the empty "if pass" and put it all in a single condition.

Done.


Notify @naucoin


i did little mistake (it was different commit) but still from 1.5.0 to 1.5.1 was filename changed :(


@pbaruah -- looks like we need some additional guidance for the 'caption' field value


Could make this a Makefile?


Could the word "your" be removed? I believe it should. But don't blindly listen to me. (If you just agree, then a respond in not necessary)


@pbaruah -- we also need some guidance for the 'description' field value


Dev


Where did this file come from? Please at least keep track of the origin of 3rd party sources and pay attention to the licenses.


Is this console.log value useful in production?  Looks like a holdover from debugging?


there's already a config param, and originally I was selecting from getting the pathPrefix from either the config param or module.config. Since I realized I had no idea how the config param would be useful (hgn uses it somehow/sometimes) I ended up just using module.config.

tl;dr, I'll get rid of the config param and just use config


reduce_dynamic_allocations (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Can you squash this commit in with the earlier ones?


**carrierwave** is a gem for file uploads, I used **paperclip** instead


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/902f48cd4cd4cc7756898a2b07b62d251cc4e84f/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/902f48cd4cd4cc7756898a2b07b62d251cc4e84f/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/902f48cd4cd4cc7756898a2b07b62d251cc4e84f/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/902f48cd4cd4cc7756898a2b07b62d251cc4e84f/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/902f48cd4cd4cc7756898a2b07b62d251cc4e84f/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


"Name for the faction" or "The name for the faction". Those are IMO better descriptions.


Hmm... good point.


@parrt Thank you for a great piece of software.


Change the parameters to `@IntegerRes int colorId` so we can pass `R.drawable.stats_round_green` directly. See `setNumber()` for an example (`@PluralsRes` as parameter).


at your service :)


Perhaps it is better to tune LMR and Futility move counts separately. LMR parameters K have a huge impact and might dominate the run.

Also, for LMR tuning you need to reset all elements of K in Search::init()
Reductions[pv][imp][d][mc] = r >= 1.5 ? int(r) * ONE_PLY: 0 * ONE_PLY;
Otherwise you will not correctly clear elements for r<1.5.

Regards, Alfred


xxxxxx


The list of active checkers depend only on filetype.  Now, I agree that most people probably care about `sphinx` rather than `rst2pseudoxml`, but `sphinx` is slow, and `rst2pseudoxml` is fast, and this can mak a difference in how syntastic is perceived at the first contact.  For serious work you're not supposed to rely on the default list of checkers anyway.


@rodrigopavezi I thought these tests were fixed, why are they still disabled? Thanks.


Usually breaks are not indented.


Actually, this is for issue #17


I use `pip install -e .` to build the exact same environment my package needs.


I hope you tested every build configuration for this.


It's configurable...


What are you planning to use this for?

If I understand right, this will only make twitter future return types parseable into metadata, but won't actually support calling client methods that expect them, or writing server methods that return them, right?

And I'm not yet convinced we really want swift-service code to support multiple types of futures (btw, we are potentially planning on converting from guava to java8 futures I think).

So, do you plan to use this for interfaces designed to work with an alternate implementation of swift-service?


We can check here for a nullptr, so that we can avoid an init from outside the module.


@tdsmith Should this line be `if OS.mac?`


First, I really hate this one liner coding style. It's bug prone.

Second, it seems like this change will prevent a proper shutdown of the event loop.
What is the purpose here?


This seems pretty big. Where did it come from? What license is it? How is it used?

Descriptive commit messages would really help me.


The alternative is `[7,8)` which will force users to upgrade to 7.  I'd rather not introduce that in a minor release (1.6.1 for instance) and instead defer such a change to 2.0.

If the concern is not being able to easily detect whether we break backwards compatibility with Json.NET 6.*, then I'm not too worried since NEST 2.0 is around the corner.


The title doesn't match the commit ;)


Then we update our API :)

OK.
By type parameter you mean for example a map where you can add arbitrarily different parameters?
E.g. <"rackname", "rack1">
       <"datacenter", "dc1">
       <"nodename", "node1">

Not sure about the last paragraph. I'll ask you then


@bnmnetp Was this what you had in mind?


Looks good.


Typo in commit title, should be `Split os_unix_defs.h into os/`.


CMake itself know when you build with MINGW. So you can simply check with
``` if(MINGW)````


A 'scripts-after' variable seems reasonable. Can you squash that into the original commit for splitting out the footer? Otherwise, I'll just split out the footer and make this change myself. Is that easier if I just make the change?


pull request დროზე დამერჯეთ ან გადააგდეთ, თორემ კონფლიქტები იქნება


I think it is :smile:.


Oups, wrong refactoring !


Oh damn, you're right ! :)


But mah pank aoc


exactly carrierwave is a gem I use to upload and process images to AWS S3 with different formats depending on where it will appear, we can go over it as well as pundit today, see you tonight


This is possibly the most contrived way possible to add the missing ions into the `zeta_data`, but I can't think of a way to make it simpler. It's the multi-index that makes it complicated, because it won't let me just add new rows so I have to create a new data-frame. Is this ok @wkerzendorf? Is there any way I can simplify this?


Can you comment more on all the commands so i dont need to google them all.

At least the ones you know off the top of your head.  I wanna read through more how you have vim configured for your preferences


I'm not familiar with this command. How is it different than NED velocity?


This was dealt with in #2832, so this commit should be dropped, and the changes from #2832 should be integrated into https://github.com/Yamakaky/neovim/commit/9492b77d96b4de738257018956fb38229381c71d (I've left a comment there as well).


This should be changed to `#ifndef USR_VIMRC_FILE2` to match the current state of `os_unix_defs.h` (I've also left a comment on https://github.com/Yamakaky/neovim/commit/68250f1640bd4ac7d3c00b29e3e4d049edf4d97a).


If this happens, the time clock string is "NULL".


@vinoski Thank you very much for the reply.  I suppose I'll run Webmachine one of the other supported webservers for now.


LGTM.


Looks good to me - but quick question: why not inline the List(a,b,c) constructor in the parser map function? No real difference, so readability? Anyway :+1:


See this thread for discussion:
https://class.coursera.org/rprog-015/forum/thread?thread_id=883


Should be only one `=`, I think.


Again, why do you only use `goto_position_target_global_int` for the last command and not all of them


If the user does ractive-partials! without anything after, and they don't have a path prefix


the `if dirname` is superflous as you have the condition in line 455, right?


text.get didn't use the require paths correctly if I recall, but I'll double check


The circle isn't drawn, where I want it to be. It should be next to the String.


@alex-deaconu this should test when adding a presentation to the playlist. Currently this is not implemented but should be enabled when the playlist gets the presentation added. cheers


Should be `if (mp_obj.mp_obj.interpret_Transaction()) { ... }` - it's boolean since the remake. :)


@mohierf what's the point of this value? Where do you need it?
If you really need this, you should call it `max_bi`, it's more explicit.

And please, don't do `if len(services) != 0:`. `if services:` is enough and well more pythonic.


Implying vanilla way isn't always bad.


it also yields files, you should mention that!


asdf


Isn't too soon to start working with AWS at this point since we are nowhere near making a real production app.


гениально! не получается что-то сделать - не будем это делать. вернуть конфирмацию пароля и заставить его работать


Looks like a good change, but let's get feedback from @crichid next week . . .


I think this change does effectively nothing, since there is no detection for the error that doesn't allow the ```-a``` option.

If ```-a``` is not allowed, p4 outputs ```User not allowed to create a ticket that is valid on all host machines.``` with exit value 1.  This isn't detected by ```checkAuthnErrors(String)```, so a PerforceException is never thrown and ```p4 login -p``` never gets called.


This is true but we'll have to support `NEST 1.x` for some time to come. we have been depending on 6 throughout so you're absolutely right to be conservative here.

Ok with it for now but in the long run we need to find a way to test both 6 and 7 version of elasticsearch when we move develop into a `1.x` branch.


What is the difference here exactly?


Done.


Revert the addition of this method.  Since it's only called once and the addition of future callers is unlikely, the benefit of its addition is outweighed by the additional complexity introduced into the interface.


In "search_hosts_and_services", the new `host_only` parameter is redundant with "type:host" in the search. You should really remove it and only use the search parameter.


I am still learning python ... thanks for your hints!

Max BI in the hosts/services filtered is interesting for hosts groups, minemap, ... indeed tactical views.


It is a fragment of a quick 'n' dirty test setup, should be removed


Infatti me lo stavo chiedendo anch'io se abbia senso continuare le
funzionalità di script. Ma mi sembra che il progetto hookii non sia ancora
ben definito e comunque ci vorranno diversi mesi per implementarlo.

Via libera per mustache o handlebars, Erni

La ricerca in realtà non funziona con Google.
Es:
https://www.google.com/webhp?ion=1&espv=2&ie=UTF-8#q=hookii%20archive%20mambombuti
Vengono fuori 5 risultati dall'archivio di cui 2 segnalati da lui.
Il textbox di ricerca del sito, invece, non trova proprio nulla.

L'idea sarebbe quella di effettuare una ricerca testuale fra i commenti i
cui risultati contengono link al commento stesso. Quindi non solo la pagina
dell'archivio in cui il commento appare.

2015-06-21 23:36 GMT+02:00 crazyhg <notifications@github.com>:

> No problem.. stavo pensando di riscrivere il codice per usare dei template
> in mustache o handlebars al posto dei print, se a voi va bene.
> Però non ho capito bene quanto temporaneo dovrebbe essere questo archivio,
> nel senso che se il sito andrà rifatto in un prossimo futuro magari non ha
> neanche senso perderci troppo tempo adesso.
>
> La ricerca in realtà mi pare funzioni anche com'è adesso con site:
> http://www.hookii.it/archived
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ernitron/hookii/commit/20d7101bfbd5e8eb754eab3f3d1ecef66d365bf7#commitcomment-11785695>
> .
>


It looks like you're missing the part needed to hook this up for "make check".  Basically you just need to make sure dd_tests/dd_test.py is in TESTS in tests/Makefile.am.


1699_MeterTimestep (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2165 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.83%25-yellow.svg)


Should we not point this to /usr/share/nginx/html ???? the root of the web server?


Good idea. Done.


So in the zeta data is not available but that ion is requested - raise an error. Are you doing that now?


Unfortunately, it is probably nothing to do with me.


Added new file frametimingtestharness.js and made the recommended changes.


For more information, visit Stamen Design.  JavaScript library information is near the bottom of the page.


:+1: LGTM


Thankyou!!!  This little patched up version just made my day. I super appreciate it!
@ChangeTip , send $5 to @faustoct


Removed the test case.


Hi @faustoct, @ratacat sent you a Bitcoin tip worth 20,206 bits ($5.00), and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/862351)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


Have you tested this?


Ok, I'll drop it


*mooola*


edfdf


Ik denk dat het probleem ligt bij de hoofdlettergevoeligheid van Linux, terwijl Windows/OSX (vaak) niet hoofdlettergevoelig zijn. Dus lokaal werkte ```logo-iwt.png``` bij mij wel, maar online niet.


Same comment as previous commit, please do "if hosts:" instead of "if len(hosts) != 0:".


/cc @andyneff: Atom is clearing all the ending line breaks in here too. Since those are regular word wrapped paragraphs, I don't think it matters though.


Those losses could have possibly been prevented: https://git-scm.com/book/en/v2/Git-Tools-Stashing-and-Cleaning#_git_stashing


@HannahVanGerven Very structured, valuable and insightful overview. LGTM :+1:


You are absolutely correct. Done.


This is a release candidate


Is this for only 6.x. I only ask since am not on the list (CYREX) and my last contribution was a long time ago (Maybe this is why?). I was more on the Database contribution than the C/C++ code. Would this matter?


I addressed your comments. PTAL.


@sunnywg @tschmid16 @SCastro16  @velizd @sonicshi What do you think?


Note that I'm not sure I will have time to fix this before my vacation, which is in the end of July. Feel free to fix it yourself. I'm not a maintainer anyway.


S3 is for storage, I already had the account since I was using it in different app, so anyway if we are going to add images we can just store on file and no need for S3 now


This helped with the protocol buffer debug. Its makes the log chatty, but its only on debug mode.
Any thoughts?


@SCastro16 This will really help me avoid some of the stupid mistakes I made in the past :wink: :-1:


Just to confirm: in the Shiny app it is assumed that column names are SNP IDs and row names are genome IDs. If each SNP binary pattern is for one SNP site in order of genomes, then you may just want to keep R's default column-wise filling of a matrix from a vector (i.e. drop the `byrow=TRUE`).


@ROM-Jeremy  and move the java too


why don't you put something like

```
if not dirname
    dirname = os.curdir
try:
    something = os.listdir(dirname)
except OSError:
    return None

return something
```

in a function? You use that snippet here and there.


It seems like this try/catch block (which is shared by setShouldShowThumb) should be pulled out into a function that returns a {} when parsing fails (which shouldShowThumb could then decide means it should `return true;`).


@SeeSharpNY that's very interesting. Thanks for your contribution.


@tschmid16 @SCastro16 @sonicshi @SeeSharpNY @sunnywg @leoniestevens thanks so much!


Yes, we're getting auth errors right now when attempting to use a server that does not allow the ```-a``` option.

Only ```p4 login -a -p``` gets executed then attempts to run ```p4 workspace -o``` again without falling back to ```p4 login -p```.

```
Using remote perforce client: jenkins-test_job--111504876
[test_job] $ p4 workspace -o jenkins-test_job--111504876
[test_job] $ p4 login -a -p
[test_job] $ p4 workspace -o jenkins-test_job--111504876
Caught exception communicating with perforce. Perforce password (P4PASSWD) invalid or unset.com.tek42.perforce.PerforceException: Perforce password (P4PASSWD) invalid or unset.
	at com.tek42.perforce.parse.AbstractPerforceTemplate.getPerforceResponse(AbstractPerforceTemplate.java:406)
	at com.tek42.perforce.parse.AbstractPerforceTemplate.getPerforceResponse(AbstractPerforceTemplate.java:301)
	at com.tek42.perforce.parse.Workspaces.getWorkspace(Workspaces.java:61)
	at hudson.plugins.perforce.PerforceSCM.getPerforceWorkspace(PerforceSCM.java:1641)
	at hudson.plugins.perforce.PerforceSCM.getPerforceWorkspace(PerforceSCM.java:1602)
	at hudson.plugins.perforce.PerforceSCM.checkout(PerforceSCM.java:907)
	at hudson.model.AbstractProject.checkout(AbstractProject.java:1282)
	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:610)
	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:532)
	at hudson.model.Run.execute(Run.java:1744)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:374)
ERROR: Unable to communicate with perforce. Perforce password (P4PASSWD) invalid or unset.
```


Is what documented?

On Wed, Jun 24, 2015 at 12:25 PM, Paul Bastide <notifications@github.com>
wrote:

> is this documented anywhere? if not, please remove or talk to vijay or I
> about it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/anthonydresser/photosharing-nodejs/commit/2fdfaca84eaca1502be61cec4f2179b349bcc2f2#commitcomment-11842617>
> .
>


it doesn't make sense to return a list here, I'd rather put the list around it at the callers side


There's a typo here:

```Scala
// there is a pawn as a victim for enpasant
```

Should be:

```Scala
// there is a pawn as a victim for en passant
```


@luisalvarado TrinityCore was already on GitHub? Who pushed your commits?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.297](http://teamcity.monogame.net/viewLog.html?buildId=8365&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Note that the user dot will require a `UIViewAnimationOptionCurveLinear` curve for the smoothest animation between location updates.


@SCastro16 thanks so much for sharing!


@sonicshi I agree these are the critical tools. Thanks!


You are right!

Indeed, I think that the search filter should be a *Webui_broker* class property available in the whole WebUI thanks to *app* ... no ? And, why not building a class for filtering ?


The write mode for the binary file may have to be `>:raw` instead of just `>` at L466

From:

```perl
open(my $out, '>', $binary_file) or $logger->logdie("Error: unable to write to file $binary_file ($!)");
```

to

```perl
open(my $out, '>:raw', $binary_file) or $logger->logdie("Error: unable to write to file $binary_file ($!)");
```

http://perldoc.perl.org/PerlIO.html


Better yet would be to wrap it in a closure, no?

(function($, window, document) {
  // Stuff with objects without bleeding out global
})(jQuery, window, document)


Thanks! Fixed.


Thanks @velizd.  This is extremely helpful. Web vs. Mobile app development is a key decision that aill have substantial impact on a project's success.


Great changes! good catch on that propA thing


spelling error


The `pair` in the `CanonicalTXSet` looks fairly big (at least 76 bytes).  I'm guessing we could get away with `auto const&` here and get a fair performance boost.


> Ok with it for now but in the long run we need to find a way to test both 6 and 7 version of JSON.net when we move develop into a 1.x branch.

:+1:


The file appears empty: is this what you intended to do?


Ik had ook al een met en zonder hoofdletters geprobeerd, maar misschien duurde het even voor alles na hard refresh deftig werd getoond? Ziet er nu proper uit! Merci!

Pieter-Jan Pauwels
Community Coordinator, Open Knowledge Belgium
m: +32 476 66 27 77 <tel:+32 476 66 27 77> | e: pieter-jan.pauwels@okfn.org <mailto:pieter-jan.pauwels@okfn.org> | w: okfn.be <http://okfn.be/>

> On 24 Jun 2015, at 20:56, Thomas Ghysels <notifications@github.com> wrote:
>
> Ik denk dat het probleem ligt bij de hoofdlettergevoeligheid van Linux, terwijl Windows/OSX (vaak) niet hoofdlettergevoelig zijn. Dus lokaal werkte logo-iwt.png bij mij wel, maar online niet.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/openknowledgebe/datawijs/commit/f3693ba9da5ca576dae83984aeab9420e6c82e1a#commitcomment-11845574>.
>


well it needs to return an iterable, it could also yield. it's just so that it fits in with the others, see line 572 and 574


r+


Glad I could help!


Replace this call with a for loop populating "sortedCommands".


Oups. I really don't like big commits like this ^^


If you notice, the schema for the Users table doesn't match what is in the migration. If you rollback the migration (```rake db:rollback```), and then re-run the migration with ```rake db:migrate```, then you should be good to go.


Thanks @sunnywg , I think the use of an example is very helpful to understand what an API is.


LOL! Not sure how it became adieu!


The duration will depend on what’s causing the update to occur. If mbgl has triggered a change of viewport, Core Animation shouldn’t be involved at all (duration of 0 seconds). The approach I took in dfd563aadde1a3ac7444fc78a3541a217184e220 was to have each caller explicitly say what duration it wants.


I known, that's why I permit myself to give you some hints :) And for information, since 3.4 you can even do `max((s.business_impact for s in services), default=0)`.

Ok, I'll look at it after my movie :)


Nice idea for different languages, I might add this to the main repo (as an option to download other language versions of the file)

However if you wish to maintain this, please change the update URL so that one (or you) doesn't accidentally overwrite your file (you might forget to provide the -s argument)


1699_MeterTimestep (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


:smiley:

I was going for "let's throw this up on GitHub before bed time", but yeah a config file would be nice. :+1:


yeah, I still didn't get that far :P maybe I should read further


The tests should get picked up by nosetests, so I think everything is fine there, but there's another problem: master uses nosetests-3.4, and there's no python3 version (that I can find) of rpmfluff.


saw approval from MonsieurNicolas
at https://github.com/graydon/stellar-core/commit/42eb2ca3ee99998eb252b1d6bdcdf33801ad1d2a


merging graydon/stellar-core/bump-medida = 42eb2ca3 into auto


graydon/stellar-core/bump-medida = 42eb2ca3 merged ok, testing candidate = a6095e22


fixed in #687


`auto const&` ?


Super!


Thanks @leoniestevens , I would definitely recommend The Pragmatic Programer to anyone interested in hiring good engineers!


I don't know. In fact I have not looked at this file too much. Let me some time to think about it. I still don't fully understand the variable scope in the plugins and the templates.

Why do you want a class?


@Ignoble61 can you confirm this fix?


SetViewNodeIDs isn't as simple as I wanted as it takes a vector. I was trying to explain to a developer how to set a fiducial list to just be visible in one viewer and wanted to point them at a simple method. SetViewNodeID could work as well, but I was avoiding it as it mimics the Set Macros from VTK that work on a single variable rather than a list of them.


Thanks, I will make those changes.


Initial research says no. I contacted them to see what their solution is.

On Tue, Jun 23, 2015 at 8:43 PM, Lawrence Wang <notifications@github.com>
wrote:

> don't really send push notifications in test env
>
> @robbiecarlton: i just wrote a test that calls the push notification
> code, and i’m putting this in here as a temporary fix. is there a test
> key we can use so that we can test connectivity to the API without
> attempting to send out real messages?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Hylozoic/hylo-node/commit/e3d1e3750e1e240c88ff2049da13d51e549ff6aa

--
Robbie Carlton

719.358.3482
<robbie@authenticmanprogram.com>


I had read the doc's, but i don't realise for what this is usefull for in this case?


will let you know

On Wed, Jun 24, 2015 at 12:12 PM, Robbie Carlton <robbie.carlton@gmail.com>
wrote:

> Initial research says no. I contacted them to see what their solution is.
>
> On Tue, Jun 23, 2015 at 8:43 PM, Lawrence Wang <notifications@github.com>
> wrote:
>
>> don't really send push notifications in test env
>>
>> @robbiecarlton: i just wrote a test that calls the push notification
>> code, and i’m putting this in here as a temporary fix. is there a test
>> key we can use so that we can test connectivity to the API without
>> attempting to send out real messages?
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/Hylozoic/hylo-node/commit/e3d1e3750e1e240c88ff2049da13d51e549ff6aa
>
>
>
>
> --
> Robbie Carlton
>
> 719.358.3482
> <robbie@authenticmanprogram.com>
>

--
Robbie Carlton

719.358.3482
<robbie@authenticmanprogram.com>


That was in there because there were lots of extra blank lines at one point, which might have been an encoding / decoding issue. I think it can be removed now.


Jose Carlos Álvarez, Boris Beck, Luis Diego Fonseca


I think since we're now going directly to the db in order to pull out the taxonomy terms we should ensure this only ever happens once per page load. Although in theory this function should only ever be called once with the $node parameter passed in, we shouldn't make that assumption here. I would change the logic here slightly such that subsequent calls to the function that include a $node parameter do not result in this db query being run. This could be done by checking the static $taxonomy variable.


Oh, I forgot that part but I was going to just make it a warning, and then insert all the extra 1s? I don't want the code to break just because the zeta data of a random ion is missing. I'm raising an error if there's missing ionization data though.


`should` is a deprecated syntax. You should use the `expect` syntax. In this case that would be `expect(Category.first.name).to eq('TV Comedies')`.


Deleted


1699_MeterTimestep (macumber) - i386-Windows-7-VisualStudio-12: OK (2189 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.92%25-yellow.svg)


line 9 of this file tells you were the dist is.  Any automated system should be referencing this (that's one of the main points of this file).  As the path changes, the place to find the path stays the same (its a pointer).  There are several tools out there that do this for you that work with either gulp or grunt.  This way you can simply tell it the package name and it will handle the rest.


@hintjens is there a parameter missing?


Pull request inbound


I think we need to leave for now. When we remove channels for endpoints, we'll need to plug the json parser ourselves. At least I think that's the plan? @josevalim


@TimWolla: `13` means `Enter`, `27` means `Escape`, `38` means `up arrow` and `40` means `down arrow`.
All but `38` are mentioned a few lines further down, but a comment on this line would be nice, yes.


having the same problem on my linux laptop "boost/filesystem.hpp no such file or directory" on a fresh clone of github master from today...


Having your IDE notice typo's, autocomplete your classes and be able to click+follow to the class ;)
If you don't use an IDE, you probably don't care. The effect is the same anyways.


Why limit this to SPA_OLD_MAXBLOCKSIZE instead of SPA_MAXBLOCKSIZE?


We now prefer range-based for loops (e.g. "for (const auto& entry : sortedCommands) {") to C++03-style iterator loops.


Instead of doing this here ... (see below)


... I would make this conditional:
if (filtered_mechs != allowed_mechs) {
    gss_release_oid_set(&min, &filtered_mechs);


Btw, prepone is not a word :-)
Please use: "Retrieve default mechs at server init" as the patch title.


Здесь стоит добавить комментарии к назначению полей.


For sure, we need some credentials ;)


Thanks.


thought that you have said that every nodes serving queries must load this.


@darksoul42 thanks for reporting, should get fixed by a new pullrequest: https://github.com/pfsense/pfsense-packages/pull/889


LGTM. But Signed-Off-By is missing.


Should this file also be deleted?  It's still present, but nothing uses it anymore?
Should the new launcher-impl.h be added to libsession_helper_la_SOURCES?


Cautious mitigating residual artifact from development... now redundant.  Will remove.


I updated this paragraph in the latest README.md. It is now 3 paragraphs explaining the 'timestamp' value. Please copy them here.


Yea, it sounded strange :)
Will fix.


Нужно проверить актуальность сведений


DRM_MAJOR gets defined in a few places now, can we move it to a common header instead of duplicating?

Same for the KDSKBMUTE stuff, etc


you can delete this condition, we'll never set UMP_SKIP_INVALIDATION


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.297](http://teamcity.monogame.net/viewLog.html?buildId=8365&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:21:12


If we delete this, the other stuff won't work (e.g.: .NET 4.5). Don't we want to allow them to still be available/compilable?


Also, this fixes #3.


I like the new architecture diagram. Thanks for fixing it.


I see you point. That said, I think consistency is key, I still think we should use `SetViewNodeID()`.

It would then be implemented like this:

```
void vtkMRMLDisplayNode::SetViewNodeID(const char *viewNodeID)
{
  if (viewNodeID == 0)
    {
    return;
    }
  std::vector<std::string> viewNodeIDs;
  viewNodeIDs.push_back(viewNodeID);
  this->SetViewNodeIDs(viewNodeIDs);
}
```

All of that said, we could also think about implementing a parallel API like the following one:

```
SetDisplayableInView(const std::string& viewNodeID)
SetDisplayableInViews(const std::vector<std::string>& viewNodeIDs)
UnsetDisplayableFromView(const std::string& viewNodeID)
UnsetDisplayableFromViews(const std::vector<std::string>& viewNodeIDs)
```

Note that I removed the `Only` in the name. The fact only one `char*` is given to the function implies it will impact only one view.

@pieper: Any thought


Вообще не актуально. Поняла. Исправлю


similar to above, some of these functions are in a few places and identical.

I think this could be ok as a follow up patch though


More where this came from: https://github.com/meteor/meteor/pull/4619


django-lockout not working for me , can you please help, the decorator/wrapper is not getting invoked?


I saw that, it's a good thing to have.  I assume all tests are passing on the 3 versions of Python we list as supported in the README?


Yes, correct.


added the middleware declaration in settings,py along with the the LOCKOUT_ controls.


Ok understood; would you prefer if the algorithm just "restarted" automatically or are you seeking reconciliation for manual book keeping/accounting?

i.e. Maybe we could do some more generic state management code -- e.g. serializing & storing binary value of the QCAlgorithm internal object every minute so it could be "restored" to its previous minute state.

We do save the live orders data offsite every minute, so you should be able to reconcile it from the order logs up to 1 minute ago.


Not sure about the last APP_NAME - this is inside the app bundle - it doesn't matter what the App is called (I rename to Insengard, Helix, etc so I can keep track of versions. Inside the bundle, it's named what it was built as, and always will be. I believe changing this, at any level other than the build level, would break Kodi. Not that it'll make a huge difference, and APP_Name is always Kodi, from a quick glance.

It also shouldn't have the `os.path.expanduser("~")` - looks like Kodi installs by default into the (equivalent) of the all users applications.

And my bad on the whole path thing - didn't realise when I was testing it that I was still loading the path from the settings file.


Not really "correct" style for the project. should be tabs for indents

also less spaces in the prototypes.  int (*connect)(void **...


ACK


Yep, thanks


Not sure these externs are "westony" enough... maybe should start with weston_

(I don't think there will be any more launcher types than we have now, so I'm ok with just hard coding these three like this, and not adding a ridiculous plug-in interface...)


Haha I was told sometimes ago that those queries are cached so they are not expensive on consequent runs, but sure I will make a local caching in this case.


In your world app name is always "Kodi", in my world it´s not :) (I part-time work for a company maintaining a fork of Kodi)


please add a copyright header based on the ones in the rest of the meson_drm files


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/68209062


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.298](http://teamcity.monogame.net/viewLog.html?buildId=8369&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Do you have to provide a path to your local Kubernetes binary directory?
If you build a local container using "docker build", how do you specify that you want to deploy this container?
In that case, why do you need path/to/kubernetes?

If you do not specify the local directory, should the script simply pull the latest container from Docker Hub?


All the plugins get an *app* object that is an instance of *Webui_broker* class ... *helper* object i s a property of this class,

So we will be able to use *app.current_filter* anywhere in the plugins ...

Why  a class ? Because we will be able to use object methods instead of manipulating a search string .. I am not really pythonic yet but I am aware of object oriented programming ... :-)


Fair enough ;) Objection withdrawn!


Please show an example "kubectl" command that exposes the Cluster-Insight collector on port 8001.


expose the cluster --> expose the Cluster-Insight collector


add INHERITS


Your lines are starting to get really long. Try something like this:

    phone_num = raw_input(
        'What is the phone number of the person you wish to add?\n '
        'Please format like this: 222-333-4444 > ')


Ok regarding that but, I'm not sure button styles are really adapted.


Probably was a bad rebase that forgot to delete it.

And yes, probably.


Not unless it breaks on Linux, which I don't expect; I think this is right for all platforms. It only affects detection.


Menos mal encontre un modo para validar fechas. Ya me preocupaba xD


I think your `else` is mis-indented


Can't you just make the `hitArea` type `HitArea` and since all those other things implement the interface they will be valid?


Is this used?


fast-forwarding master to auto = a6095e22


Yes, exactly.


I don't really understand why this is needed. Could you explain ?


Worried about SPAM, are we?


That's how it was originally but then I figured filtered_mechs will always eq allowed_mechs since it gets assigned that way (so we'll lose filtered_mechs).

So I changed it to the above and remove the condition since I recall you mentioned it's ok to release GSS_C_NO_OID_SET.

Thoughts?

I think I'll do new commits while reviewing next time and rebase at the end so th changes intention will be more clear.


could 'suffix' be empty?
if it is always not empty, should it start with a '/'?


You could even do this all in one line with `return age >= 18`


why not but changing it in the plugin css file itself does not make it safe for updates


I'm on chrome/linux and had this issue. The value was `true` (Boolean). I don't suppose any engine would simply pass by trying to execute a boolean!

Anyway, thanks for the fix. In what version are we expecting it?


Are you sure this is valid syntax? I'm quite sure you need at least a dummy parameter to keep either kzalloc or gcc from complaining.


@brianchandotcom JBoss packages the EAP zip so that it extracts to jboss-eap-6.4.  However, the original zip file has 6.4.0.  That's why I added the version.  Otherwise, we won't be able to unpackage and target properly


please give the exact link to access the document


brace on same line


I actually think I'd prefer launcher-implementation.h


I think there is a mistake here N is the unroll factor so you are allocating an array of 1,2 or 4. to the the size of the register it is cyme::trait_register<T,cyme::__GETSIMD__()>::size < --- this return the size in (byte), so you have to divise by sizeof(T) (T is float or double) and you have to multiply by N
T elems[ cyme::trait_register<T,cyme::__GETSIMD__()>::size/sizeof(T)], presently it is working but you have a nice corruption of the memory


same with iface and pimple.  I think we can afford to type interface and implementation?


This currently fails because Globals.write() is writing out 'None' beside the INIT_STATE parameter when it has no value.  Instead, this parameter should be left out of the write if it is empty (or commented out with a '#')


@jordan-brough not 100% positive but I believe certain associations and/or scopes had problems determining proper sql queries or would try initializing the model without the Spree namespace causing uninitialized constant errors.


maybe pushd/popd would be nice here?


You might consider a utility method I have (something like coerce-to-type) in case the passed-in type is already a ForcedType/bool


So `has_pending_level1_cache_flush` is unused?


Very nice. I was thinking about that few days ago when reading issue #319.

Just wonder if it should open by default (as it does now) or if a new link should display the viewer in a modal box. Great work anyway ! Thanks


Really?! Crap, sorry.


Seem's good indeed. I could allow to make the search only one time per request. I can work on this if you want.


Is this really the preferred order?


opening KUBERNETES_BEARER_TOKEN_FILE might fail.
You should call:
raise collector_error.CollectorError('cannot open token file %s', KUBERNETES_BEARER_TOKEN_FILE)


Nope I have no plans to take it down. Just FYI it uses WebGL. :)

Sent from my iPhone

> On Jun 24, 2015, at 2:47 PM, Maik Macho <notifications@github.com> wrote:
>
> Instead of Google StreetView, use google-panorama-equirectangular.
> I usually am against iframes, but I'll instead just hope @mattdesl will never take down the demo.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AngelDE98/Stacks/commit/2d88baf248a9d067d80a8fcfa68bc44b161f93eb


Ah.... sorry. I missed that one. Thanks.


There should be no space between the "open" and the opening parenthesis


The typical place for these are the kernel headers :)


Who uses 1.9.3 anymore…


When I tried this last it took about 85 years for pub run to actually start my .dart file and then secondly I couldn't actually access the disk, because it was running my .dart from localhost:random_port.

But maybe the pub run environment has since changed and I should try it again?


They're not meant as public API, so I didn't prefix them with "weston_". They should be hidden symbols internally.


@sneakerkg Please help me check the change. I have replaced all the deprecated protobuf definition with the latest one. Please run following tests:
1. Run alexnet training for several hours (including testing). Your old caffe proto file could be upgraded using [this program](https://github.com/BVLC/caffe/blob/master/src/caffe/util/upgrade_proto.cpp)
1. Run other tools only to check whether it runs or not.

-Minjie


Can you give an example of some input into the field box which failed but now is ok?


Yeah, I wasn't super happy with the duplicated code between weston-launch and direct. Perhaps a common "launcher-drm-utils.h" header would be the best solution.


once we push a new binary to Docker Hub, it will fix this statement.


90664130_AlternativeModelPAT (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Hecho por José Carlos Álvarez, Boris Beck, Luis Diego Fonseca


zalloc return should be checked


should have blank line between decls and code


OK


I didn't get any warnings here.


Hecho por Jose Carlos Álvarez, Boris Beck, Luis Diego Fonseca


do you mean from the 'cluster-insight' directory?


Great. Just wanted to check. It works fine for me on Linux.


I will fix this line as well after we push the latest binary.


Which issue are you talking about here ?


And kzalloc on a zero size works fine? What would that even mean?


That's fine, but a few things to change here:

* Don't use string concatenation, rely on string formatting:
```python
logging.debug('Raw data being sent: %s', pprint.pformat(data))
```
* To avoid the overhead of `pformat` when debug logging is not enabled, gate the call with a level check:
```python
if logging.getLogger().isEnabledFor(logging.DEBUG):
    logging.debug('...', pprint.pformat(data))
```


you're actually the one who caught this in your branch!


Ack. Thanks.


The #if 0 was part of the original code. It seems they thought about checking for that but later decided to always flush L1 instead. has_pending_level1_cache_flush will be used in the following commits.


should be:
echo "usage: $0 [path/to/kubernetes]"


0x2B05 was the duplicate entry. Changed formatting to match that of list below.


$fields['group_id']    = 1; // FIXME: Horrible hack


DO NOT MERGE TO MASTER UNTIL WE CONFIRM NO SWAGGER ERRORS


Please explain how to call this function and what are its parameters.


We need a fast version of pub run, which only finds the bin script and runs
it. No http server. No transformers. Etc.
On Wed, Jun 24, 2015 at 21:43 Eric Seidel <notifications@github.com> wrote:

> When I tried this last it took about 85 years for pub run to actually
> start my .dart file and then secondly I couldn't actually access the disk,
> because it was running my .dart from localhost:random_port.
>
> But maybe the pub run environment has since changed and I should try it
> again?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/domokit/mojo/commit/432ce45f63a73ba43571491cb62797b0036f4ae2#commitcomment-11846465>
> .
>


I will fix this line once everything is pushed.


`ResultList` I like that.


What is the parameter of this function?
Please explain it, and add:
if [[ $# -ne 1 ]]; then
...
fi


Changes to better support Moodle 2.6


please explain that you are trying every port from 8001 to 65535 sequentially.


Removed extra variable


I have no idea how to this right now with the Reftype


I think these kinds of small changes can be done with a Git "rebase" command. Then you don't have to do a merge. But, I'm certainly not an expert!


Removing used variables


I learned a lot from this PR, and I like the new architecture diagram.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.298](http://teamcity.monogame.net/viewLog.html?buildId=8369&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:24:05


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.299](http://teamcity.monogame.net/viewLog.html?buildId=8377&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Good overview! I like your pic!

Dave :smile:


gcloud-golang fails to build:
```
golang.org/x/oauth2/google
go install golang.org/x/oauth2/google: open /nix/store/8yblxwkxa69ak1fcnkgzmajaf9b1m54y-go1.4-o
auth2-f98d016/share/go/pkg/linux_amd64/golang.org/x/oauth2/google.a: permission denied
builder for ‘/nix/store/38a1jvlg6gbhffl76apr6rcdzxjbhx8p-go1.4-gcloud-golang-de1c38e.drv’ failed with exit code 1
error: build of ‘/nix/store/38a1jvlg6gbhffl76apr6rcdzxjbhx8p-go1.4-gcloud-golang-de1c38e.drv’ failed
```


I don't like that this method is called `_get_something` but it doesn't return anything and has side-effects. Seems like a code smell to me.

I think a cleaner way to do this would be:

```python
def _add_to_queue(self, metric_type, datapoint):
    # ...
    self._set_datapoint_dimensions(pbuf_dp, datapoint.get('dimensions'))
    self._queue.put(pbuf_dp)

def _set_datapoint_dimensions(self, pbuf_dp, dimensions):
    if type(dimensions) is not dict:
        raise ValueError('Invalid dimensions {0}; must be a dict!'
                         .format(dimensions))
    for k, v in dimensions.items():
        dim = pbuf_dp.dimensions.add()
        dim.key = key
        dim.value = value
```


Stray backtick


C'est nul du slip


Agree strongly, but if we have to put them here ourselves for whatever reason, I'd love to see the contamination minimized. :)


Yeah, brainfart.  I deleted the comment when I realized that, but you were too quick for me.


The result would look like shown in the picture above.


> To then upload it back to Rosetta just use "Upload translation" on the same page as where you downloaded it.
should maybe be
> To then upload it back to Rosetta,  use the "Upload translation" option on the same page that you downloaded it from.


Well I need to dynamically change the format based on the option given and if or not the format has been set, I tried to think of a better way without using the dynamic memory. But couldn't come up with anything, Any suggestions?


leaving a comment on the commit


Please add also tooltip to PLAY on DVR.


A key-value?


Agreed, no need to check, my bad.


@allan-simon: Your thoughts on naming and functionality would be appreciated :smile:. Is `get_nearest_ancestor` too verbose? I also considered `get_ancestor`, `get_prev`, `get_pred`.


a


Hi @sodastsai  , I have checked it on https://cocoapods.org/pods/MTLManagedObjectAdapter
and I use it as advised there
```
pod "MTLManagedObjectAdapter", "~> 1.0"
```


I cleaned up the code, but it would be lovely if all of the code in the second `try:` was able to be condensed while keeping functionality.


@Puggyblue999 What can you do?