Perhaps, but I doubt a lot of Haxe devs know about this (I don't think I've seen this syntax before, at least not in this context), so it's worth mentioning.

Is there some section that mentions the whole "Haxe only has expressions, which is somewhat unusual compared to other languages like Js/As/Java/C# that have statements too"-thing? Could include code examples that work because of this (this var init thing, return switch, functions without {} - I'm sure there's more).


Sure, "banned" or "excluded" would work !


Looks great!


I've reconstructed the requirements for Counter below, it should give you a better understanding of what a counter and its methods are supposed to do

>Define a class called Counter:
An object of this class is used to count thing, it records a count that is a nonnegative whole number.
For the counter class, you need to have:
- a method to set the counter to a given integer
- a method to increase the count by 1
- a method to decrease the count by 1.
- a method that returns the current count value as an integer
- a method toString that return the current count value as string suitable for display on the screen
- a method that tests whether the current count value is zero.

>**be sure that no method allows the value of the counter to become negative.

>write a program to test your class definition.


* TODO: Shouldn't this method take care of setting up a TestServerConnection if the status has changed to testing?


Parameter docstring would be helpful here


Previously, short-range pathfinding for hostile NPCs worked for cases where a path existed, but crashed if a path did not exist. An NPC now idles if it can not reach its target.


I like this approach, though I personally often make the developer_message and the user_message different. But this is nice for the simple case of them being the same.


break the build, conflict with kernel header
/usr/src/kernels/4.0.4-303.fc22.x86_64/include/net/cfg80211.h


I won't submit a pull request because it's so incomplete, but feel free to copy anything I did above that might be useful.


Ok, see d3e7c38


karthik


Excellent idea adding the image!


Line 15: the second to last sentence, I think you meant "I can do _better_"?


Also when checking in your code, make sure you only check in your source code, meaning src/Counter.java and src/app.java. Auto generated code/file should not be checked in generally.


Do asserts instead of NSException.


@mrm007 this should fix your problem


nit: is it appropriate to squash this PR down to one commit before merging?


I don't think anything is missing to move this to the DB. Both gossip_menu and gossip_menu_option have an optional condition, and we can express "you have the quest but it's incomplete" with a condition (CONDITION_QUESTTAKEN, 9, comes to mind, with the incomplete option).

So I think this is just one that Neatelves didn't convert for some reason.


That was anticlimactic. In a good way.


Vai tu vari paskaidrot, kādēļ šīs metodes ir tieši tādas, kādas tās ir? Kādēļ tām jābūt šādām nevis kādēļ vnk `.order("#{params[:sort]} #{params[:direction]}")`


## This is a markdown file


Oops, right.


I agree we should make some examples for that, because "everything is an expression" is actually very cool feature.


not sure what you mean. It should not have any effect on explicit user typings such as E:Exp. It only affects the behavior of the implicit sort checks that are generated for all variables based on their type context.


Agreed.


Why does this silently return a do-nothing backend when the other handler makes a nice error? We could have an explicit null choice if necessary.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2113


ar laiku iemācīsies, ka ērtāk ir izmantot string interpolācijas -> "#{sort_column} #{sort_direction}", turklāt arī performance labāka ir ar interpolācijām.


See: http://site.mockito.org/mockito/docs/current/org/mockito/Mockito.html#6


i am learning how to delete file on github instead create a new one


This should be spelled out in the homepage/documentation as an alternative to class mapping. Right now, it's buried in the 2.0.0 entry for the changelog.


This function needs a return value or you will not be able to properly test it.


This also needs a return value.


What does it mean this message? 😀


This needs to be: `NotEnoughItems` Along with all the NEI things are in the same folder. This needs to made clearer on the wiki file. Sorry about that.


Hehe, neman nav nepieciešams izdomāt lietas, kueras jau ir izdomātas. Divritenis no jauna nav jāizgudro, taču saprast visu - tās gan būs vērtīgi!


Hou yeah ! Good work @herpec-j !
Shame on me ! Haha !


You can get away with just having the `LogisticsPipes` part. We tend to not use the full modid for some mods which have multiple mod parts in a single jar. So the main name is sufficient.


Is this message really neded?


I think you should add a function ```_effective_cost()``` or whatever you may want to call it in the base class which returns the new calculation and call that function in the rating functions as this obviously is a useful calculation we probably want to use in all subclasses.

Is there any reason why you would write ```x**-1``` instead of the much clearer and more readable statement ```1/x```?

Also, I am not sure how you arrive at that formula. The function
```c^(1/(a+x))``` is monotonously decreasing for c > 1 and a>0 which is the case for our uses. I expect to have a higher effective cost because of the upkeep for increasing ship count, not a reduced one.

If you are sure you did some correct calculation, then please add some comment on what your intention is as this then seems to calculate something different than effective cost (or I am failing to convert this code into math right now).

Naively, I would have expected a simple function such as
``` effective_cost = self.production_cost * (1+foAI.foAIstate.shipCount * AIDependencies.SHIP_UPKEEP)```


You just linked me to documentation. I hate you. Quickest window close ever.


Empty if is not good. switch it, test and format


Good tutorial! Looks like you may need to refactor your markdown. Maybe even add some images?


There should be a more detailed paragraph explaining the context about what's going on and why I should care.


Well done. I suggest also log parameters to log file. What do you think?


Value needs to be greater than 2 to submit. I think you didn't test this


This could be simplified. sb is a SentientBeing object and SentientBeing objects have a language property, which you have access to. Get rid of these if/else statements and replace them with a single line that does the same thing.


Build bot
```
base64_convert.c: In function ‘do_convert_wholefile’:
base64_convert.c:1202:7: warning: ignoring return value of ‘fread’, declared with attribute warn_unused_result [-Wunused-result]
```


klases un atribūtu vērtības htmlā mēs esam pieņēmuši rakstīt `dasherize` stilā: class="this-is-attribute-value", tāpat arī LV nosaukumi not cool - datuSize, darbSize


Remember we also want to console.log hello in the speaker's language


Why not just emit the QStringList? You do an useless join here and another in MainWindow. If you fix this now I'll merge this right away.


```Do you want to use this framework?```
No, not Moles. [This one](https://github.com/earalov/Skylines-ModTools/blob/master/Debugger/Detours.cs). I use it in all my mods.
```In all 3 methods, the buildingID or position is known, so the district can be easily found out.```
```I found a few possible solutions:```
There is a 4th, better way (I use that pattern in my Euro buildings unlocker mod) - to wrap original methods.
See. Our first step is to detour each method to our custom method and to remember their original binary states.
And custom methods will look like (pseudo code):
```Csharp
static int blockId;

 void detouredMethod(args){
         blockId = getBlockByArgs(args);
         revertDetouredMethodUsingSavedState();
         callOriginalMethodWithReflection();
         detourOriginalMethodAgain();
}
````
You can see that we can deduce blockId in all these 3 places. So our only job will be to calculate blockId from methods arguments, save it and then use it in detoured ```GetRandomBuildingInfo```


Nvm that last comm


What happened to the subclasses?


Remove boolean and check if refreshToken exists in the init instead of clientForUser:.


Remove the boolean because of initializer comment above.


These are giving me TypeErrors. Turn this into an array, so the sort method works.


Pourquoi ce changement ?


I just added a new issue for it.


With the previous settings, there were no defaults for EOL settings for non-`.c` or `.h` files.  As a result, if you did not set your `core.autocrlf`, then your workdir files are in a strange state.

Check out the guidance at https://help.github.com/articles/dealing-with-line-endings/ and skip to the "Refreshing a repository after changing line endings".


Yeah I suppose it could.

On Wed, Jun 10, 2015, 11:36 Daniel Peebles <notifications@github.com> wrote:

> -exec rm {} \; could be -delete, right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/48381b7621a51512fa0a87f019d5d5915d9f3d20#commitcomment-11618293>
> .
>


The material looks great.  There's a problem with the images, though, in that the text is too small relative to the size of the image.  It's hard to read.  The real problem is that there's too much blank space in all the images.  Increasing the text size would get rid of this blank space.

I'm giving you an 85/100, but if you fix the two problems I mentioned and resubmit you can improve this to full credit.


AFAIK, it's easy to calculate district knowing zone block


> In fact, a number of operations are defined by using map on each character of a string.

`map` works just fine on any iterable. We could have iteration (and indexing) on this new `String{E}` type iterate over code points. The challenge is still out there to provide a compelling case of the need of even *having* a `Char` type if the `String{E}` type is so compact. From the uses I've reviewed in Base, it's mainly cases of indexing strings returning Chars and iterating over a string, which could both be made to return strings of a single code point. This would remove the current, slightly weird distinction between

```julia
char = "hey there"[1]
string = "hey there"[1:1]
```

The one case that comes to mind is where you want to restrict an input to a single code point. In that case, I wonder if having
```julia
immutable String{E<:Encoding, N}
  ptr::Ptr{E}
  len::Int
end
```
Where `len` refers to the number of *bytes* in a string, and the `N` parameter represents the number of code points. Char then becomes
```julia
typealias Char String{E,1}
```


1605_unitary_system_fan (mbadams5) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2135 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.48%25-yellow.svg)


Found a performance improvement:

change
crc = (crc >> 8) ^ table[(crc ^ *p++) & 0xFF];
to
crc = table[(crc ^ *p++) & 0xFF] ^ (crc >> 8);

Here is example.  crc32c, then crc32c with changed code, then crc32

```
$ ../run/john -test=3 -form=crc32c
Will run 8 OpenMP threads
Benchmarking: crc32c [CRC-32C 32/64]... (8xOMP) DONE
Many salts:     262015K c/s real, 78047K c/s virtual
Only one salt:  75529K c/s real, 44218K c/s virtual

$ make -s
Make process completed.

$ ../run/john -test=3 -form=crc32c
Will run 8 OpenMP threads
Benchmarking: crc32c [CRC-32C 32/64]... (8xOMP) DONE
Many salts:     319350K c/s real, 98689K c/s virtual
Only one salt:  79065K c/s real, 50211K c/s virtual

$ ../run/john -test=3 -form=crc32
Will run 8 OpenMP threads
Benchmarking: CRC32 [CRC32 32/64 CRC-32C SSE4.2]... (8xOMP) DONE
Many salts:     318872K c/s real, 100136K c/s virtual
Only one salt:  92846K c/s real, 55536K c/s virtual
```


Assign based on type and nil out other.


Joprojām views renderē 2 html, 2 head, 2body - ja tev ir layouts, tad viss views tiek izlikts iekš layouta.


it's actually also used by krun to detect the backend. That said, I have thought about it and you are right that I should probably pass false here. So I will change this.


Nu lieliski, paņemšu pull un paskatīšos, kā viss izskatās.


This would eliminate the need to have the pointers scatter below:
```
var output string
flag.StringVar(&output, "o", "", "set the output file to write logs into, default is stdout")
```


Remove the lines 225-230 and remoce the config insert_inplace_optimizer_validate_nb


This makes translating harder because 'Read the documentation at `docs.plone.org <http://docs.plone.org/external/plone.api/docs/user.html>`_ so you have working references and proper formatting.' now is two lines, right?


Don't use commas to separate multiple css classes, you only need a space.


The point of this commit is to get rid of ``*ppSample = m_ScheduledSamples.RemoveHead().Detach();`` and make it work trough a proper QueryInterface()?


Плагин не сильно поможет, для его поиска и загрузки так же нужны асинхронные методы работы с файлами. Имхо, ядро должно предоставлять удобный интерфейс для асинхронной работы с файлами. Представленная реализация, конечно, не идеальна, но. кажется. на её базе можно сделать удобный интерфейс в дальнейшем.


I didn't reply because I thought we talked about it during office hours.

Of course `execvp` can launch `history` just like it can launch any other command.  The problem is that you're never allowed to pass `NULL` as the second parameter.


ok. não sabia que já tinha vlw

Date: Wed, 10 Jun 2015 10:14:06 -0700
From: notifications@github.com
To: velocity-sublime@noreply.github.com
Subject: Re: [velocity-sublime] Adicionando snippet Redirect java Velocity (b21d00e)

Henrique, vc poderia tirar o shebang de velocity? atualmente já tem um snippet pra isso (vm)

—
Reply to this email directly or view it on GitHub.


Create new convenience initializer so that passes in nil instead of calling this one directly.


I only saw one comment, which I replied to.


lets include this example also?


Please add return true or false :)


I get this error on linux 64bit:

```
In file included from ../../../libs/openFrameworks/graphics/ofPath.h:3:0,
                 from ../../../libs/openFrameworks/graphics/ofPath.cpp:1:
../../../libs/openFrameworks/utils/ofConstants.h:359:70: error: missing binary operator before token "("
 #if (!defined(TARGET_OSX) && !defined(TARGET_OF_IOS) || __has_feature(cxx_thread_local)) && __cplusplus>=201103
                                                                      ^
```


fast-forwarding 2.0 to borshop-integration-1139-bugfix/remove-sc-aae-warning-2.0 = 0ec5c66b


Merge sha 3b9c4964 is stale.


merging basho/riak_kv/backport/zl/riak-kv-1088 = b3301efc into borshop-integration-1140-backport/zl/riak-kv-1088


basho/riak_kv/backport/zl/riak-kv-1088 = b3301efc merged ok, testing candidate = 805c1c10


saw approval from jonmeredith
at https://github.com/basho/riak_kv/commit/d32be75fd479415b00dc8bebbdb22603a5ce8163


merging basho/riak_kv/bugfix/csm/rdb-backport-vnode-status-file-2.0 = d32be75f into borshop-integration-1141-bugfix/csm/rdb-backport-vnode-status-file-2.0


basho/riak_kv/bugfix/csm/rdb-backport-vnode-status-file-2.0 = d32be75f merged ok, testing candidate = 96d1ad21


shared examples are for nouns. this one is probably "unsuccessful edit"


I still think it is possible to export some of the work to the callback handler in order to avoid the asynchrony. Hard to say which solution is more cumbersome. Cursors are already more mental overhead than your typical data structure and this does not help.

Test helpers could be nice, possibly even mock cursor object. If people are making nextTick synchronous, I would want a warning message when a cursor is updated twice, since otherwise the cursor would appear to work but have the wrong behavior.

We should also bump the version to 0.2. This is not a patch change since it breaks all the tests.


No, please!  Go look at the code that would be generated...  `String{E,1}` has much more overhead than `Char`...
Yes, it would work, and I've *long* experience with an ANSI standard language that did just that...


:) můžeme pro to zavést feature admina v novém ui


Testing the equality of two arrays is a little complicated in JavaScript because it's really testing whether both left and right point to the same object not whether they contain the same items in the same order. For our purposes here, I would just use the .toString() method. Let me know if you have questions about this.


@fraenkel Do you mean that when main receives an error on the errChan it should first close down the remaining server? I'm not sure why main would need to look for two responses, presumably if either of the servers goes down we would want to exit the process.

- @chrino && @leochu


Mirror what BOXAPIOAuth2ToJSONOperation for failure block.


True. The try..except ImportError will swallow underlying ImportErrors though.


Commented where I think I may be of help. The rest goes to @kasper93.


Make your error messages more descriptive. How can you tell which test is failing?


To by asi bylo dobrý :-)


Ca simplifie des trucs comme initmovement je pense


cm


Du coup initMovement c'est bon alors ?


You can use stack instead of a vector.


Parce que 1:
On peut pas faire 500 sorts juste pour au final retomber sur une matrice qu'on pourrait calculer beaucoup plus facilement
2:
Ca simplifie énormément d'avoir cette représentation en tête
3:
Ca permet de stocker plus facilement les données

Pour moi ça me semble capitale après coup qu'on puisse savoir à quel endroit est un tile indépendamment de sa position, surtout dans le cadre de positions variable (en gros si moi je voulais calculer dans le GameSaver la position de chaque Tile sur la Grid pour qu'ils soient remis à leur bonne position au chargement du jeu, il aurait fallu que je fasse comme dans initMovement mais en pire, il aurait fallu que je passe en paramètre de mon GameSaver la liste de point ET la liste de tile et qu'ensuite je fasse 500 calculs avec des sorts pour connaitre précisément  l'état du jeu)


There is also a comment under line 119.


Is this completely dead?


Sorry, `item` here is a mistake. Should be `a, b` like above. With that in mind, rewrite this comparison function with sumArray.


debug leftover.


Du coup là j'ai EN THEORIE finis d'implémenter les matrices pour toutes les fonctions sauf initMovement, je push ?
ça a changer pas mal de chose et c'est possible que tout ne fonctionne plus, mais ça compile et on voit tout qui s'affiche normalement (sauf le initMovement qui est pas géré)


I missed that point. Is it stated in the documentation ?


Do not override and manipulate initializer to circumvent.


@lucasrenan I think it is better to `Refund` self update, not other class. :/


@lucasrenan Yes! I'll change it :)


@genjusz, you should make changes to the [KunstmaanBundlesCMS](/arsthanea/KunstmaanBundlesCMS) fork instead


yes


This record only the node that failed. It do not record all replace done since the last checkpoint. So we will loose some reverted node. You need to track the node changed since the last checkpoint and put all of them in the failed_list.


When I fixed the crash, I was thinking about something like this too. But I ended up not doing this and kept the two strings, clarifying one with "creature" (giving the hint to check the creature table), because I believe that a GUID doesn't mean anything for most server admins. I bet most of them can't even separate players from creatures just by looking at a GUID.

That said, I personally don't mind this change.


Seems a bit harsh...


Nice!


If there is only 1 elemwise, check_each_change is 0. This will skip the optimization of that case. I think I would do `while len(elemwise_nodelist) > 0`


How about 6 then?


This should be a noun also. But I don't think that we care about this in #new


how would you do that? You only know the

* Service (residential/office/...)
* SubService (none/forestry/oil/...)
* Level (1-5)
* plot width
* plot length
* ZoningMode (corner/straight)

of the building. It could be anywhere.

We have to detour the 3 methods calling ``getRandomBuildingInfo`` where the position is known.


I'll work on making this more responsive for the phone.


This probably wants to check answers.where(something).


Case when m_stack not empty do not handled. I think "{{{" correct string for this algorithm.


Thanks ! The travis CI build fails on this one with an undefined NULL. Can you replace it with a 0 or include stddef.h ? (yay, a use for CI)


This is getting juvenile and pointless. Funny how that's started happening in the last few months.

> You are confusing things. The `CharA`, `Char8`, `Char16` and `CharU` types do NOT have encodings, and neither does `Char`.  They are simply sets of non-negative integer values.  They can be stored in many different ways.

No, that is entirely wrong. These are all concrete Julia types: they are specific *representions* of sets of values; you cannot represent values without choosing an encoding. The type `Char` is **not** a set of non-negative integer values. `Char` is a way of representing a set of non-negative integer values. Integers are a concept – they cannot be manifested directly in computers.

> Why do you even need, for example, `UInt8`, or `UInt16`, or anything except for `UInt128`, if you apply your argument to `Unsigned`, for example.

This is precisely the point. `Unsigned` does not have an encoding because it isn’t a concrete type. Concrete types like `UInt8` do have encodings.

> Please go look up the differences between characters, code points, and code units…

Not sure who this is directed at, but I’m quite clear on these terms.


Why not "copygirl (C) 2015" ?


Not really, no. As I explained in the comment, currently passing *any* kind of a string to .isKeyDown() will *always* return nil, because the keyboard.pressedChars table *never* contains any string keys, at least here. And yes, that is also the case for unicode characters like "ą" or "ż".


Not really, this was just to be consistent and use `CComPtr` everywhere. The idea was to make sure that the thread which returns a sample to a queue does not keep any reference on the sample.

However thinking more about this I don't understand why I thought it might help in any way... It cannot hurt though, at least it ensures you cannot access the sample again after returning it to a queue.

I really looked hard at what we do with those samples but so far I couldn't see anything wrong. All I came up with was this which is in fact a non-issue...


@jfirebaugh have you fixed something? I just realized that the test case was requesting a tiles at zoom level 15 even though I was doing `data_.transform.setLatLngZoom({0, 0}, 16);`.


> The point of this commit is to get rid of *ppSample = m_ScheduledSamples.RemoveHead().Detach(); and make it work trough a proper QueryInterface()?

Hmm, standard pattern is to pass pointer to an CComPtr object, assign and AddRef. With `Detach()` it just doesn't do release so it is not required to addref. But still it you want nicer way, we could use `m_ScheduledSamples.RemoveHead().CopyTo(ppSample);`. But still this it not really what you do here. Look that he essentially does move pointer instead of copying it.

While this commit is fine, I would suggest making `MoveToScheduledList` `MoveToFreeList` to get r-value reference and use std::move to case l-value when needed. Current way would be error-prone I guess.


YES.


Revert this file.


Oops.. I was pretty certain that I was reading WTForms manual, but this feature is Flask-WTF only. Sorry for the noise.


From a scale of left to right, girl is -i. I don't think it fits.


Au pire on peut revenir en arrière, faut que je réflechisse encore tellement ça me parait compliqué à implémenter


Done in 145c1f4 + I resolved conflicts with Password guessing PR to make automatic-merging for you in 5b4e266


What happens if the sym does not exists in map ?


*White spaces removed


This is probably just :answer_value.

'answers params containing a new value' is probably just 'answers params', except that it's specifically formatted for multiple choice. so 'multiple choice answer params' maybe? Then it might be applicable in more places.


D:


To clarify, in the original comment, when I said:

> keyboard.pressedChars[] is always indexed by the unicode codepoint

I meant that it's indexed by the **numeric** codepoint, not a string.


PHPCS: Whitespace found at end of line


Yep, rescuing `KeyError` is pointless.


@sebmck Just FYI.


The log handler takes care of that... It prints messages to stdout and also to a log file. The log file is currently placed in /tmp/ssds.log.


window.addEventListener


This is surprisingly MUCH faster. There is about a 20% improvement in overall rate of the format. Since there is also quite a bit of overhead that should be identical between the 2 builds, then the improvement on actual crc update macro must be quite a bit more than 20% improvement.

I have no explanation, other than there must be some way to better optimize delaying that shift-xor   I have been using my crc32 logic (with the macros), for about 20+ years.  IIRC, I remember changing the macro I 'found' somewhere, because I found it improved speed.  I had totally forgotten about that, but now do remember that improvement.


gay


Doesn't #new need to know about questions & assigning a new answer for each question so the form has the fields for the answers, though?


This was a codename; neel will rename his repo


Minor nitpick, commit message should probably just be "use match_array", yes it reduces complexity, but that's part redundant and part untrue unless you've made lots of complexity reducing changes and that's the title of the commit where 'use match_array' is part of the body. But even then "Refactor StoriesController spec" is a more accurate description of the change


bitwise AND here?


Just after I wrote that message I realized what you meant :) That's not bad idea. I will take care of that.


разве рельсы при бандл инсталл не поставятсяЮ


fix this up into wherever it was introduced.


@kasper93: I wanted to use `std::move` but we handle `CComPtr` while the list is `CComQIPtr` so it cannot work. I can use a list of `CComPtr` if you want.


The fact that one fails while one is working, you will cause all sorts of issues by bringing everything down.
The question is whether when one fails, should we be draining the other to have a more graceful shutdown.


what message?


Hmmm, unless you're excluding spec files in the `gemspec`, this will be a top-level class in the inclusion project.


Thanks for adding this one.


Where destructor?


checked


remove this line.


QW community is very good at holding grudges forever. And at loling apparently.

That being said, I am (and have been) open to opinions from more knowledgeable people that I am code-wise (we all have a job or passion as area of expertise, we're just not all coders) and open to changes done to MVDSV/KTX that would improve them.

I do not care much about who started what bug, but I do care about people who take time and effort to fix them. At the time, I found it a shame to see @qqshka and you get all aggro on the commit, but especially about the fact that nothing came out of the "discussion" regarding the issue when you both have knowledge and capacity to do something about it.

So, to conclude, anybody willing to fix this issue (or any other) in a decent _meaning without breaking current compatibility further_ fashion will be cordially received and credited where due, no matter what @qqshka likes or not.


@Olegas you forgot these :)

```
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Christian Tellnes <christian@tellnes.no>
```


Sorry the message was just for testing the communication :D It's from a movie with Samuel L. Jackson :D I will change it to something more approptiate :D


private


а для чего .ruby-gemset создавали?


(you're within 10 minutes, so you can force-push so long as there are no commits ontop of this one)


Not merging this due to being mean.
(what do you mean I'm being sympathetic to RX14? B-baka!)


develop (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Hey Alatis you free #?


поищи у рельс команды для сетапа базы


you will need to bind this function to the context of the Game, otherwise you'll end up in the window context. Create a new method called setBindings that does this:

this.uniKeyDown = this.uniKeyDown.bind(this);

That way we're always in the right scope.


Basically that it means that the `MoveTo...` functions now move the sample for real but they do that by adding a ref and then removing one instead of just transferring the ownership.


rails s шорткат удобней


Well, I'll get it into every other fork!


> I wanted to use std::move but we handle CComPtr while the list is CComQIPtr so it cannot work. I can use a list of CComPtr if you want.

I don't see a problem here. I've meant to simply do `MoveToFreeList(CComPtr<IMFSample>&& pSample, bool bTail)` so we instantly know that if we call this method `pSample` can/will be invalid. I haven't meant the list itself.


1605_unitary_system_fan (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Shouldn't this point to https://github.com/performancecopilot/pcp-webjs?

@lberk @kmcdonell


This is completely broken for users using map[string]string - it simply ignores the map and returns nil.


ok. we can see this again in the near future.


Strange. This code is simple enough I'm tempted to isolate the generated assembler and compare the two versions.


PHPCS: Whitespace found at end of line


I see the code for the quote here. But, it does not look like you have implemented it into your site. Make sure you do that so I can give you a grade.


Yeah, I know. But I'm really busy lately and didn't have time to work on it. Additionally I will have some patches for EVR which can make a difference. Basically we doesn't ever check renderer state and we should check it in few places. I say that, because I saw this crash that we get some time ago on my PC (but ignored it, it was really one time ;p) and it was during closing playback.

Anyway, I won't have time to look at it before next week.


Good point, no idea where my mind was. Fixed.


Hmm ok, so you meant just so that we have to use `MoveTo...(std::move(pSample))`? I was taking of the CComPtr overloaded methods which transfer ownership for rvalue reference.


@Fishrock123 done.


I didn't knowingly fix anything, but the pbf parse [used to be inside a try/catch](https://github.com/mapbox/mapbox-gl-native/blob/cfee5aa8ef73b5bd2050bd68d584846192ebf0a2/src/mbgl/map/vector_tile_data.cpp#L52-52) -- maybe the mismatch went unnoticed?


S do you agree with that?


I thought when you initialize a char*[] you need to add the NULL at the end manually? Either way, I can't pass the char* into execvp.


1. PrivateBuildingAI.SimulationStep
```  public override void SimulationStep(ushort buildingID, ref Building buildingData, ref Building.Frame frameData)```
```Building buildingData``` contains m_position. There is a method to get district by position

2. PrivateBuildingAI.GetUpgradeInfo
```  public override BuildingInfo GetUpgradeInfo(ushort buildingID, ref Building data)```
same here

3. ZoneBlock.SimulationStep
```public void SimulationStep(ushort blockID)```
This is an instance method, and each zone block has m_position too. Just see few lines below how they get district. ```this``` pointer is easily retrievable. In my pull request I'll demonstrate a pattern how to do that. I've already tested my detoured ```GetRandomBuildingInfo```. It works :) Will send the pull request in few minutes.


I checked on linux-64, and saw about same percentage of gain (format speed).


Looks reasonable


Achievement unlocked: "Force push to master branch of io.js repository". )


Note that if you have patches, you should probably push them even if they are not ready so that we don't work on the same thing.


Comparison of current `getindex` code for ASCIIString vs. my idea of returning a string of length 1 with the new string representation
Current:
```julia
In  [25]: @code_llvm getindex("hey",1)

define i32 @julia_getindex_21886(%jl_value_t*, i64) {
top:
  %2 = getelementptr inbounds %jl_value_t* %0, i64 0, i32 0
  %3 = load %jl_value_t** %2, align 8
  %4 = add i64 %1, -1
  %5 = getelementptr inbounds %jl_value_t* %3, i64 1
  %6 = bitcast %jl_value_t* %5 to i64*
  %7 = load i64* %6, align 8
  %8 = icmp ult i64 %4, %7
  br i1 %8, label %idxend, label %oob

oob:                                              ; preds = %top
  %9 = alloca i64, align 8
  store i64 %1, i64* %9, align 8
  call void @jl_bounds_error_ints(%jl_value_t* %3, i64* %9, i64 1)
  unreachable

idxend:                                           ; preds = %top
  %10 = bitcast %jl_value_t* %3 to i8**
  %11 = load i8** %10, align 8
  %12 = getelementptr i8* %11, i64 %4
  %13 = load i8* %12, align 1
  %14 = icmp slt i8 %13, 0
  br i1 %14, label %L, label %if

if:                                               ; preds = %idxend
  %15 = zext i8 %13 to i32
  ret i32 %15

L:                                                ; preds = %idxend
  ret i32 65533
}
```

New `String{ASCII}` getindex
```julia
In  [24]: @code_llvm getindex(t,1)

define %String.15 @julia_getindex_21881(%String.14, i64) {
top:
  %2 = icmp slt i64 %1, 1
  br i1 %2, label %L4, label %L1

L1:                                               ; preds = %top
  %3 = extractvalue %String.14 %0, 1
  %phitmp = icmp sgt i64 %3, %1
  br i1 %phitmp, label %L5, label %L4

L4:                                               ; preds = %L1, %top
  %4 = call %jl_value_t* @alloc_2w()
  %5 = getelementptr inbounds %jl_value_t* %4, i64 -1, i32 0
  store %jl_value_t* inttoptr (i64 4363346672 to %jl_value_t*), %jl_value_t** %5, align 8
  %6 = getelementptr inbounds %jl_value_t* %4, i64 0, i32 0
  store %jl_value_t* null, %jl_value_t** %6, align 8
  %7 = getelementptr inbounds %jl_value_t* %4, i64 1, i32 0
  store %jl_value_t* null, %jl_value_t** %7, align 8
  call void @jl_throw_with_superfluous_argument(%jl_value_t* %4, i32 30)
  unreachable

L5:                                               ; preds = %L1
  %8 = extractvalue %String.14 %0, 0
  %9 = ptrtoint i8* %8 to i64
  %10 = add i64 %9, %1
  %11 = inttoptr i64 %10 to i8*
  %12 = insertvalue %String.15 undef, i8* %11, 0
  %13 = insertvalue %String.15 %12, i64 1, 1
  ret %String.15 %13
}
```
which would get even better, from my understanding, based on Yichao's recent work on `throw`.


This fixed a bug where bz2 decompression was stripping newlines from the result, for every line. But this fix adds a bug, the last line will get a `\n` added to it. But I think this bug is smaller and more manageable than the previous. And I don't see a clean way to fix this right now.


Yeah, I believe this is the cleanest solution. Thanks!


Correct. Approving pull requests however is a feature available on Bitbucket. Instead on Github one has to communicate it in writing or with emoji, like :+1: (thumbs up).

I would change it like:

> When satisfied, they either approve the pull request (Bitbucket), or comment on the pull request `Ready to merge.` (Github).


This will cause double "Failed to parse" wrapping for [exceptions handled here](https://github.com/mapbox/mapbox-gl-native/blob/17fc5a741a149c925829230017cb4d55fdff53db/src/mbgl/map/tile_worker.cpp#L57-L59).

We should remove the exception handling from `TileWorker::parse` and add it to `Worker::Impl::parseLiveTile` like you've done for `Worker::Impl::parseVectorTile`.


Should use Meteor.user() instead here.
https://docs.meteor.com/#/basic/Meteor-user


It has to be something the compiler can do better. The only thing I see is that the lower 8 bits of crc are used in 1 sub expression, while the upper 24 bits are used in the next one (shifted down 8 bits).  But to my feeble human brain, it looks like the same amount of work having to be done.


This was mislabeled as 5.3.3. IT was actually 5.5.3.


I think will be better to just wrap messageCollector to MessageSeverityCollector


This looks good. It worked pretty well when I used it.


It does right now, but is that part of what we *want* for it to do?


Also, `LiveTileData::reparse` needs a change similar to the one here.


@kasper93 I don't think ``CComPtr`` is meant to be passed as a parameter, at all. Sure it can be passed, but you already have classic COM pointers for passing parameters. And ``CComPtr`` works nicely with them...

And guys, keep it simple where you can, please?


ack


For killing the mutation of forgetting to call add_answers, is the solution that we specify where all it gets called? Probably not, I think the answer is to make it so it's not something you need to call.


Won't they need 1.3.0 or whatever version we're calling the new release?


Yikes. You're right. Gone.


Until we solve that, the mutant simply lives.


I would love to convert the string to a codepoint properly, but the built-in unicode library won't let me. ;_;

There's unicode.char available, but no unicode.codepoint.


don't quote the keys


The point of mutation testing is to find specs we wanted but don't have, not specs we don't want.


ok, removed


So what do you propose? We do want the functions to move the sample, not just create a new reference on it.


@robwalch - this is causing non-linear ads to appear in the wrong place, can it safely be removed?


re: (NO ARGUMENTS) display this usage text and exit

I've always thought it's nice that programs do this. Anyway, try unzip and tar without arguments. The alternative is either one of those or that we simply run the program if no arguments are supplied. The "problem" is that --arguments are unknown to user.


PR:
https://github.com/boformer/BuildingThemes/pull/1


Good point.

I would also like to enforce no commits on master.

The only reason one would make a commit on master, and only one, is to trigger a deploy with Codeship. We had a case today where with Andrzej we did something like:

    git commit --allow-empty -m 'Deploy.'
    git push

No code change was present in the commit, but once pushed a new build was triggered from master (as a new commit was detected).


lgtm. thanks.


**Report(Day 1)**
I spent most of day one working on [Mastering Markdown] (https://guides.github.com/features/mastering-markdown/),The basic concepts on how to use markdown to write my *reports*, *editing* and trying to understand my way around [GITHUB](https://github.com/).I also spent some time finalizing the procedures and registration at *IRMA*,(i.e creating the account and getting it activated ).


>Are you saying you do not want a file that uses fstreams like how I used it?

The starting file should not use fstreams, just cout.  The student completing the lab should not have to modify any lines of code that already exist, only add new lines of code doing the io redirection.

> When you say "run the file (and display the output), then run the file with output redirection in bash (and display the output in the file)." What file am I running? Would the solution I gave still be correct? That still uses syscalls to do i/o redirection.

Something like:

--------

Compile and run the program:
```
$ g++ output.cpp -o output
$ ./output
Some text gets printed to the screen
```
You can use output redirection to make the text get printed to a file, like so:
```
$ ./output > file
$ cat file
Some text gets printed to the screen
```
The task of the lab is to modify the file `output.cpp` so that the compiled program behaves as if it has undergone output redirection.


Empty lines are important in Velocity/XWiki, and these empty lines will cause extra empty space to be displayed in the patient record. If you want to separate blocks of code, you can use commented out lines:

    ##
    ##


This patch looks ok. I would also add an ASSERT in `GetImageFromMixer` to check if sample we get from the queue have proper id.


The text option was set to true.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2117


You mean in the GetSample... functions then?


Props for thinking outside the box to tackle our various mina glitches. Hopefully this is the golden ticket we've been waiting for.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.264](http://teamcity.monogame.net/viewLog.html?buildId=8220&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Sorry, I misread the code in your question.  You do need to pass in the `NULL` manually.  I'm not sure what the problem is you're having.  Are you sure you have the `history` command installed on your machine?

The code should not have any warnings.  This may be related to your problem.


you can omit `px` with React inline styles.
```js
style={{ top: top }}
```
https://facebook.github.io/react/tips/style-props-value-px.html


Can be. Before `IMFTransform::ProcessOutput` call anyway.


Add `[Explicit]` attribute so that these tests, which are dependent on a local Redis instance, don't run automatically every time.


Not sure why you create a `new Promise`. `self.User.findAll()` does that already.


See previous comment.


That looks good to me!


please remove the changes to this file from this commit, and put them in 8882 along with commit cef20dc3b97ec205dcef5884ce93c355fc9b4c3c


Good thinking!


This was already fixed in master in 46f74bd11cbfe42b688bcd53a609c5ca751d270f


This fixture should also only run explicitly.


heh, I don't use Keys for now, didn't see this one.


Это какое-то новое место для конфига теперь? Или только для этого случая.
common/config/modules/search/config.php


I don't see dots in the code? Did you forget?


@MikeTayC, as we discussed today. You will need to move the standard router to configuration. Feel free to use JSON, YAML, XML, etc.


Looks quite cool and works relatively robust in case of matching parentheses and missing closing parentheses.

Sadly, `nested_search_in_between()` fails reliably in cases, where an opening parenthesis is missing before the first closing parenthesis - a case that you are not testing in the unit tests.

```python
>>> from coalib.parsing.StringProcessing import nested_search_in_between
>>> list(nested_search_in_between("(",")","a(b)c"))
['b']
>>> list(nested_search_in_between("(",")","a)b(c"))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/fneu/Projekte/coala/coalib/parsing/StringProcessing.py", line 492, in nested_search_in_between
    for elem in strings:
  File "/home/fneu/Projekte/coala/coalib/parsing/StringProcessing.py", line 15, in limit
    for elem in iterator:
  File "/home/fneu/Projekte/coala/coalib/parsing/StringProcessing.py", line 445, in _nested_search_in_between
    if nesting_level == 0 and left_match != None:
UnboundLocalError: local variable 'left_match' referenced before assignment
>>> list(nested_search_in_between("(",")","a(b)c)d"))
['b']
```


Looks good to me


Done.


So I should add this in OKC, right?


@MikeTayC The default module should probably be 'core'. The default Controller should probably be Core_Controller_Index


Для модуля Search он всегда там был


testando


I thought we weren't doing any official support for divs.


Well the warnings are from `char*[]` to string conversion. Since `execvp` takes `char*[]`, I need to somehow get it to take `history` but I wasn't sure how I could initialize my `char*[]` using char rather than string.


So, in each of these 3 places we retrieve District ans save it to a static variable. Then we use it in detoured ```GetRandomBuildingInfo``` to filter growables by theme. Does it make sense now?


~ Matrices ~
-> initMovement utilisera les matrices de point et de tile et plus des sort()
---> créer nextTileMatrix et utiliser tileMatrix, initMovement a pour but de créer la matrice de l'état suivant du jeu à partir de celle de l'état actuel (en positionnant correctement chaque Tile dans la matrice)
---> Ajouter des méthodes si nécessaires mais >ne pas casser l'encapsulation<
-> Il faudra prendre en compte ces matrices dans les modifications futures du TileListManager
(bien comprendre qu'il faut parcourir la matrice en x et en y et donc utiliser deux for() )
-> Les fonctions ont été refaites un peu à l'arrache, on rendra tout ça plus propre une fois fini


There is only one broker (application) which is split into three layers


Uses python:2.7 again


> We do want the functions to move the sample, not just create a new reference on it.

I fail to see why we actually want this, to be honest. To make sure there are no errors in our logic for refcounting?


as for `window.pageYOffset`
if you concider browsers compatibility
`window.pageYOffset || document.documentElement.scrollTop || document.body.scrollTop`
https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY
http://stackoverflow.com/a/20478983/3874570


Mostly because we want to be sure the sample won't be reused by mistake while it's supposed to be waiting gently in a queue.


Hm. I don't think this will work. The files will be identical, so we only need to validate one of them, but they'll all need to be signed, in the end.


missing `s`?


@MikeTayC I think the request and response class should be under the model directory within lib/core. Also, they should both be singletons and accessible via the bootstrap class via something like Bootstrap::getRequest() or App::getRequest().


Hi,

Ryan John Peck <notifications@github.com> writes:
> Shouldn't this point to
> https://github.com/performancecopilot/pcp-webjs?
> @lberk @kmcdonell

The github repo is a mirror of the material, however the most up-to-date
code is pushed to the souceware.org repo first.  Hence pointing to that
location in the docs.

Cheers,

Lukas


Hi,
I am currently at MOP (the Math Olympiad Program) at CMU. After being
unable to find the solution, I looked up the problem. In mathematical terms
it is known as the domatic coloring on a hypercube. I found a paper with
the solution but did not read it. If you think now is long enough to have
worked on it, you could email me your solution or I could read the paper.
This was a very interesting problem and I will probably regret not solving
it on my own. I guess I still have a few hours.
Thanks,
Jacob
P.s. I will probably not be rejoining Robotics next year, but if you ever
find/come up with more interesting problems please send them along.
Jacob,

If you are interested in the solution to the prisoners puzzle, I will be at
the FRC room today at 3pm sharp for the last time this year(session). I
have been wanting to share it and see what you think.

Ciao Mike

—
Reply to this email directly or view it on GitHub
<https://github.com/Team3128/frc-java-3128/commit/c0a9c6d7bf861f1c1e91a5dabb8d49a729c611d5#commitcomment-11616787>
.


I am sorry.. :cherries:
I didn't notice your disclaimer in comment: https://github.com/elementalui/elemental/pull/25#issue-86937515
```
1. I've used only pageYOffset since there is no support for <IE9
```


Not sure. Tar or unzip without args is unreasonable, but (IMHO) for game args is additions.

> The "problem" is that --arguments are unknown to user.

Traditional '-h' / '--help' ?


PHPCS: Whitespace found at end of line


We don't want this to happen silently for example:
```
MoveToFreeList(pSample);
// ... mistakenly use pSample which is not supposed to be used anymore
// unless we get it out from the queue
pSample->DoSomeThingWithTheSample();
```


The picture of how things ought to work isn't clear enough yet to move encodings into Base. That's just asking for multiple rounds of breaking changes.


> I don't think CComPtr is meant to be passed as a parameter, at all. Sure it can be passed, but you already have classic COM pointers for passing parameters. And CComPtr works nicely with them...

I agree.

> Mostly because we want to be sure the sample won't be reused by mistake while it's supposed to be waiting gently in a queue.

As Alex said to keep this simple I would just release CComPtr after calling `MoveTo...` when appropriate.


fast-forwarding 2.0 to borshop-integration-1140-backport/zl/riak-kv-1088 = 805c1c10


Merge sha 96d1ad21 is stale.


merging basho/riak_kv/bugfix/csm/rdb-backport-vnode-status-file-2.0 = d32be75f into borshop-integration-1141-bugfix/csm/rdb-backport-vnode-status-file-2.0


basho/riak_kv/bugfix/csm/rdb-backport-vnode-status-file-2.0 = d32be75f merged ok, testing candidate = b68e3a67


Line 1250 has this problem, too.


pretty cool, I couldn't break it, seems to be fixed :)

ack


optipng -o7 -strip all GnoPN15-Plakat-small.png

spart ein paar kB:

https://i.imgur.com/XH16joJ.png


Ah, my apologies, I am glad that this still covers it though -- other
similar situations of using video evidence to correct times still shouldn't
be used.

On Wed, Jun 10, 2015 at 6:02 AM Oleg Gritsenko <notifications@github.com>
wrote:

> Well, I actually meant that if the competitor resets the timer before the
> judge writes anything then the judge shouldn't use video evidence to figure
> out what the result was, just write DNF. But I guess this scenario is just
> a special case for your change anyway.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cubing/wca-documents/commit/516930275660cadd317d7d6bd7b787c75432112d#commitcomment-11607752>
> .
>


Pardon?

It's an `if` below, not an `else if`. Thus, we still set `io_input_bps` and `io_output_bps` in the event that they changed.


@MikeTayC, what if I am trying to access admin/page/view, but Admin/Controller/Index doesn't exist...I guess what I am trying to say is that I don't want the developer to be forced to have an index controller.


removed


> I would just release CComPtr after calling MoveTo... when appropriate.

And rename MoveTo to PutTo, so it won't cause confusion. The release can be done nicely by ``= nullptr``;


Also add dots here?


rax retry tests


ack


Ah, good point. Not having it be a property breaks the contour_x and contour_y code which is why i changed it.

Based on its name contour should be a property (based on my unwritten style guide).

As a method I'd prefer something like get_contour()

I'm not a fan of the long name but two names might be the way to go. Alternatively, given the complexity involved with orientation it might be better to move all this info into a contour class which then exposes different variations (vulva, non-vulva, merged, merged without redundancies, x, y, etc.)


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2176 of 2200 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.91%25-yellow.svg)


@fadeev2010 thank you. We ran into an issue with that as well. Found it was an issue with Chef 11 vs Chef 12.


...now, what may make this needlessly confusing is that it leaves the other `g->io_valid=true` in place, despite its redundancy. Taking that out while adopting to the other review feedback.


This is a great example of a time when merging instead of rebasing your local branch messes up the repo history.


Don't mean to rain on the parade but aren't all WebRTC connections encrypted by default?

http://www.html5rocks.com/en/tutorials/webrtc/datachannels/#is-it-safe


I don't like the idea of releasing the CComPtr out of the function because it can be easily forgotten. :/

I agree that passing CComPtr object is generally useless but in those cases we pass a non-const reference and we actually want to modify it inside the function. It looks to me that we are not looking into passing a COM pointer but rather the whole wrapper to ensure consistency.


Ahh. Had to reread -- the issue was failing to zero the bps values. Yup, that's valid.


@mdo we can actually do this another way https://github.com/primer/primer/commit/244a73254b8ea44c8d83bd86deea12e30056a434


DesignDaysGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.17%25-red.svg)


If you're not cool with this let me know and I'll revert.


Compatibility is quite high, since Berker only renamed the module.   You should clone astor, and then put your codegen.py into astor/code_gen.py (with the underscore), and then you can reuse our testsuite.

Then you can run the unittest for codegen, where you will probably find a few things you don't care about (that are related to our desired structure for the output code), but will also find things like "from .. import something" doesn't work, and neither does:

<pre>
def foo():
    bar((yield x))
</pre>

Finally, if you run:

   python -m astor.rtrip

it will round-trip the standard library to the AST and back, and then back to the AST, and double-check the two ASTs.  Depending on how much third party stuff you have put into your python library, you may see literally hundreds of failures (I saw over 250 by doing this with your file on Python 2.7.)  rtrip will put correct and failing ASTs into a temp directory for you to examine.

Many of these are easy fixes, especially if you don't care about ugliness.  For example, you can always wrap yield in parentheses.  But there are other things like issues with the way 2.7 "optimized" unary negative numbers, and those interact with the precedence binding of ** to the left.

Good luck, and please don't hesitate to contribute any useful testcases back to astor!


Missing a d on the end of _use_ for line 5.


Question: would it be better for the generator to totally not copy the `README.md` file? It's one of the first things I would personally get rid of (it doesn't add any value for end users of the generator, right?)

@robdodson @addyosmani WDYT?


I will update the script :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.264](http://teamcity.monogame.net/viewLog.html?buildId=8220&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:20:48


Помимо большого куска кода вот это длиннющее название напрягает
`ОбработатьКомандыПакетногоРежимаПослеОбработкиФайлаОтчетаТестирования`
Лучше сократить. Например, `ПослеОбработкиФайлаОтчетаТестированияВПакетномРежиме` или  `Событие_ПослеОбработкиФайлаОтчетаТестированияВПакетномРежиме`


any particular reason to comment this out?  I know its unused but its here because its part of the provided "types and constants" of the fcgi spec


Thank god


What is the purpose of lines 75-77 in request.rb above?  Does the == operator not work [as documented](http://ruby-doc.org/core-2.2.0/Hash.html#method-i-3D-3D)?


1670-HeatPumpWaterHeater (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Do you want 'create' here?  Try running `FactoryGirl.create(:user_with_post_and_comment)` and `FactoryGirl.build(:user_with_post_and_comment)` and see what happens with your current code.

Also please fix the indentation.


there isn't, it's legacy at this point. i havent been using ansible recently so I haven't had time to remove it. feel free to do so!


90210372-New-chiller-electric-eir-still-delivering-chilled-water-#4453 (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1655 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Query not needed since the final extract is being done in python.


This commit introduced a regression:
https://issues.dlang.org/show_bug.cgi?id=14666


I spent all this time just using two divs to align them for 2 lines which worked until I realised some languages are reallllllllly long and take up 3 lines, all ma hard work.


:D


Numerical values for font-weight do not have units.


Scroll is not a valid value for the position attribute.


r+


Is there any documentation on how to use this plugin? i cant find anything related particularly to it and neither on how to replace the reboot command that was other on the last commit to ```github.com/packer-community/packer-windows-plugins/provisioner/restart```


Missing closing span tag.


应该是Usage而不是useage


I'm going to give you the grade based on what I saw in office hours. There are too many syntax errors in your current submission of index.js.


棒棒的


I find the mix of hex and ascii confusing here. Should we use all hex escapes (even if it's a printable character)?


@rijalul hindari (" ") petik dua dalam fungsi. Next commit betulkan.


r+ (you can ignore my comment if you disagree with me)


Nice, additions are counted by line. Should be useful later.


Should we put this stuff in a Changelog file? The README.md is going to get out of hand at some point.


Should wrap the functions that will be called when the page is fully loaded, not just a console log.


The event object is more advanced than what we've covered in class. It would be much easier to select the paragraph tags themselves.


When we write code we must strive to make it as readable as possible. One of the things that improves the readability of code is good naming of variables, functions, and classes.

In general, the larger the scope of variable, the more descriptive a name you'll want to pick, since you don't have much context to understand what the variable is supposed to do.

So, try to pick more descriptive names for ```res``` and ```ctx``` that tell you at a glance what their purpose is.

If you want more details on this, please read chapter 2 of the book I'll share with you on Telegram ("Clean Code")


Good point.


It's better to check for classes or attributes rather than the content of text.


right. I'm sure there's a better way to do this?


The parameter in the send method is named 'media_list'.  It'd be better to call the list created here 'media' (no 's', media is plural) then in the send it would be media_list=media.


@rdy, the code looks solid to me. I expect most if not all of the usages of cursor to not have to change right?


We could also just comment the respective lines when they are used earlier with the same comments instead of re-displaying the same code.


Missing semicolon.


You didn't use the starter code provided for the homework, and your implementation doesn't match what was expected for the assignment.


đọc xong đếch hiểu, sao fix đây =))) cái này phải xem mấy cổng của nó giao tiếp như nào đã.


You were required to use the hide() method available in jQuery.


90210372-New-chiller-electric-eir-still-delivering-chilled-water-#4453 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1145 of 1145 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


r+


ddf


The assignment specified to use after(:build).  "Because of the direction of associations, comments and posts have user IDs, not the other way around. Therefore, use an ```after(:build)```".  When I run ```FactoryGirl.create(:user_with_post_and_comment)``` and ```FactoryGirl.build(:user_with_post_and_comment)``` in my ```user_spec.rb``` my tests still pass.


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/5f22da3a65bcfe42652e76df6d590acaff6dc5d7


merging basho/riak_cs/bugfix/missing-syslog-items-in-config-schema = 5f22da3a into borshop-integration-1162-bugfix/missing-syslog-items-in-config-schema


basho/riak_cs/bugfix/missing-syslog-items-in-config-schema = 5f22da3a merged ok, testing candidate = 5f6caea6


I know, I looked at it a bit and couldn't figure it out. I think it's because `entry` is not a regular object. It's returned from badgekit-api-client, and you can't seem to be able to delete keys from it.

We could install a debugger and find out what `entry` is, but I didn't get that far.


All the following lines should be indented a level to match the console log on line 4.


Yup, either right before or right after.


I see this has already been changed to media_list, which is good, so I won't comment on it throughout the text.


I'm of the opinion that we should be using wWinMain, since, in Windows, `__argv` is ansi. But I guess that can be addressed in another PR.


We should probably hide the read more text first, then slide the content down, and then show the read less text to take into account user experience. You can wait for the animations to finish by passing the next function in as a callback. Take a look at: http://api.jquery.com/slidedown/ , noting the [complete] argument.


@anyiwang0726 Try to catch up with you


Wouldn't adding these to a gitignore be wise, for the future?


The $.ready() handler isn't being used correctly.


This is actually meant to be part of the design / aesthetic hehe :) Playing with optiosn.


Just checked the blame and the comment comes from 2010 and was associated with a line of code that doesn't even exist anymore.  Looks like I may have forgotten to remove it when I revamped the spacing code.  I'll get rid of it in the morning.


r+


rax retry tests


It looks like you didn't use the starter code provided for the assignment.


maybe now text should default to None too.  we should be able to use send and only specify a media value and not a text value.


same as for send, default text to None


Good.


same as below, default text to None.


Missing semicolon.


It's not *rays* - it's a lion mouth at the beginning of the level.


You should use better names for your IDs.


Also, use better names for your functions.


Why the revert, especially when you just pulled it?


90210372-New-chiller-electric-eir-still-delivering-chilled-water-#4453 (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1655 of 1656 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


typo?


修复 #60


Sorry, I meant I currently call ```dropTableIfExistsCascade``` on anything regardless if it's Postgres or not. I meant to say that it would have been convenient at the DbDelete operator to be able to determine the underlying database so I can call either ```dropTableIfExistsCascade``` or ```dropTableIfExists```

I currently make the call at this line: https://github.com/uwescience/myria/blob/deleteTables/src/edu/washington/escience/myria/operator/DbDelete.java#L48


I don't want to say goodbye


How about an MMS test with no text?


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/1212


As far as I remember I was trying to get Jarvis to run on my fork, but it wasn't my intention to merge with my own master, so I reverted the merge.


Thank you for contribution

I got two questions, what's the point to get so many delegates, why not use delegateSplitter? If it's a good design, is it possible to integrate them into super class, not just facebook style definer.


I know.
I will rewrite this code later - I am tired and sleepy now. I commited these changes just in case @webnull may check this code and give any nice tips...


So true :)


that's neat!


isn't this bad due to it affecting what is in the register?

also, add a test case :)

also, this is in the same pull request as the node-sass update?


flex 方式的兼容性给个 caniuse 的链接提示吧，这个理论上要兼容到 IE8 的。


rax retry tests


Take a peek at some modifications from the icon I made this weekend. Full Illustrator source is in the repo, feel free to tweak away.


Testing  comentario O_o


Can this be switched to using the API level instead (`Build.VERSION.SDK_INT`)? That way there wouldn't need to be an update to the HockeySDK for every new preview build of the Android OS


Did you write a map-reduce routine already?  Awesome!


Spend some more time figuring out what's needed to make this work and when you have it complete the implementation and send me the pull request again.


He realizado un cambio en  este archivo


What was this code supposed to do?


And all git plugin users should go and check my changes! God mode! I
suggest you to revert your changes because of the broken BACKWARD
COMPATIBILITY!

On Wed, Jun 10, 2015, 00:13 osmancrush <notifications@github.com> wrote:

> You broke my ggpush! Ok you added a function for ggp, I chill for now.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/robbyrussell/oh-my-zsh/commit/5b75cc7880de1931a0507800d90eb77ed659fa46#commitcomment-11598592>
> .
>


@diego-d5000 Can you add Violeta (@viomac) to the project so she can give you some feedback on the things she's researching regarding the UI on Android?


Thank you for this! Do not forget to remove `interp` in favour of `interp2` from `pracma`. In that way we will not need to use the `akima` package.


use RedisConnConnectTimeout and others in newRedisConn?

I think all the redis functions here are use the same timeout.


You know, I wonder if it has something to do with phantomjs?


Yay for MonadPlus! :+1:


:+1: nice


I think change JpaRepository to CrudRepositoy is not sense.
JpaRepository extends CrudRepository.
we need sorting and pageing.


can we please name this `digitalWriteFast()`? :) :) :)


If you're going to do that just do `self.assertTrue(string in logdata)` without the try/except then


Should be NAPALM_SPRAYER instead of NAPALM_SRAYER in 2 places.


alternately we could maybe have a `digitalWrite(D7, HIGH, FAST);`?


I can think of a couple of alternatives:

* Don't use `CASCADE` at all. The user would be responsible for ensuring that all relations are dropped in the proper order to avoid referential integrity violations (or we could disable referential integrity enforcement when dropping the table, but that might be a pain).
* Add a "best effort" parameter to `dropTableIfExistsCascade` so we log a warning for databases that don't support `CASCADE` if it is set, otherwise throw an exception.

If it's acceptable to fall back to non-`CASCADE` behavior, then I think we have to ask why it's necessary in the first place.


k that works but when the client goes to reset there key on the client side it says order id not passed and this is whats in the error log

[10-Jun-2015 02:44:58 UTC] Order id not passed 9999
[10-Jun-2015 02:45:05 UTC] Invalid request. Make sure request origin is http://www.boxbilling.com/
[10-Jun-2015 02:45:05 UTC] Error executing massmailer queue: Admin is not logged in
 which i dont know what it says 9999 cause thats not the order id


Not sure if that will slow it down, but me thinks it might.  Still need to test that theses inline functions are really as fast as macros.  Should be an easy test :)

I like the `digitalWriteFast()` because it's super natural to type and will eventually pop up in our IDE's intelligent code completion engine :smile_cat:


rax retry tests


I don't think that does what you want it to.


Where does extra_info data from? I cannot find extra_info in other source code.


improve function name


use constant


Thinking more about this, I really think `bitstype Char{E<:Encoding} 32` would be the right way to go. It's a single, simple definition that leverages parametric types and corresponds simply with the new `String{E}` definition. The question on size I think would not end up being that significant; how often are you really dealing with anything memory-constrained with collections of individual characters (as opposed to actual strings)? And in terms of calculations, it may actually be more performance to have a single, 32-bit Char value since it's extremely predictable, allows better interop between inter-encoded Chars. It'd be interesting to see if there are cases where it would really make that much of a difference, but my guess is probably not.


Please don't do that. If you need to ping travis, just do an empty commit --amend on your last commit and push again.


マージ後に修正しました https://github.com/jser/jser.github.io/commit/126b5ab256e557241ab636db7e8d196d693b11e7


Please squash this into the relevant commits.


This previously caused a segfault when -index > buf_len


nice!


@myappleguy  thank you :+1:


I'll try it.


you should also add the remaining PIDs for the remaining modes:
http://forums.yuplaygod.com/threads/official-yuphoria-windows-drivers-pack-drivers-for-adb-fastboot.15025/#post-170271


same question here about commenting these out. Also i just noticed now these are wrong, according to the spec the value is FCGI_MPXS_CONNS and such. Overall since they arn't used i would probably be ok removing them, but either fix or remove not just commenting out the code.


This is just formatting tabbing and spaces for a number of files


I'm uncertain about this since I find the previous solution easier to read and understand. I usually try to avoid using lambdas for that reason and I don't see a benefit here other than slightly 'compressed' code.

Then again this is such an easy use case that it's probably okay...

so basically ack if you wish to use the lambda


intentional, as the comment says after it, it's ok to fail here. it just means no hashing


Yeah, I agree. There has been more hardcoding that was removed than what crept back in but this sure is asking for trouble. It originated in src.git, as a sibling to FreeBSD.conf and then moved a few hops without giving it any more thought.

I've been thinking back and forth, I do hate softcoding in this case as there is only ever going to be one single configuration and it'll get harder to track and trace eventually, so my question would be if changing this to "origin.conf" would be acceptable? :)


Avoid unused parameters such as '$queue'.


Avoid unused parameters such as '$name'.


Avoid unused parameters such as '$arguments'.


PHPCS: Whitespace found at end of line


PHPCS: Expected 1 newline at end of file; 0 found


Class Event does not have a Docblock comment.


@ScottPJones, what is a `Binary` encoding? Just raw bytes?


What are the `OE` versions of these encodings?


this is the new master


There are many things that aren't need at all in that repo and are heavy weight. I'd rather get raw files from the repo at a specific commit for each thing we use.


there's a fix for this bug, but it degrades performance

@@ -48,14 +48,14 @@ func (h maxFloat64Heap) Less(i, j int) bool { return h.float64Heap[i].f > h.floa
 type MovingMedian struct {
        idx     int
        nelts   int
-       queue   []elt
+       queue   []*elt
        maxHeap maxFloat64Heap
        minHeap minFloat64Heap
 }

 func NewMovingMedian(size int) MovingMedian {
        m := MovingMedian{
-               queue:   make([]elt, size),
+               queue:   make([]*elt, size),
                maxHeap: maxFloat64Heap{},
                minHeap: minFloat64Heap{},
        }
@@ -68,7 +68,7 @@ func NewMovingMedian(size int) MovingMedian {
 func (m *MovingMedian) Push(v float64) {

        if m.nelts >= len(m.queue) {
-               old := &m.queue[m.idx]
+               old := m.queue[m.idx]

                if len(m.queue) == 1 || old.f > m.minHeap.float64Heap[0].f {
                        heap.Remove(&m.minHeap, old.idx)
@@ -77,8 +77,8 @@ func (m *MovingMedian) Push(v float64) {
                }
        }

-       m.queue[m.idx] = elt{f: v}
-       e := &m.queue[m.idx]
+       m.queue[m.idx] = &elt{f: v}
+       e := m.queue[m.idx]

        m.nelts++
        m.idx++

benchmark                              old ns/op     new ns/op     delta
Benchmark_10values_windowsize1         961           1415          +47.24%
Benchmark_100values_windowsize10       15123         23641         +56.32%
Benchmark_10Kvalues_windowsize100      1834993       2939018       +60.17%
Benchmark_10Kvalues_windowsize1000     2021869       3573781       +76.76%


alphabetical


Fix to get the course id correctly


Mostly formatting tabbing and spaces


origin.conf would be fine. Could we instruct the build scripts to softlink origin.conf to ${CONFIG_PKG}?


This should be camel case for consistency with the rest of the class


The parent is the base widget, which we know has no implementation here. What is this trying to support?


@TiGoldPrizrak You found a hidden message!


Softlink? I think CONFIG_PKG is origin.conf?


Removed this section of code to stop showing extra sidebar options


PHPCS: Whitespace found at end of line


* TODO: figure out how to get the events on another queue, this seems weird


Formatting to this file as well as one larger change lower down


This commit MUST be reverted as the same result will be possible by specifying the version in the root composer.json (the plugin has an branch-alias).
You should NEVER require development versions of packages by specifying the branch name but only using a version number and either allowing minimum-stability: dev or by specifying the dev version using "dev-develop as 1.2.3" in the root composer.json.


Really thanks for your contribution; will add it ASAP. I'm continuing our discussion in the forum.  Tito


This loop *must* be rewritten as Ed suggests.  The existing code is undefined behavior.  It is incrementing an invalidated iterator.  At the time of increment that iterator refers to deallocated memory which theoretically could already be re-allocated in another thread and contain absolutely anything.


removed this variable as it is not actually part of the system


To be completely sure I understand desired behavior:

- Add time to output unconditionally in a fixed format (ISO 8601?), by default in local time.
- Honor `--utc` to emit time in UTC.

Accurate?


might as well prefer positive conditionals as long as this is being changed.  Just keeps things easier to read.


softlink meaning `ln -s ${CONFIG_PKG} /usr/local/etc/origin.conf`

CONFIG_PKG in HardenedBSD's configs is set to /usr/local/etc/HardenedBSD.conf: https://github.com/HardenedBSD/opnsense-data/blob/master/generic.conf#L20


slight change to line up better


Why you don't look at version number?


change for better formatting on the number of likes


I believe that since this commit, paradox is not asking me if I want to install the packages asynchronously even though I have that var set to default value of `'ask`.


DesignDaysGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


added to fix size of text when using a different theme


Nahuel estoy recibiendo yo todos los commits que le haces a edu, entiendo
que son destinados a el.

Saludos

On Wed, Jun 10, 2015 at 9:12 AM, nahuelsotelo <notifications@github.com>
wrote:

> Y esta propiedad? Qué esperabas conseguir? <content>tiene otra función,
> agregar contenido por CSS
>
> https://developer.mozilla.org/es/docs/Web/CSS/content
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eurdanga/awesome-travels/commit/96a04df0d60e3bed752d8869ed5dbb6a69f30ef0#commitcomment-11604625>
> .
>

--
Christian Montané Götzenberger
// (+34) 635275431


Fixes https://github.com/rubberduck-vba/Rubberduck/issues/598


Avoid unused parameters such as '$queue'.


Avoid unused parameters such as '$name'.


Avoid unused parameters such as '$arguments'.


formatting below


* TODO: figure out how to get the events on another queue, this seems weird


How about `--build-{o,ji,bc}`? The `build` part always struck me as quite clear and `--output` is a bit generic.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/13243/testReport/) for this commit**


These don't need conditionals?


moved from php coded styling


IMO not having a lambda here is a lot of boilerplate so I'm in favor of this change


I checked in my rshell as well and the history command does not work. I have looked online on how to use history with execvp and a lot of the people commenting on the questions say you cannot do it. They say that history is like cd and you have to implement your own version of it when it is used with execvp.


I think this should keep the @ on socket_write,  the errors will be reported properly via the exception below and should not spam up log files with stderr output here.


Doesn't this logic need to exist in `_setOptions()` in case you're changing both at the same time?


Are you referring to the `README.md` from PSK? There are useful things in that readme which explain which gulp commands to use and if https://github.com/PolymerElements/polymer-starter-kit/pull/151 lands, how to opt-in/out of service worker


Modified to properly show text centered in the box


I'd just always use /usr/local/etc/pkg/repos/origin.conf consistently? That is one of the variables in the build system that should not be overridden because they go cross-repo. They are variables to avoid hardcoding across build scripts really.


`=+` ?  wouldn't it just be `=`


> It looks to me that we are not looking into passing a COM pointer but rather the whole wrapper to ensure consistency.

We can put CComPtr into a struct and struct into std::unique_ptr. We can put a raw com pointer into std::unique_ptr with custom deleter that calls Release(). But that looks like classic over-engineering to me.

> I don't like the idea of releasing the CComPtr out of the function because it can be easily forgotten.

That is just how you work with COM pointers. They are shared pointers by nature, you can do nothing about it, and you _have_ to know that before working with them.


Those steps are for fixing the files and committing them to the repo. I just want to be able to clone libgit2 and  checkout a specific tag. As it stands now, I cannot do that. Are you suggesting I go through the steps described on that help page and commit a change? I'm happy to do that, but you seem to think I've configured my system incorrectly, so that's probably not what you were thinking.

I'm guessing here, but I suspect the winhttp.def file was not originally normalized and is stored in git with CRLFs. Now that the gitattributes is converting every file to text, the file checked out (with CRLFs) differs from what Git _would_ commit with normalization turned on (LF only).

As I mentioned, I tried setting core.eol, core.autocrlf, and core.safecrlf to different values, but nothing helped. I think this is something that needs to be fixed in the repo, not my config settings.


cool, glad could help you :-)


Drop the quotes.


Hrmm, okay. Why have a ${CONFIG_PKG} variable at all, then? Should it just go away?


any particular reason for using a random number, rather than a counter?  A counter seems more straight forward and would not require repeatedly generating numbers when large numbers of requests are in flight (although i doubt many users would such a large number of requests in parallel through this).


Not sure what the problem here was, but I'd rather ask for getRemoteAddress() != null and else return null here (if null is a valid result). Translating NPE to UnknownHostException might get confusing for calling code.


same with the camelCasing method names, for consistency with the rest of the class


It's time for me to sleep. It's 2 AM where I live. Will be glad to further help you with this mod :)


and that's exactly what numeric is doing for us. days and months are always two digit, hours in numeric are two or one digit depending on the locale.


should probably just remove this code rather than leaving it commented out


Seems like this and the previous conditional should be combined into an if/else.


@nlfiedler which Git client are you using on what platform?

You assumption may very well be correct, but I think we need some more information to start digging and helping you out here.


Is it? The way it's currently written, the function `return`s immediately after the iterator is invalidated, so it's no longer referenced. My suggestion is only necessary if we want to _continue_ the loop.


> Note that if you have patches, you should probably push them even if they are not ready so that we don't work on the same thing.

Like I said I don't have much time, but atm I have this three fairly small patches.
https://github.com/kasper93/mpc-hc/commit/ab74c16cdf0f08787d60a7ed5246c75c2f8f99ab
https://github.com/kasper93/mpc-hc/commit/f0041461d6069a5818f34942e949b32bdd01c960
https://github.com/kasper93/mpc-hc/commit/103ecc8b95334fdb668e33c066fa528ca666f866


Mac OS X, Git 2.4.3 command line. If you want, I'll file a bug and fix it for you.


I posted this a long time ago no worries I figured it out
On Jun 9, 2015 6:10 AM, "NileshRamani" <notifications@github.com> wrote:

> Can you please elaborate your requirement, so I can help to get output as
> you want.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NileshRamani/IframeShortcode/commit/897a93782dddd23a9c20b2e0eb860d9ac099e432#commitcomment-11584862>
> .
>


maybe rename a to target ?


LGTM


why not simply

    return !`FileReadingMode.lines.equals(this.fileReadingmode)) && this.withMarkers

??

Who cares if they say `--withMarkers=false` with some other mode? We only need to test they don't provide `true` with another mode.


Line 204 seems to cause quite some slowdown here.
I'm not sure what causes the actual slowdown (perhaps it's the terminal busy printing a lot, somehow dragging down the program performance), but as I commented out line 204, an -O2 build speed up from (checked files were precached before both runs) 7.931s to 0.118s .
Testcase was kernel git repo which has a lot of small files/files that are smaller than blocksize.

Perhaps one could introduce some --verbose flag which explicitly enables the "Skipping too small file" message and otherwise skip it?


sic, camelCase


wrrr!


Maybe, but on the other hand, personally if I begin a new project I pretty much always start with writing a readme for the project itself. Would be a little strange if people are going to keep a readme explaining what PSK is in their personal projects.


space after brace.


Sorry, that's Ubuntu Linux 14.04 with Git 2.4.1 (mixed up my dev machine with the VM that I'm testing on).


any reason to use trigger_error here rather than an exception?


This may or may not have been a typo...but did you happen to mean `shift key` or do you just really dislike the shift key?


My personal opinion is to keep code lean and self-documenting.  By declaring a constant, you're implicitly telling the coder that the constant has some function in the defined class or namespace.  Within the FCGI spec it totally does, but in this limited implementation I didn't feel it was appropriate to leave defined.  Certainly not a necessary change -- just making things explicit.


I think you should remove this change from the PR.


Can you invert all of this so the error/early exit cases are at the top and there's little/no nesting?


Insert a blank line before this.


Thanks!
@solnic, IMHO this should be merged *before* the next 2 PRs (they reload `group`)


When I eval the below,

```el
(let ((paradox-execute-asynchronously 'ask)
      noquery)
  (pcase paradox-execute-asynchronously
    (nil nil)
    ('ask
     (if noquery nil
       (y-or-n-p "Execute in the background (see `paradox-execute-asynchronously')? ")))
    (_ t)))
```

I get

```
Redundant pcase pattern: (quote ask)
Redundant pcase pattern: _
let: Attempt to set a constant symbol: nil
```
Probably I shouldn't use that `nil` case in a `pcase` in `let` (never used `pcase`). But if I remove that nil condition, the `y-or-n-p` gets executed as expected.


why remove this method?


Invert the conditional.


God I already fixed one, missed this one ... :hear_no_evil:


Ok, we will see how things go then.


Another good note for sure.  I leave comments in certain classes in case they're needed for future use cases.  Not necessary -- be happy to remove.


should remove code rather than commenting it out


Yep, totally.


Use call, since you don't already have an array to work with.


Agreed.


So far in the app I'm building with PSK I've referred back to the readme a few times for different items. When my project reaches a state where I think it's ready I would probably replace the PSK readme. I'd prefer to leave it for now.


@var string


You shouldn't have to do this pre-build, only post. right @retailcoder?


@var Integer


reack


To be consistent with the other classes, these should be capitalized full names (Integer)


This needs to be conditional. I don't know how it keeps getting wiped out, but it should only run regasm for Debug64 IIRC. I'm pretty sure this will blow things up for me in 32x.


Lines 137 and 169 should use single quotes -- adding a single `char` to `string` is easier than than adding a `const char *`, even when the latter is 1-character long:

    result += '%';


The mental capacity to realize this is directly tied to the first conditional is way too high.


Yes, the pcase documentation is not the best it could be. That should be a `'nil`, which I've fixed now.
Thanks for reporting.


This commit is a lie!


Opposite Endian.
Much of the time it's more important to know if something is native-endian vs. opposite-endian, rather than big- vs. little.
(For *comparisons*, big- vs. little- are very important, because you can use `memcmp` directly on a big-endian string,
but you can't on a little-endian string (and to compare them correctly [except for ==], you need to pick up the 2 or 4 bytes (swapped or not), and then compare as 2 or 4 byte unsigned integers).


If you've got a fix, that's great.  (There's no need for a separate issue and pull request though - just opening a PR is enough!)

Thanks!


I dont think you need this one :P


is this code reachable?  This will only happen when $this->resp === null per above


I agree with your point that logs should remain clean.  I think error suppression should be decided by the coder, not library implementation, i.e.
```php
try {
  @$fcgi->request(...);
} catch (Exception $e) { /* handle */ }
```
Error suppression causes (admittedly tiny) delays and should be reported based on the system's configuration.  The library should not make that decision for you.


Unfortunately this is the only way I can get Qt to scroll to the right place :-(

I will validate the row number before using it, however.  Good pick up.


I see a possible name conflict here. I think something like "github-http" is a better value.


Yes we'll always happily take a bug fix! :ballot_box_with_check:


This is not accurate here, because there are sources, but all of them are .java files. If possible, please change this to indicate that there are no .kt files, e.g. `No Kotlin source files found`


Uhh oops 😅


I see a possible name conflict here. I think something like "github-tarball" is a better value.


Anyway, can I look at the crashes at drdump.com? I've created an account there - alex.marsev@gmail.com


Well they do have rvalue reference overloads to swap the content so it seems like using std::move on them was expected and it's basically what we would like to do.

Anyway, if you really think it's not how it should be, fair enough. The classic way to transfer ownership would be to use Detach() when calling MoveTo and Attach() inside the function I guess. That's even more scary though so I would just go the with renaming and releasing the pointer just after the call.


Thanks for working up this patch, i've made a number of inline comments about keeping things consistent with the existing codebase, and a couple questions I have.  I had always intended to make this handle multiple requests in flight but havn't had a use case for it yet.


@alexmarsev: Done.


This indexing reverses the order of elementsRight, which is populated from leftToRight in the order above. It should be the last item rather than the first which is matched against List:get(X,-1).


> Done.

Thanks.


Just some context here: This operator acts as a boolean operator (as opposed to bitwise), but is non-short-circuiting. That's fine here, but just for reasons of code convention we should change it to &&.


Oh whoops! I've been working on another solution to this... basically, a refactoring that doesn't require `PreserveValue` but still passes the assertion. Sorry about that...!


infer is not a clear name for this. It seems to have something to do adding an element wrapper to multiplicity * cells?


@kasper93: What about my other patch? Will you have time to look at it today?


GitHub tricked me, it showed 62% swift


Is this really mean to go over body rather than k? If so, hoist the computation out of the traversal (but that seems to disagree with the ordering later on).


That's okay, this only took a few minutes.


There is one here:
https://github.com/jieter/ti1806-computer-graphics/blob/master/src/Vec3D.h#L185-L190


Sublime text annoyingly indents curly braces when doing if/else in Scala when its not supposed to. But there is a way around that: http://stackoverflow.com/questions/29158509/scala-sublime-text-3-stop-closing-curly-brace-from-jumping-when-followed-by-t/29196670#29196670


I was fishing for a comment.  I'd like to be able to detect/handle problems like this, just didn't have time to implement.


oops, replied in the main thread.  Please see https://github.com/openshift/origin/pull/2868#issuecomment-110901639


Oh!  You are right.  I completely overlooked that `return`.  Nevermind! :-)


Yeah, just kill that, that was just to get it registered on my system.


So is there any way of knowing the base address of a game at runtime? It could be accessed at runtime inside the if like gregory said.


:+1: but let's add a test to document it.

Something like this should work.

        [TestMethod]
        public void MergeViewIsNotShownWhenLocal_IsNull()
        {
            //arrange
            _view.SetupProperty(v => v.Local); //no default value, so v.Local is null

            //act
            _view.Raise(v => v.Merge += null, new EventArgs());

            //assert
            _mergeView.Verify(m => m.Show(), Times.Never);
        }


Maybe `coerceToBoolean`? `coerceToPredicate` sounds a bit like something that should return a function


@UnitedMarsupials Thanks for the suggestion; let's sweep these all up in #195.  Would you like to submit a pull request for this?


This needs to be rewritten


This creates a null pointer exception when you click on gallery and then press the back button. I'll move the code within the try-catch this way only on RESULT_OK these lines execute.


OK, adding test.


Thanks, this looks very good.

I did notice that the return value of append_allotted is ignored.  Probably makes most sense to (a) have it return a bool, and (b) exit with error on false (since we either passed bad args or ran out of memory - continuing is unsafe)


These setters are weird. In Python you generally don't need `set/get` methods, since you can always set/get instance variables directly. But stranger than that, you're creating setters whose only purpose is to set a variable to an already-defined class variable, and not taking a value to set them.


Okay, the problem reproduces with newer versions of Git on Linux and FreeBSD, but not on Mac, and not on Linux with an older client (1.9.1). I have my work around for this one system so I'm going to ignore this for now. Maybe someone else will encounter the same issue and go through the steps mentioned above to fix it.

Thanks for your time.


If you're ever in need of an interesting mathematical puzzle, I shall
provide.

On Wed, Jun 10, 2015 at 12:47 PM jacob14916 <notifications@github.com>
wrote:

> Hi,
> I am currently at MOP (the Math Olympiad Program) at CMU. After being
> unable to find the solution, I looked up the problem. In mathematical terms
> it is known as the domatic coloring on a hypercube. I found a paper with
> the solution but did not read it. If you think now is long enough to have
> worked on it, you could email me your solution or I could read the paper.
> This was a very interesting problem and I will probably regret not solving
> it on my own. I guess I still have a few hours.
> Thanks,
> Jacob
> P.s. I will probably not be rejoining Robotics next year, but if you ever
> find/come up with more interesting problems please send them along.
> Jacob,
>
> If you are interested in the solution to the prisoners puzzle, I will be at
> the FRC room today at 3pm sharp for the last time this year(session). I
> have been wanting to share it and see what you think.
>
> Ciao Mike
>
> —
> Reply to this email directly or view it on GitHub
> <
> https://github.com/Team3128/frc-java-3128/commit/c0a9c6d7bf861f1c1e91a5dabb8d49a729c611d5#commitcomment-11616787
> >
> .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Team3128/frc-java-3128/commit/c0a9c6d7bf861f1c1e91a5dabb8d49a729c611d5#commitcomment-11619656>
> .
>


Not really. I don't want to extend plugin api for this kind of hack.


Appreciate any other trivial cleanups, e.g., map.insert instead of operator[], string handling, etc.!


I did have a good reason for replicating this functionality from another class.... can't remember now.  I agree a counter is more straightforward.  Regardless of counter-vs-rand, I should check isset() because this class is intended to run forever there's a (infinitesimally small) chance we'll see duplicates.


It's unnecessary to scale bitmap at this point. You can scale before insertion.


Again, fishing for comment.


That's (closer to) what we do in trunk. This has fewer changes to the code. I just transitioned the NPE into an exception that was clearly handled already.


I'm probably only going to have stylistic comments.. When using `map`, I'd prefer the parameter of the anonymous function be on the same line, with spaces around the curly brace. e.g.
```
Book.read(id).map { book =>
    Ok(Json.toJson(book))
} getOrElse {
    NotFound
}
```


This seems to order the _in_ conditions before any other lookup. Shouldn't _in_ also be used to translate map entries whose variables can all be fixed by other lookups?


lazy me


When it becomes the last line, we can just use `airasia.fares + mas.fares + malindo.fares + firefly.fares` (without the `output`).

It'd be great if you update this one so that I can merge this pull request.


oh, right, I forgot that I removed it, my bad. I'll add it back


You are right, it's not handled properly. Will fix it.

Anyway, I think that `default_value` should not be able to be a Closure, because there is no need for it. I added Closure possibility for `value` because model sometimes can contain values that needs to be modified before they are sent to view. `default_value` should contain proper format of the value, thus Closure is not needed.


You don't need the `updateVals()` method if you're always just going to be returning the current length of numVibhagas.


Usually a mnemonic is a letter in the word it's used on. I don't see an L inside "Show stepper" :stuck_out_tongue:


I'll modify this according to comment i wrote above.


Phew!


nah, but it was part of the set.


Great, I noticed it on Sunday before demo, didn't have a chance to have a look at that part of the code=)


This is a run-loop.  An exception would stop the run-loop and drop execution back to the coder's try/catch block.  Personal preference-- let the run loop attempt to be deterministic instead of throwing exception for every issue.  Also, this seems like a low-priority issue, so I didn't think it would ever be worth an exception.


Honestly... not especially.  Just didn't know why we should ever cast to string.


Can we still refactor this to have a common base class for both `InputBinding` and `OutputBinding`? That way, `OutputBinding` doesn't need to extend from `InputBinding`. Something similar to what I have addressed here: https://github.com/spring-projects/spring-bus/pull/3


We do need to check whether or not the book creation was successful since `Book.create` returns `Option[Book]`:

```
Book.create(book).map { book =>
    Ok(Json.toJson(book))
} getOrElse {
    InternalServerError
}
```


You could also use `writeNullable[Long]`


Indeed it is


Maybe not for this branch, but I think this should probably use the styling system.


:+1: Pending Travis passing. Log looks MUCH nicer now.

Although I did notice this in the Travis log (although unrelated to this PR):

```
$ npm ls --depth 0 | sed -e ':a' -e 'N' -e '$!ba' -e 's/\n/ /g'
npm ERR! extraneous: grunt-contrib-imagemin@0.9.2 /home/travis/build/mozilla/fxa-content-server/node_modules/grunt-contrib-imagemin
```

Do we need to flush a Travis module cache or is there something else funky happening here?


You should really be working on an updated version of the cantus website, since a lot of things have probably changed, especially on the front-end. (This branch is > 300 commits behind develop). You should merge develop into your static-website branch ASAP.


Yeah it's probably just because we're printing so much tot he terminal in your case. We can just change it to vprintf so it only gets printed when we have verbose turned on.


lgtm


Indeed it is!


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/2120


Minor nit: you switched to single quotes here, while all other errors use double quotes.


I think you are wrong here...the intent has a certain capacity limit when you are sending some data with it to a different activity. If you don't scale it the app might crash. Try it=)


Whoops. Can you PR this back to us?


> I would move it before the $locations = get_nav_menu_locations(); line since the Customizer doesn't register new nav menus. A comment should be added too.

Done in bd83747


Say I need a variable to use in a assert, what is the simplest and cleanest way to have the variable only defined for debug builds so that we don't have a warning about a variable being unused for release builds?


Okay, fixed in #3207


Hi! That's a very good comment... but the problem is I haven't decided yet what quit should do...


Hehe.  Five lines of docs for one of code.


I guess you're going to witness my code reviewing in full force, style wise. When we can't fit chained methods onto one line, we should indent each.

```
SQL("DELETE FROM `books` WHERE `id` = {id}")
    .on("id" -> id)
    .executeUpdate() > 0
```


Isn't this also making sure that when used from e.g. Python that gst_init() is automagically called when using the bindings?


Sorry, but I'm leaving for vacation tomorrow and will have no time until July... You are right though regarding there being a need for a lot of trivial clean-ups -- I noticed the `string` to `char *` (and back) conversions all over...