There are two methods
fireRequestWithHttpBasicAuth() and
fireRequestWithPersistentAuth()
Only one of them called and both of them checks for connection problem.


I was referring to me restoring the html folder in my local branch fixed the compile errors I didn't fix it here. and yes the exe file is in the html folder.


ahh, okay cool!
yeah.. this is my first exposure to MVC.. so..... lol

and that makes sense, grep is my friend =]

                  Christopher Chan

On Wed, Jun 24, 2015 at 7:06 PM, jonyen <notifications@github.com> wrote:

> Well, it depends on your setup. I like to just do everything in the
> terminal and use vim, so I typically go to ./app/views and then do "grep -r
> 'username' *" to find out which files would be relevant. But if you use an
> IDE, you would just search for that. To be safe, you can go up one level
> and search under "./app".
>
> You would want to have a good understanding of how MVC works, and most of
> the changes would have to be in ./app/views, since nothing really needs to
> be modified in the controller or the model.
>
> On Wed, Jun 24, 2015 at 7:00 PM, Chris Chan <notifications@github.com>
> wrote:
>
>
> > is there a trick to figuring out which files are related to which?
> > i've been manually crawling through them and looking at the webserver
> > output trying to find which pages are called when
> >
> > or is it just famililarity with MVC frameworks?
> >
> > Christopher Chan
> >
> > On Wed, Jun 24, 2015 at 5:42 PM, jonyen <notifications@github.com>
> wrote:
> >
> > > I made some other changes myself, but you'll want to edit these files
> as
> > > well:
> > >
> > > app/views/devise/registrations/edit.html.erb
> > > app/views/devise/registrations/new.html.erb
> > > app/views/home/index.html.erb
> > > app/views/layouts/_user_widget.html.erb
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/basketbaseb/bible-fitbit/commit/2e1f6b0b9696368ad8dc66037b2271353995a9e9#commitcomment-11851123
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/basketbaseb/bible-fitbit/commit/2e1f6b0b9696368ad8dc66037b2271353995a9e9#commitcomment-11851818
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/basketbaseb/bible-fitbit/commit/2e1f6b0b9696368ad8dc66037b2271353995a9e9#commitcomment-11851867>
> .
>


But I did;
https://github.com/norcams/himlar/blob/master/hieradata/common/roles/master.yaml


@Jan-E It's `RETURN_ZVAL(xyz, 1, 0)` instead of `RETURN_ZVAL_FAST(zv)`


String.format is more readable in my opinion; is a single var insertion so no that bad in this case so up to you.


Yup, I'm just trying to get it working in the console, it's converting "A" into an integer 0 so just have to fix that and then it should work. Then I'll try and add the next letters along..


For relative paths from the newStructure and oldStructure? Yeah, that crossed my mind as well. But, if we add `structure` as a part of a reference, one could use full `keyPath` on `reference.structure.cursor(keyPath)` a mouth full, and not a very clean API, tho.


{} x 2


I like how you provided an example of a Developer Shop, their website has some interesting inshgts about software development


@ceolin That'd be just for defines


Should this be defaulting to true?! It is in my case!
In fact, so are the `searchTextChange` and `selectedItemChange` parameters since they've been marked as optional!
I have to explicitly define the parameters, i.e.

``` html
<md-autocomplete
    md-search-text-change=""
    md-selected-item-change=""
    md-autofocus="false" ...>
```


{} x 2; you can combine both ifs into one using &&.


As this is a bugfix you should add a Test to the compiler, to prevent further changes to create the same bug again.


For whatever reason, this merge broke (well actually removed) the feature introduced in e0e5e8b0840fca8040386076acd39b207cf43c8b even if it does not appear in this diff.

We abso-fucking-ly need this feature. Please do your homework, fix your sh*t and learn to properly use git branches for god's sake.

Sorry for the strong language but I spent the afternoon chasing a bug in your ugly code. I'm a bit tired :/

On a side note : you may also not want to reveal your production server to the world and the fact that you commit there (You naughty boy!) on a master branch…

Well, too late…


mmm, probably i'm missing something but having next definition
```twig
system:
    default:
        query:
            list:
                latest_articles:
                    template: "AcmeBundle:query/list/latest_articles.html.twig"
                    match:
                        QueryType\Name: 'AcmeBundle:LatestContent'
                        QueryType\Parameters: {ContentType: "article"}
```
and following subrequest call
```twig
system:
    default:
        query:
            list:
                latest_articles:
                    template: "AcmeBundle:query/list/latest_articles.html.twig"
                    match:
                        QueryType\Name: 'AcmeBundle:LatestContent'
                        QueryType\Parameters: {ContentType: "article", "Limit": 10}
```
will the definition be matched here? asking that because it could be a bit tedious if you need to add different definitions and queries for different limits, couldn't it?


Awesome job on the new stylistic changes! The page looks much nicer, and I'm enjoying the new features.


In general, a Backbone constructor only takes one argument, which is used to populate the attributes of that object. So if you want to load a model with that product ID, you will need to merge it into the `payload` variable, either by setting it manually on that object (`payload.product = product`), or by passing in a new object constructed from both (this is generally preferable):

```
var model = new Review({
  a: payload.a,
  b: payload.b,
  product: product
});
```


how about XP gain from killing mobs in instance?


@m44rt3np44uw It broke the lists method for laravel 5.0


Moved to runtime.plugins_importer.
Also now works. Which is good. c:


If we check the base power thing already do we even need to exclude Status moves?


Command acknowledged


@eitanbanks, @vdauwera did we get to use read-error corrector at the end? I think this is deactivated by default,  the corresponding param is @Hidden, an never heard of anyone actually using it... afaik it would not be surprising if it crashes in empirical data or causes artifacts after so long without been put to real test.


@milipili Well, my willingness to do any more work on this issue is very low. Don knows about the patch and can apply it if he wants to.


should use etc conf?


@AbdullahAlger Try running the app and checking the `voted` class is added as you'd expect.


also forgot that we have `trap "kill $AGENT_PID" EXIT`, which is probably what fixes this; before sh couldn't run that trap because the Go binary replaced the process


How would I proceed to have some part of my goodie instant answer in italic or bold?

Is this css file where I can set that up or can I use something in the .json?


might be nice for `present` to be named something more expressive of what it represents, like `list_item` or something


True?


Looks good Menna! Do you mind sending a pull request to our group's main branch so these comments can be documented there? Tks!


Since you are touching this code, could you please create a define for the PAL_EXE_PID= and PAL_EXE_NAME= and use it both in the sizeof and the snprintf?


I'm not against this commit, but I would like to know under what circumstances, mArtist becomes null.


quite


you can use `each_with_index` here if you want to:
```
to_do.each_with_index do |list_item, index|
  puts time[index] + ' - ' + list_item
end
```


schemas cannot be nested.

What you probably need is to create a package `+utils` to host all your matlab utilities independently of datajoint.


Eh I already fixed it in f51110ff50a804089c7462324910b43c5166b323. Not only did I comb through that dir, I also braided it's hair.


But due to the convention of `swap` (as it is currently), you're treating `structure.current.getIn(path)` as 'root'.

This is my reasoning:

```js

const refSwapListener = function(newRoot, oldRoot, keyPath) {
    // ...
}

Cursor.from(structure.cursor(path), refSwapListener);

// same semantics as above
structure.reference(path).observe('swap', refSwapListener);
```

With this `swap` semantics, you no longer should care about `structure.current`.


Yes, it does! ;)


This is a not-safe operation. The wildcard will allow the addition of extra parameters, best is to keep using the "./" , see https://github.com/koalaman/shellcheck/wiki/SC2035


Command acknowledged


Does the while need to test for ! executor.isTerminated()?  isn't the test for isHubUp() sufficient ?

I would also wait for termination on executor (with a longer interval than 1s)  maybe 30s.


You removed the redundant #include <cstdint> but didn't get rid of the condition around this one. Need to remove this #ifdef and the #else section because CorsixTH won't compile with that condition now.


I think it might be another one of those fragmentation issues where the column doesn't match, and you end up with null results, but I have to see again.


if possible, it's also better to interpolate over concatenate, like so:
```
puts "#{time[index]} - #{present}"
```


this addresses issue #21


@clabface this stuff looks awesome. i left a few comments but no need to change anything if you don't want to. just so you can see other ways of doing stuff.


why not `.replace(/\s$/, '')` instead of `.split(/\s$/).join('');`


Hmm, this moves a line to the visible page, but it doesn't give any more information about the objective. Am I missing something? :)


It's not a big deal anyway, but it's always good to reason about it. mArtist is populated during the creation of the menu (in two places I think).


Thanks. I recall this working with the default stdenv, but I had other impurity related issues, which forced me to the new darwin pure stdenv.


@AbdullahAlger This test would pass if the profile page responded with an error. At the moment it only checks the URL is what you expect. Add some expectations to prove that the profile page is as you'd expect (see the expectations in the other `it` block in `profiles_spec.rb` for a hint).


That seems a tad extreme for a problem that can be worked-around & never bother you again.  My solution automatically gets out of your way the second you work around the core issue rather than making you go & set a config option that you'll probably forget about later on.


Why does clock.h need any of those includes?


that's right, i don't know how to force idea to deal with such constructions


This is already done in v4. See https://github.com/GrahamCampbell/Laravel-Throttle/commit/91b7c355c979ad2cb9ae85996f1858890f89235d.


well... everything generated by another Scala script :)


```
virtual Time GetTime() = 0;      // should be a const method
virtual void SetTime(Time) = 0;  // should be a const arg
```


@msoky Is that retail like? I can remember this was posible on retail but need to be sure.


Can't reproduce on my Ubuntu 14.04 LTS with:
```bash
git clone git@github.com:thestk/stk.git
cd stk/
autoconf
./configure
cd projects/examples/
make
./duplex
```
I suggest you open a PR on your own.


Basic doxygen should go in clock.h, where the class and interface are defined.  Each implementation can add it's details, and will inherit the basic documentation


I am thinking about similar macro for my libs, could you explain what is "__macroStyleF" for?


changes done


Somehow I was thinking that I needed to be very careful to only run `update_geom()` when the user clicked it.  Thanks for straightening this out.


no 12?


10, 12, io.js


I don't have any better suggestions, but this comment doesn't actually tell me anything...


It's 12 by default sam :p


I still see some files like `bs-Cyrl_BA` and `bs-Latn_BA`, which are still using `_`.  Use `.replace(/_/g, '-')` instead.


vaia puta mierda de cambio


No branch was specified. Please use "runtests branchname".


ha, that was me trying to reuse our work on that other pkg. good catch.


Glad that everyone is picking it :D


@ccx-testerbot runtests test-branch


this backgroundColor (left) should be background-color ;)


Command acknowledged


You need to expose what it originally was too in PlayerChatEvent for the unformatted message.


test comment


Testing this with Vagrant. Failure during `vagrant provision` led me here.

Line 3 above: Copy module fails because rsync is missing.

```
TASK: [openshift_examples | Copy openshift examples] **************************
failed: [master -> 127.0.0.1] => {"cmd": "rsync --delay-updates -F --compress --archive --rsh 'ssh -i /Users/dlbewley/.vagrant.d/insecure_private_key -S none -o StrictHostKeyChecking=no -o Port=2201' --out-format='<<CHANGED>>%i %n%L' \"/Users/dlbewley/src/openshift-ansible/playbooks/common/openshift-master/roles/openshift_examples/files/examples\" \"vagrant@127.0.0.1:/usr/share/openshift\"", "failed": true, "rc": 12}
msg: bash: rsync: command not found
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at /SourceCache/rsync/rsync-45/rsync/io.c(453) [sender=2.6.9]
```

Added

```
- name: get rsync
  yum: pkg=rsync
```

Then I get

```
TASK: [openshift_examples | Copy openshift examples] **************************
failed: [master -> 127.0.0.1] => {"cmd": "rsync --delay-updates -F --compress --archive --rsh 'ssh -i /Users/dlbewley/.vagrant.d/insecure_private_key -S none -o StrictHostKeyChecking=no -o Port=2201' --out-format='<<CHANGED>>%i %n%L' \"/Users/dlbewley/src/openshift-ansible/playbooks/common/openshift-master/roles/openshift_examples/files/examples\" \"vagrant@127.0.0.1:/usr/share/openshift\"", "failed": true, "rc": 12}
msg: rsync: mkdir "/usr/share/openshift" failed: Permission denied (13)
rsync error: error in file IO (code 11) at main.c(587) [Receiver=3.0.9]
rsync: connection unexpectedly closed (8 bytes received so far) [sender]
rsync error: error in rsync protocol data stream (code 12) at /SourceCache/rsync/rsync-45/rsync/io.c(453) [sender=2.6.9]
```


test


Next I try to follow homebrew recipe https://github.com/ros/homebrew-hydro/blob/master/gfortran.rb but it takes a while, because a few updated required me to compile clang and friends again.

Even gcc/gfortran itself is not the nicest package to iterate builds :/


I know it's still in testing stages, but i'm trying it out.


`locale-data` still exists to avoid extracting on every build (which could be expensive)


these are not deps, they should be devDeps.


Could you please add space after the "if" like you did at many other places?


Ok, me parece un buen cambio


In fact I used private and [privileged methods](https://gist.github.com/Integralist/8419151), and no real public ones (like `Paddle.prototype.sayhello = function() {...};`), because most of the public ones need access to the privates variables or functions.


`return value.replace(/_/g, '-');` to cover foo-bar-baz


Hey no fair. Can't add to my TODO list with your commit! :)


Awesome, thanks!

On Thu, Jun 25, 2015 at 12:25 PM, Jonathan <notifications@github.com> wrote:

> fcac892
> <https://github.com/rstudio/rsconnect/commit/fcac892a69817febd7b655b189bf57193260cda0>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstudio/rsconnect/commit/d0f2cac0e101cde24787eba7a3c0767ae08a6f0d#commitcomment-11864984>
> .
>


@jwilder -- very handy, I like it. Thanks for the reference.


PHPCS: Whitespace found at end of line


If anyone knows to to prevent this model change on modifier update please let me know.


Route::resource('groups', 'GroupController', $actions); // FIXME: Add destroy to groups


r+


indeed.  but remember that weewx.conf is a config file, typically best viewed using a fixed width font, so it should be treated like old-skool typewriter (two spaces after a period) instead of new-school html/whatever.


I'm not actually sure how resource defaults interact with an explicit undef -- should be easy enough to test.  However, I think if a user genuinely wants to configure a proxy for all repos they would be better off doing it via yum.conf instead of per yumrepo resource.


The dbf files from form102 does not contains the date, so me must add it.

On Thu, Jun 25, 2015 at 7:24 AM, Evgeny Pogrebnyak <notifications@github.com
> wrote:

> Looked at DBF, maybe you are right about
>
> rec_dict["YEAR"] = dt.year
> rec_dict["QUART"] = (dt.month - 1) // 3
>
> ... seems this data is not file itself, just the filename.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/epogrebnyak/cbr-db/commit/28efc7131239309e5a30116c5ac098fd0b233f70#commitcomment-11857888>
> .
>


`return value.replace(/_/g, '-');`


I think I just googled "how to compile gfortran on os x" or something like that. The thing is, I don't know what the pure stdenv changes...


It seems this added goto is not necessary


Думаю, что этот spec можно переместить в отдельную подпапку
```
spec/classes
```
и убрать
```ruby
type: model
```
так как на смом деле это не модель


Oh my bad. This commit was apparently not present and I was still using `synchronize` module. Changing to `copy` module fixed my problem. :+1:


972124-2NewDetailedIceStorage (RKStrand) - x86_64-MacOS-10.9-clang: OK (1667 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


saw approval from MonsieurNicolas
at https://github.com/jedmccaleb/stellar-core/commit/1bff9d1416f6f91d34225d60777bc707a2e1df7c


merging jedmccaleb/stellar-core/master = 1bff9d14 into auto


jedmccaleb/stellar-core/master = 1bff9d14 merged ok, testing candidate = a3210af0


ok.  i think the syntax is 'git pull --rebase'.  i'll try that next time.


Pues integralo


we should probably remove this entire topic from the file now that cldr is controlled via semver, and everyone should know how to handle that. I just don't want to have to come back to this file everytime pkg.json is changed.


PHPCS: Whitespace found at end of line


Given branch {0} is invalid. Please select a valid branch name.


@dlbewley Glad to hear it!


@adnelson Ok. I try to follow homebrew example and report back the results.

Darwin pure stdenv changes everything on OSX with nix, because it allows to use OSX sandboxing when building all the other packages, and with sandboxing they will only see the other nix packages.


Given branch test-branc is invalid. Please select a valid branch name.


@ccx-testerbot runtests test-branch


Given branch test-branch is invalid. Please select a valid branch name.


Command acknowledged


OK, I'll update it, then.


@ccx-testerbot runtests test-branc


rax retry tests


Would be great if setting `maxChildren` to `null` would disable this feature.  That way we don't have to optionally merge `maxChildren` as an option.


Why return, as opposed to erroring out as here: https://github.com/zfsonlinux/zfs/blob/2a4324141f4a0811ba29dfef123fe5dad2ca1b03/cmd/zdb/zdb.c#L2145-L2149


is that standard python module?


Nice job!


looks godo


I'm seeing a test failure with Xcode 7 beta 2 that appears to be due to this change:

```
Test Case '-[iOS_Tests.SwiftPropertyTypeTest testIntSizes]' started.
    t =     0.11s     Assertion Failure: XCTAssertEqual failed: ("1") is not equal to ("32") -
realm-cocoa/Realm/Tests/Swift/SwiftPropertyTypeTest.swift:75: error: -[iOS_Tests.SwiftPropertyTypeTest testIntSizes] : XCTAssertEqual failed: ("1") is not equal to ("32") -
Test Case '-[iOS_Tests.SwiftPropertyTypeTest testIntSizes]' failed (0.112 seconds).
```

This is due to `SwiftAllIntSizesObject`'s `int8` property being treated as a boolean rather than 8-bit integer.


This makes it sound like VS 2015 doesn't have a free Community edition, which it does. How about this text:

> Visual Studio 2013+ (Community is free) is a pre-requisite to build this repository. See: https://github.com/dotnet/coreclr/blob/master/Documentation/building/windows-instructions.md


Two points:
* Reasonably, speed (though I should check)
* Independent of the implementation of the operator*


I didn't plan children of this class, but I can easily comply, it changes nothing.


This path is now wrong (from an earlier change). Can you fix that up, too?


Agreed. I would argue though that even the need for location based services and push notifications can be outsourced, given the requirements are clearly specified


This is still WIP, I use update_values to check the results, will restructure it once I'm done.


We should adopt the same text as above.


pour ca il faut que je connaise la bdd et le nombre max de charactere. Du coup il fautt que je fasse ca pour la plus part des variables pour eviter des problemes quand on fera des insert dans la BDD ?
apres j'ai lu ca: http://www.developpez.net/forums/d782702/java/general-java/debuter/constructeur-setter/
du coup dis moi comment je procede ;p


Thanks!


As a matter of fact, we never supported replaying deleted messages :-)


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Only after python 3.3 I believe. The commit before this one where I'm trying to add the dependency via vendoring.


ami for deb 8.1 (tested oregon and passed ec2 creation but not entire script as of this post.  script may fail due to debian 8 not 7)
US East (N. Virginia)	ami-819a63ea
US West (Oregon)	ami-3b56520b
US West (N. California)	ami-a7d621e3
EU (Frankfurt)	ami-bc92aaa1
EU (Ireland)	ami-42d89d35
Asia Pacific (Singapore)	ami-6a989c38
Asia Pacific (Sydney)	ami-79e39943
Asia Pacific (Tokyo)	ami-f454f3f4
South America (Sao Paulo)	ami-a3bd3fbe

AMI list for debian 7.8aws1   (tested California, Singapore, Oregon completed entire script successfully)

US East (N. Virginia) ami-38de9950
US West (Oregon) ami-4b51097b
US West (N. California) ami-da524a9f
EU (Ireland) ami-0355d974
Asia Pacific (Singapore) ami-e46d47b6
Asia Pacific (Sydney) ami-33502409
Asia Pacific (Tokyo) ami-a6ccd5a7
South America (Sao Paulo) ami-376ed22a

Not sure where you got these AMI's but they dont work with the debian listed in the amazon prereqs


My mistake - we did, just my plugin didnt... ;)


good catch man. I missed those professions entirely


Reverse engineered the bootloader and kernel. ;)


This seems to contradict the comment. So is it emitted as that, or is it emitted with the comma?


hi @ashleygwilliams
the underlying assumption of your code is that Ruby version will never reach 1.10.X. and that's properly true. I just think in general when we compare two version strings, it would be safer to convert them into Gem::Version for comparison.
But again, I agree for all existing MRI version numbers, current implementation is perfectly fine :smile:

Thanks a lot for your reply!


I think this is better as `!defaults.fetch("published", true)`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16898/testReport/) for this commit**


Oh, I've just noticed that this SimpleSimulator and not Simulator. private is OK, sorry to bother.


the initialisation of the grammar must go in the __init__


Before your change, the pal_module was linked in a list with exe_module, but I cannot see it being done anymore with this change.


Something seems wrong here. You have three different tabs active. You must only have one of them.

To keep your branch clean consider using the [fix-up e autosquash](http://fle.github.io/git-tip-keep-your-branch-clean-with-fixup-and-autosquash.html).


I'll open a issue for it, just to be sure that we change it before releasing


This seems to be a correction of your earlier code yes? If it is I would just rebase it onto the first commit since it's a pull request and it's cleaner to audit the trail if this is rebased.  Mistakes happen, just rebase them!


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/68352719


This closes #15


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16899/testReport/) for this commit**


![image](https://cloud.githubusercontent.com/assets/12758473/8360676/434689d6-1b3c-11e5-905d-6e9e2c182db0.png)
Foursquare is a popular user of this method


I wonder whether it would make sense if we said that `parentToken` can only ever apply to UiView sturdyrefs.

Concretely, we could extend `SupervisorObjectId` like this:

```capnp
struct SupervisorObjectId(AppObjectId) {
  # Refers to some persistent object which the Supervisor for a particular grain knows how to
  # restore.

  union {
    appRef @0 :AppObjectId;
    # A reference restorable by the app.

    wakeLockNotification @1 :UInt32;
    # This refers to an OngoingNotification for a wake lock. Note that although the app itself
    # implements an `OngoingNotification`, the supervisor wraps it in order to detect the `cancel`
    # call.

    uiView @2 :union {
      direct :group {
        userId @3 :Text;
        roleAssignment @4 :Text;
        forSharing @5 :Bool;
      }
      child :group {
        parentToken @6 :Text;
        roleAssignment @7 :RoleAssignment;
      }
    }
  }
}
```


@zsansted @Sarhersh45 @jisong16 @dpickup @hyin16 do you guys agree?


:) :clap:


Doesn't  '-ENOTSUP' better than -EBADR for this error?


The recommended 74X release is CMSSW_7_4_5.
Lower 74X releases should still compile, but the git merging retrieves a huge amount of un-needed CMSSW packages which slow down the compilation


"*" works on windows, either way both serve the same purpose.  On bash one needs to escape it of course.


Just `gsub` :100:


# OTPNFCTransfer

Det här är bara snabbisen som skyfflar filer till SD-kortet.
NFC-skrivaren ligger kvar på jobbet.


I am not seeing the CSS effect as I am seeing [here](http://multidatespickr.sourceforge.net/). Why you have deleted this file ?


@stgeorges ,
Your SunPath component is not affected by these changes and I have left the method you put in place for calculating solar time as well as the original methods for calculating standard time.  Could you elaborate a bit on the error that you see my changes causing and what revisions to the code you would suggest making?  To clarify the changes that I made to the calculation, the only significant one is that I set the self.solTime to be equal to the input hour instead of trying to calculate it with this formula for dealing with standard time:
self.solTime = ((self.time*60 + eqOfTime + 4*math.degrees(self.s_longtitude) - 60*self.timeZone) % 1440)/60
The acos function has not been changed.  I only put in some checks before it that prevent us from getting math domain errors.
-Chris


Nice catch, I'm removing the comment entirely.


@zjj010104 - I'm not sure I understand the intention of this change. IMO *seems* and *likely* are not a certainty and are inviting race conditions. Also, with this change, the documentation for this module in its suggestion the initial value may be `null` is no longer correct.


Yay! First time actually helping!


Ah, I am sorry, it is done internally by the LOADLoadLibrary.


Raster version of the Shields logo (for the new README).


TeamCity Xbim :: XbimGeometry :: XbimGeometry [Build 7](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=16&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


fast-forwarding master to auto = a3210af0


I think it would be a lot smaller if it didn't bundle and build a big chunk of its dependencies internally. I'm not sure if someone's fixed that, but last time I looked it appeared to be doing that.


```sh
$ python -c "import tqdm;tqdm._utils._environ_cols()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
TypeError: _environ_cols() missing 1 required positional argument: 'file'
```


Ugh, this is ugly :/

Doesn't go build automatically download dependencies?


As discussed, i think this is the best approach . This way we can add new graphics without requiring major changes in the Graphic class.


Relevant to #138


:neckbeard: You can embed an image inside a link while staying in Markdown, no need for HTML:

    [![alt](image-url)](link-url)


I personally don't like the usage of a ternary operator here... it took me a second to see this and I only noticed it when I went back for a second read of the code, which means this code is not speaking clearly for itself, maybe this should be split off into a line based conditional.


@Sarhersh45 @rashawsalem @jisong16 @dpickup @hyin16 Please leave comments


Uh, isn't it a little heavy to build locally? Or is the amount of CPU so low for this? BTW, I'd expect some packages built on Hydra depend on it.


TeamCity Ybackend :: synteny/ybackend [Build 49](http://192.168.30.225:8111/viewLog.html?buildId=1420&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


lol


Done


If you look at later commits you can see that this was done before the PR was merged.


It's incorrect call javascript function here. HTML and Javascript must be decouple. Besides, we're using jQuery because browsers compatibility, so consider change your code to jQuery.


True! Another con would be the potential additional expense associated with needing to redo work or do more work later on due to changes in requirements and/or specifications case you mentioned


While editing I also fixed the overlapping code on Slides 10, 11, 12, 13, 16, 17,18, 26, 27, 30, 31, 32, 47, 50 and 51.  My updates appear here: https://github.com/chef-training/chef-intermediate/tree/SD-Release-Candidates/Modules


I just pulled your changed in to my fork and my start / stop instances playbook started throwing the following error:
```
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: NameError: global name 'source_dest_check' is not defined
```

I think you need to add the following two lines at the top of the ```startstop_instances``` method:

```
    source_dest_check = module.boolean(module.params.get('source_dest_check'))
    termination_protection = module.boolean(module.params.get('termination_protection'))
```


Done, but without the leading `!`.


with or without thee link to the documentation?


Yep! Done.


Ah yes you are right, I added an extra `!` I do apologize for that!


Yeah, the dependencies is exactly why I had to add that `assert !config.inHydra`, since `meta.hydraPackages` alone doesn't prevent a package from being built as a dependency.

CPU is not the issue, it's the I/O overhead of copying that 1.5 GB over and over again.


@Sarhersh45 @zsansted  @rashawsalem  @dpickup  @hyin16
wld be great to have your feedback on this!


Done.


can you please also add a conclusion?


Always you call this function you will active both tabs. Do you expect this behaviour?


+2 with s/ebadr/enotsup/


I wonder if this is safe. What if the caller of the `PAL_InitializeDLL` tries to do something with the `exe_module.lib_name` after the caller of `PAL_InitializeCoreCLR` frees it here and before it assigns it the new value at the next line? Or is it so that this cannot happen?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 86](https://teamcity.labkey.org/viewLog.html?buildId=257221&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 1 Build time: 00:17:29
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSUpgradeTest: <no details avaliable>

```


I'd suggest using a wrapper for `kernel_fpu_begin()` and `kernel_fpu_end()` to make the code more readable.  Something like this.

```
#if defined(_KERNEL)
#define kfpu_begin() kernel_fpu_begin()
#define kfpu_end() kernel_fpu_end()
#else
#define kfpu_begin() ((void)0)
#define kfpu_end() ((void)0)
#endif
```

We've already done some thing similar with `kpreempt_disable()` and `kpreempt_enable()`.


Hey Jie, how about we elaborate - briefly - on what Scala is?


@jrmartin this stuff is gone but I think it's still needed in some form, it's not recursing anymore and cannot deal with nested entities from what I can see (it fails to map nested variables on nested entities to correct instance paths)


This commit includes the complete works of Shakespeare... Seriously, why!?


Yep, good catch... it was being re-used at one point but no longer is (when trying to send down posts and comments at the same time, except the initial query wasn't reactive after using fetch). Perhaps even making two subscriptions is a better example than the current way?


But if this prevents building some CPU-heavy things on Hydra... (I don't know if it does or not)


972124-2NewDetailedIceStorage (RKStrand) - i386-Windows-7-VisualStudio-12: OK (1673 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


By the way, are you doing your testing in a `nix-shell`? Because that'll almost certainly give you faster iteration than doing a `nix-build` or `nix-env -i`. You probably already are, but thought I'd mention that.


AFAIK the tool material of diamond is emerald in the vanilla code, so this was done for consistency. I prefer it this way though.


sure let me amend!


Is your editor setup to use tabs? It looks like 8 spaces on GitHub lol. Perhaps I can re-indent these to use 2 spaces to match the rest of the app.


LGTM


It doesn't. This is the best solution for now, they may be releasing a standard way to do it in Go 1.5


Nothing wrong about this, but it might be beneficial in the future to condense simple if statements like this. For example either doing

```
self.confirmButton.hidden = ([checkString length] == 0);
```

or

```
BOOL shouldHide = (checkString.length == 0);
self.confirmButton.hidden = shouldHide;
```

Saves a few lines. Just a suggestion though :)


well.. now this won't support `C:\Program Files\And Stuff\` since spaces are not allowed. My original didn't support either, but I don't know if we should.


The behavior here is well defined but subtle.  For a sample, it might be too subtle, maybe Write-Output is clearer.


@nathenharvey wrt "I've included slides that can be used for this in Modules - word_on_multiphase.key" I am unfamiliar with this format. How can I see it in PPT format?
https://github.com/nathenharvey/chef-intermediate/blob/nathen/nyc-04/Modules/word_on_multiphase.key


The goal is a bit more verbose here, but it should be in that final page:

```
              "We will overcome this difficulty by doing the following:",
              "",
              "* We will re-order the commits so the one we want to change is on top with `git rebase -i`",
              "* We will `commit --amend` to make the slight modification",
              "* Then we will re-order the commits back to how they were previously with `git rebase -i`",
              "* Finally, we will move master to this updated part of the tree to finish the level (via the method of your choosing)",

```


What do you think about placing each of these implementations in to a separate file.  For example:

module/zfs/vdev_raidz_sse.c
module/zfs/vdev_raidz_avx-128.c
module/zfs/vdev_raidz_avx2.c


Well, it has always been my position that nothing in Nixpkgs should depend on texLive because it's such a bloated monstrosity. A few reverse dependencies seem to have snuck in, though...


Good catch, thanks again!


are you suggesting we move shakespeare to his own maven repo?


Maybe ```FailNow()``` makes more sense here since ```Fatal()``` is technically Log + FailNow, but since we're not logging anything...

Either that or maybe a log message would be helpful in terms of why it failed? Same for a few other Fatal calls in this file.


@rashawsalem  pls like my change and give me a thum up :-)


Join already does a Clean


might be a preference thing, but can we stick to using properties without touch the instance vars everywhere? so here we just do `@synthesize branchKey....` and replace `_branchKey` with self.branchKey in every place.


CFLAGS would cause incorrect building ACE libraries.

According to [ACE/include/makeinclude/wrapper_macros.GNU](https://github.com/DOCGroup/ATCD/blob/master/ACE/include/makeinclude/wrapper_macros.GNU):

* CFLAGS is just for C compilation flags, and is not effective for C++
* FLAGS_C_CC is effective both for C and C++.


Check if the delegate responds to these selectors before calling them.

```
if ([self.delegate respondsToSelector:@selector(routerAuthenticationCanceled:)]) {
// call method
}
```


Check to see if delegate responds to this selector first


this is necessary to fix a bug related with chart js scripts. isn't the perfect solution, but it fulfill the the needs.


One somewhat tangential problem that is solved by my above suggestion is that it becomes easier to query for all entries in `ApiTokens` that represent UiViews to a given grain. If, as is the case now, a `parentToken` sturdyref does not have any further information about the provider, then you need to do multiple queries to chase down (or build up) the chains of tokens.


TeamCity Ybackend :: synteny/ybackend [Build 49](http://192.168.30.225:8111/viewLog.html?buildId=1420&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 82 Build time: 00:12:58


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 324](http://192.168.30.225:8111/viewLog.html?buildId=1422&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


This conversion to irange/drange doesn't makes much sense too me (and Sachiel). We dont have mechanism to properly interpret this as part of a single data. I would remove those for now.


@rashawsalem @zsansted @jisong16 @dpickup @hyin16
Let me know what you guys think!


While this will probably work, a better solution would use the pkg-config database to retrieve the proper include and library paths, rather than hardcoding them here.

I'll see if I can hack up an example


In my opinion is like kill a fly with a hammer. The other aproach is to stay with version without tabs due an issue related with Chart Gem.


Awesome. I would add that it's not as common as other languages and requires further effort from the programmer. You're set!


Who/what defines this __TIMESTAMP__ macro? I can't find it but I do get it in my --list=build-info.

I do not like this commit at all. It ruins the ability to tell whether two builds of JtR are exactly the same, because the timestamp (maybe only that, maybe not) differs. IMHO we should revert this.


And if the vector -> irange and vector ->drange were removed, this needs update.


@rzarzynski wouldn't it be better to just define a char array at the appropriate size?


Думаю здесь можно не смешивать английский и русский, при прохождении задания выражение Regular Expressions встречается часто) Поэтому предлагаю сделать: "Изучите Регулярные Выражения"


Love that you've boiled it down for simplicity. Great job, @zsansted!  :v:


this will probably fix #278


"Проверьте" я бы изменил на простое "Откройте эту ссылку".


I’m sorry. I didn’t realize that it was hard-coded into `HistogramTemplate`. I’d really rather it wasn’t included in the repo, but I’ll put it back for now.

- David

> On Jun 25, 2015, at 12:34 PM, Dalton Mills <notifications@github.com> wrote:
>
> are you suggesting we move shakespeare to his own maven repo?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/hridesh/panini/commit/a0186ebc9b622dd5121abeeda63b1ecfedeb5403#commitcomment-11866313>.
>


a comment


+1 besides comments


You forgot either to create or push this file. See https://discourse.mailinabox.email/t/500-internal-error/611?u=norman


Is there an example I can take a look to test it?


It might be cleaner to compute what $OLDPWD will be using filepath.Rel(pkgSrcDir, srcDir)


This broke github.com/nbio/hitch


This is sample is very helpful! espacially for beginers like me.


"beware of sort ahead" hehehe ... but I'm glade someone did it.


Also, use && between cd and $in, in case the directory doesn't exist for some reason.


I know, I just meant @nouiz (or you) can just file a PR and merge it yourself, or even directly commit to master, which would be easier than me filing a PR for such a small change. (Although a proper PR should probably add a test that triggers the error. But in that case, I'd be a bit at a loss anyway.)


The reason it's 'hard coded' is because we do not support command-line args yet, which is why I mentioned I was looking into it this morning.

However, `shaks12.txt` is a common file and used for many examples (beyond panini and at-paninij).


Ooops thanks, just pushed the file.


add me everybody


No -- when you define both the setter and getter, it doesn't auto-synth for you :disappointed:


This should not be here. The payment's association is loaded here, but not used for the rest of the method.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 324](http://192.168.30.225:8111/viewLog.html?buildId=1422&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:38


@PeterDaveHello Haha, nice to see you here as well! :smile:


selectEvents method is improved to respond the requests coming from EventList and KeyMemberofCommunity tabs of EventList page.


@zsansted @hyin16 @rashawsalem @Sarhersh45 @jisong16 thoughts? LGTY?


I mean, inplace elemwise optimization that you are working on.

Some opt call replace() and validate() directly.


I think there could be some good programmers that aren't as interested in scala, perhaps they are just more interested in diving deeper into the languages they are already familiar with instead of learning the new program. I would argue that this person is still curious, as long as they keep learning new things!


Should we start marking things like this for `rake notes`? Something like `# TODO Fix after Rails 4`


Hi, I am currently using the deflate-frame extension; have you completely removed this feature, or is there code elsewhere that uses this?  If there isn't, can you please add this back?


"Заметьте, что вы можете нажать\"continue\" чтобы перейти к следующему шагу, как только рядом со всеми задачами появятся зелёные галочки. Это часто можно сделать с помощью подстановки оператора \"dot\" (точка), но попробуйте использовать рекомендованные методы урока.", поменял "вы можете" во втором предложении.


I agree with Rasha!


@adnelson Yes, I am.


No good reason, am doing so in next commit! Thanks for the info :)


bash !- sh


image can be located at Wolfram's excellent resource on Venn diagrams: http://mathworld.wolfram.com/VennDiagram.html


Hi David! Great job! Make sure to add a link and an emoji! And I'd love to know more info :)


how many iterations are we talking about usuallly?


@bsongis I am not sure this is the best solution for vario speed but the range includes this units:
```
  UNIT_VOLTS,
  UNIT_AMPS,
  UNIT_MILLIAMPS,
  UNIT_KTS,
  UNIT_METERS_PER_SECOND,
  UNIT_FEET_PER_SECOND,
  UNIT_KMH,
  UNIT_MPH,
```
This will now work with FrSky vario, but if someone chooses some other ID for its own vario it won't work again. Is this `if()` really needed - not allowing negative value for certain units?


There should not be anything specific to a given protocol in telemetry.cpp!


thanks!!!


This is already fixed in master. So no need to fix. How did you find this? By git bisect? If so, skip that commit.


Good call.


"После завершения этих задач, переходите к следующему Waypoint'у."


@kilrah I agree, see my question to Bertrand.


Good insight. Any mockup website you recommend?


The filters parameter is optional and Chrome will automatically limit the app to only devices it has permission to access. By not providing it it will also include devices granted through chrome.hid.getUserSelectedDevices when I add support for that.


Are you aiming for reproducible builds?
https://wiki.debian.org/ReproducibleBuilds/Howto
If we drop timestamps, I'd really love to have some other info like latest commit id.


@jlgit

May you please create a model with name  `Authentication` cause current `User` model is used in preparing specs.

Regards.


Bile Retcher [3704 - 4911]
35 * (34.482 + ( 258 / 14)) * 2.0 = 3703.74
35 * 1.5 * (34.482 + ( 258 / 14)) * 2.0 = 4910.61


About how many stories should we have?


much better
![](https://cloud.githubusercontent.com/assets/2059468/8361455/f1f0db02-1b38-11e5-9716-c769f87c4d63.gif)


@jaeandersson  On OS X we get an error for this include, that is corrected if we modify it in `#include <iostream>`.. it is possible that here we should include `<iostream>`

\cc @nunoguedelha


Well I guess it depends on the project, but I'd say 20-30 is more than a good start even for the bigger projects


I agree, it's better to start with a webpage :)


Fair, thanks.


Okay, fixing.


__TIMESTAMP__ might not be the right macro anyway, since it describes the  date and time of the last modification of the current source file, i.e., it is quite useless.

```
 $ ls -l listconf.c
-rw-rw-r--. 1 fd fd 33049 Jun 18 19:51 listconf.c
(bleeding-jumbo)src $ ../run/john --list=build-info
Version: 1.8.0.6-jumbo-1-bleeding
Build: linux-gnu 64-bit AVX-autoconf
Time stamp: Thu Jun 18 19:51:34 2015
```

Plese drop the time stamp.


Yeah, good point. I actually tried `.reset` first and it didn't work so I just went ahead and did `reload`. I'll give it another try and see if I can figure out what's happening.


This is Drupal 7 specific. Use [drush_db_select](http://api.drush.org/api/drush/includes!dbtng.inc/function/drush_db_select/6.x), and skip all of this for Drupal 8.


Why not update Polish ? Plase update all from Polish becuase i change a lot of strings.


Ada boy


@roxas75 I thought using a big array for the "chain" of menu is somehow wasteful, also entries array in the Menu structure.. As you could see in this commit i tried to use a new structure for the Menu. That builds, and runs as i expected - unless the unneeded characters in every first option of menu, and i don't know what caused it really. Or else maybe you could just change the two array size? I don't know if you really have 1Kilo menu options to display.


Can you replace set disk space before login as ?


Given branch test-branc is invalid. Please select a valid branch name.


@ccx-testerbot runtests test-branch


DP feedback: what is Scala best for? Why better than PHP?


Command acknowledged


Empty function doesn't make sense to me.
Can you give more explanation?
And I don't see any call to onNothingSelected on 329 Line number.


options used to be able to be a string, such as `"utf-8"`, this now breaks with `TypeError: Cannot use 'in' operator to search for 'spaces' in utf-8`, was that intentional?


@Sarhersh45
amended, pls like!


I think this is the source of the error in last night's builds, missing paren?


Very clear! LGTM :+1:


@dpickup
excellent point, has been addressed by rasha and updated, pls like! :-)


Can you explain this? It is strange. If it is good, add a comment that tell what this does. This must sort first by the position. I don't think this is what the new code do.


Hi no problem, definitely interesting article and approach with stree, thanks for sharing it!  I am experimenting with stree but having issues with 'git stree pull':

 - Without this patch, git merge always picks the wrong directory.  It's definitely not a rare occurrence: I have not seen git merge work right once yet, other than the walkthrough from your article.  (I have a large repo, > 100k files, >100 strees.  This may impact the probability of bad guesses?)

 - With this patch (and maybe without, since I haven't seen the merge work right yet who knows?) after the pull I get many "both added" conflicts in any files that exist in the stree and the source repo which need to be manually resolved.  This is strange because there are no modifications in the stree.  To resolve the conflicts this dumb merge approach works (again, I have no changes in the stree, which makes antics like this possible):
    git reset --hard
    git diff master:<stree_path> stree-<stree_name>/master | patch -d <stree_path>

For me the patch is worth it because I otherwise can't even 'git stree pull' and the cost is only resolving some conflicts.  I should probably have included this fuller description in the PR, sorry!


@extrapixel works great, thanks!!


when you define both the getter and setter, why need @synthesize again?


When I went back I also noticed that this test is effectively
```(prio_levels && prio_levels) != (1 << log2(...``` not ```prio_levels && (prio_levels != (1 << log2(...```, which you can test by setting an invalid error and looking for the error message.


Yes! :)

It can be still be used, but I prefer `%d` for simplicity (and the underlying code has no concept of subtypes here).

I really like tinyformat, especially because `"%s"` can be used with `std::string` even without `str.c_str()`, and what I very recently found out: `"%s"` can also be used for `bool`, and it then results in `"true"` and `"false"`. :)


Not sure if changing the status label is the best to do here. It may break people's scripts.


Would'ya mind merging it?


You can also use the MVP model and go with a concierge or wizard of oz approach :tada


:tada:


Oh right, this should say `a[1]` and `b[1]`


I must have missed this one, thanks for correcting


"supported" should be "support"


Sorry, I just noticed this too.  Should be fixed now.


Thanks for showing me how to do it. I made Tyrant's Choice and Coercive Portal now. =p


done for 5.5


Because you don't have an instance variable.

By default, `@property id foo` will create an instance var `_foo`, a getter `- (id)foo`, and setter, `- (void)setFoo:(id)foo`.

If you specify your own getter and setter, it won't create the instance var for you either. Kind of a weird little quirk that makes custom properties become gross.


s/contain/contains/ or s/contain/specifies/


i += 1


Squash this one with previous


Fair, I'll remove. Should we ditch the RGB variants of those in the sequence?


passing*


@rashawsalem
absolutely love it but I think you should add a link!


This looks potentially problematic. `buffer` is passed to the parent constructor before it has been constructed.

A way to handle this is to use the boost::base_from_member idiom (in Boost.Utility.)


Depth handling should be done per block type, the current implementation can close a '(' with a '>'. you could define helper lambdas:

```
auto opening_index = [](char c)
{
    switch (c)
    {
          case '(': return 0;
          case '{': return 1;
          ...
          default return -1;
    }
}

auto closing_index = ...
```
along with an array of depth.


Thanks! BitHub has sent payment of  $8.05USD for this commit.


Sorry but why use suffix? User-installed icons takes precedence anyway, because the icons name is not "gnome" but another name. This way instead you are giving precedence to the system installed adwaita theme rather than the one compiled with the derivation. `$XDG_ICON_DIRS` must still be in prefix.


Are you not able to get the column types from the table definition?


* and so, because it doesn't create that for you, you have to synthesize it yourself (if that statement above wasn't clear).


Fix


Replace "should data values be trimmed from whitespace" with "remove leading and trailing whitespace from data values"


This is a better name, but does anything use it? Do we need to make an assignment at all?


Can "flowVars" be read from a constant?. Or refactored to a constant if you are using it more than once?.


Selecting the parity function during open is safe as long as we store the result in the vdev_t so it can't race.  The open will only happen once for the RAIDZ vdev.  I'd add the function pointers after the `vdev->vdev_nparity` member of the vdev_t.  The alignment in the structure works well and this is adjacent to the other RAIDZ specific member.

We're also going to need some way to request a specific implementation if for no other reason than testing.  The easiest way to go about this would be to add a module option which can act as an override.  Check out the `zfs_vdev_scheduler` module option in `module/zfs/vdev_disk.c` as an example.

```
#define VDEV_RAIDZ_PARITY "auto"
char *zfs_vdev_raidz_parity = VDEV_RAIDZ_PARITY;

module_param(zfs_vdev_raidz_parity, charp, 0644);
MODULE_PARM_DESC(zfs_vdev_raidz_parity,
    "RAIDZ parity calculation: auto, generic, sse, avx, avx2");
```

We'll also need to document this more fully in `man/man5/zfs-module-parameters.5`.

So we can rigorously test correctness it would be useful to add the following undocumented settings for this module option.

* __all__ - Run all available implementations and verify they yield identical results.  This is something obviously users would never do but the test suite could and it would let us quickly build confidence in the code.

* __roundrobin__ -  For each I/O round robin through the available implementations.  This wouldn't impact performance and would allow us to verify compatibility and maximize our code coverage during testing.  Alternately this could be implemented by selecting randomly.


same as before


Not sure the version bump is necessary, but for sure it doesn't hurt. I'm fine with this change now, thanks for fixing up. I don't have other changes to iodine in the queue, so if you send a pull request with my Ack that is fine for me. If this change is required to be pull-requested by me, tell me please.


Not sure I understood what that implementation does for inner. I would expect non-inner to be the argument including preceding whitespaces and (eventual) following comma. And inner would be the argument excluding preceding whitespaces and following comma.


Can these expressions be created using a method?. Like getFlowVarExpression(String flowVarName) ?.


s/supported/support/


> This is already fixed in master. So no need to fix. How did you find this?

By chance. I was looking at `python2x.py` because of the OrderedDict issue, saw that there was a recent commit changing it, wondered what it was and ended up reading the beginning of this diff. Sorry for the noise, I didn't see that it's fixed in `master` already! Ignore all of this!


@jrmartin yes see [this one here](https://www.dropbox.com/s/lxnjiyguqafsvab/wormsim-project.json?dl=0)


I think you inverted `1` and `-1` here and in the next line, "foo" should be less than "foobar".


At the moment, `a` is used for angle brackets (<...>), we could decide to use it for arguments instead, but that means tests should be fixed. maybe we have another good key for arguments/parameters (unfortunatly `p` is used for paragraph)


you stink


asdfasf 567567 567


Tables are populated using "INSERT INTO " statements.


@Sarhersh45  @zsansted @rashawsalem  @jisong16 @dpickup
pls comment


This code allows staff users to 'see' images that are made private by atmoadmin, but its a "hack-fix" in that staff users should already be able to 'see' these images IFF the Application/ProviderMachine/(Version) Memberships are appropriately set (And currently, they are not.. which is why this was required!)


asdfasdfasf


s/contain/specifies/


Can you put these pin assignments in a markdown table? It helps break up the wall of text so that people actually read it.


Intente con las clases de coffee... tambien se ve interesante trabajar asi angular :+1:


Are you not able to get the data types from the DDL file?


It would make more logical sense to put this after the admins have been notified.


Great job! There's one typo: it says verz instead of very.


Mmm, looking better at that, they do make sense: int/f -> vector get three in ports, while vector -> int/f get three out ports. Leaving as they are, actually.


Commits like this should be rebased in Git with _"fixup"_


removing the call to Initialize() leaves all the class fields uninitialize


how about in curiosity?


Is "a bug in provisioning in the Cached install strategy with the new chef_version changes" fixed now? I reverted this change in my local install and install_cached seems to be working fine. Can we change this back to using install_cached, or shall I add a new option to choose between the two strategies?


(I assume) this commit makes QGIS crash at https://github.com/qgis/QGIS/blob/2b703e397cd7ce8d4d3fd3fbb01934e8b437aad8/src/app/qgisapp.cpp#L3363 when loading http://download.geofabrik.de/north-america/greenland-latest.osm.pbf


:v:


There's still that horrific and insidious check for StructureMap within `AllContainerTestsBase.FactoryServicesAreCreatedAsPartOfCreatingObjectGraph()`:

```csharp
            // Scoping does not currently work with StuctureMap
            if (GetType() != typeof(StructureMapContainerTests))
            {
                // Verify scoping works
                Assert.NotSame(service1.TransientService, service2.TransientService);
                Assert.Same(service1.ScopedService, service2.ScopedService);
            }
```

Removing the check for StructureMap results in failure on the Assert.Same(...)


- This line is a bit long, I'd split before `.specializedFor`.
- I'd write `m.paramTypes ::: List(m.resultType)` to avoid having to think about operator precedence.


It'll be this and a merge with the fixes. Thanks a lot.


Thanks for adding this.


Yes, thanks but sadly the project I am working on has a Centos LTS version that is stuck on PHP 5.4 and V4 of your package requires 5.5. Maybe you could back port that cache tags requirement to v3? Thanks for your work,

Mark

On Jun 25, 2015, at 12:45 PM, Graham Campbell <notifications@github.com> wrote:

This is already done in v4. See GrahamCampbell@91b7c35.

—
Reply to this email directly or view it on GitHub.


Great point! Also 'imaging'?


@hyin16
yes let me update that. pls like


how much does it take on mockup?


Please add a comment explaining that the names need to be sorted to be compatible with Scala 2.11.


I love the simplicity of this loop


this broke a bunch of our code.


Not sure it would be useful for many people... but I have been spinning up servers for lots of people and my generated docs folder could use loving...

something along the lines of:
ProviderName_ServerLocation_ServerName  could work for most


In the default version of Grafana that we're using (2.0.2), `Put` is used for additions and `Post` is used for updates. What version of Grafana changes this behavior?


Yes, I'll document a proposal around this ASAP. I'm actually in favor of externalizing (i.e. --focus and --skip) at least some of the decision as to which tests should run or skip.  It's not generally feasible for a test to know whether it should be run in a given environment.  It is however feasible for a test to publish it's properties, and have the external environment to use those to decide what to run and what to skip.  Maintaining invariant test identifiers is part of that, I think.


@dpickup good catch :+1:


I want to extend this two dimensional type with functions


5.4 is essentially no longer maintained by the php team, so I can't justify supporting it. I'd recommend using remi's php packages on centos to get 5.5 or 5.6.


It's full sync. What's on transifex, it's in intl/ directory. Just type 'Ctrl-F' and 'pl.po' to check what was pushed in this commit for PL.


@tschottdorf turns out you were right :( cc @kkaneda


No! The *.scss files should be committed, the *.css files should not be committed. :)


Nope!


@zsansted :smile:


if you're going to have api changes like this, you should hard version the package (as in, new repo, httprouter_v2). golang has terrible support for pinning versions short of forking, and it's a huge drag to have to track down random errors on a go get -u


Wait, what? lol


7行目は下記の方がスマートだよ。

編集中

表示する文字は

タグで囲む習慣を付けよう。
はHTML5で廃止されているので使うべきではないかも。
応援してるぞい！


In the mean time, just change the name of this as appropriate, and update the Jenkins configs accordingly.


Once I added the `.` and `/`, GitHub for Mac automatically removed the sass-cache directory. For some reason, `sass-cache` by itself didn't do it.


very clear! good post!


I read about this issue. So, maybe you should consider old solution. Workaround is not an ideal response.


This causes problems with many external USB keyboards, including the Kinesis Advantage.


@arranf Thanks for contributing fixes and code.  We really appreciate this sort of involvement.  Would you take a look at your VS settings and see if the "Insert Space..." options are checked (as mentioned here: https://github.com/SparkDevNetwork/Rock/wiki/Coding-standards)?  I've noticed that the spaces are missing from your recent code.


What's an example usage of this mapping? Calling it on line 1 results in `E493: Backwards range given: 1,0sort`.


How about Jquery 1.9.x ? because this version's not support IE 6, 7, 8
//I think If we don't use any new feature in version 2 It still ok for continue with 1.9.x series that can support old browsers (If both of these version is slightly different)

However, change it to `minified` version please :smile:


But what processes the Sass file? Is this done via Heroku or elsewhere?


Ahh, that's right. NVM


Super clear, great screenshots. I suggest one change on the side of caution to the tail end of the document:

> Once you've set up the firewall, continue with the instructions in the

to:

> Once you've set up the firewall, **exit the Unsafe Browser**, and continue with the instructions in the

Change bolded above for emphasis. Not strictly necessary to bold in the docs, particularly because we don't often.


I wrote that comment in order to match [the implementation](https://github.com/SpongePowered/SpongeCommon/blob/master/src/main/java/org/spongepowered/common/mixin/core/entity/MixinEntity.java#L355), so if you're going to change that comment you had better update the implementation as well.


`$issue = $em->find("OjsJournalBundle:Issue",$entity->getIssueId()); $entity->setIssue($issue);` useless


This was a mistake.


Added images to the image folder


Exactly... Pros for the win next time.


I think categorical is [Prob] -> Measure Nat


hi there

is there a reason why this uses "persistEnce" while other PQS mods use "persistAnce"

I lost a couple of days over that letter :D


good post


Shouldn't this be one of the defined error codes?


keeping in line with Vector and Rotation, I'd say to make this completely immutable and have the set() methods return new instances


nice


Is the jenkins config in the repo that i need to update as part of this PR or is that something a googler needs to do?


Nice, does it work and stuff?


Do we really want to do that although we already froze strings?


Ignore me, the *.css file should be committed. Typically this can be done during deploy, but I haven't set that up yet, so for now commit both (but only work in the *.scss file)


The code is actually pretty inconsistent about how this is handled.  For example, if you look just a few lines below this the function can silently return because of a failed read.  What might be reasonable is to an error message before returning.  That way you'll just drop one of the log records here in the output and get the rest unlike exiting.


IMO it would be better to work it like "Extends Geany's LaTeX support"


Left over `println` from debugging ?


@hyin16  is your favorite api also jquery? if yes pls update!
thx


I dont suspect its a php version as we are running 5.5 in both environments. Still not 100% sure why it works in one but not the other.  but adding @ to the path seems to have resolved the issue so that it always starts at the application base.  See commit 242160c59617c4909ec5ecbeccee3c53dfe2bb91

If you do a git pull it should be resolved now


Also *it would be instead of *if would be. Good job!


But with `private` set to `true` there's no this:

```
npm WARN package.json @ No description
npm WARN package.json @ No repository field.
npm WARN package.json @ No README data
```

Mind if I indulge my OCD and bring it back?


972124-2NewDetailedIceStorage (RKStrand) - Win64-Windows-7-VisualStudio-12: OK (1673 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Here is the updated file! Please everyone give me a LGTM thumbs up! @rashawsalem @dpickup @hyin16 @Sarhersh45 @jisong16


It's not about the ability to upgrade the PHP version. I know that it is technically possible. but very very large corporate entities can be very very slow moving. I have been bugging their tech teams about upgrading from 5.4 but it is not going to happen now. Sigh. So that's why I forked the package. Cheers.

On Jun 25, 2015, at 2:17 PM, Graham Campbell <notifications@github.com> wrote:

5.4 is essentially no longer maintained by the php team, so I can't justify supporting it. I'd recommend using remi's php packages on centos to get 5.5 or 5.6.

—
Reply to this email directly or view it on GitHub.


Or event simply "Improves LaTeX support", or "Extends LaTeX support" (no need to use "Geany" here, it's already a Geany plugin :))


I strongly prefer the former because it gives us an obvious signal if we have hung children.


7.8.*4*, not 7.8.3


Nice!  Thanks!


:LGTM:


As above __LINE__ isn't helpful - use a defined error value (or define a new one if necessary).


I see that the code for kerberos has been merged here. It will be nice if there is a summarization about how to actually connect to HS2 when there is kerberos authentication.


Same, rather "Sends" than "Sending".  Or even "Send[s] the current file as attachment with your favorite mailer"


ok


Sure. I hope you get to move to a maintained php version soon. :)


I don't think so. Then you wouldn't pass this test:

```js
it('should listen to nested paths before they are created', function (done) {
      var structure = new Structure({ data: {} });
      var i = 0;

      var ref = structure.reference(['foo', 'value']);
      ref.observe(function () {
        if (i++ === 0) {
          expect(ref.cursor().deref()).to.be.not.ok();
        } else {
          ref.cursor().deref().should.eql(10);
          done();
        }
      });

      structure.cursor().update(function() {
        return Immutable.fromJS({ foo: 'hello world' });
      });

      structure.cursor().update(function() {
        return Immutable.fromJS({ foo: { value: 10 } });
      });
    });
```

As you listen to a sub-part of "foo" here, you would expect swap to trigger when a parent changes, no?


I was just copying the line above, but I'll remove both of them.


Ditto


If you're using version 2.0 or later, then simple is the default mechanism for push.


Same, "Checks whether there are updates for Geany available" (or something even better but I leave that to a native speaker :))


ixdy will sort it out, don't worry.


Are you not going to merge my commit?


Why not check SecAccess_Write here?


Removed it.


yea


Can you please explain what this commit does fix? Many thanks!


Oh wow, yeah, these are obvious and clearly unused. Thanks for the fix!


actually it was just a test to show that the program actually records without slowing down the pi. The program justs records for 10secs as a test! It's ok not everyone understands the code at first glance!


No it is not full. In Transifex for example is string:

Zaplanowany czas rozpoczęcia

but in TVHeadend is : Zaplanowany Czas Rozpoczęcia
with big letter "C" and "R". ANd it is one example.


@zsansted updated :smile_cat:


Dropped it in ad13769. But I still wonder where it comes from? I tried this but that's not it:
```
$ gcc -dM -E -x c /dev/null | grep TIMESTAMP
$
```


Drobne bledy? Kolego, tam co 2 rownowaznik zdania jest niepoprawny gramatycznie.
Od kiedy mowi sie "System konfiguracja"? Powinno chyba byc "Konfiguracja systemu", prawda?

To teraz spojrz np na:
* DVR profile konfiguracji
* DVR zachowanie
* EPG skan

I co to jest "System przeznaczenia"?
Od samego poczatku mowilem ze tak bedzie. Co 2 appka po polsku jest bez sensu i nie mozna sie polapac ktora opcja za co odpowiada. Chciales tlumaczyc - to sobie tlumacz, tylko naszego jezyka nie kalecz i pamietaj ze wielu rzeczy nie da sie przetlumaczyc wprost, tak jak usilujesz to robic.
Ja nie zamierzam poswiecac swojego czasu na takie pierdoly.


cc @SiebelsTim :p


In general, for this and all the following pieces of code:

I think this style of error checking is  **way** too verbose.

Try something like:
``` C
if (node==NULL) return PN_ERR_WHATEVER;
```
That will massively reduce the number of lines changed and keep these short functions short, and their logic linear.


Aha, so it's a feature of gcc but only when a source file is used...


@zsansted updated :smiley:


Silly, but fixes pagination for Kaminari. Found solution [here](https://github.com/amatsuda/kaminari/pull/322#issuecomment-72340899).


Thanks! Me too! :-)

On Jun 25, 2015, at 2:27 PM, Graham Campbell <notifications@github.com> wrote:

Sure. I hope you get to move to a maintained php version soon. :)

—
Reply to this email directly or view it on GitHub.


I'm not sure, what does the error message look like?

A question: what was the behaviour for you before? What happened if you printed to std::cout? Did it appear correctly? I'm a bit confused since on my 2015a (also on OS X), the output appears in the MATLAB console also without this fix.


agree. will change here and elsewhere


Do you need the "]\n" if (indexHintsCount == 0)?


Ok i found bug and correct on transifex. Plaese change set point DISK SPACE before LOGIN AS


Pass it a count, ie `7gss`


rax retry tests


this is an oversight .. left over from when I was experimenting with starting the hub in a separate process. It's not required .. I'll remove it.


From man gcc:

```
       -Wdate-time
           Warn when macros "__TIME__", "__DATE__" or "__TIMESTAMP__" are encountered as they might prevent bit-wise-identical reproducible compilations.
```


Nevermind, I'm adding the dependency on `<iostream>`, should not harm. I'm still curious whether this actually fixed anything for you.


Merging from origin


Minor: this line can be removed. The same as CwssqlEx::onGetRelatedIndexes().


I tried the following:

> R
> library(RHive)
> rhive.init(hiveHome="/opt/hive", hiveLib="/opt/hive/lib:/rhive/lib/2.0-0.2", hadoopHome="/opt/hadoop", hadoopConf="/etc/hadoop", hadoopLib="/opt/hadoop/lib", verbose=FALSE)
> rhive.login(keytab=NULL, principal="hiveserver/hiveserver-XXXXXXXX.altiscale.com@XXXX.ALTISCALE.COM", hostname="hiveserver-XXXXXX.altiscale.com")
Error: could not find function "rhive.login"
>  rhive.connect("hiveserver-ranjana-ci-XXXXXXXX.altiscale.com",10000, principal="hiveserver/hiveserver-ranjana-ci-XXXXXXX.altiscale.com@XXXX.ALTISCALE.COM")
Error in rhive.connect("hiveserver-ranjana-ci-XXXXXXXXX.com",  :
  unused argument (principal = "hiveserver/hiveserver-XXXXXXXXX.altiscale.com@XXXXX.ALTISCALE.COM")


That's pretty straight forward!

As an alternate fix what do you think about moving all this large block checking code under the `feature_get_refcount()` conditional.  That way `dump_one_dir()` won't be run for pools without this feature and the `Verified large_blocks...` message wouldn't be printed at all which could be confusing when you know the pool doesn't have this feature enabled.


I like the comparison incl. pro/con a lot!


Cf. cf4ccf95f48921396156e6694ef1cf606cac2f9d


To używaj angielskiego i nie marudz...


@rubyyot The code is looking better and better! :+1:


I have some vague doubts about commit id, but if we can "get it" in some really sensible way, I agree it would be very very nice sometimes.


Moved to SSLConfig::startup().   Now at config it's just enabled/disabled.


I implemented what's needed for parcelable and everything seems to work OK. Hashcode() wasn't needed as far as I can tell. Is it better to add it nevertheless?


[![LGTM](http://lgtm.in/p/ezgebhkGn)](http://lgtm.in/i/ezgebhkGn)

[:+1:](http://lgtm.in/u/ezgebhkGn) [:-1:](http://lgtm.in/r/ezgebhkGn)


Blame my Git configuration / nano about that.


Thanks, didn't know.


I tried but it doesn't get called on my device at least. Perhaps because this is not a PreferenceActivity?


I don't really need to check for isHubUp anymore. This too was left over from when I was experimenting with the hub in a separate process.. I'll make a change here.


I would write `List.fill(mt.paramTypes.length)(WildcardType)` instead of `mt.paramTypes.map(Function.const(WildcardType))`


I like the pictures for website design, nice idea!


nng-app="myApp" => ng-app="myApp"


The template code for adding Required attribute should also include the name of the required field.  The logic for updateable is flawed.  Owner Id is updateable, but only by the current owner.


ok, changed to ink_zero.  thanks


`isHubUp` set's it right before it returns.


Thanks, I didn't realize that. That's why I mentioned you, for such cases, as you know more about such things...

I'll push a fix.


changed.


Nice summary, but agree, I would add a picture.


Done, it's much better now :)


Just curious why you are wrapping this in cordova.define? This should happen automatically.


Wasn't intended to be merged before 1.25. Just had some minutes and started to do it.


another oversight..  from when I had the coded sleeping 10sec and with 6 tries.. I'll fix it


Added a toast (short) on success and another one (long) in the catch()


Sure


Needs same branch manipulation in pacman.conf as we do for chroot.
Its only half a fix atm.


I'll change this. I'l also likely to push this method into ThreadedLauncher or a base class of it.


Command line bullshit. Moved central node calculations out from beneath heavy loop. Another optimization.


Just my opinion: for efficiency, line 778/779/780/784 should be:
if (file)
{
  StringArray indexHints;
  file->getRelatedIndexes(indexHints);
  relatedIndexSet->setIndexes(indexHints);
}


Some may use it to build docs; perhaps ``R`` is a notable example. /cc maintainer @simons.


I just noticed you provided the same link as I did - let me change mine or add other ones as well :smile:


This should be merged with the commits that introduced the need for these imports - just edit those commits in your next rebase and modify the imports.

To use n++ with git open up a git Bash and issue:

    git config --global core.editor "'C:/Program Files/Notepad++/notepad++.exe' -multiInst -notabbar -nosession -noPlugin"

Should do the trick ;)


why not use make_dirs?


I believe you need to call ```save!``` here. That will cause an error to be raised and the transaction to rollback.


np :) Btw the icon name is `Adwaita`, `gnome` is no more.


@roxas75 Still I can't get rid of those random characters, orz.
Have size decreased arrays related to those menus, in [Tree](https://github.com/Syphurith/rxTools/tree/size).


Or you could just set it to '_'. Condensing this all to one line:

```python
return self.BASE_URL + "/{0}/{1}/{2}.jpg".format(template, top or '_', bottom or '_')
```


What do you propose?  `launcher` is used in `getInstance`, `shutdown` and `boot`


We don't actually have srcDir, so no, it's not cleaner. Even if I hardcode it to test, it can't compute the correct value if srcDir contains ".."

But I have switched to cd && $in


I guess this should be merged in for 306 - will do it the last minute though so I have the latest loot at the time (and commit the dll only once)


Does this remove measurements? Sounds harsh.


I didn't like them either when I introduced them.. I'll look for another option..


Why do you add one byte here?


I think it is safer in case more code gets added and makes it clear that it is an error path.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Thursday, June 25, 2015 9:59 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Fixed the PAL_Initialize* order problem. (5562242)

It seems this added goto is not necessary

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/556224275d2f7701b3ea25e35f6873afd5c462ca#commitcomment-11865628>.


Why you change this?


I thought we were going to leave this commented out.

My suggestion was to use FTL-style comments instead of XML-style comments.


There is a lock around initialization so this shouldn’t happen.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Thursday, June 25, 2015 10:30 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Fixed the PAL_Initialize* order problem. (5562242)

I wonder if this is safe. What if the caller of the PAL_InitializeDLL tries to do something with the exe_module.lib_name after the caller of PAL_InitializeCoreCLR frees it here and before it assigns it the new value at the next line? Or is it so that this cannot happen?

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/556224275d2f7701b3ea25e35f6873afd5c462ca#commitcomment-11866223>.


Oh, now I see I've forgotten to add ``gnome3.defaultIconTheme`` to ``buildInputs``, most likely. I had that change somewhere, but somehow I didn't push it. I wondered why those icons disappeared again for me after some time...


per Patrick's response I thought we were going to leave this commented out.


I'm perfectly fine with the change to iocp.c

However I will not merge the error checking change to the codec code:

It adds completely unnecessary complexity to the code, being very heavily handed written.

Using  __LINE__ as an error is not acceptable - It is not useful, although it appears to give a surface level of traceability.

On the whole I feel that this kind of error situation should be dealt with using an exception like mechanism. Once you fail to allocate memory you cannot carry on in any event, and need to bring some level of program execution to a halt. So in this case perhaps using `setjmp()`/`longjmp()` might be more useful.

I think we need to consider error recovery under memory failure more comprehensively, as this change does no more than shift around "the bubbles under the plastic".

A possible direction might be to register an out of memory recovery routine which would be longjmped to upon memory exhaustion - its job would be to cleanly shut down the current operation and restart.


Your wording is better than status quo so I used that.


testing to commit my programs


Dang, can't believe I missed this! Nice!


Still broken...


Is this include necessary?


I like that APIs make software development more accessible to people without a CS degree.


Same as below


Oh nice. Wanna PR?


@vcunat don't forget to remove that trailing `:` in the --prefix


default byrow=F, need to be T because part is line by line


Why do you need to pass in all_payments as a parameter? Can't the RevolvUserProfile calculate that from looking at all payments where user=self?


"Look for the helpers. You will always find methods that are helping." - Not Mr. Rogers


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2194 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.14%25-yellow.svg)


We need to quote the second `cp` argument because `build_context_dir` can contain spaces.


I'm trying that now, but it seems like the code in main() after driver.run() is never being called. I don't see any logging messages, and even raising a RuntimeError has no affect.


If you do then understand Wrinkly no longer wishes to guarantee XP support.  So there is a chance someone playing in Windows XP for Oblivion could run into problems.


Heh, that's because they were originally one line, before I put icons into suffix...


Batch is such a "lovely" language....


Haha, agreed ;)


Not sure I follow but I does not matter, please change it as you think it should be.


I'll try but no promises it will work for me.


Whoops. Duplicate Name (This just moves the stuff to a seperate method)


Hmm, but now I again see the problem why I put it into suffix: I'm using the tango icons and when I put ``defaultIconTheme`` into prefix, I'm getting the default icons instead of tango ones (in FF open-file dialog).


I'm sorry for breaking stuff.
Actually I'm trying to keep the breaking changes in my (internal) v2 branch. I'll post an announcement a few days before I'll merge it into master (watch the repo to get informed). But there will definitely be more braking changes (with prior announcements then).
Use something like gopkg.in/julienschmidt/httprouter.v1 for a stable API.


This reverts the motion of certain things to the seperate method


Do you mean consider a class called StringArray or a StructArrayOf<String> instead of StringBuffer ?


Actually, wait this doesn't work as I think it does. Let me fix.


One thing we could do that I did not is to delete these files. What do you think?


Should we support color (if possible), at least for the cases where we won't actually change files/commits?


make sure your indents are set to two spaces


Please Master Juce let Kitserver 6 code FREE !!!


@mikepetersonccv , The SampleData block is not working due to the fact that the _peopleAliasDictionary does not have any values in it when it is used during the adding of groups ( Line 963 ).  When code in lines 847-854 run to load the dictionary with person alias values, none are found and the dictionary is empty.


yup, since only RealmSwift gets the swift object util


Other than that, LGTM.


Hi @chriswmackey ,
Download the example file from here and open it:
https://www.dropbox.com/s/fuwp2aiaoqehcb5/sunPath_Jun_24_2015_ERROR.gh?dl=0
The acos function may not be changed but the argument it accepts did, that's why it's raising an error.
I can not help you with this further, I have a lot of my own work to do these days. My apologies for that.


Oye ye Kya ha?


A good idea would also be to do some survey research with your users. That way you can prioritize the features they're most excited about and can use the app for their intended purpose.


Test?


ajsdfoiajweiofjawoefjaoiwejfaiowej we arent even gonna use htis


Update the link for the toolkit to https://developers.arcgis.com/android/guide/application-toolkit-for-arcgis-android.htm


Does this commit keep it at a fixed position?


:+1: :+1: :+1:


I caused [CDRIVER-721](https://jira.mongodb.org/browse/CDRIVER-721) by removing this line.


@devdashub Please fix this


* I'd make this function a const one (out of principle, to say so) because you return a copy of the GuidSet, so there's no reason why you shouldn't be able to call this on a const object.
* Considering its use, it's probably even better to return a const reference too. You're not going to make any changes to the result anyway - you just want it to iterate over it in this case.
* Pedantic mode: GetArenaCrowdGuid**s** please? When I see Guid, singular, I'm kind of expecting to get a single one.

All together:
```const GuidSet& GetArenaCrowdGuids() const { return m_sArenaCrowdNpcGuids; }```


It's been deleted on mine and in the previous version (check-style.sh) I'm including this to .gitignore only to prevent these files going to the repository if the the script fails somehow...


Mm, no defaults? Why not use the grove kit's ones?


Sweet :smile:


No additional benefit. It is easier for me not to forget them that they are singletons.


Oh, this is the converter, you're right. Disregard.


LGTM


Good point, I can try to do that before getting it merged.


Ack.


Nit - Query -> Activate


Why do you think the RequiredAttribute should include the name of the required field?  Typically the IValidator that actually performs the validation is what defaults the error message if one is not specified in the attribute.  This is how error message gets created for the StringLengthAttribute ValidationAttribute.  If you use the RequiredAttribute with the cshtml that is part of the getting started, you will see that Html.ValidationMessageFor is getting the following message - The <FieldName> field is required.  An additional benefit to using this approach is that it handles localization.

The OwnerId logic was existing logic that was simply refactored.  What do you believe is the correct way to handle this issue?


[-5.00,0.00] hilarious.


Good afternoon, sir!

When do you think you might update the nuget package with everything that's been added over the past couple of months?

Thanks!


configure your editor to include a newline at end of file and strip whitespaces at end of lines


As far as I can see, this is only used in one place later, so it's probably better to make it a local variable there and remove the extra member.


oh ok :+1:


I'm not sure this is the *best* way to test for a redirect but it sure beats `expect_any_instance_of(ActionView::Helpers::JqueryHelper::JavaScriptGenerator).to receive(:redirect_to)....`.


Why not use `self.components_.shape[1]` as I suggested earlier? that would make it possible to get rid of that redundant `self.n_features_` attribute.


Done!


this doesn't look right


You can drop this line. The fact that data to transform must have the same number of features as the data used during training is a common requirement of most of the models in scikit-learn.


I haven't actually tested this, but it sounds like a lovely improvement! Thanks! :+1:


you are correct there, fixing it now


Sure!


New ref URL is https://github.com/kodi-game/xbmc/commit/079d9cc


Really? Interesting.


jlib/jutil.hpp declares StringArray. take a look at that class, and consider using it rather than StructArrayOf<StringBuffer>
In general StringBuffer is preferred when the contents grow/shrink dynamically, if they're static, strings are a better option


I think this looks like we want a GObject property for the current visualization and for enabling/disabling it. Then you could wait for notify::current-visulation here instead of waiting 5 seconds and hoping that something has happened


Ack.


Please make this message more explicit by including expected and observed values:

```python
raise ValueError("The provided data has %d dimensions while the"
    " model was trained on data with vocabulary size %d."
    % (n_features, self.components_.shape[1]))
```


Check the length of "string[] args" as zero (0) at the very start of the Main method and show the message and then bail out. You can then skip/undo the changes in the file CommandLineProcessor.cs.


Sure! What about moving this tests to "testify"? Is that considered better than Go's std test library for Lantern?
Otherwise I think I'll just write messages, since I think it's informative and probably will help in Travis if it ever fails.


nope


:gem:


you should not remove the licence text


Okay


ok. will change it.


Ok, I was assuming that a message was required to indicate what field was
required when the error/validation happened.

The OwnerId logic should just be removed.

On Thu, Jun 25, 2015 at 12:05 PM, msimons1 <notifications@github.com> wrote:

> Why do you think the RequiredAttribute should include the name of the
> required field? Typically the IValidator that actually performs the
> validation is what defaults the error message if one is not specified in
> the attribute. This is how error message gets created for the
> StringLengthAttribute ValidationAttribute. If you use the RequiredAttribute
> with the cshtml that is part of the getting started, you will see that
> Html.ValidationMessageFor is getting the following message - The field is
> required. An additional benefit to using this approach is that it handles
> localization.
>
> The OwnerId logic was existing logic that was simply refactored. What do
> you believe is the correct way to handle this issue?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/msimons1/visual-studio-tools/commit/7ffe6a6adaca0041219e1452ec1427ac42a780c0#commitcomment-11868260>
> .
>

--
Thanks,
Dave


Thanks; I was looking through jstring and jarray and wasn't aware of a dedicated string array class.


Mm, I'll check.


:) why not


Huhu ^^ Sieht auf jeden schonmal sehr schick aus. Irgendwie zeigt er mir aber an, dass beim Terrain selbst ein Script fehlt und beim Schluchtfuss noch zwei weitere Scripts. Kannst du deinen commit nochmal überprüfen oda sind das noch irgendwelche Überbleibsel die ich rauslöschen kann ?

Bzw. ich vermute mal das ConfigOverrider-Script aufs Terrain und Ocean-Script auf Schluchtfuss ?


I'm not sure I understand, could you give the test and output please?


It's perfectly fine to pass SOL_LOG_LEVEL=666 on the command line. Isn't the check against that case?


Hey decebal, could you start to push commits in a chunk, rather than one by one? It creates a lot of builds on the jenkins the way you  do it currently...


or 2.0, 3.0 ...


Ok, I see now. Thank you.


@eliotsykes Not entire sure what you're pointing to.


I was confident we could record video. My reservations was memory usage and encoding.

A better test would see the max video size you can encode. Can you please post those results? Also, we will need to measure memory pressure over time when recording video to gather estimates for when we are recording in a long running context like the one for competition.

But I really don't see what's wrong with working on collections of individual images. That's how most of opencv function work anyways.... I'd have to open a video stream reader to just extract the individual frames anyways. Just seems like extra work all the way around. All of this is very doable, but why?


This closes #17


Also includes a header in output CSV file now. Makes it possible to sort in Google Sheets.


@mikem8361 There is a lock around the initialization, but not around the usage of the exe_module.lib_name. What I meant is the case when the PAL_InitializeDLL call already returned and the thread is trying to do something with the exe_module.lib_name while another thread is in the middle of the call to the PAL_InitializeCoreCLR.


- `url is not defined`

Forgot to `require("url")`?


Very clever approach! I am trying to think of whether there would be any situation here where we'd end up with a negative number, (e.g. where we should be deleting rather than updating a row), which would clearly not be what we want. I can't figure out a great scenario for that in the real world, though it _seems_ like it's possible. Say someone submits a transaction with a typo in the zip code, and they later fix the zip code. So in that case, we'd be left with a negative total in the old zip code and a positive total in the new. Does that sound at all plausible?


Oh wait, I can comment here too on the line :)


If this was caught by Code Climate and not a test, I think you need to add a test.


Took a quick look looks good.


Ah, ok...I didn't know we had a Jenkins :)
Where can I find it? :P


@nikic I thought so and took the jump. See this PR:
https://github.com/php/pecl-http-pecl_http/pull/4
Time taken      : 1979 seconds <--- for running the 174 tests


in German we say

> auch ein blindes Huhn findet mal ein Korn.


Ty btw :P


i like it


If it is just a warning but it boots up. "Ignore" it ... Else we search for it ...


@eliotsykes

Fixed on the new commit.


Looks good


How did you fix the flickering in Terraria ? I'm trying to see what's causing it.


final.


I don't think that's generally true. For whatever reason the rate change might've happened 2 seconds after we called set_rate() and then we would've only advanced by 3 seconds now


No, but changing
```js
"offset": (time, width) => 0.12 * width * Math.cos(0.05 * time)+768,
```
of `gui/pregame/backgrounds/black_forest.js` to
```js
"offset": (time, width) => 0,
```
would. The texture seam would then only be seen by people using resolutions over twice as wide as tall.


Dafuq?


I generally don't like these "wait 5 seconds and see what happened" tests, they are racy :) It's always better to wait for the event you're actually waiting for instead of waiting for a specific amoutn of time and assuming something has happened by then.

I think here you could work with the position changes. You could check if positions go backwards at some point after the rate change.


if level == 666 this code will not be evalueted because it's bigger than array size (that is static const defined in this function).

This removed check is redundant. Have i missed something ?


Where did the condition go? cc @rcombs


This is the corrected test with the suggested change:

```js
    it('should listen to nested paths before they are created', function (done) {
      var structure = new Structure({ data: {} });
      var i = 0;

      var ref = structure.reference(['foo', 'value']);
      ref.observe(function () {
        ref.cursor().deref().should.eql(10);
        done();
      });

      structure.cursor().update(function() {
        return Immutable.fromJS({ foo: 'hello world' });
      });

      structure.cursor().update(function() {
        return Immutable.fromJS({ foo: { value: 10 } });
      });
    });
```


Procura que los nombres de commits sean más claros :tongue:


What should we do about this inconsistency that we take the URI from self->uri, but for the suburi always ask playbin? Can we ask playbin for the URI too?


Noticed that you capitalized the names so it shows up nicely on the tableview :)
An alternative, if you don't want to or can't edit the source of the data, is a function called `capitalizedString` : http://stackoverflow.com/a/26306372
You can use it in the `cellForRowAtIndexPath` function when you configure the cell.


Why do you stop freeing/unsetting the current suburi here?


When you do this, doesnt that mean you are no longer using the backlight? Was the intended?


yep


Introducing a new method is fine, but for efficiency reasons the original first line here, should remain:
`if (this->node() == node) return this;`
If there are no other major issues, I will merge the PR and change this.


Here's what I think would happen if somebody fixed a zip code:

* In the initial aggregate, the contribution is attributed to the wrong zip code
* The zip code is corrected
* The original row is added to the old queue
* The updated row is added to the new queue
* Later that day, the batch update runs
* The original contribution is subtracted from the original aggregate bucket
* The new contribution is added to the new aggregate bucket

As long as every row is either included in the initial aggregate or added to the appropriate queue(s), I don't think we can get negative numbers. The periodic updates will run in a transaction, so I think that all rows pushed through GG during the update will still make it to the queue tables.

That said, I think we should probably rebuild the aggregate tables from scratch occasionally--maybe once every month or two over the weekend. And we can add a check at this stage to ping the maintainer if negative numbers are ever observed. I don't think it can happen, but if it does, I want to know about it.


Store también necesita el Id de Manager (Employee), puedes usar la referencia desde el Fixture de Employee.


Yeah, but I think that as you listen to change on `['foo', 'value']` and with the first change on `foo` it should trigger the listener twice. as a change on `foo` (as a parent of `value`) is essentially a change in `value` as well.


just to confirm, `emplace_back` is appending these to the vector, so `/opt/puppetlabs/facter/facts.d` is tried first, `/etc/facter/facts.d`, and so on, like we did in facter 2.4.4?


Approved ;)


Yes.


Sure. Other requirements might need to be verified as well.


Wrap first


OK


Aha - yes did not think of that - so probably this remains out (although an option later would be to just try to load and warn if failed - but the code at those parts needs a facelift, so this is 307+)


I've made alignment independent of bitmap width, so it's unnecessary.


Also I noticed users complaining of freezing up like SoDs with your new version. Maybe this is the reason why.


Why did this expand?


ok


This looks great. Simple really.
To Pictures and TimeLapses, we should add a description field too, in case we want to include a short thing about why that picture is important or interesting. See DeepTime Pictures below.
Yes, we should include EXIF data. It can just be display in a pop-up box.
I think the DeepTime will just be clones of Pictures. These will be manually uploaded imagery though. Otherwise, should be the same as Pictures.
I'm gonna write this all up and another conversation with Mariah today. Should merge today.


^ correct


Alternatively you can simply have `{}` instead of `QStringList()`.

I will change this if I merge now.


merging new functionality


@lmr, sure, but at least to have Avocado Server on Read the Docs, this is urgency. After the integration with the Dashboard, I'm planning to update the requirements and check if everything can work good then.


final


Sure


Thanks for the update. We will get these changes included in the next release.


nice


closes #49


Actually the code is making use of position. So i store the current position in args and after 5sec callback is going to called in which will query the position again and then compare if position is moved backward. Maybe instead of doing GST_CLOCK_DIFF (previous_pos, cur_position), I can do < comparison.


TeamCity Xbim :: XbimGeometry :: XbimGeometry [Build 6](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=15&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 03:19:22


for the record, I find the earlier version much more readable


I've done some basic measurements with the u8g_graphics_test.lua script which runs for ~13 sec in a tight loop. The results show that the frame rate drops by 27% from 7.4 fps (dev branch) to 5.4 fps.
When I add function caching here and there the frame rate can be increased slightly to 5.7 fps (23%). That's quite a trade off for the additional heap - but hey, 16kB is a strong argument.

Hope you're able to submit this to upstream soon. It'll probably have a big impact on the @nodemcu community. I'm prepared now with u8g and will stand by...


@wallneremil do you remember why it was necessary to bump the version?
I get a peer dependency error unless I specify `^0.12.x`.