This doesn't seem quite right.  `time()` should return a time referenced to UTC.  Shouldn't you use `localtime()` here in order to see the daylight savings time change?

The only way this works correctly as is, is if the pebble SDK has a bug which makes your app_timer_callback not actually happen in 1hr when there's a timezone change, but instead take 2hrs (or no time at all)?  I guess it might be best to check both `time()` and `localtime()` in that case... but I really hope that the pebble SDK isn't that broken!


frankly I don't see the advantage of using StringBuilders'  .append(String.valueOf(<value>)).append(',').append(String.valueOf<value2>)).append(',')...
versus the current String.valueOf(<value>)+','+String.valueOf(<value2>)+','+....


The following snippet would solve it for all `FormType` that accept the `choice_translation_domain` via the `OptionResolver`. It would make line 49 obsolete.

```twig
    {%- if form.parent.vars.choice_translation_domain is defined -%}
        {{ form.parent.vars.choice_translation_domain is sameas(false) ? label : label|trans({}, form.parent.vars.choice_translation_domain) }}
    {%- else -%}
        {{ label|trans({}, translation_domain) }}
    {%- endif -%}


@tchap fine then.


I don't think that needs explaining.


Because it's a sparse matrix, it can contains holes. For instance, if SOL_LOG_LEVEL_WARNING == 10, everything between SOL_LOG_LEVEL_ERROR (2) and SOL_LOG_LEVEL_WARNING (10) will contain NULL pointers.

What you are suggestion is something that i've done wrongly in another pullreq


Cool!


This is one in a series of checks that needs to pass to get access, so I don't want to return access_granted if it does pass, but I want to return the error if it doesn't


this should not have been here, will remove in a new commit.


You did stuff that ended up in the package -- that's a contribution :smile:


Why does this assertion use "assertIsInstance" while other tests use "self.verify_error_type"?


I'd swap those arounds, on the grounds that `initpeercount` is likely the more frequently used option.


Hi Laksono,

A minor suggestion, which will make the code more robust. Currently, if you execute the binary without any argument, it will fail and output a C++ exception/error. I suggest you to handle this error in your cpde and output the user a message of how the file should be executed.


Also, it’s »Danila« :)


This feature has been introduced by @FHenry at e15d4c04.
How do I know that? I used ```git blame```.
Maybe you should ask him what it's for?


:+1: If you want some dangerous patches, I can go to fix some deprecations to get us on 1.13

I will be eager to see your post about migrating Ember.js project from 1.13 to 2.0!


oh, yep it should be 5, I probably copy and pasted or something


Why that parameters are paramStandard instead of paramApp?


It's consistent with our code. We are checking for < 0 in a lot of syscall calls. For instance,

open(), read(), ioctl(), dup() ....


"changes done "


I deliberately put it next to `<peer> ...`, since it's about peers. But, it's not about peers in quite the same way `<peer> ...` is about peers, is it ...


Fair enough


Woops, white is British `colour`. I've fixed (and merged) in ca5076b977fd56f55745393cc0980e45cd9585f4


FYI, while this is cleaner, we do have the ARR_X macros (I think with up to 6 or 7 args) that will properly format the array for a macro and get around the comma issue in the preprocessor.


With commit, I get 400 response code, meaning that there is some error in the header. If someone can review with a fresh pair of eyes, this could be something even trivial that I am not looking into.

sinatra app for testing is available at https://gist.github.com/shankardevy/535f48fb4583425049c3

with the sinatra app running, the following code should get the 'secret' content.
```
HTTPotion.get "http://localhost:3000/digest", [digest_auth: {"foo", "bar"}]
```

Right now, it gives:

%HTTPotion.Response{body: "",
 headers: [Connection: "keep-alive", "Content-Length": "0",
  "Content-Type": "text/plain", Server: "thin"], status_code: 400}


JoinableTaskCreationOptions should be available with Visual Studio 2015 RTM and SDK


Was this intentional?


:+1: Thanks! This is great!


Ah! That's a good point actually. The two *are* related. So leave it as is.


The rest of the docs use the default name of `build.json` instead of buildConfig.json. But the name of property `buildConfig` is fine.


Great. Once its safe to remove the current service accounts logic in
heapster, let me know and I will get rid of that code.

On Mon, Jun 29, 2015 at 1:24 AM, Jimmi Dyson <notifications@github.com>
wrote:

> @vishh <https://github.com/vishh> @mikedanese
> <https://github.com/mikedanese> If inClusterConfig uses service accounts
> without any extra config then that's fine - we'll need to rework our config
> for OpenShift, but that's not problem at all.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vishh/heapster-1/commit/4327b8810481e15067b0b720932d8f8d6fa0fe0c#commitcomment-11905153>
> .
>


Since `platforms` is added, should `plugins` be also added.


This commit completely breaks release/3641, we get a big crash at the main menu


Nou is correct here, for example this line:
`HASH_SET(_settings,"hCam",[_deviceID,"hCam"] call FUNC(getSettings));`
Should instead be:
`HASH_SET(_settings,"hCam",[ARR_2(_deviceID,"hCam")] call FUNC(getSettings));`

It's the same as when using QUOTE macro in config for example.


2.0.0 is coming :D


Maybe call _dirty_maybe_save() instead of _maybe_save()?


Great commit


Cool. But as long as we are being defensive about this, why not make a helper method for parsing whatever tag from the tag hash, together with the try/catch, desired default value, and relevant error message? Then you can reuse for both width and height (and maybe other tags as appropriate)?


@henriksen does the --watch flag now restart the server?  Previously it just killed the server


Was contemplating whether I should have commented on if this should not be split but it looks like you addressed it here anyway :)


Apparently I'm the nitpicky import police. This should be moved up alphabetically.


Cool will bear that in mind when i get round to fixing/finishing the drawing tests.


:shipit:


develop (kbenne) - Win64-Windows-7-VisualStudio-12: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Scrambling the bytes that held the password is a nice idea but I think it's ultimately futile. The same bytes are also present in buffers used for http requests, protobuf parsing, etc. Go's allocator guarantees that new allocations are zero-filled so there's no danger of the bytes being exposed when the same block of memory is reused (as could happen in C)


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (647 of 647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.33%25-green.svg)


Cheers! Glad I could help :)

-Lucas
“Valar dohaeris”
#DecimateTheErrorRate
Please consider the environment before printing this email. 

-----Original Message-----
From: Veronica Kahl Cary [mailto:notifications@github.com]
Sent: Monday, June 29, 2015 11:10 AM
To: theVKC/VKC-Script-Changes
Cc: Lucas Shanley
Subject: [VKC-Script-Changes] Added @lpshanley's change in to my branch (38c08d3)

Added @lpshanley's change in to my branch

`next_payment_amount = FormatNumber(ObjExcel.Cells(MFIP_memb_excel_row,
4).Value, 2, , , 0)` and so forth (thank you Luke!)

---
Reply to this email directly or view it on GitHub:
https://github.com/theVKC/VKC-Script-Changes/commit/38c08d33242a7746be9dcbf9f80eb69ab5d104f7


String Last_Argument;
si same, no need of __T("");


shouldn't mention 'container'; the router knows (nearly) nothing about containers.


typo "thata"


You should not import `Query` unless you absolutely have to. In this case it's better to do `createRecord` on the store.


@janl great point. Thanks!


```python
from courseware.access_response import (
    AccessResponse,
    MilestoneError,
    MobileAvailabilityError,
    StartDateError,
    VisibilityError,
)
```


Ya, python 2 and 3. Just so they know when they run into it.


Remove new build until issue fixed.


see https://github.com/ceph/ceph/commit/abd06355dbbcd8db26af12557cb4b687e68aa463#commitcomment-11895337


Nice idea @ctrueden, but I have never met a width-free image in the wild (and we have opened a lot of dm3 images at this point!). Height free images do occasionally occur when spectra are measured. So I don't this is worth refactoring, but it would be good if the fix went in to Fiji because I have bug reports for this issue from two users now. Thanks, Greg.


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Use the [RSB](http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0068b/BABFCICD.html) instruction to achieve it in 2 instructions instead of 3. ;-)


... Woops wasn't pay attention to my commits and somehow missed the + symbol >.> thank you


Parens are better than backslashes for continuing lines.


`const`


typo: it's type => its type


@sarkiroka I understand you're upset, but I'd appreciate more constructive feedback if you want a decent response.

I'd love if you watch this talk on providing good feedback/criticism and I hope you take it to heart and use it in the future: https://www.youtube.com/watch?v=PJjmw9TRB7s

Now to address your concerns.

We don't "drop the original stack trace", there is no stack trace. If you follow the flow the `if` and `else if` you'll see in both cases where we create our own error, it's because the error *was not* an actual error. It's either a string or not an instance of an error. Because it's not an error, there is no stack trace.

Does that make sense?


This backslash will leave all the indentation whitespace in the string.  Adjacent string literals are concatenated, so you can do this:
```
developer_message = (
    "Course does not start until {start} "
    "and user does not have staff access"
).format(start=start_message)
```


@financeCoding wrote above before I saw your email. I'll reply directly to you email.


I think it helps much for better balance of air/ground pushes - once tuned nicely.


@TheDash Hey Devon. Thanks for the comments. You can go ahead and change the name of repository. A lot of this code was written by the team working on the grasper before me and I guess the plan was just to get it working then. I will have a look at the ROS dynamixel tutorials this week to make the necessary changes and will let you know once it's done.


"dnx --watch <command>" will watch the project directory and die (along with <command>) if there are relevant changes. It will not restart. Kmon now starts "dnx --watch <command>" and restarts it when the process dies.


Replace the `/` with the requested url (Split[2]). Possibly with a `/` in front. (Either `Split[2]` or `/ .. Split[2]`). You'll have to test that. The `Host: ...` isn't needed.

After that you can simply connect using `cNetwork:Connect("pastebin.com", 80, ConnectCallbacks)`


I'm not sure about this one; newer plugins I've seen don't use it; works without for me.


oh whoops


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 13](https://bsr.ict.je-labs.com/viewLog.html?buildId=30469&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) is now running


There is no need to specify the group explicitly here.


Fikses i https://github.com/digibib/ls.ext/commit/ae235ab0778b413d8ef74a642cad84ab74b12ba0 og https://github.com/digibib/ls.ext/commit/862b9cc0dae329b7c88ee76673fa7fe8260418e1


I did—it's on this branch:
https://github.com/kellymason/bloccit/tree/assignment-29-css


"dnx --watch <command>" will watch the project directory and die (along with <command>) if there are relevant changes. It will not restart. Kmon starts "dnx --watch <command>" and restart it when the process dies.

-----Original Message-----
From: "Shayne Boyer" <notifications@github.com>
Sent: 29.06.2015 18:09
To: "henriksen/kmon" <kmon@noreply.github.com>
Cc: "Glenn F. Henriksen" <glenn@henriksen.no>
Subject: Re: [kmon] Removed dependency on nodemon and just uses dnx --watchinstead. Now it also installs as a global command. (afa5e3f)

@henriksen does the --watch flag now restart the server? Previously it just killed the server
—
Reply to this email directly or view it on GitHub.


hpwh_residential (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1666 of 1673 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Nope, I deleted this commit and the tokens been revoked (we will have to update the tokens for bot)


@ariarijp さん, ありがとうございます！ ( https://speakerdeck.com/ariarijp/xi-ri-mu-li-dot-rb-1zhou-nian-ji-nian-hui-lt-crystal )

It's true that for JSON parsing you need to cast, but there is a nicer alternative which is often used:

```crystal
require "http/client"
require "json"

class WeatherResponse
  json_mapping({
    weather: Array(Weather),
  })

  class Weather
    json_mapping({
      main: String,
    })
  end
end

URL = "http://api.openweathermap.org/data/2.5/weather?q=Shibuya"

resp = HTTP::Client.get(URL)
response = WeatherResponse.from_json(resp.body)
puts response.weather[0].main
```

You can define the structure of your JSON and then use `from_json`. This is not very well documented yet, so don't worry for not knowing this :-)

In this way you get type-safety and you only specify the mapping once, and you don't have to cast everything (it's also much faster).

More examples [here](https://github.com/manastech/crystal/blob/master/spec/std/json/mapping_spec.cr)

Again, thank you very much for talking about Crystal and spreading the word!


Hey, thanks for noticing, I used this for a small test and i forgot to remove It.
I will fix it, thanks again.


*vendor not config/common
lel, made a mistake


This change prevents current toolkit version from being stored to an xml that was edit with a previous version.  Not what we want.


I expect we won't re-use the gaps unless we really need to, since people might have build logic that depends on them. Most of these errors are duplicates from the compiler rewrite, or errors of the form "X is not supported yet", so there shouldn't be too many gaps over the long term.


Müsste hier nicht der Mail Titel überprüft werden oder ist nur die Methode unglücklich benannt?


You can do it now - we use released versions so will update once the next release is out.


let's not change the whitespace conventions everywhere — makes it very hard to see where the real changes are.


I meant this, is this intentional?


Does this assume that rule protocols are specified in code by their number rather than `'tcp'`, `'udp'`, `'icmp'` or is there some kind of magic that ensures those values are always mapped to their numbers at this point? The `{'1': ...}[protocol]` looks a bit fragile otherwise.

I'd probably also switch `{2}` and `{1}` around in the string formatting for clarify of argument order, but that's just style.

Otherwise looks OK.


фыв


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 13](https://bsr.ict.je-labs.com/viewLog.html?buildId=30469&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) outcome was **SUCCESS**
Summary: Running Build time: 00:05:33


Fixed.


Too late it's com.miui.core instead of com.miui.sdk now.


No problem, I will merge it.

By the way, how does that file work with Bio-Formats? Any better? Or same bug?

One other question: how would you feel about being the official maintainer for this component of Fiji? Then you could merge things yourself, etc. I'd really like to move Fiji toward a more formal list of maintainer(s) per component, with well defined maintenance and development status levels.


No


And what about the `1.25`? It's uncommon to use a non integer multiplier


Ah, here's were things went bad.


Otherwise looks good to me. Did you send a PR?


these are both fair comments, and I shall leave them for @Jc2k to clean up ;)


No reason, it's simply wrong.


will we miss part of traces?


[ Quoting <notifications@github.com> in "Re: [fleet] Merge branch 'metrics' ..." ]
>@miekg I tried the modifications in this branch and changes that you did (removing the watch) helps a lot but it just moves the problem to the next etcd bottleneck, the get and put operations to create and schedule units in the cluster. I'm adding this branch https://github.com/giantswarm/fleet/commit/c2185b2a062f5a0931e9b4607bc94263c67f0728 to yours and see if this reduces the etcd load

Thanks!

I tested this loadtest1 branch today. Fleet worked fine and the load on etcd was
a fair bit lower. So it looks good. I will test things some more tomorrow.

/Miek

--
Miek Gieben


I do prefer your suggestion @Rvanlaak, thank you. :)

I've made a new commit to apply your suggestion. The [new diff](https://github.com/Restless-ET/symfony/compare/2.7...Restless-ET:fix-choices-translation-for-expanded-choice-type?expand=1).


You could use only one media query and nest all corresponding styles under it


Just checking in to see how this is going. I'd be happy to accept a pull request when you're ready to push these changes upstream.


thanks - https://github.com/iBotPeaches/Apktool/commit/d5f3b3fd5aad4c54f5e3e74d349f509176a87cbd


あれ？これはソースだとsampleでinstall したものだとsamplesになっている？であれば変えたほうがいいですね．
変更するとぐらい副作用あるんだろう．

--
◉ Kei Okada

2015-06-29 21:18 GMT+09:00 Shunichi Nozawa <notifications@github.com>:

> @k-okada <https://github.com/k-okada>さん
> hrpsys-baseのサンプルディレクトリはsampleですが、インストール先ディレクトリ名がsamplesになってるのはなんででしたっけ？
> install先のファイル（環境モデルのwrlなどもろもろ）を参照しようとして、時々タイポ的なかんじで間違えてしまうので、
> どちらか一方に統一されてるとうれしいと思いました。
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fkanehiro/hrpsys-base/commit/7901fb17eb050c8fd9667f7b94854a0b07cd728d#commitcomment-11908788>
> .
>


Thanks for catching that boo-boo on the about page as well. :+1:


Perfectly acceptable.


anyway the server can respond with a boolean and not a string?


Hi @UtahDave I can see that you removed the extraneous msiexec=True , and you should know, not trying to argue with you on  that. ;-)
But the html docs for windows packaging that the Readme.md file points to is full of examples and text telling folks to add msiexec=true for pkgs to be installed with msiexec ? What gives?


can we just delete this line?


:tada:


I'm not sure this is correct... this is the version of scoverage (the compiler plugin) not this library sbt-scoverage.


I am sure I missed some important changes in 2.1. Please add them.


For the operation of this plugin, I should download ChestRefill ?


I'm pretty sure the convention we were using so far was to always return `true`, so that we could collect as many errors as possible in a single pass.  (The boolean value allows to short-circuit the visitor.)


[..] tools.<Here you have to put a space>That <no abbreviation> **is** [...]
Please take care of that.


@aeoncleanse Make an issue, reference the commit, include logs. Please.


I suspect this might take a while. Focus on learning what is necessary to make it a compliant piece of software, and implementation secondly.

No rush here, quality preferred over readiness.


@seelabs I did not remove the test case for delivermin > saDstAmount: https://github.com/miguelportilla/rippled/blob/07ca8db830aee09d20f4e10989dd7a4126a91124/src/ripple/app/tx/tests/DeliverMin.test.cpp#L51

I did however modify it to expect a tecPATH_DRY instead of a temBAD_AMOUNT. If someone ever added the check again, they would be be forced to update this case back to temBAD_AMOUNT.


see #236


So I will change it.

2015-06-29 18:31 GMT+02:00 Sebastian Jennen <notifications@github.com>:

> No reason, it's simply wrong.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/buddhi1980/mandelbulber2/commit/fb7683443721fe2df4f46c765c92690812b359d6#commitcomment-11913877>
> .
>


fix typo error in zh/02.6.md


Sure. Will do


Thanks for adding us to the sponsors section!


@deepak1556 oh awesome thanks for that! I actually got it working (had a typo in my domain name, doh!) but it's really good to know how to debug an issue like that. Still learning how all of this stuff works :)


Also need an entry for this in the 'configuration' doc.  (Looks like we've got a bit behind and are missing StartupCleanupDelay - please add that too.)


This override doesn't access the list from the parent. As I understand it, the parent _should_ be empty if there's a `MetaView` on top of it, but is that an invariant?


@LeaYeh Syntax error in url ...


It was a value that *felt* right. But now that I think about it, `$discussion-width-info + $default-spacing/2` makes more sense.


Maybe leave out the word >>Don't<< in subject titles.
Personally, it always puts me off reading it, while I DO think the content is important here.

Instead we could use a positive approach. For instance, make it a plain subject title (i.e. 'Offending, 'Discrimination') and explain. Something like:
"Flirting is something humans tend to do". However, we are an online community with participants of different cultures. Flirting, even lighthearted, can cause discomfort. So please, think before you start or better yet, cut it out."


you can actually make this be 'multiplicity="?" initial=""' now.


This is OK, but a better test would be to use `-x` instead.


Looks good!


`txList` is for debugging, so it doesn't really matter. This routine does what I need it to do, for comparing the experimental open ledger I'm building against the real one. However, you have recognized one of the interfaces design flaws in the `View` hierarchy. I haven't thought of a comprehensive fix for these flaws. For now they are manageable. I'm going to keep building out code to see where it goes and see if there's any more design flaws. Then I'll circle back with a better understanding of the needs of the system and try to fix the flaws.


Looks ok to me.


good, monkey patching is terrible.


Sorry, comment was  meant here : looks OK to me


Right. Done.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.4.452.906d1df991304ea46024abe54f48da36e54b7097](http://build.palaso.org/viewLog.html?buildId=59007&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:32:27


Hi,
Can you, please, update the NuGet package for these last changes?


Nice that did get it off the queue quite a bit faster.


@mogadanez could you please file a GitHub issue and PR for your suggestion? Thank you.


Shouldn't we separate the release notes between the branches? I.e. not include 2.1 in those in master, and start a fresh file with only 2.1 in next?


Sure. I will update it once I get home this evening.

Thanks,
On Jun 29, 2015 12:48 PM, "leo-gan" <notifications@github.com> wrote:

> Hi,
> Can you, please, update the NuGet package for these last changes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rpgmaker/MessageShark/commit/ce32b2dd4f45d01df30cbb464564dcd297923d41#commitcomment-11914139>
> .
>


I'm pretty sure this change is incorrect; dependencies need to appear to the right on the linker command for --as-needed to function properly.

I think the correct solution to this is presented in #20. I would suggest reverting this commit and applying that change.


Thanks


Wir haben auf anderen Seiten die Form "_innen"


Maybe leave out negative example reference to other communities.


Andere Seiten haben die Form "_innen"


Nice.


Good job! @Audryc
cc:  @ajschumacher @jonhanke


I'll have to trust your competence on this. I'm okay at CSS, but just okay :) Merge it in if you're happy.


Vielleicht "Alle Anwender_innen"


it could be worth renaming to `debugTxList`


hello @allisonchau
Vim for editor; sublime for graphical:  sounds good!
cc: @ajschumacher cc: @jonhanke


Simon, do you have a test case that can be reported?


add text to constants


@Audryc
Vim for both terminal and graphical sound good!
cc:  @ajschumacher cc: @jonhanke


.
![cat](https://cloud.githubusercontent.com/assets/13099576/8413393/73de7106-1e90-11e5-999f-61322aaeafc8.png)


Yeah, people should add msiexec=true if it's an msi. This package definition had msiexec=True twice and that was causing yaml compilation failures.

Maybe we should remove the msiexec=true and just checking the file extension for .msi.  I don't recall if there was a reason to not always use msiexec.


Fixed in 28f4b8d63e5a8d4806cfc08697e6521f4ab094c1 ...


Looks good...I am interested in continuing to work with you on this if you feel the same.


@TheBigBear I'm not 100% sure I understood your question. Am I off base?


What's the difference between that one and the others?


Leaving these in the repo prevents `link-sources.py` from succeeding.


hello @tylermuch  williames


This looks wasteful. We should probably do this once (for the group 0), apply the face properties "manually", and return nil at the end of that form.


We aren't working on PIN validation


Yes: `description: Books returned`


please, check markup.
there should be white spaces before parameters


Thanks guys! Totally forgot about those :)


GG on making a small mess in the history :p
That's why you should only work in new branches, instead of the master branch. Easy to pull the plug when shit hits the fan and no one will notice anything.


This file has redundant functionality with bonecard.js. Please update the new bonecard.js to have the proper function. Please look carefully at what was implemented previously and how while you are removing the old functionality.

See a1e4efb3b4cf1ed6dabdae9ad5534c72cccb21dd.


'wir' is a typo. I fixed that.


"dev" has been used to show a difference with "des" (for "DesktopUI").
But I believe you have done this because "de" is used several times later in this file...
Too bad [this wiki page](https://github.com/hrydgard/ppsspp/wiki/i18n-translation-pointer-names) is not really followed :/


This commit really changed the Ruby regexp too, didn't it? The message doesn't mention that.

Could you maybe add comments with the different cases it handles? Maybe also switch to the `rx` macro for extra readability (up to you).


@codeLaw  cc: @ajschumacher @jonhanke
Good job!
Additional Note:  xargs is a command used to execute commands based on arguments from standard input


add limit statements to projectTask and projects collections query


Since it's not used anywhere on this branch yet, there is certainly flexibility.


actually put a comment here or remove `//`


Perhaps it would be neater if `Prefs.GetFromCurrentProfile` simply returned empty tables over nil?


Good catch, thank you!


There's no such header. Better add yourself at the end of `Author:` (see the preferred syntax in the top comment in `lisp/emacs-lisp/lisp-mnt.el).


Ooh, that's really nice! :+1:

The sub-items should probably have a different color, maybe white?

![](http://i.imgur.com/Q4jsYJX.png)


@cgerson cc: @ajschumacher @jonhanke
thanks for adding cheat sheet


@arranf  very cool! Looks great!


`let ((*print-case* :downcase))` and `unwind-protect ... (setf *print-case* *old-print-case*)` do not work here.


this definitely doesn't do what it says and nothing is using it so let's just clean it out :put_litter_in_its_place:


@crookedneighbor This commit is causing issues with my local install. Reverting to the previous commit fixed the problems I was experiencing, so I'm sure it's this one.

With this commit, the front page looks like this:
![selection_011](https://cloud.githubusercontent.com/assets/7059890/8413437/687c650c-1e5e-11e5-96e6-c89f73451ae6.jpg)

Additionally, the "Play for free" buttons do nothing, effectively making it impossible to log in.

Console error:
```
Error: [$injector:unpr] Unknown provider: ChatProvider <- Chat <- AuthCtrl
http://errors.angularjs.org/1.3.9/$injector/unpr?p0=ChatProvider%20%3C-%20Chat%20%3C-%20AuthCtrl
    at angular.js:63
    at angular.js:3994
    at Object.getService [as get] (angular.js:4141)
    at angular.js:3999
    at getService (angular.js:4141)
    at Object.invoke (angular.js:4173)
    at extend.instance (angular.js:8441)
    at angular.js:7693
    at forEach (angular.js:331)
    at nodeLinkFn (angular.js:7692)
```


hello @Audryc cc: @ajschumacher jonhanke
Cheat sheet - should be a list of at least 10 commands; will be very important and useful for this bootcamp.
 xargs is a command used to execute commands based on arguments from standard input


remove space before types in map declaration


:+1: You should also write simple spec for it.


@hairlessbear thanks, it's a know bug and should be fixed in a few hours, in the meantime if you want to use your local install reverting is your best option


OK; point taken.


it doesn't work on my zgpax s8...still unusable


@dmitriy-serdyuk


About time.
Do you want to save this session?
Do you want to save this session?
Do you want to save this session?
Do you want to save this session?
Do you want to save this session?
taskkill -f -im mapleshark.exe


Rather than discuss style, let's just run js-beautify ahead of any new commits. If you have functional changes, run js-beautify on the file FIRST and commit those changes before moving on to functional changes. THEN make functional changes and run js-beautify before committing those changes. That'll keep our commits clean. I'll probably run js-beautify on most of the .js files myself, but we shouldn't have any conflicts if we both agree to run it on all JS files (and commit the changes) before doing any additional edits.


Then we loose all history of previous releases. The same issue was with r2964 to 2.0 transition and the whole changelog was kept.


oh, here's the commit: ccb33bb8ba8eaebde67baa5dd30fdf6677fb594b


@wilkung cc: @ajschumacher @jonhanke
Good job!


@maartenkling Were you having the same traceback as the one in https://github.com/plone/buildout.jenkins/issues/20?


Or just 'Place'? :lollipop:


Sorry to nitpick, but could you just import the name NanGuardMode from theano and put the deprecation in a warnings.warn call that happens on import? (I.e. no indent). No need for a new class.


Why are you use this method?
There is a TimeConverter class, that executes needed logic


The schema appears to say that it returns a single Book?

```yaml
schema:
  title: Book
  items:
     $ref: '#/definitions/Book'
```

Or am I misunderstanding Swagger?


@rouault what should be done in case 4 values are not there?


You can have a look at my commit in our fork as a reference. This one works nicely for quite some time here. In particular, I'm a little bit unshure about your expression in line 1560:
if (dir != null && dir.isDirectory() && !dir.exists() && !dir.mkdirs())

I would remove the && dir.isDirectory()

Everything else: LGTM


Are you sure this will work with ssl=None? (I don't know, just asking.)


localtime() was broken in 2.9, it might work in 3.0. I have no PT to test though. Checking for localtime() alone should be sufficient since I'm interested in the relative time difference.


I thought the intent was for them to be the same.
On Jun 29, 2015 9:37 AM, "Sam Halliday" <notifications@github.com> wrote:

> I'm not sure this is correct... this is the version of scoverage (the
> compiler plugin) not this library sbt-scoverage.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jedesah/sbt-scoverage/commit/9f29c92700192db0f678853da85b8c4904d35f21#commitcomment-11913974>
> .
>


@idgserpro Correct!


AddCalcCoilSurfTempSource (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1671 of 1671 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@paglias :+1:


Consistency, all method arguments should start with a capital letter as per UE4 coding standards.


Should be METHOD


answer Dylan's comment in section 3


Consistency, as above.


I'm no swagger expert, but I don't know how to define an array returned vs a single unit. maybe you define books as an array with a ref to the book model?


One fix: I think the default state should be to have de novo assemblies hidden.


In Person class ssl can be nullable, I suppose that it should work.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


repr(Rust) was motivated by two things:

* being able to randomize layout for fuzzing against bugs that "happen to work".
* being able to shuffle layout for optimization

However this does not require leaving *everything* unspecified. In particular `NewType(T)` being anything other than T at runtime is ridiculous.


OK I'll fix it.


The 'latest' has not removed, just the duplicated code


@cptvitamin We have these html changes only. Can you please do a review. Below is the sandbox link
http://tnl2490.m.sandbox.edx.org/courses/course-v1:edX+DemoX+Demo_Course/courseware/interactive_demonstrations/


Method arguments should be capitalized everywhere


Don't think this is used here, but looks like it's used in the next case management pr


lgtm +1


Oh, woops. That was unintentional.


I removed the other reference to 'pch_VA_max_size' and restarted the build, but got another error: undefined reference to '__EH_FRAME_BEGIN__' while linking libgcc_s.dll.

Did you have any success building GCC 5.1.0 i686 dwarf?


Perhaps the engine_elo string can be added to self.engine_name in the ["Black"] or ["White"] header? Like this: "Stockfish (level 10)". Putting it in the "WhiteElo" or "BlackElo" header is not in accordance with § 9.1.2 of the PGN standard: these headers should contain integer values.


So the change is that it should only happen once?


No se mira


Thank you. Could you please also push a git tag to github?


Esta es la prueba


Yes I prefer we keep the history in the release notes!

2015-06-29 19:06 GMT+02:00 Damjan Adamic <notifications@github.com>:

> Then we loose all history of previous releases. The same issue was with
> r2964 to 2.0 transition and the whole changelog was kept.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opentx/opentx/commit/f592a78b4b4d20a1e75fec27edf01cc043b0f71e#commitcomment-11914521>
> .
>


lol, fix by deleting the failing test


`userUser` ?


What would you suggest?


That seems reasonable? We can check out the Swagger docs.


You should create a variable e.g. $LUAC_PATH instead of duplicating this entire line for OSX and Linux.


hereinafter move all hardcode to constants


look after spaces


Yes, sure.

On Mon, Jun 29, 2015 at 1:07 PM, David Warde-Farley <
notifications@github.com> wrote:

> Sorry to nitpick, but could you just import the name NanGuardMode from
> theano and put the deprecation in a warnings.warn call that happens on
> import? (I.e. no indent). No need for a new class.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hantek/pylearn2/commit/5a8b39ea50cb324a414bf1a112a7ea971247bbfc#commitcomment-11914546>
> .
>

--
LIN, Zhouhan
Department of Computer Science and Operational Research
University of Montreal

Phone: +01-514-553-6037
Email: lin.zhouhan@gmail.com
Homepage:http://zhouhanlin.webs.com/


esqueleto espress-generator


Oh ok, yeah that makes sense. I'll modify it.

> On Jun 29, 2015, at 7:46 AM, David Qu <notifications@github.com> wrote:
>
> I mean having like static/bootstrap-3.x
>
> —
> Reply to this email directly or view it on GitHub.
>


hpwh_residential (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1672 of 1679 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Yeah, so the problem was becoming first responder triggers the `rac_textSignal()` to fire, and if there is already a month there, then year text field becomes first responder instead, which for some reason causes text fields to render incorrectly.


My first commit.


Haha, typo from the [existing line](https://github.com/artsy/eidolon/commit/95a33aabe3ff0b5f4180f11137118bbacb6fa080#diff-844df387cbaf4d5fc5c241ab8f620d31L170). I'll fix.


Oh yeah, quirks for everybody! :tada: :+1:


I think, that it will be more elegant decision to create constructor for NodeWrapper class, that takes Map with conditions as a parameter


This could just be XOR with 0x8000, I believe.


Tried to find something, but couldn't find a way to make it return only a boolean. I guess I could make it give a JSON object with only a boolean in it, but Im not sure that would be any better.


This is not compatible with Nexpose and has introduced customer issues and an automation regression: DCA-1943


And I had to export `withLoadPackage` from `Stack.Build`


add empty line before and after for loop, if for loop placed between other code instructions


Looks good!


Yes. I think the way numpy builds its namespace is nice. They do both, flatten the namspace by doing `from .x import *` at the top level and they also import the individual modules at top level to mirror the actual hierarchy. Additionally they set up `__all__` at top level to include just the flattened stuff, not the modules. I'll add that as well.


The type alias `M` here had more constraints than necessary, like `HasTerminal` which I did not want on the functions in `Stack.Dot` so I took the liberty to use the minimal set of constraints.


Ack.


@rouault i'm not sure if we can do anything about that.


@toddboom @pauldix This was John's baby and no one else is doing anything to maintain it. Kill or find a new owner?


Can you provide me a screenshot so that I better see what's going on?


It shouldn't be needed to || 0 since this.delay is guarateed to be define since line 24


:sunglasses:


One more change


This part of the spec confirms this behavior:
http://www.w3.org/TR/html51/syntax.html#attribute-value-(unquoted)-state


All tests using buildout-jenkins are breaking. Do you think it would be the case to create a new release of plone.app.upgrade, 1.3.11? Without this release we need to add ```Products.CMFPlacefulWorkflow``` in all of our packages in our CI infra-structure to make it work.

Anyways, thanks for the fix!


Later..:

The && dir.isDirectory() has to be certainly removed!

From the doc of File.isDirectory():

Returns:
true if and only if the file denoted by this abstract pathname exists and is a directory; false otherwise

Therefore if the directory does **not** exist, the expression-evaluation (left-to-right) would never arrive at dir.mkdirs().


I'd say issue a CPLError and not modify the variable


Para el caso de peones, si al hacer un salto existe un único camino para continuar saltando, la computadora lo hará por el usuario. Si al hacer un salto me da dos o mas opciones, obligo a  que el usuario elija un camino a continuar y aplico lo mencionado anteriormente.
Para el caso de damas, siempre se le exigirá al usuario el destino del salto, ya que es imposible adivinar donde desea caer después de un salto.


I'm afraid we might be duplicating work here.


windows_width => windowsWidth
percent_y => percentY

etc...

Estas escribiendo JavaScript a como se escribe Ruby :/

Saludos


> Look up the definition dynamically. The typechecking information gives you blahTimeout's Object, which provides scope and token position info, but not the defining expression itself. You'd have to do a search in the AST using the position information to find it.

That's right.  As you point out, you'll need to load the whole program from source since expressions may contain qualified identifiers, and that means you'll need the go/loader package.  Once you have a go/loader.Program you can call prog.PathEnclosingInterval(obj.Pos(), obj.Pos()) for a given named constant object obj, and you'll get the path down the syntax tree: [File, GenDecl, ValueSpec, Ident].  From the ValueSpec, you can hunt for the RHS expression that corresponds to the Ident.

There is no mapping directly from objects to defining expressions, but you can easily construct one for the whole program in linear time.


Why not using the globals defined above as defaults?


But for what is Language and Language WWW ?


yes my tests are failing aswel, we need a new release and a repin in or the default test setup or a 4.3.7 release


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17128/testReport/) for this commit**


I didn't mean that you should have gotten rid of isFunctionType() and isClassType(); the functions were valuable.  I just meant that they shouldn't be required before being able to call getXXX() safely.  I won't hold up the merge for this.


`'**/*.html'` will watch all html files in all directories (including vendor html files) which feels aggressive. If you notice Finder feeling sluggish, this might be the culprit.


> If should check for -1 or <= 0. Shouldn't it?

Yes, I will correct that.

It seems that I found the reason for issue: ProGuard is optimizing the APK, but it only runs on the release build. The resulting dex code still contains the call to `getActiveXposedVersion()`, but the result is not used. Now I just need to find out which optimizations I have to block in the config, then I will release a new version. I thought about using your approach and change the result type to Integer, but there's no guarantee that this won't be optimized away in the future as well.


I will at least reference this commit in our fixes. Thanks for the clarification!


そうですね．
ソースがsampleで
https://github.com/fkanehiro/hrpsys-base/tree/master/sample
こちらのinstall先がsamplesとなってるようです．

openhrp3もsampleですので，samples=>sampleのほうに統一するのが無難そうに思います．
https://github.com/fkanehiro/openhrp3/tree/master/sample

ただ影響でいうと，だいたいのコードがインストール先のもの(samples)をみるようにかかれているので，
https://github.com/fkanehiro/hrpsys-base/blob/master/launch/samplerobot.launch#L19
samples=>sampleのほうが変更が多くなりそうな気がしまいます．


@milon521, I've restored file permissions to 644 and pushed it to base
repo.

@all, please update your forks to match with the recent code and make sure
you have executed following command in your workspace to prevent accidental
modifications of file permissions.

git config core.fileMode false

On Mon, Jun 29, 2015 at 9:22 AM, Nuruzzaman Milon <notifications@github.com>
wrote:

> @mnishihan <https://github.com/mnishihan> Bhai,
> It was done accidentally. Sorry for that. Hope you fix it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bddevsclub/website/commit/da4729a74fe9586c420c0ebc0d7c09d161f08b32#commitcomment-11902585>
> .
>


Damn, +2 here, thanks.


@arowla - You're right, they are. Just fixed with. #3


Hatte auf 1,55 aufgerundet.


This seems to be redundant to what is already done on line 87


@CodeClubRik have you seen [the new-layout branch](https://github.com/CodeClub/scratch-curriculum/tree/new-layout) on this repo? There’s one for each curriculum repo. Those are the branches I was updating for the projects-site work. I’m a bit worried there’s potential for them to become quite out of sync.


This method is asynchronous and therefore it should return a promise. Furthermore, we would like to call the clean methods serially, and ideally atomically.


I'd recommend using a cdn for Bootstrap instead of hosting ourselves. http://www.bootstrapcdn.com/


lol


Не нужно 2 раза. У вас наследование есть, все что ApplicationController будет  в дочерних


I messed up some branching :|


You mean this https://github.com/ehab93/bone101/commit/99f4e040d37df5d7bca3322975e7fe56880e75a5#diff-0e7b27eada6b75413f5e8945ba728b44L15 ?


not to prevent losing root access, to prevent mounting system as r/w through adb, etc


This will introduces back that double send metrics fixed couple weeks ago. Only stats of top channel should be emitted.


Oh, didn't see you commented.
I can try doing some different colors... hopefully I'll get a chance today.


@abotalov Aha, so it was in the spec after all. Thanks for the link.


Per https://github.com/qzind/qz-print/issues/34#issuecomment-116769569, this should be reverted when you're done testing please.  We can provide manual installation instructions for those inclined.


I have no idea how this should be refactored, this was just my poor debugging at that next step.

Kk, check `firstResponder` sounds good to me.  I'll take a crack at that.


Sorry, I shouldn't try to fix stuff on the fly when I don't have time :)
Looking at it now.


Please notice that this doesn't work when the container is actually a Contact or Appointment folder. Android Lollipop will send DeleteAsMoves even on those cases. There is no deleteUIDs implemented on SOGoGCSFolder/SOGoContactGCSFolder.


One can delete these files safely when mysqld is shutdown. I guess it would be useful to do that after the image filesystem is setup, because they can grow quite large.

Another firstboot script may have started mysql - so I don't assume it's safe to do this here (like [here](https://github.com/turnkeylinux/tracker/issues/216#issuecomment-115999407)).


I don't like name of the option. I believe `encoding` is better.


I can see APTCA being removed as part of this checkin; any plans readding it?


The number of bytes you need. I've already linked to [the docs](http://www.erlang.org/doc/man/crypto.html#strong_rand_bytes-1) in the first comment.


What's the problem?
What number or text can't you see?
Could you provide a screenshot or photo please?


@dorileo ok, you are correct about sol-log-impl-linux.
I was thinking in terms of the differences between platform-impl-dummy and platform-impl-systemd, but it is a separate topic, not related to this one.


Like modal or just throw a textbox below our `NSTextField` field?  This was a quick and dirty, but the former would be a nice todo.


Maybe you're right, I will decide when to do the generation of parameters


No. The SBT plugin can have independent bugfix releases


Sollte das nicht P{Y > 80} = P{Y > 80,5} heißen?


See PR #74


I fixed it: https://github.com/HabitRPG/habitrpg/commit/bc837fd4db2a05c7269c0f0b55a7c14b2b2d831f


LOL :smile:


Do you think it's working?!?1/1? :smile: nice!

Try to use use [elixir](http://elixir-lang.org/)! That's syntax is awful. :astonished:


Add the other distfiles to this var too.


Use a spell checker.


83811490-Fault_DirtyAirFilter (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1675 of 1675 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


yeah I would rather the api return JSON objects that we could JSON.parse ... as compared to text responses that we coerce into a js primitive

thoughts?


@dcs619 , just a reminder that when white-space and stylecop type changes are included in same commit as code functionality changes it makes it extremely difficult to determine what's actually changed ( See the LoadSchedule.cs comparison above ). Also, can you use [these guidelines](https://github.com/SparkDevNetwork/Rock/wiki/Committing-Your-Code) too when making commits.  Thanks.
-David


And use **space** instead of **tab**. It's look prettier here on Github


Hmm. Should we perform an extra request on *every single request* just for getting the `WWW-Authenticate` header? What do other libraries do? I'm not familiar with digest auth really...


I skimmed the Swagger docs and I believe that it would indeed be correct to say something like the following:
```
schema:
  type: array
  items:
    $ref: '#/definitions/Book'
```


@rouault i'm not able to understand what is being done in GetFieldAsIntegerList()


true that. +2


I'm not doing much project adding between now and september. I'll make sure to keep the new repos up to date. shouldn't take much extra work


Please follow the newest INSTALL file.
Since 0.93 DSView needs qt5 libraries


that testing file can be deleted again, no?


I see a new issue in this repos future.


We need the docs in the moduledoc as well since they should be accessible via `h` in iex, and the standard generated documentation. So you can dup them over then we are all set.


Checked gtk_* functions, seems no one belong to widgets, added check for this. Waiting for `fill_class_parents_and_childs` name confirmation.


How has this worked for you?


Actually [TradingLogic.jl](https://github.com/JuliaQuant/TradingLogic.jl) is the package that is shaping up, QuantProfiling is an auxiliary one not intended for much use outside JuliaQuant..


this does not return, though


I fixed the Swagger errors in db1efc7dbf8615f1651cbbb3e64b4e3e2cfffff6


Well basically in
```
  void GetFieldAsIntegerList(int id, int *nLen, const int **pList) {
      *pList = OGR_F_GetFieldAsIntegerList(self, id, nLen);
  }
```
the arguments (int *nLen, const int **pList) will be used to return a Python array of integers as the return value of the method. So in your case you would have to change the prototype similarly as ```void GDALTranslateOptions_bandList_get( GDALTranslateOptions *translateOptions, int *nLen, const int **pList)```


see the next test for the 00 case, could be any number actually


If anyone finds there way here through #1867, the syntax in the .eslint file is as follows:

`"no-unused-vars": [1, {"ignore": ["React"]}],`


Didn't use html5 date as didn't say I could avoid IE and Firefox


Would you want to set this to volatile just in case? :)


Fixed memory leak here


nice, ack


Placing scripts in the head should not adversely effect load speed and, as Angular is responsible for loading dependencies, it should arguably be the first thing in the head. I added some nodeJS code to the project that would delay a script downloading and ran it in all the main browsers -you can see from crossbrowsertesting.com that it seems to make no difference in modern browsers….

2 in the head and 2 in the body - http://app.crossbrowsertesting.com/public/i01bee863c4fd274/screenshots/z4d9e5aa4eb2149ab10d
4 in the body - http://app.crossbrowsertesting.com/public/i01bee863c4fd274/screenshots/zcb5dd525a29df69e01a

As a result of this performance comment I've put the css call after the scripts as my bet is that would get the page rendering slightly quicker...


ack


@KOTRET Not in my experience. I just finished compiling `PHP 5.3.27` and tested the following program:

```php
<?php
printf("HELLO PHP %s\n", phpversion());
var_dump(date_default_timezone_get());
```

Result:

```
HELLO PHP 5.3.27

Warning: date_default_timezone_get(): It is not safe to rely on the system's timezone settings. You are *required* to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier. We selected 'Europe/Berlin' for 'CEST/2.0/DST' instead in /home/devel_browser/Test/test.php on line 3
string(13) "Europe/Berlin"
```


Fixed: b86b1afdb9a838cb4e13c99f44849652927058ec


That's a good idea, I'll change it so we use the cdn instead.

> On Jun 29, 2015, at 10:34 AM, Eric Pelz <notifications@github.com> wrote:
>
> I'd recommend using a cdn for Bootstrap instead of hosting ourselves. http://www.bootstrapcdn.com/
>
> —
> Reply to this email directly or view it on GitHub.
>


if you say so... ack :)


Don't worry child.... I WILL ( ﾟ▽ﾟ)/


Sorry, already fixed it 2795fbe7b4cba9b5c748eb69a84f1f50595d7aa2


This line fails to compile for me.
I think the line should be:
```c++
assert(false && "failed to retrieve system info 'SPI_GETFONTSMOOTHINGTYPE'");
````


Before we merge this to master I feel like we should add that they also expect a user auth token, but IDK how to do that, and we haven't set up our auth architecture yet so I don't know what our backend model will look like, either...


@djdekker
i know...Talked to jonas already about it..but i hadn't time until now.
I'll do that lateron.


This was mostly a time saver but also to make things more reusable. If the collection is empty then we have no column headings and what if you wanted to change the order of columns or exclude key columns etc. Would make them optional if I had additional time, this was the simplest thing that would work with my architecture.


Also, I'm wondering if this should bump up the API version. I know we're early in dev, but maybe this is `v0.0.2-preview` worthy. Or `v0.0.1-preview.2` or something. That's @redbassett's call though.


Looks good.


Fair enough about not wanting to touch `getCommand` – I know how that feels :)

And yeah, that loop is very close to what I had in mind :) For now I guess it could just be implemented in-line in the rule, but it might be something to keep in mind for the future. I feel like this is a pretty specialized case – I can't think of any other places where the general idea of 'try this then this then this' would be desirable.


@rod23: Gute Idee! Ich habe zwei Rückfragen:

1. Woran sehen wir, dass die Authorization trotzdem ausgeführt wird? Weil `load_and_authorize_resource` in der darauffolgenden Zeile steht?
2. Bezieht sich `skip_filter` auch auf `before_action`-Aufrufe? (In Rails 4 wird `before_action` statt `before_filter` empfohlen.)


This has been tested and works in IE & Firefox. Although if older IE is required it should be an attribute not an element.


*sigh*
I wasn't aware of that.
Will consider removing them. I thought it was a pretty elegant solution, but that's actually bad...


Thanks @azturner.  I wasn't sure whether to include named parameters, but I wanted those to be more visible since they break the default: false pattern.


I guess I meant Nullable...but I will consider removing them anyway. Thank you.


Код не очень хороший. Везде где ты рассчитывает в Root объекте Uow получить сущьность конкретного типа. везде получать не универсальный IUnitOfWork uow, а generic. Это исключит возможность ошибки, в контексте данного репозитория будет сразу понятно что запрос пработает только если передан UoW c с конкретным рутом.


:frowning: Why would we do this so late in the process, when we don't know anymore what needs to be sanitized? Wouldn't this be better done at the injection point, when the converters format the `value` into the error messages, i.e. in the `_str_to_*` methods of [`ir.fields`](https://github.com/odoo/odoo/blob/f2e4a10/openerp/addons/base/ir/ir_fields.py#L152-154)?
That's the point where we know precisely what part has to be escaped.
There's a bunch of `_str_to_*` methods (and related ones) so a private helper function to do the right escaping for `value` would be a nice improvement. Even one that handles raising the right exception directly, perhaps. For example this kind of (untested) function:

```python
def _raise_import_error(error_type, error_msg, error_params=(), error_args=None):
    # sanitize error params for later formatting by the import system
    sanitize = lambda p: p.replace('%', '%%')
    if error_params:
        if isinstance(error_params, dict):
            error_params = dict((k, sanitize(v)) for k, v in error_params.iteritems())
        elif isinstance(error_params, (list, tuple)):
            error_params = map(error_params, sanitize)
        else:
            error_params = sanitize(error_params)
    raise error_type(error_msg % error_params, error_args)
```
What do you think?


This line seems to perhaps kill whyrun support


That was actually just because I hate a certain kind of people who do not care to read. ;)


My search seems to not have included the title history, so sorry for any additional issues I caused with this. Although, this issue can still be fixed by correcting your own duplicate characters.


This might not be necessary with the solution given in #71, but I haven't had time to test it.


I'd prefer diversifying that list a bit more as well, do we know anyone else who would be willing to be contacted?


Have refactored all of the in-line templating, it was for time saving and agree it's not the angular way. Have moved this hard coded expression into the controller, got spot!


I had to add this in since Spree::ReturnAuthorizationReason is no longer defined which would cause this migration to fail on a new database. It felt odd to modify an old migration, but I'm not sure if there's another way around this.


This doesn't really make much sense to be here. It's a whole trend on GitHub and the angular list isn't really special in any way.


![sans titre](https://cloud.githubusercontent.com/assets/9955284/8414555/e092c3c6-1e66-11e5-95b2-fa2b43cac10c.png)


Is epel-release necessary? both tree and findutils seem to be in rhel7 base.


I always put a limit on loops to prevent crashes and chose 10 as there would probably be display issues by then. Agree this defies logic and so have bumped the limit to 999


Actually, I spoke to soon. Looks like this isn't in master yet?


Note that you can also do radosgw-admin metadata set


But it is `date_read ` no? https://github.com/open-classifieds/openclassifieds2/blob/master/oc/classes/controller/panel/update.php#L117


Not a big deal, but this commit snuck in from the other pull request. You can use `git rebase -i` to remove it from this branch, if you want to clean things up a bit. Otherwise just make sure the other branch is merged before merging this one.


hopefully more comments will help with this


Wonderful.


Functionally, nothing has changed. Rather than hardcoding the deployment tracking code, it is now done through an npm module.


Yes. And also, for older buckets (pre Dumpling) the bucket entry is also holding the bucket instance id information (at that point we didn't have separate entries).


Yeah just a modal I think would work. A label below may be nice just for general output of whats going on but I was just thinking of
```swift
guard let placemarks = $0 else {
  let error = $1 as NSError
  NSAlert(error: error).runModal()
``` or _something_ like that.


:) i prefer lazy as it does work. I have done this properly using jquery lite.


have redone all these with jquery lite


Have refactored / deleted duplication - thanks.


For the part that hides the "Q - Follow Mouse: ", what I'll need to do is ask each bot if it honors that property. Then it's easy to decide when to display that.


This might be an extraction to far for now, but rather than this firing off an API request and returning a hash, it would be rad to have a function that wrapped that, and returned an instance of a `Workflow` class that had accessors for these kinds of things. My general rule is "if logic has to be preceded by `isset` it probably should be extracted into a declarative function".

But you're mostly fixing bugs for now, so don't do any major refactors on my account ;-)


`<nit>` Style guide:  We don't put trailing underscores on public data members.


Hmm, I guess this code doesn't compile and the platforms we tested haven't covered this code path.


nice!


Don't really understand what's going on, but Bundler 1.10.5 does not show this problem (the docs server uses 1.7.7 for those releases). Going to upgrade bundler then, it was due anyway.


Nikad ne bacaj NPE! Baci neki primjereniji exception, ili genericki s ovom porukom.


Why does `applyInverse` return `apply` ?
Is that a bug or i misunderstand something ?


Not sure why you feel these are out of place but I have moved them into a separate file. This is part of my boiler plate code for e2e test and I find them super useful when debugging webdriver. They only get taken if you specify ARTIFACT_DIR.


@rec This is a much needed cleanup of account index, great work. accountFromString is still a mess and can use improvement. Here are some suggestions.

Since bStrict doesn't respect the seed code it might be worth moving creating a new function to handle this.

accountFromStringStrict should not appear in the header as it is only used privately from accountFromString. It can rolled into accountFromString.


Informational:  The `!_MSC_VER` case could get away with not declaring any of the special members except for the default constructor, and the behavior would be identical to what is here.  I have no objection to the way it is.


This `{{'modifier_class'}}` can be removed.


#9 #10 #11


In an effort to maintain proper authorship, the correct author and date should be Donavan Lance <tusklahoma@gmail.com> and Date: Thu, 18 Jun 2015 18:02:59 -0400 correct? As there was no surface in 2001 to my knowledge


This is fine, but a more concise way to write this could be:

``` javascript
var city = req.body.city || "Cary";
```


Each user `<ID>` has a corresponding object called  `<ID>.buckets` in pool ".users.uid".

This is a valid question. Originally when we created this we didn't care about pool creation, so different "system" pools were used for different namespaces. This might not have been the best decision ever, however, at this point we can't just use a single pool because then we'd have a namespace collision.


In the previous, a network including any non-masked layer would crash (due to the call to `layer.get_output_mask()`). This is a temporary fix.

Also I am skeptical that the call to `layer.get_output_mask()` will work at this stage (for other values than None). Has this been tested?


foobar


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17135/testReport/) for this commit**


Hadn't thought of that use case! Will invalidate day and add a test for this...


#3 #5 #7


hpwh_residential (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1672 of 1679 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


I would recommend removing these. `#brand-title` can be styled using existing [heading styles](http://neue.dosomething.org/#heading) in Neue. If you do need to override styles on a pattern, make a modifier like `.container--modifier-class-name`.


よい


:+1: 即可


There's already the standard `.hidden` which you could use.


So once they get it right, the program should exit.


#15 #16 #17


83811490-Fault_DirtyAirFilter (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1681 of 1681 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks, @adamvoncorswant. Well, since it's only accessed by one method, which is default to `LockType.WRITE`, single thread access is guaranteed. And the usage of lock itself should also guarantee visibility. IMHO, `volatile` is not needed here.

We do need `volatile` when it's access by some method that is annotated with `LockType.READ` though. :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17136/testReport/) for this commit**


Just curious, why?


Thanks for spotting it - will add an issue now.


#12 #13 #14


See a620a8135db4904c98a8e0d9c3d5dec59f06522d


no me equivoque. es read_date ahora lo arreglo, en el install estaba bien, o bueno el otro estaba mal xD

https://github.com/open-classifieds/openclassifieds2/blob/master/install/samples/install.sql.php#L291


develop (rraustad) - x86_64-MacOS-10.9-clang: OK (1161 of 1161 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


rgw_http_errors.h file:56    { ERANGE, 416, "InvalidRange", "	The requested range cannot be satisfied."},

Remove extra tab before "The requested"

Rest looks fine.


I have fixed it on update.php also I will commit it later ;)


Without "which has not been applied yet" the meaning of the sentence changes and no longer matches the actual behavior. So "that" would not be correct.


Max,

Hi.

David


Yeah, you're right of course. I was just thinking that the existence of the WF bug actually seems to execute more than one thread against the bean :) On the other hand, having it non-volatile just emphasizes the presence of the bug... So, let's leave it as is!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17137/testReport/) for this commit**


83811490-Fault_DirtyAirFilter (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Two things are being guessed. (1) a file and (2) a commit or range. The proposed change loses this information. Maybe this second "range or commit" should be replaced with "range/commit".


testing


The second comma separates "bigger things" than the first. And in this particular case I feel that calls for a "bigger separator".


Seems ok


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17138/testReport/) for this commit**


yep, this accidentally slipped into the wrong PR, but I think not worth changing since it is needed by #469


This object accessed when:
 - listing buckets
 - creating / deleting buckets
 - updating / retrieving buckets stats (used for quota)

Note that rgw doesn't access the omap directly, but rather makes objclass calls to the user objclass (see src/cls/user/cls_rgw_ops.h)


Git doesn't refuse to carry out any action - only those *which* would cause damage.


Using a colon here seems like a programmer-ism.


Isn't it better to do appInsights.trackPageView(...) instead?


Should we make the following 2 calls in folder or message?
It looks a bit like you could just do it on the folder directly in stead of finding message's folder.


the V is cls_user_bucket_entry:

struct cls_user_bucket_entry {
  cls_user_bucket bucket;
  size_t size;
  size_t size_rounded;
  time_t creation_time;
  uint64_t count;
  bool user_stats_sync;
};

cls_user_bucket {
  std::string name;
  std::string data_pool;
  std::string index_pool;
  std::string marker;
  std::string bucket_id;
  std::string data_extra_pool;
};


Splitting in two sentences is probably a good idea. But wouldn't it be better if the second began with "Otherwise, "? And can we leave out the comma - it seems a bit excessive... I mean after just one word. Is it not correct to use "provided" instead of "if" here?


@digitalextremist here is the only change I did


Hello.

`EGIT_BRANCH="frameworks"` is obsolete since this branch was merged into master.

See http://quickgit.kde.org/?p=kile.git&a=commit&h=e769f66518831f10016e9f4ff5ae911d777cdd3a


Esto no es tan grave, a menos que ya las hayas declarado como globales.


We are only talking about dangerous operations which may lead to data loss. Not any dangerous operation. The restructuring of the sentence makes sense though.


@simonv3 I also would like that list to be more diverse. @Kriesse since wrote me and had included her name in the CoC draft she had writing. Any other suggestions or what are you thinking? Beyond that, I hesitate to reach out to people I don't know personally, don't participate in OSD to ask them to act in this sort of role.


gprof mas que perf, porque es importante tener el breakdown exacto de las funciones.


I was going to do something like urlencode, but there is a / in there that needs to be retained. So I opted to use str_replace instead.


The user id is not actually used for the object lookup path. It is used for authentication, and maybe when creating an object for acl creation. The actual head object name is made of the bucket id with the object name appended to it.


Thanks for that i will solve the same problem for Quick style extension.


Hermoso


Looks like an easier/cleaner option would be to count number of events instead of watching resetInternalEventsThrottle - feels like this is tight to implementation unnecessary.


Ok then. It was a nice try to streamline things, but I guess it's not possible.


The punctuation added in these three hunks are a bit to much in my opinion.


Check out commit db153288c080e16314103d015f189561bd2a15fe.


@adamvoncorswant, here is the issue I created just now: https://issues.jboss.org/browse/WFLY-4844


@tdhock So I started modularizing the code. I broke-up the main SAG loop in an outer loop responsible that will call _sag_constant_iteration at each visited example. I am a bit bothered by the function above, it just seems really messy. It has in arguments, out argument and it returns the nCovered variable that SAG updates after each iteration.


As I said, this is only used for authenticating the user accessing the data. If you're not authenticating (e.g., accessing the data anonymously), then this will not be read.


Fix #1527 - Continue button disabled on Plan Shopping page


Actually...  not only should it run it first, but I think it should either run it *only*, or allow it to say "don't fall back to default implementation, just use me".  I don't think we want our Meteor package ever using the default implementation.


I’ve seen both and one other besides.


Contame brevemente que ganaste con este refactor.


Alpha4 of the installer fixes it for me.  Thanks for the quick turnaround!


Yes. Throwing if the callback is missing is a desirable canary.


Right. The marker and bucket id hold the same string currently.


I guess it could still be used if only to avoid duplicating the organization name?


@kyleam Just to be sure: in most cases I am not saying your suggestions are wrong. But if you still feel like they are needed/preferable, then please explain why. Thanks.


Register the event handler for node loading prior to calling `Load`. For the Package Manager extension, `Load` attempts to load all packages. If this event handler is null, nothing loads.


hi,
1. ja genau, sonst würde auch die resource (@attachment) nicht geladen.
2. bin nicht mehr am rechner, aber soweit ich weiss rufen before_action und before_filter den gleichen code auf, sind also synomym (sprich einer ist alias des anderen)
lg, ralph

On 29.06.2015, at 19:54, Sebastian Fiedlschuster <notifications@github.com> wrote:

> @rod23: Gute Idee! Ich habe zwei Rückfragen:
>
> Woran sehen wir, dass die Authorization trotzdem ausgeführt wird? Weil load_and_authorize_resource in der darauffolgenden Zeile steht?
> Bezieht sich skip_filter auch auf before_action-Aufrufe? (In Rails 4 wird before_action statt before_filter empfohlen.)
> —
> Reply to this email directly or view it on GitHub.
>


ack


@bnvk I totally understand and agree. I would love to be able to just toss out a couple of names of people involved, but I can't really :/. If @Kriesse is down to be listed, than that might be enough for now. As the community grows we can hopefully ask more people.


Step one


I guess this will have to do...


¿Esta función es `double` porque todo el contexto donde se usa es `double`?
Yo no descartaría calcularla en `float` y promoverla a `double` a la salida.


Are you sure just 2? :)


Move extension registration after the node library has been initialized. This is mostly to support the Package Manager extension. If a package contains types that reference things like `DSCoreNodesUI`, those types need to be loaded before the extension is loaded, subsequently attempting to load packages.


Looks like I need to turn on spell check in vim. :smile:


@MariekevC How do you mean? Not point out the "straight, white, CIS, males" thing?

I think explicitly calling it out is useful, but I can also see how it might "erase" people who are part of those communities and don't fit in those categories.


Removed.


This is never printed.


This didn't solve my problem. It seems int divided by float results in a float automatically.


This is printed in the python script windows.


Where do these constants come from?  If they are not in the WebGL 2.0 spec then they should be put on their own with a comment saying they are an extension.  The ones from the WebGL 2 spec aren't enough?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17140/testReport/) for this commit**


@glebm I thought we agreed that there'd be no more 4-digit version numbers? This should be `3.3.6`


indentation is wrong, no tabs in this town


lgtm


org.junit.Assert should be org.testng.Assert


may be subjective, but i feel the responsibility of throttle() being only answering the question - "to throttle or not to throttle", not dealing with queue.
So my recommendation would be:

throwNonUserActionable(msg){
  if (throttled(...)) { msg = "it's throttled"; }
  queue.push(msg);
}


何がしたいのか意味わからないところが多いと思いますが、途中経過です。自分でも意味がわからなくなって進まなくなってきたのでとりあえず上げます。


It's the same as older version for me. Can't see the screen.

Inviato con AquaMail per Android
http://www.aqua-mail.com

Il 29 giugno 2015 19:37:21 AdrianLxM <notifications@github.com> ha scritto:

> What's the problem?
> What number or text can't you see?
> Could you provide a screenshot or photo please?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/StephenBlackWasAlreadyTaken/xDrip-Experimental/commit/0640e6c02812a6735e23d35aa063510f382d0bd9#commitcomment-11915111


org.junit.Assert must be org.testng.Assert;


I put this in IRC, but putting it here as well:

I think something like "relating, but not limited to, the following topics" should be put here. It's saddening on the scope of things people will find to discriminate on.


Like to comment this one, I spent a few hours trying diferent solutions for my project which uses the v0.9.4  of Angular Material, Tryed updating the version but the css and html changes I will have to make will take a bit of time, so I rolledback to v0.9.4, my solution to this was forcing the self.hidden to true on the else statment like below, the code fix was not enough to fix situtations where the data is loaded via ajax and injected into the model after the autocomplete fields have been rendered, this was my case at least.

    self.hidden = shouldHide();
    if (hasFocus)
          self.hidden = shouldHide();
      else
          self.hidden = true;

May help others in the same situation, cheers!.


I also would like to voice my interest in keeping the menu support alive (again it works fine for my purpose).


@adamdecaf What do you think about this? This is just kind of a rough way of converting CSV fields into either a number or a string. I also updated the product readers to handle these. If you've thought of a better way you'd like this done let me know. This is just how I thought to handle it.


Thanks @blounsbury!


can always revert :p


You can add me.


Can you add more instruction on using this javascript library? Example, I want to use it on my PHP project. Thank you.


`self.class` or `singleton_class`. Using Project directly is refactor-unfriendly!


Good. :) Request from my side: Do you mind adding a custom suffix in your next version, e.g.: "65 (romracer / %s)"? The %s will be replaced by the current date in the build script. The ZIP filename will be adjusted as well. That makes easier to identify which build people are using, and you can release further versions based on v65.


Removed unnecessary *require 'find'*.


another thing we can do is to make the type integer instead of string.


Yes, I did.

On Mon, Jun 29, 2015, 2:35 PM Derek <notifications@github.com> wrote:

> can always revert :p
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/VanirAOSP/kernel_lge_g3/commit/2401926b9c166a655b362c1e1fb2b7168627e575#commitcomment-11916309>
> .
>
--

Sent from my Vanir LG G2


Interesting. Would the only two types we handle be BigDecimals and String?


Note: the push summary was wrongfully applied to main.css and test.html in addition to welcome_test.php.

The updates to main.css and test.html include a fix to the footer of the main site and inclusion of search bar linked with the PHP welcome screen.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.694.a46c0a67c3afa99748ae76925488c03179c31086](http://build.palaso.org/viewLog.html?buildId=59015&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 355, ignored: 3 Build time: 00:04:22


Did you mean text_length >= 2 here?


is 4 better than 1?


This allows a parser Resource to deliver it's file an line position when formatting a Pops::Issue.(see lines 19 and 374 in _lib/puppet/parser/compiler.rb_ and additions in _lib/pops/mode/model_label_provider.rb_ and _lib/pops/validation.rb_) In essence, it lets the Resource act as semantic in the DiagnosticProducer which in the end, ends up as a Diagnostic.source_pos.


Yeah, I think so. I'm pretty sure those are the only types encountered in a csv.


That makes a lot of sense. I'm saving that idea so I can circle back to it.


```max``` is only referenced from the test code; on top of that I would say that this would better covered by a static method like a ```maxMultiplicity(edge1,edge2)```. All in all I think is best to simply remove it together with the affected test. ```BaseEdgeUnitTest.testMax()```


actually I would let the main process print this part completely, you send over the skip info anyways, right?


I was hoping it would be - but there is no major improvement
(If you remember the ram usage in clang earlier showed 4 processes running
- so, I thought maybe it can handle 4 at a time)

On Tue, Jun 30, 2015 at 12:07 AM, Lasse Schuirmann <notifications@github.com
> wrote:

> is 4 better than 1?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/53d5db8c238a8d843da3758e812c6cbbb13b0213#commitcomment-11916357>
> .
>


The loop might be useful if anyone's masochistic enough to try writing a rule for ghostscript :wink:

This would only really work if all the different command names have the same syntax. There are a few `makeglossaries` options that `makeglossaries-lite.lua` doesn't support. Two of them can easily be ignored so I've made `makeglossaries-lite.lua` ignore them with a warning. One (`-d`) can't be implemented with Lua so `makeglossaries-lite.lua` will exit with an error telling the user to use the Perl version instead.

I'll leave it in the conditional block form, but I still can't decide what to do if `makeglossaries-lite.lua` isn't installed. I suppose the sensible thing is to just give a message to tell the user to do one of: (1) update to the latest version of `glossaries`, (2) install Perl or (3) explicitly call `makeindex`.


ack :)


perhaps change the name too ```orRef``` does not seem descriptive enough.


is there also an onAfterConvert event?


maybe wrap with debug enabled, since I guess source toString could be expensive.


@oleg-nenashev you added license in pom as apache2, but in LICENSE it MIT


Looks good.


good works , but color ps3doom is a incorect
![capture d ecran 2015-06-29 20 40 24](https://cloud.githubusercontent.com/assets/5261759/8415458/2f521948-1e9f-11e5-92b3-67a1557a5924.png)
![capture d ecran 2015-06-29 20 40 34](https://cloud.githubusercontent.com/assets/5261759/8415460/31fd1cd8-1e9f-11e5-8ed5-d255d8d71779.png)


Wouldn't that method throw before this could happen because you divide without rescuing?


@jcscottiii I think that you are mixing up (because it is not very clear) the broker's internal DB with the DB that the broker manages.
We can use something like this for the DBs that we manage but it wouldn't make sense for the RDS that the broker connects to...


Agreed, but for the moment, following along in the book. I also think the Task referring to Project.velocity_length_in_days introduced unnecessary coupling.


The extensions come from https://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/

They are still not in core in ES3 https://www.khronos.org/registry/gles/api/GLES3/gl3.h but in ext header https://www.khronos.org/registry/gles/api/GLES2/gl2ext.h


This should be a class constant. It should go above or below the attr_accessor, and constants are all caps.


Each character of all the existing languages is assigned a unique code by the Unicode Consortium, which is known as Unicode. Devanagari is taken as the base script.
Designed for Linux OS.


:book:


Yes, the commit message does seem wrong. I tried to edit as minimally as possible, but the logic still seems correct to me, since sysv_translate_facility can only return service or target types. I suppose I could add a t == UNIT_TARGET, and log a warning in the else. What do you think?


83811490-Fault_DirtyAirFilter (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (649 of 649 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.33%25-green.svg)


IMHO it's too complex a solution for something so simple. Sometimes DRY is sandpaper.


Hard data for that is probably hard to get... how about you try to pass NODE_INDEX+1 as j argument and add `time` before the execution to get build times?


My bad. Seems it was an erroneous copy from a wrong plugin. The code is licensed under MIT as I see


I don't understand. Do you mean I should add a blank line here?


If you look a few lines down the file from where you put it, are the extension constants (WEBGL_depth_texture and OES_standard_derivatives).  Put them below those with a comment above saying WEBGL_compressed_texture_s3tc, I want to keep it manageable as to which things are coming from where, WebGL 1, 2, extensions, etc.

Thanks


You can probably just split this here. Array also has size so you shouldn't need to change the following line.


you can get rid of the each_elements function and just say:
```
inv_chars = guess - COLORS
```


Sorry for taking so long to reply Zach!

I would be very interested to see a SWIG generated OSVR library. I'm looking into the Oculus SDK 0.6 port currently, and I really need to use an interface to JRift that would also be mappable to an OSVR or SteamVR lib.

> On 23 Jun 2015, at 00:36, Zach Jaggi <notifications@github.com> wrote:
>
> Gotta hop back on this! Hey, I've had some thoughts:
>
> The most ideal approach for open, extensible VR for Minecrift is probably going to be using OSVR, not OpenVR. OpenVR has support for a static configuration consisting of whatever devices your particular device manufacturer decides to implement, while OSVR is user-configurable to support whatever devices you like to use, via JSON configuration (to be done in GUI later on). You could, for example, use Vive hand inputs with the Rift, or a Wiimote with the Vive.
>
> OSVR is modeled after a preexisting extensible method for using VR inputs, known as VRPN.
>
> I don't know if there's a preexisting Java OSVR library lying around, but I could probably auto-wrap it for the most part using SWIG, if you're interested.
>
> The only drawback is, distortion is handled by the application with OSVR. There are some example support libraries for producing distortion to whatever OSVR HMD parameters the application recieves.
>
> The Dolphin project is moving towards adopting OSVR, and plans to implement Timewarp and other such goodies as free, open shaders that everyone can use for every headset.
>
> —
> Reply to this email directly or view it on GitHub.
>


you might want to stick these in `/usr/local/bin/` for consistency with the other binaries (e.g. `fix-displays`, `fix-audio`, etc.)


:clap:


@allisonchau  cc: @ajschumacher @jonhanke
good job!
3. xargs is a command used to execute commands based on arguments from standard input


```
if inv_chars.present?
```


Javadoc?


@omribahumi what do you think?


Best commit ever. :+1: :hamster:


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17141/testReport/) for this commit**


@Wuzzy
Debug for you


Yeah, this one should panic.
+ // Caller must ensure that types match.
Since we're not dealing with IO, it shouldn't break.


The rados pool should be adjusted appropriately to handle the number of objects. More objects, means we should have more osds, and larger number of pgs in that pool.
That been said, it is also possible to create multiple data pools and make it so that different users buckets will be created in different rados pools by default.


I found that when I click on a symlink emacs asks me if I want to follow symlink or not. So, I don't have to worry about jumping between files. So, if anyone is worried about this simply click "no" in the popup.

Thanks for the fix @jhao12


rename to ```toSequenceGraph```.


nope, order of events is `onBeforeConvert`, `onBeforeSave` and `onAfterSave`typically


Correctly spelt word is now misspelt! :)


What's your test script though?


@ardasgup @pbathia Please review


I know technically pre-existing prior to this change, bu this string is duplicated in TribeService as well, should we extract to central spot while at it?


I think this is a mistake.


Yes! Cmd+T is among the nicest things in Sublime.


This could be a one liner and combined with the line below:
```
puts "#{inv_chars.join(", ")} #{inv_chars.size > 1 ? 'are' : 'is an' } invalid color#{inv_chars.size > 1 ? 's' : ''}"


You can remove these excludes since this is a generator.


This is what I was thinking of


Not sure I understand this question. The bucket index is the rados object holding the list of rgw objects in a bucket. The bucket index is located by default in the .rgw.buckets.index pool, and when listing objects in a bucket it access that object. The bucket index is not accessed when reading an object, only when creating an object (or modifying its metadata).


Unless you are planning on adding them within the dummy app?


So,
```nim
{.passC: "-D_CRT_RAND_S".}
```
under the Windows section should work (`rand_s` is apparently unavailable unless it's defined, which is odd). Sorry I didn't notice that before. It that's too ugly a solution, I can rewrite this section to use `CryptGenRandom` and similar lower-level things instead, which is apparently what `rand_s` actually does.
It's unfortunate that this is the "solution," but that's apparently what people do (["The rand_s function requires that constant _CRT_RAND_S be defined prior to the inclusion statement for the function to be declared"](https://msdn.microsoft.com/en-us/library/sxtz2fa8.aspx)). So it needs to happen *before* "#include \<stdlib.h\>".


@tbrown1979 makes sense, any further parsing might be good to leave to the client. Which sorta prompts me to think it might be good to leave clients to parse str -> big decimal.


good idea, done in a new commit


I don't follow. Isn't "asymptotically equal to" defined in terms of limits in exactly this manner?


I tested one of the deadlock example. With jruby I'm getting this,
`Celluloid::NotActorError: not in actor scope`


I agree and will change this in the next version I push.


Maybe can -> must?


purgeWithdrawnIntents could be a more descriptive name


@dilumnavanjana `Group` is not an actor. You need to use `Manager`


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/8cb0569c0d24db07c3241a7dbe8216e4526849da/index.html)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.695.a46c0a67c3afa99748ae76925488c03179c31086](http://build.palaso.org/viewLog.html?buildId=59019&buildTypeId=bt431) outcome was **FAILURE**
Summary: Failed to resolve artifact dependency Build time: 00:00:27


`Group::Manager` I mean.


The object's head consists of the first 512k of the data (which is optional, you can have an object with no data in the head, but with data in the tail), and with the object's metadata that is stored in its xattrs:
 - manifest
 - acls
 - content type
 - etag
 - user defined metadata
 - etc.


Shouldn't this be 0.9.0? We've not fixed anything but instead introduced new API.


O que isto faz, amiguinho?


And if game is not CS?

If it is tf2, wouldn't weapon name be garbage since it is not set?


Or you could split it up to make it a bit more readable:
```
if inv_chars.size > 1
  puts "#{inv_chars.join(", ")} are invalid colors"
else
  puts "#{inv_chars.join(", ")} is an invalid color"
end
```


Yea I had it in there but it got lost when I had to install a new 14.04 LTS install because my arm64 builds were making 0 byte objects. I'll update them when I'm back from lunch


Note that there's a pending commit that removes the need of prefixing all the rgw system pools with a period, and also renames all of these pools.


True, and no.


`path.GetExtension` is quite expensive


You can also just say
```
puts my_seq
```


hello @seanabu cc: @ajschumacher @jonhanke
Good job!  Some notes:
tuples - can be dictionary keys (rather than lists)
sets - contain unique values


@harshalgupta while I think having this is a good idea, I would really like us to have our original strings, and not copy paste these from Amazon. Some of these strings don't even make sense in our context, e.g., "SOAP requests must be made over an HTTPS connection"


Don't blame me, I just give the proper rope for rulemakers. :smile:

To be honest, I can't think of a scenario where Perl is not installed – at least, TeX Live comes with a bundled Perl interpreter, so all scripts can be executed. The very same idea applies to Lua scripts which (technically) can be interpreted by `texlua`, which the basis of LuaTeX and friends. :smile:

I actually don't know how things work on MiKTeX. Maybe they have different requirements.

I'd say, write the simplest rule and hope for the best. The more we try to fix things for the user, the quicker we will get our hands dirty. :smile_cat:


> Did you have any success building GCC 5.1.0 i686 dwarf?

No.
As far as I know, nobody has been able to build gcc-5.1 with DWARF :(


test comment


@JoseGalRe should the #ifdef block perhaps be before the if-block on lines 1187-1188 ?


Never mind my previous comment. You should properly line up that last else statement, it's confusing


Trust me to screw up the first build.


Apologies I meant all the excludes except `bin` and `spec/dummy/bin/*`.


@dinhviethoa Yea, thanks, I actually was going to file a bug to libetpan, but basically if a string ends in =X, something goes wrong, but haven't dug in yet, not just =0, like I have here.


Yeah just noticed it, somehow a tab got in there


Yes.


imho part of this description relates to generic java/plugin development knowledge/quality and should be hosted under "Extend jenkins" documentation.


When you get a chance could you put this log-sqrt-params.png in the repo?


Well, in that case I guess it is ok (I didn't dig deep enough), but maybe making it explicit would be better for the next guy looking at this.


Update the minimum Chrome version to 45.


Since I'm not sure to understand what's going on just by reading this patch, could you go ahead and file the bug against libetpan? Thanks!


Hmm, i don't have `WEBGL_depth_texture`, `OES_standard_derivatives ` did you push it?


**Local cover art regex tab:**
![capture du 2015-06-29 20 56 59](https://cloud.githubusercontent.com/assets/151042/8415783/8a0d86a4-1ea1-11e5-8ce7-7bce29505868.png)
**Local cover art regex tab with error:**
![capture du 2015-06-29 20 56 55](https://cloud.githubusercontent.com/assets/151042/8415784/8a0ecb7c-1ea1-11e5-974d-2fb367f996ec.png)
**Cover Art Archive options tab:**
![capture du 2015-06-29 20 56 47](https://cloud.githubusercontent.com/assets/151042/8415785/8a145d1c-1ea1-11e5-9a75-f516aa3a64ed.png)
**Cover Art Archive options tab disabled:**
![capture du 2015-06-29 20 58 38](https://cloud.githubusercontent.com/assets/151042/8415823/a78835c6-1ea1-11e5-8900-ca4c540c557a.png)


I not sure how setter/jenkins will work with objects stored in HashMap, they must immutable afaik.


Nit: This sentence is worded so that it is talks about distinguishing "patterns" from "pieces".

How about just "... that allows distinguishing similar pieces"?


It is quite unclear what this method does, we need to change the java doc and the name. Will come back to this, when I gather more info from other parts of the code.


You may want to consider taking the input/validation out of the game class and putting it in a separate method/class. It is probably a good rule of thumb to keep data input out of logic classes so that they don't get too cluttered.


AddCalcCoilSurfTempSource (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's correct. The timestamp on the first line is used to show that the patch is output from `git format-patch`. See the [git format-patch](http://git-scm.com/docs/git-format-patch) documentation, specifically the 'Discussion Section'.

That's a patch I created btw. Just practicing how to properly format patches that the kernel mailing lists will accept.


Is this necessary?  Doesn't crispy render `MultipleChoiceField`s  correctly?  This only applies to users, so if locations or products used this field, it wouldn't be executed.


PLoS have now fixed the dead link.


It's been there since April:

https://github.com/deanm/plask/blob/aba745fe45346ce1b3b5ce0332e837203ab2394c/webgl_constants.h#L706

https://github.com/deanm/plask/commit/8bde40aa4342feb67f4713541a185d3ead91f021


Overall it is looking good!


Redundant string interpolation
`"#{place.description}"`


Comment is a bit wrong, I guess it means ```ref source``` rather than ```sin```,


Wrong file. This file is not part of project


I have successfully build such builds:
x86_64-5.1.0-release-posix-sjlj-rt_v4-rev0.7z [1]
x86_64-5.1.0-release-posix-seh-rt_v4-rev0.7z [2]
x86_64-5.1.0-release-win32-sjlj-rt_v4-rev0.7z [3]
x86_64-5.1.0-release-win32-seh-rt_v4-rev0.7z [4]
i686-5.1.0-release-posix-sjlj-rt_v4-rev0.7z [5]
i686-5.1.0-release-posix-dwarf-rt_v4-rev0.7z [6]

[1] http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/5.1.0/threads-posix/sjlj/x86_64-5.1.0-release-posix-sjlj-rt_v4-rev0.7z
[2] http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/5.1.0/threads-posix/seh/x86_64-5.1.0-release-posix-seh-rt_v4-rev0.7z
[3] http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/5.1.0/threads-win32/sjlj/x86_64-5.1.0-release-win32-sjlj-rt_v4-rev0.7z
[4] http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/5.1.0/threads-win32/seh/x86_64-5.1.0-release-win32-seh-rt_v4-rev0.7z
[5] http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/5.1.0/threads-posix/sjlj/i686-5.1.0-release-posix-sjlj-rt_v4-rev0.7z
[6] http://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win32/Personal%20Builds/mingw-builds/5.1.0/threads-posix/dwarf/i686-5.1.0-release-posix-dwarf-rt_v4-rev0.7z


Always appreciate a good nitpick.  Thanks!


there is something wrong i think


Doesn't Objects.hashCode require Java 7?


Ah!  Nevermind, using guava


Thanks! I'm making changes now

On Mon, Jun 29, 2015 at 12:02 PM, DownSpiral <notifications@github.com>
wrote:

> Overall it is looking good!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Brentwish/master_mind/commit/8bef28e1420a1be19333d63122df410a61ee440d#commitcomment-11916855>
> .
>


@MariekevC do you mean the point that @simonv3 brings up? If yes, do you mean that will alienate people from those communities who identify as "straight, white, CIS males" or more like Simon says?

Hrm, I hadn't thought about that. The question / challenge I have then is, how to word it so as to signal to minorities groups to know that this CoC is explicitly taking into account their well being and welcome them.


This will be visible on any domain which uses multiple choices.  Can you attach a screenshot?


MultipleChoiceField is rendered as standard html select.


Can we delete this branch?


@simonv3  Yes, that whole first senctence.
Being explicit and clear is ok, but this way it sounds like offending said communities with the sole purpose of making a point. That point is sufficiently made clear with the second sentence, no?
"We want Open Source Design to be a diverse community. We believe diversity leads to a healthy culture, which outputs great creativity."


:+1: awesome!


Pramod can you combine the two auth clients into 1?


Also, can you hide this behind a feature flag?


what is the purpose of the `biggestmonomial` branch?


looks good :+1:


@JordanCheney can you review?


Shouldn't this just use `tags()` instead of the deprecated `section()` to work on the master branch?


Here's one of the places where I changed things to be able to accurately reflect the edited note if you go in to re-edit it. Just added a bit of state to keep track of the new (edited) raw timestamp.


And here's where we prefer to pass in the `note` and `timestamp` from the state if the note has already been edited once.


Ditto.


@MariekevC hmmm, I definitely don't want the CoC to come off as overtly negative. Yet, I feel these points should be very clear & explicit. But you might be right, perhaps the word "Don't" is used a couple times too many!


Can you implement this such that it'll work properly everywhere it's used?  For example, modify the form class so when you render it with `{% crispy data_fields_form %}`, the form has the appropriate widget.


Shouldn't the default behavior be to save null fields since this is the way it currently works pre-2.1.7?


@gillisig thanks :+1:


Can you move the token generation code and most things related into buffer server? So when we change the scheme to generating it, we don't have to make change at multiple places.


User2 shouldn't be needed anymore since you can share the same type (User) for both tests.


Oops, this was testing whether putting the "expected biggest monomial" on the left side of a Signomial constraint improved the naive guess. Didn't work in any of our 'fails-without-guess' examples, can be deleted! (it was on github so Cody could pull it)


I thought you said nobody was able to build GCC with DWARF. Isn't 'i686-5.1.0-release-posix-dwarf-rt_v4-rev0.7z' DWARF based?

This is the one i was trying to build, and got the undefined error. After i've applied some msys2's patches, more specifically '405-dwarf-regression.patch', the build succeeded. Haven't tried it yet though.