I received warnings because g-d-p found the original doom1.wad shareware WAD, but its file size and checksum did not match this one (it's also called doom1.wad, despite being full Doom 1).


Matter of taste, but I would inline instantiation


__combined is not define here :-s
I may try to include types/combined.hpp but I think we should change our __combined to std::common_type in the future.


jpg files are for photos; use gif or png


You're right, fixed in cc1cd45


Do we need count the weight change of bucket, not just the item, but the returned 'changed' seems not used at all, maybe we simply return a bool?


This rule init.rc


wdyt about `documents: improvement of legacy filename handling`?


Hey @IjzerenHein !!

Great question!

Truth being told, it doesn't make a big difference in application code, but it should be avoided in library code IMO.

E.g. V8's bind implementation does all sorts of stuff (primarily related to the fact that it can bind arguments). We don't need any of that. Not using bind works in every browser (PhantomJS doesn't support it) and is significantly faster.

Below you can see V8's `bind` implementation, in case you're interested.

```cc

// ES5 15.3.4.5
function FunctionBind(this_arg) { // Length is 1.
  if (!IS_SPEC_FUNCTION(this)) {
    throw new $TypeError('Bind must be called on a function');
  }
  var boundFunction = function () {
    // Poison .arguments and .caller, but is otherwise not detectable.
    "use strict";
    // This function must not use any object literals (Object, Array, RegExp),
    // since the literals-array is being used to store the bound data.
    if (%_IsConstructCall()) {
      return %NewObjectFromBound(boundFunction);
    }
    var bindings = %BoundFunctionGetBindings(boundFunction);

    var argc = %_ArgumentsLength();
    if (argc == 0) {
      return %Apply(bindings[0], bindings[1], bindings, 2, bindings.length - 2);
    }
    if (bindings.length === 2) {
      return %Apply(bindings[0], bindings[1], arguments, 0, argc);
    }
    var bound_argc = bindings.length - 2;
    var argv = new InternalArray(bound_argc + argc);
    for (var i = 0; i < bound_argc; i++) {
      argv[i] = bindings[i + 2];
    }
    for (var j = 0; j < argc; j++) {
      argv[i++] = %_Arguments(j);
    }
    return %Apply(bindings[0], bindings[1], argv, 0, bound_argc + argc);
  };

  var new_length = 0;
  var old_length = this.length;
  // FunctionProxies might provide a non-UInt32 value. If so, ignore it.
  if ((typeof old_length === "number") &&
      ((old_length >>> 0) === old_length)) {
    var argc = %_ArgumentsLength();
    if (argc > 0) argc--;  // Don't count the thisArg as parameter.
    new_length = old_length - argc;
    if (new_length < 0) new_length = 0;
  }
  // This runtime function finds any remaining arguments on the stack,
  // so we don't pass the arguments object.
  var result = %FunctionBindArguments(boundFunction, this,
                                      this_arg, new_length);

  // We already have caller and arguments properties on functions,
  // which are non-configurable. It therefore makes no sence to
  // try to redefine these as defined by the spec. The spec says
  // that bind should make these throw a TypeError if get or set
  // is called and make them non-enumerable and non-configurable.
  // To be consistent with our normal functions we leave this as it is.
  // TODO(lrn): Do set these to be thrower.
  return result;
}
```

wired together in `SetupFunction`:

```cc

function SetUpFunction() {
  %CheckIsBootstrapping();

  %SetCode($Function, FunctionConstructor);
  %AddNamedProperty($Function.prototype, "constructor", $Function, DONT_ENUM);

  InstallFunctions($Function.prototype, DONT_ENUM, $Array(
    "bind", FunctionBind,
    "toString", FunctionToString
  ));
}
```

(taken from `v8natives.js`)

Including this LICENSE thing because I don't want to be sued and have no idea about copyright law:

```
Copyright 2006-2011, the V8 project authors. All rights reserved.
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are
met:

    * Redistributions of source code must retain the above copyright
      notice, this list of conditions and the following disclaimer.
    * Redistributions in binary form must reproduce the above
      copyright notice, this list of conditions and the following
      disclaimer in the documentation and/or other materials provided
      with the distribution.
    * Neither the name of Google Inc. nor the names of its
      contributors may be used to endorse or promote products derived
      from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
```


They are not mutable, so I don't see how they'll change. But I think your right though about it being public. I think here should also be a `new_failprob(q: f64) -> Bernoulli` constructor, in case you want a really low failure probability (say `q = 1e-42`) then you loose the precision by specifying `q = 1. - 1e42 == 0.`


The format of your documentation is almost, but not quite a tutorial.  I want you to combine the `instructortools-viewallgrades.md`, `docs/instructortools-grading.md`, and `docs/instructortools-addgrader.md` files into a single file.  You need to explicitly walk the reader through every single command they need to run in order to start their own class using gitlearn.  That means you need to actually talk about creating a repo for the class.  Then when you run the grading commands, you should actually run them on that repo and show the before and after state.


Ah, I didn't look close enough to see it was during linking.

Isn't this something to handle using the translations thing that was previously implemented?


Ça n'etonnera personne !


@rovo89
This patch causes dex2oat crash when apps need to be re-compiled (after cleaning dalvik cache) on LP 5.1. Probably because OatFile constructor may be called before Runtime is initialized thus Runtime::Current() instance is NULL.
Adding NULL check: is_created_in_zygote_(Runtime::Currrent() != NULL && Runtime::Current()->IsZygote()) helps to workaround this issue. Not sure if there's a better way.
I suppose the same situation is on LP 5.0

Here's a logcat of dext2oat crashing:
I/art     (  208): GenerateImage: /system/bin/dex2oat --image=/data/dalvik-cache/arm/system@framework@boot.art --dex-file=/system/framework/arm/boot.o
at --oat-file=/data/dalvik-cache/arm/system@framework@boot.oat --instruction-set=arm --instruction-set-features=default --base=0x6f978000 --runtime-ar
g -Xms64m --runtime-arg -Xmx64m --image-classes=/system/etc/preloaded-classes
I/rmt_storage(  190): rmt_storage_connect_cb: clnt_h=0x5 conn_h=0xb6403090
I/rmt_storage(  190): rmt_storage_rw_iovec_cb: /boot/modem_fs2: clnt_h=0x2: req_h=0x9 msg_id=3: R/W request received
I/rmt_storage(  190): wakelock acquired: 1, error no: 2
I/rmt_storage(  190): rmt_storage_client_thread: /boot/modem_fs2: clnt_h=0x2 Unblock worker thread (th_id: -1236802816)
I/dex2oat (  545): /system/bin/dex2oat --image=/data/dalvik-cache/arm/system@framework@boot.art --dex-file=/system/framework/arm/boot.oat --oat-file=/
data/dalvik-cache/arm/system@framework@boot.oat --instruction-set=arm --instruction-set-features=default --base=0x6f978000 --runtime-arg -Xms64m --run
time-arg -Xmx64m --image-classes=/system/etc/preloaded-classes
--------- beginning of crash
F/libc    (  545): Fatal signal 11 (SIGSEGV), code 1, fault addr 0x51 in tid 545 (dex2oat)
E/Sensors (  204): sns_reg.c(255):Invalid ID: 3040
I/rmt_storage(  190): rmt_storage_client_thread: /boot/modem_fs2: clnt_h=0x2: req_h=0x9 msg_id=3: Bytes written = 1572864
I/rmt_storage(  190): rmt_storage_client_thread: /boot/modem_fs2: clnt_h=0x2: req_h=0x9 msg_id=3: Send response: res=0 err=0
I/rmt_storage(  190): rmt_storage_client_thread: /boot/modem_fs2: clnt_h=0x2 About to block rmt_storage client thread (th_id: -1236802816) wakelock re
leased: 1, error no: 0
I/rmt_storage(  190):
I/rmt_storage(  190): rmt_storage_disconnect_cb: clnt_h=0x0x5 conn_h=0x0xb6403090
I/DEBUG   (  193): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
I/DEBUG   (  193): Build fingerprint: 'google/hammerhead/hammerhead:5.1.1/LMY48B/1863243:user/release-keys'
I/DEBUG   (  193): Revision: '11'
I/DEBUG   (  193): ABI: 'arm'
I/DEBUG   (  193): pid: 545, tid: 545, name: dex2oat  >>> /system/bin/dex2oat <<<
I/DEBUG   (  193): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x51
I/DEBUG   (  193):     r0 b5c6d2e0  r1 b6f29ebc  r2 00000016  r3 00000000
I/DEBUG   (  193):     r4 b5c6d2a0  r5 00000000  r6 b6f4bff0  r7 00000000
I/DEBUG   (  193):     r8 b5c71100  r9 00000020  sl 00000000  fp b5c6d2a0
I/DEBUG   (  193):     ip fffffa9c  sp be9912a8  lr b5c6d2d4  pc b6e5e544  cpsr 20010030
I/DEBUG   (  193):
I/DEBUG   (  193): backtrace:
I/DEBUG   (  193):     #00 pc 00209544  /system/lib/libart.so (art::OatFile::OatFile(std::__1::basic_string<char, std::__1::char_traits<char>, std::__
1::allocator<char> > const&, bool)+59)
I/DEBUG   (  193):     #01 pc 0020ca2d  /system/lib/libart.so (art::OatFile::Open(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::
allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, unsigned char*, unsigned char*
, bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*)+100)
I/DEBUG   (  193):     #02 pc 00008f75  /system/bin/dex2oat
I/DEBUG   (  193):     #03 pc 0000d6c1  /system/bin/dex2oat
I/DEBUG   (  193):     #04 pc 00012df5  /system/lib/libc.so (__libc_init+44)
I/DEBUG   (  193):     #05 pc 00004ae0  /system/bin/dex2oat
I/DEBUG   (  193):
I/DEBUG   (  193): Tombstone written to: /data/tombstones/tombstone_02
W/art     (  208): Could not create image space with image file '/system/framework/boot.art'. Attempting to fall back to imageless running. Error was:
 Failed to generate image '/data/dalvik-cache/arm/system@framework@boot.art': Failed execv(/system/bin/dex2oat --image=/data/dalvik-cache/arm/system@f
ramework@boot.art --dex-file=/system/framework/arm/boot.oat --oat-file=/data/dalvik-cache/arm/system@framework@boot.oat --instruction-set=arm --instru
ction-set-features=default --base=0x6f978000 --runtime-arg -Xms64m --runtime-arg -Xmx64m --image-classes=/system/etc/preloaded-classes) because non-0
exit status


adding the data for all other `doom1.wad` with `look_for: doom1.wad` should silence this:

```
1.0	4207819	90facab21eede7981be10790e3f82da2
1.1	4274218	52cbc8882f445573ce421fa5453513c1
1.2	4225504	30aa5beb9e5ebfbbe1e1765561c08f38
1.25	4225460	17aebd6b5f2ed8ce07aa526a32af8d99
1.4	4261144	a21ae40c388cb6f2c3cc1b95589ee693
1.5	4271324	e280233d533dcc28c1acd6ccdc7742d4
1.6	4211660	c428ea394dc52835f2580d5bfd50d76f
1.666	4234124	762fd6d4b960d4b759730f01387a50a1
1.8	4196020	5f4eb849b1af12887dec04a2a12e5e62
1.9 4196020 f0cefca49926d00903cf57551d901abe
```


The fuck you say?


Sauf erreur, ce else est inutile, l'exit stop net l'execution du code, si possible reveni a l'ancienne structure qui est plus simple / plus lisible / moins sujette à l'indentation


...but wait, wasn't this the purpose of `distinctive_name: false` ? :confused:


I already had HACX.WAD installed into a directory where g-d-p can find it. Nevertheless, it has downloaded the ZIP file again.


sure! i've written "if the node allows crawlers" man :)

p.s.: @fpietrosanti when replying from mail remove all the message present and leave only your so that tickets remain clear from 'fucking texts not related to the ticket.


Your writing is acceptable, but not great.  A lot of explanations could be simplified.

If you make all the changes I mention, you're looking at 140/100 points.  Most of that extra credit is coming from the tutorial aspect, so that will have to be done very nicely to get the points.


What is this flag doing? Did you forget something here?


Et même plus rapide, bonne idée,par contre je n'ai jamais utilisé readall mais je crois que j'ai formatté pour le human readable sous forme de table ascii, donc pas evident a parser.


@benjaoming I don't think make sense. Someone could potentially override his local settings file.
Besides `shutil.copy` would do the trick if you have to do it. But again `manage.py` is not the best place for this sort of things.


Bon boulot !


delete


Le trim foutait la merde ?


I think these should be singular since the service is a single object. Maybe I'll fix them in the service file instead


@dragonylffly it is used in the tests to assert that the number of changed items matches what is expected.


Victor, should we maybe use our orange-colored OsmAnd icon here for the sleep mode instead? In my mind something colorful would draw much better attention to the fact that something (potentially battery-draining) is still running on the device.

Unfortunately both our old and this new sleep mode icon are very similar to the regular GPS icon now used on many Android devices, see screenshot attached, so I has lead to confusion in the past in several user support cases.
![sleep-mode-icon](https://cloud.githubusercontent.com/assets/845735/8053326/e7a3ec9e-0e8f-11e5-8c3c-2a7acd048fee.JPG)


I can tell this file isn't valid latex right now because of a merge conflict!!!


`brew install homebrew/fuse/sshfs` installs it in a single command.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15983/testReport/) for this commit**


Won't we get backslash '\' as the joined value on Windows? But we don't want that for the DB.


r+


您好，我試了一下這個recoder程式，在模擬器可以使用，錄音時，println("\(a.prepareToRecord())")是True，可以成功使用，但是，在實體手機上，失敗！println("\(a.prepareToRecord())")的結果顯示false，
請問，是哪裡出了問題，謝謝！


One is the chat list, one is the actual chat.


@valib it does, and now the filesize is smaller too. Great work!


Yes, I have already corrected this locally.


Unless we provide some way to make test SKIP, FAIL or ERROR like self.fail/self.skip I disagree with this change.

SKIP: For example you execute a test, which requires 2G memory, but your system has only 1G. You can't check it before the test (the condition might be more complicated than this).

ERROR: How do you distinguish that test failed or there was some other exception? It's good to know the test failed somewhere, where the test developer expected it. There is a great difference between FAIL and ERROR.


Забыла удалить. :snail:


Haven't tested, but it looks good.


I want the cheatsheets and videos moved out of the appendix into a top level section of their own.


Why do I need to use sudo to install sphinx and make docs?


Just FYI, the graviton-api-* apiaries all rather outdated. We will not be importing these into graviton, so if you need the changes from this push in graviton, you'll have to create a story internally.


I guess that @matthijskooijman suggestion is to remove `localPrefs` and just add
```java
dict.put("build.path", buildFolder.getAbsolutePath());
```
on line 1094.
This avoids to create the `localPrefs` copy of the preferences just to carry the `build.path` into `dict`(by copying again `localPrefs` that in the meantime is not used elsewhere).


I think I fixed that here:
https://github.com/tinymce/tinymce/commit/190e3a33398a25a70859b38cbce42c3503c4e34d


No PRs. So far I got around without using them and I don't believe you want me pulling my own PRs right?


maybe it downloaded it only for the `.txt` file .... (?)


#1 solved


make these links instead of bold


Wouldn't it be better to only call self.BaseClass on return?
```lua
function GM:OnPlayerChat(ply, text, teamchat, dead)
   if IsValid(ply) then
     if ply:IsActiveDetective() then
        AddDetectiveText(ply, text)
        return true
     end

     local team = ply:Team() == TEAM_SPEC

     if team and not dead then
        dead = true
     end

     if teamchat and ((not team and not ply:IsSpecial()) or team) then
        teamchat = false
     end
   end

   return self.BaseClass:OnPlayerChat(ply, text, teamchat, dead)
end
```


Other than the links formatting issue, this looks good.


agree web client


@otafuku
ここの処理は、Viewに書くべきではないです。
Viewには、基本的に表示の処理だけを書くべきです。

このようなデータの整形は、コントローラで書きましょう。


I had tested this previously with 'Soltys': I provided the english `vol.cat` & `vol.dat` : GDP downloaded the *Spanish* .zip that per luck has the same `license.txt`... that's a bit of unexpected, but this this build a full package.


This is very nice.  Great job!


function names like open should be in backticks like `open`


Addressed in 0bfcd10ef2a81530697eeef64fcc6d5259302ffb (I think), all tests pass, PTAL.


Чтобы не кастить лучше просто поменять возвращаемое значение метода `getFrame()` (https://github.com/LeKaitoW/rdo-xtext/commit/4a0ce1879dda3e1acefc0ae701857c2e7e475517#diff-4e7b9e8780de69639a1409c4fcebf27cR49) на `ChartFrame`.


@taconaut cool badge :) would be even cooler to have a percentage one like https://img.shields.io/codecov/c/github/codecov/example-python.svg too

Does Jenkins have the ability to keep track of and/or notify of updates to dependencies? I noticed a lot of data about dependencies at http://universalmediaserver-ci.hopto.org:9999/job/ums%20trunk%20(nightly)/site/dependencies.html so I wonder...


Yes, it did. When I add the .txt file to the original directory, nothing is downloaded at all.


Bootstrap can use any line element (e.g. span) for icons. Spans are actually used in the documentation AFAIK.


Думаю, лучше вынести в приватное поле класса.


( Why is there no bug tracker in this repository? There's apparently no way to add report issues on [JetBrains' plugin page](http://plugins.jetbrains.com/plugin/7211?pr=pycharm), either.  :worried: )

The German translation is here, in this file, but it doesn't seem to work in PyCharm (tested with version 3.4.1). There is no syntax highlighting (of the keywords), just the decorators are highlighted (e.g. `@wip`).


Again, this looks real good.  Just make the bold into links.


The missing include is `<stdint.h>`, see 2d5b3d34ecd15baa28a655fc3742fcbd7b3a214f.


corregidos errores que se me pasaron antes de subir el otro commit


Shouldn't the valgrind writeup be in here as well?


looks good


#include <stdio.h>

int main(int argc, char **argv)
{

    //Un programa que pida un número del 1 al 5 y diga si es primo o no.

    int numero;
    int i;

    printf("Dame un numero desde 1 hasta 5: ");
    scanf("%d", &numero);

    if(numero == 1)
    {
        printf("Tu numero no es primo");
    }

    if(numero > 1)
    {
        for(i=2; i<numero; i++)
        {
            if(numero%i == 0)
            {
                printf("Tu numero no es primo");
                return 0;
            }
        }
        printf("Tu numero es primo");
    }
return 0;
}


please add a note about this not being a mandatory dependency. This storage backed is available only if influxdb package is installed in the user environment, otherwise it doesn't work.


great!


How did this pass? When I do debug:router I see:

```
cget_aamcmethods                                GET    ANY    ANY  /api/v1/aamcmethods.{_format}
 get_aamcmethods                                 GET    ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 post_aamcmethods                                POST   ANY    ANY  /api/v1/aamcmethods.{_format}
 put_aamcmethods                                 PUT    ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 patch_aamcmethods                               PATCH  ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 delete_aamcmethods                              DELETE ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
```


Thank you @lsegal
I've verified it in my local Windows:)


Leading space spotted :p


It would be enough to remove the space in `match_array (args)`. That whitespace is significant in Ruby because it makes the method take only one argument. See also http://stackoverflow.com/questions/16397070/why-is-farg-superfluous-arg-an-argumenterror-but-f-arg-superfluous-arg-a-s


Great, looking forward seeing aexpect as standalone app.


Same as above:

```
cget_aamcmethods                                GET    ANY    ANY  /api/v1/aamcmethods.{_format}
 get_aamcmethods                                 GET    ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 post_aamcmethods                                POST   ANY    ANY  /api/v1/aamcmethods.{_format}
 put_aamcmethods                                 PUT    ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 patch_aamcmethods                               PATCH  ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 delete_aamcmethods                              DELETE ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
```


Yep


./bin/console debug:router

```
cget_aamcmethods                                GET    ANY    ANY  /api/v1/aamcmethods.{_format}
 get_aamcmethods                                 GET    ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 post_aamcmethods                                POST   ANY    ANY  /api/v1/aamcmethods.{_format}
 put_aamcmethods                                 PUT    ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 patch_aamcmethods                               PATCH  ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
 delete_aamcmethods                              DELETE ANY    ANY  /api/v1/aamcmethods/{id}.{_format}
```


it wasn't ... the test failed then ... bcs of trailing ```.uniq``` ... and the line was long anyway, so I've moved into variable


could have used an object rather than an array


good


also good


I really am not a fan of this


感觉appveyor那边之所以挂掉，跟npm版本有关系。

```
npm ERR! Windows_NT 6.2.9200
npm ERR! argv "node" "C:\\Users\\appveyor\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "install"
npm ERR! node v0.10.38
npm ERR! npm  v2.10.0
npm ERR! path C:\Users\appveyor\AppData\Roaming\npm-cache\object-assign\2.0.0\package\package.json
npm ERR! code EPERM
npm ERR! errno 50

npm ERR! Error: EPERM, rename 'C:\Users\appveyor\AppData\Roaming\npm-cache\object-assign\2.0.0\package\package.json'
npm ERR!  { [Error: EPERM, rename 'C:\Users\appveyor\AppData\Roaming\npm-cache\object-assign\2.0.0\package\package.json']
npm ERR!   errno: 50,
npm ERR!   code: 'EPERM',
npm ERR!   path: 'C:\\Users\\appveyor\\AppData\\Roaming\\npm-cache\\object-assign\\2.0.0\\package\\package.json',
npm ERR!   parent: 'gulp-util' }
npm ERR!
npm ERR! Please try running this command again as root/Administrator.
Command exited with code 50
```


fixed


No dependences outside utils, good.


how  to show backdrop now ?


some parentheses would have been good:

```php
($weightCount20 = $this->countItemsWithWeight('10', '>')) > 0
```


Congratulations ! :tada: :beers:


mas @agung_pratama_w: tolong rollback dulu.. ini allowed_value jgn di push begini, apalagi di standard_field nanti muncul di semua feature


I also have a small fix: in messages.xml, type for motor_nb_err is uint32...


r+


OK


I think remove tildes as well and just leave fixed values if thats alright? IMO, thats the only way we can guarantee that this repo works when somebody npm installs it.


Changing the types here, whilst desirable will likely break some existing clients.


@mchf Ah, I see now, `match_array((a + b).uniq)`, tricky syntax indeed :-/


Tegra supports multiple Trusted OS', TLK being one of them. We want to be able to do this without modifying the code. Will modify the text to explain this scenario.


1. Rebase and set one commit to "Edit" status
2. Start rebase and wait it stop at that commit
3. Open another new Log Message dialog (Now, HEAD is detached.)
4. Right click top-left hyper link control and click "HEAD"


Sorry, will remove this line.


这里冲突了


@neglectedvalue Je ne sais pas... It just wouldn't work for me without it. I don't know much about the internals of sphinx though, if there's a way around it, please feel free to update the docs.


Hi Valentin,
this code breaks search and list subcommands:
dnf  copr search xyz
Error: use format `copr_username/copr_projectname` to reference copr project
Error: bad copr project format


lie to mi


You should not have blank lines like this everywhere.


s/From/Within


s/-g/`-g`

Code always gets put in backticks


You are welcome :-)


Are your sqlite databases persisting through tests?


You're giving me gdb commands, but you haven't actually started gdb yet!

You need to display EVERY command needed to reproduce your output.


word应作world


@csware
Or do you ask how to reach ```sBranchOut = _T("HEAD");```? ^^!


"must" is the wrong word


> fixed
awesome!


if statement without a then


Technically, this was a good explanation.  Your writing quality could be improved a lot though.


Don't do this!


ertyuu


Again, you need to show all the commands, including starting gdb.


nihao


用荒谬不大贴切, 忠实比较好.
word应作world


надо было добавить и bower_components/


dsa


nice :coffee:


OK, thanks


o kurwa XD


( Why is there no bug tracker in this repository? There's apparently no way to report issues on [JetBrains' plugin page](http://plugins.jetbrains.com/plugin/7211?pr=pycharm), either.  :worried: -- Are issues to be reported in JetBrains' bug tracker? If yes, where? If there were a README making this clear...)

## Navigating to steps not working in PyCharm

When editing a `.feature` file in PyCharm (version 3.4.1 tested) the step definitions are highlighted (as when they were erroneous in source code) and the tooltip says "`Undefined step reference: <text of step definition here>`".

When you click on the step definition (e.g. `<cmd>`+`<mouse click>`) the error message "`Cannot find declaration to go to`" pops up.


It would be better to isolate this (atomic commit).


motor_nb_err is uint8...


I can't actually watch your strace video right now because the computer I'm on doesn't have sound.  But I can tell from looking at it that you need to make your font much larger so I can actually read it.  Also, you have a lot of wasted screen real estate, and you'd probably be better off using two terminals side-by-side (although maybe not, that's for you to decide).

You'll have to fix the font size before I watch it.


Any specific reason to force usage of cpphs here?


does it really work on your device? Seems that it is possible to write to only specific folders like /storage/sdcard1/Adnroid/data/es.esy.CosyDVR/.... for Android 4.4 KitKat like this http://www.instructables.com/id/How-to-bypass-Android-44-KitKat-external-SD-write-/


@otafuku
アクションメソッド以外はアクセス修飾子を極力'private'でお願いします。


Ah, sorry, I missed one thing earlier. Please protect the "m" parameter from double evaluation. This is a general problem with macros. i.e. consider the case where somebody has an array of sd_bus_message objects and now passes log_debug_bus_message(m++). This will effectively increase the pointer not by 1 with the macro above, but by 9...

Hence, please change the macro like this:

#define log_debug_bus_message(m) do {
        sd_bus_message *_m = (m);
        log_debug("....,", bus_message_type_to_string(_m->header->type, ...);
} while (false)

This way we first cache the parameter in a new temporary value, and then use that. That way "m" is only evaluated once.


pass doesn't enforce it, the Firefox plugin does AFAIK. I would support both at least.
What do you think?

Nico


I believe this was removed in 40ff539e2a01635364d17efced167376e0dd6d5d to fix the issue: https://github.com/agoravoting/agora-dev-box/issues/11
Is there any reason it's been reintroduced?


Это БЭМ!!?
какой то он очень странный)


Yes.  This may be something we could fix, but it would make include vs. extend much more consistent if we required the extension to be explicitly specified here.


poked!


is this a trigger count?


If a remote doesn't exist we are synchronized? I guess you'll have to explain this to me, but having a local but no remote doesn't sound in sync to me :)


Попапы лучше в конец body писать
нельзя только на z-index надеяться


@ValeraS Пропустил это сообщение
Отвечаю по пунктам:
- Если контекст не установлен, это ошибка сценария или кода. В итоге будет исключение, значит, тест упадет. и это хорошо, т.к. тест упал на ошибке.
- по Структуре и свойству Ключ - я решил слишком уж не заморачиваться с проверкой в тесте. Если не будет структуры или не будет свойства Ключ или вернется неверное значение, это ошибка и тест упадет, что является верным поведением теста.

ИМХО все верно и ничего добавлять не нужно.
Если хочешь, то можешь доработать :)


to raise?


for future reference - commit message: usually no trailing periods are allowed. I think the shortlog could be better too. Ack anyway.


It's hard for me to manually test it since I'm in Sweden ;-)


i'd prefer just a simple deep comparison.

```js
expect(changes).toEqual({ object: 'with', all: ['the', 'properties'] })
```


ack


I don't understand this change!


@pgo-eea-sk  / @jindrichmynarz is it OK to allow all RDF formats?


reviewed


He says 'Fine. Be that way!' if you address him without actually saying **anything.**


The diff of `lib/settings_validation_wrapper.rb` is somewhat irritating. I only moved the methods `base` and `get_value` up - to make them public - and I made them class methods.


Ah, uhm, yes, may be: the bad is that `platform.keys.rewrite.txt` work with the whole key value, but sure it's cleaner. Thanks


edfg


In that case, yes, it's an optimization easy to code


Link is down it appears.


This ensures that HHVM is restarted just once and not every minute between 2 and 3am.  Also provides for full path to the service command.


@SubJunk It looks like a badge is on the roadmap for Cobertura https://github.com/cobertura/cobertura/wiki/Roadmap#add-badges-to-htmlxml-reports (I'm not sure showing a badge with a coverage of a few % would be a good thing at the current stage ;)

I'm not aware of any plugin keeping the history of dependencies for jenkins, but I might have missed it in the plethora of plugins available https://wiki.jenkins-ci.org/display/JENKINS/Plugins


this conditional always runs. please remove it


a test for each behaviour would be great. could you move this one into a separate test? maybe have a beforeEach for the setup of both?


+1. Preferably either using something like CommonJS (i.e. inline with new modules in ES6)


ty ne prav


Use `$( )` instead of back ticks


Ah wait, I didn't look at this super closely. Why did you remove *args, and **kwargs from this?


Use `$CPU_THREADS`. `$NO_THREAD` is confusing.


This might be something https://www.npmjs.com/package/istanbul-cobertura-badger


What was the problem with Bancroft? Just curious


Oh tabs, why are they here?!

Anyway, @missx take a look and enjoy (?)


Please see CODING_STYLE: we don't make up error codes like "-1". Please use return -errno, or so, since that's how we indicate errors to callers.


Same here...


As I mentioned before, string functions aren't UTF safe - although it's interesting that it works on my server.

Perhaps there's a difference between UTF8 and UTF16..?


update #17


Yes, this shouldn't be there. I'll remove it again. Thank you


accep commit from adinugraha


if this is now a generic function, I'd prefer if these assert() checks would actually become clean if checks, that return -EIO or so if they don't hold.


I figure not only sender_fd should be checked like this, but also fd.


I'd call this function "send_one_fd()" actually, to indicate that we sent only one fd, and no payload at all.


I really like this patch generally, it's a great simplification!


When cloning or any other operation which is network dependent, try to use `exec_with_retry2 ()` function from here https://github.com/cloudbase/unattended-setup-scripts/blob/master/utils.sh#L3 which retires a few times before aborting.


@bgavrilMS Do you think it could be possible here to not have to hardcode the path computation logic (i.e. "sqtemp") ? That logic is already in the BeforeTargets MSBuild targets & the settings class within the MSBuild Runner Bootstrapper


Nicolas Petton <notifications@github.com> writes:

> pass doesn't enforce it, the Firefox plugin does AFAIK. I would support both at least.
> What do you think?

ok

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill


I would prefer math instead of test method to avoid keeping an unused regex internal index pointer


I've also just noticed I forked this branch from `issue_152` rather than master.  Buggrit, buggrem...


Please be careful at indentation


I am not sure, but possibly error here.
When BUILD_SHARED_LIBS=ON then ejdb_p is STATIC (according to line 43). An on this line 149 you set linkage list to STATIC inside if BUILD_SHARED_LIBS branch.

But I am not good at CMake, so I may be wrong.


This doesn't matter much I guess, but it certainly makes things more descriptive, hence looks good.


All Lua 5.x already have a unpack function:
* `unpack` for Lua <=5.2
* `table.unpack` for Lua >=5.3

Your `unpack` function should be only usefull for Lua before 4.x

Do you really need Lua 4.x support ?


Looks good!


why do you invoke bash again ... are you in a different shell?


`exit 0`


same as above match in favor of test


I see your point, and I'd like to expand the discussion.

How do you guys feel about users raising exceptions so that can either SKIP or ERROR their test? Even though exceptions are 100% Pythonic, I have the feeling that these should be private to the framework.

As @ldoktor suggested, I believe a more user (test writer) oriented and friendly approach would be by with utility methods, in line with `self.log.warn()`, say named `self.skip()` and `self.error()`. Methods are easier to be documented and that can look a lot better in test examples.

This would be part of the standard Test API, and would have stability promises.

Comments?


Yes, but maybe it should be uint32?
uint8_t _motor_nb_err = motor_mixing.nb_saturation + motor_mixing.nb_failure * 10;
since nb_saturation and nb_failure are uint32?
Sorry to put this here...


so neat :+1:


There is such combobox in t-rdfToFiles. I did it the same way to be consistent.


How about:

```python
for loader_class in self.args.__dict__.itervalues():
    ...
```


Nitpick: by using the ``validated petition "blah" exists`` and ``pending petition "blah" exists`` steps (:+1: a good choice!) we can remove the ``, state: "whatever"`` part as it's redundant.


the same here


Do not exit from function, return a value which you evaluate later.


Neat, that is a nice catch.


Use $( ) instead of back ticks


Ha non mais y avait une très bonne raison pour ça.
Je me souviens plus laquelle... mais une très bonne raison je vous dis !


It's fixed now - wasn't to do with this at all!


Nitpick: I would drop the ``radio button`` part of this step name.  The radio button isn't super important to the definition (in the future we might change it to not be a radio button, but we shouldn't have to change the step name to reflect that).


ok!
Have already tested, have you run mvn install?


Should not `emacs` be written as `Emacs`?  As far as I know, that is the name of the editors.  `emacs` is only the command to invoke it.


It would be better to bind a dummy foreign call for Haiku, that just returns -1. i.e.:

```
#ifndef __HAIKU__
foreign import ccall unsafe "mlock"
        c_mlock...
#else
c_mlock :: Ptr a -> CSize -> IO Cint
c_mlock = return (-1)
#endif

that prevent the ifdef machinery to be spread all over


I have to ignore this files
It's not needed to commit this files


ignore this file


ok I've made it a string contact in LOG_GET


ignore


That is great.


Okay.


ok thanks


this field was originally the blmc_nb_err, and I didn't want to change the
message size...
Maybe we should re-purpose the (currently unused) imu_nb_err field instead?
Feel free to open an issue for it...

On Tue, Jun 9, 2015 at 11:13 AM, Drumettaz <notifications@github.com> wrote:

> Yes, but maybe it should be uint32?
> uint8_t _motor_nb_err = motor_mixing.nb_saturation +
> motor_mixing.nb_failure * 10;
> since nb_saturation and nb_failure are uint32?
> Sorry to put this here...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/paparazzi/paparazzi/commit/0bc805da09beb1d93f30a692ecb9e91504f64749#commitcomment-11583922>
> .
>


This looks just like removing & renaming. Not sure what exactly to check here, the compiler surely did a better job than I ever could :)


:1 done


Only xrootd debug message are logged here so maybe we can keep it for a while. I added a comment here, thanks


Still waiting for that pull request :horse:


4: L102 copyright year is outdated, expected 2015 but got 2013
27:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
31:1: E302 expected 2 blank lines, found 1
60:13: E128 continuation line under-indented for visual indent
98:13: E128 continuation line under-indented for visual indent
100:1: E302 expected 2 blank lines, found 1


The new qb doesn't support custom constraints. I'll need that.. :(


Nitpick: ``s/not validated/pending/`` ?


@bittner please report issues through [YouTrack](http://youtrack.jetbrains.com/)


--test


Change Ender Chests


Change Enderchests.


Oh yea oops. Sorry, didn't take enough time to look at it properly as I'm
far too busy in my role as a UI Consultant...

On 8 June 2015 at 17:40, Cameron <notifications@github.com> wrote:

> Err.. If changeOnFly is set it calls updateResultImage(). The first thing
> updateResultImage() does is call updateAreaCoords(). So...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bbc/ngImgCrop/commit/e92a393418d4383b59744288c081638f0ed0e268#commitcomment-11571205>
> .
>


The `ejdb_p` static target is used by testcases and it is a static library artifact produced regardless of the `BUILD_SHARED_LIBS` option value.

When `BUILD_SHARED_LIBS=OFF`:
The `ejdb` target compiled as static library
The target `ejdb_p` is a simple **alias** pointing to `ejdb` target and it does not need `target_link_libraries(ejdb_p ${EJDB_LLIBRARIES})` instruction.

When `BUILD_SHARED_LIBS=ON`:
The `ejdb` and `ejdb_p` are independent targets.
`ejdb` compiled as shared library
`ejdb_p` represents static and have to be linked  agains `${EJDB_LLIBRARIES}` on line 149


reack


Instead of redefining the conditions for finding petitions in the ``COLLECTING_SPONSORS``, ``IN_MODERATION``, and ``TODO_LIST`` states in this ``for_state`` scope we should call out to the individual scopes that already define those conditions:

e.g.:
```ruby
elsif COLLECTING_SPONSORS.casecmp(state) == 0
  collecting_sponsors
elsif IN_MODERATION.casecmp(state) == 0
  in_moderation
elsif TODO_LIST.casecmp(state) == 0
  todo_list
```

Be worth seeing if the same can be done for ``CLOSED_STATE`` and ``OPEN_STATE`` too.


I would reword it:

    Storage backends are responsible for sending data sent by the metrics service to external storage system, such as relational database, nosql, etc


please describe what influxdb is (a database, a cloud based service,...)


Sure, the NUL byte must stay, it's part of the protocol. I was more wondering whether to use the creds data attached to it or not.

@keszybz I am very sure we should use the exact same mechanism as upstream dbus-daemon/libdbus use on Linux here. I.e. if they use SO_PEERCRED on Linux, then we should use that. If we use SCM_CREDS instead on the NUL byte, then we should use that.


me**t*r*ics

I would say that it intends at "filtering" which properties to send to the storage service.

This makes me think one would want 2 filtering levels:
- one general, to send data to ALL metrics storages
- per storage filtering


Why not use the ``.todo_list`` scope you defined in the previous commit?  It might mean we could even remove the ``TODO_LIST`` branch from the ``for_state`` scope and that might even allow for us to drop the ``Petition::TODO_LIST`` state and address @otlaitil's comments.


Guidelines are saying to use this color


Why are we hiding this behind a conditional?  Is there a compelling reason not to always show the state?


LGTM


Werelds Wess


Did you change the IP address by intention? I fear this will break our nightly test.


What was the issue?


The user documentation should not redirect a user to the developer documentation.


12 Lead NN is an ECG classification project. It learns features from each lead separately and combine the activation before soft-max layer. All previous layers are seperated, so each lead's features are learned by its own.


First of all, `checkNotModified` does not necessarily imply read-only to me. A getter method implies read-only; besides that all bets are off.

Second, I am not a big fan of deprecating `checkNotModified` if the names we come up with are not much better:

  * `processConditional` is a meaningless name, it requires me to read the Javadoc to read what the method does. Granted, you'd also have to do this for  `checkNotModified` to read about , but that's the point: the new name should be *better*, not equally bad.

  * `validateEtag` and `validateLastModified` imply that these methods check the validity of the ETag/Last-Modified header, to see whether it's in the right format. And that's not what the methods do.

  * Using `handle` as the method prefix is as meaningless as `process`.

The original `checkNotModified` method has been with us since Spring 2.0, so almost 10 years. And its documented usage does read rather nicely:

```java
public String myHandleMethod(WebRequest webRequest, Model model) {
  long lastModified = ...
  if (request.checkNotModified(lastModified)) {
    return null;
  }
  else {
    model.addAttribute(...);
    return "myViewName";
}
```

Granted, it can be confusing that the method actually adds a header (**only if not present already**), but I consider that part of the modification check. And I do like the `check` prefix: it implies a boolean return value.

So, in conclusion, if we change it, we'd better come up with a name that is clearly better than the current one. I don't think any of the current suggestions are.


Fijn dat je de rotzooi van @Lg0enga even opruimpt :poop:


that introduces a typo.


This is not sufficient. The journal uses /var/log/journal as well as /run/log/journal, depending on whether persistent storage is on. But either of these directories might be missing, including both.

I figure the bus call should actually return an array of fds instead of just one. And it should contain 0, 1, or 2 fds... (though we'd leave it open for future improvement to even include more fds one day...)


This is what hours of coding will make you do! Feel free to PR!


    git -C systemd describe --tags

would be better =)


Thanks for such a quick response


Why store this in "r" in between? COuld just be "return send_fd(socket_fd, fd)", no?


That's true, I was quite precise about it as the capybara matcher for radio buttons is different, but you right it doesn't matter to the user:) Will change it.


Makes sense.


I think this function should actually turn the fd as return value, instead of a "int *fd" call-by-reference parameter. So that a return value < 0 is an error, and a return value >= 0 is a valid fd. That's how we usually did these things, and we should do that here too.


test line note


I guess this should be named GetJournalDirectories() or so, to indicate what precisely we get from the journal. And as mentioned, it should probably return an "ah" instead of a single "h".


`not validated` here refers to sponsors not petition - they've signed in but didn't validate their email. Not sure if that was what you meant?


@yehudasa , It seems that since bf8f0625bd9ae, the multipart object will not be part of the written objects. Since I test the test case mainly on giant(0.87), where bf8f0625bd9ae is not merged, I have to do more work to prevent this object from been deleted.


Absolutely:), will remove.


See CODING_STYLE: we place the opening bracket for functions on the same line as the function name...


Hi guys, I've done a major code refactoring that unifies and encapsulates the axes much nicer. There are quite some changes and also a new axis `ContinousAxis` that allows to use ticks or a divisor to divide the range of data.

@baks Can you rework your code with the new base? There's no need to use a new chart type as the Line chart is handling the axes dynamically. They get instantiated dynamically and they have a fixed interface (you can check in the existing axes).

As the axes are completely independent now, it would make sense to use a separate repository in cases an axis is rather complex (maybe time axis with a moment.js dependency).

I'll also work one some changes but I think the groundwork is laid.

Internally series data arrays always get normalized into multi dimensional series data like so:

```javascript
var data = [1, 2, 3]; // gets {y: 1, x: undefined, y: 2, x: undefined, y: 3, x: undefined}
```

In order to specify two dimensional data for both axes you can use this object notation of values directly.

```javascript
var data = [{x: 1, y: 100}, {x: 2, y: 120}, {x: 3, y: 140}];
```

When the values get projected, the axis will only use the value relevant for its dimension. This way you can now easily create a XY Chart with these options:

```javascript
new Chartist.Line('.ct-chart', {
  labels: [1, 2, 3],
  series: [
    [{x: 2, y: 100}, {x: 30, y: 120}, {x: 2, y: 140}]
  ]
}, {
  fullWidth: true,
  // As this is axis specific we need to tell Chartist to use whole numbers only on the concerned axis
  axisY: {
    onlyInteger: true,
    offset: 20
  },
  axisX: {
    type: Chartist.LinearScaleAxis,
    onlyInteger: true
  }
});
```


Yeah, just that "not validated" sounds a bit clumsy (to me).  We can still talk about pending sponsors and pending signatures.


![schermafbeelding 2015-06-09 om 11 45 54](https://cloud.githubusercontent.com/assets/1521207/8055047/28be73fe-0e9d-11e5-9d5e-53be256e9363.png)


The conditional operator ?: takes precedence here.
At SpNode this is resolved to "FutilityMoveCounts[improving][depth] + 2", otherwise to "FutilityMoveCounts[improving][depth] + 0".
Correct me if I'm wrong.


Test failed. weil mein neuer GUI Test nicht mit "Remove unused Buttons" vom letzten Commit kompatibel ist.


Nitpick: could we do something so that we can still re-use the ``results_per_page`` partial?  Perhaps it only contains the per_page elements and go button?  Or it becomes a helper that takes a block for adding extra things to the form?

I know it's only a label, a select and a submit button and the wrapping form, but the partial has some JS stuff on the form that we've lost here (perhaps intentionally, perhaps not!) and it would be good to have consistency across the admin UI.


@WesselKoorn  @Lg0enga
![schermafbeelding 2015-06-09 om 11 45 56](https://cloud.githubusercontent.com/assets/1521207/8055056/327d43d4-0e9d-11e5-8afd-a01825b8ad14.png)


I don't really get why we need this new object. Is tje same object really referenced by multiple journal sd_journal directories at the same time?

I also would be careful with attaching description strings to each individual fd, because I'd abstract away where precisely the fds come from, in particular if we have multiple of them...

Wouldn't it suffice if sd_journal just stores the dir fds we get as-is, without any object around them, and without any descriptive string around them?


Didn't want to change the current behaviour that doesn't show the state of a sponsored petition
(awaiting for moderation). Do you think we should show it always now? Or only if we want to show 'hey, it might be not ready for being published yet'.


add chart


Without type arguments we have "Type inference failed" error.
Also, after replacing `Void` with `Unit`, we have an error during compilation, because return type of getName() is ID<Kotlin.Int!, java.lang.Void!>!.


What kind of result do you get from here ` velocity.y *= -1;`


I am pretty sure we should not generate such a string at all... I think it might make sense to store the machine name somewhere, but not in a pretend-path string...


Hi,

would it make sense to convert the write function first to a buffered variant, that does not send each individual character?

Additionally, please include a hook into setup.py to run the tests. (look at http://stackoverflow.com/questions/17001010/how-to-run-unittest-discover-from-python-setup-py-test for ideas)


hm, I can't say much about this than to observe that it seems to work. Ack.


I don't think it's harmful to always show it.


add picture


add project name


Just noticed that this could probably just be ``<%= @petition.state %>`` - the state of the petition is a simple string, it won't need auto-linking as it shouldn't contain any urls.


so why does it work on circleci without the dbus-launch prefix command?


I've set [s3] host in /etc/boto.cfg but this check ignores it. Is there any reason to ignore host value from config file?


Do we really need this? I mean, GNU basename() does not modify the arg either, doesn't it? Hence, we should be safe...

Also see CODING_STYLE about this.


фронт контроллер выноси в отдельную папку, куда будет ссылаться веб-сервер, например как в симфони папка web/, чтобы из вне небыли доступно ничего, кроме того что должно быть доступно из веба :)


@NobodysNightmare this shouldn't be necessary


this member isn't used in any of your commits.


Mooi gaan @Lg0enga :dancers:


@NobodysNightmare you'll find `.required` is defined twice - in both `_tabular.sass`and `_misc_legacy.sass`. No idea why, but it should be removed here.


Preporučio bih ti samo da uvijek koristiš vitičaste zagrade uz naredbe za kontrolu toka (`if`, `else`, `for`...). Iako nisu obavezne za samo jednu naredbu, njihova konstantna upotreba može spriječiti dosta bugova


все классы мы именуем в соотвествии с PSR почитай вот тут http://www.php-fig.org/psr/psr-1/ru/ и далее 2-ой тоже относится к оформлению кода


`app/config/config.local.sample.neon ` :+1:


Makes the boot script more tolerant for slow docker setups. Will only exit in case of an error or if the service is up.


I've deprecated this in https://github.com/mysociety/alaveteli/commit/80dca6c1ff43519f673debe9a2302a7a204fba77 – someone else might be using it?


.иедя выносим в глобальный .gitignore


Good catch. Indeed, it is consistently written Emacs elsewhere, so yes, I'll change this in a next commit.


To be honest: This was the only place where I did not check to which actual elements the style applies.


отступы делай везде одинаковые, в соотвествии с PSR - это 4 пробела


комментарии к файлу мы не используем ;)


```
first.map_with_index do |elt, i|
  elt == second[i] ? 0 : 1
end.reduce(:+)
```


Ovdje imaš opasnu grešku! Porediš varijablu `number` koja je tipa `float` sa karakterom `' '` (jedan space). Ovo vjerovatno kompajler ne bi trebao ni dozvoliti, ali ako i dozvoljava sigurno ne radi ono što očekuješ :)

Ako si htio provjeriti da li je argument prazan string, onda si trebao provjeriti da li je varijabla `num` jednaka `""` (obrati pažnju na duple navodnike i na to da nema space-a između njih). Za poređenje stringova bi onda naravno koristio `equals()` metodu.


если хочешь селать комментарий к всему классу, то пиши его над объявлением класса, а не под :)


If you read the code right, this at the moment supports monthly and yearly recurring events?

Could it also support weekly events?


Sure, that sounds like a good idea.


int64_t feels like an weirdly arbitrary type here...

I'd prefer if we'd stick to unsigned here, but used (unsigned) -1 as the special marker for the new behaviour.


A gotcha? Or are we planning some more?


This also needs a man page update.


Looks OK.


I've noticed since upgrading to Nancy 1.0 (from 0.23) that diagnostics providers include functions like ToString, MemberwiseClone, Equals, GetHashCode, GetType and Finalize. In short, all of the basic functions in C# object. It seems like it would be a good idea to filter out those functions before so they don't get shown in the diagnostic interface.


Sorry -- added this comment as a result of a webex with Dave. We should be accessing the op flags through `ep->ep_tx->tx_attr.op_flags`, but the dgram end point currently doesn't handle the `ep_tx` and `ep_rx` fields correctly. This is coming in a future PR but involves a lot more changes to properly handle contexts.


This is my first time for GitHub.


Note: In ST-00-06-09 the mc15 configuration files are used by SUSYTools. We will then need to move back to these for the next production. I will be sure to do this once I start validating AnaBase,2.1.14 + ST-00-06-09.


Add ?w=1 to the end of the url and github will show you only significant changes


Not sure about this, the `test/run-build.js` script didn't exist in the tree, `test/test-build.js` was the closest file match.


I like that suggestion.  Let me take a stab at that.


Missing space between `&` and `+`?


Possibly. I just moved this from the other notebook because I felt it was more appropriate here... but as I said there's still some reorganizing and stuff to do :-)


@taurose it's for both.

The idea here is that you can give us some state and we'll store it and give it back to you on `location.state` when you need it. We reserve a few properties for the router, including `key`, `scrollX`, and `scrollY`. If you create an instance of `HashHistory` with a `queryKey`, we use a query string parameter + `sessionStorage` for persistence.

Does that work?


It caused other issues which is hard to fix or is not clear. May be Hardy will help with it, because he had an issue with volume button!


I should replace this with `coinsToSteal = Math.min(target.coins, coinsToSteal);`


This needs some compile-time tests for both negative and positive cases, with and without void return types.


Here is a almost complete rewrite of the pwm channel handling, allowing to use any number (up to 8) and arbitrary mapping between physical and interface channel numbers.
For now I stick with the "oldschool" style, using conditional preprocessor cascades. If all is working well it may be a good base for conversion.

In "pwm_init()" I left two conditional blocks seperated as one ist writing in _PWM_ and the other in _GPIO_ registers. They may be melted together,
"periph_conf.h" has a sample output configuration which is proposed [here](https://docs.google.com/spreadsheets/d/1g5xMpLbi6cMc9QdHQrpf3XH_hiRb4wrAu1wvvpelMUw/edit?usp=sharing).


Shouldn't we do this in `RLMObjectBase`? If that's not possible, just remove the trailing semi-colon here please.


Via Home button (Android) long press and swipe right. We investigate how to disable services automatically, for now you will need to click on notification, if you have GPX recording. Basically instead of kiling the recommended way is just to stop offline service (nothing in the top bar), that's enough to say OsmAnd is not running


Reveted due to build bustage, will investigate further for Linux.


The merge on line 189 should end up with unique list


I'm also planning on putting a `state` prop on `<Link>` so that links can pass stuff into this state.


1665-AppPackagingError (kbenne) - i386-Windows-7-VisualStudio-12: OK (2174 of 2202 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.73%25-yellow.svg)


what should? `iterators`?  that refers to the `iterators` in the `./iterators` directory


Maybe this code should go in `compileLoad`?


@kibra
Summary of recent issues:
I introduced a bug in the April deploy. We needed to call the construct_resolve_slist function just to see if we had a change in our list of IP addresses (node added to cluster), and if it was, we needed to destroy the current session and create a new one for the new resolve_slist. However, in destroying the session, we also cleanup, and delete the resolve_slist we just created. The fix is to recreate it when we detect that we have created a new session. Without a new resolve_slist, I believe that curl goes with the getaddrinfo default, which is picked based on a quasi-geo-location algorithm. The node which I happened to choose to take down to do the test had the IP addr which I think getaddrinfo defaulted to, so we would try it and fail, and then esssentially have getaddrinfo choose it again, and try and fail, then a third time. This then turned on saint mode, and all attempts on the thread to create a file failed since saint mode prevented accessing the cluster for 10 seconds, and for creates and deletes, has no choice but to return ENETDOWN. It also explains why some file creations succeeded; those were on threads which by chance had a different node at the top of their resolve_slst.
Currently we call construct_resolve_slist to see if we need to create a new session, then call it again. We might figure out how to do this more elegantly.


sorry, i thought it was from `this.iterators = options.iterators`


I think everything looks good except the changes you made in lines 79-86 of `fb_chat.py`. The `str()`conversion is actually needed because without it a `beautifulsoup_string` (or something of that sort) is returned, which causes problems when pickling the messages. If that's not the case anymore just let me know.


When I install RASPA2 thorugh pip package manager, it gives following error. How can I solve it?

![screenshot 3](https://cloud.githubusercontent.com/assets/12029276/8072442/bfb3e67c-0eca-11e5-9ddf-0c5c53193ae0.png)


$mapper->setHydrator(new UserHydrator(new \Zend\Crypt\Password\Bcrypt));


TeamCity Azmq :: Build (Windows) [Build 137](https://78.46.71.115/viewLog.html?buildId=519&buildTypeId=Azmq_Build&guest=1) is now running


TeamCity Azmq :: Build (Linux) [Build 106](https://78.46.71.115/viewLog.html?buildId=518&buildTypeId=Azmq_BuildLinux&guest=1) is now running


TeamCity Azmq :: Build (OSX) [Build 90](https://78.46.71.115/viewLog.html?buildId=520&buildTypeId=Azmq_BuildOsx&guest=1) is now running


TeamCity Azmq :: Build (Linux) [Build 106](https://78.46.71.115/viewLog.html?buildId=518&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:06


TeamCity Azmq :: Build (OSX) [Build 90](https://78.46.71.115/viewLog.html?buildId=520&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:14


TeamCity Azmq :: Build (Windows) [Build 137](https://78.46.71.115/viewLog.html?buildId=519&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:19


You used my code!


This change has stopped the token generation from happening now, as it throws an exception from line 44 in this class with the message:

```
"Could not create token: Undefined index: alg"
```

How is this supposed to be set after this change?


This README is much nicer now, thanks! The only thing is I'm writing this in python 3+, so if there arises any differences between the two, the python 3+ version is the way I'd like things to go.


Эти настройки из другого проекта


static


Is this really being used?  Tags are already sorted as part of the of the `Point.Key`.  It's a different sort too.


remove semi colon


Grammar: "are not load**ed**" or "**do** not load"


This whole function may not be needed any more, but we'll have to see once compilation is working on the branch


follow code style


Hey everybody, sorry I'm so terribly slow right now. I promise to get better :) Reviewing this now, but might take a day or two of testing!


Maybe I still am confused, mainly because of PhysX and those last 5 lines of this document... Am I in trouble or something? I could switch back to Bullet or just discard this license all together (more probable) and use something else more fitting, can anyone help me on this?


1679-DualDuct (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2130 of 2214 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-96.21%25-yellow.svg)


This should have a PLUMgrid agnostic name...what does PEM stand for in real-world terms?


Please use lock_xadd, which masks the return value (not supported by BPF JIT).


This also makes progress on #34


Proposed change here: e5153b971843604018e91387534729c2a3d37660


Oh I see...this is not the original acronym meaning of PEM: PLUM Engine Manager.


магию проверки можно спрятать - 3 последние строки можно обернуть хорошим названием


nice repo name! :D


typo?


what is this ?


@jasonmit Does this work for you locally on PhantomJS 1.9.8? Currently still failing the four tests locally for me, but noticed it's passing Travis.


You mean is `marshalTags` used? Yes, I see it used in `tsdb/meta.go`. Sounds like we're doubling sorting, since `marshalTags` also sorts tags keys.


FieldValueGenertor ==> FieldValueGenerator


1679-DualDuct (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Forgot: http://bugs.mtasa.com/view.php?id=8654


@Asiant So, now that I've accepted your pull request,  and there are some new commits to the master branch on Equitable's repo, you are in likely one of two scenarios:

1) You haven't made any changes yet.
2) You've done work, either on your master, or on a new branch off of master

Case 1, is easy.  Before you do any new work, you'll want to synchronize your GitHub repo with Equitable's Repo.  More info, here: https://help.github.com/articles/syncing-a-fork/

Case 2, is easy too, just slightly more intimidating.  You have lots of options.  You can deal with it by either continually rebasing, and handling minor (small/easier) conflicts as they pop up.  Or, you can ignore all upstream changes, until your ready for your next pull request.  This is a very flexible process.  I remember, my first few contributions to OS software, I felt like I should hurry up, so that there would be a smaller chance that I have complicated git-stuff to worry about.  Have no fear, it's actually, very, very easy.  More info https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request


Ah ok, entendido.


Yeah, working for me as of last night.  Are you running `ember test ci`?  Did you `npm install phantomjs-polyfill`?  Do not use `ember try` yet, this will fail on < 1.12


I'd use a `case` for every *expected* value, and reserve `default` for handling unexpected input.


Required


Could these 3 blocks of very similar code be re-factored to a function ?


Needs more http://awesomegifs.com/wp-content/uploads/king-of-the-sumo-buttheads-via-moonpolysoft.gif


Use the first sentence to describe what the app *does*, instead of how it works. You can do that in subsequent sentences.


@levicole I'm getting a NameError in Welcome#index on this line. Not sure what I'm missing.

Showing /Users/sfiller/code/blocitoff/app/views/layouts/application.html.erb where line #13 raised:

undefined local variable or method `welcome_index_path' for #<#<Class:0x007f843063f2e8>:0x007f8433d17720>
Extracted source (around line #13):

Suggestions?


These dependencies are useful for testing but should not be part of the commit.


What's the benefit of introducing browserify?


Having said that, http://www.thedailybeast.com/articles/2015/06/09/nobel-prize-winning-biologist-calls-women-love-hungry-cry-babies.html wouldn't lead one to believe that science is doing better than tech...


This will rename the trait, not the property.


Thanks


LGTM


Commit message should be shorter, so it doesn't wrap in the github interface - around 65 characters max.


If you want a longer one use this format:

```
Short commit message.

Longer commit message goes here.
```


@CatDany nothing is "wrong" exactly, but @Vazkii usually puts colors in Hex from what I can tell. Also, IDK what its called, but declaring constants upfront is usually preferred, like https://github.com/Vazkii/Botania/blob/master/src/main/java/vazkii/botania/common/item/ItemManaTablet.java#L35

In my professional noob opinion, it makes more sense to do `private static final Color particleColor = new Color(0x00C6FF);` at the start of the class than to change to RGB representation. It feels more java-style IMO.


sepeartor misspelled. should be period at the end. I would capitalize the I and capitalize it on the previous comment immediately above it as well.


revert this, we shouldnt use single or double lettered variables, ever, always use clear ones so then we dont need documentation / comments along with code :)

"good code is its own documentation" ~ Steve McConnell (some guy... lol)


@Lazersmoke Yeah, I think declaring static-final Color is the best option.


Maybe line 128-here should be in `compileLoad` (then `compileLoad` would also need the `sfxEntryPoints` parameter.


Nitpick: consider `const` here.


感谢您的贡献


See if this actually works in Sphinx; I seem to recall it doesn't. Sometimes I spell it "Plugin instances" to avoid the `s thing.


Does this file need an appropriate license?


Great job on the FormatUtil to output formatted frequency, but I had intended for you to (also, now) write a method to parse GHz, etc. from (the name) String to Long, since you're doing the same thing 3 times.


84691154_AutomateBuildingOfDocs (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1160 of 1160 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


we should also remove placeholder content in sh-ota and add actual links and etc to release versions for debugging purposes, i wanna test this out ;)


:-1: If we're going to change this, we need to work out a good set of test data, to make sure we don't break anything (eg `org.jboss.seam` in documentation.).  The example in https://bugzilla.redhat.com/show_bug.cgi?id=805737#c20 isn't properly punctuated, so we shouldn't over-optimise for it.  I think angle brackets are a more important delimiter to handle.


@DeicPro Ehh since its a dev thing i didnt put to much user-friendly-ness with it, since the only people that will use it are you and maybe me lol :)


Consider adding a line break and a constant for the fields that we care about.


84691154_AutomateBuildingOfDocs (lefticus) - Win64-Windows-7-VisualStudio-12: OK (1674 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


84691154_AutomateBuildingOfDocs (lefticus) - i386-Windows-7-VisualStudio-12: OK (1674 of 1674 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Shouldn't this have type constraints on it?  Otherwise, wouldn't you be able to *create* a `WhileSome` that you can't do anything with (`WhileSome::new("lolwut")`).


pyroute2 has support for veth creation, see the documentation at the top of pyroute2/netns/__init__.py


Nope. Total lost in space moment. Forgot to merge in upstream. Realized upon commit with merge conflicts.


Ew. Put that parenthetical phrase on the next line so that it's a regular paragraph instead of a part of the header.


need a link


Consider keeping the initial request count to be say 300 or so - that you do not have to do multiple requests.


I like storeauth or store_auth in config file.

You can see that all the configuration keys is lowercase.


It would be nice to give better error handling here.


Tudo errado


I'm not super happy with this passing this state around everywhere, maybe package-level unexported globals would make more sense.


for reborn, all the store services have the same password, so here only using auth is ok.


I notice that `lastPingSeq_` is reset to 0 whenever we process a `pong` message, regardless of whether the value of the security cookie matches. To me, this means, that a peer can make us always enter the `if` on line 520 and never get to here.

I suggest resetting `lastPingSeq_` to 0 iff the cookie matches; if a peer refuses to reply with the correct data, we should treat that as no reply at all.


vai se fude


Same above too, we only use one auth.


Copiando tudo da net né. Que vergonha!


np it's hard to read this diffs sometimes


Esse é mito


RedisConnConnectTimeout, RedisConnReadTimeout, RedisConnWriteTimeout may be better ?


There should be a space before the closing quotes on this line.  Otherwise, the message will be `"gregoriotex-font" header is deprecated.Please use \\gresetgregoriofont in TeX instead.`


No problem with `empty +: next`, but you can also just do `next.continue`.  Doesn't hold up the merge.


It seems that we only log this. Where do we drop this query?


I already caught that error and it's just not pushed out because we are debugging a deploy issue with something.


This is a reply to a query - why are we worrying about the SendQ?


Agreed, this is great. Congrats on the OCR performance, and it sounds like your general system architecture (python + C++) is quite solid.

Nice!

Lewis

> On May 26, 2015, at 11:33 AM, Katherine <notifications@github.com> wrote:
>
> Jason, this is awesome :)
>
> Congrats to you and the team!
>
> -Katherine
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/UCSD-AUVSI/Heimdall/commit/9bc3454fb44dba220cb8542009d6142bd3793864#commitcomment-11370627>.
>


Also, if you're going to remove this line, you should probably also remove the comment that precedes it.


Here this needs

```
  - go test -a -v ./...
  - go test -a -tags noasm -v ./...
```


@mezcalero how is the caller supposed to handle this function?


You do know we need this to build inline?
A better way would be to specify CROSS_COMPILE when running make
make ARCH=arm CROSS_COMPILE=/path/to/toolchain


I swear I've seen this pattern before. :)

One suggestion I have would be to change the name of the class and the filename to something like ```Component``` and the file to ```app/component.js```. Since 'subclasses' of this class can mix in both HTML data as well as behavior, it's more than a simple View. I think the name Component represents both the data and behavior side well.

The filename should also not include .html, at least in this module, since there isn't any HTML markup in the file.


90210372-New-chiller-electric-eir-still-delivering-chilled-water-#4453 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1145 of 1145 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I thought the comment went with the section above it.


Any chance you could release a new version of Faker up to PyPI with these fixes?


@whothat I'm trying to pass @blog.id into the @blog_comment.blog_id, can i not do that from new_blog_comment_path( .. )?


ok, got it


Tal y como compruebas la configuración el campo no es opcional, y alguien que no haya añadido ese objeto "accessControlAllow" en su config va a recibir una excepción al pasar por la línea:

```
if(accessControlAllowConfig.enabled){
```

poner algo de este estilo antes de la linea 6 de headerCors.js:

```
if(config.accessControlAllow === undefined) {
return  next();
}
```

otro detalle es que siempre hay que llamar a next o el middleware dejará congelada la llamada hasta que expire por timeout, por lo que en el caso de entrar a la linea 15 de headerCors.js, hay un res.send() pero no un next(false), por lo que estaríamos generando un memory leak. El next(false) para la cadena de middlewares tras su ejecución.


yeah


Wat? Try running that with this patch reverted... HTC added this line, and it overrides the CROSS_COMPILE definition passed through make (see line 196), so passing CROSS_COMPILE=/path/to/toolchain when running make would do nothing.

Also, I use 'make ARCH=arm CROSS_COMPILE=/path/to/toolchain' :P


About these 2 lines above, it seems that the receiver should be `self.contentView`, not `self` because `view` is added to `self.contentView`. Do I misunderstand?


rax retry tests


oops.. this was a mistake from the example I copied


90664130_AlternativeModelPAT (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.5%25-red.svg)


agreed, i made a mistake.


Oh sorry my bad, however we do need this to build inline otherwise CM wouldn't have added it back for Ville :)


Improve me to ur Project pls :)


pics shows eventually go under `{{assets}}`


No worries :)

If you add an ini parameter, can you also have none as an option?


This will indeed give a significant perf boost - from simple network profiling I did.


Need to mention:

- how to launch the app
- users need to login first
- why login is needed


By this, do you mean to run `gg capacity CELLS CAPACITY` after flashing? (And per the [Crowd Supply page](https://www.crowdsupply.com/sutajio-kosagi/novena), those values are `3` and `3000` respectively, right?)

Is there anything else that needs to be run?


CM is not jesus. You don't need this to build inline. Actually, by removing this line, Makefile is now closer to upstream CAF, so this change reverts the Makefile to the correct configuration.


Yeah, this is intended, calling configure with the system python binary


While it is closer to upstream CAF, why would they change it if it wasn't needed?


Also halved Scallop DPS to keep deathball power down, alongside small range buff.

This should encourage floating amphs more.


added css file


Why would CM wreck a device's entire kernel if it weren't needed? Not all of CM's changes can be trusted, especially in the kernel. Also, that change you linked to is 2 years old, and I don't use it in any of my kernels (and I can build inline and out of tree perfectly fine).


I'll remove it


90664130_AlternativeModelPAT (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


oh boy ...


otherwise LGTM.


Ah, yes, sorry. gg capacity is the command you want. The parameters depend entirely on the battery you're using. I don't have the custom novena battery, but if that 3000mAh value is correct then yes, the command you're suggesting is the right one.


@levicole Found other fixes for this issue. See subsequent pushes for the most current code.


LGTM


@normanmaurer - This is what I did in my patch...but leak is fixed either way.


@vinsonchuong hey, what do you think of making the cursor function async? it fixes the long time problem of the data not merging in the expected manner.


First, make some functional requirements
What do you suggest?


@charleshansen @stubbornella if you could also look this over and see if it makes sense to you


LGTM.


maybe don't look at the dist version of cursor, but the source version which isn't transpiled like a crazy person....


This certainly shouldn't have any impact on T :) Merge at your leisure.


I was wondering why the console.log statements I was putting below this weren't registering... this return statement is ending your program prematurely. If you want to return this value, make this into a function.


starting at 1 will give you an assertion error below


Where do you call `dropTableIfExistsCascade` on anything but Postgres?


Yes.
I think I can provide a constructor with this four parameters.


1665-AppPackagingError (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2176 of 2202 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.82%25-yellow.svg)


sure. thanks


See, @retailcoder, you didn't assign it to `null`


You have a point.  I don't know who put that comment in, so it may apply above.  I generally comment above what I'm commenting about, except for an "end of something" comment, so maybe I am misinterpreting it.


This should work then.  That is probably why the hash codes were different.


That would allow a client as many times as they want to forge a ping reply. Why give them more than one chance?


Ack! Nice catch.


A cosmetic change that makes the README rendered on the github website (perhaps of special importance because the project is pandoc).


Thanks! Made fixes.


It would be better to break this commit into smaller, "bite-size" commits with clear commit messages as to what is being fixed in each case. Use a commit message similar to `block: Xyz xyz xyz xyz` for each change.


no need to assign it to `null`, as long as the only constructor that actually assigns it is the constructor taking a `VBProject` argument.

but this whole thing stinks.


Different partitions in linux is not an issue because it only searches upto the root directory `/` ... and partitions in linux will be in `/media or `/mnt` , so the function will go down to `/` and stop there


nah, you're right. `_project` has to be assigned in all constructors.


You give them that chance now. I chose `lastPingSeq` as 123 and send you "PING 123"; you reply "PONG 0" and I reset your `lastPingSeq_`. I chose `lastPingSeq` as 768 and send you "PING 768"; you reply "PONG 0" and I reset your `lastPingSeq_`. I chose `lastPingSeq` as 923 and send you "PING 923"; you reply "PONG 0" and I reset your `lastPingSeq_`.

If the security cookie doesn't match, the PONG should be ignored, which will cause a PTO. Right now, a server can hard-core a PONG reply every 30 seconds and never PTO.


Thanks for the note! This is being fixed in [bug 1166309](https://bugzilla.mozilla.org/show_bug.cgi?id=1166309).


这是一部未来之书的序言，但这部未来之书的存在只是一种可能性，可能在未来会有这么一部书，也可能没有。不管有没有，这部书现在都有了一篇序文。开放社会及其敌人是我一直都喜欢的名字，如同霍乱时期的爱情爱于瘟疫蔓延时之于王小波，不同的是我不会成为信息社会及其敌人的作者，因为按惯例序不能是作者本人来写，否则就称为前言了。即便喜欢这书名，我仍不能从未来的作者那里侵占掉，另外在未来的维度我也未曾有过写作本书的计划。但是我又非常希望在未来会有这么一本书来解决我们现在的诸多疑惑。毕竟还没给我们为开放社会担忧的机会时，信息社会就这么到来了。

信息，在中国自古有之。但自从上古绝天地通起，就一直作为稀缺被巫史士等少数人掌控操纵着着，在口口相传中又夹杂着结绳彩陶龟甲牛骨铜鼎刻石法度权衡竹简木牍丝帛楮皮雕版活字等等传播载体。可任何一个时代都没有像今天这样——信息似乎有点多了。

因为某种原因这段时间我经常在长春市的火车站前行走一大段路以换乘公交。可能和中国的其他城市差不多，火车站前毫无特色，但却能够让人不用怎么思考就很清楚身在中国，甚至不用参考到处都是的汉字。如果问我是如何识别出这是中国的呢，我也不清楚，因为我从未离开过，也就未曾考虑过身在何处的问题。现在的站前和几年前站前又绝对不会一样。围工地用的彩钢板围着的不是火车站而是站前的一块空地，乞丐的位置也都因为工地的存在改变了位置，至于是不是原来的乞丐我记不清楚，他们最近是一个少了一条腿的趴在地上磕头的青年，一个拉二胡坐着卖唱的老人，一个背着书包跪在一行粉笔字后面的女孩，其他的乞丐我路上没有看到，这三位我次次都能遇到，但每次都无法确定和上次遇到的是否是同一个人。同样因为工地的存在改变了原来状态的是车流，行车路线的变更并没有影响之前的堵车与混乱。似乎一切都没有变，可一切又略有不同，在四周风格各异的建筑外墙上不知何时多了几块LED屏幕，循环播放着与之前印刷形态类似的商家广告。其中一块位置显眼的屏幕上还会隔几分钟插播一次泥人张胖丫版的中国梦宣传视频。看到这里不禁想起前一阵微信朋友圈中身在美国的大学同学发的纽约时代广场的照片，其中一块屏幕上赫然是中华人民共和国的宣传片。


s/gree/green


This type stinks. not sure how long it's going to survive as a multi-purpose `struct`.


Isn't it just @blog  no id


I've just merged your PR. Thank you again.


This is not code for software creation, please use it for caution.


And right before this is where @mize would add whitepoint transformation in a later PR, right?


I would taste :dango: :P
PS: arround 4 hours to repair a bug with IO with the server.


why was this reverted?


@mojyt: may be we can discuss further about assign legend's name?


reack


ack


Oh, you're right. The ping out check has to be unconditional. Nice catch.


Your editor seems to make a mess of whitespace.

$ git diff --stat -w f6d6f221ad439ebd62017d29ffc7b73819b885b4 77261fa88371d52281dae80e4011b5f75a4c02b7
 common/main/playsave.h    |  2 ++
 similar/main/kconfig.cpp  | 44 +++++++++++++++++++++++++++++++++++++++++++-
 similar/main/menu.cpp     | 29 ++++++++++++++++++++++++++++-
 similar/main/playsave.cpp | 10 ++++++++++
 4 files changed, 83 insertions(+), 2 deletions(-)
$ git diff --stat f6d6f221ad439ebd62017d29ffc7b73819b885b4 77261fa88371d52281dae80e4011b5f75a4c02b7
 common/main/playsave.h    |   2 ++
 similar/main/kconfig.cpp  | 116 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------
 similar/main/menu.cpp     |  63 +++++++++++++++++++++++++++++++++++++++++++++------------------
 similar/main/playsave.cpp |  40 +++++++++++++++++++++++++---------------
 4 files changed, 151 insertions(+), 70 deletions(-)


I guess it would, but why not use `sessionStorage` for `BrowserHistory` as well? As I said, the drawback I see in using the built in history state is that it can't be changed after a transition, i.e. you couldn't provide an API for setting state in `componentWillUnmount` or `transitionHook` for pop transitions because `replaceState` would override the state of the next page.  I guess that means for use cases like #1188 we'd have to call `replaceState` on `componentDidUpdate`, or use `location.key` and manage it ourselves.

Setting `state` with `<Link>` seems like a good idea. How is this related to #1273 ? I think we should differentiate between persistent state and state that's only used once.


my name is haha


This block duplicates the same logic via copy&paste.  Please refactor it to use a helper function.


No, it's a query. TMGetLedger is always a query.


hmmm does this new commit work? (plugin wise)


These macros duplicate the text of `DXX_INPUT_SENSITIVITY`.  Why not reuse `DXX_INPUT_SENSITIVITY`?


Sorry 'bout that.


From earlier commit:

The conditions will work for both unix and windows.
Unix has a root directory (/) where everything is and Windows has multiple root directories for each partition (c:, d:, etc)

This function will go upto either the root directory or the home directory. So, in both cases if it is run from his OS partition - it will stop at home directory. If it is run from any other partition it will go upto root and stop.


Все нормально :)


Hello I'm E980 Developer.
This commit not build e980
Please revert


This whole file is way too wordy.


> Below is the first step ~~in~~ **to** designing ~~this~~ **our ToDo List API**, with a ~~a~~ few assumptions on what that API should do. ~~It's a Todo List~~


You're not following the styleguides!!!!!!!!!


adf


owner and group do not get put in backticks


I struggle with calling it the ToDo List a service and not an application. In the next paragraph you refer to it as an application...


Thanks for adding support for this...


You need to break this example into much shorter chunks and put the descriptions next to each chunk.


Well, I actually meant that if the competitor resets the timer before the judge writes anything then the judge shouldn't use video evidence to figure out what the result was, just write DNF. But I guess this scenario is just a special case for your change anyway.


tabs are the devil's plaything


Nice catch.


does the test work ?


Ah, will do, thanks!


i think this is buggy? i think want:

```js
// (feel free to rename it, maybe permissionGTE or permissionMatch)
// check that permission a >= b
function permHigher(a, b, cb) {
  if (!isPermission(a) || !isPermission(b)) throw new Error('Permission not valid')

  switch (a) {
  case 'read':
    return cb(null, b === 'read')  // r >= r
  case 'write':
    return cb(null, b === 'read' || b === 'write') // w >= rw
  case 'share':
    return cb(null, true) // s >= rws
  }
}
```


It's clear that you guys didn't review #1632.  Each time you break a guideline you get -5 points. I stopped grading once you reached -1000.  Please redo in light of this and the comments I left above and resubmit by Thursday at 6PM.


Looks good


Avoid variables with short names like $id. Configured minimum length is 3.


Thoughts on ending with a question to spark a conversation?

Is this something we want to have a conversation around (individually or on behalf of Apiary?)


Class ServerStatusChanged does not have a Docblock comment.


Pourquoi avoir changé la présentation du code ?


PHPCS: There must be one blank line after the namespace declaration


Idem ;-) !


Trigger a new queue job to check the url may not the best way. If you have many more project to deploy, when one project's url is checking. The others may be delayed.

I think the best choice is to delay the project' urls not the other project's url checking job.


This misses a number of places JASPIC should have been added:
- files.tomcat.embed.core
- the dist-deployer task
- building the source JAR


:ok:


this must be oil, not 'add oil'


ghdf


gfjgjgckgjdkg


delete lines 3-5


I'm doing it like this, since in case of errors this is the form that unittest will print in, so comparing them then is easier


@bchavez :

  As we are unable to set up Sandbox for Coinbase since there are many exceptions with our piece of code, we are setting up Live Coinbase setup , in this we need some help from you on whether we are going correct way or not. Please check the sample code base without API keys in the following :   https://dotnetfiddle.net/fMqlpx

 And in the above URl, we are using two controllers: Home and Checkout(wrote in Model).
 The sample structure is in the attached screenshot.
![sandbox](https://cloud.githubusercontent.com/assets/2277305/8080044/b5fd972e-0f86-11e5-89db-3a54d5ea299a.png)

And with respect to live coinbase environment, i have below question:
Q1 : Are the 4 Redirect URLs required ? If mentioned all the 4 URLs, how will the flow in the application?
                    CallbackUrl = "http://localhost:50430/Checkout/Confirm",
                    CancelUrl = "http://localhost:50430/Checkout/Cancel",
                    InfoUrl = "http://localhost:50430/Checkout/Info",
                    SuccessUrl = "http://localhost:50430/Checkout/Success",
And if possible share the Sandbox sample in https://dotnetfiddle.net

Thanks


You should not have blank lines separating each sentence like this.  Blank lines indicate new paragraphs, and your sentences need to be grouped into logical paragraphs.


yes, I plan to clean this up a bit for the 0.5.0 release


To address PR https://github.com/polomoshnov/jQuery-UI-Resizable-Snap-extension/pull/7.


Be careful, than I will rename this flag because "step" is incorrect. This value shown in "ticks per second" and step size will be calculated by formula 1000/<this value>. Please rename it as "getTicksNumber" or similar


put these in backticks


ПРАКТИКА.pas

vot eto text


You should have a couple more real-word examples.  Personally, I have `<c-c>` set to comment a line and `<c-C>` set to uncomment the line.


napisal


Aren't `seq?` tests redundant now that all keys are seqs?


redundant?


Ah yeah I get what you are saying, will revert


shouldn't this be you, @sgso ?


Not sure if this field should be required. Machines in cluster may only have names, without domain.


lengthty


Maybe you should talk about how to enable spell check :)


# GoogleLogin


I don't see how this can possibly work


I think it would be better to stop using variadic functions and define valid arities:

```clojure
(defn has-one
  ([ent sub-ent] ...)
  ([ent sub-ent opst] ...))
```

No need to merge and better for users.

Applies also for other relation types.


Oh, because it's an unbound, anonymous function. Good you caught it!


Avoid variables with short names like $id. Configured minimum length is 3.


wot


Class DeploymentStatusChanged does not have a Docblock comment.


Your technical content and your writing are both great.  You could use more examples though to convince me these features are worthwhile.  If you fix the changes I indicated without adding more examples you'll get an 80/100.  You'll need to add more examples to bump the grade up to 100.


Of course in case of many-to-many we need to merge if there are two different maps (lfk & rfk).


test


someone doesn't know how to use make


здесь не обязательно создавать деферед
метод логин и так возвращает промис
https://www.parse.com/docs/js/api/symbols/Parse.User.html#logIn
можно писать
return Parse.User.logIn(...)


This revision is clean.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16053/testReport/) for this commit**


`conn_add_servers` reads servers from a file. This is a totally **A DIFFERENT BEHAVIOUR**! Why use the `server` param instead of a new one??


getEnclosingClass() returns null if the code is obfuscated with proguard without keepattribute EnclosingMethod. Enum.getDeclaringClass() should be safe as it just returns the superclass. The loop itself should be redundant.


Reverted


This commit seems to break leansand if no autorun.lua is provided.


It's because of the 's' at the end. You are checking for "DeathSoundS", which is the trait name.


What exactly does the API class?


все равно странный БЭМ у тебя какой то)))
обычно схема такая
БЛОК_МОДИФИКАТОР_ЗНАЧЕНИЕ
БЛОК__ЭЛЕМЕНТ
БЛОК_МОДИФИКАТОР_ЗНАЧЕНИЕ__ЭЛЕМЕНТ
БЛОК_МОДИФИКАТОР_ЗНАЧЕНИЕ__ЭЛЕМЕНТ_МОДИФИКАТОР_ЗНАЧЕНИЕ


Right, the div is already used in letters-filter component.
So no need to duplicate it. div deleted.


@thockin I guess what @pires is trying to say here, is that this change would (and it does) break the CoreOS deployment. Since it pulls older kube-apiserver binary, the service just dies with "unknown flag: --service-cluster-ip-range".


Do you still need ```serverId``` - looks like you've (tried) to replace it with ```serverUrl```?


i think, there is a error. Can you look?


done. the code is externalized to a local rendering function.


the way you've defined it `rtype` may be `dict` or `Quiver`. `obj` is not the name of a class in Python:

```
>>> obj
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'obj' is not defined
```


@socketpair: `git archive` doesn't handle submodules, else could've done it using `export-ignore` attributes for the directories listed above. The whole point of a tarball is to include submodules, else you can use the tarball downloads from Github directly (which also use `git archive` internally).


@cydh i think there is error.


Tossa voisi kyllä näkyä vuosiluku kuitenkin, mutta tosiaan kellonaika tässä turha


j'avais pas vu cette aprtie là, merci !


Hello JustAkan,

What message does the build system spit out?
I can't imagine this commit renders the complete build process impossible.
Also this isn't the place to revert comments, this should be done in gerrit.
But if you would provide me with the failure message I will take a look at it.

Greetings PsychoGame


My comments are only sandwitched by '@@@'.
The other lines may  be Github's bug.


Et tarvitse tätä luokkaa metatiedoille. Voit käyttää suoraan sitä post-meta-luokkaa


@vhuber please respect code style : member class has a prefix M_. and lines indentation.
Also hasPc is useless. You can write  if (pc) ...  with pc a pointer or boost::shared_ptr


Yeah I wasn't sure if it was already like that cause I don't see how this causes it but just add a `z-index: 1` onto the glyph to keep it on top.


do you need to make these `@staticmethod`? What's the use-case for using them when they're unbound to an instance?


For me it's ok either way, added.


What do you think DO_LAND_START is Spatial(Coord)Item.. inheritor or Command inheriton? Сommand class does not contain Coord3D type field.


Yes, it's working. Thank you! It's updated.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.263](http://teamcity.monogame.net/viewLog.html?buildId=8216&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity YaccConstructor :: YC.Core General Build [Build 442](http://teamcity.codebetter.com/viewLog.html?buildId=192987&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


hostess? http://en.wikipedia.org/wiki/Hostess


this is good


please add some doc strings for these methods. even if they're short, it can be amazingly helpful later on.


Thank you! It's updated.


What about the fastPinSet/reset? do they become pinSetFast?


C'est ma façon de programmer :-)
ça te dérange? Si tu veux on peux le faire comme tu as l'habitudes. Fais
moi tes remarques si non comme ça je fais des modifications :-).

2015-06-10 12:09 GMT+02:00 Julien Peeters <notifications@github.com>:

> Idem ;-) !
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tateba/arduino-led-cube/commit/02a29b1865c7fd47f280074f58996a2c81e5d8de#commitcomment-11607847>
> .
>


Indeed, fixes the waiting thread hangup, added.


How do you configure this coding?????


Looks good.  Flushing periodically and when the buffer is full makes sense, and I like not seeing all that logic in a case statement. :-)


re: digitalWrite(D7, HIGH, FAST); I'd prefer to keep it a separate name in case we have to fallback to macros for some reason. And with "find usages" it's much easier to see where the specific fast methods are used in IDEs.


TeamCity YaccConstructor :: YC.Core General Build [Build 443](http://teamcity.codebetter.com/viewLog.html?buildId=192988&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


Okei, muutan sen


`setState` is a private API (it's not exposed from `createRedux`) and an implementation detail.


Good job me


I already use JSX in example page.
- import: <script src="https://fb.me/JSXTransformer-0.13.3.js"></script>
- <script type="text/javascript"> ==> <script type="text/jsx">
- render React components by their tags instead of using React.createElement


this is the preconditioner given in backend->solve()  ( the arg _prec=)


Следующее это:
3) _accumulate_sufficient_statistics c 7.3%, где 6.6% - выполняется в методе родителя, т.е в base.
4) и logsumexp с 5%.
Кажется существенного прироста мы не добьемся ?!

C другой стороны, некоторые хромосомы анализируются за 1-1,5 минуты.
В новой версии добавил фичу с возможностью анализировать некоторые выборочные хромосомы.


Fix for issue must be fixed to Level 1


clang_defaultEditingTranslationUnitOptions are optimized for editing. How is performance if you change headers? Does this still take 5 seconds? In that case this is a huge improvement


Crap, had :boom: moeten zijn


This is inconsistent, either we leave the user in a 'Press 9' state every time (adding a `combineButton.PerformClick();` at the end of `combineButton_Click` or we always drop they in the 'Combine' state, removing the `combineButton.PerformClick();` here.

The other change is ok, I'll split the commit.


i did use git revert, just via the tortoise gui, for some reason it picked a really old commit as well.


Lisätty vuosi. Laitoin sen muodossa vvvv, sillä se taitaa näyttää
selkeämmältä kuin muoto vv.


Sample comment


Not sure whether start/stop_needle is a generic parameter applicable for every machine/hack type.
Ok for now, but I suggest to still keep the possibility of configuration validation for each plugin itself, also.


TeamCity YaccConstructor :: YC.Core General Build [Build 442](http://teamcity.codebetter.com/viewLog.html?buildId=192987&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: NUnit test failed (23).   at Fake.NUnitSequential.NUnit(FSharpFunc`2 setParams, IEnumerable`1 assemblies)   at FSI_0002.Core.commonConfig@178-12.Invoke(Unit arg10@) in Z:\Builds\work\4138ce7c6332a78c\tools\Build.Tools\Core.fsx:line ... Build time: 00:14:14
### Failed tests
```
AppoximationTests+Approximation tests.Approximation tests. Simple test.: <no details avaliable>

YC.FST.Tests.FstTable+FST tests.FST. Cicles.: <no details avaliable>

YC.FST.Tests.FstTable+FST tests.FST. Multiple final state test.: <no details avaliable>

YC.FST.Tests.FstTable+FST tests.FST. Multiple initial state test.: <no details avaliable>

YC.FST.Tests.FstTable+FST tests.FST. Simple test.: <no details avaliable>

YC.FST.Tests.GraphBasedFst+Graph FST tests.Graph FST. Concat test with multi finit and init 1.: <no details avaliable>

YC.FST.Tests.GraphBasedFst+Graph FST tests.Graph FST. Concat test with multi finit and init.: <no details avaliable>

YC.FST.Tests.GraphBasedFst+Graph FST tests.Graph FST. Concat test.: <no details avaliable>

YC.FST.Tests.GraphBasedFst+Graph FST tests.Graph FST. Simple test.: <no details avaliable>

YC.FST.Tests.GraphBasedFst+Graph FST tests.Graph FST. Test composition FSTs 1.: <no details avaliable>

YC.FST.Tests.GraphBasedFst+Graph FST tests.Graph FST. Test composition FSTs.: <no details avaliable>

##### there are 13 more failed tests, see build details
```


Ah, good catch


ok


Style consistency, could you use this form of if-else? It seems more prevalent:
> if (condition) {
> du_stuff();
> } else {
> du_other_stuff();
> }

[github apparently doesn't like indents in quotes :( ]

Could you also use more parenthesis? ship.cpp:10141  has correct operator order, but using parenthesis helps clarify what is all calculated at a quick glance.


I think the first level needs more time, because usually 60 seconds it isn't enough.
When the pj go near a rock's wall, the head sets under the wall.
Sometimes when you put two bombs near a destructible wall ,and you stay behind this wall, the explosion hits you (and i think it isn't normal.


You don't need this, you can just do
    var StartWeek time.Weekday = time.Monday
And it does the same thing.


This should fix issue #7 yet solve compatibility issues with legacy pywbem


You should just use Time.Before() and Time.After()


A lot of your functions are returning slices of errors, but it looks like they all can really only produce a single error.