```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212154737
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


`git describe --tags` is commonly used for this.  For example, on master, it would produce:

`v0.9.0-168-g9323ede`

Man page describes this as:

> The command finds the most recent tag that is reachable from a commit. If the tag points to the commit, then only the tag is shown. Otherwise, it suffixes the tag name with the number of additional commits on top of the tagged object and the abbreviated object name of the most recent commit.
>
> By default (without --all or --tags) git describe only shows annotated tags. For more information about creating annotated tags see the -a and -s options to git-tag(1).


Just a thought :)


Consider changing the `boot2docker` dependency to `docker-machine`.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212227195
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


正規表現よいですね．


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212355871
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Looks like a lot of duplicated code, especially for the JSON parsing, between the new and old formats. Any way to refactor this?


Use `os.path.join('.docker', 'config.json')`


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212397697
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212411452
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212426598
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


lgtm


I'm deeply concerned by this fix.  There are around 30-40 ways that a certificate can fail verification, and just because it matches a certificate in the local cert file doesn't mean that it doesn't have fatal issues.  The local cert file should *only* be used for otherwise valid self-signed certificates.

This fix introduces significant verification vulnerabilities.


thank you for fixing that. I set now in the main application.properties the static.path to empty and would remove this fix.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435212518491
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Ok, I understand this is needed for people running stable who'd had pinned GDP from testing/unstable.


And shift by 0 or 3 will be more appropriate here ...


Looks strange to me, I would use ```$strStorageMode == ''``` or ```!$strStorageMode``` so the last argument can be ```null``` as well.


Simply download the two files and get going .
Visualise your most import URL's or Files in groups of 9 - You can use a pen and paper to stetch :-)
Right Click to add a url or file
Add your 9 buttons ....then if you need more you can add 9 sets of 9 buttons.
Hence my originally naming my9x9
An image will be found for a SITE
An image for a file is always 9x9 image at present.
You cannot currently move tiles around - this will be coming
Quote behind this tool
The difference, as Forrest Gump so eloquently stated. is this: “Simple is as simple does.”


Most probably pecl_http, has to be fixed using ZVAL_DUP().
See Zend/zend_ast.changes in the same patch.
In near all other cases (in PHP sources) the duplication was useless.

On Wed, Jun 24, 2015 at 8:33 PM, Jan-E <notifications@github.com> wrote:

> @m6w6 <https://github.com/m6w6> This commit broke pecl_http in PHP 7
> Alpha 2
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/php/php-src/commit/8e10e8f921101e0787c8228d257107a204de3e36#commitcomment-11843858>
> .
>


changeItemOrder can also be removed


@sad-spirit: Thanks for the ping, looks good, I'll comment on the PR there in depth.


Should this be @_cache_root ?


Good call


Ha ha, newbie bug - bitwise AND instead of boolean AND ;-)


Complete Chapter 1


ちょっと達成感


change file3.txt


In practice, it's better to use the default textures wherever possible - in this case the correct action is to adjust the size of the flower part in the potted-plant model so that those flowers are the right size - besides, it's impossible to make them too much bigger (otherwise they'd be larger than one node).


For example. It guarantees a smooth upgrade.


changes done


Like so:

    new ProjectXDialog(this);

However, you should also rename this class since it's not actually creating a dialog, it's doing a POST.


[Template](http://73dcab3a.ngrok.io/w/YH5ou_MQeWqfVpYXD476JaLG) How to create a template for projects and tasks


啊手动发大师傅


LGTM @Hony Pls also review
:)


Seems like I couldn't get IsInstance() working, probably because of the way it compares the objects. Our Prop isn't equal to a base-prop after we've added stuff at runtime?

Yeah, one could think OnDamage was called every tick from looking at GPG's type == 'Reclaim' check there but in reality it's never called when something is reclaimed.


Congrats!! Your persistence paid off :)


[Markdown](http://73dcab3a.ngrok.io/w/ZH5ou_MQeWqfVpYXD476JaLG); Try our very own flavored Markdown


Health is unchanged when something is reclaimed, it's the GetFractionComplete() / progress bar that is changed


Good spotting


这个实现直截了当： 它所做的是初始化Toolbar然后设置视图的焦点逻辑。


`for index in 0..< numberOfSegments` would be better


This was fun. She could have been rougher
http://www.pornhub.com/view_video.php?viewkey=87441621


Rougher, a lot of this is really hot
http://www.pornhub.com/view_video.php?viewkey=ph55819a68980b1


Grr, sorry , not add it :/


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435213823935
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Last update error:
http://prntscr.com/7l26ww

The error occurred because the use functions
http://prntscr.com/7l27a5


[GitHub Integration](http://73dcab3a.ngrok.io/w/SPrsc8AATXs8NsgiWZ3unO0p)


Wow, that was *very* quick, you're amazing! Thanks


please add `swift` keyword at the end of the line


Code climate is arguing about this. It looks for it like a noop statement. And for me it looks the same. Do understand how this expect works could you please explain. First we call a function called expect and then we call some properties but it seems no functional call? Is Harry Potter evaluating this?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214026789
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214032994
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


然而，为ViewController写测试代码一直以来都是一个晦涩难懂的话题。

框架来为大家解开这些疑惑。


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214039947
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214049973
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214057355
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214068404
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214078394
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214087502
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1435214099363
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


**Nimble** 框架同时适用于Swift和Objective-C语言.


Can you please put a working demo link. I want to implement the vpaid ads. Please help me.


哈哈哈


I like where this is going so far (and very glad this is only adding the headers so far, and not changing the code to use it, I'm pushing the final stage of a large cleanup that's been in progress shortly, and it'd conflict everywhere ;)).

My primary concern here is whether it wouldn't just be better to generate whole new sets of headers when chipset-specific changes happen, and have them as include/hw/<chipset>/<unit>.h or even include/hw/<unit><chipset>.h (ie. like the rest of the nouveau source files).  The original plan I had for if/when we ever got around to using register headers was to store them as nvkm/subdev/<unit>/regs<chipset>.h, and there's a couple of examples of this already, but I'm just as happy to have them spread into a separate hw/ or hwref/, whatever.

There'd be a largeish amount of duplication by having chipset-specific headers, but I think it'd make it far easier to read and know that what you were looking at applies to whatever gpu you're debugging / writing new code for, not to mention wouldn't require the compat definition before including a file.  I'm not 100% set on this, but what does everyone else think of that idea?  Out of curiosity, what do you guys do in resman?

The only formatting gripe I have is that perhaps the values can be right-justified, while the names are left-justified, which I find somewhat easier on the eyes.


#JqZ7: test


[dddddd](http://73dcab3a.ngrok.io/w/JqZ7Q6LsKAe52BZd8J_WmVg4): test


Thanks. I was just lucky and happened to notice, haha.


各个主流实现都是默认使用deque。原因是vector只增加不缩小， deque时空更平衡一点。如果追求时间效率可选vector，用户自己换就可以。


I had to look these up with my clothes on, time to go to bed and open some snapchats :)


已修改


GetAwaiter doesn't exist on .Net4 Rx, hence this didn't compile.
It seemed to be unused in Rx.Events projects, didn't know/check it was used elsewhere.


このテストコードだと，`1 microposts`を許容するのが仕様になるけれど，それで正しいですか？


@Lollypo 代码上逻辑的翻译不知道有没有错，没有用过这些东西，你可以认真看看哈


LGTM


do not use a define but a basic const int elems_size = ..... , it will be calculated at compiled time.

The alternative is into sims.h you declare a structure

template<class T, int N>
elements_helper{
     static const int size = ........
}

and in your function you do const int size = elements_helper<T,N>::size;  it will be also computed at compile time,
no cost and reusable

Compare to define:
 - it preserves encapsulation


@Awk34, here's my implementation of babel made against `canary`.


fix #JqZ7: ddddd


Why name as check_type_by_key? And it is duplicated by above one.


close [dddddd](http://73dcab3a.ngrok.io/w/JqZ7Q6LsKAe52BZd8J_WmVg4)


close #JqZ7


I've downloaded your source code, but I can't run it properly. the controller don't seems running.
because when I do "pingall" on mininet, all host are unreachable
could you show me how to run your code properly.

thx.


换句话说，Quick是一个用于创建BDD测试的框架。配合Nimbl，可以为你创建更符合预期目标的测试。


I'd try removing only the ghost interaction, that might fix it still, and
not break anything important.
On Jun 25, 2015 12:57 AM, "BlueNexus" <notifications@github.com> wrote:

> I know, but apparently these changes make the powernet work. I can't
> figure out which part is making it work, though
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BlueNexus/NSS-Phoenix/commit/ff8e3ee98470f612aa3b31cfc415a0a3a33d49e3#commitcomment-11849714>
> .
>


为Pony配置Quick和Nimble


ooops


The most beautiful file I know in here!


Quick文件模板（可选）


Shouldn't this be *or*, not *and*?


You mentioned you had issues running the tests in another issue. Do they still fail?


This update implements the exception route. If the validation fails, the response is a 422 Unprocessable Entity, together with the validation message(s). It also shaved away some more code from the basecontroller and handles rules updating based on request method in the validator class.


* 多字符集版本修改

主要是在@兔哥哥基础上 把unicode模式 换了如下接口
1. L"" 换 _T("")
2. strmcp 换 _tcscmp
3. wtoi 换 _ttoi
4. LPCWSTR参数 换 LPCTSTR
5. wcscpy换_tcscpy
6. OLE2T和COLE2T 宏区别
7. 部分WCHAR换TCHAR
8. PUGIXML_WCHAR_MODE
9. 接口参数更换 virtual int __stdcall OnInit(UINT nIDTemplate, HWND hWnd,
LPCTSTR lpszName, CRect rc);
virtual int __stdcall OnTimer(UINT uTimerID, LPCTSTR lpszTimerName);


People can see more clearly!


明确区分出初始化与验证步骤中有哪些需要被测试


I believe you are trying to make a fix only for this line. Could you recreate a clean pull request only have this line modified?


You can actually see it if you focus the checkboxes using the keyboard (TAB). Not sure if it should be possible to focus them, though. We could perhaps add `tabindex="-1"` to the selection column checkboxes.


test


The tab in front of the command is necessary! Should not be removed. It's makefile syntax.


Cybran bots with repair functionality


Write [GitHub Integration](http://73dcab3a.ngrok.io/w/6BOdZCJg952hs594bmIuOMyQ)


明确测试目标，你可以使用Quick框架和Nimble来实现更有意义的测试;


I didn't notice this name, I find there are 4 check_type_by_key, 2 should_see_text_element_with_color, 2 i_press in this file. Whether need to modify all the same names?


;akf;lsfk


Edit [GitHub Integration](http://73dcab3a.ngrok.io/w/6BOdZCJg952hs594bmIuOMyQ) added more description.


@artstorm cool. I just commented on the previous code but your diff swallowed it. Basically there is potential issue with the line
```
$this->data = array_add($this->data, $this->getKey(), $id);
```

In the scenario that the client has created an entity with an id that differs from the id they provided in the route, the `array_add` method will not overwrite the json id that was provided.

The integration test currently fails if the json id is valid and the route id is invalid. Basically if they don't match we should reject it as the client has clearly made a mistake somewhere.


I copied the structure more or less from something like `string EncodeBase64(const unsigned char* pch, size_t len)`. The static definition within the function allows to keep things together without blowing up the memory (which is really not a issue here...).
And right, i need to remove `strResult`. Thanks!


What is the purpose of those #defines? I'd rather use the `TEE_*` macros directly for better readability.


You are not making tasks as expected.
You have already merged feature branch to the master while you should create pull request first and wait for acceptance.
Besides, task 2 is structural script, and you've merged class tests. The branch name `feature` is not very descriptive. Your first branch should be called `feature/structural-script` and it should contain only task 2 code.


I am not happy with this Patch. The System.out.println is not needed. And setting the userCfg as mandantCfg prevents errors when accessing the mandantCfg. But instead of fixing the setting in the DB, the configuration will be happily stored in the wrong configuration.


No typedef please (especially not with mixed case name ;-))


Please send me a working link.


Chrome....


s/Matthew/Matthew Landauer/


Note to self: WTF?


有没有问题，
现在每做一步开始最后加上
步骤X

步骤_1


Inconsistency: `tee_fs_generate_fek` (verb), `tee_fs_meta_encryption` (noun) => `tee_fs_meta_encrypt`, `tee_fs_meta_decrypt`.
Also, adding `const` to input args may help see which ones are input vs. which ones are output.


This gives problems with serializing closures etc. Perhaps better to use `json_encode`?


Oh sorry, didn't see the pull request https://github.com/Mashape/kong/pull/272


fixed with 492f13f


Write [Template](http://73dcab3a.ngrok.io/w/7BOdZCJg952hs594bmIuOMyQ)


Write [Drill Down](http://73dcab3a.ngrok.io/w/8BOdZCJg952hs594bmIuOMyQ)


jaime, funcionan todos los crud ????


It shouldn't be merged. I would like to see pull request.
How can I have a comments now if it is already merged?
And how can you fix it now due to my comments if you already delivered it?

The process is that:
1. create a feature branch
2. make a development on feature branch
3. create pull request
4. make some fixes due to pull request comments
5. merge pull request


```php
function os_migrate_testing_event_export($permission) {
  return !empty($_GET['testing']) ? TRUE : user_access($permission);
}
```


Edit [GitHub Integration](http://73dcab3a.ngrok.io/w/6BOdZCJg952hs594bmIuOMyQ), [Template](http://73dcab3a.ngrok.io/w/7BOdZCJg952hs594bmIuOMyQ) and [Drill Down](http://73dcab3a.ngrok.io/w/8BOdZCJg952hs594bmIuOMyQ) paraphrased a few sentences.


chiper? This should be cipher I guess. Please make the name consistent (if you keep `plain_text` then use `cipher_text` not `cipher`).


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/a7d1593371c97cfc955ec44b7c08a7644b6fac75


merging basho/riak_cs/feature/multibag-with-proxy-get-rebase1 = a7d15933 into borshop-integration-1171-feature/multibag-with-proxy-get-rebase1


basho/riak_cs/feature/multibag-with-proxy-get-rebase1 = a7d15933 merged ok, testing candidate = 605c7808


Does https://github.com/barryvdh/elfinder-builds/commit/f11eb97d55ad16cdb96b6e41c2d9ffc4e697303c fix it?


I'm wasn't sure about this change, I wanted to see whether that would solve the problems the user were reporting.  But I am thinking that if the verification of the certificate using the systems truststore does not succeed for any reason, imapfilter should go back to the previous way of verifying certificates, that is let the user decide if the certificate is valid or not.

In this particular case, I think that the reason that the verification was failing was `X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN`.  Should we assume that this might happen and move on to the local certificates functionality, too?  Can there be more reasons that we should do that?

What if we let the user know the reason that the verification failed, and then we ask if the user wants to continue accepting the certificate anyway?  Although, the user will still get this question everytime, because first we try to verify with the system's truststore...


Issue 18


tasty


deleted readme.md


@arunk-s This won't work as the Web API requests json data from OWTF's database and ``local_timestamp = Column(DateTime)`` and ``Timer.get_current_date_time()`` are ``datetime`` objects that cannot be serialized.

What should be done instead is to use ``local_timestamp = Column(String)`` and ``Timer.get_current_date_time_as_str()``. This should fix your problem because ``String`` can be serialized in json ;)


I'm sorry.
I want to fix only I2C but there are change I want to update.
1. I2C
2. Uart pin name was wrong so I correct it.
3. PWM channel 1 and channel 3 are used for RTC and ticker. So I block user cannot choose them.


fix #MauD: test


Hrm, something weird happened with that patch.  Actually, BUGS and TODO need to go, and the text on lines 105 and 106 needs to be under the DESCRIPTION heading.  Sorry that this go through!  I'll fix up this commit and push the change in a new PR.


Почему не желательна? Она описана в гайде http://guides.rubyonrails.org/active_record_querying.html#dynamic-finders  и кажется более читаемой.


If a commander starts an enhancement the assisters automatically switch into assisting that instead of repair


@xiphiaz Ah, yes, you are right. I just pushed 35555d0 which should fix that.


fix [test](http://73dcab3a.ngrok.io/w/MauDKqBjJvmXMxTaXKrhQpWW): test


I think a format without any tests should fail self test.
May be bleeding-jumbo should even require two tests, at least for salted formats.


Yes, please fix all of them.


Rubocop на нее не ругается


gridspec_kw defines the height ratios of the plots. (see http://matplotlib.org/api/pyplot_api.html?highlight=subplots#matplotlib.pyplot.subplots and http://matplotlib.org/api/gridspec_api.html#matplotlib.gridspec.GridSpec)
Therefore it has no functional but only visual functionality.


Why was this necessary?


So in that case, you should set harvesterSelected.site.useChangeDateForUpdate to a true boolean when parsing the response and before affected it to the model. I don't think you can set the model with the expression above. At least, it was returning a JS error on Chrome and FF.


Close [GitHub Integration](http://73dcab3a.ngrok.io/w/6BOdZCJg952hs594bmIuOMyQ) article finalized


The engine barfed unless the Issue-commands was in a separate thread for a unit that just starts to assist something, the alternative would be to fork around the actual Issue-block but then CheckAssistersFocus() will cause one thread / assister


Did you try the DBCheck tool? This should fix such semantic errors ...


Isn't this a problem? I remember, with TypeScript at Prezi, we had this issue where the order of sources was important. It's bad compiler/language design, but we still had to figure out a way to make one source appear in front of another one.


I fixed the URL issue in https://github.com/zotero/translators/commit/f9ef79cfd9d0a341e386e2acfc3327b8b264b542 Otherwise, there's not much that is different from the previous version in terms of fields. Feel free to point out what you're missing and we'll see what we can do.


Yea I think it would be better that we fail validation in this scenario. Something has gone terribly wrong from the client side that it is trying to clobber an entity with another entity. It would be better to abort than to clobber.


Done. Though I can't see the change here, just the main thread.


good chance to change to `for (Element* elem: _el)`?


done


merge done


We don't have to create task instances here.
It would be better if we will be able to create TaskDefinition objects. [This](https://github.com/tstrachota/foreman_deployments/commit/da9c517940dca6d4b8c0116c397e9d80ebcdf6e3#diff-0da87209dfcf7db25a86c77a43560a47R24) is what you are looking for.


Together with #274


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16822/testReport/) for this commit**


Yes!! Thanks @pmario


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/1255


Are the changes due to re-ordering?

I see you have changed `PCW::DDR::V4.00.A::C_S_AXI_HP0_BASEADDR` which are necessary. Are others necessary changes?


Perhaps:
```
var m = $window.marked || require ? require('marked') : marked;
```


@travs, We also have [another folder](https://github.com/VahidGh/ChannelWorm/tree/master/channelworm/web_app/static/third_party/lte/dist) named `dist` that when we add this name to the .gitignore file, preventing this directory from being pushed. Would you please constraint this dist/ directory with more details.


Yeah, the RoF buff doesn't affect the constant MuzzleChargeDelay which then become a significant delay between shots for a fully buffed arty


Please move this in GettingStarted/Tools @wkyoshe


文言を追加しました。


在分支上做修改
步骤_3
buzhou_3


java nerds, @sheeo come in and teach them a lesson aboutTheseCoolVariableClassNames


注释说


Close [Template](http://73dcab3a.ngrok.io/w/7BOdZCJg952hs594bmIuOMyQ) and [Drill Down](http://73dcab3a.ngrok.io/w/8BOdZCJg952hs594bmIuOMyQ) articles finalized


If the only point of this variable is to memorize whether format must be freed, then `must_free_format` would be clearer.


what about them ?


Provide an exception class and message as arguments to `raise`.<br>Use `fail` instead of `raise` to signal exceptions.


1 trailing blank lines detected.


`end` at 11, 6 is not aligned with `if` at 7, 22


Useless `private` access modifier.


Align `else` with `if`.


Extra empty line detected at class body beginning.


Use 2 (not -14) spaces for indentation.


Space inside parentheses detected.


留下脚印


sorry for late my reply and thank you.


what bug? this commit will actually cause a build error.


Right, HP0 base and also removed GP0 slave port


I would call it `TaskRegistry`, and create a singleton in ForemanDeployments module. This way it will be available to all extensions.


No it`s not Harry and I can't explain how it works.
But I can point you to [Chai](http://chaijs.com/api/bdd/) maybe there is an explanation how it works.
Me, Webstorm and ESlint don't like it either, I will change it to:
`expect(scope.isActive('/plant-shortcut')).to.equal(true);`


What is the purpose of having one REE file per TEE file block? (as opposed to having tee-supplicant manipulate blocks in a single file).


ffhfjgjgj


hardware/boards/xilinx-z702/mn-dual-shmem-gpio/sdk/system.xml is already deleted in https://github.com/zelenkaj/openPOWERLINK_V2/commit/e5087d10cffb2f763f528fa866d393c843017c09.

btw: Is the assignment of C_S_AXI_HP0_BASEADDR in the system.mhs solution to this problem?


OK. Was just a quick fix to get the tests green.


Here is a better idea. How about you work in your free time and I work in mine and whatever we need from other we just post an issue?


Use `size_t`


So, if we update from git we lose our current configuration file?


Thanks


`static` is redundant inside an anonymous namespace.


Done (incl. typo in the log message): https://github.com/cc65/cc65/commit/a840c169a23642a1b8ed7b8aeb89c5dc723a133d

Thanks for the hint.


are sure it will not end up with infinite loop? maybe increase retry count?


`template <typename T>` (everywhere)


Yeah, sure. That would be great. I think since you have already started
working, create a README for me so that I can start working on whatever you
feel I can handle. I am hoping you lead here and I can support :)

Thanks and Regards,

Chinmay.

On Thu, Jun 25, 2015 at 12:49 PM, S Giritheja <notifications@github.com>
wrote:

> Here is a better idea. How about you work in your free time and I work in
> mine and whatever we need from other we just post an issue?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/giritheja/gbunk/commit/f5c3795962cd00be67a971c9268e5d7464820b67#commitcomment-11854660>
> .
>


Open [Template](http://73dcab3a.ngrok.io/w/7BOdZCJg952hs594bmIuOMyQ)


maybe make `500` a constant?


In our case, we want to schedule $rootScope.$applyAsync. It is possible to pass this a specific function to apply, but since we're not doing that we have to schedule the apply itself


`Vector<T, 3>` (everywhere)


import requests
import subprocess
import json
import sys
import threading
import time
from Queue import Queue

numberOfViewers = int(sys.argv[1])
builderThreads = int(sys.argv[2])
startTime = time.time()
numberOfSockets = 0
concurrent = 25
urls = []
urlsUsed = []

def getURL(): # Get tokens
  output = subprocess.Popen(["livestreamer", "twitch.tv/CHANNEL_NAME", "-j"], stdout=subprocess.PIPE).communicate()[0]
	return json.loads(output)['streams']['worst']['url'] # Parse json and return the URL parameter

def build(): # Builds a set of tokens, aka viewers
	global numberOfSockets
	global numberOfViewers
	while True:
		if numberOfSockets < numberOfViewers:
			numberOfSockets += 1
			print "Building viewers " + str(numberOfSockets) + "/" + str(numberOfViewers)
			urls.append(getURL())

def view(): # Opens connections to send views
	global numberOfSockets
	while True:
		url=q.get()
		requests.head(url)
		if (url in urlsUsed):
			urls.remove(url)
			urlsUsed.remove(url)
			numberOfSockets -= 1
		else:
			urlsUsed.append(url)
		q.task_done()

if __name__ == '__main__':
	for i in range(0, builderThreads):
		threading.Thread(target = build).start()

	while True:
		while (numberOfViewers != numberOfSockets): # Wait until sockets are built
			time.sleep(1)

		q=Queue(concurrent*2)
		for i in range(concurrent):
			try:
				t=threading.Thread(target=view)
				t.daemon=True
				t.start()
			except:
				print 'thread error'
		try:
			for url in urls:
				print url
				q.put(url.strip())
				q.join()
		except KeyboardInterrupt:
			sys.exit(1)


`1.0` -> `T(1.0)`

In fact, maybe you can make that function non-generic and simply use double everywhere? As far as I can tell you don't actually need it to be generic, and it would be more readable...


import requests
import subprocess
import json
import sys
import threading
import time
from Queue import Queue

numberOfViewers = int(sys.argv[1])
builderThreads = int(sys.argv[2])
startTime = time.time()
numberOfSockets = 0
concurrent = 25
urls = []
urlsUsed = []

def getURL(): # Get tokens
  output = subprocess.Popen(["livestreamer", "twitch.tv/Franklopezwv2, "-j"], stdout=subprocess.PIPE).communicate()[0]
	return json.loads(output)['streams']['worst']['url'] # Parse json and return the URL parameter

def build(): # Builds a set of tokens, aka viewers
	global numberOfSockets
	global numberOfViewers
	while True:
		if numberOfSockets < numberOfViewers:
			numberOfSockets += 1
			print "Building viewers " + str(numberOfSockets) + "/" + str(numberOfViewers)
			urls.append(getURL())

def view(): # Opens connections to send views
	global numberOfSockets
	while True:
		url=q.get()
		requests.head(url)
		if (url in urlsUsed):
			urls.remove(url)
			urlsUsed.remove(url)
			numberOfSockets -= 1
		else:
			urlsUsed.append(url)
		q.task_done()

if __name__ == '__main__':
	for i in range(0, builderThreads):
		threading.Thread(target = build).start()

	while True:
		while (numberOfViewers != numberOfSockets): # Wait until sockets are built
			time.sleep(1)

		q=Queue(concurrent*2)
		for i in range(concurrent):
			try:
				t=threading.Thread(target=view)
				t.daemon=True
				t.start()
			except:
				print 'thread error'
		try:
			for url in urls:
				print url
				q.put(url.strip())
				q.join()
		except KeyboardInterrupt:
			sys.exit(1)


Thx! I'm not exactly sure why we needed that workaround anyway. But the HP0 base address is correctly forwarded to system.xml.


Hi @thbar,

I don’t have a specific case  for this change currently, but it occurred to me, when going through the examples you provided, that there is a possibility that the pre-processor could do some processing after the source class is initialised.

The first case is in your example where you run a sed command to truncate the source file before the processing of the file begins. However, the source class effectively opens the file before the pre-processing is done. In the case of the CSV file reader, the file is likely only read when the ‘each’ method call is made, but this may not be the case for all data source libraries.

The second case could be where the pre-processor needs to copy (maybe ftp), or rename a file before the source class processes it. While this could be done before calling the Kiba script, it would be neater to have this contained in a single script.

I had thought of adding an additional method (such as ‘open’) to the source class, but I prefer the simplicity of the initialiser setting up the data source and the ‘each’ method handling the data reads.

Alternatively, the opening of the data source could be done in the ‘each’ method before the ‘yield’ loop, but this might confuse users developing scripts using the library.

My thinking is that the ETL script should execute roughly in the manner it is written so that the behaviour is more predictable to script writers.

Cheers,

Bruce

From: Thibaut Barrère [mailto:notifications@github.com]
Sent: 25 June 2015 01:27
To: bcherrington/kiba
Cc: Bruce Cherrington
Subject: Re: [kiba] Re-ordered flow to ensure that pre_processes logic completes before source, transform and destination initialisers are called. Also changed flow to ensure post_processes initilisers are called after all processing is complete. (5f8fe89)

Hey @bcherrington <https://github.com/bcherrington>  - I would love to hear about what made you re-order that way. Maybe is this to generate a file from the pre_process step, because your sources "instantiate" will require it to be there? Just curious and trying to make sure I understand various possible use cases here. Thanks!

—
Reply to this email directly or view it on GitHub <https://github.com/bcherrington/kiba/commit/5f8fe89446f358b91961330ed79e87d227b354a7#commitcomment-11850156> .  <https://github.com/notifications/beacon/AA8qKoFT7bz3KQGj-MxsuoVAScttGJ5Mks5oWzQogaJpZM4FLRVk.gif>


That doesn't seem like a good solution - the class with only one static method.


Yes.


done


fast-forwarding develop to borshop-integration-1171-feature/multibag-with-proxy-get-rebase1 = 605c7808


For now it's ok - but eventually it must change.
Please pass so we will handle it in the nearest future.


no need for this since we always memset the sliceParam


oh yeah..


excellent !


For me the correct solution would be to remove the check if (StringConstants.ONE.equals(user.get(Kontakt.FLD_IS_USER))) {
in getUserSetting(Kontakt)
as it is not relevant wether the refered user IS_USER;


better put "int32_t i"  here


I always use type safe comparison wherever possible. And the last argument is not allowed to be null, because the docblock says you must pass a string :)


I would rather check for all available methods than inheritance. This way I will be sure that the implementation is meaningful. It's the closest thing that we can get to defining a Java-like interface.


コミットメッセージが間違っていた。
s/DR2110/DR2210/


I'm not sure. First they analyze javascript only for now but I'm confident there will be a java analyze in the near future. So we can send them the coverage report to display the coverage but I think we wont use the badge.


Do we really need a configurable option?
Why not just always add /MP for VS2005 or later?


do not use table indent


just fyi `_.find(this.queue[id], { 'id' : objId })`, but you probably already know.


It is OK


Should be fixed in dec0f0ac7c7ce37644cc527560d97093b5b97634


use `class << self` if you want methods below private


@DePierre , Hey, I discussed about this on IRC channel, whether to use `string` or `datetime` as the data type for timestamps. Here is the log of the discussion: http://pastebin.com/eLTqZd1M
As suggested by 7a and others, I decided to use native `datetime` object in the model as it is corresponds to the postgres `datetime` data type.
Should I make another field that corresponds to `local_timestamp_human` of type `String` that can be serialized or there can be another way ?


I think this should be `@default 1000 (seconds)`. Meaning you're expecting inputs to be in seconds.


LGTM


done


why we need change this. Can you compare this to gstreamer vaapi?


do you really want to load file on each call to `Defaults.*`?
you can check for example rspec config maybe you can find some useful ideas
https://github.com/rspec/rspec-core/blob/master/lib/rspec/core.rb#L84


readCount and writeCount are linearly incrementing variables. We should consider a roll over and handle it suitably.


@jamet did you run the appropriate ìnstall_dependencies.sh` after updating?


I think Dropbox is not so good. I'll upload to http://wololo.net/psp2sdk.


Why do you copy the name to ifr_ifindex and not call if_nametoindex directly, as you do in the other commands?


making some changes to commit.


update to git page


Well, we might, no? All we want to do is to drop one reference to each entry, and if someone else has a reference we will in fact not destroy the struct...


Initially: 90 mangoes | 3 bags - 30 mangoes / bag | 30 gates

10 gates - 1 bag down - 30 mangoes given@gates
15 gates - 1 bag down - 30 mangoes given@gates
how much needed for 5 gates left? - 5 mangoes

Answer: 65 mangoes needed - 25 left


Hi @bcherrington,

Thanks for the detailed input and yes, this is what I realized during this
night indeed!

The next release will change the behavior and add tests around that, and I
will most likely also add command line args passing.

Thanks for the feedback, much appreciated!
Le jeu. 25 juin 2015 à 09:24, Bruce Cherrington <notifications@github.com>
a écrit :

> Hi @thbar,
>
>
>
> I don’t have a specific case for this change currently, but it occurred to
> me, when going through the examples you provided, that there is a
> possibility that the pre-processor could do some processing after the
> source class is initialised.
>
>
>
> The first case is in your example where you run a sed command to truncate
> the source file before the processing of the file begins. However, the
> source class effectively opens the file before the pre-processing is done.
> In the case of the CSV file reader, the file is likely only read when the
> ‘each’ method call is made, but this may not be the case for all data
> source libraries.
>
>
>
> The second case could be where the pre-processor needs to copy (maybe
> ftp), or rename a file before the source class processes it. While this
> could be done before calling the Kiba script, it would be neater to have
> this contained in a single script.
>
>
>
> I had thought of adding an additional method (such as ‘open’) to the
> source class, but I prefer the simplicity of the initialiser setting up the
> data source and the ‘each’ method handling the data reads.
>
>
>
> Alternatively, the opening of the data source could be done in the ‘each’
> method before the ‘yield’ loop, but this might confuse users developing
> scripts using the library.
>
>
>
> My thinking is that the ETL script should execute roughly in the manner it
> is written so that the behaviour is more predictable to script writers.
>
>
>
> Cheers,
>
> Bruce
>
>
>
>
>
>
>
> From: Thibaut Barrère [mailto:notifications@github.com]
> Sent: 25 June 2015 01:27
> To: bcherrington/kiba
> Cc: Bruce Cherrington
> Subject: Re: [kiba] Re-ordered flow to ensure that pre_processes logic
> completes before source, transform and destination initialisers are called.
> Also changed flow to ensure post_processes initilisers are called after all
> processing is complete. (5f8fe89)
>
>
>
> Hey @bcherrington <https://github.com/bcherrington> - I would love to
> hear about what made you re-order that way. Maybe is this to generate a
> file from the pre_process step, because your sources "instantiate" will
> require it to be there? Just curious and trying to make sure I understand
> various possible use cases here. Thanks!
>
> —
> Reply to this email directly or view it on GitHub <
> https://github.com/bcherrington/kiba/commit/5f8fe89446f358b91961330ed79e87d227b354a7#commitcomment-11850156>
> . <
> https://github.com/notifications/beacon/AA8qKoFT7bz3KQGj-MxsuoVAScttGJ5Mks5oWzQogaJpZM4FLRVk.gif>
>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bcherrington/kiba/commit/5f8fe89446f358b91961330ed79e87d227b354a7#commitcomment-11854743>
> .
>


If on of these counters reach 0xFFFFFFFF, the next increment rolls over to
0 automatically.

E.g. writeCount = 0x0, readCount = 0xFFFFFFFF
result = writeCount - readCount = 1 // 32 bit unsigned result

I have not seen any issues with the FPGA targets, is it required for OS
platforms in your view? What about 64 bit?

Please let me know what handling you suggest.


this implements a suggestion from https://gist.github.com/sudheesh001/ee26ba3cf8bf07425d54


You mean change it to "assert(s->n_ref != 0)"?


I updated the link with commit bf7b09786585a367edb81797a510170727a34331. It looks nice. ;) Thanks.


Add gravity
9 will become 6 :dancer: :dancers:


This should help in serializing Python `datetime` objects to `JSON` http://blog.codevariety.com/2012/01/06/python-serializing-dates-datetime-datetime-into-json/


The flag arrays were file specific and hence had to be removed.
Base64 encoding scheme increases the cipher size quite largely


minor nit, make the scripts executable.

Hitting a different issue with ssh keys as well, but I think thats my legacy env.


This makes the other flowers ridiculously proportioned compared to the pot's size now...


I believe this to be incorrect. Beanstalkd will enter drain mode after receiving a SIGUSR1.


ok


[test2](http://73dcab3a.ngrok.io/w/VkVcMxAUcLtRx51bKcXiJOUr): Retry!


Ehm, whoops. Guess I want to do a 1.1.2 when I get home today.


updated


good


[test2](http://73dcab3a.ngrok.io/w/VkVcMxAUcLtRx51bKcXiJOUr) Close it! Right now!


e


The number of selected plugins is already counted at line 257. So this number is not correct anymore by these exclusions. (see also https://github.com/splitbrain/dokuwiki/issues/1206 for an example.)


yes


yoxi


close [test2](http://73dcab3a.ngrok.io/w/VkVcMxAUcLtRx51bKcXiJOUr)


Faudra penser à supprimer le fichier help/help.html car remplacé par le fichier help/newsletter.html.
Penser aussi à supprimer main.lang.php car il n'est plus à jour et prend le pas sur le main.po qui, lui, est complet.


Si soc web designer hauras de pujarme el sou


I realize my above sentence wasn't clear. I meant that as soon as at least one of adfULLR[i] != 0, then it is set. All components sets to 0 do not make any sense in practice (that would collapse a raster to a single point extent)


Releasing:
1. Make sure there's no changes ready to be committed (untracked is fine)

    ````bash
    git status
    ````

2. Remove development tag from version number, increment it, merge development into master, and push to github

    ````bash
    sed -i .bak 's/2.0.1-dev/2.1.0/' lib/chatBot.js
    git add lib/chatBot.js
    npm version 2.1.0 -m "Version 2.1.0 for release"
    git diff master development
    git checkout master
    git merge development
    git push
    ````

3. [Release on github](https://github.com/Efreak/node-steam-chat-bot/releases/new)
4. Release a clean version on npm. Downloading a tarball from git is easy if there's files in the working directory. So is cloning the repo to another folder and releasing from there.

    ````bash
    #cd ../steam-chat-bot-clone
    #git pull ../node-steam-chat-bot
    #npm publish 2.1.0 .
    wget https://github.com/Efreak/node-steam-chat-bot/archive/2.1.0.tar.gz
    npm publish 2.1.0.tar.gz
    rm 2.1.0.tar.gz
    ````

5. Switch back to development. and re-add development tag & push

    ````bash
    git checkout development
    sed -i .bak 's/2.1.0/2.1.0-dev/' lib/chatBot.js
    sed -i .back 's/2.1.0/2.1.0-dev/' package.json
    git add lib/chatBot.js package.json
    git commit -m "back to dev"
    git push
    ````


我觉得可以有个awesome-hit-experiment.


nice


Why?


@chriscool Haha, I think too much sometimes, thank you :)
@moy I guess I'll eliminate the whole thing :)


I've understood your fixed code. LGTM, Thanks.


thanks!


Hola, no se si és una línia de codi o un comentari. Meritxell


@12345ieee  maybe the calculate_friction should be protected in order to be used in the implementation of calculate_friction of the child classes


@12345ieee maybe the calculate_friction should be protected in order to be used in the implementation of calculate_friction of the child classes


realize upload progressBar


I wanted it be a little more dynamic - but probably it's not worth it. I will change it to be more optimized. Thanks for the link to rspec :)


The error message does not correspond to the actual condition checked. I agree with @rosen-vladimirov that it is beneficial to allow working in the current directory.


`-x ada` seems to be needed too.  Also, what about `header_flags`?


ahh nice :-) For some reason I thought we had some modification in this one, but maybe that was just temporary. The more extensions we can use directly from the awestruct lib the better.


Sounds good.  I will test it out tomorrow, expecting to merge it later.

On 24 June 2015 at 21:01, John Jones <notifications@github.com> wrote:

> Here is the bulk of the url which triggered the problem.
>
> /NumberField/?natural=x%5E3+%2B+x%5E2+%E2%88%92+3%5Ex+%E2%88%92+1&search=Go
>
> I used a web converter to get x^3 + x^2 − 3^x − 1 for the polynomial. I am
> giving both versions in case the converted one did not past properly.
>
> At first I thought the problem was the 3^x but we handle that ok. The
> problem is the minus signs are not the kind you get from your keyboard.
>
> I just added another line. We replace those unicode dashes with ascii -,
> and then strip any other unicode from the string. So, the function above
> won't be found (it is not a polynomial), but it won't give a crash either.
> If you change 3^x to 3x, then it will find what you want.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jwj61/lmfdb/commit/03130061cd2c732568fa5209ce814534d4970c5f#commitcomment-11846799>
> .
>


this is testing cdmm128 change something


hhh


testing this function


True but in the chain of calls, you'll see that at the end we call the function geohashGetDistanceIfInRadiusWGS84() with inverted arguments compared to their previous positions:

```
-    if (!geohashGetDistanceIfInRadiusWGS84(x,y,latlong[1], latlong[0],
+    /* Note that geohashGetDistanceIfInRadiusWGS84() takes arguments in
+     * reverse order: longitude first, latitude later. */
+    if (!geohashGetDistanceIfInRadiusWGS84(lon,lat,latlong[1], latlong[0],
```


Just use `element.className` rather than checking for the `class` attribute?


Why is this List<DataTypeBasic> ? It should be IEnumerable<DataTypeBasic>


Should them complete as instance-wide ? like [24869] -  [Deprogramming] ICC Weekly Quest


Good job!


it shows my messagses


nice as well. I like that you created `InRelationTo::Extensions`. I think we should change the modified extensions which we need to keep to this namespace as well (after removing extensions which are actually still identical to the awestruct original). It creates a cleaner namespace and makes clear that there are changes from the original (which can be referred to via a comment)


You are right, there is no reason, will change


Sorry for late reply.  Busy couple of days.  How do I initialise them?  I have no clue when it comes to js!  I saw in the documentation it gave me a string to initialise but I don't know where I'm supposed to put it!


Right, thanks, I'd forgotten about that. But we were having issues with the `restserver.php` responses. They only seemed to update randomly, sometimes after ten minutes, but also once only after we tested with the Facebook object debugger. The opengraph api at least seems to update immediately and consistently.

Thanks for letting me know!


What about backwards compatibility? We could also use `true` as an alias to "overwrite"?


Disabling physic on a command pod part is a really bad idea. A mass of 100g would still work but it s not like the AR202 is an empty cardboard box...
You should consider including the MJ module in the probe if you worry.


Btw, I started using class constants for such properties where a specific value is expected.

```php
const MODE_OVERWRITE = 'overwrite';
```


This line and below should be ignored. Wrongly added to commit.


i am sad


Table name is SqlLiteTable ? :)


ich glaub du täuschst dich. Es geht nur um die Debug-Konsole ;-)


@MrKepzie you forgot to update FRAME_KEY_VERSION in the header


I misread this.. looks fine.


in fact, the default value of [option livereload](https://github.com/gruntjs/grunt-contrib-watch#optionslivereload) is false, you can remove the line


should this condition change to some small conditions, like `
if ((flag&setNXFlag > 0) && (o != nil && !o.IsExpired())) { return ErrSetAborted }
if ((flag&setXXFlag > 0) && (o == nil || o.IsExpired())) { return ErrSetAborted }`
or extract check func?


モジュールの説明


Delete the commented lines.


Ok, the fact whether we destroy the object or not is irrelevant. You unlink it from the list, regardless whether it was the last ref or not. So the list is guaranteed to be empty afterwards.


#7 Generate ability to select Different Views.

Use a radio button approach.


@12345ieee why this?

IMHO the update_values method is called only by the get_friction{A,C} methods (and only when really necessary). In fact the fitted values would change only if there have been an event insertion and this is checked using the validFriction variable.


#FQKx #4bkk


[ddddd](http://73dcab3a.ngrok.io/w/FQKxXKmZlv3DpIQHweWZvl_i) [aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd)


I don't think it is necessary, but we can remove `if flag > 0`


Looks good! I havnt tried it, but shouldnt renderFooter be above the if block to allow for footer on the last page?


This is an interesting method. Perhaps we should change the name to be a little bit more meaningful since it isn't really clear as to what it is really doing:

* Returning all configured data types
* And all potential data types based on unused editors
* In groups based on the property editor grouping.

Not sure the best wording but something like:

GetAllDataTypesByEditorGroup ?


A new era begins :)


Hi Jc - I think Nicole's use of the term "Only" had a different meaning because it removed other views where the proposed SetDisplayableInView(s) is kind of ambiguous to me in terms of what happens to the other view node ids...  Maybe it should be

SetDisplayableInView( /*string or vector of ids */, bool)
bool GetDisplayableInView( string )

to be more like a regular Get/Set macro.

-Steve


Actually const REFERRER_TYPE_CAMPAIGN = 6; in current master.


Personal opinion: such big, always present, string on the top of the screen is quiet awful. I like the previous clean interface used before. Note that I've disabled any authentication feature, so no login/logout widgets on top for me. IMHO.


Thanks @leopoul


wow, thank you, very useful.


Shouldn't `target.buildSettings.linkerFiles` first be populated with the reversely filtered source file list?


@shellscape yeah :D that is not pretty but does the job. Still, I think the event listeners route is more customizable (you will have to add [pretty-hrtime](https://www.npmjs.com/package/pretty-hrtime)).

```js
var gulp = require('gulp');
var gutil = require('gulp-util');
var prettyTime = require('pretty-hrtime');

var chalk = gutil.colors;
gulp.removeAllListeners();

// code below adapted from
// -> https://github.com/gulpjs/gulp/blob/master/bin/gulp.js#L173
//

// Total hack due to poor error management in orchestrator
gulp.on('err', function(){ failed = true; });

// TODO: batch these, so when 5 tasks start at once it only logs one time with all 5
gulp.on('task_start', function(e) {
  console.log('Starting \'%s\'...', chalk.cyan(e.task));
});

gulp.on('task_stop', function(e) {
  console.log('Finished \'%s\' after %s',
    chalk.cyan(e.task),
    chalk.magenta(prettyTime(e.hrDuration))
  );
});

gulp.on('task_err', function(e) {
  console.log('\'%s\' %s %s',
    chalk.cyan(e.task)
    chalk.red('errored after'),
    chalk.magenta(prettyTime(e.hrDuration))
  );

  // format error
  if(!e.err){ console.log(e.message); }
  else if(typeof e.err.stack === 'boolean'){ // PluginError
    console.log(e.err.toString());
  } else if(e.err.stack){ // Normal error
    console.log(e.err.stack);
  } else { // Unknown
    console.log( new Error(String(e.err)).stack );
  }
});

gulp.on('task_not_found', function(err) {
  console.log( chalk.red('Task \'' + err.task + '\' is not in your gulpfile') );
  console.log('Please check the documentation for proper gulpfile formatting');
  process.exit(1);
});
```


Looks good to me.


If you don't wish to bundle url parser from mdurl (save browser file size), use `var encode = require('mdurl/encode')`


1: M190 line is too long (62 > 50)


Why not simply go with `Math.abs(scrollParent.fastClickLastScrollTop - scrollParent.scrollTop) > 1`?


@nunoguedelha (probably in your fork the option is still named `GENERATE_MATLAB`.


Hmm why do you think so?


True! I suppose there is a tight coupeling between the styles in the render functions  and the height calculations right now. I'm looking to improve this in v2.


I'd say that is a good practice move this to a private method.


Actually, line 70 isn't the problem in DocMap.pod, since the slash is part of specifying a link to a section.  The problem is with a slash being used as part of a section heading, e.g. `GETTING HELP/SUPPORT` (line 66).  In that case the slash needs to be escaped since it is part of the heading and not a delimiter of the link.  By the way, `podchecker` gives a warning for this issue in DocMap.pod as well:

    ** WARNING: node 'GETTING HELP/SUPPORT' contains non-escaped | or / at line 66 in file DocMap.pod

This is the same warning as I found in lib/SQL/Translator.pm.

To be honest, I agree with you: all of the pod parsers probably parse this correctly.  Nevertheless, I was simply trying to reduce/remove the warnings that `podchecker` generates.  I'm not worried if you don't want to merge the change, it is intended to be helpful, but if it isn't, then I've just had bad luck :-)

BTW: as far as an `xt` test for this goes: do you just want the errors to be reported?  Or should the warnings be flagged as well?


test


Fixed in e238182


I rather use the Option B :stuck_out_tongue_winking_eye:


GitHub can detect that a README file is available, and will display its content on the project's "homepage". The content may be formatted using a specific syntax. By default, Rails uses the [RDoc format](https://github.com/rdoc/rdoc), but you may use a different one (or none: raw text). Many people use [Markdown](https://help.github.com/articles/github-flavored-markdown/), that you already know about for it's used on both GitHub.com and Bloc.io. When you wish to use a specific formatter, you must instruct GitHub which one by appending an extension to the README file: README.rdoc for RDoc, README.md for Markdown, etc. I also think only one README file should be provided (in that commit, you could have deleted the default README.rdoc file).


Why pass the date as 'dt' to write_csv_by_path(dbf_path, csv_path, field_name_selection, form, dt):
rec_dict["YEAR"] = dt.year
rec_dict["QUART"] = (dt.month - 1) // 3
Can one read rec_dict["YEAR"] and rec_dict["QUART"] from file? This is an indeded outcome.


because its always a good idea to move magic numbers/strings to constant especially when you use it in few places


typo - pls fix by using: "$componentName-$version"+'.pom'


upload folder


Không được commit `novalidate`!!! Chỉ dùng để tự test trên máy!!!


-#include "gc.h"
+#include <stdlib.h>


OK. I will fix it. You can pass it just for me to remember :P


     Merhaba Özge benim yarın sınavım var, o yüzden gelemedim, soran olursa
söylersin.
On Jun 19, 2015 3:33 PM, "Ozge Ozavci" <notifications@github.com> wrote:

> kjdfkljdkfl
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Ozgeozavci/sasa/commit/06140da3198b30aefb0f60f6305e7ea6898ed824#commitcomment-11766790>
> .
>


sizeInBytes is unused, isn't it


Please raise this as an issue instead of a comment on the original code. This makes it hard to track.


There are 2 really hard computer science problems - cache invalidation and naming things.
GetGroupedDataTypes ?


I see now. I didn't understood earlier for what exactly pull request is.
I've got one question. So if i make a feature/structural_script with script2.rb and pull request what would you like me to do with tests? Shall I move that commit to new branch feature/script2_tests after merging script2.rb?


I dunno, I thought they looked fine after that fix.  If anything ridiculously out of proportion, it's the actual flower nodes in minetest_game.  I mean, one-meter-tall tulips? :smile:


change way to check platform


Tamamdır söyledim
25 Haz 2015 11:22 tarihinde "MustafaAkgure" <notifications@github.com>
yazdı:

> Merhaba Özge benim yarın sınavım var, o yüzden gelemedim, soran olursa
> söylersin.
> On Jun 19, 2015 3:33 PM, "Ozge Ozavci" <notifications@github.com> wrote:
>
> > kjdfkljdkfl
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/Ozgeozavci/sasa/commit/06140da3198b30aefb0f60f6305e7ea6898ed824#commitcomment-11766790
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Ozgeozavci/sasa/commit/06140da3198b30aefb0f60f6305e7ea6898ed824#commitcomment-11855649>
> .
>


could you move the ```#ifdef HAVE_METALINK``` defined functions to metalink.c.  It can be done as part of a new commit on top of what you already have.


Any flowers except dandelion_white and viola. Whatever... those reductions look bad but it's your business now.


I get this error when building tests:

http.c: In function 'test_find_key_values':
http.c:5032:50: warning: passing argument 3 of 'find_key_values' from incompatible pointer type [-Wincompatible-pointer-types]
                                                  &key, &value); pos++)
                                                  ^
http.c:2610:1: note: expected 'char **' but argument is of type 'const char **'
 find_key_values (const char *start, const char *end, char **key, char **value)
 ^
http.c:5032:56: warning: passing argument 4 of 'find_key_values' from incompatible pointer type [-Wincompatible-pointer-types]
                                                  &key, &value); pos++)
                                                        ^
http.c:2610:1: note: expected 'char **' but argument is of type 'const char **'
 find_key_values (const char *start, const char *end, char **key, char **value)
 ^


Why does this default to 1000? This changes the behaviour between 5.4.7 and 5.5.0, is that intended?


This commit is fine.


Not fail, but warn. I think the current logic silently accepts a lack of tests unless you test the format explicitly.


you can do also this:
```
![Screenshot from twitch.tv](https://raw.github.com/wargio/Twitch-Streamer-Linux/master/Screenshots/Screenshot.png)
```
an example:
https://github.com/wargio/Twitch-Streamer-Linux/blob/master/README.md


Yes, create a new feature branch, for object oriented solution, and then another feature branch for the tests, and move commits there.

After you create first pull request, I will show you how to make feature branches up to date with master.


Ừ a quên commit nên a commit lại bỏ novalidate đi đó :D


I'm against checking-in out-commented code.


I just realised that Android Studio on Windows and Ubuntu are likely different and that's a recipe for bugs; I'll migrate my setup to a Windows version before my next push.


#4bkk: hello


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): hello


I have this in my N6 repo if you want it


good catch, thanks! fixed


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): hello1


#4bkk: hello1


In the current implementation "min" and "max" have the type double


test


Yes, but I don't think it looks so nice for this project because it's a collection of libraries and a CLI application.


@krispark#2 test


I could but there is the issue that in the metalink_from_http I am using both Metalink (for the data structure) and static http.c functions for HTTP header parsing (resp_header_locate). Shall I make the latter non-static?
The helper functions (find_key_value[s], has_key) do not need either of them. So they can be either compiled unconditinally or moved to metalink.c.


@vietj Is the implementation wrong or the documentation? I think that long makes more sense if "min" and "max" count absolute values


Awesome work. :+1: Good job!


Looks great!


well, it's just an image and it will dl from github instead of from wololo.

you can use also a branch for that. so you can keep the image away from the project, like the gh-pages


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16824/testReport/) for this commit**


haha, yup sure. Then i suppose the ID on the DataTypeModel would just be zero if it's not a real data type?


Please change the variable names to something more meaningful, like for example default_log_owner, default_log_*. Thanks.


The update will not overwrite an existing config file.  It will only correct the user in the file that it created 2 lines above this line.


xD


Oh hell. Ignore this entirely, github broke


This causes fluentd to crash in record processing when someone has innocent timestamp field.
Line 171 causes:
2015-06-25 08:33:15 +0000 [warn]: temporarily failed to flush the buffer. next_retry=2015-06-25 08:33:22 +0000 error_class="NoMethodError" error="undefined method `has_key?' for 1435221182.562538:Float" plugin_id="object:3feb02398820"

And as a result all data is lost. Please fix.


Two remarks:
1. Maybe we find a more telling name than "inventory controller"? How is something like this called in a CRM?
2. We should think about a better grouping of the tools, e.g.
  * tools
    * cmd
      * rockin-device-ctrl
      * ...
    * gui
      * rockin-viewer
      * rockin-controller
      * rockin-inventory-controller


:+1: Thanks!


one question ... does this create a setting "tentacles" in the the settings app ?


you left a lying comment ;-)


Weird, it fixed the issue for me.
On Jun 25, 2015 12:16 PM, "vikassangwan1" <notifications@github.com> wrote:

> yes I have used it. Made a clean build. Still not working :(
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arter97/arm-linux-androideabi-5.1/commit/f990446fd64408d1f628d559ba519d4d702ac437#commitcomment-11852550>
> .
>


De settings zou je nog refactoren naar een setup met env variabelen toch? zodat het ook op heroku werkt?


I don't think hosting a binary file with Git is good idea. And gh-pages branch is used for Doxygen, which can change its structure unintentionally.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16825/testReport/) for this commit**


Elke bestandsnaam doet wat je wil, maar de standaard is `.gitkeep`.


Remark for myself ;) : The CFH should probably provide a list of all known items.


I haven't seen this 'in the wild' as I haven't built a recent version - I've only seen @PiterEL's screenshot on another post.

I was thinking previously about how you could add a disc space display, and wondered if it belongs in the About... tab instead. That would allow a table, more like the output of df -h - that would show all mounted filsystems, use, free space, etc.; if you wanted to be really adventurous, you could have architecture/CPU use or similar, although that's all decoration and not really necessary. Knowing *where* your free disc space is, though, is more useful.

Similar "</opinion>" to above.


Try after the js calls. After this https://github.com/Hellowlol/HTPC-Manager/blob/master2/interfaces/default/js/settings.js#L306 or just add it somewhere in default.js


ok, i updated scripts to set it in css instead of plugin


if you use right click, and after left click on another file, the left clicked file will open in viewer and context menu will stay open, this fix close the context menu in this case.


This looks wrong. The type should be `Validation<E, List<A>>` given a semigroup for `E`, no?


Currently, one of the REEF contributors is doing a checkstyle run.
One of the checkstyles is to use only one asterisk for the license header.


I would like to keep the naming consistent; the other tools are all written with dashes.


i am using this style for my personnal site where i integrated your file manager and it seems to be ok, if there something you don't like tell me i will make changes


This case will never occur since you're starting `acc` with a `success`.


I'm not sure if this indentation follows REEF's coding style (Sun Java). I think this line should go on the same line as the one above.
```Java
final Configuration contextConfiguration = ContextConfiguration.CONF
    .set(...)
```


docker-cp has compiled code, which require http server to serve static files, like a nginx or apache. Grunt required only for developer, to view changes without compiling code.
Latest version is always online and available there: http://13w.github.io/docker-cp/


By the way  `$('#splitter .vsplitbar').width() ` returns 6 on FF, 0 on Chrome ....
Same with `$('#splitter .vsplitbar').css('width')`

But, this seems to work correctly :

```javascript
$(window).load(function() {
	$('#fileinfo').css({'left':$('#splitter .vsplitbar').width()+$('#filetree').width()});
        // alert($('#splitter .vsplitbar').width() + ' / ' + $('#splitter .vsplitbar').css('width'));
    });
```

See : http://stackoverflow.com/questions/4022184/jquery-width-chrome-and-safari-problem


MAC.equals metoda nije implementirana. Kako ce ovo raditi?
Mislim da bi trebalo i u MAC klasi implementirati equals.


Maybe 'existing_proxy_port_to_use' is better. This sounds like a boolean.


@jordangriffiths01 I'll try better next time when indenting my commit message lists!  ¯\_(ツ)_/¯


@dankocherga no. It's just a motivator to upgrade my code-sniffer rules.


Are you sure the equals sign goes on this line and not on the one above?
```Java
final Configuration serviceConfiguration =
    OutputService.getServiceConfiguration(outputDir, outputStreamProviderClass);
```


if you open it in new window, it will like to call a pdf with pdf viewer installed (so only a window.open in the code, no need the pdf viewer library), anyway, in the JS viewer you have a full screen option, so if the user want to have a better view he can use it without quiting the filemanager tab. But it is as you want, it doesn't need lot of change to open veiwerJs in new window, tell me about i will do change if needed !


redundant blank lines


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 564](http://build.prxm.it:8811/viewLog.html?buildId=3190&buildTypeId=Jarvis_DocumentStore_CI) is now running


`"Task-" + taskId.getAnd...`


#4bkk: god man...


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): god man...


Use `described_class` instead of `User`


Assignment Branch Condition size for match_or_create_from_github is too high. [18.36/15]<br>Method has too many lines. [14/10]


on peut pas faire ou override_settings qui simulent les microsites ?


got scrapped later anyway :tractor:


quid de tous les autres tests ? ca passe sans ce deco ?


`final`


inconsistent styling across the project. need to standardise.


Nice :+1:
Useful for any renderer for better FF/RW experience.
In my tests I didn't found any flaws using it.


hh


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16828/testReport/) for this commit**


Did you mean "Write timed out..." ?


Вот это всё вообще бы не коммитить по-хорошему. Ну да ладно уже


;o)


Why was this change necessary? Isn't it less secure if assemblies are not signed?


Breaks compilation in master. maint compiles fine. I'm using GHC 7.10:

<pre>
src/full/Agda/Interaction/Response.hs:135:32:
    No instance for (Applicative (TCMT IO))
      arising from a use of ‘liftIO’
    In the expression: liftIO
    In the expression:
      liftIO
      $ do { putStr s;
             hFlush stdout }
    In a case alternative:
        Resp_RunningInfo _ s
          -> liftIO
             $ do { putStr s;
                    hFlush stdout }
Failed to install Agda-2.4.3
</pre>


#4bkkg: on.......


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): on.......


good catch


The commit message is too verbose. You can write details on the pull request message. Keep the commit message as simple as possible (maybe the two asterisk statements will be enough).


Pourquoi tu "t'embêtes" à le faire en pur JS alors que tu load jQuery juste en dessous ?


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): qqq2


#4bkkg: qqq2


Fix issue if you link against a project that isn't aviable in the current configuration.


Why?


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 564](http://build.prxm.it:8811/viewLog.html?buildId=3190&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 240 Build time: 00:08:57


i am talking about "By the way $('#splitter .vsplitbar').width() returns 6 on FF, 0 on Chrome ...."
the splitter is being loaded and chrome didnt fineshed when he get the width so it return 0, this fix should fix chrome trouble but in fact it depend.

i tested your fix and it is a better one, so i just commited it again

(en francais c'est peut etre plus simple a expliquer: au chargement du filemanager, il y a un decalage de 6px en mode liste, ce correctif sert à regler ce problème !)


LGTM


Vahid i think we can change the dis directory of theme.


commit


Maybe also add new tab with this info disk space, cpu and other... but Disk space should be still show on the bottom page.


comment


#4bkkg: oh my god....


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): oh my god....


@Marketionist django 1.7 migrations are missing here


so please leave metalink_from_http in http.c, if other functions are metalink-only and can be moved to metalink.c, then we should do it I think.


conform ?


Les autres tests passent mais ceux-la non. Il faudrait les réécrire pour qu’ils prennent en compte les microsites.


ah they are here NVM


По дефолту - NSIntegerMax -  по мне так лучше дефолт сделать сразу 100.


g


can't we get rid of "wc" by checking for an empty output of "lvm lvs"?


I'm looking into serving multiple experiments on the same server as well.
Do you guys have a pull request that implements the changes you're
considering? If so, if be happy to take a look.

Jay
On Jun 16, 2015 12:03 PM, "Alex Rich" <notifications@github.com> wrote:

> @gureckis <https://github.com/gureckis> @jbmartin
> <https://github.com/jbmartin> I made this change in the hopes that Anselm
> and I would be able to serve experiments from the "burn" server
> simultaneously as long as we use different ports. As far as I can tell,
> this should be possible, and safe since one user's processes can't kill
> another's. However this line was causing psiturk to search for all psiturk
> server processes across all users and treating them as owned by the current
> user, causing an error. I changed the flag so it would only find the
> current user's processes.
>
> This isn't my area of expertise though - do you guys know of any reason we
> need to be messing with server processes of another user, or why two user's
> servers couldn't coexist?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NYUCCL/psiTurk/commit/e4e0964b83635762e297621b5749de9a1b99d9e2#commitcomment-11710003>
> .
>


The main problem has to do with the node-pre-gyp process node-serialport is using. So merging this would result in longer install-times for everybody else. I think the best place to address this would be the node-pre-gyp project (I recall there was already an issue about it, but I didn't have the time to look further).


Skulle kunna använda angular forEach.


Hello World!


Yes, ideally all binaries should be strong-named, but Google's API is currently not strong-named:
https://github.com/google/google-api-dotnet-client/issues/238

I attempted to manually strong-name them, but this messes up some internal visibility dependencies between the assemblies. I will be looking at removing the Google Drive dlls completely, and just using the web API, because there is very little that I need from the provided assemblies, and they are quite large.


Definitivno, zbog neimplementirane metode MAC.equals ni Computer.equals ne radi.

	public static void main(String[] args)
	{
		char[] mac1 = {12, 13, 14, 15};
		char[] mac2 = {12, 13, 14, 15};

		Computer c1 = new Computer("mirza", mac1);
		Computer c2 = new Computer("mirza", mac1);

		System.out.println(c1.equals(c2));
	}

Ovo vraca "false".


Если поставить 100 то будет сразу работать, а это как мне кажется не желательно. Пользователь должен сознательно включить эту фичу


As discussed in the telcon, I suggest to do the check if the images prior to getting the measurements from the DataService. You could use your OSMTileRenderer#imagesExists() method!


A follow-up regarding the name: In my opinion, the tool should later also allow the management of the orders.


well thanks anyway.


А где проверка на NSNotFound?


return NULL;


This is great, I much prefer passing in the variables, it makes it more obvious what is being used.
With the feature approach here I've continued to try and keep only the method names in the scenario (no params).

Hiding away the variables inside the methods which will only lead to it being a pest to maintain.


255 строка, обнови, ты смотришь не последнюю версию


Normal que le main soit dans la class Authentification ? (je ne sais plus comment on fait, mais ça me semble bizarre : il ne vaudrait pas mieux faire une class Escrim qui contiendrait le main ?)


Move this up (avoid fclose (NULL)).


I would like to as you if I can delete all commits from that repo. The main reason is that I've made mistake while making script3 - I put it to this repo, and it should be in other. The description is incorrect. Also, OOP script2.rb and tests are in the same commit.


Indeed, never seen before. Well spotted !


Je pense que tu peux mettre le texte du bouton en français, on code pour des français et pas à l'international.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16829/testReport/) for this commit**


> Oh! I can see you are the author of less. Awesome! I am great fan of less by the way.

Thanks - I'm not the author, unfortunately!, though I have written a large number of the features and bugfixes since 1.3.0


Essaye d'éviter de push du code commenté, ou explique pourquoi il est commenté, pour plus de lisibilité, merciii :3


Sorry, closes https://github.com/DanePubliczneGovPl/ckanext-danepubliczne/issues/201 not ckan's #201


saw approval from shino
at https://github.com/basho/riak_cs/commit/49c952fcc438418cac289880468658e438da8925


merging basho/riak_cs/feature/gc-bucket-status = 49c952fc into borshop-integration-1160-feature/gc-bucket-status


basho/riak_cs/feature/gc-bucket-status = 49c952fc merged ok, testing candidate = 95b73b0f


You added `18` value but wanted `30` I guess


Should have @Usage for each of these


Does this work without a world in the location?


The patch is actually totally wrong - I added it to the dmsquash module, not lvm :-|

Besides that it seems that newer LVM version don't activate thin snapshots by default, thusI'd say we can revert that patch.


OK good but please move LOGIN AS in the right page as i show on the screen in one before commit.


Yes. Is ok! Thanks


Tu n'es pas obligé de postfixer le nom de variable par le nom de la classe : un simple
`private int id`
suffit.


Yes I understand the keyword and your motivation, but the solution does not seam to work everywhere.

I checked the available keywords for my matplotlib:
                   ```subplots(nrows=1, ncols=1, sharex=False, sharey=False, squeeze=True, subplot_kw=None, **fig_kw)```

I'm using ```Version: 1.3.1-1ubuntu5``` and python2.7.6. What do you use?


BC for what? This gateway class is not really made to be extended...


all of the following methods (```loadImage```, ```saveImage``` and ```imageExists```) have to be thread-safe on a track-scope level. It could happen that multiple requests against the same track preview produce race conditions and create invalid files or even throw some RuntimeException. Brute force approach would be to make it static synchronize but that would have the result that only one thread could globally access these methods, creating an unnecessary bottleneck. I will think about this. Maybe you have any ideas?


Yes. As the NPC cannot teleport between worlds - Denizen must assume it is in it's current world?


care to send the revert PR? :-)


Påverkar detta string-objekt globalt? Kanske borde dokumenteras i så fall (eller begränsas till intern kod).


We'll need this file to replicate the exact results as that of BCFWStruct.
This is really handy for regression and sanity.

How about I make this an optional parameter, instead of removing it?


The underscore is the problem.
https://help.github.com/articles/files-that-start-with-an-underscore-are-missing/
e.g. https://myrdd.github.io/media/flag-tiny.png


Excellent, thanks!


Le camel case c'est la première lettre en minuscule, puis les autres en majuscules, soit :
`private String precision;`
au lieu de
`private String Precision;`


focus tag


please make sure that the File path creation is platform independent. You should use ```System.getProperty("path.separator")``` for subdirs.

Also String concatenation this way is expensive. A better way would be to use a ```StringBuilder```. e.g. see http://stackoverflow.com/questions/4648607/stringbuilder-stringbuffer-vs-operator


The methods are protected. If I remember correctly, I already did extend that class for some special file uploading…


warning: nentries is now fixed to 100000
https://github.com/CMSDIJET/DijetRootTreeAnalyzer/commit/4614ccebca23c47aa5a5b59e64de52de75d20a88#diff-0147a1cb1597f765efe988b6cbf0875dL92


Essaye de mettre à la ligne quand il y a trop d'arguments et que la ligne de code devient trop longue ;)


This is the only one I intended you to merge. The rest is just for testing and needs a lot of cleaning up


Нашел. Окей.


Fais une méthode toString qui retourne un aperçu de l'objet sous forme de string, ce sera utile pour le débug ! :D


Try reverting some compiler stuffs on android_build (if you have).
On Jun 25, 2015 6:08 PM, "vikassangwan1" <notifications@github.com> wrote:

> well thanks anyway.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arter97/arm-linux-androideabi-5.1/commit/f990446fd64408d1f628d559ba519d4d702ac437#commitcomment-11856380>
> .
>


Maybe should you add classes to depends of this mod?


Do what you must.
I would do it this way:

First copy your script files somewhere, then:
```bash
git checkout origin/master
git fetch
git reset --hard 1659dbf2de8e1d0ae95641ee49310faa87157426
git push -f origin master
git checkout -b feature/structural-script
```
Then you can paste first script file, and make a pull request.


Là, en rapport avec mon commentaire d'au dessus, tu pourrais afficher l'objet dans la console et bien en voir le contenu :)


Use "FilesCrawled" hook to ensure proper requests order
HEAD test.meta
GET File1_try1_corrupted
GET File1_try3_ok
HEAD File2
GET File2


index


Have you taken a look at ```StatisticsService``` as posted on trello (https://trello.com/c/Yt8M3wub/7-envirocar-server-component; comment from Jun 22 at 9:49 AM)


Test-meister!


Fixed here: https://github.com/netguru/access/commit/2e0a4d8b3213202e7df0b699df896c789e08ef0f


Même remarque que sur le 1454f6593298847fb8eb253210e7dbbcca825ae8 :
Tu n'es pas obligé de postfixer le nom de variable par le nom de la classe : un simple
`private int id`
suffit.


Fixed here: https://github.com/netguru/access/commit/5efd8381b09704501dd86ac38d14274db12627e4


It took me a while to spot the `fetch` at the end of the map. I was busy chasing to see how `true` and `false` were being used in render_breadcrumbs. Would this be simpler?
`if @firm.trading_name?

  {
    name: t('self_service.trading_name_edit.title', firm_name: @firm.registered_name),
    url: edit_self_service_trading_name_path(@firm)
  }

else

  {
   name: t('self_service.firm_edit.title', firm_name: @firm.registered_name),
   url: edit_self_service_firm_path(@firm)
  }

end`


Ici, mets une majuscule à Matériel, et un accent aigu sur le e, sinon à l'affichage ce sera immonde.


Correctly configure site temporary directory and permissions


@mhugent Looks good, but should there not be a /Factory/ annotation?


Liking the helper methods approach!

As the `breadcrumb_` methods are pretty much the public interface should go at the top of the file and be the first thing the dev sees?


:+1: Looks good @stoeffel!


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/1259


For a final version I agree, this is at the moment just for testing, not for release.


@johnbender I'm getting a similar issue (also via grunticon).

node: 0.12.5
npm: 2.11.2

Running on linux 64.

`npm install` fails with `'@filamentgroup/worker-farm' is not in the npm registry.`

[shrinkwrapping](https://docs.npmjs.com/cli/shrinkwrap) back to directory-colorfy@2.0.2 appears to resolve the issue, so it looks like the old dependency works fine.

I haven't been able to reproduce this on OSX - even with the same node & npm versions, and the exact same code. Could be my mistake though; the linux box is on AWS and the OSX one is a laptop I use all the time, so the key difference could well be something other than the OS (cache etc).


названия полей говно, потому что содержат повторяющуюсь часть _group, хотя сама модель называется VkGroup. меняй


Right, the factory annotation is needed. Thanks for the hint.


Resulted in "w" being missed out in decrypted words.


Je pense qu'il vaudrait mieux que tu utilises les setters : si par exemple tu mets en place des mécanismes de vérification dans les setters de ta classe, ça te permettra de vérifier correctement ce qu'on passe en paramètre au constructeur de ta class.
Exemple : si précision ne doit pas excéder 400 caractères, tu vérifies dans le setter que ce qui est envoyé ne dépasse pas ce nombre, et si ça le dépasse, tu throw une erreur. Là, si tu passes direct dans la variable dans le constructeur, la vérif ne sera pas faite et il y a donc la possibilité de mettre une précision à plus de 400 caractères. Tu pourrais faire la vérif à deux endroits, mais ça dupliquerait du code, donc autant utiliser les setters pour factoriser au maximum les endroits où tu vérifies le contenu des champs ;)


> What part of the install step is broken?

I can't install to `$HOME/lmdb` without hacking the Makefile ..


why not just .length?


КАКОГО ХУЯ ДВЕ МИГРАЦИИ НА ОДНУ И ТУЖЕ ТАБЛИЦУ


Est-ce résolu ?


Have you tested on the usual browsers? If so, just merge it in. I have faith ...


Agreed, that was what I first had in mind, but the file with the wrong naming was already checked in. I'll change it together with the new structure you mentioned in another comment


I think we should need to import CoreGraphics and not UIKit, don't you think?


good !


Yes, why not :) :+1:


Est-ce qu'il fonctionne comme ça ?


+1 good one


The order will probably depend on the JVM. I would completely remove the assertion, since we're doing proper checks after deserialization (line 38).


Packers and movers @ http://professionalmovers.in/
http://professionalmovers.in/packers-and-movers-in-bangalore/
http://professionalmovers.in/packers-and-movers-in-chennai/
http://professionalmovers.in/packers-and-movers-in-delhi/
http://professionalmovers.in/packers-and-movers-in-gurgaon/
 http://professionalmovers.in/packers-and-movers-in-hyderabad/
http://professionalmovers.in/packers-and-movers-in-nodia/
 http://professionalmovers.in/packers-and-movers-in-pune/
http://professionalmovers.in/packers-and-movers-in-mumbai/


This option only matters for servers.


CAFeteria ;)


Regarding that point, I will remove some extensions by default in config file (like asp, php, ...)

And regarding the reader (other than pdf), I would rather use CodeMirror than iframe to get thing harmonized. And by the way, it seems there is some conflicts when editing files (try on txt files) .... I would say it is not totally ready yet.

Would you mind to make many PR, so I can accept them individually ?


@tchap So the bottom line is that it's needed because the encoder is bad, right?


@back2dos: I vaguely recall talking about this with you before. I noticed that a private type would be referenced using its full path, e.g. `package.ContainingModule.TypeName` which doesn't make any sense. With this change it is not always converted back to just `TypeName` under the assumption that it can only be accessed from within `ContainingModule` anyway.

Makes sense?


who is root?


Damn that was the fastest comment I have ever seen... stalker??? Just kidding. Yeah CAFinated I should have put.


fixed in latest commit. Thanks!


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): .. so tired...


The problem is, that I can only merge complete branches (not individual commits). Additionally, if there is an open pull request for a specific branch, every push of changes to this branch also updates the pull request.


warning: unused variable ‘oldcount’ [-Wunused-variable]


fast-forwarding develop to borshop-integration-1160-feature/gc-bucket-status = 95b73b0f


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd): oh, again...


Closes #1


Stalker LOL.. iPop xD


spelling error!


Undocumented parameter.


the new method to check duplicates


This is what I didn't now. I thought that the pull request is only for the last commit before the request.


May as well use `except: [:index]` here


This file is missing two end statements


The commit message doesn't really reflect the content of the commit :)


@dachary

i have following output when running erasure-code/test-erasure-code.sh in my emacs:
```
test/erasure-code/test-erasure-code.sh:1168: main:  CEPH_CONF=/dev/null
test/erasure-code/test-erasure-code.sh:1169: main:  unset CEPH_ARGS
test/erasure-code/test-erasure-code.sh:1171: main:  local code
test/erasure-code/test-erasure-code.sh:1172: main:  run testdir/test-erasure-code TEST_rados_put_get_lrc_advanced
test/erasure-code/test-erasure-code.sh:22: run:  local dir=testdir/test-erasure-code
test/erasure-code/test-erasure-code.sh:23: run:  shift
```

and `C-x \`` brings me to the end of erasure-code/test-erasure-code.sh at seeing `test/erasure-code/test-erasure-code.sh:1168`. so, maybe we can have

```sh
PS4='${BASH_SOURCE[0]}:$LINENO: ${FUNCNAME[0]}:  '
```

instead?


It would be possible to name this ass_render_frame2() and make it take a bitmap_type parameter. Good idea or not? (Maybe not, but would allow avoiding duplicating the function call in code which wants to support both.)


#4bkk [2nd test](http://73dcab3a.ngrok.io/w/92nCYbT2BVacn6NATrUaWjMS): again...


[aaa](http://73dcab3a.ngrok.io/w/4bkkg8HrZAOSAV05QPBjDCzd) #92nC: again...


What's this for? It sounds kind of useful for refcounted output.


This is confusing. unit_file_load_follow but don't follow symlinks?


thanks for pointing out. I've got it myself multiple times too but forgot to adress it.


Why are we including brw_fs.h here? Is it needed?


I think these two files could be better named. I can't tell from these two lines which file does what.


@bmsdan I believe you'll also need to set the new refresh token, I'll create a PR for the module that automatically sets this.

```js
spotifyApi.setAccessToken(data.body['access_token']);
spotifyApi.setRefreshToken(data.body['refresh_token']);
```


Method has too many lines. [14/10]


To avoid the ``split_ref`` I ended up adding a small ``/f/`` between the identifier and the filename (which btw, you should precise is a path).


Why? I though that there should be basically an opposite check which would run the following code only in case of /usr/lib/systemd/system


@matiassingers In testing we saw that no new refresh token is returned by the `refreshAccessToken()` method, which is why that isn't included. Let us know how the fix performs for you, though.


One way to do this is `format!("{:?}", fund)`.


`ass_render_rgba_frame` returns a single uncached ASS_Image that must be freed. But yeah, it definitely could be.


> To be honest, I agree with you: all of the pod parsers probably parse this correctly.

Right, my motivation here is "if it can be made to work in all cases with less thought - we will use that". So I am disinclined to silence this particular warning.

As far as the test goes - perhaps have the .t itself ignore this warning itself, and present all others? The rest of the issues flagged were rather valuable.


Все таки, зачем ~~? Реально думаешь, что кто то отправит "2" вместо 2? От всех бед не защитишься все равно.


ok thanks i'll take a look


We don't check returns from alloca


Merci Merci Merci !!!!


thanks, now this function only leaves us 6 lines in the output! i'd say it's a great bargain ! =)


first github


For example:
`1000000 ns - 999999 ns = 1ns` becomes 0ms while it would be `1ms - 0ms = 1ms` in milliseconds.


What does `--fresh` indicate?

Also, the duplication of `SummaryBoxes` here seems odd to me; why not use the cascade (e.g. `.SummaryBoxes .fresh`)?

Also also: why CamelCase? It's harder to read and, if memory serves, behaves inconsistently in DOM implementations (though that may only be the case for super-old IE versions…)?


As we are not using these variables here I would add them in the first commit that needs them, although I understand Edu's rationale to include them here. We are doing something similar in the commit that prepares the nir_emit_alu, create the dst_reg and src_reg, however in that commit we do more things (set the swizzle, the writemask, etc), so include the definitions makes sense for me in that commit than in this one.


Perhaps it would suffice to add a comment clarifying this hack?


What government agents do we want (i.e. FBI, CIA, NSA...) and how many difficulty levels?

e.g. Police > FBI > NSA ?


35行目
>$count = count($array[$prefInitial]);

からの部分、もう少しまとめられるかと


We should probably call ``xfs_admin -U generate`` on the snapshot of the root filesystem before mounting it. See e.g. http://www.miljan.org/main/2009/11/16/lvm-snapshots-and-xfs/ for more details.

TL;DR XFS filesystems have UUIDs that are used in kernel for some mapping and thus two filesystems with the same UUID cannot be mounted at the same time. One of them needs to have the UUID changed (as suggested above) or mounts have to be done with ``-o nouuid``.

This code is not going to hit the issue because the origin is unmounted before the snapshot is mounted, but it could cause troubles later if somebody tries to mount the origin with the snapshot being already mounted (e.g. as root).


It doesn't look like this is a necessary change. I changed it back locally and all the tests still pass. I think I'd be inclined to leave it with an underscore unless there's a good reason to change it to a hyphen.


yes. much better now ;)


It is not needed, we only need "glsl/ir_uniform.h" from there.
I already fixed that.


This looks like a memory leak, see line 1194


How do I add double tap to zoom in there? At the moment, I am able to detect double tap in `MultiPointerGestureDetector`, throw it and receive it in `DefaultZoomableController`. Any clue on how to get further?


Thanks for the link. They use defineProperty and define a getter for the property. This is called "accessor descriptor". With it you can define a function that is called transparently on querying the content of a property. Something like a dynamic property. Its geekie but hides a lot of logic. ;-)


you can also create a method for this, like findNthRow, taking row number as input :)


> This makes sense, but an explanatory comment seems like a good idea.

Yes, I agree. I think the commit message should be copied over to the code as a comment.


The key is built like this `synonyms_of_cp_in_#{ceremony_country}` where ceremony_country = 'new-zealand'. The country was moved from an outcome that `gsub('-', '_')`. I am planning to make it consistent in another PR.

Nothing is failing, because when a key is not found it silently falls back to rendering the key on the page :(


It looks as if there might already be a convention of using hyphens within the country name e.g. https://github.com/alphagov/smart-answers/commit/40997f00bd6eab4cb51d4bf0964da123afaa1964#diff-cc52fc8502475c98c9ca23bc21d2e5a2R1137


メンテナンス性を考えると、もうひとひねり欲しいところ。
47都道府県設定できてるって一目で確認できるかとか


I was only wondering if they can do more with this information. If not then its not possible.


When a DC is created, what is the expected behavior for existing nodes in the cluster. Will the DC try to create daemon pods on existing nodes?


good points..


なるほど。英語っぽいのがいいと思います。`user.has_stamp_by?(current_user) `でもいいですし、押したのはcurrent_userで押されたのはuserなので`user.stamped_by?(current_user)`でもいいのかな、と思いました。


Yes exactly.


@achock all this code was generated by this command:

rails g model Order description:text discount:float profit:float confirmed_date:date completion
_date:date status:string tax:float user:references customer:references


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1155


The new version has removed runtime and makes use of sync mutex's instead.


Since this is an example, it needs to be compilable code. You need to add this to the setUnreadMessagesListener() method call, omit the key name, and probably add an equivalent log call to it.


It's not related to this commit, but the name of this variable is misleading. It could be called e.g. childItemObject.


Yeah but it's the whole case that is getting removed. This information is handled elsewhere in the code.


This would probably be better handled with some kind of ENV_PROTECT flag on the related and new clothing.


[heavywater] New heavywater-ruby created (version: 2.1.5-beta-beta10)

- https://fission.d2o.io/pipeline/job/344315ec-820e-4c06-83cc-000008020000


[heavywater] New heavywater-ruby created (version: 2.1.5-beta-beta10)

- https://fission.d2o.io/pipeline/job/344315ec-820e-4c06-83cc-0000082e0000


`kSignal` is poorly named, it should be named `kStopped`. I'm planning on making this change when I merge more enum types in the future. For now we need to keep this.


better: use the "dual simplex method"


Yes. We deal with IDs (thread, process, core) before, and we deal with stop event/reason after.


Esse trecho pegou bem a vibe geral dessa semana, não o modificarei!


LGTM.


Thought about it, not really sure, I might make the change in the future. Thanks for the suggestion.


"cut" and "cutting plane" are synonymous.
So I think this method should be renamed!


~ % irb
2.1.4 :001 > foo = 5
 => 5
2.1.4 :002 > bar = 6
 => 6
2.1.4 :003 > %w(foo bar)
 => ["foo", "bar"] # not [5, 6]


Yeah, I was just trying to make as simple of a fix as possible. If you think it's better we do it in Processor it is fine too :)


lgtm


T instead of Object


+1 for this usage of node selector


Though you might want to add in your commit message that this fixes CMake 3.0.2.


If you'd be willing to elaborate and maybe open a PR that would be helpful, thanks!


Yeah, without the -v, py.test on display one dot by case. With the -v option, the output is a bit more verbose and shows test names:

https://travis-ci.org/mozilla/mozregression/builds/68076530#L687


@chrisseaton Could you please spot check this for me and make sure I didn't do anything that would hurt performance?


@peti curious - what's the difference between `preCheck` and `preConfigure` btw?

I see that you use `preCheck` and set `doCheck` to `false.


I think this one can't work because new_slack_variable is just 1 object, not a list.
Best to add a doctest for this.


Why not implement this in Node Controller? Node controller already identifies new nodes through cloudprovider interface and adds them to apiserver. The daemon pods could be scheduled there ahead of making the node ready for other pods.


After speaking with @epengr about the Ge 13 Element detector I decided to make the detector as bare as possible since we cannot confirm if it has the same features as the KETEX one.  When this code was originally written for IDEAS the two detectors were mirrors of each other but this appears to be not the case in real life.  Dave Muir and I will sit down sometime and determine what the detector can do and what PV's it has.


# Declarar uma estrutura registro denominada dados_pizza com os seguintes campos: codigo (tipo inteiro),
nome (uma palavra com o máximo de 15 caracteres), raio, diametro (corresponde ao diâmetro da pizza),
peso e preco (corresponde ao preço da pizza).
# Declarar um vetor denominado Pizza do tipo dados_pizza para armazenar os dados de 35 pizzas.
# Preencher o vetor Pizza declarado na questão anterior. O campo diametro deverá ser calculado a partir
do campo raio.
# Exibir os campos codigo, diametro e preco atualizado de cada pizza. Considere que, a atualização do
campo preco será aplicando um desconto de 7,5% sobre o preço original da pizza.


your docstring promises you'll use the prefix; but in fact you use "x"


They are different types but if/when I push more of this functionality (`isRunning`, for example) into the launcher, I can porbably do away with the `instance` field


The 'i' should probably be decreased as well, otherwise the existence of the next item object will not be checked. In general, it would be safer and more efficient to use iterators.


> floating-point values are EqualityComparable despite the fact that the equality function is only well-defined over a restricted domain. For floating-point values 'a' and 'b', a == b is only valid if neither a nor b is a NaN.

For what it's worth, this is a major hurdle for many people to accept.
I can't count the number of times I've heard e.g., "double isn't
totally ordered". Well... that's true if you include NaN in the set of
values, but algorithms like sort() don't work if your input includes
NaN.

Another good example is accumulate() called over a range of ints. If
the accumulator overflows, you have undefined behavior, yet int is
still a model of additive monoid.

> You can require Assignable<T, U>() despite the fact that t = u is not valid for all possible values t of type T and u of type U. It is the user's responsibility to ensure that the actual values used fall within a domain in which the requirements of Assignable are satisfied.

I'm worried if we ever allow types to define a state where assignment
to an object is not valid. I know that such examples are possible to
construct, but those cannot seriously be examples of usable code.

> I'm trying to do something similar by incorporating the "stable object" requirements into Destructible et al. Your "timer counting down" doesn't have a stable value, so it can't be considered Destructible in general. However, in a context where Destructible is the only requirement:

These notions of "stable object" and "value" are where specifications
start getting into trouble because you have to start characterizing
what those terms mean. And that's not easy (what is the "value" of a
function?).

IMO, trying to explicitly characterize the extent of side effects is a dead end.

I think the only property that should matter is whether the
modification of one object remotely affects another distinct object in
a way that would break the substitutability of equal inputs to a
regular function or the postconditions of an algorithm.

I don't know how to phrase this formally in those terms because I'm
not thinking too hard about it right now :)

Andrew


Sorry if I missed this, but does DC status reflect whether all the spawned daemon pods are in Running state?


It looks like this line is erroneous:

```java
String streamId = "558c692ea2f80b0b00a2e769";
ApiInvoker apiInvoker = new ApiInvoker();
String path = "/stream/{stream_id}".replaceAll("\\{format\\}","json").replaceAll("\\{" + "streamId" + "\\}", apiInvoker.escapeString(streamId.toString()));
Log.d(TAG, streamId);
Log.d(TAG, path);
```
Leads to:
```
558c692ea2f80b0b00a2e769
/stream/{stream_id}
```


That's a small oversight, ill look at fixing it tomorrow if vaz doesn't pick it up before I come home from work.

Thanks for pointing it out.


This relies on a compiler extension (if `__VA_ARGS__` is empty, don't emit the trailing comma to `DS2LOG`). Have you verified it works with MSVC?


Located in /etc/init.d/mpd