Why the negation? We try to avoid negation in options.


Good good


Try to be consistent. You called this `ingest_endpoint_url` in the other example. Same comment about `url` in the help message.


We had this line here for when we were testing things.  I'm fine if you want to leave it but just wanted to bring your attention to it.


I have done that, and just to be sure, I just did it again to confirm. What are these green boxes you speak of?


OK, good.


I believe this pattern was changed


You should add some form of visual/logging feedback that something is going on.


why are you using a read lock here?


Awesome!  Thanks for cleaning up my incomplete push. ;)


Also good.


Good catch! How about if we check the return value for NULL in get_alloted, if so set count to 0 and break the while loop. It will then cleanup and exit with code 1 from main(). The advantages are that it is simple and doesn't require any repetition of cleanup code, the disadvantages are that it is perhaps a little unclear and it will exit with the message "Quota reached"...


in reply...

1) I didn't know that change would cause this issue, I was surprised to
see the exit and didn't feel it correct, I can (and will) change it
back.

2) I was thinking about that too, I was toying with removing the
dropdown on attach (you can only select spreadsheet now) and all other
docs references, leaving it with just spreadsheet.

3) I have only seen "services" refer to services that are offered by the
drupal instance (not services consumed by the instance) I think
admin/config/content/webform/* is a good idea

On 2015-06-11 11:00, Charlie Schliesser wrote:

> Hey @toftat [1], awesome changes, a couple of questions.
>
> 1) In includes/oauth2callback.inc I do not think that we want to return '' as that would cause Drupal to render a full page, which will take a little extra time as well as potentially confuse the user. The goal of that oauth2 calback is to update the parent window as quickly as possible. What do you think?
>
> 2) In the .info file, I think we should remove the reference to "Docs" and just have "Spreadsheets".
>
> 3) Instead of the admin path lying at admin/config/content/do you think a better place might be either admin/config/content/webform/* as a local task (tab) or at admin/config/services/* since we're connecting Drupal with a 3rd party web service?
>
> Thanks for working on this! I really appreciate the revisions to install / uninstall, the requirements check, etc.
>
> --
> Reply to this email directly or view it on GitHub [2].

Links:
------
[1] https://github.com/toftat
[2]
https://github.com/csdco/webform_to_gdocs/commit/eb5dc5a39e61fbdd45fd17b0f141157a368afc3f#commitcomment-11635748


If this is the behaviour we prefer I think it should, at least, be noted in the readme.


@lynnetye This should be named using BEM conventions... something like `.news-feed__poster-avatar`


If removing this, update the DocBlock that references it.

I'm assuming something else about the code changed that the queueing is no longer needed?


It would be a better demo if the version kept increasing. You can use `i` for that.

* Change `if i >= 10:` to `if i % 10 == 0:`
* Don't reset `i` to 0
* Make `version` be `'{date}-{version}'.format(date=time.strftime('%Y-%m-%d'), version=i)`


nvm, figured it out


Preserve the newline at end of file (no empty line, but make sure the last line ends with a `\n`)


New line at end of file


OK it's updated.


Preserve new line at end of file


I see. Can we resolve it by using submodules? The problem is that neither Encode/Decode nor Serialize/Deserialize properly reflect what is happening here - we not only transform the message from one format to another, but also send it to the far end, and these names do not imply any transmission. We could use Send/Receive, though this seems to be a rather artificial workaround - all similar actions in the Protocol are called write and read, and you can see how inconsistent encode looks on line 244.


Broke all over the place, but I figured it out and changed the necessary things.


:+1: good eye!

Fixed in d008a0f.


rax retry tests


@lynnetye This shouldn't be nested inside of anything. One of the main benefits of the BEM naming convention is that your classes will almost always have unique names, so you don't need to nest them inside of other CSS blocks to avoid collisions. So instead of this:

```
.news-feed__post {
  ...

  .news-feed__post-container {
    ...
  }
}
```

You should have this:

```
.news-feed__post {
  ...
}

.news-feed__post-container {
  ...
}
```


Those warnings were there because without them, those inner class throw new deprecation warnings that don't really tell us anything-- it's a similar situation as to the one you spotted in `test_rdfcat`.


Because you dont need a write lock.

We have a read lock that will prevent anyone trying to modify the state of the current items variable. Therefore, during the construction of the new LinkedList<T> we wont need a write lock. In the usual case we would upgrade, but in this case the set is "atomic" in the sense that readers dont care to get an old pointer (no harm done, in fact it is better in this case), and writers are prevented to see the old pointer completely.


Done in d008a0f. Shell output now spans multiple lines :-(

```

Compiling all tests together: In file included from everything.cc:38:0:
.././Bricks/time/test.cc:51:2: warning: #warning "===================================================================" [-Wcpp]
 #warning "==================================================================="
  ^
.././Bricks/time/test.cc:52:2: warning: #warning "Ignore this warning if a full batch test is being run!" [-Wcpp]
 #warning "Ignore this warning if a full batch test is being run!"
  ^
.././Bricks/time/test.cc:53:2: warning: #warning "A flaky test comparing against wall time is disabled for batch run." [-Wcpp]
 #warning "A flaky test comparing against wall time is disabled for batch run."
  ^
.././Bricks/time/test.cc:54:2: warning: #warning "===================================================================" [-Wcpp]
 #warning "==================================================================="
  ^
OK.
```


@lynnetye Your BEM class names should have two underscores between the block and the element, not one... `side-bar__profile` not `side-bar_profile``


It's a very old and very obsolete note (about moving from `KnowSheet/Bricks` into `KnowSheet/KnowSheet` or something).

Removed in d008a0f. :+1:


oh, aha! A bit confusing that the sort happens so far away from the code this code depending on it.


@valzav Yeah, I'm not sold on that one either. Dan decided it was important that registrars be lifetime members.


I know ;-)


1) Yeah it is odd, but I don't know of a faster way to do it (correct me if I'm wrong!). If you `return` from a menu callback, Drupal will call `drupal_deliver_html_page()`. You can define your own page delivery callback via a hook, and then define that you want that delivery callback to be used in `hook_menu()`, but that's a lot of code for no gain. You can call `drupal_exit()` if you'd like: https://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_exit/7

2) I say go with just spreadsheet. I had (years ago) thought about including docs but it just never made sense to do it.

3) Cool – the webform tab would be awesome and allow people to find it by stumbling through the webform config.


But the only operation that is allowed here is ClearHalf (everything else would be blocked because they need a write).
Also, Clear() need to also have a lock, otherwise you might see strange behavior (a write tha twas missed because of a concurrent clear that didnt' propogate).

So in effect, there is a lock here and can only be held by a single thread.


@lynnetye `$font` is not a descriptive variable name. It should be `$font-family`. Additionally, you should use BEM naming conventions for your variable names. Since this is the font you want to use globally, I'd call it something like `$global--font-family` or `$app--font-family`. If you had a font family you only wanted to use for news feed post comments, you might call it `$news-feed__post-comment--font-family`.


This breaks switching tabs! I have uninstalled this package because of this!


I'll get this released soon, probably within the next 24 hours.


Excellent (not the breaking, the fixing!) :+1:


I'm guessing this was generated from https://github.com/signalfx/signalfx-java. The fact that it's not in its own repo is a bit unfortunate, but we can fix that later. For now, we need to be super transparent about where this comes from and how it was generated, especially since you're committing generated code, which is not great. I would put it in its own subpackage, with a specific README file that explains where this comes from and how it was generated, and how it can be re-generated with `protoc` if needed.


You are fire! for not indent your code... have a nice day


Working on the other fix now!


Yeah the reason for doing this is that it's causing huge performance issues in some apps, causing queries not to use covered indexes and it's out of control to the user. It's better for us to not assume the _id sort and make the user do it explicitly to avoid this situation.


I think that should be kickstart, not kickstart-highlight, does highlighting goes off when you change the filetype option ?


Looks like all of that should be private. Since there is no way to make module-level global variables private, these should probably be private constants defined in the `__BaseSignalFx` class


Problem here :)


Those last 3 also look like private constants


Should probably just axe this.


Don't change the name


You can call .FirstOrDefault() (the most common case) that only needs a read lock. An oversight on the push may introduce a race condition on .Clear() ... Will PR it in a minute.


"Advanced Options" can actually be removed entirely, they should not be a part of the TR55 model package.


there is a lot of `%\<` where the `\<` seems redundant as a word start marker, not a big deal, but might makes regexs easier to read.


even more concise, nice ^^


PS: I now have our application passing all tests on f56b96b75eef6d71102c1ef89f3600d35d277e69 which is pretty close to latest?


@lynnetye You didn't break down the HTML for this page correctly imo. The side bar, the header bar, and the news feed should not all share the same parent element.


The fix for the problem with cfg80211_connect_result() has been pushed.


TRALALALA LALA LA. I have no idea why I thought it wasn't needed...
I guess I was to focused on making sure we picked up new servers that I didn't want to remove them ever!


Working now. I had to change the reference in the `answers` migration file. Then the schema changed automatically when starting `rake db:migrate` again.


Are you sure? ASMHelper.findMethod is using the deobf mappings, at least I've been told so.


This string formatting syntax is heading for deprecation in Python. Use the `{0}/{1}` syntax instead.


About using joins or not, something is not clear for me. JOINs are one way to link tables, and a WHERE clause is another way. Not linking tables at all would seem silly to me, in a multi-table QBE (maybe there are use cases but rarely IMO). So when choosing to avoid JOINs, I was expecting that a WHERE clause linking the tables would be generated. If it's not the case, maybe this option should be rephrased.


Not really necessary, our entire REST API is JSON-based.


@maddox, isn't it repo:status?

Although, it just occured to me that I haven't tested the pull request links for private repositories (public PRs work fine).


Note that FirstOrDefault is only called for profiling, and that is hardly a
common case for performance issues.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Thu, Jun 11, 2015 at 9:01 PM, Federico Andres Lois <
notifications@github.com> wrote:

> You can call .FirstOrDefault() (the most common case) that only needs a
> read lock. An oversight on the push may introduce a race condition on
> .Clear() ... Will PR it in a minute.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Corvalius/ravendb/commit/2c777a7977f1e9a67d30dc2ed6a5d69c527d876e#commitcomment-11639623>
> .
>


BTW, just learned that `#warning` is not portable :(
http://stackoverflow.com/questions/171435/portability-of-warning-preprocessor-directive
https://msdn.microsoft.com/en-us/library/3sxhs2ty.aspx
https://msdn.microsoft.com/en-us/library/2c8f766e.aspx


"ProtocolBuffers" is the actual name. Let's keep our documentation standards as high as possible.


@lynnetye Is there a reason this is the only partial without an underscore? Underscores are totally optional, but if you use them you should be consistent and use them with all of your partials. In general, you always want all of your code to be consistent unless you have some very clear reason for breaking from that.


DERP thanks!

`repo:status` works for public and private.


@jklontz  - Let me know about changes like this.  This buffer is expected in OpenCV's vec format for interoperability and in the readBlock function of our own implementation.  Fixed in a83fa29.


Holy sheet!

Guess I could `#ifdef` away this whole test altogether then. Does it look good?


Don't do this. Libraries should never enforce how they log, and certainly not at what level they log.


Proposed solution: http://stackoverflow.com/a/1911632


Nope. This was intentionally. The :js flag is not needed, because the code does not need JavaScript to run. As a bonus feature you will get proper Capybara errors (I.e. infinite redirects). With browser based specs you only get empty results. That's very hard to debug.


I'll go look in my Eclipse settings though I thought I had the defaults in this area. Paradoxically, I get the opposite effect - the unnecessary (to my settings) @SuppressWarnings on the inner classes causes warnings.


Plus they are much faster ;)


Meh, too complex.


It all works now with this patch, I can display devices and turn them on and off. What we really need is to make the watch app much simpler. I would remove the accessory info and just leave the switch on the list view. That could save us a few clicks


fixed. Made it SignalFx


This was here for a reason


Yeah, it works for fetching the build/test status, but I'm not sure if it works for getting info about pull requests?


You're not sending a single datapoint here


It's so good that Java is so deterministic. I really don't know-- maybe it's better to not have them. Maybe we should take a vote amongst all the IDEs! {grin}


Technically, isn't any code that begins with a `2` a "success" code?


I think that it would be better to with a standard lock, instead of rw lock. Can you test perf with that?


@mikegapinski feel free to modify that and send pull request :)


@wabain is this correct? I understand that the `event.preventDefault()` method is to ensure that Backbone manages the navigation, not the default brower behaviour.


yes, leftover from my debug where i was using lab url.

Fixed.


I'll see what I can do :)


This string formatting syntax is heading for deprecation. Also, `sys.version_info` is better suited for what you want here:

```python
return '{name}/{version}'.format(name=PYTHON_NAME, version=sys.version_info.major)
```


Mhhh now I see how it is used :)

If that its try a simple lock would be far better, I never considered that the cache was actually externalized.


But I also don't like the idea of disabling the whole test for MSVC :(


ohhhhhh :/

I really hate to suggest giving that kind of access to an accessible token though.


I would make this return the API token so you can write:
```python
self._api_token = self._check_api_token(api_token)
```
In the constructor, a little like `Preconditions.checkNotNull(ref)` in Guava returns the ref itself.


LOL same comment in the other PR.


`if not api_token` will work just as well and also check if the token is empty.


It will still be enabled on its own. Just disabled under `full-test.sh`.


Why do we need a distinction between `.set()` and `.updateIn()`?


Prefer single quotes (consistency). Also, it's not really about "entering" a token here, but specifying, or passing. Remember this will be used in code more than just through a command-line tool.


done


If Aizoban is deprecated, is there a newer version hosted somewhere else?


You don't seem to be using this


yhidhfidfigifdhgidfggf


Yeah, we should probably fix that.


How do you allow the table of contents to expand and collapse?  I have related layers grouped, but when it's brought into the viewer it only shows the top group name and not the sub layers.


Thanks! BitHub has sent payment of  $8.61USD for this commit.


Thanks! BitHub has sent payment of  $8.43USD for this commit.


This commit is missing and make build fail.
https://github.com/CyanogenMod/android_frameworks_base/commit/8b35a49276d2be5de6446abd1aa957c78ba9c3d8

When you can update repositories. Thanks!


@CecilioM  an update to add this functionality is coming in the next release. Look for an update to this repo in early July that has this capability.


I


Updating


Strange, I use visual studio 2010.

Could you please fix it?

From: Alexander Danilov [mailto:notifications@github.com]
Sent: Thursday, June 11, 2015 2:14 AM
To: INMOST-DEV/INMOST
Cc: Kirill Terekhov
Subject: Re: [INMOST] Updates and bugfixes (95a568f)

std::string::back() was introduced in C++11 standard.
We should avoid pulling C++11 requirements for single use of std::string::back().

—
Reply to this email directly or view it on GitHub <https://github.com/INMOST-DEV/INMOST/commit/95a568f0ecbb16e4c6693cf372b917ff2a61a442#commitcomment-11629670> .


Thanks!

From: Kelly Hutchins [mailto:notifications@github.com]
Sent: Thursday, June 11, 2015 1:17 PM
To: Esri/map-tools-template
Cc: Cecilio Martinez
Subject: Re: [map-tools-template] Update main.js (aee126f)

@CecilioM<https://github.com/CecilioM> an update to add this functionality is coming in the next release. Look for an update to this repo in early July that has this capability.

—
Reply to this email directly or view it on GitHub<https://github.com/Esri/map-tools-template/commit/aee126f39d0bc8c3002fa55126c1aada6afa807a#commitcomment-11639911>.


+ foo
+ foo


@arschmitz looks mergable


This whole function looks a lot more complex than it needs to be. Just set your user agent header and be done with it:
```python
session.headers['User-Agent'] = '{0}/{1} (Python {2})'.format(
    version.name, version.version, '.'.join(sys.version_info[:3]))
```

Which also means you don't need the `_get_python_version` method.


Added capability to set logging level. Will use 'DEBUG' as default in the example also.


Could you please do a pull request on Z3 with this patch ?


Very sorry! I meant to just delete the unused variable `write5` not the whole line.


good idea. will do similar for metrics as well.


https://xkcd.com/859 :(


No worries :smile:.


Just name it `session`, doesn't collide with anything


Nice. Thanks @case!


I prefer using README.md with github markdown, but this is good for now.  See https://help.github.com/articles/github-flavored-markdown/


I try to test it when this machine decides to not lag behind like a half-asleep tortoise.


Don't loose the doc


Two things:
1. use the new and better way of closures - still using cj because 4.4 needs it.
2. include the js code as a file instead of inline (a little more complicated since it was being pulled in conditionally via an ajax load).


This is not a correct algorithm. If you never reach batch size, nothing gets sent and your datapoints end up delayed and/or with inaccurate timestamps. See `signalfx-java` for a better implementation.


Make a new branch without dispatcher.


I just tried it, and:

1. The package actually works for me, lol.
2. It looks like it links and redirects to the actual status url for my CI. So...something happened?


Pourquoi pas laisser en Ticker ? Plus rien ne va respecter la notion de pas, du coup.


Why is this not done by the parent constructor?


Don't loose this


Name your thread


`self._batch_size = max(1, batch_size)`


Yeah, it creates a link to `target_url` on the build status, but it should also create another link to a pull request, if there is one on the current branch.

I just tested this too, and the build status works fine, but the pull request link isn't created (on a private repo).


You need to give people a way to gracefully stop the thread


Nice catch on my mistake !


So, security-wise, it works as expected. It's just missing the PR link if the repository is private.

This would require an additional permission on the token, but I'm not sure which one.


also removed SlothWalls source from build.
add SlothWalls apk to product copy files


looks good


Since you're never `join()`-ing on the queue, this is not necessary.


saveCommonChunk hasn't been implemented yet, which is a prototype.


use char base[XEN_BUFSIZE]; to be consistent


With this change, gcc now links with `isl` and `cloog` dynamically instead of statically, which was probably unintended. It also breaks ARM, since linking a statically linked `gmp` into dynamically linked `isl` doesn't work:

````
/nix/store/jipqp9739n7wrjz40igbk85pqk13s0ad-binutils-2.23.1/bin/ld: /nix/store/92pdpqrqkdf8wjciq1cisvsp8kdz8p2i-gmp-5.1.3/lib/libgmp.a(mp_get_fns.o): relocation R_ARM_MOVW_ABS_NC against `__gmp_allocate_func' can not be used when making a shared object; recompile with -fPIC
/nix/store/92pdpqrqkdf8wjciq1cisvsp8kdz8p2i-gmp-5.1.3/lib/libgmp.a: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
make[2]: *** [libisl.la] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/tmp/nix-build-isl-0.11.1.drv-3/isl-0.11.1'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/nix-build-isl-0.11.1.drv-3/isl-0.11.1'
make: *** [all] Error 2
builder for ‘/nix/store/a8ghniifd8d8agqx0cqsh41daa08v11c-isl-0.11.1.drv’ failed with exit code 2
````

I could get it to work with https://github.com/dezgeg/nixpkgs/commit/c9c2ea9b605799a34729cf58acf6ed4a7c269798, which is horribly ugly, but I don't know much about the overrides mechanism either. In particular, I don't get why the `isl = isl_0_11; cloog = cloog_0_18_0;` are needed here, as it works correctly for `mpfr` & `libmpc`. It looks like this override at https://github.com/NixOS/nixpkgs/blob/staging/pkgs/top-level/all-packages.nix#L3726 is taking precedence over the `pkgs.makeStaticLibraries` override here.


use sizeof(base) instead of an immediate value


Discussion continued as issue #41


One idea might be to make the pwm logic a class.  For example:

```
class Actuator:
  def __init__(self, maxHeight)...

  def set(self, percentage)...
```


The ability to override the session or the url here doesn't seem necessary. It's better to have the whole client scoped to the same target endpoint.


I recommend moving these tests to a source file so that we only test once per build instead of once per translation unit (will slightly speed up compile times).


So, I've implemented this and am passing the deleteItem call all the way back up to my delegate/datasource, but am unsure as to how we are expected to delete the item from there.

Can you share your code for **removeItemAtIndex:(NSInteger)index** ?


Danke für die Blumen :).


Sure. Sounds good.


In general I would agree but there's no clean place to put it and this is only included in a small number of places. If it gets more use I might consider it.


Also the number of lines in the test is small


Eventuell sollten wir für den Wert `edit_posts` einen Filter anbieten, da es statisch ist und nicht immer gewollt.


Might as well use `.exception()`:

```python
self.log.exception('Error sending datapoints!', e)
```


It would require `repo` access. I suppose it would be up to people to use whatever they want and we can explain it in the README :/

The idea of putting a token with that access, that can be used by other packages seems like a terrible idea though.


Don't do the string formatting yourself, because it will have to be done even if the logger is not logging at DEBUG level. That's why logging methods take in formatting arguments:

```python
self.log.debug('Sending metrics %s (%d %s)',
    'Passed' if response.ok else 'Failed',
    response.status_code, response.text)
```


With that change to the template, do you still get an acronym listing? Such as with:
```
\documentclass{article}
\usepackage[colorlinks]{hyperref}
\usepackage[printonlyused,withpage]{acronym}
\usepackage{makeidx}
\begin{document}

\section{Intro}
In the early nineties, \acs{GSM} was deployed in many European
countries. \ac{GSM} offered for the first time international
roaming for mobile subscribers. The \acs{GSM}'s use of \ac{TDMA} as
its communication standard was debated at length. And every now
and then there are big discussion whether \ac{CDMA} should have
been chosen over \ac{TDMA}.

\section{Furthermore}
\acresetall
The reader could have forgotten all the nice acronyms, so we repeat the
meaning again.

If you want to know more about \acf{GSM}, \acf{TDMA}, \acf{CDMA}
and other acronyms, just read a book about mobile communication. Just
to mention it: There is another \ac{UA}, just for testing purposes!

\begin{figure}[h]
Figure
\caption{A float also admits references like \ac{GSM} or \acf{CDMA}.}
\end{figure}

\subsection{Some chemistry and physics}
\label{Chem}
\ac{NAD+} is a major electron acceptor in the oxidation
of fuel molecules. The reactive part of \ac{NAD+} is its nictinamide
ring, a pyridine derivate.

One mol consists of \acs{NA} atoms or molecules. There is a relation
between the constant of Boltzmann and the \acl{NA}:
\begin{equation}
k = R/\acs{NA}
\end{equation}

\acl{lox}/\acl{lh2} (\acsu{lox}/\acsu{lh2})

\subsection{Some testing fundamentals}
When testing \acp{IC}, one typically wants to identify functional
blocks to be tested separately. The latter are commonly indicated as
\acp{BUT}. To test a \ac{BUT} requires defining a testing strategy\dots

\section{Index}
\printindex

\section{Acronyms}
\begin{acronym}[TDMA]
\acro{CDMA}{Code Division Multiple Access}
\acro{GSM}{Global System for Mobile communication}
\acro{NA}[\ensuremath{N_{\mathrm A}}]
     {Number of Avogadro\acroextra{ (see \S\ref{Chem})}}
\acro{NAD+}[NAD\textsuperscript{+}]{Nicotinamide Adenine Dinucleotide}
\acro{NUA}{Not Used Acronym}
\acro{TDMA}{Time Division Multiple Access}
\acro{UA}{Used Acronym}
\acro{lox}[\ensuremath{LOX}]{Liquid Oxygen}%
\acro{lh2}[\ensuremath{LH_2}]{Liquid Hydrogen}%
\acro{IC}{Integrated Circuit}%
\acrodefplural{BUT}{Blocks Under Test}%
\acro{BUT}{Block Under Test}%
\end{acronym}

\end{document}
```


I'm left wondering what purpose `b` serves here.  How about using `b` in the `if` test, or just returning the `static_cast` directly.


@claudioandre @Sayantan2048 I did this just using 'meld' and copying MD4 stuff. I still don't understand it all but am getting closer :sunglasses:


>Kontakta underhållaren för...
Underhållaren funkar inte riktigt här. Kanske ersätta med ett annat engelskt ord. 'Kontakta teamet ' ?


Oh man, wish you would have dropped that last bracket on to a new line ;)


Although this will indeed raise a `TypeError` if no previous exception has been raised in this scope, it's better to be explicit about it. You also probably don't need the logging, the exception will carry the message just fine:

```python
else:
    raise ValueError('Invalid value ' + value)
```


I think the dangling `else` is causing `Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Cannot reassign variable _repo_url at /etc/puppet/environments/sawslab/modules/st2/manifests/pack.pp:36`?


Not relate to this commit, but `This value will be 0 if the total number of frames is unknown or infinite.` under `num_frames` should be deleted as well.


Nix. Det förra är det korrekta.


If this is only for `pyformance`, this should be handled in our Pyformance reporter, not here.


Yeah, it's a shame the permissions aren't more fine grained... All the package really needs is to look up if there's a pull request for a specific branch.

The good news is that having just the `repo:status` permission doesn't break anything, the pull request link just isn't generated (the build status link is).


I didn't get a build error.
I will update. Wait.


@HowardHinnant Because `std::shared_ptr::operator bool` is explicit


Nit: Space after `//`


Panorering?


Keep spaces around your operators and simply multiply by 1000, it's easier for the reader:

```python
pbuf_dp.timestamp = int(datapoint['timestamp']) * 1000
```


Samma här. Panorering.


This should use the metric type values defined in the protobuf.


All the package really needs is the pull request *number* (or URL), not even information about the pull request. The pull request URL could be added to the build status JSON without any real security implications.


Datapoint-level logging should be at the trace level. Also, don't do the formatting yourself or it will be done all the time.


Heh. Yup. I broke it. Give me a few.


Use `if not metrics:`, so you skip empty lists as well directly.


I don't understand the question - the 'User Story' I'm addressing is "As a user of the Java SDK integration, I should not have to specify an MVC view name for a given Stormpath MVC config unless I want to specify my own view template.  In that case, I want to specify the view name in the same config location (along side of) the other properties of the Stormpath MVC block."


It's an error if it's not a list, programmer probably deserves an exception otherwise.


using dashes in service name could be a bit misleading, as config server takes 'after-dash' part as a profile name
```
/{application}/{profile}[/{label}]
/{application}-{profile}.yml
/{label}/{application}-{profile}.yml
/{application}-{profile}.properties
/{label}/{application}-{profile}.properties
```


I think it is good to change to `if (b)`.  But just fyi, `explicit operator bool()` works implicitly in a context that is termed "contextually convertible to bool".  And `if` is one of those special places.  So `shared_ptr` continues to have an implicit conversion to `bool` inside an `if`.


Updated.


These are datapoints, not metrics


Shame


Ok. Let's add then a `#pragma warning` under MSVC `ifdef` to easily find it
when we have time to revisit compilation in Visual Studio.

11 июня 2015 г., в 21:12, Dima <notifications@github.com> написал(а):

It will still be enabled on its own. Just disabled under `full-test.sh`.

—
Reply to this email directly or view it on GitHub
<https://github.com/dkorolev/Current/commit/bf9dc3bb5969162f07498336e05f5e2a4ab24573#commitcomment-11639833>
.


this isn't available when removing the d3dx9.h include from support.h which we need to get rid of


It is for jump arguments taking strings, like `--log-prefix`. They're not handled here, but see current develop for all jump arguments supported.


现在看过来感觉自己真可笑


You need to validate the types (valid ones). Update the description with the ones that are valid.


That's right but not in `return shouldBeTrue` and I wanted to perform the `bool` conversion once.


bravo :clap:


`public final class PublishSubject<T>
extends Subject<T,T>`

`public abstract class Subject<T,R>
extends Observable<R>
implements Observer<T>`


nice, thanks


Give proper authorships @W4TCH0UT


выравнивай код. старайся чтобы он был у тебя всегда отформатирован. важно, чтобы код было легко читать


This code is pretty confusing, but it looks like you run 20*count tests in total 8*count at a time, and require floor(20/8)=2 to succeed?  See above comment to make all of this clearer.


@insidegui could you please explain the reason of `dispatch_once` with a **static** onceToken here?
In my understanding it will be executed just once for the first instance of `GRCustomPlayerView` and never for the following instances, but this class isn't looks like a singleton.


форматирование


(just a note for myself)


отформатируй весь файл


Why do you need access to network state?


I think it looks fine. Here is the verbatim HTML output:
```html
<!DOCTYPE html><html>
<head>
<title>Untitled Document</title>
<!--Generated on Thu Jun 11 14:46:48 2015 by LaTeXML (version 0.8.1) http://dlmf.nist.gov/LaTeXML/.-->
<!--Document created on June 11, 2015.-->

<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<link rel="stylesheet" href="LaTeXML.css" type="text/css">
<link rel="stylesheet" href="ltx-article.css" type="text/css">
</head>
<body>
<div class="ltx_page_main">
<div class="ltx_page_content">
<article class="ltx_document">
<section id="S1" class="ltx_section">
<h2 class="ltx_title ltx_title_section">
<span class="ltx_tag ltx_tag_section">1 </span>Intro</h2>

<div id="S1.p1" class="ltx_para">
<p class="ltx_p">In the early nineties, <a href="#id2"><abbr href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">GSM</span></abbr></a> was deployed in many European
countries.  <a href="#id2"><span href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Global System for Mobile communication</span></span></a> (<a href="#id2"><abbr href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">GSM</span></abbr></a>) offered for the first time international
roaming for mobile subscribers. The <a href="#id2"><abbr href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">GSM</span></abbr></a>’s use of  <a href="#id6"><span href="#id6" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Time Division Multiple Access</span></span></a> (<a href="#id6"><abbr href="#id6" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">TDMA</span></abbr></a>) as
its communication standard was debated at length. And every now
and then there are big discussion whether  <a href="#id1"><span href="#id1" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Code Division Multiple Access</span></span></a> (<a href="#id1"><abbr href="#id1" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">CDMA</span></abbr></a>) should have
been chosen over <a href="#id6"><abbr href="#id6" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">TDMA</span></abbr></a>.</p>
</div>
</section>
<section id="S2" class="ltx_section">
<h2 class="ltx_title ltx_title_section">
<span class="ltx_tag ltx_tag_section">2 </span>Furthermore</h2>

<div id="S2.p1" class="ltx_para">
<p class="ltx_p">The reader could have forgotten all the nice acronyms, so we repeat the
meaning again.</p>
</div>
<div id="S2.p2" class="ltx_para">
<p class="ltx_p">If you want to know more about  <a href="#id2"><span href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Global System for Mobile communication</span></span></a> (<a href="#id2"><abbr href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">GSM</span></abbr></a>),  <a href="#id6"><span href="#id6" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Time Division Multiple Access</span></span></a> (<a href="#id6"><abbr href="#id6" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">TDMA</span></abbr></a>),  <a href="#id1"><span href="#id1" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Code Division Multiple Access</span></span></a> (<a href="#id1"><abbr href="#id1" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">CDMA</span></abbr></a>)
and other acronyms, just read a book about mobile communication. Just
to mention it: There is another  <a href="#id7"><span href="#id7" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Used Acronym</span></span></a> (<a href="#id7"><abbr href="#id7" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">UA</span></abbr></a>), just for testing purposes!</p>
</div>
<figure id="S2.F1" class="ltx_figure">
<p class="ltx_p">Figure</p>
<figcaption class="ltx_caption"><span class="ltx_tag ltx_tag_figure">Figure 1: </span>A float also admits references like <a href="#id2"><abbr href="#id2" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">GSM</span></abbr></a> or  <a href="#id1"><span href="#id1" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Code Division Multiple Access</span></span></a> (<a href="#id1"><abbr href="#id1" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">CDMA</span></abbr></a>).</figcaption>
</figure>
<section id="S2.SS1" class="ltx_subsection">
<h3 class="ltx_title ltx_title_subsection">
<span class="ltx_tag ltx_tag_subsection">2.1 </span>Some chemistry and physics</h3>

<div id="S2.SS1.p1" class="ltx_para">
<p class="ltx_p"><a href="#id4"><span href="#id4" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Nicotinamide Adenine Dinucleotide</span></span></a> (<a href="#id4"><abbr href="#id4" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">NAD<sup class="ltx_sup">+</sup></span></abbr></a>) is a major electron acceptor in the oxidation
of fuel molecules. The reactive part of <a href="#id4"><abbr href="#id4" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">NAD<sup class="ltx_sup">+</sup></span></abbr></a> is its nictinamide
ring, a pyridine derivate.</p>
</div>
<div id="S2.SS1.p2" class="ltx_para">
<p class="ltx_p">One mol consists of <a href="#id3"><abbr href="#id3" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short"><math class="ltx_Math" alttext="N_{\mathrm{A}}" display="inline"><msub><mi>N</mi><mi mathvariant="normal">A</mi></msub></math></span></abbr></a> atoms or molecules. There is a relation
between the constant of Boltzmann and the <a href="#id3"><span href="#id3" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Number of Avogadro</span></span></a>:</p>
<table id="S2.E1" class="ltx_equation ltx_eqn_table">

<tr class="ltx_equation ltx_eqn_row ltx_align_baseline">
<td class="ltx_eqn_cell ltx_eqn_center_padleft"></td>
<td class="ltx_eqn_cell ltx_align_center"><math id="S2.E1.m1" class="ltx_Math" alttext="k=R/\AC@acs{NA}" display="block"><mrow><mi>k</mi><mo>=</mo><mrow><mi>R</mi><mo>/</mo><mtext><a href="#id3"><abbr href="#id3" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short"><XMath xmlns="http://dlmf.nist.gov/LaTeXML"><XMApp><XMTok role="SUBSCRIPTOP" scriptpos="post4"></XMTok><XMTok role="UNKNOWN" font="italic">N</XMTok><XMTok role="UNKNOWN">A</XMTok></XMApp></XMath></span></abbr></a></mtext></mrow></mrow></math></td>
<td class="ltx_eqn_cell ltx_eqn_center_padright"></td>
<td rowspan="1" class="ltx_eqn_cell ltx_eqn_eqno ltx_align_middle ltx_align_right"><span class="ltx_tag ltx_tag_equation
      ltx_eqn_eqno ltx_align_middle
      ltx_align_right">(1)</span></td>
</tr>
</table>
</div>
<div id="S2.SS1.p3" class="ltx_para">
<p class="ltx_p"><a href="#id8"><span href="#id8" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Liquid Oxygen</span></span></a>/<a href="#id9"><span href="#id9" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long">Liquid Hydrogen</span></span></a> (<a href="#id8"><abbr href="#id8" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short"><math class="ltx_Math" alttext="LOX" display="inline"><mrow><mi>L</mi><mo></mo><mi>O</mi><mo></mo><mi>X</mi></mrow></math></span></abbr></a>/<a href="#id9"><abbr href="#id9" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short"><math class="ltx_Math" alttext="LH_{2}" display="inline"><mrow><mi>L</mi><mo></mo><msub><mi>H</mi><mn>2</mn></msub></mrow></math></span></abbr></a>)</p>
</div>
</section>
<section id="S2.SS2" class="ltx_subsection">
<h3 class="ltx_title ltx_title_subsection">
<span class="ltx_tag ltx_tag_subsection">2.2 </span>Some testing fundamentals</h3>

<div id="S2.SS2.p1" class="ltx_para">
<p class="ltx_p">When testing <a href="#id10"><span href="#id10" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long-plural">Integrated Circuits</span></span></a>, one typically wants to identify functional
blocks to be tested separately. The latter are commonly indicated as
<a href="#id11"><span href="#id11" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_long-plural">Blocks Under Test</span></span></a>. To test a <a href="#id11"><abbr href="#id11" title="" class="ltx_glossaryref ltx_role_acronym"><span class="ltx_text ltx_glossary_short">BUT</span></abbr></a> requires defining a testing strategy…</p>
</div>
</section>
</section>
<section id="S3" class="ltx_section">
<h2 class="ltx_title ltx_title_section">
<span class="ltx_tag ltx_tag_section">3 </span>Index</h2>

</section>
<section id="idx" class="ltx_index">
<h2 class="ltx_title ltx_title_index">Index</h2>

</section>
<section id="S4" class="ltx_section">
<h2 class="ltx_title ltx_title_section">
<span class="ltx_tag ltx_tag_section">4 </span>Acronyms</h2>

</section>
<section class="ltx_glossary ltx_acronym ltx_role_acronym">
<dl class="ltx_glossarylist">
<dt id="id1" class="ltx_glossaryentry ltx_role_acronym">CDMA</dt>
<dd>Code Division Multiple Access</dd>
<dt id="id2" class="ltx_glossaryentry ltx_role_acronym">GSM</dt>
<dd>Global System for Mobile communication</dd>
<dt id="id3" class="ltx_glossaryentry ltx_role_acronym"><math id="m1" class="ltx_Math" alttext="N_{\mathrm{A}}" display="inline"><msub><mi>N</mi><mi mathvariant="normal">A</mi></msub></math></dt>
<dd>Number of Avogadro (see §<a href="#S2.SS1" title="2.1 Some chemistry and physics ‣ 2 Furthermore" class="ltx_ref"><span class="ltx_text ltx_ref_tag">2.1</span></a>)</dd>
<dt id="id4" class="ltx_glossaryentry ltx_role_acronym">NAD<sup class="ltx_sup">+</sup>
</dt>
<dd>Nicotinamide Adenine Dinucleotide</dd>
<dt id="id5" class="ltx_glossaryentry ltx_role_acronym">NUA</dt>
<dd>Not Used Acronym</dd>
<dt id="id6" class="ltx_glossaryentry ltx_role_acronym">TDMA</dt>
<dd>Time Division Multiple Access</dd>
<dt id="id7" class="ltx_glossaryentry ltx_role_acronym">UA</dt>
<dd>Used Acronym</dd>
<dt id="id8" class="ltx_glossaryentry ltx_role_acronym"><math id="m3" class="ltx_Math" alttext="LOX" display="inline"><mrow><mi>L</mi><mo></mo><mi>O</mi><mo></mo><mi>X</mi></mrow></math></dt>
<dd>Liquid Oxygen</dd>
<dt id="id9" class="ltx_glossaryentry ltx_role_acronym"><math id="m5" class="ltx_Math" alttext="LH_{2}" display="inline"><mrow><mi>L</mi><mo></mo><msub><mi>H</mi><mn>2</mn></msub></mrow></math></dt>
<dd>Liquid Hydrogen</dd>
<dt id="id10" class="ltx_glossaryentry ltx_role_acronym">IC</dt>
<dd>Integrated Circuit</dd>
<dt id="id11" class="ltx_glossaryentry ltx_role_acronym">BUT</dt>
<dd>Block Under Test</dd>
</dl>
</section>
</article>
</div>
<footer class="ltx_page_footer">
<div class="ltx_page_logo">Generated  on Thu Jun 11 14:46:48 2015 by <a href="http://dlmf.nist.gov/LaTeXML/">LaTeXML <img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAsAAAAOCAYAAAD5YeaVAAAAAXNSR0IArs4c6QAAAAZiS0dEAP8A/wD/oL2nkwAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9wKExQZLWTEaOUAAAAddEVYdENvbW1lbnQAQ3JlYXRlZCB3aXRoIFRoZSBHSU1Q72QlbgAAAdpJREFUKM9tkL+L2nAARz9fPZNCKFapUn8kyI0e4iRHSR1Kb8ng0lJw6FYHFwv2LwhOpcWxTjeUunYqOmqd6hEoRDhtDWdA8ApRYsSUCDHNt5ul13vz4w0vWCgUnnEc975arX6ORqN3VqtVZbfbTQC4uEHANM3jSqXymFI6yWazP2KxWAXAL9zCUa1Wy2tXVxheKA9YNoR8Pt+aTqe4FVVVvz05O6MBhqUIBGk8Hn8HAOVy+T+XLJfLS4ZhTiRJgqIoVBRFIoric47jPnmeB1mW/9rr9ZpSSn3Lsmir1fJZlqWlUonKsvwWwD8ymc/nXwVBeLjf7xEKhdBut9Hr9WgmkyGEkJwsy5eHG5vN5g0AKIoCAEgkEkin0wQAfN9/cXPdheu6P33fBwB4ngcAcByHJpPJl+fn54mD3Gg0NrquXxeLRQAAwzAYj8cwTZPwPH9/sVg8PXweDAauqqr2cDjEer1GJBLBZDJBs9mE4zjwfZ85lAGg2+06hmGgXq+j3+/DsixYlgVN03a9Xu8jgCNCyIegIAgx13Vfd7vdu+FweG8YRkjXdWy329+dTgeSJD3ieZ7RNO0VAXAPwDEAO5VKndi2fWrb9jWl9Esul6PZbDY9Go1OZ7PZ9z/lyuD3OozU2wAAAABJRU5ErkJggg==" alt="[LOGO]"></a>
</div></footer>
</div>
</body>
</html>

```


Hmmm, I thought It would be executed once per instance. Maybe I'm wrong...


Add a comment why this is here (since getModel doesn't use the information).


Yeah we can do that once we need it (so we can benchmark it - who knows, it might not be faster). Sooner or later I expect we'll have a format that needs it.


merge my version of the loop here.


Best commit message ever.  ;)


Well, it has to go somewhere... Suggestions welcome.


следи, чтобы объекты jquery назывались с "$"
тут var $menuUp = $('.menu');


Awesome


On this commit I don't see the reason why to use `PublishSubject`, if you're not using `hasObservers()` for example.

What's the rationale?


Surprised this parses, seems like line lengths are bad.


is this diff only a retabing ?


I meant to put a logging message there to indicate that the element was not explicitly handled and that the code was going to treat it as a metadata tag_type. I could probably still do that and fold it up into the metadata elif.


just some comments


transaction.complete is called earlier: https://github.com/ripple/ripple-lib/commit/278331cc4a577f5b50a17e6acbcd0aaa767aff94#diff-2cce243153aedbf06a64c72380082df1R52


The markup is different. In your example LaTeXML creates a ```glossaryentry``` with ```role='acronym'``` while I only filtered out the ```glossaryphrase``` with role acronym.

But it still feels a bit dangerous if you have any example that uses glossaryphrase elements with acronym roles to deposit actual content.


петя красава


A


I initially wanted to add a network checker, forgot to implement one lol.


hey this is totally lame....


Nej, sorry! Originalet är något bättre. Men jag skulle ändra sista meningen:

>Annars blir din ljudfil mer eller mindre högljudd, men originalfilen förändras inte

Till bara: Originalfilen påverkas inte.


the rationale is that this class already manage the subscribers list. We return a shared observable, but if we create them manually, we should keep track of every (primary) subscriber and additionally, add an additional operation to the subscription to remove it from the internal list when the subscriber unsubscribe.


I noticed that, but doesn't this project provide a sliding window for all iterator types (with `Item: Copy`)? `.windows()` is only for slices


This looks real good :+1:


This is directed at keywords (well keys actually) in the returned objects so a new version could return more keys and a client shouldn't use the object, dict or associative array that you get when you decode the json object in a way that could break if more keys are added. Like passing it to some database library that converts keys to db columns since then you'd end up with a query that tries to use columns that don't exist.

Does that make sense?


I call subject.onNext btw


Looks good to me.


But I will probably need that permission later anyway. I want to add a tasker. So when network state changes it will also apply a profile for example.


use SUBRULE()
instead of SUBRULE1()


This is some ugly c++. Should we throw an error at the end instead of an *ostensibly* redundant return? Why are we inlining these anyhow?


It's fine temporarily since we'll actually need the browser to navigate to the static homepage. I plan to revamp the navigation code in the next week or so that we don't need ad hoc `preventDefault` commands everywhere.


format this.
 Error{ --> Error {


>tasker
Allow to do it using intent. There are a lot of tasker-like free (like in "free beer") addons.


Missing comma at end of line here


@kevinastone I just want to notify you that today we released v0.5.2 on PyPI


:tada:


Check this out @casey-collab


Rad! :+1:


I'd still want to keep the complete example because in my mind that is easier to read, but the numbered list is better than the sentence I have.


где используется эта переменная?


I will add an own implementation. I don't want people download any third party app for that.


@Aktron Thnx :)


такое нужно убирать


something's weird with the indents, yeah.  It looks fine in my editor so IDK :|  Not sure why line length would affect parsing though..


тут пишеться var
так прийнято


var


Great!
This happens to me because I made recently repo sync.


hmm, what's the idea behind this?


시간이 많이 없을때는...
리드미 파일을 정리 하는게 좋을것 같애


FYI @vigliensoni


Shouldn't this be AppEngineFileUploadHandler?
(Just noticed the back-compat lines at the bottom, but this confused me.)


@tejasmanohar @holman Very funny :p :p
How you did this?


oh, I thought that was a method of the abstract parent, now I see its not, nvm then.


comment for this


sure, we can thrown an error, not sure how to do that though.  I kept the `return response;` because my editor was complaining when I didn't return anything.  Agree it's redundant though.

what do you mean by inlining?


`tq, queue = queue[0], queue[1:]`


so in the end you were right that it's up to the Observable implementation to keep that list.


а почему ты сразу в его не преобразуешь? зачем тебе переменная margin?


constructor is too verbose .
you can use short form to define members + init them

```TypeScript
constructor(public prop1: type1, private prop2: type2 = "bamba"...
````


It is not unix way. But it's your app, so you decide.


если уже пишешь такой комент то лучше раздели его на два и укажи где ты это делаешь в методе, а не ставь комент возле класса


@gabrielrios @ylluminate @andreanastacio Darn it, sorry, I forgot to make a PR for this change :sweat_smile:

Basically, I changed `Phaser::Input#on` so that it would return `Phaser::Signal` if no block was given:
```ruby
@game.input.on(:down) # returns Phaser::Signal
```

I did so that methods could be accessed from `Phaser::Signal`, such as the `dispose` method, like so:
```ruby
@game.input.on(:down).dispose # disposes the onDown event
```

Is everyone okay with these changes?


var


Wouldn't we want to have an error here?


Putting all of the disconnects and returns in each block.

Depends on the API for the return, there are exceptions in C++ but they're a bit wonky. CAn we return a -1 or something and have an upper layer throw up?


@vongillern I threw in another test case to show you what I've built here.

I opened up the Assist code to allow users to register their own "value retrievers" and "value comparers" when doing the SpecFlow.Assist stuff to tables.

They're pretty simple.

An ```IValueRetriever``` is a class responsible for converting a text value in a table cell to some sort of value.

An ```IValueComparer``` is a class responsible for comparing a text value in a table cell to some sort of value.

In the past, these were closed off and only coding for the standard .Net base value types.  This means you could do this:

```gherkin
| Name | Category |
| Apple  | Fruit  |
```

and say:

```c#
table.ConvertToInstance<Product>();
```

**only if** both were base value types.  (Name & Category are both strings).

### but what if Category is an custom class???

Before, you were out of luck.  But with this PR, you can register your own ```IValueRetriever``` and ```IValueComparer``` to tell SpecFlow how to handle the Category as a custom class.

So I ask you, @vongillern... is this of any value to you?  Do you like the idea, and would you use it?  Is there anything else around this area that would be of use to you?


But I call them the "primary ones", because in the pipe construction, it could be a lot of "connections" that keep different type of subscriber lists, to do different operations.


I really did not see a huge improvement using SSE4.2 over my original table based #define. It was a little faster (10% or so), but that was it.  Also, I could get a few extra % improvement with the u32 functions, and I would assume more using the u64.  I wonder if alignment on either of those functions would make things better.

I guess we can play with it some, since it is in a function where we pass a length and string over.  It probably can be optimized, but I do not know how much the gain will end up being.


r+


тит краще зробить switch, але не принципово. можна й if


in what situation will there not be a top level rule?


@vongillern I'd start with the two test cases.  See how the setup works, then see how the value retriever & value comparers do their thing.


Well took some time to try out something... unless I am doing something wrong it paid off :100: times.
http://i.imgur.com/DuCdMVd.png


Done.


My code only uses title and and from but I think we should pass:
title, from, to, cc, body.

If someone needs something besides that we can add it.


I've been linking to the local file: change `http://opensource.org/licenses/MIT` to `LICENSE`.


isn't source going to end up as None if not explicitly passed?


этот блок кода повторяется три раза
давай сделаем функцию отдельную которая будет возвращать procent
так мы избавимся от дублирования


ternary condition formatting is ugly.
maybe split into a few lines instead of one big fancy line.

btw you can use ES6 template strings in typescript 1.4


var


Looks great!


четыре раза :+1:


Remove this file.


пять :+1:


что бы проще ориентироваться кнопки можно сразу называть каким нибудь действием, тогда даже не придется писать комент что она делает button_check_decrypt


The next idea is to create an ```IValueRetriever``` and ```IValueComparer``` that binds up to the  ```StepArgumentTransformation```s


var next 4


Ok, just small thing: could you use a relative path here? ```File dir = new File("C:/pythonexercises/download/");```

Thank you!


oh, well we're inlining all those disconnects because without it, node manager will return without having called disconnect at all.  And the number of file descriptors / connections to the asterisk db explodes.

sure, returning a -1 seems fine I guess.  I don't know much about C++


Need to update the ``==`` method below.


You should probably be working on the new Make More Digital website.


if you want to collect results in a functional style, use _.reduce or map + flatten


still need this block above the change?:

```
if (listener != null) {
    listener.onResults(performer, results);
}
```


Eh heh? :-) :) Eh Heh?


@Anaethelion  @regilero see https://github.com/makinacorpus/makina-states/tree/master/docker, this is going to please you ;)


що це?
видалить


вар


No. This is needed for proper handling of embedded fields with names that are shadowed. Consider:

```
type Foo struct {
  A int
}

type Bar struct {
  Foo
  A int
}
```

See `TestMappingEmbedded`.


BigInt p = GeneratePrime(PLength);
    while ( (p-1)%q!=0 ) {
        p = GeneratePrime(PLength);
    }


The change to app.rb in this commit is required since jruby-9.0.0.0.rc1 see https://github.com/jruby/jruby/issues/3036, if I had not already bumped to 2.7 I would have incremented further as this likely a breaking change (but only on a pre-release). @fluxusfrequency @stevekinney will need to repeat for JRubyArt.


I'm confused by this. Even if the user asks for `--rsync` or `--curl`, shouldn't we abort if the directory already exists?


Yes, still working with System.out.println, I need to figure out the design to get the performer in the UI, because I use the token to send to the right tab.


var str №80, 81 82 85 86 87


var


немного не понял, эти клики делают тоже самое что функции portfolioLeft() и Right()
или я ошибаюсь?


And I don't want to pass a performer reference in the pipe (mutability issues).


in kim1 `mapper.fields` always uses the `attribute_name` and not the `name` or `source`

I think it would be more confusing if you declared a field  `foo = Field(name='bar')` but then it actually exists on `mapper.fields` as `bar`


что такое met?


In the crc32 format, we're hitting all sorts of bottlenecks. This function can potentially be used in something similar to RAR -hp mode, where a huge block will be checksummed. In that case I'm sure u64/u32 will be a tremendous speedup.


Would you be fine with me stripping the CPU-session stuff from this commit and just leave the NOVA syscall bindings? Than I could start playing with the idea to expose the execution times to a trace monitor.


tomó hasta los espacio. Este es el delta de modificación que hice en la versión


no_raw_loops (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Assuming this is a placeholder for later actual encoding.


лапки не потрібно
але не принципово


Awesome!


Tu as utiliser quel commande pour deploy ?

Car https://twitter.com/aschelch/status/609066339525722112


:shipit:


(C'est fixé)


Nice


Unfortunately travis-ci keeps rolling back their "built-in" phantomjs 2.0 support. In the mean time, this will work


Until we get the Macintosh packages fixed, you'll need to compile from source or to install from Homebrew, as you've been doing anyway, I imagine.


Yes. When we have a full schema columns will have column ids. But it's essentially going to just be appending a single value to the primary key like this.


@arthurvr fine now?


Tests. I'll correct the test.


no_raw_loops (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


~~inspired by~~ shamelessly stolen from thought_bot:  https://robots.thoughtbot.com/mygem-configure-block


@SDkie authors != committers in git. everything's in the `.git/` folder and there are flags like `--author` http://schacon.github.io/git/git-commit.html. wrote a small shell script and boom! :tada:

there are some other things like you have to have the other user as a collaborator on the repo for it to show on their contribution graph, but the commits link to their profile either way (for now- i'm guessing eventually there'll be some key-based (either ssh or http auth) checks). users can also remove themselves from the repo which @holman has done here.


I'll just correct the test


So there's no difference between `on(:down)` and `on(:up)`, tried to look at the Phaser.js code but couldn't find, that's weird.


I knew we used a simpler syntax.. I'll change this


Move this to Environment variables


reset the stalelock flag


keep the check_failed, and reset the "stalelock" flag.


loop over the volume, check_failed() for each that still has the stalelock flag set.


remove this loop


On 06/11/2015 08:54 PM, Larry Shaffer wrote:
> Missing comma at end of line here

Thanks for spotting this, I've fixed it in #26.


Indeed ;) Good thing this tool will auto-generate brilliant marketing websites when it's finished in 3 years time.

$formfront create_website -company "make more" etc...


не пиши такие большие коменты тем более на против класса, разделяй их и пиши в методе если ты хочешь детально указать что где


I think this is not 100% accurate and may end up being misleading. Error messages to users must be as accurate as we can.

### magical strings
instead of: "CONSUME"/"SUBRULE" use:
```JavaScript
 lang.functionName(BaseRecognizer.prototype.CONSUME)
```
to get the name of the function for maintainability/refactoring

### occurrence = 1 ambiguity
instead of giving possibly inaccurate errors, modify the gastBuilder and its classes to be able to differentiate between
an instance create from CONSUME1 vs CONSUME

### FQN of Terminal ambiguity (CONSUME(A.B.C.Identifier | A,Identifier))
Again you can modify the gastBuilder to keep a reference to the original string a TOP rule was built from.
if you have the original string you can use the same RegExps GASTBuilder to extract the **exact** form the user wrote.


no_raw_loops (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


Pushed 39902b0.


There are several files here which I don't should have been committed.


@gabrielrios Yes, they're the same. I looked at them both; they're just instances of `Signal`: https://github.com/photonstorm/phaser/blob/v2.3.0/src/input/Input.js#L377-L380
Btw, you might not have been able to find them because their definition is hidden in the `Phaser.Input.boot` method.


alrighty, its "normalized" now.
:)

On Thu, Jun 11, 2015 at 10:35 AM, Doga Gursoy <notifications@github.com>
wrote:

> How about using normalized instead of doNorm? I try to use all lowercase
> letters for the args with underscores.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ttgmichael/tomopy/commit/0349213ccb682e6b02b22a53634dce6fc6308519#commitcomment-11639119>
> .
>


From the commit message: "Added member is needed for baseConnectionContactsInterface::getContactByID()."


:+1: Secret like travis?


it used deobf mappings but aprearently it doesn't know the obf mapping for non dev environments


I'd still like this to get DRY'd up into a helper, especially since the list of things is growing.  Also will be easier to read `userCanSave` or some such than a big conditional.


we need SRG names


I see that it's done in a later commit, cool.


Only Own in front of ghost? @akhilnarang ?


I think this line should be replaced by (https://track.hpccsystems.com/browse/HPCC-12303):

bool* tagValue = resultChildTags.getValue(tag);
if (tagValue && *tagValue)


looks good


in what situation is prods.length = 0 ?


Same as the last comment.


no_raw_loops (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


looks fine to me too.


Whoops, this refs #119.


I think that isn't possible to move to /etc, so at least I marked as config.


OK. So I'm going to restore the changes.


typo: we are


if possible would recommend starting jruby with the processing jars on the class-path instead of requiring them (since it assumes to be loading classes outside the jar that might be elsewhere on the class-path) ...


I've removed the ternary operator. In the tests I don't initialize the top rule but I don't call message() therefore I don't get a dereferencing null error...


Consider changing to `user_id && this.userMatch(user_id)`


well done


Should probably redirect to login page instead,of /


If the construction throws, then we're likely to get UB as the stack unwinds and tries to destruct `v` a second time.  I realize that we probably want the exception to terminate anyway.  But we want a clean terminate for a better debugging experience.

One way to fix this would be to wrap the whole function in a `try/catch(...)` and call `std::terminate()` in the catch.  A cleaner way to do exactly that is to simply tag `reconstruct` with `noexcept`:
`reconstruct (LedgerEntrySet& v, Args&&... args) noexcept`


The readme should be targeted towards product developers (consumers), so I would remove this section. There should be a way to test locally without having to change `_variables.scss`, but it's difficult to verify until the registry is online and the demos are functioning.


Yes, static variable defined in a method/function is actually a global variable visible only in this method.


Hmm, "@Deprecated" exists precisely to signal to others that class or method will be deleted in the future, it seems strange that you do not want to use it.


shall we use 'elif' here ?  otherwise '?' will still reach the following two branchs


Hi @morgo!

Thank you very much for the observation :)

I just created an issue on Ecto with your suggestion: https://github.com/elixir-lang/ecto/issues/656


Partly secret, more like "not visible in the web interface" :) We cannot make it secret completely as it should be available for reading through the api. We could have the api not return those on normal queries (`/api/..../environments/`) and only return in the `http://api.bootenv.com/api/env/TOKEN` calls that can be restricted to only those that can get a token.


@EIrwin can we move this specific commit into a separate PR of its own. Will increase the likelihood of this important change getting merged in sooner. CC @tsudot


PLEASE LEARN HOW TO SET PARAMETER IN IDE NEXT TIME !!!!!


OK, now it doesn't fail (was failing for the wrong reasons). =(


I'm confused. This was meant to be ``transaction``, right?


@sophokles73

Hi, we're looking at using a persistent backing store (Cassandra or something similar) for DTLSSessions so that we can load balance our CoAP proxy servers.

I'm wondering about the reason for this patch. Is it purely because the InMemoryStore doesn't require update()? Modifying the interface will still break clients who have implemented their own SessionStore that isn't necessarily in memory.

Is the stated assumption that all SessionStores be in memory because of a spec requirement, or just that they happen to be in memory in the one SessionStore implementation included in Scandium?

Thanks,

Paul

cc @kpalacz


Done!


Yes


@lucywyman can you look at this and make sure I'm on the right track before you leave?


Thanks. Partly included in commit 42100ca
Corrections to tests/date_api.test yet to be applied.


Ok, but if I have the same struct tag twice in my main struct, I'd expect to error out somewhere. Right now that will simply ignore the second field, correct?


что такое met?


:beer: :+1:


Pushed 69945a8.


Yes, sorry, I ended up leaving something out of my comment, but I did saw that they were just a signal just was wondering how Phaser know the difference between an up and a down if both are just a Signal


I fixed my OrangeGrove class so that it accurately counts all the oranges from the grove, completing the Lunch level.


productionToDSLCode seems like a bit of an overkill for an identity function.
it will even be incorrect if you upgrade it to return true string representation.

because somebody can write
var a = b
CONSUME1(a.BambaTok)
CONSUME2(b.BambaTok)

which (with improved DSL-->Code) won't have the same identity even though it should.

Consider separating the concerns of Identity and Error message building


для  того что бы не писать лишний раз комент в проге, можно просто назвать кнопку относительно ее действия  button_check_decrypt


Chang cen


Cool wäre es, wenn man hier so was wie std::endl zulassen könnte, aber hab leider nicht herausgefunden, wie man das abfragen kann bzw. man das selber implementiert ...


good job to check if a string can be converted into a float.
Consider the following two ways which may be neater
1. use try statement
try:
    float(element)
except ValueError:
    print "Not a float"

2. regular expression
import re
if re.match("^\d+?\.\d+?$", element) is None:
    print "Not float"


how can a result Arr of a groupBy be empty?


`mysql_config_editor` is only available in 5.6.6 which is also when they added the warnings.


Hmm, you're correct. Let me think about how to detect that while still allowing shadowing of embedded fields.


Nice back door dude!


I did not test it for long. neither I tested on OE 5.0. so I dont dare. I'd suggest users switch to beta.


Whoops, yeah. That one was meant to be without the suffix.


Muss hier eine Kopie erstellt werden oder kann man auf dem string arbeiten? (weil "const" und "&")


:void ?


copy paste error, thanks


I wonder why our versions are different? Further, if other users will run in to this disparity...


Fixed in the version that got merged


renaming it to a more specific name would remove the need for the comment?


@gabrielrios Yeah, I don't understand that either. I've tried to find out where they differentiate, but I've never had any luck in doing so.


test


don't make this public
you can still access protected in tests using <any>


This is interesting. What are you using it for?


But `reconstruct` is really leaving a bad taste in my mouth`.  I think this is much better handled by a copy assignment and move assignment, even if they are implemented in the same way.  Clients would say:
`rippleCalc_.mActiveLedger = lesCheckpoint;`
instead of:
`reconstruct(rippleCalc_.mActiveLedger, lesCheckpoint);`
And:
`lesSandbox = LedgerEntrySet(cache->getLedger (), tapNONE);`
instead of:
`reconstruct(lesSandbox, cache->getLedger (), tapNONE);`


I was wondering the same thing about that re: just a signal...


Also, if one entry contains invalid element, besides just drop this entry, we'd better print a warming stating that which entry is invalid


Test Case? (für einfache Werte geht's, an den Header Feldern ausprobiert)


Breaks with Carthage:

fatal: http://git.chromium.org/webm/libwebp.git/info/refs not valid: is this a git repository?


I'll probably be making similar comments as I did with Eric. Style nitpick: If one of the `fold` branches can fit on one line, we don't need to use braces. We should also return valid JSON for backbone's sake (it doesn't like when it's not)
e.g.
```
error => BadRequest(Json.obj("message" -> "Json request is not valid"))
```


this comment belongs here?


Top! :-)


Similar to above, the `NotFound` should include valid JSON so backbone doesn't freak out. Even if we don't really need to read it.


Hi, thanks for the feedback! I was just letting the code "settle" in my mind, before I review it and submit a PR. Along with your suggestion, some of the XML comments need tidying up (there's a couple of copy and paste errors). When I get a chance to do that I'll be sure to submit the changes back to you.


Try to reinstall dash and projectile. Previous code was also anaphoric. So `it` should not be a problem.


function return type signature


you have already declared that entry[index] != '?'. So the following logic did a jb.


I don't think this really returns string[]


Sure. Will do.


I've already changed this


Huh?


Similarly to `OK`, there are aliases for other status codes like `NOT_FOUND`, `INTERNAL_SERVER_ERROR`, `BAD_REQUEST`, etc.


I don't know if you throw an instance of this class if the stack trace will be ok.
I had issues with this. Check the Recognizer errors in recognizer.ts


Found it: https://github.com/photonstorm/phaser/blob/63c9d2e88082cef5b702260d463647e1e348f4e3/src/input/Keyboard.js#L341-L369

So, this onDown is just a reference to the callback that is called by the keyboard (or other input) when it process.


please go fmt the code here.


:shipit:


Unrelated to the cs changes. I just noticed. `float`, `double` and `real` should all be aliases. I'm saying you're missing `real `here. :)


oo another backdoor


too poor for your backdoor?


Ok, added a new commit to detect this error.


and boom goes the dynamite


that's worse what are you doing


I wasn't aware that PHP has a type named `real`.


Well, that seems OK


88737258-EPW-Ruby-Access (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (2184 of 2214 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.64%25-yellow.svg)


btw, how do you handle values like `-181` or `-91`? refs https://github.com/mapnik/mapnik/pull/2901


Yeh, it's an alias of `float`. :)


`noexcept` is the right choice here since `LedgerEntrySet` is supposed to be no-throw on construction.

I know how you feel about the bad taste but I specifically chose this approach to avoid needing a copy assignment operator. And this also removes one call site where a default `LedgerEntrySet` constructor is needed.

`reconstruct` is only a temporary step along the way to a bigger refactor of `LedgerEntrySet`. The correct fix is to change how `lesSandbox` is used in RippleCalc and PathState, I think by using `boost::optional` which allows the same behavior as `reconstruct` but without the oddness. That turns out to be quite a complicated change so I am submitting this pull request now, letting me move the jtx test framework forward until I come back to `LedgerEntrySet`.


`geojson` should be more specific, what kind of geojson feature? This function only works with featurecollections right? a variable name of `featureCollection` or `fc` would be more appropriate.


Commit local file HelloWorld.md


So here, too, instead of doing `embed: :id`, you can do:

```
class ArtistSerializer < AM::S
  embed :ids

  # ...
end
```


I don't think it helps much (and is 50% longer: we'd need a local variable for `clock` as well since that's where SetMaxOffset lives). If I were going to change this code I'd probably construct the slices with `make()` and use only indexing, not `append()`.


Ah, okay.


Yeah same here, you don't inline `embed: :ids`, it's

```ruby
class SongSerializer < AM::S
  embed :ids

  has_one :artist
end
```


good catch


I don't think this is a problem for us, though, right?


By the way, this commit and onwards, we are back to working code. You do get dropped into the debugger at the end of the main function, but that's on purpose.


@wkennington I second the "why?". The shared libs seem to build fine on Darwin. Is there some deeper reason?


тоже самое просто задай правильно имя кнопке и можно не писать комент


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.267](http://teamcity.monogame.net/viewLog.html?buildId=8242&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This commit breaks scans with positioners. `positioners` was in `kwargs`, which is passed to `_move_positioners` directly. Removing it causes `positioners` to be `None` in `_move_positioners`.


Rather than compare against the entire set of results, I would compare against one or two of them for each case. Having all of the results makes the file longer and more unwieldy, and makes changing the tests in the future more difficult. I would likewise recommend having smaller input data as fixtures, for similar reasons.

Tests should be as simple as possible while still testing the relevant functionality. As I see it, this gives three main benefits: they're easy to read and understand, they're easy to change and extend, and they run fast.


The lne.replace call is not working on Travis and I don't think it is working on Windows either. I'll confirm that one way or the other once I'm back on a windows machine.


Here is an example of a layered graph produced by "MTH353 Project visualization aid.nb."

![orbits5](https://cloud.githubusercontent.com/assets/12665864/8098198/848183f0-0fe4-11e5-817a-4501069f1332.jpg)

The edge labels indicate Weyl group type C permutations, which split the set of plane trees with five edges neatly into two self-contained orbits, one of symmetric plane trees and the other of asymmetric plane trees.


I would prefer this as a tertiary command if those of line 41 and 46 fail.

Furthermore, there should be some additional safety to prevent deleting existing directories on the SD card.


eek a remainder from the inspiring source


By default, the google icon on fontello is named `gplus`. We just need to make a note to use `googleplus` name every time we use fontello for social icons.

We may need to support a way to handle class name better, but this will do for now.


What about these?
http://fontello.com/#search=googleplus


UPDATED from original


> Which just leaves the BSDs in question.
>
> My reasoning there is:
>
> EV_OOBAND maps cleanly to POLLRDBAND
> POLLRDBAND is equivalent to POLLPRI
> Therefore EV_OOBAND can be used with EVFILT_READ when we want POLLPRI

On [FreeBSD](http://fxr.watson.org/fxr/source/bsd/kern/sys_generic.c?v=xnu-1699.24.8#L1497), `poll()` is implemented in terms of a kqueue; and they just map `POLLPRI` to `EV_OOBAND`.

Meanwhile, NetBSD doesn't seem to offer a method to poll for high priority data via kqueue **at all**. The only way seems to be falling back to `poll()`.


noted!


will do thanks!   yeah, still a work in progress.


Most of the time, Jesse and Will will choose icons from FontAwesome (don't know about other designers). Either rename one or choose a matching one, we still have to remember to do it. Not a big deal though.


Good, I look forward to that.

I built it and tried it and and I like it.  But expect a lot of respectful
debate with the team about details, before ultimate acceptance of your
feature.  My own contributions have gone through no less than that.

On Wed, Jun 10, 2015 at 9:43 PM, LBoggino <notifications@github.com> wrote:

> Thanks Paul for all the suggestions and ideas, I'll merge my changes with
> yours, polish everything a little bit and make the pull again.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LBoggino/audacity/commit/0c0280589308c8382820c39a265469ffc865b8a5#commitcomment-11624818>
> .
>


why not use ofpbuf_tail +  ofpbuf_tailroom as below?


Are you talking about line 94?  That was how I was setting the target of the player damage effect...it's supposed to be the controller of the creature.  I tried without line 94, but then repercussion didn't deal any damage at all.


似乎多上传了一个😨


New Bee!!


只是merge了一下而已


Last site I got from Will was using web symbols.  So it varies maybe?

On Wed, Jun 10, 2015 at 9:10 PM, Son Tran-Nguyen <notifications@github.com>
wrote:

> Most of the time, Jesse and Will will choose icons from FontAwesome (don't
> know about other designers). Either rename one or choose a matching one, we
> still have to remember to do it. Not a big deal though.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jlafitte/jQuery-BEShare/commit/582c280e9ea1d5af1c938f093e78df7aabcf4607#commitcomment-11625123>
> .
>


哦


task 1.4 of https://docs.google.com/spreadsheets/d/1N9xUqZQhignq7QM_7CtrV4zv86sq4lMdJj81IQuch3Y/edit?pli=1#gid=0


哎呀，糟糕，我上传的是储存前的东西，新加的没有


That would of been a pretty cool bug to abuse.


fixed in https://github.com/mesosphere/kubernetes/commit/72ef40903eb338325f9b52a56bf5381c173b267f


@pretyman Well I was wrong about terminology a little bit - I was talking about squashing all the changes into one big commit. Probably you can use [rebase -i](http://stackoverflow.com/questions/2563632) for this or combinations of `git reset` + `git commit`:

Settings:
```
autotools -> autotools branch of remote https://github.com/pretyman/hunter/
develop -> develop branch of remote https://github.com/ruslo/hunter
```

Update branch develop:
```bash
> git checkout develop
> git pull
```

Pick all updates:
```bash
> git checkout autotools
> git merge develop # make sure you have all the updates in your branch
```

Squash:
```
> git reset develop
# now your have all new changes uncommited
```

You can add them and commit again:
```
> git add cmake/*
> git diff --cached # verify
> git commit
```

See the result: https://github.com/ruslo/hunter/commit/6576413dbc41a20729b900451fbbebdf9b641e5f


confirm


Most of the HBase client Put methods take byte arrays as parameters:
https://hbase.apache.org/0.94/apidocs/org/apache/hadoop/hbase/client/Put.html
So to me it seems like that's the type we should use in HBaseFieldInfo.familyName and the fields of FieldInfo; similarly, the type of rowGetter should be Getter<Object, byte[]>. This gives us the maximum generality and all these calls to Bytes.toBytes() go away.

If FieldInfo is intended to be used in other places, the type of columnName should be parameterized rather than hardcoded as String.


hhc's first comment.


patch-1 (kamilzubair) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


use size instead of agent_state->hit_set_map.size() to avoid unnecessary recomputing.


The above block doesn't work. It is missing FAIL_REGEX "not supported".


Probably before he knew about fontawesome :)


This block needs to add -msse4 to the compiler flags.


This block needs to add -msse2 to compiler flags.


This block needs to add -mpclmul to compiler flags.


1605_unitary_system_fan (mbadams5) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.61%25-red.svg)


patch-1 (kamilzubair) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Seems like using valueType.name() might be idiomatically slightly better (though it doesn't matter in this instance):
http://stackoverflow.com/questions/13291076/java-enum-why-use-tostring-instead-of-name


after clicking 77 times for the recitals, it still locks the buy.. I'm thinking maybe cause you might be using float numbers and thusly it 77 smiles is not equal to the cost as it may be 77.x


chào cái khỉ j


rax retry tests


Cleanups: https://github.com/ruslo/hunter/commit/cd07f230775f2689df3e6185b3c00d1018756ba4


albert


I am not sure. I think this file just show us the structure of DB. Since we have already change one migration file name, I think we can commit this file.


Whenever you have an `if` expression without `else` expressions, prefer to use `when` instread. It conveys the semantic that you have no `else` which improves readability. This is the case for the `if` at line 18 and 36.


patch-1 (kamilzubair) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


hou jun,ok?


should be pool.info.hit_set_count - 1


Init variable: https://github.com/ruslo/hunter/commit/b83d6a75ac33cf8bccbdcf7961d4d4bbdf0238e6


Still needs textures and localization entries


patch-1 (kamilzubair) - Win64-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


I looked into the spec and it says "The values "true" and "false" are not allowed on boolean attributes. To represent a false value, the attribute has to be omitted altogether."

http://www.w3.org/html/wg/drafts/html/master/infrastructure.html#boolean-attribute

So unfortunately this will be required.


Merged


忽略该提交


I think we should contain hit_set_count items when osd do not creat new hitset.
trim -> reload -> trim -> reload is not necessary.


Oh woops, looks like the name of the commit was the squash message. Oh well!


duplicate?


rax retry tests


okok😂，sorry，我语文拼音不好，hou看成hon了直接脑补hong。。。

发自我的 Windows Phone
________________________________
发件人: HouJun11220033<mailto:notifications@github.com>
发送时间: 2015/6/11 10:36
收件人: Burning-Max/addressList<mailto:addressList@noreply.github.com>
抄送: LongYeh<mailto:llgtgx1@hotmail.com>
主题: Re: [addressList] houjun (1595ba2)

hou jun,ok?

---
Reply to this email directly or view it on GitHub:
https://github.com/Burning-Max/addressList/commit/1595ba2847eeb8613d2ef5a732adfa84a5438508#commitcomment-11625391


อันนี้งานใหม่ใช่มะ


Modified 2.2.8 branch for a personal server.


set(CMAKE_REQUIRED_FLAGS "-mpclmul")


Fixes #31


it seems like the cache isnt working right with groups


set_source_files_properties(${ARCHDIR}/fill_window_sse.c PROPERTIES COMPILE_FLAGS -msse2)


Umm, I don't think ksmserver requires kglobalaccel


set_source_files_properties(${ARCHDIR}/deflate_quick.c PROPERTIES COMPILE_FLAGS -msse4)


Ah yes, forgot about that. Neat...


set_source_files_properties(${ARCHDIR}/crc_folding.c PROPERTIES COMPILE_FLAGS "-mpclmul -msse4")


@RayzorDragon check this out...I wrote a PowerShell script to syntax check my php


Maybe we could just add a checking, look simpler like this:

```go
if len(statusParts) > 1 {
    resp.Status = statusParts[1]
}
```


haha,okok ,没事没事


Shouldn't you explicitly match null here? Otherwise you might accidentally and completely silently throw data away.


this is unnecessary since the type of min_read_recency_for_promote is unsigned int. so its value could not be negative, and the zero case has been covered by case 0.


This only works for accordion. It breaks tabs functionality.


yep, looks better :)

Slawomir Jasinski [swə'vɒmɪə jə'sɪnski]
[image: twitter] <https://twitter.com/slavomirj> [image: linkedin]
<http://www.linkedin.com/in/slawomirjasinski> [image: blog]
<http://www.spidersoft.com.au/?utm_source=signature&utm_medium=email&utm_campaign=sig>
 [image: facebook] <http://www.facebook.com/slawomir.jasinski> | Quote:
"When all else fails read the manual"

On Thu, Jun 11, 2015 at 12:52 PM, Tw <notifications@github.com> wrote:

> Maybe we could just add a checking, look simpler like this:
>
> if len(statusParts) > 1 {
>     resp.Status = statusParts[1]
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/slav123/caddy/commit/14b64fef43381ee0e9719b3f5e4f14a115c19b0b#commitcomment-11625546>
> .
>


@Oksisane Why are you not extending the Gamepad class?


> The following overview is pretty good

Ahh that's actually a really clear explanation - thanks :)


At some point we should change these. I suspect the global variable is not necessary.


Good catch!


Did you push the change so that this predicts "vector"?


@Oksisane @ethan-schaffer I'd like to set the convention that power is always a double that ranges from -100 to 100, not -1 to 1.  I'm saying this because the way Java does Doubles is sketchy and I don't like roundoff errors.  :smile:


testes


rax retry tests


Looks good. Good to pull once the predict change is pushed.


I suppose it depends on how deterministic wait_for_response() is.  If you trust it to always come up with a response without throwing an exception, then I'd argue this should work correctly.

I'm trying to hide the complexity of multiplexing from the coder.  Edge cases can get confusing for devs.  The parent Client instance will always maintain a reference to a Response object until it hits REQ_STATE_OK or ERR.  The edge case that will break the above code is when the wait_for_response() method sets a partial response AND triggers an exception but that exception is either a) not related to this request or b) is not a strong enough trigger to stop listening for the full response body.  In that case, the get() method will bubble the exception to the caller and the dev must somehow figure out that the exception was a weak signal and re-execute $client->wait_for_response($response->reqID) to completely download the response body.

This is why I was trying to hide this complexity inside wait_for_response() and only trigger warnings -- to make wait_for_response() similar in functionality to libxml or libcurl and make the dev ask for the errors instead of interrupting execution.  (obviously, I haven't written that part yet, just a design goal)


I wrote similar code for realtime quite recently, and chose to only do this if the keys were all strings. If the keys weren't strings, I changed the map into a list of key value pairs. I'm not suggesting you *should* do the same thing, simply mentioning the possibility.


## This is a markdown file


Yep.  Case of laziness/copy-pasta.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 58](https://teamcity.labkey.org/viewLog.html?buildId=254650&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 1 Build time: 00:17:24
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSUpgradeTest: <no details avaliable>

```


![screen shot 2015-06-10 at 7 58 15 pm](https://cloud.githubusercontent.com/assets/1269969/8098940/1f0b50f2-0fab-11e5-82ff-9bd010b22d1b.png)


Got thinking about this formula. I'm wondering if it is accurate. Wouldn't it be:
  double volume = (4 * Math.PI * Math.pow (radius, 3)) / 3; // calculate volume of a sphere


hm, seems weird to take this one out before you set num_planes, and not take out pix_mp.


I saw that consistency in the Client class.  I use PHPStorm as my primary editor and it auto-suggests the shorthand "int" for me.  ...and I like typing fewer characters.  So... yea.


do you have to keep repeating this? is there no way of pulling it out from the v4l2_buffer?


Please don't do this sort of stuff.
Sure add the log message, but needlessly nested code is ugly.


что такое met?


Yes.


:shipit:


Agreed.


I second @luvemil comment


no, that's ok. :shipit:


Now I'm working on implementing aformentioned ```get position->revert->invoke->detour``` pattern for those 3 methods that use ```GetRandomBuildingInfo```. If you're starting working on some feature, please, tell me what you're working on in order not to overlap too.


@lmignon @legalsylvain  can you explain me how can this be used on version 7?

I have a database where the module have not been installed and after install I could not find the way to execute this query for populate fields. Thanks in advance!


Note the rearranging of routes here, as it may affect current routes.


> I still don't think there should be distinction between general public and users. Unless you want to build an exclusive (rather than inclusive) service out of it.

:+1:


@jfoug "ntptojohn.py" should be all right, it was tested against real .pcap files.


No, not at least for rsync.  Suppose that I pseudotap, with rsync, `~/someuser/homebrew-foo`, so that my pseudotap is `Library/Taps/someuser/homebrew-foo`.  Now I edit (or delete) some formulas in `~/someuser/homebrew-foo`.  I want to sync these into my pseudotap.  So I simply `any-tap` it *again*, i.e., `brew any-tap someuser foo ~/someuser/homebrew-foo --rsync`, and rsync will pull in any changes.  This is impossible if we don't put the above condition on the `raise`.

The only alternative is to build this kind of thing into `brew update`, which I am loathe to do if we can help it.


no_raw_loops (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@vspinu Turns out Emacs on my machine is using a quite old dash.el, which is installed on the machine.  That version has --some? and --some-p but not --some.  I'll have to fix the elisp load order somehow.  Sorry for the noise.


Pour répondre à la question même si c'est fixé : `npm run deploy`


As requested in #17.


bitsPerSample == 16


PHP does not cease to surprise me :-) Go ahead and send a pull request. Thanks!


It is difficult to see that `lesEntries_` has a value in all of the function in PathState.cpp except for `expandPath`.  Some comments and/or asserts would be assuring.


Ok, I just added
error->set(TP_QT_ERROR_INVALID_HANDLE, QLatin1String("Could not process ID"));

I'll not force-push commit, to avoid a noise.


Done!


After thinking about this one more time, how about renaming this method to getBirthDateTime()?
Such that getBirthtime() is simply a getter for birthtime


no_raw_loops (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (351 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:+1: thanks


`EXPECT_NE(Join(...), Join(...))` ?


Here too.


What I'm saying is this: let's standardize on a name for the sake of this "global" config (`viewName` seems the most reasonable to me).  But if that name is confusing for a particular framework or environment, then that particular integration could look for a property that has a  different name.


I'm having a problem with the module lib.dateutil on the BluelivAlienvualtPlugin.py. It keeps telling me that I do not have the module lib.lib.dateutil. I feel their is something wrong with the coding.

Any insight?


You can drop this X and even `operator<(const C&);`, just the declaration with no body.


nice.


@kabobrocks I like this commit.


@mikegapinski BTW if possible, can you test and see if the accessory is still controllable when the iPhone is in Airplane mode?


Oh cool, I hadn't realized that. In that case, we may switch over.

Does `cli_util` respect `DART_SDK`? I'm not sure that's what we want to do here, since it's important that we end up pointing to the same SDK that the executable is running from.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 61](https://teamcity.labkey.org/viewLog.html?buildId=254741&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 25 Build time: 00:34:21
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

```


If only this were python


We need to add "-O3" to compiler flags, otherwise compression code runs very slowly...


You could combine them into a single eval-after-load using a prog block... Just a suggestion.


The [code standard for the project](http://wiki.apache.org/velocity/CodeStandards) states that both with and without spaces is allowed, but the preference is to not include these spaces inside parens. Could you change your code formatter to remove them?


No, I can't - it will cause another `static_assert` failure :(


Hello Colby

In the ApplicationController, I was trying to get the current_user to use
for customizing the display of the Upgrade and Downgrade links at the top
of the window. When I tried '@user = current_user' in the class, I got an
error. I read in Stackoverflow that it could be done this way. And it
worked.

What would be the correct way to do this?

On Thu, Jun 11, 2015 at 11:58 AM, Colby Aley <notifications@github.com>
wrote:

> hmm, what's the idea behind this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stephenwlott/blocipedia/commit/cb6db812bddd2eab116335b5caf0e88c8ff70219#commitcomment-11640656>
> .
>


I already gave a thumbs up, but this is what I had in mind for this refactor: https://github.com/seelabs/rippled/commit/b905f27e8b046906352bc453bd2b00f966eb46f8 I think that's equivalent to what's there now (but PathState always has a valid LedgerEntrySet).


The query is runned when the module is installed. You have nothing to do.


All that's left is a test to verify this fixes the bug :-)


Wow. Well, still, it should be safe to remove `int x;` and just `return true;` from the comparator, right?


@scottpurdy ping


You forgot to remove this.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.268](http://teamcity.monogame.net/viewLog.html?buildId=8246&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.267](http://teamcity.monogame.net/viewLog.html?buildId=8242&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 485, ignored: 6 Build time: 00:16:16
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.Visual.BlendStateTest.VisualTests: <no details avaliable>

```


It doesn't look like this is being used.


no_raw_loops (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (350 of 351 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


You might want to take a look at:
http://www.w3schools.com/js/js_conventions.asp
http://javascript.crockford.com/code.html
It's basic set of rules and conventions, we generally try to follow them at CC.
In most cases we use 2 spaces indentation and personally I don't think that 80 chars line length is important nowadays (just keep it reasonable or as readable as you can). Also, Crockford is a bit strict and I don't think that single var statement is that helpful. In general it's more about common sense rather than following every single rule, but most of them are quite useful.

JSHint is also very useful, you could try to keep the number of warnings close to zero:
http://jshint.com/
You can install it locally and integrate with your editor.

Thanks!


Ok :)


Hey @davidtkelleher, what do you think about this definition?


Using `<p>` doesn't introduce unwanted margins?


Hey, get on Slack :-)

And, as always, have a nice day!
Dima

http://dimakorolev.com/ | http://www.linkedin.com/in/dimakorolev |
dmitry.korolev@gmail.com | +1 (312) 593 2783

On Thu, Jun 11, 2015 at 1:16 PM, Maxim Zhurovich <notifications@github.com>
wrote:

> Ok :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mzhurovich/Current/commit/a4d69e364bceadba7cf3e029071f4d9849ba2dc2#commitcomment-11642132>
> .
>


Unfortunately there is OSM data that contains such illegal coordinates, but only in historical data, not current one. But this means I can't just rely on this not happening. There is the location.valid() call to check for validity. But the projection code doesn't check for this I think. I guess I have to add some more tests. :-)


Thanks.


Went from 14 minutes down to 5min.  5 minutes of test is not too bad!


Ah, of course. Sorry, I wasn't thinking clearly about `rsync` or `cp`. This only strengthens my earlier thought though:

1. First get the big change approved by Homebrew to accept directories without `.git`.
1. Then make separate external commands for `brew curl`, `brew wget`, `brew rsync`.

I might still have them default to bailing out if the directory exists. Maybe make the user add a flag `--update` if they know that they want to update an existing directory? Just a thought to protect users from accidentally copying over a directory of the same name. Maybe unlikely though.


This should be after
% cd social-feed-manager
Otherwise we would get following error as we are not in a git repository:
fatal: Not a git repository (or any of the parent directories): .git


@HowardHinnant @vinniefalco I left a comment in an outdated commit, but I think this refactoring would always give PathState a valid lesEntries_: https://github.com/seelabs/rippled/commit/b905f27e8b046906352bc453bd2b00f966eb46f8


cc @rafaelfranca @kaspth


I don't think there's a pressing need to merge this in today. I'd like to check out the code and do a quick once-over.


@jfoug yep, you also get usable bleeding-edge Windows binaries too! :)


Interesting idea.


added setValueAtIndex() method with your implementation.