ga niet deze shit doen


sprintf


I think that we can avoid this workaround (maybe extract the method `protected String getMimeType(routeContext, filename)` with the default implementatio `return mimeTypes.getContentType(routeContext, filename)`?)


wat is deze lege class onzin


Patch applied.

When breaking long lines across multiple lines, try to choose a break point that aids readability. A missing ';' is generally a poor visual clue that a line has been broken since people often ignore ';'.  Good visual clues include ending with an opening parenthesis: "...foo(" or an operator "...intValue +"


I don't get the meaning of this annotations. Correct me if I'm wrong, but these annotations are used for the endpoints, when you want to produce data. But our application doesn't  produce JSON on path pnc-rest/rest/build-configurations


:+1: I'm tidying up the targets, i'll make this change


The corresponding tests should be added to the itests project.


Is phpcs 2 backward compatible?


Why are these methods static? It should be probably CDI bean


Nah, doesn't matter, and I kinda prefer this style as it's the same as JSON.stringify output.


this


@NobodysNightmare you're right, of course.


Patch applied. Note that this isn't session caching but authentication caching within the session


maybe this can be clarified by indenting it?


Review done


No worries.  With that description I'm sure I can roll some Specl checks to make sure it stays unbroken!  Thanks!


Do we need to >/dev/null output from it?
Otherwise there is no possibility to find out what container was created and there is no way to stop it in some initialization script.


@GcySun Tabs again. Adjust your editor settings to avoid these kind of commits!


struct device_driver seems to have been introduced in struct xenbus_driver in kernel 3.3. If we plan to build against older kernels we need a macro to check the version.


*engrish* -> *english* :stuck_out_tongue:


Good thinking regarding errors. However, I regard this as more minor things since in 99% of cases validation happens client-side.
You should still implement notes as items that are cleared on submission, since the current way of doing it has many of these drawbacks as well.
Doing database manipulation if validation succeeds for all items is one way of doing it, but I don't particularly like it, since we didn't implement a "monkey form" (i.e. if validation fails for one item, the input for all other passing items is lost, it's not shown as pre-entered).

Maybe we should support "monkey forms" at some point in the future, but for now let's fix notes and submit items one-by-one. I think this is going to be a problem a lot less often than disappearing/unwilling-to-disappear notes.


that was intended ;)


It's recommended to also implement a != and override Equals so that all methods of determining equality are consistent.


rename to this.init


This unit test kind of defeats its own purposes. The dictionary code is not working. Here's output in ipython:

In [29]: geocoder.geocode({'postalCode': '80020', 'countryRegion':'United States'})

In [30]: geocoder.geocode('80020 United States')
Out[30]: Location((39.9208984375, -105.077003479, 0.0))


I think that we have some problems on multiple requests. Maybe I will introduce the `Resource` concept but for now it's safe to write in a file with a unique name (maybe via `File.createTempFile`).


:smile:


TAX
TAY


Wouldn't the  `edit_theme_options` capability make more sense here?


Since you reset metrics here, could you please remove TODO from line 91?

(it is not possible to comment there)


klpot, maar gaan we dan weer niet teveel overlap hebben tussen introductie en conclusie?


This is useful if you code in Perl with Moose.

This patch is to be used in tandem with ctags as so:

    ╰─± cat ~/.ctags
    --regex-Perl=/^[ \t]*method\s+([a-zA-Z0-9_]+)/\1/s/
    --regex-Perl=/^[ \t]*has\s+([a-zA-Z0-9_]+)/\1/a/
    --regex-Perl=/^[ \t]*enum\s+([':a-zA-Z0-9_]+)/\1/t/
    --regex-Perl=/^[ \t]*coerce\s+([':a-zA-Z0-9_]+)/\1/t/
    --regex-Perl=/^[ \t]*subtype\s+([':a-zA-Z0-9_]+)/\1/t/

then in your lib dir where your Moose classes are

    ctags *


Please use an absolute path constructed via require_once(dirname(__FILE__) . '../../.....')


Sorry i was meaning absolute pos for GameObject not relative one, it's the scroll that is relative to the plot type


```$calendarId``` was renamed


niet echt...
ik zal even moeten zoeken


This script has nothing to do with the stoney cloud, please use the correct copyright header


Probably but I can't change commit names now.


Why do you remove this? Does it still work without this line?


This is interesting !
Removing the comments shows the test is failing, even though it is the one test that proves the fnctl based locking works.
I don't understand the explanation given here - does it mean this would work if a different process would try to acquire a lock ?


Please add a short description on what this script does and how is one supposed to call it. According to our skeleton documentation header.


I still get the duplicate mapping errors for uuid. Can you look into it?
The package named saving does not seem to be line with our naming convention. Can you change it?


Done.


The original version works on a Sony Z3 running Lollipop.


This apparently doesnt work.. Needs fixing (duh)


does not work.. idiot


how about "generate-resources" lifecycle phase instead of "compile"?


Hey wunki! I'm getting a 404 at that url for the 10.1 box :(


My  mistake - these shouldn't have been comment out.


There are links to activate plugins in the welcome screen.


Для названия предложу такие варианты: "Изучите цикл for" или "Изучите цикл for в JavaScript"


They have been in the subsequent commit: https://github.com/shamser/HPCC-Platform/commit/620293c96566cca2954c60fe45cf968bc474dfc9


`drupal_get_path('theme', 'ocelot') . "/assets/js/vendor/modernizr$js_extension" => array(),`


`$js_extension = '.js';`
`$js_extension = '.min.js';`


Ah, sorry - missed that!

On 23 June 2015 at 11:27, James Koster <notifications@github.com> wrote:

> There are links to activate plugins in the welcome screen.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/woothemes/storefront/commit/ef07ea0296e054241725d20c58259ea723aa727a#commitcomment-11813303>
> .
>


Revert: https://github.com/Verlihub/verlihub-1.0.0/commit/5e3f898a00e14bbb33c6489c7c1b575179a151fd


The date is given to the function through an argument in line 319 https://github.com/owncloud/tasks/blob/13f88a7b3e5eb4a7b718762ed6a113b33fd68c4a/service/tasksservice.php#L319
The params function is deprecated!


Эту строчку можно сделать чуть проще: "Давайте узнаем побольше о циклах, которые используются практически во всех программах - цикле for и цикле while. Начнём с цикла for."


these make this change a bug fix.


Ich vermute, sie wollen echten Javadoc-Style: https://en.wikipedia.org/wiki/Javadoc


This gets done if you use the `.editorconfig` file and plugin in your editor anyway :wink:


Yes, but it is no ```DateTime``` object, so i think the correct replacement would simply be
```php
$date = new \DateTime('@'.$date);
```


Both the java and the Maven plugins are applied by the Forge plugin.


Forgot to uncomment here!


Good addition though for the guys who don't install [editorconfig](http://editorconfig.org/#download) :+1:


No need for this anymore :)


buggy somehow, not getting rendered. can confirm?


Did you try SHIFT selecting multiple rows? Without this the browser attempts to select text.


Yeh was a problem for the backend guys running the grunt task without using sublime


Just set it to LevelDB, it will always be the right one depending on what could be imported.


@richardkchapman  My personal observation was that I found "without generating archive" confusing. There is no implication of it's scope and the word 'without' leans towards a more global scope, i.e. this option is propagated beyond just eclcmd, i.e. it doesn't just apply to the 'sending of'. It implied that it would overwrite the eclserver option 'createArchive'. Now  that I understand how everything works, regarding this, I see that you can make easy sense of it, however that is not the case when you remove all(or at least most) prior-knowledge and perspective - which is the primary audience base for the usage text. For example you have to use 'ecl run -v' to even observe that the default is to generate and send as an archive. So the 1st interpretation of that usage text is that the ecl is sent to hpcc as text (as normal) and that no archive is generated, where ever it would have been generated, i.e. there needs to be an 'instead of' or 'rather than' to relay the replacement of the two methods and that it relates to the sending of.

Perhaps -
Send ECL query to HPCC as text rather than as a generated archive
but I'm curious of you perspective on how a "generated archive" is different from an "archive"?


This can stay as it was.


Ok.


Done in subsequent commit: https://github.com/shamser/HPCC-Platform/commit/620293c96566cca2954c60fe45cf968bc474dfc9


Ok


chmod: cannot access ‘{/opt/genymotion}/genymotion/genymotion/gmtool’: No such file or directory


this breaks sites upgrading from older versions to current master (and consequently the next release)
i'll add another upgrade step that adds the setting to the registry.

@rnixx how can we improve the development process/workflow of bda.plone.shop in a way that problems like this occur less often?


Also: You are making the database a static attr instead of setting _leveldb = LevelDB and then instancing with _leveldb() on the constructor so it can be overriden from the tests. We want to override which class to use to open the database, not the actual database used across all instances of that class (also remember this is now used for two different stores)


Same with all self._db -> _db


This is for debugging purposes only, in case there's a problem with the dictionary or if there's a bug in the code that makes it look for tag that's not there.


One other inconvenient is loosing the ability to use `ng-class` to switch between different icons. But this case currently occurs only a few times in our templates.


@dalgaaf, what if the return val is `1` which indicates the success?


Preposition vs. article (adjective). I think that's the rule I settled on for titles from the beginning.


Will revise.


Does this include also when 1-line is return and throw?


Service locator is no better than `new` IMHO. :-1: Use a dependency injection framework like [guice](https://github.com/google/guice)


In `tests/`, I think we should at least wait until the syntax has been used for documentation of `Base` for å while.

I don't think the interactive features that `@doc` provides (will provide)  is especially attractive for a dummy range type in a test anyway . In my mind `@doc` is for documentation of APIs and should be meaningful without reading the code. Comments is for explaining the implementation when it isn't obvious what the intention of some code is.


Indeed, conventionally the so version is used for ABI versioning and I did
that for libfm-qt.
Most libraries I know follow the libtool versioning scheme, but it does not
seem to be mandatory.
It's good if we can follow the convention by setting correct ABI versions.
Without that, however, things can still work.

On Tue, Jun 23, 2015 at 5:33 PM, palinek <notifications@github.com> wrote:

> Doesn't the .so version express the the ABI compatibility? Why should it
> stick to QT version? IMHO it's best to change it manualy every release (if
> it's needed).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lxde/libqtxdg/commit/e80152a921c71956a110a05a73a2b9eb0e7822b1#commitcomment-11812466>
> .
>


Wow. Amazing amount of code removed! *claps hands*


primer títol (prova de comentari)


Actually Corrected to Version 4.11!


idd, dat is precies wat ik gisteren zei :unamused:


The overridden method says:
Returns list of analyzed tokens with additional tags, or {@code null}
so I was just following the pattern.


snprintf is safer


I don't trust env vars on windows. I've just reintroduced jna so we don't use reg query anymore. Please give a try to the next hourly build


Line is too long. [106/100]


Line is too long. [115/100]


Method has too many lines. [14/10]


Line is too long. [119/100]


Line is too long. [118/100]


Align the elements of a hash literal if they span more than one line.


Extra blank line detected.


Extra empty line detected at block body beginning.


Line is too long. [105/100]


windows in general allows forward backslashes too.


-> which is good because if you then use forward slashes your coafile will also work on windows.


I understand policy fix, but don't understand tmpreaper deamon. I don't think this is a good idea. If you don't use some deamon for while, logs are untouched some time and then this deamon delete it? Hmm... Simon, do you have AVC related to this?


I think the way you decided to implement ligature support in svgicons2svgfont with streams makes this commit redundant. However, I’m not sure how else to modify the glyph metadata before being passed to svgicons2svgfont.


Looks good :+1:


@hone Yes you need to supply your own oniguruma.
We can't build cross oniguruma since we can't know which target triple to build.


Great :) :+1:


whut


Use the es6 arrow function syntax:
`(columnNumber) => {
    return (player, index) => {
`


This makes it harder for TortoiseGit to find the usr/bin directory.


Yes, it works.


I thought it was better to have Luna on m2e 1.6: most people will still be using Luna and I imagine would have updated to m2e 1.6, which is available as an update for this release.


Line is too long. [106/100]


Line is too long. [115/100]


Line is too long. [129/100]


Method has too many lines. [14/10]


Line is too long. [128/100]


Line is too long. [118/100]


Extra blank line detected.


Line is too long. [105/100]


Could you reformat this part of code, please. According to [Google Java Style](https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s2.3.1-whitespace-characters) Tab characters are not used for indentation


why `hasTheWorld` and not `to`?


can we reuse `result` to hold the error code? and check it instead after the for loop?


Here is Tab characters again


I think it's ok, look here: https://docs.jboss.org/resteasy/docs/3.0-beta-3/userguide/html/RESTEasy_Client_Framework.html#d4e2049


True! Just dumb copy-pasting. I'll move that to the layout.


hjk


diagram


I would call it ger_rotation_matrix, or get_rot_matrix or so.


A better solution would be to use a (flex box layout)[https://css-tricks.com/snippets/css/a-guide-to-flexbox/]. Then no column width based arithmetic will be necessary in the render function.


@sabberworm the fact glyphs are emitted here is not intended to modify them, it it jsut made to generate HTML/CSS etc...

Ligatures are handled at the filename level. See https://github.com/nfroidure/svgicons2svgfont#cli-interface and the icon.unicode description.

To programmatically change the ligatures, you'll have to add a custom gulp plugin between your gulp.src and your gulp.iconfont streams to change the file names accordingly to your own logic. If you do so, please PR the gulp-iconfont README to mention it.

Or, you can name your files to have the exact behavior you want ;).


thanks
don't know why I missed this.


The thing is that people also use LT as a library and they usually don't expect a library to print out stuff to stderr. So I think this should only happen in a debug mode or it should be commented out.


But in my tests, no glyphs are emitted.

> On 23.06.2015, at 13:01, Nicolas Froidure <notifications@github.com> wrote:
>
> @sabberworm the fact glyphs are emitted here is not intended to modify them, it it jsut made to generate HTML/CSS etc...
>
> Ligatures are handled at the filename level. See https://github.com/nfroidure/svgicons2svgfont#cli-interface and the icon.unicode description.
>
> To programmatically change the ligatures, you'll have to add a custom gulp plugin between your gulp.src and your gulp.iconfont streams to change the file names accordingly to your own logic. If you do so, please PR the gulp-iconfont README to mention it.
>
> Or, you can name your files to have the exact behavior you want ;).
>
> —
> Reply to this email directly or view it on GitHub.
>


optional*


Yeah, I have updated this now to reflect that its not configurable - it's a new commit but same PR so diff still at: https://github.com/jbosstm/narayana/pull/875/files


I guess so - I always use curly braces, there are no exceptions.


+1, but might be worth noting that it needs to be the app user's home dir (if they've not used `alaveteli`)?


How different are your tests from this code https://github.com/nfroidure/gulp-iconfont/blob/master/tests/tests.mocha.js#L115 ? Oh, i see, it lacks a s, it seems indeed redundant.

What a messy release, 3 issues already :/.


And why not emit an event where you can change the metadata? Otherwise any user wanting to add stuff to the metadata will have to re-implement the svgicons2svgfont filename parser logic.


@Kirben

shouldn't `elvira2_pc_sfx.zip` from http://scummvm.org/games/#elvira2 linked in Datafiles section too ?


Ah ok. I didn't know it ;-)


are you sure :smiley:?


Done.


I had thought of keeping it consistent with the file. Those spaces seemed weird to me too, but I thought that coding style fixes should be made on a different commit.

I'll fix it.


Not urgent, and maybe something to add to the backlog for a second release: but it'd be nice to move the HTML out of the JavaScript code.


This deletes ```picture``` regardless whether or not it is found in ```d->blocks```. Is it by design or just a mistake?


Yeah, I debated that but didn't in the end as we reference `alaveteli` earlier in the `SuExecUserGroup` clause


ACK.


__Can't build under debian 7.x (32b)__

## build log

states/state_width.cpp: In member function ‘etl::smach<studio::CanvasView, studio::EventKey>::event_result studio::StateWidth_Context::event_mouse_handler(const etl::smach<studio::CanvasView, studio::EventKey>::event&)’:

**states/state_width.cpp:524:43: error: no matching function for call to ‘min(float, etl::clock_base<etl::clock_desc_gettimeofday>::value_type)’**

states/state_width.cpp:524:43: note: candidates are:
In file included from /usr/include/c++/4.7/bits/char_traits.h:41:0,
                 from /usr/include/c++/4.7/ios:41,
                 from /usr/include/c++/4.7/ostream:40,
                 from /usr/include/c++/4.7/iterator:64,
                 from /usr/include/glibmm-2.4/glibmm/ustring.h:29,
                 from /usr/include/gtkmm-3.0/gtkmm/dialog.h:7,
                 from states/state_width.cpp:34:
/usr/include/c++/4.7/bits/stl_algobase.h:187:5: note: template<class _Tp> const _Tp& std::min(const _Tp&, const _Tp&)
/usr/include/c++/4.7/bits/stl_algobase.h:187:5: note:   template argument deduction/substitution failed:
states/state_width.cpp:524:43: note:   deduced conflicting types for parameter ‘const _Tp’ (‘float’ and ‘etl::clock_base<etl::clock_desc_gettimeofday>::value_type {aka double}’)
In file included from /usr/include/c++/4.7/bits/char_traits.h:41:0,
                 from /usr/include/c++/4.7/ios:41,
                 from /usr/include/c++/4.7/ostream:40,
                 from /usr/include/c++/4.7/iterator:64,
                 from /usr/include/glibmm-2.4/glibmm/ustring.h:29,
                 from /usr/include/gtkmm-3.0/gtkmm/dialog.h:7,
                 from states/state_width.cpp:34:
/usr/include/c++/4.7/bits/stl_algobase.h:233:5: note: template<class _Tp, class _Compare> const _Tp& std::min(const _Tp&, const _Tp&, _Compare)
/usr/include/c++/4.7/bits/stl_algobase.h:233:5: note:   template argument deduction/substitution failed:
states/state_width.cpp:524:43: note:   deduced conflicting types for parameter ‘const _Tp’ (‘float’ and ‘etl::clock_base<etl::clock_desc_gettimeofday>::value_type {aka double}’)


Not urgent, and maybe something to add to the backlog for a second release: but it'd be nice to move the CSS out of the JavaScript code.


Will you create a pull request after with your commits? :)


Well done but check the linter


I prefer to use = instead of ~>


Could you move this method to new resource class? Not to change the existing [test](https://github.com/t1/swagger-core/commit/d87cd2b24ebf2378453e17ca40bf62e2456280bb#diff-da347ab3605afe72c833ff6ff98efb34R18). Also it would be great to add test with both hidden and non-hidden params.


It would be interesting to add the properties of the other modules


The problem of emitting an event is that you can't do any asynchonous operation, if you really want such feature, it would probably be better to have an option to pass a an asynchronous callback containing the glyphs metadata.

I thought about it while creating this file https://github.com/nfroidure/svgicons2svgfont/blob/master/src/iconsdir.js , it could be replaced per any other logical unit with an option to https://github.com/nfroidure/svgicons2svgfont/blob/master/src/iconsdir.js#L12

Let's talk about it there https://github.com/nfroidure/svgicons2svgfont/issues/38.


The `reply(true)` is just true for `plugin.user.confirm` and `plugin.user.confirm.changeUsername` hooks. You've changed the `server.api.plugin-request` hook. It needs to be defined like hapi defines it.


That will broke compatibility...


It would be good to review the indentation :)


Some comments


개인적으론 기존에 클럽에서 하던것처럼 가입 수락 절차가 좋아보임
확인 질문같은 보통 한번 정하면 잘안바뀔거 같은데 그렇게되면 누군가는 모르는 사람이 들어올 일말의 가능성이 생기지 않나 싶음. 물론 모르는 사람도 들어오는걸 환영한다면 괜찮겠지만 ㅋㅋ
아 그리고 commit message는 자세하게 써줘 ㅠ
난 github 이 싸이트로 밖에 못봐서 뭐바꼈는지 볼라면 커밋 다들어가봐야함 ㅋㅋ


ur a faggot


Bootstrap isn't included so col-md-3 won't have any effect. We should put a responsiveness item in the backlog, but for now, just use a maximum width of some sort with word wrapping.


I did a quick code review prior to our team code review. Please take a look at my line comments.


This feature is in planning phase.


Sorry! I forgot to check the build. I'll fix it.


@dannyroberts you might wanna take a note of this. I have removed this in favour of another test that I added to catch a bug, I kept the latter, as it does more coverage and properly resolves the merge conflict. Here's the test [commit1](https://github.com/dimagi/commcare-hq/commit/47f27cedc51c67c8938b5e0ed0a2dfc01d640eaf) [commit2](https://github.com/dimagi/commcare-hq/commit/b7068bf9ae18a4caabaac377f30e0731f9a7f95a)


Usually yes, but here you are also moving the file so you can fix the wrong spaces.


We could add pessimistic versioning here (`~> 2.17.2`), so that when `bundle update` is run we update to the latest patch version (`2.17.3` but not `2.18.2` for example).


혹시 시험삼하 Test해보는 용도로 commit 하는 거면 fork 해서 써줘 ㅋㅋ
아 그리고 commit 좀 더 자세히 써줘.
"bootstrap 관련 JS script 추가 및 index, userlist, adduser page 적용."  뭐 이런식으로 ㅋㅋ


:+1:, please fix this issue


Do you really need to catch Exception and not StandardError?


En mere elegant løsning er at hacke Surf så der ikke er scrollbarer.

Det plejede vi at gøre, dengang alting var bedre.


I mean breaking the line, not moving the file...


:+1: +1.

It's a pity @ryanflorence doesn't seem to be going to maintain this...


Would `perform(tag_id)` be clearer here?


TeamCity OsmSharp :: GitHub - OsmSharp [Build 1035](http://build.osmsharp.com:8080/viewLog.html?buildId=5015&buildTypeId=bt16) is now running


On 2015-06-23 04:23:21, Troels Henriksen wrote:
> En mere elegant løsning er at hacke Surf så der ikke er scrollbarer.
>
> Det plejede vi at gøre, dengang alting var bedre.

Så gør det.


Is this the same as `MainstreamBrowsePage.all`?


We really need a better API for this (in the new URL module for example) so that the escaping doesn't have to be done by the user of the API.


Could these be added to `spec/support/sidekiq.rb` instead.  That'll make future RSpec upgrades easier.


I am not sure if StandardError will catch exceptions from Celluloid. I can try :)


so on the command line one still have to provide magic numbers?


:+1 for DRY-ing this


short version: yes

long version: yes very much.. on our side there are no errors. It's just a method to mimic what we get from api.


What could be the problem with package org.openmrs.module.chartsearch.saving; ?


Maybe defining this inside `publishing_api_notifier_spec.rb` or using the factory directly would be easier. You wouldn't have to know/lookup what `browse_page("d")` means.


Yeah, definitely the WhirlyKitElevationChunkProtocol was a dirty hack


We already have modules that save data. Have you seen any with such a
package name? :)

On Tue, Jun 23, 2015 at 2:27 PM, k-joseph <notifications@github.com> wrote:

> What could be the problem with package
> org.openmrs.module.chartsearch.saving; ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-chartsearch/commit/4896e738d848a07ce301a48569f78ffc600753ad#commitcomment-11814184>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


@elliotwoods
Aww, I liked the Digital Emulsion moniker... But Rulr is shorter.

Can't I just pull the changes? Or would that likely screw up my local fork?


The Open Source Intel HD Graphics VA driver does not support color space flags in VPP. I am sorry.

(BTW, the heuristics for selecting BT.709 vs. BT.601 was slightly different in the AMD driver but I won't give the details) :)


It should, Celluloid exceptions are based on StandardError:
`Error = Class.new(StandardError)`
https://github.com/celluloid/celluloid/blob/master/lib/celluloid/exceptions.rb


Not 100% sure about this, but did you consider using the sidekiq testing helpers for this as well? That would make these tests no longer dependent on the internals of `PublishingAPINotifier` (`: send_to_publishing_api`).


@wkyoshe What about the case "USE_SHARED=OFF" ?
And that won't produce dynamic library
please read it
http://www.cmake.org/cmake/help/v3.0/command/add_library.html


why references instead of objects?


Hm this change isn't really necessary. Could you please revert this.


Is it intended that the lock file remains, or is it part of the *UNIX IEEE Std 1003.1-2001* ?

One problem I see here is that the test-cases create files that they never remove, which can affect other tests or possibly themselves.


nodeboxのカッコ省いても大丈夫なんですね…知りませんでした(^_^;)


That's fine. People will see the line notes, porbably :)


I don't think we need this anymore since we are running these manually in line 9 and 10.


이번 커밋은
1. celery 및 redis 설치 (설치 방법은 고빈섭 강사님 자료 150513.pdf p.18)
2. redis-server 실행
3. celery worker 실행 (python manage.py celery worker --events)
4. sample_celery_run.py 실행 → 20이라는 결과 반환
이 순서로 진행하시면 됩니다. (혹시 저처럼 헤매는 분이 계실까봐)


I understood you preferred one single opaque class in Maply layer instead of to make a high-level mirror of Whirly classes. It's ok for me


This is the wrong indentation. Could you please fix this.


this breaks upgrades to GS profile version 3 in case 20 is not selected as available VAT in `IShopTaxSettings.vat`

```
2015-06-23 13:32:00 ERROR Zope.SiteErrorLog 1435059120.80.213967118272 http://localhost:8441/Plone/portal_quickinstaller/prefs_reinstallProducts
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module Products.PDBDebugMode.runcall, line 70, in pdb_runcall
  Module ZPublisher.Publish, line 48, in call_object
  Module Products.CMFCore.FSPythonScript, line 127, in __call__
  Module Shared.DC.Scripts.Bindings, line 322, in __call__
  Module Shared.DC.Scripts.Bindings, line 359, in _bindAndExec
  Module Products.PythonScripts.PythonScript, line 344, in _exec
  Module script, line 11, in prefs_reinstallProducts
   - <FSPythonScript at /Plone/portal_quickinstaller/prefs_reinstallProducts>
   - Line 11
  Module Products.CMFPlone.QuickInstallerTool, line 101, in upgradeProduct
  Module Products.GenericSetup.upgrade, line 175, in doStep
  Module Products.GenericSetup.tool, line 365, in runAllImportStepsFromProfile
   - __traceback_info__: profile-bda.plone.shop.upgrades:2_to_3
  Module Products.GenericSetup.tool, line 1119, in _runImportStepsFromContext
  Module Products.GenericSetup.tool, line 1030, in _doRunImportStep
   - __traceback_info__: plone.app.registry
  Module plone.app.registry.exportimport.handler, line 49, in importRegistry
  Module plone.app.registry.exportimport.handler, line 94, in importDocument
  Module plone.app.registry.exportimport.handler, line 320, in importRecords
  Module plone.app.registry.exportimport.handler, line 218, in importRecord
  Module plone.supermodel.utils, line 134, in elementToValue
  Module zope.schema._field, line 373, in fromUnicode
  Module zope.schema._bootstrapfields, line 182, in validate
  Module zope.schema._field, line 389, in _validate
ConstraintNotSatisfied: 20
> .buildout/eggs/zope.schema-4.2.2-py2.7.egg/zope/schema/_field.py(389)_validate()
-> raise ConstraintNotSatisfied(value)

```


Just realized what -o- is. -o is write to file and the last - is to redirect to stdout.


@jscp does this fix any known issue?


Note I used a different algorithm than was used in the original code. It is not clear to me which is the better algorithm. With only one example it is difficult to tell.


getSettingsNonStaticTrlException()


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.4.0.1035](http://build.osmsharp.com:8080/viewLog.html?buildId=5015&buildTypeId=bt16) outcome was **SUCCESS**
Summary: Tests passed: 542 Build time: 0:0:0


Wrong indentation too


Yeah, definitely the WhirlyKitElevationChunkProtocol was a dirty hack


Please, for each commit, if applicable, refer to the related issue.


fixed, thanks!


OK, I need to explain what I wanted to do.

I had implemented some feature for supporting Unicode in PDF bookmarks as in ba4e7ed8fa1ead17077d169b66442a2346302158 and sent a pull request to Simon. Simon accepted it with some changes; the problem happened here. I just don't know how to treat such situation properly. The change I made to my branch was different from that was made to Simon's. To make my branch up-to-date with the upstream repository, I simply tried to revert my change and then to incorporate changes made to upstream to my fork. I think I did something wrong there.

What I am now wanting to do is to clean up things. I am using GitHub for Windows mostly with GUI. Command line tool is also available. I don't know if there are variation to git command but

     $ git --version
     git version 1.9.5.github.0


Most of those, i have looked at store in the root package like: org.openmrs.module.chartsearch, which i don't feel lie doing!


typo.
You do not have tried it on your side.


@wpillar using thephpleague link here


Call client.connect directly without the anonymous function


The typo is more in the 'keep' to me.
The 'and' is not necessary, see https://en.wikipedia.org/wiki/KISS_principle


Yes, that's by design.  IIRC the special behaviour is only for editables.


Ta!


@pedro Why not use rspec?


Had we all better upgrade to 1.10.4 then?


Ok, thx. I will fix it. You can pass the commit :)


this is becoming irritating


This was needed to get the tests running against OpenMRS 1.12.x (master). It could cause an issue when trying to run the module with other versions of OpenMRS (but it might not).


I'm pretty sure this is place track. I have already implemented this function and called it place_track. I would have thought GAME_COMMAND_3 is place track piece. And 47 is place actual track (td4/6).


@forresst you were right about the weird character. That was messing things up. I have fixed this in 0.10.17. Thanks!


```
Console.WriteLine(fileContents.Input());
```
って書けた方がスマートな気がするのは私だけでしょうか？


Yeah indeed it's much easier to find.


Hi Cheng,
Thanks for the quick update. I wonder if it is possible to allow auto detect user location without setView?
Cheers


コメントへの返信はGitHubのコメントで返してください。
コミットのコメントは変更点を書きましょう。


ACK. I was following a rule of adding two indent tabs when a line has to be broken. It seems though that it's a common sense to align the parameter list to the first one - and indeed that enhances readability.


If you are creating your functions then they should be prefixed otherwise they will conflict with other code. Please prefix `sanitize_textarea()` and `sanitize_default_layouts()` too.

You might want to use [`sanitize_text_field()`](https://developer.wordpress.org/reference/functions/sanitize_text_field/) instead.


I like to say, that I find the naming unconventional now. From what I've read and seen so far, it should be addXXXListener(XXXListener) (without "Event" in the name).


typo: libvir**y**-sandbox-init-util.c -> libvir**t**-sandbox-init-util.c


Hey Juan!

Thank you. Good idea. I am in holidays and when I am back, I will add it :)

Great to see people using *Feeling Responsive* and adding features.

All the Best, mo.


I really have no idea how to use this lib... Can you give a simple and explain how will the each of paramenter work?

```
//rc.send(0,267715,24,185,1)    --GPIO, code, bits, pulselen, protocol,
static int ICACHE_FLASH_ATTR rc_send(lua_State* L) {
  const uint8_t pin = luaL_checkinteger(L, 1);
...
  platform_gpio_write(pin, 0);
  long code = luaL_checklong(L, 2);
  //const uint8_t bits = luaL_checkinteger(L, 3);
  uint8_t bits = luaL_checkinteger(L, 3);
  const uint8_t pulseLen = luaL_checkinteger(L, 4);
  const uint8_t Protocol = luaL_checkinteger(L, 5);
  const uint8_t repeat = luaL_checkinteger(L, 6);

  NODE_ERR("repeat:%d\n",repeat);
...
```

There is difference between your definition and program, fix it...


a bug fix for rbd lock.


The package named saving just does not sound right. Does that mean anything
to do with saving activities is to be in that package?

On Tue, Jun 23, 2015 at 2:35 PM, k-joseph <notifications@github.com> wrote:

> Most of those, i have looked at store in the root package like:
> org.openmrs.module.chartsearch, which i don't feel lie doing!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-chartsearch/commit/4896e738d848a07ce301a48569f78ffc600753ad#commitcomment-11814325>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


testing comment


bonjour tout le monde


test


Done in master as 2ca04d07d2bc625e5d71efee44ea6dbe4bfe13d3 and 1.9.x as 947f4c5942322db98441744ccb6ade32b426a58e.


Thanks. Per https://github.com/micropython/micropython/issues/1225#issuecomment-114465157 , I posted to python-ideas mailing list to find a suitable way to solve this issue.


Test


bla bla bla


digigi


@petebacondarwin Thank you. I can do a small patch in the README_fr_FR.md ;-)


@fblundun does this commit make sense?  The IP being passed to the collector payload is "unknown" if the IP is null and a random uuid string for the partition key.  Does the partition key need to be a random IP Address instead?


lgtm


doesnt this make the line useless?


ZupID should be ZupPath


@tvsonar is this file still required?


Nice to have this fixed! Now there are 4 repeated blocks of code that are almost identical apart from the event type. Could you refactor that into a common function parameterized by event type?


Triple strings are good for this sort of thing. :smile:


thank you


@tvsonar do we actually need this? IMO the EndToEnd folder should not have been added to Git in the first place, and so i don't see why they would need to be ignored


you can keep the yum update but installing dependencies should go in the user defined bootstrap. you might as well add these bits to a separate file and read it in during these preliminary local development.


See Android-DFU-Library for more changes.


Thanks mat!.
They are not repeated blocks of code but in independent files(core and photon) and different function calls.


this is a functional change that probably was worth a ticket


var callback = priv.generateClentCallback(client, callback);
client.watch(callback);


Well, in the case where the token exists, the subsets could be used to re-build the new set with the token deleted in O(1).  So `splitMember` does both remove the token and give us the information whether it was in the set in the first place.

But perhaps I am missing something.  Also: don't care enough to spend more time on this.  (-:


Just been looking at the spray source and it looks like your check for null
ips won't work because spray represents an absent IP using https://github.com/spray/spray/blob/master/spray-http/src/main/scala/spray/http/RemoteAddress.scala#L26 rather than null. (So really that ticket should be renamed...)

Other than that it looks good - using a random UUID should work for the partition key.


Tabs


Yeah, it's the new policy.


it fails with
```
  1) test nested keywords (MongoTest)
     test/mongo_test.exs:58
     ** (EXIT from #PID<0.165.0>) an exception was raised:
         ** (MatchError) no match of right hand side value: {"title", <<2, 0, 0, 0, 120, 0>>}
             (mongodb) lib/bson/decoder.ex:118: BSON.Decoder.list_elems/3
             (mongodb) lib/bson/decoder.ex:113: BSON.Decoder.list/1
             (mongodb) lib/bson/decoder.ex:100: BSON.Decoder.doc_fields/2
             (mongodb) lib/bson/decoder.ex:95: BSON.Decoder.document/1
             (mongodb) lib/mongo/protocol.ex:145: Mongo.Protocol.decode_documents/2
             (mongodb) lib/mongo/protocol.ex:120: Mongo.Protocol.decode_reply/1
             (mongodb) lib/mongo/protocol.ex:71: Mongo.Protocol.decode/1
             (mongodb) lib/mongo/connection.ex:268: Mongo.Connection.new_data/2

13:59:39.611 [error] GenServer #PID<0.166.0> terminating
Last message: {:tcp, #Port<0.5690>, <<81, 0, 0, 0, 12, 129, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 8, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 45, 0, 0, 0, 7, 95, 105, 100, 0, 29, 28, 6, ...>>}
State: %{auth: [{"mongodb_test", "mongodb_user", "mongodb_user"}], database: "mongodb_test", opts: [backoff: 1000, port: 27017, hostname: 'localhost'], queue: %{1 => %{command: :find_one, from: {#PID<0.165.0>, #Reference<0.0.0.1565>}, params: nil}}, request_id: 2, socket: #Port<0.5690>, tail: "", timeout: 5000, wire_version: nil, write_concern: [w: 1]}
** (exit) an exception was raised:
    ** (MatchError) no match of right hand side value: {"title", <<2, 0, 0, 0, 120, 0>>}
        (mongodb) lib/bson/decoder.ex:118: BSON.Decoder.list_elems/3
        (mongodb) lib/bson/decoder.ex:113: BSON.Decoder.list/1
        (mongodb) lib/bson/decoder.ex:100: BSON.Decoder.doc_fields/2
        (mongodb) lib/bson/decoder.ex:95: BSON.Decoder.document/1
        (mongodb) lib/mongo/protocol.ex:145: Mongo.Protocol.decode_documents/2
        (mongodb) lib/mongo/protocol.ex:120: Mongo.Protocol.decode_reply/1
        (mongodb) lib/mongo/protocol.ex:71: Mongo.Protocol.decode/1
        (mongodb) lib/mongo/connection.ex:268: Mongo.Connection.new_data/2
```

\cc @ericmj


We need to fix that ...


This is one InlineJS too much ...


This is not necessary in all of the files ...


@rnixx not sure what's the best way to handle this edge case:

the workaround: adding 20%  in the registry editor `Plone/portal_registry/edit/bda.plone.shop.interfaces.IShopTaxSettings.vat` does not work (the widget is empty - i don't know why!?)
![vat-settings1](https://cloud.githubusercontent.com/assets/1120517/8305339/555c8bb4-19ae-11e5-8b17-04bdb3a44ea7.png)

A) to not set the value in the upgrade step at all. people will notice/find out that the setting is missing when they run into an error.

B) the upgrade step could choose the first, last or random value that is present in the bda.plone.shop.vocabularies.AvailableVatVocabulary

C) we could use the `AvailableVatVocabulary` vocabulary  for `IShopShippingSettings.shipping_vat`
This way we could be sure 20 is a valid value (although the siteadmin decided it should not be available :-( )


No worries I will go back to the toOption.  I got rid of it initially because if the IP object was genuinely null it threw a NPE.  But their way of handling it makes sense!


FYI - latest master now has support for mp4 clipping. URL format is the same as HLS/HDS clipping - /clipFrom/<millis>/clipTo/<millis>


Missing link? Do we really need to add a dependency on another tool?


The player crashes, when one try to load statistics file.


would be ideal to return `EINVAL` if the `preadv()` and `pwritev()` are seeing an `iovcnt` less than ZERO.


thx :+1: @dkhamsing


See http://www.phpinternalsbook.com/classes_objects/serialization.html for more details


@slash13 Done.


@rottegift That's a very good point.  The "fairness" algorithm is not always desired, for example, if the goal of adding a new top-level vdev is to gain IOPS and the existing ones (top-levels) have plenty of free space but much less relative to the new on (vdev).  You can set ```metaslab_bias_enabled=0``` to disable the metaslab group biasing algorithm in these cases.


shouldn't this be called `rawId`, since it is `:: UserId`?


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Saved down these commands when I started if they'd be useful here?

mkdir myapp
cd myapp
rvm use ruby-2.2.2@myapp --ruby-version --create
gem install rails --no-document --no-ri
rails new . -T --database=postgresql


Woop!


I'd rather hardcode forward and backslashes directly and not using os.sep anymore because who knows if os.sep is forward slash because that would also be valid? Also a comment would be nice.


https://github.com/netguru/access/blob/master/app/models/google_integration/api.rb#L179 it is already fixed. Please accept it :)


aa


// TODO: Check for input, make sure it is a valid gitlab hook, check repo and branch are correct


// FIXME: Change to use repo


Hi Dan,
for each context, I suggest to add in the class doc the URL to the appropriate page from the MySQL manual describing the keywords.


@edekruif  again : tabs


Would have been nicer to refactor this line to use the ``$escapetool.url(map)`` (in order to avoid calling ``$escapetool.url(string)`` for each parameter name/value).


That was temporary workaround (there was common file with non-inlinable `fn` fun call). Will remove commit.


Why should it need to find the `usr\bin` directory if it finds the `bin` directory already?


fixed


I wrote this:

```haskell
userIdFromPath :: MonadError ThentosError m => Path -> m UserId
userIdFromPath (Path s) = do
    uri <- either (\ e -> throwError $ MalformedUserPath (cs $ show (s, e))) return $
        URI.parseURI URI.laxURIParserOptions $ cs s

    rawId <- maybe (throwError $ MalformedUserPath s) return $
        stripPrefix "/principals/users/" (cs $ URI.uriPath uri)

    maybe (throwError NoSuchUser) (return . UserId) $
        readMay rawId
```

This type-checks, but `MalformedUserPath` could take its arguments in a more readily available form now.

Is this an improvement?


The usr/bin directory needs to be on the path for (libgit2) hooks.


I just realized that attempting to delete the newly created file might actually introduce some sort of race. Nonetheless I wonder if it would be a useful feature to have it clean up after itself, at least as an option.


Yes, ``getURL()`` should take the query string parameters as a map not a string.


Is it building for you?  I have to change every reference from asus/moorefield/fhd to asus_moorefield/fhd.


I have changed it to rather; org.openmrs.module.chartsearch.cached


>>> how can we improve the development process/workflow
actually we need to implement one ;). Development within b.p.shop was not that strict until now, but it seems time to tighten the process.

If we follow some basic rules we should be safe:

* Avoid pushing to master, if you do, be sure you know nothing breaks.
* Use Pull requests, do not merge them on your own
* Provide upgrade steps if necessary.

@jensens @thet @agitator Everybody agrees?


The production import is marked with a comment that we actually don't want to import snap modules here.  Could you flip it so that both modules use the variant from `Network.HTTP.Types.URI`?


Final newline missing.


Trailing whitespace detected.


Method has too many lines. [12/10]


Spec path should end with `github_integration/user*_spec.rb`


Line is too long. [129/100]


Line is too long. [112/100]


Line is too long. [110/100]<br>Space missing after comma.


Line is too long. [101/100]<br>Space missing after comma.


Space missing after comma.


No problem, thanks for the good work. But line https://github.com/owncloud/tasks/commit/13f88a7b3e5eb4a7b718762ed6a113b33fd68c4a#diff-65491d4538236f0aefd53ec50520c3f8L193 has to be changed too I think ;)


Line is too long. [111/100]


Line is too long. [105/100]


Align the parameters of a method call if they span more than one line.


Assignment Branch Condition size for list_groups_with_members is too high. [16.31/15]<br>Method has too many lines. [12/10]


Line is too long. [102/100]


Align the elements of an array literal if they span more than one line.


Inconsistent indentation detected.


Unnecessary spacing detected.


Redundant `begin` block detected.


Use `fail` instead of `raise` to signal exceptions.


Unused method argument - `group`. If it's necessary, use `_` or `_group` as an argument name to indicate that it won't be used. You can also write as `privacy_diff(*)` if you want the method to accept any arguments but don't care about them.<br>Unused method argument - `expected_group`. If it's necessary, use `_` or `_expected_group` as an argument name to indicate that it won't be used. You can also write as `privacy_diff(*)` if you want the method to accept any arguments but don't care about them.


Missing space after #.


Assignment Branch Condition size for list_groups_full_info is too high. [19.21/15]<br>Method has too many lines. [12/10]


Extra empty line detected at class body beginning.


Assignment Branch Condition size for list_groups_full_info is too high. [16.31/15]<br>Method has too many lines. [12/10]


Use a guard clause instead of wrapping the code inside a conditional expression.


Let's go all the way and change the values to respect the convention we've established-  `TASK_EVENTS_DELETE` and `TASK_EVENTS_DELETE_ERROR`


Can you describe the category of classes to go in this package?

On Tue, Jun 23, 2015 at 3:17 PM, k-joseph <notifications@github.com> wrote:

> I have changed it to rather; org.openmrs.module.chartsearch.cached
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-chartsearch/commit/4896e738d848a07ce301a48569f78ffc600753ad#commitcomment-11814960>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


This one is just in progress, becouse there is still some bug in dataweave, so it is not the final version.


It's a bit weird to modify code that you're going to remove completely in the next patch. As a reviewer, I'd rather avoid having to spend time and energy reviewing this change if it's going to disappear anyway. If you have a way to avoid this change, that would be better. Otherwise, perhaps explain the situation in the commit message.


THAT is a patch hunk I like :-).


Oh, I've forgotten this..


Thanks for your answer. So for now, when going the "RGB path" as of missing mesa functionality, there is _no_ way of getting colors right?


Mmm, ok, but how?


xstrdup?


Fine by me


test


I would keep only:

     expectedEffortVector = thrusterMatrix * cmdVector;


POJO accessed and used by ChartSearchCache class to store, edit and delete search history, bookmarked searches and notes added to a search


Yep, thanks. That's what happens when I write code in slides.


I would keep the svd for the thrusterMatrix only, since we don't need it to calculate the expectedEffort.


Avoid re-wrapping unmodified text, it makes the diffs painful to read.


`os.path.splitext`?


Why drop 'lexicographic'?


Looks good


You don't want to delete the README! @lhofer


Sync'ed with Jitsi's 20th June 2015 code checkin.


probably s/object/commit/


probably s/object/commit/ too.


likewise.


We usually do not use past tense. So cache would be more in line with our
convention than cached

On Tue, Jun 23, 2015 at 3:26 PM, k-joseph <notifications@github.com> wrote:

> POJO accessed and used by ChartSearchCache class to store, edit and delete
> search history, bookmarked searches and notes added to a search
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-chartsearch/commit/4896e738d848a07ce301a48569f78ffc600753ad#commitcomment-11815117>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


Looks good.


The Issue (Firefox has stopped working with two options a)check online and b)close the program) still exists when we run through ANT.

Problem signature:
  Problem Event Name:	APPCRASH
  Application Name:	firefox.exe
  Application Version:	38.0.5.5623
  Application Timestamp:	5563b224
  Fault Module Name:	xul.dll
  Fault Module Version:	38.0.5.5623
  Fault Module Timestamp:	5563c343
  Exception Code:	c0000005
  Exception Offset:	0033d04b
  OS Version:	6.1.7601.2.1.0.256.48
  Locale ID:	1033
  Additional Information 1:	0a9e
  Additional Information 2:	0a9e372d3b4ad19135b953a78882e789
  Additional Information 3:	0a9e
  Additional Information 4:	0a9e372d3b4ad19135b953a78882e789

Read our privacy statement online:
  http://go.microsoft.com/fwlink/?linkid=104288&clcid=0x0409

If the online privacy statement is not available, please read our privacy statement offline:
  C:\Windows\system32\en-US\erofflps.txt


function calls ends up calling itself and cause a crash. here are the relevant log snippet

 B_h, W_i, B_h, B_h, W_i, W_dense5, B_dense5]), ('rho', 0.95), ('gsum_regularization', 0.0001), ('method', 'SGD')]
INFO:deepy.trainers.trainers:Added 0 free parameters for optimization
INFO:deepy.trainers.trainers:network updates:
INFO:deepy.trainers.trainers:learning updates: B_h B_h W_i B_h B_h W_i B_h B_h W_i B_h B_h W_i W_dense5 B_dense5
Traceback (most recent call last):
  File "experiments/basic/word_pos_rnn.py", line 62, in <module>
    trainer.run(batch_set.train_set(), batch_set.valid_set(), controllers=[annealer])
  File "/home/arun/legolas/dl/deepy/deepy/dataset/mini_batch.py", line 38, in valid_set
    if not self.valid_set():
  File "/home/arun/legolas/dl/deepy/deepy/dataset/mini_batch.py", line 38, in valid_set
    if not self.valid_set():
.
.
.
.
.
  File "/home/arun/legolas/dl/deepy/deepy/dataset/mini_batch.py", line 38, in valid_set
    if not self.valid_set():
  File "/home/arun/legolas/dl/deepy/deepy/dataset/mini_batch.py", line 36, in valid_set
    if not self.origin.valid_set():
RuntimeError: maximum recursion depth exceeded


ATM yeah. I wouldn't mind changing this to "magic strings" instead which are at least readable.


You are right. It is the best way, and the way it was at the very
beginning. (Although the regular expression at that time was complicated
and broken)

Am 23. Juni 2015 2:10:14 nachm. schrieb Lasse Schuirmann
<notifications@github.com>:

> I'd rather hardcode forward and backslashes directly and not using os.sep
> anymore because who knows if os.sep is forward slash because that would
> also be valid? Also a comment would be nice.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/coala-analyzer/coala/commit/b1e45499a7d32a87a8c2b1015b3a250963bc629d#commitcomment-11814831


`filter(Lecture.name == lect['name'], Lecture.subject == lect['subject'])` or even `filter_by(name=lect['name'], subject=lect['subject'])`


No, since it is a completely optional add-on for improved sound effects.


Commit message is incorrect.


Although this approach is pretty universal and we *know* what is.sep is on
the supported platforms

Am 23. Juni 2015 2:10:14 nachm. schrieb Lasse Schuirmann
<notifications@github.com>:

> I'd rather hardcode forward and backslashes directly and not using os.sep
> anymore because who knows if os.sep is forward slash because that would
> also be valid? Also a comment would be nice.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/coala-analyzer/coala/commit/b1e45499a7d32a87a8c2b1015b3a250963bc629d#commitcomment-11814831


Тестовый комментарий


write that it is optional


Ещё один комментарий


Bakit ganito ito?


Тынц


Crazy indentation here. The sub-parts of the query should be one single tab extra indented.


haha :D


well we have the universal approach in the else branch, this one's windows specific.


Yes, possibly, though by the time this check fails nearly no work has been done. As anyone can send big packets to an IP that are then ignored, it may be that the additional complexity isn't really worth it.


Crazy indentation here. Everything should be tab (rather than space) indented. The sub-parts of the SQL query should be one single extra tab indented more than the start of the query.


B sounds appropriate to me

^^ @jensens @thet @agitator


So, there are no tests, right?


parameter 'page' seems to be needless here.


`const`


replace all var with let


is now officially documented


вывод списка в файл, N - количество строк, 1 - начиная сверху, 0 - начиная снизу


this adds the new functionality ...


> but it has already been dereferenced on all paths leading to the check.

yeah, `new_session()` will crash before it reaches here. if it fails to create a `MonSession`.

i'd suggest we move the `assert()` from to `MonSessionMap::new_session()` instead.


If array is empty


Вот учишь их учишь

https://docs.docker.com/articles/dockerfile_best-practices/#sort-multi-line-arguments


See above


Not sure why Ovidiu's change is part of the pull request.


Aqui não precisava da função `ucfirst`. Na verdade não precisava do PHP. Podia estar solto mesmo no HTML. Mas sem problema. :+1:


Would recommend @toggleProperty('hideAccepted')


новая строчка


начало файла


So this is instead of `/draft-services/<string:framework_slug>/create`, right?


typo.


@jongreenall maybe some sort of default value?

``` javascript
  .timeout(timeout || 1000)
```
or we can assume it's covered by superagent?


Oh, so you would keep os.sep there?

Am 23. Juni 2015 2:36:42 nachm. schrieb Lasse Schuirmann
<notifications@github.com>:

> well we have the universal approach in the else branch, this one's windows
> specific.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/coala-analyzer/coala/commit/b1e45499a7d32a87a8c2b1015b3a250963bc629d#commitcomment-11815322


Hey , r you going to merge this ? Do i need to add something else before merge ? I'm kind of needing this enhancement at work .. :)


yeah, that's no linux branch, thats just "not windows"

2015-06-23 14:46 GMT+02:00 Fabian Neuschmidt <notifications@github.com>:

> Oh, so you would keep os.sep there?
>
>
>
> Am 23. Juni 2015 2:36:42 nachm. schrieb Lasse Schuirmann
> <notifications@github.com>:
>
> > well we have the universal approach in the else branch, this one's
> windows
> > specific.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> >
> https://github.com/coala-analyzer/coala/commit/b1e45499a7d32a87a8c2b1015b3a250963bc629d#commitcomment-11815322
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/b1e45499a7d32a87a8c2b1015b3a250963bc629d#commitcomment-11815496>
> .
>


@lucasdemarchi I think we don't necessarily need to try to take the semaphore until we're sure that we have new data available, huh?

If we're using GPIO for data-ready, we should try taking the semaphore only if we really need to call ```_read_data_transaction_g()``` or ```_read_data_transaction_a()```.


You could also call the functions `a` for "activation". Sigma could indeed be a tad confusing (but it's not a big deal).


Unfortunately I don't think I can use from as a keyword argument; that's what I tried initially.
On Jun 22, 2015 10:37 PM, Erik Rose <notifications@github.com> wrote:There's no need to break off all the "params" and add indirection for the kwargs that are always there. You could do something like this:

return jsonify({'redirect': url_for('browse.',
                                    _anchor=line,
                                    tree=tree,
                                    path=path,
                                    from=query_text,
                                    **({'case': 'true'} if is_case_sensitive else {}))})

Or break off just the case_kwarg if the above is too nested for you.

—Reply to this email directly or view it on GitHub.


It'd be nice to have a comment explaining why the formula begins on January regardless of when consensus was achieved. I mean, I do think that it makes it easier for everyone to understand and reimplement the formula, but a quick discussion of why it's done this way in the comment would be good.


Well, js file, that contains `sum` definition is not used in test run, so if test result is `OK` then `sum` was inlined (otherwise it would undefined function call).


hey @alexischr adding colours is great, thanks! However, with these recent commits, whenever I get a build failure I don't get the error in the output, I just get something like:

```
Building (arch: darwin-32)

	@	export CC="$CC -arch i386"

	@	export CXX="$CXX -arch i386"
(bockbuild warning) arch_build() got an unexpected keyword argument 'defaults'
(bockbuild error) Failed build at ./gtk+-3.16.2.problem
 Run "source ./BansheeDarwinProfile_env.sh" first to replicate bockbuild environment.
```

How to get the exact error? Thanks


nice! i know someone that needed this :-)


Hello
How are you ?
You know i tried to add new directory - i use insert => directory but it doesn't let me to insert new name and  path .
Also it will be realy nice to import header :)
Thanks !


Thank you :)


I am not very happy with this function.
Maybe it could be something like:

```
static int filter_pattern_match(struct ref_filter *filter, const char *refname)
{
    if (!*filter->name_patterns)
        return 0;
    if (filter->match_as_path)
        return match_name_as_path(filter->name_patterns, refname);
    return match_pattern(filter->name_patterns, refname);
}
```


Sure!


Je ne suis pas 100% chaud pour ça, mais le rendu typo est nettement meilleur


On n'en profiterait pas pour virer la border-bottom du tabs ?


Otherwise, :+1:


Please provide the proof that you're a using the version that includes this fix (it is not released yet).


Added a few assertions https://github.com/typeinference/kotlin/commit/ec1930c2dff627c30f953b8794681a78b965a76c


알겠습니다!


Please document the meaning of the number that follow each keyword.


raising the stakes: turn of your alarm in 60 seconds, else the end of the world


@mpinsky They aren't the same. The deleted line 286 was the same is Spring. The added Lines 287-290 show the calculation for which strata were observed in all years. The Fall has a few less strata, but some of the strata in the fall were not used in the spring (i.e., the strata in either season are not all elements of the strata of the other season).

Does this clarify things for you? They aren't the same, and I programmatically identified which strata to use, rather than listing them out manually.


i think we always have a valid `s` pointer here. the only two caller of this function are in `Monitor::_ms_dispatch()`. and we can ensure that the message being handled is a `CEPH_MSG_PING`, which has been dealt with, thus the function has returned before reaching here.

so, does an `assert(s)` help in this case?


Wouldn't it look better without the parenthesis:
```
reviewIsGood: Ember.computed 'grade', ->
  @get('grade') == 'good'
```
or is this a convention you use in the project?


에공 이런식으로하면 안돼~ bower 쓰는 게 훨씬 낫다


Ok


Yes you're absolutely right, it's not exactly my best choice and it originated from a somewhat stupid decision as well (I just wanted to have a place to link to directly so that ppl had the latest APK from the latest commit). Plus, since I've been using tags+releases because F-Droid checks those for updates I have no need for the apk's inside of the repo at all anymore. I will have a look at RepoSurgeon for this, if you can give some pointers on the parameters to use in order to safely remove the /apk folder out of all the commits, that would be even better. Thanks!


Ouais, y'a plus les bordures, on peut les virer (si je me souviens bien)


Perhaps with `return 1` instead of `return 0`.


it is, but I'm sending the children first then the parents to help avoid a parent page being updated before a child page and potentially 404ing


And here you could call the function like that:

```
if (!filter_pattern_match(filter, refname))
    return 0;
```


fixed


This doesn't mention anywhere that these are java commands and need java on the path or JAVA_HOME set


'My must'...?


Thanks, I just replaced my bootstrap-datepicker.js with your and it is working fine

Thanks :)


This introduces a new consensus rule that isn't mentioned in the BIP? It probably should be.


you may use the comma separated approach to avoid the extra testing of the log level and evaluation of the parameter when logging:
LOGGER.debug (arg1, arg2, arg3 etc....)


Should have referenced #1504 instead of #1502.


Added comment:
        // Piecewise-linear-between-doublings growth. Calculated based on a fixed
        // timestamp and not the activation time so the maximum size is
        // predictable, and so the activation time can be completely removed in
        // a future version of this code after the fork is complete.


Worth mentioning that you have to do this first? the jar installer will fail if pre-req features are missing I think


Fixed the case with constant.


Faudrait qu'on teste un peu du floor() par endroit, ça pourrait nous éviter quelques surprises je pense.


Again, you'll need to make sure the necessary features are installed


nkjnj


"tarball"?


I've moved it to MIT license. Let me know if that's ok.

Going through your changes and comments now.


I was thinking the same thing this morning, although I think a separate BIP just describing the new rule would be better (From Bip 1: "It is highly recommended that a single BIP contain a single key proposal or new idea").


You need other features in the liberty server beside this. For 8.5.5.5 core edition, servlet-3.0 etc would be there by default, but that isn't going to be true for the 8.5.5.6 zip packages.


fixed


[<pattern>...] is duplicated above.


OOC is this a standard better approach (generally or in c* code)?


Here we're: https://ng-messages.github.io/views/inbox

That should work entirely offline in Nightly and latest Spark build (with enabled SW) once service worker is installed and both inbox/conversation views are visited at least once to allow SimpleOfflineCache to cache resources.


Ack. It's not a hard dependency, it just pulls the git logs from the latest tag into the file and adds a timestamp which makes it then easy to format the release.


If you check the ticket description you can see that it talks about History screen and History tab. History tab is visible to users as tab on the right side when they are editing the chapter. "Restore" button inside that tab should also not be visible if users do not have that permission.


Hi Steve, It is good to write such a method, it will be very useful. However, I would advice to take some time and understand how to write a method. There are certain steps which are compulsory, you can check any method written by David, Danny, Fred, Fanuel, Abib ... and you will be able to identify those steps. I would also advice you visit the files Climate_data_refclass.R and Climate_refclass.R to know more about the different lower level methods available and also try them on climate (data) objects. This will help you to write methods better. All the best.


@dbolkensteyn I use it sometimes when I want to generate everything in one step. Similarly, I use the release_local.bat when I generate the nuget package. (Which I didn't do at all during this sprint)


Shouldn't hello be capitalized?


`convertArgumentsToStringList` usage in `AbstractJetDiagnosticJsInlineWithRemovedLib`


i don't think the null check is required. `FileUtils.closeQuietly(..)` is null friendly.


I think hello should be capitalized


LARS will install into any 8.5.5.x Liberty. This is not obvious at the moment. installUtility won't work on 8.5.5.5 and lower (its not there!), 'java -jar' should work but you would need to use featureManager to get the mongodb feature. Unzip should work on anything, again, you'd need featureManager to get mongo feature.


What the heck is this?? JulianDay is not part of the MoonPhase? nor is dayOfTheYear??


this commit not work when generating recurring invoices, return model not id
```
124 - return delivery.property_account_position or partner.property_account_position
124 + return delivery.property_account_position.id or partner.property_account_position.id
```


Pre-populating forms after validation in such things is quite standard thing to do. Didn't know it was not implemented. I tried to do this in some follow up commit. Needs more testing though. https://github.com/cyriltata/formr.org/commit/680cfa860b93409d0cd7b6091af053b1772b0de6


LGTM


overall a big +1 but ...
... sorry, unless there are good enough tests written this does not make a big difference. Review may help to not break things, but is no guarantee.
Currently working with the shop stack is like a night flight in the fog without compass and radar.
There are too many dependencies by inheritance and ZCA impossible to oversight.


If you modify the spec to this, does this pass?

```ruby
  # TODO: Correct description text on line below
  it "should add the remove an entry to the address book" do
    book = AddressBook.new

    book.add_entry('Ann A', '555-123-123', 'aa@aamail.example')
    book.add_entry('Bobby B', '555-456-456', 'bb@bbmail.example')
    book.add_entry('Carol C', '555-789-789', 'cc@ccmail.example')

    book.remove_entry('Bobby B', '555-456-456', 'bb@bbmail.example')

    expect(book.entries.size).to eq 2
    expect(book.entries.first.name).to eq 'Ann A'
    expect(book.entries.last.name).to eq 'Carol C'

    book.remove_entry('Ann A', '555-123-123', 'aa@aamail.example')

    expect(book.entries.size).to eq 1
    expect(book.entries.last.name).to eq 'Carol C'

    book.remove_entry('Carol C', '555-789-789', 'cc@ccmail.example')

    expect(book.entries.size).to eq 0
  end
```


PHPCS: Whitespace found at end of line


we should put the menu back into the loop for efficiency as @hoholee12 said earlier with a commit.
also I discourage the use of automatically killing background apps, comment it out lol instead maybe we can make it apply a strong lmk profile. :)


// TODO: Check for input, make sure it is a valid gitlab hook, check repo and branch are correct


I'm aware. Thanks


// FIXME: Change to use repo


Better remove the goal invocation `attach-artifact` altogether (along with the whole plugin reference). Causes the artifacts to be attached twice (see the output of the install goal). Worse it causes them to be uploaded twice on deploy.


@amanpwl92 remove commented part


TODO: Undo this replacement, or remove entirely


@Sunilkumarr appendUrl


Comentando el commit


Actually I didn't want to add them to Date directly, we can rename that and I am thinking moonPhase doesn't belong here.


@Sunilkumarr code not formatted, no space before and after =


First steps to solving #1


Right there: https://github.com/GNS3/gns3-gui/blob/unstable/gns3/topology.py#L725


I have been informed that content-store is far more robust: https://github.com/alphagov/content-store/blob/master/doc/content_item_fields.md#links

I'll get it changed to `all`


Looks fantastic! Swift is amazing. Great job!!


I see you changed that to a computed property as we discussed on #emberjs, nice :+1:


it would, thanks! :)


Кнопка "Показать разделы" и название сайта в панели навигации должны отображать только для мобильной версии, для всех остальных - они должны быть скрыты.

![2015-06-23 16 09 20](https://cloud.githubusercontent.com/assets/1649877/8306704/c82736bc-19c2-11e5-914d-aaf1934b323c.png)


最初のtheは"the SLC"のつもりで書いたのですが間違ってますかね？


You need to check it out as:

  <project name="CM-zenfone2/android_device_asus_moorefield_fhd" path="device/asus/moorefield/fhd" remote="github" />

in a local repo manifest.


判断语句不直观，应该写成boolean isRight = ....


Can module be null?


<project name="CM-zenfone2/android_device_asus_moorefield_fhd" path="device/asus/moorefield/fhd" remote="github" />


it's a nice idea to create attr_readers for accessing instance variables.


感謝 @jasteralan 修正，剛剛急忙修改忘了下面也要修改。


fixed


Thanks for the tip.


> where attributes are array of elements

This is not correct according to the current main spec. Attributes may either be an object or an array of member elements. This means the example below is not correct at the moment.

Action: Define how this is used in current context of current attribute definition in spec or propose new attributes definition for Refract spec.


it doesn't impact the standard view until you make modifications to the less variables that manage corners.   For example,  I change the following in "variables.less" file in bootstrap 3.3.4  ( note - this is prior to the addition of  btn-border-radius-base, but the problem exists for that case as well ) :

-@border-radius-base:        4px;
-@border-radius-large:       6px;
-@border-radius-small:       3px;

+ @border-radius-base:       4px;
+ @border-radius-large:       6px;
+ @border-radius-small:       10px;   // my change

this creates a "gumby" kind of look where the border curves are asymmetric..

![image](https://cloud.githubusercontent.com/assets/7736675/8306758/81b2872a-1988-11e5-971b-9a2f6b71aa36.png)


I don't think it can, in practice. Just making Guava happy until we rewrite this class in Kotlin.


in any case doing right would need active choosing, guessing may fail. but B at least breaks least.


might be removed....


Denne comitten får følgende test til å feile:
Scenario: Se på eksemplarer knyttet til verk


What is this about?


This change has landed, can we close this pull request please?


After voucher confirmation, riba list must be paid


Ok, I understand. It feels cleaner to me too.

> we know `defaultProps`, `statics`, `mixins`, etc. will always be defined as static class properties, no?

I'm not working in ES6 and I am not very familiar with it yet, but for now I've seen 3 different patterns:

ES6 instance property :
```js
class Hello extends React.Component {
  // ...
}
Hello.displayName = 'Hello';
```

ES6 class method:
```js
class Hello extends React.Component {
  static get displayName() {
    return 'Hello';
  }
  // ...
}
```

ES7 class property:
```js
class Hello extends React.Component {
  static displayName = 'Hello'
  // ...
}
```

In second case the method type can be `static`, `get`, `static get` or none. In third case the property type can be `static` or none. The `static` type does not seems to be mandatory.

However, I'd really like to come out with a good default configuration for ES5/ES6 classes, with method type support if needed.


Ah, I didn't experience it when I changed them via the Customizer with modified variables and built a local demo that used the vertical button group. Fundamentally I agree with you @sdwarwick, I just didn't experience that behavior (which I was expecting to). I made the PR because I don't know why mine didn't do that and as such I don't trust what mine built even though it checked out in regards to values of the resulting CSS


The static modifier is redundant for enums, as inner enums are static by default.


-1 Não use '#', use javascript:void(0)

http://stackoverflow.com/questions/134845/href-attribute-for-javascript-links-or-javascriptvoid0


Hmm. Depends whether the proposal is "the january hard fork" or "block size change". Well, up to you, I have no opinion on one BIP vs two.

Could you note in the chain params section where the timestamps are defined that it's not _only_ block size that changes on that date.


It worked, but not sure. Changed from c_char*65 to c_char_p (null terminated string) to see if it works, this is the right way.


@jorisvanoers sjiek of nie


Insira um for no label referente ao seu input.


block.vtx.size() > nMaxBlockSize is a little odd. I know this code isn't new, but we're comparing a vector length against a byte size here, which intuitively *looks* buggy even though it's just an optimisation shortcut.

As there is a defined min byte size for a valid transaction, perhaps it should be multiplied by that instead to ensure both sizes of the comparison are in bytes?


actually the main problems are due to missing upgrade steps, so this can easily be checked.

and referring other changes, yes, unless there is a good test suite, changes need to be done with care. There are anyway people with a good oversight on the stack, just avoid more than one change at once.

And yes, changes and effected features also need to be checked at least once by hand in a browser. Automated tests do not discharge you doing this :)

Last but not least - tests stubs are there in all packages among some concrete tests. Any help improving the situation is appreciated.


Yes, it is needed, because the ClosureCleaner makes sure that the SourceFunction is serializable at building of the graph (not at execution).


Does this test work or not? If yes, why the comment/


You know how I :heart: static accessors.  :)


@title-fonttype deveria ser @title-font-type seguindo a convenção de nomes separados por '-' que já vem utilizando.


LOL!! Nah, I think you should leave this :)


Why are you checking if res !=0? Haven't you already select only the author with level > 0 before?


Should this be a function of MAX_STANDARD_TX_SIZE rather than a magic number? At least explain where 4000 came from.


What's the output of `-Dquasiquote.debug` for this quasiquote? The change above doesn't look right.


Вот это как-то плохо сделано. Не понятно откуда взялись и почему именно `163px`? Без свойства `display: block` это вроде бы вообще не имеет смысла.

На мобильных телефонах меню должно превратиться в своего рода трёхколоночный макет:
1 колонка - кнопка "Показать разделы", фиксированной ширины;
2 колонка - ссылка с названием сайта `.navbar-title`, резиновая, занимает всё свободное пространство между 1 и 3 колонками;
3 колонка - кнопка "Войти", фиксированной ширины.

Пример правильной реализации можно найти тут (см. макет № 2):
http://htmlbook.ru/samlayout/tipovye-makety/rezinovyi-trekhkolonochnyi-maket


Looks good to me


We decided to use WeakHashMap. Fixed.


are there any major changes?


?? why 16 ?


`primary key` точно делать не стоит, максимум, `unique`, и то не думаю, что это нормальное решение.

Думаю, стоит находить подстроки среди нуклеотидных последовательностей. Обрезка последовательности по скобки может привести к неожиданным результатам, эта операция не похожа на что-то, что не может повлиять на свёртку


https://github.com/tpope/vim-rsi
I found that vim-rsi includes all the key bindings that vim-emacs-bindings provides as well as some other useful one.


Да, отлично. Именно то, что я и имел в виду.


Думаю, теперь сокращение уже не так актуально


of nie, inderdaad.


OK, a second `stat_conn` would be better, and safer, yes.


Step 5, under "Deployment" should reference defaults.js and not index.html


PHPCS: Whitespace found at end of line


I still found two :)


can we invert this if and have everything in else and below inside it

also can we swap operands in ```value === selectedUser``` and next expr?


Эти удалённые стили для `.nav`, если возможно, нужно вернуть обратно. Они взялись из bootstrap'а, не уверен, что это не повлияло (повлияет) на вёрстку на других страницах сайтах.


what's tt?  A GUN loading? :)


thanks for contributing, (and fixing this bug). The only thing missing are the build files, in order to do that please run:

```
gulp monaco
```

then commit the generated files


show loading handgun :)


> caused when the filename is invalid as it contains a nul byte.

Nul vs Null. I took that from the CString::new() docs, but I don't think it matters.


fgh


@mschaaf You print out the max value but dont set it. Is this correct?


fyi: [GitHub Pages](https://pages.github.com/) führen kein PHP aus ;)

Am einfachsten sind [Google Formulare](https://support.google.com/docs/answer/87809?hl=de), die lassen sich hier [einbetten](https://support.google.com/sites/answer/90569?hl=de).


camilo es gay


This triggers the data fetch while the user is changing the page number in pagination. I would leave that in there.


Думаю, здесь вынесение создания логгера в отдельную функцию не требуется, так как единственная строчка функции является достаточно понятной


Awesome. Much nicer. Thanks!


sure will do.


Because we had to start somewhere :smiley_cat:

Feel free to open a PR changing it to `@public` and we can get it updated if we generally agree.


// TODO: Check for input, make sure it is a valid gitlab hook, check repo and branch are correct


// FIXME: Change to use repostory


Was the previous max block file size required for anything? IIRC there was some issue with large files on old Windows systems, or something like that. I can't quite recall the history around why it's 128mb here.


The above is a weak password exception. But i see an error key with duplicate. Can you explain the relationship with weak and duplicate?


Thanks for the help again !


Лучше не использовать селектор `:nth-of-type()`, т. к. мы поддерживаем некоторые старые браузеры, в которых он не работает. Здесь этот элемент можно получить по классу `.user-panel-sign-up`.


А этот элемент можно получить по классу `.user-panel-sign-in`.


You will need to have a unit test for each of these changes.


Сокращение - это в смысле rf?


Я и не предлагал избавляться от функции получения всех результатов. Можно переименовать её в `get_all_structs` или что-то в этом роде, а `find_best_structure` уже в `run_for_collection` (хотя и это название в итоге лучше изменить)


Да


Not the latest anymore! https://github.com/JamesNK/Newtonsoft.Json/releases/tag/7.0.1


Good


typo: perspective


Логгер не создаётся дважды, об этом заботится библиотека.


А если будет, например, такая ситуация - .....().. и ..()....?
Как тут быть с подстроками и через них определить, что основная часть этих структур одинакова?


При желании его можно сделать глобальной переменной. Это одно из немногих исключений, когда использование глобальной переменной оправдано


I have misunderstood the array case (that is has to be an array of Member elements and nothing else). Going to update the PR.


in case of A) (do not set it in upgrade step) this error will occure if a user adds an item to the cart:

```
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module Products.PDBDebugMode.runcall, line 70, in pdb_runcall
  Module ZPublisher.Publish, line 48, in call_object
  Module bda.plone.cart.browser, line 156, in cartData
  Module bda.plone.cart, line 168, in data
  Module bda.plone.cart, line 324, in shipping
  Module bda.plone.shop.shipping, line 52, in description
  Module decimal, line 548, in __new__
  Module decimal, line 3874, in _raise_error
InvalidOperation: Invalid literal for Decimal: 'None'
> /usr/lib/python2.7/decimal.py(3874)_raise_error()
-> raise error(explanation)
```


Ура!)


incorrect - should be `cryptogroup.id === 'private'`. the name is null and is so displayed.


Could we have a brief discussion here in the code around why bitmasking is being used instead of the more obvious nVersion == 3? I'm assuming this is so if Core wants to do some other kind of rule change whilst the big blocks change is running, they can do so by using other bits a la Pieter's proposal?


Can we change this to use `slug` instead of title?


**FIXME** 相対パスへ


@mcm69 What do you think, should we allow pausing for NO_TIME? This issue happened due to `player.seek` performed just from the start, when player wasn't yet playing anything.


The script contains Windows and Linux based gemfire scripts


I can see how the short password exception name matches with the error message key having length. But i do not see it matching with case, digit, and non digit expressions in the error messages.


Oh I missed it because the if was on the same line :(


Problem solved :)


This is not a library to be used by general public. Also, supporting multiple versions would be difficult since python 3 and python 2 are not so similar. We should test only in python 2.7 and up for now.


why even have `NO_TIME` and not default to `0`?


This commit mistakingly undoes some modifications done for reaction tag processing. Those modifications are put back again in c27d4ddb2a66923b3e20774e8d1be2a88c6d55c2.


MIT will be excellent - that way cargo can use it at will. Thank you.


Suggest calling it `remote.log` and adding more than just the output of ssh there.


I think this should be `paver test_all`.


I mean like this: #280


/** Blocks with version fields that have these bits set activate the bigger-block fork */


Actually, the problem was in the arch_build() method, which was highlighted by bockbuild as a warning. As soon as I fixed the warning, the build error appeared in the next bockbuild run :-m .


@michaeldexter merge the pull request to fix the typo?


'a'? Isn't that a bit short? Why not something a bit more informative for people looking at keys in the db?


You are right. We could add some ticket for refactoring,


Тогда стоит подумать об использовании алгоритма поиска наибольшей общей подстроки


Oh, sorry about that 'nul->null' - it was highlighted in my editor and I didn't think about it.
Is `Nul` used anywhere except for in the `NulError` case ? The only thing I know that comes close is `Nil`.


What are these used for?


I haven't made any changes yet, I was just capturing the two versions you created that I got through Mike.  I would suggest (and can help) that we either make the board a bit smaller or much bigger as the pricing is based on board size and the step up happens when a dimension is above 5cm.  We're currently at ~5.4cm x 5.4cm.

Also I didn't see the logo bitmap in the schematics, I'm not sure how you added it or if Mike just had an older version, but I'd like to also create a Lowell Makes Eagle Part library and put that in there for future projects as well (I'll have to look at what i did, but I did this for Random Wire)

Finally, I'd like to consider using all SMD for the micro enabled parts so that we don't disrupt the silkscreen on the front (Silkscreen will be cut off of any through hole pads).  This can make the board a very simple starting soldering board as well as an "Advanced SMT" soldering board.  The ATTiny13 comes in SOIC which is a pretty easy SMD part to solder.

Thoughts?


/** Writes to the database that the fork requiring the given version bits has activated at the given block hash. A hash of zero indicates the fork has not activated. */


Думаю, стоит переименовать `optimality` в `is_optimal` и сделать булевой переменной вместо строки


When it starts to get used, will this comment still be valid?


`for` лучше не отрывать от `in`


Actually, reading the code more closely, I think we need much clearer comments here and elsewhere. The confusing thing is that once the fork is "activated" in the BlockTreeDB sense, it's still not activated for real until the grace period is over. Thus the fork can be "activated" and yet not "activated" at different parts of the code. It'd be nice if each part of the code was super, super clear on which it is at each point.


xD


`res` contains the outcome of applying the combined comparison operator `<=>`. So `res` will be -1, 0 or 1 depending on whether level 1 is less than, equal to or greater than level 2, respectively. In case it's equal, the name is used for the comparison.


This test is really good, but I'd feel more comfortable if it also tested the reorg case, as I know from bitter experience that reorgs can hide all kinds of obscure bugs.


If it was a performance issue, we can cache it. Currently it's not a problem.


В этом файле должны быть только стили для панели навигации.
Стили для `.page-buttons` должны быть в файле /module/Application/public/less/include/utilities.less (95 строка).


This defines the package where i have Mapped annotated classes which am now days using instead of Hibernate ORM (*.hbm.xml) files.


No, just the NulError case.


В этом файле должны быть только стили для панели навигации.
Стили для .page-buttons должны быть в файле /module/Application/public/less/include/utilities.less (95 строка).


そういうことなのかなーと思いましたが、 `SLC interpreter` の一つ、みたいな感じで不定冠詞のような気がします。 `an interpreter of the SLC` とかならともかく。


Just added that to ensure that people don't worry of dropping a table with data, it stands valid since the changeSet id includes the date


Oh i see! :)


I think there should be more LEDs.  Like a bunch of neopixels.  More LEDs =
better IMO ;)

We could use the lithium ion batteries from those pedometers that were
donated so we have plenty of power.

On Tue, Jun 23, 2015 at 9:48 AM, Patrick <notifications@github.com> wrote:

> I haven't made any changes yet, I was just capturing the two versions you
> created that I got through Mike. I would suggest (and can help) that we
> either make the board a bit smaller or much bigger as the pricing is based
> on board size and the step up happens when a dimension is above 5cm. We're
> currently at ~5.4cm x 5.4cm.
>
> Also I didn't see the logo bitmap in the schematics, I'm not sure how you
> added it or if Mike just had an older version, but I'd like to also create
> a Lowell Makes Eagle Part library and put that in there for future projects
> as well (I'll have to look at what i did, but I did this for Random Wire)
>
> Finally, I'd like to consider using all SMD for the micro enabled parts so
> that we don't disrupt the silkscreen on the front (Silkscreen will be cut
> off of any through hole pads). This can make the board a very simple
> starting soldering board as well as an "Advanced SMT" soldering board. The
> ATTiny13 comes in SOIC which is a pretty easy SMD part to solder.
>
> Thoughts?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LowellMakes/LowellMakesBadgePCB/commit/0e4e89d7cd58e51b67c3d2c9af9e53ef30fc1da2#commitcomment-11816768>
> .
>


Damit wird auch das Last Millenium deaktiviert


Just going along with the other items stored in this database, which all have single-character key prefixes.


@alex-emslie let's find a way to get this into the markup so it can be edited and abstract this tooltipster function so we don't need one for every tooltip. Maybe content can be `$(this).attr('data-tooltip')` or something


I don't think you need this method since it is identical to the ViewController's version. ViewController will automatically call you whiskey's numberOfWhiskeyShotsForEquivalentAlcoholAmount method since you overrode it.


`NO_TIME` is the case when there's nothing loaded into the player. But may be you're right, having falsy `player.anim` is enough for this.


axali metodebi xelit ar gamitestavs magram iseti arc araferi iyo. select-ebi gavteste da sworebia mgoni


@alex-emslie can this be extended from something in typography/_extends.sass?


indentation! :imp:


I will try to take a look at it in the next day or two.  Will let you know.

On Jun 22, 2015, at 5:05 PM, Raphael Jackstadt <notifications@github.com> wrote:

Updated README.md

added TOTP info

@tswagger take look over the TOTP pls, i dont know if anything is missing.

---
Reply to this email directly or view it on GitHub:
https://github.com/REJack/CodeIgniter-Aauth/commit/9afda70a7d61692edbece00340735a027d57dd58


Thanks for fixing this.


@alex-emslie I'd really love to avoid !important wherever possible. What's the cause?


Changes are as per design, can be merged with existing code


You should replace `ein` with `an`


_e( 'Acceptable podcast file types: .mp3, .ogg, .jpeg, .png'); should be surrounded with a conditional to check if the current page is the podcast upload page. Otherwise podcasters will be able to upload image files along with audio files.


// TODO: Check for input, make sure it is a valid gitlab hook, check repo and branch are correct


// FIXME: Change to use repostory


remove these lines and change toDate in the entity to allow null


changed


For a freshly created color object, _color will be nil.


Thanks getting lots of drm errors on different folders.  Will try to work them out later. Can I contact you later?


Same here.


This was the real "hack"... Eww!


done


If you're exposing the thermistor constant, bear in mind that 10000 is the resistance constant, which could also be tweaked. Also, you hardcode 4096 here and expose the bit precision mask as an user option -- shouldn't you use the  value from there?


Длина кнопки не должна быть задана в процентах. Кнопка всегда должна вести себя как `display: inline-block` (для десктопов).

Тут правильнее было бы так: для мобильных `display: block; margin: 0 1em`, для остальных `display: inline-block; margin: 0`


So how many is 'some'? :) I'm very curious how it is evaluated, is cuke so smart?;)


This is a test


ObjectGuid is size 16.


Nice, but these do this formula's contants' have anything related to the sensor in question? If so, they might deserve to be exported, too.


Agreed however it's possible (though not smart) to call initXXX after having called CGColor.  This was all to help not only plug a leak, but keep it plugged.


in the code I gave you in https://github.com/metapolator/metapolator/pull/616#discussion_r32886563 I deliberately not `pop`ped at this position (instead `obj = exportObjects[exportObjects.length-1]`). Because you have to use that `obj` until `it.done == true`. If you pop it here, you do one iteration and then throw `obj` it away.


            if (params.reserved === 'false' && params.setup === '') {
                params.setup = 'true';
            }


Also, would you mind to convert each galileo-grove-kit .fbp sample that relates to this patch series to the higher-level nodes you introduced afterwards? :)


update


Also, 4096 hardcoded, again.


4096 hardcoded.


Avoid unused local variables such as '$deployment'.


PHPCS: Expected 1 newline after opening brace; 2 found


We need to add transparency to these.


@AbdullahAlger Instance variable `@post` not needed here, alternatives are:

1. Use local variable
```ruby
def save_with_initial_vote
  ActiveRecord::Base.transaction do
    post = self
    user.votes.create(value: 1, post: post)
end
```

2. Use `self`:

def save_with_initial_vote
  ActiveRecord::Base.transaction do
    user.votes.create(value: 1, post: self)
end
```


Someone in the doctrine team is obviously using it, I don't see a reason to remove it unless that person delete the account on coveralls.


good idea, but don't forget to free() the system-allocated memory.


Hm, I like $a$, although I've seen it most commonly used to denote the value of a unit after activation, e.g. $a = \sigma(Wx + b)$.  If there's consensus one way or another I'm happy to change it.


Concerning 2):
Some DGT boards have lettering a-h and 1-8 on them. When the player is playing White, he will have the USB connector on the left side, next to square A2.


Because size of ObjectGuid is 16 (it's composed of 2 uint64 (low and high part) and size of uint64 is 8 bytes -> 8x2=16)


receive_message_chain :+1: _to remember_


Yes. It looks a little redundant.


I would make `catalog_name` a parameter of `get_quasar_catalog_path` with `DR12Q` as the default value.


Hmm is there a drive to make url extractors wrapped urls/wrapped playlists of wrapped urls, or just urls/url lists?


Hmm I haven't done measurements, but I don't think there's going to be a
difference with the way I implemented the "module..." :)

What's up these days man? :)

Cheers,

/* vendu */

On Mon, Jun 22, 2015 at 9:52 PM, Dale Anderson <notifications@github.com>
wrote:

> How do the shunting yard changes compare performance wise vendu?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vendu/OS-Zero/commit/05ce7d29ffe32a999cda68ae1eac50bc2b442e18#commitcomment-11800925>
> .
>


lgtm


Lynch is back:)


Can't we just ignore the value of `lite` if a quasar catalog is specified?  Could add a `quasar_catalog_name` parameter here also, which defaults to `DR12Q`.


Why is `Soomla/Assets/Plugins/Soomla/Core/` added to .gitignore?


You can jsut have ```expectNoError(resetMetrics(c))```


Oh, and because you ignore my advice of checking the break condition at the beginning of the function: here https://github.com/metapolator/metapolator/pull/616#discussion_r32885777 and also in the code here: https://github.com/metapolator/metapolator/pull/616#discussion_r32886563 your code is actually trying to execute even though `exportObjects` is empty. However, that's maybe good for you, because otherwise you wouldn't have an error message at all, i.e. that `obj` is undefined


Good test :+1:


Neat work! :+1:


Magic


put all `*.bat` files inside a folder called `fix-symlinks-windows`


Should be 7.0.


I don't understand ... I basically inverted the cmdVector calculation up there

~~~
     if(_svd_calculation.get())
     {
     	/* The output vector is calculated through the SVD solution, which is
     	   similar to the pseudo-inverse solution */
     	cmdVector = svd->solve(inputVector);
     }
     else
     {
     	cmdVector = thrusterMatrix.transpose()*inputVector;
     }
~~~

So how to compute expectedEffort is also dependent on _svd_calculation, no ?


this can be done in one line with Math.max & Math.min


i don't understand what you mean here.


PHPCS: Expected 1 newline after opening brace; 2 found


PHPCS: Whitespace found at end of line


// TODO: Check for input, make sure it is a valid gitlab hook, check repo and branch are correct


$model->servers; // FIXME: Surely we can use append


imo it's good practice to have the metavar name in caps; so, instead of '-n' imo it would be better to use '-N'


Converts raw sensor temperature readings to Celsius, Fahrenheit and Kelvin packets, maybe?


Implemented as requested. :-)

> On 23 Jun 2015, at 13:54, Džoka Mitrov <notifications@github.com> wrote:
>
> ZupID should be ZupPath
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/jhoek/UncommonSense.Nav.Automation/commit/1fb85814d2902644c8af1c8b73e9be4ad7a9e159#commitcomment-11814579>.
>


yes, you're right, the issue here was the `sql_flush` override not working properly


Maybe expose the underneath formula here, so the user better knows how it will influence the output?


Awesome


A more reliable test would be if it wasn't dependent on `Topic.all`.

If there was a bug that meant both `Topic.all` and `Topic.visible_to(user)` were returning the wrong results, this expectation might still pass.

Consider using:

```ruby
expect(Topic.visible_to(user)).to eq([@public_topic, @private_topic])
```

If it feels like duplication, thats OK in tests. Its more important tests are easy to understand and dependable. Its less important that tests are DRY.


Ditto WRT formula


Like this one as I am a Verizon customer :)


this was the bug which caused also the problem you observe, adi


will do.


dont think it's so bad to have 1 or 2 of those in the code :)


Use `user = nil` to match the description text more closely.


@kfogel thank you!  Yes, avoiding 3 (!) masters makes perfect sense.


Luminance?


// FIXME: Handle the failure as it is unclear what went wrong


It's there to avoid committing things on the repo on windows because of the symlink issue.
Does it conflict with the symlink stored on git ? It is not supposed to I think


@kfogel looks nice!  Thanks for adding the check about location and the extra output and documentation for users.


Should we check for more specific exceptions (e.g., IOError)?


@mybits 'some' equals 6 (according to @h-lame)


Hello. I haven't implement directory edit window yet. At this moment only file editing is possible.
I've achieved some success in testing modified PKGs on real instrument. First I've replaced /omega_sys/SetMediaLabels.sh file from Pa900 pkg. It just renames the labels of some partitions. I've installed this modified pkg and putted sd card into instrument's slot. After boot I removed sd cart and inserted it in PC. The label of disk have changed.

Second time I edited /omega_sys/OPOS file. After analyze I've found interesting string:
>Unit=C,  RegisterUnits=Yes, MaxNumOfPartitions=0, MainDevice=/dev/mmcblk0, PartitionDevice=/dev/mmcblk0p7,       MountPoint=/emmc/omega_sys,        Descriptions=SYS,  Label=SYS,  Removable=No, PublishedViaUSBDevice=No

I replaced _No_ in last statement to _Yes_ and saved the file. After installing it I can browse /omega_sys/ partition on my PC by USB cable. Unfortunately after disabling USB connection KORG system crashes and needs restart.
That's all I have done.


@whyvez it's not clear to me what you are saying.  Where if not here is the user defined bootstrap?  I would like to get this all working smoothly before creating many separate files.  So once it is working you would like it to go where?


Not a problem!


typo :)


@garthg yeah, everyone seems to want both: always show the full titles **and** keep the bold in the titles. That's what option 2 (find a better fragsize) was about: https://github.com/IQSS/dataverse/issues/2191#issuecomment-112924562

The commit we're commenting on is option 1, which is more straightforward.

I probably should have attempted to have the conversation in a public place like https://groups.google.com/forum/#!forum/dataverse-community so you can see how we arrived at wanting to try option 1 first. The thread has 22 messages in it so far.

For my part, I was sort of hoping for a quick fix for #2191. This commit hasn't been merged in yet.

Also, @eaquigley wants to do some usability testing on a public server for [another feature](https://docs.google.com/document/d/1xv_IKS1hWYUzX3GZOjHqGQ3BUBI7QH_2FekP90cexNA/edit?usp=sharing) before we merge it into a release branch so maybe I'll ask if we can preview this commit too.