30:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
32:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
37:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_SOLR_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_XAPIAN_ENABLED
37:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 37
37:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 37
37:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 37
37:1: F999 redefinition of unused 'CFG_LOGDIR' from line 37
37:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 37
37:1: F401 'CFG_XAPIAN_ENABLED' imported but unused
37:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
37:1: F401 'CFG_OAI_ID_FIELD' imported but unused
37:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
37:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
37:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
37:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
37:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
37:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
37:1: F401 'CFG_SITE_RECORD' imported but unused
37:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
37:1: F401 'CFG_INSPIRE_SITE' imported but unused
37:1: F401 'CFG_LOGDIR' imported but unused
37:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
37:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
37:1: F401 'CFG_BASE_URL' imported but unused
37:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
37:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
37:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
37:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
37:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
37:1: F401 'CFG_SOLR_URL' imported but unused
37:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
37:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
37:1: E402 module level import not at top of file
38:6: E126 continuation line over-indented for hanging indent
81:1: E402 module level import not at top of file
82:1: F401 'get_most_popular_field_values' imported but unused
82:1: E402 module level import not at top of file
83:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
83:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils
83:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
83:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
83:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
83:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
83:1: E402 module level import not at top of file
84:6: E126 continuation line over-indented for hanging indent
88:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors
88:1: F401 'get_fieldvalues_alephseq_like' imported but unused
88:1: E402 module level import not at top of file
90:1: E402 module level import not at top of file
91:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
91:1: I201 Missing newline before sections or imports.
91:1: F401 'create_record' imported but unused
91:1: F401 'record_xml_output' imported but unused
91:1: E402 module level import not at top of file
92:1: I101 Imported names are in the wrong order. Should be get_bibrank_methods, is_method_valid, rank_by_citations, rank_records
92:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.record_sorter should be before from invenio.legacy.bibrecord
92:1: F401 'rank_by_citations' imported but unused
92:1: F401 'get_bibrank_methods' imported but unused
92:1: E402 module level import not at top of file
97:1: I101 Imported names are in the wrong order. Should be calculate_reading_similarity_list, register_page_view_event
97:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.downloads_similarity should be before from invenio.legacy.bibrank.record_sorter
97:1: F401 'register_page_view_event' imported but unused
97:1: F401 'calculate_reading_similarity_list' imported but unused
97:1: E402 module level import not at top of file
98:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_stemmer should be before from invenio.legacy.bibrank.downloads_similarity
98:1: F401 'stem' imported but unused
98:1: E402 module level import not at top of file
99:1: F401 'BibIndexDefaultTokenizer' imported but unused
99:1: E402 module level import not at top of file
100:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.modules.indexer.tokenizers.BibIndexDefaultTokenizer
100:1: F401 'author_name_requires_phrase_search' imported but unused
100:1: F401 'get_field_tags' imported but unused
100:1: E402 module level import not at top of file
102:1: I101 Imported names are in the wrong order. Should be lower_index_term, wash_author_name, wash_index_term
102:1: F401 'wash_index_term' imported but unused
102:1: F401 'wash_author_name' imported but unused
102:1: F401 'lower_index_term' imported but unused
102:1: E402 module level import not at top of file
103:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_config should be before from invenio.legacy.bibindex.engine_washer
103:1: F401 'CFG_BIBINDEX_SYNONYM_MATCH_TYPE' imported but unused
103:1: E402 module level import not at top of file
104:1: F401 'create_download_history_graph_and_box' imported but unused
104:1: E402 module level import not at top of file
105:1: F401 'DataCacher' imported but unused
105:1: E402 module level import not at top of file
106:1: I101 Imported names are in the wrong order. Should be perform_external_collection_search, print_external_results_overview
106:1: F401 'perform_external_collection_search' imported but unused
106:1: F401 'print_external_results_overview' imported but unused
106:1: E402 module level import not at top of file
107:1: E402 module level import not at top of file
108:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS, VIEWRESTRCOLL
108:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
108:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
108:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
108:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
108:1: E402 module level import not at top of file
114:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch.adminlib should be before from invenio.modules.access.local_config
114:1: F401 'get_detailed_page_tabs' imported but unused
114:1: F401 'get_detailed_page_tabs_counts' imported but unused
114:1: E402 module level import not at top of file
115:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.legacy.websearch.adminlib
115:1: I201 Missing newline before sections or imports.
115:1: E402 module level import not at top of file
116:1: I201 Missing newline before sections or imports.
116:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
116:1: E402 module level import not at top of file
117:1: F401 'deserialize_via_marshal' imported but unused
117:1: E402 module level import not at top of file
118:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.utils.serializers
118:1: F401 'acc_authorize_action' imported but unused
118:1: E402 module level import not at top of file
119:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine
119:1: E402 module level import not at top of file
120:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
120:1: F401 'encode_for_xml' imported but unused
120:1: F401 'wash_for_utf8' imported but unused
120:1: F401 'strip_accents' imported but unused
120:1: E402 module level import not at top of file
121:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
121:1: E402 module level import not at top of file
123:1: E402 module level import not at top of file
126:1: I101 Imported names are in the wrong order. Should be calculate_cited_by_list, calculate_co_cited_with_list, get_cited_by_list, get_citedby_hitset, get_citers_log, get_records_with_num_cites, get_refers_to_list, get_refersto_hitset
126:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before import invenio.legacy.template
126:1: F401 'get_citedby_hitset' imported but unused
126:1: F401 'get_records_with_num_cites' imported but unused
126:1: F401 'calculate_cited_by_list' imported but unused
126:1: F401 'get_refersto_hitset' imported but unused
126:1: F401 'get_cited_by_list' imported but unused
126:1: F401 'get_citers_log' imported but unused
126:1: F401 'calculate_co_cited_with_list' imported but unused
126:1: F401 'get_refers_to_list' imported but unused
126:1: E402 module level import not at top of file
131:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_grapher should be before from invenio.legacy.bibrank.citation_searcher
131:1: F401 'create_citation_history_graph_and_box' imported but unused
131:1: E402 module level import not at top of file
132:1: I101 Imported names are in the wrong order. Should be get_self_cited_by, get_self_cited_by_list, get_self_refers_to_list
132:1: F401 'get_self_refers_to_list' imported but unused
132:1: F401 'get_self_cited_by' imported but unused
132:1: F401 'get_self_cited_by_list' imported but unused
132:1: E402 module level import not at top of file
133:55: E126 continuation line over-indented for hanging indent
136:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
136:1: F401 'wash_table_column_name' imported but unused
136:1: F401 'get_table_update_time' imported but unused
136:1: F401 'run_sql_with_limit' imported but unused
136:1: E402 module level import not at top of file
138:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
138:1: F401 'collect_user_info' imported but unused
138:1: E402 module level import not at top of file
139:1: I101 Imported names are in the wrong order. Should be create_error_box, pagefooteronly, pageheaderonly, write_warning
139:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
139:1: F401 'pagefooteronly' imported but unused
139:1: F401 'create_error_box' imported but unused
139:1: F401 'write_warning' imported but unused
139:1: F401 'pageheaderonly' imported but unused
139:1: E402 module level import not at top of file
140:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webpage
140:1: E402 module level import not at top of file
142:1: F401 'apache' imported but unused
142:1: E402 module level import not at top of file
144:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch_external_collections should be before from invenio.utils
144:1: F401 'do_calculate_hosted_collections_results' imported but unused
144:1: F401 'calculate_hosted_collections_results' imported but unused
144:1: E402 module level import not at top of file
145:1: F401 'CFG_EXTERNAL_COLLECTION_MAXRESULTS' imported but unused
145:1: E402 module level import not at top of file
147:1: F401 'DatabaseError' imported but unused
147:1: E402 module level import not at top of file
152:22: E203 whitespace before ':'
152:14: E225 missing whitespace around operator
153:24: E203 whitespace before ':'
154:24: E203 whitespace before ':'
155:28: E203 whitespace before ':'
156:30: E203 whitespace before ':'
157:24: E203 whitespace before ':'
158:23: E203 whitespace before ':'
159:29: E203 whitespace before ':'
160:26: E203 whitespace before ':'
161:33: E203 whitespace before ':'
162:30: E203 whitespace before ':'
163:30: E203 whitespace before ':'
164:30: E203 whitespace before ':'
165:30: E203 whitespace before ':'
166:30: E203 whitespace before ':'
167:30: E203 whitespace before ':'
168:41: E703 statement ends with a semicolon
170:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from sqlalchemy.exc
170:1: E402 module level import not at top of file
171:1: F401 'collection_restricted_p' imported but unused
171:1: E402 module level import not at top of file
172:1: F401 'restricted_collection_cache' imported but unused
172:1: E402 module level import not at top of file
173:1: F401 'get_permitted_restricted_collections' imported but unused
173:1: E402 module level import not at top of file
174:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.utils
174:1: F401 'get_all_restricted_recids' imported but unused
174:1: E402 module level import not at top of file
177:1: F401 'check_user_can_view_record' imported but unused
177:1: E402 module level import not at top of file
179:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.records.access
179:1: E402 module level import not at top of file
180:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.collections.cache
180:1: E402 module level import not at top of file
181:1: F401 'get_field_i18nname' imported but unused
181:1: E402 module level import not at top of file
183:1: I100 Imports statements are in the wrong order. from invenio.modules.indexer.models should be before from invenio.modules.search.cache
183:1: E402 module level import not at top of file
189: D401 First line should be in imperative mood ('Create', not 'Creates')
189: D202 No blank lines allowed after function docstring (found 1)
189: D400 First line should end with a period (not 'n')
189: D205 1 blank line required between summary line and description (found 0)
197:33: E261 at least two spaces before inline comment
206:1: F401 'get_synonym_terms' imported but unused
206:1: E402 module level import not at top of file
208:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
208:1: E402 module level import not at top of file
211: D401 First line should be in imperative mood ('Return', not 'Returns')
211: D300 Use """triple double quotes""" (found '-quotes)
232:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers
232:1: F401 'get_collection_allchildren' imported but unused
232:1: E402 module level import not at top of file
235: D401 First line should be in imperative mood ('Return', not 'Returns')
235: D202 No blank lines allowed after function docstring (found 1)
238:5: E266 too many leading '#' for block comment
242:5: E266 too many leading '#' for block comment
243:5: E266 too many leading '#' for block comment
245:34: E261 at least two spaces before inline comment
262:13: B901 blind except: statement
267:9: E266 too many leading '#' for block comment
279:9: E266 too many leading '#' for block comment
284:17: E266 too many leading '#' for block comment
293: D400 First line should end with a period (not 'o')
293: D205 1 blank line required between summary line and description (found 0)
293: D208 Docstring is over-indented
338:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names
338:1: E402 module level import not at top of file
341: D209 Multi-line docstring closing quotes should be on a separate line
341: D400 First line should end with a period (not 'y')
341: D205 1 blank line required between summary line and description (found 0)
341: D208 Docstring is over-indented
354:38: E203 whitespace before ','
385:1: E302 expected 2 blank lines, found 0
385: D209 Multi-line docstring closing quotes should be on a separate line
385: D400 First line should end with a period (not 'g')
385: D205 1 blank line required between summary line and description (found 0)
385: D208 Docstring is over-indented
414: D209 Multi-line docstring closing quotes should be on a separate line
414: D205 1 blank line required between summary line and description (found 0)
426:1: I100 Imports statements are in the wrong order. from invenio.modules.search.models should be before from invenio.modules.search.searchext.engines.native
426:1: E402 module level import not at top of file
431: D210 No whitespaces allowed surrounding docstring text
431: D400 First line should end with a period (not 'h')
431: D205 1 blank line required between summary line and description (found 0)
449: D401 First line should be in imperative mood ('I', not 'Is')
449: D400 First line should end with a period (not '?')
460:1: E302 expected 2 blank lines, found 1
460: D205 1 blank line required between summary line and description (found 0)
460: D208 Docstring is over-indented
467:1: I101 Imported names are in the wrong order. Should be CACHE_SORTED_DATA, SORTING_METHODS
467:1: F401 'CACHE_SORTED_DATA' imported but unused
467:1: E402 module level import not at top of file
470: D205 1 blank line required between summary line and description (found 0)
470: D208 Docstring is over-indented
484:20: E127 continuation line over-indented for visual indent
486:25: E126 continuation line over-indented for hanging indent
537: D103 Missing docstring in public function
547: D401 First line should be in imperative mood ('calculate', not 'calculates')
547: D209 Multi-line docstring closing quotes should be on a separate line
547: D202 No blank lines allowed after function docstring (found 1)
547: D400 First line should end with a period (not 'e')
547: D205 1 blank line required between summary line and description (found 0)
558:20: E261 at least two spaces before inline comment
562:17: E261 at least two spaces before inline comment
589:1: E302 expected 2 blank lines, found 1
607: D210 No whitespaces allowed surrounding docstring text
607: D400 First line should end with a period (not 'n')
613:25: E261 at least two spaces before inline comment
614:13: E222 multiple spaces after operator
637:10: E261 at least two spaces before inline comment
654:1: E266 too many leading '#' for block comment
656: D103 Missing docstring in public function
657:25: E128 continuation line under-indented for visual indent
658:25: E128 continuation line under-indented for visual indent
659:25: E128 continuation line under-indented for visual indent
660:25: E128 continuation line under-indented for visual indent
677: D401 First line should be in imperative mood ('Set', not 'Sets')
677: D202 No blank lines allowed after function docstring (found 1)
677: D400 First line should end with a period (not 'l')
677: D200 One-line docstring should fit on one line with quotes (found 3)
678:23: E128 continuation line under-indented for visual indent
679:23: E128 continuation line under-indented for visual indent
680:23: E128 continuation line under-indented for visual indent
681:23: E128 continuation line under-indented for visual indent
682:23: E128 continuation line under-indented for visual indent
720:9: B901 blind except: statement


1: D100 Missing docstring in public module


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013


1: D209 Multi-line docstring closing quotes should be on a separate line
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
25:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
33:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.dbquery
44:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from .getter should be before from .searcher
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: I101 Imported names are in the wrong order. Should be get_collection_descendants, get_collection_id, get_verbose_print, warning
50:1: E402 module level import not at top of file
53:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from .utils
53:1: E402 module level import not at top of file
55:1: E402 module level import not at top of file
66:1: E302 expected 2 blank lines, found 1
66: D400 First line should end with a period (not 'y')
67:9: E128 continuation line under-indented for visual indent
94:1: E302 expected 2 blank lines, found 1
94: D202 No blank lines allowed after function docstring (found 1)
95:9: E128 continuation line under-indented for visual indent
96:9: E128 continuation line under-indented for visual indent
97:9: E128 continuation line under-indented for visual indent
106:13: E128 continuation line under-indented for visual indent
116:1: E302 expected 2 blank lines, found 1
116: D209 Multi-line docstring closing quotes should be on a separate line
116: D202 No blank lines allowed after function docstring (found 1)
116: D205 1 blank line required between summary line and description (found 0)
136:1: E302 expected 2 blank lines, found 1
136: D300 Use """triple double quotes""" (found '-quotes)
145:1: E302 expected 2 blank lines, found 1
155:98: E502 the backslash is redundant between brackets
156:17: E128 continuation line under-indented for visual indent
163:1: E302 expected 2 blank lines, found 1
163: D209 Multi-line docstring closing quotes should be on a separate line
163: D202 No blank lines allowed after function docstring (found 1)
163: D400 First line should end with a period (not 'e')
163: D205 1 blank line required between summary line and description (found 0)
196:1: E302 expected 2 blank lines, found 1
198:5: F841 local variable '_' is assigned to but never used
210: D209 Multi-line docstring closing quotes should be on a separate line
210: D205 1 blank line required between summary line and description (found 0)
224:1: E302 expected 2 blank lines, found 1
224: D103 Missing docstring in public function
270:1: E302 expected 2 blank lines, found 1
270: D103 Missing docstring in public function
279:1: E302 expected 2 blank lines, found 1
279: D103 Missing docstring in public function
284:13: E128 continuation line under-indented for visual indent
294:1: E302 expected 2 blank lines, found 1
294: D103 Missing docstring in public function
303:1: E302 expected 2 blank lines, found 1
312:1: E302 expected 2 blank lines, found 1
312: D202 No blank lines allowed after function docstring (found 1)
328:1: E302 expected 2 blank lines, found 1
328: D202 No blank lines allowed after function docstring (found 1)
328: D400 First line should end with a period (not 'e')
342:1: E302 expected 2 blank lines, found 1
342: D202 No blank lines allowed after function docstring (found 1)
342: D400 First line should end with a period (not 's')
347:30: E701 multiple statements on one line (colon)
354:5: E122 continuation line missing indentation or outdented
364:39: E701 multiple statements on one line (colon)
371:1: E302 expected 2 blank lines, found 1
371: D209 Multi-line docstring closing quotes should be on a separate line
371: D202 No blank lines allowed after function docstring (found 1)
371: D400 First line should end with a period (not 's')
371: D205 1 blank line required between summary line and description (found 0)
404:1: E302 expected 2 blank lines, found 1
404: D202 No blank lines allowed after function docstring (found 1)
404: D400 First line should end with a period (not 's')
423:1: E302 expected 2 blank lines, found 1
423: D209 Multi-line docstring closing quotes should be on a separate line
423: D202 No blank lines allowed after function docstring (found 1)
423: D205 1 blank line required between summary line and description (found 0)
428:5: F841 local variable '_' is assigned to but never used
463: D209 Multi-line docstring closing quotes should be on a separate line
463: D205 1 blank line required between summary line and description (found 0)
474:64: E261 at least two spaces before inline comment
474:65: E262 inline comment should start with '# '
480:21: E266 too many leading '#' for block comment
481:21: E266 too many leading '#' for block comment
482:21: E266 too many leading '#' for block comment
483:21: E266 too many leading '#' for block comment
489:13: E266 too many leading '#' for block comment
490:13: E266 too many leading '#' for block comment


final-test/git_workflow/How I- Use a common code repo to pivot quickly.srt


there are listed just below in Event Interface part.


Are you sure you have an updated clone including this commit?


Not sure we should add the dollar signs for these instructions. The user won't be able to copy/paste all the lines at once anymore.


Doh. My bad. Is the tags lowercased prior to this check, or will it potentially fail any case differences such as `Http`?


post :create, format: 'js', report: attributes_for(:report, user: user) - code dublication


Long lines. Let's stick to 120


Hmm, this is a bit misleading and might leave people wondering: what does “latest” mean and when could this actually be a problem? We should explain a really clear and concrete example of where this is needed, and we should also make it clear that this is really an exceptional case—normal use of CRDTs will not require this ever, as far as I can see.

One case could be the following:

  * A on NodeA adds Item to the ORSet
  * A sends message to B on NodeB
  * B removes Item from same ORSet

The question here is why an ORSet would be used at all or why the side-channel message is done at all—the communication could just as well be done _via_ the ORSet, removing the need for read-before-update. I think we should recommend the latter approach for people to use.


looks fine basically...
you need to keep the php file though with the entries for custom user settings available in expert mode...


the difference here appears to be only in the folder name inside the tarball, once extracted `diff -r` returns identical


add params (:each) to before


Yes, not sure this the right way to do this...


Its an generated class?


code dublication


done https://pypi.python.org/pypi/plone.app.jquery


as user and no_permited_user belongs to different tests, move those variables to corresponded scopes.


@rochoa unfortunately it won't work with this approach, since it later uses that string to build the sql query for the ogr command. I'm going to push what I think an alternative solution, see what you think ;)


Dieser Kommentar sollte gelöscht werden!


Added "ravintola tilaus" codes


It could also be that load balancer routes the requests to different nodes.

I started the section with "In some rare cases" :-)

We can of course clarify more. I certainly agree that it is normally not needed.

I think the ShoppingCart example is rather illustrative.


remote


Hier sollte das JSDoc format verwendet werden siehe http://usejsdoc.org/


```
* FIX Fixes MitedDOIValidator, so that it correctly checks if DOI was
  already minted for the specific upload. (addresses zenodo/zenodo#285)
```
- added `FIX` label
- corrected typo: check vs. checks


test comment for readme.md file


I can use it inside virt-test, if that's something of concern, no problem.


2016浙江省服务外包    ，16题


Yes, there were so many wip changes.


:anguished: - that was fast. thanks a lot!


yeah!


it seems to me that this variable isn't used.


The `extra={}` can have side effects. Is that what it's there for?

http://docs.python-guide.org/en/latest/writing/gotchas/


move those variables to corresponding scope


1: M111 unrecognized component name: legacy


1: D100 Missing docstring in public module


1: D209 Multi-line docstring closing quotes should be on a separate line
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
25:1: E402 module level import not at top of file
27:1: E402 module level import not at top of file
33:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
35:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.dbquery
44:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. from .getter should be before from .searcher
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
50:1: I101 Imported names are in the wrong order. Should be get_collection_descendants, get_collection_id, get_verbose_print, warning
50:1: E402 module level import not at top of file
53:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from .utils
53:1: E402 module level import not at top of file
55:1: E402 module level import not at top of file
66:1: E302 expected 2 blank lines, found 1
66: D400 First line should end with a period (not 'y')
67:9: E128 continuation line under-indented for visual indent
94:1: E302 expected 2 blank lines, found 1
94: D202 No blank lines allowed after function docstring (found 1)
95:9: E128 continuation line under-indented for visual indent
96:9: E128 continuation line under-indented for visual indent
97:9: E128 continuation line under-indented for visual indent
106:13: E128 continuation line under-indented for visual indent
116:1: E302 expected 2 blank lines, found 1
116: D209 Multi-line docstring closing quotes should be on a separate line
116: D202 No blank lines allowed after function docstring (found 1)
116: D205 1 blank line required between summary line and description (found 0)
136:1: E302 expected 2 blank lines, found 1
136: D300 Use """triple double quotes""" (found '-quotes)
145:1: E302 expected 2 blank lines, found 1
155:98: E502 the backslash is redundant between brackets
156:17: E128 continuation line under-indented for visual indent
163:1: E302 expected 2 blank lines, found 1
163: D209 Multi-line docstring closing quotes should be on a separate line
163: D202 No blank lines allowed after function docstring (found 1)
163: D400 First line should end with a period (not 'e')
163: D205 1 blank line required between summary line and description (found 0)
196:1: E302 expected 2 blank lines, found 1
198:5: F841 local variable '_' is assigned to but never used
210: D209 Multi-line docstring closing quotes should be on a separate line
210: D205 1 blank line required between summary line and description (found 0)
224:1: E302 expected 2 blank lines, found 1
224: D103 Missing docstring in public function
270:1: E302 expected 2 blank lines, found 1
270: D103 Missing docstring in public function
279:1: E302 expected 2 blank lines, found 1
279: D103 Missing docstring in public function
284:13: E128 continuation line under-indented for visual indent
294:1: E302 expected 2 blank lines, found 1
294: D103 Missing docstring in public function
303:1: E302 expected 2 blank lines, found 1
312:1: E302 expected 2 blank lines, found 1
312: D202 No blank lines allowed after function docstring (found 1)
328:1: E302 expected 2 blank lines, found 1
328: D202 No blank lines allowed after function docstring (found 1)
328: D400 First line should end with a period (not 'e')
342:1: E302 expected 2 blank lines, found 1
342: D202 No blank lines allowed after function docstring (found 1)
342: D400 First line should end with a period (not 's')
347:30: E701 multiple statements on one line (colon)
354:5: E122 continuation line missing indentation or outdented
364:39: E701 multiple statements on one line (colon)
371:1: E302 expected 2 blank lines, found 1
371: D209 Multi-line docstring closing quotes should be on a separate line
371: D202 No blank lines allowed after function docstring (found 1)
371: D400 First line should end with a period (not 's')
371: D205 1 blank line required between summary line and description (found 0)
404:1: E302 expected 2 blank lines, found 1
404: D202 No blank lines allowed after function docstring (found 1)
404: D400 First line should end with a period (not 's')
423:1: E302 expected 2 blank lines, found 1
423: D209 Multi-line docstring closing quotes should be on a separate line
423: D202 No blank lines allowed after function docstring (found 1)
423: D205 1 blank line required between summary line and description (found 0)
428:5: F841 local variable '_' is assigned to but never used
463: D209 Multi-line docstring closing quotes should be on a separate line
463: D205 1 blank line required between summary line and description (found 0)
474:64: E261 at least two spaces before inline comment
474:65: E262 inline comment should start with '# '
480:21: E266 too many leading '#' for block comment
481:21: E266 too many leading '#' for block comment
482:21: E266 too many leading '#' for block comment
483:21: E266 too many leading '#' for block comment
489:13: E266 too many leading '#' for block comment
490:13: E266 too many leading '#' for block comment


Hmm, it does not work with gpgcheck=1 in config and --nogpg on commandline...


>I guess by using the created property.

But I think we don't have an event to listen when the `created` property changes as we have for the `attached` property ?

>Regardless, the main problem with the name is the word "no". It's unclear if you mean "number" or "non". Maybe "_numNonUpgradedChildren" would make more sense.

ok. Should I maybe also change `_setupNoAttachedPanel()`  and `_setupAttachedPanel()` to `_setupNonUpgradedChild()`  and `_setupUpgradedChild()` ?


@locutus2  Just wondering, does this really also work in case pos.is_opposition() returns false?


so many white spaces before } leave just one :)


We don’t support custom filament thickness per printer on the client yet.
https://github.com/Doodle3D/doodle3d-client/issues/162
I removed it for now: https://github.com/Doodle3D/doodle3d-firmware/commit/7f56af0dfc8d386f241d3ccaf60d9a93f5bc6248


fixing= confirmed


ID selectors should be discouraged. If this #palleteContent id was generated by another framework or something it adds complexity and makes it a less reusable.


Wenn möglich eine genaure Beschreibung am Anfang der Datei!


This line should read `expect(book.entries.size).to eql 0`.


Thanks for that!


Yeah looks like that from that merge, maybe there's another way now.


Hi @mannyhenri -- that error looks like a typo perhaps? It coming from this line:

```
    return !!Session.get('commentSubmitErrors')[field] ? 'has-error' : '';
```

That session variable should definitely be defined, as we set it in the `onCreated` callback for the template. What does  `Session.get('commentSubmitErrors')` report in the browser console?


Please change this line.


sycn -> sync.


Ah !
Now I remember your explanations when someone else was trying to play with this.

Thank you, test is removed.


This just about wraps up work on #1328 I believe.


If `JcrRdfTools.removeProperty()` is throwing a `ServerManagedPropertyException`, why is any update needed for `MalformedRdfExceptionMapper`?


Tinha um espaço a mais e isso é o suficiente para a busca não encontrar "Piper Kerman".


Nope. There is a bash [operator precedence](http://tldp.org/LDP/abs/html/opprecedence.html) in which `&&` takes higher precedence than `||`. You can try this yourself:

```
><> bash -c 'if [[ 4 != 0 || 4 == 4 && "hello world" != *"hello"* ]] ; then echo hi; fi'
hi
```


Equals that make the difference!


I am not credited.


Ironicamente, faltava considerar o int que carrega informação sobre o tamanho do registro no cálculo do tamanho total do registro.


:clap: It's about time! :tada:


I think I prefer isTypeAny


You're doing two things here; changing the elements of the words array to "chirp" and building up x by concatenating those chirps. Why not just do one of these, either by joining the array at the end or just skipping the reassignment of words[i] ?


Agora essa função também dá informação do offset do registro anterior ao de maior tamanho na lista de deletados, para atualização da lista caso uma adição com reaproveitamento de espaço seja feita.


I change it to that later.


Nice


Also a closing ].


A precedência das operações tava causando erro nessa linha. Eu tentei adicionar parênteses mas não funcionou e ficou horrível. Usar os dois const int acima acabou sendo minha solução.


We discussed this in Slack, but just to follow up here --- the issue was that the "identity" source map was still relevant in the isopackets use case.  78ddff5a024917f49f35c434 fixes this.


Not so hot on the all caps variable name.


This dlls thing would need to be confined to windows. But personally i do not think this belongs here... This is not a standard location, and any application developer could do this this in their code before importing freetype and it would do the same.


What command or steps that I should use to start run the test?


Probably don't need an array if we're only interested in the first hungry day


A atualização da lista de registros deletados teve de vir especificamente nessa parte do código. Não pode vir depois, pois ela pode mexer com o cabeçalho do arquivo (se o registro repaproveitado era o primeiro da lista). Como o cabeçalho do arquivo também é modificado nas linhas abaixo (para adicionar o espaço que sobrou como um novo registro deletado), aqui acaba mesmo sendo o melhor lugar. Se fosse em outro (ou se fizessemos uma função pra arrumar a lista, por exemplo) haveria dois acessos para ler o FILE_HEADER.


Again if we're only interested in the first hungry day, we could just break or return here and skip those unnecessary iterations.


@jayarjo, why did you remove `Chromium` here? I did #107 to fix issue in Chromium and you've introduced already fixed bug again!


The idea is sound, (maybe just for rooks and queens)

But you should not give the bonus when there is no bishop on board.
Because the engine will quickly exchange the minors to get the bonus...

And for the same reason, for this to have a chance to work, the bonus will need to be smaller probably.


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 47](https://teamcity.labkey.org/viewLog.html?buildId=253376&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3 (1 new), passed: 23 Build time: 00:31:51
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySavedGroupPlot: <no details avaliable>

```


change to inform_displayer


never mind. found it.


LGTM


To catch the string and return a 409 code instead of a 400 code.


looks like you are correct


how about `task.info-refresh-interval`


No problem. :)  Was thinking... wouldn't it be easier to create a system to dynamically create the buffer so that the it doesn't take up so much memory?  I know the primary focus was to reduce CPU usage, but would it make sense to have it where we could create the receiving buffer in a dynamic manner where it would only use the memory it needed?  Currently, it's creating a 2MB buffer for receiving data when instantiating the Client object, which I'm failing to see the need for.  Do you think that this would be something that could lead to less CPU usage, as we ideally only would need to create a small buffer at first when the Client is connecting?


My point is, `MalformedRdfExceptionMapper` never interacts with `ServerManagedPropertyExceptions`.


That would complicate things down the track. (ie we'd have to `map(io.discard_alpha, map(io.imread, images))`.) I'd rather avoid that. The alpha is a bit of a quirk of whatever reader is currently being used... On some systems I seed it, and on others I don't. So I'd rather take it out at read-time. I can't conceive of any time that we'd want the alpha channel.


neon-vfpv4 is a better choice than vfpv4.


Ok, I moved it into `FEATURES`.


That's a good point


Yeah I saw the failure as I went to bed. Stupid forgotten doctest... =P Fixing now...! =)


Possibly but not on the master branch.

Sent from my iPhone

> On Jun 3, 2015, at 5:47 PM, Teagan Marie Glenn <notifications@github.com> wrote:
>
> Any way we can abstract this out using dynamic query for future use?
>
> —
> Reply to this email directly or view it on GitHub.
>


Why were these reverted.


You are now ;) Sorry about that. Hard keeping track of all these bugs sometimes.


I would not port this class If you can avoid it. I think is only used to feed info to the annotations at this point ReadLikelihoods should take over completely; that was a refactoring unfinished task in GATK3, sorry.


link to source and some comment on why it is there / needed?
 ... ideally a test would be great :)


Hey kordan,

Because you are doing a group by in the query, you can only include column
within the select that are either part of the group by or ones that perform
aggregate functions like sum() for example. So the options would be to
either add si.type to the group by which allow select on it, or do a sum()
count() .. I just guessed that including it was the best options.

On Wed, 3 Jun 2015 at 22:09 kordan <notifications@github.com> wrote:

> Why is si.type needed in GROUP BY clause in your opinion? I don't see any
> good reason to include it. Can you explain me better, please?
> Thanks in advance.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/central-queensland-uni/moodle-mod_surveypro/commit/75743390dba6b7985a1a7e73f4e6d49636841b4e#commitcomment-11497408>
> .
>


@Ironholds @dgrtwo Just want to alert you to some new plots.

5217 out of 6551 packages on CRAN have no evidence of tests, according to our definition. :scream:

Would also appreciate your interpretation of the fact that essentially every single packages has been downloaded in 1 month. Does that seem right to you?


* もし、ハンガリアン記法にするなら統一したほうがいいよ
* 現在のコードは、ハンガリアン記法とそうでないものがあるよ
* キャメルケースのポインターの表現は特にないです、
* 基本的に、どんな型なのかは、名前で表現はしません。
* なんでかというと、変数の上にマウスを持ってこればわかるからです。
* コンパイラが進化しているからこそ、ハンガリアン記法は、使わない時代になってきています。

* なので、ポインターの表現はしません。
以上です


Mike was here. ;-)


The name could be more explanatory.


looks good


Ahh right. I was calling it with a buffer created the same way as MemoryUtil 'globalBuffer' (ie, 0 byte direct buffer, calling 'duplicate' on it), so it passed debug checks. Although I hadn't considered that the slices aren't a direct ownership of the memory if I do it that way: If an allocator owning a single buffer with a couple MB goes poof, any slice returned by it wont work anymore.

Its actually the behavior I want since I'd be leaking slices if it were the case, works like that by coincidence then :smile:

Thanks for the heads up.


What is the purpose of this?


When you hit this you should probably stop iterating, either with a break or return statement.


Interesting approach. Did you consider using indexing to reassign the elements in words in place? Doing so would allow you to use .join(" ") to construct your string. But this solution works, so it's really just a question of style.


sorry, I forgot to mention, this would need to include a freetype.dll in the distribution.

pyopengl does this, and the developers of pyassimp also like the idea.
(increases portability and decreases the chance of errors and mad users)


Can I ask why this messes things up? While working on an import command this will cause problems because refreshing won't read the entire state in for the resource without this.


The last exercise that was bonus or part of the advanced track was
incomplete, think it was exercise 4.

On Wed, Jun 3, 2015 at 4:53 PM, Henry Howes <notifications@github.com>
wrote:

> This function doesn't look like it was tested.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bentongreen/foundations-js-lab1/commit/4b40a17063a0083668297ca601c0de6772bd22b3#commitcomment-11511657>
> .
>


@smbarbour : Would like to ask if we are allowed to integrate this into the OpenModularTurrets mod itself.


I dont understand all of the complexity just to load the library, just take the path found the find_library directly and feed it into the loading function it should work out fine.


This should not be needed with later version, unless someone overwrote that again in our repository...


I tend to prefer to use ctypes.CDLL over ctypes.cdll.LoadLibrary since ctypes.cdll is an instance of a class that is just a wrapper around ctypes.CDLL.


Make this function static like the rest.


```enyo/anchor``` should be updated as ```enyo/Anchor```


Drop the second paren to the next line.


Mike was here. ;-)


I'd move this struct to the top of the file.


iov part is broken and is being migrated currently (used by in_xbee)


I got it.  Thank you for your clear explanation.


Make this line span over two lines instead of 1 because it exceeds 80 chars.


typo: PSOT should be POST


Make this function static too.


r+


In consistent spaces. Use 2 spaces everywhere.


:dancers:


both the connect calls also need to use this override.


static


two lines


Put a space before the beginning of a comment like
```c
// This is a comment
```


Variables at the top of the file.


Create a header file for this.


Magic number. Make a `#define`.


Another magic number.


Spaces around operators.


Edit: please disregard this, and see 327d6e8a67637a729e68ed9dffcc26b5e850b2d8 instead


You can do asymmetric eval, but you have to be able to break it down into the sum of symmetric and asymmetric, and handle the assymetric part in the search.


Good question, grep:ed the blueprints now and no air units have death animations.

The current death behavior/ballistification of air units is in engine (the spin etc) and leaves correct position of the bones in the end,  even without TryCopyPose


yes, mock worked because you can create properties on the fly. Here I replaced mock with an instance of the actual object that has all the properties


Extra line break.


What do these variables actually do? Better names or more comments.


Mike was here. ;-)


Always wrap with `{}`.


CWD = CurrentWorkingDirectory
it's an acronym... why lowercase it >_>


Of course!
On Jun 3, 2015 7:35 PM, "Keridos" <notifications@github.com> wrote:

> @smbarbour <https://github.com/smbarbour> : Would like to ask if we are
> allowed to integrate this into the OpenModularTurrets mod itself.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/smbarbour/StrangeToolkit/commit/66d8e04184230f9e36655400e6d117af635117ba#commitcomment-11512174>
> .
>


Oops! I'll fix that in the next update. Thanks!


Thanks!


Perhaps pass in the assembly identity rather than a bool.


Is there any reason to add this line?  Other than that the code looks good to me.


Make sure you link to the permalink.


very good


This test is leaving a `jenny` module behind after running, affecting other tests.

A better option would be to create a temporary `confdir` for this run.


LGTM


That is an interesting question. Why are the other code being routed that way also?


Should be `atom.xml`. Updated in c3a59d9f6c3609a4c7df7fa142cafa42c1f220de.


I agree these tests could be better, but that refactor seems out of scope for this PR.


I renamed this method to try to make it more clear what it does.


empty should map back to null. Nullable booleans are tri-state.


I also renamed state.value to state.infixExpression to avoid ambiguity.


This is ES6 syntax and is equivalent to saying `this.setState({infixExpression: infixExpression})`


After some research, what I had had mentioned prior to this comment about dynamic buffers, seems like a bad idea.  Disregard that. :P  Back to the drawing boards!

`GCHandle.Alloc` seems like it would be a more efficient way to handle allocating space for the buffer, as well as significantly reducing CPU usage.  While you're busy and unable to work on this, I'll look into what you have already done and try to understand what is happening (With the server not working properly.)


those look good to me.


Actually, there never was a duplicate project bug.

It was App.sampleData always adding the data back at every startup


This section just had some indentation problems so I fixed those :)


Tengo la duda de qué link agregar aquí, para mientras puse el de acton academy


Updated to c29937b1e7da5a905e55369e97853cb3ef8a5c4c


Other things:

* Removed submit button, since it no longer does anything
* Removed `submit` method, since there's no button to call it
* Stopped storing the generated postfix expression in `state`


I know that, still it didn't work as expected, basically the projection was None in that situation. I know that it works with Python 3, not sure why it doesn't work in Python 2.


:+1: awesome


Updated in b687d06.


I still don't see where `:contents` is used.  If you remove `:contents` entirely no tests fails, that line is not used.


1) We need to return res, no body as the second argument.
2) If err is already define from the request, you are nulling it out.
I'm going to make a couple changes and commit this to the branch. You can have a look.


There is no need to adjust every other test, IMO just don't duplicate the tight coupling in *your* tests.


GitHub可以托管各种git库，并提供一个web界面，但与其它像 SourceForge或Google Code这样的服务不同，GitHub的独特卖点在于从另外一个项目进行分支的简易性。为一个项目贡献代码非常简单：首先点击项目站点的“fork”的按 钮，然后将代码检出并将修改加入到刚才分出的代码库中，最后通过内建的“pull request”机制向项目负责人申请代码合并。


Is there a guarantee that the written data gets flushed before calling flock?


Yup, this was the intended behavior. If inclusion and exclusion is in the schema, then that's going to be rejected by Mongo anyway. What the code tries to do is detect if there are any exclusions defined, if yes, then skip adding inclusions as that will trigger an error.


去去去去去去


También me pregunto si al compartir en social media, sale esta imagen ^


should we also pass in this value from HdfsFetcher.getConfiguration from VoldemortConfig. so that if required SRE's can alter this variable ?

But the 30 minutes sounds good enough to me and should be done even without the above change which will make it nicer.


Test Commit


Thanks @brentvatne :)


Thanks. I've amended the commit, so that there isn't a bunch of tiny commits when we merge.


:boom:


Imagine an imp is the very last mobj in the list before thinkercap. It throws a fireball, which causes a new thinker to be added, which causes P_AddThinker() to be called. That function does thinkercap.prev->next = thinker; which would have the effect of changing the imp thinker's "next" pointer, wouldn't it?


This is normal mode


It's still doesn't fix type double(12,3) but in type double it's work well.


this is hard mode


Ah, yup, my bad. I had intended to test the contents of the new feed, but decided that the other content tests would suffice. I'll remove.


I can I tell what version is installed on my Mac?  The dropdown menu says Client UI Version: 0.19 (beta).


```js
// TODO(@mxth): Use controllerAs and bindToController in demo
```


Sounds like a good plan.  This might be a good place to use virtual file
system?

On Wed, Jun 3, 2015 at 7:34 PM, John Zeringue <notifications@github.com>
wrote:

> My thought was that a DatasetResource would be instantiated with just a
> Dataset (probably easiest with a factory providing some subcomponents)
> and that the Dataset would be immediately written to disk elsewhere
> (known to the DatasetResource). That way, all the CRUD operations are
> internal to the DatasetResource and we're not passing Paths in and out.
>
> @bowring <https://github.com/bowring>, what do you think?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/clementparizot/Topsoil/commit/86445f6def3358bb5bdc3787efd782cc80d1d90d#commitcomment-11511489>
> .
>

--
Jim Bowring
C. Richard Crosby Distinguished Teaching Co-Chair
Principal Investigator, www.CIRDLES.org, www.github.com/cirdles

Computer Science
College of Charleston
66 George Street
Charleston, SC 29424

Google Voice: 843.608.1399 (preferred)
Google Email: bowring@gmail.com

Office:
Harbor Walk East (360 Concord Street) Room 308
843.953.0805
http://stono.cs.cofc.edu/~bowring/
bowringj@cofc.edu

R. Buckminster Fuller (1972):
If humanity is to survive aboard our planet, it must become universally
literate and preoccupied with inherently cooperative Comprehensive
Anticipatory Design Science in which every human is concerned with
accomplishing the comfortably sustainable well-faring of all other humans.


cause that is what works... surprised you got as far as you did


nit: newline after the left brace `{`, newline before the right brace `}`


Reviewed


This is inelegant and generates a trailing comma.


Removed in 44f0ef6.


Nav changes need to be on all three properties


Mike was here. ;-)


Hmm yes, I can make it part of VoldemortConfig. I'll do that now.


An incremental improvement we could do later would be to use angular's logging service. This would allow the message to be tested, and would allow developers to mock it out and shut it up if they see fit (similar to what the semantic-ui core library lets you do)


But, it doesn't look like you used your thumbnail featured image in your site?http://maddyswebnation.com/web170/templates/wordpress/blog/


I'm not sure we should use angular.forEach, just because it's so goddamned slow. If we care about skipping `$$hashKey` we can easily do that ourselves.


If this isn't hot code, feel free to ignore the above comment for now though =)


Thanks!


Seems like fixing them all in one sweep with a new PR would be cleaner and make more sense. I mean, if this PR won't be merged without it, then I can do it. But in an effort to make progress, I'd lean toward making those fixes separately.


Please document each group in this regexp, in a similar style to the microsyntax regexp documentation in angular core. This will save us a lot of pain when we have to maintain it


Ditto here


Actually that's fine, but I'll do it because there were a few other pain spots I wanted to send a PR for so I can send mine and that correction in on swift shot in a few days (unless you do want to do it.)


I disagree with this because the code you sent me did a .dll check and continued using it (not appending another '.dll' to the name)


大师


Doesn't look like I wrote good tests...


Mac OSX 10.10.3

bdsync.c:227:11: warning: 'EVP_get_digestbyname' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    md  = hash_getbyname (checksum);
          ^
./bdsync-hash.h:21:32: note: expanded from macro 'hash_getbyname'
        #define hash_getbyname(name) (EVP_get_digestbyname (name))
                                      ^
/usr/include/openssl/evp.h:842:15: note: 'EVP_get_digestbyname' has been explicitly marked deprecated here
const EVP_MD *EVP_get_digestbyname(const char *name) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
              ^
bdsync.c:234:11: warning: 'EVP_MD_size' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    *hs = hash_getsize (md);
          ^
./bdsync-hash.h:22:30: note: expanded from macro 'hash_getsize'
        #define hash_getsize(name) (EVP_MD_size (name))
                                    ^
/usr/include/openssl/evp.h:483:5: note: 'EVP_MD_size' has been explicitly marked deprecated here
int EVP_MD_size(const EVP_MD *md) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
    ^
bdsync.c:235:5: warning: 'EVP_MD_CTX_create' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_init (ctx, md);
    ^
./bdsync-hash.h:23:35: note: expanded from macro 'hash_init'
        #define hash_init(ctx,md) {ctx = EVP_MD_CTX_create(); EVP_DigestInit_ex (ctx, md, NULL);}
                                         ^
/usr/include/openssl/evp.h:549:13: note: 'EVP_MD_CTX_create' has been explicitly marked deprecated here
EVP_MD_CTX *EVP_MD_CTX_create(void) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
            ^
bdsync.c:235:5: warning: 'EVP_DigestInit_ex' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_init (ctx, md);
    ^
./bdsync-hash.h:23:56: note: expanded from macro 'hash_init'
        #define hash_init(ctx,md) {ctx = EVP_MD_CTX_create(); EVP_DigestInit_ex (ctx, md, NULL);}
                                                              ^
/usr/include/openssl/evp.h:555:5: note: 'EVP_DigestInit_ex' has been explicitly marked deprecated here
int     EVP_DigestInit_ex(EVP_MD_CTX *ctx, const EVP_MD *type, ENGINE *impl) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:272:5: warning: 'EVP_DigestUpdate' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_update (ctx, salt,      saltsize);
    ^
./bdsync-hash.h:24:36: note: expanded from macro 'hash_update'
        #define hash_update(ctx,buf,len) (EVP_DigestUpdate (ctx, buf, len))
                                          ^
/usr/include/openssl/evp.h:556:5: note: 'EVP_DigestUpdate' has been explicitly marked deprecated here
int     EVP_DigestUpdate(EVP_MD_CTX *ctx,const void *d,
        ^
bdsync.c:273:5: warning: 'EVP_DigestUpdate' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_update (ctx, zeroblock, blocksize);
    ^
./bdsync-hash.h:24:36: note: expanded from macro 'hash_update'
        #define hash_update(ctx,buf,len) (EVP_DigestUpdate (ctx, buf, len))
                                          ^
/usr/include/openssl/evp.h:556:5: note: 'EVP_DigestUpdate' has been explicitly marked deprecated here
int     EVP_DigestUpdate(EVP_MD_CTX *ctx,const void *d,
        ^
bdsync.c:274:5: warning: 'EVP_DigestFinal_ex' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_finish (ctx, pzeroes->hash);
    ^
./bdsync-hash.h:25:32: note: expanded from macro 'hash_finish'
        #define hash_finish(ctx,buf) {EVP_DigestFinal_ex (ctx, buf, NULL); EVP_MD_CTX_destroy (ctx);}
                                      ^
/usr/include/openssl/evp.h:558:5: note: 'EVP_DigestFinal_ex' has been explicitly marked deprecated here
int     EVP_DigestFinal_ex(EVP_MD_CTX *ctx,unsigned char *md,unsigned int *s) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:274:5: warning: 'EVP_MD_CTX_destroy' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_finish (ctx, pzeroes->hash);
    ^
./bdsync-hash.h:25:69: note: expanded from macro 'hash_finish'
        #define hash_finish(ctx,buf) {EVP_DigestFinal_ex (ctx, buf, NULL); EVP_MD_CTX_destroy (ctx);}
                                                                           ^
/usr/include/openssl/evp.h:550:6: note: 'EVP_MD_CTX_destroy' has been explicitly marked deprecated here
void    EVP_MD_CTX_destroy(EVP_MD_CTX *ctx) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:341:13: warning: 'EVP_DigestUpdate' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_update (state->ctx, fbuf, blen);
            ^
./bdsync-hash.h:24:36: note: expanded from macro 'hash_update'
        #define hash_update(ctx,buf,len) (EVP_DigestUpdate (ctx, buf, len))
                                          ^
/usr/include/openssl/evp.h:556:5: note: 'EVP_DigestUpdate' has been explicitly marked deprecated here
int     EVP_DigestUpdate(EVP_MD_CTX *ctx,const void *d,
        ^
bdsync.c:360:5: warning: 'EVP_DigestUpdate' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_update (state->ctx, buf, len);
    ^
./bdsync-hash.h:24:36: note: expanded from macro 'hash_update'
        #define hash_update(ctx,buf,len) (EVP_DigestUpdate (ctx, buf, len))
                                          ^
/usr/include/openssl/evp.h:556:5: note: 'EVP_DigestUpdate' has been explicitly marked deprecated here
int     EVP_DigestUpdate(EVP_MD_CTX *ctx,const void *d,
        ^
bdsync.c:1207:14: warning: 'EVP_get_digestbyname' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    *dg_md = hash_getbyname (digest);
             ^
./bdsync-hash.h:21:32: note: expanded from macro 'hash_getbyname'
        #define hash_getbyname(name) (EVP_get_digestbyname (name))
                                      ^
/usr/include/openssl/evp.h:842:15: note: 'EVP_get_digestbyname' has been explicitly marked deprecated here
const EVP_MD *EVP_get_digestbyname(const char *name) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
              ^
bdsync.c:1373:9: warning: 'EVP_DigestFinal_ex' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
        hash_finish ((*state)->ctx, *buf);
        ^
./bdsync-hash.h:25:32: note: expanded from macro 'hash_finish'
        #define hash_finish(ctx,buf) {EVP_DigestFinal_ex (ctx, buf, NULL); EVP_MD_CTX_destroy (ctx);}
                                      ^
/usr/include/openssl/evp.h:558:5: note: 'EVP_DigestFinal_ex' has been explicitly marked deprecated here
int     EVP_DigestFinal_ex(EVP_MD_CTX *ctx,unsigned char *md,unsigned int *s) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:1373:9: warning: 'EVP_MD_CTX_destroy' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
        hash_finish ((*state)->ctx, *buf);
        ^
./bdsync-hash.h:25:69: note: expanded from macro 'hash_finish'
        #define hash_finish(ctx,buf) {EVP_DigestFinal_ex (ctx, buf, NULL); EVP_MD_CTX_destroy (ctx);}
                                                                           ^
/usr/include/openssl/evp.h:550:6: note: 'EVP_MD_CTX_destroy' has been explicitly marked deprecated here
void    EVP_MD_CTX_destroy(EVP_MD_CTX *ctx) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:1404:30: warning: 'EVP_MD_size' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    int           hashsize = hash_getsize (md);
                             ^
./bdsync-hash.h:22:30: note: expanded from macro 'hash_getsize'
        #define hash_getsize(name) (EVP_MD_size (name))
                                    ^
/usr/include/openssl/evp.h:483:5: note: 'EVP_MD_size' has been explicitly marked deprecated here
int EVP_MD_size(const EVP_MD *md) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
    ^
bdsync.c:1428:13: warning: 'EVP_MD_CTX_create' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_init (dg_ctx, md);
            ^
./bdsync-hash.h:23:35: note: expanded from macro 'hash_init'
        #define hash_init(ctx,md) {ctx = EVP_MD_CTX_create(); EVP_DigestInit_ex (ctx, md, NULL);}
                                         ^
/usr/include/openssl/evp.h:549:13: note: 'EVP_MD_CTX_create' has been explicitly marked deprecated here
EVP_MD_CTX *EVP_MD_CTX_create(void) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
            ^
bdsync.c:1428:13: warning: 'EVP_DigestInit_ex' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_init (dg_ctx, md);
            ^
./bdsync-hash.h:23:56: note: expanded from macro 'hash_init'
        #define hash_init(ctx,md) {ctx = EVP_MD_CTX_create(); EVP_DigestInit_ex (ctx, md, NULL);}
                                                              ^
/usr/include/openssl/evp.h:555:5: note: 'EVP_DigestInit_ex' has been explicitly marked deprecated here
int     EVP_DigestInit_ex(EVP_MD_CTX *ctx, const EVP_MD *type, ENGINE *impl) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:1429:13: warning: 'EVP_DigestUpdate' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_update (dg_ctx, salt, saltsize);
            ^
./bdsync-hash.h:24:36: note: expanded from macro 'hash_update'
        #define hash_update(ctx,buf,len) (EVP_DigestUpdate (ctx, buf, len))
                                          ^
/usr/include/openssl/evp.h:556:5: note: 'EVP_DigestUpdate' has been explicitly marked deprecated here
int     EVP_DigestUpdate(EVP_MD_CTX *ctx,const void *d,
        ^
bdsync.c:1430:13: warning: 'EVP_DigestUpdate' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_update (dg_ctx, fbuf, step);
            ^
./bdsync-hash.h:24:36: note: expanded from macro 'hash_update'
        #define hash_update(ctx,buf,len) (EVP_DigestUpdate (ctx, buf, len))
                                          ^
/usr/include/openssl/evp.h:556:5: note: 'EVP_DigestUpdate' has been explicitly marked deprecated here
int     EVP_DigestUpdate(EVP_MD_CTX *ctx,const void *d,
        ^
bdsync.c:1431:13: warning: 'EVP_DigestFinal_ex' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_finish (dg_ctx, buf);
            ^
./bdsync-hash.h:25:32: note: expanded from macro 'hash_finish'
        #define hash_finish(ctx,buf) {EVP_DigestFinal_ex (ctx, buf, NULL); EVP_MD_CTX_destroy (ctx);}
                                      ^
/usr/include/openssl/evp.h:558:5: note: 'EVP_DigestFinal_ex' has been explicitly marked deprecated here
int     EVP_DigestFinal_ex(EVP_MD_CTX *ctx,unsigned char *md,unsigned int *s) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:1431:13: warning: 'EVP_MD_CTX_destroy' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
            hash_finish (dg_ctx, buf);
            ^
./bdsync-hash.h:25:69: note: expanded from macro 'hash_finish'
        #define hash_finish(ctx,buf) {EVP_DigestFinal_ex (ctx, buf, NULL); EVP_MD_CTX_destroy (ctx);}
                                                                           ^
/usr/include/openssl/evp.h:550:6: note: 'EVP_MD_CTX_destroy' has been explicitly marked deprecated here
void    EVP_MD_CTX_destroy(EVP_MD_CTX *ctx) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
        ^
bdsync.c:1458:29: error: use of undeclared identifier 'O_LARGEFILE'
    fd = open (dev, flags | O_LARGEFILE);
                            ^
bdsync.c:1649:16: warning: 'EVP_MD_size' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hashsize = hash_getsize (dg_md);
               ^
./bdsync-hash.h:22:30: note: expanded from macro 'hash_getsize'
        #define hash_getsize(name) (EVP_MD_size (name))
                                    ^
/usr/include/openssl/evp.h:483:5: note: 'EVP_MD_size' has been explicitly marked deprecated here
int EVP_MD_size(const EVP_MD *md) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
    ^
bdsync.c:1783:13: warning: 'EVP_get_digestbyname' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    dg_md = hash_getbyname (digest);
            ^
./bdsync-hash.h:21:32: note: expanded from macro 'hash_getbyname'
        #define hash_getbyname(name) (EVP_get_digestbyname (name))
                                      ^
/usr/include/openssl/evp.h:842:15: note: 'EVP_get_digestbyname' has been explicitly marked deprecated here
const EVP_MD *EVP_get_digestbyname(const char *name) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
              ^
bdsync.c:1795:16: warning: 'EVP_MD_size' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hashsize = hash_getsize (dg_md);
               ^
./bdsync-hash.h:22:30: note: expanded from macro 'hash_getsize'
        #define hash_getsize(name) (EVP_MD_size (name))
                                    ^
/usr/include/openssl/evp.h:483:5: note: 'EVP_MD_size' has been explicitly marked deprecated here
int EVP_MD_size(const EVP_MD *md) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
    ^
bdsync.c:2144:5: warning: 'OpenSSL_add_all_digests' is deprecated: first deprecated in OS X 10.7 [-Wdeprecated-declarations]
    hash_global_init ();
    ^
./bdsync-hash.h:17:27: note: expanded from macro 'hash_global_init'
        #define hash_global_init OpenSSL_add_all_digests
                                 ^
/usr/include/openssl/evp.h:833:6: note: 'OpenSSL_add_all_digests' has been explicitly marked deprecated here
void OpenSSL_add_all_digests(void) DEPRECATED_IN_MAC_OS_X_VERSION_10_7_AND_LATER;
     ^
24 warnings and 1 error generated.
make: *** [bdsync] Error 1


we are honestly going a bit crazy with the module names. There's no "real" benefit to it, it should probably just be something like `semantic/media` or something --- but that's a nit, we can always break this at 1.0.0


Document every contract / policy whereby behaviour changes depending on different combinations of inputs provided


Go for it. I appreciate the help! :sparkles:


po博主  说好的demo那  也是掉进第三方登陆的坑了


可以，挺好


How does this look Felix?
Will this work?


可以，挺好
![26](https://cloud.githubusercontent.com/assets/12604343/7974871/cf5add36-0a99-11e5-92e1-7f11374ad9ef.gif)


You could also do `user.is_a?(User)`


No problem. Thanks!


Mike was here. ;-)


That looks lots better. :+1:


That dog looked pretty sad. :-(


Ok so after some modification, I got the code to work.  I had to change the check for our `GCHandle` in our `byte[]` property to a bool `bufferAllocated`.  Checking for null won't work (Apparently GCHandle isn't a nullable type).

Some things I noticed.  The garbage collector was collecting garbage from the LOH more often than it would previously. (Might be placebo, the GC is so random :8ball: )  CPU usage did not decrease (Perhaps bottle-necking the server for creating Client connections would be sufficient?)


Style nit: organize your imports alphabetically! :)

(do you care about following a style guide? I'll just mention nitpicky style things you can ignore anyways in case you do)


Maybe under different circumstances. I'd be interested to see a project chasing performance doing file operations in memory for the speedup.


rax retry tests


Actually, nevermind, this may not be in Google's R style guide... :( Nitpick fail.


Sure! Which one should I follow??

On Wednesday, June 3, 2015, Edwin Chen <notifications@github.com> wrote:

> Style nit: organize your imports alphabetically! :)
>
> (do you care about following a style guide? I'll just mention nitpicky
> style things you can ignore anyways in case you do)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hudsonsuds/plotMDTS/commit/9d9528ebe7c5d8dc691f37e34e01767581560c2a#commitcomment-11512628>
> .
>

--
Matt Hudson | matt.b.hudson@gmail.com | linkedin
<http://www.linkedin.com/profile/view?id=11006170> | 650-648-3766


update issue #19


I had used lintr as a quick pass

On Wednesday, June 3, 2015, Matthew Hudson <matt.b.hudson@gmail.com> wrote:

> Sure! Which one should I follow??
>
> On Wednesday, June 3, 2015, Edwin Chen <notifications@github.com
> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
>
>> Style nit: organize your imports alphabetically! :)
>>
>> (do you care about following a style guide? I'll just mention nitpicky
>> style things you can ignore anyways in case you do)
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/hudsonsuds/plotMDTS/commit/9d9528ebe7c5d8dc691f37e34e01767581560c2a#commitcomment-11512628>
>> .
>>
>
>
> --
> Matt Hudson | matt.b.hudson@gmail.com
> <javascript:_e(%7B%7D,'cvml','matt.b.hudson@gmail.com');> | linkedin
> <http://www.linkedin.com/profile/view?id=11006170> | 650-648-3766
>
>

--
Matt Hudson | matt.b.hudson@gmail.com | linkedin
<http://www.linkedin.com/profile/view?id=11006170> | 650-648-3766


Yeah, that should work. You're right, I was canceling out the default error the server may have provided...good catch. :)


Definitely reads better that way. will change it.
Thanks


You should really just give credit to IodineGBA, my stuff was simply a minor change to the IodineGBA glue code, and threw some games in.


@niallo How is this supposed to work with Sauce?


Lol we need this file XD


Might want to pull out that `console.log()` on line 89. :)


Mike was here. ;-)


If you're naming the metric, seems like you maybe might as well name the date column too (instead of requiring it to be called "date"). Not sure, up to you.


Also, does the `res` contain the Sparkpost-specific error content that the `body` param in the request callback contains? (I can't recall...but I think it does).


Can you smell me?


Q: why add page list?


之前没有权限，就尝试了 pull request，现在已经直接在上面修改了


Nothing at all. :) I am merging this.


# markdown supported

- 中文也能通
- 那當然
- 分支上做新功能討論


Must be new Role()


@csnover I updated the dojo modules to use
```
(typeof module === 'object' && typeof module.exports === 'object' && typeof exports === 'object')
```
detection and got to:
```
Listening on 0.0.0.0:9000
Tunnel started
‣ Created session chrome on any platform (d15208fe-614e-4377-8ce1-00a548be37f0)
Suite chrome on any platform - unit tests FAILED
NoSuchWindow: [POST http://localhost:4444/wd/hub/session/d15208fe-614e-4377-8ce1-00a548be37f0/url / {"url":"http://localhost:9000/__intern/client.html?config=tests%2Fintern&basePath=%2F&initialBaseUrl=%2F&reporters=WebDriver&rootSuiteName=chrome%20on%20any%20platform%20-%20unit%20tests&sessionId=d15208fe-614e-4377-8ce1-00a548be37f0"}] no such window: target window already closed
from unknown error: web view not found
  (Session info: chrome=42.0.2311.107)
  (Driver info: chromedriver=2.14 (0fb4fbe55f5a967b960644f0fdc2013668d5a46a),platform=Mac OS X 10.10.3 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 2 milliseconds
Build info: version: '2.45.0', revision: 'a53b301', time: '2015-04-06 21:57:50'
System info: host: 'vladikoff', ip: '192.168.1.174', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.10.3', java.version: '1.7.0_67'
Session ID: 6736cb264362720fb13459e7581f6835
Driver info: org.openqa.selenium.chrome.ChromeDriver
Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=chrome, chrome={userDataDir=/var/folders/_z/8gy7l13n7yx4mdtmz4_xz_j00000gn/T/.org.chromium.Chromium.alD3Lt}, rotatable=false, locationContextEnabled=true, mobileEmulationEnabled=false, version=42.0.2311.107, takesHeapSnapshot=true, cssSelectorsEnabled=true, databaseEnabled=false, handlesAlerts=true, browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
  at ProxiedSession._post  <node_modules/intern/node_modules/leadfoot/Session.js:59:30>
  at ProxiedSession.Session.get  <node_modules/intern/node_modules/leadfoot/Session.js:523:15>
  at ProxiedSession.lang.mixin.get  <node_modules/intern/lib/ProxiedSession.js:90:23>
  at Command.<anonymous>  <node_modules/intern/node_modules/leadfoot/Command.js:625:19>
  at <node_modules/intern/node_modules/dojo/Promise.ts:393:15>
  at Object.run [as _onImmediate]  <node_modules/intern/node_modules/dojo/Promise.ts:237:7>
  at processImmediate [as _immediateCallback]  <timers.js:354:15>
  at Command.target.(anonymous function) [as get]  <node_modules/intern/node_modules/leadfoot/Command.js:600:11>
  at ClientSuite.lang.mixin.run  <node_modules/intern/lib/ClientSuite.js:137:6>
  at runWithCatch  <node_modules/intern/lib/Suite.js:314:21>
  at next  <node_modules/intern/lib/Suite.js:322:18>
  at <node_modules/intern/lib/Suite.js:345:6>
  at new Promise  <node_modules/intern/node_modules/dojo/Promise.ts:411:3>
  at runTests  <node_modules/intern/lib/Suite.js:278:12>
  at <node_modules/intern/node_modules/dojo/Promise.ts:393:15>
  at runCallbacks  <node_modules/intern/node_modules/dojo/Promise.ts:11:11>
  at <node_modules/intern/node_modules/dojo/Promise.ts:317:4>
× chrome on any platform - Todo (functional) - submit form (0.449s)
NoSuchWindow: [POST http://localhost:4444/wd/hub/session/d15208fe-614e-4377-8ce1-00a548be37f0/url / {"url":"http://localhost:9000/app.html"}] no such window: target window already closed
from unknown error: web view not found
  (Session info: chrome=42.0.2311.107)
  (Driver info: chromedriver=2.14 (0fb4fbe55f5a967b960644f0fdc2013668d5a46a),platform=Mac OS X 10.10.3 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 2 milliseconds
Build info: version: '2.45.0', revision: 'a53b301', time: '2015-04-06 21:57:50'
System info: host: 'vladikoff', ip: '192.168.1.174', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.10.3', java.version: '1.7.0_67'
Session ID: 6736cb264362720fb13459e7581f6835
Driver info: org.openqa.selenium.chrome.ChromeDriver
Capabilities [{platform=MAC, acceptSslCerts=true, javascriptEnabled=true, browserName=chrome, chrome={userDataDir=/var/folders/_z/8gy7l13n7yx4mdtmz4_xz_j00000gn/T/.org.chromium.Chromium.alD3Lt}, rotatable=false, locationContextEnabled=true, mobileEmulationEnabled=false, version=42.0.2311.107, takesHeapSnapshot=true, cssSelectorsEnabled=true, databaseEnabled=false, handlesAlerts=true, browserConnectionEnabled=false, webStorageEnabled=true, nativeEvents=true, applicationCacheEnabled=false, takesScreenshot=true}]
  at ProxiedSession._post  <node_modules/intern/node_modules/leadfoot/Session.js:59:30>
  at ProxiedSession.Session.get  <node_modules/intern/node_modules/leadfoot/Session.js:523:15>
  at ProxiedSession.lang.mixin.get  <node_modules/intern/lib/ProxiedSession.js:90:23>
  at Command.<anonymous>  <node_modules/intern/node_modules/leadfoot/Command.js:625:19>
  at <node_modules/intern/node_modules/dojo/Promise.ts:393:15>
  at Object.run [as _onImmediate]  <node_modules/intern/node_modules/dojo/Promise.ts:237:7>
  at processImmediate [as _immediateCallback]  <timers.js:354:15>
  at Command.target.(anonymous function) [as get]  <node_modules/intern/node_modules/leadfoot/Command.js:600:11>
  at Test.registerSuite.submit form [as test]  <tests/functional/Example.js:14:10>
  at start.then.finally.self.timeElapsed  <node_modules/intern/lib/Test.js:211:24>
  at <node_modules/intern/node_modules/dojo/Promise.ts:393:15>
  at runCallbacks  <node_modules/intern/node_modules/dojo/Promise.ts:11:11>
  at <node_modules/intern/node_modules/dojo/Promise.ts:317:4>
  at Object.run [as _onImmediate]  <node_modules/intern/node_modules/dojo/Promise.ts:237:7>
  at processImmediate [as _immediateCallback]  <timers.js:354:15>
No unit test coverage for chrome on any platform
chrome on any platform: 1/1 tests failed
```


Isn't `data.in` already a data frame (according to the comments)? What else would it be?


Change the casing to standard Java method naming.


typo: operations.

Also, minor: obvious comment :)


Must be new User()


I guess this just skips the node part of detection anyway.


? Can't tell what you're doing or why.


unused variable?


Fix the formatting structure.


Mike was here. ;-)


Fix formatting structure.


Check only current $entity not whole class


I saw that you also have a "Reset" shortcut for extended keymaps. I am trying to do the same with the "magic command" for keyboard "Lock Keyboard(Child Proof)"  I tried ```LSFT(RSFT(KC_CAPS))``` and making a macro. in both cases It only toggles capslock. Do you have any idea why this would work for reset, but not lock? https://github.com/tmk/tmk_keyboard/blob/master/README.md#magic-commands


It look like the code is here. But, I do not see the images loading: http://www.nectarshakir.com/web170/html/wordpress/?page_id=15


24小时制


Maybe change the message to: "Identifier value can't be null for type: " + identifierTypeName


test


If you're open-sourcing this (that's the goal, right?) or want other people to use it, might be helpful to have a better error message if these conditions fail.

e.g.,

```
if (!exists("date", where = data.in)) {
  stop("data.in must have a column named 'date'")
}
```


嗷嗷


How do you specify multiple filters? Is adding filters here the same as subsetting your input data frame on the filters beforehand?


Add spacing between patientId value and idenfitier id because I think this message will generate: "patientId = XYZIdentifier Id = ABC"


@wuciawe 原来如此，这么一说我才懂了……


What is `filter_` on line 51? (Sorry, commenting sucks.)


great :D


Fixed.


Will clarify this in the wiki page for config properties.


You needed some sleep!!!!


It s not related Journal.


添加新功能


I've since changed this to RESET in my uncommitted version, and calls the bootloader directly (not with the Magic commands) - unfortunately the Magic-watching section doesn't seem to see LSFT(RSFT()) as the Magic button.

I imagine there's some way to build in support for that, but I'm not sure what it is.


You should probably set your global `git config` to [properly handle Windows line endings](https://help.github.com/articles/dealing-with-line-endings/#platform-windows) so you're not changing the entire file like this.


noob question: What is `interp`?


I think if we do it this way, we will ended up missing the full stack trace because we're swallowing the exception here. I think we should either log the exception here or store the exception reference and throw it in the finally block. That way we will still have the full stacktrace in the log file.


Same comment here about the exception swallowing above.


This could have the same issue because the full exception will be swallowed here.


aa


Is the codename seriously nedge???


The other way would be to create queueProcessorException using e from this exception here.


nidietui


queueProcessorException = new QueueProcessorException(e);


Minor: this block of `if` statements might be easier to read if you kept it all one-level deep (without nested `if` statements), i.e.,

```
if is.null(group) && is.null(facet)
else if is.null(group)
else if is.null(facet)
else
```


This is weird.  This was just some random syntax checks but git/git-plus/github didn't take my actual commit...


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.233](http://teamcity.monogame.net/viewLog.html?buildId=7986&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


:thumbsup:


No this isn't the real password (fooled ya!)


Yo Spartans


eciEncode looped whole content string,but eciprocess looped one by one string!
For example,content ="インドネシア市場事業における出展者募集", ecoprocess loop the first character "イ", but eciEncode looped whole content string every time.

//...
qmarksAfter = eciEncode(content.charAt(i),"ISO8859_1");
//...
qmarksAfter = eciEncode(content.charAt(i),"SJIS");
qmarksAfter = eciEncode(content.charAt(i),"UTF8");
//...


@Ovilia 嘿嘿 女神一定是經常被搭訕 然後就熟視無睹了


Unnecessary. Journal roles are nearly static.


If someone config `cipher` not `MCRYPT_RIJNDAEL_128`, this change will cause a `Exception`.


longTap event  bugfix in android webview.


Thank you! :+1:

3529 - Holy Salt..?
=> 염 here is more like will or aura, not salt :smile: :
(Korean can be confusing sometimes :confused: )


Case of bad naming that trigger should be MagicWhenBlocksOrBecomesBlocked**By**. Use MagicWhenBlocksTrigger and MagicWhenBecomesBlockedTrigger, when in doubt double check with MagicAbility (in this case it is MagicAbility.BlocksOrBlockedEffect)


You don't need to pass in the `title` here as you already have access to it from the instance. eg.

```ruby
def markdown_title
  markdown_to_html(title)
end
```


Because I want to include the lda-driver code in the `zen-assembly-*.jar`, so that there's no need to configure `spark.executor.extraJavaOptions` and `spark.driver.extraJavaOptions`, and just submit the `zen-asembly-*.jar` instead. On the other hand, I forgot to check the examples' `target` folder and thought you were not willing to output `examples` module as a jar package.

Please feel free to revert this pom file to previous version if you want.


At some point, we should look at changing this to be a list of authors. I don't want to take credit away from Darren, but I do think the other maintainers should be acknowledged.


Will be renaming the trigger to the more correct name. Thanks for catching this.


Same here, you don't need to pass in the `body`.


odd. I have not had any issues opening watchlist prior to this fix. what was the problem?


@wuciawe 你看…… https://github.com/Ovilia/ThreeExample.js/issues?q=is%3Aissue+is%3Aclosed


Yay!


Will be fixing Spitting Slug as well, since I'm renaming the trigger.


Since you are already updating this log line we should correct it to read "Field updates **will** be skipped."


Nevermind, I got it now!


@Ovilia 好歡樂呀 啊哈哈哈哈


撒旦法


if you're es6-ing you should be able to switch to method shorthand for Tapper#render:

```javascript
module.exports = React.createClass({
	displayName: "Tapper",
	render() {
		// code
	}
});
```


@iracooke is there any reason to change this? `searchgui_archive` is an official datatype now and without this does not work in tests.


Thanks a lot!
I resolve the type error when setting my stream information into 'sources.json' file.

But I still get the  error: 'MEDIA_ERR_SRC_NOT_SUPPORTED'.
I will try it again, thanks.


It was inevitable. Good move.


You can tell your kid's growing up when you're editing modules for a Duplo car...


@KozhinM info.range.start also needs to be changed?


.swp 這東西應該要進 gitignore
另外就是可以用 endswith('.yml')


This will give the achievement to players who currently have all the top-level gear (which is correct), but not to any player who had bought that gear in the past but has lost one or more pieces due to death or rebirth. Is that the desired behaviour?

Ignoring this migration script for the moment, what is meant to happen when a player gains an ultimateGearSets achievement and then loses one top-level item? When they buy back the item, does that trigger the awarding of the achievement again?

If it does trigger the awarding of the achievement again, then this migration script is okay, because anyone who currently has one of those top-level items set to false will be given the achievement naturally when they buy the item back.

However if rebuying a lost top-level item does not trigger the awarding of the achievement again, then this migration script needs to also assign the achievement if the user has a value of `false` for any of the top-level items.


The logic seems maybe better but a local element (added with `.push()`) and a firebase element (added with `.$add()`) don't have the same contents.


Give meaningful variable names


Well it's quite different. This one is about merging and the previous about viewing. But I can merge them, it's no problem.


sip, se queda muda... es raro porque `demo.sid` de hecho ocupa menos memoria que el otro.


input 我要怎麼塞 args & kwargs


Looks like you need skeletons: https://github.com/seletskiy/dotfiles/blob/master/.vim/UltiSnips/sh.snippets


others looks good to me.


@KarishmaBagga, I thought that if we don't know anything about the last box, we should use the same range.start and just increase the end, should not we?


I hate it when my jumbotrons explode

![image](https://cloud.githubusercontent.com/assets/1258370/7981836/974657bc-0aa9-11e5-9571-838e7d04725d.png)


Well, the `tree_unittest` should be updated with the `mux` change, the rest with this last commit.


I like this!


Hooray.


could be worth increasing it to 16MB to avoid any further issues like this :)


If you need to check for true or false, then you probably want to use [$exists](http://docs.mongodb.org/manual/reference/operator/query/exists/). It matches true, false, and null. We don't need null but it shouldn't do any harm because there should never be a case where a gear item exists in the user's `owned` array with a null value.


Contains all channels listed below


This was fixed by e05c936f23afc3f71a37ee1df1acc60a5ff4c619 and that's just shell script in the code comments, but I guess it should be updated also.


yanghe


Seems ok to me but i see 3 thing 25 26 and 27 may and i have no idea which one can be merged since 2 of them have rukususu still present and one ok with script moved to door npc. (Windurst 8-1, 8-2, 9-1  from 27 may ). need someone familiar with git to merge it


downshifter, you need this:
https://github.com/kovetskiy/dotfiles/blob/master/.vim/UltiSnips/php_vim_pythonx.snippets


Given that you've already got `range` here, I wonder whether it'd be clearer/simpler to use `unless range.include?(date)`?


Does that mean you can see the sled?
To me the entity is somehow invisible when l'm driving it.


So far this is just a text file without any specific format. It is designed for humans to read basically. What I can do to make it simpler to parse? IMHO it would need a major redesign, like:

```
[release]
version=3.0.2
...
```

Not sure if it's worth it. Maybe just let stick to a set of rules with the current format that makes it more parsable?


binary operator, spaces around :P


Yes, it is... I just cherry-picked this commit https://github.com/Gamua/Starling-Framework/commit/68aa0813dc8f822ec07b83401c65f627aecc17d2 without much thinking about it, thanks


Maybe add `caller` to this line, similar to some of the other validation errors, e.g. https://github.com/alphagov/smart-answers/blob/master/lib/smart_answer/question/multiple_choice.rb#L31


This may not be a good idea for systems that require high security, especially when you're low on entropy which is probably the case if you're using `rngd`. The random date provided by `/dev/urandom` just replenishes itself by hashing its previous contents.


Could have been written as:

    #extendQueryString($url {'highlight': [$highlightEnabled]})


good,very


Maybe we should test `get_include_paths`, shouldn't be complicated


I find this better readable because its in a generator expression, operator spaces are not a fixed rule usually because in some cases its better readable to not have those spaces IMO, PEP agrees


I am normally using the same one you forked, but just compiling yours with latest arduino like you wrote in the forums doesn't work on it's own.


I've tried that. The problem is that the range checking is not ideal when the start of the range > end:
```ruby
> start = 1.day.from_now.to_date
=> Fri, 05 Jun 2015
> finish = 1.day.ago.to_date
=> Wed, 03 Jun 2015
> (start..finish).include? Date.today
=> false
> (finish..start).include? Date.today
=> true
```

I also added a test "do not complain when the input is within the allowed range when the dates are in descending order" to alert whoever tries to refactor this in future :)


ack


hogehoge


Yay!


we do test it implicitly and completely, also there are probably other heuristics we could do to get some include paths and they would be valid also.


Did you open the misstaken bug?


out


Is it automatically included in the tests?


this change still allows to send many packets with count < REGISTERED_ADDON_PREFIX_SOFTCAP, filling _registeredAddonPrefixes vector.

It also removes the check at https://github.com/TrinityCore/TrinityCore/commit/c905d1a6b7be3d0cdfdab0e8c4db267e01c68684#diff-384014a84bd8ee157a32df38eb177db6L934 raising a new issue


Can be written as:

    #set ($highlightEnabled = $request.highlight != 'false')


@jcbrand This is NOT a bugfix. What you committed here is debug code, to temporarily turn off filtering in the action plan phase. However, this filter is needed in the action plan, so I'll re-enable it again.


`isTypeOrSubclass()` is not necessary here.


Is the directory structure on this site the same as on the old site?

Something like the following might be better if that is the case:

```
RewriteRule    "^(.*)"  "http://www.mojohaus.org$1"
```


I made mistakes in describing what this commit actually is.
For one I did not remove UnBind(int)... I added it... opps?
I added cl_draw_focusless... Pretty important.
ImGui made adjustments to imgui.ini... I should add it to gitignore.
OpenGL debug contexts can be run with Debug builds via a preprocessor definition... I need more sleep.
The project folder got renamed when I made this engine public on github.
The working directory for both the debugger and otherwise had to change because of the project folder name change.... For some reason, relative paths refuse to work with the debugger.
Fixed a resize glitch and added window title changing.
changing the window refresh rate still does not work and doesn't really do anything.
TODO: Add cl_draw_focusless to the wiki!


Yes it is. This application was meant for internal use only. Licence Header has been added.


I liked my sorting algo... but doing it in the view is really better.
The code is simpler and we have less access to the database.


I think I'd be inclined to add some more unit tests to assert the behaviour at each end of the date range, i.e.:

* date of one day earlier than `from` is invalid
* date equal to `from` is valid
* date equal to `to` is valid
* date of one day later than `to` is invalid


`Dashboard exit code already set on the worker node`


Got it, thanks!

On Thu, Jun 4, 2015 at 9:55 AM, LnmVolbo <notifications@github.com> wrote:

> Anyway, the header says the parser is makelist.exe. The source in
> makelist.exe is src\build\makelist.py. Line 31 seems to be the line that
> checks for the first space after valid game name characters. Perhaps if
> line 31 was changed from:
>
>         if c==' ':
>
> to this:
>
>         if c==' ' or c==9:
>
> it might parse tabs better.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mamedev/mame/commit/4d3ae8b5aeff6f4a396051dd8467077a3c087929#commitcomment-11515912>
> .
>


Typo in commit message summary: "anwser"


yeah. copy/paste for the win. removed it here and on the other places where it is not necessary.


Only one `isSameAs()` assert is enough here. We already check the event handling in the other test.


hm you're right this can rather change.
Ack


The po/nl.po from this commit was "conflicted"... it had <<<head text showing where it was not able to be merged. I replaced it with the version from maintenance/gramps42 to allow tests to pass. If you need help with git, please ask on mailing list. Thanks!


Instead of making an entire repo for CSI in yours. Make an organisation using the CSI email id and all members can be a part of it. And put all your projects there.


@KozhinM Yes I think that will be correct. Thanks for the fix...it looks perfect now


you should definitely squash that with 15c0b4113cd3554792b4abaa7b5b25dad2ea82ae.


Use spaces rather than tab here, othewise this is good to go :+1:


Now that it works, I'll plan a merge of the 5 or 6 lasts commits (with a rebase).
I'll just wait that you see them.


Thank you for doing this!


It is not needed here as well.


good


We want to check the type. use an `isSameAs()` assert here.


don't you need to change the interactor function also?


The problem with doing this for everything is it slows down the initial configuration. However for complex logic like we'd end up with for no-reserved-I'd-macro, I think this is the right option


Befor doing atoi(buffer) check whether buffer contains only numeric values or not.
Put atoi(buffer) within if(siz == -1) so that if r_read fails then it checks for the error code in the buffer.


@KarishmaBagga, thanks so much for the code review and for all your suggestions!


Well I'm afraid for old gpu. Cerberus was a bit above 4MB. 8MB gives some margins.
Ps2 is 150M vertices/s best case. 2.5M vertices/frame. So 262K give the possibility to draw a frame in only 10 draw call.


That's true. For 0.2.0 release I decided to make it more human-friendly and then focus on direct messages, privates. In 0.4.0 milestone will do better bump: https://github.com/pepyatka/pepyatka-server/issues/179


yeah, but android doesn't care about the correct answer ;-)


interesting, the rpm builder does not complain at seeing
```
%if
....
%else
....
%else
....
%endif
```


Agreed. This is un-readable and thus un-maintainable.

I'm not smart enough to keep all those 0, 1, 2, 3 in my head, especially inside things like `tok[3][1]`.


pulled new update


yes I was surprised too.


Again, we have to check the instance.


Fantastic! Now make sure to shut down and delete your old SF presence as carefully as possible... :P


remove


isSameAs


These are already listed in [xwiki-enterprise-ui-common/pom.xml](https://github.com/xwiki/xwiki-enterprise/blob/master/xwiki-enterprise-ui/xwiki-enterprise-ui-common/pom.xml#L36) and [xwiki-enterprise-ui-mainwiki/pom.xml](https://github.com/xwiki/xwiki-enterprise/blob/master/xwiki-enterprise-ui/xwiki-enterprise-ui-mainwiki/pom.xml#L36). They are features (old identifiers) of an existing flavor. I don't understand why you need to duplicate this information.


I can't see the list of section names in the invocation^^


Unnecessary.


OK


I dont think so, == is I think a bashism to help people using more modern languages hate shell less.


-eq might be better though


Please revert the unrelated formatting.


Unnecessary formatting.


The old code allowed sending as many as you wanted anyway.

This is on a dev branch, anyway, and c905d1a6b7be3d0cdfdab0e8c4db267e01c68684#diff-384014a84bd8ee157a32df38eb177db6R924 should read
```c++
_filterAddonMessages = !packet.Overflown;
```