Looks like the variable name 'cmd' is used for two different purposes here.


ghimport.py script requires a new element on CONFIG file, github.webhooks.secret, that represents the secret used when creating the webhook in GH.


you can remove these comments as it is clear from the concept of NodeHandle namespacing...


this breaks multihash initialization


@pawroman OTOH, I think the C++ version is the most interesting one. It's C++11 and it's a) totally different language than the one I used to know 15 years ago and b) has included most of the so called "modern" features like local type inference and smart pointers. It's *not* pretty, and I think it's impossible to make C++ (as a language) pretty because of 30 years of legacy code C++ needs to support, but its one of the most powerful languages I know of. And I know quite a few of them... :smile:

Also, sorry for not contacting you directly earlier, I'm experiencing rather severe health issues (the same as usual, only worse) and I was totally useless for the last month. I'm getting better though, so you can expect me to harass you in not that far future :smile_cat:


NodeHandle naming (see the other comment)


var's and val's should always be lowercase.


the magic is here ...


this comment is misleading...as it is actually __not__ the global namespace ```/```


You were right: 4 times.  Fixed.


Remove "implicitly"


Let's do this on Monday...and apply the changes to the yaml's in ```cob_robots``` etc.


I realize this commit is 2 years old, but applied relatively OK to my own code base (needed a few tweaks for the build system, mostly). But it seems the code doesn't work (I tried both 0.2.1 and 0.3.0 efforts on bugzilla bug 856375 since I want to add WebP support to Pale Moon) and webp images always give "the image cannot be displayed because it contains errors" without further insight or errors.

Would you be willing to lend a hand?


Following your point of view one of our doubts is if the private methods come to the new class or not.
I was thinking, probably we should create a new Class with name like Nuno said: "stats" (simple class), make the calculations in the financial and then return that class to view with all the information needed to all graphs.


This is a pleasingly small file. I'm at 725 lines of code on radial phylo and haven't written the documentation yet lol.

1. One thing I don't see is validation of the function arguments. If someone messes up an argument, the function is going to fail with a cryptic error message that might make the user think the function just isn't written right. It would be much more user-friendly to give some sort of helpful error, and fairly easy with some simple error checking. Some examples from `radial_phylo()`:

    ```R
    > radial_phylo(d)
    Error: Argument 'seqs_col' must be a column index or a column name when 'd' is a
      data.frame, or NULL if 'd' is a vector
    > radial_phylo(d, 'clone')
    Error: Data does not have column named 'clone'
    > radial_phylo(d, 'cdr3')
    Error: Sequences must only contain characters from A-Z and a-z
    > radial_phylo(d, 'cdr3', rings=c("antigen.species"=1))
    Error: Validation of the argument 'rings' failed: the column name 'antigen.species' does
      not exist in input data 'd'
    ```

  * Have you tried passing a single-column data.frame to `data`, or a vector?
  * What if the user does `krange=5`? What about `krange=c(-10, 20)`? `krange=c(5, 2)`? Or `krange=c(4,4)`? In a scientific application where the code is being used for research, I think the worst thing to happen is that your function somehow runs with unexpected inputs and as a result produces a false (but seemingly correct) outcome. Good validation of function arguments can prevent that type of situation. As an example, here's how you might take care of validating `krange` for a decent number of scenarios by simply preventing unexpected inputs (notice how the error checking is cascading, getting more specific with each if statement):

    ```R
    if (is.null(krange)) {
        stop("The argument 'krange' cannot be NULL", call.=FALSE)
    } else if (class(krange) != "numeric" || length(krange) <= 1) {
        stop("The argument 'krange' must be a range of integers", call.=FALSE)
    } else if (krange[1] <= 1) {
        stop("The range 'krange' must begin with a value greater than one", call.=FALSE)
    } else if (krange[length(krange)] < krange[1] || krange[length(krange)] <= 1) {
        stop("The final value of the range 'krange' must be greater than 1 and greater than
              the beginning value of the range", call.=FALSE)
    } else if (any(floor(krange) != krange)) {
        stop("The range `krange` must contain only integers", call.=FALSE)
    }
    # You could wrap all this in a `validate_krange(krange)` function.
    ```

  * What if `item.max=0`?
  * What if `runs=0`?

  I think you'd want to check for:

    1. The right data type (e.g. `data.frame`, `character`, or `numeric`, etc.)
    2. The right length (e.g. if you expect a range, check to make sure a single number isn't passed)
    3. The value conforms (e.g. if you expect an integer, make sure you don't get a float)
    4. `NULL`. Weird things happened when arguments are `NULL`, especially if you use that argument in an if statement.
    5. Anything other unique requirements. In this case, all data in `data` should be digits only. You might also want to issue a warning if the data is only 0s and 1s.

  Since most of your data gets passed into `kmeans` a lot of this might already be taken care of, but it would be worthwhile to check, and add your own validations to supplement when needed. A cursory look reveals `kmeans` validates `centers`, but not `data`:

    ```R
    > kmeans(d)
    Error in kmeans(d) : 'centers' must be a number or a matrix
    > kmeans(d, 3)
    Error in do_one(nmeth) : NA/NaN/Inf in foreign function call (arg 1)
    In addition: Warning message:
    In kmeans(d, 3) : NAs introduced by coercion
    ```

  I see some validation of `krange` in Line 43. Nice. I'd change your error message to "The argument 'krange' must be a range that begins with a value greater than 1" to be as clear as possible, and use `call.=FALSE` in `stop()` to suppress the traceback:

    ```R
    if (1 %in% krange) stop("The argument 'krange' must be a range that begins with a value greater than 1", call.=FALSE)
    ```

    The error message there now sounds like you're going to make something > 1 yourself, and it's a good practice to name the function argument that caused the error.

    The added benefit of doing extra good validation on this function is that you will **know** that the class you return is correct. Then any function that works off this class has to do hardly any error checking and will never break.

2. `data` is already defined in R (`?data`), so I'd steer away from that.
  * I'm using `d` instead (after "data"), other packages have used `x`. We should probably pick something consistent.

3. Your call to `kmeans` should be ``stats::means``, in case the user has some other package loaded that has a `kmeans` function. It shouldn't matter for less common function names, but in my own library I can see three different packages with functions called `kmeans`.

4. Nice...I notice you're using `swss` now as a scoring measure rather than silhouette to increase performance.

5. Have you run `devtools::test()` or `devtools::check()`? I think this will fail the code style check since quotations should be double, not single.

6. Do you have documentation somewhere for you class `cluster_optimal` so we know what data is in it? I can see most things are lists, but I don't know what type `clust_gap` will be, for example.

7. Function name and class name: I still have some confusion based on the existing names since they're saying "optimal" but *everything* is being returned when I look at the code. Doesn't seem like the name matches. What about something like these for the function name:

    * `cluster()` (verb...I can't find any existing functions with that name)
    * `cluster_ranges()` (trying to keep up with the "verb" function names)
    * `ranged_cluster()` (verb)
    * `multi_clust()` (verb)

  And for the class name something that indicates it contains data for a range of clusterings:

    * `clusterRange` (I think it's supposed to be camelCase for classes...don't remember)
    * `multiClust`

  Those seem to make more sense when you think about taking `multiClust` or `clusterRange` and then subsetting `$kbest`. Whereas if you already had `clusterOptimal` why would you need to subset to get `$kbest`?....know what I'm saying?

Coding is hard. This is awesome stuff. I think the final 10% of fine-tuning for production-code takes a bit more time than we're used to compared to writing stuff for labs, etc., but it's worth it and good to take care of now so it's not a worry later (or in case we're unable to change it later because something is already in production). I'm just about at this stage for radial_phylo. Still need to write documentation (added my final error checks/argument validation today). Would you be able to do the same look-over for me in a day or two?


better set the topic name explicitly as a string as it is clear to see what the topic name is...


Unfortunately, optString will return the string value "null" if the value is explicitly set to null in the JSON. That's why you have to use isNull().


This works, but, is there a method on Array that will allow you to delete a specific item in the array?


Mmm this is a good idea.


What we are looking to not mock is the actual stream_definition validation, not the json-type validation


Nice touch. I've had NFS flakiness derail simulations in a past life so that's a great idea.


Please see in-line review comments. I think the use of cmd in 'def assert_tc()' needs to be fixed before landing. The interface selecting needs a larger solution, so I'm fine with that coming in a later branch.


dam4, honestly, buying more like new than the maximum number of WH a user has is overkill... current servers had 2k max WH, so that means we technically only needed 2k for the hwole server, so using them liberally batters about zilch.  id rather have them going off and avialable than sitting there wasting valueable time doing nothing when we could be hitting more WH...... I put thought into this, ran the numbers and  updated the valuesm, basd on current games running

realize ive seen enough abou tthis to be scary


typo  - Static method that "sends" ....


This should be made consistent with the function definition. s/num_sats/num_sdiffs


Thank you!


same thing here for validateTransform.


Let's create a module `stream.js` that exports a function named `handleProfilePostsRequest(req, res)` and implements the behaviour from this if-branch.

Then in the if-branch you'd write:

```javascript
if (req.query.author) {
  return stream.handleProfilePostsRequest(req, res)
}
```


Some questions:
1. Why did you remove configuration support for TCP?
2. Why did you remove manual configuration for local port?
3. why did you remove some a TODO without finishing it?
4. Why did you replace "silencePackage.contentSize" with some strange magic number?


Is your runerror correct.  Looks like not found returns the wrong error.


Sun/Oracle JDK 6 is EOL since November 2012, and is no longer supported.


Ah where did you find this then? ```cdnjs.cloudflare.com/ajax/libs/mocha/2.1.0/mocha.min.js```


what about html5 sections?
asides?


The same here. Implement a function named `handleDashboardPostsRequest(req, res)` in `stream.js`.

```javascript
else {
  return stream.handleDashboardPostsRequest(req, res)
}
```


Did this fix your problem? I pulled it down and ```rake db:reset``` worked fine.


wenn man dependencies hinzufügt, muss man die ins Project hochladen und keine Hardlinks auf den Download Ordner verwenden


I'm not comfortable with this. Deep purple? Lighten 5? We need to discuss this.


Yes. But the fact that you can create 5 records with the same exact token illustrates that the `NULL` field is not taken into account in the unique index.


output


Let's use the `create` function from mongoose. It simplifies the code.

```javascript
Post.create(req.body.post, function(err, newPost) {
 // ...
})
```


Thanks for pointing that out! I pushed an update.


typo, it's `Object.getOwnPropertySymbols` ;-)


более удачное название для контроллера - home, static_pages.


почитай что такое gitignore и заигнорь всё лишнее, типа временных файлов, логов и т.п.


а ещё лучше - загугли какой-нибудь публичный gitignore для рельсовых проектов.

так же см. git rm, git rm --cached.


I would expect that you could drop ".to_v4()" here, no? there's a risk that ``a`` is an IPv6 address


Ryan, this is `Tzvetomir Todorov`. We had an issue with the previous git global config on the `Mac Mini`(which I set to `ttodorov@locqus.com` / `TzvetomirTodorov` and it's still using the old SSH key. We need to modify this so that Greg can make commits with his own account. I also managed to set the ***name associated with my email address*** to `Greg Kaiser`.

See image:
![screen shot 2015-06-17 at 5 58 49 pm](https://cloud.githubusercontent.com/assets/12847058/8219796/8c71936c-151a-11e5-9f92-4fb04fb80318.png)


We discussed this. lighten-4 at least


Please, create the tag 2.5.0


Reader hasn't been imported into this scope.


Please, create the tag 2.6.0


Missing line:

Configuration.Serialize(...)


Let's create a separate module `graph.js` that implements a function named `handleGetFollowers(req, res)`

The if-branch will become

```javascript
else if (req.query.following) {
  return handleGetFollowers(req, res);
}
```


it's not a question, it's about assigning a descriptor instead of using only enumerable and value, still keeping th efunctional approach 'cause you didn't modify, neither tried to, the received object. You just copied its properties as these were meant to behave in there ... this is how *I* would personally explain the whole final pattern.


lgtm


@shobu9 added ya :D


Jenkins test this please


やるべきことがずれている気がしますが…すみません…
あとは、この前のコードをそのまま実行した時に
---> 46                 pref = females[proposed]
     47                 # より好み＝好みで上位にランクされてるなら、略奪成功
     48                 if pref.index(int(i[1:])) < pref.index(int(matched_male[1:])):

TypeError: list indices must be integers, not str
とでます。どうしても自分では直せなかったです…
この場合のint の使い方を教えて下さい。（できれば４８行目も…）


@valib There is a typo __Strimg__ :-)
I suppose @SubJunk will fix the typo as he reverted this commit partially.


Let's add to `graph.js` a function named `handleGetFollowers(req, res)`.

The if-branch will become

else if (req.query.following) {
  return handleGetFollowers(req, res);
}


@AlmaasAre WTf skjedde her?!


Type Correction


This is spectacularly unlikely to happen, but:

If we switch them around, then it is possible to have a process running (`fork()` succeeds) that we have no way to reference (`calloc()` fails).  In that case, what is the right thing to do?  I rewrote it to do that and it looks like now I have to write `kill(child_pid, SIGKILL)` in the calloc failure cleanup routine, which doesn't feel good.  Instead of failing to `accept()` and start the conversation, now we will start it and then randomly drop the socket in the middle (due to `kill`) or we will accept the client and then just await for 2 minutes for `SIGALRM` to fire while the whole time the client thought it was in the queue.


@dangerouse Should I keep `controller_action`? If yes, `page.url` is fine here or should I use `page.title`? (Check [here](http://jekyllrb.com/docs/variables/#page-variables) all the available jekyll variables.


Looking at this more in depth now. Big performance hit, but agree it is needed to function correctly with non 8-bit character payloads.


do you use m_i2p_conn in any context where you don't have the ``req``? If not, you may not need to add a member


Let's create a module named `account.js` that implements and exports function that handle login, signup, password reset, and retrieval of authenticated user.

Once we have it the code here becomes:

```javascript
if (req.query.isAuthenticated) {
   return account.getAuthenticatedUser(req, res);
}
```


Hah! Thanks :gift:


DESTDIR, like PREFIX, should never contain a / at the end. I'll see what the convention is for handling things if it does.


Done.


Can you not use `Meteor._inherits` instead of defining your own extend helper?


This should only happen if no configuration was found.


fixed


Done


I was thinking more that the ControlSys "fovea extension" and the figure arrangements would also be part of the core "library" part of the PCA application setup alongside the linear algebra and the PCA execution loop, and that the disc and hypersphere functions and final initializations of fovea would be the only things in the test script. Could you try to organize it that way and then make additional commits within this same PR, and I'll review it again then?


Let's add a method function to the user schema. I want end up writing the following here:

```javascript
req.user.follow(user.id, function(err) {
      if (err) {
        return res.sendStatus(500);
     }
     return res.send({
         user: user
     });
})
```

Same for unfollow.


It's only used in this one place, so it feels strange to make it a global.  I'll change the comment.


No, I did that fix (I don't think it saved when I pushed it), but after
fixing that same part, I get the aforementioned error on the /posts page. "
http://modayil-box-224894.use1.nitrousbox.com/posts" to be precise. All the
other pages work, only that one doesn't.

Ben

On Wed, Jun 17, 2015 at 5:54 PM, Alex Stophel <notifications@github.com>
wrote:

> Did this fix your problem? I pulled it down and rake db:reset worked fine.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/benjaminmodayil/bloccit/commit/492fc13af4229b27dc8e8460184dae78339d2258#commitcomment-11735135>
> .
>


I also wouldn't want to completely rewrite a core piece of the module just to be able to report line and column numbers of errors. (In general, this whole stringToDocument thing feels like a hack that I wrote at the very beginning of the HFE module that _should_ be refactored.)

If you're going to do this, the way is to treat this as "scary legacy code" and write a bunch of unit tests around the existing stringToDocument functionality. Once you have good test coverage there, you can feel safe about making changes to it.


oops. #460 not 17


Coole Bilder ;)

Mathworks gibt hier einige Tipps: http://de.mathworks.com/help/optim/ug/when-the-solver-fails.html#br53e_u-1

Ich würde folgendermaßen Vorgehen:

1 Relaxierung der Ungleichungsnebenbedingungen (durch so ein Delta wie von Mathworks vorgesschlagen)
2 Wenn 1 nicht klappt, dann würde ich für jeden Zustand lineare bounds einführen (hilft dem Solver ggf)
3 Wenn 2 nicht klappt, dann müssen wir weiter überlegen


doesn't read well, add  - Middlewares are functions that "take" a single parameter ...


Segue a minha solução de Front-End para o layout enviado para apresentação de uma página responsiva.


In the real world, of course, `calloc` never fails unless the whole system is about to crash, so this whole thing is overengineering.


Hello,did you tested with pattern="mirc" ?


if I get it to run on travis, then yes


this description doesn't really matches the code below, does it?


Oops. Side effects of `git commit -a`. I forgot to get rid of that.


xmm1.r2 and xmm1.r3 also ...


here... you'd shift twice and lose one argument.


no problem :), since you mentioning out about inconsistency, I checked my code and found a lot of inconsistencies and miss-alignments, I will push the correction soon.


Should add that to https://github.com/NikosPapakonstantinou/my-inspircd-mods/blob/master/m_ctcpxline.cpp


@ExSport yes this is my mistake. I think I have to buy new glasses to avoid such stupid typing error :-(


@rossedman sounds good :+1: I don't know much about designing themes, but I look forward to seeing it action!


Please don't keep such logging - there are usually a lot of words and they overwhelm the log.


typo - Middlewares can also be "used" to extend...


Nevermind - I see it's deleted now:)


Oops. Side effects of git commit -a. I forgot to get rid of that.


Not really, we could do class hierarchies if we desired. The callback wrappers are also managed classes and as such can only leverage instantiations of native C++ templates like _callback.


Great !


yes this working but please connect and i have a good idea for that


Ok, das schaue ich mir morgen an :)


Exactly 1 RouteEntry would be fine, we just want to optimize around 0.  Should be:

```cs
if (result.Count > 0)
```


Have those updates worked ? Or it broke something ?


I added more of these to the callbacks to dispose when I realized that GetBrowserWrapper means that ALL IBrowser^ are properly disposed of. So none of the callbacks now need to dispose (or contain) IBrowser^ members. See my latest commits to this PR for the details.


good news bro,ok


@jonschlinkert Could you add me as npm owner of `write-yaml`?


Ok. Good warning then.


I've since changed this to delete.


wether -> whether
sensetive -> sensitive


And I was being paranoid since this is a native C++ class. :)


Typo... I will fix it.


Neat! thanks :+1:


It looks like you pulled it in from @nbougalis. It's all his fault. :)


Yer welcome.


@muriloaandrade a section está com a classe errada


typo - request to "determine" if they...


Fixes #21


@muriloaandrade o código html está 2 tabulações a frente(código não está "colado no limite esquerdo" do editor)


Should this just be `if(ignoreCase)`? If we want to insist that that `ignoreCase` must be a boolean than it seems better to check the type and throw as a method pre-condition. As it is, truthy values will be treated as `false` instead of `true`, but you'll still be able to pass non boolean arguments.


@muriloaandrade pt-BR


@muriloaandrade muda o nome da folha de estilização pra stylesheet.css


Should also just be `if(ignoreCase)`.


Hello from FULL_TEST_CASE :p


<3 :grinning:


> The platform makes a new entry in ApiTokens with userId = Bob, owner = grain 2.

Yes.

> The platform also makes a new entry in RoleAssignments that upgrade's Bob's permission level. (This is the step I hadn't considered before.)

I don't think that's necessary. Remember that `requiredPermissions` is checked against grain 2, i.e. the receiving grain. Bob presumably already has a RoleAssignment there because otherwise he could not have opened it to field a powerbox request. Bob does not need to have any permissions to grain 1 for everything to work.

> But what if a UiView capability gets transmitted without a user interaction?
> ...
> 6) Grain 2 transmits the live UiView to grain 3 over a pre-existing connection.

Is this a UiView that has been attenuated for a specific user, or is it the original raw object? In the former case, `userId` needs to be set to the user for whom the view has been attenuated. In the latter case, `userId` should be empty.

I think you're right, then: `requiredPermissions` needs to be based on a different property.


i get the point that having to learn about encrypted data bags is an extra step up the learning curve.. and lowering the curve is a good thing.. but, imho, unencrypted passwords in source control just outweighs the extra bit of effort..

w/ regards to roles, I think the main arguments against roles was that they're global and not versioned and that attributes defined in them make it harder to keep track of exactly which attribute overrides what..


@muriloaandrade acrescenta display: table; para wrap


You should move this function into the function body of $(document).ready(function(){ .


@muriloaandrade remove text-align: center;


Great job!


You have added versioning information to the build script. Looks good.


PHPCS: Whitespace found at end of line


curly braces on if statements inconsistent in example code.
609 has braces
617 drops the braces


Looks like it was happening when a user wasn't logged in. Pushed a new commit to fix it. Let me know if that works.


There's a lot of extra horizontal indentation on these lines that doesn't need to be here


else if statements aren't continuously indented like this.


Should use multiple lines


Do we know rd can't be empty?  If it is, `head $ lines rd` will raise an uncatchable exception.
Best to avoid all use of partial functions like `head`.


// FIXME: Horrible hack


Nice job!


Best to avoid partial functions like `tail`


it broke nothing, the ROM dev just needs to build this kernel inline so that the updated prima drivers should work.


remote the space between ( and {


ok good


remove the space between ( and {


uh .. cause I was in a meeting while doing this and obviously wasn't thinking


@bole007  On complete ATOM 2 CKAN, all institutions are checked and each time a request is sent to CKAN - this may be quite time consuming - you may want to first check the internal eag_harvester table, and only if you don't find in this table go and check CKAN for the institutions.
Hmm.. Normally, eag_harvester table must always be accurate, thus only checking of this table should be sufficient in optimal case and CKAN does not have to be checked again.


Combine these with `-o`


You could have done this in 1 test and got rid of a level of nested ifs, but I'm not going to quibble :)

`if url.scheme == "firefox"
  && url.lastPathComponent == "open-url"{...}`


typo - to "determine" if it has


I will appease the quibble!


If ret is non-zero, we should probably abort.


but then again, that's because we're going to have multiple paths later on to check!


This method needs to be indented.


this prototype needs to change as well.


Where on the UI is this supposed to display? I'm not sure this is working for me.


No, take it from the argments.


This was for #1711.


Nice job!


@oxtopus Why is `taurus` image built from ` taurus.metric_collectors` and not `htmengine`?


Yours or @mbonsma's?


rax retry tests


:+1:  for discovering the before block.

I am not sure this is the best solution for ensuring the users are logged in. The problem is as you add more pages to the app the if statement will become very big.

One solution here would be to keep a list of all pages that do not require a login in an array:

```ruby
before do
  OPEN_PAGES = ['/login', '/signup', '/']
  redirect_to '/login' unless OPEN_PAGES.includes?(request.path)
end
```


why this change? Do the test pass without it? If it fail without this, we can make a new issue to fix that as this is an not optimized case.


Yep, good idea, and already implemented in a follow-up commit! https://github.com/meteor/meteor/commit/29e33af748644bad08907f1135c7ce1938e3460c


@ankane from_now is throwing an error from 14400


It's not enabled for masses.  Not sure if it should be - might become a troll leaderboard.


Hello from FULL_TEST_CASE :p


@muriloaandrade utilize apenas o margin: 0; pois se você está querendo colocar as caixinhas lado a lado, não tem porque querer centralizá-las


Does it work that way?


This may have startup performance implications for command line apps that previously did not load pops. (Not sure it is possible to avoid).


@kalenjohnson


Looks good. While we're at it, we should switch to url_for(). Then we don't have to worry about escaping things. A good example is below in _tree_tuples().


Any reason to say location.href rather than just location? https://developer.mozilla.org/en-US/docs/Web/API/Window/location


Wonderfully clear, commented, and foolproof :-)


We already figured it out @austinpray, tattle tail


please ignore this one - on a newer ASDF (version 3) it just works


@bronevet

Code above is not needed. It was creating a duplicate SgFunctionDefinition. This caused the scope to be set differently all the arguments of the function. Removing this fixed the scope issues and also StxNamedMemRegion::isLiveMR code as well.


can we store these in localstorage, along with an index tracking how many times each user has used an ability improperly?


I like this. Commit early, commit often. In this case you've gotten a structure you're happy with. That is saveable.


Yeah! TDD for the win!


Related observation is fixed on:

https://github.com/fundacionjala/enforce-gradle-plugin/pull/134


I changed the `remove_entry(entry)` method to use `.delete(entry)` instead of the `.delete_if` method.  I also had to update the RSpec test.  Inside the `book.remove_entry(entry)` method, I passed it `book.entries[0]` to get at the entry that was added.


Not sure I like that we do this in the actual functionality. Can we remove this and do it as a helper in the tests instead?

Also, check your indentation before commiting!!


:+1: Nice refactor!


true, in that case, it's perfect just the way it is :)


Thx :+1:


lol.... you forgot this is git...all commited history is still there though. and commit message like "take out phone number for privacy reason".... :smile:


Hello from FULL_TEST_CASE :p


is this change required? - it makes it hard to read the delta


There's still a reference to NR on line 38 of the caching_controller that's causing the app to crash when deployed to Heroku without newrelic_rpm in the Gemfile


> var key = "user-"+rgEntry.actor_name;
> var current = parseInt(localStorage.getItem( key ) || 0, 10);
> localStorage.setItem( key, (current+1)+"" );


So, just as a small thing that I'm going to require. Use the following brace structure.

if()/method/function
{

}


another way we could have done this is to create an enum with all the possible lastPathComponents that we will expect and then use a switch here on that enum to get to the right behaviour, but that's the sort of thing we can leave until we actually do have more than one path to check. No point overcomplicating things when they are still simple


I only now register that it doesn't work at all....


TeamCity SupportNet Continuous Integration :: pypackage-copy-me :: 1. CI [Build 1](http://build.mentorg.com/viewLog.html?buildId=329001&buildTypeId=SupportNetContinuousIntegration_PypackageCopyMe_1ci) is now running


This got my attention because it removed background from my circular checkbox i just wrote yesterday.
Is it legit to write `background-color: none transparent;` ?


Wow, that's a lot of changes... It worked!

Thanks Alex.

On Wed, Jun 17, 2015 at 6:29 PM, Alex Stophel <notifications@github.com>
wrote:

> Looks like it was happening when a user wasn't logged in. Pushed a new
> commit to fix it. Let me know if that works.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/benjaminmodayil/bloccit/commit/492fc13af4229b27dc8e8460184dae78339d2258#commitcomment-11735591>
> .
>


TeamCity SupportNet Continuous Integration :: pypackage-config-override :: 1. CI [Build 17](http://build.mentorg.com/viewLog.html?buildId=329002&buildTypeId=SupportNetContinuousIntegration_PypackageConfigOverride_1ci) is now running


TeamCity SupportNet Continuous Integration :: pypackage-copy-me :: 1. CI [Build 1](http://build.mentorg.com/viewLog.html?buildId=329001&buildTypeId=SupportNetContinuousIntegration_PypackageCopyMe_1ci) outcome was **SUCCESS**
Summary: Running Build time: 00:00:22


Remove unused dependencies


TeamCity SupportNet Continuous Integration :: pypackage-config-override :: 1. CI [Build 17](http://build.mentorg.com/viewLog.html?buildId=329002&buildTypeId=SupportNetContinuousIntegration_PypackageConfigOverride_1ci) outcome was **SUCCESS**
Summary: Running Build time: 00:00:19


It would track offenders across games.


Thanks for libserial. Please send me your pal address to "kivig"+var+"inbox.lv"; char var=64, if I may buy you a beer/coffee.
[Comment may be deleted after reading]


In short: This change needs to be reverted and the issue investigated further. I'm trying to investigate it, but I'm now sure I have sufficient knowledge about UMS or uPnP/DNLA to figure it out.


Instructor and staff should be `FORUM_ROLE_MODERATOR` not `TA`. I think.


You have logic in the view here. It's good to avoid that completely.

In this case the logic on line 35 is checking to see if the current user upvoted the song. You could move this logic in the song model.

```
# app/models/song.rb
class Song

  def upvoted_by?(user)
    Upvote.where(user_id: user.id, song_id: song.id).exists?
    # Sidenote: you could refactor the line above to:
    # !!song.upvotes.find_by(user: user)
  end
end
```

Then in your view you can just call the upvoted_by? method on the song.
```
<td>
  <% unless song.upvoted_by?(current_user) %>
    <%# Show buttons here %>
  <% end %>
</td>
```


Be consistent, all other variable names are using camlCase, do the same for this variable.


Yeah, fairly certain there's already a contingent of anti-scripters out there, tagging along and nuking our WH targets.


为什么要默认MySQL呢？应该默认MySQLi啊...


On our processor, int is 4 bytes, right? So then I would think it isn't large enough for this to be valid for all s32's. Might as well make it a valid version since it's easy.


Nice work!


Hello from FULL_TEST_CASE :p


nit: I know int should be able to hold all the differences in all the u8s we could want, but is this compiler defined or language defined?


@bradenmacdonald No, everyone is a TA now. Otherwise they won't get the TA label in Apros anymore with the new changes. Also the permission sets between moderator and TA are identical.


Uh oh, validate_parameters is used client side as well and may be used in types and provider plugins even if not done in the puppet code base - this changes the API of resource which makes it impossible to add this in 4.x - may not be possible to deprecate/change etc. Ping @kylog.


OK, but the point I'm making is not that encrypted data bags are bad, but that there are other options other than encrypted data bags to secure your attributes and we shouldn't force users to use them.


This is my HTML5 project location.  thats it!!


Was this change actually made for the security fix? It breaks passing non-form elements with an href attribute to handleRemote


Not quite the right logic here -- you need to remove any existing scales that aren't in the new array. See `Plots.datasets()` for an example of how to implement this, and let's add a test for the functionality.


Kivig2: Thanks and I really appreciate the offer for beer/coffee.  If you like, please buy a random stranger a beer/coffee and make their day!!
[I will delete both comments shortly]


I'm into it.  As part of my upgrade process, I need to actually abandon this page to reduce the customizations I have from the latest release

I am actually going to see if anyone wants to make a new splash page for jd.com, and I'm happy to incorporate these needed copy changes to this page.


It was fixed on https://github.com/naverus/enforce-gradle-plugin/commit/b97dd33a17c2a43823f5d61cceba6b3ef0f4129d


need to update the include guard to proper file name


I think DBI should be generic. Why **mysql_auto_reconnect** is used?

    $dbh->{mysql_auto_reconnect} = 1;


TeamCity SupportNet Continuous Integration :: pypackage-config-override :: 1. CI [Build 18](http://build.mentorg.com/viewLog.html?buildId=329004&buildTypeId=SupportNetContinuousIntegration_PypackageConfigOverride_1ci) is now running


TeamCity SupportNet Continuous Integration :: pypackage-copy-me :: 1. CI [Build 2](http://build.mentorg.com/viewLog.html?buildId=329003&buildTypeId=SupportNetContinuousIntegration_PypackageCopyMe_1ci) is now running


class name should really be GroundPlaneError


Issue #3: Changes leadership links from evewho to evegate.


TeamCity SupportNet Continuous Integration :: pypackage-config-override :: 1. CI [Build 18](http://build.mentorg.com/viewLog.html?buildId=329004&buildTypeId=SupportNetContinuousIntegration_PypackageConfigOverride_1ci) outcome was **SUCCESS**
Summary: Running Build time: 00:00:09


TeamCity SupportNet Continuous Integration :: pypackage-copy-me :: 1. CI [Build 2](http://build.mentorg.com/viewLog.html?buildId=329003&buildTypeId=SupportNetContinuousIntegration_PypackageCopyMe_1ci) outcome was **SUCCESS**
Summary: Running Build time: 00:00:18


note the style guide for indentation (2 spaces)


Кодировка посыпалась:
return "Îøèáêà ñîåäèíåíèÿ ñ ñåðâåðîì"


Where is z_height defined? Also, this param should be on it's own line


TeamCity SupportNet Continuous Integration :: pypackage-copy-me :: 1. CI [Build 3](http://build.mentorg.com/viewLog.html?buildId=329005&buildTypeId=SupportNetContinuousIntegration_PypackageCopyMe_1ci) is now running


TeamCity SupportNet Continuous Integration :: pypackage-copy-me :: 1. CI [Build 3](http://build.mentorg.com/viewLog.html?buildId=329005&buildTypeId=SupportNetContinuousIntegration_PypackageCopyMe_1ci) outcome was **SUCCESS**
Summary: Running Build time: 00:00:09


update include guard name


As always I gladly hear your comments, even if it's things I might already be aware of.
I know that some things are not very good for now, but it's a work in progress. I always try to make things not to bad at first, but there is always some cleanup needed (like renaming thing whose job has changed or determining whose method really needs to be public).


TeamCity SupportNet Continuous Integration :: pypackage-config-override :: 1. CI [Build 19](http://build.mentorg.com/viewLog.html?buildId=329008&buildTypeId=SupportNetContinuousIntegration_PypackageConfigOverride_1ci) is now running


TeamCity SupportNet Continuous Integration :: pypackage-config-override :: 1. CI [Build 19](http://build.mentorg.com/viewLog.html?buildId=329008&buildTypeId=SupportNetContinuousIntegration_PypackageConfigOverride_1ci) outcome was **SUCCESS**
Summary: Running Build time: 00:00:09


this can't possibly be compiling....


Wenn du meinst dass wir die Bridge ausprobieren sollten, mach einfach nen Pull Request, vllt kannst du ja dann in die Wiki schreiben wie die Befehle aussehen sollen. Werde bis zum Wochenende denke ich noch was machen diesbezüglich.


> Bob does not need to have any permissions to grain 1 for everything to work.

Sure, but the ApiToken made in step (3) is not going to be able to do anything until Bob has some permissions for grain 1. My feeling is that if we're automatically updating userId to be Bob, then we should also automatically update Bob's permission level so that the saved capability is actually useful.

Would there be any problem with setting userId = Alice instead? That would be simpler, and would consistent with thinking of `userId` as part of the "provider", i.e. the fields that specify "how to restore this object". I think that usually the provider will remain constant in chains of saves and restores.


add comment noting end of namespace


add comment with include guard name (see the checkerboard file this was copied from)


In `Ledger::read`, you're returning `std::move(sle)` with the explanation
```
    // need move otherwise makes a copy
    // because return type is different
```
Is one incorrect, or does the use of a `Slice` here change the behavior in a way I'm not seeing?


@daniel-g please review


Retain license headers when copying files


I prefer not to rename `ticketOwner` to `sle` because there's an `sle` in the outer scope (declared on line 164).


It looks like there is an extra <br> at the bottom when we did not used to have one, and a missing one at the top. It's not a big deal but could you sort it out?


@eregon I think there is a new MRI test regression near one of these commits:
```
     [exec]
     [exec]   1) Failure:
     [exec] TestEval#test_cvar_scope_with_instance_eval [	from /home/travis/build/jruby/jruby/test/mri/ruby/test_eval.rb:387]:
     [exec] Failed assertion, no message given.
     [exec]
```


indent 2 spaces


[![Walks in the Dark](http://api.artsmia.org/images/123066/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=123066)


[![Thunder Up Above Series](http://api.artsmia.org/images/123067/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=123067)


missing closing brace?


Oh, hah I wrote bracket return and it got marked up somehow.


:+1: very nice


this is not actually used, remove


@XinyuHou Log lines are always lower case, please fix this.


this is definitely not right


Especially: "For the other things, I can run static code analysis tool myself."

Well if you can, then do! And if you don't want (I didn't see any fixes so far) then stop being snobby and accept those pull requests. Everything else goes against everything open source software stands for and helps nobody (except maybe @donho 's ego, which I really don't get).


Why include this block at all if we're using the defaults?


good fix :disappointed_relieved:


Thanks.  I’ll fix that.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Wednesday, June 17, 2015 1:33 PM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Allow CTRLC to work when running under lldb using the SOS plugin and debugger dlls (bca300a)

It seems it would be safer to create the pipe before creating the signal handler thread. Otherwise the thread could attempt to read from a handle that doesn't exist yet and would abort.

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/bca300af76baafccd169c859bc84d943ae34ab07#commitcomment-11733681>.


Shouldn't the whole event be removed then?


@rodrigopavezi being the first commit I couldn't create a PR for it. In any case, can you review/take a look at this commit? Just basic copy & paste/search & replace work. Thanks.


Yeah I figured it out a few minutes later.  The problem is if someone is linking it as part of a larger library you're now linking in the full startNote and stopNote functionality - even if that functionality isn't actually users.  For Arduboy we've added the ability to play tones also - so it's possible to just play a certain frequency without even using all the music stuff - yet those routines are still compiled and linked because they are called during init.

Any objection to a PR that JUST did the necessary timer bootstrap vs calling both those functions?


@jeffrymorris I'm a little bit concerned about dropping the entire `bucketConfig` into the logs, considering it has credential information in it. This is definitely a security issue.


Good catch, @chrif . I assumed this would transpile to a for loop, this being the only CoffeeScript I've ever written.


Just a heads up, you could rewrite this as:

```
<% if @new_song && @new_song.title.blank? %>
```


I'm asking about domain specifics not C++ mechanics. How do you feel about passing `CachedView` where `View` is expected in the business logic? Does this achieve the goal? How does it compare to `Ledger::getSLEi` which it replaces?


You got eagle eyes broseph, this deserves the same treatment!


this is ok


Good assumption.


r+


Is this somehow different than `System.FilePath.dropTrailingPathSeparator . toFilePath`?


In addsong.erb you are checking if `@new_song` is defined before pulling in the value of a field into an input element:

```
 <input type="text" name="author" value="<%= @new_song && @new_song.author %>">
```

If you changed this action to:

```
get '/addsong' do
  @new_song = Song.new
   erb :addsong
end
```

Then you no longer have to check if the variables are defined in addsong.erb.

```
 <input type="text" name="author" value="<%= @new_song.author %>">
```


saw approval from MonsieurNicolas
at https://github.com/graydon/stellar-core/commit/c313eca9a824b74ca4f873575d9a3e71b52fa1df


merging graydon/stellar-core/loadgen-fixes = c313eca9 into auto


graydon/stellar-core/loadgen-fixes = c313eca9 merged ok, testing candidate = 7331642a


what the hell


Whoops! Didn't see that. `sleAccount` and `sleTicket` then.


At least it's not on the site


Wait no, that's not right ether, its not the SLE for a ticket its the account root of the ticket owner which I guess can be different from the account? Is this that "ticket target" thing? Anyway I think `sleAccount` and `sleOwner` might be appropriate.


@AllPurposeName thinks he deserves credit for this. He doesn't.


This update moves the orb up from the bottom of the screen to prevent iOS intrusion into the game. The orb is also resized which reduced accuracy, this is compensated for by returning to the ancient method of shooting from the center of the orb instead of the user's touch point.

Implementation of UI icons, and layouts.

TODO: Prune unnecessary image assets from project.


You don't always simply install with a Python package. And we bundle py{2,3} builds.


This is a little bit racy:

1. you remove the file
2. the daemon dies
3. you fail to kill the daemon

Additionally the file could be a leftover if the pigpiod daemon dies for any reason.  These types of things in Linux are usually delegated to the init system that has the proper knowledge on how to stop the daemons. Could you start/stop the daemon through the init instead of this?

Anyway, I'd just like to contribute here. I don't have and I am not using RPi so if its maintainers think its overkill, feel free to ignore me ;-)


Hrm. I think the ordering of what I had could be shuffled around and still handle the returning value of nullptr.
Something like:

    if (handler == nullptr)
    {
        delete requestWrapper;
        return NULL;
    }

or something...

That way the ResourceHandlerWrapper can be the "disposer" of the requestWrapper, frameWrapper, and if necessary the browserWrapper.

Bill


This should be a regular comment `/*` not `/**`. Rationale: Its in a .cpp file, its test code, and no one else is going to call it. So it doesn't need to be picked up by Doxygen.


Haven't had a chance to refactor https://github.com/numenta/numenta-apps/blob/master/taurus/taurus/engine/webservices/tweets_api.py#L35-L39 out, yet.


You've been getting a bit rusty doing these challenges.

Yay terrible pun!!


I don't know if this binding.pry works outside of a method. If it does, a good way to make sure you don't accidentally commit them is to run the tests, they will stall whenever it runs into a pry.


Hehe


edited this in the latest commit. Thanks for the heads up!


The remaining gap with this solution is it doesn't cover multi-threaded or distributed computing scenarios (as far as I can tell).    The random generator within ND4J is static, and is set by the nnconf builder, thus the most recent conf will overwrite any other confs.  The seed isn't set at all in Hadoop or Spark scenarios where the conf is serialized and sent to other cluster nodes.   Admittedly a tough couple of problems to solve without design changes to ND4J.


alue |= o 09348/32


I think I just tried it, but i dont remember :)


@NyKaren vc criou uma branch de a partir de uma que ja estava finalizada, não posso aprovar o pull request, entendi que vc se atrapalhou, essas alterações deveriam ser na branch que da o conflito


hmm.. now on Windows with MSVC2012 I'm getting:
C:\projects\libical\libical\src\libical\icaltz-util.c(61) : warning C4005: 'bswap_32' : macro redefinition
        C:\projects\libical\libical\src\libical\icaltz-util.c(48) : see previous definition of 'bswap_32'


done! I'd be happy to add you to anything I maintain, you're a great maintainer...


pls no


nice


When I have the commit message state that the change was for comments, I expect there is no other meaningful changes. Adding the @balance return is more than just a comment. Also careful about committing binding.pry


It is worth noting that an option to disable this process will be necessary as some simply won't get pass reconfiguration.


Really, this just seems like SDL being stupid, but whatever.


rax retry tests


This solution to issue #304 depends on the intention of the future design of the project, Will the 'hierarchies' section be required? Will a default hierarchy be required?


I like seeing formatting commits being in their own commit away from code commits. :)


FWIW I just grepped a recent drop (May 27th) of the forge and found no uses of `validate_parameters`.

I haven't grokked this entire PR, but if we're merely deprecating this attribute, but not removing it, that seems okay.


So I understand with #each you can yield to a block. Why is there a stray value hanging around? Is it used as the argument to the block passed to #each ?


The `cmd` in the `assert_tc()` method has been updated.


Im guessing this is used to make NotUris function as any basic array would?


It looks like this commit actually removes comments instead of adding them.


> except maybe @donho 's ego, which I really don't get

Whoa, pump your brakes! Or at least take it down a notch.

While I strongly disagree with his decision, I know that everybody has their own reasons. Lets keep the *ad hominem* attacks to a minimum (i.e. zero).


you can simply all of the above to

```
if err := json.NewDecoder(weatherRes.Body).Decode(&weatherResponse); err != nil {
  // you also probably should not panic because that will kill your binary, perhaps better log
  log.Printf("error decoding the response body: %s", err)
  return
}
```


you should check the error here, and log it as above.


This property should be private, it's not for end-users. Users should use `selectable`.


log instead of panic.


This is kind of cryptic to me. Is this the same as saying #to_a on something? Since this is attached to the solr_document. Im kind of confused as to how this works.


use cherry-pick - don't steal


not sure if you meant to leave this in?


you don't seem to do anything with the `red.Body` so you do not need to close it.


Seems  like we can avoid saving identity of each activity if we are not creating new instance of `BranchWindowCallback` for each activity. Can we create an instance of  `BranchWindowCallback` in the `Branch` class and set that for each activity?


I'm not a woocommerce expert, but I think the maxlength change needs to also be applied to the state. See this line: https://github.com/woothemes/woocommerce/blob/master/includes/wc-template-functions.php#L1748


It's idiomatic to return a `nil, err` if an error occures above unless you intend to do something with the config regardless of the presence of the error.


Sure didn't. New commit incoming.


Maybe, although I wouldn't want to have all the messy OCR stuff in two places.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/67288878


Is there any merit to returning -3, where they are both invalid?


`"config.json"` should probably be a flag. so:

```
var configFile = flag.String("config-file", "config.json", "The path to the config file")

func ReadConfig(configFile string) (Config, error) {
  var config Config
  file, err := ioutil.ReadFile(configFile)
[...]
}

func main() {
  flag.Parse()

  config, err := ReadConfig(*configFile) // configFile is a pointer to a string so you need to pass in the string
}


Well, using the term 'uncaught' seems fine here. As for making a boolean config value, that would simplify the code and validation, so I like it.


Yes. http://rubylearning.com/satishtalim/ruby_blocks.html might help


Am I missing something? Or is the commit message wrong?


[] is...special.
```ruby
s = SolrDocument.new
s[:bla] # => This is the same as s.[](:bla)
```


Err... should this stuff be public?


How should I mark it as private? `_` or `__`?


Nice! :+1:


fast-forwarding master to auto = 7331642a


@alexandreinfo @pedro-guimaraes @marcoafilho  lalalalalala lalala


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 70](https://teamcity.labkey.org/viewLog.html?buildId=255555&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 24 Build time: 00:33:24
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

```


Haha. Sounds good. I think I'll do the same.


is there a reason this is in the script rather than in shippable.yml?


added! Thanks :)


No particular reason, I'm just more accustomed to specifying href.


Is there a simple or analytical way to calculate this maximum?


To clarify, I feel a little funny setting the Location object to a string and having it work correctly.


Definitely tough. Weight initialization with the seed wasn't working at all which was what led to this fix and it's crucial for tuning which is where I'm focused. There were mixed references between DL4J's DefaultRandom and Random vs ND4J's DefaultRandom and Random classes. I focused the solution on ND4J as a single source of truth. However, I hear where you are going with distributed. Recommendations are totally welcome on this.


You can't assume that it is `default_exception_ce`. This should be able to be fixed like this:
```c
	object = getThis();
	base_ce = zend_get_exception_base(object);

	if (zend_parse_parameters_ex(ZEND_PARSE_PARAMS_QUIET, argc, "|SlO!", &message, &code, &previous, zend_ce_throwable) == FAILURE) {
		zend_error(E_EXCEPTION | E_ERROR, "Wrong parameters for %s([string $message [, long $code [, Throwable $previous = NULL]]])", base_ce->name->val);
		return;
	}
```


LGTM


1682_waterheater_stratified (mbadams5) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2161 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.56%25-yellow.svg)


@benbenwilde -

Yeah, I agree. Its super useful for debug purposes, so maybe better if password at the least was omitted. TBH, this shouldn't be logged to INFO...maybe DEBUG only, since you really can't use DEBUG in production.

I created a ticket here: http://issues.couchbase.com/browse/NCBC-920

-Jeff


Ha! Hey Scott ya sneaky bastard. I decided to try pick up a systems language and settled on rust, gotta start at the bottom with this one, especially after coming from Python.


Zookeeper managed rng state

/thread
On Jun 17, 2015 4:46 PM, "Melanie Warrick" <notifications@github.com> wrote:

> Definitely tough. Weight initialization with the seed wasn't working at
> all which was what led to this fix and it's crucial for tuning which is
> where I'm focused. There were mixed references between DL4J's DefaultRandom
> and Random vs ND4J's DefaultRandom and Random classes. I focused the
> solution on ND4J as a single source of truth. However, I hear where you are
> going with distributed. Recommendations are totally welcome on this.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/deeplearning4j/deeplearning4j/commit/fdded78bfec62e944c7f53984be5fa772a6f120f#commitcomment-11736570>
> .
>


Thanks a lot for this :)
And of course for the other commits as well.


`mediums` -> `media`


lgtm: r+


We should probably fix this to not be the case, so that if you subscribe to `open-file` in ready, you just get the callback immediately played back to you


*Grower lol


Thanks for the feedback and education on string management.  I'll resubmit.


I probably would have done it the same way, but I'm curious why you didn't just do away with the single_diff function now that it's nothing more than a call to intersection_map.


I like the idea of cleaning up these tests. Taking out tests that will be tested by other tests is a great way to make sure the tests don't get bloated.


This appears to be missing a closing ?>


You're right but we must differentiate between two things. PrestaShop needs access to the network to install. What is even more disturbing is that personal data is sent without the permission of the user.
I'll try to make other PullRequests


done


this function is gone in a later commit


The spacing seems odd here. Some lines have a leading pair of spaces, and others don't.


`int` is defined to be at least 16 bits so this is safe, I'll make a more explicit version though that also works for the `s32`s etc.


`sizeof(s32) == sizeof(int)` on our processor but its only guaranteed to be 16 bits so I'll make a more portable version.


Whoops


I think it needs to be early for correct interaction with loseAllAbilities which is at ability layer


ddddddddddddđ


Yes, that's a good point - not so much of an issue for Snow as it's already dependant on abilities.


I made an inline comment because I forgot to comment here (learning curve).  Like my comment says: is there a reason why the two lines at 148/149 or 158/159 are better than list.remove(element)?


Btw, it doesn't work by only changing the Layer indicator. At game layer, the method called is modGame not modAbility... I'll fix it.


I'd abstract out the awk fq2fa bit so it isn't repeated.


Yes, that stack trace is very useful.  So this really has nothing to do with the registration service and you just mentioned that in passing?

It seems like your client is trying to disconnect the client when it gets the disconnected message.   net.qb.network.NetworkStateClient.clientDisconnected
...that's going to cause problems because the client is already closed.


eclipse RCP小例子


> eliminates some redundant considerations as Snow mana generating permanents always generates Colorless anyway

Hmm, taking this to the extreme, colored permanents also always generates colorless mana as well. So so it seems that we can limit the mana used to pay for Colorless cost to be the Colorless mana type.


i was looking for something like this, done


This revision is clean.


You will still have sockets timing out if they were in IDLE mode before.

```
In [1]: import socket

In [2]: socket.setdefaulttimeout(10)

In [3]: s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)

In [4]: s.connect(('localhost', 2000))

In [5]: s.gettimeout() # as expected
Out[5]: 10.0

In [6]: s.setblocking(0) # called at the beginning of imapclient's idle_check method

In [7]: s.setblocking(1) # called at the end of imapclient's idle_check method

In [8]: s.gettimeout() # oops, the timeout went away!

In [9]:
```


Interesting art stile for the tokens, looks really great! Good job!


createdDate should be changed to createdAt which is automatically generated by Parse.


Will need to make assignees objects w/in the array and add those attributes to be collected on create form.


Are we keeping documents? We can't have users upload or choose from drive. Maybe just URLs?


Will need to add submittedBy and activity attributes.


Per #4.


this sh** made me mad ... But this is needed ..


nice job with the HTML skeleton and gulp! :+1:
I guess we might want some gutters on our grid at some point and some JSON-key specific placeholders inserted, but that'll have to be accomplished when we get the chance tomorrow and can figure out what all those are. :sleeping:


Ah, I see you did try using constants (in re: comment about `bank_info` private method). What you can do is specify `self.class::CONSTANT_NAME`. Then the constants defined by the child class *do* override the parent class.


hello github


Should be fixed now.


Fixed and resubmitted to GitHub. However, I'm having some issues with
running it. The app runs on my local host just fine and dandy, but when I
upload to s3 it never renders my search. I've been working a few nights on
this and still can't get it figured out. Any ideas as to why this is
happening? Thanks!

On Sat, Jun 13, 2015 at 3:52 PM, Jeff Dean <notifications@github.com> wrote:

> What's here looks great. The final requirements for the project included a
> search bar on the index page, so users can search for any kind of movie,
> not just cats. Can you please change index to have a search box (a form
> with a get, and querystring parsing code) and redeploy and resubmit?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ashleypelan/omdb-client/commit/f36aa47fe9eeff844af5cca59c5eb7d03655eb1a#commitcomment-11668013>
> .
>


cool


Your last suggestion is good if you think there would be less maintenance or better stability in the long run by using the SciPy code.

At this stage, it is probably more work pulling it out and replacing it with SciPy's implementation!


Sounds good but have you seen any reliable way to identify needed firmware from the config file or vice versa?


DPS carries over, so if level is > ..450 and < ..501 it should disable all
damage, probably, just to be safe.

ons. 17. jun. 2015 kl. 01.44 skrev leeps <notifications@github.com>:

> Or not clicking for 5 seconds, then resuming?
> Or only people with other elementals click, as long as elemental max
> damage is not casted (probably unlikely)?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SteamDatabase/steamSummerMinigame/commit/a68dfb298b72cefde2a5cf05e8d135268621d82e#commitcomment-11714757>
> .
>


Future-proofing the mana may be better than having Colorless being a separate mana. Lots of abilties are concerned by what color was used to pay for colorless (Sunburst and <if [color] was spent to pay> for example)


Looks like you misspelled "canola"!  Let me know when you've updated the change.


How else am I able to create 15?


What does the ++ stand for?


@eteq: This version of the rise/set time calculator uses AltAz (which I'm frankly embarrassed for not knowing earlier). Next step: using `scipy.optimize` to calculate rise/set times with arbitrary precision.


Is there a specific reason we need `inverse_of`? From what I could read in the [docs](http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html):

> Automatic inverse detection only works on has_many, has_one, and belongs_to associations.

So our current records all have inverse detection as is. Could you perhaps give an example that will show why this addition will provide value to our code?


If this open else statement wasn't here would the #`s not divisible by 3,5 or 15 show up in the console?


Whoops. Missed this :blush:  Good catch!


A very nice start. I am a little nervous about the dependency on csvuniq... hopefully everyone can get that working. For conditionals I would skip it. Loops ... perhaps something very simple using 'seq'?


You should probably add this to the enforcer blacklist, along with a comment pointing to the replacement artifact.


Has this merge been pushed to Steam?


Could we just have @atombaby install csvuniq?


This would probably read clearer if you had
```ruby
invalid_message = Message.new
valid_message = Message.new(body: "hello world")

expect(invalid_message).not_to be_valid
expect(valid_message).to be_valid
```


I see, so it is better to make it so that any colored type or colorless can pay for colorless cost and remove the colored type from being generated by colored sources. This way we can track the color of the type.


Also, I think we should have model validations that a `Message` must have a user attached to it as well.


I found my pearson's test give me r=0.19795112500667397 with p=0.084397024355638312. so at p=0.08 level, it is unlikely there is a correlation between income and affordable housing numbers.


Yes, that would be perfect.


This is a test


This is retarded. It yells at me when in fact i have a cpu that supports this retardation


You dont care about if the cpu supports it you only care if the intel supports it and is intel


It may be smarter not to force the connection of messages to be created on a room until it has already been successfully saved. Something like:
```ruby
room = Room.find(params[:room_id])
message = Message.new(message_params)
if message.save
    room.messages << message
    flash[:success] = "Your message has sent!"
else
    ...
```
This way we are not creating links until they are needed. I'd be curious to know if you have a differing opinion.


related #174 #275


Why is there a duplicate set of flextGL.{c,h}? I am confused.


Let me double check this tomorrow when I get in.


```
/home/xlz/src/libfreenect2/examples/protonect/viewer.cpp: In constructor ‘Viewer::Viewer()’:
/home/xlz/src/libfreenect2/examples/protonect/viewer.cpp:20:18: warning: converting to non-pointer type ‘GLuint {aka unsigned int}’ from NULL [-Wconversion-null]
     triangle_vbo = NULL;
                  ^
/home/xlz/src/libfreenect2/examples/protonect/viewer.cpp:21:18: warning: converting to non-pointer type ‘GLuint {aka unsigned int}’ from NULL [-Wconversion-null]
     triangle_vao = NULL;
                  ^
```


Nitpick: `addFrame` instead of `AddFrame`?


And if nobody in the room has any more wormholes, we slow the room progress on purpose...


indentation issue


You can use either something like `Tamaggo Inc <jvidunas@tamaggo.com>` or `Joseph "UpAllNite" Vidunas <joe@vidunas.net>` (up to you) but probably not that.


agree


OK; great. Thanks.

I think it would be nice to be able to point folks to their `.bashrc` and how to edit that anyway. That's a pretty key 'nix thing to be vaguely familiar with. They're going to be figuring out how to edit anyway. I can defer to you on that though. Having the script installed to the module would certainly make things more convenient...

How about for conditionals I just do a single slide so they're generally aware of them. Just an example, and simple explanation?

For loops what I had in mind is something like

```bash
for filename in *.fastq; do
  program "$filename"
done
```

Could add something very simple like that to the script to illustrate how they could run something for everything in a collection. What do you think?


`__attribute__(x)` is not portable.


To be clarified


Agree


The new shader files `grayrender.fs`, `render.fs`, and `render.vs` are duplicated here as std::string. Is this necessary?


@Rarity1 be constructive or you'll be blocked.

AVX is required. Are you saying your processor supports AVX but does not report it through the standard CPUID feature?


전용채널에 도메인이 없을 시 에러메시지 추가하였습니다.


1682_waterheater_stratified (mbadams5) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2151 of 2214 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.15%25-yellow.svg)


Rehman Remo ullah
Add me fast liker and fast commenter
Awosame
Great
Add close karlo ya phir unfriend karlo
Just now 2
Just now Looo
Ok Remo


Add RFC reference?


Yes amd fx 8320s do support avx but 30 minutes to an hour ago the thing was throwing the unsupported cpu error and now the thing opens but it closes right away.


Judging by all the merge commits, have you had this sitting in your local copy of release-0.3 for 9 months?


Looks like this makes it impossible to run e2e networking tests on a single node.   but  i think networking.go should work on single nodes - in fact - its an important test for local development imo.  is there a way we can dial back the `nodes >= 2` requirement?


Ok i read the error list and now its claiming that my cpu isnt even AMD64


Any reason why we are using a `hidden_field_tag` here? They are kind of icky. Is there no other way to get this `
`form_for` working?


@Rarity1 Delete the xenia source, and reclone and rebuild it.


Alright


Also, might I suggest using
```ruby
<%= message.body %></br>
```
on line 7 so that the messages don't show up inline?


@deepak1556 Thanks for the head up, this is actually used by an internal project which only needs to ignore connections limit on a certain domain, so a command switch should do the work for now.


Is it possible to support windows with arbitrarily names? This limits the names that can be recognized.


WUT!!!


TODO: going back to the page does not repull data, so the newly written review does not show up..


'Make yourself the author' He says.  'It'll be fine' he says.


I don't like much the idea of having a mutable classloader here.


diff内容が2つのことをやってるので、コミットを分けるか、一言足した方が良さそう (revert chance?)


- Remove ',' in the last line
- jsonfile
 - Why we should this library than simple basic file IO?
 - Any reason to fix the version "2.0.1"?


1682_waterheater_stratified (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I think you misread that quote, it only works on Relations which we have. It's not automatically applied. From what I've gleaned, inverse_of takes a small toll on the creation to prevent database queries in the future. There is almost no reason to not use them except perhaps because we want the messages handled as quickly as possible.


yes, it'll be on https://github.com/rathena/rathena/commit/b71ed058573af7d3c7ed04f7fadef38fd05dda09#diff-d96b6365b4bdad78139e676d6e7e3295R7366


It says something about a mismatch between architecture or something between the project being built and the architecture of the reference processor when i launch visual studio. I think it might be my fault but i wouldnt know how to fix this


I don't think "#init" is necessary.


@yohm
ここでのiconはfont awesomeではなく，png画像のiconについて？
それなら画像がfaに置き換えられたので指定する必要はない？


Does not call callback in case of err?


@jedevc Why is this bad? They're constants.


Yeah, that's gonna be a problem. We could store a variable with how many wormholes got used in the last jump level and if that amount is lower than a set threshold it assumes people are out of wormholes?


Sounds perfect


In fact during my code-challenge review, Cheek said to keep basic model tests inline and succinct. My test in that project looked almost exactly like what you suggested and he refactored it in the way that I PR'd. I tend to agree with him because the test is so short, not much is happening to necessitate breaking it out further. I'll shorten it to ```expect(Message.new).not_to be_valid``` I wasn't aware of the be_valid method, thanks RSpec.


Thats all its saying. i pretty sure "The program '[4400] xenia.exe' has exited with code 0 (0x0)" means it had no errors


@takeshi-uchitane 記憶が曖昧で申し訳ないのですが、custom.css.scssの .i.padding-8 の指定についてだったような気がします。今pxで指定していますが、emで指定したほうが良いと指摘されたように記憶しています。
優先度は低いのでそのままでも良いです。


Change to more specific name like removeAlarmJob.


> remove the colorless type from being generated by colored sources.
implemented in https://github.com/magarena/magarena/commit/d71315c93b419e39efa7381e2b2c1fd0120da195


Oh and I have mixed feelings about the message/user validation. There are times a message could belong to no one. In ol' IRC you could call things like ```/time``` and it would produce a message of the current time. It didn't really belong to anyone, but simultaneously we could make there be a flackbot pseudo-user for just that case.


It might be a good idea to add a ticking noise and buzzer for the timer.


I completely agree.


@heitorlemos , os brs devem ser utilizados apenas para separar textos, aconselho que estilize as margins no seu css para conseguir o espaçamento que deseja.


Can't you use #{$small-up} here instead of the em value?


I dont want to spam but is "Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF348, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF4D0, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF488, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF6F8, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF5A8, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF7D0, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF5A8, 0x0000000000000000).
Exception thrown at 0x00007FFFDDBE8B9C (KernelBase.dll) in xenia.exe: 0x406D1388 (parameters: 0x0000000000001000, 0x00000094CCFAF748, 0x0000000000000000)." Normal?


Opened #40806 for consideration.


1682_waterheater_stratified (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (2190 of 2214 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.92%25-yellow.svg)


I assume you meant 'sizeof' in the comment?


링크시 config 생성 안되는부분 수정.


@yohm analyzrのshowページにdestroyボタンが存在しているのでリダイレクトは必須


@monteirocode Thanks a lot! I want to focus on tweaking specific language highlighting next.


Please delete this.


So here is the problem with this form: it passes the message information, but not the room with which to associate the message. The easiest solution is something hacky like ```Rails.application.routes.recognize_path(request.referrer)[:room_id]``` The next two ways would be a hidden field, which I used, or namespacing the rooms so the message's url contains the room's. And lastly we could send an array into form_for. I personally really don't like multiple instance variables passed to the view, so I would prefer steering clear of that solution.

The reality of the situation is a presenter could be used to send down a single message variable which would handle all the current functionality including taking care of passing the right room to messages#create. I don't want to refactor that before we decide whether we are going to replace this entire feature with JavaScript.


I think this should be a function, not a method

func Run(cmd *exec.Cmd, opts ...Option) {

...

}


Omg im an idiot. I think the reason its closing now is because i didnt start it with a game. I think i know how to open games with it now


line 7 needs a div, maybe, but that's front end's problem :stuck_out_tongue_winking_eye:


@takeshi-uchitane 潜在バグですね。analyzerのデータテーブルから削除した場合もちゃんと動くことを確認しておいてください。


Might make a good partial!


This time it's pretty good. `scmutils` had a few inline sanity checks in the comments. However, I noticed that we are usually not consistent with them up to `machine-ε`. I don't know how serious of a problem this is. I really don't think that its a mistake in the code, but rather in the numerics implementation of all the primitive floating point operations. We will see how things go when we use fixnums. At that point we should be good up to the fixed precision (hopefully).


Do you care about the unqualified imports here? I suppose We should qualify them anyway... I'll do that next commit.


This is not a message board, please take it elsewhere!


=# datasciencecoursera


Adding link to parent of Variable product


:+1: Love this


You could at least make a button to switch between the two


When the reset is asserted after copying the DDR code, NIOS does not go to reset state and ARM hangs on the while loop. So the reset de-assert in the beginning of the function was removed so that NIOS stays in reset till the code is copied to DDR. Once reason for this would be that as now the exception stack is on the tcm(after the optimization), once NIOS was out of reset it starts execution which would generate an exception and the next reset assert does not take effect.


log.warning is invalid here @sandsower


Sure! => #1


先写一个hello world看会怎么样？


In that case @hyi your current implementation looks good.


Same thing would apply to
https://github.com/collective/collective.transmogrifier/blob/master/src/collective/transmogrifier/sections/logger.py#L24


In `WHENCE` there are entries like this :

```
Driver: advansys - AdvanSys SCSI

File: advansys/mcode.bin
File: advansys/3550.bin
File: advansys/38C0800.bin
File: advansys/38C1600.bin
```

making the comparison very easy with :

```
# pseudo code
driver=`grep '^Driver' $WHENCE_FILE|cut -d ' ' -f1`
grep ${driver^^}  $DOT_CONFIG
```

But unfortunately it isn't consistent. When they are as above it's easy to copy the whole dir. But sometimes there are lists of individual blobs in the root of `linux-firmware`.  That's not so bad when they are like this:

```
Driver: ti_usb_3410_5052 -- Multi-Tech USB cell modems

File: mts_cdma.fw
File: mts_gsm.fw
File: mts_edge.fw
```

but becomes a PITA if they are like this:

```
Driver: orinoco - Agere/Prism/Symbol Orinoco support

File: agere_sta_fw.bin
Version: 9.48 Hermes I
File: agere_ap_fw.bin
Version: 9.48 Hermes I
```

..individual blobs with info.. and that can have other stuff like Download url, or Source. So it is doable but a mission indeed!


1682_waterheater_stratified (mbadams5) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.39%25-red.svg)


Yeah, I think rears its head during inheritance and with objects that are shared by reference (like a list). By initialising the parameters with `None`, *instance* attributes are over-writing the *class* attributes - so all is well.

The actual distribution parameters could definitely simply be made part of the class though!


Technically, it is not starting now:

```
$ git grep .patch|grep http:
recipes/bridge-utils/bridge-utils_1.5.oe:SRC_URI += "http://www.linuxfromscratch.org/patches/blfs/svn/bridge-utils-1.5-linux_3.8_fix-1.patch"
recipes/libgpg-error/libgpg-error-1.12/pkgconfig.patch:# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
recipes/pciutils/pciutils/configure.patch:# Patch managed by http://www.mn-logistik.de/unsupported/pxa250/patcher
recipes/valgrind/valgrind_3.10.1.oe:SRC_URI += "http://www.linuxfromscratch.org/patches/blfs/svn/valgrind-3.10.1-glibc_2.21-1.patch"
```

How is it easier to see how much patching we are doing if we are carrying the patches ourself?

Doing it like this makes it quite obvious what is the source of the patch.


FYI, the issue isn't missing the EGL_KHL_gl_colorspace extension; the bug is using RGBA color format for blobs that expect BGRA color format.
See: https://github.com/MWisBest/android_frameworks_native/commit/12794aab7432fd9ab0e5ce0b280ffcb9d70c76d5


This is a lot better. Only style note is that we should probably be liberal in what we accept, and use truthiness / falsiness instead of the value `false`.


struct point{
          int y;


If possible (for future), I think there is value in committing generated code in a separate commit to the actual code changes.  It makes the version history more meaningful..

Also, I know it's nit-picky, but there;'s probably no need for `preg_matches` when a simple strips would suffice.

Cheers for keeping this up-to-date though!


厉害！


I'm not clear as a user of this class, what methods am I supposed to use? Only `command_line` ? If so the others should have underscores


Also, the documentation for Hmmer#hmmsearch is now out of date.


its an [isSorted] parameter, making it optional. im sure it only accepts
true or false. but either way, it cant hurt to specify that it's sorted

On Mon, Jun 15, 2015 at 8:15 PM Saiichi Hashimoto <notifications@github.com>
wrote:

> I thought you did? I have no idea, though. I assumed it would use 'link'
> for the isSorted parameter, doing some craziness.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/saiichihashimoto/poptags/commit/3c5034594928b9a303fe8dee6b21cdefa2fc17ad#commitcomment-11694006>
> .
>


Ideally, all functions declared in `ctype.h` and `string.h` per POSIX must be removed.

http://pubs.opengroup.org/onlinepubs/009695399/basedefs/string.h.html

In other words, you should remove all of the above "#undef" hacks.


Было памяти мало, ты сделал её ещё меньше?


Initially I wanted to scan the `/dev/ttyUSB0` continuously. That's why I created a dedicated thread of execution for this consumer. Then I decided that usually you don't want to read so fine-grained GPS coordinates. Currently the consumer is refactored to use `ScheduledPollConsumer`.


В 3.4.7.1 убрано


Generally, no.  In some cases, it is by far the easiest solution.

In this case, they are using a different syntax for arm host arch, ie. armv7-*-* instead of arm-*-*

I am pretty sure that we do not want to change our arch syntax in general.  But we could ofcourse adjust it for valgrind recipe specifically.


Hi Team, I am new to Heat templates. When I do a stack-create of dns.yaml I discovered that it is not able to parse the shell script and can't download the bind package as a result of which rest of the statements are failing to execute. However, the instances are launched sucessfully. Any assistance will be highly appreciated.


오, 명섭, 굳!


perasaan ini udah ada deh di file template/javascript.jsp


泳道图


Unless you're expecting the user to be passing in a buffer length much larger than the null-terminated string, you might want to check backward from the end.

    /* look for a null starting at the end of the buffer until
       we find one or hit the beginning of the buffer */
    for (i = len - 1; s[i] != 0 && i >= 0; --i) {}

    /* If a null wasn't found before the element at offset 0, counter will be negative */
    if (i < 0) return -1;

In normal cases, this will only check a single element of the string rather than all of them.  It's a small thing, and maybe a bit less clear, but I think making the common case cheaper is worth it.


owh wes ono toh, yo wes mengko tek benerna :P


這邊寫錯喔！XD


能不加括号的尽量不加括号吧。。简洁点
比如这个if 和 console.log


Please indent properly =)


추천/비추천을 세분화해서 사용하기 위해 검증부분을 분리
태그삽입부분 추가


應該是：
```rb
render :new
```


@benvanik , last time when i tried to build and run on my Ivy bridge i7-3770k, it simply exit so i think probably the reason of exit  because of my CPU not supporting AVX2 instructions  .

However , If only AVX instruction is required but not AVX2 , probably it is other reason of exit on my system .


		Version 0.1
1. Follow NTP.docx for prerequisites and setup.
2. copy code to linux machine
3.Run ./Automate.bash <ntp_server_ip>


Also, any reason why `extract_from_raw_reads` doesn't use the shiny new way?


见 #25


Closes #1


I didn't make a separate commit, but it's included in #436


oh wesley, you know how to make me a happy man


yes is, but as I would like to “merge it” ;) I changed it already;) Thanks for the reminder! cheers


"shouldn't gotten rid of", I am a modern Einstein.


won't that have duplicates?


actually scratch that last comment


vdiがスナップショットか否かのチェック処理も入れた方がよさそうです。
例えば以下のようなコード
```
            (out,_err) = self._execute('collie', 'vdi', 'list', name)
            if DEFAULT_SNAPNAME in out:
                cloneable = True
            else
                LOG.debug("volume %s is not snapshot", name)
```


What about if ALL network firmware is  included and other missing firmware is downloaded on demand based on kernel messages, where you know exactly what you miss.
Though I'm afraid most of the firmware is for network and input devices and if they are missing you have a hard time getting them.
Not sure what would be a good solution that will keep size reasonable. Looking at the forum I do not think there are a lot of problems with the current implementation.


Hello, Vladimir!
The links to bower, enb, jscs, jshint must be to the node_modules dir.
Or it needs to be bower, enb, jscs, jshint symlinks.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.410.b543a45baf58914e8f49bcc799c98f5eb98b830a](http://build.palaso.org/viewLog.html?buildId=58661&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3306, ignored: 124 Build time: 00:07:37


bool cmp(struct point node1, struct point node2)
{
      if(node1.y < node2.y)
         return true;
      else
         return false;
}


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.380.b543a45baf58914e8f49bcc799c98f5eb98b830a](http://build.palaso.org/viewLog.html?buildId=58662&buildTypeId=bt322) outcome was **FAILURE**
Summary: Tests failed: 11 (11 new), passed: 3308, ignored: 130 Build time: 00:06:29
### Failed tests
```
SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDI30Tests.ActorType_ArchivingActor_ValidActorType: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDI30Tests.AddDescription_Add2ForSameLanguage_AddsOnlyTheFirst: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDI30Tests.FindByISO3Code_InvalidIso3Code_MustBeInList_Throws: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDI30Tests.FindByISO3Code_InvalidIso3Code_NotMustBeInList_DoesNotThrow: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDI30Tests.LocationType_ArchivingLocation_ValidLocationType: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDI30Tests.SetContinent_InvalidContinent_ReturnsUnspecified: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDIArchivingDlgViewModelTests.CorpusDirectoryName_ValidNameForNewDirectory: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDIArchivingDlgViewModelTests.NormalizeFilename_FileName_NormalizedFileName: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDIArchivingDlgViewModelTests.SetAbstract_MultipleLanguages_AddsDescriptionToCorpusImdiFile: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDIArchivingDlgViewModelTests.SetAbstract_SingleLanguage_AddsDescriptionToCorpusImdiFile: <no details avaliable>

SIL.Archiving.Tests.dll: SIL.Archiving.Tests.IMDIArchivingDlgViewModelTests.SetAbstract_UnspecifiedLanguage_AddsDescriptionToCorpusImdiFile: <no details avaliable>

##### there are 1 more failed tests, see build details
```


あとはcayenne.logを出力させてみて意図した削除用のSQLが実行されているか確認すれば終わりかと思います。


Good point :+1:


I think this is nice since it also opens the door to simplifying use of isGpRelation() in the future (ie. don't need to know the integer code to do the check). I'll request Rod to look at it since he is original developer of this module:
@sunsetsystems


To make it clear, for these cases would probably put a quick comment to right of it:
``````
\\ abbrevation for form_encounter table


Thanks @circlespainter!


IMO, instead of introducing #undef, we should just use -nostdinc along with !ACPI_USE_SYSTEM_CLIBRARY. And stop including standard c headers when !ACPI_USE_SYSTEM_CLIBRARY.
I can offer a fix for you.

Thanks
-Lv


Oh good I'm glad you got it working.  As for github chat I don't know if there is.


Closes #20, Closes #22.


分割します……！


I'm hoping that this fork is short-lived and phantomjs 2.0 will be stable
soon so phantom-render-stream can switch to it.

Another option might be to remove the direct phantomjs dependency and
instead make the phantom module a config option for phantom-render-stream.
That way phantomjs, phantomjs2 and slimerjs could all be used with one
"render-stream" module.

On Tue, Jun 16, 2015 at 5:03 PM, Mark Stosberg <notifications@github.com>
wrote:

> Thanks for working on getting phantom-render-stream to support PhantomJS
> 2.0. There's also a ticket about getting the main project to support
> Phantom JS 2 if you are interested to provide input on that:
>
> e-conomic#86
> <https://github.com/e-conomic/phantom-render-stream/issues/86>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/w3dot0/phantom2-render-stream/commit/dc938f7efff29c68bda581398af0b4020440b786#commitcomment-11714962>
> .
>


Awesome @wezm, thank you. I just learnt about 6 things.


Extension of the function signature to include size is a good idea as it might be required in some platforms for remapping memories. But it would seem incongruent to invalidate the cache inside the memmap modules. The cache operations/invalidation should be done before/while processing the frames e.g: handleRxAsyncFrameInfo() or handleRxAsyncFrame().


我只是偷懒没打完，你不能也这样啊 :sob:

`也许配置概要文件的嵌入证书和单点登录认证的能力可以增加通信类应用程序的安全级别`


@yohm データテーブルからの消去は正しく動作しました．


HelloWorld Servlet is not working in Tomcat.

I don't know why.

:octocat:


I want to create an offset file by the command from the uk-2006-05-nat.graph data which is compressed in bvgraph format. I'm using a 32-bit win7 so I run from command line "java it.unimi.di.webgraph.BVGraph -O uk-2006-05-nat" but gives Error: could not find or load main class it.unimi.di.webgraph.BVGraph -O uk-2006-05-nat. I've set classpath right as JAVA_HOME  as C:\Program Files\Java\jdk1.8.0_45 and PATH=%JAVA_HOME%\bin;%TOMCAT_HOME%;  Can't figure out how to solve it,  I need help


@yohm 修正しました．ついでにAnalysesページでのJSのバグを修正．
7c85bf86e0cd0dfcd1041a124dc3e1d5fcbafc1d


thx! :smile:


Después del `#` va un espacio. Y no sólo pongas "devise". Tienes qué poner la razón: i.e. "Use Devise to manage authentication."


I get ```TypeError: unhashable type: 'Task'``` here.


I'm not sure I understand the question ?


fit declares multiple JSON fields named


Solid commit :+1: Excepto por el comentario que te mencioné.


<query id="insertTagInsertLog" action="insert">
    <tables>

    </tables>
    <columns>
        <column name="member_srl" var="member_srl" />
        <column name="tags" var="tags" />
        <column name="regdate" var="regdate" default="curdate()" />
    </columns>
</query>

<query id="updateDocumentExtraVar" action="update">
    <tables>

    </tables>
    <columns>
        <column name="value" var="value" />
        <column name="lang_code" var="lang_code" />
        <column name="eid" var="eid" />
    </columns>
    <conditions>
        <condition operation="equal" column="module_srl" var="module_srl" filter="number" notnull="notnull" />
        <condition operation="equal" column="document_srl" var="document_srl" filter="number" pipe="and" />
        <condition operation="equal" column="var_idx" var="var_idx" filter="number" notnull="notnull" pipe="and" />
    </conditions>
</query>

<query id="updateExvar" action="update">
    <tables>

    </tables>
    <columns>
        <column name="tags" var="tags" notnull="notnull" />
    </columns>
    <conditions>
        <condition operation="equal" column="document_srl" var="document_srl" filter="number" notnull="notnull" />
    </conditions>
</query>


:cool:


No, that is not an option because 1) we have other header files with `ACPI_USE_STANDARD_HEADERS` and 2) platform-specific headers, i.e., acfreebsd.h must be able to include any standard header files if necessary.

BTW, I just created a pull request:

https://github.com/acpica/acpica/pull/83


hmm... we've never done these kinds of "hacks" from core packages but hey, maybe we should...?


¿Qué caraios es este archivo?


for(; pos >= 0; pos--)
{
         while(true)
         {
                 if(board[pos].y != lastY -1)
                 {
                      if(board[pos].y != lastY - 2)
                      {
                             free(avail);
                             return false;
                      }
                      else
                           lastY--;
                 }
                 else


thanks for looking! both great ideas, i'll definitely add them.


To detect if Hola extension is installed in the browser, just call check_hola_ext_installed() and supply 2 callbacks: found_cb and not_found_cb.


Este es un cambio muy importante. Lo suficiente como para ir en su propio commit. Por otro lado, `localhost:3000` no es universal. Cada quién puede usar su propio Domain Server (como yo) y su propio puerto. Por lo pronto, ponlo en un commit aparte. Al rato hago una Story para hacerlo bien.


Otro archivo que qué pedo.


For  Armh7?


Una migración (y su respectivo cambio en `db/schema.rb` van en su propio commit.


Estoy bastante seguro de que esté archivo no sabes de dónde salió ni para que sirve. Ergo, no lo comitees.


Lo mismo que el archivo anterior.


En general, un commit muy achocado. Hay como 3 commits aquí.


I am amused by these if statements.


Archivo que no entiendas, archivo que no comiteas.


Cool man. Now push again !


this has lost context and refers to window in some instances. recommend using `cell` instead of `this`.


Si vas a borrar los comentarios de este archivo, eso es un commit. Estas líneas borradas no tienen nada que ver con "login".


Should this be Oshi?


should be `_update_context(('pages', hidden_pages')` here


Nigga WTF ¬_¬


Parece un buen commit pero le metiste mucho ruido.


Thanks Danccls,

"hardware\tools\avr\bin" solved my Problem :)


A whole pile of Waffles!


Should the pom dependency on 4.1 be updated as part of this commit rather than separately?


This README has been updated since you copied it.


¿Era necesario que instalaras devise manualmente?


Se pone `#` un espacio y el comentario. Y no pongas solo "active-admin" ¿Eso qué significa? Jaja. Pon algo como "Use Active Admin to provide an Admin panel" o algo así.


¿Esto es parte de la instalación de `active-admin`?


could just do .hidden instead of the css


Las migraciones (y su respectivo cambio en `db/schema.rb`) van en su propio commit. Una por commit. Al menos que estén muy relacionadas, como en este caso, de hecho.


Si me explicas qué es este archivo dejo que se quede :stuck_out_tongue:


En general, archivo que no estés usando no lo comitees.


Buen commit, pero con algo de ruido. Eso y te faltó separar las migraciones.


ok


Estoy casi seguro de que aquí va

    ActiveAdmin.register User do


wot?


you get this in the example you posted on #60 ? I get no error... but actually this `set` is not being used yet.


@tifaniwarnita good job!


Commit pequeño, preciso, cumplidor. Muy bien :+1: Pero checa los comentarios.


p


wow! i didn't know coffeescript supported this kind of interpolation, good to know


Vlw
Em 17/06/2015 06:52, "Elone Sampaio" <notifications@github.com> escreveu:

> ok
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ndongalameck/CEAFIE/commit/a742b0f7bea511676bc573002ccbee789ea084d1#commitcomment-11717541>
> .
>


That's true, unless you write some tests for the newly created ``equals``
function as well. Which is proper anyway.

The could go like this:
Test 1: Returns true when it gets an identical action with the same cell.
Test 2: Returns false when it gets an identical action with a different
cell.
Test 3: Returns false when it gets a different action altogether.


What I mean is, the config section here doent seem to mention anything but the cluster name; how does teuthology know how to contact the Openstack server for that cluster?

From: Loic Dachary <notifications@github.com>
Sent: Jun 16, 2015 10:33 PM
To: dachary/teuthology
Cc: Dan Mick
Subject: Re: [teuthology] provision.py: implement an OpenStack backend (ad148bb)

I'm not sure I understand the question ?

---
Reply to this email directly or view it on GitHub:
https://github.com/dachary/teuthology/commit/ad148bb31d577909e19bae887229292f9876d9e0#commitcomment-11717396


filename can't have dots - probably something like

parts = filename.split "."
n = parts.length
extension = parts[n-1] if n > 1 else 'txt'


haha OK


@dstillman, is this OK with you? I might be overlooking the reason for throwing, but this change makes things simpler IMO.


Another minor comment: `get_f_wrapped` should probably be private. Also, what about a more explicit name e.g. `_fill_function_args`?


Either the package won't install or it'll give a message about conflicting requirements


First commit of the script


Ho, ok. Medhi already had this issue, that was why he generated tmp files instead of named so. I guess the new distutils changed that.


Fixed via https://github.com/hotosm/osm-tasking-manager2/pull/660


Coming soon ;)


Yes, I get it with that example (Python 3.4.3). Actually, I can reproduce this when executing `import doit.task; {doit.task.Task(name='', actions=[])}` in the Python shell.


maybe something like "what Julia version your code needs"?


@aembler Any reason for this?


I think @artas360 patch is done for it. With his extra dependencies, this should not happen anymore.


If we don't mention Travis CI anywhere, maybe we should? We auto-generate the yml file but I don't know if we document anywhere what that means or how to use it.


Mistakenly added a binary object file here?


I put this comment here because it is the nearest possible I can do to the function def :) (If it is the question)


Tested on 2.4.12 without problems.

If you need me to test with other versions of mongodb, it will have to wait until the weekend.


Not the cpp but the same without the include part : "pythonic/types/exceptions.hpp"


Ahh...em. That wasn't what I intended to do. Note to self, stop doing git without thinking.

I'll fix this tomorrow...or something...


@banjaxbanjo, thanks for actually **not** fully removing your name from the code, but just changing it the way I've done it in numerous other places where I found your contributions. You've made a *very important* statement in https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/pull/473#issuecomment-112565609: I not only consider important to give credit where credit is due, but also ensure that a person who coded a certain part leaves some sort of contact address to be able to ask questions later on. Before I merge this, how shall we proceed about the [other Copyright aadditions](https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/search?utf8=%E2%9C%93&q=Copyright)? In my eyes, we should keep all copyright notices from AOSP, Cyanogenmod, etc. - but what to do with Copyright from other other people under other licenses such as Apache? Also asking @E3V3A here: Is it a common practice to keep the Copyright notice of certain parts licensed under another license, or will this break GPL?


@arturoc why were all those boost headers added? I thought we only used a small fraction of boost (i.e. system and filesystem)? this looks like all/most of boost's headers?


プロフィールカードのテキスト入力のタイミングではなく他の画面にあわせてプロフィールカードを表示したタイミングで裏のレイヤーの表示を消すようにしてください。


The test should fail right here, after the logging. No need to continue any further and obscure the reasons of the test failure


Wow, congratulations. You get a gold star. :-P


The test should fail here


Please see https://github.com/murdos/musicbrainz-userscripts/pull/17
The reason this was not fixed is because I don't want the script to silently import buggy tracklist that will lead to incorrect data in MusicBrainz.
There were 3 options:
1. Display a message indicating the Discogs release has errors and could not be parsed
2. Import all data but the tracklist, with an informative message besides the import button
3. Still try to import the tracklist, but with a warning message besides the import button.

This commit implements option 3 without the warning: could you please add it?
I think that if we find that generated tracklists with option 3 are horrible, we may change the fixes to option 2.


Это же локальная переменая. В других функциях ее не видно будет


The ```save_to_db``` and ```delete_from_db``` functions look great! You will be using them often :smile:


OK


Будет, особенность JS - всплытие переменных.


This looks OK.
Have you confirmed it for compiling ACPI tools using GCC?
Let me confirm this in Windows environment using MSVC.


Which libcore revision are You using for build (fix GPServices FC's)? Not gcc 4.8 patch?
https://github.com/temasek/android_libcore/commit/bd74ec68b2e81422d57758c2c4a52a84a48db7b8
Manifest redirects to cm-12.1, not gcc patch - is it correct? :)


fixed