1: D100 Missing docstring in public module
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils
41:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.records.api
45:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly, warning_page, write_warning
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.webjournal should be before from invenio.legacy.webuser
50:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
50:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webjournal
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
53:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, guess_primary_collection_of_a_record, record_exists
54:6: E126 continuation line over-indented for hanging indent
57:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
57:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.modules.records.access
60:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
63:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.collections.models
68:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
68:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
68:1: E402 module level import not at top of file
69:6: E126 continuation line over-indented for hanging indent
75: D101 Missing docstring in public class
77: D102 Missing docstring in public method
117:94: E203 whitespace before ':'
119:30: E127 continuation line over-indented for visual indent
119:95: E502 the backslash is redundant between brackets
119:76: E203 whitespace before ':'
119:92: E203 whitespace before ':'
127:60: E502 the backslash is redundant between brackets
128:52: E251 unexpected spaces around keyword / parameter equals
128:54: E251 unexpected spaces around keyword / parameter equals
157:17: E266 too many leading '#' for block comment
158:17: E266 too many leading '#' for block comment
176:13: E266 too many leading '#' for block comment
200:37: E266 too many leading '#' for block comment
201:37: E266 too many leading '#' for block comment
204:45: E128 continuation line under-indented for visual indent
211:107: E203 whitespace before ':'
213:37: E122 continuation line missing indentation or outdented
213:102: E502 the backslash is redundant between brackets
213:83: E203 whitespace before ':'
213:99: E203 whitespace before ':'
214:41: E128 continuation line under-indented for visual indent
275:25: E128 continuation line under-indented for visual indent
275:79: E502 the backslash is redundant between brackets
276:41: E127 continuation line over-indented for visual indent
277:54: E502 the backslash is redundant between brackets
278:25: E128 continuation line under-indented for visual indent
280:25: E126 continuation line over-indented for hanging indent
287:25: E127 continuation line over-indented for visual indent
288:25: E127 continuation line over-indented for visual indent
289:25: E127 continuation line over-indented for visual indent
290:25: E127 continuation line over-indented for visual indent
293: D400 First line should end with a period (not 't')
293: D205 1 blank line required between summary line and description (found 0)
293: D208 Docstring is over-indented
305:1: E302 expected 2 blank lines, found 1
305: D210 No whitespaces allowed surrounding docstring text
305: D202 No blank lines allowed after function docstring (found 1)
305: D400 First line should end with a period (not 's')
314:13: E203 whitespace before ':'
321:13: E266 too many leading '#' for block comment
333:17: E266 too many leading '#' for block comment
348: D101 Missing docstring in public class
352: D400 First line should end with a period (not 'd')
352: D200 One-line docstring should fit on one line with quotes (found 3)
373:22: E126 continuation line over-indented for hanging indent
373:50: E203 whitespace before ':'
374:55: E203 whitespace before ':'
384:9: E122 continuation line missing indentation or outdented
437:96: E128 continuation line under-indented for visual indent
448:50: E502 the backslash is redundant between brackets
468:5: E128 continuation line under-indented for visual indent
476:26: E251 unexpected spaces around keyword / parameter equals
476:28: E251 unexpected spaces around keyword / parameter equals
479:111: E502 the backslash is redundant between brackets
479:34: E251 unexpected spaces around keyword / parameter equals
479:36: E251 unexpected spaces around keyword / parameter equals
480:37: E127 continuation line over-indented for visual indent
481:25: E251 unexpected spaces around keyword / parameter equals
481:27: E251 unexpected spaces around keyword / parameter equals
482:24: E251 unexpected spaces around keyword / parameter equals
482:26: E251 unexpected spaces around keyword / parameter equals
487: D202 No blank lines allowed after function docstring (found 1)
487: D400 First line should end with a period (not 'e')
487: D300 Use """triple double quotes""" (found '-quotes)
502:16: E127 continuation line over-indented for visual indent
506:35: E128 continuation line under-indented for visual indent
507:35: E128 continuation line under-indented for visual indent
517:13: B901 blind except: statement
523:13: B901 blind except: statement
528:17: E128 continuation line under-indented for visual indent
529:17: E128 continuation line under-indented for visual indent
530:17: E128 continuation line under-indented for visual indent


1: D400 First line should end with a period (not 'e')
1: D300 Use """triple double quotes""" (found '''-quotes)
1: D200 One-line docstring should fit on one line with quotes (found 3)
1: L101 copyright is missing
25:1: E402 module level import not at top of file
26:1: I201 Missing newline before sections or imports.
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.access.engine
27:1: E402 module level import not at top of file
28:1: I101 Imported names are in the wrong order. Should be collect_user_info, page_not_authorized
28:1: E402 module level import not at top of file
29:1: I101 Imported names are in the wrong order. Should be list_remote_servers, perform_display_category_list, perform_display_collection_list, perform_display_metadata, perform_display_server_infos, perform_display_server_list, perform_display_sub_status, perform_submit_record
29:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsword.client should be before from invenio.legacy.webuser
29:1: E402 module level import not at top of file
30:37: E126 continuation line over-indented for hanging indent
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webpage
38:1: E402 module level import not at top of file
39:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: I101 Imported names are in the wrong order. Should be CFG_MARC_ADDITIONAL_REPORT_NUMBER, CFG_MARC_REPORT_NUMBER
41:1: E402 module level import not at top of file
43:1: E302 expected 2 blank lines, found 1
43: D210 No whitespaces allowed surrounding docstring text
43: D203 1 blank line required before class docstring (found 0)
43: D204 1 blank line required after class docstring (found 0)
48:5: E303 too many blank lines (2)
48: D400 First line should end with a period (not 'e')
48: D300 Use """triple double quotes""" (found '''-quotes)
53:5: E303 too many blank lines (2)
53: D102 Missing docstring in public method
61:9: E303 too many blank lines (2)
66:17: E203 whitespace before ':'
69:21: E203 whitespace before ':'
70:21: E203 whitespace before ':'
71:23: E203 whitespace before ':'
72:24: E203 whitespace before ':'
73:21: E203 whitespace before ':'
74:25: E203 whitespace before ':'
77:24: E203 whitespace before ':'
78:20: E203 whitespace before ':'
79:31: E203 whitespace before ':'
80:28: E203 whitespace before ':'
81:25: E203 whitespace before ':'
82:28: E203 whitespace before ':'
84:17: E203 whitespace before ':'
85:20: E203 whitespace before ':'
86:22: E203 whitespace before ':'
87:26: E203 whitespace before ':'
88:27: E203 whitespace before ':'
89:31: E203 whitespace before ':'
90:32: E203 whitespace before ':'
91:38: E203 whitespace before ':'
94:22: E203 whitespace before ':'
95:18: E203 whitespace before ':'
96:19: E203 whitespace before ':'
97:27: E203 whitespace before ':'
98:25: E203 whitespace before ':'
99:20: E203 whitespace before ':'
100:24: E203 whitespace before ':'
101:23: E203 whitespace before ':'
108:9: E303 too many blank lines (2)
115:9: E303 too many blank lines (2)
127:39: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
128:19: E127 continuation line over-indented for visual indent
132:55: E502 the backslash is redundant between brackets
140:9: E303 too many blank lines (2)
166:59: E126 continuation line over-indented for hanging indent
173:44: E203 whitespace before ':'
175:56: E126 continuation line over-indented for hanging indent
214:9: E303 too many blank lines (2)
224:44: E203 whitespace before ':'
235:40: E203 whitespace before ':'
259:59: E126 continuation line over-indented for hanging indent
265:56: E126 continuation line over-indented for hanging indent
271:9: E303 too many blank lines (2)
281:40: E203 whitespace before ':'
295:56: E126 continuation line over-indented for hanging indent
303:56: E126 continuation line over-indented for hanging indent
310:9: E303 too many blank lines (2)
322:56: E126 continuation line over-indented for hanging indent
328:28: E221 multiple spaces before operator
333:40: E203 whitespace before ':'
337:56: E126 continuation line over-indented for hanging indent
346:51: E128 continuation line under-indented for visual indent
347:51: E126 continuation line over-indented for hanging indent
364:40: E203 whitespace before ':'
366:56: E126 continuation line over-indented for hanging indent
373:9: E303 too many blank lines (2)
374:28: E221 multiple spaces before operator
379:40: E203 whitespace before ':'
407:51: E128 continuation line under-indented for visual indent
408:51: E126 continuation line over-indented for hanging indent
418:13: E303 too many blank lines (3)
423:25: E127 continuation line over-indented for visual indent
425:40: E203 whitespace before ':'
428:50: E128 continuation line under-indented for visual indent
429:50: E126 continuation line over-indented for hanging indent
436:9: E303 too many blank lines (2)
437:26: E251 unexpected spaces around keyword / parameter equals
437:35: E251 unexpected spaces around keyword / parameter equals
437:26: E221 multiple spaces before operator
438:25: E251 unexpected spaces around keyword / parameter equals
438:35: E251 unexpected spaces around keyword / parameter equals
438:25: E221 multiple spaces before operator
439:29: E251 unexpected spaces around keyword / parameter equals
439:35: E251 unexpected spaces around keyword / parameter equals
439:29: E221 multiple spaces before operator
441:32: E251 unexpected spaces around keyword / parameter equals
441:35: E251 unexpected spaces around keyword / parameter equals
441:32: E221 multiple spaces before operator
442:24: E251 unexpected spaces around keyword / parameter equals
442:35: E251 unexpected spaces around keyword / parameter equals
442:24: E221 multiple spaces before operator
443:29: E251 unexpected spaces around keyword / parameter equals
443:35: E251 unexpected spaces around keyword / parameter equals
443:29: E221 multiple spaces before operator
445:29: E251 unexpected spaces around keyword / parameter equals
445:35: E251 unexpected spaces around keyword / parameter equals
445:29: E221 multiple spaces before operator
446:30: E251 unexpected spaces around keyword / parameter equals
446:35: E251 unexpected spaces around keyword / parameter equals
446:30: E221 multiple spaces before operator
449:5: E303 too many blank lines (2)
449: D401 First line should be in imperative mood ('Thi', not 'This')
449: D202 No blank lines allowed after function docstring (found 1)
449: D400 First line should end with a period (not 'l')
449: D208 Docstring is over-indented
449: D300 Use """triple double quotes""" (found '''-quotes)
449: D200 One-line docstring should fit on one line with quotes (found 3)
455:17: E203 whitespace before ':'
456:17: E203 whitespace before ':'
466:9: E303 too many blank lines (2)
469:25: E127 continuation line over-indented for visual indent
471:40: E203 whitespace before ':'
474:9: E303 too many blank lines (2)
475:26: E251 unexpected spaces around keyword / parameter equals
475:35: E251 unexpected spaces around keyword / parameter equals
475:26: E221 multiple spaces before operator
476:25: E251 unexpected spaces around keyword / parameter equals
476:35: E251 unexpected spaces around keyword / parameter equals
476:25: E221 multiple spaces before operator
477:29: E251 unexpected spaces around keyword / parameter equals
477:35: E251 unexpected spaces around keyword / parameter equals
477:29: E221 multiple spaces before operator
479:32: E251 unexpected spaces around keyword / parameter equals
479:35: E251 unexpected spaces around keyword / parameter equals
479:32: E221 multiple spaces before operator
480:24: E251 unexpected spaces around keyword / parameter equals
480:35: E251 unexpected spaces around keyword / parameter equals
480:24: E221 multiple spaces before operator
481:29: E251 unexpected spaces around keyword / parameter equals
481:35: E251 unexpected spaces around keyword / parameter equals
481:29: E221 multiple spaces before operator
482:27: E251 unexpected spaces around keyword / parameter equals
482:35: E251 unexpected spaces around keyword / parameter equals
482:27: E221 multiple spaces before operator
483:29: E251 unexpected spaces around keyword / parameter equals
483:35: E251 unexpected spaces around keyword / parameter equals
483:29: E221 multiple spaces before operator
484:30: E251 unexpected spaces around keyword / parameter equals
484:35: E251 unexpected spaces around keyword / parameter equals
484:30: E221 multiple spaces before operator
487:5: E303 too many blank lines (2)
487: D401 First line should be in imperative mood ('Thi', not 'This')
487: D202 No blank lines allowed after function docstring (found 1)
487: D400 First line should end with a period (not 's')
487: D205 1 blank line required between summary line and description (found 0)
487: D208 Docstring is over-indented
487: D300 Use """triple double quotes""" (found '''-quotes)
497:5: E303 too many blank lines (2)
499:1: W391 blank line at end of file


1: D100 Missing docstring in public module
28:1: F401 'sys' imported but unused
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. import datetime should be before import sys
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. import os should be before import time
31:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: I101 Imported names are in the wrong order. Should be CFG_CACHEDIR, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_TMPDIR, CFG_TMPDIR, CFG_TMPSHAREDDIR, CFG_WEBSEARCH_RSS_TTL, CFG_WEBSESSION_NOT_CONFIRMED_EMAIL_ADDRESS_EXPIRE_IN_DAYS
34:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.dbquery
34:1: F999 redefinition of unused 'CFG_TMPDIR' from line 34
34:1: F401 'CFG_LOGDIR' imported but unused
34:1: E402 module level import not at top of file
35:9: E126 continuation line over-indented for hanging indent
38:1: I101 Imported names are in the wrong order. Should be task_get_option, task_init, task_set_option, write_message, write_messages
38:1: E402 module level import not at top of file
39:10: E126 continuation line over-indented for hanging indent
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.modules.access.mailcookie
42:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.utils.date
46:1: I201 Missing newline before sections or imports.
46:1: E402 module level import not at top of file
98:1: E302 expected 2 blank lines, found 1
98: D210 No whitespaces allowed surrounding docstring text
105:1: E302 expected 2 blank lines, found 1
105: D210 No whitespaces allowed surrounding docstring text
109:13: E128 continuation line under-indented for visual indent
112:9: E128 continuation line under-indented for visual indent
112:42: E502 the backslash is redundant between brackets
113:13: E128 continuation line under-indented for visual indent
115:9: E128 continuation line under-indented for visual indent
115:44: E502 the backslash is redundant between brackets
116:13: E128 continuation line under-indented for visual indent
118:9: E128 continuation line under-indented for visual indent
118:46: E502 the backslash is redundant between brackets
119:13: E128 continuation line under-indented for visual indent
122:1: E302 expected 2 blank lines, found 1
122: D210 No whitespaces allowed surrounding docstring text
126:13: E128 continuation line under-indented for visual indent
130:13: E128 continuation line under-indented for visual indent
132:9: E128 continuation line under-indented for visual indent
132:33: E502 the backslash is redundant between brackets
133:13: E128 continuation line under-indented for visual indent
135:9: E128 continuation line under-indented for visual indent
135:33: E502 the backslash is redundant between brackets
136:13: E128 continuation line under-indented for visual indent
139:9: E128 continuation line under-indented for visual indent
139:46: E502 the backslash is redundant between brackets
140:13: E128 continuation line under-indented for visual indent
140:46: E502 the backslash is redundant between brackets
143:9: E128 continuation line under-indented for visual indent
143:45: E502 the backslash is redundant between brackets
144:13: E128 continuation line under-indented for visual indent
144:46: E502 the backslash is redundant between brackets
149:17: E128 continuation line under-indented for visual indent
151:13: E128 continuation line under-indented for visual indent
151:48: E502 the backslash is redundant between brackets
152:17: E128 continuation line under-indented for visual indent
152:50: E502 the backslash is redundant between brackets
153:17: E128 continuation line under-indented for visual indent
155:13: E128 continuation line under-indented for visual indent
155:50: E502 the backslash is redundant between brackets
156:17: E128 continuation line under-indented for visual indent
156:50: E502 the backslash is redundant between brackets
157:17: E128 continuation line under-indented for visual indent
160:13: E128 continuation line under-indented for visual indent
162:9: E128 continuation line under-indented for visual indent
162:44: E502 the backslash is redundant between brackets
163:13: E128 continuation line under-indented for visual indent
168:9: E128 continuation line under-indented for visual indent
168:44: E502 the backslash is redundant between brackets
169:13: E128 continuation line under-indented for visual indent
169:46: E502 the backslash is redundant between brackets
174:9: E128 continuation line under-indented for visual indent
174:44: E502 the backslash is redundant between brackets
175:13: E128 continuation line under-indented for visual indent
175:46: E502 the backslash is redundant between brackets
181:13: E128 continuation line under-indented for visual indent
181:48: E502 the backslash is redundant between brackets
182:17: E128 continuation line under-indented for visual indent
182:50: E502 the backslash is redundant between brackets
183:17: E128 continuation line under-indented for visual indent
187:13: E128 continuation line under-indented for visual indent
187:48: E502 the backslash is redundant between brackets
188:17: E128 continuation line under-indented for visual indent
188:50: E502 the backslash is redundant between brackets
189:17: E128 continuation line under-indented for visual indent
193:9: E128 continuation line under-indented for visual indent
193:44: E502 the backslash is redundant between brackets
194:13: E128 continuation line under-indented for visual indent
199:9: E128 continuation line under-indented for visual indent
199:44: E502 the backslash is redundant between brackets
200:13: E128 continuation line under-indented for visual indent
205:1: E302 expected 2 blank lines, found 1
249: D205 1 blank line required between summary line and description (found 0)
266:69: E502 the backslash is redundant between brackets
267:25: E128 continuation line under-indented for visual indent
272:69: E502 the backslash is redundant between brackets
273:25: E127 continuation line over-indented for visual indent
276:72: E502 the backslash is redundant between brackets
280:1: E302 expected 2 blank lines, found 1
280: D209 Multi-line docstring closing quotes should be on a separate line
280: D400 First line should end with a period (not 'n')
280: D205 1 blank line required between summary line and description (found 0)
296:1: E302 expected 2 blank lines, found 1
296: D400 First line should end with a period (not 'e')
296: D205 1 blank line required between summary line and description (found 0)
307:71: E261 at least two spaces before inline comment
309:1: E302 expected 2 blank lines, found 1
309: D400 First line should end with a period (not 'B')
309: D205 1 blank line required between summary line and description (found 0)
321:74: E261 at least two spaces before inline comment
323:1: E302 expected 2 blank lines, found 1
323: D401 First line should be in imperative mood ('Delete', not 'Deletes')
323: D200 One-line docstring should fit on one line with quotes (found 3)
338:1: E302 expected 2 blank lines, found 1
338: D401 First line should be in imperative mood ('Delete', not 'Deletes')
338: D400 First line should end with a period (not 's')
344:1: E302 expected 2 blank lines, found 1
344: D209 Multi-line docstring closing quotes should be on a separate line
344: D202 No blank lines allowed after function docstring (found 1)
344: D400 First line should end with a period (not 'r')
344: D208 Docstring is over-indented
376:34: E203 whitespace before ':'
384:9: E128 continuation line under-indented for visual indent
386:9: E128 continuation line under-indented for visual indent
389:5: E303 too many blank lines (2)
407:26: E701 multiple statements on one line (colon)
412:17: E128 continuation line under-indented for visual indent
414:17: E128 continuation line under-indented for visual indent
417:5: E303 too many blank lines (2)
421:9: E128 continuation line under-indented for visual indent
438:9: E128 continuation line under-indented for visual indent
461:5: E303 too many blank lines (2)
471:5: B901 blind except: statement
490:5: B901 blind except: statement
516:5: E266 too many leading '#' for block comment
542:1: E302 expected 2 blank lines, found 1
558:13: E128 continuation line under-indented for visual indent
559:13: E128 continuation line under-indented for visual indent
560:17: E127 continuation line over-indented for visual indent
571:13: E128 continuation line under-indented for visual indent
572:13: E128 continuation line under-indented for visual indent
573:13: E128 continuation line under-indented for visual indent
574:13: E128 continuation line under-indented for visual indent
575:13: E128 continuation line under-indented for visual indent
577:1: E302 expected 2 blank lines, found 1
577: D103 Missing docstring in public function
592:1: E302 expected 2 blank lines, found 1
592: D210 No whitespaces allowed surrounding docstring text
592: D400 First line should end with a period (not 'e')
592: D205 1 blank line required between summary line and description (found 0)
649:1: E302 expected 2 blank lines, found 1
649: D210 No whitespaces allowed surrounding docstring text


1: D100 Missing docstring in public module
23:1: I101 Imported names are in the wrong order. Should be cPickle, calendar, cgi, commands, datetime, os, random, time
23:16: E401 multiple imports on one line
23:1: E402 module level import not at top of file
24:1: E402 module level import not at top of file
25:1: I101 Imported names are in the wrong order. Should be CFG_BIBCIRCULATION_ILL_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CANCELLED, CFG_BIBCIRCULATION_ITEM_STATUS_CLAIMED, CFG_BIBCIRCULATION_ITEM_STATUS_IN_PROCESS, CFG_BIBCIRCULATION_ITEM_STATUS_NOT_ARRIVED, CFG_BIBCIRCULATION_ITEM_STATUS_ON_LOAN, CFG_BIBCIRCULATION_ITEM_STATUS_ON_ORDER, CFG_BIBCIRCULATION_ITEM_STATUS_ON_SHELF, CFG_BIBCIRCULATION_ITEM_STATUS_OPTIONAL, CFG_BIBCIRCULATION_REQUEST_STATUS_DONE, CFG_BINDIR, CFG_CERN_SITE, CFG_SITE_NAME, CFG_SITE_URL, CFG_TMPDIR
25:1: I201 Missing newline before sections or imports.
25:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: I101 Imported names are in the wrong order. Should be get_collection_reclist, get_most_popular_field_values, perform_request_search, search_pattern
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.search_engine should be before from invenio.utils.url
42:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
49:1: I101 Imported names are in the wrong order. Should be book_information_from_MARC, book_title_from_MARC
49:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.utils should be before from invenio.legacy.dbquery
49:1: E402 module level import not at top of file
51:1: I101 Imported names are in the wrong order. Should be get_borrower_data, get_id_bibrec
51:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibcirculation.db_layer should be before from invenio.legacy.bibcirculation.utils
51:1: E402 module level import not at top of file
54:1: I101 Imported names are in the wrong order. Should be convert_datestruct_to_dategui, convert_datetext_to_datestruct
54:1: E402 module level import not at top of file
55:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.utils.date
55:1: E402 module level import not at top of file
58:38: E261 at least two spaces before inline comment
63:1: E302 expected 2 blank lines, found 1
63: D401 First line should be in imperative mood ('Return', not 'Returns')
63: D400 First line should end with a period (not 'r')
63: D205 1 blank line required between summary line and description (found 0)
87:25: E128 continuation line under-indented for visual indent
91:29: E128 continuation line under-indented for visual indent
91:61: E251 unexpected spaces around keyword / parameter equals
92:29: E128 continuation line under-indented for visual indent
93:29: E128 continuation line under-indented for visual indent
104:27: E128 continuation line under-indented for visual indent
107: D401 First line should be in imperative mood ('Return', not 'Returns')
107: D202 No blank lines allowed after function docstring (found 1)
129:29: E128 continuation line under-indented for visual indent
130:29: E128 continuation line under-indented for visual indent
144: D210 No whitespaces allowed surrounding docstring text
144: D209 Multi-line docstring closing quotes should be on a separate line
144: D400 First line should end with a period (not 's')
144: D205 1 blank line required between summary line and description (found 0)
153:29: E128 continuation line under-indented for visual indent
154:29: E126 continuation line over-indented for hanging indent
160:27: E128 continuation line under-indented for visual indent
163: D401 First line should be in imperative mood ('Return', not 'Returns')
163: D202 No blank lines allowed after function docstring (found 1)
163: D400 First line should end with a period (not 't')
163: D205 1 blank line required between summary line and description (found 0)
182:17: E128 continuation line under-indented for visual indent
183:29: E128 continuation line under-indented for visual indent
186: D401 First line should be in imperative mood ('Return', not 'Returns')
186: D400 First line should end with a period (not 't')
186: D205 1 blank line required between summary line and description (found 0)
208:13: E128 continuation line under-indented for visual indent
211:13: E128 continuation line under-indented for visual indent
211:44: E251 unexpected spaces around keyword / parameter equals
212:13: E128 continuation line under-indented for visual indent
216: D401 First line should be in imperative mood ('Return', not 'Returns')
216: D400 First line should end with a period (not 'n')
216: D205 1 blank line required between summary line and description (found 0)
236:21: E128 continuation line under-indented for visual indent
237:21: E128 continuation line under-indented for visual indent
241:21: E128 continuation line under-indented for visual indent
242:21: E128 continuation line under-indented for visual indent
246:25: E128 continuation line under-indented for visual indent
248:25: E128 continuation line under-indented for visual indent
257: D401 First line should be in imperative mood ('Return', not 'Returns')
257: D400 First line should end with a period (not 't')
257: D205 1 blank line required between summary line and description (found 0)
280:17: E128 continuation line under-indented for visual indent
300:27: E128 continuation line under-indented for visual indent
303: D401 First line should be in imperative mood ('Return', not 'Returns')
303: D400 First line should end with a period (not 't')
303: D205 1 blank line required between summary line and description (found 0)
321:13: E128 continuation line under-indented for visual indent
324: D401 First line should be in imperative mood ('Return', not 'Returns')
324: D400 First line should end with a period (not 'r')
324: D205 1 blank line required between summary line and description (found 0)
346:17: E128 continuation line under-indented for visual indent
350:17: E128 continuation line under-indented for visual indent
357: D400 First line should end with a period (not ':')
357: D205 1 blank line required between summary line and description (found 0)
428:37: E126 continuation line over-indented for hanging indent
429:10: E261 at least two spaces before inline comment
466: D400 First line should end with a period (not ':')
466: D205 1 blank line required between summary line and description (found 0)
575:62: E502 the backslash is redundant between brackets
576:23: E128 continuation line under-indented for visual indent
587:13: E128 continuation line under-indented for visual indent
588:13: E128 continuation line under-indented for visual indent
589:13: E128 continuation line under-indented for visual indent
590:13: E128 continuation line under-indented for visual indent
596:13: E128 continuation line under-indented for visual indent
597:13: E128 continuation line under-indented for visual indent
598:13: E128 continuation line under-indented for visual indent
599:13: E128 continuation line under-indented for visual indent
600:13: E128 continuation line under-indented for visual indent
605: D400 First line should end with a period (not ':')
605: D205 1 blank line required between summary line and description (found 0)
673: D400 First line should end with a period (not ':')
673: D205 1 blank line required between summary line and description (found 0)
699: D401 First line should be in imperative mood ('Return', not 'Returns')
699: D400 First line should end with a period (not 's')
717:17: E128 continuation line under-indented for visual indent
719:17: E128 continuation line under-indented for visual indent
723:17: E128 continuation line under-indented for visual indent
724:17: E128 continuation line under-indented for visual indent
728:25: E128 continuation line under-indented for visual indent
730:25: E128 continuation line under-indented for visual indent
739: D400 First line should end with a period (not ':')
739: D205 1 blank line required between summary line and description (found 0)
837: D400 First line should end with a period (not ':')
837: D205 1 blank line required between summary line and description (found 0)
866:21: E127 continuation line over-indented for visual indent
897: D401 First line should be in imperative mood ('Return', not 'Returns')
897: D400 First line should end with a period (not 't')
897: D205 1 blank line required between summary line and description (found 0)
943:19: E128 continuation line under-indented for visual indent
948:19: E128 continuation line under-indented for visual indent
948:66: E225 missing whitespace around operator
952:25: E128 continuation line under-indented for visual indent
954:25: E128 continuation line under-indented for visual indent
963: D400 First line should end with a period (not ':')
963: D205 1 blank line required between summary line and description (found 0)
1014: D202 No blank lines allowed after function docstring (found 1)
1014: D400 First line should end with a period (not ':')
1014: D205 1 blank line required between summary line and description (found 0)
1079: D400 First line should end with a period (not ':')
1079: D205 1 blank line required between summary line and description (found 0)
1122:57: E128 continuation line under-indented for visual indent
1137:9: E128 continuation line under-indented for visual indent
1140: D400 First line should end with a period (not ':')
1140: D205 1 blank line required between summary line and description (found 0)
1199: D400 First line should end with a period (not ':')
1199: D205 1 blank line required between summary line and description (found 0)
1235: D400 First line should end with a period (not ':')
1235: D205 1 blank line required between summary line and description (found 0)
1281:1: E302 expected 2 blank lines, found 1
1342: D400 First line should end with a period (not 'n')
1342: D205 1 blank line required between summary line and description (found 0)
1354:10: E261 at least two spaces before inline comment
1354:11: E262 inline comment should start with '# '
1376:83: E502 the backslash is redundant between brackets
1376:82: E211 whitespace before '('
1377:21: E128 continuation line under-indented for visual indent
1379:82: E502 the backslash is redundant between brackets
1379:81: E211 whitespace before '('
1380:21: E128 continuation line under-indented for visual indent
1382:82: E502 the backslash is redundant between brackets
1382:81: E211 whitespace before '('
1383:21: E128 continuation line under-indented for visual indent
1386:82: E502 the backslash is redundant between brackets
1386:81: E211 whitespace before '('
1387:21: E128 continuation line under-indented for visual indent
1394:1: E302 expected 2 blank lines, found 1
1394: D401 First line should be in imperative mood ('Build', not 'Builds')
1394: D400 First line should end with a period (not 'r')
1394: D205 1 blank line required between summary line and description (found 0)
1446:1: E302 expected 2 blank lines, found 1
1446: D205 1 blank line required between summary line and description (found 0)
1456:13: E127 continuation line over-indented for visual indent
1459:1: E302 expected 2 blank lines, found 1
1459: D401 First line should be in imperative mood ('Fetche', not 'Fetches')
1459: D400 First line should end with a period (not 't')
1459: D205 1 blank line required between summary line and description (found 0)
1471:15: E711 comparison to None should be 'if cond is None:'
1471:15: E225 missing whitespace around operator
1471:32: E225 missing whitespace around operator
1475:5: B901 blind except: statement
1493:1: E302 expected 2 blank lines, found 1
1493: D401 First line should be in imperative mood ('Return', not 'Returns')
1493: D205 1 blank line required between summary line and description (found 0)
1510:77: E502 the backslash is redundant between brackets
1511:25: E127 continuation line over-indented for visual indent
1515:81: E502 the backslash is redundant between brackets
1516:25: E127 continuation line over-indented for visual indent
1526:1: E302 expected 2 blank lines, found 1
1526: D401 First line should be in imperative mood ('Return', not 'Returns')
1526: D400 First line should end with a period (not 'n')
1526: D205 1 blank line required between summary line and description (found 0)
1560:33: E128 continuation line under-indented for visual indent
1561:28: E211 whitespace before '('
1567:33: E128 continuation line under-indented for visual indent
1568:28: E211 whitespace before '('
1576:28: E211 whitespace before '('
1585:33: E128 continuation line under-indented for visual indent
1590:77: E502 the backslash is redundant between brackets
1590:76: E211 whitespace before '('
1591:21: E128 continuation line under-indented for visual indent
1593:1: E302 expected 2 blank lines, found 1
1593: D400 First line should end with a period (not 't')
1593: D205 1 blank line required between summary line and description (found 0)
1606:13: E127 continuation line over-indented for visual indent
1608:1: E302 expected 2 blank lines, found 1
1608:33: E211 whitespace before '('
1608: D401 First line should be in imperative mood ('Return', not 'Returns')
1608: D205 1 blank line required between summary line and description (found 0)
1617:73: E502 the backslash is redundant between brackets
1617:72: E211 whitespace before '('
1618:21: E128 continuation line under-indented for visual indent
1621:1: E302 expected 2 blank lines, found 1
1621: D401 First line should be in imperative mood ('Return', not 'Returns')
1621: D400 First line should end with a period (not 'r')
1621: D205 1 blank line required between summary line and description (found 0)
1635:1: E303 too many blank lines (3)
1637:1: E302 expected 2 blank lines, found 3
1637: D401 First line should be in imperative mood ('Create', not 'Creates')
1637: D400 First line should end with a period (not 's')
1642: D210 No whitespaces allowed surrounding docstring text
1642: D401 First line should be in imperative mood ('Return', not 'Returns')
1642: D400 First line should end with a period (not 'g')
1647: D401 First line should be in imperative mood ('Return', not 'Returns')
1647: D400 First line should end with a period (not ')')
1652: D401 First line should be in imperative mood ('Return', not 'Returns')
1658: D210 No whitespaces allowed surrounding docstring text
1658: D401 First line should be in imperative mood ('Return', not 'Returns')
1658: D400 First line should end with a period (not 'g')
1664:1: E302 expected 2 blank lines, found 1
1664: D401 First line should be in imperative mood ('Return', not 'Returns')
1664: D400 First line should end with a period (not 'n')
1664: D205 1 blank line required between summary line and description (found 0)
1697:12: E713 test for membership should be 'not in'
1704:34: E127 continuation line over-indented for visual indent
1707:34: E127 continuation line over-indented for visual indent
1710:34: E127 continuation line over-indented for visual indent
1723: D400 First line should end with a period (not 'y')
1723: D205 1 blank line required between summary line and description (found 0)
1756:26: E127 continuation line over-indented for visual indent
1761:114: E261 at least two spaces before inline comment
1765:16: E713 test for membership should be 'not in'
1769:49: E502 the backslash is redundant between brackets
1770:42: E127 continuation line over-indented for visual indent
1772:48: E502 the backslash is redundant between brackets
1773:42: E127 continuation line over-indented for visual indent
1775:53: E502 the backslash is redundant between brackets
1776:42: E127 continuation line over-indented for visual indent
1790:21: E126 continuation line over-indented for hanging indent
1809: D400 First line should end with a period (not 'g')
1809: D205 1 blank line required between summary line and description (found 0)
1823: D400 First line should end with a period (not 'g')
1823: D205 1 blank line required between summary line and description (found 0)
1840:1: E302 expected 2 blank lines, found 1
1840: D401 First line should be in imperative mood ('Return', not 'Returns')
1840: D202 No blank lines allowed after function docstring (found 1)
1840: D400 First line should end with a period (not 'r')
1883: D401 First line should be in imperative mood ('Create', not 'Creates')
1883: D400 First line should end with a period (not 'd')
1883: D205 1 blank line required between summary line and description (found 0)
1897:5: B901 blind except: statement
1950:1: E302 expected 2 blank lines, found 1
1950: D401 First line should be in imperative mood ('Create', not 'Creates')
1978: D401 First line should be in imperative mood ('Create', not 'Creates')
1978: D400 First line should end with a period (not 't')
1989:21: E128 continuation line under-indented for visual indent
1997:21: E126 continuation line over-indented for hanging indent
2036:37: E128 continuation line under-indented for visual indent
2045: D401 First line should be in imperative mood ('Create', not 'Creates')
2045: D400 First line should end with a period (not 'y')
2093:35: E127 continuation line over-indented for visual indent
2117: D401 First line should be in imperative mood ('Create', not 'Creates')
2117: D400 First line should end with a period (not 'y')
2143:25: E128 continuation line under-indented for visual indent
2168:21: E128 continuation line under-indented for visual indent
2168:60: E225 missing whitespace around operator
2169:21: E126 continuation line over-indented for hanging indent
2207:18: E222 multiple spaces after operator
2225:9: E116 unexpected indentation (comment)
2243:9: E116 unexpected indentation (comment)
2307:62: E203 whitespace before ':'
2311: D210 No whitespaces allowed surrounding docstring text
2311: D401 First line should be in imperative mood ('Return', not 'Returns')
2311: D400 First line should end with a period (not 'a')
2326: D401 First line should be in imperative mood ('Create', not 'Creates')
2363: D401 First line should be in imperative mood ('Create', not 'Creates')
2386:46: E502 the backslash is redundant between brackets
2387:21: E128 continuation line under-indented for visual indent
2413:1: E302 expected 2 blank lines, found 1
2413: D401 First line should be in imperative mood ('Return', not 'Returns')
2413: D400 First line should end with a period (not 'y')
2419: D401 First line should be in imperative mood ('Return', not 'Returns')
2419: D400 First line should end with a period (not 'y')
2431: D401 First line should be in imperative mood ('Return', not 'Returns')
2431: D400 First line should end with a period (not 'y')
2439:14: E128 continuation line under-indented for visual indent
2444: D401 First line should be in imperative mood ('Return', not 'Returns')
2444: D400 First line should end with a period (not 'y')
2449: D401 First line should be in imperative mood ('Return', not 'Returns')
2449: D400 First line should end with a period (not 'y')
2454: D401 First line should be in imperative mood ('Return', not 'Returns')
2454: D400 First line should end with a period (not 'y')
2459: D401 First line should be in imperative mood ('Return', not 'Returns')
2459: D400 First line should end with a period (not 'y')
2466: D401 First line should be in imperative mood ('Return', not 'Returns')
2466: D400 First line should end with a period (not 'y')
2474: D401 First line should be in imperative mood ('Return', not 'Returns')
2474: D400 First line should end with a period (not 'y')
2482: D401 First line should be in imperative mood ('Return', not 'Returns')
2482: D400 First line should end with a period (not 'y')
2490: D401 First line should be in imperative mood ('Return', not 'Returns')
2490: D400 First line should end with a period (not 's')
2494:10: E128 continuation line under-indented for visual indent
2498:1: E302 expected 2 blank lines, found 1
2498: D401 First line should be in imperative mood ('Export', not 'Exports')
2511: D401 First line should be in imperative mood ('Export', not 'Exports')
2521:66: E502 the backslash is redundant between brackets
2522:18: E128 continuation line under-indented for visual indent
2526: D401 First line should be in imperative mood ('Export', not 'Exports')
2546:68: E502 the backslash is redundant between brackets
2556:1: E302 expected 2 blank lines, found 1
2556: D400 First line should end with a period (not 'a')
2556: D205 1 blank line required between summary line and description (found 0)
2565:64: E502 the backslash is redundant between brackets
2566:25: E127 continuation line over-indented for visual indent
2569: D400 First line should end with a period (not ',')
2569: D205 1 blank line required between summary line and description (found 0)
2624:13: E128 continuation line under-indented for visual indent
2625:13: E128 continuation line under-indented for visual indent
2626:13: E128 continuation line under-indented for visual indent
2627:13: E128 continuation line under-indented for visual indent
2628:13: E128 continuation line under-indented for visual indent
2629:13: E124 closing bracket does not match visual indentation
2629:13: E125 continuation line with same indent as next logical line
2645:13: E125 continuation line with same indent as next logical line
2651: D401 First line should be in imperative mood ('Return', not 'Returns')
2677:27: E128 continuation line under-indented for visual indent
2680: D401 First line should be in imperative mood ('Return', not 'Returns')
2680: D400 First line should end with a period (not ',')
2680: D205 1 blank line required between summary line and description (found 0)
2724:1: E302 expected 2 blank lines, found 1
2724: D401 First line should be in imperative mood ('Transform', not 'Transforms')
2724: D400 First line should end with a period (not 'e')
2724: D200 One-line docstring should fit on one line with quotes (found 3)
2731: D401 First line should be in imperative mood ('Run', not 'Runs')
2731: D400 First line should end with a period (not 's')
2731: D205 1 blank line required between summary line and description (found 0)
2745: D401 First line should be in imperative mood ('Return', not 'Returns')
2745: D400 First line should end with a period (not 'n')
2751: D401 First line should be in imperative mood ('Return', not 'Returns')
2751: D400 First line should end with a period (not 'm')
2760:13: E127 continuation line over-indented for visual indent
2763: D401 First line should be in imperative mood ('Return', not 'Returns')
2763: D400 First line should end with a period (not 'm')
2767:9: E125 continuation line with same indent as next logical line
2772: D401 First line should be in imperative mood ('Return', not 'Returns')
2772: D400 First line should end with a period (not 't')
2780: D401 First line should be in imperative mood ('Return', not 'Returns')
2780: D400 First line should end with a period (not 's')
2784:33: E713 test for membership should be 'not in'
2784:54: E261 at least two spaces before inline comment
2789: D401 First line should be in imperative mood ('Return', not 'Returns')
2789: D400 First line should end with a period (not 'm')
2797: D400 First line should end with a period (not 'e')
2797: D200 One-line docstring should fit on one line with quotes (found 3)
2809:1: E302 expected 2 blank lines, found 1
2815:1: E302 expected 2 blank lines, found 1
2820:1: E302 expected 2 blank lines, found 1
2827:1: E302 expected 2 blank lines, found 1
2833:1: E302 expected 2 blank lines, found 1
2846:1: E302 expected 2 blank lines, found 1
2851:37: E128 continuation line under-indented for visual indent
2853:10: E128 continuation line under-indented for visual indent
2854:10: E128 continuation line under-indented for visual indent
2855:10: E128 continuation line under-indented for visual indent
2856:10: E128 continuation line under-indented for visual indent
2857:10: E128 continuation line under-indented for visual indent
2858:10: E128 continuation line under-indented for visual indent


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
147:16: E126 continuation line over-indented for hanging indent
152:58: E203 whitespace before ','
210:15: E126 continuation line over-indented for hanging indent
213:1: E402 module level import not at top of file
247:17: E203 whitespace before ':'
248:22: E203 whitespace before ':'
249:20: E203 whitespace before ':'
250:18: E203 whitespace before ':'
251:24: E203 whitespace before ':'
252:22: E203 whitespace before ':'
253:19: E203 whitespace before ':'
254:20: E203 whitespace before ':'
255:23: E203 whitespace before ':'
256:18: E203 whitespace before ':'
257:17: E203 whitespace before ':'
258:19: E203 whitespace before ':'
259:20: E203 whitespace before ':'
260:21: E203 whitespace before ':'
261:19: E203 whitespace before ':'
262:20: E203 whitespace before ':'
263:17: E203 whitespace before ':'
264:24: E203 whitespace before ':'
265:23: E203 whitespace before ':'
266:21: E203 whitespace before ':'
267:37: E203 whitespace before ':'
281:4: E131 continuation line unaligned for hanging indent
310:1: W391 blank line at end of file


1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
25:1: I100 Imports statements are in the wrong order. import logging should be before import sys
25:1: F401 'logging' imported but unused
27:1: I100 Imports statements are in the wrong order. import re should be before import urllib2
31:1: I101 Imported names are in the wrong order. Should be CFG_BIBINDEX_FULLTEXT_INDEX_LOCAL_FILES_ONLY, CFG_BIBINDEX_SPLASH_PAGES, CFG_SOLR_URL, CFG_XAPIAN_ENABLED
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
32:6: E126 continuation line over-indented for hanging indent
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.miscutil.solrutils_bibindex_indexer should be before from invenio.utils.html
39:1: I101 Imported names are in the wrong order. Should be BibRecDocs, InvenioBibDocFileError, bibdocfile_url_p, bibdocfile_url_to_bibdoc, download_url
39:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.miscutil.xapianutils_bibindex_indexer
40:6: E126 continuation line over-indented for hanging indent
44:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibsched.bibtask
45:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.ext.logging
45:1: I201 Missing newline before sections or imports.
46:1: I201 Missing newline before sections or imports.
48:29: E261 at least two spaces before inline comment
51: D203 1 blank line required before class docstring (found 0)
51: D208 Docstring is over-indented
51: D200 One-line docstring should fit on one line with quotes (found 3)
56:41: E251 unexpected spaces around keyword / parameter equals
56:43: E251 unexpected spaces around keyword / parameter equals
56:66: E251 unexpected spaces around keyword / parameter equals
56:68: E251 unexpected spaces around keyword / parameter equals
56:94: E251 unexpected spaces around keyword / parameter equals
56:96: E251 unexpected spaces around keyword / parameter equals
56:123: E251 unexpected spaces around keyword / parameter equals
56:125: E251 unexpected spaces around keyword / parameter equals
56: D102 Missing docstring in public method
59:49: E127 continuation line over-indented for visual indent
60:49: E127 continuation line over-indented for visual indent
61:49: E127 continuation line over-indented for visual indent
63: D401 First line should be in imperative mood ('Allow', not 'Allows')
63: D400 First line should end with a period (not 'g')
67: D400 First line should end with a period (not 'r')
72:5: E303 too many blank lines (2)
72: D401 First line should be in imperative mood ('Return', not 'Returns')
72: D400 First line should end with a period (not 'y')
72: D205 1 blank line required between summary line and description (found 0)
72: D208 Docstring is over-indented
100:28: E713 test for membership should be 'not in'
152:66: E261 at least two spaces before inline comment
170:29: F821 undefined name 'file_converter_logger'
170:60: F821 undefined name 'old_logging_level'
179:5: E303 too many blank lines (2)
179: D102 Missing docstring in public method
183:5: E303 too many blank lines (2)
183: D102 Missing docstring in public method
186: D102 Missing docstring in public method
188:1: W391 blank line at end of file


4: L102 copyright year is outdated, expected 2015 but got 2012
30:1: I100 Imports statements are in the wrong order. import time should be before import urllib2
31:1: I100 Imports statements are in the wrong order. import os should be before import time
34:1: I100 Imports statements are in the wrong order. import tempfile should be before import urllib
35:1: I100 Imports statements are in the wrong order. import shutil should be before import tempfile
42:1: I101 Imported names are in the wrong order. Should be CFG_BIBUPLOAD_FFT_ALLOWED_LOCAL_PATHS, CFG_TMPSHAREDDIR
42:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.url
42:1: E402 module level import not at top of file
49: D203 1 blank line required before class docstring (found 0)
49: D204 1 blank line required after class docstring (found 0)
51: D102 Missing docstring in public method
56: D203 1 blank line required before class docstring (found 0)
56: D204 1 blank line required after class docstring (found 0)
61: D400 First line should end with a period (not 'e')
61: D205 1 blank line required between summary line and description (found 0)
121: D400 First line should end with a period (not 'a')
121: D205 1 blank line required between summary line and description (found 0)
217: D401 First line should be in imperative mood ('Finalize', not 'Finalizes')
217: D400 First line should end with a period (not 't')
217: D205 1 blank line required between summary line and description (found 0)
252: D401 First line should be in imperative mood ('Copie', not 'Copies')
301: D209 Multi-line docstring closing quotes should be on a separate line
301: D400 First line should end with a period (not 't')
301: D205 1 blank line required between summary line and description (found 0)
323: D401 First line should be in imperative mood ('Open', not 'Opens')
323: D400 First line should end with a period (not 'd')
323: D205 1 blank line required between summary line and description (found 0)


yaml


oh, oops, the file wasn't changed on my side.


1: M111 unrecognized component name: legacy


Lo mismo que con el ```margin``. No hace falta declarar ```padding-top: 0```


Rather parse `,format=qcow2` than `:qcow2`


Avoid variables with short names like $id. Configured minimum length is 3.


Class ProjectStatusChanged does not have a Docblock comment.


Class DeploymentStatusChanged does not have a Docblock comment.


Class ServerStatusChanged does not have a Docblock comment.


Class ServerLogChanged does not have a Docblock comment.


@mbernat Hmm, theoretically I could pass a pointer to `err` and the value would be checked in `defer` so that it becomes something like `defer rollbackOnError(&err, action)`, which is better, true...


rather parse `file:hda=/tmp/img.blah,format=qcow2`


Hi Matthias,
I see. If the data for API level isn't there in the API, what would you think of flipping the fallback behavior? For example: the SDK could consider a version letter to always be newer than a version number. It seems unlikely that a preview build will ever be too old. We test our app on preview builds, and the current behavior makes it harder for us to keep betas up to date every time a new Android version preview comes out


same for this one.


Your examples at the end are pretty good.  But your explanation at the beginning about what io redirection and piping actually do is awful.

On the first half, you get 0/50 points.  On the second half you get 45/50.  The minus five is because some of the explanations could be reworded a bit better, but they're overall pretty good.

I'm not entering a grade for you yet.  Please fix the first half and resubmit before Thursday at 3PM.


change the format in the commit description


Done


There is a typo in `recursivaly`. Also a capital letter at the beginning looks better.


@tchap I don't understand this message.


s/and essentials to understand and implement/of
s/using/in


adding comment


the format needs to be changed here


And here too


Just mention `file` so far


this one? https://github.com/SUSE-Cloud/automation/commit/c4768bad3e0cc0ca87702bd171026ce8aecdbc23


s/programming for a beginner level programmer, even an expert level programmer, much faster and/programs much


I think generally we should write some JSDoc, at least for such pure functions


or any other libvirt supported target disk


@mbernat True. That is not really happening right now. I guess that I didn't do it because I didn't need it and also it's a complete pain to implement since you have to fetch all review requests and iterate over to see which to discard I guess. Or maybe RB got more clever, but I barely think so... Anyway, I am always submitting the reviews as soon as they are accepted to clean up the list. It has always been pretty sufficient, but we can implement submitting as well...


Actually, just delete this whole paragraph and get to the example


Dit sloopt het idee dat je parameters kan meegeven aan glut, bijvoorbeeld om de maat van het window te defenieren:
https://www.opengl.org/documentation/specs/glut/spec3/node10.html

Maar voor nu is het wel prima denk ik.


this isn't c++


Mention that this is optional and the format can be guessed from the image extension


use backticks, not single quotes


filenames need to be in backticks too


@mbernat It is fixed somewhere else, should be `Make sure milestone ...`.


How am I supposed to notice this?  You need to tell me what command to run to check this.


wouldnt it be better, if you did not catch it?


No we can't.  You need to tell me what command to run to check this.


sentence doesn't make sense


sdfsd


your explanations don't make sense


the function name is not telling what this function does, maybe 'log_migration'?


Barf.  Anyone reading this already knows what stdin/stdout/stderr mean.  Just use those terms from the beginning.


This should probably be inside the "if"


delete this sentence; in the previous sentence, make the word `fstream` a link to cppreference.com


filenames in backticks


delete


unfortunately every other plugin does NOT support cordova ios 4.0.0 :8ball:


You need to provide specific commands that tell me how to do this.


Ok, I will modify the code.
Some other components need to be refactored.because they still using Object.keys:
- advaned-search,
- common: group-mixin,
- common:search-mixin,
- facet-box
- ...


Done


Hmm, here if `full_newname` does exist, we silently ignore and don't do anything to that file. Is that intentional, or wouldn't it be better to abort to an error if that does happen?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16044/testReport/) for this commit**


Is the `mceliece_work_factor` of type uint or double? MSVC warns here
> warning C4244: 'return' : conversion from 'double' to 'size_t', possible loss of data


Hmm, dit werkt dus niet:
```
cd src/ && make test
g++ main.cpp mesh.cpp raytracing.cpp -w -Wall -std=c++11 -o ray-tracer -lGL -lGLU -lglut
./ray-tracer 100x100
Single image test mode
Left button: turn in XY,
Right button: translate in XY,
Middle button: move along Z.
Load material file models/dodgeColorTest.mtl
4  materials loaded.
Create glut & raytracing image from '100x100'

make: *** [test] Segmentation fault (core dumped) cd src/ && make test returned exit code 2
```


@durran I'm not sure this is a good idea, because it means that embedded documents behave differently than 'joined' documents when using `first` and `last`, even though in most cases they are interchangeable. I raise this as I'm having to do a pretty detailed hunt through our code base to add the sort back in and it's not clear where this needs to be done and where it can be skipped. But maybe `first` and `last` were always a bad idea.


Both done, but awaiting checks?  Ta.


Fixed in ade81c7


In some situations, browser stupidly enough also fire compositionend events with empty data when a composition is aborted by, for example, moving the cursor away. I believe the `\u200b` hack works around an issue with Google Keyboard on Android, but unfortunately I did not take notes and am not entirely sure anymore. I know that in Firefox, an empty compositionend event is ambiguous (it might mean deletion, it might mean abort). I opened a bug on therir bugzilla for this, but it hasn't seen any response yet.


Without seeing the problem live I'm struggling to grasp it. If it's only bookeeping your are concerned with, what about extending your `RubyObject` data type to also take an optional cache you can populate along the way? Would that be an improvement?


doesn't that method already exist?


right, that's my code, will fix


+1, CA c'est de l'inversion de dépendance !


Should at the very least escape spaces in this string.


@gibiansky It seems like these lines made *some* difference. The output still comes piece by piece, which I've tested using `threadDelay` inside the click handler, so there might be something else I was missing before.


Please review.


I think we'd probably like to put this somewhere general and have it take an int for total expected size, so we can print "downloaded x of y" or a little "[====>  ]" progress bar. Generalized enough, it can take a label and be a consumer that just prints progress on a series of steps, which can then be used for building packages, fetching packages, downloading a big thing (like this example of ghc), docker, etc.


@Rantanen has dissected some of the code above, which based on the comments is obviously incorrect, so  at least the IPv6 parts of the code are buggy. The upstream repo has also merged something that looks identical to @jacoscaz implementation. Because of all this and lack of personal needs for this project, my fork will probably be deleted sometime in the future.


@gibiansky The handling of a `RunResult` was missing beforehand, so this might be responsible too.


NO!

The code should start using `cout` and sending output to the screen.  You mention that one way to output to a file is to use the `fstream` library.  But the point of this lab is to use a different technique with the syscalls above.  I don't want the students to have to figure out how to delete/modify any of the existing code.  It should JUST be a matter of adding new code that does the redirection.  Nothing else.

You need to explicitly show the steps to compile the file, run the file (and display the output), then run the file with output redirection in bash (and display the output in the file).  The student's goal is then to make the program do what the output redirection did without having to use output redirection commands in bash.

Does that make more sense?


Haha, that's funny – what's the hook, exactly? You write code with tabs, and the hook converts it to spaces?


Oh no !

Maybe it is a previous bug that doesn't clean the buffer properly. Or the handling of rectangle suck. Basically gabest did a union of all rect instead of the current rectangles lists. Or I miss something...


When reviewing this please be aware that this is unifinished, dummy code that has been pushed to a separate branch as a reference.


these image files need to be relative paths (not absolute) so they link to whatever image is actually in this repo, not your repo


@refractionpcsx2 I think you reverted to the wrong commit? :/


Just out of curiosity, why do we add two invalid caps after the core cap? Does a core thread check this to detect that it is a core thread or is it just for robustness?


@chuan137: can you check again?


`设计部分急于盒子`


delete all of this tutorial information; this information already exists in a better form in the links you provided above; we never want information duplicated in multiple spots


You're right, thanks for fixing it!


just use output redirection and echo to make the file


This needs to be modified in the same way as the output redirection part


delete everything above this


ryurhrh


Why? (if this will enter in the master history, can you reword and add the why to this commit message?)


the example above isn't very good because it doesn't require piping; delete everything above this.


just use this example, but explain it a bit  more


delete this explanation and link to the textbook folder


No, but a main thread expects 3 capabilities in its UTCB: its thread cap, parent cap and utcb dataspace cap. The bootstrap code that unmarshals these caps is the same for all main threads including the core main thread. Obviously, the core main thread has no parent capability, there is no dataspace service available at this point so there is no utcb dataspace capability too.


The collapse on the 3 boxes as you go to mobile width is fantastic!

Unfortunately the button text overlaps :(

![screen shot 2015-06-10 at 09 54 44](https://cloud.githubusercontent.com/assets/282788/8078601/be94ac40-0f56-11e5-9f2f-f445c4f33519.png)


this is not an interesting example; use the same example you had above of history and grep


Hmmm... This PR isn't what I want it to be.


@tchap Perhaps "Milestone %v not found." would be a better message than "Weird"?


delete this file


done


i finalment també ha calgut instal·lar:
* pkg-config
** brew install pkg-config


thank for u help！！！


@gaearon @acdlite I was tricked by this method as I thought I can just do `setState({ foo: 'bar' })`, but instead I should be doing `setState(store(state, action))`, where `store` is actually [this](https://github.com/gaearon/redux/blob/master/src/utils/composeStores.js#L4) function.

It's quite confusing and if you're not careful it's error prone. Any idea how to improve this?


```
ubuntu@box969:~/ti1806-computer-graphics$ gdb ./src/ray-tracer
GNU gdb (Ubuntu/Linaro 7.4-2012.04-0ubuntu2.1) 7.4-2012.04
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://bugs.launchpad.net/gdb-linaro/>...
Reading symbols from /home/ubuntu/ti1806-computer-graphics/src/ray-tracer...(no debugging symbols found)...done.
(gdb) run 100x100
Starting program: /home/ubuntu/ti1806-computer-graphics/src/ray-tracer 100x100
warning: no loadable sections found in added symbol-file system-supplied DSO at 0x7ffff7ffa000
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Single image test mode
[New Thread 0x7ffff190c700 (LWP 12761)]
[New Thread 0x7ffff110b700 (LWP 12762)]
[New Thread 0x7ffff090a700 (LWP 12763)]
[New Thread 0x7ffff0109700 (LWP 12764)]
[New Thread 0x7fffef908700 (LWP 12765)]
[New Thread 0x7fffef107700 (LWP 12766)]
[New Thread 0x7fffee906700 (LWP 12767)]
[New Thread 0x7fffee105700 (LWP 12768)]
Left button: turn in XY,
Right button: translate in XY,
Middle button: move along Z.

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff6ad07e4 in fclose () from /lib/x86_64-linux-gnu/libc.so.6

(gdb) backtrace
#0  0x00007ffff6ad07e4 in fclose () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x0000000000408b36 in Mesh::loadMesh(char const*, bool) ()
#2  0x000000000040f7ae in init() ()
#3  0x000000000040489f in main ()
```


(this is probably fixed later, but will want to call the user-given callback `cb` etc)


Is fixed later.


@tchap :+1:


may want to make this into a set of functions like `isAuthor(author)` etc so can check in one place.


As-is, I can't use this lab for future classes.  The problems aren't like we discussed in office hours; you're including a lot of explanation that I wanted removed; and your writing quality is VERY wordy and convoluted (I didn't mark all of these places up).  As-is, this would be a 40/100.  I'm not entering a grade for you yet though.  Please resubmit by Thursday at 3PM.


espace en trop :stuck_out_tongue:


argh! It's gone and made a mess >.< It was the right commit, it just decided not to do all of it


fast-forwarding develop to borshop-integration-1162-bugfix/missing-syslog-items-in-config-schema = 5f6caea6


Hi Edgar,

No, this is not a known issue. Please [post a new issue](https://github.com/mike42/escpos-php/issues/new) on the bug tracker and *include the version of PHP which you are using*, so that I can see if I can replicate the problem.


So the bootstrap code would get stuck.


You've just placed these examples here but you don't even mention them in the writeup.  You need to explicitly explain what's going on.


yeah this looks good to me :+1:


Done later.


Same as above.


Minor: I would make page_rounded_size and phys_addr const.


filenames in backticks


ohhh


does `emit` get patched in by them into the scope or something? (i see the https://github.com/BeagleLab/beagle/blob/cb109704f4b169bc26d3c0e75da660a0beebe915/js/data/schema.js#L1 )


@mbernat This prints `Weird, review milestone for release RELEASE not found` or something ;-)


Hi,

On 09.06.2015 23:08, André Luiz dos Santos wrote:
> My initial thought was to create a new pull request, but I did not
> know how
> to proceed, since I needed to change a file that was only available in my
> first pull request (the test_api.py file). Should I have created a new
> branch off of my unittest branch, and then created a new pull request for
> that one?

or you create a new branch of master and cherry-pick the changes needed
for your 2nd pull-request. Also try to keep your master branch in sync
with the upstream repo (git fetch upstream; git rebase -p
upstream/master) and rebase your pull request repositories against your
master branches.

>
> On Tue, Jun 9, 2015 at 3:48 PM, André Keller <notifications@github.com>
> wrote:
>
> > Hi,
> >
> > makes sense. I added a similar version to master (with exception
> handling).
> > Next time please do not push commits for different features into the
> > same pull-request (make a branch/pull-request per feature)
> >
> > g
> > André
> >
> > On 09.06.2015 17:14, André Luiz dos Santos wrote:
> > >
> > > Why not use sendall instead of calling send for each character?
> > > It works with SSLSocket as well as with ordinary sockets.
> > >
> > > def write_sock(self, string):
> > > self.sock.sendall(bytes(string, 'latin-1'))
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/andre-luiz-dos-santos/tikapy/commit/57f521188c164a09b9d3e1ea89a0a2a1bb039b73#commitcomment-11591209
> > >.
> >
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> >
> <https://github.com/andre-luiz-dos-santos/tikapy/commit/57f521188c164a09b9d3e1ea89a0a2a1bb039b73#commitcomment-11595842>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/andre-luiz-dos-santos/tikapy/commit/57f521188c164a09b9d3e1ea89a0a2a1bb039b73#commitcomment-11598524>.
>


I dunno whats going on but i tried to recommit the old MMI files and it said they were out of date, i did a rebase and now it thinks they're right.  GIT was fine til i updated it recently, grrr. guess ill re-checkout and copy them back in


@stefano-k: this will require some new translations...


Reverting changes, published to the wrong repository.


Ok. I will change it


```haxe
t(unit.TestType.typeError(addEnumListener(NoMessage, noMessage)));
```
should be

```haxe
t(unit.TestType.typeError(addEnumListener(NoMessage, onMessage)));
```


I can see that `itBehavesLike("events coordinator")` takes different configurations (different `value` and `isNil`) what for me means different `context`s. However, this is a tiny, not very important change, so it's up to you to change it or not. I just pointed out an opportunity to use one describe and separate contexts, because they describes the same thing, but only in different situations or states.


Make sure it's not just that file that is missing, might be other stuff too. Sorry for this mess...


it was just the 2 mmi files which are linking to a file that no longer exists :P I'll have this sorted in a min


Basically. It's what is able to be compared to the `key`.


Really? is it REALLY that cool?


awh that's great, fixed.


I do not get it.
```c++
precPetsc->attachInHousePreconditioners("blockns",a_blockns);
```
What is precPetsc ?


Put this back please. Please don't rename things in my code without speaking to me. Also please stop! commiting directly to next.


this cookbook already supported tomcat7, it just wasn't the default


I am not a huge fan of that new API (ie. it's quite verbose when you want to use a format string) but I didn't manage to get something simpler working without loosing perf ... if anyone has a better idea, I take it :-)


The code block above is too big; interleave your explanation with it.


delete this information


Can not convert file encoding of UTF-8 to GBK, it was saved as UTF-8 instead  类似这个提示,昨天遇到的
今天我再看下


Thats great! Thanks!


Yes, you are right - the `if` block is not needed!

Have pushed the fix for this.


I surely intent to


make the same changes below that I said to make above


that's not what the current working directory means


Ok. Yea I dont blame you. I would take a little breather also if I did all the work you did. Anyways I also noticed that to changed up how the "Class Weapons" sheet looks. I gotta hand it to you it looks nice. Just hope it doesn't screw up Feats that grant weapons and armor proficiencies


Pretty sure you're wrong.  Can you link me to documentation that states this?


Unfortunately cordova ios 4.0.0 is not released and as so other plugins are not supporting cordova ios 4.0.0


Utilities/Math.h should be included from what I see here...
https://github.com/PCSX2/pcsx2/commit/ed9dbd9faed6f6f10bb1f53b130082a90a1279a2


:smile: :+1:


Avoid Using Ternary Operators, they are not part of good code writing practice


it was added in the commit you asked me to revert, we've never used math.h


Awesome! Thanks!


Нужно использовать 1 из способов или rebuildCache(); или cachedContacts = null;


Protocol files were left off by accident! Please see subsequent commit


Both `cardiaca` and `cardíaca` are accepted by the *Royal Spanish Academy*. `Cardiaca` is the preferred form in Peninsular Spanish, and `cardíaca` is the preferred form in Spanish of the Americas. [[1]](http://lema.rae.es/dpd/?key=card%C3%ADaco)


Этому методу место в HelperBase


delete this extra information, the same way I had you do it from the previous file


boolean formType - этого параметра здесь уже быть не должно


try {
...
} catch (ClassCastException e) {
   throw new ClassCastException(activity.toString() + " must implement ...... ");
}


Well, seems to be a composer issue: https://github.com/composer/composer/issues/2959

Also getting stuck on this PR with Travis: https://github.com/sonata-project/SonataUserBundle/pull/564


i-ый контакт здесь не выбирается


Fixed.


wasn't aware of Jade's availability for armhf


Если есть rebuildCache(); то это обнуление не нужно


Your examples are reasonable, but not amazing.  You will get 40/50 on the technical part of the grade.  Your writing is rather disjoint, and the contents feel very cluttered and just thrown together.  You will get 30/50 on the writing part of the grade.

I'm not entering your grade yet.  Please make the changes I pointed out and resubmit.  When you resubmit, provide a link back to this commit.


Please do this before Thursday at 3PM


В этом классе методы универсальные, в нем не должно быть методов с конкретными локаторами.
Эти методы относятся к форме контактов, значит им место в ContactHelper


Вместо этого if сразу пишем:
return driver.getCurrentUrl().contains("/group.php") && driver.findElements(By.name("new")).size() > 0)


Fixed!


Hi @saulvargas,
Could you check if these examples for ETD and binomial diversity make sense? Especially if the pastRecommendations function is something that you were using? Also, what is a good alpha to use for the binomial model?


Text for "reason" must be made translatable.


Can we please double check if https://jira.talendforge.org/browse/TMDM-8257 is not broken.
Related commit: https://github.com/Talend/tmdm-server-se/commit/2c71c38642ae7d02068484607fd1c35d9598346b


Not necessarily, I think in the current implementation it would return an invalid capability either, but it is more safe for future modifications to transfer the correct amount of capabilities where they are assumed.


This file is converted form BQ Aquaris E5 4G's fw.
We can hexedit this fw, but there is almost no info about it. Its like editing blind.


Just wondering why you chose 1.1 here.
1.0 would make more sense...
Shall I change this to 1.0 or is there a particulare reason for the 1.1 value?


There is really no reason for translatable formats. Just use the same name at all of the places. They were not synced before but it is not a reason to keep the same names.


Hi Mark,
I agree, just created #72 for this. Appreciate any feedback.
Unfortunately at least this time you will have to update the SDK one more time to get this fix once it's out.
Best,
Mat


Ok. Thanks for the explanation :)


My apologise TortoiseGIT, looks like GIT made an absolute hash of it.

I'll let you fix it @gregory38 , you're better at taming the GIT beast than the rest of us ;p


@tchap hm, okay, but that's unreliable. If the library's author changes that or something goes wrong, you'll get no descriptive error. But fine, not a big deal.


@johnsimons please review


Good catch! That's the problem with error tests and not actually checking for the error message.


@dominikl

Tested using OMERO.insight-5.1.2-62-1e098b0-ice34-b530-win on Win 8 and OMERO.insight-5.1.2-62-1e098b0-ice34-b530-mac_Java7+ on Mac - trout merge - user-3 and user-4

 ROI analysis tools working as expected.
Graph pane and intensity view in ROI tool working as normal.
No connection issues/failures encountered.

Good to merge as far as these tests are concerned.


Quick fix to a padding issue that was causing the simulation to get stuck in an infinite loop. A major overhaul of how we deal with padding is badly needed


@udalov
Please take a look at this small commit --- it is similar to extracting common logic in KotlinAbiVersionIndex


Docblockow brakuje - dodaj pliz wszedzie


this looks not correct.


Your conclusion still looks gigantic to me and doesn't provide any new insights.  I'm giving you 95/100 docking 5 points for the conclusion.


@monde we will do a release soon. Right now I'm focused on adding encryption/decryption support and later want to review all the issues/PRs reported in order to add some.

Maybe as you suggest we do a 1.0.0 release.


* TODO: rewrite this as it is doing way too much and is very messy now


// FIXME: Handle this situation as it is then unclear what went wrong


* TODO: refactor these 2 functions


'cipher' => MCRYPT_RIJNDAEL_128, // FIXME: See if we can update this to the recommended 'AES-256-CBC'


You haven't explained what an inode is.


'In our recent blog post,...'

also it's not clear ...'specifically around freeing the produces and consumers...'


I think you should be able to include hidden elements like this `page.has_css?("script#naughty", text: @javascript, visible: false)`


To explain myself a bit, the presenter can have a method called IsValidName, but the view should not have any concept of what's valid or not. It only needs to know whether or not it's button is enabled.


you don't explain what a data block is


There's no implementation of sharing so far, this was a mere bugfix.
I don't think this is implemented in the namenode yet?


you're using the wrong formatting for the header


this doesn't make sense to me


this section was hard to follow


This like isn't very clear.. 'It is a subtle impedance we overlook because of the distance we've made it in HTTP APIs and because the spectrum of frameworks, libraries, and tools promote this coupled thinking.'


We do place a space between "if" and the "("...


なんじゃこりゃ？


Please uppercase the log message, like an english sentence.


We place a space between "if" and "("


@tcrsavage this is really the main change that I've done to your PR https://github.com/dashaluna/hm-content-toc/commit/f8a7fe7ca0e1d368ce053a64e1f872d78a011456#diff-a20892fca22525983b4f0537d0ea0ebaL252 (others just vars renaming & adding comments)

As I understand it, we want the passed param `$post_content` (which has got shortcode placeholder HTML and all content filters applied to it up to priority 12).
We don't want `$post_content = get_the_content();` which is pretty much raw content (without any filters run on it).

Is that correct?


I understand you don't want to put logging into the tests - but if a test fails it would have to at least log this exception to standard out.


Waarom heb je dit verwijderd? Dit was handige info om de status van CakePHP te bekijken. DB connecties e.d.


Update:  A more detailed howto can be found on my blog at http://www.opennet.za.net/e107/e107_plugins/content/content.php?content.12


@tcrsavage this is really the main change that I've done to your PR (others just vars renaming & adding comments)

As I understand it, we want the passed param `$post_content` (which has got shortcode placeholder HTML and all content filters applied to it up to priority 12).
We don't want `$post_content = get_the_content();` which is pretty much raw content (without any filters run on it).

Is that correct?


This oldidx creates a warning when compiled with -DNDEBUG.


Belle vengeance !!


Jumping between 'user' and 'users'


Obrigado Sérgio. I will accept your commit, but replace it later by (mb_convert_encoding($str, 'HTML-ENTITIES', 'UTF-8')), as I prefer it to the prepending. Please tell me if it works for you, ok?


今天使用Linux安装git gui工具，第一次选取的是git-cola，但在centOS上安装完毕之后，PyQt4总是被git-cola识别不了，无奈之下，选取了另外一款工具giteye，初次使用，还是比较方便的。


Your technical information is pretty good.  There's a few minor mistakes, but the good content makes up for it.  You get 50/50 on that.  The writing and organization, however, is difficult to follow.  Lot's of explanations are missing completely.  You get 25/50 on this section.


Not that it would matter much, but I think we should not check against the precise value of 1, but instead simply consider it negative, 0 or positive, Hence, change this check to "if (r <= 0)" or so...

Also We place a space between ) and {.


I think these should be capitalized 'Create, retrieve, update, and delete'


Please add a test for this.


Space between "if" and "("


Why?


What is the reason not to store the embedded database in memory anymore?


@mbernat I think that it's ok. In case the error is not `*ErrMilestoneNotFound`, a regular error is returned. And in case it is of this type, we just use the error message as represented by the error, which is IMO reliable enough.


Also, it's not enough to just silently fail. The user needs to know they selected an invalid location.


Please avoid doing function invocations and assignements, and checks all in one line. There's no shame in doing this in two lines, i.e. first assigning the result to r, and then checking r...

Also would prefer the check to be <= 0 again...


Uppercase message string please, and space between if and (.

Also, if we ignore an error, then it's not really an error, but more a warning, hence the log_error() message above should actually be log_warning() I think.


True it’s a miss type but 1.1 also works but Booleans should be 1.0 and 0.0 as you corrected it to.

From: Marcel Groothuis [mailto:notifications@github.com]
Sent: 10. juni 2015 11:22
To: lausdahl/fmi-export-20sim
Cc: Kenneth Lausdahl
Subject: Re: [fmi-export-20sim] Temp addition to support booleans as reals. This allows a boolean to be set with a real id. Basically allowing a scalar variable in the model description with type Real to be exposed with type Boolean. This should ofcause be removed

Just wondering why you chose 1.1 here.
1.0 would make more sense...
Shall I change this to 1.0 or is there a particulare reason for the 1.1 value?

—
Reply to this email directly or view it on GitHub <https://github.com/lausdahl/fmi-export-20sim/commit/61eb4b9c8a516e28dc54aaf5ecda1a26c4636770#commitcomment-11606988> .  <https://github.com/notifications/beacon/ACdMOlmzywPyJHhZLxrYD1mAS_9oW1a0ks5oR_kpgaJpZM4E-NBa.gif>


> Using only what CRUD provides **leaves** the users of an API to figure out what can be done ~~with the API through~~ **by** understanding these concepts around **the** URLs and HTTP methods.


It is under development by Mahmoud. First step is to get multiple users, he's working on that now. Then this fix will be relatively straightforward.


Since we ignore this condition really, this should not be a log_error(), but a log_warning(). Also, uppercase first char of english sentences please.


@3nids  this is cool! Have you thought about adding it to the prepare commit script?


Hmm, you copied my whitespace mistake over... Of course everything should be indented here by multiples of 8 whitespaces here, but this one is indented by 15...


> For example, the aspects of CRUD alone ~~do~~ not **only** convey how a client may **might?** change the state of a resource, how one resource is related to another, or what actions can be taken that don't fit into these four principles.


still testing...
I'll see if I can integrate it later on!


Looks ok

On Wednesday, June 10, 2015, Andreas Öhlund <notifications@github.com>
wrote:

> @johnsimons <https://github.com/johnsimons> please review
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Particular/PBot/commit/2c725b27b3afe7d82d93c5538c645f65d2c629ba#commitcomment-11607014>
> .
>


> it can also be a barrier to ~~enter~~ **entry in** the API design space.


closes #1


PHPCS: There must be one blank line after the namespace declaration


PHPCS: There must be one blank line after the last USE statement; 0 found;


DRY?


You forgot about line lengths (including undoing a previous fix)


Ok


so then it would be `~6.0.0@dev` ?


single quotes


Where does this import refer to?


remove extra spaceline


> **For example, how will the API will be used, by whom and what are the specific use cases that need to be addressed** ~~what will users do with your API?~~
It's something I read yesterday — not sure if it works or fits but I think it would be beneficial to have a boarder understanding as to **why** this approach is better.


Added a new class `Navigator` that has a command line interface as well as initiates rover.


keen to join


one line it


amm... I can't grab edge when I press action and back (it broken again) + in case of "climb on" loosed no_fix_all flag, so Lara's position in end of climbing become wrong; May be it is previous changes in anim_state_control.cpp module;


This line is a bit of a run-on and not clear..
> The goal should be to move as much shared understanding as possible away from the server and client source code to API description documents, profiles, and media types that may be used at build time and runtime.


Linking to issue #10.


potrzebne do działania daty


I experienced that different bluetooth devices cause very different reactions. One (a headset Plantronics ML 10) interacts only with Androids phone system (and does not make Osmand to react in any way), while the media button of another one (TCM 304956) correctly starts a voice notice registration (if the audio/video plugin is configured this way), but there is no way to stop this registration (i.e. recording) without touching the smartphone screen. The volume buttons do not cause any reaction.
The best way to provide the feature and to avoid issues with certain devices IMO would be the possibility to switch the feature on or off (in the plugin configuration).


rok miesiąc dzień - lokalny czas


I missed the `RequestStackAware ` part and assumed you did not have need for a specific kernel version, branch alias it is, lets keep the discussion going in the other place, and soon PR's.


**Love this!**


do you need var ```view```?


Thanks. Fixed in a1f945578739df37bbdb06e7e53c14c90f5559ed.


It is better to use the system variables:
AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY
Documentation:
http://boto.readthedocs.org/en/latest/boto_config_tut.html#introduction


confirm always exist??


I think you can come up with something a little stronger :)
> We are just on the cusp on what **could be accomplished** in this **area**.


Hmm, I cannot parse the commit msg "SO_GETPEERCRED is dropped to be consistent. We also should
get this information at connection time."

Also, the struct ucred in the sd_bus structure, that can now be dropped, right?


nice


lets do it


I understand why you choose _**may**_ over _**might**_ but it comes across as passive, thoughts?


The name should be javax/security/auth/message
The implementation title should have been changed when you created this file from a copy
The EGs are very inconsistent when it comes to maintenance releases. Sometimes they increment the version, sometimes not. Therefore we always include the MR info in the implementation version so folks can be sure what they are getting.


> The inverse of this is actually true—**a** shared understanding frees the users of an API to be creative by providing better visibility into the design and purpose of the API.


element.find_element_by_xpath(".//td[2]") - поиск нужно делать относительно эдемента


этот параметр не нужен


what about `query: Query` in `Dependency` definition?


hello world


sweet


Yes we used it ! :)
Very usefull node for "music event" (for example)


`TypeError: Invalid argument props supplied to struct combinator`

as `Query` is not initialized yet, there


do you need check ```&& this.get('vlan_id')``` here and below in ```else if```?


extract vars needed


No reboots at the moment so I hope it's fixed :) // but I'm not analyzing device logs all the time ;)
BTW Big thanks for F2FS :+1:


why sprintf here?


这里推荐你使用 transtionend 事件去替代 定时器，就更好了。


Since the `SQL()` returns an array {empty array for no row}, it will always be `set`. better idea would be to use, `count()` method here! And add a condition if `count($result) == 0`


let's put field first


> The idea is that by communicating the semantics of a more richly-defined system, you empower your users to be **more** innovative and intrinsically provide **better** value to them.


all the same comments as for ```www/js/models/fabrics-vlan-network.js```


Could you undo the change to this line? It gives me this error:

    /home/matthias/dev/ufo-core/ufo/ufo-task-graph.c:1: unexpected character `�'


Когда выполняешь данный запрос - отабатывает без ошибок ?
У меня такое выдает:
 Ответ MySQL: Документация
#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '5    SELECT @cnt:=@cnt+1 AS NN, IF((fin.nplane) IS NULL,"",fin.nplane) as num, fin.' at line 1


We talked about this!  Everything above is straight from the manpage, and so should not be duplicated here.  You should be explaining the examples and nothing else.


oh, right, recursion!


There's lots of functions in the text missing backticks.


Normally there is git revert <hash> command. I could look to fix this ugly but only after work. Otherwise don't try to fix it if you can't :)


> It may be beneficial to look at an example of thinking this way. We'll use API Blueprint ~~for designing a simple API for a todo list service~~ **to quickly design/describe an API for a simple todo list service.**


maybe we could add: passed value x 1.6  to be precise.


not valid code


@o-smirnov please check if this is still working after all the merging and stuff.

If so we can do a release. You can do this also, very easy, just make a new release on github :) make sure that the release number matches the version in the source code (`radiopadre/__init__.py` i assume). new package will turn up on pypi after a short while.


You need to actually specify a path.


Why the `server-name` option was removed?


@hflynn Do you want to replace ``slated`` with ``planned`` here as well ?


This example adds no new information and should be removed.


really


For input redirection is it okay if the exercise is to take the contents of a already existing file called `infile` and displaying it to screen?


asdfasdf


@lethalman I agree, the use of nixos-artwork adds several unnecessary MBs to the system closure.


Yes.  It should be exactly like the output redirection:  The initial
program uses `cin`; you should how to get input from `infile` using input
redirection; the task is to modify the code so that the program gets input
from the file without using the shell's redirection.

On Wed, Jun 10, 2015 at 5:00 PM, ZhuLeon <notifications@github.com> wrote:

> For input redirection is it okay if the exercise is to take the contents
> of a already existing file called infile and displaying it to screen?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lboyd002/ucr-cs100/commit/dcf03e6af7a326729a03549ea61de483ecdc412e#commitcomment-11623838>
> .
>


[It worked!](http://www.kosagi.com/forums/viewtopic.php?pid=1827#p1827) Thanks again for your help.


Oh, I actually meant Set entries. It seems you use the choice function any time there is a variable in the item, even if they might be fixed by other lookups.


@Mantish Caray, esa no iba ahí, ya la quité. Va en el próximo commit.


@OnlyByGrace I really like where you're going with this. Is the code you added for live transcribing working for you? I keep getting an error, appears to have something to do with the headers.

```
File "/home/pi/jasper/client/stt.py", line 633, in transcribe_live
    headers=self.headers)
```


Ok, I think I get your point about code units vs. characters.

I don't think alignment is a `Strings.jl` problem, that seems like a Julia GC problem. Obviously, this is using a custom `StringPool` type right now, but that's a hack so I can emulate having Strings point to Julia-allocated memory blocks.

Sorry, I asked on your Encodings PR what it was for and didn't hear back, so I forgot to leave it in. I'm not sure I quite understand the Binary encoding though. Why not just deal with a `Vector{UInt8}`/`Vector{UInt16}` if you were worried about your data getting converted?


TeamCity YaccConstructor :: YC.Core General Build [Build 445](http://teamcity.codebetter.com/viewLog.html?buildId=193019&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 116 Build time: 00:13:24


This seems to make the name "java" give a do-nothing backend. That's really not a good name.


You can break `illiad_params` into a separate method.  This will probably only get you until the params hash is too large (which may or may not be a problem).

You can also use string interpolation (e.g. https://github.com/sul-dlss/sul-requests/blob/proxy/app/models/proxy_access.rb#L57) but that may be overkill.


testing code snuck in ^^ accidentally. Reverted in 0c1dd16


PHPCS: Line exceeds 120 characters; contains 138 characters


$this->last_activity = $heartbeat->last_activity; // FIXME: Change so it only sends the actual date not timezone and timezone_type


beginnings of that idea, intended to be non-functional, please review: https://github.com/3drobotics/ardupilot-solo/commits/solo-pr-flight-phase


hmmm commenting these 3 constants (EMU_PS2_DVD, EMU_PS2_CD and EMU_PSX), cause that the constants EMU_BD and EMU_DVD get the values of 2 and 3 respectively, instead of 5 and 6 like in Cobra :( This affects the Disc Insert function in storage_ext.c (which calls  process_disc_insert) when a data BD or DVD is emulated.