dt_util_dstrcat() does not seem to free token, so looks like it is leaking.


Pourquoi on ne les crée pas directement dans l'appli ?
Quel intérêt à les faire créer lors de l'installation ?


Need to check ruby code style – https://github.com/bbatsov/ruby-style-guide
Problem with spacing


Тут используется серверный роутинг. Нужно использовать ui-sref


Nit: This `using` can be out side of namespace.


Шаблоны нужно перенести на клиент


Couldn't help peeking - this is mighty cool! Looking forward to it.

Any chance of adding matrices later?


@vicb not sure if this is really how it should be.


Please put the old comment back.

```
// Unlock unlocks the account with the given address. The account
// stays unlocked until the program exits or until a TimedUnlock
// timeout (started after the call to Unlock) expires.
```


Great, I'll try to check this out when I'll get some free time.


Wel mooier


```
// TimedUnlock ...
```


These are not applicable to the WebGoat-Legacy project


jQuery нужно убрать. У angular другая логика работы приложения
Советую посмотреть видео – https://www.youtube.com/watch?v=5JJFiAS1ys4


According to MSDN documentation [SupportedFrameworkRuntimeEdition](https://msdn.microsoft.com/en-us/library/vstudio/dd393757%28v=vs.100%29.aspx) element "Specifies the versions of the .NET Framework common language runtime (CLR) that are supported by the extension."
I think that the version is not a .Net Framework version but its CLR runtime which is same for all the 4.* frameworks: 4.0. According to the same documentation maxversion attribute is inclusive.

And thanks for the hint about diff comments. I will remember next time.


Bower components не комитятся на репозиторий


And please, give some attending care to you huge TC-methods
(see for instance ``test_dispatcher/test_dispatcher:test_dispatch()``).


Probably you dont need mutex_lock here: you are not protecting any data.


- desaturated colors replaced with disabled variables as state wasn't clear enough.


Just a suggestion - you've already calculated url.indexOf("?") above - maybe just use the "idx" variable instead of re-calculating? Small overhead avoided.


What's the difference between a connection that failed and a connection that closed?


BC is doing something really funky with the fluid registry. It appears to have register lava, twice??!!


:$ to using ocamlc rather than $(OCAMLC)!! Your patch is much better than mine - factoring out .o and .a at the same time is good, though I expect it'll be quite a bit more work to get ./configure CC=cl.exe to allow the MSVC build to happen directly!


ouaahia


Same comment as line 58 in dist/index.html.


confirmation about this logic from RFC: https://tools.ietf.org/html/rfc3493#section-3.7


めっちゃいい


Did you try other grids? IIRC a [0 1 0; 1 4 1; 0 1 0]  is much better.


Maybe worth noting that the names of the sysvinit example files have changed - in case anyone's regenerating them automatically.


That does indeed seem to be the problem - again, your patch is a much nicer fix than mine! :smile:


This should be 'e' not 'event'.


Is this to be expected?


Is this the right logic to skip annotation, instead of reading them?


We don't need this as we already have the message from socket.io being displayed.


Failed means no longer operational connection, but that was not closed explicitly. These connections appear when transport/endpoint closes. We need this state explicitly because we need to differ between these cases, and throw `ConnectionFailed` message when we are trying to use `Failed` connection, and `ConnectionClosed` when we are using `Closed` connection, also in other to send `ConnectionFailure` events between endpoints. In other transport this state is implicit, for example in `n-t-tcp` `ConnectionFailed` is `ConnectionValid` but socket is already closed. And because we don't have any communication channel that could be closed, we have to introduce explicit state for that.


2 part commit?


Thanks for fixing the typo.


:smile:


Wouldn't it be more robust to add an `Extensions` field to the `.cabal` file?


coming up


In fact this one would be fixed just by `(require 'cl-lib)` afair I have it in my branch.


cause this error
ld: 128-bit LDR/STR not 16-byte aligned: from __ZN13CResizeEngine16horizontalFilterEP8FIBITMAPjjjjPK10tagRGBQUADS1_j (0x1006FFF20) to l005@0x00000850 (0x100B825D8) in '__ZN13CResizeEngine16horizontalFilterEP8FIBITMAPjjjjPK10tagRGBQUADS1_j' from /Users/mahmoudnasr/Desktop/-------/-----/AR/QCAR/REVU_IOS/FreeImage/lib/ios/freeimage.a(Resize.o-arm64) for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)


I'd prefer to remove this at this stage, I don't want to get into custom notification sounds at this stage so have defined this parameter as "default" for background use, but for foreground it can just have no sound like the other platforms.


If you rename stuff for whatever reason, please also fix the comments. There are a few comments that talk about 'dropping' and 'dropLater'.


This shouldl likely be based on the fraction of src.GetWidth() / dst.GetWidth()


:cake:


hi, seems like AV already has its own family
INSERT INTO `mob_family_system` VALUES (329,'AbsoluteVirtue',15,'Luminian',0,40,120,140,1,1,1,1,1,1,1,3,3,3,3,1,1,1,1,1,1,1,1,1,1,0.5,1,0);


You were right this did come in as a string "1" rather than a boolean or number. I know I put you wrong by mistake in flowdock when showing you the code it comes from, but then edited my post to correct my mistake which you no doubt missed.


This should be not in the header though. Where's the objc main() & co ?


Thanks, I've just made the alteration to index.html (hopefully correctly, I'm new with github).
Yes I did import several generated addresses into the software wallet and all was good.
Thank you :)


Fair enough.


:niku:


@tonytonyjan Thanks!


What does this have to do with unbinding events?


I'm protecting the register of the device. Maybe I'm slightly paranoid about the split writes. If we get threads A and B in a scenario like this:
```
A writes lower with 0xa;
B writes lower with 0xb;
B writes higher with 0xb;
A writes higher with 0xa;
```
we can end up with `0xaaaabbbb` in the register. I'm not sure it can happen since most registers writes are on paths protected with other locks but taking a lock isn't that much of a cost after all.

Feel free to prove this is not needed, I didn't check it can actually happen ;)


bra jobbat


I'm confused. The latest version is 14.1.3, according to the download page: https://www.jetbrains.com/idea/download/


oh, that's too damn stupid...I never wiped between installations. Thank you.

I hope no one is going to read this :p *hide*


Fixed.


fdsf


This require is broken when you build the project into a gem:

```
[msavy@mmbp pkg](master)$ asciidoctor-pdf --help
/Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/lib/asciidoctor-pdf/converter.rb:10:in `require_relative': cannot load such file -- /Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/lib/asciidoctor-pdf/temporary_path (LoadError)
	from /Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/lib/asciidoctor-pdf/converter.rb:10:in `<top (required)>'
	from /Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/lib/asciidoctor-pdf.rb:3:in `require_relative'
	from /Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/lib/asciidoctor-pdf.rb:3:in `<top (required)>'
	from /Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/bin/asciidoctor-pdf:3:in `require_relative'
	from /Library/Ruby/Gems/2.0.0/gems/asciidoctor-pdf-1.5.0.dev/bin/asciidoctor-pdf:3:in `<top (required)>'
	from /usr/bin/asciidoctor-pdf:23:in `load'
	from /usr/bin/asciidoctor-pdf:23:in `<main>'
```

Think this might have been debug code?


Remove this line.


My mistake, I didn't consider device registers at all :).


The problem with `swapMVar` is that if the thread gets interrupted, then it's possible that we will have left the global state with broken invariants. In particular, when closing the transport, all connections should be in a closed state. `modifyMVar` blocks out async exceptions, though only in its `*masked` variant.

Using the STM here instead is tempting.


I back ported this on v2.1 using the commands you suggested.  Thanks

As regards the expression.  It is the way it is because the function that is used in the histogram bead is the integral of the kernel between the lower and upper bounds.  The derivative is thus the value of the kernel function at the particular point.  However, having thought about this more though I am not sure if I am happy with this whole HistogramBead class at all. I think it is rather confusing.  I need to think but I will try and send an email in the next few days about this.


Code getting a bit verbose. Can you have a look at introducing `withValidLocalEndPoint` and the like, along the model of what already exists in distributed-process for process state?


Added this check to ensure I have one of the possible fields with this method.
If for some reason there will be changes again I wanted to avoid a exception.


I think if we consider using `STM` we should switch all the library to it. I also should help much with closing channels.


Yes.


provided pseudo table/fieldname because those values are used by the render method to retrieve TCEFORM tsconfig information.


@josepjaume I think this is the new ES2015 syntax. @barelyknown Are you running your tests on IO.js (or an ES2015 enabled Node) by any chance?


Line is too long. [106/100]


Align the elements of a hash literal if they span more than one line.


Redundant curly braces around a hash parameter.


Extra empty line detected at block body beginning.


Extra empty line detected at block body end.


Use the new Ruby 1.9 hash syntax.


Inconsistent indentation detected.


Space inside { missing.


Space inside } missing.


I'd add a comment here on why it's needed.


```
[userDescriptor dictionaryRepresentation]
```


Ok, now unar (& 7z) can replace unzip
http://anonscm.debian.org/cgit/pkg-games/game-data-packager.git/commit/?id=949b3c041330a1eb29614bc0d4f2abc84343f18d


Thx for the bug


done in later commit


I see. FYI cl-lib doesn't have lexical-let, so you may need lexical-binding
magic comment to make same variable's scope. Sorry if you already know
about it.
On Jun 22, 2015 03:50, "Jędrzej Nowak" <notifications@github.com> wrote:

> In fact this one would be fixed just by (require 'cl-lib) afair I have it
> in my branch.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yuutayamada/nim-mode/commit/edbc6993d89e4ad52f9ae051406c424cde87d576#commitcomment-11791405>
> .
>


@CodeClubRik I think you need to run `git submodule update` to prevent this from happening


it is done in the won node controller now that controls the crawling process


pretty minor, but I think the convention in the compiler is to use `domain_state.ml` or `domainstate.ml` (ie. no Capital letter in filenames).


@prudhomm This does not run correctly
http://my.cdash.org/testDetails.php?test=19801658&build=782993


есть же методы assertTrue и assertFalse вроде


Yes that is the way it should be. Great find!


@kouno Done.


Thanks


This type of exception is usually thrown by the DecisionEngine class. If rules, actions and input have their own exception class, then so should the DecisionEngine class. That was the reason for creating it.


FFFFUUU~. Надо поправить.


"&"は、実体参照の開始文字として使われるので、"&"を表示したいなら、その代わりに "&"を使おう。


@mrasumof Great! Be sure to set up your GitHub account with a picture and everything as well. Thanks!


странное название метода. создаётся ощущение, что он нарушает принцип single responsibility. но в итоге это оказывается обманом, потому как кэш здесь не чистится


will you make addon in C++?


sureto


Read all posts but didn't find same issue as mine :( I've submited new post there 3 days ago but suppose thread alrdy not popular, could you please review it give ur response?


dov


vhfg


@hvsarma Cool! Do you use that command? It looks like it's designed to move Emacs backup files. You can also customize Emacs so that it doesn't put those files everywhere.

Also, what is your GitHub picture? Is that your logo or something?


s:/@alien0ada/@ailen0ada ;-)


@SystemUpdate

Link works for me, takes me to http://jsbin.com/jadofehoqu/1/edit?html,css,output

Even though the preview might not work, the tool is still fully functional.


странный ход из цепочки вызовов. где тогда тест для метода _dispatchEvent?


changed the name of the method


An other one ? :sparkler:  (here for Spear Of Destiny demo, LHA is also used by quake.yaml & doom2.yaml )

```
unar SODEMO.EXE
sodemo/SODEMO.EXE: Self-extracting LZH
Archive parsing failed! (Unknown error.)
No files extracted.
```


В следующих коммитах метод убран.


I'm probably doing something daft, but I don't seem to be able to get any sound with the new piano synth.
Tried
use_synth :piano
play :c4, sustain: 1

nothing heard

synth_violin works OK


@pipay04 Great! It looks like you tested `xargs` experimentally, which showed you some of what it does but not the main thing it's used for. Have you tried `man xargs`?

Be sure to set up your GitHub account with a picture and everything as well. Thanks!


Cool, now can you also put this as a comment where it is best placed as a comment?


Could you explain somewhere the rational for this `ClosingChan` thing? What tests is it meant to fix?


@piscisaureus FYI this came in with `PR-URL: https://github.com/nodejs/io.js/pull/1991/files`, i.e. copypasta of `/files` in the url


Is this on the RPi? The new piano uses the MDAPiano in SuperCollider which might not be available on the Pi's current version of SuperCollider yet.


```
%p.music-name
%audio.music
%p.explain
```
が繰り返し表示されてるのを見ると、たぶんコレで1セットなので、
```
.column
  %p.music-name
  %audio.music
  %p.explain
```
みたいに、1つずつ何かしらdivでくるんでおくと、
あとの管理が楽かも。


```diff
- example = 'rake config_files:wrapper DEPLOY_USER=deploy SCRIPT_FILE=config/alert-tracks-debian.example'
+ example = 'rake config_files:convert_wrapper DEPLOY_USER=deploy SCRIPT_FILE=config/alert-tracks-debian.example'
```


Это же он и есть.


@yongcho822 :+1:


@Itelina Great! Be sure to set up your GitHub account with a picture and everything as well. Thanks!


нет. это тест проверяет, что вызывается метод _dispatchEvent, а теста метода _dispatchEvent  нет


Also, I think the example `SCRIPT_FILE` should be  `config/run-with-ruby-path.example`?


@wilkung Cool! Like @reshama said, I think you'll find that `xargs` is even more useful than you've found so far. :smile: Be sure to set up your GitHub account with a picture and everything as well. Thanks!


Oh, I see, you are right. I will remove it.

2015-06-22 10:31 GMT+02:00 Matthias J. Sax <notifications@github.com>:

> Why do you call close() here? Flink is calling close automatically.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mbalassi/flink/commit/9421dc44e9c24866a74162061441c2b02cfaa71c#commitcomment-11789321>
> .
>


fails on this one too

```
unar master-levels-for-doom-ii.zip
master-levels-for-doom-ii.zip: Zip
  deice.exe  (36064 B)... OK.
  install.bat  (972 B)... OK.
  master.1  (1436188 B)... OK.
  master.dat  (285 B)... OK.
Successfully extracted to "master-levels-for-doom-ii".
tchet@antec:/tmp$ unar master-levels-for-doom-ii/master.1
master-levels-for-doom-ii/master.1: Self-extracting LZH
Archive parsing failed! (Unknown error.)
No files extracted.
```


Oh nice job.  So this means vboxapi supports py3?  Maybe you could put the compare logic directly into the Enum.\_\_cmp__ function (line 85)?


Might be better to call this `run-with-rbenv-path`?


@wbush008 Great! Be sure to set up your GitHub account with a picture and everything as well. Thanks!


@tyshaikh :+1: (But it seems like `-rf` could be overkill if you're just `rm`ing text files! :smile:)


yes agreed.


@xavriley it works on a pi. I think @rbnpi is using his hand rolled Mac version and hasn't bundled the extra scsynth ugens. The mdapiano ugen isn't part of the standard ugen set.


@seanabu Great! The particular example you give for `xargs` can be achieved with just `cat`, but the concept is good! Please be sure to set up your GitHub account with a picture and everything as well. Thanks!


The only values a bush kit can have is 0, 1, 2, 3, or 4. Doesn't that always make the `<or>` true, and thereby useless?


missing coma


:)

No problem. Someone can learn from it.


Same thing with the `<or>` here :smile:


@trishaandrews Great! HTML is valid markdown, but I generally avoid putting in things like `<br>` if I can avoid it. You could make a list instead, for example. Be sure to set up your GitHub account with a picture and everything as well. Thanks!


По поводу базы.
Хочется ее сделать более универсальной (ну вдруг структур будет все-таки много).

Основной посыл состоит в том, что нужно избежать того, чтобы в базу попадали одинаковые структуры, но под разными именами. То есть, видимо, нужно искать по базе - есть ли уже такая нуклеотидная последовательность или нет. Есть ли смысл на это поле ограничение primary key?
И еще одна проблема есть - на концах структур обычно есть свободные нуклеотиды. То есть может получиться, что вот такая структура ....().... кем-то записана как .()., потому что кто-то счет концевые нуклеотиды не сильно важными.
У меня пока только одна идея - брать структуру, обрезать ее по первую открывающую скобку и последнюю закрывающую, взять нуклеотидную последовательность по этим позициям и как-то сравнивать ее с тем, что записано в базе


@npatta01 :+1:


pinging @asiekierka for the funky BC fluid stuff


You have an `<and>` here with each property wrapped in a `<not>`. You can replace this construct by taking the `<or>` from 3554, and wrap the `<or>` in a `<not>`. So you get:

```xml
<not>
    <or>
        <property...>
        ...
    </or>
</not>
```


We do anything with the fluid registry!? We do register two fluids, but that's oil and fuel... why it registers as lava is beyond me.


Done


@kevntao Neat! I've never seen `xargs` used quite like that before. Interesting! Be sure to set up your GitHub account with a picture and so on as well. Thanks!


We can't do `module.exports = typeof buf.indexOf === 'function' ? buf.indexOf : shim;` as the method calls are different. I could cache the `typeof buf.indexOf === 'function'` check in a variable, but I'm pretty sure V8 does that already. Feels like premature optimizations anyways, and a doubt it has any gains.


Fixed.


@juleskk Hi! Glad to see this is coming along. Be sure to set up your GitHub account with a picture and so on as well. Thanks!


+1 This commit message is NOT an e-mail address or domain name, it is a Java reference to an annotation called WebContext.


@JEJodesty Good to see this is coming along! :+1:


@edooley7 Great! Be sure to set up your GitHub account with a picture and so on as well. Thanks!


komento


if this is easily solved we should change it at some point as i'm sure other will make the same mistake.


You may want to look inside rafi's hacklib which does the memory reading (https://bitbucket.org/rafzi/hacklib_gw2, https://bitbucket.org/rafzi/hacklib). If the memory areas don't change too often you can simply poll these values. Alternatively you may be able to change the code which writes to the memory area you want to observe to notifiy your own code (I know that cheat engine can look for instructions that access or write to a certain address). Of course this is not trivial.


@ipa-fxm
you could try:
target_link_libraries(augmented_solver constraint_solvers ${orocos_kdl_LIBRARIES} Eigen)


@emschuch Great! :+1:


@derekjanni Great! Be sure to set up your GitHub account with a picture and so on as well. Thanks!


Thank you for sharing this API. You saved my ass from big trouble man! Millions of thank you!


@cgerson Nice! Be sure to set up your GitHub account with a picture and so on as well. Thanks!


@codeLaw Nice! :panda_face: Be sure to set up your GitHub account with a picture and so on as well. Thanks!


This change sucks.


@alisoncossette :+1:


for the one ARJ archive, unar actually works, but as this is a multi-part archive, the semantics of the two tools are a bit different; implementing alternative UNAR support would be a bit tricky (like it was to get unarj to work in the first place)

Well:

https://qa.debian.org/popcon-graph.php?packages=arj+unar&show_installed=on&want_legend=on&want_ticks=on&from_date=&to_date=&hlght_date=&date_fmt=%25Y-%25m&beenhere=1

```
tchet@antec:/tmp$ unzip /var/www/desc14sw.exe
Archive:  /var/www/desc14sw.exe
  inflating: INSTALL.EXE
  inflating: DESCENT1.SOW
  inflating: DESCENT2.SOW
tchet@antec:/tmp$ unar DESCENT1.SOW
DESCENT1.SOW: ARJ
  4GWBIND.EXE  (45551 B)... OK.
  DESCENT2.ADV  (1347 B)... OK.
  DESCENT.PHX  (2079 B)... OK.
  DESCENT.B50  (1563 B)... OK.
  DESCENT.M50  (1006 B)... OK.
  DESCENT.HOG  (2339773 B)... OK.
  DESCENTG.INI  (2824 B)... OK.
  HMIDET.386  (17134 B)... OK.
  HMIDRV.386  (116455 B)... OK.
  HMIMDRV.386  (111876 B)... OK.
  SETUP.UBN  (223761 B)... OK.
  ORDERFRM.TXT  (2077 B)... OK.
  REFCARD.TXT  (2991 B)... OK.
  README.TXT  (53079 B)... OK.
  DESCENT.BAT  (163 B)... OK.
  DESCENT.PIG  (1416672 B)... OK.
Successfully extracted to "DESCENT1".
tchet@antec:/tmp$ unar DESCENT2.SOW
DESCENT2.SOW: ARJ
  DESCENT.PIG  (3676199 B)... OK.
  DESCENT.UBN  (835841 B)... OK.
  4GWPRO.EXE  (242724 B)... OK.
Successfully extracted to "DESCENT2".
tchet@antec:/tmp$ cat DESCENT1/DESCENT.PIG DESCENT2/DESCENT.PIG > DESCENT.PIG
tchet@antec:/tmp$ md5sum DESCENT.PIG
f8dc0f2b3ee8baa2c622f57b470fe147  DESCENT.PIG
```


deals with sequences with no perfectly mached barcode


@darknessomi


Was about to do the same  :)


This bug is really annoying in large (height) grids.


Hmm,

`The following macros are extensions to Common Lisp, where all bindings are lexical unless declared otherwise. These features are likewise obsolete since the introduction of true lexical binding in Emacs 24.1. `

So probably we should use lexical-binding instead or sth. But there are some problems with lexical-binding for emacs `<= 24.3`. @reactormonk , what do you think about it ?

> Sorry if you already know about it.

All feedback, fixes are welcome :)


great !


Indeed.


@KevinEtienne Review?


What is the reasoning behind this?


Открывание страницы лучше сделать отдельным методом в пейджобджекте например
public void open();
И вызывать:
mainPage.open();


Fixing issue #2


The integer branch would be better as signedVB I think in order to support potential future adjustments (and to be shorter on average since most adjustments are 1 byte).

Indents are using tabs and need to be spaces everywhere (turn on visible whitespace if your editor supports it).


Hi @birkenfeld, what was the reason for not uploading this and reverting to “in development” state? Are there any regressions?


Ah, yes. Understandable.


so little code you added


@ajschumacher I don't use the command. :-)

Github img is a logo of a travel project that I started two years ago. :-) Should I change my profile pic?


I've commented on this on StackOverflow: http://stackoverflow.com/a/30895644/21998


Do you mean `... from Down to !Down`? :)


@hvsarma I like seeing pictures of people myself; if you don't have a strong preference I would recommend putting up a nice picture of yourself. :smile:


It might be easier to put this #ifdef inside the function bodies, and remove it from all the places where this function is called. This way, when BLACKBOX isn't defined, this routines will be empty and the optimiser will remove all calls to them, without having to add #ifdefs through the entire file.


if ($pingback->validate()) {


@ajschumacher aye aye!


не надо проверять страницу на нулл. Страница должна в любом случае создаваться и она не должна быть равной нуллу.


Tested on production env for #186


Страница должна в любом случае создаваться и она не должна быть равной нуллу.


ip_half can be a macro.


use PSR-2 https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md as coding style


pi can be a macro like M_PI


It files `testExceptionOnReceive`, but after some thinking I'm finding out that it may be an overkill, and it's enough to test LocalEndPointState in `receive`. The problem here is that after `EndPointClosed` event all calls to `receive` should finish with exception.


oh, how funny!


この文言って大丈夫ですか？


на нулл не хорошо проверять и вообще использовать WebElement на уровне теста.
как показывает практика - если по простому то эти елементы надо оборачивать в методы - например в данном случае loginPage.isEmailAddressPresent();
1. assertTrue("Verify email address field present", loginPage.isEmailAddressPresent());
2. или сделать метод в пейджобджекте вроде verifyEmailAddressPresent() котроый будет содержать ассершн с первого пункта. Это для того чтоб если в другом тесте будет такая же проверка - не дублировать код вместе с еррор меседжом.


@wtnbtkts 大丈夫です〜！


Good catch as always! Fixed now.


Предлагаю drop'ать тенанты в before each и на destroy Account'а. У нас все равно одно без другого существовать не может


The lines under this one seem pretty internal and are covering the usage of the Coverage library. I'm not sure whether they are needed here. You could simply replace this sentence with "This is due to the way Ruby's coverage library works.".

What do you think ?


I did some testing and the stopService function is being called.  So, it must be something with the folder2ram -clean command.


Yep, good catch.


Выходит, требуемая версия php повышается до 5.5


I think there should be no any problems with init in constructor


Thanks! Fixed.

On Mon, Jun 22, 2015 at 12:12 PM, Thomas Gazagnaire <
notifications@github.com> wrote:

> pretty minor, but I think the convention in the compiler is to use
> domain_state.ml or domainstate.ml (ie. no Capital letter in filenames).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stedolan/ocaml/commit/60263b26d96d82d376e299f1905dd9dc3d44c3ae#commitcomment-11791712>
> .
>


Did you contemplate pushing the `data["xxx"].keys.include?(response)` down into a method on the `DataQuery class`? I'm not sure that's the right approach, but I'm just interested.


`pair<int, int>`最好写成`make_pair`


@Malezha Требуемая версия повысилась в момент перехода на Laravel 5.1


you should not implement such checks in constructor, instead create separate method like isPageOpened() - but don't put it into constructor.


I've added this to avoid missing module name in instances view ... cause now we're showing app's name and not classes name ... but of course instances running already before the update, were not changed ... so I've tried to change them in that way ... maybe there is a better place to do this, but without, instances view looks broken in UI ...


А почему бы это в конструкторе прям не сделать?


Should we do this step if deleting any rows fails?


This file should be called `_comment` as this partial renders one comment, not multiple comments.


android requires library names to start with lib


Also removed autofocus code on multid as was causing serial error. however, need to use at least some autofocus - perhaps go straight for the crispm system?!


Seems to cause following error:

`Warning: bind(): You are binding a component method to the component. React does this for you automatically in a high-performance way, so you can safely remove this call. See undefined`


Don't throw an exception. Create method as I've described above and return boolean value.
And decision to fail a test or not would be applied on test case level using assertions.


It is recommended to use a new without upper cases.
In new installation this `base` field is used as template directory name. And there can be functions that assume template directory names has no upper cases in the name.

See also: https://www.dokuwiki.org/devel:templates#template_naming_conventions
(and eventually https://www.dokuwiki.org/devel:template_info)


@frozeman. Please do not alter the code if you don't understand what it does. This line was completely fine, now it's broken.


don't create WebElements in constructor.
It's better to use on class level:
@FindBy(locatorType="value")
private WebElement linkLoginElement;

It would be initialized after first try to interact with element


**NOTE**: if you get an error while testing this that says "unable to find route `/configurations_path`" or something like that, make sure you're using the latest version of `dradis-theme_snowcrash`. Anything earlier than [this commit](https://github.com/dradis/dradis-theme_snowcrash/commit/ce1187441d4bf9d21d9c415e231c87dd3e79bac1) has a broken link in the navbar.


That's weird. I am using unar literally since years for each and every archive file that I get my dirty fingers on and I never had any problems.

I just reported the failure to parse the SODEMO.EXE archive. Unfortunately, it makes no sense to report the master-levels bug, since the data is not publicly available, but judging from the output and error message they are probably related.

Unpacking the multi-part ARJ archive looks a bit awkward, though, but at least it works. Does it make a difference if you rename the files to .ARJ and .A01 before?


It's a bad practice to return WebElement from page object and use it on Test case level. It's better to implement actions you need to do with element on page object level.


Ваш Loader ориентируется исключительно на зарегистрированные в $prefixes namespaces, а как насчёт автозагрузки?
Не пробовали превратить $classname в путь к файлу автоматически?
Например:
класс *\Response\RedirectResponse* я мог бы искать сразу в ***/framework/Response/RedirectResponse.php*** ...


/fyi Submitted #3391.


C'est vrai que c'est mieux que ce soit dans l'application, je modifie.


If the fdrv sfs is distributed as part of the iso, what are we saving?
Some memory when the zdrv is copied into memory.
Could save more memory, by putting all firmware in zdrv and leaving it on disk.
If the fdrv sfs is separately downloaded, then why not load it as an ordinary extra sfs.


Здесь можно написать просто
```ruby
role
```
вместо
```ruby
association :role
```
так как имена совпадает.
А вообще строчку пока можно убрать, так как тесты и без нее проходят, а время прохождения тестов увеличивается


$this->dispatch(new RequestProjectCheckUrl([$url])); // FIXME: Should this be a model event?


require и require_once - чем отличаются и какой лучше использовать?


If an attachment is not deleted from db first, [it won't be deleted from disk](https://github.com/cloudant/CDTDatastore/commit/c75c6714bf131a4ba56ed1d37e74950d8ace0c95#diff-ce77b2812a143c42aa7fdb8b3818581dR205).


Could this Bug-Fix also be merged/ported back to the 2.4-branch?


easy


Will it work with previous versions? What does the version denote here?


This line is what made the jslint break. And how is a single `|` correct?


don't create WebElements in constructor.
It's better to use on class level:
@FindBy


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Don't init elements of another page right here. Put it into LoginPage constructor.


попробуйте использовать
```ruby
have_button
```
Кажется, такой вариант работает


Could be `if CURRENT_VERSION:`


I think this is the wrong place to fix this. If the updatePlugin method of the StateManager is not iterating correctly through the elements, the StateManager should be updated, so we don't need to iterate manually.


an example~~s~~


Could be `if not chkit:`


Yes I was trying it on a Mac, and have not added any extra ugens.


@wei2912 are you sure? 3 exercises seems a bit excessive and time-consuming.


Currently it's hardcoded - but in future we will place it in config files.


I am pretty sure this causes #16, although of course, the "rm -rf /tmp/verifier" needs to be changed.


Interesting :+1:


Thanks!


Agree - will test with that


Может ли у нас быть пользователь без роли? Если нет, то нужны тесты, которые проверяют валидацию на уровне модели и на уровне базы.


I mean #6 -.-


Please provide a demo.


hi


The preceding block makes this less likely - Openshift uses "type/api" which becomes "deployapi" which is a lot clearer than api10, api11, etc.  in the future that might just be an input (define short names for packages up front an error if there is a conflict)


Должно ли быть название account'а уникальным? Если да, то нужен тест


I had a customization that I removed (was trying to make a default package behave a certain way).  Will remove


I'd be inclined to put this commit straight into master as it appears to be unrelated to the changes in this PR.


nedir?


test


We are still using it for private type aliases in a separate scenario.


Yes - I completely agree. I like the approach that you chose (deployapi is much better than api10).
What I was just saying that assuming that we have that (e.g. deployapi), I think that we will never reach this is a practical case. But I'm completely fine with leaving as is.


$this->dispatch(new RequestProjectCheckUrl([$url])); // FIXME: Should this be a model event?


Bother, it looks like I missed this (and the previous ```accept()```) - we don't need to declare them here as they are _inherited_ :confused: (?) from ```QDialog``` and we don't want/meed to *override* (?) either of them in our classes.  _Hey, maybe I **am** getting the hang of this OOD stuff!_ :fireworks:


> It does seem to cause a new assert to fire, though.

We don't know yet whether the assert is caused by this commit.


Missing part - define end dates for market data extraction


[docs](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Bitwise_Operators).

**TL;DR**
```javascript
var number = number | 0;

// is equal to

var number = Math.floor(number);
```


Badly indented line.


Translations?


Thank for explaining. How exactly do you use Coveralls apart stuffs done by Scrutinizer?


Not here because of your work, but... typo: `Mongiod`


@ehartmann bad indentation?


Yes, should be.

And there cannot be boot failures as device will not use OC frequencies during boot (there is another commit for that, setting max frequency for boot process).

Why 25mV - empiric testing.

Andi


Does not seem to work

C:/temp/instiki-master/vendor/plugins/bundler/gems/bundler-1.5.1/lib/bundler/dsl
.rb:232:in `block in _normalize_options': `ruby_22` is not a valid platform. The
 available options are: [:ruby, :ruby_18, :ruby_19, :ruby_20, :ruby_21, :mri, :m
ri_18, :mri_19, :mri_20, :mri_21, :rbx, :jruby, :jruby_18, :jruby_19, :mswin, :m
ingw, :mingw_18, :mingw_19, :mingw_20, :mingw_21, :x64_mingw, :x64_mingw_20, :x6
4_mingw_21] (Bundler::GemfileError)


Use `fail` instead of `raise` to signal exceptions.


Yes, pkrel up is needed for additions like these.  But I don't see it an updated pkrel in this or the previous commit.


Assignment Branch Condition size for to_yaml is too high. [16.03/15]


Assignment Branch Condition size for groups is too high. [19.1/15]


Doc comment for the $debug argument


ok cool, i never pushed bits in js before :P

but why did jslint fail then if its basic operator?


Optional (IMO), but a bool-cast might be a more "Spoon/Forky" way to go ;-)


Is this method necessary? It just calls parent :)


I think it would be clearer to split this commit into multiple commits, probably corresponding to the four bullet points in the commit note.


`self.sack`, please ;)


Yes, I allow up to 1600 mA for USB as many wall chargers are identifying themselves as usb devices wrongly.

It shall be safe as the charging logic will not use it when the current is not stable enough. So it should reduce the charge current automatically.

Also, good USB ports are safe against it.

Of course there is always a certain rest risk, so the user should also be a little bit knowing what he does.

Andi


Ooops missed that.


No, it's not necessary it just looked better to me. Also I was trying to avoid loading the servicemodel dll when not needed. But i'm not sure this is enough to do that.


I believe we still need this workaround for gcc.


done


And if it would mean that all our future PRs are failing checks because of this line, i would rather use `Math.floor()` ;)


gcc needs this


You are right... it was too verbose for the project README.
I removed the detail and put a link to my proposal (which describes the limitation in more detail) instead: https://github.com/Genki-S/ttnt/commit/4eabb15b11aab620664b5d35a66b7df9c511aae0
Thank you for catching this!


Shouldn't it also update the embedded.mobileprovision files for extension / app?


Now there are two PIPE_CAP_MAX_SHADER_PATCH_VARYINGS cases... This should have been merged.


Yes, if I run the app without my changes, the app crashes. I also submitted feedback through Google Play, so you should see it in the Developer Console.

This is in logcat:
06-22 14:20:41.955  19993-20015/? E/AndroidRuntime﹕ FATAL EXCEPTION: AsyncTask #1
    Process: de.Ox539.kitcard.reader, PID: 19993
    java.lang.RuntimeException: An error occured while executing doInBackground()
            at android.os.AsyncTask$3.done(AsyncTask.java:300)
            at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
            at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
            at java.util.concurrent.FutureTask.run(FutureTask.java:242)
            at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at java.lang.Thread.run(Thread.java:818)
     Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'short android.os.Bundle.getShort(java.lang.String)' on a null object reference
            at android.nfc.tech.NfcA.<init>(NfcA.java:92)
            at android.nfc.tech.NfcA.get(NfcA.java:78)
            at android.nfc.tech.MifareClassic.<init>(MifareClassic.java:166)
            at android.nfc.tech.MifareClassic.get(MifareClassic.java:156)
            at de.Ox539.kitcard.reader.ReadCardTask.doInBackground(ReadCardTask.java:46)
            at de.Ox539.kitcard.reader.ReadCardTask.doInBackground(ReadCardTask.java:1)
            at android.os.AsyncTask$2.call(AsyncTask.java:288)
            at java.util.concurrent.FutureTask.run(FutureTask.java:237)
            at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
            at java.lang.Thread.run(Thread.java:818)
06-22 14:20:42.026     787-2066/? E/ActivityManager﹕ App crashed! Process: de.Ox539.kitcard.reader

I have a HTC One M7 with this software:
Android 5.0.2
ROM 7.19.401.2
HTC SDK API level 6.55
Build number 7.19.401.2 CL482424 release-keys


Isn't it overkill to fill backendproperties with information for all backends on every call to UpdateBackendCache and then actually to use only the information for one backend? Remember, in GetBackendProperties a call to every addon's GetDriveSpace function is involved. The latter might be quite expensive (disk access, no caching posisble if accurate data shall be delivered, ...). The old code only retrieves data for the active client.


by default lint has [disabled bitwise operators](http://jshint.com/docs/options/)

> This option prohibits the use of bitwise operators such as ^ (XOR), | (OR) and others. Bitwise operators are very rare in JavaScript programs and quite often & is simply a mistyped &&.

Although in our config they are [on](https://github.com/ethereum/web3.js/blob/master/.jshintrc#L3). You probably run lint with different config on our code. I'm fine with replacing it with `Math.floor()` if it will make it more readable :)


http://php.net/manual/en/function.preg-match.php said: Use the === operator for testing the return value of this function.


This is nit a StateTest, please move the test to test/libdevcore


Does "$RCSTOP -eq 2 or 3" need special treatment as well?


thanks:)


Could reuse existing keystone cert related defaults?  https://github.com/stackforge/os-ansible-deployment/blob/master/playbooks/roles/os_keystone/defaults/main.yml#L116-L121

Having ssl keys outside the keystone_idp var will also mean ssl certs can be generated on the sp keystone without needing to define (and therefore enable) keystone_idp.


Hallo SirBenII
Mal ne (eventuell dumme) Frage: gibt es in deinem Programm keine main.c-Datei? Ich bin an der ExternControl Funktion des mk's interessiert und im mk-Forum wird öfters auf diesen Code verwiesen ;-)

Danke und Gruss
Peter


`self.` is not necessary in both cases here.


`| 0` is a well-known type conversion in javascript. I would not say that Math.floor makes it more readable (you have to know what it does to strings in the same way you have to know what | does to them). Furthermore, `Math` can be reassigned, the semantics of `|` cannot be changed.


Also needs to check order of separate subtitles, like 1, 2, 3 ...


I'm guessing that the changes to the regression test checksums in this commit don't only relate to the other changes in this commit, so I think it would be clearer to have them in a separate commit.


You should use a `transaction` block here.


@lakshmi-kannan I believe that's the right thing to do - can you please double check and verify it?

On a related note, we don't have a consistent (naming) pattern for methods which retrieve objects from a database - some of them throw and some of them don't and that's why things like the one above happen.

```
Traceback (most recent call last):
  File "/data/stanley/st2actions/st2actions/notifier.py", line 76, in _get_execution_id
    return str(execution.id)
AttributeError: 'NoneType' object has no attribute 'id'
2015-06-22 01:29:09,966 ERROR [-] Execution object corresponding to LiveAction 5587a7c80640fd0ee03313a5 not found.
Traceback (most recent call last):
  File "/data/stanley/st2actions/st2actions/notifier.py", line 76, in _get_execution_id
    return str(execution.id)
AttributeError: 'NoneType' object has no attribute 'id'
```


Use `DIRECTORY_SEPARATOR` directly.


@YuryBT - You should actually use the .set() method directly on propSaver, rather than adjusting the properties value directly.  Otherwise the value will not be reset when the test completes.  So just set it to 1 at the start of your test and don't worry about resetting.
Sorry, I should have caught this with the earlier commit.


Ditto. Change all references from `DS` to `DIRECTORY_SEPARATOR`, no need for this definition.


Another "on a related note" - `test_notifier` test is broken by itself (it fails when running it standalone), but I have a fix for that in the other PR (Policy.query is not mocked so it fails).


True, isn't necessary ;) I forgot delete.


Actually this property also defined in ancestor.


Actually the text is misleading. As I have gathered now the "invocation" error comes up anyway if one of the tests fails.

But this has another benefit: This way tox is compatible to windows and linux. Nothing much, but still ;)


Too bad that partial application in C# is so hard. With F# we wouldn't need this kind of boilerplate code.


yeah, this helps. still need to look at gfGenerate to make sure it's not doing anything nasty, but everything else is obviously safe.


Where's is the duplicate?  Is it because AP_HAL includes them? I'm much more in favor of a "include what you use" approach since it tends to have less breakages when headers change.


Do you need to create a new document that is equal to `document_a` in order to delete it from the manual?
If you can't send `document_a` itself, I think that renaming `document_with_id_a` to something like `document_to_remove` could make it a bit more easy to understand to someone that is reading the code for the first time (me).


Shouldn't this be ElementDisplayingContext? Doesn't appear to build as ElementDisplayContext in a new pull.


ha yes, i already did that
forget to pull again? xD


Looks good. You could add the `LICENSE` file and the classifiers in `setup.py`


Need to have multiple events for legacy apps. [see stackoverflow](http://stackoverflow.com/questions/1483657/performing-a-double-click-using-cgeventcreatemouseevent?answertab=votes#tab-top)


Needs a "creates: " condition to prevent failure on subsequent runs.


In your locale branch, is there anything else but [changing queue size](https://github.com/apsdehal/intern/commit/8dce176da179260e1c8abd65f1bca9b291b718dd)? Can we get intern to accept that value as a parameter, and have Globalize to configure it, and get that landed upstream?


I believe the author disabled the app account attached to those tokens.


Congrats on commit #3000


actually no, because we need to decide on a unit. Either minutes or hours (currently it is hours), and then we need to decide which type (currently fixnum), because your approach with `0.5` hours wouldn't work with fixnum. Basically just say which way you want to go and i'll set it up.


Mischien nog handig om te controleren of de grootte van deze vectoren overeenkomen en een foutmelding geven als dat niet zo is? Of defaulten naar 1,1,1


Who guarantees the order of the client data obtained from GetBackendProperties between different calls, alas ensures <code>++</code> actually will point to the successor of the current active client? IIRC, the root cause of the trac ticket is changing number of clients between the calls to UpdateBackendCache.

This problem exists also with the current code. Thus, no regression, but also no improvement here.


Looks good


love it!


What platform do you see this issue on?  On Arch Linux I don't have any issues with MARK_DIRS and the applications source.


@mikepetersonccv Not sure what is trying to be accomplished here, but the AliasPersonId field stores the original person id that the person alias record pointed to when it was first created, and it would be common for that person id to no longer exist after that person is merged ( and the personalias' personid field is updated to point to new person id ). Trying to delete all of those record would result in foreign key constraint exceptions due to all the places those person alias ids are used.


а как сделать валидацию на уровне схемы? Использовать gem schema_validations?


The "savings" is memory usage I guess.
Would be nice to be on the ISO in case your network  hardware is not recognized.
Can still be a separate download, then remaster the iso and boot from it.


First commit failed to contain message - this commit involved editing of the beam properties within such that the correct beam properties would be viewed in a new window when the 'view' button clicked


that's what you get for Ctrl-C.


The tableview was needed to determine cell look at one point but isn't needed anymore, so yes it does not need to be a parameter to enter.

But as for self.tableView, this is a tableviewcontroller and from what I've seen in examples that is normally how the tableview is accessed.
` FilterViewController : UITableViewController<MHCollapibleViewManagerDelegate>`


@an0n981 can you please test this?

http://www.faircode.eu/BPT2-v0.41t.apk

I am considering to make this a paid feature, since Tasker is a paid product as well (I don't want to sponsor a paid product for free).


not tested much, is only a base code to test better filters, i will try more when i have more free time. as you say in your other code the patern and weights should depend on the fraction.


Hi Christophe,

I realized, that you made some progress in order to implement Levensthein distance into the checking routine by using iconv with TRANSLIT paradigm. This seems to me a great idea, however this will only work for lamguages basing on latin letters and will fail completely for any other language (Chinese, Japanese, Korean, Arab - for sure also for Russian and Greek as well...)

Therefore I suggest to couple this feature onto the language used (EN, FR, ES, IT, DE will work, others should be bypassed).

Also, there will be differneces with the TRANSLIT paradigm for each loclization. For example Göthe (written wrongfully intentionally) will be translated by iconv to "Goethe" in German environments, but to "Gothe" in English ones. This will make a difference by using the (shortest) Levensthein distance procedure: Gtoehe => Goethe will be 2, Gtohe => Gothe only 1 Levensthein step to be counted. Also, for using a relative count (let's say "Levensthein distance per total count of letters") will be different as the total count of letters also differs accordingly to the language environment.

This is slightly combined with ticket "Strict and Tolerant answer checking" https://github.com/e-lang/moodle-mod_elang/issues/59

(Hope, I do not swamp and spam you with those requests... it's not necessarily a feature for the very next versions and I will do my best in order to support you with that as ususal, but I post it all here in order not to forget it and also to discuss this. =)


@pecko - we have "special handling" that means the time display objects have to be in a "DynamicLayer" object.  So, we need to prevent these objects from being moved/pasted into a layer that isn't a DynamicLayer.

We need to do this in code.

We also need to prevent this happening in the XML file.  So, instead of having a layer that has a boolean "MovingLayer" attribute, I think we should declare a DynamicLayer type in XML, extending the Layer object.  Only this object should allow timeDisplay objects within it.


hier ook whitespace


This work for me in CM11, but C12.1 led work bad.

This work well in your device?


This fix may also be added to "auo novatek 1080p cmd" ?
Thanks!


Maybe you can update the read me with information how to configure this in Tasker.

Possible usage case: automatically create a waypoint when a photo has been taken (intent *android.hardware.action.NEW_PICTURE*).


You only updated the hash, not the url?


@igorastds this was just fixed in: http://golang.org/cl/11310

Please note that we do not use GitHub's code review system, so comments you make here will probably not be seen. (I saw this one by accident.) If you would like to comment on a CL, please use gerrit.


You're right. This isn't very clear at all. I'll have a think.


Then I prefer minutes as fixnum.


:D belli oluyor zaten


Тоже так думал сделать. Но в кострукторе MainPage я инициализирую контролы страницы. А теперь смотри, я пытаюсь достучаться к контролам перед тем как страница будет отображена, exception мне гарантирован. Теперь вопрос, куда выносить инициализацию элементов странички, сделать отдельный метод?


No


I will move this comment to issue and implement it soon.


Hallo Peter,

schau mal hier:
http://svn.mikrokopter.de/websvn/listing.php?repname=Projects <http://svn.mikrokopter.de/websvn/listing.php?repname=Projects> -> RaspberryPi

Der entsprechende Wiki Artikel befindet sich hier: http://wiki.mikrokopter.de/PiMote <http://wiki.mikrokopter.de/PiMote>

Die Github Dateien sind nicht mehr aktuell.

Gruß, Ben

> Am Jun 22, 2015 um 2:27 PM schrieb rideyourstyle <notifications@github.com>:
>
> Hallo SirBenII
> Mal ne (eventuell dumme) Frage: gibt es in deinem Programm keine main.c-Datei? Ich bin an der ExternControl Funktion des mk's interessiert und im mk-Forum wird öfters auf diesen Code verwiesen ;-)
>
> Danke und Gruss
> Peter
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/SirBenII/PiMote/commit/b1e36e2a9027c417052b94e1caf26e659f2ab68f#commitcomment-11792846>.
>


the sencha api doesn't list this method, just [`setValue(newValue)`](http://docs.sencha.com/extjs/5.1/5.1.0-apidocs/#!/api/Ext.form.field.ComboBox-method-setValue)


Посмотри коммит со страницей. Я там написал как можно создавать/инитить елементы.


Thanks a lot


What if only that value is set and the `protocolHeader` or `remoteIpHeader` isn't? Is that a valid use case? (I asked because I worked on that issue over the week-end and thought I would ask before committing :)


DateTimeDimensioner?


is ```ShortCode``` necessary?


dimensioner?


I'd rather avoid unnecessary changes. If it was absolutely necessary it would be better to rename this file and preserve the `git history`.


Are these test binaries generic test utilities? If they are specific to security, we could add them here.

If not, can they be replaced with available tools, like socat? tcp_server and tcp_client sound like they do things that socat covers.


Thanks, yea this line of codes doesn't have any tests, adding them now.  Will have a fix in an hour or so.


I'd prefer this version:
```rb
JawboneInit.perform_async(@jawbone_profile.id)
```


Should these additions be versioned?


this.setValue is a method of LayerList, not the combobox?


Other ports use `nic.isconnected()`, any change `status()` can be renamed?


I don't think this belongs in code. Link is dead now anyways.


Hence the "fix up merge fail" commit later on.
On Jun 22, 2015 8:25 AM, "Christoph Haag" <notifications@github.com> wrote:

> Now there are two PIPE_CAP_MAX_SHADER_PATCH_VARYINGS cases... This should
> have been merged.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/imirkin/mesa/commit/f1bc930e3a5be038e5f49a50cba940c4cbe90fb0#commitcomment-11792818>
> .
>


so... did you add this back in on purpose?


method setRtcPowerUp(AlarmActivity,boolean)
not found in class AlarmStateManager


Sweeet


There's no need to always be verbose. If you want to use `--verbose` use `npm test -- --verbose`. I think you should revert this.


@geertplaisier I think I have a fix, checking now

```javascript
   setValue: function (appLayer, preventEvent) {
        if (preventEvent) {
            this.combobox.select(appLayer);
        } else {
            this.combobox.setValue(appLayer, preventEvent);
        }
    },
```


Thanks for this, have added in core.


If it is converting from old to new format, this is the right place, but make it clear, please.

Do new modules work as expected? Who know do it? SH UI? or backend?


Either rescue from a specific error or log the error/print it to STDOUT at least. Otherwise this kind of thing leads to bugs that are very hard to track down.


Now also in core (will be 2.0) :)


The missing payload case is not documented


Let me give you the actual velocities of the weapons (in game units):

* PAC: 2359264
* ION: 1834976
* RTL: 4456423
* MAM, SAD, SWT: 524288 to 4194304

The speedup of missiles seems to be linear. It takes exactly one second to reach max velocity.


This is already implemented in the `react-native` branch. Since you didn't add any test I guess we should merge what we already have:https://github.com/podio/podio-js/blob/react-native/lib/auth.js#L113


Looks good, should then probably be
```js
   setValue: function (appLayer, preventEvent) {
        if (preventEvent) {
            this.combobox.select(appLayer);
        } else {
            this.combobox.setValue(appLayer);
        }
    },
```


They are specific to security, not really general, but necessary for testing smack over sockets. I do not think that we can use socat for that - as far as I know, socat cannot set smack labels per socket. Please check the PR with the added binaries, they might provide more insight.


Review complete, one minor comment regarding versioning


Just checking to make sure it isn't a mistake, vows is no longer a dependency?


This could be eagerly instantiated here to reduce memory usage a teensy bit


> I don't think this belongs in code. Link is dead now anyways.

Oh no! OK, I remove the comment ...


This is strictly limited to Mac OS X (Darwin). Since applications are found both using `mdfind` and a glob over /Applications/*, duplicates are inserted since the applications found using `mdfind` don't have a trailing slash (on OS X, applications are actually directories).


Cleaned up the Code. Thanks ! :+1:


My app breaks on IE7 & 8 when I try to unbind events by calling the `.off()` method. This PR fixes this for those browsers.

It's also in a function called `destroyTarget()` and the comment above the function is `// Destroy the slider and unbind all events.`.


Oh no! OK, I remove the comment ...


Maybe `.subscribe(asyncResponse::resume, ApiUtils::serverError)` would be enough, the specific error message does not convey more information to the user


You need a different ns.


What it's supposed to test is that `ManualWithDocuments#remove_document` doesn't depend on the `document` you pass it being the exact same instance that's in the collection `ManualWithDocuments#documents`.

The name `document_with_id_a` is supposed to illustrate that `#remove_document` uses the `id` attribute to compare the `document` you pass to it with its own `documents`.

Maybe this is overly complex because `#remove_document` should take a `document_id` argument instead?


Why do you need beforeEach here?


done: https://github.com/combak/ShatteredWorld/commit/be57118eb0d10258e7b3516140c091adacb418c1


Testing


You have to set those properties to enable the valve. See https://github.com/spring-projects/spring-boot/issues/1624.


This broke compilation on msvc2005


Add newline at end of file


I am going to merge it, but I'm curious why /2


Sure, I was just trying to stabilise a few things in order to have Platboard depend on an NPM hosted version of the SDK, instead of a commit on GitHub. I didn't know about the react-native branch, so if that's the latest code, and if it is stable, then i think we should merge and publish.
I will revert my last 2 commits.


done: https://github.com/combak/ShatteredWorld/commit/aa19cbcc80178808df46651fe353c95b2bfe05fc


I'm glad to hear you like it.

I concatenate strings so the code is cleaner, I like it more that way, and it has nothing to do with some odd behavior.

You can see that it's clearer this way:

```
 worker.port.emit("alert", "CurrentSong error: 'Folder' option is not set.\n\n" +
                             "Go to the Add-ons Manager, find CurrentSong in the extensions list,\n" +
                             "click the Preferences button and set the 'Folder' option.");
```

```
 worker.port.emit("alert", "CurrentSong error: 'Folder' option is not set.\n\nGo to the Add-ons Manager, find CurrentSong in the extensions list,\nclick the Preferences button and set the 'Folder' option.");
```

Thank you for using CurrentSong, consider leaving a rating on the [OBS page](https://obsproject.com/forum/resources/currentsong.182/) and/or on [Mozilla Add-ons](https://addons.mozilla.org/en-US/firefox/addon/currentsong/). If you have any other issue or suggestion feel free to contact me :+1:


Huh. Git must have done something weird when I merged your branch: https://github.com/ChristophHaag/mesa-mesa/commit/a476cf5df36057403b69e45c5b5bf034d963bb6c#diff-4972bfd46c5e4788b447fe725d5d6e38R302
Your fix up commit is included, but the merge somehow non-interactively must have removed the fix for some reason. Perhaps git rerere was involved?
Sorry to bother you then.


그냥 간단하게 다음 버전까진 아래 방법으로 사용해 주세요.
모바일 [사용자 정의 CSS] 에 아래 코드을 적기.
* **.lt > li .auth .vtt {position:static}**


@pbathia this service should probably be inside a new mock "mockUdsService.js" going by structure. It would also ensure clear demarcation between strata and UDS mocks.


status() is a bit more full-featured than isconnected() since it returns information about the cause of a failure. Perhaps we should add isconnected() to maintain parity?


I wouldn't call this method `getHeaders`, or at least: not if you're setting the headers on the given `outputMessage` as is done on line 200. Perhaps call it `addDefaultHeaders` and make it return void?

Also: it's a protected method, so it should probably get some Javadoc.


hhhhh


aasd


update of test.txt file


Hi, I've just taken this patch and added to haxe-ga. It's already on haxe-lib (haxe-ga version 0.5.0), so now haxe-ga it's compatible with both (openfl-legacy and openfl-next). Thanks!


Maybe `#remove_document` could be `#remove_document_by_id` and take `document_id` as argument?


Same commit in both branches, I figured it'd be fine, but it ends up with
silent merge fail. Look at the second to last two commits, should be
obvious why.
On Jun 22, 2015 9:01 AM, "Christoph Haag" <notifications@github.com> wrote:

> Huh. Git must have done something weird when I merged your branch:
> ChristophHaag/mesa-mesa@a476cf5#diff-4972bfd46c5e4788b447fe725d5d6e38R302
> <https://github.com/ChristophHaag/mesa-mesa/commit/a476cf5df36057403b69e45c5b5bf034d963bb6c#diff-4972bfd46c5e4788b447fe725d5d6e38R302>
> Your fix up commit is included, but the merge somehow non-interactively
> must have removed the fix for some reason. Perhaps git rerere was involved?
> Sorry to bother you then.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/imirkin/mesa/commit/f1bc930e3a5be038e5f49a50cba940c4cbe90fb0#commitcomment-11793411>
> .
>


TeamCity Xbim :: XbimGeometry :: XbimGeometry [Build 4](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=13&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 03:19:36


needed because build/cmake now contains other files then CMakeLists.txt


Yes, for *some* implementations, outermost closes innermost (though you use the antique  source level 1.5, so I'd check each case to make sure). Except (and this is true even after 1.6) that an exception during the flush of one of the outer streams will leave any stream constructed by the nested calls inside it open.


Eigen is template-only (?), at least the CMake module does not export any lib.
I guess there is still a header missing.


This was probably not specific enough in the issue description. The key-value meta data must be build on top of the case file and document objects (= not part of the "core" SDK). We are referring to it as a "helper" extension internally. So essentially adding this functionality shouldn't touch CaseFile.cs and Document.cs


the cmake-testbuild script builds and installs into ./out


Thank you very much @mbeijen !!!


We already have such kind of `static_assert` tests inside the `*.h` files, where the corresponding functions are defined. If we started doing this way, maybe move these asserts to `ss.h`?


Why not reversing the list here to avoid iterating through it in reverse order each time afterward ? easily done using : http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/collect/Lists.html#reverse(java.util.List)


yes. we don't support that any more.


uuuh Those lines should not be commented. This is the constructor for the bukkit serialization.


That makes sense, I made them available so that subclasses could access/override them. I wasn't sure if private to the class could be accessed by a subclass. The functionality might need to be changed by a subclass but I guess that class can just override all the methods then.


done: https://github.com/combak/ShatteredWorld/commit/29fc7a4adc0a787d9e2fea9a6e673454d74b0651


I am not sure I understand why we need to iterate in reverse order if we end up reporting on the method tree anyway ?


Soll aktiviert bleiben.


This CMake script is needed to duplicate an imported library (like `GLEW::glew`) under a different name (`GLEW::GLEW`)
Unfortunately the simple solution `add_library(GLEW:GLEW ALIAS GLEW::glew)` does not work.


Oh okey. My intellij said it was not used in any class. I'll uncommand this


Isn't `@var ClientContextInterface` enough since it's already referred to the variable `$pipeline` set below the phpdoc block? Honest question, my phpdoc-fu is admittedly weak :-)


@jpfr @FlorianPalm @ichrispa hey, this is kinda a problematic commit, since it is not needed for a compatibility with e.g. UaExpert... should we add a precompiler switch ```BARE_BONES``` to keep this size-minimal server? or is it an overkill?


absolutely.


Thanks for the update. Just a thought: IGNORE: 3 might be a useful option? Basically would just say, don't do any inline styling for overflow so i can handle it myself in css.


bkjk100 / bkPATs / atxbk100


The FCCF sets the connection's listener to the real listener in `obtainConnection`. There is a timing problem where the listener is null until that happens, causing the incoming message to be rejected. Setting this suspends the `run()` method (in `getListener()`) until `obtainConnection` has completed.


done: https://github.com/combak/ShatteredWorld/commit/31e80e7b325c60938303ddaffd352985705dc0b5

OreGen bleibt aktiviert.


Since functions are first-class citizens in go, you can define function above and reuse it here.


The idea was to centralize in one place all the process necessary to reset the table. If I create an admin panel for the application, I just have to dispatch the same event in a controller and my table will be reseted. And of course you can play with the listener priority if you want to order which listener has the priority.

But maybe it is a better idea to create a dedicated service for this task and you retrieve it in the container when you need it.

If a service is created, the event can be dispatched inside this service and HIGHSCORES_RESETED can be a good event name


@arildojg , favor colocar os comentários de header do Framework Demoiselle nos arquivos novos, como por exemplo:

https://github.com/arildojg/behave/blob/master/impl/core/src/main/java/br/gov/frameworkdemoiselle/behave/annotation/ElementLocatorType.java


executeForEachPod?


:+1: Indeed, the PR is far from being size-optimized (which, at the end, is the only target alongside modularity). So thanks for the suggestion, I'll implement it ASAP!


Looks good.


Please make this more clear, this boundary definition is very confusing. If I read it correctly, you are over arrays, i.e. you go through exactly two iterations.


But accepting trailing dollar sign means the case `START_STATE` will never be reached.


Actually that is correct behavior. identifiers.org URIs are not meant to resolve directly. See the identifiers.org documentation here: http://identifiers.org/documentation . If you want to retrieve metadata or the original document, use http://info.identifiers.org/doi/...


@ryancarlson  Setting the identifiers here wouldn't be able to be done in the method like this because it would make every entity with "label" as the name. I guess it could be added to the parameters and then the developer could toss the string of the single/plural of the entity. It's just tricky because the title doesn't equal an entity name, so Surveys versus survey (caps versus not)


I tried to import it client side but was unable to get it to load. This is
probably more my noobiness showing than anything else.
https://www.dropbox.com/s/m9v04dpnmss2asz/Screenshot%202015-06-22%2008.57.22.png?dl=0

I had googled for using socket.io with webpack and didn't see any immediate
solutions to the issue I'm having in the image. I'll keep cracking on it.
Any hints in the meantime?

On Mon, Jun 22, 2015 at 2:33 AM Daniel Steigerwald <notifications@github.com>
wrote:

> I believe socket io should be imported instead.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/terakilobyte/esterethinksocketchat/commit/cb56c8a0547da623188b58934b86429875ec3e3c#commitcomment-11787800>
> .
>


How about having a map of yaml files? As for now it's (at least for me) hard to track which variables point to yaml files and which don't.


Try replacing the regular jquery with this one and check if things still seem to work. Fixing bugs to work with newer library versions is an OK approach.


I’m seeing `14.1.4`.
![image](https://cloud.githubusercontent.com/assets/1699443/8282507/39028ede-18e9-11e5-9d35-8c315caca3ab.png)


Please address this comment.


It was for testing the DQL syntax.


No problem. Just drop me a mail if we need to talk about that. We can have a hangout. You can't remove pages in translatewiki.net, but if you let me know of major rework in the app that touches i18n/L10n, I can help. I'll make changes related to the above now.


Yep Sanyam normally we do must've been a mistake
Sorry
@Meninblack007


Seconding @kevin-brown, yup.


@ryancarlson This makes a lot of sense and makes it even easier as there wouldn't need to be a filter object. The filterviewcontroller could just pass the information off in its method. The subclass could be oblivious to the real structure. Thanks! I will rework it to include the identifiers or figure out how to make that make sense.


`Bricks` part of the name looks a bit redundant here.


imo, the commit message and NEWS should describe better the aim of the commit, ie: handle cleanups with (_)setUp errors.


Is there a reason you added in an extra `vsc.SetDefault(mob)` row?


Maybe we shouldn't worry too much about `equals` and `hashCode`. This TO is only used to populate lists of data when posting/fetching data points. How about removing them, simply?


s/intao/into/


Glad to hear you figured it out. When I have the time, I will add better response checking for handling unusual or incomplete responses such as with this.


See comment in `CounterDataPoint`.


done: https://github.com/combak/ShatteredWorld/commit/bcbf7029d0369a02aeacd20572e87d8b7539aacb

Ich habe es erst einmal übernommen ggf im Rezept Stone und/oder Iron durch etwas "schwereres" ersetzen.


Here we are mutating the list as we are traversing it (conditional .remove if the exception is a RuntimeException: a runtime exception is removed from the list if an issue is raised, to prevent a second issue reporting if Exception is also declared as thrown).

If we use an incrementing index we must prevent the increment of value every time a tree is removed from the list, which result in increased code and logic (either .remove or i++). Using a decrementing index makes the decrement unconditional.

Another approach is to use an iterator with a conditional iterator.remove(), but I don't think it would result in a simpler implementation. Anyway we can change the implementation if you feel either solution is easier to understand.


My bad


That's very strange. I'm seeing 14.1.3, released June 19th. The link goes to idea-IU14.1.4.dmg, but the file I downloaded from the link in IntelliJ earlier was 14.1.3…

![screen shot 2015-06-22 at 14 20 05](https://cloud.githubusercontent.com/assets/472830/8282628/00a2b2fc-18ea-11e5-8214-f2f0fea6fc85.png)

Do you know anyone who works at JetBrains? Don't really want to randomly highlight people, but looks like it's a bug on their website.


Replace slideshow.php with new slideshow based on Bootstrap carousel


It would be good to avoid !important if possible.   It is also good to not over-qualify css selectors.  If these could be reduced to the following, it would be good.

```
.rooms-three-month-calendar .event-start,
.rooms-three-month-calendar .event-end {
   border-width: 10px;
}
.rooms-three-month-calendar .event-start {
   bottom: -10px;
}


I think, with a modern compiler, you don't need to do such things. It will compute log(2.0) at compile time and replace the result in the compiled code.


fixed


Imho we should keep the preprocessor switches at a minimum.
Can we just mark the "absolute minimum" part of ua_server.c with comments?

We could have a docu or wiki-page with ideas for further size reduction.


More details would probably be good; however, what I have done is consistent with what currently do in the ```onError``` callbacks for fetching gauge and availability data. Better error handling is needed, but I think it is a separate concern.


Explicit `equals` and matching `hashCode` are always a good idea for DTOs, as you will never know where they end up.


done: https://github.com/combak/ShatteredWorld/commit/9590702c932c29d3c12a90d6423e7bbf8bed8bbd


Hi,

Maybe I'm missing something, but what is the reason for this change?

Cheers
Mike


if this is still a PR please remove the @'s in the commits to avoid spam


This is the special case I mentioned. `n.teardown` exists only after `n` has been initialized. But here too it can be fixed, I can just do `n.proc = ...` after initialization.


@dbolkensteyn : exact, I'll fix this for the next version.


Try Ctrl+clicking the reload button in your browser, to get rid of the cache, to see if it fix it. Kind of like [turning it off and on again](https://www.youtube.com/watch?v=kb2gzteVNa4).


We absolutely want them. These classes are used in collections. Behavior could easily break if we remove them.


Great :)


Thanks, Walker! I'll merge this, but I have had issues with that approach before. Maybe "if extent.text else ''" will take care of that though.


@akhilnarang I Don't Want Cruz ;)


Coool. :+1:


Mildly ashamed of myself, but could have sworn I already tried that. Fixed it!


why?


Hi humans!
This file is written so that noone besides me understands the whole concept.
--== ASD ==--


Please use bonecard.js and bonecard.css to keep things simple. For display, those should be all you need. If the others are needed for some reason, then use those files to include them. The point being is that it should be really easy for anyone to create a page for a bonecard and they shouldn't need to include a lot of files to get there.

I believe there needs to be an example of using a gistid for a bonecard, so I'm not good with eliminating that example. If you need a static example, create a second example.


nu stiu daca linia asta afiseaza ceva. Nu pui nicaieri detaliile de pe angajat


I haven't noticed any audio distortion with it but I also kept the values pretty low.

Thanks for the heads up about fech also.


It would be clearer to explicitly say:

  setUp ensures self.cleanUp is called even if self._setUp fails


Published to http://ui.edev.d2l.com/88_aba4f865f55e2595ab7bf74e73cdbe79f616b57d


We just use them in lists. Anyway, keep them if you prefer.


Sorry, all I did was download the latest revision and overwrite the last copy I had in place, I have now rolled back to what I had before.


Nu stiu ce ai facut aici..rezolvarea pe care ai sters-o era buna


hi every one


@geerds: That looks like an automatically generated tarball. Better use fetchzip (or fetchFromGithub) so that it calculates the hash on the unpacked contents instead.


Any chance this can get merged in and a new build pushed out to npm?


Alrighty!


done: https://github.com/combak/ShatteredWorld/commit/c7cacbb4f7dcabec3dcbc29a62492ecedd3f149d


I'm not convinced.  These three usages relied on a list in their old format, but it seems like bulk lookups in general should return iterators.


Hi Sam,

Thanks for noticing this. There was a PT bug filed recently relating to this
<https://www.pivotaltracker.com/story/show/84069882> same issue. I fixed it
by removing this optimization. So, a fix is in the latest code-line

Thanks,

Jonathan

On Fri, Jun 19, 2015 at 1:12 PM, Sam Fentress <notifications@github.com>
wrote:

> I think this change broke the caseIDToIndexMap, although I don't know
> enough about the model to see any visible effect of it.
>
> Currently, if you inspect the caseIDToIndexMap of any collection, every
> index is "NaN."
>
> It looks like this is because the first case that is created has no
> parent, so parentID is undefined, so caseCounts[parentID] is undefined.
>
> Previously, the equality operator was used, and since null == undefined,
> caseCounts[parentID] was assigned 0, and caseCounts[parentID]++ was 1.
>
> Now with the identity operator, caseCounts[parentID] remains undefined and
> caseCounts[parentID]++ is NaN, which is propagated for all future
> caseCounts.
>
> However, as I said, I don't currently see any effect of this.
>
> I am currently implementing the ability to insert a case into an arbitrary
> index of a collection, so I had assumed that it would be important to keep
> this map correct. But if this map being all "NaN" hasn't caused any
> ill-effects, then maybe the whole map isn't needed?
>
> If the map is needed after all, this could be fixed by using SC.none
> instead of === null
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/concord-consortium/codap/commit/7ff9948815c8a4ae256b09cfce38ebedf9474594#commitcomment-11774874>
> .
>


@cordoval I'm really sorry but your name (and mine) is included in the title of one commit of this PR (https://github.com/symfony/symfony-docs/pull/5423). I can't modify this :(  Hopefully this PR will be merged soon.


Looks mostly good at a glance. Do you need to use the base_url variable?

BTW, the name for 'create.js' should probably be something like 'bonecard-create.js' to remain unique over time. I'm not sure if it needs to be outside 'bonecard.js' to make it load faster and isolate the viewing code, but, if so, please try to prefix these scripts with 'bonecard-'.


ok..ai facut aici completarile:D


Should potentially have a DiscussionEvent and a UserReportEvent I think. For example, the DiscussionEvent would allow us to have the discussion as the object and the module in the context.


If you are using 'http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git' as a source,
it contains a fair bit of useless stuff, look in the Makefile to see the beginnings of an attempt at removing this stuff, but more could be done.
An example is the directory 'carl9170fw' which contains only source, the actual blob is in the parent directory.


It should probably be in a different commit, but it seems that 'base_url' is needed here. Also, another totally unrelated item to this particular commit, is 'tutorial.html' the name we want to use to display an active bonecard? It might be fine, but I hope you are paying attention to the choices of URLs and thinking when other people embed them into their websites.


Looks good.


The recipe should be attempt_abandoned and we need to create a new event in the recipe emitter for this I think. Unless abandoned is just a different way to complete a course.


este reduntanta propietatea EndDate avand in vedere ca intotdeauna este StartingDate.AddDays(Duration). Plus ca nu e chiar facuta propietate


In general, I've been trying to use URLs like '/Support/bone101/bonecard/create/', not 'create.html'. The 'html' seems superfluous to me. It would mean creating 'index.html' inside /Support/bone101/bonecard/create/'. My preference is to maintain that style.


I see :)


[Similarly to what I said on the expander](https://github.com/jlowe64/Moodle-Log-Expander/commit/77f5fad72bf58c9060e5a81ad9c73e5306c25ffa) I think there needs to be DiscussionViewed and UserReportViewed events.


I didn't used the zoomed version of the bonecard as I saw it after  I made many changes!
till now there is 4 versions of the bonecard:

1- default version with 'bonecard' class
2- code version
3- bonecard-micro version for viewing it in a list
4- bonecard-preview for my_tutorials page

I do used the last 2 versions on top of the default version, but didn't do it with the bonecard-code accutly! but I think that I can edit that.


ok


It's a shame we have to leave out the newline at the EOF in the partial. Did you consider using `-%>` in the lines which render the partial?


@hannele ok?


If this is on a github page, this might redirect them to something like http://user.github.io, which might not always have valid content. Also, I don't necessarily like 'create.html' and would generally prefer 'bonecard/create/'.


:confused: select still causes a change event with unwanted side effect, using `combobox.setRawValue` fails and using
```
         this.combobox.suspendCheckChange++;
            this.combobox.setValue(appLayer);
            this.combobox.suspendCheckChange--;
```
also has unwanted side effects in editing tools that requires choosing a layer before enabling an action button

I'm reverting this for now.

see also:
 - https://www.sencha.com/forum/showthread.php?232919-ComboBox-suspendEvents-doesn-t-work
 - https://www.sencha.com/forum/showthread.php?282061-Not-able-to-suppress-combobox-change-event


you could use ``$this->isGranted()``


Wenn ich das so übernehme bekomme ich immer ein Stone Slab angeboten egal auf welcher Reihe ich die Steine platziere.


@ryantenney @leelasharma

Is this deliberately set 1.9.x? Why not 2.x?


There is an ambiguity in naming messages in the comments and in the code - do we call `pushed` messages that we try to push, or de facto pushed into the queue (maybe name these ones `accepted`?).


It seems that `npm start` doesn't work on windows.


technically, your form types are requiring 2.7+ as they use only the new ``configureOptions`` method and the forward compatibility layer was not there in 2.6


@jpfr it is currently at the "absolute minimum" so it is easy to fix this state :/


Typo in commit note: "This was **a** really simple" -> "This was really simple".


this first


statusCode is clearer than code for clarity


@anthonydresser this code references the use of cookies.  are the cookies documented any where? if not, please change to using an API. thanks Paul @vfrancis


Nur ein workaround


I just tested again, this time replacing Buildcraft with MineFactory Reloaded.  Interestingly, the behavior was slightly different.  Instead of the client timing out if the order was different on the server, the client outright crashed.  Just to be sure it wasn't a fluke, I tried it twice: https://gist.github.com/anonymous/045a43df643c75b24022
When the server's mods were renamed to match the order they appear in on the client, everything worked fine.


Btw, maybe replace "push" -> "publish" everywhere in the test?


'name' should probably be 'type'


Good call. I might just abstract this higher for now until I have time to throw in universal binaries.


``See above`` is wrong now


Instead of "plugin" I think we should say "module" or "feature".


Also we should pretty much always use `let` -- it helps to enforce Immutable thinking


The tuple type identity maybe something you want to use elsewhere in your code. This could possibly be extracted out to named type using typealias. For example...

```swift
typealias WebResponse = (code: Int, message: String)

func refreshWebPage() -> WebResponse {
```


这个php文件可以在进行数据转换的时候直接include进来。


Nur ein Workaround


done: https://github.com/combak/ShatteredWorld/commit/75dadb6caca350e57699330b9fbda8c12ec9d18e


:) Что это за картиночки?


I also did a similar thing in the feature/serial2 branch ;-)


Oh that's cool. I'd say either is acceptable.
I think this rule should be defined separately and should be something like:

If the line is very long this is a cleaner approach.
Or to add clarity in terms of what this function returns.


Ajout de la constante RETURN_PATH


This is a crap commit message. During recovery boot, the properties are not working. The ones passed from the kernel parameters are never integrated into the properties. The fs_mgr uses these to set boot_device_base. If they're missing, it uses boot_device_default.


key3 = test str 3


OK


This is to make the file structure more understandable, but also so we can process our images more easily


Has any of this been tested on the WKWebView? I get some funny behaviour which can be avoided by  checking for the WKWebView in keyboardFocusIn and returning false if it's found.

If there's no testing done on WKWebView I'll raise a PR


Yeah definitely. Probably should be split in to the two, with information about when to promote the type to a named type as well. If it's used in multiple places, promote it. If its unclear the purpose at first glance, promote it.


Wy would you want them at the top? That would mean that the common/login/beagle styles would take precedence. That doesn't make sense to me. Since you are manually adding these, I'd expect you'd want them to have precedence.

NAK.


teşekkürler


You missed `getYValsAtIndex` in `PieRadarChartBase` :-)


done: https://github.com/combak/ShatteredWorld/commit/578273b41d38b668c5a3d45fc588338175ddfe30


With WKWebView still being very unstable, we haven't been testing on it. Feel free to put together a PR for it though.


> master-levels

of course, I hope it's the same bug fort both archives; I'm subscribing to the 2 bugs right now,
and I'll test patch on master levels if available.

> Does it make a difference if you rename the files to .ARJ and .A01 before?

Ah ok, I get it to work that way. So GDP would need to create 2 symlinks in /tmp before it call ARJ once.

```
unzip /var/www/desc14sw.exe
Archive:  /var/www/desc14sw.exe
  inflating: INSTALL.EXE
  inflating: DESCENT1.SOW
  inflating: DESCENT2.SOW
tchet@antec:/tmp/t$ mv DESCENT1.SOW DESCENT.ARJ
tchet@antec:/tmp/t$ mv DESCENT2.SOW DESCENT.A01
tchet@antec:/tmp/t$ arj x -v -y DESCENT.ARJ
ARJ32 v 3.10, Copyright (c) 1998-2004, ARJ Software Russia. [28 Mar 2015]

Processing archive: DESCENT.ARJ
Archive created: 1995-04-11 18:24:50, modified: 1995-04-11 18:24:50
Extracting 4GWBIND.EXE               , Warning! Binary file from a different OS  OK
Extracting DESCENT2.ADV              , Warning! Binary file from a different OS  OK
Extracting DESCENT.PHX               , Warning! Binary file from a different OS  OK
Extracting DESCENT.B50               , Warning! Binary file from a different OS  OK
Extracting DESCENT.M50               , Warning! Binary file from a different OS  OK
Extracting DESCENT.HOG               , Warning! Binary file from a different OS  OK
Extracting DESCENTG.INI              , Warning! Binary file from a different OS  OK
Extracting HMIDET.386                , Warning! Binary file from a different OS  OK
Extracting HMIDRV.386                , Warning! Binary file from a different OS  OK
Extracting HMIMDRV.386               , Warning! Binary file from a different OS  OK
Extracting SETUP.UBN                 , Warning! Binary file from a different OS  OK
Extracting ORDERFRM.TXT              , Warning! Binary file from a different OS  OK
Extracting REFCARD.TXT               , Warning! Binary file from a different OS  OK
Extracting README.TXT                , Warning! Binary file from a different OS  OK
Extracting DESCENT.BAT               , Warning! Binary file from a different OS  OK
Extracting DESCENT.PIG               , Warning! Binary file from a different OS  Continued on next volume, OK
    16 file(s)
Processing archive: DESCENT.A01
Archive created: 1995-04-11 18:25:46, modified: 1995-04-11 18:25:46
Extracting DESCENT.PIG                at position 1416672, Warning! Binary file from a different OS  OK
Extracting DESCENT.UBN               , Warning! Binary file from a different OS  OK
Extracting 4GWPRO.EXE                , Warning! Binary file from a different OS  OK
     3 file(s)
```


@mbernat This is required for changes in the following commits. `ActionChain` makes it possible to bundle multiple actions and return the bundle.


セミコロンねえじゃねえかやり直しだ（ぉ


TeamCity YaccConstructor :: YC.Core General Build [Build 452](http://teamcity.codebetter.com/viewLog.html?buildId=193794&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


- All what I did here is adding the if condition to check if the tutorial is valid to save.
- For base_url I fixed it in this commit 7182ef675dbaa96d874d56434ba650abe055616d.
- For tutorial.html part it meant to be so to redirect to the tutorial after a successful saving. for a valid tutorial URL validation I think that I still need to do it but it will be in tutorial.js


Cool. Yea it's pretty wild with inputs. I've found that having ionic just let it do it's thing is better than the jumping about that currently happens. Will put it in now


Getting rid of some code duplication.


Mmm, again we are ignoring errors :( Why not let it pass with success if sol_platform_get_name() is NULL but not if it's non-NULL (forwarding the return code)?


Yes, for me it's working good.


Let use  {@link AdapterFactory} here


I'd prefer this be called index.html under the /Support/bonecard/create/ directory. Under the /Support/bone101/bonecard/create/ directory also makes some sense, but I don't see a reason to have it be so deep and 'bonecard' seems sufficient to me. The need to be under '/Support' is to avoid cluttering up the root folder with additional stuff as new users are looking to explore these directories dropped in /var/lib/cloud9 on BeagleBones.

Also, I'd like you to minimize the number of CSS and JS files you are including to make it easier for people to clone this work.

Also, I'd prefer if you used the generic name for 'jquery' rather than a specific version. I'd like to minimize the number of versions of the same library to include to reduce the space all of this is taking.

I believe the editor code can be made generic across 'beaglebone-create.js', so I suggest putting it there.


I tried to download MPlayerX-1.0.22.1.dmg, but my web virus protection blocked it. It looks like this download is flagged by many scans VirusTotal.

https://www.virustotal.com/en/file/8a62217ee4f9b373415197480e167864d01482d05ff71493b15fa79a0e0ded14/analysis/1434250366/


This is done, just fix the previous


I'm going to update the PR, if you want to add something regarding the alias send me the markdown


I've come across this bug yesterday. Actually, you need not to insert 0.83 factor.
The problem is in line 398:

img.style.marginTop = (-(1 - options.anchorRef.y) * img.height) + 'px';
should be
img.style.marginTop = (-options.anchorRef.y) * img.height) + 'px';


The log thing will follow the convention (generated by the .py) I'll introduce soonish, but it's okay for now, I guess.


`EnsureLocalTrackingBranch` is very similar to `CreateTrackingBranchUnlessExists`, but it also makes sure the branch is up to date in case it already exists. I am replacing the latter function with the former one where possible. Also replacing `EnsureBranchSynchronized` so there should really be only `EnsureLocalTrackingBranch` unless more specific behaviour is needed.


This commit should be discarded if ever merged to upstream.


名字别改， 都是经过当事人确认的


So it looks like the nil coalescing operator didn’t care for this; that’s unfortunate.


we use [consolidate/express conventions](https://github.com/strongloop/express/blob/master/lib/view.js#L67-L74) for template engines, so we try to consistently use `.` before extensions


You can use -regtest mode setmocktime to mine/reorg chains at arbitrary times in the future or past, so no need to put these dates int he past.


Need to refractor the code.


Good catch, fixed!


We need the staging branch to be up to date as well!


Added an extra check when in head mode during review post. Make sure the current branch is up to date.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.393.97d0aeb6fa242eae2e02fff137060a81c5848195](http://build.palaso.org/viewLog.html?buildId=58813&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3187, ignored: 112 Build time: 00:06:25


I promise that in 2 weeks, after I finish all the exams, I will be able to work on this mod again regularly :)


Cannot use `EnsureLocalTrackingBranch`, because we don't want any branch to be created since `parentBranch` can be basically any git ref. This works because `EnsureBranchSynchronized` succeeds when there is no tracking branch.


- I don't think that I'll need base_url variable in these changes, except for redirecting to tutorial.html part.
- I'll rename it.


This really should be call 'Date line' or 'First date' or something. I should probably let it roll on and see what I can come up with. As I get to know the characters better, I can pull it back to the darker, death centric narrative that I initially came up with.


Now that I look closer, I see that the tests expect to have the test utilities installed in the image. A comment in the commit message highlighting this aspect would be useful, because it is relevant to understand what the commit achieves (and doesn't achieve).

For a start, such an approach is okay.

oeTest.hasPackage() might be slightly more efficient (it works without running anything on the target) and easier to use.

But the real goal is to have all tests install all additional files they depend on explicitly, instead of expecting some special QA image. Can you use oeRuntimeTest.install_packages for this? This can go into a separate commit, appended to the existing ones in this PR.


Hey @nacho87 I think we can use reuse the default link custom post type in Wordpress. Let me know if you need help on this.

Thanks.


Why was this editor chosen? Is it better than 'tinymce'? 'tinymce' has already gotten added to http://beagleboard.org/static/tinymce.min.js and it would be handy if we could choose just a single editor to try to minimize the size and variations of things where possible.


TeamCity TDMS Reader :: Deploy [Build 3.0.12.0](http://build.mikeobrien.net/viewLog.html?buildId=2380&buildTypeId=tdmsreader&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 38, ignored: 2 Build time: 00:00:58


change to "trasferendo"


Sorry for putting this change here as well, git was generating a very weird diff so that I just staged the whole file so that the reviewer is not confused.


I should add that the jury is still out on how to get files installed in all cases, for example when package management is disabled. For now, we can rely on package management for this.


Yep I agree should be suggestion. Its more about clarity, reuse, etc...


Epic! Will be good to have you back, but leave it for now and concentrate on exams ;) (I've just finished mine :D) Hope they go well!


Couldn't help myself removing this one sorry...


Untested!


Moved everything into the file below. The only change is that instead of using `defer action.RollbackOnError(...)`, I create an `action.ActionChain`, push all actions there and then return the whole action bundle from `commands.Stage` function.


Add an assert that the mode is max, as this is the only supported mode.


Twisted, but necessary to prevent a potential CPU denial-of-service attack.


These were called by other classes and it should be simple to make them pass throughs to the new underlying thread


magic number ?


Would need to be configurable - maybe in that static block I deleted :)


Not this instead ?
> level % 100 **>**= 90 && level % 100 <= 9


I just realised that the capitals at the beginning of some of the methods is part of your coding style. I feel stupid now, I didn't mean to intrude with that. Let me know if you would like me to change it back.


since params can be not null (meaning can come with custom data) I believe we need to make use of the process method (https://github.com/droolsjbpm/jbpm/commit/1f9ff60c8bad07154586f354c9dd5cc0dcd417d6#diff-689952382afd5c1b954169c4e53ec220R109) that will do additional logic to deserialize its content if needed - mainly used in ejb services when EJB remote capabilities are expected


A (harmless) warning would be generated... but I'll rename 'remainder' to 'r' here.


I suggest minimizing the number of JS/CSS files included.

It would be great if the preview was live/visible within the bonecard form-factor while under creation, but the tab is a reasonable work-around for now. I'll accept this as-is once you clean up the includes in the commits before this.


Also, probably should use the threaded param to determine whether this is necessary to create


The comment is a very general one that apply to all grad method. I don't think it is useful to add it here. Anyway, you can keep it there.


That's why I said 'it seems'. I saw the error for the first time after the change.
More important: I can not guarantee that this did NOT cause the assert.
Therefore I guess we need more investigation before merging.


Note that this just ends up generating:

```crystal
class CodepointMap
  def initialize(@data = JSONEmoji.load("emoji/db/emoji.json"))
  end
end
```

So the JSON parsing and stuff still happens at runtime. To make that happen at compile-time you probably need to use [run](http://crystal-lang.org/api/) inside a macro.


In truth, I know I'm rewriting Paper Towns here and the problem is that I won't write John Green better than John Green. I have to write Paul Cupido. I have to write stories that are mine and no-one else's. I like the idea of the current version of Paper Walls if it becomes like Nothing-Good is to That-Day (The precursor story which provides the basis for a better and more realized story).


Where were these duplicates made? Are they already in the baseline? I'm going to go back and look.


was just about to create an issue regarding this... and here it is already ;) nice.


Well, I don't have a Mac, but it doesn't seem to break anything on Linux.  So if you tell me that this really works, I'll trust you and merge it.


Another note: I can't find the `emoji.json` file, did you forgot to commit it? You should also use a relatve path, something like `"#{__DIR__}/db/emoji.json"` if you want this to work at all.


Not good


Finally, this is a cute little project, I like it :smile_cat:


Did you include the log as an example? If so, please rename it to something more meaningful (like: example.log)


> Did you contemplate pushing the `data["xxx"].keys.include?(response)` down into a method on the `DataQuery class`?

No, it didn't cross my mind to try to be honest.


cause de l’erreur 500 ?


You really don't like to check for errors, eh? We can't do that :(


What is that function doing here?


update


Is this different than `b#`?


Ditto on error checking.


I will be updating that before release, don't worry :)


There should be no need for a switch here: or we wouldn't need to factorize the code


> Ah ok, I get it to work that way. So GDP would need to create 2 symlinks in /tmp before it call ARJ once.

How about unar?


These functions can surely sit in a shared file that would be compiled in both init-common and init-qemu