I don't know if this approach would be the best for this scenario. I know that you adopted duplicate the attribute 'is_final' in both tables (state and sponsor) to avoid joins when you list sponsor's state in my tasks view. If each sponsor already load all relations (transitivity), well, this scenario will be redundant and will have lower performance. Otherwise, this scenario gain some advantage because avoid a lot of joins when list sponsor's state. However, this approach will always be a tradeoff between write and read, considering that you have 20w/80r law i believe that its the best approach if the condition about transitivity does not verify.


不能翻译的词条最好添加noT=“1”的属性


It's seems that you somehow parse arguments of the partial. But why don't you use [\Handlebars\Arguments](https://github.com/XaminProject/handlebars.php/blob/master/src/Handlebars/Arguments.php) class? Are partial arguments differs from helpers ones?


AttributeError too.


Using the move order with subtree size considerations from this thread https://groups.google.com/forum/#!msg/fishcooking/FvE0k4G4lag/XRiXebVIKRQJ


Hmm, interesting... This code is taken from WinMBF. Thanks Jeff. I'll make the same change you made in your commit.


@djazayeri


Runtime Notice: Only variables should be passed by reference:
https://papertrailapp.com/searches/4565794


Absolutely, thanks. I just didn't think of it.


i have tried different values of position and top/left combination. doesn't work.


This step is necessary if you want to make sure that the website is running on a local web server.


引起bug建议添加noT="1"属性
如果不是建议添加noT="2"


duplicate peerDependencies removed


Remove libboost-python1.54-dev. It is for my pull request.


these checks guard against svg errors if the chart mounts without valid width and height


Best to leave enabled by default as it's pretty much instant.


the reason for your first question is, that there can be multiple sets of brackets, i.e. `[12]3[45]6[78]9[0]` and a lot of starts and ends won't really cut it... What I can do though, is to change line 27 and make that a `while index < position:`. This should stop the test when either position itself is reached by index or a set is added that reaches behind index.

i can try to come up with better names, at least for `index2`


I'd say `ace_x.y.z.zip` is okay, or must it be `ace3`? Also probably good to rework `ACE_VERSION` at some point.


I would expect this to be skipped if we are not writing out the lock file due to it being locked.


welcome to ATN


Funny thing is, doing the opposite and letting Sinon get its hands on stuff can break code too.  https://github.com/petkaantonov/bluebird/issues/631


ah yeah, can't you just after the while loop check if position is between index and index2and jump out early instead of iterating through?


there is a typo in "specific". looks good otherwise.


It's better to do this sort of things during module load time, not leave tham as function run time.

```python
if PY2:
    def fun(...):
        pass
else:
    def fun(...):
        pass
```

The asserts are also a bit funny. This utility function probably won't be used out of scope. If someone does, they deserve all the pain they get. That's why it starts with the underscore :P.


As mentioned in the comment seen below, this is a very specific case of connect error where there's no server at the other end of connection. `connection_error` callback now serves the only function of initiating a reconnect.

This is exactly the same as what was done previously at TCP_CLOSE state in `sk->sk_state_change()` that, as we know, can't be reached any other way in current implementation of Sync Sockets. Only this was moved to to `sk->sk_error_report()` as a more logical place for this.

If we're talking of, say, keep alive timeout in ESTABLISHED state, that's not an error, but rather a normal socket close initiated by the other end of connection. This is handled in `sk->sk_data_ready()` callback that calls `ss_do_close()` on FIN reception.


ok maybe I will actually take your solution... it's a loop less at the beginning and a loop more at the end though... I don't know


where's the additional loop?

2015-06-17 21:27 GMT+02:00 Fabian Neuschmidt <notifications@github.com>:

> ok maybe I will actually take your solution... it's a loop less at the
> beginning and a loop more at the end though... I don't know
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/b991caedc7db84a1de673ecbe40d477150832e0f#commitcomment-11732381>
> .
>


a D is usually considered "ausreichend" ;)


What does this do exactly?


You save some vector elements copy

Le mer. 17 juin 2015 20:13, Navid <notifications@github.com> a écrit :

> why is it better doing it like this ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RomainGoussault/Deepov/commit/9f091755aca959c091b5f9b3f097a90fbed84788#commitcomment-11731023>
> .
>


This needs to be mentioned in the readme.


at coala we have higher standards than elsewhere ;) we can't achieve a grade of 9.5 with D-classes and functions...


As you said "more charts will be made later", so a better approach here would be to pass 'plans' as parameter for other class (e.g. Graphs) and implement the different graphs that you need.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.416.5f0fc38e0b8bf948a1a1b0bb366fd0713e7ec028](http://build.palaso.org/viewLog.html?buildId=58702&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.WritingSystems\SIL.WritingSystems.csproj (new) Build time: 00:01:47


TeamCity libpalaso :: palaso-win32-master-nostrongname Continuous [Build 2.6.115.5f0fc38e0b8bf948a1a1b0bb366fd0713e7ec028](http://build.palaso.org/viewLog.html?buildId=58704&buildTypeId=bt436) outcome was **FAILURE**
Summary: Compilation error: SIL.WritingSystems\SIL.WritingSystems.csproj (new) Build time: 00:01:46


Так как `el` -- это кортеж, можно сделать так: `run_mfold_for_one_seq(*el)`

А ещё проще записать это одним выражением:
```python
return {el.name: run_mfold_for_one_seq(*el) for el in input_collection}
```


K cool, makes sense to me


Only success when add it in rails_helper.rb


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.386.5f0fc38e0b8bf948a1a1b0bb366fd0713e7ec028](http://build.palaso.org/viewLog.html?buildId=58703&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:23


After that modification, feel free to merge your branch.


1608-IGCrash (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2156 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.42%25-yellow.svg)


Это нужно вынести на глобальный уровень, так как это новый класс, а также переименовать в `MfoldResult` в соответствии с принятыми стандартами. Также при работе с `namedtuple` принято, чтобы имя переменной и содержимое строки названия совпадали, т.е. `MfoldResult = namedtuple('MfoldResult', [...])`


Cool. I will have  a look later


RestoreCommand should use the inputs it was given instead of assuming the request was incorrect and reading the files itself.

For the scenario where nuget is trying to install a new package, but the lock file is locked there doesn't appear to be a way to get the new lock file without deleting the old one from disk first or creating a fake empty lock file to pass in.


This is a huge fix for the Arena-PVP aspect of the game right? It's been an ancient issue asaik


need a better example


this is a useless line.


perfect! :) T y


Actually, it doesn't work for me.


@gatorpazz

you probably will want/need to deleted `Gremlins are coming...` it will definitely not help us, unless you want to pull gremlins in.


IIRC this was added because it would crash when torrents are seeds or when the torrent is just a magnet.


Actually, resource_events is a vector. So this gives the `[k v]` pairs in each resource-event map. `(update % 0 ...)` below only hits the key.


Можно создать файл `datatypes.py`, в который перенести эту строку. В таком случае все скрипты будут знать, что хранится в этом типе и смогут нормально его использовать.


I was thinking about just covering one of them so they could figure out what the rest were doing. No go youthinks?

Are you going to be offering another office hour? I'm going to try to encourage people to attend if you are willing to. Their are obviously people with questions...


@pcreglow , same as gatorpazz we will need delete the gremlins line.


Можно будет заменить на один аргумент типа `RnaStructureInfo`


Stole from the book :-) So true though...


TeamCity Ybackend :: synteny/ybackend [Build 35](http://192.168.30.225:8111/viewLog.html?buildId=1340&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


Named parameters for the null here


I would appreciate very much if you checked the behavior of charge in arenas after this commit and report any feedback (please note blade's edge arena pillars issue still exists)


A couple style comments:
# you should choose one of EMPI vs MPI and stick with that. :-) I suggest MPI
# If something is an acronym, only capitalize the first letter. It works better for java capitalization. E.g. MpiCredentials, and an instance would be mpiCredentials.


Is there a scenario where writing the lock file and msbuild files should happen independently?


Oh wow, that's all it was? I hate those bugs :(. Good sleuthing! :mag:


@wolframkriesing Out of curiosity, how did you minify mocha? I'm looking to do the same to run mocha inside Nashorn as a single script. Seems like you need to do a bunch of work arounds to do this.


@esoergel  Should this warn on an india deploy as well? Otherwise they will be a week behind since we deploy india before prod.


Inserir self.vapor = self.Bolha


@MathBrandino aqui você tem uma parte do código que grava uma foto no disco. Uma coisa legal de Orientação a Objetos é a abstração das coisas. Tenta extrair esse código para uma classe que quando uma outra pessoa bata o olho aqui, já saiba o que está acontecendo.


Yep, This class should be common in future for all MPI providers so it make sense to not tie this class with EMPI.
Will rename to MpiCredentials.


Hmm I think you should do some research on this line before you try pushing it into our master branch.


Which part of my first paragraph would you include?


I have correctly extracted Blade Edge arena, all paths works like charm.


This is specific to "OpenEMPI", not to just "EMPI". I suggest calling this OpenEmpi(Xyz)


o que essa variável **helper** significa? É um helper de que? Pensa que eu não quero ter que ir em cima do código para descobrir.


The command:
```
php .\codecept.phar run acceptance --steps
```
The result:
```
See the rows with Bought and sum of withdrawals (ByDescriptionCept)
Scenario:
* I am on page "/activity/description?d=bought&c=withdrawal"
* I see "Bought a laptop"
* I am on page "/activity/description?d=gift&c=deposit"
* I see "gift"
* I am on page "/activity/description?d=Interest&c=deposit"
* I see "Interest"
* I am on page "/activity/date?dt=2000"
* I see "2000-"
* I am on page "/activity/date?dt=2009"
* I see "2009-"
* I am on page "/activity/date?dt=2004"
* I see "2004-"
 PASSED
```


Is this used anywhere?


Jenkins test this please


That should probably be "pvaClient".


formatting


mesma coisa aqui. Nesse caso, pelo menos o método me indica alguma coisa. O valida lá de cima não me diz nada, valida o que?


Dont edit the PassThroughCipher, just create a sepeate subclass
**Class SubstituitionCipher(BaseCipher):**


were are the surrounding round brackets gone? Out of this function?


:bulb:

```csharp
using (var fileStream = file.OpenRead())
```


popoop


@djazayeri
Yep, agree with you.


Null object pattern these conditionals out of the views.


Anything else you'd recommend out of vmstat or anywhere else?


pq vc deixou com visibilidade default? tem algum motivo para não ser private?


@kimchy I'm unable to get these tests to pass. [This is the help output I get](https://gist.github.com/anonymous/b37a0f92e97ce3c5f73a) and it looks like the other clients are experiencing similar failures. Any idea why that might be?


Please make a branch for this paper and work in that, not on the master branch.


1608-IGCrash (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


@rvagg Why a new patch?


For learning rule stuff especially, naming these `pre` and `post` make these networks much easier to read... at least to my eyes!


Should be camelCase: examplePvaClientGet


ack


1608-IGCrash (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2185 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.73%25-yellow.svg)


:thought_balloon: This seems a little strange. You're moving data from one `Stream` to another `Stream`, and then "deserializing" (caller-defined) from the second stream. Consider updating the code to use one of the following instead:

1. Change the argument to `Func<Stream, Task<T>>` and pass the `FileStream` to it instead of a `MemoryStream`.
2. Change the argument to `Func<byte[], T>` so it's clear that the deserializer is loading from a pre-loaded data set. As an alternative, `Func<MemoryStream, T>` might serve the same purpose.


Don't you mean scrapers-us-municipal?


Somehow posts here isn't always a jquery-array.


By your approach, when the torrent is paused and it has download/uploaded 100GB, the average speed will read as "100GB/s" this isn't good.
You should do something like this IMO:
```c++
QString avgDownSpeed;
if (m_torrent->activeTime() - m_torrent->finishedTime() > 0)
    avgDownSpeed = Utils::Misc::friendlyUnit(m_torrent->totalDownload()/(m_torrent->activeTime() - m_torrent->finishedTime()));
else
   avgDownSpeed = QString::fromUtf8("∞");
label_dl_speed_val->setText(Utils::Misc::friendlyUnit(m_torrent->downloadPayloadRate()) + tr("/s", "/second i.e. per second)") + " " + tr("(%1/s avg.)","e.g. (100KiB/s avg.)").arg(avgDownSpeed));
```


The `Cept` suffix in `SigninCept.php` is necessary to make the PHP file a valid scenario.


Yeah, I'm going to add some API docs and mention it there.


Yep. I did, in fact


Should be "pvaClient".


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 312](http://192.168.30.225:8111/viewLog.html?buildId=1342&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


This doesn't look right.


TeamCity Ybackend :: synteny/ybackend [Build 35](http://192.168.30.225:8111/viewLog.html?buildId=1340&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 16; exit code 1 (new) Build time: 00:09:48


> `MetaView` can be copy constructed, and is derived from `View` how would this work?

Go back to the old workaround of making the copy members `protected`?


What problem are these two lines solving?  I don't understand.


hard return yes to split nav. quick and dirty...


Forget this. I thought that active_time was reset when you paused. But it is persistent. So your "hack" is good.


Very nice! Ready for migrations


But I use "pre" and "post" down below...


It seems unexpected that the command would modify the request. If the same request was executed multiple times this would cause different results.


Then this function does nothing?


Tu instancia de Sql Es DIEGOMCD pero el mio es .\SQLEXPRESS


pvaClient


odd spacing.


I already created a branch called 'Morales-Castilla_etal_2015_TREE’. Vanessa, Gian Marco and I will be working on that...


Nice! I'll add it.


So you do! Rescinded!


## This is a markdown file


Hooray!


Thanks!


The few times (sadly) we obey the 80 character width limit, with respect to long expressions/assignments, we put the equals sign on the higher line.


I'm going to make it back to diagonal then so it's clearer. The other option is to make a few more constant variables which I don't think is really worth it here.


Give me a switch statement rather then the iffs.

Trim off excess white space.


Please fix just "Українська" instead of "Українська мова" for Ukrainian language. This the same issue as with Slovenian


yeah this one doesn't need `()`, never mind


@khellang: Incidentally, the reason I didn't create a PR is because the change would be to entirely back out this entire change. I'm not sure why the change was made in the first place, and whether @ranjitCatchinUp has a use-case for it, so I didn't want to be obnoxious and roll it back.


The division sign should probably go a line higher.  This would be consistent with the use of the previous additions (see status sums/calculations above in the same file) and much of the code base where we break arithmetic across lines.


Built new bottles and pushed them. Maybe a weird race condition.


Wouldn't it be easier to read
```js
if (error != null) {
  return deferred.resolve(false)
} else {
  return deferred.resolve(true)
}
```
Or, if you really want to make it short doesn't it make more sense to just do this?
```js
return deferred.resolve(error ? true : false)
```


Instead of multiplying this whole block, why not make a macro? What would you think of something like the following?

```
# list cpp files excluding platform-dependent files
set(LIBCAF_IO_SRCS
    src/basp_broker.cpp
    src/abstract_broker.cpp
    src/broker.cpp
    src/max_msg_size.cpp
    src/middleman.cpp
    src/hook.cpp
    src/interfaces.cpp
    src/publish.cpp
    src/publish_local_groups.cpp
    src/remote_actor.cpp
    src/remote_group.cpp
    src/manager.cpp
    src/stream_manager.cpp
    src/unpublish.cpp
    src/acceptor_manager.cpp
    src/multiplexer.cpp)

add_custom_target(libcaf_io)

macro(build_io_lib shared_name shared_target static_name static_target multiplexer)
  # build shared library if not compiling static only
  if (NOT CAF_BUILD_STATIC_ONLY)
    add_library(${shared_name} SHARED
                ${LIBCAF_IO_SRCS}
                ${multiplexer}
                ${LIBCAF_IO_HDRS})
    target_link_libraries(${shared_name} ${LD_FLAGS} ${LIBCAF_CORE_LIBRARY})
    set_target_properties(${shared_name}
                          PROPERTIES
                          SOVERSION ${CAF_VERSION}
                          VERSION ${CAF_VERSION}
                          OUTPUT_NAME ${shared_target})
    if(NOT WIN32)
      install(TARGETS ${shared_name} LIBRARY DESTINATION lib)
    endif()
    add_dependencies(${shared_name} libcaf_io)
  endif ()

  # build static library only if --build-static or --build-static-only was set
  if (CAF_BUILD_STATIC_ONLY OR CAF_BUILD_STATIC)
    add_library(${static_name} STATIC
                ${LIBCAF_IO_SRCS}
                ${multiplexer}
                ${LIBCAF_IO_HDRS})
    set_target_properties(${static_name}
                          PROPERTIES OUTPUT_NAME ${static_target})
    if(NOT WIN32)
      install(TARGETS ${static_name} ARCHIVE DESTINATION lib)
    endif()
    add_dependencies(${static_name} libcaf_io)
  endif ()
endmacro()

if (CAF_USE_ASIO)
  build_io_lib(libcaf_io_asio_shared libcaf_io_asio_static caf_io_asio caf_io_asio_static src/asio_multiplexer.cpp)
else()
  build_io_lib(libcaf_io_shared libcaf_io_static caf_io caf_io_static src/default_multiplexer.cpp)
endif()
```


o tempo inteiro você chama esse método close() nos seus daos. Dá uma olhada na interface http://docs.oracle.com/javase/7/docs/api/java/lang/AutoCloseable.html do Java7, vai melhorar bastante esse controle.


The pvaClientCPP directory has to be created in the SourceForge web space.


The comparison on 273 never matches because item.getAttr("id") is a type of uuid.uuid and the result from the response is a unicode string.   comparing it against str(item.getAttr("id")) makes the code work.   but you might want to consider casting the uuid to string at 268.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 312](http://192.168.30.225:8111/viewLog.html?buildId=1342&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:22


Yeah, the new bottles and all the bottles you pushed in the last ~15 minutes are fine, even the ones with revision 1/revision 1 in formula/bottle block.


Also, which of the cons would you want to bring up here? Looking at the current list, they seem to be mostly covered by the new material, except for the access to existing libraries.


In your return statement
`return any(index <= position <= index2 for index, index2 in bracketed)`
It's a shorter loop, and `return in bracketed` is actually also one, so it probably isn't valid. Then again you get the extra comparisons, so I don't know which one is faster.

"ah yeah, can't you just after the while loop check if position is between index and index2and jump out early instead of iterating through?"
This is probably actually where it's at. which goes for the whole thing. return `False` if I encounter position in the while loop, return `True` when I encounter a set that contains position.


Yes, I'm on it.


hmmmmmmmmm... I see what you are saying.

so... This???
```
for (NSInteger i = otherNumber ; i <= number ; i++ ){
```


from scrutinizer: unneeded brackets around re.finditer. I agree they don't do any good for me.


so unack :)


extra lines are cool


Huh? addAbility is as it sounds, add another one to the existing ones.


"One of the cool features of the NeoPixel is that it uses multi-colour LEDs with integrated drivers that can be chained together. If you connect the output pin of one to the input pin of another you can connect them together in a connected chain.This is how the ring is built and they also provide the ability to connect multiple rings together, which would all be controlled by the one pin from the arduino. This means that we can take almost all of the same code for the 24-LED ring and use it with a 16-LED ring, a 4-LED strip or a 144-LED strip and it will all work the same!"


seems the start of the cleanup for sound i/o landed here as well. ¯\_(ツ)_/¯


Note that I said "almost all the same code". This is because the number of LEDs in the sequence is required in the code for the initialisation of the ring (the NeoPixel library is not built to be able to detect the number of LEDs in the sequence).


For the transmitter all we needed was:


That's what I thought, but I even tried having the statics (in b6f5909cc29e444bc203769b82fbb9d66c927894) in a different order, Snow first then Basic. And it prevented all basic lands from producing mana.


don't forget to update docs :)


Most likely it is the order. Both are id = 0, so their order is not fixed. If SnowManaEffect is applied first, producesMana will be false, then it does nothing. We need BasicLandEffect to be applied first for SnowManaEffect to work correctly, but there is no guarantee that sorting by id will make SnowManaEffect be in front of BasicLandEffect.


god fucking damnit git, stop thinking I deleted and rewrote the whole file.


These items seem required to declare the product flavors, even though those are empty.
If I remove it, the gradle configuration will be broken.


我写的是正确的你别老该我的好不好。。。。。。


The ordering in MagicCostManaType is also problematic, it must be from least restrictive to most. Snow is at least as restrictive as single color. I'm rearranging Snow to always appear after Green (the last color). It also should not be included in ALL_TYPES as "one mana of any color" does not generate Snow.


YOU'RE THE SCRUB SON!


Thanks !!


Please help to test that Snow still works as expected with these changes. I assume you have some test cases on hand. It will be good to commit them into the repo as well, so we can test it after some code changes.


Good


怎麼可以留白!!! 畫面要全滿


The maps_m4b.jar will be updated outside of this library. I'm concerning that we might stick to old versions if I checkin the file statically. It would be the best if the maps_m4b.jar would be available on Maven repository.


This was good for hiding the help text at the bottom of the screen, but it's not necessary to fix the z-index issue.


I think the resource prop is only used in owned-card. A console warning comes up from it on the collections-user page


Changing the z-index worked for me.  To get above fancybox, I had to use a z-index of 9000 because the z-index values in my fancybox.css settings were around 8040.


Nice gettin shit done :P


Shouldn't Snow be included in ALL_TYPES as it is a type of mana. ALL_COLORS should be for "one mana of any color"

Been using a snow-deck (Always prefer testing in a duel) Can make a test-scenario too.


Ah yeah I was copy/pasting :fearful:


@sergeyshushlyapin , what version of Sitecore has this pipeline? Is this 8.1? Don't see `Sitecore.Pipelines.GetFieldValue` namespace in 8.0 :)


Hey, good stuff. Couple things. Class names are generally nouns, and I think you added a pyc file- use global gitignore I'd say.


yummy!


OS API 22 Android 5.1


hmm, good question, I can't seem to come up with one...


:ok:


I see that the project structure of these files is different from what we've seen on `ti create -t module`. It also has a issue on searching `WINDOWS_SOURCE_DIR`. We might want a way to create correct project structure based on `ti create -t module` command?


we can now debug the music option from html file


This change produces this error:
```
Exception from controller.runGame: 6
java.lang.ArrayIndexOutOfBoundsException: 6
	at magic.model.event.MagicSourceManaActivation.<init>(MagicSourceManaActivation.java:25)
	at magic.model.MagicPlayer.getManaActivations(MagicPlayer.java:477)
	at magic.model.choice.MagicPayManaCostResultBuilder.<init>(MagicPayManaCostResultBuilder.java:32)
	at magic.model.condition.MagicManaCostCondition.accept(MagicManaCostCondition.java:28)
	at magic.model.event.MagicPayManaCostEvent.isSatisfied(MagicPayManaCostEvent.java:39)
	at magic.model.event.MagicActivation.canPlay(MagicActivation.java:112)
	at magic.model.event.MagicPermanentActivation.canPlay(MagicPermanentActivation.java:52)
	at magic.model.event.MagicPermanentActivation$2.canPlay(MagicPermanentActivation.java:142)
	at magic.model.event.MagicSourceActivation.canPlay(MagicSourceActivation.java:26)
	at magic.model.choice.MagicPlayChoice.addValidChoices(MagicPlayChoice.java:66)
	at magic.model.choice.MagicPlayChoice.getArtificialOptions(MagicPlayChoice.java:56)
	at magic.model.choice.MagicChoice.getArtificialChoiceResults(MagicChoice.java:85)
	at magic.model.choice.MagicChoice.getSimulationChoiceResult(MagicChoice.java:102)
	at magic.model.event.MagicEvent.getSimulationChoiceResult(MagicEvent.java:412)
	at magic.ai.MCTSAI.runSimulation(MCTSAI.java:462)
	at magic.ai.MCTSAI.randomPlay(MCTSAI.java:428)
	at magic.ai.MCTSAI.access$000(MCTSAI.java:63)
	at magic.ai.MCTSAI$2.run(MCTSAI.java:189)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)
```
Returning Snow to ALL_TYPES returns to as before.


Good point. I'll make the changes. Return ALL_COLORS for one mana of any color instead of ALL_TYPES.


@dillaman  In func snap_set, i think there also need because it call flush_cache.


Oh, this file is essential to indicate the copyright, license and involved party's responsibilities.


Please fix spacing.


rax retry tests


@benvanik , so only AVX instruction should be sufficient running xenia but not compulsory AVX2 ?


haha yeah I figured


少了一个分号。


Thank you very  much!

Seriously,  Much Thanks!
> On Jun 15, 2015, at 3:44 PM, Ricky C. <notifications@github.com> wrote:
>
> Delete app.db and restart foreman.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/gIoRdAnIsAwEsOmE/Drinks/commit/1db50905873833334678d99061fcd7924aed8b01#commitcomment-11691083>.
>


Fixed po


To keep it simple, I'm assuming Colorless and Snow are independent (Colorless cost can't be paid by Snow), which eliminates some redundant considerations as Snow mana generating permanents always generates Colorless anyway.


do you mean cHours -= 15 ???


cHours += 9


dat space after the bracket :o


The arguments change is not meaningful. So if you're here scratching your head, don't worry about it. It was added in order to wrap the entire contents of the function in a `process.nextTick` but then that was removed.


This isn't cybo's openbump, these keys were taken down :O


The reordering of MagicCostManaType means you always pay for Snow costs first. The payment is from most restrictive to least restrictive. I think this is reasonable, otherwise you might use the only Snow permanent to pay for say "{R}", then you are unable to pay the "{S}" cost.


I think this should be `var_dump($int);`


I think this should be var_dump($int);


#WhinyBitches


Since the scope for this annotation is so small, it might be a good idea to link to the usage in PoreEventWrapper for those trying to figure out why the annotation is present for certain event classes.


Use camel case in creating methods.


@mmckegg thanks for the fix, i ran into this bug last night.


Typos here. Pdf links are pointed to module 6


According to the code documentation, `embox-value` [claims that it does automatically stop](https://github.com/3stack-software/meteor-embox-value/blob/master/embox-value.js#L26-L31).


i delete this file for test,

i can delete file, but i can not add file, and i can not save my edit file;


Yes, but it is not yet implemented: https://github.com/3stack-software/meteor-embox-value/issues/4 :-)

Probably they will implement it in the same way I have done it here. :-)


develop (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.52%25-red.svg)


It seems it was added recently: https://github.com/3stack-software/meteor-embox-value/commit/1778d930e9f3950181e2886420622b8531d58eab#diff-f2c912bd02f323236d81d4a6e42046a2R58


So, it seems only `LazyBox` is stopped automatically.


Do these keyboard shortcuts need to work when the right click menu is not open? If so then `keyDown:` also needs to be updated in `ORImageBrowserView`.


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (2191 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.01%25-yellow.svg)


`\gre@deprecated` needs to be defined in `tex/gregoriotex.tex` in addition to `tex/gregoriotex.sty`.


This and above broke Vizio maybe more


Thanks, I realised it after your comment on ALL_TYPES. Fixed inhttps://github.com/magarena/magarena/commit/cab5fa905addce87f6122fbf607841d80f90101a


good question @carlosmn

based on documentation:

 <blockquote cite="http://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html">
This system exists to allow the library to conform to multiple standards.
Macro: _GNU_SOURCE
    If you define this macro, everything is included: ISO C89, ISO C99, POSIX.1, POSIX.2, BSD, SVID, X/Open, LFS, and GNU extensions. In the cases where POSIX.1 conflicts with BSD, the POSIX definitions take precedence.
</blockquote>

But if you want the preceding definition is that of BSD over the POSIX, we have to add two macros.
#define _BSD_SOURCE
#define _GNU_SOURCE


Adding Colorless into ALL_COLORS is confusing the icon for ANY_MANA being applied correctly. It checks if the amount of colors produced matches the amount of colors. Permanents that can add 4 different types of mana will be given an ANY_MANA icon.


Okay.
> 2015/06/17 11:45、DBInsight <notifications@github.com> のメール：
>
> i delete this file for test,
>
> i can delete file, but i can not add file, and i can not save my edit file;
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/DBInsight/postgres-x2/commit/15fb5af398e954019648669c5ffbc7b7bdd87938#commitcomment-11716386>.
>


Oh.. interesting. I'm still trying to wrap my head around how some of the intricate features of Tracker works.


Why not have the loop outside?
```
\ifgre@deprecated%
  \def\gre@deprecated#1#2{\gre@warning{...}}%
\else%
  \def\gre@deprecated#1#2{\greerror{...}}%
\fi
```
Note: I'm not necessarily saying this is what you should do.  I asking why you did that instead of this.


ANY_MANA should be 5 different types, not four.


Realised that the problem is probably due to gaining mana abilities not implementing Snow anymore


1682_waterheater_stratified (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Yes. We already use it inside gjs, and should use it more.


Snow should be at game layer, it needs to happen at the end.


@raven02, correct.


fixed


> `let relUnpackedPath = "."`

This breaks `cabal install`, see #2658.


Yes - Same for Basic land mana too. Good point


to rotate the position of the screen, the activity is recreated and the currently selected option is lost. No way to keep the manual selection is done by menuItem.setChecked(true);??? Android Do not save the state of selectable menu options?


Hang on for Basic land mana, I recall that there is some reason it needs to be in one of the earlier layers.


Pair programming across 700 miles!


Thanks a lot!


The life of building for OSes :stuck_out_tongue_winking_eye:


Have you considered mb_strpos / iconv_strpos?


must be if(newcolor   otherwise it'll always be false


Gtfo


if(newname) otherwise it wont' have any name.


:+1: so true!

On Wed, Jun 17, 2015 at 4:00 PM, Forest Gregg <notifications@github.com>
wrote:

> Pair programming across 700 miles!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opencivicdata/scrapers-us-municipal/commit/2380c3132f2d8b3167094686ab042abaaafb657c#commitcomment-11732962>
> .
>

--
Paul Tagliamonte
Software Developer | Sunlight Foundation


ahm yeah. dunno why they are there tbh.


Put the godoc on the respective methods inside the interface


hmm
with this commit the notempty validation is always failing (no matter if value is -1,0,space,any other)
BTW: it's not possible to set no value as suboption

fabrikDataEmpty is added in details view for values -1, 0 (as the description says), but I don't like to have 0 consideredEmpty. It's a very usual value e.g. for NO and may break the display of existing records.

-1 and 0 are not consideredEmpty in list view (still showing the label "please select" or whatever)


By my read, line 511 is still going to go off, what happens there?


Actualizaciones


Won't it return if it doesn't get a newname? If it's not b, r or nothing, it returns and never reaches name = newname.


Yup, good catch.


Usar a lógica de keyincorreta


Ah yes, didnt see the last case, okay.


no, actually I think that part is fine.


`return $pos ?: self::length(substr($haystack, 0, $pos));`


Hm, maybe this does work as-is. E.g.

 1. Alice creates a UiView webkey to grain 1.
 2. Bob plugs the webkey into a powerbox request from grain 2.
 3. The platform makes a new entry in ApiTokens with userId = Bob, owner = grain 2.
 4. The platform *also* makes a new entry in RoleAssignments that upgrade's Bob's permission level. (This is the step I hadn't considered before.)


Is it [`takeFileName`](http://hackage.haskell.org/package/filepath-1.4.0.0/docs/System-FilePath-Windows.html#v:takeFileName) from `filepath`?


lgtm if tested


All the minification takes place here.
https://github.com/tddbin/tddbin-frontend/blob/master/package.json#L13
does that help?


@mafintosh this is OK right?


FYI: the .git suffix is optional when using https://. Only git:// requires it.


Ah I see, actually, as the commit says: I seemed not to have been able to minify it :/


This breaks API compatibility so we'd have to bump to nar-maven-plugin version 4.0.0. Is it worth it? And if so: any other dead code or backwards-incompatible API changes we want to make at the same time?


This was causing the sketch to quit cleanly when its window closes, which is necessary to let the Mode know that it can turn off the "stop" button and turn on the "play" button, etc.


This file `codeception.yml ` is a global configuration file. There is also a config for each suite. We also support `.dist` configuration files.
If you have several developers in a project, put shared settings into `codeception.dist.yml` and personal settings into `codeception.yml`. The same goes for suite configs. For example, the `unit.suite.yml` will be merged with `unit.suite.dist.yml`.


@jpfr probably you are right, sacrificing sizeof(void*) for every node is worth the speedup


need same fix on lib/error/cast.js


I think it's much more understandable if these functions are named something different for different platforms. (Windows has errno, for example, though you're probably not going to use it.) `TranslatePosixErrno` and `TranslateWin32Error`? I believe WSA (Win32 BSD-style networking) has its own error namespace too.

No big deal, of course.


Just to save you some time when pull requests come along, I prefer to delete code rather than comment it out.


Sheesh, I'm an idiot.

On Wed, Jun 17, 2015 at 11:01 AM, Aaron Borden <notifications@github.com>
wrote:

> Did you mean to commit the exit ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/goodeggs/developer-start/commit/cbc511505f9dc8ebdd50ba53914bd6dd264938ea#commitcomment-11730793>
> .
>

--
randy puro || good eggs || 510.326.2789

dig in: twitter <http://twitter.com/goodeggs> || facebook
<http://facebook.com/goodeggs> || blog <http://blog.goodeggs.com/>


This is a gray area in SemVer. What is our officially supported API? Someone might have their own extension of `AbstractDependencyMojo` which would no longer compile after this change. Of course, we can declare that our use of SemVer only covers public API for consumers (not implementors). But I'd like it to be a conscious decision.


Melhorar mensagens de erro!


I guess it will be slower.


node is not released. how do we check the type? how do we prevent multiple attaches?


I generally agree that we're hiding the issue, but assuming the description in the issue is accurate, there's nothing special going on, just a fragment in an Activity. If that's the case, there aren't real alternatives. isFinishing may be false, because you don't need to be finishing for the activity to be destroyed. isDestroyed on the activity is only available on more recent API levels, and it's less than certain that isDestroyed will be correct on the fragment manager here.

Given that this behavior just enables recursive pausing/restarting, this seems like a reasonable solution. The logging will be on by default so if we make an error that makes this super common, we should see it logged.


`ByDescriptionCept.php` is an individual test.


Sugestão de mensagem: foi inserido informação para a incerteza de x, entretanto não forma inseridos dados de x e y


Another backwards-incompatible change. And I vaguely recall when looking at this code awhile back that the `AbstractNarMojo` does end up being needed? Are we sure it's OK to remove here?


I'd reverse the condition, makes it more natural:

```
if None in (start, end):
    yield pattern
else:
...
```


@cnathe @mbellew Sorry fellas, this might break your currently imported test setup.


I like it this way, it can be used in platform independent code. For
instance, you call some function that's supposed to create a socket, it
fails, you can return an error code in a generic way.

On Wed, Jun 17, 2015 at 1:12 PM, strager <notifications@github.com> wrote:

> I think it's much more understandable if these functions are named
> something different for different platforms. (Windows has errno, for
> example, though you're probably not going to use it.) TranslatePosixErrno
> and TranslateWin32Error? I believe WSA (Win32 BSD-style networking) has
> its own error namespace too.
>
> No big deal, of course.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sas/ds2/commit/c3c595d2b41ecee77d4e5889b2576d8cab4828c2#commitcomment-11733181>
> .
>

--
Stephane Sezer


Sweet @ncanceill


We can leave this in to avoid breaking API compatibility.
I'm not aware of any other project depending on NAR as a library for API, having checked http://mvnrepository.com/artifact/com.github.maven-nar/nar-maven-plugin


@warneboldt  Is there a reason for calling url(/img/tab-background-half.gif) twice here?  Caught my attention after seeing ```ActionController::RoutingError (No route matches [GET] "/img/tab-background-half.gif),%20url(/img/tab-background-half.gif"):``` in our server logs.


Brian and Shigeki also are not TSC yet, guess I'll have to make a PR..


This is interesting but there is a default figwheel use case is to do dev on remote devices (iphone, ipad, etc) at the same time.  This would preclude that use case.

You should try this. Open an app in your phone's browser and in your laptop browser and edit the app. Not just magic, much needed magic.  This should be the default behavior of figwheel.


TeamCity libpalaso :: palaso-win32-master-nostrongname Continuous [Build 2.6.116.0d36a09cf10dec6e6f2be67586c062c36b4fdae8](http://build.palaso.org/viewLog.html?buildId=58707&buildTypeId=bt436) outcome was **FAILURE**
Summary: Compilation error: SIL.WritingSystems\SIL.WritingSystems.csproj Build time: 00:00:50


Close `hFile`.


Inverter ordem dos blocos de validações;


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.417.0d36a09cf10dec6e6f2be67586c062c36b4fdae8](http://build.palaso.org/viewLog.html?buildId=58705&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.WritingSystems\SIL.WritingSystems.csproj Build time: 00:01:04


This ^^


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.387.0d36a09cf10dec6e6f2be67586c062c36b4fdae8](http://build.palaso.org/viewLog.html?buildId=58706&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:42


Ha. Oh the wonderful titles we will have.


instead of this condition you could actually use `filter` :)


isn't this logic duplicated inside `initDS9` itself? It explains why when things go wrong you get 3 x 10 messages indicating that we are waiting for ds9,


msvc only added recently in this version - as it is still snapshot I think you may be thinking of something else


This is the area where the order of transaction checks changed.  I'll see what I can do to preserve the historical order of the checks.  The resulting code is likely to be less straight forward.

Over time we'll need to think about how important the order of error checks is to transaction processing.  The checks that are currently in place were not put there for maintainability.  To a certain extent, each check occurs where it does because it was convenient to put it there.  Requiring that the order of transaction checks may not change over time will make it more difficult for us to maintain our code.  If error ordering is important we should probably have white box unit tests in place that verify the order in which various errors are tripped.


LGTM


We never reach these states in `sk->sk_state_change()` socket callback, as we forcefully close the socket when it is moved to TCP_CLOSE_WAIT state (which happens when FIN is received). We call `ss_dropdata()` that releases all resources associated with the socket, and then call `ss_do_close()` that closes the socket. Also, see the comment above.


Shouldn't this be `argCount += 1;`?


Hmm... didn't work without for me... Maybe a zsh thing? But still, likely more portable then, and it's also what they show in the book.


Also, rather than this `argCount` thing, I'd much rather see the arguments accumulated in a `List<String>` or some similar structure, and then finally concatenated at the end. That would eliminate any possible skew here. (Duplicate data structures: never a good idea!)


The entire purpose of this argument seems to be to decide whether to print a message indicating where `ds9` is already running or not. I had expected from the name that it would be used to decide whether an attempt should be made to start DS9.


Agreed; `#` prefixed now so if they do it's no biggie.


This only works for x86. =[


From what I can see m_mceRequest is not a scoped pointer and it's not deleted anywhere. Looks like a leak.


Off the top, there are a number of problems with this pull request.

1) The rest of the functions in ec2_operations.jl are alphabetized.  It would be better if the new functions were alphabetized along with the existing functions, rather than just being inserted at the top.
2) You are exporting each function twice, once after each definition.  By contrast, the existing functions are exported just once each, right after the second definition.
3) There are two definitions of each function.  The first is supposed to take env and msg; the second takes env and kwargs. While it appears that your kwargs version is correct, the msg version fails to actually take env and msg as arguments.  Further, the msg argument for each should be associated with the types in ec2_types.jl from patch-2.

Your patch-2 branch should be applied first, followed by a corrected version of patch-1's changes (with env and msg in each function's argument list).

Also, please remove comments that describe the changes (e.g., "Additions to ec2_operations.jl" should not be inside ec2_operations.jl; that should be a commit comment).  Comments should describe the current state of the code, not what changed since the previous revision.


Well. Where is the 2.3 branch then? :-)


Grub1 and grub2 both support setting the root directory for an install and
then look for grub in $root/boot/grub. Since we want to support multiple
boot directories with both grub2 and grub1, we just set the root directory
to the boot directory. Since grub will now look at /boot/boot/grub or more
generally $bootdir/boot/grub, we flatten out the hierarchy by symlinking
boot to the current boot directory.

On Wed, Jun 17, 2015, 12:28 Eelco Dolstra <notifications@github.com> wrote:

> What does this do exactly?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/d4fc2b4d99122ba6592835aa84f659b22aeea433#commitcomment-11732391>
> .
>


This `shared` variable is only necessary to increment the reference count on any requested maps, correct?


Why do you need the casts?


buttonX nie jest w tym scope zdefiniowany


And at the moment there doesn't actually appear to be any public API - sure a discussion should be held.


CSS Appearance not supported by: IE (10,11), IE Mobile (10,11)


CSS Masks not supported by: IE (10,11), Firefox (37,38), Chrome (42,43), Safari (8,7.1), Opera (28,29), iOS Safari (8,8.1-8.3), IE Mobile (10,11)


It is considered good practice to do active record queries in the action instead of the erb file. There should be as little logic as possible in your erb.

Consider defining `@songs = Song.all` in your actions and using that in the erb.


Please make the message translatable.


I should also note that they still detect which partitions the directories
exist on so it still works fine at boot it just adds an extra layer of
indirection since grub1 doesn't support changing the location of the boot
directory relative to the root.

On Wed, Jun 17, 2015, 13:19 William Kennington <william@wkennington.com>
wrote:

> Grub1 and grub2 both support setting the root directory for an install and
> then look for grub in $root/boot/grub. Since we want to support multiple
> boot directories with both grub2 and grub1, we just set the root directory
> to the boot directory. Since grub will now look at /boot/boot/grub or more
> generally $bootdir/boot/grub, we flatten out the hierarchy by symlinking
> boot to the current boot directory.
>
> On Wed, Jun 17, 2015, 12:28 Eelco Dolstra <notifications@github.com>
> wrote:
>
>> What does this do exactly?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/NixOS/nixpkgs/commit/d4fc2b4d99122ba6592835aa84f659b22aeea433#commitcomment-11732391>
>> .
>>
>


You reversed this condition!  `!map` => `map == nullptr`.  Is it necessary to compare to `nullptr` at all? Why is `!map` bad?


Oh yeah, good point: we haven't done a release since then have we? Never mind then!


looks good besides


Translatable?


Piotrze, możesz w skórcie napisać, co ta zmaina zrobi w aplikacji? Czego miałbym się po niej spodziewać?


What if the user is not logged in and they create a song? Right now, the user_id would be nil.

This is not part of the official requirements, but as an enhancement you can redirect to the login screen if the user tries to create a song without being logged in.


Got it.  I'll take your basic fix and use an alist instead, plus add tests.  Thanks for the report and initial fix!


small syntax suggestion `if user && params[:password] == user.password`


Mhmmm, true, this shouldn't be in this file. I'll move it to ThreadX86.cpp.


I thought it is not necessary to make this translatable, as this is a developer feature?


From what I've read, clicking damage on bosses make up a tiny portion of damage and it's actually the nuke-type abilities that some randoms are casting or maybe Napalms that are still active from previous round that do the majority of the damage. Disabling auto click damage would have a minimal effect and hurt gold obtained from Gold Rain, though gold seems to have lost a lot of its value recently.


Not sure what you mean by "there doesn't actually appear to be any public API". There are lots of public classes, methods, etc. That's what I mean by "public API".


`pos?`


nitpick ... but @karimnaaji can you set your editor to prune trailing whitespaces?


-1, please consider the changes to simplify this that we discussed F2F earlier.


Because size_t and SIZE_T are not the same type and the compiler complains. Also, because address.value() returns an uint64_t.


so you double the spec here, I'd remove the comment on top of the file then. Double docs is never good


#### Stackedit client code is generating incorrect timestamps

still throwing same error, at least with custom smileupps instance. perhaps problem is on smileupps side. its not a time zone thing, though -- most likely year

- Took timestamp from  couchdb
![image](https://cloud.githubusercontent.com/assets/3758548/8217701/fb778108-150c-11e5-981b-f4aefbdf473b.png)

- checked it in python
![image](https://cloud.githubusercontent.com/assets/3758548/8217661/c516ec70-150c-11e5-838b-3648a5d9b128.png)

#### tl;dr Timestamp that stackedit client is generating is incorrect.


But what if a UiView capability gets transmitted without a user interaction? What if we continue the scenario:

 5. Grain 2 restores the UiView.
 6. Grain 2 transmits the live UiView to grain 3 over a pre-existing connection.
 7. Grain 3 saves the UiView.

What value should be used for userId in step 7? It would be wrong to leave it empty, as that would mean that when it's restored it'll be able to create sessions with any permissions.


# USE THE ~~FORCE~~ QUOTES, @SirEdBr!


Yeah, you'd call `TranslatePosixErrno` after calling `socket`. `GetLastError` doesn't return `socket`'s error code.


Not really without falsifying that function, didn't know that there is itertools.filterfalse() though


fantastic


What kind of commands can the listening websocket do on the developers machine? Does it just display thing from the browser or can the browser also run commands? I don't know enough about the inner workings. If it's really just passive and the websocket doesn't allow anything crazy then it'd probably be ok with listening on a public IP.

However, it also serves the `(route/resource)` so it'd also mean that you serve all your source code to the world. That's probably not good.
Scanning the entire internet can be done with a few hours of work. Scanning for `:3449` and slurping up all your resources is probably not good security for developers.

So I'd say it should be an opt-in with a config option. Definitely not the default and figwheel also lies about it when it prints out "localhost:3449".


Please document lock ordering requirements here.


Err, you'd use `WSAGetLastError` on Windows for `socket`. (I was thinking of `open` when I wrote my latest comment.)


makes sense


:+1: yep will do, sorry about that


why don't you cover this? We measuer coverage on linux.


Paoloo,

I've discussed multi platform builds with the premake devs and I now have the correct solution.  I'm helping out on a film shoot this weekend so I'll be out of pocket until next week.

The changes I make to the premake scripts should allow compiles against OSX, Linux, BSD and Windows.

jim


Typically with authentication systems we only store the user_id in the session. We can then use the user_id to retrieve the full user object later. You can use a helper method called `current_user` to accomplish this.

The problem with storing the username in the session is that over time you will need other user attributes too, like the email of the current user. If you add all these attributes to the session you end up with too much data in there.

Plus, you will have to remember to clear all of these attributes when you clear the session.


Actually, jsx-typescript is running on 1.5.  Native JSX support is currently not on any roadmap, though I'm guessing it will come with 1.6.


no need for the second no cover, if you do no cover after a condition that will uncover the body too


Yeah, sockets are not a great example, but you get the idea I guess :)

On Wed, Jun 17, 2015 at 1:24 PM, strager <notifications@github.com> wrote:

> Yeah, you'd call TranslatePosixErrno after calling socket. GetLastError
> doesn't return socket's error code.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sas/ds2/commit/c3c595d2b41ecee77d4e5889b2576d8cab4828c2#commitcomment-11733518>
> .
>

--
Stephane Sezer


Yes, you said that in the last review also but the comment got lost on rebase and force push. I will remove that.


could refactor these two lines into a helper method that logs in the user

```ruby
helpers do
  def login_user(user)
    session[:user_id] = user.id
    session[:username] = user.username
  end
end

# some more code here

post '/login' do
  # use the login_user method here
end

post '/register' do
  # use the login_user method here
end


Argh. Added in c544a2b.


maybe move this block out of the `for` loop, and change
`for i in range(0, len(xd))` to `for i in range(1, len(xd):`


`for match in filter(lambda match: not _position_is_bracketed(pattern, match.start()), re.finditer(...)):`?


i don't think this line is needed


Have you tested this on SKL?  Now that we support SKL, we need to test these.


right


@matsen: Dude... Totally killing the joy here...


AE wants to know the delay at the time it calls GetDelay, not at the time of the callback. I have no information about why callbacks are preferred here but in case of callbacks the time needs to be measured from cb to GetDelay.


Typo.


It's better to use RootSift here. See here for the other version of sift https://github.com/openMVG/openMVG/blob/master/src/nonFree/sift/SIFT_describer.hpp#L32

It basically consists in dividing each element of the descriptor by the norm L1 of the descriptor to obtain a float between 0 and 1 (then u can cast it to uchar multiplying by 512)


05405694, doesnt allow for the the new one also?


We might want to make this speakerbotclient?


Please test your patch set on SKL


LGTM


could you add the command to apply it to an existing virtual server?


Codestyle.


-1, we don't add people to authors just because you add some one patch series.


Hot.


Need to test on SKL.


Oooooh yeah.


What happens with all the code above is this is not defined? (Hint: do we really need this ifdef?)


Please test on SKL.


haha no `[:-1]` or `rstrip`?


those are good ideas.  :)  did not think of those


Testing


tesing 2


It seems it would be safer to create the pipe before creating the signal handler thread. Otherwise the thread could attempt to read from a handle that doesn't exist yet and would abort.


this is a bit confusing and I think can be improved:
Does "client ssl profile" relate to x509 client certificates or something else entirely? And if yes, why is ocsp ties to client certs?

It's be worth adding a few commands to illustrate how configuration of either the DNS resolver or the proxy is performed.

Commands to verify the current configuration are useful as well.


@sidorares Given that I came back to node-x11 and finally figured out what was wrong, you could add https://github.com/Airblader/node-tinywm to this list now, if you want. Nothing fancy, but oh well.


This commit introduces _no_ changes.


Se mudar alguma coisa em alguma classe antes de testar, ela deve ser recompilada.


Prefer `enum class` to `enum` with Polish notation.


what about providing only the hsts information in this section, and not the extra stuff about redirects?


please change this to this.raw(node) in the serializer since cdata would actually be serilized as '<![CDATA[' +node.nodeValue+ ']]>'


You can replace lines 70-72 with the http://apidock.com/rails/ActiveRecord/CounterCache/ClassMethods/increment_counter  method. This method is also handles concurrency.

Consider what happens if two users vote for the song at roughly the same time. If line 70 runs at roughly the same time for both users, then when line 72 runs, it will miss one downvote.

Here is an example: http://apidock.com/rails/ActiveRecord/Base/increment%21#981-No-concurrency


For now - we basically do the same - we poll and might not get any information at all ...


so yeah, esentially you're duplicating parts of the code from the is bracketed function so I'd suggest you move that out into an own function to make both a bit simpler


Great job on the assignment! Please review the comments and let me know if you have any questions.


test


This is pretty ugly but that's due to how tag-stat-combine is stored in settings. Definitely not worth fixing now.


brb reverting to bundler 1.10.3


Fixes #7


Like any other patches in this project I have ported this from vpg driver.This is not someone's patch series.
If you still think I shouldn't be there in the list I will remove this patch.


I'll experiment with that, but that is the mechanism that will generate the warning. This is probably a good detail to document.


I got this feedback about the unghost: "You've implemented a screen refresh between pages. Works great when going across multimaps but it a bit cumbersome in the Config/system menu. Can that be changed? "

http://www.paraglidingforum.com/viewtopic.php?p=p462923#p462923


you would still have to make a list of all of them and take the last one, I'm not really sure that it is an improvement?
interesting concept though.


No, regardless of the state of the lock file we need to write the MSBuild targets/props file. Imagine if the user removed the file accidentally.


have to run on jdk7


1608-IGCrash (kbenne) - i386-Windows-7-VisualStudio-12: OK (2193 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.1%25-yellow.svg)


No, but since the lock file versioning rules will likely be strict and there has been talk of putting non-package libraries in the lock file, I want to put it there now.


OCD :3
TimeStamp იყო sun -ის და sql გვჭირდება ჩვენ


why this have to removed?


uuugh, I hate that C# makes you put named parameters after all positional parameters... I'll try to reorder the parameters to make that feasible


Pero si no he hecho ná!


I meant that you could just check getBaseConstructorTypeOfClass instead of baseClassType


Ah...thanks! One of those insidious little things you warned me about. Keeping an eye out as I hunt test failures.


WaitForOperation(pa_stream_update_timing_info(m_Stream, NULL,NULL), m_MainLoop, "Update Timing Information"); <- this one here I basically don't like at all ...

from my logging I see that GetDelay is called a whole lot of time ... and I consider a cache value bettern than blocking for some ms. But I can measure the blocking ... Let me try something else before: http://sprunge.us/gaFZ


Sure, I agree that would make things simpler and easier to understand.


You can exit if you got an error from one of these.


If the lock file is not valid relative to the project, it is completely unusable. We could error out and fail immediately, but that seems to be a major hurdle for the user to get around. If the user changed the project.json, the lock file must be updated regardless of the locked state.

Thoughts @davidfowl ?


ყველა ფაილში body tag -ში უბრალოდ დააიმპორტეთ header.jsp


This is weird... we are calling main/cron/user_import/service.php although this file doesn't exist.
However, it exists in main/webservices/user_import/service.php... any idea why the link was left like that, @jmontoyaa ?


I'm not necessarily suggesting that this is required (though it would fix the immediate problem)  Shock is in fact better for the larger files. But it would be nice if the Workspace api didn't make the api consumer have all the logic to handle this.


well i copied the code from here, but yes, I can probably extract a find_set(index) function that returns (start, end) or similar


have to implement it later


why are you using so many underscores? That looks like you're using something super-important-dangerous-python-builtin and on second look you're just defining file paths...


Ah, you're right, but it's on the alpha release, not the current beta, and the API changed between the alpha and the beta. The main point is that jsx-typescript is behind the currently released TypeScript which has a different API and there are no plans to update it (I asked the author on twitter some time ago) because it's coming natively to TypeScript. Regarding a roadmap, I'm not sure, but there are a number of issues in the Microsoft project related to it.


This isn't needed because `Check Test Tags` also verifies status. I can remove it.


Hi,
thanks for the pull request: I think it's a good change and I'd love to merge it.
Would you mind updating the tests so that they can pass and amend this commit?

Thanks!


Line 601 shows how to add an SSL profile to an existing virtual server. Are you referring to something else or do you think what I've written is ambiguous or unclear?


I only ran "mvn -Pdev" locally.  As per comment on the PR - the test code should be robust to either correct form being produced.


gdfgdf


Like so? https://github.com/hotosm/osm-tasking-manager2/pull/661


Jenkins test this please


I suppose we can do that. RestoreCommand is always used in some kind of host, and the host can decide how it wants to handle this.


@matsen: Can you leave these in next time? I'd like to have them there as a way of guiding my sense of time as I speak. These were based on a run at home.


Just want to point out that it's possible to use `Chef::EncryptedDataBagItem.load`  right from a role. Thus, it's not true the users were forced to pass credentials un-encrypted.  This only forces users to use their own template to override these parameters to do exactly what they were already doing in the first place.


Yes but probably not here. Maybe a devdocs section on more details about the package manager? For new people we should explain what they need to put in their REQUIRE and what that means, but maybe we can leave the finer details to somewhere other than the intro to package management section.


Understood. We don't have a lot of documentation around creating OCSP profiles at the command line (most of this is done within the GUI). I may pull this section, for now, unless you think I can re-word it to make it clearer?


this looks great


I think I'd defer the issue of adding a check to accept only `ForeignKey`. There might be code out there that works with other fields in some strange way. Unless we find it's a common problem of people using the wrong field types, I don't think a check offers much benefit.


database (oracle prod setup) naming conventions


why don't you write a small function that appends slashes to a list of paths?


Yo tampoco :sob:


I'm so keen on the spreadsheet integration idea FYI :)

On Wed, Jun 17, 2015 at 11:44 PM Mikey <notifications@github.com> wrote:

> @bhaugen <https://github.com/bhaugen> yes, i think so. [image:
> :smile_cat:] you can use holodex/enspiral-data
> <https://github.com/holodex/enspiral-data> as a rough guide, if you have
> questions please ask in open-app/holodex/#47
> <https://github.com/open-app/holodex/issues/47>, i'm happy to help.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/open-app/holodex/commit/0069360b5c627a777bde36dcdf9d10295cb85eda#commitcomment-11723110>
> .
>


I was changing line 479 which had been 'namepsace'. it look like it had already been corrected in master. This pull seems to be only the misspelled words in the comments.


This is unnecessary boto transparency pages the results, see: https://github.com/boto/boto/blob/develop/boto/route53/record.py#L182


according to docs the filter function already returns a list


Sounds good.  I'll just use the v0.3x release for the time-being.  Thanks!


`filter(lambda match: not _position_is_bracketed(pattern, match.start()), re.finditer(...))[-1]` would do :)


Of couse, the other reason you get lots of error messages is that each of the AFW tests will try and fail to launch DS9.


bbbbbbbbbbooooooooooooooooooo


Soooorrryy


Tiny detail: there are too many negatives, it makes the logic confusing. Can this be renamed to canOverwriteOutputDir, and move the negation to line 75?


Out of shame for declaring global variables I guess ;) It hides them a little behind their super-important-dangerous-python-builtin-look.

On a serious note, all the super-important-dangerous-python-builtins like `__name__` are module specific and I thought that fits. This way you're also not looking at the code later, searching for where 'file1' was declared.


@podviaznikov @Deraen What was the rationale of removing `endophile` in favor of `markdown-clj`? The deeper I get into migrating my blog the more I notice shortcomings in `markdown-clj` and opinionated decisions (e.g. blockquote syntax) that break compatibility.

Endophile claims to pass the original markdown test suite and just lets some Java code do the heavy lifting.


Done.


@DarthAndroid Thanks!
@cy6erGn0m Should we revert this commit then?


You forgot to version bump.


so why don't you simply make them class static?


These names are already long enough, in some cases too long. Too much effort going into "hiding the name" which has to date not given us any returns. I'd prefer to see deeper improvements related to core business logic than haggling over how to keep a name hidden.


tesest


Perhaps it is that the endophile is only parsing library, it doesn't do rendering?


Its not about efficiency its about making certain that we catch invalid inputs at the high level instead of the low level. Because then we have fewer items on the call stack to unwind when handling the invalid input.


C'est pas bon ici, car ce n'est pas un float mais un entier. /2 est la division entiere par 2, alors que * 0.5 vas convertir en double (ou en float si -fsingle-precision-constant ou si tu fais * 0.5f) puis reconvertir en entier. Ce sera plus couteux au final.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 69](https://teamcity.labkey.org/viewLog.html?buildId=255485&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 1 Build time: 00:17:26
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSUpgradeTest: <no details avaliable>

```


Again, I'm not sure this code is necessary - it looks like boto does this transparently: https://github.com/boto/boto/blob/2d7796a625f9596cbadb7d00c0198e5ed84631ed/boto/route53/connection.py#L131

I've not tried creating that many records, but have you seen truncation happening?


Or well, it provides `to-hiccup` function which I guess would be enough.


Ici aussi, il faut laisser /2 car il sagit d'entier.


Собственно как мы карту вставляем? Правильно, через скрипт.


Do you have SPEC running on pydgin-riscv yet? Any results? :)


Views are less likely to leave their scope and accidentally outlive their referent if they can't be copy constructed.


I felt that getFlat and getRaw were nearly identical unit tests, so I just picked one at random. I think they should be combined into one test, but didn't feel that was in scope for this ticket. So...how wedded are you to my moving the test?


WAAAAAAAIT why are there slashes.
And why is this passing on Windows :anguished:

There should be a function appending os.sep though. yes.


Ce sont des entier ici (par contre, tu peux faire >>1 à la place, mais le compilateur le fait déjà certainement).


Assuming eth0 here will be problematic for any complicated bundle deployment. There is going to need to be a way to target specific interfaces. This is probably fine for an initial implementation of chaos using tc but we'll need to enhance the solution in the near future.


`PaymentView` is currently unused.  Do we need it?


`DeliverMin` or maybe
`"Partial payment not specified for " << jss::DeliverMin << "."` if that could somehow be made to work.


:P

2015-06-17 22:51 GMT+02:00 Fabian Neuschmidt <notifications@github.com>:

> WAAAAAAAIT why are there slashes.
> And why is this passing on Windows [image: :anguished:]
>
> There should be a function appending os.sep though. yes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/2c184b7244eb5dc81de7d086d27509385bb0d3cf#commitcomment-11734017>
> .
>


Des entiers encore ici visiblement.


Des entiers...


Found the tweet. https://twitter.com/jbrantly/status/595769644016865283

I think you're right though that it probably won't be in 1.5. Maybe @Fdecampredon might release an interim version for 1.5 stable once that's out.


This function gets removed later \phew


Des entiers non ?


```clojure
;; parsed is an org.pegdown.RootNode
(def parsed (mp (slurp "README.md")))

;; convert to html using clojure.xml and enlive
(println (html-string (to-clj parsed)))

;; convert to html using hiccup
(println (html (to-hiccup parsed)))
```
As far as I understand it uses enlive or hiccup to do rendering.


Entier. Et de tout façon, MAXBLOCK est un #define, la valeur sera calculée à la compilation.


`getFlat` and `getRaw` exercise different code --- they are not "nearly identical".  Both should be preserved.


remove semicolon


This could be re-written to be more readable and easier to change:

```ruby
if ['orta', 'ash', 'artsy', 'Laura', 'CI'].include?(ENV['USER'])
```


Changes made, have another look.


I'd like to hear your thoughts on the domain-specific aspects of this design


Interestingly separate `Check Test Case` and `Check Test Tags` are needed here. I was surprised why, and after little investigation found the reason. When explicit status is given to  `Check Test Case`, it sets test's `exp_status` and `exp_message` attributes that also `Check Test Tags` will then read.

A cleaner solution is adding the expected status to those tests on the test data side. I'll take care of that.


It's just that it's totally inconsistent with where it is in obs_cfht, and that seems silly.  To that point, those two tests files should probably have the same name in each repo, but I wasn't going to have you do that here.


I'm referring to the command needed to apply the profile that has tickets enabled to a virtual server. It's probably similar to the one on line 601, but not exactly. correct?


@sanchitshaleen Can you clarify what you're asking about?


Do you accept "writing 'TestFiles.file1' everytime takes too long (time as well as space)" as a valid reason?


>Because that is copied from old code.
>And because the old code never #defined WAIT_TIME_SRVR

Can we just define this and replace the `3` magic number? If we're rewriting this whole function, why keep that part?


we can totally add screenshots. just put the links somewhere in these comments and I'll upload them.


Might be zsh.  `locations*` will attempt to match objects in the cwd:

```
mrg@talos:~$ for f in locations* ; do echo $f ; done
locations*
mrg@talos:~$ touch locationsa locationsb
mrg@talos:~$ for f in locations* ; do echo $f ; done
locationsa
locationsb
```

if you meant that as `$locations*`:

```
mrg@talos:~$ locations=(one two three)
mrg@talos:~$ echo $locations[*]
one[*]
```

Shell won't interpret the bracket as part of an array.  This is a posix thing:

> If the parameter name or symbol is not enclosed in braces, the expansion shall use the longest valid name (see the Base Definitions volume of IEEE Std 1003.1-2001, Section 3.230, Name), whether or not the symbol represented by that name exists.

Names, as defined by section 3.230, are alphanumerics and underscores, so it stops at the open bracket.


btw I know this isn't according to the codestyle and I will probably change that.


джэджэд


To be clear, I'm referring to getRaw.py in obs_subaru vs. testButler.py in obs_cfht.


I think it should be almost there. I just need to bug Yunsup to get us
bare-metal SPEC to try.

On Wed, Jun 17, 2015 at 1:51 PM, Christopher Batten <
notifications@github.com> wrote:

> Do you have SPEC running on pydgin-riscv yet? Any results? :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cornell-brg/pydgin/commit/4731cf6c214c6a2e22d2d957788ffc6687f67dd6#commitcomment-11734009>
> .
>


How do you feel about invoking the `Keylet` constructor directly instead of using a generating function?


Oh, I see.  You're not removing the tests, you're just adding an additional test to one of them.


Does `touch()` need to be thread safe? I don't see any mutexes in `Ledger` that would indicate anything in it is thread safe.


Great catch!


For this specific application we aren't using the `CachedView` copy constructor at this time.  I recommend that if we use it in the future, we should be notified by the compiler, and decide at that time (with the motivating use case in hand) if we want a copy constructor.


@martinklepsch I used both libraries before: `endophile` for parsing markdown file and finding metadata from html comment (I think I used it 2 years ago just as hack).
`markdown-clj` was always used for converting markdown to html.
If you see some specific bugs with markdown parsing - post them here (it would be nice to have test use cases). I'll investigate using other library.


yeah so no need for unneeded underscores


>> Can we document why we explicitly ignore `EINTR`?

> Because the act of signal handling can cause `EINTR`, and also because it's standard practice.

I mean can we document this in the source code. That's not obvious to everyone who reads the code (e.g. me). 1232 does a similar thing and explains why we're special casing `EINTR`


Can we make default blank for this, so garbage value doesn't get saved


> You cannot be absolutely sure, that the repository is saved in a folder called mtheme.

That's true. I'll fix that tomorrow. Or the `zip` program :rage1:

> Another thought: I would propose we save the CTAN archives in a separate folder (ctan or downloads) and keep all the archives we distributed as a reference there.

You mean checking the archive into the repository? I don't think this is a good use case for Git. In any case, we can tag commits and push a release to the GitHub page. From that we can always re-create a CTAN archive for a given release.


```
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.000519
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.007221
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.002165
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001558
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.000771
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001724
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001014
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.013594
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.000968
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.013669
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001095
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.012579
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.002486
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001630
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001637
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.000758
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.003405
22:57:12 T:140628663068416  NOTICE: Time to measure GetDelay: 0.001328
```

Measured with: http://sprunge.us/iLUE <- Let's call this method A


HOLY!!!!


I actually don't remember making this change


Good catch. Thanks!

As to Moscai: what I would need to know is the task hierarchy that gets to the photocal task in whatever task loads the Mosaic.py config override file. For processCcd the information is "calibrate.photocal", which tells me to load colorterm data using "root.calibrate.photocal.colorterms.load(...)". I don't know the equivalent invocation for Mosaic.


Okay, good point. It's easy to get a little too granular. Short but correct then will be the goal for this section.


@robertmesserle - this is still causing me issues with md-list components. In 0.10.0 the you could use md-list-item with <span flex> children and layout in a simple table style. This no longer works when there is an ng-click on the md-list-item...

![screen shot 2015-06-17 at 21 59 46](https://cloud.githubusercontent.com/assets/1916471/8218666/4b9bb684-153c-11e5-9c37-e96029bde47c.png)


LGTM Thank you very much.


Bu senin buldugun icon degil miydi ? bende icon yoktu ayni isimde internetten arattim bu cikti karsima :D

Aynen problem oyle buyuk bir problem degil, dedigin gibi oynayanlarin sabit bir canvasta oynamalari gerekiyor.


Ah, I see you have written tests already. You are very good, taking my jow away, hh :)


I just moved it, but feel free to change in a subsequent PR. Suggested: `enum class FreezeHow`, `ignore`, and `zero`


I'm unsure what advantage a factory function would give, but am open to the idea.


You can introduce a constant here, that you can reuse here and on the other lines so you don't repeat yourself, and you give a name to this magic constant.


This probably could be done with the has_many relation, or scope. I'd prefer the first one :)


I think it's just `root.colorterms`.


rax retry tests


We'll need it in Payment.cpp after we solve the problem of `DeferredCredits` in the `View` interface


And our old code:
```
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.002724
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001042
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.012548
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001015
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.000991
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.003162
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001875
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.005343
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.002043
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.002526
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001342
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.022256
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.002033
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.014257
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001037
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.002850
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001051
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.000927
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.053592
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001424
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.006775
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001457
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.006321
23:02:22 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001207
23:02:23 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.002733
23:02:23 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001118
23:02:23 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.003103
23:02:23 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001406
23:02:23 T:140577671870208  NOTICE: Time to measure GetDelay (OLD): 0.001571
```
via: http://sprunge.us/OcHX


Missing 2.2 branch.


The issue is that the two existing should probably be combined into multiple test methods of a single unit test file. It would reduce boilerplate. But I think that is outside the scope of this ticket.


Ok.  Don't worry about this...I'll have to get it all sorted out on DM-2647 anyway!


Test is not created in the correct location:
```
$ yo turris:component testComponent
You called the Turris component subgenerator with the argument testComponent.
? Add header license? - no / yes (use LICENSE.md) / your file path: yes
   create src/components/testComponent/index.js
   create src/components/testComponent/template.jsx
   create src/components/testComponent/style.less
   create test/component-testComponent.jsx
 conflict test/index.jsx
? Overwrite test/index.jsx? (Ynaxdh)
```


Let's do all the imports at the beginning of the file. Also let's use the following pattern to define multiple variables in
a sequence.

```javascript
var mongoose    = require('mongoose')
    , userSchema = require('./schemas/user')
    , postSchema = require('./schemas/post');
```
You should use this pattern in all the source files.


Should be fixed in #4058.


missing `l` in `install`


Trivial nitpick: inconsistent line wrapping with similar `addTransaction` above.


Agreed.


Should we use a variant of ``ngettext`` here to handle the plural forms, i.e. "1 Team", "2 Teams"?


Do you understand what `Keylet` is for?


Ditto, but I do stand by the new test going in getRaw.py instead of getFlat.py.


Yep. :-)  It would be worth it even if it was 6 bigger, but it is nice that it's symmetric with speed and size.


For the record: root.colorterms is correct if the Mosaic task's config has a colorterms configurable field that is an instance of ColortermLibrary. If Mosaic is calling PhotoCalTask (perhaps indirectly) then the path will contain additional elements. In any case, I'll leave it to Lauren.


Can you make it "private" by prefixing it with a ``_``? I know it's not done on other parts of the code, but that should have been the case and I'd like new attributes not to be "exposed" outside.


How do I inject parent injector?


`test/component-testComponent.jsx`
that's not good? what'd you prefer?


ezeq@S3-debian:~/XML-JSON-XML$ diff test.xml fef.xml
ezeq@S3-debian:~/XML-JSON-XML$


ok


Currently playing around with `endophile`. Will report back how it goes. :)
For issues with `markdown-clj` check the projects issue tracker, I created 2 tickets there.


SYNTAX


ok, sounds good:)


CSS Appearance not supported by: IE (10,11), IE Mobile (10,11)


CSS Masks not supported by: IE (10,11), Firefox (37,38), Chrome (42,43), Safari (8,7.1), Opera (28,29), iOS Safari (8,8.1-8.3), IE Mobile (10,11)


What's ATN?


For the record,  "-D_GLIBCXX_DEBUG" seems to be the cause.


Yeah. I also added two comments, hoping that will help me and others to understand what's going on there , even in three months :).


> From that we can always re-create a CTAN archive for a given release.

Ok, I haven't thought about that it is really quite easy to recreate a CTAN archive.


Can you refactor this to a simpler/cleaner implementation using indexOf ?

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/String/indexOf


ahh, I should have looked closer.  I just looked at "conflict test/index.jsx" and assumed that was the file being written.


Looks like s/public/public static/


Thanks for the speedy fix!


C-casts are scary!  My first suggestion is to use `static_cast` instead.  However I think a better idea is to rename `succ (uint256 const& key, uint256 const& last) const` to some other name so that it is not hidden by the virtual `succ`, and therefore no cast at all will be necessary.


In summary: it does not matter at all - let's keep it as is ...


You may also want to check if the symlink is there that enables it: `/etc/systemd/system/multi-user.target.wants/chronos.service -> /usr/lib/systemd/system/chronos.service`


@cmelion it adds `require('newtest.jsx')` to the end of the script so that npm test will run all tests at once :)


SHAMaps are thread safe and the Ledger exposes those


`    colorterms = pexConfig.ConfigField(dtype=ColortermLibraryConfig, doc="Color term library")`


looks good! :+1:


This makes me think we should have a link here, but there is yet to be a "Video Quality" section of the "Account Setup" doc. Anyway, just a note for later.


You did not undo all of the changes in this file that were introduced in the previous commit against it in this PR.  Please capture these as well.


Can you refactor the logs to contain meaningful information?

e.g.

```javascript
logger.info('Reseting password for user id', user.id)
```


Timer 2 is the first one assigned, and is used both to (possibly) generate a tone, and also to time score waits, whether or not it is currently playing a note. See the code in the ISR for timer 2. We need to start it running by calling tune_playnote() at initialization. Note that tune_stopnote() will leave it running but sets "wait_timer_playing" false so that the ISR knows it isn't actually playing a note.


we could just move it to wednesday


In-line comment regarding network interface selection.


This is the actual fix. Everything else is just unit-testing


to be fair, that's not a bad point... but then again, there seems to be a huge debate about using roles in the first place..   ; )

i don't think it's a bad functionality to have, right?


I know we're doing away with SD, MD, and HD behind the scenes -- should we ditch it in the docs too? Maybe just put the aspect ratio of the videos here, ie 1920 x 3840 instead of "1920px wide HD". I think most peeps get confused by how we classify things with width.


CSS Appearance not supported by: IE (10,11), IE Mobile (10,11)


CSS Masks not supported by: IE (10,11), Firefox (37,38), Chrome (42,43), Safari (8,7.1), Opera (28,29), iOS Safari (8,8.1-8.3), IE Mobile (10,11)


Or maybe just simplify and make this a boolean variable?

generic_exceptions_as_test_failures = true/false


Note to self, this should break all the connections, not remove the node.


Some slight tweaks/suggestions, but looks good to me! :rocket: Thanks for doing this @mrdavidjcole


Hello my friend Nikos fix in ctcpxline that
$ModConfig: <ctcpxline pattern="mirc*" action="gline" duration="84600" reason="You version is blacklisted on this server.">
to
<ctcpxline pattern="*mirc*" action="KILL" duration="84600" reason="You version is blacklisted on this server.">


You are exposing our AWS keys in this commit, I've disabled them. Please generate new ones on AWS.


Apologies!


Concur @emilywistia! I went to look for the anchor on the Account Setup page while writing this :wink: .


Again, this is a NAK. The whole point of the sectionsparser is to be compatible with existing `gtk-doc` tooling. And I can say that, since I was the one who wrote it.


@dwaynebailey It is possible to deal with this automatically. But blindly deleting duplicates sounds a bit scary to me. If you just remove directories without any further check you might lose complete trees, and if not you still will ask for user manual intervention. So which option do you prefer:

1) Inform the user about the duplicated paths and halt the migration.
2) Delete the duplicate directories and just inform about that.


Great! I will do it in the morning and once you test and confirm I will do a new 4.0 release.


I see in jenkins log that https://ci.drtshock.net/plugin/repository/everything/ repo is causing conflict problems, change it to https://ci.drtshock.net/plugin/repository/everything/net/ess3/


Hello Nikos fix this <ctcpxline pattern="mirc*" to <ctcpxline pattern="*mirc*"


I'd like to see some testcases for this, especially with respect to CommonMark compliance.


Thanks @emilywistia! Agree there's a lot we can/should do to improve this page still. Gonna :ship: it for now since the scope of this little project was only intended to be tweaks to include the updated resolution info.


I believe freezegun closes #180, correct?


arguments should be on separate lines


There's a lot of extra horizontal indentation on these lines that doesn't need to be here


See follow-up commit: https://github.com/meteor/meteor/commit/29e33af748644bad08907f1135c7ce1938e3460c


We're inside a member function of `Application`, so calling `getApp()` here is at best redundant.


I think it would be better if AbstractTagHandler implemented both TagHandler and TagValidator, instead of making TagValidator extend TagHandler.  I think this would make this clearer.


Nope. Sections files are not XML. You can't do that.


OK, then I suggest falling back to `$(  )`:

```
mus re/tangletex ‹master*› » sh
$ for i in $(echo tangletex.*); do echo $i; done
tangletex.bib
tangletex.tex
$
```


ahh, excellent!


Actually, instead of using "generic", let's use "uncaught", which is the correct word in this case. We're not considering generic exceptions as ERRORs/FAILures, we're considering uncaught exceptions.

This applies to both the variable name and the documentation.


(づ｡◕‿‿◕｡)づ


@guybedford  on line 879 should dirname be splitting on path.sep for Windows users?


LGTM, submit upstream.


You picked up my conversion branch here, which has a change to Convertible in it on top of the decomposition changes. (I'm going to propose that Convertible require both implicit and explicit conversion with equivalent results, so that concepts like Boolean can get those semantics for free.)


Still not crazy about this. I understand saving ourselves a `fork()` if the `calloc` fails, but that's probably a moot point because if we can't allocate a few hundred bytes, we probably can't fork either. Plus, even if it succeeds, can't we just send the server error message to the child or let it time out on its own?

Splitting it up like this puts the burden on us of remembering to free `new_child` at every exit point and it looks like we're currently missing one in the 1488-1498 block.


Let's refactor the var definition using the pattern mentioned earlier.


Atualização simples: Apenas reiniciar.


Please do this with each commit that touches things so we don't break bisect.


Meh.


nice


typo - "If"


You should probably use self.r.now(). The "r" var is undefined.


Yes exactly, thanks I've added that.


Pushed this directly.


Published to http://ui.edev.d2l.com/77_c3a9b5131fc0a02df051028748b74768cf88e44b


Pushed this direcftly.


:eyes:


No cleanup, memoryleak.

Alternative:
int16_t evtType;
InBuffer->ReadInt16(&evtType);


о(ж＞▽＜)ｙ ☆


Ist jetzt in 0b986ca5520e6ae44df49c1179e622c1c8d4feab implementiert, die verwendeten Server stehen im Wiki.


Brant -

I will look into ANY and ALL with the query team. In general, you can't really going wrong at this point, since we can always change the internal implementation later for performance reasons.

As for execute scalar, it should probably map to SELECT [fields] FROM [bucket] LIMIT 1 I would think? It doesn't make sense retrieve the entire result set unless it supposed to be a non-deferred operation (works in memory). None the less, we can add optimizations such as caching much later after the core Linq to N1QL features are completed.

-Jeff


>>We're repeating this `ndtchild` cleanup code a lot. Can we have a `free_ndtchild` function that encapsulates this?

>Only twice, right? Once when we reap the dead, and once more if we can't enqueue the child.

I think it's 5 because it's the two you named + 2 currently in `spawn_child` + 1 that's missing in `spawn_child` resulting in wasted memory. Though I'm pushing for moving the `calloc` down in `spawn_child` which would reduce it down to 2, but I also think it's worthwhile to have a function because it makes it obvious to future developers how to free the child and we can also make it set the pointer to NULL to reduce the possibility of double-free/use-after-free bugs.


this is really cool!


LikeNewChance should be multiplied by (Like New / Wormholes) count. That way like news should run out at the same time as wormholes


Needs a test.


Hi dbongs,

It was nice to talk to you. I will share you the updates as soon as possible. Thanks.

Thanks & Regards
Vivekjyoti Pramanik


No space. And I'd just prefer to set next_section directly.

Should we also have a previous link?


Nice use of `.thru`!!


Note to self - check the comments in Falcon: https://github.com/falconry/falcon/issues/303


Still not a fan of this. I think we should just support the standard `GtkWidget<!-- -->s` syntax you see elsewhere.


Welcome back....:smile:
Yeah it'll be much more clearer, let me get on it.


Let's do HTTP 200 here.


Capitalization. Or if we're lowercasing `true` we need 1385 to be consistent.


Note to self: grab the FxA OAuth2 bearer token from the request here.


Somehow the class made it through to master without these exception classes.  Not sure when they were removed.


But using `os.walk` is cheating! Most of the languages have something similar/equivalent, for example Nim provides almost identical behaviour via its `walkDir` iterator (http://nim-lang.org/docs/os.html#walkDir.i,string), but there are also languages which do not, so I decided to code for a lowest common denominator. Which is, basically, this: http://www.gnu.org/software/libc/manual/html_node/Accessing-Directories.html - there's no way for any language to NOT have these, either already wrapped or trivially imported.

Still, Python is a cute language, and its evolution after around 3.3 is very impressive!


I just tried to do another 'gem install coloration' and it worked and I was able to run tm2vim with some success (it wasn't perfect but I only had to edit three of the HTML highlighting items)


fuck you I made this...


Fixed in commit [f487202d96463816fe995c0d5c4ae7d34bb30933](https://github.com/mcneel/developer-rhino3d-com/commit/f487202d96463816fe995c0d5c4ae7d34bb30933)


in this case, the '_' looks like a type...;-)


Oops. I've cancelled your travis build and mine. Do you want to pull the iterator.hpp changes into your branch, or shall I create a new one?


Oh sorry, that was stupid of me. I don't even know why we gitignore examples in the first place...


We probably want to leave feast as a string so we can use it in a faceted search. You can use copy fields to copy it to a dynamic text general field though.


I'll pull them.


Can you step through what changes you make here and why you did?  Honestly, I'm a scared to merge this in because it looks like it is a complete rewrite/redo of parsing HTML forms in a document, which is a pretty core part of the module.  I'm worried that parsing may start to fair for various edge cases in various end user forms.

I'm thinking you'd want to keep the existing stringToDocument method and continue to use it for all cases except within the HtmlFormValidator, and the create a new method (stringToDocumentWithLineAndColumnNumbers?)  for use within HtmlFormValidator... though that really isn't ideal, as now the validator would be using a different method to parse the form that the code that actually renders and processing the form.

Are the changes to stringToDocument only to allow reporting line and column numbers of errors?  Although this is a nice feature, I don't know if it is worth the instability it introduces.


Same with the other fields. Use a copy field to copy their values for case insensitive search but leave their field types as strings so we can use their actual values.


Comments included.


@matzew Just realized that since UPS only depends on the full profile, removing the jgroups subsystem should actually work (since jgroups is part of the ha profile). There are just a few more changes needed to remove clustering completely:

1. In the ejb3 subsystem configuration, change cache-ref="distributable" to cache-ref="simple", as shown here:
https://gist.github.com/fjuma/3df7f64fbaebd5506ef5#file-standalone-xml-L218

2. Replace the infinispan subsystem configuration with the configuration from here:
https://gist.github.com/fjuma/3df7f64fbaebd5506ef5/download#file-standalone-xml-L260-L293


will continue tomorrow. angular will help making this project cleaner


I fixed all the other occurrences


LikeNew is used way too fast for the 1:25 ratio now.


Yes its just to keep a reference alive


Some analysis tool is producing a warning


also name the bean after OpenEmpi (not just EMPI)


Should I be seeing 5 records here?


Let's create a module `config/index.js` that uses [nconf](https://github.com/indexzero/nconf) to load all the configuration parameters of the app from a json file.

`config/index.js`

// import nconf
// load the configuration file
// export nconf

Then in your code you can access the data as follows:

```javascript
var config = require('./config')

console.log(config.get('mailgun:apiKey'))
```


I don't know about that... for a while at least it wasn't considered cool to enforce users of a cookbook to use a specific encryption tech.

Also, the debate isn't that we shouldn't use roles (and attributes) in our own cookbooks, but that contributed cookbooks should define new resources.


"global" normally means ```/``` as namespace...
use ```ros::NodeHandle nh``` and ```ros::NodeHandle nh_private("~")```
```nh``` -> namespace ```/_ns_``` (where ```_ns_``` is equal to ```ns=``` in the launch file
```nh_private``` -> namespace ```/_ns_/_nodename_``` (where ```_nodename_``` is equal to ```name=``` in the launch file, i.e. ```cob_obstacle_distance```


@hodeyp - Please provide a CodePen that demonstrates this issue.
*  CodePen template: http://codepen.io/team/AngularMaterial/pen/BNNqWm