@guybedford Well I believe it's good for jspm since less files can be also used as static assets as well. Although I don't want to be only reason causing this change =) I was just curious.

Currently I'm using bower endpoint for jspm as a workaround since it's also including less files.

And btw this is how I'm working with gulp/systemjs and jspm. Will improve it soon maybe as a plugin.

```javascript
import gulp from 'gulp';
import LoadPlugins from 'gulp-load-plugins';
import runSequence from 'run-sequence';
import paths from '../paths';
import System from 'systemjs';
import LessPluginCleanCSS from 'less-plugin-clean-css';
import LessPluginAutoPrefix from 'less-plugin-autoprefix';
import lessInlineUrls from 'less-plugin-inline-urls';

//(...)

const plugins = new LoadPlugins();
const loader = Loader || System;
const vendorPaths = [];

gulp.task('loader-config', () => {
  return loader.import(`${paths.js}/config.js`);
});

gulp.task('vendor-paths', ['loader-config'], () => {
  let vendorPromises = [];
  Object.keys(loader.map).forEach(key => {
    let promise = new Promise((resolve, reject) => {
      loader.normalize(key)
        .then(path => {
          path = path
            .replace('file:\/\/', '')
            .replace('.js', '');
          vendorPaths.push(path);
          resolve(path);
        });
    });
    vendorPromises.push(promise);
  });

  return Promise.all(vendorPromises);
});

gulp.task('build-less', ['vendor-paths'], () => {
  let lessCleanCss = new LessPluginCleanCSS({
    advanced: true
  }),
  lessAutoPrefix = new LessPluginAutoPrefix({
    browsers: ["last 2 versions"]
  });

  return gulp.src(paths.source.less)
    .pipe(plugins.plumber())
    .pipe(plugins.changed(paths.output.less, {
      extension: '.less'
    }))
    .pipe(plugins.less({
      paths   : [
        paths.less,
        paths.vendor
      ].concat(vendorPaths),
      plugins : [ lessAutoPrefix, lessInlineUrls, lessCleanCss ]
    }))
    .pipe(plugins.sourcemaps.write({
      sourceRoot : paths.sourceMapRelativePath
    }))
    .pipe(plugins.plumber.stop())
    .pipe(gulp.dest(paths.output.less));
});
```


We can create ```allowable participants``` in ```application_controller.rb``` to return ```['Instructor',  'Teaching Assistant',  'Administrator',  'Super-Administrator',  'Student']```.


re


make sure commented out code is removed before it is merged to upstream


"Если вы не пользуетесь браузером Chrome, то скачайте его отсюда: http://www.google.com/chrome/. Хотя у браузера Firefox есть инструмент Firebug, который очень похож на Chrome DevTools, в этом задании мы будем использовать Chrome."


1: M111 unrecognized component name: elasticsearch


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: elasticsearch


1: M100 needs more reviewers
1: M101 signature is missing


60: D103 Missing docstring in public function
72: D103 Missing docstring in public function
83: D103 Missing docstring in public function
89: D103 Missing docstring in public function


42: D103 Missing docstring in public function
53: D103 Missing docstring in public function
59: D103 Missing docstring in public function


32: D103 Missing docstring in public function
43: D103 Missing docstring in public function
47: D103 Missing docstring in public function


Hi,

You can see the idea behind this in this talk:

https://indico.cern.ch/event/243940/session/0/material/slides/0?contribId=1

and more info on the changes here:

https://twiki.cern.ch/twiki/bin/viewauth/CMS/TrackerValidation

in TrackingRecHits and RecHits links.

Andreas

________________________________
From: ngrenz [notifications@github.com]
Sent: 24 June 2015 18:22
To: ngrenz/cmssw
Cc: Andreas Psallidas
Subject: Re: [cmssw] altered TrackerRecHits/SiStripRecHitsValid and RecoTrack/SiStripTrackingRecHitsValid to make them geometry generic (05b83bd)

@apsallid<https://github.com/apsallid> Hi unfortunately I could not find your mail address to contact you, so I try it through this comment.
Currently I'm working on this file, do you know what the original idea behind this FIXME was, I would then re-write the class.

Thanks

—
Reply to this email directly or view it on GitHub<https://github.com/ngrenz/cmssw/commit/05b83bd26126fb63d6aacdd1431310d7d0c1f649#commitcomment-11841170>.


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
23:1: I201 Missing newline before sections or imports.
28: D209 Multi-line docstring closing quotes should be on a separate line
28: D202 No blank lines allowed after function docstring (found 1)
37:5: B901 blind except: statement
38:9: F401 'pickle' imported but unused
83: D400 First line should end with a period (not 'y')
97: D103 Missing docstring in public function


30:1: I100 Imports statements are in the wrong order. from invenio.base.utils should be before import pkg_resources


52:1: I101 Imported names are in the wrong order. Should be current_app, jsonify, request
52:1: I100 Imports statements are in the wrong order. from flask should be before import requests
53:1: I201 Missing newline before sections or imports.
54:1: I201 Missing newline before sections or imports.
56:1: I100 Imports statements are in the wrong order. from invenio.utils.xmlhelpers should be before from lxml.etree


52:1: I100 Imports statements are in the wrong order. from urlparse should be before import requests
52:1: I201 Missing newline before sections or imports.
54:1: I101 Imported names are in the wrong order. Should be current_app, jsonify, request
55:1: I201 Missing newline before sections or imports.


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I201 Missing newline before sections or imports.
26: D203 1 blank line required before class docstring (found 0)


33:1: I201 Missing newline before sections or imports.
37:1: I100 Imports statements are in the wrong order. from urlparse should be before from sqlalchemy.event


4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: I100 Imports statements are in the wrong order. from datetime should be before from bagit
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be copydir, copyfile
32:1: I201 Missing newline before sections or imports.
34:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug.utils


4: L102 copyright year is outdated, expected 2015 but got 2014


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.orm.exc
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio_records.api should be before from invenio_records.models


4: L102 copyright year is outdated, expected 2015 but got 2014
22:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite


4: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
23:1: I101 Imported names are in the wrong order. Should be MultipleResultsFound, NoResultFound


1: D200 One-line docstring should fit on one line with quotes (found 3)
4: L102 copyright year is outdated, expected 2015 but got 2013
32: D203 1 blank line required before class docstring (found 0)
32: D204 1 blank line required after class docstring (found 0)
34: D102 Missing docstring in public method
38:17: E128 continuation line under-indented for visual indent
39:17: E128 continuation line under-indented for visual indent
41:17: E128 continuation line under-indented for visual indent
43:17: E128 continuation line under-indented for visual indent
45:17: E128 continuation line under-indented for visual indent
50:9: E128 continuation line under-indented for visual indent
52:9: E128 continuation line under-indented for visual indent
55:1: E302 expected 2 blank lines, found 1
55: D203 1 blank line required before class docstring (found 0)
55: D204 1 blank line required after class docstring (found 0)
57: D102 Missing docstring in public method
61:17: E128 continuation line under-indented for visual indent
62:17: E128 continuation line under-indented for visual indent
64:17: E128 continuation line under-indented for visual indent
66:17: E128 continuation line under-indented for visual indent
68:17: E128 continuation line under-indented for visual indent
70:17: E128 continuation line under-indented for visual indent
72:17: E128 continuation line under-indented for visual indent
75:1: E302 expected 2 blank lines, found 1
75: D203 1 blank line required before class docstring (found 0)
75: D204 1 blank line required after class docstring (found 0)
77: D102 Missing docstring in public method
81:17: E128 continuation line under-indented for visual indent
82:22: E128 continuation line under-indented for visual indent
84:17: E128 continuation line under-indented for visual indent
85:17: E128 continuation line under-indented for visual indent
87:17: E128 continuation line under-indented for visual indent
88:17: E128 continuation line under-indented for visual indent
93:17: E128 continuation line under-indented for visual indent
95:17: E128 continuation line under-indented for visual indent
97:17: E128 continuation line under-indented for visual indent
99:17: E128 continuation line under-indented for visual indent
101:17: E128 continuation line under-indented for visual indent
103:17: E128 continuation line under-indented for visual indent
103:31: E231 missing whitespace after ','
106: D203 1 blank line required before class docstring (found 0)
106: D204 1 blank line required after class docstring (found 0)
108: D102 Missing docstring in public method
112:17: E128 continuation line under-indented for visual indent
113:17: E128 continuation line under-indented for visual indent
115:17: E128 continuation line under-indented for visual indent
116:17: E126 continuation line over-indented for hanging indent
119:17: E128 continuation line under-indented for visual indent
120:17: E128 continuation line under-indented for visual indent
122:17: E128 continuation line under-indented for visual indent
123:17: E128 continuation line under-indented for visual indent
125:17: E128 continuation line under-indented for visual indent
126:17: E128 continuation line under-indented for visual indent
128:17: E128 continuation line under-indented for visual indent
129:17: E128 continuation line under-indented for visual indent
131:17: E128 continuation line under-indented for visual indent
133:17: E128 continuation line under-indented for visual indent
135:17: E128 continuation line under-indented for visual indent
137:17: E128 continuation line under-indented for visual indent
139:17: E128 continuation line under-indented for visual indent
141:17: E128 continuation line under-indented for visual indent
143:17: E128 continuation line under-indented for visual indent
145:17: E128 continuation line under-indented for visual indent
150:17: E128 continuation line under-indented for visual indent
161: D203 1 blank line required before class docstring (found 0)
161: D204 1 blank line required after class docstring (found 0)
163: D102 Missing docstring in public method
167:17: E128 continuation line under-indented for visual indent
168:17: E128 continuation line under-indented for visual indent
170:17: E128 continuation line under-indented for visual indent
172:17: E128 continuation line under-indented for visual indent
173:17: E128 continuation line under-indented for visual indent
175:17: E128 continuation line under-indented for visual indent
177:9: E128 continuation line under-indented for visual indent
180:17: E128 continuation line under-indented for visual indent
182:17: E128 continuation line under-indented for visual indent
184:17: E128 continuation line under-indented for visual indent
186:17: E128 continuation line under-indented for visual indent
187:17: E128 continuation line under-indented for visual indent
189:17: E128 continuation line under-indented for visual indent
191:17: E128 continuation line under-indented for visual indent
197:1: E302 expected 2 blank lines, found 1
197: D203 1 blank line required before class docstring (found 0)
197: D204 1 blank line required after class docstring (found 0)
199: D102 Missing docstring in public method
203:17: E128 continuation line under-indented for visual indent
204:17: E128 continuation line under-indented for visual indent
206:17: E128 continuation line under-indented for visual indent
208:17: E128 continuation line under-indented for visual indent
209:17: E128 continuation line under-indented for visual indent
211:17: E128 continuation line under-indented for visual indent
213:17: E128 continuation line under-indented for visual indent
214:17: E128 continuation line under-indented for visual indent
216:17: E128 continuation line under-indented for visual indent
217:17: E128 continuation line under-indented for visual indent
219:17: E128 continuation line under-indented for visual indent
222:17: E128 continuation line under-indented for visual indent
227:1: E302 expected 2 blank lines, found 1
227: D203 1 blank line required before class docstring (found 0)
227: D204 1 blank line required after class docstring (found 0)
229: D102 Missing docstring in public method
233:17: E128 continuation line under-indented for visual indent
234:17: E128 continuation line under-indented for visual indent
236:17: E128 continuation line under-indented for visual indent
238:17: E128 continuation line under-indented for visual indent
240:17: E128 continuation line under-indented for visual indent
242:17: E128 continuation line under-indented for visual indent
245:1: E302 expected 2 blank lines, found 1
245: D203 1 blank line required before class docstring (found 0)
245: D204 1 blank line required after class docstring (found 0)
247: D102 Missing docstring in public method
251:17: E128 continuation line under-indented for visual indent
252:17: E128 continuation line under-indented for visual indent
254:17: E128 continuation line under-indented for visual indent
255:17: E128 continuation line under-indented for visual indent
257:17: E128 continuation line under-indented for visual indent
259:17: E128 continuation line under-indented for visual indent
261:17: E128 continuation line under-indented for visual indent
263:17: E128 continuation line under-indented for visual indent
265:17: E128 continuation line under-indented for visual indent


1: D100 Missing docstring in public module
27: D103 Missing docstring in public function


24:1: F401 'intbitset' imported but unused
25:1: I201 Missing newline before sections or imports.
25:1: F401 'cached_property' imported but unused
27:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug
75: D101 Missing docstring in public class
76: D102 Missing docstring in public method
103: D103 Missing docstring in public function
121: D203 1 blank line required before class docstring (found 0)
121: D204 1 blank line required after class docstring (found 0)
121: D400 First line should end with a period (not 'e')
121: D205 1 blank line required between summary line and description (found 0)
126: D102 Missing docstring in public method


23:1: I100 Imports statements are in the wrong order. from invenio.modules.search.api should be before from invenio_records.signals
23:1: I201 Missing newline before sections or imports.
44:32: E711 comparison to None should be 'if cond is not None:'
67: D103 Missing docstring in public function


26:1: I201 Missing newline before sections or imports.


23:1: I100 Imports statements are in the wrong order. import socket should be before from datetime
25:1: I101 Imported names are in the wrong order. Should be Blueprint, abort, current_app, flash, g, redirect, render_template, request, url_for
29:1: I201 Missing newline before sections or imports.
30:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from invenio.base.decorators should be before from invenio.base.i18n
42:1: I100 Imports statements are in the wrong order. from invenio.utils.mail should be before from invenio_records.views
45:1: I101 Imported names are in the wrong order. Should be CmtACTIONHISTORY, CmtRECORDCOMMENT, CmtSUBSCRIPTION
54: D103 Missing docstring in public function
67: D101 Missing docstring in public class
69: D102 Missing docstring in public method
74: D102 Missing docstring in public method
78: D102 Missing docstring in public method
92: D102 Missing docstring in public method
101: D102 Missing docstring in public method
108: D102 Missing docstring in public method
121: D103 Missing docstring in public function
155:9: B901 blind except: statement
166: D103 Missing docstring in public function
180:9: B901 blind except: statement
255: D103 Missing docstring in public function
274: D103 Missing docstring in public function
294: D103 Missing docstring in public function
316: D103 Missing docstring in public function
324:5: B901 blind except: statement
332: D103 Missing docstring in public function
346:5: B901 blind except: statement
360: D103 Missing docstring in public function


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. from invenio_records.api should be before import six
24:1: I201 Missing newline before sections or imports.
27: D400 First line should end with a period (not 't')
27: D200 One-line docstring should fit on one line with quotes (found 3)
52: D400 First line should end with a period (not 's')
52: D200 One-line docstring should fit on one line with quotes (found 3)
64: D200 One-line docstring should fit on one line with quotes (found 3)
83: D400 First line should end with a period (not 's')
83: D200 One-line docstring should fit on one line with quotes (found 3)


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
22:1: I100 Imports statements are in the wrong order. from invenio.utils.datacite should be before from werkzeug
22:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.utils should be before from invenio_records.api
25:1: I201 Missing newline before sections or imports.
58: D102 Missing docstring in public method
61: D102 Missing docstring in public method
74: D102 Missing docstring in public method
78: D102 Missing docstring in public method
110: D102 Missing docstring in public method
122: D102 Missing docstring in public method
148: D103 Missing docstring in public function
177: D103 Missing docstring in public function
245: D103 Missing docstring in public function
280: D103 Missing docstring in public function


25:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. import dateutil.parser should be before import dictdiffer
26:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from tempfile should be before import dateutil.parser
29:1: I100 Imports statements are in the wrong order. from functools should be before from tempfile
30:1: I101 Imported names are in the wrong order. Should be abort, current_app, request
30:1: I201 Missing newline before sections or imports.
31:1: I201 Missing newline before sections or imports.
32:1: I100 Imports statements are in the wrong order. from functools should be before from flask_login
32:1: I201 Missing newline before sections or imports.
35:1: I100 Imports statements are in the wrong order. from invenio.modules.editor.models should be before from invenio_records.api
35:1: I201 Missing newline before sections or imports.
36:1: I101 Imported names are in the wrong order. Should be Agent, Deposition, DepositionDraftCacheManager
36:1: I100 Imports statements are in the wrong order. from invenio.modules.deposit.models should be before from invenio.modules.editor.models
38:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.deposit.models
41:1: I101 Imported names are in the wrong order. Should be deposition_record, make_record, record_to_draft
41:1: I201 Missing newline before sections or imports.
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from .helpers


28:1: I201 Missing newline before sections or imports.


1: D400 First line should end with a period (not 'e')
4: L102 copyright year is outdated, expected 2015 but got 2011
23:1: I100 Imports statements are in the wrong order. from pprint should be before from string
24:1: I100 Imports statements are in the wrong order. import os should be before from pprint
29:1: I101 Imported names are in the wrong order. Should be task_low_level_submission, task_update_progress, write_message
30:30: E126 continuation line over-indented for hanging indent
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.bibsched.bibtask
35:1: I101 Imported names are in the wrong order. Should be assure_quality, encode_video
38:41: E126 continuation line over-indented for hanging indent
42:1: I100 Imports statements are in the wrong order. from invenio.modules.encoder.metadata should be before from invenio.modules.encoder.utils
43:41: E126 continuation line over-indented for hanging indent
45:1: I101 Imported names are in the wrong order. Should be chose2, generate_timestamp, getval
45:1: F999 redefinition of unused 'chose2' from line 41
46:1: I101 Imported names are in the wrong order. Should be CFG_BIBENCODE_ASPECT_RATIO_MARC_FIELD, CFG_BIBENCODE_DAEMON_DIR_NEWJOBS, CFG_BIBENCODE_PBCORE_MARC_XSLT
46:1: I100 Imports statements are in the wrong order. from invenio.modules.encoder.config should be before from invenio.modules.encoder.utils
47:39: E126 continuation line over-indented for hanging indent
51:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.modules.encoder.config
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.ext.email
56:1: I100 Imports statements are in the wrong order. import invenio.config should be before from invenio.utils.json
66:1: E302 expected 2 blank lines, found 1
66: D401 First line should be in imperative mood ('Send', not 'Sends')
66: D400 First line should end with a period (not 'g')
66: D205 1 blank line required between summary line and description (found 0)
77:13: E128 continuation line under-indented for visual indent
78:13: E128 continuation line under-indented for visual indent
79:13: E128 continuation line under-indented for visual indent
80:13: E128 continuation line under-indented for visual indent
81:13: E128 continuation line under-indented for visual indent
83:14: E128 continuation line under-indented for visual indent
91:1: E302 expected 2 blank lines, found 1
91: D401 First line should be in imperative mood ('Send', not 'Sends')
91: D205 1 blank line required between summary line and description (found 0)
109:13: E128 continuation line under-indented for visual indent
110:13: E128 continuation line under-indented for visual indent
119:13: E128 continuation line under-indented for visual indent
120:13: E128 continuation line under-indented for visual indent
122:14: E128 continuation line under-indented for visual indent
123:14: E128 continuation line under-indented for visual indent
124:14: E128 continuation line under-indented for visual indent
127:14: E128 continuation line under-indented for visual indent
128:14: E128 continuation line under-indented for visual indent
129:14: E128 continuation line under-indented for visual indent
137:1: E302 expected 2 blank lines, found 1
137: D401 First line should be in imperative mood ('Send', not 'Sends')
137: D205 1 blank line required between summary line and description (found 0)
153:13: E128 continuation line under-indented for visual indent
154:13: E126 continuation line over-indented for hanging indent
160:13: E128 continuation line under-indented for visual indent
161:13: E128 continuation line under-indented for visual indent
163:14: E128 continuation line under-indented for visual indent
164:14: E128 continuation line under-indented for visual indent
165:14: E128 continuation line under-indented for visual indent
168:14: E128 continuation line under-indented for visual indent
169:14: E128 continuation line under-indented for visual indent
170:14: E128 continuation line under-indented for visual indent
178:1: E302 expected 2 blank lines, found 1
178: D210 No whitespaces allowed surrounding docstring text
178: D401 First line should be in imperative mood ('Generate', not 'Generates')
178: D205 1 blank line required between summary line and description (found 0)
178: D208 Docstring is over-indented
189:1: E302 expected 2 blank lines, found 1
189: D210 No whitespaces allowed surrounding docstring text
189: D401 First line should be in imperative mood ('Store', not 'Stores')
189: D400 First line should end with a period (not 's')
189: D205 1 blank line required between summary line and description (found 0)
189: D208 Docstring is over-indented
198:1: E302 expected 2 blank lines, found 1
198: D401 First line should be in imperative mood ('Remove', not 'Removes')
198: D400 First line should end with a period (not 'r')
198: D205 1 blank line required between summary line and description (found 0)
222:25: E128 continuation line under-indented for visual indent
223:25: E128 continuation line under-indented for visual indent
224:25: E128 continuation line under-indented for visual indent
225:25: E128 continuation line under-indented for visual indent
239:1: E302 expected 2 blank lines, found 1
239: D210 No whitespaces allowed surrounding docstring text
239: D401 First line should be in imperative mood ('Create', not 'Creates')
239: D400 First line should end with a period (not 'n')
239: D205 1 blank line required between summary line and description (found 0)
240:29: E126 continuation line over-indented for hanging indent
256:1: E302 expected 2 blank lines, found 1
256: D210 No whitespaces allowed surrounding docstring text
256: D401 First line should be in imperative mood ('Create', not 'Creates')
256: D400 First line should end with a period (not 'a')
256: D205 1 blank line required between summary line and description (found 0)
274:1: E302 expected 2 blank lines, found 1
274: D210 No whitespaces allowed surrounding docstring text
274: D401 First line should be in imperative mood ('Create', not 'Creates')
274: D400 First line should end with a period (not 's')
274: D205 1 blank line required between summary line and description (found 0)
297:1: E302 expected 2 blank lines, found 1
297: D210 No whitespaces allowed surrounding docstring text
297: D401 First line should be in imperative mood ('Create', not 'Creates')
297: D400 First line should end with a period (not 'y')
297: D205 1 blank line required between summary line and description (found 0)
298:21: E126 continuation line over-indented for hanging indent
320:1: E302 expected 2 blank lines, found 1
320: D210 No whitespaces allowed surrounding docstring text
320: D401 First line should be in imperative mood ('Check', not 'Checks')
320: D400 First line should end with a period (not 'y')
320: D205 1 blank line required between summary line and description (found 0)
326: D210 No whitespaces allowed surrounding docstring text
326: D401 First line should be in imperative mood ('Sanitize', not 'Sanitizes')
326: D400 First line should end with a period (not 's')
326: D200 One-line docstring should fit on one line with quotes (found 2)
355:5: E129 visually indented line with same indent as next logical line
357:21: E128 continuation line under-indented for visual indent
373:1: E302 expected 2 blank lines, found 1
373: D210 No whitespaces allowed surrounding docstring text
373: D401 First line should be in imperative mood ('Processe', not 'Processes')
373: D400 First line should end with a period (not 'y')
383: D210 No whitespaces allowed surrounding docstring text
383: D401 First line should be in imperative mood ('Create', not 'Creates')
383: D400 First line should end with a period (not 'd')
383: D200 One-line docstring should fit on one line with quotes (found 2)
386:36: E225 missing whitespace around operator
400:5: E266 too many leading '#' for block comment
403:5: E266 too many leading '#' for block comment
406:5: E266 too many leading '#' for block comment
416:5: E266 too many leading '#' for block comment
431:21: E129 visually indented line with same indent as next logical line
434:21: E266 too many leading '#' for block comment
436:25: E266 too many leading '#' for block comment
437:47: F821 undefined name 'get_fieldvalues'
445:27: E128 continuation line under-indented for visual indent
448:13: E266 too many leading '#' for block comment
451:5: E266 too many leading '#' for block comment
458:5: E266 too many leading '#' for block comment
466:5: E266 too many leading '#' for block comment
469:5: E266 too many leading '#' for block comment
473:5: E266 too many leading '#' for block comment
481:13: E266 too many leading '#' for block comment
482:13: E266 too many leading '#' for block comment
483:13: E266 too many leading '#' for block comment
484:13: E266 too many leading '#' for block comment
486:27: E128 continuation line under-indented for visual indent
488:37: E126 continuation line over-indented for hanging indent
491:13: E266 too many leading '#' for block comment
492:13: E266 too many leading '#' for block comment
496:21: E126 continuation line over-indented for hanging indent
513:28: E128 continuation line under-indented for visual indent
515:9: E266 too many leading '#' for block comment
525:13: E266 too many leading '#' for block comment
533:13: E266 too many leading '#' for block comment
538:13: E266 too many leading '#' for block comment
541:13: E266 too many leading '#' for block comment
542:13: E266 too many leading '#' for block comment
544:50: E126 continuation line over-indented for hanging indent
551:13: E266 too many leading '#' for block comment
553:18: E126 continuation line over-indented for hanging indent
567:53: E261 at least two spaces before inline comment
573:13: E266 too many leading '#' for block comment
574:15: E271 multiple spaces after keyword
575:17: E266 too many leading '#' for block comment
590:47: E127 continuation line over-indented for visual indent
616:25: W503 line break before binary operator
617:25: E128 continuation line under-indented for visual indent
619:28: E128 continuation line under-indented for visual indent
620:28: E128 continuation line under-indented for visual indent
621:28: E126 continuation line over-indented for hanging indent
631:13: E266 too many leading '#' for block comment
633:17: E266 too many leading '#' for block comment
634:17: E266 too many leading '#' for block comment
637:21: E266 too many leading '#' for block comment
638:21: E266 too many leading '#' for block comment
641:21: E266 too many leading '#' for block comment
644:21: E266 too many leading '#' for block comment
648:21: E266 too many leading '#' for block comment
652:21: E266 too many leading '#' for block comment
653:21: E266 too many leading '#' for block comment
657:35: E128 continuation line under-indented for visual indent
660:37: E126 continuation line over-indented for hanging indent
665:13: E266 too many leading '#' for block comment
677:5: E266 too many leading '#' for block comment
681:5: E266 too many leading '#' for block comment
686:9: E266 too many leading '#' for block comment
699:44: E251 unexpected spaces around keyword / parameter equals
699:46: E251 unexpected spaces around keyword / parameter equals
700:50: E251 unexpected spaces around keyword / parameter equals
700:52: E251 unexpected spaces around keyword / parameter equals
701:49: E251 unexpected spaces around keyword / parameter equals
701:51: E251 unexpected spaces around keyword / parameter equals
734:5: E266 too many leading '#' for block comment
744:55: E721 do not compare types, use 'isinstance()'
744:69: E202 whitespace before ')'
754:32: E128 continuation line under-indented for visual indent
755:32: E128 continuation line under-indented for visual indent
756:32: E128 continuation line under-indented for visual indent
758:1: W391 blank line at end of file


26:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.exc
26:1: F401 'db' imported but unused
27:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from invenio.modules.search.models should be before from invenio_records.models
28:1: I201 Missing newline before sections or imports.
35: D401 First line should be in imperative mood ('Return', not 'Returns')
52: D401 First line should be in imperative mood ('Return', not 'Returns')
70: D401 First line should be in imperative mood ('Return', not 'Returns')
70: D400 First line should end with a period (not 'e')
84: D401 First line should be in imperative mood ('Return', not 'Returns')
84: D400 First line should end with a period (not ',')
84: D205 1 blank line required between summary line and description (found 0)
101: D401 First line should be in imperative mood ('Return', not 'Returns')
111: D401 First line should be in imperative mood ('Return', not 'Returns')
111: D400 First line should end with a period (not 'e')
125: D401 First line should be in imperative mood ('Return', not 'Returns')
154: D401 First line should be in imperative mood ('Return', not 'Returns')
169: D401 First line should be in imperative mood ('Return', not 'Returns')
183: D401 First line should be in imperative mood ('Return', not 'Returns')
183: D400 First line should end with a period (not 'e')
195: D401 First line should be in imperative mood ('Return', not 'Returns')
195: D400 First line should end with a period (not 'e')
212: D401 First line should be in imperative mood ('Return', not 'Returns')
212: D400 First line should end with a period (not 'e')
224: D401 First line should be in imperative mood ('Return', not 'Returns')
224: D400 First line should end with a period (not "'")
249: D401 First line should be in imperative mood ('Return', not 'Returns')
249: D400 First line should end with a period (not 'd')
249: D205 1 blank line required between summary line and description (found 0)


47:1: I201 Missing newline before sections or imports.
49:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug.utils
52:1: F401 'CFG_BIBFORMAT_CACHED_FORMATS' imported but unused
52:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
52:1: F401 'CFG_BIBFORMAT_DISABLE_I18N_FOR_CACHED_FORMATS' imported but unused
57:1: F401 'record_empty' imported but unused
68:1: F401 'CFG_BIBFORMAT_OUTPUTS_PATH' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_TEMPLATE_EXTENSION' imported but unused
68:1: F401 'CFG_BIBFORMAT_TEMPLATES_DIR' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_OUTPUT_EXTENSION' imported but unused
78:27: E261 at least two spaces before inline comment
79:28: E114 indentation is not a multiple of four (comment)
79:28: E116 unexpected indentation (comment)
80:28: E114 indentation is not a multiple of four (comment)
80:28: E116 unexpected indentation (comment)
81:28: E114 indentation is not a multiple of four (comment)
81:28: E116 unexpected indentation (comment)
84:28: E114 indentation is not a multiple of four (comment)
84:28: E116 unexpected indentation (comment)
98:33: E225 missing whitespace around operator
183:1: E731 do not assign a lambda expression, use a def
186: D203 1 blank line required before class docstring (found 0)
190: D401 First line should be in imperative mood ('Return', not 'Returns')
190: D400 First line should end with a period (not 's')
204: D401 First line should be in imperative mood ('Format', not 'Formats')
204: D400 First line should end with a period (not 'f')
204: D205 1 blank line required between summary line and description (found 0)
263:8: W503 line break before binary operator
267:41: F841 local variable 'exc' is assigned to but never used
342:82: E225 missing whitespace around operator
353: D401 First line should be in imperative mood ('Return', not 'Returns')
353: D202 No blank lines allowed after function docstring (found 1)
353: D400 First line should end with a period (not 'g')
353: D205 1 blank line required between summary line and description (found 0)
374:64: E261 at least two spaces before inline comment
374:65: E262 inline comment should start with '# '
381:38: E261 at least two spaces before inline comment
381:39: E262 inline comment should start with '# '
382:48: E261 at least two spaces before inline comment
382:49: E262 inline comment should start with '# '
385:24: E127 continuation line over-indented for visual indent
394: D103 Missing docstring in public function
397: D400 First line should end with a period (not 's')
397: D200 One-line docstring should fit on one line with quotes (found 3)
410: D210 No whitespaces allowed surrounding docstring text
410: D400 First line should end with a period (not 'a')
410: D205 1 blank line required between summary line and description (found 0)
495: D401 First line should be in imperative mood ('Filter', not 'Filters')
505: D401 First line should be in imperative mood ('Searche', not 'Searches')
505: D400 First line should end with a period (not 's')
505: D205 1 blank line required between summary line and description (found 0)
531:9: E303 too many blank lines (2)
545:5: E303 too many blank lines (2)
549: D401 First line should be in imperative mood ('Return', not 'Returns')
589:28: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
603:1: E302 expected 2 blank lines, found 1
603: D203 1 blank line required before class docstring (found 0)
603: D204 1 blank line required after class docstring (found 0)
603: D400 First line should end with a period (not 'n')
603: D205 1 blank line required between summary line and description (found 0)
634:15: E261 at least two spaces before inline comment
636: D401 First line should be in imperative mood ('Create', not 'Creates')
668:31: E261 at least two spaces before inline comment
693: D401 First line should be in imperative mood ('Return', not 'Returns')
693: D400 First line should end with a period (not 'e')
708: D401 First line should be in imperative mood ('Return', not 'Returns')
708: D400 First line should end with a period (not 'd')
731: D401 First line should be in imperative mood ('Return', not 'Returns')
731: D400 First line should end with a period (not 'e')
731: D205 1 blank line required between summary line and description (found 0)
769: D401 First line should be in imperative mood ('Return', not 'Returns')
769: D202 No blank lines allowed after function docstring (found 1)
878:36: E127 continuation line over-indented for visual indent
881: D401 First line should be in imperative mood ('Return', not 'Returns')
938:33: E127 continuation line over-indented for visual indent
949:60: E251 unexpected spaces around keyword / parameter equals
951:54: E251 unexpected spaces around keyword / parameter equals
961:37: E127 continuation line over-indented for visual indent
972:64: E251 unexpected spaces around keyword / parameter equals
974:58: E251 unexpected spaces around keyword / parameter equals


23:1: I201 Missing newline before sections or imports.
26: D203 1 blank line required before class docstring (found 0)


3: L102 copyright year is outdated, expected 2015 but got 2014


37: D103 Missing docstring in public function
47:13: E121 continuation line under-indented for hanging indent


22:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
24:1: I101 Imported names are in the wrong order. Should be clean_field_model_definitions, field_definitions, model_definitions


25:1: E402 module level import not at top of file
26:1: I101 Imported names are in the wrong order. Should be ImportPathRegistry, PkgResourcesDirDiscoveryRegistry, RegistryProxy
26:1: I100 Imports statements are in the wrong order. from flask_registry should be before from invenio.base.wrappers
26:1: I201 Missing newline before sections or imports.
26:1: E402 module level import not at top of file
28:1: E402 module level import not at top of file
29:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
29:1: E402 module level import not at top of file
43:1: E731 do not assign a lambda expression, use a def
45:1: E731 do not assign a lambda expression, use a def
47:1: E731 do not assign a lambda expression, use a def


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio.modules.scheduler.models should be before from invenio_records.models
27:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
427:25: E711 comparison to None should be 'if cond is None:'


1: D400 First line should end with a period (not 'r')
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
28:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.exc
29:1: I201 Missing newline before sections or imports.
31:1: I100 Imports statements are in the wrong order. from invenio.modules.pidstore.provider should be before from invenio_records.models
34: D210 No whitespaces allowed surrounding docstring text
34: D203 1 blank line required before class docstring (found 0)
34: D400 First line should end with a period (not 's')
39: D401 First line should be in imperative mood ('Create', not 'Creates')
58: D102 Missing docstring in public method
63: D200 One-line docstring should fit on one line with quotes (found 3)


1: D100 Missing docstring in public module


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: I201 Missing newline before sections or imports.
38: D200 One-line docstring should fit on one line with quotes (found 3)
64: D400 First line should end with a period (not 'e')
131: D400 First line should end with a period (not 'e')
171: D400 First line should end with a period (not 'n')


:+1:  May as well cherry-pick this to `master` now.  No need for it to wait.


Изменил пару слов в начале и в конце: "Обратите внимание что этот курс, результат совместного производства Google и Code School, технологически впечатляет но иногда глючит. Если вы столкнулись с багом, проигнорируйте его и проходите курс дальше.",


These regular expression matches look brittle e.g. what would happen if someone chose to use parentheses: `content_for(:body)`...?


My version... forgot to give the instructions to merge the modified package...


Continuing this issue in #226


good to go


Hey, @JohnMcLear , I know that it's been a while since you've committed this change, but I'm wondering if you had to do this fix to be able to find opendislexyc when `minify: true` on `settings.json`.

The reason I'm asking is because on `ep_comments_page` the font icons are not being correctly displayed when minify is on (I get a 404 when trying to get `http://192.168.50.5:9001/font/fontawesome-etherpad.woff`, as the file is at `http://192.168.50.5:9001/static/font/fontawesome-etherpad.woff `), and by doing the same fix for `fontawesome-etherpad` the error is gone and icons are shown.

As I'm not a CSS expert, I don't know the other possible impacts it could have to make this change. I tested both with minify on and off, and all font icons are correctly displayed (the ones from Etherpad, the ones form plugins), both on the editor and the timeslider.

Is there anything else I should test for?


what happened to this commit? why didn't you send a PR?


Thanks bro :beers:


edit: the code actually will take input, but only use the numbers 1, 2 ,3, 4, 5, and 6 no matter what the input is


So what you are saying is:
 - Fix typo
 - Separate the additions from deletions
 - Reconsider the ratio between the bonecard dimensions.

right? and should I do that using rebase & edit?


@jtdowney great, thanks for the info.


I think the following would be more idiomatic:
```ruby
@additional_files_path.select(&:exist?).map(&:realpath)
```


@bturner thanks SO much for this!  I'm testing this out now but I think you've found my problem.  Additionally, you are spot on about needing to audit my dependencies.  Perhaps a guide for dependencies that makes it more clear how to determine what stash can provide, and what scope things should have, would improve the plugin dev documentation?  (or maybe such a thing exists and I've missed it)

Anyways, I am testing now and expect your suggestion will make things work.


@tchap I thought you wanted to mark it as implemented, not reviewed.


Are you consciously using `assert_equal false, foo` rather than `refute foo`?


```
  1) test no output (ExUnit.CaptureLogTest)
     test/ex_unit/capture_log_test.exs:15
     ** (exit) exited in: GenServer.call(ExUnit.Server, {:log_capture_on, #PID<0.560.0>, {#PID<0.561.0>, []}}, 5000)
         ** (EXIT) exited in: ExUnit.Server.log_capture_on()
             ** (EXIT) an exception was raised:
                 ** (Protocol.UndefinedError) protocol String.Chars not implemented for {}
                     (elixir) lib/string/chars.ex:3: String.Chars.impl_for!/1
                     (elixir) lib/string/chars.ex:17: String.Chars.to_string/1
                     (logger) lib/logger/formatter.ex:107: anonymous fn/1 in Logger.Formatter.output/5
                     (elixir) lib/enum.ex:1043: anonymous fn/3 in Enum.map/2
                     (elixir) lib/enum.ex:1385: Enum."-reduce/3-lists^foldl/2-0-"/3
                     (elixir) lib/enum.ex:1043: Enum.map/2
                     (logger) lib/logger/formatter.ex:94: anonymous fn/6 in Logger.Formatter.format/5
                     (elixir) lib/enum.ex:1385: Enum."-reduce/3-lists^foldl/2-0-"/3
     stacktrace:
       (elixir) lib/gen_server.ex:365: GenServer.call/3
       (ex_unit) lib/ex_unit/capture_log.ex:75: ExUnit.CaptureLog.capture_log/2
       test/ex_unit/capture_log_test.exs:16

```


dammit you are right. I've thought it were "recieved", because that made most sense.


Is there any Java example to ignore itÉ
Thanks advance


are you


This same hunk is in my own branch as well, but it continues to seem strange to me.  Shouldn't we be requiring *all* the signatures be valid, not just one?  Wondering if we should split this into a small util function somewhere so we have a central place for our signature validation policy.


This function is too long to read. Please move the embedded switch statements into other functions. Thanks.


:+1: when?


All right, I approve the change. Can you edit that issue for me?


What does the `bin` array do, exactly?


Hey Vlad,

Regarding your question on specific exceptions, I have a list containing
all the types of errors that have occurred for each section:UnZipping,
UnTarGZipping, and problems with reading the setup.py file.

 For x is not none, the function can also return empty string, so it may
not be appropriate(unless none and empty string are the same).

For the file, I didn't know that open() was preferred so I will probably
change it.

I will work on adding the header block and correct the indentations.

On Tue, Jun 23, 2015 at 10:55 AM, Bing Xu <bing4130@gmail.com> wrote:

> Hey Vlad,
>
> Do we have meeting today ?
> On Jun 23, 2015 10:19 AM, "Vladimir Diaz" <notifications@github.com>
> wrote:
>
>> Should we check for more specific exceptions (e.g., IOError)?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/BingCanXu/Python-Dependency-Resolution/commit/c3fd6cd04a00e77f1e63082ebed35fa65052992e#commitcomment-11817446>
>> .
>>
>


I don't agree with removing this. I don't see the problem with it? Just because not many other projects use it? It's a convenience if you want to link to libwebsockets from another Cmake project. The config makes it easy for CMake to find the lib without some special find script.


Remember to update `doc/ostree-sections.txt` as well.


@mbernat Yeah, this is wrong, but it's already fixed, somewhere :-)


Ah… anything that is used outside the actual application, like a build/deploy script. Nothing in here would get `include`d by PHP, presumably, but might be run from the command line, etc.


@mbernat Good catch, though :+1:


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/7595/testReport/) for this commit**


@dcs619 oops, thanks for letting me know.  Fixed now :)


I wonder if it would help to introduce two new helper methods: `#content_for_title` and `#content_for_body`...


Minor, but could just use `else` here.


Looks good to me, though I guess we've lost the `-w` in places.


Apologies! I was in the midst of exploring moving transforms to their own
sub-module and so removed the dependency on the logging module. However due
to a couple important dependencies (the expression parser for Formula &
Filter, and the transform parser for Facet) it seems better to keep
transforms in Vega core for the time being.

Feel free to reintroduce the debugging statements if useful. I thought the
code might be mature and well-tested enough at this point to start taking
down some of that scaffolding.

On Wed, Jun 24, 2015 at 8:15 AM, Arvind Satyanarayan <
notifications@github.com> wrote:

> @jheer <https://github.com/jheer>, why have all the log.debug statements
> been removed? Those have been crucial for debugging, so far.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/uwdata/vega/commit/9f8e9e0971bd697ed031095b782985d01ca885bd#commitcomment-11840993>
> .
>


@lmangani This one is actually used in SQL schema as current SIP Search, you probably want revert this change. But these _1432821348.json _1431943495.json are actually same just different position of text boxes.


Ditto my previous comment about this.


More specifically, when you `require` the package (either in a project or globally), Composer will symlink anything listed in the `bin` configuration to the `vendor/bin` directory.


That camel case


Rename `mParent_`. I know the `m` prefix is for `meta` but there is also a `parent_` many classes use the `m` prefix for member. Seems ripe for confusion.


@Krillle I think the role of the system specific styles (CEVNI, BNIWR and PPWBC) should be to show the correct renderings, there are several areas using note marks that not are conforming with these systems, and I agree that they should be rendered as well. In that case it can be handled by the INT1 style, or we can make a generic note mark style.


Дублирование?


Fortunately, the multidimensional array syntax in BASIC is fairly compatible with C++. You could create new constructors for 2 and 3 dimensional arrays like this:

    array(int _size1, int _size2)

And access operators, something like:

    variant& operator()(int index1, int index2) { return elements[(index1 - 1) * size2 + (index2 - 1)]; }

(with appropriate error checking)


keeping commands simple and short


Very cool. This is definitely helpful.


1679-DualDuct (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Yes, but a (very) cursory test didn't show any negative effect. And apparently (according to the man page), you're supposed to use `use warnings` anyway, but I'm not a perl programmer.


I just mean that there is the "technical" offline where the very same files are cached; and the "functional" offline where we cache more stuff, and that's not especially related to offline capability. I don't know if I'm really clear :D


:banana:s


Leave as is then.


Yeah, I had debated whether we had wanted to leave them in there or not. My inclination is to leave them in for now because I suspect that the majority of bugs that remain in the system will be subtle interactions between nodes and propagation, for which log traces are useful. This has certainly been true for the most recent crop of bugs, which were actually in unexpected places!


yeah I just tested your code, I think I'll show this directly.


Deze weghalen en eigen versie updaten naar repo


@benbc The _2.2.3_ git tag points to a commit with a 2.2.3-**SNAPSHOT** version, which can't be right, can it? (There's no commit doing the 2.2.3-SNAPSHOT -> 2.2.3 dance in POMs (yet)).


Nit: prefer nullptr to NULL.


Looks like you misspelled "canola"


rax retry tests


It does leave the question of how to support logging in external modules -- for example, the DataSource input and output nodes in vega-dataflow no longer have logging statements, which is a little frustrating. A vega-utils package seems overkill though...


1.2.0 is the unreleased one. Please add your changes in this section, not a new one.


Just for my own learning, is there a reason (other than personal preference/style) not to use:
```
if (!Engine.Capabilities.HasFlag(ImapCapabilities.UidPus))
```
?


I'm in the train right now, but from what I can see there is a proper definition of `setTaxelPosesFromFile` (both old and new) into `compensator.h` (see this page above).


@tchap Why should labels be nil? Is there a difference between an empty array and nil here?


The change to ContributedLibrary.java ignores the fact that both versions may be null (in the case of a legacy library or libraries), in which case the version test should always have the result true. Changing this causes link failures because of multiple linking of the same library. See [#3412](https://github.com/arduino/Arduino/issues/3412).


OMG. Isn't it amazing how one's eyes and brain see what the want to see
instead of what is really there!
Can't tell you how many times I've looked at that line and still not spotted
that miss-spelled country name!!!
Thanks.

  _____

From: Mário Franco [mailto:notifications@github.com]
Sent: Thursday, 25 June 2015 01:49
To: SchizoDuckie/DuckieTV
Cc: garfield69
Subject: Re: [DuckieTV] actually, Português (2a78bf8)

You should also fix the Country name: Portgual -> Portugal

Reply to this email directly or view
<https://github.com/SchizoDuckie/DuckieTV/commit/2a78bf8bd3527ea72498d8e5881
cf6884fd2c2a3#commitcomment-11838984> it on GitHub.
<https://github.com/notifications/beacon/AGnK-GQOR6p5PRmt3UkHBMuYPMbgH9Nzks5
oWqzfgaJpZM4FK1u-.gif>

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


you can remove this.


One question ... I dont know if its a silly one ...
This ntoification drawer is created in Build Tweaks or in the main settings menu ??
Please Reply if possible

Thanks


Nope, I need coffee. Deleting comment.


Pass in a local variable ```comment``` here. Then you can use that in the partial instead of having to create a local variable in the view.

```ruby
<%= render partial: 'comments/form', locals: { topic: @topic, post: @post, comment: @post.comments.build } %>
```


:shipit:


@mbernat `pivotal.Story.Labels` is of type `*[]*Label`. It is like that so that JSON encoder can distinguish between unset value and an empty array, which is a valid value when you want to set labels to [].


@campoy is currently reviewing. I have tested this branch on several live App Engine apps and it works fine, if you want to use it early.


It's a bit different, the kicker is that it returns the value that was written or already exists.. so it looks more like this:

```
local ham = db.read("ham");
 if (ham != null) {
    ham = "sandwich";
    db.write("ham", ham);
}

// Do something with ham...
```

@bbharris described the setDefault method as one of the really useful bits of code we carried forward from previous 'persist' type classes we've had in the past. I get the utility, and it's not much code (and not device side code), so I think it's a good thing to keep around :)


execute program:


usage:
```smalltalk
o := REPLOCompletion new.

o tryGetCommentFor: #rf:n:
'Run the file specified by aString (an instance of String).'

o tryGetHeaderFor: #rf:n:
'rf: aContext n: aString'
```


good point. will clean that up. thx.


Ok i give you some money :) but please dont stop in development.


Maybe a method `rootUrl()` instead of a getter?


I don't think so. In fact it appears that Ritchie proposed it with a space.


remove public access modifiers from all properties, that are not shown on page


@tchap "to roll back"


divide logic in some logic parts


That is also easier to mock...


you should test the listing with "user/usera*", it should provide 3 folders ?


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 3](https://bsr.ict.je-labs.com/viewLog.html?buildId=29618&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) is now running


@jotomo We've changed our build process so that we no longer commit the changed POMs.


that's a good start for the haste issues


проверка связи, приём)


Donate Bitcoins


Nope. I'd just completely forgotten about `refute`. Having just searched our project I can see that we're using both `assert_equal false, foo` and `refute foo`. I'm inclined to stick with `assert_equal false, foo` for now (although that's mainly laziness) but will change to `refute` if you'd prefer?


Fixed


The latest docs explain this further, but bottom line is that by keeping the `-` dash cruft you are suggesting that you support _both_ version `0.3- dev` (from the very first commit) and the official release version from `0.3.0`. So the better way is to simply have `julia 0.3` on this line.


rax retry tests


really hard to read, I think that we should at least extract named variables and methods


- We need a class (to bind it)
- `AppRootUrl.rootUrl()` is kind of weird, isn't it ?


где классы для submit, input, reload?


Please put spaces around operators.
```c++
    return m_pieceSizes.at(comboPieceSize->currentIndex()) * 1024;
```


Use Map<Id, EmailRoleWrapper> instead of map with string key.


That won't work, it should be `haxelib run`.


cc @brunocasanova @gabrielpconceicao


correct


dash accepts it, and checkbashims does not complain, but I think you are right.


whitespace after 'for'


Job Snijders <notifications@github.com> writes:

> Fixed

Thanks!

--
Matthieu Moy
http://www-verimag.imag.fr/~moy/


looks good


TeamCity Wordpress :: CorpSite :: CorpSite-Staging :: Deploy Update [Build 3](https://bsr.ict.je-labs.com/viewLog.html?buildId=29618&buildTypeId=Wordpress_CorpSite_CorpSiteStaging_DeployUpdateWordpressCoreDirect) outcome was **SUCCESS**
Summary: Running Build time: 00:05:45


A small, lightweight logging module (`vega-logging`) seems sensible to me.

On Wed, Jun 24, 2015 at 8:50 AM, Arvind Satyanarayan <
notifications@github.com> wrote:

> It does leave the question of how to support logging in external modules
> -- for example, the DataSource input and output nodes in vega-dataflow no
> longer have logging statements, which is a little frustrating. A vega-utils
> package seems overkill though...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/uwdata/vega/commit/9f8e9e0971bd697ed031095b782985d01ca885bd#commitcomment-11841891>
> .
>


Note this is a change in behavior from the old version. The old version kept the deferred credits from `other` the new version just records new deferred credits. I did see this code went away in other commits, so I'm not going to audit further.


Better redo this block:
```c++
if (destination.isEmpty()) return;

pref->setCreateTorLastSavePath(Utils::Fs::branchPath(destination));
if (!destination.toUpper().endsWith(".TORRENT"))
    destination += QString::fromUtf8(".torrent");
```
So more compact.


I think I'm right in saying that this line *could* be indented without breaking the regression tests. I think I would prefer it to be indented if that is the case.


ACK, but the looks can be improved by removing unnecessary zeros and moving the non changing masks out from the ```#ìf``` statement


@ofTheo this breaks the repo when pulling from master.

```
fatal: reference is not a tree: 5445d64f2b32e3b077c13ed746108f8f8c6b8ec1
Unable to checkout '5445d64f2b32e3b077c13ed746108f8f8c6b8ec1' in submodule path 'projectGenerator'
```

The linked commit (https://github.com/openframeworks/projectGenerator/tree/5445d64f2b32e3b077c13ed746108f8f8c6b8ec1) doesn't exist.

Here's steps to fix.

https://stackoverflow.com/questions/2155887/git-submodule-head-reference-is-not-a-tree-error


@bjori It shows up here as a *release* https://github.com/php/php-src/releases and you can verify signature using:

```shell
git tag --verify php-7.0.0alpha1
```

I think providing signature verification should be consistent across the board if that is the case. Considering we live in a post-NSA world it *could be* trivial for them to modify source archives during download.

However, I do understand the time constraints by volunteers. But looking forward with time permitting, we should ensure all downloads are over HTTPS *(see footnote)* and that they provide PGP signatures.

Possible weak/insecure HTTPS setups?
- qa.php.net ([report](https://www.ssllabs.com/ssltest/analyze.html?d=qa.php.net&hideResults=on))
- downloads.php.net ([report](https://www.ssllabs.com/ssltest/analyze.html?d=downloads.php.net&hideResults=on))
- secure.php.net ([report](https://www.ssllabs.com/ssltest/analyze.html?d=secure.php.net&hideResults=on))


I'd recommend not writing this, as the `!` makes it look like [it's testing for inequality](http://c-faq.com/style/strcmp.html).  I'd prefer writing it out as `if (strcmp(server, "ga4gh") == 0)`, as in that and also in `if (strcmp(a, b) >= 0)` etc the `==` or `>=` is the same as the string comparison test you're aiming for.  More readable IMHO.


TeamCity Jarvis Framework :: CI [Build 85](http://build.prxm.it:8811/viewLog.html?buildId=3184&buildTypeId=CqrsFramework_Ci) is now running


please, emphasize NOT statement with white spaces from both sides
Example : if ( ! condition)


require goes outside of the class.  Should not be needed if it's in the Gemfile as it auto-requires heroku-api unless require is set to false in Gemfile.


This needs to be done for the washington theme too.


Yeah, that looks much better. I've changed this in a fixup! commit on this branch.


@myoldmopar could you chime in here when you get a minute?

In most of the GroundDomain related code, you had an option that if the KA parameters were omitted, Site:GroundDomain:Shallow could be included in the file and the KA parameters would be determined based on the data in the Shallow object. That's fine. I have been trying to consolidate the logic into one place, which I have done [here](https://github.com/mmatts/EnergyPlus/blob/1579840-GroundTemps/src/EnergyPlus/GroundTempsManager.cc#L125) in a ShallowGTMFactory, which is another derivative of the KA type model. That way, if the user wants this option, they just specify "Site:GroundTemperature:Shallow" as the GTM object type for the ground heat exchangers. This all seem straight forward.

The problem I ran into is related to this commit. While reading the basement inputs, the [GetGroundTempModelAndInit](https://github.com/mmatts/EnergyPlus/blob/1579840-GroundTemps/src/EnergyPlus/GroundTempsManager.cc#L204) routine goes out, gets the data for the GTM, initializes it, and passes back a pointer. When I was using the new object, Site:GroundTemperature:Undisturbed:KusudaAchenbach things were working perfectly. However, when I specify the GTM type as Site:GroundDomain:Shallow, [this line](https://github.com/mmatts/EnergyPlus/blob/1579840-GroundTemps/src/EnergyPlus/PlantPipingSystemsManager.cc#L1479) returns different results. For the KA type, the 11th rNumericArg for the Basement object is returned; for the Shallow object, the 11th rNumericArg for the Site:GroundTemperature:Shallow object is returned. This was causing meshing problems, hence the reason for this commit which moves the call to GetGroundTempModelAndInit after all of the references to the Basement input fields.

This seems strange, but maybe it is due to the fact that I am [GetObjectItem-ing](https://github.com/mmatts/EnergyPlus/blob/1579840-GroundTemps/src/EnergyPlus/GroundTempsManager.cc#L152) something else before I'm finished reading the inputs for the current object. Does that seem right, or is there something else I have missed?


OK


尽量还是用WPF架构吧


No need for this.. just raise an error.


As per my [previous comment](https://github.com/alphagov/smart-answers/commit/cd44db5c45958fd484512117239a5efad2db0159#commitcomment-11842197), if the two calls to `render partial: ...` could be indented without breaking the regression tests, I think I'd prefer that.


raise an error.. don't hardode a token in git.


TeamCity Jarvis Framework :: CI [Build 85](http://build.prxm.it:8811/viewLog.html?buildId=3184&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 119 Build time: 00:01:01


Although this is not reflected in the Coding Style, now we prefer camel case. ```urlSeeds``` and so on.


I would have written it as a single if (`if not has translation and ...`), as I find the empty if condition confusing, but that's a matter of taste. Otherwise I'd suggest merging it.


Note: this commit is related to another commit for the same update named "Make Symbols check work with extern prototypes".  Commit 9bcaee4d913c0573df70b917ad952e2087df684a


I think it's fine to leave it as it is in this PR, but it would be good to standardise across the project at some point.


Almost always a better way to do this with ruby than appending to an array.

```ruby
projects.map do |project|
   project.stories.all(:state => 'delivered', :modified_since => time_of_last_deployment.to_s)
end.flatten!
```


Yes, of course. I'll fix that.


@Skippern even more arguments:
- there are only a few ambiguous seamark:notice:category tags
- meaning of the sign remains the same, 'only' different icons
So please do not insist on formal correctness, a working CEVNI style is what we need

P.S. Just added "+ seamark:notice:system=cevni" to https://wiki.openstreetmap.org/wiki/DE:OpenSeaMap/CEVNI_Notice_Marks#Kennzeichnen_von_Hinweisschildern and https://wiki.openstreetmap.org/wiki/OpenSeaMap/CEVNI_Notice_Marks#Tagging_Notice_Marks_in_OpenSeaMap


and @crafteverywhere


Prefer a class to a module unless you really need to mix this into multiple classes.


Just released 2.0.3 with some performance improvements and bug fixes!


@dukesrg Okey. I thought it would be
```C

#define TOP_SCREEN (u8*)(*(u32*)((uint32_t)0x080FFFC0 + 4 * (*(u32*)0x080FFFD8 & 1)))
#define TOP_SCREEN2 (u8*)(*(u32*)0x080FFFC4 )
```


you probably pushed to the old repo in ofZach's?

using `git remote show origin` inside the PG folder will tell you were it's pointing at


You'll want to memoize this method as you are calling it once for each project.


Yes


here's a fix. https://github.com/openframeworks/openFrameworks/pull/3998


there is no need in temp variable
you can change the value of object field in next manner:
emailRoles.get(em.Employee__c).emailRole = ....


After we finish all tests


I can probably get a fix in for this today.


TeamCity Jarvis Framework :: Publish Framework to MyGet [Build 21](http://build.prxm.it:8811/viewLog.html?buildId=3186&buildTypeId=CqrsFramework_PublishFrameworkToMyGet) is now running


1440-AWS (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


scumbag stef... leaves a random G


@mbernat Fixed in 6226e2a


Ah, nevermind :)


please, check if all this properties are use on page. if this is not true, remove public access modifiers from properties, that are not used on page


thoughts on having a callback that does this once all of the dependencies are loaded? that way there is no static timeout


@dukesrg Okey. I thought it would be
```C
if (screen == (u8*)(*(u32*)((uint32_t)0x080FFFC0 + 4 * (*(u32*)0x080FFFD8 & 1)))
    && (u8*)(*(u32*)0x080FFFC4))
```
Even still feeling odd for it, i would not take it too seriously.


TeamCity Jarvis Framework :: Publish Framework to MyGet [Build 21](http://build.prxm.it:8811/viewLog.html?buildId=3186&buildTypeId=CqrsFramework_PublishFrameworkToMyGet) outcome was **SUCCESS**
Summary: Tests passed: 108 Build time: 00:01:38


@SachaG May I know why? I am trying to follow http://telescope.readme.io/v0.20/docs/custom-packages


Sorry for nitpicking about git history, but would you mind splitting the changes into 4 separate commits?(fix #87, fix grammar tests, improve performance, enhance Oomph setup)?


:+1: this doesn't seem to work in 3.5.1


Isn't this asserting equality rather than truthfulness?


I did some research and found that `this property contains text to describe an HTML 4.0 document`
for use with `toHtml()` and `setHtml()`. We don't use these; therefore it seems irrelevant.
However, it seems like we have always been using `MS Shell Dlg 2` for the command input and output.
It doesn't appear in our code, but in the UI designer. Therefore, `MS Shell Dlg 2` must be the default.
Reading [microsoft's article][1] illuminates Qt's decision to use this.

[1]:https://msdn.microsoft.com/en-us/library/windows/desktop/dd374112(v=vs.85).aspx


Nice. So lets sit this weekend and start development.


So does this make you feel more or less empowered to manage your own software development process?


Using [markdown lint](https://github.com/mivok/markdownlint) to clean up the README.md file


My understanding is sky:init does launch the mojom script.  Are you asking for it to launch sky_tool as well?  Would it then be:

pub run sky:init start my_app.dart --install? :)


**Integrate countermeasure**

See if it's possible to provide api for integrating different countermeasures


might be interesting for users, too:
- support for a public definition of `ADIOS_VERSION` the main adios header file


element == null should take care of both null and undefined


Note: these functions are from Google Closure library (see the comment in the traceur implementation).

In general, I would prefer using an existing library, as we need a good test coverage for this (the tests that we have right now are not enough).

E.g. we could use the `Uri` class from Closure directly (or some parts of it), including their tests (see https://github.com/google/closure-library/blob/master/closure/goog/uri/uri.js).

Please also talk to @igorminar and @btford as they also need want to use url segments (parts delimited via a `;`), and need a URL parser for this as well.


I'm pretty sure these two scale values aren't necessary.


Aaand with `exit/1` on the caller's side it looks better:
```
1) test log tracking (ExUnit.CaptureLogTest)
     test/ex_unit/capture_log_test.exs:35
     ** (exit) exited in: ExUnit.Server.log_capture_on()
         ** (EXIT) an exception was raised:
             ** (Protocol.UndefinedError) protocol String.Chars not implemented for {}
                 (elixir) lib/string/chars.ex:3: String.Chars.impl_for!/1
                 (elixir) lib/string/chars.ex:17: String.Chars.to_string/1
                 (logger) lib/logger/formatter.ex:107: anonymous fn/1 in Logger.Formatter.output/5
                 (elixir) lib/enum.ex:1043: anonymous fn/3 in Enum.map/2
                 (elixir) lib/enum.ex:1385: Enum."-reduce/3-lists^foldl/2-0-"/3
                 (elixir) lib/enum.ex:1043: Enum.map/2
                 (logger) lib/logger/formatter.ex:94: anonymous fn/6 in Logger.Formatter.format/5
                 (elixir) lib/enum.ex:1385: Enum."-reduce/3-lists^foldl/2-0-"/3
     stacktrace:
       (ex_unit) lib/ex_unit/capture_log.ex:83: ExUnit.CaptureLog."-capture_log/2-after$^0/0-0-"/1
       (ex_unit) lib/ex_unit/capture_log.ex:77: ExUnit.CaptureLog.capture_log/2
       test/ex_unit/capture_log_test.exs:37
```


They're certainly brittle. If the Regexp doesn't match (because someone's used `content_for(:body)`, for example) then we'll end up with failing regression tests as the rendered outcomes will be different.

I'm not sure how much effort it's worth putting into making them less brittle as I wasn't really thinking that these methods would be very long lived. I think they're useful to help retain the same rendered outcomes while we're converting from YAML to ERB but that they can probably go once the conversion has finished and we're less worried about the rendered outcomes being identical.

What do you think? I'm willing to be swayed.


Have you uploaded EmailRoleWrapper.cls ?


Last point is especially valid. The Pragmatic Programmer also offer some tips on 'programming deliberately' that are very relevant to this.


赞！


Looks better now, doesn't it?
I guess that was related to an unclean d*cker shutdown two days ago.


1679-DualDuct (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-77.53%25-red.svg)


Hi @davidok8
Nice to see you back on your library.
And happy to see that you have found a sexy name ;-)


Is there a reason why there is no type check in the "TO" value of the loop? This omission is still present in the current master.


nice


Fixed.


"service" is a shell script locate at /usr/sbin/service Looks like you have some troubles with PATH variable. Try to use "/usr/sbin/service apache2 restart"
Anyways it looks like off-topic for this pull request.


I have  been unable to copy the code from http://gethum.com/MisterJames/BootstrapingMvc-Code.
I am a Subcriber: My email address: jpjr4jose@gmail.com


Thanks, I will check this!


s/mapstruture/mapstructure/


I am not sure whether I should answer YES or NO to your question above. Instead, I think we learned to avoid some pitfalls. I still don't feel prepared to manage my own software development process, but might be a little better prepared to supervise someone else managing - or identifying stuff that makes no sense.


I fixed the error and reverted this commit so the farmbot is back again. Considering how the secbots fail to walk around walls when chasing a hostile, I will assume it's a non-issue that the farmbot can't pathfind around windows/soils in hydroponics.


Never knew about this getCSSNumber method. Very useful!


ante gia


Not really, it's scale *up*, so we want it to go from 0 to 1

El mié., 24 de junio de 2015 1:47 p. m., Ümit Seren <
notifications@github.com> escribió:

> shouldn't this be scale(0) ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PolymerElements/neon-animation/commit/cf9f1f44298b3721e8d498904e583510e4a8d633#commitcomment-11836521>
> .
>


week naming game


Adding control of firewall rules in the next couple of days (https://github.com/UpCloudLtd/upcloud-python-api/tree/firewall-feature)

Going to make sure this kind of helper to add several rules with one function call is included too :)


This looks like a really good commit. Since you are adding new files, it is probably difficult to make this much smaller. The commit message needs improved. This commit isn't a true merge. Rather you are adding new classes to the project. The commit message title can be as simple as "Add `BaseballCardDetails` and `PremiumActivity` to premium edition". Then insert a blank line and then a body which describes in more detail why these two classes are needed. Also, you should consider a different name for the new `BaseballCardDetails` class, perhaps `PremiumDetails` or something similar.


That seems reasonable, given that the regression tests would fail. I do wonder slightly whether we'd remember to remove these regular expression matches later, but happy to leave it up to you.


@moyni can you check please?


The fix is ready on my machine, I was just wondering if it would have other impacts before submitting the PR.


Class's internal will override methods & field's


Won't it make sense to increase the reduction and not reduce it at draw positions?


Should be okay, send the PR through and we can try.   FWIW I don't know what your fix is...


Trey I'm still having trouble clicking the dropdown in iOS. It's working fine in Android, though.


This causes my builds to fail with:

```
cp: /Volumes/Data/Programming/c-cpp/of-my/openFrameworks/addons/ofxMaps/example/bin/exampleDebug.app/Contents/Frameworks/GLUT.framework: No such file or directory
```
This happens when the GLUT.framework hasn't already been copied there manually or by an old xcode file.


Why can't we use the real `UrlResolver` here?


Hello Pattrick!!
Why are you skipping the destination param when the upload is for multiple files ?
The destination folder is unique for all the upload files (is the current path in the folder you are located)

Regarding file param name... Why not just do something like this...
```js
if (fileList.length > 1) {
  form.append('file', fileObj)...
} else {
  foreach...
    form.append('file-' + index, fileObj)...
}
```


Better your way. I'll make the changes and commit it.


@Dirk-- There are several issues to this
* While all seamarks was in INT1 style, I had not added categories to generic marks as there was still a lot of work pending in the style (there still is)
* Separating CEVNI from INT1 I removed CEVNI marks from INT1, no point in having the same data defined two places, I did the same with BNIWR and PPWBC for consistency
* The problem your new CEVNI seamark style overrided my specific styles, adding seamark:notice:system to the style was a first step in an attempt to make the styles work with each other as there are places in the world where it is necessary having two system styles active.
* There seems still to be need for a generic note mark style, and should probably be focused on solving this through a generic rule, either as a standalone file or internal to INT1

If JOSM adopt support for `@import` statement in MapCSS all of these will be imported back to INT1, which should be general, in that case the system specific files will be maintained separately for ease to understand.

I am still advising people doing seamarks to install the validator to JOSM, this validator is currently in a very early stage, but warns about missing `seamark:notice:system`, that way you can easilly find the missing ones, and in areas where you are positive of all marks being CEVNI should be easy enough to bulk edit these.


Why do you check ```hostname``` here, but ```(hostname && *hostname)``` above?


Should we add an autoconf check so that the OpenSSL version gets used when it becomes available?


Check the later commits :)


is this documented anywhere? if not, please remove or talk to vijay or I about it.


I'm really :+1: about re-using the code from closure. However I would really prefer if we can defer it to a follow-up PR.
What do you think ?


Im very interested on this change, what is the behaviour??


This gets changed in the subsequent commits


What's the KanBan board? I think I missed that one...


Wouldn't that make it even less likely to find alternatives escaping the draw?


done


I believe other outputs of `cal` in the codebase are with Sunday first.
I see the benefit of using `-m` here since it makes the offset counting easier to scan.

Note for this patch, but we may want to standardize one way or the other across the codebase.


thanks! perfect!!!


```SSLConfidParams::initialize()``` gets called on each reconfiguration event, so this will leak ticket caches. If this is not supposed to be a reloadable configuration, I think it should occur in ```SSLConfig::startup()```. However, it would be great if you could figure out a way to make it reloadable, since it seems like a shame to force a restart on people who forget to turn it on at first.


Is this done for the purpose of not having to do `i + 1` in the asserts?


Looks good, mind adding a unit test as well


New commit: ef7ccb539820f303f11e51ccf43875bbca9449ce


Shouldn't the image be renamed to `audiosocket/docker-base` ?


@calzoneman just fyi... I added a less-than-awesome "make test" in the test_cases directory, which runs OptACC with each of the command line options and search methods.  It only covers some happy-path cases, but if one of the options or search methods breaks in a way that completely crashes the tuner, it should catch it.


@wchristian This hunk is subtle change in behavior - it does not check **duplicate** order entries. Think a piece of hand-written yaml with a lot of copy pasta, so both $highest_index == amount of columns **and** the index is sparse due to a number being duplicates on several columns.

Is this commit really making a difference speed-wise? If not I prefer we not apply it, and leave things as-is.
Thoughts?


The example iTRAQ4 data for iPQF is an extract of 11 proteins with spectra measurements from the original data set described by Breitwieser et.al. -> so probably good to mention this and also add reference to this data extract? (Breitwieser,F.P. et al. (2011) General statistical modeling of data from protein relative expression isobaric tags. J. Proteome Res., 10, 2758–2766.)


@ehebert did you have to do something special to make Sunday come first?  This is just the result I got from doing

```
In [5]: from calendar import prmonth

In [6]: prmonth(2015, 6)
     June 2015
Mo Tu We Th Fr Sa Su
 1  2  3  4  5  6  7
 8  9 10 11 12 13 14
15 16 17 18 19 20 21
22 23 24 25 26 27 28
29 30
```


HasFlag is a lot more expensive than good old fashioned bit masking. HasFlag() has to figure out what the original type of the variable is (and it's integer size) and do the same for the enum value you are checking for, then it has to cast them both to the same integer type and finally mask. Might do other checks as well. When I last checked, it was pretty expensive for what it did.


@wchristian Same question here - is this **really** a gamechanger performance-wise? I rather not apply it unless there is a tangible double-digit gain.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 82](https://teamcity.labkey.org/viewLog.html?buildId=256913&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 1 Build time: 00:22:30
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSUpgradeTest: <no details avaliable>

```


I tested the sniffers and found a few small errors, which I fixed in my pull request. Please note that the sniffer of Phyloxml does the same unsafe checking as I copied the code from that one.


I deleted this "overall takeaways" tab because we're supposed to make a tab per topic (I now included it under "Preferred Platforms", calling Trello the preferred platform for Kanban board. A Kanban board is a to do-list with several columns (for example: waiting for development, under development, waiting for quality testing, quality testing, waiting for production, etcetera). The idea is that everything moves from left to right, providing an overview of progress on to do's, as opposed to a static to do list where one can only tick the box when finished. It's used for SCRUM.


1679-DualDuct (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Thank you for the corrections. I will add the 'article' method in the PR corresponding to article edit, which is where the correction was placed.


To prevent further confusion: add 'spectra' in text -> " proteins are only supported by 1 or 2 peptide spectra


Use ```ink_zero``` here.


Fixed bugs with replay, completing the flag-switching capabilities and closing #24


The original definition of this was with an OrderedDict with keys manually set from 1 to 6.  Since the test data depends on the asset values, I didn't bother changing these so that I had fewer changes to make to the expected testing output.


check if it's correct to mark this as mandatory..


ATS needs origin side TLS version control.  Created ticket TS-3716 to address.


AFAICT all the pointer parameters here should be const.


The gnu `cal` utility does this


Good to know. Thanks!


There are several changes, in the future I'll keep the changes more compact.
With this, I intended to do an atomic rack awareness push.
Your input is highly appreciated.


done


@benbc I see, thanks. Just wanted to make sure this wasn't accidentally released.
Hm, I wonder if this can cause issues for (Linux) distributions building from source. The source zip/tar at https://github.com/neo4j/neo4j/releases has the SNAPSHOT suffix (didn't find a source package on neo4j.com) ... I might be worrying too much tough ;-)


Missing parenthesis?


Enabling/disabling JMX should not be configurable. If a service doesn't want JMX, it should not be built with JmxModule


*(u32)0x080fffc4 can only be evaluated at runtime, so (u8*) too. The same thing is for the first part. So finally two dynamical pointers to u8 is compared. Nothing wrong, not very readable though save code text space.


Good suggestion. I haven't seen any brokerages who accept custom tags though, how would we save that information at the brokerage?


Neither is any of the memory we allocate in Buffer. But it still uses `kInternalized` or else every instance would need to be a `Persistent` so it would be possible to free the memory manually when the object is cleaned up by GC.

I might also be missing your point about it being heap-allocated.


`public static final`


> Could you ever have 2 predecessors that both contain the same node?

No.  `Contains` means that the `head` actually has the `tail` inside of it.  This is useful for types like `PodSpec` that can have many different top level objects, but logically have edges pointed directly to them.


Fix the constant and we'll merge it


Mariano, hay un error de tipeo en la linea 17, __liceFnse__ en lugar de __license__


lol


Ah, forgot the name. Was confused with Kanban inventory system. Thanks for the explanation!


Why are you not returning fallback() here?


The link for create a proposal opens a wrong link, new issue on authentication. Instead of a link, we should add a brief description on how to create a new proposal.


@andrewgregory
Sorry for not getting to your pull request earlier. It looks good to me, however I wonder if the regexes should change to `/^ \s* BEGIN \s .* \s END $/mix`, so that `.*` will match multiline triggers.

Please let me know if there is a problem with that plan.
Cheers!


The detection code is needed. It's to protect a service being configured with conflicting com.sun.jmxremote settings and airlift config options.


```
+ git checkout fork/m
Note: checking out 'fork/m'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 4f31541... asdg
+ git rebase origin/master
First, rewinding head to replay your work on top of it...
+ git checkout origin/master
HEAD is now at 6a20827... rebase before merge
+ git merge --ff-only fork/m
fatal: Not possible to fast-forward, aborting.
```

Doesn't seem to work.


Пробвай да го обърнеш и виж дали ти харесва повече :)
if(!...) {
  throw ...
}


Hey, I believe so =)

Lets follow up on the email thread on what is the best approach to solving this issue.


Oh yeah, got the error, but the reasoning is actually in 760cb7a29f8d8416392ed3852c9e161ca8590650, where the keyframes were somewhat inverted. The default indeed should be `scale(0, 0)`.


1679-DualDuct (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-77.84%25-red.svg)


I see...you are looking at the Root score.

My thought was that you are looking at the current node score.


OK, good point. Reason is clear:

```
def publicipv4():
    try:
        import urllib2
        f = urllib2.urlopen("http://api.ipify.org", timeout=2)    # timeout 2 seconds, in case website is not accessible
        public_ipv4 = f.read()
    except:
        public_ipv4 = None
        pass
    return public_ipv4
```
So: return value is everything that is returned when calling http://api.ipify.org. Normally that's the IP address, but with it can also be HTML from the landing page.

I'll improve the code to check for an IPv4 address.

Thanks.


Can you break out this commit separately. I'm still not sure I like the other tutorial stuff.


App.isRunning() looks like exact function I need to get Focus method for mobile VM's just perfect. Thanks Raiman!


update


do you mean movie instead or image?


oui


@mattlistro I think this is really great. Especially you're point about making sure if you hire developers to work remotely, they have experience doing so.


I think we define EPOCH earlier in the module, so could use that, but `Timestamp(0)` is straightforward enough.


:+1: Dimming of hidden sites now works in search mode :)


One additional thought on this: startups will have a limited budget, and whatever they don't spend on developing the product they can spend on customer acquisition. Gaining a critical mass of customers is often at least as important to the success of the business as having a good launching product. So working with a MVP is a double whammy.


updated (got squashed in this morning. sorry)


@rasdan @rudygodoy creo que no tiene sentido tener los archivos originales dentro del bundle, al final no van a ser usados desde symfony. Considéren moverlos.


Отлично.! Так держать.
А как делать pull request ты знаешь?


Just added it, so you wouldn't have!


Should we promote this column to uint64 to allow larger date ranges?


Why is it required to be a resource? If you need a placeholder for a unique magic value, you could just use `new stdClass` because when strictly compared only matches with itself.


"double-triple" hehehe

but triple_f or triple_float is better than vector_3f


This closes #8


The only way it would be size<2 is if the first element holds the NULL pointer. In that case, JtR never gets to this location.  You get a warning message (failure actually), listing "no test vectors."


Interesting. So if I understand why you've done this, you get blank buffers during a normal stream, but the part will recover without resetting if you just retry? Or they're not quite blank, since you're comparing against 1000? Also curious how often do you see this, I'm not sure I noticed it.

One thing to note, is that I actually return a sum from this function. If you want to check the sum before returning, I would move the call `data_buffer.sum()` up, and use that value -- this `sum()` method should also be a little faster to compute since it's getting done in native code through numpy.


@rasdan, falta separar en carpetas también


The port parameter was merged. The project changes did not work for me. The project would not load.


Pyssdeep is on pypi


All the actual values we want to store fit in a uint32: this only matters for just the synthetic test data where we're using various decimal places to encode data.


It's a good idea, but let's do it in a different PR.


> I think it'd be better to set up a DC with a real RC

Why would that matter?  I don't necessarily disagree (I'm working on building up canned `List` objects of working examples for `status`), but in this case the mere presence is enough to test the node and edge creation.


If we wanted larger date ranges, we could also shuffle this to store date in a higher-order bit and move asset lower, but this format is fine for most tests I imagine wanting to run.


fixed! still an inconsistency, but I guess is part of the UT framework ... commit soon


@igable cherry-pick


s/import/important


Might want to move the `with` to the top-level bullet point, I think this makes more sense that way


s/and/an


The `iterator.hasNext()` call is blocking and will throw a `ConsumerTimeoutException` just like `next()` when there are no messages available, so calling it here doesn't give us anything.


How do users of Presto disable JMX?


@igable this came with 8f19bf19


pydeep is, pyssdeep isn't as far as i've been able to tell


rax retry tests


please, test this method.
i think, that you simply rewrite junction because of the same id.
you should create new junction instead.


I see that Krs.Ats.IBNet.Order and Execution have OrderRef field, perhaps
Tradier has something similar. My main goal is to reconcile Brokerage
orders with those that Algorithm submitted and saved just in case it would
need to recover from interruption. So, if brokerages preserve the OrderId
that you pass on their orders and executions, then maybe nothing needs to
be done to achieve that. On the other hand, custom order comments are a
common requirement, so maybe using OrderRef is a way to preserve them.

On Wed, Jun 24, 2015 at 12:35 PM, Jared <notifications@github.com> wrote:

> Good suggestion. I haven't seen any brokerages who accept custom tags
> though, how would we save that information at the brokerage?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dpavlenkov/Lean/commit/d772016df95710eee1b0f3b80572c43f6e7cd153#commitcomment-11842833>
> .
>


@igable test, cherry-pick


Sure, it's need, but it doesn't work, so remove it until we can write detection that works. That seems better than continuing to ship with known broken code.


Looks cook 👍


Assentos não seria igual a vagas?


I am baffled by the need for this hack, but perfectly willing to apply it to #392


Please ignore this pull request, inadvertent...


@igable came in with da4da90e


lol


Se precisar de todos vagos tu pega o index de todos aqueles com false.
Se precisar de todos ocupados tu pega o index de todos aqueles com true.


There are a bunch of places where it looks like you're mixing tabs and spaces.  I think pyflakes or flake8 should pick these up.  PEP8 always specifies a 4 space indent, which we should stick to.


test_get_with_some_dude - brilliant.


@dukesrg Ok.. Comments here follow Markdown syntax, so ```* Italic *```.


I think Dustin is going with underscores between words in method names, so a better name here would be read_file()


@igable came in with e7a59705


Yep, and cuckoo depends on pydeep since 2012:

Cuckoo Sandbox 0.4.1 (2012-08-09)
=================================

* Added Yara signatures to HTML report
* Replaced pyssdeep with pydeep
* Added support for signatures' version requirements
* Added unit tests
* Fixed delete_original race condition
* Fixed reconstruction of registry keys
* Fixed logging in cuckoomon
* Improved exception handling


hsize_t would be better, since that's what the right side is.  I can throw it in my next misc patch...


:ok:


Fixes Notice: Undefined index: groupby_times error found in LUGG-336


I will tell you if you give me 5 shekels.


Perhaps `DATASET_EPOCH`?


1440-AWS (axelstudios) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


rather than creating a new String in order to call the substring function, why not use the StringBuffer funtions. perhaps strXPath.append(strXPathOrignal.str(), int offset, int len)


No need of invoking size on hs


Why is it in?


that's my default colorscheme! :+1:  :-)


Let me revert that now.


remove extra blank line


No need to have this static instance variable declared


ah... missed that one... might be able to fix it later...


You should take a look at the tempfile module which will let you create a temporary file/dir so that these don't clutter up your home dir.


Make this method returns a Map<String, Integer>


can you create static const char * for all these tags? "AccordionItem:", "altTitle:", "index:", etc?


No need for console printing


@AgentRX could you please follow rmsauth formatting style - breaking formatting style leads to difficulties with tracking of changes and makes the file different among the others.


looks good to me @pazdera


remove if not needed


Bien Ricardo! :beers:


1440-AWS (axelstudios) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


1679-DualDuct (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-78.2%25-red.svg)


leftover debug code?


Instantiate EntityDictionary before every test case. See how to use @Before annotation in junit


merged from upstream


Что-то явно туго шло, если 5 часов потратить...


Some "shit-code", hardcode:
```
action="<?php echo $_SERVER['REQUEST_URI'] . '/batch/delete'; ?>"
```


Let's shift this conditional to just not do the history persistence etc., so that we still update the title during redirects.


Wait...what?? you are comparing two declared variables?? Of course input and expected will be equals.


```
var confirmed = confirm('Are you really want to delete checked items?');
```
no multilanguage support


Russ' comment applies to other changes in this commit as well.


Can we make this a computed var instead?


How are these to be understood? If I give `1` as the number, but a list of more than one rack and node? Also, what if the node and rack contradict each other?


@Jrubin16 based on our conversation yesterday about the startup we're launching for Launching New Ventures, I think India is the way to go for development. I think we should do a dev. shop there. It gives us flexibility in case the project doesn't work out and we don't need a full-time team. Plus, as much as I'd prefer to hire locally, our budget is VERY small. Yes, you get what you pay for, but I think it's the best option. We should be sensitive to cultural issues, but that's my vote.