@Brettflan Any plans on releasing a new version publicly with the new feature?


Is this not supposed to be written in ES6?


@slarosa Shouldn't this be using the svg version?


same here


Hi Martin,
It seems the problem is It's using differernt compiler. Try to run make (see Makefile). I just tried and it passed ok...
![make](https://cloud.githubusercontent.com/assets/763318/8276688/bca98fc4-18b9-11e5-8a32-7dd3162cf8dc.jpg)


Why would it say "unreleased"? According to the web page (graylog.org) version 1.1.3 is the latest version. There's no indication that this is some sort of preview version, or did I miss something?


Hi @Narsul . I agree that these shouldn't be installed as dependencies. However I don't really see how your pull request fixes this?


I agree that the repeated "very much" was too much but I am not sure
that the first sentence was grammatically wrong. Can you please change first sentence back
and rebase? Then I will merge this change. Thank you!


As a test, I also tried with juxtaposing the order of two major mods with fluids: Buildcraft and Thermal Foundation/Expansion/Dynamics.  Renaming all of the Thermal mods to have "A-" at the beginning resulted in the same behavior as with buildcraft and advanced generators.


Yeah I found that. More precisely I'm going to rewrite this a little -- the warnings will be better for the user.
But I have frozen the work here and doing more priority bugs now.
I think the best will be to close this PR because the patch will change in the future.


You shouldn't have to get item flags and remove item flags anywhere in this hunk. There will never be item flags in a material's meta data by default, as far as I know. If ia is null, do nothing. If ia is an array just add the item flags.


Hi Simon,

I had to do an important bug fix in Persistit (doesn't work without it) and
did a release request which is currently being handled.
I understand the problem and I will update the version once it is done but
I already did the P/R so that Julien can already review it.

On 19 June 2015 at 23:25, Simon Brandhof <notifications@github.com> wrote:

> SNAPSHOT dependencies to external projects must be avoided as it makes
> build fail outside SonarSource infrastructure (travis-ci).
> Is this version of persistit required right now ? An option is to release
> persistit before doing this change
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SonarSource/sonarqube/commit/0f847fc2ad1352404986f7f0033784ca3fffb650#commitcomment-11775953>
> .
>

--
*Duarte MENESES | **SonarSource*
http://sonarsource.com


Please Check following suggestion & make changes:
1> Try to exclude importing time & datetime to set time.
2> Change in Many2many syntax fields.Many2many('objet.name', string="string to display")
3> Remove variables like self_obj, give proper name.
4> Make change in onchnge function. Use api.onchange('field1').
5> Check pass_marks float that you converted. Make it correct.


@Js41637  let me know if you are done with templates\serieslist\tools\favorites.html
I've got a little fix but I don't want to clash updates while you're working.


Fixed all above except '{0} - {1} of {2}' - correct the translation on transifex.


The files in src/main/webapp are these files for building or are they also necessary for runtime?


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1434955312136
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


These two method names are inconsistent with CH method naming convention.


Hi Martin,
I can't reproduce the error. Don't have IAR ...
Sorry


I think "+" sign is incorrect, infront of ##. Otherwise the output is OK.


Hi! This is so cool!


The opacity: 0; simply tells the object to start at 0 for the animation.
There are two elements on the page with the .fade-in class. The paragraph
and the "trouble hearing?" text both have that class. Which one are you not
able to see on Chrome? I am able to see everything displaying correctly
over here.

I'll talk to you tomorrow about the function of the eye button that I am
now trying to implement. For some reason my script isn't running and I'm
not sure why. I constructed it myself so I'm not surprised. Things never
work the first time ):

On Sun, Jun 21, 2015 at 11:04 PM, oren <notifications@github.com> wrote:

> I can't see the element with the .fade-in class. probably because it has
> opacity: 0;
> I can see it on Firefox but not on Chrome.
>
> Here is the javascript code you can put in app.js or whatever filename you
> want.
> And then you can remove the onClick you have in the html file.
>
> var eye = document.querySelector('.buttonsize');
> eye.addEventListener('click', changeClass);
> function changeClass() {
>   document.querySelector("#boxone").className = "slidein";
>   document.querySelector("#textcontainertwo").className = "fadein two";
>   document.querySelector("#listenbox").className = "invisible";
> };
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Tewt/tewt.github.io/commit/3fdb7c74625852e40f8314af54199691aedde2d3#commitcomment-11787618>
> .
>


+1 for more info in that message. @ndbroadbent you can read more here https://github.com/cjohansen/Sinon.JS/pull/745


Assignment Branch Condition size for upload is too high. [23.35/20]


Method has too many lines. [13/10]


Oh yeah i'm done for the moment :)


You should add an error handler to this promise. Also, `updateState` is a bad method's name.. it should be called `addHost` or `hostListAppender`


There is a typo in the commit's comment. It should read:
Insert **some** casts to allow C++ compilation.


Hmm.. could you please quickly describe what's happening here? What's the relation between the height wallet transactions, STO and the txids?


I have to admit I am surprised this is still like that. I could have sworn it was changed in the meantime to use a separate setting again and solving the issue of having to specify the "same" setting twice was solved differently.

Anyway, it is not supposed to work with Neos only, of course.


@JKE-be could you help me a little bit here please? I know how to do most of this since your last help but I'm struggling with two small things.
1) I've made a redirect that when the user clicks on shop it will redirect to /shop/categoryselection but this should only happen the first time. Whenever a user has had this screen once and selected a category he should be automatically redirected to /shop with the products that match this. When the user would click on shop again it should then show the products.
2) The /shop/categoryselection is giving me an error when I select a category and then click on submit. This is the error:

  File "/odoo/odoo-server/addons/aa_houbolak/controllers.py", line 44, in categoryselection
    order.write({'afwerkingpicker': int(post.get('afwerking'))})
AttributeError: 'NoneType' object has no attribute 'write'
Why am I getting this? I don't see any problems..


Extension "md" missing...


ここはどういう意図ですか．


Maybe better "the importer will read the `json` file and build a `product-type` with updated enum attributes out of it"?


@BrateloSlava thanks for that I totally missed that, I was going to go through each new addition such as this just to be sure there was nothing like this that did not suit the yuga.

Thanks for the quick pick-up.


Nice one :+1:


Need to redesign ioctl codes first...


Sure - so walletTXIDCache is just a vector, and transactions are added to it in sequence, this forms the "order".  The heights are used here to insert STO receipts (which don't have an actual wallet transaction) into the cache - but now I think about it this is actually going to be problematic because other areas of the code assume that a transaction in the wallet cache is available in the wallet...

Hmm, yep I'll definitely need to make some changes here - I think the insertion of STO transactions is going to have to remain where it is at the presentation layer rather than the wallet... Crap, I was just removing a whole bunch of STO stuff hehe


Again... `static class method` isn't available?


Ok but text must be transformed:

example:
 "Brak nie udanych nagrań do wyświetlenia"

tabs should be:
"Nie udane Nagrania"


Good stuff! :100:


just asking... but what is this instance of WorkGuard here for?


should be better


very nice indeed!


The new version should have the new URL, change the existent one is wrong


Some {} missing. setmx has no purpose imho.


@SubJunk No issues, when i get around to getting ffmpeg to build with the dependencies we need i'll let you know


I am not sure it is setting a vector, data is being saved in the function.


@SubJunk don't see why not!!


@Js41637  cheers. 090edf0efc3e47a57c68ad07b3aaccd354beeeff committed. all yours again :-)


You should also check `%branch%` over here.


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1434956536983
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1434956556979
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1434956563259
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1434956572233
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


some nasty compiler warnings here and on L288, which are errors with msvc


```json
{
  "version": "0.6.20",
  "approved": true,
  "approver": "mschaaf",
  "approvalDate": 1434956581767
}
```
approved with [gh-review](http://gh-review.herokuapp.com/)


Everything looks good now, I've merged your contribution into Fedora package.


:+1: Great, thanks @fuzxxl


I miss some docu in wiki or readme about how to use it.


Hey no worries. Git is magic and poetry but it's also a behemoth and using it can feel like herding cats if you are out of your depth. I'm actually glad to help out with a little git education, especially as a way to contribute to projects I like this that I care about.

It looks like you've got a regular tangle going on. If you'd like I'd be happy to help you sort it out. If you let me know roughly what is _supposed_ to be going on here and whether you are using the command line tools for git or some GUI I can probably give you exact steps to sort it out. For now my brief observations are:

* You're doing merges backwards. You're work should be getting merged into the upstream project but the project probably shouldn't be getting merged into your work. The main fix for this is to use rebase rather than merge if you want to bring your branches up to pace with the upstream project before such a time as they are accepted upstream.
* As a result of multiple rounds of the above, your branches have instances of commit->revert commit->recommit->etc. The same code is going in and out of the commit log multiple times.
* In some cases you're branches have reverted upstream progress and re-written it to an older state as a result of bad merges.

For example a quick history comparisons shows:

	❯ git log --oneline simoncozens/master..shirat74/upstream
	3a8b45b Merge branch 'master' of git://github.com/simoncozens/sile
	7333e8b update
	6ff3594 Merge branch 'master' of https://github.com/simoncozens/sile
	7170026 update
	1089722 Revert "Unicode PDF bookmark"
	e47560c Merge pull request #1 from shirat74/sh

Of those, the three merge commits and the revert all need to be removed from the history entirely before this branch would be useful to show just your work. A quick look at 7333e8b shows that it only has one minor fix:

	❯ git show --ignore-all-space 7333e8b
	commit 7333e8b
	Author: Shunsaku Hirata <shunsaku.hirata74@gmail.com>
	Date:   Sun Jun 14 13:21:08 2015 +0900

		update

	diff --git a/packages/pdf.lua b/packages/pdf.lua
	index ee7e1c2..742c034 100644
	--- a/packages/pdf.lua
	+++ b/packages/pdf.lua
	@@ -29,7 +29,7 @@ SILE.registerCommand("pdf:bookmark", function (o,c)
	SILE.typesetter:pushHbox({
		value = nil, height = 0, width = 0, depth = 0,
		outputYourself= function ()
	-      local d = "<</Title("..title..")/A<</S/GoTo/D("..dest..")>>>>"
	+      local d = "<</Title<"..ustr..">/A<</S/GoTo/D("..dest..")>>>>"
		pdf.bookmark(d, level)
		end
	});

A quick look at the upstream master branch shows this fix is already there. Using `git blame -L 32,32 packages/pdf.lua` I was able to determine it got included when your PDF bookmark code got included in ba4e7ed8. So that commit is unnecessary. So lets have a look at 7170026.

	❯ git show --ignore-all-space 7170026

Now that shows a lot of stuff. The trouble some of it looks like changes you may have made but some of it is back-peddling changes that happened upstream. It appears to me like this commit has some bits of changes that were leftover from uncompleted merge conflict resolution in your local tree. However it's a bit tricky for me to sort out I am not sure what the code is supposed to be accomplishing.

Perhaps that's where you can start: the commit message for 7170026 is not helpful. Can you explain what you expect that commit to accomplish in terms of what fix or feature you expect it to bring to the code base?


If you use something like Figaro, which Kevin linked for you, you can use env vars in this file and you don't have to add it to your gitignore. You only need to add it if you plan to have it contain live secret data.


Sorry - last couple of commits should have cleaned things up.

I was basically trying to spoof STO receipts into the wallet cache so we didn't need to keep "inserting" them everywhere, but adding non-wallet transactions to a wallet cache is just not smart :)  Should be better now :)


If this an unexpected error? Then we should throw an exception. If we know it can happen, we shouldn't print it to STDERR because we don't do that usually (only in some special debug mode).


Nazval bych to jen Černobílá, mapnik je pro běžného uživatele nicneřikající a matoucí


At least the UI history has something similar, if I'm not mistaken.

Could this inner loop be moved outside? It looks like a pitfall, given that there are `receivers ^ txs` iterations.


Nazval bych to jen Černobílá, mapnik je pro běžného uživatele nicneříkající a matoucí


Do you know the difference between `&&` and `and`? If not I would recommend you read these:

https://www.tinfoilsecurity.com/blog/ruby-demystified-and-vs
http://devblog.avdi.org/2010/08/02/using-and-and-or-in-ruby/


Левак по невнимательности.


Objectselection is geen Nederlands?


Please also add a copyright header for this file.


Maybe you also want to add a CONTRIBUTING.md file:
https://help.github.com/articles/setting-guidelines-for-repository-contributors/


If you push the sorting to the db layer, it will be more performant. Something like:

```ruby
@top_quizzes = Quiz.order(score: :asc).limit(10)
```

That puts all of the work on the db, instead of pulling all of the quizzes into memory to sort them.


't Is voor mij ook maandagmorgen ;)


BIP43 still has this requirement but it never mentioned ASCII.


The STO stuff has gone back to it's original homes in the last few commits - also FYI it's shouldn't be ```receivers ^ txs``` as ```vecReceipts``` only contains STO actions that credited an address within the wallet.  On my testing wallet for example it's 11 iterations (because I have received 11 balance changes from STO receipts).  Each individual STO receipt entry (each item of ```vecReceipts```) has the block number it came in and so we need to extract that before we can compare it...


Archivo README


test comment


You should use named routes, since your routes could change and you don't want to have to update them all over the place manually. If you use named routes you only have to update the routes file.


Klidně. Ale po přidání předvoleb už je to celkem jedno, takže jsem preferoval přesnější název.


The same logic I referenced in the other commit will work here, but you don't need the `Quiz` part since it is in the `Quiz` class. You can just do `order(score: :asc).limit(5)`.


Please also use curly braces if there's only one statement in the `if` block (http://wiki.languagetool.org/code-style).


unar is able to extract about any compressed file format available, including rar, without needing the dedicated external utilities. Maybe it should be made the preferred solution for *all* unpacking work?


It's just an [RAII](https://en.wikipedia.org/wiki/Resource_Acquisition_Is_Initialization) ...
I know that exceptions aren't used in QT, but I don't like the "old C style"  (or GTK) as:
```
aquire(...);
<work>...
release(...);
```


start program


i


This accidental change introduced an inability to set headers in the main PHP code.


actually that line should be the one that creates the opensslconf_$TYPE.h. it's fixed now. thanks!


@Yago You can remove these lines completely. :)


I am wondering: why don't you make this check once and for all at module initialization to maximize perf (in both cases, whether `buf.indexOf()` exists or not)?


These don't need to be assigned to variables since you are not using the variables. You can actually do `Fabricate.times(3, :puzzle, quiz_id: quiz.id)` and then just have your expectation.


but WorkGuard does not do anything. It just stores one bool with no external effects...


You should take the pens by const &


You can use named routes here too.


Didn't missed the `WorkGuard`'s constructor & destructor?


Not sure I understood this fix, but looks ineffective in 6.7.9.1:
![js css blocks not recognized in html](https://cloud.githubusercontent.com/assets/2916485/8277148/063689e0-1896-11e5-951f-884167f4544f.png)


Is it possible for this to happen? IIUC this would require explicitly calling AddImport("") which seems like a bug. Maybe we can just remove it?


_submit_ au lieu de _send_
_edit_ au lieu de _modify_


The lines below are mostly identical with the lines above in the previous if. With 3 or more, mostly identical lines, it's probably a good idea to extract these into a function. It's best to do this in a local lambda:
auto drawArrow = [&painter, ...] (QPointF arrow) { ...} // or something similar.


correct, missed


asdasd


I think I changed this in master. This does nothing, since p is immutable.


Would it make sense to keep `module.exports = ....` as the last lines in each file for consistency? It would mean to add another function variable?


I think this is a bit paranoid approach :) [but obviously correct]


The name of this method is a bit unspecific. Could you make it more specific? Do you expect that the returned item is always of type VViewItemNode or not? If so you might want to indicate that. In any case, it would be nice to use something that specifies what correct means, instead of just saying correct.


Don't forget to delete exporter!


Don't forget to delete importer!


Los fires pueden ir en un mismo file, no? :O


i like this change


Have you considered returning an empty list here? It's often better to return an empty list instead of null to avoid NullPointerExceptions.


Naast EBNF en Haddock hebben we weinig commentaar in de code. Het is mij in deze zin niet duidelijk waarom geen Haddock wordt gebruikt. Haddock kan namelijk ook gebruikt worden voor interne functies.


Why do you added "nameForType" method? Can't we just leave "typeName" method as it was (currently both methods do exactly the same).


De code sturen wij toch niet als appendix?


we completely loose the the types now, which I think was important


I'm not sure if I fully understand this. Can you elaborate a bit more? So now the CullVisitor will calculate the near far for each camera, including the main camera, so why the main camera won't have it's near far computed when it exists a subcamera?


appveyor says they set `CI`, according to their docs :)


I think you'll need this to have some leeway, hence the * 1.2. you'll be waiting 10 seconds, you'll need the test to timeout sometime after that.


It seemed to pull in a lot of dependencies (GNUstep runtime)... there are several other tools that can read ISO's in theory: 7z, iso-tool, losetup (needs root); and that could even be done in native code (maybe slow) https://github.com/kamwoods/isotools/blob/master/python/isoextract.py ...

It's just that this particular ISO image wasn't accepted by any other tool.


Maybe we can add tooltip to name of column because in translation name column is to long to show and we must resize column to see.

https://tvheadend.org/issues/2961


user controller뿐만 아니라, micropost controller에서도 필요하기 때문에 application controller로 이동


Hi @mgruner

Thanks for info. It looks very nice. I believe it could be useful for some tests where more window is used.
I saw that you updated some tests, if we should check something we will be able to do that. We can go through all test where switch_to_window() is used.

Regards
Zoran


Instead of updating the arrows in updateGeometry, do it in this lambda here. Maybe even make this a separate method.


The code below should move to a separate method and be provided as the argument to setDynamic2Items in addArrowOverlay


Put this in a separate method.


Nice! i stared at the 2 **N.A** pin info trying to figure out what are they used for only to realize they are just placeholders last week ;)


IIUC, this is not used - can we just remove it for now?


@MagdaMalinowska done in https://github.com/BuddyBroker/guides/commit/2b8765a166e8a22e673a8ec22426454e4889b144


@coolwanglu Thanks for making this release possible! @mark7, @GeoffMaciolek and @calculuswhiz Thank you very much for your contributions on this one!


As above - IIUC, this is not used - can we just remove it for now?


De code moest toch ook ingediend worden in een zip file dacht ik?

> Op 22-jun.-2015 om 09:30 heeft Daniel Schiavini <notifications@github.com> het volgende geschreven:
>
> De code sturen wij toch niet als appendix?
>
> —
> Reply to this email directly or view it on GitHub.
>


Doing so actually causes massive breakage:

```
test result: FAILED. 217 passed; 145 failed; 0 ignored; 0 measured
```
I didn't investigate on whether the tests now need adjustments, but if more than half of all tests fail one might assume the breakage is legit.

Failures usually look like this ...
```
---- test_cargo_test::lib_with_standard_name stdout ----
	thread 'test_cargo_test::lib_with_standard_name' panicked at '
Expected: execs
    but: differences:
  1 - |     Running target[..]syntax-[..]|
    + |     Running debug/syntax-982d16e54956bed1|

  8 - |     Running target[..]test-[..]|
    + |     Running debug/test-4c797b7e50f29162|
```
... or like that ...
```
---- test_cargo_test::selective_testing stdout ----
	d1
thread 'test_cargo_test::selective_testing' panicked at '
Expected: execs
    but: differences:
  1 - |     Running target[..]d1-[..]|
    + |     Running debug/deps/d1-b9baf528ccbc9e0e|

  7 - |     Running target[..]d1-[..]|
    + |     Running debug/deps/d1-eec1fa0ca148154c|
```
... and besides obviously different hashes in the latter case, I don't see much in them.


How to set the application icon:
right click the ratcycle project in solution explorer
click properties
click on application (on the left side)
under recources, change the icon to the GameIcon.ico
Done


See also my comments from conversionGenerator - this is pretty similar here.


Dat wist ik niet. Maar ik kan het wel toevoegen aan de batch :)


set_ver() が 「self.ver = ver」しかしていないため、
この時点で「self.ver = ver」でも良いかなと思います。


Thanks for this change - it's much better now :)


The URL is currently broken, and I encountered also a downtime a while ago. I don't know about the details of the servers maintainance, but if its frequently down we might have to think of a more stable solution.


When compiled without `-threaded`, all foregin calls block the calling thread (so effectively the whole haskell runtime).

When compiled with `-threaded` only `unsafe` calls (that are effectively just inlined function calls) block the calling thread [[1]](https://downloads.haskell.org/~ghc/7.10.1/docs/html/users_guide/using-concurrent.html) (and the calling Capability), but threads calling `safe` ones are suspended until the function returns (hence the overhead), allowing other threads (spawned via forkIO) to continue [[2]](https://downloads.haskell.org/~ghc/7.10.1/docs/html/users_guide/ffi-ghc.html#ffi-threads).

The rule of thumb I've been told to follow is to use 'unsafe' only for small, 'pure' computations that do no IO, especially those called very frequently, where the resume/suspend overhead of the threading can really be significant. For the rest - especially for relatively low frequency calls, calling out to other systems - go with `unsafe`.

My inclination would to use `safe` for most of the wrapped functions exported from librdkafka - looking at their implementation, most of them do non-trivial work, including calls to pthreads that may block for a short time, so I think that the `safe` call overheads would be acceptable. As those calls will probably return (almost) immediately, it may not matter much (although if they do some network operations, it may not be true).

Anyway, as the 'consume' calls are even designed so they could wait indefinitely (or at least for multiple seconds), signified by the 'timeout' arg, they definitely shouldn't be called as `unsafe`.

Actually I think `interruptible` would be the correct, not even `safe` [[3]](https://downloads.haskell.org/~ghc/7.10.1/docs/html/users_guide/ffi.html#ffi-interruptible), but that probably doesn't matter in most scenario).

Further readings I found useful while investigating the topic:
- [blog article [4]](http://blog.ezyang.com/2010/07/safety-first-ffi-and-threading) from E.Z.Yang (and comments)
- [commentary on the rts scheduler [5]](https://ghc.haskell.org/trac/ghc/wiki/Commentary/Rts/Scheduler
) on GHC Trac
- The [Concurrent FFI paper [6]](http://community.haskell.org/~simonmar/papers/conc-ffi.pdf) by Simone Marlow, Simpon Peyton Jones and Wolfgang Thaller.

ps: the other problem commonly related to FFI and external libraries, using bound threads (and the need to use forkOS), does not affect librdkafka as it doesn't seem to use thread-local storage.

[1] https://downloads.haskell.org/~ghc/7.10.1/docs/html/users_guide/using-concurrent.html
[2] https://downloads.haskell.org/~ghc/7.10.1/docs/html/users_guide/ffi-ghc.html#ffi-threads
[3] https://downloads.haskell.org/~ghc/7.10.1/docs/html/users_guide/ffi.html#ffi-interruptible
[4] http://blog.ezyang.com/2010/07/safety-first-ffi-and-threading/
[5] https://ghc.haskell.org/trac/ghc/wiki/Commentary/Rts/Scheduler
[6] http://community.haskell.org/~simonmar/papers/conc-ffi.pdf


Please forget the last note - for some reason even on an unchanged master I see the aforementioned breakage, even though only 144 tests fail instead of 145. This might actually show that only one test breaks when removing lines I originally commented on.
Now it's about figuring out why the tests fail all of the sudden.


It might be worth trying again without the overclocking, just to eliminate that as a possible cause. All chips are slightly different, and the signal paths that dictate the maximum clock frequency are also different. With each kernel the code changes, and this can cause an overclock that previously worked to fail. For some other boards it could perhaps also allow a higher overclock, but you wouldn't know that unless you tried.

[ Although I haven't studied the rpi-update mechanism, I'd be surprised if it was already running new code at the point of failure, but it's probably worth trying anyway. ]


@yuki24 1.3.6 has been released today, let me know if there is anything I can help. :beers:


Hi,
I'm very sorry but I only get unreadable characters shown (only readable word "musl")
Christian


I this we've made a logic error here, let's discuss in irc.


http://www.appveyor.com/docs/environment-variables

I think `APPVEYOR` can be an alias. At first I wasn't sure what `CI` was.


How about deleting the file as well?


Ah, thanks. I've corrected [the translation in the localeapp project](https://www.localeapp.com/projects/7829/translations/4841677?utf8=%E2%9C%93&in_locale=). Will be fixed next time we pull locales.


yes you need to add it in cms.env.json and lms.env.json inside Features section


The current is 10.10.3.  So let's just put 10.10!


for mac users, use this: http://developer.xamarin.com/guides/mac/deployment,_testing,_and_metrics/app-icon/


Why 5?
If it's an internal exit code, we should make it a constant and something that shouldn't interfere with a possible exit code returned by a valid command.


from ._speedups import compute_coverage
ImportError: No module named 'fairy._speedups'


@jef-n thank you!


Well, at the moment it's more like a development blog where I try to document all the things I do on my emulator over at https://github.com/simias/psx-rs

I want it to be a comprehensive guide to playstation emulation but currently I feel like I'm being too verbose for some things and not enough for others. There's probably too much code as well. It's the first time I try to write a doc like that so I learn as I'm making it.

You can find a rendered version of the doc here: https://svkt.org/~simias/guide.pdf

The introduction is pretty bad but I'll rework that later. I'm open to any and all suggestions!


Bonjour


:-p niet dat iemand dat ooit zal bekijken :-p

> Op 22-jun.-2015 om 09:47 heeft Daniel Schiavini <notifications@github.com> het volgende geschreven:
>
> Dat wist ik niet. Maar ik kan het wel toevoegen aan de batch :)
>
> —
> Reply to this email directly or view it on GitHub.
>


You're right. Thanks.


I think this deserve a comment in the code, since the reason is to not overwrite your specific exit code 5, or rewriting this code to make more visible this special exit code.


C'est quoi ce fichier commité ???! :angry:


I guess this was never updated to use the "Root resource" concept. Unless there is a good reason why it wasn't done I would vote for an UpgradeProcess that does it now.

@rotty3000?


great


We've upgraded to Symfony 2.7 so you can now use $this->addFlash() which is easier and shorter


That's my point. Why do coverage twice?


この辺、UpdateVMが参照しているから復活させて欲しい


Looks good. Could you add a comment like SIG_BLOCK, SIG_UNBLOCK, and SIG_SETMASK are 0, 1, and 2 respectively on Linux, while they are 1, 2, and 3 on Darwin?

Or, it would be even nicer to create a function like __translate_sigprocmask_how so we don't need any comments. See __translate_pshared for detail.


Forked Branch


This commit doesn't look correct. Granted we should close the Body stream in case of errors, but leaving out entirely the body() function and its validation of the incoming Content-Type looks wrong to me.
Especially in case of HTTP error where you'll read twice the response Body.


ready*


This solves partly my previous commit comment (in which case you need to squash this commit with the previous one). Unfortunately this leaves the now defunct `body()` function, and doesn't protect against incorrect Content-Type


LGTM


testing comment from vim


Hmmm, is URL: previous wel zo`n goed idee?


或许应该在issue中讨论，而不应该commit到目录，:D


Ok, thanks. It was worth another shot.

I'm merging this.


Gewoonlijk word je dan naar de juiste /components-pagina doorgestuurd. waarschijnlijk is er wel iets beters te bedenken, maar het is wel prettig om op de juiste pagina uit te komen :p

(natuurlijk stuurt deze momenteel ook door naar andere pagina's, misschien naar de editpagina als je iets verkeerd invult enzo...)


+# faygo-party+im mostly likly to be called silly+Just learning


Can you please correct the header?


:+1:  Thanks :smile:


A correct header should contain first the authors, followed by one (the initial) date parameter


I completely agree with you!


Can you eliminate this superfluent TrustZOne function from this code?


TeamCity Selenium POM :: CI [Build 17](https://teamcity.sponte.uk/viewLog.html?buildId=101&buildTypeId=SeleniumPom_Ci) is now running


There is really no purpose for a description if a command is hidden.  Things could be changed so that `yargs.command('secret', false)` would create a hidden command (if `description` is `false`, a command would be hidden).

But it would be good to hear if people actually want `completion` to show up in the usage first.  If `completion` should optionally be made visible, another arg could be added to the completion function.


looks good. wdyt about global rejection handler ? The one as here https://github.com/cargomedia/CM/pull/1754/files#diff-e0eff5171683d087113b5e2db9299f94R658


TeamCity Selenium POM :: CI [Build 17](https://teamcity.sponte.uk/viewLog.html?buildId=101&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:44


Hi Mats! I am making good progress, have one more question! You used a couple of registers to save flags, and I do not find out what the purpose is of them. Could you please explain the use of RX9, TX9, TMR1GE. As my processor has enough space and as I do not have this bits/registers on my pic, I moved them to variables, but I am not sure if I handle them correctly.


my guess is the animation does not happening on chrome from some reason, which keeps the opacity to be 0. FOREVER (:

![pic](http://i.imgur.com/rulviaL.png)


TeamCity Selenium POM :: CI [Build 18](https://teamcity.sponte.uk/viewLog.html?buildId=102&buildTypeId=SeleniumPom_Ci) is now running


哦哦哦


wow


TeamCity Selenium POM :: CI [Build 18](https://teamcity.sponte.uk/viewLog.html?buildId=102&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:33


Alternatively one could factor out the L2 cache controller and iplement platform specific hooks for this Pandaboard specific TrustZone hooks, but this is something I would do take over.


TeamCity Selenium POM :: CI [Build 19](https://teamcity.sponte.uk/viewLog.html?buildId=103&buildTypeId=SeleniumPom_Ci) is now running


测试


wow!


TeamCity Selenium POM :: CI [Build 19](https://teamcity.sponte.uk/viewLog.html?buildId=103&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:31


TeamCity Selenium POM :: CI [Build 20](https://teamcity.sponte.uk/viewLog.html?buildId=104&buildTypeId=SeleniumPom_Ci) is now running


TeamCity Selenium POM :: CI [Build 20](https://teamcity.sponte.uk/viewLog.html?buildId=104&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:29


we don't do the coverage twice. Phpunit generate the coverage an output it on 2 different forms ( a clover.xml file and an html report ). Then the clover.xml is pushed to 2 different services that try to shed some light on those raw numbers. Like evolution of the coverage and so forth. They are complementary.


wow wow!


TeamCity Selenium POM :: CI [Build 21](https://teamcity.sponte.uk/viewLog.html?buildId=105&buildTypeId=SeleniumPom_Ci) is now running


what about the other comment?


TeamCity Selenium POM :: CI [Build 21](https://teamcity.sponte.uk/viewLog.html?buildId=105&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:29


TeamCity Selenium POM :: CI [Build 22](https://teamcity.sponte.uk/viewLog.html?buildId=106&buildTypeId=SeleniumPom_Ci) is now running


ok


TeamCity Selenium POM :: CI [Build 22](https://teamcity.sponte.uk/viewLog.html?buildId=106&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:29


TeamCity Selenium POM :: CI [Build 23](https://teamcity.sponte.uk/viewLog.html?buildId=107&buildTypeId=SeleniumPom_Ci) is now running


another one. ya!


TeamCity Selenium POM :: CI [Build 23](https://teamcity.sponte.uk/viewLog.html?buildId=107&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:27


TeamCity Selenium POM :: CI [Build 24](https://teamcity.sponte.uk/viewLog.html?buildId=108&buildTypeId=SeleniumPom_Ci) is now running


another one. yaaaaaaaaaaaaaa


TeamCity Selenium POM :: CI [Build 24](https://teamcity.sponte.uk/viewLog.html?buildId=108&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:31


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.286](http://teamcity.monogame.net/viewLog.html?buildId=8321&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


fix some bug


Would you mind to resign the leading underscore character? We only use the for private or protected class members (referencing doc/coding_style.txt).


関数にする必要がないので、定数で良いかと思います。


I think this was more of a workaround. There must be a better way, as we managed to make this work on 8.1


I agree, a `<textarea>` would be preferable.


The `DateTime` & 'Timezone` are not top level widgets (windows) so the title isn't shown anywhere. I think just remal of the windowTitle property is what you've intended to do.


Including spec-arm_v7a.mk seems to be unnecessary, as it gets already included by spec-cortex_a9.mk.


msgで比較せず、下記でどうでしょうか？そうするとGeneratorが不要になります。

self.assertEqual(expected_reason, ex.kwargs['reason'])


:( this entire service was created to be sustainable. This is unfortunate. I have ping'ed the Galaxy team.


Following our coding standard, we leave a line above a comment.


ack


this function has two problems :

1. it should not its responsibility to create a new cell
2. it's unoptimal , you are creating a new object (allocating new memory etc.)  even when the state does not change ...


do you know why calling detachInterrupt() is not valid here? The only difference I can see is the deallocation of the handler, which is needed, or we may end up with leaked memory.


Looks good for me. We just need to confirm that we are using the same identention on all branches, and in all files, otherwise we can have problems with that.


Aside the few comments I gave, I'm fine with your commit, and willing to overtake it. Thank you very much for your engagement!


why 2 class,  which require you to make a allocation everytime you need a new cell, why no just using a flag isAlive and turn it  to false/true


These files are sources only. No they are not necessary at runtime.


why using a sentinel ?  just break when the value is correct


Thanks, @chrissnyder. What happens if n <= 0.1 and all of the ```sloan_singleband``` subjects have reached the retirement limit?


an exception is for exceptional that should not happen ,  not to be used as a if :)

instead create a factory method

World::from_size(rows, cols)

that returns null in case of invalid size

and you do while become

while (!area)


test


In this situation, you can set position with 'auto-bottom',it will automatically correct the position


it's not  C , why not putting choice next to where it is used ?


The deallocation of handler (i.e. delete handlers[pin]) for raw_interrupt_handler_t type was resulting in hardfault - SOS.
Also it's done inside allocate_handler() for std::function<void()> version of attachInterrupt()


is it broken?


lol !


ok. i think it's fine


What's the point of doing this? Values of mDecoInsets are never used afterwards?


Why do you call close() here? Flink is calling close automatically.


why do you need a separate for loop, just do the init in the for loop below


why do you use a 2 dimensional array, if you use a uni dimensional array you only need to alloc 1 array regardless of the size,  while with your 2 dimensional arrays you need to allocate a shitload of array.  and now to access to an element you need to go through 2 indirection instead of one .


Can we dig deeper -  do you know why it's causing a SOS? Probably an invalid pointer, but I don't see why from the code. IMHO, the change is more a sidestep of the problem rather than an actual fix, so my concern is the problem could reappear anytime.


if you use only one class for dead and alive, you now don't need a if else anymore as you can do

isAlive = random.nextInt(RANDOM_MAX) == 0
array[i][j] =  new Cell(isAlive);


isn't it strange that Android requires a different name?


function should be renamed as well


??  i can't make sense of this method that seems highly convoluted and inefficient


why was this necessary again?


rename as well


I would add a check if land != null!

Player can have lost meanwhile and the permanents are removed meanwhile.
Or the land can have left the battlefield since the event happened.


you broke javadoc again. Use < for '<' and > for '>'


I wonder if `delete` is NULL pointer safe? In the C++ standard it should be, but our implementation of delete in newlib_stubs.cpp doesn't check for NULL:

```
void operator delete(void *p)
{
	free(p);
}

void operator delete[](void *p)
{
	free(p);
}
```

That might be the reason for failure.


@flavour Is this enough for location hierarchy? This is location_id in cap_area.
There is already location_id for cap_area_location  in https://github.com/flavour/eden/blob/master/modules/s3db/cap.py#L834.


About the commit message: 403 is forbidden, different from 401 unauthorized (grammar nazi: no authorized is wrong, not authorized or, better, unauthorized).

In the code is ok the error.


Probably that could be a reason but I tried doing a NULL check before delete and it didn't work.


Les NPC peuvent-ils teleporter d'un serveur à un autre ?
Can NPC teleporter from one server to another ?


Do you think `O_EXCL` would be needed here to assure proper operation ?

I am currently looking into options for file-based locking for cargo, and still wouldn't know how to achieve something like it on windows, especially something like `F_SETLKW`.

Also it seems cargo can't use GPL licensed software, but would be fine with LGPL.


I think a ```cp``` command has caused openssl to be come aliases.


Hi!

You are correct in moving them to variables! That is really ugly and
something I should fix myself. I have optimized the code since doing that,
so I think I could move them to a bit field variable also, or at least add
defines to explain them better.
They are just used as flags. TX9 keeps track if temperature 1 or
temperature 2 (from the optional second sensor) should be shown on the
display. RX9 is just used to make SA flash and beep in an interval if a
setpoint alarm is detected. TMR1GE indicates if we are currently in the
menu, if so then don't 'overwrite' the display with the current temperature.

Cheers!
//mats


string concatenation like you do is inefficient in java because you make your string to realloc memory one character at time, though from one generation to an other, the size of the world does not change ,  so you should have a preallocated string that you will fill up


The new tests are failing in OSX. @andrewgaul @lmivan I see several tests in this class are ignored in OSX (but don't know why). Should these new tests be annotated accordingly?


ack


I am also seeing regressions in my iron-form after updating to the latest versions. In particular, even though both my paper-input elements are marked as required, I am able to submit the form even though they are empty. Also the styling seems to be broken, the line beneath the control stays gray and it doesn't get the animation and the color of the header.


@jef-n Nice. Could pyspatialite also be added? I think that's the reason for the last failing test.


well done :)


Those ARM commits need more testing.. :P


This commit actually breaks the view, please check the screenshots:

Before

![before](https://cloud.githubusercontent.com/assets/461719/8278360/0316ab70-18cb-11e5-8817-e7a4b42b5f72.png)

After

![after](https://cloud.githubusercontent.com/assets/461719/8278364/05464220-18cb-11e5-8fd6-b68a340e17a4.png)


and even more, you don't need an object at all , as you can simply have a an array of boolean :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.286](http://teamcity.monogame.net/viewLog.html?buildId=8321&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:23:30


Do you want the documentation about the library (dev part) to be erased ?
http://www.feelpp.org/docs


otherwise users could appear twice in the user list, when they are in multiple groups. once with "staff" flag, once without.


But at least we could avoid common pitfalls with the auto generated password.


I didn't notice until I fetched this commit.

Now when I do apothecary -t ios update openssl. It only leaves this in the git status:
```
        typechange: aes.h
	typechange: asn1.h
...
```


Logic is not good. This function can be very small.


Why there is only one class?
Where is the `DiceSet` which was already created in this project?
There should be `Player` and `Game` classes as it was mentioned in comments.


% Create Time, 4 records.
epochTime = EpochTT(EpochTT('2002-03-04T09:30:00Z')+(0:3));
% Create arbitrary data, 4 records of 3 dimensions.
data4x3 = [1 2 3; 4 5 6; 7 8 9; 10 11 12];
TS_xyz = TSeries(epochTime, data4x3, 'vec_xyz'); % TS XYZ vector
x = TS_xyz.x; % Access data

% Transform or create any other format other than XYZ vector
TS_rlp = TS_xyz.tranform('xyz>rlp');
TS_rlp2 = TSeries(epochTime, data4x3, 'vec_rlp');

% Try to access data will result in error...
r = TS_rlp.r;

% Error traced back to
  teno = obj.tensorOrder_;
  if length(comp)~=teno, return, end % <- 1 = 1 .. Ok..
  basis = obj.BASIS{teno}; % <- THIS will result in "basis" being
  % identified as XYZ and not RPL which it is. Then trying to get R from
  % XYZ will fail in the following:
  if ~any(basis==comp(1)), return


I can imagine this would not work correct if a Target Shapeshifter from Opponent get's e.g. hexproof before resolution. It should do nothng then but I guess it will do the copy now.
Good case to define a test method in Mage Test project.


you repeat the same test over and over,  making your code convoluted and inneficient

instead do  a

bool  isTop /  isLeft /  isRight / isBottom

so that after you do

if  (!isBottom) {
      below = // you're a smart man so you use an one dimension array for your table, so you can represent by one number the cell below/above/next/right  the current one =)
      quantity +=  array[below];  // because you're a smart man who use boolean so you have 0 for dead and 1 for alive so no need for a if =)
}


Yes, I made the exact same mistake when developing pvr.vbox.


Removing this constant breaks the whole gem when loading it together with Rails. This file requires this constant: https://github.com/hexorx/countries/blob/master/lib/iso3166.rb#L9


If you dont have Geometry under the main camera but only sub camera rtt, the main camera will have an +/- infinit near/far plane. It means that if you send a compute intersections it will not work as expected.


The reason behind this lines is some commands do return error output but are not setting the exit code after the command is done, im just trying to make sure that if there is error content and the exit code is 0 the exit code is set to 1 as there are errors.
Makes sense?


I am ;)

Still the name of that method freaks me out (`transition.author` does **not** look boolean), but this is no crime you commited ^^


Попробуй

```
$ python setup.py build_ext --inplace
```


and if you're really clever, you can do without a single if at all =)


Done.


Fixed a potential buffer overflow


@wkyoshe I do not have on my computer this path.
Please use relatives paths.


Please update it complete.  There are more obsolete entries which can be replaced.


가능하면 이슈와 직접적으로 상관없는 스크립트는 별도 가지에서 처리 부탁드립니다.


Ok, now I got it. The point is that you don't have any Geometry attached. Maybe it would be good to state it in the comments.

Thanks so much for the explanation.


Just pulled this finally into a standalone package.


Hi!

Yeah, there should definitely be some close at all. Also happy to bump this to 1.6.

One thing though, I was assuming that if you did a close on the outermost stream, that would close all inner streams?

-M


Can mt7601u_rr be ran concurrently by more than 1 thread?
I can see race condition here: dev->dma_reg can be invalid.


Make sure the hook is executable. I think that it doesn't make much sense to check the permissions before, like to check whether the file is executable and only proceed if not. Just setting the permissions is fine.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 319](http://192.168.30.225:8111/viewLog.html?buildId=1393&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


I just picked 5 as i dont know anything that particularly uses 5. Im trying to achieve a distinguished error exit code if the connection was terminated mid command. EG: Server rebooted mid way trough it, or you lost connection.
I dont quite follow what making it a constant will fix.
I do notice that it gets complex separating internal exit codes and command output exit code, but i dont see a clear separation in the current implementation.


I briefly patched up tahr and tested the fdrv patches. Indeed it loads fdrv.sfs only when the "pfix=fw_drv" is passed as boot argument.


The parsing code must not be duplicated because ``HTTPUtils`` is in iceland.

@lestarcdog Do you mean because of the try-catch block there might be performance issues?

@autermann Do you see performance advantages of logging a String instead of the accept header?


Great! I'll merge this into the admin-layout-update branch and reinstate that later. Will also update the default theme template and setup database with these new tags.


Should be inside `DiceSet` class. Local methods should not be used inside classes.


Funziona bene. Solo una cosa. Visto che sono minimalista mi piacciono gli indirizzi senza www. Che ne dici di usare geekbreakfast.it senza www come canonical?


APCast is a wireless AV transmitter supporting UPnP.


Ill squash this with the previous command, i dont see where it was checking correct content type, it was jut verifying it was able to parse it and the code is still doing that as far as i see.


ロジック側の例外はstdoutとstderrを.replace('/n', '//n')したものを格納していますので、こちらも同様に置換してください。
メッセージ用定数（DOG_CLUSTER_RUNNING、DOG_CLUSTER_INFO_WAITING_OTHER_NODES等）に'//n'置換後の文字列を設定してもよいですが、改行があった方が可読性が良いと思いますので。


This should be inside `Game` class.


Nice commit =)


why did you add [] to name?


Lot of logic outside classes. Methods should not be more than 10 lines.


Do you mean the camelcase in the argument?


Not sure what you mean here?


Ah, good spot. That's the wrong choice of words on my part. I meant to say the full filename (including the extension) of the partial, not the full path. I'll update it.


@renujhamtani should we not keep this router file ?, i suppose this could act as a framework for any future A/B test scenario and we could just change the testgroup.


I ran the unit tests on Travis and I found that all the tests that are using the `fade` transition, fail on IE.
I noticed there are already a fade test that is skipped on IE (Line 211). Should we skip those tests too ?
Link to the Travis build : https://travis-ci.org/EAlexRojas/deliteful/builds/67522672


Huge method. Should be refactored.


hey,  may i talk with you in skype or etc?


was just looking at that url and i noticed for Afghanistan we have AFA as code and that site lists it is AFN
Maybe we got to review all our currencies and update ?


Thanks, now I know how to monitor nf_conntrack_max.


Ok, os it's not a NULL pointer. Do you have a reproducable test case so we can debug and get to the bottom of this? I also wonder if we really do need to dynamically create the std::function instances. A simple static array of instances should be sufficient, afaik. If you have a test case and would like me to look into this, let me know.


Good idea!


Please remove!


Music seek isn't working. Reverted it


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 319](http://192.168.30.225:8111/viewLog.html?buildId=1393&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:34


Prefer single-quoted strings when you don't need string interpolation or special symbols.


Extra empty line detected at class body beginning.


Extra empty line detected at class body end.


TeamCity Ybackend :: synteny/ybackend [Build 44](http://192.168.30.225:8111/viewLog.html?buildId=1395&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


Use `fail` instead of `raise` to signal exceptions.


Why didn't you use the QueryBuilder here ?


17周心得


Sorry, I'll fix it later


I'm afraid of a case where a command exits with code 5 and then the library gets confused. I would have preferred using a larger number than the maximum known windows command error code (https://msdn.microsoft.com/en-gb/library/windows/desktop/ms681381(v=vs.85).aspx). Which you could put in a constant somewhere so that other part of the code wouldn't have to refer to '5' in several places.


Lovely, thanks.


Use a guard clause instead of wrapping the code inside a conditional expression.


Yes, it makes sense, but as I understand it you don't want to erase your exitCode if it is 5.
A more compact code would be
```go
// Some commands can error, but still return an 0 exitCode. In those cases, we want to signal our callers
// that something failed.
if comand.err != nil && command.exitCode == 0 {
  command.exitCode = 1
}
```


Please, merge with master.


In fact, originally the `exitCode` was for the run command, and the `err` was for the library internal error messaging.


Very true, I have this fixed locally but didn't push it out yet. I will rebase `testing` soon with the latest version of my fixes. Code from this repo does not build any more on Linux 4.2 which slows me down :/


Do we move such type from types::PublicSignKey to here? or would it in the end stay in types?


ugh, yeah i changed it to copy the full openssl directory but didn't realize that that folder is only links to the original files. i'm fixing it


fix code


fix redefined arginfo_kscan , arginfo_scan


You need some extra lib from your stock kk.
Try open camera from lockscreen and share your logs.


Why not reusing `initializer`?


Unfortunately it currently goes BOOM! Without this assert the following line writes out of bounds and goes BOOM! some of the time. Like it says in the pull request this patch is NOT for merging. That's the reason for the debug printfs. When someone figures out how to properly fix it I'll either revise this patch or the person who figures it out can just close this one.


@OwnDroid @akhilnarang
Your ROM is Good :+1:
But Please Maintain Authorship, You Didn't Ported This Feature.
So Please Give Full Credits To That Guy or Add Commits Link In Commit Msg From Where Did You Ported :)


indentation


이거 바꾼 이유가 멀까요? rectangle 이라고 의미를 정해서 Rect 인데 ㅠㅠ


I don't know if this is a good idea. Cleaning everything silently. Ran into some issues while setuping new project.


Ah yeah - we stopped doing that in client and I was just experimenting with what it would be like if we didn't do it in core :)


Surely it shouldn't be running in debug mode unless e.g. `int(os.getenv("NCSS_DEBUG", "0")) == 1` or some such?


Sorry for not being clear about what I meant.

Prior to your commit, around line 52:
```go
 	if resp.StatusCode == 200 {
		response, err = body(resp)
 	} else {
```
It was calling the `body()` function which checked the response content type (and also was closing the Body stream afterward).

I agree that we need to close this stream also in case of errors (hence the defer you added), but in your new implementation, we lost the content type checking and also the `body()` function has no reasons to stay there since it isn't called anymore.


Is this an intended new pattern? returning the result;  I assume you will want to validate the signatures before returning the type?


Let's not forbid that. There's value in being able to use op(A /B ) for integer division with standard integers.


TeamCity Ybackend :: synteny/ybackend [Build 44](http://192.168.30.225:8111/viewLog.html?buildId=1395&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 82 Build time: 00:13:10


I don't know that dispatch an event to do the job is the right way. What if you have several process to do in a specific order ? As the main purpose of your command must to reset the highscores, I think it should call all services or other process directly instead of dispatch an event. However, dispatch an event after the process make sens, HIGHSCORES_RESETED. What do you think ?


I agree. I've only dealt with mutable state in C/Java/C++ and it was initially odd to me that from a reference of a composite type, one cannot get a reference to its sub-object.
Similar to your suggestion, I wonder if mutable arrays, e.g. of ints, should be modeled by the type
vector (ref int)  instead of ref (vector int). I find the former closer to how one accesses mutable memory.
I can explain more when I come back next week.


Create a HipayTransaction resource in python API so users can ask hipay transaction status to be refreshed using **order_id** when their users reach their redirect page.

This must be used when an application uses hipay payment backend to avoid manually clicking on "Authorize" button when order is authorized (when you're in prod, you won't know if end-user has authorized the payment or not).


that works for me.  alternatively:

```haskell
xdocs = prettyMimeRender . docs
  where
    docs Api_Simple     = Simple.docs
    docs Api_Adhocracy3 = A3.docs
```


Посмотрел, вроде должно работать https://github.com/flavio/qjson/blob/master/src/parser.cpp#L117 и ok в данном случае не похоже чтобы менялось и в оригинале.


хотя нет невнимательно смотрел )


Before the change, if you enter 1001 two times in a row, second time it will show 1001 inside the field and won't adjust it to 1000 (max value). It's happening because the check `this.options.value !== this.last_value` works with already adjusted values, not actual user's input.


Okay, let's go for it.


I have trouble parsing this sentence.


No this was me getting around the fact sodium does not implement serialisable types. So Instead of moving to vectors I used this PR to mimic the sodium setup and see if it could be made better (so redirection here, which is bad). I have a separate PR in the making for sodium to apply these traits to their types in a safe manner (obeying the memory wipes etc.). I expect nearly of these mimic types to now be removed here and I will use a github repo until sodium can supply traits on the types. This will clean this up a lot I hope.


missing empty lines


Done. Check out 70a4324b72e


Yes, we won't be able to construct a type that is now secure in this way. I feel it is more solid to not be able to construct unless everything works. I am still looking at parsing into types as well as these need to remain secure. Query for the name will help, I hope we do not require to use a `validate()` but we will see.


{this} instead of card name


You can use spell.getLogName instead of sell.getName to have colored request text.


Sorry I don't understand your question. This project is CM-based, so it will use the global handler, which is good. Did I miss something?


This doesn't take range of influence in account or?


d


В этом цикле нет необходимости, уже есть верхний цикл, в котором можно и обрабатывать ситуации, когда введено не число


Hello, I cannot understand category_id = mp.get(args[4])[0], because mp.get(args[4) return int , it's not list


Излишнее создание объекта Scanner каждый раз, можно было создать один раз перед циклом и использовать


is that a leftover from the 1.0?


здесь нет проверки, второй раз я могу ввести опять не число, а лучше считывать число первым, и когда введен 0, просто выходить


Done: 284d7ffad31bc814db59e29a98b3eb2b4be1933d


spelling fix


Thanks a lot for fix =)


Take a look at my fork of UltiSnips.

It's possible to have alias `i` for PHP, which will autoexpand into `if` without tab trigger. In your case you can type something like `ie` and it will automatically expand into `if (|) ...` on first keypress `i` and into `if (empty(|)) ...`


idd, github is veel handiger


Pull requests are easy to revert. Whenever in doubt, google it.


This commit breaks compilation on master branch.

Essentially the new "trim" on line 409: kv[0] = kv[0].trim();
make the tests in CassandraAdminTest.java fail.

Unfortunately I cannot tell if the trim should be there or not, but if it is safe to leave it you may want to remove the extra spaces in CassandraAdminTest.java (line 39-43) so master can pass tests and be successfully built. Thank you.


Why is or instead || , and instead && used?
And when a replacement, it should bo done in the whole file (not it is a mixture).


Oh. Sorry. Yep. It's CM-based. I have no more questions.


looks ok then.


> BUGについては、YPSへpull-req、Issue、コミットコメントを頂けたら嬉しいです。
すみません、気を付けたいと思います。


add dynamic soql


Залил на npm апдейт, версия 1.06


@Seldaek l Found this too late, anyway, thanks for the info, doing `sudo composer self-update` fixed it!
Please discard my pull request,
cheers :)


add white space after if statement


ok


We should point to [Bug 1172906 - (messages-nga) [Messages][Meta] New Generation Architecture](https://bugzilla.mozilla.org/show_bug.cgi?id=1172906) somewhere :)


move Test.startTest() statement before creating Controller object


Обрабатывать так ошибки в данном случае можно, только здесь не учтены все ситуации. Об остальных замечаниях на занятии, они просто общие для всех.


nit: maybe ```Service Worker and ServiceWorkerWare library```


Should this be a list of _issues_ and not _characteristics_ as mentioned above? To mention a few:

* complex update mechanism
* less than ideal launch speed
* animations jank
* inability to leverage multi-core processors in full
* .... and etc.


Not sure but maybe we also should mention [```Channel Messaging API```](https://developer.mozilla.org/en-US/docs/Web/API/Channel_Messaging_API) and [```Broadcast Channel API```](https://developer.mozilla.org/en-US/docs/Web/API/Broadcast_Channel_API). They are independent, but we'll highly rely on these "tools".

```Navigation API``` can probably mentioned later in ```Views and Navigation``` section.


你不该这么写，很耗性能


Maybe ```business logic``` will be less confusing, ```model``` can sometimes refer to state/data object passed between service and view controller. But maybe it's just me :)


How about  ```Provide full-fledged (first-class or just full) offline experience with various Service Worker cache layers``` instead of these two highly related points? Or what did you mean?

nit: I see both ```service worker``` and ```Service Worker```, maybe stick to ```Service Worker``` only?


nit: maybe ```HTTP-based apps``` ----> [```hosted apps```](https://developer.mozilla.org/en-US/Marketplace/Options/Hosted_apps)


To me ```Landing code in master``` sounds like we migrate master to nga, but in fact we have two different version that co-exist side by side, maybe ```Landing code in master (base and nga versions side-by-side)```? Not that important though since you'll be there to explain :)


```Each panel has its own JavaScript behavior object``` or maybe joined (if not too long) ```Each panel has its own JavaScript behavior object with life-cycle methods```?


Maybe ```CSS transitions and transformation``` will be clearer?


Maybe ```Same URL for all panels``` as it could be either hash or push state?


```Firefox``` Yay! :) Not everyone in gaia can say that :)


stylistic nit: in some lists you don't use dot or semi-colon at the end of list item, but in some you use :)


mmm, sorry didn't get ```Some model is in the DOM.```, do you mean that we leverage ```HTMLElement.dataset```?


TeamCity Xbim :: XbimGeometry :: XbimGeometry [Build 4](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=13&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


use "for(Employee_Task__c em : ems) {
}" instead


catching error when long url already exists.
Adding replace shorturl by longurl from yourls. Not working correctly yet.


@Hellowlol I was trying different things to try and get it working and the documentation said to use names ending with an array and example had [].  At this point it's just experimentation on this isolated branch - thought I'd check with you as to whether it was viable to implement as I've already spent hours trying to figure it out so didn't want to waste more time if it wasn't workable.


postというとget/postのpostだったり色々な意味があるので，個人的には長くなってもmicropostとしたほうが読みやすくて良いのではないかなあと思いました


1. When I was splitting panels into separate views one of the issues I had is that views were passing non-simple data types when they navigate to each other (e.g. full draft object when we navigate from Inbox to NewMessage and some other case as well). It's hard to replicate when we use _real_ navigation with URLs and query strings;

2. Also there is no direct access to the specified view (e.g. for new activity request or notification we should go to Inbox and only then to Conversation/NewMessage view);

3. Maybe also simultaneous access to several data source at startup (contacts, threads, drafts) that slows us down or maybe it's for ```Services``` section?


guard clause would raise `AbstractController::DoubleRenderError`


Almost, in 99% cases, I recall our separate startup files :)


last commit fixes it


Graylog 1.1.x is final, only the puppet module is not released yet. The puppet module version is not tied to the Graylog version.


We have meta for this if you want to add [Bug 1155507 - (messages-nga-views) [Meta][Messages][NG] Separate panels into dedicated views](https://bugzilla.mozilla.org/show_bug.cgi?id=1155507).

> remaining ones are still in one of them.

I'd say that it's quite beneficial and allows to gradually extract views and be fully functional :)


I'd specifically note that it really blocks quite important functionality like activities, notifications (we may also point to the [Bug 1172006 - [Messages][NG] Use Notification ServiceWorker API](https://bugzilla.mozilla.org/show_bug.cgi?id=1172006) as possible solution), alarm and sms-received


Or have view-in-iframe where top level document can handle system messages for us and navigation happens inside iframe.


I think this assertion can be enabled now, providing that you set `TestModel.settings.applyHookUpdates` to true?


why???


Should we mention that all this looks ugly until we get support for http://chrislord.net/files/mozilla/gaia-navigator/spec/navigation-transitions.html? And pre-render support (in a much less degree if we support render cache). I can host on github.io this version to see how it looks like without navigation transition :)


typo? ```responsibility```


Nice.

You want to make a new branch to test this?  I was going to at some point for the massive changes needed for the xwin/xorg-wizard (etc,etc) changes that I will get to soon.

I want to add slackware-current support too. It's quite easy really, but you don't get dependency checking as Salix only sticks with stable.


What about ```Services: current status and issues``` with:

* Point to [Bug 1162031 - (messages-nga-services) [Meta][Messages][NG] Migrate business logic to bridge-based services](https://bugzilla.mozilla.org/show_bug.cgi?id=1162031)

* Tell about about threads/brdige naming problem, update scripts to work with bower;

* Maybe point to [Bug 1164539 - postMessage during document load is slow](https://bugzilla.mozilla.org/show_bug.cgi?id=1164539), as we'll be affected once we use services on startup.


We can point to [Bug 1172902 - [Messages][NG] Use SimpleOfflineCache to cache all app resources](https://bugzilla.mozilla.org/show_bug.cgi?id=1172902). Our main dependencies are various Gecko problems with ```app://``` protocol.

I think I'll be able to host this on github.io by Wednesday, so that we can open it in nightly and see how it looks like.


this has nothing to do with your error, it complains about the database being already open.


LGTM


We should probably add a migration to remove the column as well.


unar wasn't able to decompress the files I stumbled on, it can only uncompressed the same files as the free version of RAR; these archive could only be uncompressed with the non-free version


Unless i read the docs wrong this should be used for multiselect. None of them should be multi as this will fuckup things. Does it work if you remove it?


Even though SIGPIPE is being ignored, the server eventually starts to fail to write to broken pipes. The CGI test script also gets broken pipe exceptions. On top of that there is still a deadlock (which is probably unrelated).


Исправил замечания.


we can rerender only a part of page. There is no need for reloading the whole page


@chris5560 Under MUSL not functioning properly?


Для вывода текста с переводом на новую строку лучше писать ```java System.out.println()```


В целом хорошо. Некоторые общие замечания обсудим на занятии


yes, me too.  thanks, fixed.


It would be nice to have this operation named. I suppose it's `HAS_PRESENCE` from the java client library (https://github.com/ably/ably-java/blob/master/src/io/ably/types/ProtocolMessage.java#L47-L49).


testUserDetail_InitializeAdmin, testUserDetail_InitializeTasks, testUserDetail_InitializeEditMode can be combined in one test method. There are no different usecases, that's why there should be a single test method.


I find it difficult to know why we separate the locking process from the normal `syncStart`. I guess it's a case where comments would be helpful.


this is fixed on master.


Apologies: pushed this in error to master. As it's only one file, it's not worth reverting.


why are you calling init() method second time?


I didn't understand how your std::function based overloaded attachinterrupt method work so didn't tried getting into the C++ details. Would be great if you can look into this.
A simple way to reproduce the SOS issue is just call the following in your setup code.
attachInterrupt(DAC, ANY_ISR_CALLBACK, FALLING);


move Test.startTest() instruction before controller creation


ここかな (favorites_controller#createで@userはいつでもcurrent_userなのでここで数がcurrent_userのものと連動してしまう)


This unrar support is needed for a single demo that is also available in .zip format.

```
unar /home/tchet/gdp/arx/arx_demo_english.exe *.cab
/home/tchet/gdp/arx/arx_demo_english.exe: Embedded RAR
  Setup1.cab  (101581207 B)... Failed! (Attempted to read more data than was available)
  Setup2.cab  (23103162 B)... Failed! (Wrong checksum)
  Setup3.cab  (28787575 B)... Failed! (Wrong checksum)
Extraction to directory "arx_demo_english" failed (3 files failed.)
```


Ignores .idea


В целом нормально, некоторые общие замечания обсудим на занятии. И в следующий раз следуйте заданию.


@koorchik Спасибо!


Ping. Is this going anywhere?


Ack (modulo fixing the subject line).


Looks good. I had already started on a state object and the wicket code to save/retrieve it in a branch but I'll merge yours in and my bits into yours.


does this cause other regressions?


Не учтена ситуация, когда при вводе массива произойдет ошибка, в таком случае массив не будет заполнен, но при этом следующий код для него будет выполнен


I will Thanks for the warning


Actually, Authors=Lars Windolf <lars.lindner@...>; Simon Kagedal Reimer <skagedal@...>

Notice, `;` instead of `,`.


1st RULE: You do not talk about FIGHT CLUB.


Does the test_logging still work?  If so, you probably got this right.


@hinds89 this is awesome!


Fixed in https://github.com/ScienceCommons/api/commit/c29230820c1ff8f288c4e981c169c02cfba77c1c


asdasd


The table was created few lines above.


No worries, but I'm still curious why it's being flagged :D


Why this tests were removed?


@vdaubry why 1am?


I fmessed up the commit message; it should say "Changed completion modal watch to be on $scope instead of $rootScope"


File looks like tabs instead of spaces


https://dicapricorn.wordpress.com/korku/comment-page-1/#comment-1    yoorum
atarmısınız biraz ilgi laazım

2015-06-22 15:45 GMT+03:00 0014 <notifications@github.com>:

> :D belli oluyor zaten
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mrgenco/squaregame/commit/9a0db444a019aaaea0e35ac36ac322444564068b#commitcomment-11793123>
> .
>


What is confusing? Inheriting from cons?


Xuper!


Requested comment added


How could this file end up with a version number that differed from the actual version of the file?


@codyopel


Nevermind... this is a shell script.  I thought it was editing a VS file itself.


يسسي


I have no idea if this worked.  Presumably, you tested it by opening the resulting file.


I kind of see what you're getting at, but IMO the parens are oftentimes not helpful in scanning the meaning of a condition.


This change was done on purpose to increase efficiency, given this executes in constant time.  Why did you revert it?


Did you mean "canola"?


1679-DualDuct (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2192 of 2216 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.92%25-yellow.svg)


I'm getting a compilation error after these commits:

imp_clean/modules/multi_state/bin/multi_foxs.cpp:325:24: error: variable of type 'IMP::saxs::RatioVolatilityScore' has protected destructor
  RatioVolatilityScore rv;


This could be improved so that it does not make the call to subList() if there are <15 entries using a conditional.


That should be *ado*


162000 on yuga? Usual UC is 192000. Also you need the UC freq here:

https://github.com/xLaMbChOpSx/android_kernel_sony_apq8064/blob/151ff4da064450528c213fcffb8de68bf6cb0840/arch/arm/mach-msm/acpuclock-8064.c#L660


I switched it to QRegExp until we know.
The whole project can be converted to QRegularExpression later.
:v:


If I read this correctly, when I incr instances, all mysql will be restarted?
Two questions:

1. I assume this implies that all app connections to the database cluster will be rolled. If unlucky (ie, they re-connect to the next node that gets restarted), multiple times?
1. In the current Amazon AZ deployment, will it restart all mysql instances across all jobs, or just the instances in the current job (eg, mysql_z1). If not all nodes, is that a problem?


+*.php


Here's a screenshot of pwrap in VICE, as of 06-22-2015.  For this example, I set the left and right margins to 6.  I'll be doing more testing, with various margin values.  I'll need to add some code to verify legal values for margins, etc.- that is planned for the near future.  In addition to adding the left and right margin capability, I cleaned up some code and comments.
![vice c64 emulator running pwrap 06-22-2015](https://cloud.githubusercontent.com/assets/12759129/8296264/7177dfac-1903-11e5-965e-2f68f05fa8e5.jpg)


Сontrol of X/Y limit switches in the calibration knocks down coordinates (if the limit switch is not the end point of movement)


Script ran without errors on server vm.

settings file correctly updated, with correct dates in correct formats.

stock codes table has been updated with the used codes.

stock_prices has been updated correctly.

stock_volumes has been updated correctly.


It seems the array new expression is adding a move-constructibility requirement, which we don't want here. I suggest we only test for array new if `std::is_move_constructible<T>::value` is true.


Acceptance testing for python 3.4 passed.

Acceptance test for python 2.6.* awaiting.


Please make "unhealthy" a link to [unhealthy](https://github.com/cloudfoundry/cf-mysql-release/blob/release-candidate/docs/proxy.md#unhealthy).


Yes, that is an improvement.  I can work on it.


css


Adam olun sümüklüler

2015-06-23 3:11 GMT+03:00 murat gencosmanoğlu <
muratgencosmanoglu1764@gmail.com>:

> https://dicapricorn.wordpress.com/korku/comment-page-1/#comment-1
>  yoorum atarmısınız biraz ilgi laazım
>
> 2015-06-22 15:45 GMT+03:00 0014 <notifications@github.com>:
>
>> :D belli oluyor zaten
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/mrgenco/squaregame/commit/9a0db444a019aaaea0e35ac36ac322444564068b#commitcomment-11793123>
>> .
>>
>
>


Disabled scrolling because it was getting annoying...


Ton correcteur orthographiqe ammène des fautes. Dualité sans e à la fin !


I moved the spritesheet texture to here because it didn't really belong in the player bit.


Oops! nothing new in this commit.


The old graveyard window is terrible. Burn it with fire.


Hello. I am enrolled in the Coursera R Programming course and am grading your Programming Assignment 2. In its current state, this repository doesn't contain the required cachematrix.R file. However, in this commit you added the cachematrix.R program but in the next one removed it. Can I suggest copying this file and committing it back in so that your repo is complete and your Assignment can be graded correctly?


@josharian: I found a failure mode. If there's code like this:

```go
blahTimeout := time.Minute
...
time.Sleep(2 * blahTimeout)
```

then this check flags the `2` expression on the last line. Is that easy to fix?


SeqPoint is a structure, so the two lines are kinda the same.


Heh heh. You were entering that on the command line without using single-quotes or backslashes, weren't you? :) Thanks for letting us know!


Commit message has `rm -Rf`.


Maaaaaaaaaaaaaaaybe. I will neither confirm nor deny :wink:


It's also breaking on code like this:

```go
var maxDays = 90
maxDuration := time.Duration(maxDays) * 24 * time.Hour  // it is flagging "24"
```


@akiran hey I think you forgot to update the dist files.


Drat. Looking...


Useless assert. Will always be true.


And another:

```go
type opts struct { period time.Duration }
...
var o opts{}
oneThird := o.period / 3 // it is flagging "3"
```


Cheers


Awesome, good catch!


Eh. That's not the only thing going on

[![this is weird, too](http://i.imgur.com/LJhxoiG.png)](http://i.imgur.com/LJhxoiG.png)


If you make a new `mbed` directory under `firmware`, you can put these cmake files in there, then just change the `include(arm_toolchain.cmake)` to `include(../mbed/arm_toolchain.cmake)` and it should all work without having to copy the files :)


Webpage for Jonathan Fang


Lots of hoop jumping here, but OK.  Will add to PR.


Keep 'em coming. :)


Thank you so much
i asked because my config got bootloop in some devices
your answer helps me alot,thanks

Mostafa


I think we have spacing issue here.


I apologize for the delay in replying. It took a while to understand in what case an error occurs. It seems that it was my fault. And in addition I want to say  that I emulated browser IE 9 via IE developer tools F12. Here is the code:

```
<!DOCTYPE html>
<html lang="ru">

<head>
  <title></title>
  <meta charset="UTF-8">
  <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
</head>

<body>
  <div data-query="view(Form)">
    <textarea data-query="val(someField)">{{someField}}</textarea>
  </div>
  <script src="/scripts/blocks.js"></script>
  <script>
  var App = blocks.Application();

  App.View("Form", {
    someField: blocks.observable()
  });
  </script>
</body>

</html>
```


1679-DualDuct (kbenne) - i386-Windows-7-VisualStudio-12: OK (2197 of 2216 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.14%25-yellow.svg)


need to review setup of server vm, and replication of this. look into vagrant and shell provisioning.


Inheriting from `cons` is not confusing. The code pattern is, the way the code is arranged. The alias name strongly suggest injected class names, but it is not the case. The way the alias is computed, split into two steps (due to `list_to_cons` duality), one `public` and the other one `private` (for no apparent reason), is what made me stop and wonder what was I missing.

That said, inheriting from the sequence implementation is not ideal if one wishes to exploit EBO, as that introduces artificial base classes. But that's unrelated...


Those first two seem to account for the majority of the false positives I've triggered inside Google so far. I'm skimming more, but it'll be easier to get at least those two fixed and see if there's other classes of false positives.


Just a weird spacing of the pointer. You probably meant to put the "*" next to object_name like is normally done.


That's actually from my commits. Should be fixed by c86f2b30.


This is a good way to show the version number. Thanks for being so thorough.


@surayashivji DWMR. Very good work here. :+1:


Ok great!


esto se debe borrar


Actually, there's another mechanism that might be better to apply to solve this. In some parts of the code you find sections that read `enable_endstops(true); ... enable_endstops(false);`, sometimes based on the `ENDSTOPS_ONLY_FOR_HOMING` conditional. Instead of doing this for every `do_blocking_move_to` it would be better to fix those places in the code where the endstops are not being disabled when they should be, namely whenever they are not actively homing and `ENDSTOPS_ONLY_FOR_HOMING` is set.


This is a file describing the project, I think.


Just do

return simple_strtoull(ptr, NULL, 16);


awsome,this commit helps to implement gov like alucard
but other gov also wants midification !! can i prevent that ?


I would have thought the `constructor` would be better suited below the static properties, but above the lifecycle methods.


You typically do not initialize to 0/NULL if you do not have to. You set them up to their values just a couple lines below.


Not sure what the real recommendation should be.


For example, on a DELTA the `homeaxis` function will leave the endstops enabled if there's any `endstop_adj` value, clearly a mistake.


In a hurry, I missed "if".


yes, will follow the style


Thanx!


I think it's more accurate to say "very fast, unambiguous" failover. When switchboard cuts all running connections to a node it has determined as unhealthy, it is anything but transparent.


well, I'll try to find these sections of code.
P.S. I'm sorry for today commit private changes in the configuration, it is my fault


s/an every/on every/


@modsoussi Or you could have JobManager be a singleton. Just from the name, it seems like there would only be one "JobManager" that's attached to the application. (At least that's how I'd imagine it be done for Android).
```swift
class SomeManager {
    static let sharedInstance = SomeManager()
}
SomeManager.sharedInstance
```


Disabling the salt generation closes #72.


nit: can do just `return errs.Validation...`?


이견 없습니다. 수고하셨습니다.


Updated and validated: http://sam-genduso-air-traffic-express.mybluemix.net/


btw, this can throw.


nit: Go errors start with lowecase


o iya iku mas,, sing wingi perubahane di tambahna ning TODO


Looks fine. Go ahead and merge


There is no duality. The one is ::type. The one in private is implementation detail, and rightly so. They are not the same.

I *am* exploiting EBO by using derivation. If the base is empty, so will be the derived. You lost me there.


Why did you add the forward declaration? It is not needed in this case.


Messages have been optimized and made verification on 4x20 LCD


In the existing krbd code when we go over 80 cols like above we would put the "struct rbd_img_request *img_request, on the next line. See rbd_img_request_create for an example.


iteration (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2155 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.38%25-yellow.svg)


> I'll try to find these sections of code.

Cool. It's pretty straightforward. With `ENDSTOPS_ONLY_FOR_HOMING` the endstop should only be enabled when the position of its axis is unknown or when homing of that axis is actively taking place (XYZ for cartesians, ABC for other kinematics). At all other times the endstops should be disabled.

Meanwhile, the line where you are re-enabling endstops — `enable_endstops(true);` — is definitely not correct w/r/t the `ENDSTOPS_ONLY_FOR_HOMING` option.


Why is this private?


> There is no duality. The one is ::type.

There is `list_to_const::type` and there is `list_to_cons::call`. The existence of those two is presumably why it makes sense to alias `list_to_const`.

> The one in private is implementation detail, and rightly so. They are not the same.

They are both `private` in the latest PR.

> I am exploiting EBO by using derivation. If the base is empty, so will be the derived. You lost me there.

The base won't ever be empty. This is the non-nullary case so the base will always be `cons`, which does not exploit EBO. If it were to do so, then the inheritance here would better not be used anymore.


이거 필요없이 간단하게 다음 버전까지 아래 방법을 사용해도 됩니다.
모바일 [사용자 정의 CSS] 에 아래 코드을 적기...
* **.lt > li .auth .vtt {position:static}**


Why get rid of sf_input_key_polling and sf_input_mouse_polling?


Same as above.


@dan-hoerr changed the video carousel into a modal per Kiu's request, wanted to make it a more full screen experience. If you can check out what I've done and point it in the right direction. Mobile is looking pretty good. Of course needs some love.

Let me know what you think.


iteration (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Actually, this isn't correct: `OpamState.dev_packages` was used for updates and will only find _installed_ dev packages.
What we want here is to know if the current upstream is version-controlled, so we would have to look at the URL (`OpamState.is_dev_package` does that). Problem: the state contains all data from `opam` files, but not the urls (assuming we don't often need them, _i.e._ only for requested packages on show and install), so we'd have to load all url files just to check the kind of upstream. That would be pretty costly, even if we add them to the state cache, it nearly doubles the number of files to read on first init and on update...

A quick approximation would be to do this only for pinned packages, assuming dev is false on the repository. This is required to be true on the official repository, i.e. no version-controlled packages are allowed ; if you have VC packages on a custom repository, I guess you just put all dependencies without adding a `dev` flag anyway. Unless of course it's a staging repo, and you afterwards push back to a master repo with upstream archives that don't need the `dev` flag, then you would really need the full expressivity.

I think the simpler (check on pinned packages only) alternative is OK for now and clear enough to the user. In any case, this should be documented in the manual (https://github.com/ocaml/opam/blob/master/doc/pages/Manual.md#opam ; I still try to keep the LaTeX manual (doc/dev-manual/dev-manual.tex) up-to-date too, as it's more precise in some areas). I'll need to make sure the published manual is from branch 1.2 first, so that 1.3 features don't make it to the front site yet!


We don't really need to do this, because you used kmem_cache_zalloc which zeros it out when it is reallocated.

I see we sometimes do this in other places, but it is not clear to me if we do that because we use the non zeroing allocators.


Ah I see (about private). Looking at the code, you are right about Cons not exploiting EBO (should probably be fixed).


Lovely! #2325


Why disable both online?
Arkedo is broken like that.


@erictune Eric, it looks like some extra indents are causing at least some of these TOCs to be rendered in 'code' mode.
e.g view https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/getting-started-guides/gce.md
Then compare to the one from my PR of a few days ago: https://github.com/amygdala/kubernetes/blob/gettingstarted/docs/getting-started-guides/gce.md
I'm about to go into gce.md again and will address it for that file.


Just kind of a weird place to put this. Did you maybe have this closer to where you first used it in rbd_osd_read_callback or by similar forward declarations?


why do you need this?


tab instead of space


Done


Also, not need to init these to null/0.


Hmm...this code was added years ago to patch up directories that had a bug. It might not be needed. I added the assert to see if it ever really happens, so that we might remove that code path entirely. @joelkatz ?


Python version


Looks like this wasn't a survey year for GOA.

On Monday, June 22, 2015, Ryan Batt <notifications@github.com> wrote:

> can't update GOA
>
> @mpinsky <shrug>, new data aren't there apparently
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mpinsky/OceanAdapt/commit/e23a246d8f4e4dca92804250fbe3b935fdc4800d
>

--
Please excuse, sent from a device with tiny keys...


What I did to make this work was a bit dirty - and the name reflects it. It will be tidied up later


@igorcanadi - FYI rough edges have been addressed, it is staying.


Thanks, and it caught quite a few bugs


I don't think that's necessary, because it has a user defined constructor. @howardhinnant ?


There you go! :+1:


I don't want to say too much about it because it will likely be wrong and mislead readers. The whole point of this interface is so that after transaction processing is complete, the `MetaView` implementation can compare the `SLE`s before and after the modification, to compute metadata.


`request(options)` で使われていないオプションも残してある。あっても害はないはずなので。


I see that the strata are the same as for spring. You checked to make sure
they are sampled in all years in the fall?

On Monday, June 22, 2015, Ryan Batt <notifications@github.com> wrote:

> update neus fall strata
>
> @mpinsky this should take care of #28
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mpinsky/OceanAdapt/commit/5a7b51f7d0a0071baf80812bc7494dd2f94a94b2
>

--
Please excuse, sent from a device with tiny keys...


+1 should resolve http://stackoverflow.com/questions/10557930/mod-wsgi-error-class-dict-not-accessible-in-restricted-mode


Correction to my description:

The list with strictly more numbers of one parity should also be the one with a higher proportion of numbers with that parity. It's pretty intuitive, but just for clarification.


If you fix up you gotos so they go to thing they should start cleaning up then there is no need to do those "ifs". For example, the out_request "if" will always fail, because we just failed to allocate the copyup_request. You would want to do

name = kmalloc(size, GFP_KERNEL);
if (!name)
         return NULL;
or for the above one you can add a new goto that goes to the return NULL statement at the bottom.

pages = ceph_alloc_page_vector(page_count, GFP_KERNEL);
if (IS_ERR(pages))
         goto out_name

copyup_request = kmem_cache_zalloc(rbd_copyup_request_cache, GFP_KERNEL);
if (!copyup_request)
           goto out_pages;

See rbd_queue_workfn() for another example.


Sigh. I don't see a reasonable way, much less an easy way.

The problem in a nutshell is getting from `2 * blahTimeout` to the definition of `blahTimeout`, which could be anywhere. I was just wrong that the shortcuts I took were sufficient to remove most false positives.

The two options I see are crummy:

* Look up the definition dynamically. The typechecking information gives you `blahTimeout`'s Object, which provides scope and token position info, but not the defining expression itself. You'd have to do a search in the AST using the position information to find it.

* Identify every time constant in the AST and mark everything up the tree from there as ok. Then take another pass through looking for expressions of time.Duration type that didn't get marked ok. Unfortunately, ast.Inspect and ast.Walk do a pre-order rather than a post-order traversal, so that marking is either expensive or requires re-implementing the traversal. Also, this marking is space-intensive.

I hope that you found some true positives to compensate for your time...because at this point, I'm inclined to roll it back. I don't see a plausible path forward.


Maybe...user your best judgment, but not a strict enforcement of parenthetical usage?


Hmm, must be something in the subtyping rules -- I notice it's another issue with a `void` type. I'll try to take a look tomorrow.


Thank you! Any idea how long it will take for the changes to take effect?


Again, not need to set to null since we free below and zero out on allocation.

If this is customary for the code, then I guess keep the style for now.


whats wine shell? tell me everything i need with scrpit please


We do 80 col, so break up the line.


try to change it to "just a line"


I accidentally committed the previous commit. Sorry about that. I had thought I was working on a fork.


`fetch()` と同等のオプション引数はそのまま `request()` にも使える。ただし request の body オプションは[あとで書く]  https://github.com/request/request#requestoptions-callback


The ultimate commit...


Technically, it isn't necessary because there are two user *declared* constructors, and only one user declared constructor is necessary to inhibit the default constructor.  Deleting the two copy members is enough to inhibit implicit declaration of all other special members except for the destructor.


Add space between "if" and leading "(".

Also 80 col, so break up line.


Done


What do you mean? They have already taken effect for me.


You're saying that even if the only constructor was
`CachedView (CachedView const&)`
That would be enough to inhibit default construction?


90664130_AlternativeModelPAT (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


One more correction:

In the case where all the random numbers are of the same parity, in terms of coding we are done because that is what we want in a node.


Looking into this.


@jfields would you mind adding some specs?


My push from an hour ago took effect just two minutes ago using the url.


 Example 2-3. cleanup: An enhanced and generalized version of above scripts.**
>`範例 2-3. 清理：加強與普遍版本以上的腳本`

建議翻成：範例2-3 清理：針對上述腳本之強化與通用化。


`item()` returns `any`. I think you may want to remove `data` and update `item`.


Or at least, when it is stable enough we can think of including it again. It was an old spike that made it way to the current build. :-)


Yes.  Also even if the only constructor was the deleted copy constructor (which is considered user-declared), that also would be enough to inhibit default construction.


`request()` が返す `body` は普通のオブジェクト[要確認：文字列か？Bufferか？]なので、 `stream` でラップしている。 `request()` がストリーミングオブジェクトを返すようにするほうが真っ当だが、これでも動く。


any reason why we deleted these image logging lines ?


It may have something to do with your browser cache. I can see the exact time your changes were deployed and it was all within 30 seconds of your commit.


Any reason why we deleted this image logging lines?


See https://travis-ci.org/w3c/web-platform-tests/builds/67918791

The trailing whitespace on this line caused Travis CI automation for the rep to fail.

@jgraham fixed it with https://github.com/w3c/web-platform-tests/commit/a4e187e1296cb981648202a0d7567aa81d869d91 but this is one of the reasons to avoid pushing anything to master without review.

Even for just docs changes, we’ve been trying to follow a policy that all changes get submitted as PRs and get reviewed by another pair of eyes before they’re merged.

Also, to catch whitespace errors and other common problems, it’s a good idea to always run the lint tool in your working directory. See https://github.com/w3c/web-platform-tests/blob/master/docs/lint-tool.md

Note that the current Travis CI status for the master branch is at https://travis-ci.org/w3c/web-platform-tests/builds and the status for all PRs is at https://travis-ci.org/w3c/web-platform-tests/pull_requests


This typedef is a bit confusing.  Maybe `ArrayIter` instead?


No need to keep around `old_header`. Feel free to delete it. The whole point of git and version control is general is that you never lose any data, so even once you delete the old header, you can still recover it through git commands.


This really doesn't belong in the task.


we need to decide if we're going to do tabs or spaces... Just for sanity's sake.


Hi, we bought the A20-SOM-EVB_Rev_B boards with A20-SOM_Rev_B. I am building a shield for the A20-SOM based on the EVB-RevC design. I would like to know whether there is a document where I can find a list of changes between REV_B and C boards.

I would really appreciate if that exists. In particular I am wondering right now why did you add PC17/PB9 jumper in the OTG circuit and if I need to keep the switch.

Thank you.


Try to modify


No need to set to null.


I'm not sure yet why this happens, but `theano.tensor.blas.ldflags()` remembers its first return value, wich has all the `-l` flags, even if `config.blas.ldflags` changes afterwards.
Removing the `@memoize` decorator form `ldflags()` makes it work.


It does not look like you ever used the kref. Did I miss something, or is there another patch adding on to these?

If you do not need the refcoutning that kref provides, just remove its use.


You also need to make this change in the WhiskeyViewController


It looks very good abstraction:+1: I have one suggestion: could you consider about the renaming of the toXXX methods like roundToXXX or something? I misunderstood and confused the difference between the toInt() and IntegerValue.getInt() so. How about it?


Although I question the sanity of anyone adding id3v1 tags to FLAC, this looks alright. It does disappoints me that taglib is doing all this extra IO to look for id3v1 tags in my FLAC collection.


so pro much tru


I prefer this format `@author Daniel Jipa`


Отступы скачут.


I know this gives NOTEs if you don't do it, but do CRAN maintainers expect us to do this? I've always ignored those NOTEs if the word was actually correct.


Неизменяющиеся переменные следует помечать `const`: `const int width = image.get_width();`.


コメントありがとうございます！
指摘していただいた部分を修正しました！


Зачем вводить новые обозначения для `i` и `j`, если можно пользоваться `i` и `j`? Или переименовать `i` и `j` в `x` и `y`.


@hadim could you please roll-back these changes? About the Bug in TrackMate: Potentially, you provided an `ExecutorService` from outside, which you didn't close? This may explain, why the bug is fixed with this commit.


Что значит префикс `str`?


seems like this class got in there by accident...?
(the existing RESTCoreActivator is used in MANIFEST.MF)


store only if symfony is debug false


Зачем тут 0 и 1? Что они означают?


Yes you say only for reading but you are registering handles to that Key many times
```key.close()``` in this case


ga niet spatie


L12-16 放這邊OK嗎？ 或是放回 generator中？
原本是在 generator 的 generateRecordActionNs 裡，看起來沒有其他地方有用到，所以就包進 CRUD 裡。

也可以有另外一種做法是把這段邏輯包回 generator 中，然後把 CRUD 這個拿掉，讓 BaseRecordAction 直接自己用 generator，不過，看 test 中蠻多地方用到 CRUD::generate，所以不敢輕舉妄動的把它拿掉，因此選擇保留 CRUD，然後把要驛動的邏輯搬到 CRUD 裡。