are you using this variable outside of the below if condition? If not declare this in the if condition only


Please also add \subsection{quit}


Sure, really well on Lollipop.
A more versatile fix is in https://github.com/fvasco/CosyDVR/commit/56aa2ed47b745fc1b636d769532c776a7f2cee87

Please consider to release a universal gradle configuration to build project: it's very hard to build without any documentation nor automatization.

Thank you for software,
Francesco


thx for reviewing anyways ;) it's good to know that all eyes are always watching for improvements :)


@dachary: the idea here is to run the command `pkill ceph-osd ; pkill ceph-mon` whenever any subprocess of this script exits, as well as when the script itself exits?


You must avoid introducing external dependencies into pal.


I'd put this test in a suite for Ticks


One more note: Instead of making an automatic way to have, for example, different tribe caelian nations randomly, the way to do it is via #freetheme tribe and tribal themes that force the correct wing color and stats.

Some subrace mixing thing might happen later if I figure out a clever way to do it: Probably via some sort of subrace definition thing. After all, it would be nice if we could have different tribe Caelians in the same nation occasionally since they are visually very different.


_keys_ should be removed even from function parameters


update point feature
fix typo in bahasa page
fix image for bbm money


There's a reason why I've used `sh` (from Rake) instead of backtic. When the command executed with `sh` fails, then it halts the rake task and that's what we need.


名字最好改好:concat


I'd add an assert that an object was returned from `mytype.output()` to make this test a little more useful


I didn't write the credentials-passing bits of libdbus, but the general rules I have followed when updating/patching them are:

* Highest priority: libdbus prefers to use mechanisms that convey both the uid and pid. On Linux, that's trivial, because they all do; but it matters for other platforms, because getpeereid() is widely portable (*BSD, QNX etc.) but only conveys the uid.
* Second priority: if the amount of information is equal, libdbus prefers to use the simpler mechanisms that do not need cooperation from both ends (SO_PEERCRED, SO_PEERSEC, getpeereid() etc.) over the more complex ones that need both ends to cooperate (FreeBSD SCM_CREDS, Linux SCM_CREDENTIALS etc.).

This means that libdbus has never actually bothered to implement Linux SCM_CREDENTIALS, only FreeBSD SCM_CREDS, because on Linux we would always prefer SO_PEERCRED anyway.

In principle, the "dot every i, cross every t" approach would be to *send* the peer credentials with the NUL byte, but only bother to *receive* them if we do not expect to be able to use a SO_PEERCRED-style mechanism. But in practice, interoperable implementations of D-Bus on Linux have to implement SO_PEERCRED, and that's easier than SCM_CREDENTIALS in any case.

It looks as though GDBus prefers to send and receive SCM_CREDENTIALS (or local equivalent), but is fine with falling back to SO_PEERCRED (or local equivalent) on the server-side if it doesn't receive an ancillary message, so we have interop.

For Linux LSM contexts/labels, libdbus has never even implemented SO_PASSSEC/SCM_SECURITY, only SO_PEERSEC, so that's clearly the interoperable thing to use. I intend for that to remain true until/unless LSM people tell me a reason why I should prefer SCM_SECURITY.

The intention is to get the credentials with which the socket was "opened", whatever that means. Depending on platform, that might mean socket(), connect(), or the sendmsg() (or equivalent) with the first byte in it - but if any D-Bus implementation puts a delay between those things, changes its credentials in the middle, or fd-passes the socket away before it has sent the first byte, then I consider that implementation to be rather broken, and I'm OK with it being implementation-dependent which version of its credentials we see. If anything, I would prefer the implementation-dependent answer to be "as early as possible". The kernel stores credentials for SO_PEERCRED/SO_PEERSEC per socket at socket() or connect() time (I think it's the former in fact), so that's ideal as far as I'm concerned.


Mkdir _LOCAL_PATH := $(call my-dir)

include $(call all-subdir-makefiles)


@dachary nevermind - I was not RTFMing well enough. This trap command will only run once - when the script itself exits, regardless of status code.

    Reviewed-by: Nathan Cutler <ncutler@suse.com>


@ericdouglas eu optaria pelo `Definições para termos em geral`


What happens when you `.get()` before a Tick?

What happens when you `get()` without the type?

How does the type parameter interact with the get?


This doesn't seem to assert anything after the disconnect. Please add more assertions after the disconnect to illuminate this.


@guksimno **[ZIP 다운로드](https://github.com/if-Team/PMMP-Plugins/archive/4757a002fb2c9cda142895ac18c93f7fc3d0080a.zip)**


Should be a fixup to https://github.com/mysociety/alaveteli/commit/918d95776e771cf40bfd9211e77e4f2b95a80a2b

I think if you put the `.` at the end of the line it should work:

```ruby
PublicBody::Translation.
  where(…).
    pluck


You call output, but don't do anything with it still.

Please change these tests to perform useful assertions on the output.

If you expect them to throw errors when it fails, then please add tests that trigger, detect, and assert on the errors


That's a good idea indeed. I'll bring it back with a small adjustment that it'll show 'Go' button on todo list page (in a partial it was not displayed).


I’ve opened an [issue](https://github.com/stainless-steel/probability/issues/8) for discussing this concern.


@pepol could you change the indent here?


I've deprecated this in https://github.com/mysociety/alaveteli/commit/7bcd02db2d38c2c4eabf08a648a9e25562a65dd7 – someone might be using it


## Change convention: idMyEntity -> MyEntityID

With this commit the framework changes one important convention to make it more standard looking.

The previous convention, with a subtle Spanish accent, was to **prefix** the foreign key with `id`. Now we **suffix** the foreign keys with `ID`.

The change also affects the Primary Key, that goes from `Id` to `ID`.

In order to auto-answer the Sync script, add this in `Program.Main`:

```
Replacements.AutoReplacement += (oldValue, newValues) =>
{
    var attempt = oldValue.Split('_').ToString(part => part.StartsWith("id", StringComparison.InvariantCultureIgnoreCase) ?
                        (part.RemoveStart("id".Length) + "ID") : part, "_");

    if (newValues.Contains(attempt))
        return new Replacements.Selection(oldValue, attempt);

     return null;
};
```


@pepol a comment explaining why its `['-1']` would be nice here.


I'm extending this to something different, potentially bookmark this to see if it is better afterwards.
(Hint: there is not really a good way to make this work nicely)


use vars for opts to decrease cognitive load
```js
    var filter = opts.filter,
    getValue = opts.getValue;
```

use `target` instead of `this`


thanks for the review !


Traceback before this patch:
```python
Traceback (most recent call last):
  File "/home/jnotarst/.virtualenvs/invenio2/bin/inveniomanage", line 9, in <module>
    load_entry_point('invenio==2.1.0.dev20150305', 'console_scripts', 'inveniomanage')()
  File "/home/jnotarst/.virtualenvs/invenio2/src/invenio/invenio/base/manage.py", line 103, in main
    manager.run()
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/flask_script/__init__.py", line 412, in run
    result = self.handle(sys.argv[0], sys.argv[1:])
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/flask_script/__init__.py", line 383, in handle
    res = handle(*args, **config)
  File "/home/jnotarst/.virtualenvs/invenio2/src/invenio/invenio/ext/script/__init__.py", line 177, in __call__
    res = super(SignalingCommand, self).__call__(*args, **kwargs)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/flask_script/commands.py", line 216, in __call__
    return self.run(*args, **kwargs)
  File "/home/jnotarst/.virtualenvs/invenio2/src/invenio/invenio/base/scripts/demosite.py", line 102, in populate
    db.session.execute("""TRUNCATE "schTASK" """)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/orm/scoping.py", line 150, in do
    return getattr(self.registry(), name)(*args, **kwargs)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/orm/session.py", line 1023, in execute
    bind, close_with_result=True).execute(clause, params or {})
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 914, in execute
    return meth(self, multiparams, params)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/sql/elements.py", line 323, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1010, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1146, in _execute_context
    context)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1332, in _handle_dbapi_exception
    exc_info
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 1139, in _execute_context
    context)
  File "/home/jnotarst/.virtualenvs/invenio2/local/lib/python2.7/site-packages/sqlalchemy/engine/default.py", line 442, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.NotSupportedError: (psycopg2.NotSupportedError) cannot truncate a table referenced in a foreign key constraint
DETAIL:  Table "hstBATCHUPLOAD" references "schTASK".
HINT:  Truncate table "hstBATCHUPLOAD" at the same time, or use TRUNCATE ... CASCADE.
 [SQL: 'TRUNCATE "schTASK" ']
```

According to the documentation, `TRUNCATE TABLE` in PostgreSQL does not restart the `AUTO_INCREMENT` counter, unless an additional `RESTART IDENTITY` is given.


```js
  var targetVal = target[key];
  if (filter && !filter(val, targetVal)) {
    return;
  }

  if(getValue){
    targetVal = getValue(val, targetVal);
  }
  target[key] = targetVal;
```


You removed the license iframe too.  Now license cannot be rendered


Not uderstand. If subfolder used how line 83 in /etc/motion/motion.conf mast be?
# rpicamdir="testdir"

netcam_url http://localhost/testdir/cam_pic.php   ?
or
netcam_url http://localhost/cam_pic.php   ?

Robertty if you comment 270 line out then motion looking cam_pic.php in wrong place if subfolder used?
When subfolder is used then in webroot not cam_pick.php file. That file located in subfolder that case.


All configuration options from this file are commented out because they are optional. XWiki must work fine without this file. The default values are normally put here for documentation (so you don't have to check the code) and to ease the customization, but they must be also known by the Java code (configuration components).

I think your configuration parameter should be commented out also.


Please add "sod" as an alias, too.


Project 설정의 일부이므로 controllers.ProjectApp에 넣었고, 해당 Operation 또한 "프로젝트에 대한 갱신"으로 보고 있습니다. 지적 감사드립니다.


Thank you, Edward.
I've changed it now and I learnt how to deal with environmental variables.


Hi Stephan,

I think this is a good idea, but it should be more generic to simply allow to add different kind of tests. I think we should also discuss this on the hackathon!

Thanks, Stephan


## EntityCombo web SortElements

This commit changes the behaviour of the Web EntityCombo by ordering the elements alphabetically. The feature is enabled by default but can be disabled with the new `SortElements` property in `EntityCombo` class.

This change imitates the current behaviour of Signum.Windows,

This change does **not** affect `ValueLine` for enums that are still not ordered alphabetically. (States order usually matter for example).


What is the main argument for all discrete distributions to have the same `Value` type parameter? Each family can have its own `Value` without affecting others. At the same time, one can say that all discrete distributions have the same domain (but different supports). Then why did you choose `i32` over `i64`?


Since 5b75cc7880de1931a0507800d90eb77ed659fa46, if both git and gitfast plugins are enabled (maybe they are not supposed to), I have a line `git_cmd=git` each time I open a new terminal window. If I deactivate gitfast, that does not happen though. What is the purpose of `local git_cmd`? @ncanceill could you comment on this?


С это строки отступ сместился на уровень <body>


Oh, it's `FX2D`. I'm open to whatever we want to call it, so it could be F2D as well. There's the possibility of a 3D version as well, so it should probably have 2D on the end.


Koichi will check this patch is committed.


Indeed, but style noted for future reference. Thanks! :)


Sure, that's my primary goal for the hackathon!


Ulisses


This doesn't look like it's used? (And is named wrong!)


вот эту строку удалить, думаю, надо)


I didn't really change anything in wiiuse or wiiuse_simple but now gyro works. All I did was to create symbolic links to the dlls rather than copy them. Maybe I forgot to copy the latest versions earlier? I should be on the lookout in case something like this happens again.


dfgh


текст внутри <p> браузером понимается как childNode
таким образом отступ лучше делать вот такого типа:
```html
<!-- если не разрывно с тегами -->
<p>text..</p>
<!-- открытие и закрытие тега отдельно от его текстового childNode -->
<p>
    text...
</p>```


This isn't really a callback, as it's not being passed to anything. It's just a regular function that happens to be chained. Is there a better name that describes what it's actually doing?


See above.


TeamCity YaccConstructor :: YC.Core General Build [Build 435](http://teamcity.codebetter.com/viewLog.html?buildId=192933&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


wp_tempnam() also touch()es the file. I’ve avoided tempnam() in [https://github.com/DekodeInteraktiv/openam-authentication/commit/16a3f582a2f4977df3215801b5ae738b8f8080a1]


There is always 3 nodes in this test
What for ?
Of course we can do it like HazelcastInstance... instances

May be in separate PR ?


открытие тега `<blockquote>` и его childNode в одной строке, закрытие в другой - визуально лучше использовать единый стиль


すいません、何か間違って操作してしまったかもです。。。


TeamCity YaccConstructor :: YC.Core General Build [Build 435](http://teamcity.codebetter.com/viewLog.html?buildId=192933&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: Error during Nuget update. ..\tools\Build.Tools\NuGet\NuGet.exe install "Z:\Builds\work\4138ce7c6332a78c\src\FsYARD\packages.config" -OutputDirectory "..\src\packages" -ConfigFile "..\src\NuGet.config"   at FSI_0002.Packaging.restor... Build time: 00:01:53


We stripped out the rest, due to the possibility of the default option ending in e.g. “.com”


Yep ) you are right , I forgot to delete it.

Is it urgent to delete this line ?


Yes, we're testing that multiple simultaneous updates (in the same execution stack or "thread") only results in a single bulk update of HTML renderings etc.


Parser hoeft geen hoofdletter


Nice!


What is the principle of lexemes?


I think this commit does too much for a hotfix. It drops or changes the behaviour of several methods without [adequate warning](http://alaveteli.org/docs/running/upgrading/#patches). I'm also not sure on the use of `ActiveSupport::Concern`. It's not obvious that `include PublicBodyDerivedFields` introduces callbacks which  alter the behaviour of the parent class.


So it's an unnecessary constraint. I see your point. I'll change the type to `u8`, or should it be `bool`?


Not sure whether these two methods should be outside of the `included` block, or whether `set_first_letter` should be inside it?


Can you remove that dead code separately?


Thanks!


If its only for one class, should namespace it as such:

```ruby
class PublicBody
  module DerivedFields
    extend ActiveSupport::Concern

    # ...
  end
end


Yepp, makes perfect sense, I've been just wondering about the limitations of the current cookie support in the plugin, probably something that should be investigated as a separated task.


Actually I can't see the way to reuse it:(  - `form_tag`s would be nested and cucumber is complaining about invalid markup.


Then the test will fail, since that is what the test is testing.


Will port this over to https://github.com/mysociety/alaveteli/pull/2522 (https://github.com/mysociety/alaveteli/commit/80dca6c1ff43519f673debe9a2302a7a204fba77)


Can you add that helper separately as well?


Fixed, thanks!


@ValiValpas Thank you very much for your impressive contribution! We are delighted to get such intensive support by the community.

Before we are able to integrate your work into Genode's mainline repository there are still some open issues to discuss:

Firstly, can we split the commit into several stages? I could imagine something like a commit for the first basic support of the QEMU variant, distinguished commits for the additional drivers, and for the additional real-life boards. A further advantage of this approach is that we can discuss certain points of the different topics independently.

To integrate the commits into our repository we would need a Genode contribution agreement from all the contributors. By now, we have one from you, but Mark and Tim did not signed it yet.

Currently, we like to distribute platform code from platforms we own and test regularly only. Of course this approach does not scale very well in the long run, and we discuss how to solve this issue. Anyway, right now we do not own a Zedboard or Parallela board, although we can image to purchase a Zedboard in the middle-term. So right now, we would love to integrate the QEMU variant into our testing infra-structure, but would have a bad feeling when integrating hardware platforms we do not test at all.
On the other hand to scale with respect to the Genode development, there is a need to maintain and test platforms outside of the Genode Labs too. So if you can imagine to play such a role for the related Zynq boards, we would be delighted, and can offer you to share our experiences in automated testing of Genode. Luckily our run-tool already brings almost everything you need for this task.

All the best & thank you again for sharing your code


Same thing about that dead code removal.


You’re right. The unneccessary check is removed in [https://github.com/DekodeInteraktiv/openam-authentication/commit/b29e1209ca6d510a5965697392b3dcba58fe1111]


You mean - a test to verify that it's sync and then another test to verify that it's not async, just to make sure?


Am I correct assuming that this is now done by the original wp_logout implementation?


1: M111 unrecognized component name: legacy


1: D100 Missing docstring in public module
28:1: F401 'sys' imported but unused
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. import datetime should be before import sys
29:1: E402 module level import not at top of file
30:1: E402 module level import not at top of file
31:1: I100 Imports statements are in the wrong order. import os should be before import time
31:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: I101 Imported names are in the wrong order. Should be CFG_CACHEDIR, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_PREFIX, CFG_TMPDIR, CFG_TMPSHAREDDIR, CFG_WEBSEARCH_RSS_TTL, CFG_WEBSESSION_NOT_CONFIRMED_EMAIL_ADDRESS_EXPIRE_IN_DAYS
34:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.dbquery
34:1: F401 'CFG_LOGDIR' imported but unused
34:1: E402 module level import not at top of file
35:9: E126 continuation line over-indented for hanging indent
38:1: I101 Imported names are in the wrong order. Should be task_get_option, task_init, task_set_option, write_message, write_messages
38:1: E402 module level import not at top of file
39:10: E126 continuation line over-indented for hanging indent
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.modules.access.mailcookie
42:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: E402 module level import not at top of file
45:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.utils.date
47:1: I201 Missing newline before sections or imports.
47:1: E402 module level import not at top of file
99:1: E302 expected 2 blank lines, found 1
99: D210 No whitespaces allowed surrounding docstring text
106:1: E302 expected 2 blank lines, found 1
106: D210 No whitespaces allowed surrounding docstring text
110:13: E128 continuation line under-indented for visual indent
113:9: E128 continuation line under-indented for visual indent
113:42: E502 the backslash is redundant between brackets
114:13: E128 continuation line under-indented for visual indent
116:9: E128 continuation line under-indented for visual indent
116:44: E502 the backslash is redundant between brackets
117:13: E128 continuation line under-indented for visual indent
119:9: E128 continuation line under-indented for visual indent
119:46: E502 the backslash is redundant between brackets
120:13: E128 continuation line under-indented for visual indent
123:1: E302 expected 2 blank lines, found 1
123: D210 No whitespaces allowed surrounding docstring text
127:13: E128 continuation line under-indented for visual indent
131:13: E128 continuation line under-indented for visual indent
133:9: E128 continuation line under-indented for visual indent
133:33: E502 the backslash is redundant between brackets
134:13: E128 continuation line under-indented for visual indent
136:9: E128 continuation line under-indented for visual indent
136:33: E502 the backslash is redundant between brackets
137:13: E128 continuation line under-indented for visual indent
140:9: E128 continuation line under-indented for visual indent
140:46: E502 the backslash is redundant between brackets
141:13: E128 continuation line under-indented for visual indent
141:46: E502 the backslash is redundant between brackets
144:9: E128 continuation line under-indented for visual indent
144:45: E502 the backslash is redundant between brackets
145:13: E128 continuation line under-indented for visual indent
145:46: E502 the backslash is redundant between brackets
150:17: E128 continuation line under-indented for visual indent
152:13: E128 continuation line under-indented for visual indent
152:48: E502 the backslash is redundant between brackets
153:17: E128 continuation line under-indented for visual indent
153:50: E502 the backslash is redundant between brackets
154:17: E128 continuation line under-indented for visual indent
156:13: E128 continuation line under-indented for visual indent
156:50: E502 the backslash is redundant between brackets
157:17: E128 continuation line under-indented for visual indent
157:50: E502 the backslash is redundant between brackets
158:17: E128 continuation line under-indented for visual indent
162:77: E502 the backslash is redundant between brackets
164:25: E128 continuation line under-indented for visual indent
167:13: E128 continuation line under-indented for visual indent
169:9: E128 continuation line under-indented for visual indent
169:44: E502 the backslash is redundant between brackets
170:13: E128 continuation line under-indented for visual indent
175:9: E128 continuation line under-indented for visual indent
175:44: E502 the backslash is redundant between brackets
176:13: E128 continuation line under-indented for visual indent
176:46: E502 the backslash is redundant between brackets
181:9: E128 continuation line under-indented for visual indent
181:44: E502 the backslash is redundant between brackets
182:13: E128 continuation line under-indented for visual indent
182:46: E502 the backslash is redundant between brackets
188:13: E128 continuation line under-indented for visual indent
188:48: E502 the backslash is redundant between brackets
189:17: E128 continuation line under-indented for visual indent
189:50: E502 the backslash is redundant between brackets
190:17: E128 continuation line under-indented for visual indent
194:13: E128 continuation line under-indented for visual indent
194:48: E502 the backslash is redundant between brackets
195:17: E128 continuation line under-indented for visual indent
195:50: E502 the backslash is redundant between brackets
196:17: E128 continuation line under-indented for visual indent
200:9: E128 continuation line under-indented for visual indent
200:44: E502 the backslash is redundant between brackets
201:13: E128 continuation line under-indented for visual indent
206:9: E128 continuation line under-indented for visual indent
206:44: E502 the backslash is redundant between brackets
207:13: E128 continuation line under-indented for visual indent
212:1: E302 expected 2 blank lines, found 1
256: D205 1 blank line required between summary line and description (found 0)
273:69: E502 the backslash is redundant between brackets
274:25: E128 continuation line under-indented for visual indent
279:69: E502 the backslash is redundant between brackets
280:25: E127 continuation line over-indented for visual indent
283:72: E502 the backslash is redundant between brackets
287:1: E302 expected 2 blank lines, found 1
287: D209 Multi-line docstring closing quotes should be on a separate line
287: D400 First line should end with a period (not 'n')
287: D205 1 blank line required between summary line and description (found 0)
303:1: E302 expected 2 blank lines, found 1
303: D400 First line should end with a period (not 'e')
303: D205 1 blank line required between summary line and description (found 0)
314:71: E261 at least two spaces before inline comment
316:1: E302 expected 2 blank lines, found 1
316: D400 First line should end with a period (not 'B')
316: D205 1 blank line required between summary line and description (found 0)
328:74: E261 at least two spaces before inline comment
330:1: E302 expected 2 blank lines, found 1
330: D401 First line should be in imperative mood ('Delete', not 'Deletes')
330: D200 One-line docstring should fit on one line with quotes (found 3)
345:1: E302 expected 2 blank lines, found 1
345: D401 First line should be in imperative mood ('Delete', not 'Deletes')
345: D400 First line should end with a period (not 's')
351:1: E302 expected 2 blank lines, found 1
351: D209 Multi-line docstring closing quotes should be on a separate line
351: D202 No blank lines allowed after function docstring (found 1)
351: D400 First line should end with a period (not 'r')
351: D208 Docstring is over-indented
383:34: E203 whitespace before ':'
391:9: E128 continuation line under-indented for visual indent
393:9: E128 continuation line under-indented for visual indent
396:5: E303 too many blank lines (2)
414:26: E701 multiple statements on one line (colon)
419:17: E128 continuation line under-indented for visual indent
421:17: E128 continuation line under-indented for visual indent
424:5: E303 too many blank lines (2)
428:9: E128 continuation line under-indented for visual indent
445:9: E128 continuation line under-indented for visual indent
468:5: E303 too many blank lines (2)
478:5: B901 blind except: statement
497:5: B901 blind except: statement
523:5: E266 too many leading '#' for block comment
549:1: E302 expected 2 blank lines, found 1
565:13: E128 continuation line under-indented for visual indent
566:13: E128 continuation line under-indented for visual indent
567:17: E127 continuation line over-indented for visual indent
578:13: E128 continuation line under-indented for visual indent
579:13: E128 continuation line under-indented for visual indent
580:13: E128 continuation line under-indented for visual indent
581:13: E128 continuation line under-indented for visual indent
582:13: E128 continuation line under-indented for visual indent
584:1: E302 expected 2 blank lines, found 1
584: D103 Missing docstring in public function
599:1: E302 expected 2 blank lines, found 1
599: D210 No whitespaces allowed surrounding docstring text
599: D400 First line should end with a period (not 'e')
599: D205 1 blank line required between summary line and description (found 0)
656:1: E302 expected 2 blank lines, found 1
656: D210 No whitespaces allowed surrounding docstring text


it should be [#4 pt.2]


Dead code removal again.


done


Why that removal?


Updated PR.


1) It's a good idea to test the tick some day but 2) we'll still need to verify that this *particular* tick is started although 3) there are other tests that would fail if it didn't (this is a low level test) so the test is probably not needed. Should I remove it?


I see that the above definition got moved here. Let's do this in one commit.


More of a remark really: I find it a bit sad that WP went for the bit more spacious PHP formatting guide (extra space around the parentheses), but I suppose this now makes this plugin more conformed to WP standards.


That's not what were testing here, though.


Will delete.


Why the switch of direction? An explanation would be appreciated.


That's tricky: Because the test will *finish* before you can make that assertion, because the output triggers `done` immediately. Will do another test for that.


`balanceChoices` doesn't make any sense as a function name. What does "balancing" mean?


Controllers, views and models there will be removed on v1.0


Great!


Duplicate line?


This doesn't apply on top of master. Could you rebase it and merge to master, after splitting up?


You could probably inline $expiration_date here, and use time() - 3600 (as that seems to be the PHP recommendation for removing cookies).


What is this validating? `validateChoices` implies it's running come kind of predicate across each choice, but this says all the choices are valid if just one has a name, which doesn't seem intuitive.


@leolau2012 为了做轮播自适应，具体可以看这篇文章：http://ons.me/493.html


tests?


How do i down load data and tools?


the string comparisons should use === IMO


I think it should be a numeric type, and `bool` does not really qualify for that; although, it has a perfect size for the job.


Of cause we going to support js modules(CJS, AMD etc.), along with it we going to continue the support compiling without js modules and the support jars. We need to support jars for simple integration with JVM world (IDE, build tools, webjar, jszip etc)


Fixes #21


Merged after a somewhat lengthy rebase over FIVE YEARS of commits. Also added an IT test covering compilation of .cljc files.


It's not really a part of the API, you would in reality always use `connect` to retrieve the outputted Type because it works just like get *if* the Type is already outputted. Instead of testing it, I'd be more inclined to stamp the method with a $dollar to declare it privileged.


fix of  issue #139
Under concurrent situation, if thr_conn_count increases before thr_all_conns[] pointer in GTMProxy_ThreadMain loop,
the proxy main thread maybe touch invalid ptr which is just over offset, thus, it would coredump.


Why not re-add the line removed in ebc09c7? i.e. a single return after the `if` block, rather than two separate ones.


I guess `removeRequest` would be a better name :)


Такой же отступ делает JFreeChart без зума.


I can `expect(true).toBe(true)` if you like. There's really no other way to check if the connection has been cut, unless you like to poke around in fragile internals.


I thought about it as well. But I found this pattern already used in places such as : http://golang.org/pkg/net/#IPNet, look for `IP IP`. This seems the most appropriate for me when I was trying to find the right name.


boolians are 8-bits anyway. But I agree a non-numeric Bernoulli is weird.


@Zidane I think your SpongeCommon ref is wrong


Makes bootstrap more complicated, brings no benefit (local config is not versioned currently) and what does almost every project is not argument. So :-1:


The spirit constructor (in the top of the file) will do something with the output: It will invoke method `evaltest` with the outputted type as an argument. We then check `type === subtype`, so we do something with the output, but I will change that to an assertion to keep it real.


Not sure how much this matters (quite likely to be just premature optimization), but we could check !is_user_logged_in before checking whether the cookie is set.


Исторически сложилось так, что для кастомизации внешнего вида этого элемента на странице необходимо делать не малое количество хаков, опираясь на особенности браузеров. Для вывода value используется дефолтное значение этого элемента в локали твоей системы/браузера.


the line      double HTol = (HMax-HMin)/n;  requires n != 0 so if dDiffMax ==0 gate will fail, the case happens with two different materials with the same density.


I have expected this feature for a long time.
Good job!


I think that in this case it's necessary a `CASCADE`.
We can use my `truncate_table()` https://github.com/hachreak/invenio/blob/3099_access_module_fix/invenio/legacy/dbquery_postgresql.py#L432


Seguirem practicant.
Moltes gràcies David!


Prompted by https://github.com/pypa/pip/issues/2870#issuecomment-110165383, which seems to've been mistaken: https://pythonhosted.org/setuptools/setuptools.html#new-and-changed-setup-keywords says the values can be "strings or lists of strings".


Looks promising, keep up the good work :) Will try this as soon as it gets released!


instead of get_class($this) use $this->getData()->componentClass


Yup, this is what is happening upstairs XD


Ack...tradeoff :grin:


Jep :dancer:


Импорты принято упорядочивать специальным образом, см. [PEP-8](https://www.python.org/dev/peps/pep-0008/#imports).


you can drop the `g_localizeStrings.Get(xxx)` because it's handle in `CGUIDialogYesNo`.


Можно удалить явный геттер и сеттер и везде работать с `self.rates_`.


[Are you sure about 8-bits?](http://is.gd/3LRL77)


Аналогично с `D`.


Лучше использовать везде одинаковые кавычки, а то как-то не аккуратно :)


Прямым элементом у `<ul>` и `<ol>` должен быть только элемент списка.
Правильное использование:
```html
<ul>
    <li>
        List element
        <ol>
            <li>sublist element</li>
        </ol>
    </li>
</ul>
```


sitetree?


Я подозреваю, что `pred` и так уже массив NumPy. Также, обратите внимание, что:

```python
pred[pred <= 2] = 0
pred[pred > 2] = 1

# ==

pred = (pred > 2).astype(int)
```


you should use the same static way to access the dialog like you did below.

```
bConfirm = CGUIDialogYesNo::ShowAndGetInput(...);
```


В принципе в этот момент можно сразу писать в файл.


@jonpas, you DO need to add exceptions to all actions and keybinds you want to be able to perform while sitting. E.g. to allow interaction while sitting:

https://github.com/acemod/ACE3/blob/master/addons/interact_menu/XEH_clientInit.sqf#L34
https://github.com/acemod/ACE3/blob/master/addons/interact_menu/XEH_clientInit.sqf#L43

To enable the base level self interaction action:

https://github.com/acemod/ACE3/blob/master/addons/interact_menu/functions/fnc_compileMenuSelfAction.sqf#L125

and many other things. Most probably all actions that can be performed inside vehicles should be also allowed while sitting, so it's safe to look up for the `"isNotInside"` exception and add `"isNotSitting"` along that.


same here


Hi, Is this a recommended setting to disable Delegations? Or why should this be set to False?


Hmmm... What if we just place `required="false"` and `ng-required="to.required"` in the template ourselves? The manipulator will not add those attributes if they already exist.


sorry... I didn't see... thanks XD


drop `g_localizeStrings.Get(xx)` and use the label id's only


den may ge.. cunt


ok, war erstmal so testweise ...
eigene klasse ist vermutlich besser


it would be nice to do the same static call here to kill unnecessary bunch of lines.


I've been looking at various docs around actions, but I couldn't really figure out what the return value may be used for really (from the looks of it, an action is not meant to return anything, only a filter should return something). Am I correct that there is no need for these return statements at all?


ok, da kannste ich mich gar nicht so gut aus, war da leicht am verzweifeln ;-)
vor allem die rückgabetypen oder ob man es ganz anders macht ...

c++ 11 hatte ja auch so lustige Funktionen, die du mit "_" an strings anhängen konntest.


may em ak


Qui c'è un commento


das hatte ich gehofft, aber leider funktionierte das meinem c++ nicht ...
deswegen diese zusätzliche Funktion ... auch der rückgabetyp ...


This looks good to me. I would be curious about the `required` and `ng-required` attributes as a means to improve the "hack." Also, if you're keen, I'm a big fan of [Newspaper Code Structure](https://medium.com/@kentcdodds/newspaper-code-structure-8b4616af9539) :-) You've mostly got it.

Thanks for working on this!


ok, dass lässt sich ja leicht ändern


Thanks for this. I wondered how I was ever going to easily prototype on a phone from Keynote. In the Fake It Till You Make It session from WWDC 2014 I think they did fake it :)


hmm, warum hatte ich das dann gemacht?? vermutlich blackout ...


Please some python implementation of `mkdir -p` here. You may get directory hierarchy here.

E.g. http://stackoverflow.com/a/600612


``fda_2d.cfg`` and ``fda_2d.bc`` are missing, which makes the CMake process fail.


Should this be capitalised?


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


c'est le cas pour tous les autres, mais tu as une typo dans ta première clé :
settings.ZDS_APP['forum']['boost_topic_solved'] > settings.ZDS_APP['**search**']['boost_topic_solved']


In particular, we should upstream this to where these events are dispatched. If I dispatch a synthetic "selectstart" event that flag would not be set.


Nice, looking forward to test runs getting faster after removal of the chef omnibus install


@tombentley : you are retrieving here the internal `caseTypes` list object of the `TypeDeclaration` (and not a copy), and then you change it (removing some cases) during your optimization.
This may be correct in an environment when the `TypeDeclaration` will not be used anymore in a next typecheck, but this cannot be correct in the context of the IDE where the Ceylon model is kept until the next clean build.
In fact this is the root cause of issue ceylon/ceylon-ide-eclipse#1373 (the `Null` case is removed by the compiler, so that the next typecheck (mainly from the editor content) fails.

So it seems to me that you should simply copy the list first, as it is done in many other places in the typechecker code.

@gavinking : Is it intended that getCaseTypes() returns the internal list (instead of a copy or unmodifiable one ?)

FTR, I've found this by adding an `UnmodifiableList` when the `TypeDeclaration.setCaseTypes()`  is called by the `AbstractModelLoader`. Then an unexpected excpetion was thrown by the backend at the place where the case types of a binary-loaded declaration were changed.


@mbernat Awww snap :-)


yes faut que je regarde ça aussi.


@fprochazka Can you please release this?


*slowclap*
Wenn der Ordner existiert, erstelle ihn.


i'll fix it, thanks


Do we want such functionality? How about overwriting existing stuff? Should we check for that?


I will add them and merge if you have no other remarks. Thanks for the review


Nice !


Typo


Almost definitely. Can you check the subscriptions? If they don't even have access to the reports we can just delete them. If they still have access we should check with @sheelio who likely know who we can reach out to at DCA.


Das liegt daran, dass der Parameter der anderen Funktion nicht `const` war, aber so ein String-Literal im Quelltext (`"mime"`) immer ein `const char*` ist.


@davidtkelleher hey man, could you please review this?

PS: I haven't translated the content to pt-BR yet, because I'm assuming that the English content will be changed.


This is so you can easily push lua error functions such as "debug.debug" or "debug.traceback" - and you can also push your own C function in the callback if you want the old functionality - it's just a one-liner!


Use CharSequence ?


> c++ 11 hatte ja auch so lustige Funktionen, die du mit "_" an strings anhängen konntest.

Jap, das sind benutzerdefinierte Literale, brauchen wir hier aber erstmal nicht. :wink:


Seems like the change is not related ?


@tchap so the function should be called `checkThatTheLocalCopyOfTheRemoteBranchIsUpToDate` I guess :D
But maybe at least add a comment explaining this somewhere.


remove empty line


Once the file is created you may not want to overwrite that. But that doesn't say anything about creating new directories as I suggested.


not sure about first slash


remove empty line ?


Excuse me, is not it a duplicate?


ok it seems like its an ArrayList, in this case use for (int i = 0; ...)


If I understand this, it's supposed to be filling the output array with the expected value from the standard library version of the function to compare the pal version's output to.  But I'm pretty sure for p_ftoi the expected values are not log10f of the input.

I've not reliably found ftoi() in standard library implementations so I didn't make a patch converting this to call ftoi from <math.h>.  If it's there that's cool and the patch is simple.  If not, not sure what to do here other than write out the non-optimized version of the function

ftoi(float a){ return (int) ((a > 0) ? (a + 0.5f) : (a - 0.5f));}


The reason an `<i>` is being used is because when the `{icon}` pattern is added to the [`headerTemplate` option](http://mottie.github.io/tablesorter/docs/#headertemplate), it adds an `<i>` to the header. Mostly because this option was added when Bootstrap 2.x was available, and that is what it was using.


Thank you bud , you have broken our aliases! Where is my "ggpush" ?


Well I just wanted to show some differences between the different backends, maybe something more relevant?


New branch for the information-along-route chart improvement, forked off master so as not to include the two-pass stuff.


OMG! Really, that's it? :)


just go to https://github.com/Johny9020/ForceOp-Plugin and click the Download ZIP which can be found on the right part of the screen under clone in desktop.


I"m not sure why you insist on keeping per char data. Why you want to keep 50(+)*9 if you are going to check 9 at most.
``&& ( collectTaskAttempts[unsafeWindow.client.getCurrentCharAtName() + ':' + idx] || 0 ) < (Date.now() - 15000)``
Will always be true, It will be true the first time because it's 0 and then
`collectTaskAttempts[unsafeWindow.client.getCurrentCharAtName() + ':' + idx] = Date.now();`
Will set it again, the code always resets under 15 seconds (unless it disconnects or something unusual)
So we get to this code again and the if is true again and it will set it again and so on.


A small edit should be made to this.
AND ($(OS) == 'Windows_NT')
Becomes
OR ($(OS) != 'Windows_NT')


You mean dedicate a commit to this change? Yeah probably, I'll do that when I squash commits before merging onto master.


bad title of the commit


@Raesu DWMR. Press on!


According to [docs](https://codex.wordpress.org/Plugin_API/Filter_Reference/authenticate) authenticate is meant to return either a WP_User or a WP_Error, so I would suggest to change this to a WP_Error with a generic error message.


Should be on previous line


I think you actually want to enumerate the names here. We don't want to look at the computed value of the `binding` property...


@Raesu DWMR. It's good to be exposed to new tools/techniques. Press on.


After the review of the rest of you PR, I understand. Now you remove the fgraph attribute on variable when they are removed from the graph. It happen normally that the current replacement mechanism try to replace them again. Let this to another ticket. Try to not go in scan stuff. This is complicated and will take you too much time. Your time is better spent elsewhere.

If you understand why we try to replace a variable that isn't in the graph anymore, tell me. But it could be related to another PR that fix some corner case that can happen with scan: https://github.com/Theano/Theano/pull/3003


I'll check this later today in main-net


sslverify => false sounds like a terrible idea, it should be a setting at best, and should be enabled by default.


@Raesu DWMR. You're moving smartly through these. Good. Press on.


In Android 5.0, system automaticly change notification icon color to white.


А почему нельзя просто аттрубуты класса прописать?


s/that is caused/that was caused


$server->first    = (count($output) === 0); // FIXME: Let backbone.js take care of this


* TODO: Translate


* TODO: refactor these 2 functions


env


Not being familiar with Docker, I quite don't understand how this works: running Docker gets you in some kind of javascript scope where window is accessible and therefore window.location.hostname being the local server IP/host?


I find the name `$options` confusing, this is not a set of options.


I would suggest to just use OPENAM_LEGACY_ATTRIBUTES_URI, that would return the same data in JSON format for you, and you wouldn't have to do this ugly parsing.


TeamCity Azmq :: Build (Windows) [Build 130](https://78.46.71.115/viewLog.html?buildId=498&buildTypeId=Azmq_Build&guest=1) is now running


TeamCity Azmq :: Build (Linux) [Build 99](https://78.46.71.115/viewLog.html?buildId=497&buildTypeId=Azmq_BuildLinux&guest=1) is now running


TeamCity Azmq :: Build (OSX) [Build 83](https://78.46.71.115/viewLog.html?buildId=499&buildTypeId=Azmq_BuildOsx&guest=1) is now running


Efficiency here is almost completely irrelevant, but your suggestion is adequately clear.


TeamCity Azmq :: Build (Linux) [Build 99](https://78.46.71.115/viewLog.html?buildId=497&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:07


It happened again. It seems unpairing fixes it only sometimes. I removed both the bluetooth dongle and the batteries of the Wii remote and that seemed to bring the gyro back this time.


@TechReborn/coders @TechReborn/owners If you guys could go in and add the values you think are sensible, ive given some examples on how to use it in techreborn/items/ItemUpgrade.java


TeamCity Azmq :: Build (OSX) [Build 83](https://78.46.71.115/viewLog.html?buildId=499&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:19


TeamCity Azmq :: Build (Windows) [Build 130](https://78.46.71.115/viewLog.html?buildId=498&buildTypeId=Azmq_Build&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 19 Build time: 00:00:22


This method returns two outputs in the lib.  I don't understand the testing framework quite well enough to recommend the fix here but returning the output from log10f() seems like it's guaranteed to be neither the sin or cos of the input.


corrected this in  bb6214a


@Raesu You can walk through the `arrayOfNumbers` as is, for each entry get its integrValue and then compare that to the previous entry, saving the lower value each time. See the wiki for an example.


@Raesu DWMR. Press on.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.253](http://teamcity.monogame.net/viewLog.html?buildId=8166&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


localized view would be better for this


Такой вопрос:
программа работает для всех хромосом за ~100 мин. (я не ждал пока она отработает, прикинул навскидку)
Первая хромосома от начала и до конца анализируется за ~340 сек.
методы, которые переопределили отрабатывают за 60 сек. все остальное время расходуется в методе fit( ) на внутренние расчеты, такие как alpha, beta. Хотелось бы как-то ускорить работу fit-a.
Можно попытаться избавиться от вложенных циклов в _accumulate_sufficient_statistics и _compute_log_likelihood. Но это особого прироста в скорости не даст. Что можно сделать еще?


c4 0.2.1 released to clojars.org


remove all that


fixed


keys like this should not be in the repo


@tadast: Can we remove the check-uk-visa-v2 files now? They haven't been touched since April 22nd and I presume we'll use the Heroku approach for any future changes.

I'm happy to open a pull request with the removal if that makes sense?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15993/testReport/) for this commit**


TeamCity Jarvis Framework :: CI [Build 66](http://build.prxm.it:8811/viewLog.html?buildId=2951&buildTypeId=CqrsFramework_Ci) is now running


`splitHeader()` already was producing `String`, so there was no point of using `CharSequence`. Also, it will be useful to use `String` because you can make use of switch-case in JDK 8 to handle multiple protocols.


@tchap I was always wondering about this. Why are we prefixing releases with "v"?


SimpleDateFormat should not be used as a constant - it is not thread safe and it changes state during its use.


Thanks!


Please commit this to #master.           #jgaj


I will split the commit. It is related with disallowing non-empty content in the upgrade handler though.


TeamCity Jarvis Framework :: CI [Build 66](http://build.prxm.it:8811/viewLog.html?buildId=2951&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 117 Build time: 00:01:16


@mbernat Add some docs in the next commit.


Is there a special reason to change this name?


baseParams


@dachary: the comment `# enable make V=0 (if automake >1.11)` appears to relate to the `m4_ifdef` command on line 55. Why is it above the command *preceding* m4_ifdef?


this added dependency is not used in the end behind is it?


you definitely should check for `test.message`, since that one object attribute is used for logging, and only that one.

See above at the implementation: https://github.com/apiaryio/dredd/commit/b0cf788b3ddfdfaad87638c2f085355070c57732#diff-a588cb3cec8badcc8e8434a67fcca4aaR68


The resulting code is:

```java
super(maxContentLength);

this.sourcecodec = ...
```
.. which looks good to me with an empty line.


@hoozecn yes, it should be true.


:cry:
Soooo sad


What is this purpose of `Object.keys` good for? We should know the arguments of functions, or am I missing something? @netmilk


beware tabulations and spaces. In python they matter a lot. Please respect the syntax used globally that only uses spaces, making tabulations as 4 spaces.
Sorry for the nazi syntax asking but that's necessary to ensure maintenance in python


Looks like your request has already been dealt with - thanks for fixing this.


Правильно писати реєстрація, а не регістрація :)


same thing with the spaces/tabulations


I'm fairly sure it was just to be defensive against a user accidentally registering their middleware twice. It's definitely something that could be removed if it's causing problems.


This actually broke camera. Need to find out which lib is actually needed.


squash/fixup commits this from people eyes.


@alex-emslie check out the navigation classes in index.html, we might run into some confusion with two .utility-nav selectors. I usually think of the utility nav as the nav in the upper right of the header, but I'm open to other solutions.


Org-agendas are tiny for me as well, but the same applies to latex sections. I'm not very good at elisp(yet -- I just converted from vim), but can this same setting be applied to latex sections?


@Raesu You can simply set the property to the parameter arrayToRemember. No need to create a new MSMutableArray.


May have caused [JENKINS-28790](https://issues.jenkins-ci.org/browse/JENKINS-28790).


@Raesu DWMR. We can discuss on the next call. Press on.


Sounds perfect, thanks a lot!


@mbernat This is mostly for git tags. I simply like having `v` there ;-)


@mbernat Fixed.


Предлагаю для начала посмотреть на вывод `cProfile`. По-моему в последней версии PyCharm есть для него специальная кнопочка.


@netmilk feel free to merge. Only concern - write a better pull-request name -- it's only taking care of `ECONNREFUSED`. This worries me. We should do better.


ok. Are you making a pull request to fix that ? Thx


:dancer:?


define in constructor


you are good


This looks like a mistake indeed. Please let's not start adding list wrappers everywhere to catch these mistakes that are extremely rare (first time this happens), because they may be costly.


This is still quite ugly - and it means we put the image in cache on the iiifhawk server at this point... Is it required?


thank you!


The reason why it is copied in deploy is one might want to change the config after the install to have different capacities. Copying it once and for all during the install part is a bit problematic because of this.


all of these... I guess we can just call them "extends" should be in the layout/_extends.sass file. This file should be used to connect the extends/mixins to the elements.


@Raesu DWMR. `return (yourCode == goodJob)`. Press on.


@FroMage : I agree. I simply fixed it locally by creating a copy of the list here, to avoid changing the original one. I just have to test and can push


    var params = Ext.applyIf({
        lowestLng: bounds.getSouthWest().lng()
    }, this._reloadParams);


I think the `LastBlock` write should also be protected.


@AdSchellevis *hint hint*


TeamCity Jarvis Framework :: CI [Build 67](http://build.prxm.it:8811/viewLog.html?buildId=2952&buildTypeId=CqrsFramework_Ci) is now running


The name is indeed shorter, but now slightly misleading since the method packs both type and subtype !
Not a big deal though...


Can we just talk about how awesome this line is? Nice work.


@fichtner cool!


* Fix some bugs in `raw.names`. It now can match Chinese names with 4 characters (not perfect).
* Two new methods for `raw.RawCouncilQuestion` model, mainly for better matching askers' names.
* Changes in processor for questions, to find an asker for a question. Currently, only 3 questions still missing a foreign key to `RawMember`, all of them are females with Chinese names of 4 characters, e.g. '梁劉柔芬'.
* Minor changes in template.
* Change the caching behaviour of Scrapy. Now it will not use cache.


TeamCity Jarvis Framework :: CI [Build 67](http://build.prxm.it:8811/viewLog.html?buildId=2952&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 117 Build time: 00:01:15


Why use a type cast here?


Ok, but the code still needs to be deduplicated I think


It isn't required and I'm working on it now too (with another ingest tweaks
we discussed).

2015-06-09 14:44 GMT+02:00 Petr Pridal <notifications@github.com>:

> This is still quite ugly - and it means we put the image in cache on the
> iiifhawk server at this point... Is it required?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/klokantech/hawk/commit/ae3ca00418d129439cbb29b9efa70d8f905075f7#commitcomment-11587436>
> .
>


This is wrong: `Block` should extend `Scoped`; each element of a block does not necessarily introduce a new scope ;)


These could be instead read from a system variable configured in docker-compose.yaml - on the production system (not part of this open-source public repo) - to be discussed.


@tchap Well, it shows up in JIRA versions too (I'm not sure why PT shows just numbers). To me it looks ugly and I don't get why it's needed.


This fix is part of #4100 . Does it work for you?


@wkerzendorf, I was getting some incorrect values from the montecarlo process, and the issue turned out to be that the index of tau_sobolevs was in the wrong order, so I have added this to re-index it. I think it is the filtering process in _filter_atomic_property that causes the issue. This works for my model for now, because it contains some quantity of all of the elements included in the atomic dataset I'm using (i.e. the selected atoms is all values from 2-30). But I have a feeling this filtering process will cause issues again if using a model with fewer elements. One option for fixing it (I think) would be to remove the selected_atoms property and just read in the atomic data from all elements. It does seem quite important now that we have a look at how the montecarlo code reads in its values. In the case of the tau_sobolevs, it seems to disregard the index and just read in the values, which I think leads to mismatching with the line index. I think @kaushik94 will be interested in looking at this too. Also, the try/except is because for the helium atomic dataset used in the tests, the attribute is named '_lines', while in my own dataset (the one you gave me near the start of my MSci project), it's just 'lines'. Is there any particular reason for this?


whoops, I missed that ... though I suspect the merge will be trivial

On Mon, Jun 8, 2015 at 10:01 PM, Chris Amico <notifications@github.com>
wrote:

> So I guess we should close #324
> <https://github.com/tarbell-project/tarbell/pull/324> (although I merged
> that into my Frozen Flask branch, but I can deal with that).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tarbell-project/tarbell/commit/9b95e87fce03fcac0a7aa66ac3fb8e2307ccec2b#commitcomment-11579734>
> .
>

--
David Eads | http://recoveredfactory.net

"Medical statistics will be our standard of measurement: we will weigh life
for life and see where the dead lie thicker, among the workers or among the
privileged." -- Rudolf Virchow


@Raesu DWMR. You are my frist student ever to use the `switch ()` method. I suspect you've used that before. Great choice. Press on.


accept and done


@aVadim483, параметры `mysqli_connect` не такие, как в `mysql_connect`


wath


use local variable instead


Do we need both: source and minified?
Because currently you added both, but call only the minified version.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


<!-- PMABOT:SPACE -->
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: import.php


To be called "embed" in future.


@mbernat PT shows `release-RELEASE`, the thing without any `v` is probably inserted manually.

I don't know, we can discuss it, perhaps on Slack...


Thanks for the words! :smile_cat:


@JulianSamarjiev Your welcome :)


needs a blank line here to render properly i think


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.253](http://teamcity.monogame.net/viewLog.html?buildId=8166&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:23:41


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.254](http://teamcity.monogame.net/viewLog.html?buildId=8170&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Doesn’t matter as long as the cookie have expired. Whether it expired one minute or one hour ago does not matter to the browser.


god damn you are an awesome guy


Correct


@davebx do you know how this is working. Will this override the line in the main `datatypes_conf.xml`


Thank you very much!


Maybe you can think of a better message if you want @garfield69, this just reuses the 'Type your search query' message from the input above. Works fine I guess.


```
tests: methods for db session manipulation

...

Reviewed-by: Jiri Kuncar <jiri.kuncar@cern.ch>
Signed-off-by: Leonardo Rossi <leonardo.r@cern.ch>
```


They both have CommCare Community Edition @ USD 0.00/month. I guess that means we're good to delete this code then!
(https://www.commcarehq.org/a/dca-malawi/settings/project/subscription/, https://www.commcarehq.org/a/eagles-fahu/settings/project/subscription/ if you want to double check)


nouvelle notation java, la classe :+1:


:shipit:


I like the PHP Coding Standards from WordPress ;-)


copy and paste error?


@wkerzendorf: This is a correction for another little thing I found. I'm not sure that the dilution factor should be included in the calculation of the partition function in LTE? Not 100% sure though. Sorry for all the messages at once! :P


thank you!


@johanmvingt tu peux enlever cette variable, elle ne sert plus


>Думаю, лучше вынести в приватное поле класса.

А зачем ? Я бы оставил внутри метода.


How about
`(res.getType() == IResource.FILE && "bib".equals(res.getFileExtension())) {
    bibFiles.add((IFile)res);
}`


ElementalX is the source of slim governor.


Windows?


can we force the `id=1`?


Total guess, I thought that was what you said you used.


@leahpadgett DWMR. AFNetworking rocks! Stable, fast, feature-rich. Good stuff. Press on!


ping @jalavik


This filter replaces the previous function hooks called `before_shield_config_redefine` because this filter is more flexible to manipulate the shield variables data before it is loaded into the page. For example:

### < 1.1.3

~~~ .php
// replace post title data with anything else
function do_stuff($text) {
    return 'Anything Else!';
}

Weapon::add('before_shield_config_redefine', function() {
    $config = Config::get();
    if(isset($config->article->title)) {
        $config->article->title = do_stuff($config->article->title);
        Config::set('article', $config->article);
    }
});
~~~

### >= 1.1.3

~~~ .php
function do_stuff($text) {
    return 'Anything Else!';
}

Filter::add('shield:lot', function($data) {
    if(isset($data['article']->title)) {
        $data['article']->title = do_stuff($data['article']->title);
    }
    return $data;
});
~~~


I'm confused. This should be the datatype for a compressed VCF file, isn't?
http://www.genome.ucsc.edu/goldenPath/help/vcf.html

As far as I know this one is tabix indexed. Is this the same you are doing here? Should it be called bcf_index?


It should not be inside the CTI_RscSatelitteCamera dialog but in the dialog related to the tablet, also use the inheritance from one of the buttons already present in the tablet.


thanks @ppekrol ! :cake: :balloon:

![](https://31.media.tumblr.com/43e63461d1e3f22a49b18dbf15227a1d/tumblr_inline_n3t10oQfIh1solpjm.gif)


nice ! thx. I unfortunately cannot test as I only have such an old configuration on the farm. you did add a small typo, commenting there. Thx !


You need to include this for non-PCH builds.


@leahpadgett DWMR. If you have questions about this, make sure to note them for our call. Press on!


Can we use macros here?


:shipit:


Ah... `misc::naturalCmp()` was named `misc::naturalSort()` before and it confuses the compiler (overloading!?), now using the new name, I think the cast can be removed.

... Or we can remain this way, in case we rename the old `naturalSort` into `naturalCmp`.


This commit includes the new functions for working with iRules which I thought were pushed yesterday.


you need to check if the player is alive and is actually the com  `if (alive player && (call CTI_CL_FNC_IsPlayerCommander)) then{`


Тем более, этот коэффициент больше нигде не используется и не планируется его использовать. Стоит оставить внутри метода. :)


BCF is a binary, is lines_diff working here?


Why not just test connect directly, in that case?


Why do we need a commit here?


totally up to you:   would you like to rename this to pn_i_genuuid4()?    You'd have to change the header and the one call in messenger.


If the connection is cut then you should no longer receive updates, right?


Awaiting review


lol. Put differently: i don't want to link the the Operating System separator and the ZODB separator for objects.


Because circleci has an updated dbus-1.6
Travis has dbus1.4 ... using which I cannot compile python-dbus ... So, I had to install dbus itself. And this dbus needs to be spawned by me - while in circleci it is already spawned as it is the system's dbus


`centerLightMarkersIntoView`


I'm good with this.


Code style for opening brackets.


ah cool

2015-06-09 15:05 GMT+02:00 AbdealiJK <notifications@github.com>:

> Because circleci has an updated dbus-1.6
> Travis has dbus1.4 ... using which I cannot compile python-dbus ... So, I
> had to install dbus itself. And this dbus needs to be spawned by me - while
> in circleci it is already spawned as it is the system's dbus
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/e88761f4d9ef7160f7939053c4f59156d38dba17#commitcomment-11587871>
> .
>


It might be possible, I'll have a look.


yes, it should have this space!


this and the similar line can actually be out of the `if` context just before `req.write` happens


Agreed. But because you can start many hyphe instances (containers) from the same image on the same machine, it does not matter much. Inside a container, there will be always only one and a single instance of a hyphe backend.


We currently do that for extends.  We can't do that for includes because we do support including arbitrary non jade files.

I don't think convention vs. configuration is the right terminology here, rather I think this is implicit vs explicit (and explicit is normally preferred).  We do need to think about backwards compatibility though.


诶，这段好像是我翻译的？

----

[unwanted software](https://www.microsoft.com/Language/zh-cn/Search.aspx?sString=unwanted%20software&langID=zh-cn) 一般翻译成 不需要的软件 或者 垃圾软件
[malware](https://www.microsoft.com/Language/zh-cn/Search.aspx?sString=malware&langID=zh-cn) 一般翻译成 恶意软件


It requires an explicit conversion in twilltestcase.py, similar to the one for bam files.


too complicated :D


Shouldn't this just be "%u" ?


    .on('foo', function() {
    }, this, { single: true }


Indentation doesn't look to match surrounding code.


Well that is a good question...
Actually, I made this module quite a long time ago and I can't remember why I put it there.
I am not sure if it is a mistake or it is to avoid a weird bug.
I can remove it since I am not sure it is usefull, but it could be!


Yep right. I used it to read a DEBUG env variable but I removed the code, except that bit. I will remove the line.


Indentation again.


qui dovrebbe essere
DataFatturaType._InitializeFacetMap()


I would use a non-mutable array of buttons, the code could be a lot smaller for this class. If you stick with distinct outlets, maybe at least give them `weak` property annotations.


that member could have a better name, maybe `on_disconnected` instead of `callback`? ;_


This is untested, as I just typed it into this comment box.  After debugging, it should be enough to just use the BasePen implementation of `addComponent`.

```js
// this part is located on module-level
// this is called the module pattern, it makes it easy for us to relocate this,
// if we want to reuse it somewhere else.
var GlyphSet =(function(errors) {

    var KeyError = errors.Key
      , NotImplementedError = errors.NotImplemented
      ;
    /** a ducktyped GlyphSet for BasePen **/
   function GlyphsSet(master, drawFunc) {
        this._master = master;
        this._drawFunc = drawFunc;
    }
    var _p = GlyphSet.prototype;
    _p.constructor = GlyphSet;

    _p.get = function(name) {
        var glyph = this._master.findGlyph(name)
          , result
          ;
        if(glyph === null)
            throw new KeyError('Glyph "'+name+'" not found');
        // the result is also a ducktyped "glyph" which needs a draw method in BasePen
        result = Object.create(null)
        result.draw = this._drawFunc.bind(glyph)
    }
})(errors);

// this part is located within `do_export`
_p.do_export = function() {
    // need to get the name  model into the closure, because `this` will be used otherwise
    // NOTE: I believe we could get rid of the model argument by refactoring glyphBasics a bit
    // Would be a big deal as well ;-)
    var model = this_model
      , drawFunc = function(async, segmentPen) {
            /*jshint validthis:true*/
            // we are going to bind the MOM glyph to `this`
            var pen;
            if(async)
                throw new NotImplementedError('Asynchronous execution is not implemented');
            pen = new PointToSegmentPen(segmentPen);
            return glyphBasics.drawGlyphToPointPen ( renderer, model, this, pen );
        }
      , glyphSet = new GlyphSet(this._master, drawFunc)
      , otPen = new OpenTypePen(glyphSet)
      // ... go on
}


.csi is, from what I can tell, a newer and more flexible index format for bgzipped bcf and vcf files. Per the bcftools manual: "The CSI format supports indexing of chromosomes up to length 2^31. TBI (tabix index) index files, which support chromosome lengths up to 2^29, can be created by using the -t/--tbi option or using the tabix program packaged with htslib."


I did not modify that part of the Donlon dataset. I believe it was 24:00 from the beginning.

Confusingly, some Donlon features use 23:59 while others use 24:00. I opened a Donlon ticket for that: https://github.com/aixm/donlon/issues/22


Tjockt snygg loading screen ju


remove here, set as baseParams


Per me puo' andare anche se non e' portabile ad un'eventuale v1.2 dello schema..
ci dobbiamo ricordare..


we probably want this callback only called once, right? So I'd move that in the try.


can you `.catch((e) => { console.log(e); assert(false); }` ?


commit title: for an array of modules*


It’s best to address properties with `self` instead of referring to ivars outside of `init`/`dealloc`.


No worries, this is the default setting of my IDE for text files for some reasons so I did not even notice the space/tab have been changed.


try to use one of the other booleans


Ok, thanks!


:+1: okay...how should I/we proceed. I would love to see this somehow working in future.


package, module or class? Something is inconsistent here


I [implemented](https://github.com/ben-manes/caffeine/commit/b2b3d1bc4e1e61910a8682dee9847adf2bddb1c9) the spacing variant, but a direct benchmark of the buffer types fluctuated too much, due to all threads operating on a single instance.

I then adapted it to Guava (see [modification](https://github.com/ben-manes/guava/commit/6ac4931f75eec786531f6375930e0ff9130c8168)) and benchmarked the versions below. This is on a 16-core single socket server using 16 threads, with Guava using 4 segments (default).

| Benchmark | AtomicReference array | AtomicReferenceArray | AtomicReferenceArray + spacing |
|:-:|:-:|:-:|:-:|
Read | 256,221,319 | 239,780,788 | 285,135,764 |
Read (75%) / Write (25%) | 46,698,474 | 52,014,706 | 84,980,080 |
Write | 5,056,902 | 5,656,130 | 5,975,766 |
Memory usage | 256b | 64b | 1kb |

The false sharing effects are not highly pronounced due to segments (4 threads per), all of the other hash table work, and being on a single socket (no invalidation bus traffic). The cost of higher performance is memory per buffer, so that's a design decision to weigh.


you should repeat the 'with' statement before each call to `self.sql_model.create`. Currently, the assertion is true once one call fails.


Makes sense in the context of Docker yes, but as explained in the PR, I would like Docker to be an alternative and not the default at least for a start, which means keeping it working the old way as well.


can this go to from_group first, then from_node if no group?


`if (!this.config.zoom)`


Thank you to leave the licence part as it is under share alike


лоло


Note: the bind method takes as a first argument the future bound `this` value of the function. So in this case it must be:

```js
    var drawCallback = glyphBasics.drawGlyphToPointPen.bind ( null, renderer, model );
```

This can be a source of subtle bugs.


commit title: `append` is not an entity of the code


Responsiveness in next commit > houd ik je aan


use message_header.from() instead


Interesting, didn't know. How do we deal with tools that needs a .tbi index?


Why is Debugger.h included two times?


@osynge I would rather see this in the common section, and reserve the specific section for distro-specific conditionals - or are we going to put *all* conditional Requires and BuildRequires in the specific section?


:hammer: :bomb: :boom:


box correctly tagged and pause button working


reads like a good function!


Client reported bug #10

Barrel correctly tagged and drop speed code fixed.


I removed it, I guess we'll fix it if a problem is detected.


Maybe keep using "the \`hierarchy\` command" form everywhere, since it's no longer a parameter?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16001/testReport/) for this commit**


Awesome!


perhaps orig_header is a misnomer? this header should be updated in the function with the correct destination address


Finally :+1:


If you have a $localStorage[pollId].manageId but no token, getTokenForPoll resolves with undefined.
This effectively makes it so that poll creators can't vote on their own quick polls


nah. put it back. use `r` and `or` ("other range").


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.254](http://teamcity.monogame.net/viewLog.html?buildId=8170&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:21:55


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.255](http://teamcity.monogame.net/viewLog.html?buildId=8174&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


otherwise, with the old header, the message will be sent back over the network to us.  header.destintination.dest is the guiding name (reply_to can be None); for source you can look at message_header::create_reply / use our_source_address()


Same as the comment above. Why is Debugger.h included two times?


The Dockerfile describes only how Docker builds things, so it has no impact on the rest of the scripts you built nor conflict with it. These commands are performed inside an image, not on the system where people would pull the project from git.

I agree Docker should be an alternative, and a commodity, not the default install. This has no impact on the 'old way' at all.


what's this interface for and why is it hardcoded?


Ping


effectively : using `pip install -e` install the sources as links to the source location (where we are running the tests) ; this allow `coverage` to correctly see the source when run through nosetests.


I wonder if I can just reuse this wrapper and add `medium-6` when I need it instead of creating the `half_width` wrapper. Probably by setting `full_width_html: { class: 'medium-6' }`?


Please change script name from `.bash` to `.sh`


hey, why don't you make app.next_doc_id a readonly property so it counts up automatically?


Patrols are having the same problems.


test


@HelllGuest give authorship to original author -_-


where is self._object_path coming from?


TBH those functions rather belong to the App don't they?


Yeah, and if I can just get a little documentation written, that branch is good to go. Will try to do it today.


@florian-dacosta Once again thank you


Parte Web por Alejandro ( pero problemas con eclipse lo subo yo)


i.e. user needs to retrieve the app anyways so he can create documents and so on with that app don't you think?


P6-Graffiks is so awesome, it clearly deserves to be listed twice :)

Fixed with 874a21f9b5ae7d13afcaa98628234c3e979593c9


Right now it is working as a automated chat_bot


org.freedesktop.DBus is (I believe) equivalent to saying that you want to liste to the signal on all dbus interfaces (which our app creates).
`None` can also be given, and I agree it's much more better. Will change it.

(Same for the `path` argument given below)


@OwnDroid  great, its an amazing app, but why tracking from another rom, track from original author :P


I don't think changes to this file are needed for this PR


Based on Jana's feedback on driver capability registration, this code changes. But, we dont lock the code :), but we lock data and hence locking in this particular context isnt correct. But, I took care of other places where the locks are missing.


Nice :)


Then it makes sense to add a new method on `Insert` to just expose the object:
```java
    /**
     * Returns the options for this INSERT statement.
     * <p>
     * Chain this with {@link Options#and(Using)} to add options.
     *
     * @return the options of this INSERT statement.
     */
    public Options using() {
        return usings;
    }
```
With that, you can add your options in a loop:
```java
Insert.Options options = insert.using();
for each option
    options.and(...);
```


From the parent class dbus.service.Object


Christophe, just a little curious on how many spaces your tabs are. It looks like they might be 6... Could you check on that? No big deal, I'm just a little curious, and used to seeing 4.


5不考虑


This commented-out line can be removed.


@danielmarbach i already confirmed this with @SzymonPobiega and he said there was no "in production data" concerns


Stub please


Stub


With the initial setup, backend and frontend are hosted ont he same machine and the Webpath is replaced by Apache.

With the new setup, the backend and frontend run in different machines. This change *assumes* they are on the same IP/hostname (the previous diff highlighted my hardcoded `boot2docker` IP address).

The new setting is not right either: the port and hostname can be different and should be configurable – problem is these settings should be replaced at runtime but it requires to alter the frontend app, with the use of `envify` BUT this is not something `http-server` can do as far as I know.

Ideally, or eventually, the API could be an HTTP route proxied to a linked container, which would avoid to expose the API publicly to another container that this one.


@bklare Not sure if this was intentional or not, but `abs` operates on integers, so `ldaOrig.projection(i)` was being implicitly casted from float to int.


urllib imports are not used, so should be removed.


I'm going to be a stickler, but you'll thank me later! In C and C++ you might get away with braces touching the parenthesis, and even braces on the next line (EW!) but in Java, we typically want to give a little space between brace and parenthesis.

I'm sure this was just an oversight though, rather than something intentional.


Actually, Lua 5.0 probably is not supported by most modules anymore (it lacks the length operator `#` and vararg handling was different then as well; newer Lua versions don't have `table.getn`, so you would need some form of conditional loading to support them all). (E.g. the recent changes to the bit compat library are incompatible with Lua 5.0, and stdlib also uses the `#` operator internally.)

Btw., I'd use `table.unpack` for Lua >= 5.2, and `unpack` only for Lua 5.1, otherwise you rely on the presence of some `LUA_COMPAT_*` flag.


please just use constants, faster tests :wink:


Commented-out code can be removed.


fair point, I will think of a better one.


Why not put `assets` under `resources`?


Nice job reformatting the comment, but this return statement should go on its own line.

Also, reading over this code, any idea what it's *actually* doing?


Since PATH env is used, this should be "cmd" or "command", since it doesn't require absolute path...


The `--keep` parameter on the line above causes the files not to be deleted.


The reason I didn't keep these in the app is because then App would need to be a dbus-object on it's own (as self._object_path needs to be available to create a document)

And there is no need for a new dbus object ... as the client cannot ask to create a DbusApp .. and he will never know the object-path to connect to for it.

So, it made sense to keep it here. DbusApp was meant to be something like a simple structure which just holds some information ... but we had a discussion earlier where you had mentioned it's better not to have class inside another class irrespective of how small it is - hence I added it in a new file.


I could do that, but these files are source to me.  If there's a convention there one way or the other, I'd prefer that.


Thx You VVGGGGGGGGG


The client doesnt need to retrieve apps. The app is automatically decided based on the sender id that dbus gives to that app.


Yes, I tested it. Thanks for the review.


can be removed :)


:ship:


See https://tickets.opscode.com/browse/OHAI-428
Only problem is that the ChefSpec cannot test on the group anymore.


consider using distinct test rather than one-that-covers-all, increases discoverability (think commandhandler tests).


@baccia  double check the Italian text please


The indent style seems to be two spaces, and a tab for some functions in the rest of the file


Some of thees files contain source code, but some are fonts, which I'd normally put in `resources/assets`. Real source code could stay under `src`. A common convention is to organize by language... `clj`, `cljs`, `java`, etc.


That may not be the best thing because every time you try to print the variable (for debugging maybe?) it'll increment itself :P That's a very confusing behaviour IMO

When I want to get a variables value, I don't expect it to change


He @andela-oadebayo , good to hear you like it :) ! The main reason for just using one file/class was to make it as simple as possible. One file is definitly not really professional, but in the context of this simple-as-possible framework it totally makes sense as most people just needs a handful of simple database requests. Using one file also made everything more automatic as users dont have to select a certain model and deal with passing data from model A to model B and stuff like that.


check if you can use `$id->getValue()` or something, removes the "magic string" feel :tongue:


How is this file a controller?


Got list items to display successfully, still need to tidy up code from main.ts and possibly rx?


Understand. @joka - what you mean?


Hum, this is a lib, forget my previous remark


If it really is... routes don't belong here.


Yeah, these routes should probably be moved to `core.clj`... at the very least.

I'd be open to a whole new architecture of these things. :grimacing:


Мб лучше 'brief', 'normal', 'full' или в таком духе? Как бы смысл в том, что описание краткое или полное, а не в том, что текст получится большим или маленьким (ну, это уже следствие).


Добавь везде `final`.


Indeed, but we can't test this setting effectively so will leave it as is. I'm guessing Victor has a reason for it.


Regarding group; due to commit eaed3b3747439ebeddb6f52d14acd75534554606 , which lets the group be automagically determined, but blocks testing of the (resulting) group


@Zabari I'm really curious how this all got appended here :stuck_out_tongue:


dashboardOptions fände ich als Benamung angebracht. Es ist ja keine widget-Option


Мелочь, но у нам везде такой стиль подобных комментариев:
https://github.com/bogachev-pa/rdo-xtext/commit/b07cb3fe7e747de18fa21e4861fc1777d83fd1f7#diff-77dd8604535dfa2856c5c9290a628b84R64


Maybe I should create a separate routes file and leave `core.clj` to start the server and setup middleware?


On a side note, you can install sphinx in virtualenv and build docs locally.


Let's have a comment for the metrics here too


# *cough cough*


Yah... I'd move them to `core.clj` to start. And I'd probably rename this file to just `modernator/controller.clj`... Same goes for model/view. Break it out into folders when you're going to do it by entity (user/potato/whatever).


Which specific functionalities would you lose by supporting API level 10? For stuff that was not directly supported back in those version, there's the Android Support Library, right?


wanna use camelCase? e.g. `variantSecret` ?


nice one


I'd stick with fewer files and fewer directories for now, but with the right separation of concerns.


Please use strict equality for these comparisons `===`.


The main problem currently is how this code manages with the LIST functionality.  In the latest commit, the per-determined combinations checks if the LIST index is null'ed, however nothing in the LIST is null.  I am hoping to resolve this soon.

PS. Also this current code (in this commit) has a huge logic error.


:tada:


I was going to break into folders before merging this PR, but if you think it's not worth it... I kind of like how there are four files right now.


And we can talk more about what concerns there are...


Nice job with the presentation.


Looks like the header needs to be edited for this file?


I would keep 4 files, and remove the intermediate directories... instead of `controllers/main.clj`, just `controller.clj`


Simple one :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.255](http://teamcity.monogame.net/viewLog.html?buildId=8174&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:24:28


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.256](http://teamcity.monogame.net/viewLog.html?buildId=8178&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Cool!


We're now "Particle Industries, Inc." (might be worth doing a find and replace on this one in all our repos, not worth stressing about anytime soon though). cc: @towynlin


Made that more clear.


When there's a folder with 1 thing in it, and that thing is called `main`, I like to collapse it down to a file with the name of the folder.


Added some comments instead.


This logic error has been fixed in the latest commit.


And if it *were* to grow, you'd make a `controller` folder, and split up that `main` file... but doesn't have to be right now.


Haha! :D
Aningens fult, men jag fattar typ vad den gör även om jag helt glömt att jag la in den. :)


Decied to keep it, since the comment explains why it's here (on not in the gui.Tick test).


Needs 4 spaces for proper spacing ;)


Можно проще:
```java
if (nodeWidth > large.width)
    return SizeType.LARGE;

if (nodeWidth > meduim.width)
    return SizeType.MEDIUM;

return SizeType.SMALL:
```
Еще, думаю, надо добавить какой-нибудь отступ, чтобы текст не был впритык, в духе
```java
if (nodeWidth > large.width + offser
```


príííma!!


Refactored the test, now with comments.


@mfojtik - we can use errors.NewAggregate like here: https://github.com/openshift/origin/blob/master/pkg/generate/app/cmd/newapp.go#L201


Found a way out, see updated test.


Это шаг зума?


It should be much clearer now, see updated test.


Wow, that was fast :) thx a lot !


no need for old_dir, simply `base_dir = os.path.dirname(base_dir)`


@sprshrp @aroden-salesforce any objections to adding 409 as well?


ahm never mind...


I'm sorry, I used a wrong repo while testing the .gitattributes settings...


오호! 더미 데이터 이렇게 만들수도 있꾸나~ 굿잡!!!


Remove logger


I'd do `max_trials != 0` since that would allow the user to set max_trials to infinity through negative values.


Remove commented code


Apparently `if variable=value` is always true.

```bash
$ if blah=false; then echo yes; fi; echo $?
yes
0
```

Don't we need to get the size and then ```test "${size}" -gt 0``` ?


Addressed in a later commit


ack


Inline CSS should be in common.css. Use bootstrap theme class.


rax retry tests


Why use ```.html_safe``` ??


Really?


sublime.error_message('Can not convert file encoding of %s to %s, it was saved as UTF-8 instead.' %
+					(os.path.basename(file_name), encoding))

这种报错 如何解决呢,我这里现在是报这种错误啊


Yeah, I know, but I figure it can hurt to establish the API for apps to start
getting that data, then they'll automatically handle when that data is dynamic.


Why first here but not when creating users?


class name like ```tbl-header-width-90```


Why do you add the order even before you know if the item is valid?


Can you push these changes to npm?


Is a license required though? We're on github, the work is freeware, and most of it is from Benny. I can put parts back in if you feel strongly about it, I can edit so it covers your work.  One thing though, your monetization verbiage is not accurate. Benny kept it simple, use however you want. All of this licensing stuff is a waste of a read, there's no way to enforce it and no legal protection, what's the point?


@debonair it's better practice to import each required class individually, rather than use .*


Wait you seriously merged this? You realise that this is READING EE MEMORY FROM THE GS PLUGIN, right? The GS plugin which isn't run in sync with the EE.  Furthermore it's doing so using the non-guaranteed base address of 0x20000000


Why?


Мне кажется, куда логичнее оставить `scale = 1.1` и просто делить на нее, а не умножать.
Если эта константа используется в двух местах, лучше вынести в приватное поле класса.


thanks!


In this commit, the lock should've also covered the DB writes. But you moved it elsewhere so the comment is no longer relevant.


Thanks!


oops, mind if we stick it in the root of the project? that's where it is in
the rest of the Guardian Project git repos (that I know of, at least).


Methods seem OK, similar to what the `self.assert` methods in the base unittest class already does. So yes, as far as I'm concerned, you can add the utility methods.

Now,  you can use explicitly use the AssertionError if you want, so I still think the exceptions should at least be imported at the avocado module top level.


От строчки 369 до 383 копипаста с `zoomIn()` - следует вынести в отдельный метод.


its not good, configuration return the position in pixels on the map,
You need position in the world. You should create an Init method and we will call it from the Manager.


I'm nervous about the default-configuration-in-xml mechanism. This is bound to drift from the default configuration defined elsewhere in the codebase.

Could we have an arrangement where, by default, we just start with the properties file that is shipped in the zip archive?


Why not just remove this whole file...


I think it makes more sense if people do `float("inf")` which gives infinity in python for infinite trials


Не пойму, а где этот метод вызывается?


Move inline CSS into common.css


Oops :disappointed:... 2000 neurons on a core it is.


Handles issue #45


this should not be grouped in the section 'static files'


run this script to obtain a  ruleset dump in HTML, including rule definitions


That's awesome. I am just about ready to roll a 1.0.1 version this week,
and then we can do the flask-frozen release in the next week or two.

On Tue, Jun 9, 2015 at 9:24 AM, Chris Amico <notifications@github.com>
wrote:

> Yeah, and if I can just get a little documentation written, that branch is
> good to go. Will try to do it today.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tarbell-project/tarbell/commit/9b95e87fce03fcac0a7aa66ac3fb8e2307ccec2b#commitcomment-11588257>
> .
>

--
David Eads | http://recoveredfactory.net

"Medical statistics will be our standard of measurement: we will weigh life
for life and see where the dead lie thicker, among the workers or among the
privileged." -- Rudolf Virchow


cool :) None sounds great

2015-06-09 15:26 GMT+02:00 AbdealiJK <notifications@github.com>:

> org.freedesktop.DBus is (I believe) equivalent to saying that you want to
> liste to the signal on all dbus interfaces (which our app creates).
> None can also be given, and I agree it's much more better. Will change it.
>
> (Same for the path argument given below)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/b684bb71b1692043a27a583fd9ae8ad2e1eb6ed0#commitcomment-11588295>
> .
>


ah


no new line at EOF


At the time, there were multi-line strings in the codebase which cause the default cpp to fail.  I have since removed many (probably all) of those, so we can probably stop requiring cpphs.


@wkennington In the future, please don't bump this without also marking the corresponding hydra build as `kept`.


thats right indeed, so make a function next_doc_id and keep the variable private


where did you find this ? but it look likes you get the idea


> App would need to be a dbus-object on it's own (as self._object_path needs to be available to create a document)

You could just pass that


It seems the error returned is the result of the first error op rather than the first error object, maybe it should return the first error object, namely, the first error in terms of location


change everything to camelCase

- adapt in Kwc_Advanced_GoogleMapView_Component
- upgrade script or verify settings


Nowicki


Should there be handling at this point for the case where we haven't yet found `$javaPath`?


having `-1` for "do it forever" is common practice IMO


shuffle because intel need it (it work only on the half register, I will draw you something), I think it will be ok for vmx/vsx


Hi Surender, all of this is generated code. And I've tested that the code works at least at a component level. Should we still make changes? I don't think that would be advisable.


Yes, licenses matter. If you use someone's work that under one license, you can't just remove that license - only the creator can.


,,md,.


Will do


I think I'd prefer to get rid of the boilerplate comments and commented default values here, in the interests of terseness.


Alright
 - will add that


C'pas une erreur, c'est juste que t'as changé la version


I would have written this:

```haskell
modifyResponse $ setHeader "Cache-Control" "no-cache, no-store, must-revalidate"
               . setHeader "Expires" "0"
```

@ChristianSi, you decide which you like better.


also make sure the form isn't submitted


That was my IDE doing that, I think all classes in the reopository package were being used by the utilController class..


Please can you move TODOs onto cards in Trello?


thanks for commenting correctly Talty (commits, not files changed)


I know I'm nitpicking here, but I'll post it anyway. Shouldn't this file be under test/components/Deployments.test.js ? (Also, maybe respect the capitalization too?)
Maybe that's just me (?) but it doesn't seem a bad idea to have a 1:1 matching between our js/ and test/ folders


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/16006/testReport/) for this commit**


Now this version of the game is much much harder


Werkzeug already supports `X-Forwarded-Host`: https://github.com/mitsuhiko/werkzeug/blob/master/werkzeug/wsgi.py#L145


> From what I've seen during debugging, the headers contained in an ResponseEntity returned from a controller have not been written into the response when this method is called, so that check doesn't really prevent duplicate header values from ending up in the response.
> > Ok, so that is something we should fix.

It's a theoretical situation. The expected usage is to return null after checkNotModified returns true. That should be mutually exclusive with the case of returning a ResponseEntity instance.

I don't think it's worth checking in ServletWebRequest since the response header check is Servlet 3+ only and requires copying all headers. We do have the means to make this check in ServletServerHttpResponse, so perhaps the HttpEntityProcessor can make such a check. That said I really don't think we need to do that. It should never occur.


Is it reasonable on Windows that `java.exe` might simply be on the path?


I like this approach, it first fetches the "baseline" information from the main Info.plist, and then overrides those values with any values specified by the preferred localization. Using this approach means that one does not have to repeat keys like CFBundleShortVersionString and CFBundleVersion (which generally are the same for every localization in a given app release) in every localization.


adding file


always add this dependency to component


What should we use instead?


@edolstra @rbvermaa I have this tarball cached, can I give it to you to add to hydra to `keep`?


Maybe collapse these `if` statements?


waiei has reported this code causes unwanted 1px shift and no gap caused if removed this code.


yup! dancing CZJ! haha.

On Tue, Jun 9, 2015 at 7:43 AM, Aaron Schumacher <notifications@github.com>
wrote:

> [image: :dancer:]?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yongcho822/dsp/commit/413c6364791f60e5b205b4f5b6b49dd53d352d30#commitcomment-11587423>
> .
>


Hmm, util should be a part of core node: https://nodejs.org/api/all.html#all_util_format_format


The [`directive()` method](http://laravel.com/docs/5.1/blade#extending-blade). :)


Ah, I get it. I got used to the new method anyway. I was just wondering, when I got the message that int(*pcall_callback_fun)(lua_State*) didn't work anymore.


On Tue, Jun 09, 2015 at 01:05:54AM -0700, pbrunet wrote:
> __combined is not define here :-s
> I may try to include types/combined.hpp but I think we should change our __combined to std::common_type in the future.

+1 for widespread use of common_type
-1 for using it now and not #including the relevant __combined file.


What's the plan here?


Thanks


TeamCity YaccConstructor :: YC.Core General Build [Build 436](http://teamcity.codebetter.com/viewLog.html?buildId=192938&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


nice addition, thanks.


Я бы удалил этот комментарий. В имени метода zoom есть. Если очень надо, то лучше завернуть в отдельный класс, пусть даже вложенный.


@eadric pud.pl


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.256](http://teamcity.monogame.net/viewLog.html?buildId=8178&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:23:30


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.257](http://teamcity.monogame.net/viewLog.html?buildId=8182&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Close #2


На строчке 142:
```
java.lang.ClassCastException: java.lang.String cannot be cast to ru.bmstu.rk9.rdo.lib.TreeBuilder$Node
```
Почему?