1: D400 First line should end with a period (not 'e')
4: L102 copyright year is outdated, expected 2015 but got 2011
23:1: I100 Imports statements are in the wrong order. from pprint should be before from string
24:1: I100 Imports statements are in the wrong order. import os should be before from pprint
29:1: I101 Imported names are in the wrong order. Should be task_low_level_submission, task_update_progress, write_message
30:30: E126 continuation line over-indented for hanging indent
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.bibsched.bibtask
35:1: I101 Imported names are in the wrong order. Should be assure_quality, encode_video
38:41: E126 continuation line over-indented for hanging indent
41:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.cli should be before from invenio.modules.encoder.profiles
43:1: I100 Imports statements are in the wrong order. from invenio.modules.encoder.metadata should be before from invenio.modules.encoder.utils
44:41: E126 continuation line over-indented for hanging indent
46:1: I101 Imported names are in the wrong order. Should be chose2, generate_timestamp, getval
46:1: F999 redefinition of unused 'chose2' from line 42
47:1: I101 Imported names are in the wrong order. Should be CFG_BIBENCODE_ASPECT_RATIO_MARC_FIELD, CFG_BIBENCODE_DAEMON_DIR_NEWJOBS, CFG_BIBENCODE_PBCORE_MARC_XSLT
47:1: I100 Imports statements are in the wrong order. from invenio.modules.encoder.config should be before from invenio.modules.encoder.utils
48:39: E126 continuation line over-indented for hanging indent
52:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.modules.encoder.config
53:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.ext.email
57:1: I100 Imports statements are in the wrong order. import invenio.config should be before from invenio.utils.json
67:1: E302 expected 2 blank lines, found 1
67: D401 First line should be in imperative mood ('Send', not 'Sends')
67: D400 First line should end with a period (not 'g')
67: D205 1 blank line required between summary line and description (found 0)
78:13: E128 continuation line under-indented for visual indent
79:13: E128 continuation line under-indented for visual indent
80:13: E128 continuation line under-indented for visual indent
81:13: E128 continuation line under-indented for visual indent
82:13: E128 continuation line under-indented for visual indent
84:14: E128 continuation line under-indented for visual indent
92:1: E302 expected 2 blank lines, found 1
92: D401 First line should be in imperative mood ('Send', not 'Sends')
92: D205 1 blank line required between summary line and description (found 0)
110:13: E128 continuation line under-indented for visual indent
111:13: E128 continuation line under-indented for visual indent
120:13: E128 continuation line under-indented for visual indent
121:13: E128 continuation line under-indented for visual indent
123:14: E128 continuation line under-indented for visual indent
124:14: E128 continuation line under-indented for visual indent
125:14: E128 continuation line under-indented for visual indent
128:14: E128 continuation line under-indented for visual indent
129:14: E128 continuation line under-indented for visual indent
130:14: E128 continuation line under-indented for visual indent
138:1: E302 expected 2 blank lines, found 1
138: D401 First line should be in imperative mood ('Send', not 'Sends')
138: D205 1 blank line required between summary line and description (found 0)
154:13: E128 continuation line under-indented for visual indent
155:13: E126 continuation line over-indented for hanging indent
161:13: E128 continuation line under-indented for visual indent
162:13: E128 continuation line under-indented for visual indent
164:14: E128 continuation line under-indented for visual indent
165:14: E128 continuation line under-indented for visual indent
166:14: E128 continuation line under-indented for visual indent
169:14: E128 continuation line under-indented for visual indent
170:14: E128 continuation line under-indented for visual indent
171:14: E128 continuation line under-indented for visual indent
179:1: E302 expected 2 blank lines, found 1
179: D210 No whitespaces allowed surrounding docstring text
179: D401 First line should be in imperative mood ('Generate', not 'Generates')
179: D205 1 blank line required between summary line and description (found 0)
179: D208 Docstring is over-indented
190:1: E302 expected 2 blank lines, found 1
190: D210 No whitespaces allowed surrounding docstring text
190: D401 First line should be in imperative mood ('Store', not 'Stores')
190: D400 First line should end with a period (not 's')
190: D205 1 blank line required between summary line and description (found 0)
190: D208 Docstring is over-indented
199:1: E302 expected 2 blank lines, found 1
199: D401 First line should be in imperative mood ('Remove', not 'Removes')
199: D400 First line should end with a period (not 'r')
199: D205 1 blank line required between summary line and description (found 0)
223:25: E128 continuation line under-indented for visual indent
224:25: E128 continuation line under-indented for visual indent
225:25: E128 continuation line under-indented for visual indent
226:25: E128 continuation line under-indented for visual indent
240:1: E302 expected 2 blank lines, found 1
240: D210 No whitespaces allowed surrounding docstring text
240: D401 First line should be in imperative mood ('Create', not 'Creates')
240: D400 First line should end with a period (not 'n')
240: D205 1 blank line required between summary line and description (found 0)
241:29: E126 continuation line over-indented for hanging indent
257:1: E302 expected 2 blank lines, found 1
257: D210 No whitespaces allowed surrounding docstring text
257: D401 First line should be in imperative mood ('Create', not 'Creates')
257: D400 First line should end with a period (not 'a')
257: D205 1 blank line required between summary line and description (found 0)
275:1: E302 expected 2 blank lines, found 1
275: D210 No whitespaces allowed surrounding docstring text
275: D401 First line should be in imperative mood ('Create', not 'Creates')
275: D400 First line should end with a period (not 's')
275: D205 1 blank line required between summary line and description (found 0)
298:1: E302 expected 2 blank lines, found 1
298: D210 No whitespaces allowed surrounding docstring text
298: D401 First line should be in imperative mood ('Create', not 'Creates')
298: D400 First line should end with a period (not 'y')
298: D205 1 blank line required between summary line and description (found 0)
299:21: E126 continuation line over-indented for hanging indent
321:1: E302 expected 2 blank lines, found 1
321: D210 No whitespaces allowed surrounding docstring text
321: D401 First line should be in imperative mood ('Check', not 'Checks')
321: D400 First line should end with a period (not 'y')
321: D205 1 blank line required between summary line and description (found 0)
327: D210 No whitespaces allowed surrounding docstring text
327: D401 First line should be in imperative mood ('Sanitize', not 'Sanitizes')
327: D400 First line should end with a period (not 's')
327: D200 One-line docstring should fit on one line with quotes (found 2)
356:5: E129 visually indented line with same indent as next logical line
358:21: E128 continuation line under-indented for visual indent
374:1: E302 expected 2 blank lines, found 1
374: D210 No whitespaces allowed surrounding docstring text
374: D401 First line should be in imperative mood ('Processe', not 'Processes')
374: D202 No blank lines allowed after function docstring (found 1)
374: D400 First line should end with a period (not 'y')
383: D210 No whitespaces allowed surrounding docstring text
383: D401 First line should be in imperative mood ('Create', not 'Creates')
383: D400 First line should end with a period (not 'd')
383: D200 One-line docstring should fit on one line with quotes (found 2)
386:36: E225 missing whitespace around operator
400:5: E266 too many leading '#' for block comment
403:5: E266 too many leading '#' for block comment
406:5: E266 too many leading '#' for block comment
416:5: E266 too many leading '#' for block comment
431:21: E129 visually indented line with same indent as next logical line
434:21: E266 too many leading '#' for block comment
436:25: E266 too many leading '#' for block comment
437:47: F821 undefined name 'get_fieldvalues'
445:27: E128 continuation line under-indented for visual indent
448:13: E266 too many leading '#' for block comment
451:5: E266 too many leading '#' for block comment
458:5: E266 too many leading '#' for block comment
466:5: E266 too many leading '#' for block comment
469:5: E266 too many leading '#' for block comment
473:5: E266 too many leading '#' for block comment
481:13: E266 too many leading '#' for block comment
482:13: E266 too many leading '#' for block comment
483:13: E266 too many leading '#' for block comment
484:13: E266 too many leading '#' for block comment
486:27: E128 continuation line under-indented for visual indent
488:37: E126 continuation line over-indented for hanging indent
491:13: E266 too many leading '#' for block comment
492:13: E266 too many leading '#' for block comment
496:21: E126 continuation line over-indented for hanging indent
513:28: E128 continuation line under-indented for visual indent
515:9: E266 too many leading '#' for block comment
525:13: E266 too many leading '#' for block comment
533:13: E266 too many leading '#' for block comment
538:13: E266 too many leading '#' for block comment
541:13: E266 too many leading '#' for block comment
542:13: E266 too many leading '#' for block comment
544:50: E126 continuation line over-indented for hanging indent
551:13: E266 too many leading '#' for block comment
553:18: E126 continuation line over-indented for hanging indent
567:53: E261 at least two spaces before inline comment
573:13: E266 too many leading '#' for block comment
574:15: E271 multiple spaces after keyword
575:17: E266 too many leading '#' for block comment
590:47: E127 continuation line over-indented for visual indent
616:25: W503 line break before binary operator
617:25: E128 continuation line under-indented for visual indent
619:28: E128 continuation line under-indented for visual indent
620:28: E128 continuation line under-indented for visual indent
621:28: E126 continuation line over-indented for hanging indent
631:13: E266 too many leading '#' for block comment
633:17: E266 too many leading '#' for block comment
634:17: E266 too many leading '#' for block comment
637:21: E266 too many leading '#' for block comment
638:21: E266 too many leading '#' for block comment
641:21: E266 too many leading '#' for block comment
644:21: E266 too many leading '#' for block comment
648:21: E266 too many leading '#' for block comment
652:21: E266 too many leading '#' for block comment
653:21: E266 too many leading '#' for block comment
657:35: E128 continuation line under-indented for visual indent
660:37: E126 continuation line over-indented for hanging indent
665:13: E266 too many leading '#' for block comment
677:5: E266 too many leading '#' for block comment
681:5: E266 too many leading '#' for block comment
686:9: E266 too many leading '#' for block comment
699:44: E251 unexpected spaces around keyword / parameter equals
699:46: E251 unexpected spaces around keyword / parameter equals
700:50: E251 unexpected spaces around keyword / parameter equals
700:52: E251 unexpected spaces around keyword / parameter equals
701:49: E251 unexpected spaces around keyword / parameter equals
701:51: E251 unexpected spaces around keyword / parameter equals
734:5: E266 too many leading '#' for block comment
744:55: E721 do not compare types, use 'isinstance()'
744:69: E202 whitespace before ')'
754:32: E128 continuation line under-indented for visual indent
755:32: E128 continuation line under-indented for visual indent
756:32: E128 continuation line under-indented for visual indent
758:1: W391 blank line at end of file


26:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.exc
26:1: F401 'db' imported but unused
27:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from invenio.modules.search.models should be before from invenio_records.models
28:1: I201 Missing newline before sections or imports.
35: D401 First line should be in imperative mood ('Return', not 'Returns')
52: D401 First line should be in imperative mood ('Return', not 'Returns')
70: D401 First line should be in imperative mood ('Return', not 'Returns')
70: D400 First line should end with a period (not 'e')
84: D401 First line should be in imperative mood ('Return', not 'Returns')
84: D400 First line should end with a period (not ',')
84: D205 1 blank line required between summary line and description (found 0)
101: D401 First line should be in imperative mood ('Return', not 'Returns')
111: D401 First line should be in imperative mood ('Return', not 'Returns')
111: D400 First line should end with a period (not 'e')
125: D401 First line should be in imperative mood ('Return', not 'Returns')
154: D401 First line should be in imperative mood ('Return', not 'Returns')
169: D401 First line should be in imperative mood ('Return', not 'Returns')
183: D401 First line should be in imperative mood ('Return', not 'Returns')
183: D400 First line should end with a period (not 'e')
195: D401 First line should be in imperative mood ('Return', not 'Returns')
195: D400 First line should end with a period (not 'e')
212: D401 First line should be in imperative mood ('Return', not 'Returns')
212: D400 First line should end with a period (not 'e')
224: D401 First line should be in imperative mood ('Return', not 'Returns')
224: D400 First line should end with a period (not "'")
249: D401 First line should be in imperative mood ('Return', not 'Returns')
249: D400 First line should end with a period (not 'd')
249: D205 1 blank line required between summary line and description (found 0)


47:1: I201 Missing newline before sections or imports.
49:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug.utils
52:1: F401 'CFG_BIBFORMAT_CACHED_FORMATS' imported but unused
52:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
52:1: F401 'CFG_BIBFORMAT_DISABLE_I18N_FOR_CACHED_FORMATS' imported but unused
57:1: F401 'record_empty' imported but unused
68:1: F401 'CFG_BIBFORMAT_OUTPUTS_PATH' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_TEMPLATE_EXTENSION' imported but unused
68:1: F401 'CFG_BIBFORMAT_TEMPLATES_DIR' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_OUTPUT_EXTENSION' imported but unused
78:27: E261 at least two spaces before inline comment
79:28: E114 indentation is not a multiple of four (comment)
79:28: E116 unexpected indentation (comment)
80:28: E114 indentation is not a multiple of four (comment)
80:28: E116 unexpected indentation (comment)
81:28: E114 indentation is not a multiple of four (comment)
81:28: E116 unexpected indentation (comment)
84:28: E114 indentation is not a multiple of four (comment)
84:28: E116 unexpected indentation (comment)
98:33: E225 missing whitespace around operator
183:1: E731 do not assign a lambda expression, use a def
186: D203 1 blank line required before class docstring (found 0)
190: D401 First line should be in imperative mood ('Return', not 'Returns')
190: D400 First line should end with a period (not 's')
204: D401 First line should be in imperative mood ('Format', not 'Formats')
204: D400 First line should end with a period (not 'f')
204: D205 1 blank line required between summary line and description (found 0)
263:8: W503 line break before binary operator
267:41: F841 local variable 'exc' is assigned to but never used
342:82: E225 missing whitespace around operator
353: D401 First line should be in imperative mood ('Return', not 'Returns')
353: D202 No blank lines allowed after function docstring (found 1)
353: D400 First line should end with a period (not 'g')
353: D205 1 blank line required between summary line and description (found 0)
374:64: E261 at least two spaces before inline comment
374:65: E262 inline comment should start with '# '
381:38: E261 at least two spaces before inline comment
381:39: E262 inline comment should start with '# '
382:48: E261 at least two spaces before inline comment
382:49: E262 inline comment should start with '# '
385:24: E127 continuation line over-indented for visual indent
394: D103 Missing docstring in public function
397: D400 First line should end with a period (not 's')
397: D200 One-line docstring should fit on one line with quotes (found 3)
410: D210 No whitespaces allowed surrounding docstring text
410: D400 First line should end with a period (not 'a')
410: D205 1 blank line required between summary line and description (found 0)
495: D401 First line should be in imperative mood ('Filter', not 'Filters')
505: D401 First line should be in imperative mood ('Searche', not 'Searches')
505: D400 First line should end with a period (not 's')
505: D205 1 blank line required between summary line and description (found 0)
531:9: E303 too many blank lines (2)
545:5: E303 too many blank lines (2)
549: D401 First line should be in imperative mood ('Return', not 'Returns')
589:28: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
603:1: E302 expected 2 blank lines, found 1
603: D203 1 blank line required before class docstring (found 0)
603: D204 1 blank line required after class docstring (found 0)
603: D400 First line should end with a period (not 'n')
603: D205 1 blank line required between summary line and description (found 0)
634:15: E261 at least two spaces before inline comment
636: D401 First line should be in imperative mood ('Create', not 'Creates')
668:31: E261 at least two spaces before inline comment
693: D401 First line should be in imperative mood ('Return', not 'Returns')
693: D400 First line should end with a period (not 'e')
708: D401 First line should be in imperative mood ('Return', not 'Returns')
708: D400 First line should end with a period (not 'd')
731: D401 First line should be in imperative mood ('Return', not 'Returns')
731: D400 First line should end with a period (not 'e')
731: D205 1 blank line required between summary line and description (found 0)
769: D401 First line should be in imperative mood ('Return', not 'Returns')
769: D202 No blank lines allowed after function docstring (found 1)
878:36: E127 continuation line over-indented for visual indent
881: D401 First line should be in imperative mood ('Return', not 'Returns')
938:33: E127 continuation line over-indented for visual indent
949:60: E251 unexpected spaces around keyword / parameter equals
951:54: E251 unexpected spaces around keyword / parameter equals
961:37: E127 continuation line over-indented for visual indent
972:64: E251 unexpected spaces around keyword / parameter equals
974:58: E251 unexpected spaces around keyword / parameter equals


23:1: I201 Missing newline before sections or imports.
26: D203 1 blank line required before class docstring (found 0)


3: L102 copyright year is outdated, expected 2015 but got 2014


37: D103 Missing docstring in public function
47:13: E121 continuation line under-indented for hanging indent


22:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
24:1: I101 Imported names are in the wrong order. Should be clean_field_model_definitions, field_definitions, model_definitions


25:1: E402 module level import not at top of file
26:1: I101 Imported names are in the wrong order. Should be ImportPathRegistry, PkgResourcesDirDiscoveryRegistry, RegistryProxy
26:1: I100 Imports statements are in the wrong order. from flask_registry should be before from invenio.base.wrappers
26:1: I201 Missing newline before sections or imports.
26:1: E402 module level import not at top of file
28:1: E402 module level import not at top of file
29:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
29:1: E402 module level import not at top of file
43:1: E731 do not assign a lambda expression, use a def
45:1: E731 do not assign a lambda expression, use a def
47:1: E731 do not assign a lambda expression, use a def


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio.modules.scheduler.models should be before from invenio_records.models
27:1: I201 Missing newline before sections or imports.


You said static framework, but I think you meant dynamic framework, right?

Not that it matters much.


4: L102 copyright year is outdated, expected 2015 but got 2014
427:25: E711 comparison to None should be 'if cond is None:'


1: D400 First line should end with a period (not 'r')
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
28:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.exc
29:1: I201 Missing newline before sections or imports.
31:1: I100 Imports statements are in the wrong order. from invenio.modules.pidstore.provider should be before from invenio_records.models
34: D210 No whitespaces allowed surrounding docstring text
34: D203 1 blank line required before class docstring (found 0)
34: D400 First line should end with a period (not 's')
39: D401 First line should be in imperative mood ('Create', not 'Creates')
58: D102 Missing docstring in public method
63: D200 One-line docstring should fit on one line with quotes (found 3)


1: D100 Missing docstring in public module


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: I201 Missing newline before sections or imports.
38: D200 One-line docstring should fit on one line with quotes (found 3)
64: D400 First line should end with a period (not 'e')
131: D400 First line should end with a period (not 'e')
171: D400 First line should end with a period (not 'n')


How about using ```(throw (ex-info ... {}))``` instead of conditional exceptions? Should make the code much more readable.


??? Sieht danach aus
 Am 23.06.2015 18:02 schrieb "Max Albrecht" <notifications@github.com>:

> any reason why this was rolled back? mistake?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Madek/madek-webapp/commit/64202fb59a50373ed6e7c0f13a27c3da7157f88a#commitcomment-11819994>
> .
>


@bnb There aren't many viable alternatives, really — we have to use something that doesn't require a `node` executable to avoid the bootstrapping problem ("You have to have a working copy of node to compile node.") Additionally, we're testing the *entire* system with these tests, including the startup bits that can't be gotten at by JS frameworks.


The change is sufficiently trivial to not warrant contribution, as it was not a direct copy. If it were larger, or had the code been implemented unmodified I would have likely included a copy of your license.


Wrong comment for this revision. Should be:

Show more/less link in description text with a little bit help from the JQuery dotdotdot (http://dotdotdot.frebsite.nl). Issue #19.


-1 new darker theme, at least for the fact that the background color no longer matches the rest of the theme


please add more feature.


i'm not sure if the duplicate switch case was actually removed in this commit :)

noticing some potential merge issues, this could be one too.


Membros do grupo: Lira Specht e Maureen Souza


Don't keep the old function. Expecialy as now you lost the interresting part of there docstring I think. Or the docstring was not useful? Document as comment where the new code is.


idem for the doc


The test seems to induce network issues on the replication side as well, which would be a no-op if there is only a single server?


It is fixed only based on code inspection so we will see if it is fixed or will occur again. for now we closed


@jdalton there doesn't seem to be any coverage for this condition (it can be removed freely) - I thought it was required to allow debounced functions to be called recursively

Do you know if this is a gap in testing or did you figure out some other magic? :)

Otherwise I'll look into this this some more later / add a unit test for this case


Change this to 'result/output.txt'


Sorry about that, will fix it right away !


Newton-Raphson.
Not that I knew, but I found out when tried looking it up.


I don't want to update with my DNS provider, let's remove this.


fix #138


I tried your change on the buildmaster using 'buildbot checkconfig...' and got the following error:
```
Configuration Errors:
  cannot use both allowForce and authz parameters
````


idem, as the other loop. Do something like this:

view_o = destroy_handlyer.view_o
while ....:
   use view_o

The fact that you use an extra destroy_handler, cost extra compute time to look op the view_o each time that line is executed.


Thank you @keith-hall and @sethreno for the fix :)


Add files from phpipam


much better & simpler, simple solutions are easier for understanding.


I don't see any misused parenthesis?
`not` is more readable here.. I would like to know why hound prefers the `!`..


Certainly up for discussion. It's early enough to change it. Do you have a more concrete name in mind?


Awesome, thanks a lot!


@ronjrees the temporary workaround for monasca-vagrant is to change influxdb_version back to the previous version until the new 0.9.0 latest changes are pushed.

host_vars/mini-mon
influxdb_version: 0.9.0-rc28


i tried the same but still i am facing same issue.
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://localhost:8080/. (Reason: CORS request failed).

I tried to replace with the dynamic ip address "192.168...."  same problem.
Can u help me on this ?


Is this a cross-compilation target?


It's freeing them to avoid holding on to them in memory. Functionally you won't notice a diff.


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: elasticsearch


1: M100 needs more reviewers
1: M101 signature is missing


32: D103 Missing docstring in public function
43: D103 Missing docstring in public function
47: D103 Missing docstring in public function


Maybe, but it's really not that important yet.


Cool


See https://github.com/lodash/lodash/pull/389.


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013
23:1: I201 Missing newline before sections or imports.
28: D209 Multi-line docstring closing quotes should be on a separate line
28: D202 No blank lines allowed after function docstring (found 1)
37:5: B901 blind except: statement
38:9: F401 'pickle' imported but unused
83: D400 First line should end with a period (not 'y')
97: D103 Missing docstring in public function


30:1: I100 Imports statements are in the wrong order. from invenio.base.utils should be before import pkg_resources


52:1: I101 Imported names are in the wrong order. Should be current_app, jsonify, request
52:1: I100 Imports statements are in the wrong order. from flask should be before import requests
53:1: I201 Missing newline before sections or imports.
54:1: I201 Missing newline before sections or imports.
56:1: I100 Imports statements are in the wrong order. from invenio.utils.xmlhelpers should be before from lxml.etree


52:1: I100 Imports statements are in the wrong order. from urlparse should be before import requests
52:1: I201 Missing newline before sections or imports.
54:1: I101 Imported names are in the wrong order. Should be current_app, jsonify, request
55:1: I201 Missing newline before sections or imports.


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I201 Missing newline before sections or imports.
26: D203 1 blank line required before class docstring (found 0)


33:1: I201 Missing newline before sections or imports.
37:1: I100 Imports statements are in the wrong order. from urlparse should be before from sqlalchemy.event


4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: I100 Imports statements are in the wrong order. from datetime should be before from bagit
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be copydir, copyfile
32:1: I201 Missing newline before sections or imports.
34:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug.utils


4: L102 copyright year is outdated, expected 2015 but got 2014


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.orm.exc
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio_records.api should be before from invenio_records.models


4: L102 copyright year is outdated, expected 2015 but got 2014
22:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite


4: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
23:1: I101 Imported names are in the wrong order. Should be MultipleResultsFound, NoResultFound


1: D200 One-line docstring should fit on one line with quotes (found 3)
4: L102 copyright year is outdated, expected 2015 but got 2013
32: D203 1 blank line required before class docstring (found 0)
32: D204 1 blank line required after class docstring (found 0)
34: D102 Missing docstring in public method
38:17: E128 continuation line under-indented for visual indent
39:17: E128 continuation line under-indented for visual indent
41:17: E128 continuation line under-indented for visual indent
43:17: E128 continuation line under-indented for visual indent
45:17: E128 continuation line under-indented for visual indent
50:9: E128 continuation line under-indented for visual indent
52:9: E128 continuation line under-indented for visual indent
55:1: E302 expected 2 blank lines, found 1
55: D203 1 blank line required before class docstring (found 0)
55: D204 1 blank line required after class docstring (found 0)
57: D102 Missing docstring in public method
61:17: E128 continuation line under-indented for visual indent
62:17: E128 continuation line under-indented for visual indent
64:17: E128 continuation line under-indented for visual indent
66:17: E128 continuation line under-indented for visual indent
68:17: E128 continuation line under-indented for visual indent
70:17: E128 continuation line under-indented for visual indent
72:17: E128 continuation line under-indented for visual indent
75:1: E302 expected 2 blank lines, found 1
75: D203 1 blank line required before class docstring (found 0)
75: D204 1 blank line required after class docstring (found 0)
77: D102 Missing docstring in public method
81:17: E128 continuation line under-indented for visual indent
82:22: E128 continuation line under-indented for visual indent
84:17: E128 continuation line under-indented for visual indent
85:17: E128 continuation line under-indented for visual indent
87:17: E128 continuation line under-indented for visual indent
88:17: E128 continuation line under-indented for visual indent
93:17: E128 continuation line under-indented for visual indent
95:17: E128 continuation line under-indented for visual indent
97:17: E128 continuation line under-indented for visual indent
99:17: E128 continuation line under-indented for visual indent
101:17: E128 continuation line under-indented for visual indent
103:17: E128 continuation line under-indented for visual indent
103:31: E231 missing whitespace after ','
106: D203 1 blank line required before class docstring (found 0)
106: D204 1 blank line required after class docstring (found 0)
108: D102 Missing docstring in public method
112:17: E128 continuation line under-indented for visual indent
113:17: E128 continuation line under-indented for visual indent
115:17: E128 continuation line under-indented for visual indent
116:17: E126 continuation line over-indented for hanging indent
119:17: E128 continuation line under-indented for visual indent
120:17: E128 continuation line under-indented for visual indent
122:17: E128 continuation line under-indented for visual indent
123:17: E128 continuation line under-indented for visual indent
125:17: E128 continuation line under-indented for visual indent
126:17: E128 continuation line under-indented for visual indent
128:17: E128 continuation line under-indented for visual indent
129:17: E128 continuation line under-indented for visual indent
131:17: E128 continuation line under-indented for visual indent
133:17: E128 continuation line under-indented for visual indent
135:17: E128 continuation line under-indented for visual indent
137:17: E128 continuation line under-indented for visual indent
139:17: E128 continuation line under-indented for visual indent
141:17: E128 continuation line under-indented for visual indent
143:17: E128 continuation line under-indented for visual indent
145:17: E128 continuation line under-indented for visual indent
150:17: E128 continuation line under-indented for visual indent
161: D203 1 blank line required before class docstring (found 0)
161: D204 1 blank line required after class docstring (found 0)
163: D102 Missing docstring in public method
167:17: E128 continuation line under-indented for visual indent
168:17: E128 continuation line under-indented for visual indent
170:17: E128 continuation line under-indented for visual indent
172:17: E128 continuation line under-indented for visual indent
173:17: E128 continuation line under-indented for visual indent
175:17: E128 continuation line under-indented for visual indent
177:9: E128 continuation line under-indented for visual indent
180:17: E128 continuation line under-indented for visual indent
182:17: E128 continuation line under-indented for visual indent
184:17: E128 continuation line under-indented for visual indent
186:17: E128 continuation line under-indented for visual indent
187:17: E128 continuation line under-indented for visual indent
189:17: E128 continuation line under-indented for visual indent
191:17: E128 continuation line under-indented for visual indent
197:1: E302 expected 2 blank lines, found 1
197: D203 1 blank line required before class docstring (found 0)
197: D204 1 blank line required after class docstring (found 0)
199: D102 Missing docstring in public method
203:17: E128 continuation line under-indented for visual indent
204:17: E128 continuation line under-indented for visual indent
206:17: E128 continuation line under-indented for visual indent
208:17: E128 continuation line under-indented for visual indent
209:17: E128 continuation line under-indented for visual indent
211:17: E128 continuation line under-indented for visual indent
213:17: E128 continuation line under-indented for visual indent
214:17: E128 continuation line under-indented for visual indent
216:17: E128 continuation line under-indented for visual indent
217:17: E128 continuation line under-indented for visual indent
219:17: E128 continuation line under-indented for visual indent
222:17: E128 continuation line under-indented for visual indent
227:1: E302 expected 2 blank lines, found 1
227: D203 1 blank line required before class docstring (found 0)
227: D204 1 blank line required after class docstring (found 0)
229: D102 Missing docstring in public method
233:17: E128 continuation line under-indented for visual indent
234:17: E128 continuation line under-indented for visual indent
236:17: E128 continuation line under-indented for visual indent
238:17: E128 continuation line under-indented for visual indent
240:17: E128 continuation line under-indented for visual indent
242:17: E128 continuation line under-indented for visual indent
245:1: E302 expected 2 blank lines, found 1
245: D203 1 blank line required before class docstring (found 0)
245: D204 1 blank line required after class docstring (found 0)
247: D102 Missing docstring in public method
251:17: E128 continuation line under-indented for visual indent
252:17: E128 continuation line under-indented for visual indent
254:17: E128 continuation line under-indented for visual indent
255:17: E128 continuation line under-indented for visual indent
257:17: E128 continuation line under-indented for visual indent
259:17: E128 continuation line under-indented for visual indent
261:17: E128 continuation line under-indented for visual indent
263:17: E128 continuation line under-indented for visual indent
265:17: E128 continuation line under-indented for visual indent


1: D100 Missing docstring in public module
27: D103 Missing docstring in public function


24:1: F401 'intbitset' imported but unused
25:1: I201 Missing newline before sections or imports.
25:1: F401 'cached_property' imported but unused
27:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug
75: D101 Missing docstring in public class
76: D102 Missing docstring in public method
103: D103 Missing docstring in public function
121: D203 1 blank line required before class docstring (found 0)
121: D204 1 blank line required after class docstring (found 0)
121: D400 First line should end with a period (not 'e')
121: D205 1 blank line required between summary line and description (found 0)
126: D102 Missing docstring in public method


23:1: I100 Imports statements are in the wrong order. from invenio.modules.search.api should be before from invenio_records.signals
23:1: I201 Missing newline before sections or imports.
44:32: E711 comparison to None should be 'if cond is not None:'
67: D103 Missing docstring in public function


26:1: I201 Missing newline before sections or imports.


23:1: I100 Imports statements are in the wrong order. import socket should be before from datetime
25:1: I101 Imported names are in the wrong order. Should be Blueprint, abort, current_app, flash, g, redirect, render_template, request, url_for
29:1: I201 Missing newline before sections or imports.
30:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from invenio.base.decorators should be before from invenio.base.i18n
42:1: I100 Imports statements are in the wrong order. from invenio.utils.mail should be before from invenio_records.views
45:1: I101 Imported names are in the wrong order. Should be CmtACTIONHISTORY, CmtRECORDCOMMENT, CmtSUBSCRIPTION
54: D103 Missing docstring in public function
67: D101 Missing docstring in public class
69: D102 Missing docstring in public method
74: D102 Missing docstring in public method
78: D102 Missing docstring in public method
92: D102 Missing docstring in public method
101: D102 Missing docstring in public method
108: D102 Missing docstring in public method
121: D103 Missing docstring in public function
155:9: B901 blind except: statement
166: D103 Missing docstring in public function
180:9: B901 blind except: statement
255: D103 Missing docstring in public function
274: D103 Missing docstring in public function
294: D103 Missing docstring in public function
316: D103 Missing docstring in public function
324:5: B901 blind except: statement
332: D103 Missing docstring in public function
346:5: B901 blind except: statement
360: D103 Missing docstring in public function


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. from invenio_records.api should be before import six
24:1: I201 Missing newline before sections or imports.
27: D400 First line should end with a period (not 't')
27: D200 One-line docstring should fit on one line with quotes (found 3)
52: D400 First line should end with a period (not 's')
52: D200 One-line docstring should fit on one line with quotes (found 3)
64: D200 One-line docstring should fit on one line with quotes (found 3)
83: D400 First line should end with a period (not 's')
83: D200 One-line docstring should fit on one line with quotes (found 3)


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
22:1: I100 Imports statements are in the wrong order. from invenio.utils.datacite should be before from werkzeug
22:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.utils should be before from invenio_records.api
25:1: I201 Missing newline before sections or imports.
58: D102 Missing docstring in public method
61: D102 Missing docstring in public method
74: D102 Missing docstring in public method
78: D102 Missing docstring in public method
110: D102 Missing docstring in public method
122: D102 Missing docstring in public method
148: D103 Missing docstring in public function
177: D103 Missing docstring in public function
245: D103 Missing docstring in public function
280: D103 Missing docstring in public function


25:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. import dateutil.parser should be before import dictdiffer
26:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from tempfile should be before import dateutil.parser
29:1: I100 Imports statements are in the wrong order. from functools should be before from tempfile
30:1: I101 Imported names are in the wrong order. Should be abort, current_app, request
30:1: I201 Missing newline before sections or imports.
31:1: I201 Missing newline before sections or imports.
32:1: I100 Imports statements are in the wrong order. from functools should be before from flask_login
32:1: I201 Missing newline before sections or imports.
35:1: I100 Imports statements are in the wrong order. from invenio.modules.editor.models should be before from invenio_records.api
35:1: I201 Missing newline before sections or imports.
36:1: I101 Imported names are in the wrong order. Should be Agent, Deposition, DepositionDraftCacheManager
36:1: I100 Imports statements are in the wrong order. from invenio.modules.deposit.models should be before from invenio.modules.editor.models
38:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.deposit.models
41:1: I101 Imported names are in the wrong order. Should be deposition_record, make_record, record_to_draft
41:1: I201 Missing newline before sections or imports.
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from .helpers


28:1: I201 Missing newline before sections or imports.


1: D400 First line should end with a period (not 'e')
4: L102 copyright year is outdated, expected 2015 but got 2011
23:1: I100 Imports statements are in the wrong order. from pprint should be before from string
24:1: I100 Imports statements are in the wrong order. import os should be before from pprint
29:1: I101 Imported names are in the wrong order. Should be task_low_level_submission, task_update_progress, write_message
30:30: E126 continuation line over-indented for hanging indent
34:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio.legacy.bibsched.bibtask
35:1: I101 Imported names are in the wrong order. Should be assure_quality, encode_video
38:41: E126 continuation line over-indented for hanging indent
42:1: I100 Imports statements are in the wrong order. from invenio.modules.encoder.metadata should be before from invenio.modules.encoder.utils
43:41: E126 continuation line over-indented for hanging indent
45:1: I101 Imported names are in the wrong order. Should be chose2, generate_timestamp, getval
45:1: F999 redefinition of unused 'chose2' from line 41
46:1: I101 Imported names are in the wrong order. Should be CFG_BIBENCODE_ASPECT_RATIO_MARC_FIELD, CFG_BIBENCODE_DAEMON_DIR_NEWJOBS, CFG_BIBENCODE_PBCORE_MARC_XSLT
46:1: I100 Imports statements are in the wrong order. from invenio.modules.encoder.config should be before from invenio.modules.encoder.utils
47:39: E126 continuation line over-indented for hanging indent
51:1: I100 Imports statements are in the wrong order. from invenio.ext.email should be before from invenio.modules.encoder.config
52:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.ext.email
56:1: I100 Imports statements are in the wrong order. import invenio.config should be before from invenio.utils.json
66:1: E302 expected 2 blank lines, found 1
66: D401 First line should be in imperative mood ('Send', not 'Sends')
66: D400 First line should end with a period (not 'g')
66: D205 1 blank line required between summary line and description (found 0)
77:13: E128 continuation line under-indented for visual indent
78:13: E128 continuation line under-indented for visual indent
79:13: E128 continuation line under-indented for visual indent
80:13: E128 continuation line under-indented for visual indent
81:13: E128 continuation line under-indented for visual indent
83:14: E128 continuation line under-indented for visual indent
91:1: E302 expected 2 blank lines, found 1
91: D401 First line should be in imperative mood ('Send', not 'Sends')
91: D205 1 blank line required between summary line and description (found 0)
109:13: E128 continuation line under-indented for visual indent
110:13: E128 continuation line under-indented for visual indent
119:13: E128 continuation line under-indented for visual indent
120:13: E128 continuation line under-indented for visual indent
122:14: E128 continuation line under-indented for visual indent
123:14: E128 continuation line under-indented for visual indent
124:14: E128 continuation line under-indented for visual indent
127:14: E128 continuation line under-indented for visual indent
128:14: E128 continuation line under-indented for visual indent
129:14: E128 continuation line under-indented for visual indent
137:1: E302 expected 2 blank lines, found 1
137: D401 First line should be in imperative mood ('Send', not 'Sends')
137: D205 1 blank line required between summary line and description (found 0)
153:13: E128 continuation line under-indented for visual indent
154:13: E126 continuation line over-indented for hanging indent
160:13: E128 continuation line under-indented for visual indent
161:13: E128 continuation line under-indented for visual indent
163:14: E128 continuation line under-indented for visual indent
164:14: E128 continuation line under-indented for visual indent
165:14: E128 continuation line under-indented for visual indent
168:14: E128 continuation line under-indented for visual indent
169:14: E128 continuation line under-indented for visual indent
170:14: E128 continuation line under-indented for visual indent
178:1: E302 expected 2 blank lines, found 1
178: D210 No whitespaces allowed surrounding docstring text
178: D401 First line should be in imperative mood ('Generate', not 'Generates')
178: D205 1 blank line required between summary line and description (found 0)
178: D208 Docstring is over-indented
189:1: E302 expected 2 blank lines, found 1
189: D210 No whitespaces allowed surrounding docstring text
189: D401 First line should be in imperative mood ('Store', not 'Stores')
189: D400 First line should end with a period (not 's')
189: D205 1 blank line required between summary line and description (found 0)
189: D208 Docstring is over-indented
198:1: E302 expected 2 blank lines, found 1
198: D401 First line should be in imperative mood ('Remove', not 'Removes')
198: D400 First line should end with a period (not 'r')
198: D205 1 blank line required between summary line and description (found 0)
222:25: E128 continuation line under-indented for visual indent
223:25: E128 continuation line under-indented for visual indent
224:25: E128 continuation line under-indented for visual indent
225:25: E128 continuation line under-indented for visual indent
239:1: E302 expected 2 blank lines, found 1
239: D210 No whitespaces allowed surrounding docstring text
239: D401 First line should be in imperative mood ('Create', not 'Creates')
239: D400 First line should end with a period (not 'n')
239: D205 1 blank line required between summary line and description (found 0)
240:29: E126 continuation line over-indented for hanging indent
256:1: E302 expected 2 blank lines, found 1
256: D210 No whitespaces allowed surrounding docstring text
256: D401 First line should be in imperative mood ('Create', not 'Creates')
256: D400 First line should end with a period (not 'a')
256: D205 1 blank line required between summary line and description (found 0)
274:1: E302 expected 2 blank lines, found 1
274: D210 No whitespaces allowed surrounding docstring text
274: D401 First line should be in imperative mood ('Create', not 'Creates')
274: D400 First line should end with a period (not 's')
274: D205 1 blank line required between summary line and description (found 0)
297:1: E302 expected 2 blank lines, found 1
297: D210 No whitespaces allowed surrounding docstring text
297: D401 First line should be in imperative mood ('Create', not 'Creates')
297: D400 First line should end with a period (not 'y')
297: D205 1 blank line required between summary line and description (found 0)
298:21: E126 continuation line over-indented for hanging indent
320:1: E302 expected 2 blank lines, found 1
320: D210 No whitespaces allowed surrounding docstring text
320: D401 First line should be in imperative mood ('Check', not 'Checks')
320: D400 First line should end with a period (not 'y')
320: D205 1 blank line required between summary line and description (found 0)
326: D210 No whitespaces allowed surrounding docstring text
326: D401 First line should be in imperative mood ('Sanitize', not 'Sanitizes')
326: D400 First line should end with a period (not 's')
326: D200 One-line docstring should fit on one line with quotes (found 2)
355:5: E129 visually indented line with same indent as next logical line
357:21: E128 continuation line under-indented for visual indent
373:1: E302 expected 2 blank lines, found 1
373: D210 No whitespaces allowed surrounding docstring text
373: D401 First line should be in imperative mood ('Processe', not 'Processes')
373: D400 First line should end with a period (not 'y')
383: D210 No whitespaces allowed surrounding docstring text
383: D401 First line should be in imperative mood ('Create', not 'Creates')
383: D400 First line should end with a period (not 'd')
383: D200 One-line docstring should fit on one line with quotes (found 2)
386:36: E225 missing whitespace around operator
400:5: E266 too many leading '#' for block comment
403:5: E266 too many leading '#' for block comment
406:5: E266 too many leading '#' for block comment
416:5: E266 too many leading '#' for block comment
431:21: E129 visually indented line with same indent as next logical line
434:21: E266 too many leading '#' for block comment
436:25: E266 too many leading '#' for block comment
437:47: F821 undefined name 'get_fieldvalues'
445:27: E128 continuation line under-indented for visual indent
448:13: E266 too many leading '#' for block comment
451:5: E266 too many leading '#' for block comment
458:5: E266 too many leading '#' for block comment
466:5: E266 too many leading '#' for block comment
469:5: E266 too many leading '#' for block comment
473:5: E266 too many leading '#' for block comment
481:13: E266 too many leading '#' for block comment
482:13: E266 too many leading '#' for block comment
483:13: E266 too many leading '#' for block comment
484:13: E266 too many leading '#' for block comment
486:27: E128 continuation line under-indented for visual indent
488:37: E126 continuation line over-indented for hanging indent
491:13: E266 too many leading '#' for block comment
492:13: E266 too many leading '#' for block comment
496:21: E126 continuation line over-indented for hanging indent
513:28: E128 continuation line under-indented for visual indent
515:9: E266 too many leading '#' for block comment
525:13: E266 too many leading '#' for block comment
533:13: E266 too many leading '#' for block comment
538:13: E266 too many leading '#' for block comment
541:13: E266 too many leading '#' for block comment
542:13: E266 too many leading '#' for block comment
544:50: E126 continuation line over-indented for hanging indent
551:13: E266 too many leading '#' for block comment
553:18: E126 continuation line over-indented for hanging indent
567:53: E261 at least two spaces before inline comment
573:13: E266 too many leading '#' for block comment
574:15: E271 multiple spaces after keyword
575:17: E266 too many leading '#' for block comment
590:47: E127 continuation line over-indented for visual indent
616:25: W503 line break before binary operator
617:25: E128 continuation line under-indented for visual indent
619:28: E128 continuation line under-indented for visual indent
620:28: E128 continuation line under-indented for visual indent
621:28: E126 continuation line over-indented for hanging indent
631:13: E266 too many leading '#' for block comment
633:17: E266 too many leading '#' for block comment
634:17: E266 too many leading '#' for block comment
637:21: E266 too many leading '#' for block comment
638:21: E266 too many leading '#' for block comment
641:21: E266 too many leading '#' for block comment
644:21: E266 too many leading '#' for block comment
648:21: E266 too many leading '#' for block comment
652:21: E266 too many leading '#' for block comment
653:21: E266 too many leading '#' for block comment
657:35: E128 continuation line under-indented for visual indent
660:37: E126 continuation line over-indented for hanging indent
665:13: E266 too many leading '#' for block comment
677:5: E266 too many leading '#' for block comment
681:5: E266 too many leading '#' for block comment
686:9: E266 too many leading '#' for block comment
699:44: E251 unexpected spaces around keyword / parameter equals
699:46: E251 unexpected spaces around keyword / parameter equals
700:50: E251 unexpected spaces around keyword / parameter equals
700:52: E251 unexpected spaces around keyword / parameter equals
701:49: E251 unexpected spaces around keyword / parameter equals
701:51: E251 unexpected spaces around keyword / parameter equals
734:5: E266 too many leading '#' for block comment
744:55: E721 do not compare types, use 'isinstance()'
744:69: E202 whitespace before ')'
754:32: E128 continuation line under-indented for visual indent
755:32: E128 continuation line under-indented for visual indent
756:32: E128 continuation line under-indented for visual indent
758:1: W391 blank line at end of file


26:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.exc
26:1: F401 'db' imported but unused
27:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from invenio.modules.search.models should be before from invenio_records.models
28:1: I201 Missing newline before sections or imports.
35: D401 First line should be in imperative mood ('Return', not 'Returns')
52: D401 First line should be in imperative mood ('Return', not 'Returns')
70: D401 First line should be in imperative mood ('Return', not 'Returns')
70: D400 First line should end with a period (not 'e')
84: D401 First line should be in imperative mood ('Return', not 'Returns')
84: D400 First line should end with a period (not ',')
84: D205 1 blank line required between summary line and description (found 0)
101: D401 First line should be in imperative mood ('Return', not 'Returns')
111: D401 First line should be in imperative mood ('Return', not 'Returns')
111: D400 First line should end with a period (not 'e')
125: D401 First line should be in imperative mood ('Return', not 'Returns')
154: D401 First line should be in imperative mood ('Return', not 'Returns')
169: D401 First line should be in imperative mood ('Return', not 'Returns')
183: D401 First line should be in imperative mood ('Return', not 'Returns')
183: D400 First line should end with a period (not 'e')
195: D401 First line should be in imperative mood ('Return', not 'Returns')
195: D400 First line should end with a period (not 'e')
212: D401 First line should be in imperative mood ('Return', not 'Returns')
212: D400 First line should end with a period (not 'e')
224: D401 First line should be in imperative mood ('Return', not 'Returns')
224: D400 First line should end with a period (not "'")
249: D401 First line should be in imperative mood ('Return', not 'Returns')
249: D400 First line should end with a period (not 'd')
249: D205 1 blank line required between summary line and description (found 0)


47:1: I201 Missing newline before sections or imports.
49:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from werkzeug.utils
52:1: F401 'CFG_BIBFORMAT_CACHED_FORMATS' imported but unused
52:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
52:1: F401 'CFG_BIBFORMAT_DISABLE_I18N_FOR_CACHED_FORMATS' imported but unused
57:1: F401 'record_empty' imported but unused
68:1: F401 'CFG_BIBFORMAT_OUTPUTS_PATH' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_TEMPLATE_EXTENSION' imported but unused
68:1: F401 'CFG_BIBFORMAT_TEMPLATES_DIR' imported but unused
68:1: F401 'CFG_BIBFORMAT_FORMAT_OUTPUT_EXTENSION' imported but unused
78:27: E261 at least two spaces before inline comment
79:28: E114 indentation is not a multiple of four (comment)
79:28: E116 unexpected indentation (comment)
80:28: E114 indentation is not a multiple of four (comment)
80:28: E116 unexpected indentation (comment)
81:28: E114 indentation is not a multiple of four (comment)
81:28: E116 unexpected indentation (comment)
84:28: E114 indentation is not a multiple of four (comment)
84:28: E116 unexpected indentation (comment)
98:33: E225 missing whitespace around operator
183:1: E731 do not assign a lambda expression, use a def
186: D203 1 blank line required before class docstring (found 0)
190: D401 First line should be in imperative mood ('Return', not 'Returns')
190: D400 First line should end with a period (not 's')
204: D401 First line should be in imperative mood ('Format', not 'Formats')
204: D400 First line should end with a period (not 'f')
204: D205 1 blank line required between summary line and description (found 0)
263:8: W503 line break before binary operator
267:41: F841 local variable 'exc' is assigned to but never used
342:82: E225 missing whitespace around operator
353: D401 First line should be in imperative mood ('Return', not 'Returns')
353: D202 No blank lines allowed after function docstring (found 1)
353: D400 First line should end with a period (not 'g')
353: D205 1 blank line required between summary line and description (found 0)
374:64: E261 at least two spaces before inline comment
374:65: E262 inline comment should start with '# '
381:38: E261 at least two spaces before inline comment
381:39: E262 inline comment should start with '# '
382:48: E261 at least two spaces before inline comment
382:49: E262 inline comment should start with '# '
385:24: E127 continuation line over-indented for visual indent
394: D103 Missing docstring in public function
397: D400 First line should end with a period (not 's')
397: D200 One-line docstring should fit on one line with quotes (found 3)
410: D210 No whitespaces allowed surrounding docstring text
410: D400 First line should end with a period (not 'a')
410: D205 1 blank line required between summary line and description (found 0)
495: D401 First line should be in imperative mood ('Filter', not 'Filters')
505: D401 First line should be in imperative mood ('Searche', not 'Searches')
505: D400 First line should end with a period (not 's')
505: D205 1 blank line required between summary line and description (found 0)
531:9: E303 too many blank lines (2)
545:5: E303 too many blank lines (2)
549: D401 First line should be in imperative mood ('Return', not 'Returns')
589:28: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
603:1: E302 expected 2 blank lines, found 1
603: D203 1 blank line required before class docstring (found 0)
603: D204 1 blank line required after class docstring (found 0)
603: D400 First line should end with a period (not 'n')
603: D205 1 blank line required between summary line and description (found 0)
634:15: E261 at least two spaces before inline comment
636: D401 First line should be in imperative mood ('Create', not 'Creates')
668:31: E261 at least two spaces before inline comment
693: D401 First line should be in imperative mood ('Return', not 'Returns')
693: D400 First line should end with a period (not 'e')
708: D401 First line should be in imperative mood ('Return', not 'Returns')
708: D400 First line should end with a period (not 'd')
731: D401 First line should be in imperative mood ('Return', not 'Returns')
731: D400 First line should end with a period (not 'e')
731: D205 1 blank line required between summary line and description (found 0)
769: D401 First line should be in imperative mood ('Return', not 'Returns')
769: D202 No blank lines allowed after function docstring (found 1)
878:36: E127 continuation line over-indented for visual indent
881: D401 First line should be in imperative mood ('Return', not 'Returns')
938:33: E127 continuation line over-indented for visual indent
949:60: E251 unexpected spaces around keyword / parameter equals
951:54: E251 unexpected spaces around keyword / parameter equals
961:37: E127 continuation line over-indented for visual indent
972:64: E251 unexpected spaces around keyword / parameter equals
974:58: E251 unexpected spaces around keyword / parameter equals


23:1: I201 Missing newline before sections or imports.
26: D203 1 blank line required before class docstring (found 0)


3: L102 copyright year is outdated, expected 2015 but got 2014


37: D103 Missing docstring in public function
47:13: E121 continuation line under-indented for hanging indent


22:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
24:1: I101 Imported names are in the wrong order. Should be clean_field_model_definitions, field_definitions, model_definitions


25:1: E402 module level import not at top of file
26:1: I101 Imported names are in the wrong order. Should be ImportPathRegistry, PkgResourcesDirDiscoveryRegistry, RegistryProxy
26:1: I100 Imports statements are in the wrong order. from flask_registry should be before from invenio.base.wrappers
26:1: I201 Missing newline before sections or imports.
26:1: E402 module level import not at top of file
28:1: E402 module level import not at top of file
29:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
29:1: E402 module level import not at top of file
43:1: E731 do not assign a lambda expression, use a def
45:1: E731 do not assign a lambda expression, use a def
47:1: E731 do not assign a lambda expression, use a def


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio.modules.scheduler.models should be before from invenio_records.models
27:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
427:25: E711 comparison to None should be 'if cond is None:'


1: D400 First line should end with a period (not 'r')
1: D205 1 blank line required between summary line and description (found 0)
1: D208 Docstring is over-indented
4: L102 copyright year is outdated, expected 2015 but got 2014
28:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.exc
29:1: I201 Missing newline before sections or imports.
31:1: I100 Imports statements are in the wrong order. from invenio.modules.pidstore.provider should be before from invenio_records.models
34: D210 No whitespaces allowed surrounding docstring text
34: D203 1 blank line required before class docstring (found 0)
34: D400 First line should end with a period (not 's')
39: D401 First line should be in imperative mood ('Create', not 'Creates')
58: D102 Missing docstring in public method
63: D200 One-line docstring should fit on one line with quotes (found 3)


1: D100 Missing docstring in public module


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: I201 Missing newline before sections or imports.
38: D200 One-line docstring should fit on one line with quotes (found 3)
64: D400 First line should end with a period (not 'e')
131: D400 First line should end with a period (not 'e')
171: D400 First line should end with a period (not 'n')


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I201 Missing newline before sections or imports.
24:1: I100 Imports statements are in the wrong order. from invenio.testsuite should be before from mock
24:1: I201 Missing newline before sections or imports.


Ha, beat me to it. I'm working on this on a private branch right now. I've changed other explicit calls to slots to make the code "cleaner". I'll make a new pull and start from scratch, seems like the cleanest option.


@cowofevil , I was thinking about adding back that note about not being able to downgrade here. Like, is that a thing a user might try to do because this is only x86 for 2003?


Whenever I see this


Setting the GOPATH in a Makefile is a bit of an anti-pattern. It makes the experience of trying out new dependencies a chore. I'd recommend we make the Makefile GOPATH agnostic and have a build script to take care of the repeatability.

Check out the [`Makefile`](https://github.com/docker/distribution/blob/master/Makefile) in the distribution project for a simple example.


Thanks!


I believe 916c70a8ff83cb228fc5485e5e9a98b1f61348b2 fixes all issues with array allocation requirements. I pushed them up into MoveConstructible, CopyConstructible, and DefaultConstructible which is reborn from the ashes. They use the form `new T[1]{<expression>}` to avoid DR1467. I've added notes that these forms implicitly (pun intended) require the constructor in question to be non-`explicit`, since I think it's a subtle point.


:zzz:


Time constraints :(


wrap should be changed to capitalized Wrap for accessing from other packages.


Updated Kara-cleaned code for CRU pull precip and temp - 2015-06-23.


shouldn't the config.xml have been updated to 1.0.5 with this commit?


Although


Aye, commit attribution as present should do fine.

I'm currently fiddling around locally with getting those icons to highlight on rollover; so you may want to copy that over when I push it to my private repository. May do even a we 'on highlight pretty alt-text' thing or something to show in text form what each icon is.

There's no license clash anyway; and my site isn't even Open Source yet anyway. :smile:


Looks good, except formatting. Can you replace tabs with spaces?


Why did you take out `__slots__`?


I mean I thought the condition `if (!timeoutId && !maxTimeoutId) {` was required for recursive calls, but it can be removed and the unit tests will still pass. I don't see how always setting `args = thisArg = undefined;` could create a memory leak

```js
if (!timeoutId && !maxTimeoutId) {
  args = thisArg = undefined;
}
```


Nice one !
Maybe you need to set "Removable=No" to "YES".
I have succeeded to replace the wallpaper.ppm so on boot time you can see your edited picture (with photoshop)
If you have any success to upgrade memory please tell me
please
Or if you enable the sampling mode


Ah ups ok. Aber soweit ich weiß, ist es vorher bei mir auch nicht gegangen...


:-1: This breaks with Python 3.3 and 3.4. It also generates a pep8 error, since the module is technically unused.

I'm actually going to be replacing the current approach with `pbr` soonish.


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2157 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.47%25-yellow.svg)


Since query objects are lazily evaluated, I *think* that you can write the conditional much tighter. Something like this:

```python
query = sesh.query(Station.native_id, History.station_name).join(History).join(Network).join(VarsPerHistory).join(Variable).\
        filter(Network.name == network_name).\
        distinct().order_by(Station.native_id)

if self.args['is_climo']:
    query = query.filter(or_(Variable.cell_method.contains('within'), Variable.cell_method.contains('over')))
else:
    query = query.filter(not_(or_(Variable.cell_method.contains('within'), Variable.cell_method.contains('over'))))
```


:+1:  looks good to me. I did ask for an additional log file stating whether good to go or failed.


Fixed the indentation. I used `kDebug()` because it is also used on line 1311.
I think your suggestion to break makes sense, should I change it?
I have no strong opinion regarding `kDebug()` vs `kWarning()`, your call...


When it was a worker failure, the worker would be disconnected. As an app failure the worker can still be used, and the task is either scheduled for retry or if it has failed several times before should stop. Ideally this is a different type of failure because it is master related and not a result of the worker or the app itself. Lacking a third failure type, Ben and I discussed that app made a bit more sense since it did not boot the worker.


`args` can be modified by the user, while `args_after` can't.  Before the `args_after` machinery was available, the user had to copy the entire `-n -q -E -N -b dummy -c ...` to change a single option, and it was possible to remove options that were essential to syntastic.  The `args_after` thing is not nice, but the result makes a lot of sense from a user's perspective. _shrug_


There is no --nolaunch arg :)


@danielmarbach push a potential fix for this https://github.com/Particular/NServiceBus/commit/4f0e280b80cbb1eef9fe5993ce00c68d4f41d4b4 was that what you had in mind?


These changes will have an effect on https://github.com/pahaz/sshtunnel/pull/14/files#diff-76bc1662a114401c2954deb92b740081R578


Our packages have always only supported x86 on 2003, so I'm not sure what they downgrade to. And we only claim to support upgrading from packages, not upgrading from a source installation.


"formaté de tel sorte" should be "formaté de telle sorte", I'll do a merge request latter after this one will be merged


These don't modulesync? This is an issue on all platforms, but since we're targetting master/agent deployments the agent should resync modules on the first connection.


Need to remove the call to the now-removed `.dockerbuild` from [`docker-shell`](https://github.com/rehabstudio/fe-skeleton/commit/2962d64b24294c320fb90a2c61046d0ad3ccbba3#diff-b67911656ef5d18c4ae36cb6741b7965R69)?


OK


This should now be `new Preference` right?


**good job**


All right.


+1 Works.  Personal opinion, it'd be nice as a user to still have the option to navigate once I'm at the Intro or the Appendix.  Or, to not have the option to have gotten there with the previous nav errors.  Once I was on those pages, I couldn't nav back the way I got there.


Yup, works properly - takes about 13ms to run in the current form. Thought I had added it to the build.gradle file?


We can do more LED's on the next design. This one is meant to be REAL simple. The original design was just a single LED and a battery. The rest was a bit of future-proofing with minimal effort. We need to get these sent out and back ASAP.


I suppose a link to the actual session is in order here ^


These changes will have an effect on https://github.com/pahaz/sshtunnel/blob/d01ba0347a71de6e616e7dd1ffaf24f5fdad54e1/sshtunnel.py#L578-L579


This is excellent.


Well this has some problems with your try :

* Buildout dont know anything of compass so giving foundation/compass version in the buildout.cfg is not usefull;
* The "compass_install" is nice but it does not resolve problems with conflict between Foundation 5.4.x requiring Compass 0.x, and Foundation 5.5.x requiring Compass 1.0;

If you install the two compass versions 0.x and 1.x on your system, this will be the last that will be used each time you execute the compass tool.

And Foundation 5.4.x can't be compiled with Compass 1.x, nor Foundation 5.5.x cant be compiled with Compass 1.x

Finally, installing the two compass version will results that you wont be able anymore to work all of your project that need Compass 0.x, because when you will do "compass compile" it will use the 1.x


Hatte ich schon mal drin gehabt ... ;-)


yeah, that'd be nice, kelly. I was just using what PressBooks allows and didn't dig in to go beyond that.


Setting them to `undefined` isn't creating a memory leak it's preventing it. We only want to clear the stored `args` and `thisArg` when they are no longer needed.


is the return value of HandleCustomSpell() supposed to be handled somehow in this case ? Is the spell supposed to be cast at lines 1764 and 1766 even if HandleCustomSpell() returns true ?


Whoops, disregard the comment in the previous commit I made.


Please, rebase and use one of the enumerated exit statuses.


OK


That fixed my build, but broke travis :/


Hatte eine mögliche Methode zum Parsen ja schon geschrieben. Mit leichten Änderungen müsste die Übernehmbar sein. (also Semikolon optional, MIME ist immer an erster Stelle bei meinen Daten)


Yeah. PhPStorm's refactoring missed that one.


Yes, good point.


They would modulesync on an agent/master relationship. I'm not sure if @jbondpdx was pointing this out as agentless relationship or not.


@OrionDevelopment got it :P


Yup, agree.


So then there is a gap in the unit tests, right?


@MikaelSmith , there was some discussion the other day about whether we needed to mention that you couldn't downgrade from x64 to x86. But it sounds like that's not something we need to worry about.


Commented out code should be removed (git preserves history).


Nice!


Why You not in IRC?TS??


Added the key closing now.


@kdandola what do you think about this?


Yep.


@avital Please review!  Thanks :)


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Usos principales: redes sociales, geolocalización, comunicación


Ok, dann ist das wohl bei irgend nem merge oder rebase rausgeflogen. :wink:


While I also prefer the endif(statement) syntax, it *is* optional and not required in CMake as of 2.8 and above (including 3.x). For compatibility with 2.6, however, the endif(statement) syntax is required, but the CMakeLists.txt file here lists CMake 2.8 as the minimum required version, so this is wholly supported syntax.


Cool, glad I'm not going crazy

You dig this change? I can send it and a unit test later today


If LMDB was anywhere close to 300KB I'd be seriously perturbed. The .so file is around 300KB but most of that is ELF/symbol overhead, the actual code is only ~75KB and less than 64KB is in the normal execution path. The rest is administrative functions that are seldom used.


ok


I've never used vagrant myself, but it DO look awesome! Was looking through the docs and examples etc, and found this in package_Vagrantfile.erb:

```
# Load include vagrant file if it exists after the auto-generated
# so it can override any of the settings
include_vagrantfile = File.expand_path("../include/_Vagrantfile", __FILE__)
load include_vagrantfile if File.exist?(include_vagrantfile)
```

That way we can load the/a "global" vagrant file, and in that (if it exists) a local file either in the same dir or from the homedir of the user...


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2192 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.05%25-yellow.svg)


@yepesasecas [ActiveModelSerializer](https://github.com/rails-api/active_model_serializers) would be help you to make this clean & isolated :grin:


In htmlbars we can instead do `class="{{if isExpanded 'lowered' 'raised'}}"`, this is probably spitting out deprivation warnings.


@JimHokanson a different algorithm for which?

- normalization to 49 points (no?)
- skeleton? (i believe yes?)
- widths? (i believe yes?)
- angles (no?)
- area (yes)
- length (no)

Thanks!


No problem!


Ja, die hatte ich erstmal rausgenommen, da sie nicht verwendet wurde. Aber lässt sich ja einfach wieder einfügen.


dat werkt dus niet! AA moet 4 zijn


Sure, I'll prolly tweak the helper function name but the general thing is goodness.


Rather than checking the map name, why don't you check the map itself?


@mattlistro what do you think?


What's external? Are there more details somewhere about this change.


@Jrubin16 I think it looks great! Good to go.


Since you're in the area, `choice` and `choices[i]` are the same thing here, it's weird that they are specified both ways in the same expression.  Also this is the only use of local choice in this block now, removing the variable would be more readable in my opinion (in part because the name collides with self:choice)


Frequent commits - awesome!


Zal wel even een nieuwe commit doen met alle AA = 4.


Good idea!


@robertomiranda thank you sensei Roberto :) I will have a look.


1: M111 unrecognized component name: legacy


1:1: F403 'from bibclassify import *' used; unable to detect undefined names
1: D100 Missing docstring in public module
1: L101 copyright is missing
2:1: F403 'from bibexport import *' used; unable to detect undefined names
3:1: F403 'from bibknowledge import *' used; unable to detect undefined names
4:1: F403 'from bibrank import *' used; unable to detect undefined names
5:1: F403 'from indexer import *' used; unable to detect undefined names
6:1: F403 'from oai_harvest import *' used; unable to detect undefined names
7:1: F403 'from websearch import *' used; unable to detect undefined names
8:1: F403 'from websession import *' used; unable to detect undefined names


@Anik1199  why so jobless lol


More frequent commits! Every few minutes!


Thanks to @penibelst for making this possible!


Right on, had trouble figuring out a decent name. Underscore has test
coverage for this so just going to port it over

On Tue, Jun 23, 2015 at 1:42 PM, John-David Dalton <notifications@github.com
> wrote:

> Sure, I'll prolly tweak the helper function name but the general thing is
> goodness.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/megawac/lodash/commit/0635bf70abe02370f8fefb123d940bc01b5e0eb7#commitcomment-11822021>
> .
>


I push this commit to navtableforms to keep proyects synced


Do we need to tag the current branch? On compile right now, it's calling the version only

.b905.

It looks like git describe isn't returning a value


I second @adereis, call it `remote.log` and group `paramiko` and `fabric` logs on it.


as you are touching in this line, there is a unnecessary/unbalanced parenthesis in the comment


Wait WTF ? https://github.com/BuildCraft/BuildCraft/blob/6.5.x/common/buildcraft/BuildCraftCore.java#L162


Team, I have just added the benefits of each of the hiring alternatives (FT employee, Dev Shop & Contractor) on Github. Please, let me know what you think! @sunnywg @HannahVanGerven @tschmid16 @velizd @sonicshi


@SCastro16 this looks really good. thank you for contributing. lgtm :+1:


1 << 32 overflow.  upper bound impossible for (int) in any case.


my bad. i see that the components set already constructed isn't what's being accessed, instead it's going through the `SSTableReader.componentsFor(..)` process from scratch.

so your suggestion saves us some of the componentsFor..discoverComponentsFor… overhead.


Ummm.... did somebody do a *push --force* on this?  Because the SHA changed since yesterday.


@twizmwazin Should I amend the commit?


Can these `print` statements be removed?


check-style complains about the lines above (831-836)


Yes


Same here ^


We need to tag the current branch, I didn't realize I had to push the tag
separately
 On Jun 23, 2015 1:49 PM, "Isaac Tamblyn" <notifications@github.com> wrote:

> Do we need to tag the current branch? On compile right now, it's calling
> the version only
>
> .b905.
>
> It looks like git describe isn't returning a value
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hashkat/hashkat/commit/b933ef768cfb25b7ccaf9ea7ac377aeb36259265#commitcomment-11822135>
> .
>


@HannahVanGerven These are all very relevant takeaways, particularly 9. "Never forget the big picture". Good work!


Is this needed on win32? Because it creates additional directories (`lib/kodi` and `share/kodi`) that aren't actually used by the rest of the buildsystem (at least on win32) and which pollute the final install directory and can cause some unnecessary warnings about non-conformant addon directories in Kodi during debugging.


Minor typo - 'slector'. :)


I am wondering when this PR will be merged into jenkinssci and released for general use. I am in need of the fix for using submodules in Jenkins.

Thank you,
Cody Baxter


you did a mistake it is the opposite __BIG_ENDIAN__ is the power7 and __LITTLE_ENDIAN__ is the power8. Your tests do not work on power7 of the bg/q (the log fail) ^_^, please make the fix and on the front end of the BG/Q


Just a minor thing: tabs are preferred


Consider combining the issuer & currency checks into one: `if (deliverMin.issue () != saDstAmount.issue ()) { ... }`


Can you skip the `class_name` assignment (which is only used once) and avoid aligning variable names (it's not very [PEP-8](https://www.python.org/dev/peps/pep-0008/) - though I admit not strictly following it myself)?


<picky mode on> Is red_max guaranteed to not be 0? Same for the other _max values.


97643186-ABUPS-total-row-not-match-water (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1671 of 1671 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


avoid mixing variable declarations and code. put decls first


@abisosa este y los dos commits anteriores agregan las respuestas binarias.


On Mon, Jun 22, 2015 at 11:53 AM, Eric Niebler <notifications@github.com>
wrote:

> @sean-parent <https://github.com/sean-parent> wrote:
>
> I agree with Andrew on this.
>
> You mean, you agree with me (Eric) on this.
>

 I was agreeing with Andrew's comment - the biggest concern is if the
concepts allow us to reason about algorithms.

Some further thoughts -

I think copy independence is getting confused with general side effects.
You need an overarching precondition that operations don't have side
effects that affect other values used within an algorithm and that no other
thread of execution is changing values used by an algorithm.

The more I think about this the more I think the correct way to handle it
is by specifying the postconditions of assignment, and noting that for
references, or proxy types, to satisfy this post condition they cannot
alias the same object, and the referenced object's assignment must satisfy
the postconditions. i.e. for the set of objects visible to an algorithm,
assignment may only change the value of the object assigned to. The value
of other objects may not change.

We do not prohibit side effects in general.

Sean


LGTM


response with an s


Aren't you missing an `else` statement here? (Also `id_or_class` is already set to `'id'`.)


add space after }


Remove this second return.


The old system should be left in place. The only reason the player location is sometimes used is because there is no location specified, so it is essentially a "fallback" for when location isn't specified in the XML. However, when it is specified, we would want to use the XML's location as the proximity at that point is based on block location (safety/retrieving inventory) instead of the player's location.


"a property"


unconsistent identation


anything inline should be static. if this header is included by applications, you should use RTEMS_INLINE_ROUTINE


request


А вот здесь у меня проблема - у меня не работает, если я просто пишу import rnafold


a


The wording here seems a little awkward, "defaults to containing". Also, not sure what "is a type of" is supposed to mean.

Why not simply "`FlxGroup` is an alias for `FlxTypedGroup<FlxBasic>`"?


can use just n_tags, and n_qrs, except that n_qrs is unclear without the comment. Perhaps call them "request/response entries" or "values", then this can be n_entries or n_values?


But the first return is inside one if (I'll remove the empty line between the if and the return, it is confusing)


It's possible that people can call _either_ `$.scrollTo()` or `$.fn.scrollTo()`. Let me refactor the code to group together the container-related code.


Let's make use of type inference here.


Would it be possible to start a lightweight in process JAX-RS server, so that we don't have to mock out so many things but instead have more like a integration test?


duplicate ID `navigate_button`


Perhaps ```BUFFER_REQUEST_SUCCEEDED```?


the red_max can be received from one RGB packet. Is it safe to be non zero?


fuck. spelled @rouge8 's name wrong


And the macro maybe should be SUCCEEDED


Ok. I'll fix it


Use 2 spaces for identation.
When declaring private methods, they must be aligned with the "private", and not idented.


>(Also id_or_class is already set to 'id'.)

The value could of course also be previously set by the user, but either way maybe it's better to fall back without explicitly setting the value!?

Also, why not add some more common HTML selectors?


Except, functions are usually given in non-uppercase, so ```bcm2835_mailbox_buffer_request_succeeded()```


Jup, this looks really clean and I believe it will help new sailors get on board effortlessly.


Hi. The callback being passed into _authenticate is missing the err argument, this results in responseData being null as the callback is invoked with (null, res.body) in _onAuthResponse.


Not a fan of the name "MyClass", seems pretty generic - that could be pretty much anything. Maybe something more concrete would be better? `Ball` would fit the demo.


Handler/Scores.hs was accidentally included in this commit. It should have been in https://github.com/haBuu/tuohi/commit/612cbe88562e38e2a8874f1196ce18447f607b7e


The use of the addresses here is perhaps a bit confusing, as if the address isn't in the wallet the command won't be successful, so a add that works for me won't work for you.  If we're both parties in this multisig we'd want to both run the command,


And I guess this should really be ```bcm2835_mailbox_response_succeeded```? I'm not sure what "tag is succeed" means.


On it


Hi @sunnywg @tschmid16 @SCastro16 @velizd @HannahVanGerven  what do you think about this?


hello, I have some puzzling questions for this code.
Using NSGetSizeAndAlignment   , we can deal with all type of arguments.
Why we need so many "if else " code?
Is there some potential problem ?


If we know a maximum number of buffers that will be needed ahead of time, they can be pre-allocated into a freelist and just added/removed from there. Is that a possibility instead of using ```malloc```?


Oops. B6t onky in the comment ...


We don't need you to write your name - git blame makes it easy to look this up.


1679-DualDuct (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Please add docstrings for the class and methods. See https://github.com/OpenKMIP/PyKMIP/blob/master/kmip/core/messages/payloads/query.py for an example.

Also please fill in `validate` for both classes. It can be super simple, since it's only checking the UID type. No need for `__validate` like in other classes; it's unnecessary and I'm phasing it out.


Hi @sonicshi this looks great. I will think about this for my next project. lgmt :100: :+1:


Again, don't need name


@pozibrothers you are very welcome - thanks for reporting :)

@sethreno do you think that it's worth making a new release with this fix included? :)


Don't need { } as it is a single line conditional


Hi @HannahVanGerven I like it. It's really relevant and well written. Great job.


Done


Please add a docstring for this method. See the `query` method for an example.


I don't think this logic is quite right, but could perhaps be fixed by me in a follow up. It seems odd to display cubes as an option when none are present, or MOs/electron density when that information is not present.


Avoid the extra \ at the end here. Also, use the do-while(0) trick to force a compound expression with scoping, e.g.
```C
#define BCM2835_MAILBOX_ALLOCATE_INIT_BUFFER(_buf, _buf_size) \
  bcm2835_mailbox_buffer *_buf = malloc(_buf_size); \
  ... \
} while (0)
```
Without the trailing semi-colon. On the other hand, this macro could also be made into a function, e.g.
```buf = bcm2835_mailbox_allocate_init_buffer(int size);```


this should be in tests, not src


Duuuplication of effoooorrrtt : P


Done.


Oh right on. We have no limitations on what we've dubbed "side-grading" (horrible name I know), where you install one architecture and then install a different architecture over the top of it.  It should work without issue, we've spent a lot of time testing both downgrading to earlier versions and this side-grading.

While technically possible, it is hard to go up using this module and then downgrade to an earlier version of puppet and not need to perform manual changes to put things back the way they were.


keep it this way revision=1,2,0.1,0.2 xD


We probably want to make this more dynamic if we are going to generalize this dialog.


FYI, STASH_MAX_PERM_SIZE is a deprecated variable no longer used from version 3.8 forward. Change should probably have been the reverse, AKA changed STASH_MAX_PERM_SIZE to MAX_PERM_SIZE instead of the other way around?


Handler/Input.hs was accidentally included in this commit. It should have been in https://github.com/haBuu/tuohi/commit/847dbaaa4624c8d5ea2953933e3305fb50250721


@Mariano, @Gustavo, tengo algún comando en git para descartar los archivos
de por ejemplo DriverSerie para no subirlos en el branch? o tengo que
volver para atrás y hacer merge con una versión anterior?
Saludos

Seba

2015-06-15 12:50 GMT-03:00 Gustavo Muro <notifications@github.com>:

> acá tambien están raros los espacios
> seria:
> case ciaaPOSIX_IOCTL_SET_NONBLOCK_MODE:
> (*)(*)(
> *)if((bool)(intptr_t)param == false) (*)(*)(*){
> (*)(*)(*)(*)(*)(*)...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sebabedin/Firmware/commit/669395b41570910d10976c594b6fdba8dca4aaae#commitcomment-11683337>
> .
>


Here use do-while again. _tag has to be a literal constant and not a variable in order for these CPP concatenates to work, is that always going to be the case? Add some doxygen comments about this macro.


@SCastro16 I like it. I will consider this when hiring my next developer. lgtm :+1:


As a data model comment, it's not clear why categories are pre-determined.


LGTM


Shiny button?!

I approve of better shading. But also, MOAR new logo.
On Sun, 14 Jun 2015 at 10:26 Callan Bryant <notifications@github.com> wrote:

> Thanks, I'm glad we have the original. The thickness of the box disappears
> where the cat is though lol. Needs some fixing, and no shiny button around
> it I think.
>
> Maybe we should shade it like this?
>
> <https://camo.githubusercontent.com/6bee0b78066fb69b713e1cfb7c1b0d0122d29e5c/687474703a2f2f73332e616d617a6f6e6177732e636f6d2f7468656f61746d65616c2d696d672f7468756d626e61696c732f6661696c65645f6578706572696d656e742e706e67>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/naggie/crates/commit/d11fba52a9972bbbdbe7f6213a8ca55f52e43534#commitcomment-11669287>
> .
>


You don't need the second set of ```##```


@exters This is the wrong place, please use #115.


```##__VA_ARGS__``` isn't right. It should just be ```__VA_ARGS__```


develop (axelstudios) - i386-Windows-7-VisualStudio-12: OK (2186 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.78%25-yellow.svg)


Setting a return value as side-effect of a macro is a bit suspicious. It might be better to make this into a function.


This looks really good. In addition to the docstrings, please add test cases and/or test suites for the new methods and objects. See https://github.com/OpenKMIP/PyKMIP/blob/master/kmip/tests/unit/core/messages/payloads/test_query.py for an example of test suites for payload objects. See https://github.com/OpenKMIP/PyKMIP/blob/master/kmip/tests/unit/services/test_kmip_client.py for examples of client tests.


Its better to use less lines of code:

```ruby
return redirect_to @article if @article.save
render 'new'
```


Generally speaking it is better to use an inline function rather than a macro.


90664130_AlternativeModelPAT (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


.icon-box > img {
	width: 20%;

kenapa di delet jaw ? ada conflict ?

gw butuh bwt icon "Who we are" tetep kecil


in this case, shouldn't you release the sentinel's memory ?


Delete files that you dont use


Changed "Given" -> "given". Should I change this for replication controllers too?


`buildInvitedUserViewModel(users)` should return the whole object to pass in to `RenderJson`.

have a look at this:
https://github.com/santiaago/gonawin/blob/master/controllers/teams/ranking.go

Also, I think it should be `TeamInvitedUsersViewModel` and `buildTeamInvitedUsersViewModel`


Ich würde eher einen leeren String dafür nehmen. Außerdem kannst du hier die `extractString(3)`-Funktion verwenden:
```c++
writer << Value::extractMIME(extractString(record.content, pContentType, ""));
```


Thanks; I'd offer to edit that into the commit message, but I have no idea how it compares to e.g. SQLite.  While I've got you here, do you happen to know if there's a native Java implementation of LMDB planned or available?  That would be useful for jGit.  I know there are wrappers, but the jGit folks prefer pure Java.


Bummer, I didn't catch that... was getting tired when i was editing files last night. I'll fix it. Thanks


So, like with many changes, this one is missing a reason.Does it fix a bug? if yes, what's the bug?

If that's not a bug, then why does this change take place?

If it's not a bug, then IMO we should reject this PR, because it's just a preference name and not user visible, and preference/config option names are better kept consistent as lower  case.


This would be neater and still fit in 80 columns:

```
                for (level, optname), value in self.connection._sock_opts.iteritems():
                    self._sock.setsockopt(level, optname, value)
```


Hier gibts doch kein Problem? Dass bei `";text/html;;;;;"` `""` rauskommt ist doch in Ordnung, das ist ja auch kein valider `Content-Type`-Header.


added a branch named root1


Screenshot for generating Gnome desktop entry with Android Studio
![menu_001](https://cloud.githubusercontent.com/assets/803596/8313659/808371a0-19e4-11e5-8d83-f43220d22648.png)


Any news on when this will be included in a release?


I don't know the answers to those questions; I haven't used it. If anyone has anything specific to add, I'll gladly include it. For now, I'm just trying to get what I _know_ documented and we can expand from there.


Then unless anyone disagrees, I'm going to stick to our original decision that the downgrade issue is an edge case anyway and doesn't especially need to be addressed here.


The VM does not use Ruby 2.2.x by default
```
vagrant@vagrant-ubuntu-trusty-64:/vagrant/xml_to_csv$ ruby -v
ruby 1.9.3p551 (2014-11-13) [x86_64-linux] Brightbox
```
When you try to run the script using `ruby2.2` it throws:
```
/usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require': cannot
load such file -- parallel (LoadError)
```
it seems like `gem install` installs to the default rubygems


@keith-hall Yep, I'll do it later tonight. BTW will you shoot me an email so I have your email address? I had something I wanted to send you.


Hola Seba.
El tema es que tu comit cambia varios archivos.
Creo que lo mejor sería hacerte una copia de los archivos que sí deben cambiar, luego deshacer el commit, y finalmente restaurar los archivos para que queden más prolijo el commit.
Se entiende?
Mariano, se te ocurre algo mejor?


Sieht schon mal ganz ordentlich aus :+1:  Also dafür, dass wir noch keine Bilder haben :smile:


Done.


ich fände ja ```none``` besser als einen leeren String, aber inhaltlich vielleicht besser leer?


@sunnywg @tschmid16 @HannahVanGerven @SCastro16 @sonicshi.  What do you think?


When is the new release planned?


to avoid repeating code you should use:

```ruby
def article
  @article ||= Article.find(params[:id])
end
```
This will place in @article the Article only if article is nil. Then in edit, show and update you just call article.


Me parece que taguearon al mariano incorrecto ;)


Hi @velizd looks good. thanks for contributing. :+1:


ok, war mir nicht sicher, was man als gute Test Cases annimmt.


also there is no -q or -pidfile. See Htpc.py for a full list of args


> I was agreeing with Andrew's comment - the biggest concern is if the
concepts allow us to reason about algorithms.

Whoops, I missed Andrew's comment.

> The more I think about this the more I think the correct way to handle it
is by specifying the postconditions of assignment [...]

I *think* this is close to what I was saying, but I need to think about it some. Thanks, Sean.


please dont upgrade to a commit; use a published version.


It was almost perfect the first time I did it...With a few exceptions...Those debug comments really helped a lot :)


Looks great to me.