I had hoped that by defaulting to relative positioning (assuming that's what would cascade to `#map_box`) , and using relative width, then the map would flow inside `container`.


@bernardobrezende não sei o que aconteceu comigo


test


It seems that this https://developer.chrome.com/extensions/manifest/web_accessible_resources will solve the problem. Of course, it opens the possibility for anyone to uninstall the extension, but since we're deprecating it, it's IMHO not a vulnerability. Especially if we add the confirmation button.

Updated the CL, PTAL.


Oki; solucionado -> https://github.com/Codeko/codeko-password-manager/commit/043c99f8f128c4d08e8091c4def68af81b587a54


czemu sam napisales mini serwer ? :D


you should set t->params after doing the sanity checks, otherwise you'll do a double free (you can catch it with DBG_QM_MALLOC)


add a new line to document


@Deadooshka mind expanding on that?

I see that are some cons and pros on both extensions, eg:
- iconv comes bundled by default, while mbstring needs to be enabled
- iconv uses an external library (supports more encodings but less portable) [[1]](https://beeznest.wordpress.com/2008/04/22/mbstring-vs-iconv/)
- mbstring has the library bundled with PHP (less encodings but more portable) [[1]](https://beeznest.wordpress.com/2008/04/22/mbstring-vs-iconv/)

Perhaps extracting those calls to a separate interface with both iconv and mbstring implementation and letting the user decide which one to use is a good idea?


Thanks, we should definitely default the flag to false. My mistake.

Thanks for offering to do a Google around. I must admit my knowledge on these issues is scant and it's great having someone as knowledgeable as yourself to look into it.

I think making the version of the GLES you link to configurable is a great idea.


I really want this in. I don't want 300 day old drafts in the database. So I am reverting this revert.


@graingert Thanks for the suggestion! I didn't try tox before, I'll look into that. Maybe you could send a PR \O/


I've tried to put them to the end of importing block , but go fmt reorder them like that.


nice


Thanks to fixing.
I shoud be careful about class name.


http://uskk2ecdf061.schadock.koding.io:3000/ everything seems fine -> "Hello World!" being displayed correctly


Congrats, nice to see that some more Elo can be tuned out of king safety.


Ok, I will replace it with getForm()


To rename MetricsDBServiceBase


Oh, maybe. I'm not very well versed in lib/lib64 directories should be handled.
But isnt there usually a link from lib to lib64 on 64 bit systems? But then again maybe there isnt in /usr/local?


Yep makes sense - I am going to do it the same way like in AjaxButton.


resule --> result


no exception handling in the case no ceph cluster deployed.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.224](http://teamcity.monogame.net/viewLog.html?buildId=7930&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 496, ignored: 6 Build time: 00:20:20


Adding this line breaks the build on ARM 32


Why did you do this? I think it is better for this to live in the AboutActivity. It is only used there.


:+1: agreed, current impl is just 1


The other refactorings show only the packagename change. Why does this show complete red and green changes? Not that important but just curious.


The OutputField should always be assigned to a form, but it can be placed outside it. I am going to implement it the way you suggested at getForm() - so if the OutputField is inside a form you don't have to set it explicitly and it is received the same way like AjaxButton.


Nice. I'll give that a shot.
Thanks @minrk.


Magistraal @Lg0enga


Which OS is this?

That's how it looks for me... Adding more spacing would look weird here.

Instead of using the text height as width indicator for the checkbox there should be something else used...

![plugins](https://cloud.githubusercontent.com/assets/588407/7934931/75db0c5e-092c-11e5-8d91-ab463af58b80.png)


Все же не приема с сайта, а отправки из лаунчера


This might change the tracking behaviour of the L1 controller because the waypoints are suddenly in front of him. But maybe you won't notice it.


This seems to solve the issues with smoothing in 3D, but minimal_example.py still fails with max_edge_length=1. and max_edge_ratio = 50. .


Yes, certainly!

But is there some finer subdivision you can think of? Chopping `executePhases()` up into smaller pieces?
Because *preferrably* I'd only want to *add* something, so future changes to `executePhases()` don't have to be copied over to the subclasses that override it.

eg:

```java
@Override
protected void executeDeclarationPhase() {
    super.executeDeclarationPhase();
    MyVisitor v = new MyVisitor();
    for (PhasedUnit pu: listOfUnits) {
        v.visit(pu);
    }
}
```


This can go into chapter or common because it is used outside of the eventseries pages like event Fragment in the chapter pages.


ss


Right now, this is opened only from the news feed of the chapter but it doesn't have to be like that. In the past we had GDL pages. We were thinking to have Youtube videos page from Google Developers Youtube channel. Where should this class be?


Имена функций


check for correctness - yes, it's fine, upper level methods (which perform checks) set this and lower level record layer methods have asserts for that. Changing it mid-flight will cause your connection to be instantly dropped anyway, so you'll quickly notice that you're doing something wrong ;)

it is a public method as it was a public field, so I'm preserving the API.

I'll add a note that user applications are supposed not to use it.


原文: explicit type
訳案: 型を明示
(「明示的な型」では文脈的にちょっと意味がわかりにくいかと思ったので）


Here you should probably just default-construct ```help``` as a ```VectorType``` of the appropriate size:
```
VectorType help(v.size());
```


Why not? In my opinion the input event does the main job - it calculates the value the OutputField grants access to. See the example:
http://www.w3schools.com/tags/tag_output.asp

I think it is nice to set the InputScript in the Java class, because this way you can decide what the client is calculating based on PageParameters or other flags for example.

outputField1.setInputScript("parseFloat(%s.value) "+(something?"+":"-")+" parseFloat(%s.value)");


... and move the declaration of ```v``` here, since this is where you use it.


We don't need to store the group leader, we can get it from Process.group_leader(self()) each time. This should be done as io request so could do the group leader.


I think I can reduce code a bit by matching `{-# PRAGMA_NAME` at once.


I have rather minimal test coverage for this, so I'd rather not do this just yet. I also plan to change the error handling rather significantly later on, so this code may disappear completely in the future.


FakeHandler?


We don't need to set any group leader because the group leader of the the ProxyIO process will be inherited from its parent automatically.


what do you think about pulling the UTC from units into the time zone field at this point?


I'm sure i'll be slapped for being stupid but, how do i do this to fix my stuff?


study


New structure, related to #5.


Overflow warnings eliminated by added extra parentheses around ACCELERATION/2000.0 so that this takes precedence over the leading multiplication.


Should be fixed in a2d0523


StackClass Stack Class
StackClass1 Stack Class Template


Lets not set the group_leader here, instead let pid change its leader to the ProxyIO process. Changing another processes group leader can lead to race conditions.


text number - '-A' ))


Can we move this to Logger.Backends.Capture? This backend itself and the cature_log function should be independent of ExUnit


Finally solved and validated by the client #17


We don't need any of this, if using code from my gist it would be like
```elixir
def init(prox_io_pid), do...
```


lets use `:capture` key.


ah, ok. :-) That's the whole magic behind it. Thx!


Well if I did it that way, you would not be able to insert your own phases; you would be stuck with mine. So it's less flexible and, frankly, sounds over-engineered to me. It's not like I change this process very often and it's not like there are lots of places which need to customize it.


maybe `#if !defined(IPPORT_USERRESERVED)` is better?


if you just say
```
return point - tmp * normal_vec;
```
the compiler can optimize a lot more than if you first explicitly declare it. Also, your code is much more concise.


You can use `allow_failures`: http://docs.travis-ci.com/user/build-configuration/#Rows-That-are-Allowed-To-Fail


lero?


Why just not to skip them earlier before creation of proxy class?\


This can be squashed with the previous commit


I'm not sure about the behaviour myself. Let me just set the previous waypoint behind the plane so that we don't need to speculate.


Congrats too!


Would it make sense to rename ranges here as well? I guess the above messages are visible to the user...


Why didn't you overloaded move assignment operator?


Argh. Nevermind this. I'll just remove the texts from here entirely.


Have you handled the exceptions elsewhere?


Yup, they certainly are.


Is this commit necessary?


LGTM


я следующим комитом вообще убрал эти пред-надписи... они просто для теста были..


I can see the confusion. Feel free to improve it :-)


@ktakagaki
Would it be acceptable if I on the dev branch modify .gitignore to include most of the .idea/ folder? It has been my experience that including the .idea folder when collaborating quickly can lead to merge conflicts and runtime errors that are IDE specific and not code/project specific.

@slentzen
Reminder to myself to look at this section.


@jcoglan that's fine.

Not asking you to do any work.

But I wonder if the hassle of people saying "I hit this issue" is equivalent to the hassle of doing a new release.

But by now, maybe everyone has already added the monkey patch.

If anything, this was a little helpful in letting us know we've got a hole in our exception notifications

(Because it was an error on the EM thread, it ended up being swallowed, and it broke for a few weeks before we noticed)


> Why just not to skip them earlier before creation of proxy class?
There is no information about the alias in the service locator, to understand it you should call `->get()/->has()`


Ah, what? Did you test this? "Observation.time.location.<blah>" doesn't make any sense.


原文: explicit type
訳案: 型を明示
（「明示的な型」だと文脈的にわかりにくいかと思いましたので）


Ok, no problem.


Hahahahaha awesome


Any reason for leaving out the schema? I don't really think it matters


@fishcakez thanks, will address your comments in the separate commit to keep history for a while.


You can use [tokenize.generate_tokens()](https://docs.python.org/2/library/tokenize.html#tokenize.generate_tokens) on Python 2.7 to get the same-ish API, but it won't return namedtuples.


Че эта тут захардкожено. При этом moduleName передаётся и ниже используется вроде как.


Does this sentence make sense? I can't parse it.


Also, any reason for leaving out the `.ruby-version` file? This specifies that ruby version we use for this application, and keep the development environments consistent


Not much convinced about the default threshold. As I see I missed the "label = 0", which is "Frontal Pole" in the Harvard Oxford Atlas. I could not find it by switching the ```cut_coords (x=48 y=94 z=35)``` since where the maximum intensity lies. May be I should use some other strategy for a threshold ? Any views on this ?


```
if ($config['event_manager']['listeners'] == null) {
continue;
}
```
On LoadModulesPostListener line 37


撒的发斯蒂芬


Hum, please revert, the name property is "nginx_working_dir" and not kong...


To which change in which class does this refer to?


Что-то я не то сделал, хотел пул реквест создать, а получилось вот так.


What value? Maybe giving an working example?

plg_system_redirect.sys.ini is https://github.com/joomla/joomla-cms/blob/master/administrator/language/en-GB/en-GB.plg_system_redirect.sys.ini


If you know bower, you should reconsider using it to get external libraries / assets, instead of adding the whole file onto the repository


you should use defvar instead, if the mode is reloaded these variables are reset using setq.


webpack.config.js 没改...


forgotten #1


This can be squashed with the previous commit


Wouldn't creating an `ArgumentError` with string as argument already create a GC frame?

Also #11508 should reduce the cost....


Check explicitly that the state is not unknown.


@skymovinggit you're welcome)


yes, good idea. I will add that.


@tardate @jamesotron I agree, I don't want an argument.

In reality you're welcome to choose how you manage your own project.

But I think it was wrong to call it

```
old school and dumb
```

But, somehow I noticed the commit, and I personally wouldn't do it.

So...


Missing..
`packages/apps/ExodusSettings/res/xml/exodus_dashboard_categories.xml:120: error: Error: No resource found that matches the given name (at 'title' with value '@string/interface_title').`

`packages/apps/Settings/res/xml/hardware_settings.xml:17: error: Error: No resource found that matches the given name (at 'title' with value '@string/more_device_settings_title').`

`packages/apps/Settings/res/xml/hardware_settings.xml:22: error: Error: No resource found that matches the given name (at 'title' with value '@string/supported_hardware_preferences').`

`packages/apps/Settings/res/xml/hardware_settings.xml:26: error: Error: No resource found that matches the given name (at 'title' with value '@string/button_navigation_title').`

`packages/apps/Settings/res/xml/hardware_settings.xml:26: error: Error: No resource found that matches the given name (at 'summary' with value '@string/button_navigation_summary').`

`packages/apps/Settings/res/xml/hardware_settings.xml:32: error: Error: No resource found that matches the given name (at 'title' with value '@string/button_settings').`

`packages/apps/Settings/res/xml/hardware_settings.xml:49: error: Error: No resource found that matches the given name (at 'title' with value '@string/fast_charge_title').`

`packages/apps/Settings/res/xml/hardware_settings.xml:49: error: Error: No resource found that matches the given name (at 'summary' with value '@string/fast_charge_summary').`

`packages/apps/Settings/res/xml/hardware_settings.xml:62: error: Error: No resource found that matches the given name (at 'title' with value '@string/sensors_motors_title').`

`packages/apps/Settings/res/xml/hardware_settings.xml:88: error: Error: No resource found that matches the given name (at 'title' with value '@string/wake_options_title').`


Argh, no, that won't do. Grrr. I'll have to come up with another solution for the failed test for running doc on the language module.


How/why is this useless and duplicated?


@cataphract
I applied your suggestions in the next amended commit.
https://gist.github.com/anonymous/d4bd27529aecfeef4e9b
https://gist.github.com/anonymous/c44162b5b25f603a28bd


ah mogao sam ali nisam :)


prachtig mooi!


Close #9


Just open the sample app activity_main.xml and add app:dsb_step="15" to the SECOND DiscreteSeekBar.
Now run it inside an emulator and use the keyboard to move the thumb. You'll see it going to 105 when the max is 100.
The thumb and bubble will be drawn at "100" but the floating bubble will show 105.


Tried a new approach which I think is the better solution:
https://github.com/hmb-ba/protocol/commit/d7838ff38fea5cb9383563e41b072ed91903eb9f


As it is now, there is no easy way to make flags recipe type specific, so in this case, the nls flag is for all recipe types, so both machine and native.


ARRAY_SIZE return size_t. It's better to use
size_t i;
for(i = 0; i < ARRAY_SIZE(); i++) {....}


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Why is it lazy val vs def?


Might be worth pulling `Firm.find(params[:id])` into a before filter. Wouldn't be surprised if needed for another action, i.e. `destroy`. Not too fussed about this though.


The value is that the link only works if the string 'System%20-%20Redirect' is translated to the equivalent value in the local language.

As far as I am aware we have never done this before which is why there is the note


I would prefer that you returned the stream `ws` in `fromFile` ... then I could just go back to using your version :)


To avoid maximum overlaps between each maps, I used less value ```threshold=1e-1```. But, I guess that should not be the case. If our use case is canica maps then users will see to threshold more to display it quite neatly. But, here the design of the threshold contradicts. Am I wrong ?


Well, it seems you have no tested: "rtcwake -m show", must be

if (!alarm && !seconds && (suspend != DISABLE_MODE && suspend != SHOW_MODE))


No, at least on linux it's an enum. Configure check should work though.


did this change or was it wrong?


I believe this should be `GameStats.find().fetch()`


This is where it might be better as:
```julia
    checkfornul(p, sizeof(s), s)
    return Cstring(p)
end

checkfornul(p, len, s) = throw(ArgumentError("embedded NUL chars are not allowed in C strings: $(repr(s))"))
```


Congrats!


eh no, for the sake of being still able to run 32-bit-compiled stuff. all the `*-32bit` packages put their stuff in `lib`, while regular packages go to `lib64`.

In this case, you'd either check for which architecture the library is being compiled, or alternatively assume `lib64` as that's what would work for most people on most recent distros.

In my case (opensuse), jsonrpcc went correctly into `/usr/local/lib64`.


Unfortunately, this code leads to the CSRF error we've been seeing.


So we have this https://github.com/moneyadviceservice/rad/blob/master/spec/spec_helper.rb#L26, which should enable you to just type `create(:principle)`


Do you have bandwidth to quickly implement and test in HIL? Then Andreas could wrap it up tonight.


oh and, `f.id` is still good for anyone not generating their own ids (and also backward compat with gridfs-stream)


We use the PEP8 convention when writing Python. It says that variable names should be lower case with underscores separating words, so this should be ``user_authenticated`` instead.

See https://www.python.org/dev/peps/pep-0008/


We can see all these information in `db/schema.rb`. I think this is unnecessary as these information can get deprecated


Unnecessary


si, las comas me las comí


@wincent I saw your commit reference - I remember specifically testing something like this so it's odd that it's still giving you an error? Also, I just downloaded the repo and removed the these comments and am not getting the error.


Code conventions here


Nice!


Just after
https://github.com/diorcety/oe-lite-core/blob/c6df66a3e48b8b8374f542b43292547a0a858249/recipes/binutils/binutils.inc#L137


You might consider exposing only safe conversion functions like `textToTopic :: T.Text -> Either String Topic`. They would report failed conversions of invalid names on construction time. This way there are no surprises in production.


Hmm, I just double-checked on Ubuntu and found that they place everything in `lib`... so it seems it is distro-dependant. That mean your patch probably works for Debian family but not for Redhat derivatives...


Thanks, fixed.


Ok ok, so without nls flag is quite unusable


I don't think so, it makes it easier to support STARTTLS and TLS shutdown, so that only part of communication is secured and the connection is reused later - the client application then doesn't need to keep a reference to socket itself

IOW: the socket comes from application using tlslite library, not from library, so hiding it doesn't prevent users from shooting themselves in the foot anyway


> How exactly it doesn't work? No sound, cracking sound, desync?

Desync and after switching to channel to one with different audio type there is no sound. Until I reselect it.

Anyway `AM_PUSHSOURCECAPS_NOT_LIVE` flag is there so no wonder it doesn't work.

I've forceful changed `live` to true, and it does work for EAC-3 audio, but with MPEG-1 it cracks and spams "AudioDevice 10ms of silence", apparently `chunk.IsEmpty()` is true.


alert needs to be removed.


What's supertest?


This can be squashed with the previous commit


They were always the same in ofono


We should run mongo and
/data in a different directory


Should this function be moved to MultiDataGet ?


"here an not" ->  "here has not"

Or, perhaps better

"but here the student has not _ordered_ "


Just missed it


Shoudl this function also be moved to multiDataGet, but without hard coding Activity.class ?


What is myAlertFunc method for? For testing?


this is version set by the handshake protocol, not one that is set by user or received through the socket

so a version set to a wrong value here indicates that something went really bad somewhere else in library, an assert for such check is correct, IMHO


@eguneys I tracked this down and opened https://github.com/intridea/grape/issues/1023 which is likely the same problem you are having, I am probably going to undo the `respond_to 'merge'` part.


I do want to support this kind of usage one way or another. At the moment I'm not convinced that the capnp crate is the right place for the non-blocking logic to live; if we clean up some interfaces I think it might be possible to put it in a separate crate.


You're aware that we can use enum right?


Hmm... not elegant, what about to add skip_fline() to include/strutils.h  (we already have some skip_ functions there), and then:

if (skip_fline(fp) || skip_fline(fp))
   goto error;


Please review this [commit](ba7e519a099f349adc556415ce52a26a24c20b46), if there's any problem, let me know.


Then we can remove it for now. Turns out it was not what caused the problem it was meant to fix.


@erichonkanen just wondering, because of #60, is this supposed to be `expiresAt` or `exp` ?


just as in the c5bb319 commit - the self.version is set by library, incorrect value here means that something went really bad in the library


Thanks.....
I made a little modification in order to calculate max min limits during governor startup or policy changes its limit :)


Meant: It didn't fix the problem it was meant to solve.


I love this feature.


something a bit weird here. you are checking symbol.isStatic twice (one other time in isInnerInnerClass)


add a small documentation


1. For === is ok,
2. Ok. Now I know :)


Not sure if we're doing style-nits but these could easily go on one line now.


Sounds good. Thanks for the details.


The idea is to move the code that implements the encryption to separate class, the code that implements the negotiation of encryption _keys_ stays in TLSRecordLayer and TLSConnection


Well, cracking is good actually. It means it receives samples, just feeding algorithm is slightly wrong. No samples would mean complete silence.

I need some time to think about ``AM_PUSHSOURCECAPS_NOT_LIVE``. Though, screenshots of DirectSound audio renderer and madvr statuses during DVB playback would help somehow.


nit: maybe rename to `NodeAddressResolver` or something which reflect dynamic character for this class (now it suggest it is a bean).


Related to #89


We can rename the `regression-version-to-3.2` branch to `release-3.2` and then probably tag it.


Does this decorator needs to be declared here ? Doesn't it already exists anywhere else ?


Any reason for choosing `will_paginate` over `kaminari`? I'm looking at the repositories of the gems, and it seems like `will_paginate` is not being maintained at the time. Comparing the number of open issues, `will_paginate` has 59 whereas `kaminari` only has 12. Also, last commit occurred about almost a year ago for `will_paginate` whereas `kaminari` was committed only 6 days ago.


This can be squashed with the previous commit


Not sure I understand this.   I don't see mongooseConnection as an option for mongoStore


Supertest was one of the default libraries included when we ran the Yeoman generator.  It's for running http assertions in unit tests:

https://github.com/visionmedia/supertest


style-nits lead to better code :-)
fixed.


Why this xmlid?


its just to get used to it.


Once the sending of properties will be moved to the end of the build, this maybe doesn't need to stay that way.


Функциоонал для отмечания комментария как "хороший" (несколько) или "лучший" (1) (не доделано: после переназначения "лучшего" комментария не обновляется отметка).


The compiler will not be happy with devpath = devname;  (char = const char). What about:

<pre>
char *devpath = NULL;
...
if (startswith(devname, "/dev"))
    devpath = devname;
else {
    xasprintf(&devpath, "/dev/%s", devname);
    devname = devpath;
}
fd = open(devname, O_RDONLY | O_CLOEXEC);
...
free(devpath);
</pre>


Assumin glob now uses promises.  We could add this back to mean.js


It looks like an inherited view without inheritance info...


Not 100%, but this seems to broke the code. exports.static() creates another object and sets 'lr' field for it, so exports.lr is just undefined, or am I wrong?


I'd be tempted to split these two onto their own lines, but that's sort of a personal preference @nomis52 may feel differently.


Onda nešto komitaj :)


Cuidar a notação PascalCase. Olha o diagrama e vê como os valores estão lá.


I absolutely agree.  Unfortunately, when using the editor in c9.io, I don't have write access to any directory in the filesystem except for my workspace. It's by necessity that I need to create (and `.gitignore`) a `data` directory in the project root.  By adding it to `.gitignore`, however, we ensure that none of that data will be checked into the repository.


`(nth 8 (syntax-ppss))` is the position where the comment starts, can use that instead of `(line-beginning-position)`.


pq alguns membros são internos e outros privados? Isso está inconsistente para o que precisamos.


:warning: :warning: :warning:

Prestar mais atenção na convenção de nomes e nos modificadores de acesso!

:-1:


Remove this blank line.


`setq` can be smarter: `(setq var1 val1 var2 val2...)`


Added In Mod.calss php Language tags, because, the module switch not worked I also made changes in Mod php and added language tag in english lanf  .REMOVE.


new to github, do you have a link to the dev branch?


On the other hand... maybe I'll just leave it this way and just rethink the definition of `supportsBackend()`. In this case `backend == Backend.None || backend == Backend.Java` would mean "supports Java but won't complain if no implementation is found".


This can be squashed with the previous commit


It's something that was added recently. It allows you to re-use an existing connection so we don't have to establish a new one every time.

The documentation can be found here: https://github.com/kcbanner/connect-mongo#re-use-a-mongoose-connection


That might contradict with the force RGB Range, right? E.g. you will already use color information here?
RGB_RANGE = Full, but driver will "scale" to limited via nominal_range

The ZeroMemory I though correct at the beginning to start from a defined state?


With MPEG-1 audio
![stats](https://cloud.githubusercontent.com/assets/1126053/7935924/03d11e42-0935-11e5-9eeb-b0058659309b.png)
With EAC-3 audio
![stats2](https://cloud.githubusercontent.com/assets/1126053/7935928/06b41858-0935-11e5-9c16-fbbbf78dc9ec.png)


probably the same about outerClasses.isEmpty and outerClasses.size() > 1 which are a bit redundant


for sake of clarity I would change !isInnerInnerClass to isFirstParentStatic:
  private boolean isFirstParentStatic(Deque<Symbol> outerClasses, Symbol.TypeSymbol symbol) {
    // root class is implicitly static
    if (outerClasses.size() > 1) {
      return true;
    }
    for (Symbol outerClass : outerClasses) {
      if (outerClass.isStatic()) {
        return true;
      }
    }
    return false;
  }

and for sake of performance I would reorder the condition to check the easy one first:
  if (!symbol.isStatic() && !oneReference && isFirstParentStatic(outerClasses, symbol)) {


This class (and the corresponding Fake) needs a more specific name.


@Jabher That's why I asked about use of `path.sep` and normalization. If the separators have been normalized to `/` by this point then maybe that makes sense. I assume it's negligibly more performant.


reack


This, and the fact that the yeoman generator creates everything with tabs even though the included `.jshintrc` says every tab should be four spaces (drove me nuts!).  We would probably also get brownie points for updating all the required packages and fixing the glob and mongoose stuff as well, but all of this is an undertaking that will take a few hours.


Not sure what you mean about `f.id`? You mean it would then be accessible if we returned `ws`?

I noticed in #5 you were returning `ws` in and `rs` in the other - seems a little odd? I can see the use for returning `ws` in fromFile, but I'm not sure why you wanted to return `rs` in toFile. Do we want toFile to return anything at all? Once we get this figured out I'll cut the 1.0.0 release.


Thanks. Now I need to revise my assumptions, it will take some time. The lack of clear documentation is killing me :(


I think it is common practice in Bash to write variable names in caps lock. And if you change it I would make it in a different commit.


I would overall do this like:

1. See if we are in a comment.
2. See if we are at the end of a word, a space or newline follows.
3. See if comment starts with "(LANGUAGE|OPTIONS)[[space]]*".
4. Grab the word before point as it (word = up to previous space).
5. Use that as complete prefix if long enough.

That skips a lot of interpretation, ignores all options between LANGUAGE and current word, ignores if it has dashes or not. But supports multiline LANGUAGE pragmas, those happen often.

What do you think?


Maybe that fix the dual sim...


@kmike According to https://tools.ietf.org/html/rfc6265#section-5.1.4 cookies set by `http://localhost/something?foo=bar` and `http://localhost` are different. So we `splash:delete_cookies{url="http://localhost"}` should not delete them. So I think the Qt5 behavior is the correct behavior and just fixing the test should be enough.


Great. Can move ExUnit.ProxyIO to ProxyIO (i.e. lib/elixir/lib/proxy_io.ex)
as well.

On 2 June 2015 at 13:00, Aleksei Magusev <notifications@github.com> wrote:

> @fishcakez <https://github.com/fishcakez> thanks, will address your
> comments in the separate commit to keep history for a while.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lexmag/elixir/commit/fcec453e0fa7d1d8af85ff9e2daa40d8cb689e8c#commitcomment-11474126>
> .
>


I don't see any test happening there, did I missed them ?


oups....
Thanks for this. I will update.

These kind of things happen when the design is poor and we insert numbers in quotes as chars instead of numeric. :angry:


This is really not elegant solution, how many times the code open & read SYS_POWER_STATE_PATH?

It would be better to add one function to read all the supported sysfs modes to zero terminated array and keep the array in the control struct and use is always when you need it.

BTW, in include/strv.h we have nice functions for zero terminated arrays. All you need is to read SYS_POWER_STATE_PATH to memory and then split it by strv_split() to array.


I want the last instance to be created with same delay - the other 2 members form own cluster in mean time


:tada:


These can be moved into the constructor.


:8ball:  :+1:


Sure, that's my thoughts after our chat in the IRC, all that stuff are generic building blocks.


This code will be called before every test suite. Since you may be adding tests that do not require this, it would be better to move this to the test suite itself.


%현미 -> 50%현미


Because it will be called multiple times for different keys and we don't want to send multiple queries and reevaluate the same tings over and over again.


Yes. The ninja output file is always `build.ninja` and it is always for a single target. This handles what I believe is the most common case (by far) - using ninja for fast turn-around times for a single target.


Perfect @jonatasoliveira!! Thank you for the observation. I fixed this issue using only status code 400 (Client Bad Request) for any problem with vote. I think that is semantically correct and we can get what we need. You can see here: https://github.com/cacarrara/speakerfight/commit/968645b097e30a29a0a63fb8ec37b25a7aa7a46e


Does this test successfully pass and can you make it fail?


This constructor is a little dangerous because it invites a hard to debug error: calling ```Hyperplane(normal_vec, center)``` instead of the correct version.
You can prevent this kind of error by creating more types:
```
typedef std::vector<NumberType> Vector;
typedef std::vector<NumberType> Point;
...
Hyperplane(const Point& center, const Vector& normal_vec)


hi, in archive.php and content-single.php , there is a code 'thumbnail'. Do I have to set a featured image in a post in order for the archive to show that featured image as a post thumbnail in Archive?


Cool, thanks


Remove this file?


c9.io has a help article on how to set up Mongod - basically you go up one directory and run a shell script they provide.  I can show you later


I've refactored your test a bit. Not sure if this runs or not, but consider doing something like this to clean up the code.

`describe('media header tests', function () {
  'use strict';
  var headerView, content, page, header;

  beforeEach(function (done) {
    this.timeout(10000);

    require(['cs!modules/media/header/header', 'cs!models/content', 'cs!models/contents/page'], function (Header, Content, Page) {
      headerView = new Header();
      content = new Content();
      page = new Page();
      done();
    });
  });
  describe('title update test', function () {
    it('should include the title and page name in title when updateTitle is called', function () {
      content.set('title', 'Book title');
      page.set('title', 'Page title');
      content.set('currentPage', page);
      header = headerView({'model': content});
      header.updateTitle();
      header.pageTitle.should.equal('Book - Chapter');
    });
    it('should automatically call updateTitle when currentPage changes', function () {
      content.set('title', 'Book');
      page.set('title', 'New Chapter');
      content.set('currentPage', page);
      header.pageTitle.should.equal('Book - New Chapter');
    });
  });
});`


Objects of this class represent mappings from Hosts to their Addresses. It is just data. Thats why it is also Serializable. NodeAddressResolver would be a good name for a service class, not value class.


Here and in the following, you copy ```normal_vec``` instead of passing a reference. This is needlessly expensive.
The constructor should be
```
Hyperplane(const vec2& normal_vec) : ...
```


No this function cannot be moved to MultiDataGet since it is generic. This is the implementation which uses Activity.class


This result in an error, when my satis wants to get the new master:

[RuntimeException]
  Could not load package monolog/monolog in https://packagist.org: [UnexpectedValueException] Could not parse version constraint >=0.90 <3.0: Invalid version string "0.90 <3.0"

I think a , is missing between the two versions.


I'd do `a dict) and` instead of `a dict.). And`


I don't understand this:
<!-- replaced <i...> with <span...> as CSS should be used instead of presentational HTML5 elements -->
You've just replaced one presentational HTML5 element with another, and solved nothing. In HTML5 <i> no longer has any more semantic meaning than <span> so why change it?

Also, I *really* don't understand this:
<!-- <label elements should not be wrapped around form controls -->
Why not? It's a perfectly valid construct in HTML5 and allows the label element to be used as a container, which allows it to be styled in place of a <div>. Which reduces the signal to noise ratio for SEO purposes. It also (though not in this case) allows you to dispense with IDs on form field elements which is a massive benefit in performance and page weight when you're generating forms dynamically.


Makes sense. I've done that, and also used the gl_info struct to avoid redundant checks for every texture created.


this is weird.. the index is not the same for pager


`bear` instead of `x` improves understandability IMO


it makes sense to move in to a common place, such as master.buildbot.utils.deferred.py


No, we can't use KeyFMap because it's a map from Key to the value type of the key. RecordHandler is not a value type of any key.


@kmike I was mostly referring to
```
 	3352	    QWebPage page;
 	3353	    QWebFrame* frame = page.mainFrame();
 	3354	    QCOMPARE(frame->url(), QUrl());
 	3355	    QCOMPARE(frame->requestedUrl(), QUrl());
 	3356	    QCOMPARE(frame->baseUrl(), QUrl());
```
The default url is an empty url unless you explicitly load an invalid url.


Awesome. Added to `fs-extra`: https://github.com/jprichardson/node-fs-extra/commit/f2c2c586dda96a72b5c0bae85f38cf8b82850690 Thanks :)


:+1:
I will be disappointed if the README ever has an image without a good TV show reference...


Cuidar indentação e convenção de nomes (PascalCase). Se você olhar o enunciado do exercício vai ver que o enum especificado é diferente. Além de que COZINHA NATURAL não funciona dentro de um enum!


MetricsStorageBase ?
StorageMetricsBase ?

(nothings tell there is a db behind, it can be a hadoop :) )


Your satis just has a very old composer version, run a composer update
in there and you should be fine.


this should be true just to the player


@andreastoermer update your Satis to the latest version (and run ``composer install`` to get the uptodate deps in your Satis install)


ah - so the current mean.js creates two connections (or pools). 1) one for sessions and 2) another for mongoose?


TeamCity YaccConstructor :: YC.Core General Build [Build 418](http://teamcity.codebetter.com/viewLog.html?buildId=192596&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


this tests that reconfiguration doesn't fail. There is indeed no "assert" statements. But I don't know which one we can add. Just ensure it doesn't raise


Shouldn't this cover rabbitmq, too?

Also, prefer removing code completely over commenting it out.


This is incorrect. When you initialize ```list```, it already has ```steps``` entries that are all default-initialized to zero; here you append additional elements, so that in the end ```list``` has length ```2*steps```.

What you want is to reserve space for ```list```, not construct it:
```
std::vector<vec2> list;
list.reserve(steps);
```


Fix arrow positions


J'avoue c'est utile :+1:


where it says  lua/pac3/editor/client/panels/properties.lua

you have to make folders in lua called pac3 in that editor,ect and then you made the panels folder you make a text and copy to code into it, and save it as Proprieties.lua


It makes sense, thanks for the pointer.


Wow - will remove..


Faltou a inclusão para `System.ComponentModel`


There is also another error: You should reflect a _fixed_ point in all the hyperplanes, and then repeat. You just reflect the image of the last reflection!


yes, of course, that should be removed. Updated.


why not simply set `display: block`? That makes much more sense IMHO then the combination of `@include inline-block` and `width: 100%`


Note for the future: there are some places, where we need to keep ```==``` but not ```===```. For example, if we translate SQLish ```=``` in to the JavaScript code. BTW: AlaSQL supports three equality statemens:
* ```=``` - like JS ```==```
* ```==``` like JS ```===```
* ```===``` like deepEqual()


Ok - thx for the clarification. Also interesting in this aspect:

http://www.cnx-software.com/2013/05/07/vivante-gc4000-is-the-best-mobile-gpu-when-it-comes-to-accuracy/

Mali might suck :D


Cuidar convenção de nomes (PascalCase)


again, ```const &```


This can just be ```Universe() {}```, the ```std::vector``` will get default-initialized anyway


looks good!


:warning: :warning: :warning:

1. Prestar mais atenção com os erros de compilação do Visual Studio (**sempre compile o projeto antes de commitar**, utilize Ctrl+Shift+B para isso)
2. Prestar mais atenção na convenção de nomes (PascalCase)

:-1:


unnecessary, because ```x``` and ```y``` get default-initialized anyway. This is an advantage of c++ over c


Great work, very useful!


@erikrozendaal how this method is supposed to be used?
in the doc of this file the example still refer to given_events.
Could you please explain?


I actually prefer to have the constructors in the ```.h``` file, that way everybody knows about them without having to look in the implementation


TeamCity YaccConstructor :: YC.Core General Build [Build 418](http://teamcity.codebetter.com/viewLog.html?buildId=192596&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: Building ..\src\YC.SDK.sln failed with exitcode 1. Build time: 00:06:53


This is non-standard and nonportable! Please don't do this in your very first program!!


@rec Given a `style` (`unity` or `classic`), `toolchain` (`clang`, `gcc`, `msvc`) and variant (`debug`, `release`) should I build a ninja file for the `target` (`gcc.debug`, `gcc.debug.nounity`, etc).

The logic here splits up the target into its components and compares the components to the given input params. Make sense?


Any version after 5.5.1.2, breaks my Abide live validation. What changed?


@AndreeaDora Two things here. It might dangerous if VG_HOME is not set and we get a `NULL` value out of `getenv()`. I think we should investigate how to handle such errors (perhaps exception handling or just checking for `NULL` value. Eventually we could have a singleton object that will verify these environment variables on Verigreen load (or at a certain frequency) and hold them in its attributes. You can then query that object from other objects to get that value. You could use Spring's dependency injection mechanisms to make this more elegant and avoid having to pass objects around in the constructors.


The way I see it, mpc-hc forces audio renderer into "pseudo live" mode by its manual flush. The graph tells audio renderer that it should do proper lazy clock matching based around timestamps and graph clock. But that manual flush puts the renderer into situation when it doesn't have enough samples do that and plays just what it got. Hence the "pseudo live" mode. Proper clock matching with big buffers probably won't work anyway because of mpc-hc's unique way of channel switching, timestamps will be wrong anyway. It's sad :(


Cuidar com a convenção de nomes (PascalCase). Olha como foi solicitado no exercício!


Thanks


Yes; you should test it. What happens is the following:
- first `gcode_M600()` is called
- then the `while (!lcd_clicked() && change_filament)` loop is entered
- `manage_inactivity(true)` is called during every iteration
- looking inside `manage_inactivity(bool ignore_stepper_queue/*=false*/)` we see `if (commands_in_queue < BUFSIZE - 1) get_command();` which should always be the case since we removed `M600` from the buffer
- `get_command()` is where we find the `if (strcmp(command, "M601") == 0) change_filament = false;`statement which allows us to escape the loop


I have completed the README with the magical field which require changes.


@AndreeaDora what would happen if `VerigreenNeededLogic.history` is `NULL`? Could you investigate how `JSONObject` handles these error scenarios?


Corresponding modulefile on envinf1 (`/global/apps/modulefiles/lis/1.5.54_gcc-4.8.1-3`):

```
#%Module1.0

module-whatis "http://www.ssisc.org/lis/"
conflict lis

set		    lis	/global/apps/lis/1.5.54_gcc-4.8.1-3

prepend-path PATH $lis/bin
prepend-path LD_LIBRARY_PATH $lis/lib
prepend-path -d " " LDFLAGS -L$lis/lib
prepend-path -d " " CPPFLAGS -I$lis/include
setenv       LIS_ROOT_DIR $lis
```


Cuida que restaurante tem outros relacionamentos descritos lá no diagrama (Contato e Localizacao)


Ok, You are right, it's not possible without strange casts.


@AndreeaDora same as above.


left out the "Not"


Where to find this change?
not on Carbon git where I pick this


s/enable/enabling/


TeamCity YaccConstructor :: YC.Core General Build [Build 419](http://teamcity.codebetter.com/viewLog.html?buildId=192599&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


I see why we don't want to minify the non-vendor bundle in development, but why not in production?


de si nejm. jebali me ovi. boli me vugla sad


@AndreeaDora same as above


manually merged this patch now, thanks!


@AndreeaDora Check error handling here as well.


Hi! If you manage to build the engine on Windows we can put together a new release with a proper download for Windows. (See the last news entry on the SLUDGE homepage.)


Don't commit LOGDIR and CONFDIR


Good point.

If we at some point can make a test that tests that funcitonality I can refactor src .js files and test if I introduced any problems...


+1 good job neil


It would seem that this recommendation dates back to 2011, and by 2012 was obsolete?
This batch of tests from 2012 would seem to indicate that browsers now correctly expose the label text via the accessibility API with wrapped labels http://www.html5accessibility.com/tests/form-labels.html


Can't this be done in the InvenioLoader init (first parameter is the Celery app)?


Well I guess I will bring back original clock marching implementation and tweak it to work with really small buffers and sudden flushes. Hopefully it will satisfy everyone.

That's for the feedback, will bug you again in a few days ;)


This commit seems to be a duplicate of 767cac47de1dbd6dd6dd1975c66873dadbf64441.

767cac47de1dbd6dd6dd1975c66873dadbf64441 is already merged into develop and release.
Is this intentional ?


@AndreeaDora Could you make the message more explicit. Something like: `"Failed creating json file: /path/to/history.json"`


This was actually a copy & paste error. Will fix now.


I'm not sure you should be using ``invenio.base.config`` here. It's only default values and not the user configured ones.


The following should be deleted from sai.h:
SAI_API_QOS              = 11,  /* sai_qos_api_t */


Wait, do we really want to have this behavior? Having `b1 == b1` but `!b1.equals(b1)` sounds very bad. I think that `scalac` did the right thing here by always overriding `equals` and `hashCode`. This should not block this pull request, but I can prepare a separate pull request to fix that.


Shouldn't this one go into `FEATURES`?  I don't really have an opinion on this, I just noticed that `ENABLE_OAUTH2_PROVIDER` is in `FEATURES`.


Nice.


:joy::joy::joy:


TeamCity YaccConstructor :: YC.Core General Build [Build 419](http://teamcity.codebetter.com/viewLog.html?buildId=192599&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: Building ..\src\YC.SDK.sln failed with exitcode 1. Build time: 00:09:08


I suppose I felt there must be a reason I used inline-block int he first place


Now I remember, it wasn't a copy & paste error. The task above this minifies the vendor bundle, then this task generates a non-minified bundle for the primary application. I did this in case we need to debug/troubleshoot the application in production.


@ChrisRus No, A quick look up of the [visitor pattern][1] vs the [template pattern][2] shows that the two are different. I believe that this commit is describing the [template pattern][2] more then the [visitor pattern][1].

> In software engineering, the template method pattern is a behavioral design pattern that defines the program skeleton of an algorithm in a method, called template method, which defers some steps to subclasses. It lets one redefine certain steps of an algorithm without changing the algorithm's structure. This use of "template" is unrelated to C++ templates.

[1]: http://en.wikipedia.org/wiki/Visitor_pattern
[2]: http://en.wikipedia.org/wiki/Template_method_pattern


@AndreeaDora From what I understand here, you are
- Pointing to the `/history.json` file to write to.
- Retrieving the `history` and creating a `JSON` object of it.
- Then writing that new history to the `/history.json` file.
So this is basically *overwriting* the `history.json` not really cleaning it up. Not sure that `HistoryCleanerJob` is the correct name for this class. Either we change it to something like `UpdateHistoryJob` or we simply cleanup the history **only** and then have another job that writes it. These would need to go serialized so that you dont have a locking problem on the file.


MSDN says that RGB_Range applied only to RGB output while the YCbCr_ members applied to YCbCr output (https://msdn.microsoft.com/en-us/library/windows/desktop/hh447654(v=vs.85).aspx) I think this also holds for input. all inputs are YCbCr. this is copying behavior of DXVA-HD implementation in master. One question which I have is what to do with Nominal_Range? MSDN says nothing about it. so I defined it as driver default.

As for ZeroMemory it isn't irrelevant because we define all members of struct except one which is not used by dx.


Had to run the bundle script twice because there's no way to minify 1 bundle but not the rest in a single command.


TeamCity YaccConstructor :: YC.Core General Build [Build 420](http://teamcity.codebetter.com/viewLog.html?buildId=192600&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


That's not the only build error for the public version. In a sprint to release so all focus was on the private source. I'll get the public branch building this week sometime


So we're leaving this alone, correct @Kureev ?


Because otherwise the serializer fails on the passed in functions. Could also be done by giving sensor type a serialize function and handle the special stuff there?


Hi yes we spotted that. Should we remove the prefix?


@Kureev do you want me to move this out of return?


@AndreeaDora It would good to consider for future improvements, to have these jobs be configurable from the `config.properties`. For instance to have the history cleaned once a day and the cache every hour.


Would you like a separate file? Or just down at the bottom of index.js?


Congratulations, the generalization of StormDanger and ShelterWeakness must by now have given some serious ELO.


@AndreeaDora  Add newline.


yes, take a look here:
https://github.com/rspec/rspec-rails/blob/master/lib/generators/rspec/model/templates/model_spec.rb

This is the latest version of rspec generated file.


Thanks @Kureev. Awesome Job @skevy :+1:


The irony is that zanata generates that xml file, which the zanata python client then complains about.

I posted a bug: https://bugzilla.redhat.com/show_bug.cgi?id=1227325.

If zanata the server is doing the wrong thing, we should fix this. But if it is zanata the client that is wrong, we should probably leave it alone.


Does this need to be random?  I'm thinking it would be better to just bake in some values that span negatives, positives, and zeros.

Ditto for confidence at line 208 below.


@morelj Nice work! Can you create a pull request for this? I'll merge it into the library.


tab ff netjes


comments weg


done


Yep, it's in.


@rec A flag is intercepted by `scons`, so we'd have to figure out how to hijack the flags before scons gets to them. I don't think we want to go down that route. Chromium implemented this as `build_ninja=build_file`, but since we almost always want this in the default file `ninja` will use, `build.ninja` I just used `ninja=1`.

I tried making it a target makes sense, but I chose the "easy code" route over the "nice interface" route for two reasons: 1) Adding ninja support needs to be a quick effort or it isn't worth putting in, and 2) I want to make a minimal impact to the existing sconstruct file.


removed


`Expected these nodes to be exercised, but they were not: [...]`?


I take it that this is a javascript `Array`. You could use `push()` to avoid having to use the index `i` to add elements.


had you try it ? is it work ?


We should make sure the ``reconfigServiceWithBuildbotConfig`` method is doing what it's suposed to do, exerce every if, for, ... In that case, at least looking inside the registeredArray would improve the situation. Hint:There is a lot more that can be tested ;)


...but an honest man :hocho: :smile:


Hmmm... Not sure if the reference is available if you use `var exports = module.exports = {};`. Maybe you are right.


Actually i was thinking about this a bit. What about a filter "item" that when right clicked gives you a gui that you can put items into. Then you use that on the item coil instead of the item directly.

You could even have different types of filter items so you could have an "include filter", "exclude filter", an "ignore metadata" filter, etc.


Yes. Same machine in same network works with version 2.15.0 fine. I'll open an issue ...


I added an eslint-disable-lint annotation on two lines, so perhaps that is
why you're seeing no error?
https://github.com/wincent/corpus/commit/4f37e724ab11b882b3ae4fd0a264b67c597cc8f5
The usage here is occurring inside a type alias (`type Operation = () =>
Promise`).

On Tue, Jun 2, 2015 at 5:17 AM Henry Zhu <notifications@github.com> wrote:

> @wincent <https://github.com/wincent> I saw your commit reference - I
> remember specifically testing something like this so it's odd that it's
> still giving you an error? Also, I just downloaded the repo and removed the
> these comments and am not getting the error.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wincent/corpus/commit/4f37e724ab11b882b3ae4fd0a264b67c597cc8f5#commitcomment-11474365>
> .
>


@ebrehault your commit broke the 5.0 build: http://jenkins.plone.org/job/plone-5.0-python-2.7/1347/changes#665ef6522a75e26efbd9c9f2f28160e8c0dbfb82

Please fix or revert commit.


Haha, yes. This can basically be chalked up to a n00bie emax mistake. :dancer:


FYI, I think this has broken the acl2(r) build.

In particular, `books/rtl/rel11/support/basic.lisp` now seems to be failing with:

```
10:05:22    | *** Key checkpoint before reverting to proof by induction: ***
10:05:22    |
10:05:22    | Goal'
10:05:22    | (IMPLIES (AND (RATIONALP X)
10:05:22    |               (ACL2-NUMBERP Y)
10:05:22    |               (REALP (* X (/ Y))))
10:05:22    |          (RATIONALP (MOD X Y)))
10:05:22    |
10:05:22    | ACL2 Error in ( DEFTHM RATIONALP-MOD ...):  See :DOC failure.
10:05:22    |
10:05:22    | ******** FAILED ********
10:05:22    |
10:05:22    | Summary
10:05:22    | Form:  (CERTIFY-BOOK "basic" ...)
```


as I understood from the wiki pure-lua type Body is serializable, but when unserializing it crashes when I serialized the body and not the systempath


Does it not work on your system? Then it may be a Linux problem...
Your sql file had cryptic stuff like "¤Å" or so. I made "ß, ä..." out of it
and it works on my system (Windows 8.1).
I can't debug that here since I don't have Linux.

On 2 June 2015 at 01:06, Jonas Gröger <notifications@github.com> wrote:

> Wo is da der Unterschied? :O
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JOBAA/amos-ss15-proj4/commit/2b77d48783363c178747af7ace655006b23aacd7#commitcomment-11465088>
> .
>


what is the change ? it looks like that your tab indentation still using tabs. please change it to spaces, I prefer 4 spaces.

see this https://github.com/semplon/GeniXCMS/blob/master/CONTRIBUTING.md#coding-standard


@tobihan Yep, that's the plan :) Right now we're focused on preparing the binaries for our game (they're slightly patched with minor, but non-generic stuff, like changed behavior of window close event), but when we're done we can build the vanilla SLUDGE as well and contribute the downloads.

We already got working engine on Windows, and I hope to be able to build OS X one somewhere next week.


do you think its feasible to construct some data flow patterns like the diagram i created. to model the control loops and bags (which are essentially a prioritized kind of buffer) with camel but also represented as a graph so that when nodes and edges are changed the camel topology changes. then we can implement the entire system as interlinked processing elements and apply queing theory and how this graph can be efficiently partitioned across expanses of i/o busses and networks.


@adamschoenemann spelling error.


not sure where you can find it BUT it's in systemui/res/layout/heads_up

The drawable there is set to heads_up_scrim and needs to be the images pulled in the commit instead


TeamCity LabkeyTrunk :: CDS postgres 9.3 [Build 41](https://teamcity.labkey.org/viewLog.html?buildId=253110&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 25 Build time: 00:32:12
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


Unfortunately, I can't test my stuff on the course console.
CiscoVPN doesn't work...

On 2 June 2015 at 15:25, Benedikt Rauh <bene.rauh@gmail.com> wrote:

> Does it not work on your system? Then it may be a Linux problem...
> Your sql file had cryptic stuff like "¤Å" or so. I made "ß, ä..." out of
> it and it works on my system (Windows 8.1).
> I can't debug that here since I don't have Linux.
>
> On 2 June 2015 at 01:06, Jonas Gröger <notifications@github.com> wrote:
>
>> Wo is da der Unterschied? :O
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/JOBAA/amos-ss15-proj4/commit/2b77d48783363c178747af7ace655006b23aacd7#commitcomment-11465088>
>> .
>>
>
>


I just added the test352. Will merge it tonight.


good


1: M111 unrecognized component name: docker


TeamCity YaccConstructor :: YC.Core General Build [Build 420](http://teamcity.codebetter.com/viewLog.html?buildId=192600&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: NUnit test failed (6).   at Fake.NUnitSequential.NUnit(FSharpFunc`2 setParams, IEnumerable`1 assemblies)   at FSI_0002.Core.commonConfig@178-12.Invoke(Unit arg10@) in Z:\Builds\work\4138ce7c6332a78c\tools\Build.Tools\Core.fsx:line 1... Build time: 00:11:40
### Failed tests
```
CYKGeneratorTests+CYK generator tests.Simple one rule term with lable without weight test: <no details avaliable>

CYKGeneratorTests+CYK generator tests.Simple one rule term without lable code gen test: <no details avaliable>

CYKGeneratorTests+CYK generator tests.Simple one rule term without lable code gen to file test: <no details avaliable>

CYKGeneratorTests+CYK generator tests.Simple one rule term without lable test: <no details avaliable>

CYKGeneratorTests+CYK generator tests.Simple one rule with lable without weight test: <no details avaliable>

CYKGeneratorTests+CYK generator tests.Simple one rule without lable test: <no details avaliable>

```


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


32: D101 Missing docstring in public class
36: D203 1 blank line required before class docstring (found 0)
36: D204 1 blank line required after class docstring (found 0)
36: D400 First line should end with a period (not 'o')
36: D205 1 blank line required between summary line and description (found 0)
41: D102 Missing docstring in public method
65: D102 Missing docstring in public method
68: D102 Missing docstring in public method
72: D203 1 blank line required before class docstring (found 0)
72: D204 1 blank line required after class docstring (found 0)
72: D400 First line should end with a period (not 'd')
72: D200 One-line docstring should fit on one line with quotes (found 3)
78: D102 Missing docstring in public method
82: D210 No whitespaces allowed surrounding docstring text
82: D400 First line should end with a period (not 'h')
92: D210 No whitespaces allowed surrounding docstring text
92: D400 First line should end with a period (not 'e')
96: D210 No whitespaces allowed surrounding docstring text
96: D400 First line should end with a period (not 'e')
125: D210 No whitespaces allowed surrounding docstring text
125: D400 First line should end with a period (not 'e')
132: D210 No whitespaces allowed surrounding docstring text
132: D400 First line should end with a period (not 'e')
139: D210 No whitespaces allowed surrounding docstring text
139: D400 First line should end with a period (not 'e')
146: D210 No whitespaces allowed surrounding docstring text
146: D400 First line should end with a period (not 'e')
153: D203 1 blank line required before class docstring (found 0)
153: D204 1 blank line required after class docstring (found 0)
153: D400 First line should end with a period (not 'a')
153: D205 1 blank line required between summary line and description (found 0)
158: D102 Missing docstring in public method
165: D203 1 blank line required before class docstring (found 0)
165: D400 First line should end with a period (not 'e')
165: D205 1 blank line required between summary line and description (found 0)
171: D102 Missing docstring in public method
178: D102 Missing docstring in public method


37: D103 Missing docstring in public function
47:13: E121 continuation line under-indented for hanging indent


1: M100 needs more reviewers
1: M101 signature is missing


(Whoops, I replied via email so I didn't see that you were already commenting on the commit I linked to...)

I'll double check this when I get back o my computer.


30:1: I201 Missing newline before sections or imports.
31:1: I100 Imports statements are in the wrong order. import logging should be before from six
31:1: I201 Missing newline before sections or imports.
33:1: I201 Missing newline before sections or imports.
34:1: I101 Imported names are in the wrong order. Should be current_app, has_app_context
34:1: I100 Imports statements are in the wrong order. from flask should be before import six
34:1: I201 Missing newline before sections or imports.
35:1: I100 Imports statements are in the wrong order. from functools should be before from flask
35:1: I201 Missing newline before sections or imports.
35:1: F401 'wraps' imported but unused
36:1: I101 Imported names are in the wrong order. Should be find_modules, import_string
36:1: I201 Missing newline before sections or imports.
111:13: B901 blind except: statement
224:1: E302 expected 2 blank lines, found 1
228: D102 Missing docstring in public method
231: D102 Missing docstring in public method
239: D102 Missing docstring in public method
242: D102 Missing docstring in public method
246: D401 First line should be in imperative mood ('Run', not 'Runs')
298:23: E222 multiple spaces after operator


44:32: E711 comparison to None should be 'if cond is not None:'
67: D103 Missing docstring in public function


1: D100 Missing docstring in public module


24:1: I100 Imports statements are in the wrong order. from flask should be before import six
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I101 Imported names are in the wrong order. Should be MultipleResultsFound, NoResultFound
28:1: I201 Missing newline before sections or imports.
30:1: I100 Imports statements are in the wrong order. from invenio.base.utils should be before from werkzeug.utils
31:1: I100 Imports statements are in the wrong order. from invenio.base.helpers should be before from invenio.base.utils
34:1: I101 Imported names are in the wrong order. Should be SmartDict, SmartJson
35:1: I100 Imports statements are in the wrong order. from invenio.modules.jsonalchemy.errors should be before from invenio.modules.jsonalchemy.wrappers
41: D101 Missing docstring in public class
44: D102 Missing docstring in public method
71: D102 Missing docstring in public method
74: D102 Missing docstring in public method
80: D103 Missing docstring in public function
255:33: W503 line break before binary operator
256:33: W503 line break before binary operator


42:1: W391 blank line at end of file


Well, I took it to mean that it can load native decls from Java but not JS, which is precisely the case. And the `ModuleManager` requires this to load those native imports, that are required for ceylondoc to run on the SDK.


There should either be a ~ at the beginning of the string, or the 'n' should be taken out.  Most likely the latter.


Android开发 - 匿名聊天App


done.


Thanks for your tests Mindbreaker !
I would be surprised that +24 instead of +20 would make a difference, but who knows ?
Will wait to see your results.

Meanwhile I started some tuning starting at +22, but using the latest master.
Tuning 4000 games @ 1s +0.06 gave the following PSQT values for RANK_1, middlegame.:
Knight -120, -72 -59 -51
Bishop -29, -3, -15, -27

And for MinorBehindPawn[2] tuned for Bishop or Knight (and without rank_1 of course) I get
Knight: 19
Bishop:15


I think @SamSaffron reverted this because he fixed it properly in d459cb95dc817f706c5ad514bca4fa007f707976 and 0fd1974838ad8147593cc90a910b15745d1ffb2a


Yeah, I'm not a huge fan of using them either, I just wondered how easy it would be to replicate it in shader form were it to be removed. But like I said, I don't think burdening the plugin with OpenMP just for the one filter is really worth it either, so it's not a big deal to me either way.


Need add handling for (error.code == JSSessionExpiredErrorCode), because JMReportLoaderErrorTypeAuthentification used in visualize report loader only.


Oi, obrigada pelas correções.
Eu achei que o enum tinha que ser maiúsculo mesmo.
E os outros erros foi total falta de atenção, nem tinha criado o projeto na solution... :(


Published to http://ui.edev.d2l.com/65_ec032d0c1ab82e63e900b3ecd8116e9cfa1a8617


Could do — though we'd need to exempt the index action. Is there an existing pattern for that?

Since there's no destroy action planned I might leave it til the 3rd duplication.


The general convention is that "secret key" is used for symmetric crypto, and "private" is asymmetric. This seems like it should be private, right?


I believe the change from abide 5.5.1 to abide 5.5.2, broke live validation. At least it did for me.


Looks good to me.


done


Sorry for spamming you - but this is really interesting as it covers the exact same issue we see on mali:

http://community.arm.com/groups/arm-mali-graphics/blog/2011/09/06/at-home-on-the-range--why-floating-point-formats-matter-in-graphics


Is it weird/funny that I didn't even see the "UrbanSpoon is now Zomato" notification at the top of any of the pages I've looked at?


Nice catch. Vamos ver se será aceite. 🎈


Since this is the first time the package is being added to the Package Control repository, so the key "previous_names" is not required.


Eh, perhaps the convention isn't as strong as I thought it was. Feel free to disregard :smile:


Should the guess result be cached in a property? I *think* that would make the method slightly faster.


Hi. Is there is any reason why we can't specify just libboost-chrono-dev on 34 line of /CMakeLists.txt?


@ShawnieBoy, thanks for implementing this card, it's a bit of a classic. I had given it a look before and became concerned about a situation where both players would be reduced to below zero life, which should normally result in a draw. Because this deals different amounts of damage due to the rounding damage detail, I didn't manage to do it with getAPNAP which would allow the damage to be simultaneous (like Shepherd of Rot's life loss, for example).

Don't mean this as criticism at all, just sharing because I had given this particular card a bit of thought previously. I think some cards could use some kind of method that allows two actions to be performed simultaneously. This is already available in Magarena, since the APNAP cards allow simultaneous actions. Anyway, draws are being treated differently in Magarena (well, they don't exist) so I don't know if any of these comments makes sense. A few cards like Banshee, Shepherd of Rot or Skirk Fire Marshall can deal a lot of damage to both players at the same time which is known for leading to a high number of draws, so for those cards this can be a relevant question?


Probably yes. But it is static, it has no context. So registering a new factory/unregistering one should reset the cache, shouldn't it?


okay that is good


I think it should be checked whether the package type is a cmake package and if the build type isn't already set, or is this node automatically by setting "stable"

```ruby
Autobuild::Package.each do |name, pkg|
    if pkg.kind_of?(Autobuild::CMake) and !pkg.defines.has_key?('CMAKE_BUILD_TYPE')
        pkg.define "CMAKE_BUILD_TYPE", "Release"
    end
end
```


@mihairaulea please do not commit this file with your local path


Why this move back to 1.8.3-SNAPSHOT ?
Given the huge set of changes, including incompatible ones, such as removing the org.apache.felix.scr package, I think a leap to a major version is a good thing.


Keşke Button üzerindenki ismi değiştirseydin !


Why is it static? Why can’t the Guesser be an instance (even a service that can be configured through a DIC)?


/cc @hajoeichler @mmoelli


@ Ivan19871002 : thanks! :thumbsup:


A quick test with the rookandpawnonlyopening book did not show any superiority, but cannot test much on my computer.
If you want to try it with a decent number of games, I would really appreciate.


I see no reason to reject it. Always provide detailed feedback about errors and problems, maintaining the language consistency. UX Basics, sir!


To avoid injection. Guesser should be used when no MessageFactory is injected. So if you want to configure it through a DIC, configure MessageFactory.


You can of course use a patched engine for your release if you want, but
note that it can have its advantages in the future if the game works
with the vanilla engine. For example if someone ports SLUDGE to another
platform in the future or one of your binaries does not work on a new OS
release, people can help themselves.

Of course I don't know if your changes make your game incompatible with
vanilla SLUDGE. If not, everything is fine. It might also be that the
changes you made could be included in SLUDGE in some form if they can be
made generally useful.

On 06/02/2015 03:25 PM, Sebastian Krzyszkowiak wrote:
> @tobihan <https://github.com/tobihan> Yep, that's the plan :) Right now
> we're focused on preparing the binaries for our game (they're slightly
> patched with minor, but non-generic stuff, like changed behavior of
> window close event), but when we're done we can build the vanilla SLUDGE
> as well and contribute the downloads.
>
> We already got working engine on Windows, and I hope to be able to build
> OS X one somewhere next week.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dos1/opensludge/commit/5b437295212e1cf9e737b77828bfe213faf9b76f#commitcomment-11475675>.
>


OOOPS! My bad sorry! Thanks for the fix!


See it [here](https://github.com/php-http/guzzle5-adapter/blob/internal_separation/src/Guzzle5HttpAdapter.php#L47)


No, it's not possible to add comments in the Sibelius file and have them translated to XML comments. This is specifically for the libmei API, where you can add something like:

```
comment = libmei.XMLComment('This is a comment');
libmei.addChild(someelement, comment);
```

This is in use here:

https://github.com/music-encoding/sibmei/blob/master/sibmei.plg#L1056

and elsewhere to provide some explanation of the encoding.


ack


On 02.06.2015 15:35, Steffen Planthaber wrote:
>
> I think it should be checked whether the package type is a cmake
> package and if the build type isn't already set, or is this node
> automatically by setting "stable"
>
> Autobuild::Package.eachdo|name,pkg|
>      if  pkg.kind_of?(Autobuild::CMake)and  !pkg.defines.has_key?('CMAKE_BUILD_TYPE')
>          pkg.define"CMAKE_BUILD_TYPE","Release"
>      end
> end
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rock-core/base-build_server_scripts/commit/061906c355760a38e82b81dc22a2509ba080aa1a#commitcomment-11475918>.
>
This does not work other package types, the stable tags was explicitly
introduced to have upper level instead of package specific options to
set the type. Your solution regarding the check only helps part wise,
because the package itself could enforce it, this is why this option in
general is currently only for experimental reasons. (have some side-effects)

--
  Dipl.-Inf. Matthias Goldhoorn
  Space and Underwater Robotic

  Universität Bremen
  FB 3 - Mathematik und Informatik
  AG Robotik
  Robert-Hooke-Straße 1
  28359 Bremen, Germany

  Zentrale: +49 421 178 45-6611

  Besuchsadresse der Nebengeschäftstelle:
  Robert-Hooke-Straße 5
  28359 Bremen, Germany

  Tel.:    +49 421 178 45-4193
  Empfang: +49 421 178 45-6600
  Fax:     +49 421 178 45-4150
  E-Mail:  matthias.goldhoorn@informatik.uni-bremen.de

  Weitere Informationen: http://www.informatik.uni-bremen.de/robotik


could you use `super` here?


Ich werde es mal forken, mergen und dann einen neuen PR machen, damit deine Änderungen auch dabei sind.


Makes sense. But why then are there `(un)register()` calls? Who calls those?


How to get the score? To see how many tests are passed?
But for the Atom, if you comment Test Case 1 out, some of others are right. So, is the score right?


ESAAA


I think that is more conventional, but I followed the NaCl/Sodium convention of "secret" and "public".


This breaks running when "Output directory" field is empty.


The coding looks great! Thank you for this. I'm going to make the merge and test out how it works.


teste


Hi,

I am afraid I am not very familiar with cmake. I didn't have any issues with the libboost-chrono portion of /CMakeLists.txt so I didn't change it.


Actually it is there for test purposes. ;)


True, most libs just set /usr/include/, but by far not all. The reason to simply use standard dirs is that compilers use them by default. Since we require kodi-config.cmake to be available, we don't gain anything from default include/lib paths.

consider forks: When they change APP_NAME, also their include and libdir will change.
Hardcoding kodi in addons will break those addons for them.


that test doesn't make sense, the assert will never fail because the condition in the while look will otherwise not be met


@yagop, in my opinion you should add a small section in the readme to explain how to create this files and what layout should they follow.

I updated yesterday the bot and after checking this update I tried to add this file in my `data` folder:

```lua
do local _ = {
  consumer_key = "MY-CONSUMER-KEY",
  consumer_secret = "MY-CONSUMER-SECRET-KEY",
  access_token = "MY-TELEGRAM-BOT-ACCESS-TOKEN",
  access_token_secret = "MY-TELEGRAM-BOT-ACCESS-TOKEN-SECRET"
}
return _
end
```

I've also added symlinks to the other plugin files so every twitter plugin is configured using this file, but doesn't seem to work.

The problem isn't the symlink as the `twitter` plugin is not working (and my configuration is in `data/twitter.lua`).

PS. Si quieres creo un issue para esto, de hecho estaba escribiendo en inglés porque es lo que tenía en mente... xD


finalmente alguém fez certo :pray: :pray: :pray: :pray:


Few things we need to clarify so we are on the same page. We have different modes for switching channels, including full graph rebuild. I don't see why you are saying that our channel changing logic is "unique". Demuxer exposes dozens of pins and we simply reconnect them to the one we need for current channels. Why this would be wrong? One thing we do weird is to have separate audio decoder for each audio type (we would better have one and/or remove it when not needed), but this is not the case if "rebuild always" mode is used. Manual flushes are not really a problem, because I might very well remove them for testing purposes (my tuner doesn't need them). It doesn't change a thing. Mostly because graph is flushed anyway when reconnecting.

> Proper clock matching with big buffers probably won't work anyway because of mpc-hc's unique way of channel switching, timestamps will be wrong anyway. It's sad :(

Buffer would be filled after channel is switched. Do you need to sync the very first sample?


Yuck! (But I understand. :wink:)


Rettet conditions


It's a good point - currently draws are dealt with by having the active player lose first. If I swap the damage order around, so that the activator is dealt damage first, that should solve the problem.


This method has changed since I last looked at. It now looks more like a proper clone method than it did before. I suggest we rename this method to clone. And then at the very top of the file we should add implements Cloneable.


I'd rather not have a setUp method for this test, setUp methods provide high coupling between the tests as they are shared data. In this one you initialize the queue e.g., I think it's better  to have all those methods merged in one test.

How about writing a custom LogPrinter that just prints the log message without time, color or anything and then check that with the retrieve_stdout context manager?


Sure, we're not going to break any compatibility. We just have a few hacks that won't be useful in upstream unless generalized - like triggering ESC key event when user tries to close the window, so the game handles "do you really want to quit" message and can autosave when exiting (and also actually show that dialog at all on GNU/Linux). Just little "usability" things like that, with "graceful degradation" when the same slg file is played in vanilla build.

If I find some time for it I might try to make it upstreamable later (like adding ability to define exit handler inside sludge file, so it can be still 100% compatible with old games), but that will definitely require me to learn a lot more about SLUDGE internals than I know right now :)


Hey patrik, you forgot to update the help strings. They state that the file must be in `plugins/twitter.lua` when it should be in `data/twitter.lua`.

cc/ @patschi


@mulkieran  - will zanata client regenerate this file once present in the source? If not and it keeps complaining about it maybe we ought to fix it.


@bernardobrezende Boaaaa!!!!


Typo in target name here


The only place, in anaconda, that, this method is used the result is multiplied by 1024 and converted to a Size(). Any chance of having this method just return a Size object?

Otherwise, // is probably a better choice than conversion.


Not *yet*


```
zf create model User
```


Same here.


When is is not the "default" build type, the buildserver should not use this option, the buildserver should do the default builds only.

It is ok to add the option, but it shouldn't be used to the default builds aka "rock-complete(-incremental)"

http://rock-robotics.org/status/


@ivan19871002 Thanks 😊


This bullet point is from the office manager job.


I will probably have to rewrite the guesser in a more sane way. Right now I needed it to be working, so I can simply call `guess` => done.


comment body


That's what I ended up doing. Let me see what I have.


PHPCS: Expected 1 newline after opening brace; 2 found


Fair enough! Optimisations like the one I proposed shouldn’t be done prematurely.


@yibuyisheng ，这个问题得等edp 修复了，目前比较方便的解决方案是安装0.1.2版本，麻烦点就是自己手动修改页面require的配置了


... and first week logistics for [successful applicants, candidates we hire, new joiners]?


@mishoje jebo te aleks ferguson sir


Feel free to open a PR. ;)


fast-forwarding develop to borshop-integration-1158-merge-2.0.1-release = 3fdee746


haha


Do the bullet points look right on-screen, or would a series of very-short paras work better?


a


It make sense to do this.
We may want to wrap setRole and setUnRegDate in another action that will perform the final node modify.
So there is one less hit to the DB


What about enforcing the order with the flake8 plugin I mentioned in the last PR?


@Justineo @Exodia 谢谢解答^_^


events planning vs PA-type roles?


@mikepetersonccv did you forget to uncomment this?


that comment doesn't fit anymore


@FruitieX looks like everything I did is in the `replace-irc-backend` branch. Hopefully some useful stuff in there. I did switch it to use the `irc` lib.


any info why it's best to revert? i didnt find anything...


the indentation changes slightly here.


`for (type_, token, start, end, line) in toks:` would be more readable than using things like `tok[2]` in the middle of an expression.  (Assuming Python 3 doesn't change the number of fields in the returned tuples, which would make things slightly more fun.)


Ha. It works, my problem is I was relying on a long-lived `gulp` process that was doing linting in the background. Because I failed to restart it after updating to 3.1.10 it hadn't picked up the changes. Yay.


```
zf create controller User
```


I can try it again and submit a pull-request if you'd like.


Yeah, that’s the OSS spirit! :laughing:


@kghbln 2.2.1 release; In case you want to give a test drive before making the tag.


OH FOR FUCKS SAKE


also added
 `original_user` varchar(255) NOT NULL default '' COMMENT 'This is the user that created the original record',
 `lastseq`  varchar(4) NOT NULL default '' COMMENT 'The element file should contain this number of elements for this id',
 `seq`  varchar(4)  NOT NULL default '' COMMENT 'This gives a numerical sequence for the events of this pt_tracker_id',
 `user`  varchar(255) NOT NULL default '' COMMENT 'Yhis is the user that created this element',


Annoying perfectionist polish.


uhm you only change indentation here from one valid for to another, can you just discard this unneeded change, making the commit smaller?


This line assumes a hard dependency on ot-logger. ot-logger is declared as an optional dependency.


@creeonix This middleware is meant to parse a "standard bearer token." I'm all for total customization, but I think the middleware pattern itself provides that. If we're going to start allowing customization of the parameter name, then it would be inconsistent not to allow a custom header signature, at which point we're talking about a general token parsing middleware, and not a bearer token parsing middleware. If you're not using a standard bearer token, then you should be using a different middleware, imo. I would prefer to keep that outside the scope of this package. As always, I'll defer the final decision to @stubailo and @aldeed. I think we should at least keep everything standard in this PR, or this thing will never end :)


Same here: This line assumes a hard dependency on ot-logger. ot-logger is declared as an optional dependency.


And here...


etc


I'd rather put the log_pritner as the second argument, we currently have first the contents and then the logging facilities in almost all functions I think


Sure thing.


Plone 5 robot tests are also broken since that commit: http://jenkins.plone.org/job/plone-5.0-python-2.7-robot/1364/


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/15753/testReport/) for this commit**


This is insanely helpful :+1:


implement createwithowner in poidao interface. this will remove code duplication.


This is a vicious circle indeed, and it's going to leave a lot of cool cards out of Magarena for the time being. I'm trying to figure out which part of the "circular argument" thing is the problem, so maybe you guys can have some ideas about possibly fixing it in the future.

Having a valid target is a requirement for casting targeted spells or activating targeted abilities, so that part is correct. I think the problem here is that the check is occurring before the X amount is chosen. If maybe somehow the X amount decision could come before the target availability check, this would potentially solve the problem? Just theorizing, I obviously have no idea how to do that.


+1 here too.


If I understand this correctly, your suggestion was to add it to the make file. Is that correct?


Sure, that might be a little better.


You mean like this: http://gerrit.aicp-rom.com/12280

to whom to give authorship?
same person as this patch?


verygood


This commit introduced hard dependencies on ot-logger (see line comments above). However ot-logger is now declared as an optional dependency. Preparing a PR to wrap this dependency, before we pull it out altogether.


:cry:


Funny!! also added slim recents yesterday. Also made switch for it, so we can choose between aosp and slim recents.

![screenshot_2015-06-02-02-54-53](https://cloud.githubusercontent.com/assets/10132563/7937338/d02f2380-093f-11e5-8f49-ce9210e9b609.png)


Fair enough!


Hi, I did and I've added tickets #120 and #119


Ok awesome - I'm also working on a fix for polymorphic types and `mixed` https://github.com/babel/babel-eslint/pull/118 which I guess will be just a identifier check.


50GB may be quite a high suggestion... maybe it's worth mentioning that the operating system and ISOs are stored in the root logical volume. Possibly say that the amount can be lower because that VMs are stored as logical volumes in the volume group and that there must be space available in the volume group to store them.


Hard dependency on ot-logger, ot-logger is declared as an optional dependency.


Capitalized H in sentence


indentation off? Or just github not showing this right?


Could you use a wildcard, otherwise this documentation will need updating for every release and can't be kept up-to-date


This commit introduced a hard dependency on ot-logger in the lines marked above. Preparing a PR to wrap this dependency (thus making it truly optional, as it is declared in package.json) before we can fully remove it.


fyi, field_factory can be None here so need to do a check here.


TeamCity xBIM :: Xbim Geometry :: Release [Build 90](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=1794&buildTypeId=XBIM_XbimGeometry_Release) outcome was **FAILURE**
Summary: Exit code 1 Build time: 04:39:33


same here, I'd put the log priter to the end


yay!


typo in commit message


Hello - we've just spoken with Ben and agreed that as far as pages containing the map are concerned, we've decided to ask for revision back to the previous version which made use of full width display.


related with #6 and #4


Индекс забыл.


yes. just behind the installation of `flake8`. the rest should work automatically


This was copied from the README


This was just moved in the file


look ok to me, but could you change the name of the onfig option to something with prefix "reply_"?
I'm trying to keep some order for the growing list of config options..
How about `reply_account_header_priority` ?


Corrigido.


@ebrehault I reverted your commit: https://github.com/plone/plone.schemaeditor/commit/170766f8046e180c4957c1bc7ae45e134a818c89

I hope I did not break even more. It is a lot easier to revert commits on pull request. Also pull requests can be tested up-front before merging...


ACK


retirei o (targer), para não abrir o usuário em uma nova guia do navegador...


Except renaming copy to clone I don't have much other feedback. So I would suggest you merge this commit with the later one by Madus. And also of course rename copy to clone. Then as long as this is properly bug tested and is doing what it should we should be able to pull this into MassiveCore.


users be like:root isn't working 1!1!1!
http://forum.xda-developers.com/xiaomi-mi-3/development/rom-resurrection-remix-lp-v5-3-8-t3056711/post60441828#post60441828


we are working on s2w/d2w for sprout, and need testers. contact @agaphetos or me @thewisenerd for more details.


Nice!


right, sorry
I fix and I make a PR


that's better


@ntkoso Thanks, should be fixed now. ea7e8d2286207fdf89269f0f1398bea809d82d89


Flushing before channel switching shouldn't really pose a problem (though flushing from outside the graph is a problem in itself). Flushing after the switch may drain the buffers permanently. If mpc-hc does the former, I take back my words about "unique".

The thing I'm not sure about, is whether NewSegment commands are generated during channel switching and who makes the timestamps. If it's the demuxer who makes the timestamps, all should be fine. If it's the filters that are dynamically reconnected, that calls for a disaster. Though I would put my money on the demuxer.

All of that won't really change what I need to do now, but sorry if I sounded offensive.


The comment for this function still says:

> @ param dist The maximum search distance.
**If 0, OMAPX is used.**


这行干嘛用的？？？


This selector should probably be more specific to help prevent conflicts. Something like this:

```js
expect(element(by.attribute('br-model', modelName))
  .element(by.attribute(
    'ng-show', ['regForm', elementName, '$error', expectedErrorId].join('.')))
  .isDisplayed()).to.eventually.equal(true);
```

Would tie it more closely to the element that matches the model name. I'm not of fan of tying it to `ng-show`, but it will do for now.


Didn't find anything either... except guys tested binder commit on Shamu with Android M and reverted in later stage.


Unfortunate but needed since we **have** to unmount the components. Doing so the attach controller actually controls the lifecycle of the view we attach components to which is not great but exactly the same as what we currently have with the lifecycle managers.

Going further it might be interesting to look at attaching an "unmounter" to the view which is tied to the lifecycle of the view and will unmount the components on dealloc. Will put this up as a future RFC.


Not a huge fan of the name tbh, I'm open to propositions :)


What line?

With Best Regards

 <mailto:zabavnov@gmail.com> Vadim Zabavnov

From: Philippe Miossec [mailto:notifications@github.com]
Sent: Wednesday, May 27, 2015 8:13 AM
To: vzabavnov/git-tfs
Subject: Re: [git-tfs] #772 - add intermediate variable. make sure "force" works only on first Change set (3688007)

Could you remove this line also?

—
Reply to this email directly or view it on GitHub <https://github.com/vzabavnov/git-tfs/commit/368800707f7978e5aa04514e1c219c70f95314d5#commitcomment-11384203> .  <https://github.com/notifications/beacon/ACjG1NbvBxyvVhq0vHBToHB9PGdtbRDTks5oNawzgaJpZM4Erze0.gif>


ich guck mal ob ich die finde ;)


This commit changed the behaviour somehow. We use to have nil constraints that returned true (a config) and now with this nil returns false.


@Matoxxi my last commits on vendor repo are untested  atm.


use iconv at least in case when mb_function is not exist


Sounds great :)

when you say merge - is it because you have made the changes locally and is putting them "into" github?


Why? :cry: Haven't tried the latest but ActiveSupport 4 worked for me before the v0.4 release.


@pbauer Why is P.CMFQuickInstallerTool Plone 5 only? We have to fix that properly. Next time somebody checks out that package it will break (most likely when we do releases).


Ha. Nevermind. Didn't see there was already a styles.js. My bad.


this won't get warning. see #6


I think that it is a line for StyleCop and we don't have this type of lines in our project, so it's more a useless comment for us....


will push the switch for it to you. first have to pull you base again so give me few minutes


isnt it easier to just click download zip and extract it to addons?


Please also remove my email address ;)


I just meant explicitly, Instead of returning 'void' or undefined explicitly.


试试看 npm i edp-project@beta 解决问题了没有？


Grosso mal! :)


@pbauer it seems you need to revert your merge:

https://github.com/plone/Products.CMFQuickInstallerTool/pull/8


Add gitter


No cwd support :(


Puse el cs.select{|c| cs.count(c) > 1}.uniq así agarraba los contactos que tenían todas las etiquetas. Si buscás por dos etiquetas, creo que de esta forma te va a encontrar los contactos que tienen una u otra. Con el count me aseguraba de que estén en todas. Ah, igual debería ser diferente, debería ser count(c) == v.count.


All looks good. @ajewers


looks like tests made it plone 5 only. Need a branch at least if we're going to make packages plone 5 only.


We should put all the non-standard properties we put into package.json inside the 'brain' key (would be pkg.brain.bundler)


Oh my. Gracious of you. Thank you.


The difference is that for those two rules that do work now I'm using ES6 syntax for the importing. That made a difference in how `src/index.js` understood the rules.


Thank for this, @psarna -- now `LOCK_MEMORY` option works. :)


I'm too working on that can i join you?


fixed #221 [エフェクト]装備品破壊エフェクトを実装する


YES not modules activating and deactivating without any problem


Can't find this DOM element :
' Error: An "el" #extraParameters_myAction1 must exist in DOM '


Reverting this causes tests to fail. 145 of them. If you have capacity to address that, I'd love to see a pull request :)


Me gusta más que sea OR que and me parece


OH TRUE. Sorry for missing that. We should be able to do something like require("./...")._default I think, but it's hacky.


May cause some trouble.
cf dahu/core/app/scripts/views/workspace/actions/move.js:17


Delete


Please don't commit debug code.


Sorry for the delayed answer. No objections here, your solution is better.


Can't we just bind opacity value to 'running'? This way we won't need to onRunningChanged slot below.


Cool :)


We should try to avoid creating branches for every tiny detail. This merge is about tests only. Branches will always lead to additional work (backporting, releases, updating changelogs, etc.). If we create branches for everything it does not make much sense to have separate package repositories any longer...


TeamCity YaccConstructor :: YC.Core General Build [Build 421](http://teamcity.codebetter.com/viewLog.html?buildId=192601&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


it is first commit


check "this" is typed as "tis".


Oh... sorry about that, I somehow thought we already released 4.1 (because it shows in my Settings panel)... I forgot I'm on the bleeding edge channel here ;-)


@kmike [This commit](http://git.chromium.org/gitweb/?p=external/Webkit.git;a=commitdiff;h=aa852570f9d283d62d8eec9a82d975be9773cc19) seems to be the cause of this new behavior. I'll remove the test and fix the docs and code.


We use an associated objects instead of for instance a view->attachInfo map, so that it ties the lifecycle of the attachInfo to the view.
We could also have use a weakToStrong map to achieve the same effect but then it makes this class more difficult to read, indeed attach and detach have the side effect of modifying the view->attachInfo mapping and with an external map it's pretty easy to "cache" a value in an ivar without thinking that it might be invalid a few lines later.
Using associated objects, as we read values out of the view (as regular properties) and not local state this constraint is more obvious and it also allows to mount and unmount without depending on local state.


it is my first lin code(blank)


this commit downgraded openssl package version, intentional @bgruening  ?


Below is the output for 4 socket NUMA x86 machine, just FYI.

    # irqstat
    interactive commands -- t: view totals, 0-9: view node, any other key: quit

    Tue Jun  2 07:18:32 2015
    Top 30 IRQs / 5 second(s)
    IRQ#     TOTAL     NODE0      NODE1      NODE2      NODE3  NAME
     136 369904713 369904713          0          0          0  PCI-MSI-edge ahci
     137 341014680 341014680          0          0          0  PCI-MSI-edge ddnv0
     284 207975229  69292473   12402524   73018838   53261394  PCI-MSI-edge eth7a-fp-0
     294 199487827  54464705   43703481   57122933   44196708  PCI-MSI-edge eth7b-fp-0
     298 196856357  89180061   13453269   35152807   59070220  PCI-MSI-edge eth7b-fp-4
     290 196828313  38188188   25007426   35244012   98388687  PCI-MSI-edge eth7a-fp-6
     291 195588907  50532830   29056520   78011815   37987742  PCI-MSI-edge eth7a-fp-7
     287 195463260  24635508   36937721   61587930   72302101  PCI-MSI-edge eth7a-fp-3
     301 194805628  33956308   60894886   30079291   69875143  PCI-MSI-edge eth7b-fp-7
     286 193297194  42104527   15526457   69163677   66502533  PCI-MSI-edge eth7a-fp-2
     285 192614599  62289517   19507390   26685820   84131872  PCI-MSI-edge eth7a-fp-1
     300 191668789  53690571   21937636   41329556   74711026  PCI-MSI-edge eth7b-fp-6
     299 190483637 146234568   19247581   19048043    5953445  PCI-MSI-edge eth7b-fp-5
     296 188731400  15705081   19915767   82680675   70429877  PCI-MSI-edge eth7b-fp-2
     297 187795355 102616790   36309698   46896873    1971994  PCI-MSI-edge eth7b-fp-3
     295 186754816   6506182  117945519   14962317   47340798  PCI-MSI-edge eth7b-fp-1
     289 182229416  77786278   35571180   45924159   22947799  PCI-MSI-edge eth7a-fp-5
     288 173079514  27105336   73628687   57437844   14907647  PCI-MSI-edge eth7a-fp-4
     162 154708801       780  154708021          0          0  PCI-MSI-edge spcv1-msix8
     163 146352408       283  146352125          0          0  PCI-MSI-edge spcv1-msix9
     164 141679853        58  141679795          0          0  PCI-MSI-edge spcv1-msix10
     165 140317608       262  140317346          0          0  PCI-MSI-edge spcv1-msix11
     234  83305473  12675957   30595271   20502449   19531796  PCI-MSI-edge eth1d-fp-0
     236  79996395  51295656     108329   28563691      28719  PCI-MSI-edge eth1d-fp-2
     224  79526742   7403998   42821521   15735698   13565525  PCI-MSI-edge eth1c-fp-0
     235  79338097  20274039    9085367   40797494    9181197  PCI-MSI-edge eth1d-fp-1
     215  78457009  13381660       6654       8289   65060406  PCI-MSI-edge eth1b-fp-1
     214  78042092  16825384   21190547   25981281   14044880  PCI-MSI-edge eth1b-fp-0
     221  77451495   1797007   31088576    5282957   39282955  PCI-MSI-edge eth1b-fp-7
     217  77325281   1206496   10839049   53199790   12079946  PCI-MSI-edge eth1b-fp-3


Une wildcard serait plus appropriée que d'hardcoder les noms dans le fichier.


:heart:


ok, entonces joya.


Once you fix the build can you file this series of commits to 1.8 and 1.10?


@Kt-baddy Yes, and I've corrected it. What's your point?


This changelog is a bit monothematic :stuck_out_tongue_winking_eye:


what is line no. 92
I m not able to understand.


this is a comment in a commit: beautiful refactoring!!!


I noticed 2 interesting jumps (from -298 to -281 and -169 to -150).
Good job Lucas !


Is this safe? According to the pthread man page:

> Async-signal Safety

> The mutex functions are not async-signal safe. What this means is that they should not be called from a signal handler. In particular, calling pthread_mutex_lock or pthread_mutex_unlock from a signal handler may deadlock the calling thread.


Yes the immediately preceding firmware works fine.


Rather than this laconic comment, something explaining why would be better (basically, verifying pattern is compiled once).


No idea if this will be required as well for `mixed`: https://github.com/babel/babel/pull/1669


indentation off?