The label lab is not always available on Empire. I will need to update the default label to include the app name, e.g `acme-inc` etc.

Just realized I need to provide a more generic solution for people using this outside of empire. Just default to a uuid of something.


Or maybe this is useful because you want to preserve state across hot-code-reloads? I'm trying to understand how that would work, and I've so far been unable to observe any difference in behavior caused by backing `expandedVar` with a Session variable.


Ok, sounds good.


Try using lodash to do this (extend method).


@neappx

I think you are overestimating the effect of offensive content in an isolation section. Git repos and subreddits are isolated from the site. Honestly, unless you are looking for offensive content, you won't find much. I feel censorship hurts users trust (and thus hurts github/reddit) more than the 'offensive' content ever will.


The variable currentTime isn't needed.  The TimeStamp can be directly assigned to mStartTime.

Also, and this might be just my personal taste, I'd put your new if statement inside the else clause.
Reasoning: It's doing the choice between going to MoveNow state, or Idle state.  Idle state may or may not play an animation.


FacilityTabGridView (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I think it can?

-N

On Thu, Jul 30, 2015 at 4:06 PM, Arjun Guha <notifications@github.com>
wrote:

> But it can't be used in quotation mode, right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/frenetic-lang/frenetic/commit/f8b5b9feb67b382ddc7ba3fea031cda2f0563473#commitcomment-12453306>
> .
>


and me?


also, can you update the text of partials/admin/project-settings.html:70 to reflect the new syntax (and that "blacklist trumps whitelist")?


req.query could have also worked and kept it RESTful


Here you need to add a ```shiftedCoordinates``` argument to the function definition. Like this:
``` function willFit(shiftedCoordinates) { ```
Then when you call the function like
``` willFit([[0,1],[0,2]]) ```
The variable ```shiftedCoordinates``` inside the function will refer to what you passed in, in this case an array with value ```[[0,1],[0,2]]```.

You are using ```shiftedCoordinates``` inside the function, but the reason your function works at the moment is because you don't use the ```var``` keyword when declaring the ```shiftedCoordinates``` variable in ```moveLeft``` for example.

As we discussed before, this means that variable is in **global** scope, and thus can be seen every where. If you go and put ```var``` in front of all the ```shiftedCoordinates``` declarations, you will see that your function will no longer work as expected, in fact it likely to through an error since ```shiftedCoordinates``` will not be defined.

That is because the ```shiftedCoordinates``` variable will be in the scope of the function in which they were declared, and the code inside the body of ```willFit``` will not be able to see it. That is why you need to pass the value to the function, and you need an argument in the function definition.


There is a way to represent a collection in a query string.


TODO: Change "is server running" check to use the exit code instead of string compare.
Exit code 0 = Server is running
Exit code 1 = Server not running


Please rename the class to match the file name.
By the way, I think `SingleDomainHostFactory` or something like this would be better for understanding the behaviour of the factory.


I've changed from ' ' to ?, after reading the RSnapshot FAQ:

http://rsnapshot.org/faq.html


What is this for?


I made these changes idk why it says im that username... something with intellij?


Instead of a CopyOnWriteArrayList, I'd either 1) use a plain ArrayList, iterate with an actual Iterator and call remove on the iterator when needed, or 2) create a copy of the list before iterating on the original one and use it for mutations. When the iteration is done, swap them.


KISS:

```
{% if(isBanner) %}
parent.$('#edit_series').load('{{ path('pumukitnewadmin_series_update', {'id': resource.id}) }}');
{% else %}
parent.$('#pic_{{ resource_name }}_{{ resource.id }}').load('{{ path('pumukitnewadmin_'~resource_name~'pic_list', {'id': resource.id}) }}');
parent.$('#pic_{{ resource_name }}_{{ resource.id }}').html('{% trans %}Update the video to show the images{% endtrans %}.');
{% endif %}


I believe "petrifying frost" is correct here, not "stone" or "petrified."


They're used, we register some services, encryption namespace was fixed and some things around encryption was changed, and we do use core.


I fixed it and will commit it to the master repo.


I meant 2.1.4


@ensonic, I spent all day trying to figure out why ev3devKit wouldn't compile. I finally remembered this. :-/

Ref. issue ev3dev/ev3dev#362


I prefer it this way, it's less jarring because everything doesn't move once you start typing a name. If we could get a third opinion maybe? :)


A ```return``` statement will exit the execution of the function, and return the specified value. So you don't need the ```break``` afterwards (it will never be reached)


nautilus_view_is_search. Let's get rid of all hints of the connection with the directory/model.


Should it unique?


You're right, it's a bit more complicated that what I expected. I thought hubs were able to act like aggregators and pull the content periodically to send notifications to subscribers.


Could this be aggregated?


MemberArray_Reduce (DeadParrot) - x86_64-MacOS-10.9-clang: OK (1771 of 1771 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


WAT


Verified that all licenses are compatible with Apache Commons 2.0.


I don't think the `Error: ` prefix is necessary: we don't have that in other "help-block" messages. Can you remove it from here as well as the user settings?


Does this mean at least 1 element?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.871.b60ecb979b898c8b54558937f4e05e3b1f973632](http://build.palaso.org/viewLog.html?buildId=60272&buildTypeId=bt431) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:00:26


Hooray for this change!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18539/testReport/) for this commit**


No, this is a modify, not a compare


It should not be "An 4-bit". Instead, it should be "A 4-bit".


Buying a song multiple times at once? Is this like plays?


Closed the following issues:  #110 #109


Maybe a virtual?


ok


Later I'm planning to animate identicon appearance and also instead of hiding it when user enters invalid account it would display some blank account placeholder, so the jarring will be minimized.


@arnova It is my impression 'tc' as used in this context only works with a single external interface, hence the test.  The code is written more generally if/when the day comes when 'tc' does support multiple external interfaces, then this check can be removed.  Don't think that day has come.


Nothing Serious


`patch 7.4.799` should be replaced with a blank line in the commit message.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.872.d5b6cc1f5e8e6011ad2133975d7b87aa6a5c9941](http://build.palaso.org/viewLog.html?buildId=60274&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:03:01


required


unique?


Right now the Syntax Extension itself is commented out of the build ... that was on my todo list to make this work this summer.  It would re-use the camlp4-based NetKAT string parser in Frenetic_NetKAT_Parser and Frenetic_NetKAT_Lexer.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 236](https://teamcity.labkey.org/viewLog.html?buildId=263661&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 0 Build time: 00:09:49
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


@Raynos are there thoughts on using this outside of ringpop e.g. have TChannel Servers advertise to Hyperbahn with both a `service` and `sk` and have requests forwarded particular `(service,sk)` pairs automatically?


Are both ends of this necessary?


Fixed spelling


97647908-DocIssues4615-again (rglazer2) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.9%25-red.svg)


Full width on small screens


looks good!


We have 2015 :)


TYPI


@mintindeed I moved ```Config``` class into classes dir for this reason only, it is in plugin namespace & should be loaded by autoloader when its used, no need to load it explicitly using ```require_once```. That's why commit msg says explicit file loading was removed.


Set authorSuggest back to false every time


WATMAN


Fixed issue with being the first on the authors list


What do these magic numbers mean?


This is poor email regexing -- there are lots online.


@pdaukintis  Are you using this with FOSS or PE out of curiosity?


Woohoo!


Fixed issue with parentheses not getting parsed as literals.


we can actually remove toggle and do like
nautilus_window_slot_set_serach_visible (slot, slot->details->search_visible ||
                                                                    (slot->defailts->content_view && nautilus_view_is_search (slot->details_content_view))


In the commit message I mentioned that changing to SASL binding is a fundamental change in our authentication method and is out of the scope of this bug. I did "upgrade" it from a simple bind but another issue needs to be opened to consider SASL


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2203 of 2231 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.74%25-yellow.svg)


change variable to match above after change


Oh looks like you reverted this anyway


nit: I think this means it should be a return? Unless you really want to add a display twice.


This is a weird decision.


Don't notify "You are creating a new author" if it's been changed to one.


Did you mean to add 5.21?  I am guessing you meant 5.22 (given that it's out at this point.)


This is an old commit :wink:


How do you know when the operations in this method have completed?


fixed in 617429b4e296bbcddfa0d316e77037fa472bb431


You don't.


It would be cleaner if we had this information stored in the army table. Don't we actually have that available?


I will wait till there's more than one thing that uses a plugin


When `is_uploaded_file()` fails, it could be indicative of an attack, and it may be worth providing a message somewhat like we see in the manual: http://php.net/manual/en/function.is-uploaded-file.php#refsect1-function.is-uploaded-file-examples


This is a pracitce :)


Why the change in visibility?


unrelated


Oh, actually, why not `private`?


Can't believe I went through the trouble of doing that, adding that long commit description, and then got the boolean the wrong way round! Oops!


I should probably update this comment. On Windows, the vsync time we get from DwmGetCompositionTimingInfo is of the previous vsync.


Honestly, I have no idea if we need it or not, because I am total zero in graphics. I can't find that particular conversation, but the idea is to somehow switch from current "follow" camera to fixed camera placed somewhere in the level... I'm not sure if lookat is suitable for this purpose (as well as other matrix functions you want to cut).


This isn't robust enough. You should use the Album model to make sure this album went into the database because that's what you're testing basically (in addition to the HTTP response).


Ok, just curious.


Oh, k.


Rename this class as well.


@steals thanks for the heads up, what happens when you run npm install mavensmate? does keytar install properly?


Still doesn't compile. Without C++11 headers std::to_string is not defined.  I'll fix it right quick.


Check database.


Why not a promise?


:sob: so close


it adds really all wps for the flying ones in og

https://gist.github.com/Rushor/e6069c800b5b070b965c - See you on 6.x :)
![Bild](http://i.imgur.com/vKSIS4Y.jpg)
It's really great - if you want to have it even better, pls fix https://github.com/TrinityCore/TrinityCore/issues/15190 + add the creatures an activeflag:
```sql
-- Orgrimmar Wind Rider SAI
SET @ENTRY := 51346;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,1,0,100,0,1000,1000,1000,1000,60,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Orgrimmar Wind Rider - Out of Combat - Set Fly On"),
(@ENTRY,0,1,0,25,0,100,0,0,0,0,0,48,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Orgrimmar Wind Rider - On Reset - Set Active On");
```


@smeezekitty
I thought we were mainly talking about this topic in a theoretical way (what if..?) since I don't think there are many cases where admins actually should interject. Having a content policy does not mean they have to be enforced (selective enforcement), but it's there if they really feel they have to. Censorship may hurt, but damaging a company (or offending other users) also hurts and at that point you have to evaluate what's more important in a realistic, not just pure ethical, way.


nit: You can probably just coalesce these two functions.


Not g_ please !


You can pass an array into .create to create multiple documents at once.


@msimmond I'm getting installation errors for this package. I'll try to figure it out, but is this type of interaction plot necessary or can we use something from one of the other packages we are already using?


Also no g_ please :)


yay! lol


@arnova Is this only for the special case when non-AIF programs set 'tc' data, and then AIF started ?  It would seem this is not needed if only AIF is used.


> @neappx: Really? I just checked ProBoard's, FreeForums/LeFora (CrowdGather) and Forumoation (the first four entries on Google for "free forum host") and all have a clause similar to GitHub's one. And that's what I'm used to from free web hosts. If you really have a service that says "anything legal is fine", then try common things to piss them off like abusing your forum as a download portal (can even just be legal content; high traffic is important), getting involved in a shitstorm (e.g. (Anti-)GamerGate) or just getting DDoSed (maybe more than one time) and see if they really let you on their platform, especially for free. If they do, they are great.

WordPress is one example of a platform that implements this policy openly. I have run across a number of cases where it was implemented informally, but I can't recall where this was - I haven't used free forum hosts for a long time :)

Getting DDoSed is a separate matter - it isn't about the content at that point, but about the network being disrupted. And that is increasingly becoming less of a problem, as datacenter-wide DDoS mitigation is becoming more widespread (thanks, OVH!)

For what it's worth, [this](https://pdf.yt/tos) is the policy I maintain on the PDF hosting service I operate (non-commerciall). I have rejected a number of "I don't like this content" requests since.

I have also implemented an "anything legal goes" policy on AnonNews.org in the past (and rejected "I am offended, please remove" requests), and that was an actual community rather than a platform. That site is currently down for lack-of-time (and subsequent lack-of-money) reasons, however.

> It's the run-off-the-mill clause many services have that allows them to remove problematic stuff if they have to, even if it's not legally required but still for their own sake.

I am aware. It being so common makes it worse, not better. Unfortunately, many hosting companies maintain similar clauses.

> It kinda sucks, but it's better than writing "If your stuff may get us in trouble, we may delete it" and it may actually give you a way to appeal it.

There's really no difference between those two, depending on how you define 'in trouble'.


Also returns errors


This is a different type of test. It's not for the events. It's for the deleter. So if you think I should still rename it, what about `PatientEditingCanceledDeleterTest`?


Still happening :(


Just sending the string logs for now, probably will end up sending more fields based on how we consume it.


@neappx

Selective enforcement is the most harmful and least ethical way to do this.

On Thu, Jul 30, 2015 at 3:27 PM neappx <notifications@github.com> wrote:

> @smeezekitty <https://github.com/smeezekitty>
> I thought we were mainly talking about this topic in a theoretical way
> (what if..?) since I don't think there are many cases where admins actually
> should interject. Having a content policy does not mean they have to be
> enforced (selective enforcement), but it's there if they really feel they
> have to. Censorship may hurt, but damaging a company (or offending other
> users) also hurts and at that point you have to evaluate what's more
> important in a realistic, not just pure ethical, way.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nixxquality/WebMConverter/commit/c1ac0baac06fa7175677a4a1bf65860a84708d67#commitcomment-12453757>
> .
>


Add a JavaDoc explaining that implementations need to be ok with schedule() being called at any time, even if they previously reported they were blocked.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.873.b99ef97afe06ed6b2216ef5ec95924c2ceef3ef1](http://build.palaso.org/viewLog.html?buildId=60275&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:02:31


This is for testing. `protected` so that I don't have to write a javadoc.


Don't show this to Shauren he will kill you.


This commit actually closes #68.  I messed up the commit message.


:ship:


To add in the javascripts block.


97647908-DocIssues4615-again (rglazer2) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.78%25-red.svg)


This is no longer a double negative


you have a nautilus_view_is_search below, you can just use that so it checks for null etc.


Is there a case where this would actually be valid? I'd rather make sure we never have loose display id's floating around.


ReadVarsSmallDiffTest (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1768 of 1771 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


ReadVarsSmallDiffTest (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1261 of 1261 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


@andreymal, вот как-то так будет. Тут пока зайчатки, и сломан csrf.


.then(function(albums) {
+            res.json(albums);
+        }, next)


You're welcome.


@tiago-rocket é authorisation com S mesmo. A especificação é a ISO, que é britânica; portanto a grafia está seguindo o padrão britânico e não o norte americano.

;)


can't you just expose these on the run command? why do you need incoming traffic on these?


Respondr attribute is defined to be true, but when used (in UserAgentViewNameSelector.java), the value is false. Not sure why that happens.

Current views:

![works jul30_desktop](https://cloud.githubusercontent.com/assets/3407469/8994369/db4f8e14-36d8-11e5-883f-e0e6d82f9c1a.png)

![works jul30_mobile](https://cloud.githubusercontent.com/assets/3407469/8994373/df9aad46-36d8-11e5-8fac-45b6051fb4df.png)

![works jul30_smartphone](https://cloud.githubusercontent.com/assets/3407469/8994376/e362c1a2-36d8-11e5-9cd2-02f7bd7ace1e.png)


The conversation is [here](http://www.tombraiderforums.com/showthread.php?p=7369665#post7369665)


"But look, officer, I only hit *half* of the people on the sidewalk. That's good, right?"


Can't this be encoded with a pattern match, as we do in cluster member https://github.com/akka/akka/blob/master/akka-cluster/src/main/scala/akka/cluster/Member.scala#L142 ?


"Vanilla" readStopBit() shouldn't call threaLocalMap, and enter such deep abstractions. Better to leave the old implementation.


Message should be in the request body (POST).


Class design should never be influenced by its tests. This method doesn't belong in the visible part of the class, so either make it private, or don't write it at all and leave the code inline.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.37%25-red.svg)


Rick and Morty:

http://i.imgur.com/A9qXncp.jpg


How do we end up with timestamps that are less than `start` if we specify `start` as the start of the range to retrieve messages for?


Why not add whether the coordinates are inside the bounds of the grid to the ```willFit``` check?


This code will print the nth number in fib series


I don't know the context, but illustrating state transitions as a crdt is useful and interesting!


Thanks. I did some changes in https://github.com/FreshRSS/freshrss.org/commit/727a597e92d222cadaf89dbc165d492aac27f4e1

I just realised that I will have to publish article tomorrow morning since I will not be available for the next few days then. If you want to improve the language, don't hesitate ;).


!false is always true, so there is no need for this if statement


...and here also if CassandraSession::CassSession operator overload returns a const CassSession ptr


To dobrze, nad tym najdłużej siedziałyśmy :)

Kasia Frąszczak

Project Manager
Geek Girls Carrots

+48 530 604 630
www.geekgirlscarrots.org <http://www.geekgirlscarrots.pl>
www.facebook.com/geekgirlscarrots <http://www.geekgirlscarrots.pl>

2015-07-30 20:22 GMT+02:00 Krzysztof Płocharz <notifications@github.com>:

> Super, tego brakowało [image: :smile:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Karaluszyca/django-carrots/commit/cfc1d9d7d5472818bf9e420b67a3004f7f3e0dba#commitcomment-12451162>
> .
>


Why is this necessary?  Shouldn't any `this.setState()` be enough to force a rerender (given that there is no `shouldComponentUpdate`)?


Please don't break public API on source level. leave the old method and add the method with an extra parameter, that you need (and it could be `private`, as far as I see)


It's just so, so pretty, @lefticus.  Thanks.  Mathdiff, tablediff, warnings, everything going.


I'll add it in again, then... tomorrow. Putting a TODO into my calendar.


How big is the default index page currently? Perhaps we should specify an explicit value in this method? A bit concerned that any busy campaign will do well over one page per five minutes.


Also, beefeee


The commit message of this commit was erroneously set to a commit message of a different branch that was also available at the time of of rebasing this branch with the recent master branch. For unknown reasons the other commit message was retained during a branch switch and rebase.

It should have read:

  Bug 1177798 - Order contributors by recency of last edit.

Apologies for the annoyance.


That just broke all of the themes that check for enabled Yoast Breadcrumbs in options. Could it be done more gracefully? Like with fallback of some kind.


You also need to add this to src/tests/servers/app/Jamfile


I would suggest "has been" rather than "is", but otherwise looks great.


I doubt there should be `offset + bytesRead` as the second argument? Please add a simple test for `readUTF0()` method.


Going to make the partition key just the app name so every logs for one app ends up in the same kinesis shard. Then we can manually filter per proctype and version. @bmarini suggestion.


@riddhishb Check the gradients. Untested code as of now.


The pattern match is manually optimized magic, what I’d like to show is a recipe that can easily be adapted to different use-cases. BTW: I had to change the implementation slightly because changing an ORMap value from New to Executing raised an exception ;-) (i.e. there is the limitation that the `Class` stays the same—which is reasonable in a way, but might be unnecessary now with the fully typed keys).


vOv


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.874.5996dfbecae8b6b1b9aaf70bc8f5d94341299d4a](http://build.palaso.org/viewLog.html?buildId=60276&buildTypeId=bt431) outcome was **FAILURE**
Summary: Compilation error: Glyssen\Glyssen.csproj (new) Build time: 00:01:57


Need to make all these changes also in src/tests/servers/app/Jamfile. As much as it sucks...


Ok, I see it should be correct.


Prevents multiple toasts showing up regarding creating a new author. Only counts one per change.


Woot! :D


Yeah, we should definitely make this configurable. I like how the syslog adapter in logspout just lets you pass in a Go text/template for things like this.


Fair enough, but classes should also be tested. What would you suggest I do to make the code testable? I did not find satisfactory solutions, other than this one, for passing a mock into `new DocumentReference(my_mock)`.


This is fine!

Very soon there won't be the possibility of an empty suspend, but we should put this in anyway - belt and suspenders...


I think that this shouldn't ever happen. If the fd was in the pollset before suspend, it should still be there after the coroutine is resumed. What about using an assert() instead of if?


Figured it out. You must have the complied versions of libmpfr4 plus the headers installed.

`apt-get install libmpfr4 libmpfr-dev`


FacilityTabGridView (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.3%25-red.svg)


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


@bob-rove fixed here! https://github.com/jhbabon/proctor.rb/commit/33e3a350cd87df4f024a9998505274d368a88b88


Wouldn't we have a separate kinesis stream per app? I was thinking we could grab the kinesis stream from an env var or label on the container (prob env var).


Why does VsyncChildCreateCallback need a reference to the display id? Can we just fetch it from the widget instead?


El .classpath fue borrado!!!???


What exactly can't you test?


Could you preserve the kill method in the container service so we have the option for a separate kill goal in the future.


Shouldn't `ForwardingByteCountListener` just implement `ByteCountListener` instead of extending `SimpleBCL`? What does `reset()`, for example, mean for FBCL?


Works with both entire strings and the first item in author list.
Related to: https://github.com/materialos/MOS-Website/commit/522df745fa5564e0432be64ae672a5a701d7ac20#commitcomment-12453626
`aniel` will correctly match `Daniel Hickman` instead of `aniel Hickman`


What exactly happens here with GCC_2_NRV(transform)? This should expand to:

SimpleTransform
Canvas::LocalToScreenTransform() const return transform
{
	_LocalToScreenTransform(transform);
	return transform;
}

?! I've never seen such a construct. Maybe I don't read the macro right.


To zadanie z zajęć co tygodniowych w Pythonie. Opisywał Grzegorz Kapkowski.
Też się na tym z Agnieszką chwilę zastanawiałyśmy, ale pewnie, żeby było prościej.

Tutaj jest kod źródłowy: https://github.com/CodeCarrots/warsztaty_2015/blob/master/sesje/2015-02-25/script1.py


There is a code path that leaves `target_stage_id` undefined (namely when the condition in line 271 is false), resulting in a UndefinedLocalError here.


Should we be handling this error here? Seems like this could fall through and `err` could be reset to nil.


if you have any ideas of how to do this in a robust way, let me now... I was thinking maybe `diff`ing the include directory, but that is not really robust


It would be safer to use `#if 0` here instead of block comments.


Sorry, I should ask you to do a pr.
Will do next time.


I'm pretty sure the effects package can make this same plot. I'll check into it. I'm also not sure how all these package dependencies are installed on Mac and Windows. We will have to be careful so that we don't have all these hard to install packages.


May I ask if there's there a specific reason for **not** using [the HTTP**S** version of the git-for-windows.github.io site](https://git-for-windows.github.io/) here? And, if not, would it be too much to ask you to update your change set with one more commit, which makes it a secure link as well? That'd be awesome! Thanks anyway. :beers:


Se solucionó en el commit 8767626ec03c368fa5e20352fe54e1d3256a318d


oh! you need to send it to your own repo... and then send me a link... just as if you were me... :)

not sure why you dropped the ldap url, it was quite nice to be able to specify a port and such, no?

besides that it looks good.


`Pool` class tree is over-complicated IMO. It might be just `poll = new TL<SBCListener> { @Override public SBCL get() { SBCL l = super.get(); l.reset(); return l; } @Override protected SBCL initialValue() { return new SBCL(); }}`, and for `FBCL`, accordingly, just in-line where these pools are instantiated. Without the pool class tree at all.


Replaces on a set of files should be performed with **manual confirm mode** to avoid such bugs (see other files). You can fix it the same way (manual confirm) f.e. in vim `%s/WARNING_LEVEL/WARNING/c`.


Ah, good point. I didn't want to add unneeded output... Maybe we could add a specific name or tag to it?


Feels like there is a lot of redundant info in the definition of successors/predecessors, but that is perhaps the easiest way? Doesn't matter. The sample is good.


It would mean a new method was added, either to Exhibit or Cmless, without a corresponding assertion being added. Just a fine-grained coverage check, like the other places I have assertion arrays.


Ok done. Sorry.


so the HMD is specific for VR right? As in, the base widget can listen to both a "display" - e.g. monitor and listen to the HMD? IS there a reason we can't abstract the HMD out as another display? Is it because it technically isn't it's own widget?


ok, poprawiłam


Here i come!


Ah, that probably answers my other question. Note that we now have BStackOrHeapArray in support classes. That would get rid of the code duplication.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.875.5996dfbecae8b6b1b9aaf70bc8f5d94341299d4a](http://build.palaso.org/viewLog.html?buildId=60278&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:02:31


kind of picky, but
1. Can we move the minus to the front?
2. Can we put the magic number `70` in a variable so we can give it a descriptive name? Or add a comment for it.


Heads up for users of Sidetiq: This breaks triggering batches from its web interface. See tobiassvn/sidetiq#138 .


MemberArray_Reduce (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (1777 of 1777 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yep, your instincts were right! The inheritance situation in Rails is the same as with Ruby itself, what is probably more confusing though is that because Rails uses convention all over the place, along with scaffolding via ```rails generate```. Thus it's less obvious where you're "allowed" to add new classes/code into the existing structure.

I'd encourage more experimentation with changing the inheritance hierarchy in both models and controllers :)


Can you see a speedup from this commit to the previous one?


createExecutionSchedule?


Overall, everything looks about right. It's actually a bit cleaner distinction between VsyncSource/Display that we had before as well. Thanks for doing this!


This was my first version, but then I found e0ce28d548f7b9fba5e5a6308c3473c8a243482e, and assumed that this state is possible (otherwise you would not add this check). If indeed this state is impossible, an assert is much better.


Instead of this, you should probably use `path.dirname`


That's fine, FYI `apm publish` handles all that


Sweet. That answers my question above. That sounds a lot simpler if it works.

We should be generating the partition key based on the `EMPIRE_*` environment variables then, right? So we can generate the partition key to stream from in Empire?


This is sketchy and I think we'll have issues if this is ever consumed in node. We talked about possibly wrapping this in an `ExecutionEnvironment.canUseDOM` check. eg

```js
if (require('ExecutionEnvironment').canUseDOM) {
  require('whatwg-fetch');
  return self.fetch; // needs to be I guess?
} else {
  return () => { throw new Error('lame'); }
}
```


You are using $staged_package before it is declared now.


Should there be a comment above the method here saying that the caller needs to hold on to CurrentState() before calling SetDrawState()?


Since all we can do is log errors everywhere:

``` go
logErr(rb.Flush())
func logErr(err error) {
    if err != nil {
        log.Println("kinesis: ", err.Error())
    }
}


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.876.6f24a6623cca3666182df0684f19fe3a663f558e](http://build.palaso.org/viewLog.html?buildId=60279&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:02:34


`final` -> `static`


Is dateutil supposed to be added to sdetools.extlib?


Remember to use NSInteger instead of int.


>WordPress is one example of a platform that implements this policy openly. I have run across a number of cases where it was implemented informally, but I can't recall where this was - I haven't used free forum hosts for a long time :)

Checked the ToS. Looks nice, but do they actual still tolerate you when it gets extreme? Because as I already stated, having a rule does not necessarily lead
to the actual (active€ enforcement of a rule.

>Getting DDoSed is a separate matter - it isn't about the content at that point, but about the network being disrupted.

Yeah, but what if the hosts gets to know the DDoS happens because your site is participating in hate speech or something like that?

>For what it's worth, this is the policy I maintain on the PDF hosting service I operate (non-commerciall). I have rejected a number of "I don't like this content" requests since.

>I am aware. It being so common makes it worse, not better. Unfortunately, many hosting companies maintain similar clauses.

You have some kind content policy:
>Please don't upload anything that'd get me in trouble.

That's basically what sites mean with their ToS clause; they just can't formulate it that poorly since it's a bad base for business.
Since your site is non-commercial you can basically do whatever you want without major consequences. Companies though have to deal with PR, may be more prone to legal trouble and have users appealing the ToS, so they have to save themselves somehow. This leads to this vague lines that don't get enforced regularly anyway, but they need to grant themselves this right without being too vague so your service seems serious (from a customer-side and enterprise perspective) and not like a hobby site.

>There's really no difference between those two, depending on how you define 'in trouble'.

The one seems more serious and more specific (making it appealable if you're a customer), the other one unserious and more hobby-like since you don't assure them specific (!) rights.

@archer884

What's a better way of enforcement, in a realistic way?


Please add a comment, what does this condition mean


@dragotin: when you consider to redesign chunked protocol upload I think that the transfer ID should be generated by the server (and not by the client). IMO the protocol should not assume that clients are "well behaved" or that their random number generators function properly.


That's what's in there, that's entirely what line 34-37 does.


You're repeating the code here. You need to refactor this into its own method.


a better and proper way to do it.
align: 'left'
lol :smile:


Yep I agree. That is definitely one of the limitations of this approach.

What I was saying is that I think the number of cases where people actually do
```
@gen.coroutine
@vcr.use_cassette(...)
```

will generally be very few.

I would imagine that we will see more cases where we use some type of generator test and that calls in to some other code that actually runs the @gen.couroutine decorated code...


@rsivasundaram ready for code reivew. Please also look at this https://github.com/ccle/moodle-local_recyclebin/commit/b8f11dc97ca8a0129b8e3322551f600c555e80e3 , which is its parent commit. There are totally 3 files changed, and 3 Scenario created in total. Thanks


I believe it's not possible. There's a check to ensure that as long as one coroutine is waiting for a specific fd, no other coroutine can wait for it (line 110 and 117). Therefore, there should be no one to remove the fd from the pollset while the coroutine is suspended.


Yeah, `EMPIRE_*` environment variables are only available from `router.Message.Container.Config.Env` which is an array so a bit more annoying that labels (`map[string][string]`) but doable.


For R2, we may want to revisit the build system question again. Although there aren't any better ones out there... :(


I wonder what would've happened to this thread if the first comment was GitHub staff apologizing for taking down this particular repo.


No, it's 8


perfect :smile:


@neappx I think I already said this in reply to someone here: you remove
content after the court tells you to. As a hosting service, if it isn't
illegal, it's none of your business.

On Thu, Jul 30, 2015 at 4:00 PM neappx <notifications@github.com> wrote:

> WordPress is one example of a platform that implements this policy openly.
> I have run across a number of cases where it was implemented informally,
> but I can't recall where this was - I haven't used free forum hosts for a
> long time :)
>
> Checked the ToS. Looks nice, but do they actual still tolerate you when it
> gets extreme? Because as I already stated, having a rule does not
> necessarily lead
> to the actual (active€ enforcement of a rule.
>
> Getting DDoSed is a separate matter - it isn't about the content at that
> point, but about the network being disrupted.
>
> Yeah, but what if the hosts gets to know the DDoS happens because your
> site is participating in hate speech or something like that?
>
> For what it's worth, this is the policy I maintain on the PDF hosting
> service I operate (non-commerciall). I have rejected a number of "I don't
> like this content" requests since.
>
> I am aware. It being so common makes it worse, not better. Unfortunately,
> many hosting companies maintain similar clauses.
>
> You have some kind content policy:
>
> Please don't upload anything that'd get me in trouble.
>
> That's basically what sites mean with their ToS clause; they just can't
> formulate it that poorly since it's a bad base for business.
> Since your site is non-commercial you can basically do whatever you want
> without major consequences. Companies though have to deal with PR, may be
> more prone to legal trouble and have users appealing the ToS, so they have
> to save themselves somehow. This leads to this vague lines that don't get
> enforced regularly anyway, but they need to grant themselves this right
> without being too vague so your service seems serious (from a customer-side
> and enterprise perspective) and not like a hobby site.
>
> There's really no difference between those two, depending on how you
> define 'in trouble'.
>
> The one seems more serious and more specific (making it appealable if
> you're a customer), the other one unserious and more hobby-like since you
> don't assure them specific (!) rights.
>
> @archer884 <https://github.com/archer884>
>
> What's a better way of enforcement, in a realistic way?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nixxquality/WebMConverter/commit/c1ac0baac06fa7175677a4a1bf65860a84708d67#commitcomment-12454485>
> .
>


Why is this needed? I'm not familiar with python enums.


You are getting the "Missing template" error because Rails is looking for a "delete" template/view to match with this link. If you add remote: true to the end of this line rails should then be able to find your destroy.js.erb file instead and use that as the "template" it is looking for to give you your AJAX action.


Never!!!!!!


Nice!


"else" goes on previous line, behind bracket

I don't quite get it. Is it that you can't just call SetTransform(fTransform), since that will bail out without actually re-computing fCombinedTransform?


`volatile`


So, if you don't want global, you say "global"?  Is that right?


This change feels half baked. There is a bug where if you use the staging code (not yum or apt) it breaks because $staging_file is used before it is declared. Also the forwarder now defaults $pkg_provider to undef rather than using the value from splunk::params which is misleading I feel. I'm guessing this is so the splunkd package can still be installed from a non-apt/yum source but why is the behavior split to begin with? In our environment we have both splunkd and splunkforwarder in our Apt mirror. I would prefer that the changes made to the forwarder class be made to the base splunk class as well. And then, if so inclined the default $pkg_provider for Debian and RedHat systems can be set to undef.


What is the point? Who *could* update the size?


Just connect/disconnect in the connect/disconnted_model_handlers.
You will have to create connect_model_handlers, but the disconnect_model_handler is already there.


#TEST-3 Fixed


You have a function just below for this, that even checks for null


Let's meet halfway. 7!


It's not necessary right here. I moved the location of the enumeration and forgot to move the import with it.


So this needs works, seems you overkilled some important details, like connecting twice to the same signal and duplicating functions.


Thanks! Will do ;-)


Works for me.


Shouldn't this be called DISPLAY_NAME_DISPLAY_NAME?

(Just kidding. :-) )


@JeromSar I was getting one every time before... This appears to have fixed the problem so far.. Or at least I fixed the issue with it not working at all... Any suggestions on how to completely work around it?


thanks, Chad. Appreciate your help!!! It worked.


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


IMHO just a single `MmapInfoHolder` class, which body is equal to `ReadWriteMmapInfoHolder`, is enough.


Why are all of these properties weak?


I thought I needed it to parse the dates coming back from APIv2, yeah.

Do you think we can do it some other way?

On Jul 30, 2015 5:00 PM, Jasmin Lantos <notifications@github.com> wrote:

Is dateutil supposed to be added to sdetools.extlib?

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sdetools/commit/43a4e8a89e6ff458d831605d8dffe81377cb684c#commitcomment-12454474>.


one concern would be that dbItems might be able to be returned before all of the Product.findById's have run....


Remember to use CGFloat instead of float.


I'm using your version of the waitforresponsetimeout...

What I get is the timed out,  and the device side seems to continue sending packages which brings up the "warning" lines..
This must be on the device side.. not client.


This is repeated. Should be in a method.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 237](https://teamcity.labkey.org/viewLog.html?buildId=263678&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 0 Build time: 00:09:42
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Tss.. da fehlt "Media".. ;)


Not a problem, AJAX can be a bit tricky at times! Once you get a hang of the process it’s pretty straightforward to use one action as a template and adjust it from there, whether it’s creating, updating, or deleting.
> On Jul 30, 2015, at 4:07 PM, PamBWillenz <notifications@github.com> wrote:
>
> thanks, Chad. Appreciate your help!!! It worked.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/PamBWillenz/Blocitoff/commit/21c6232ec4046a7d36de9c28f00c10e6ee97acd1#commitcomment-12454677>.
>


What is this error? Message?


Where will this error be caught?


@ckaznocha @allanliu Can you guys review what I have in mind to integrate with marathon. Things are alot different from the 0.4 plugin structure I presented about that relies on Docker containers. Take a look at https://github.com/drone/drone/blob/master/plugin/publish/s3.go and https://github.com/drone/drone/blob/master/plugin/publish/publish.go  that I used for reference


It's a bit of a hack. It would be better to filter the set based on what's enabled. Doing this it this way is to put `pv::StoreSession`'s problems inside `pv::Session`


d9d6a91 checks whether the fd is in the last position in the pollset, not whether it is beyond the end of the pollset.


@Victorious3 You just deleted files instead of moving :-)


Tl;dr of this thread

Github acted within their rights and proper legal planning but really they just got bullied by some sjws.


LGTM


Can't you just use dish._id?


Nooo :(

Is there any replacement? And what does "strong" mean (can't find much discussion about this method)?


What is the purpose of checking for the existence of selector here, and also making sure that selector !== ""?  I am wondering because just about we said $(this).each.... and did not worry about if there was an empty selector.  The problem this is causing is that when inside of an event handler, referring to the element using $(this) is not applying the mask because $(this).selector === "", so it is skipping getting the setInterval.


From this commit I get the icon with a blackish gradient defined. It's not in use which is why there's no linear gradient defined in the source after https://github.com/numixproject/numix-icon-theme-circle/commit/2b6a82115dfd046b60c81662ef05419c8d52977c.
@Foggalong What did you do there?

Speaking of ``clipPath`` elements there are a few icons which have them in the source.
I think it's leftovers which somehow managed to survive both ``inkscape -vacuum-defs`` and the ``svgclean`` script.
In any case, as far as I've tested there's no obvious clipped stuff remaining in any Numix Circle icon and all display fine in Qt since https://github.com/palob/numix-icon-theme-circle/commit/d424d17d898579149aec4d1451c83c8065f895ac.


OK


Uhm... Yeah, I love my git client. Will fix it tomorrow...


It also doesn't appear to have worked? @tomsabin what have I done wrong ?


Ugh but ok


Since most commits only include translations from one translator, we should keep setting this translator as the commit author. Author should be set to translator that has submitted the latest translation or even better - the most translations.


Make sure you change the name of the structure from `S3` :smile:

`MarathonJSONFile` will be a path to a file in the repo?


TeamCity Bender :: Deploy [Build 3.0.18.0](http://build.mikeobrien.net/viewLog.html?buildId=2452&buildTypeId=bender&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 3249, ignored: 5 Build time: 00:01:08


@evg-zhabotinsky, welp, that's a problem due to how @Victorious3's IDE
copes with git

On 2015-07-30 22:10, evg-zhabotinsky wrote:
> @Victorious3 <https://github.com/Victorious3> You just deleted files
> instead of moving :-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Victorious3/Integrated-Circuits/commit/7657dddcb08ad578ad80d86f0794fd64403831d8#commitcomment-12454768>.
>

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


Suspicious use of callbacks


You should do this differently by using the tag name to find the tag's id, then doing an elemMatch query.


The commit message is a little misleading. I would just put something along the lines of:

This was needed for some bug, but seems it got fixed at some point and I can't reproduce anymore.
So let's remove it and see if it continue to work properly


This test doesn't make much sense, isn't it?


I'm trying to understand if this saves back to the node presumably the load function above gives you a copy?  Maybe you can explain a little more how this fixes the issue, thanks!


Haha, no you are correct. Time to sleep..


Thx


No, I wasn’t thinking we could do it some other way. I was just wondering if it was supposed to be added there since it wasn’t part of the commit and I don’t already have it in sdetools.extlib.

From: geoffwhittington <notifications@github.com<mailto:notifications@github.com>>
Reply-To: sdelements/sdetools <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thursday, July 30, 2015 at 5:07 PM
To: sdelements/sdetools <sdetools@noreply.github.com<mailto:sdetools@noreply.github.com>>
Cc: Jasmin Lantos <jasmin@securitycompass.com<mailto:jasmin@securitycompass.com>>
Subject: Re: [sdetools] Commands report and sync_jira are working (43a4e8a)

I thought I needed it to parse the dates coming back from APIv2, yeah.

Do you think we can do it some other way?

On Jul 30, 2015 5:00 PM, Jasmin Lantos <notifications@github.com<mailto:notifications@github.com>> wrote:

Is dateutil supposed to be added to sdetools.extlib?

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sdetools/commit/43a4e8a89e6ff458d831605d8dffe81377cb684c#commitcomment-12454474>.

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sdetools/commit/43a4e8a89e6ff458d831605d8dffe81377cb684c#commitcomment-12454688>.


Is the DCOS CLI going to work for folks running marathon without DCOS?


My use case today is that our build has crept up to 30m and I want to fix
it. My first impulse is to find a culprit commit, but the graphs at the
bottom of the dashboard show things like build time on Thursdays - I'd
rather see a graph of build time per SHA (post-commit only of course, no
PRs)
Is that easy to do?
Other bits:
- kiloseconds in the header is obtuse and hard to know what this means.
Show minutes!
- do you have any guidance on how we can make travis give better labels for
how the time is spent instead of just "script.1" (which is the vast
majority)
- we care the most about the "long pole" - if we have two matrix builds,
and one takes 10m and one takes 20m, I'd rather see this as a 20m build,
not average them to 15m (is that what's happening now?)

Thanks again! Our product manager just noticed the dashboard on the big
screen and wanted to know all about it.

On Tue, Jul 28, 2015 at 12:06 PM Alex Eagle <alexeagle@google.com> wrote:

> okay, we'll hang around as evaluators for a little while, I don't have
> much desire to replicate it. I subscribed to those issues. Thanks!
>
> On Tue, Jul 28, 2015 at 11:28 AM Dieter Adriaenssens <
> notifications@github.com> wrote:
>
>> Good points. I created feature requests for both :
>>
>>    - Auto-refresh dashboard
>>    <https://github.com/buildtimetrend/python-lib/issues/99>
>>    - distinguish between pull requests an regular builds on dashboard
>>    <https://github.com/buildtimetrend/python-lib/issues/100>
>>
>> They shouldn't be too difficult to implement, finding time is more an
>> issue here : Buildtime Trend is a young project I'm working on in my free
>> time.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/angular/angular/commit/30bd2a3fc72f8f1cdb0ffc4b9d11b4ca42e9ece7#commitcomment-12403712>
>> .
>>
>


@archer884
What about damage that could've been avoided by proper execution (meaning no bad stunts like Pao) or topics that have the tendency to attract illegal content? Even 4chan had to restrict content once with GamerGate. Some topics end up being too tiresome to defend. I agree that the best case would be to avoid deleting if not required to do so, but it isn't really a viable option for everyone.

>As a hosting service, if it isn't illegal, it's none of your business.
Tell them that. Some will agree, some will show you the cold shoulder.


Due to a weird force push issue, I erased this by accident and recommitted your change. Sorry about that. I set the attribution back to you so you should be good.


Is this covered by tests?


You are overwriting req.user that passport puts on the req object in order to represent the logged in user.


Can't you just populate?


LGTM


@tenshihan Wrong / Incomplete Tl;dr. Some people here is discussing wether it is moral for GitHub to use their rights that way, and if you should switch to another hosting as a user.


Requerying?


TeamCity Bender :: Deploy [Build 3.0.19.0](http://build.mikeobrien.net/viewLog.html?buildId=2453&buildTypeId=bender&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 3249, ignored: 5 Build time: 00:01:09


Hola.
Me presento, soy Sergio. También estoy realizando el MOOC de node.js y... la verdad es que estaba bastante atascado y tu forma de resolución me ha abierto mucho los ojos sobre "programación orientada a promesas"

Sólo comentarte que en esta sentencia, si por alguna circunstancia aún no se ha incluído ningún comentario, acabaría en una división entre 0. Lo que daría error.

Sólo avisarte por si no te habías percatado de este hecho.

Un saludo :)


No, actually you shouldn't.


Cool. Nice work on this! Thanks


Please remove this commit and use `git rebase` to keep your branch in sync with the master. https://help.github.com/articles/syncing-a-fork/


I know it was not really meant. This is exactly what e.g. `git commit -a` will do.


Yeah, copied it from dbix-connnector. Thanks.


TeamCity Bender :: Deploy [Build 3.0.20.0](http://build.mikeobrien.net/viewLog.html?buildId=2454&buildTypeId=bender&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 3249, ignored: 5 Build time: 00:01:09


Mac should work too I think, @Udayan12167 ?


Yeah, Travis was failing before because of this.


This totally breaks Relabel.  The magic string is telling SELinux whether to Relabel Private or Shared.  If you want to move the handling of the magic string to all over docker that is fine.

There are three cases where this is called.

1 no Z or z so this means do nothing.
2 z Means change the default label to s0, so all containers can share the content.
3 Z means label with the private MCS label.


you don't handle None, do you?


Do we have plans of pushing this upstream?


I'd really prefer you doing None here and simple do the platform comparison thing in the ColorPrinter itself...


I feel that it would be better to put the adding of the menu item inside the if clause.  That would better convey your intent and mean that it is easier to add more code after this.


that probably be
  if (ho_valid(sig))) {
?


this is just... complicated


r+


Oops !

On Jul 30, 2015 5:18 PM, Jasmin Lantos <notifications@github.com> wrote:
No, I wasn’t thinking we could do it some other way. I was just wondering if it was supposed to be added there since it wasn’t part of the commit and I don’t already have it in sdetools.extlib.

From: geoffwhittington <notifications@github.com<mailto:notifications@github.com>>
Reply-To: sdelements/sdetools <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thursday, July 30, 2015 at 5:07 PM
To: sdelements/sdetools <sdetools@noreply.github.com<mailto:sdetools@noreply.github.com>>
Cc: Jasmin Lantos <jasmin@securitycompass.com<mailto:jasmin@securitycompass.com>>
Subject: Re: [sdetools] Commands report and sync_jira are working (43a4e8a)

I thought I needed it to parse the dates coming back from APIv2, yeah.

Do you think we can do it some other way?

On Jul 30, 2015 5:00 PM, Jasmin Lantos <notifications@github.com<mailto:notifications@github.com>> wrote:

Is dateutil supposed to be added to sdetools.extlib?

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sdetools/commit/43a4e8a89e6ff458d831605d8dffe81377cb684c#commitcomment-12454474>.

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sdetools/commit/43a4e8a89e6ff458d831605d8dffe81377cb684c#commitcomment-12454688>.

—
Reply to this email directly or view it on GitHub<https://github.com/sdelements/sdetools/commit/43a4e8a89e6ff458d831605d8dffe81377cb684c#commitcomment-12454927>.


Does this make sense as an unique field?


But what happends when theme checks for breadcrumbs-enable, I suggest add to if ( $breadcrumbs_enabled ) also setting options = true, but may be throw depreciated or something.


Use the following here:

```elixir
List.foldr(collection, [], fn x, acc -> [x.id | acc] end) |> to_formatted_string
```

Because prepending values to an array is way faster than appending them.


Maybe we should add a new callback to be overridden?  Or maybe this could be subclasses?  It doesn't make sense for a VolumeMenu to also doeal with wallpapers.


Could anyone please give me a hint on how I could get Playback QMenu* ?


In this specific kind of cases, doing dot notation seems a little easier to read:

```navigationVC.viewControllers.firstObject```


rax retry tests


Interesting!


ok, actually not sure that check was needed before either


@datakurre I accidentally committed this to master. Do you mind reviewing on master or would you prefer I revert?


Flawed logic.


Shouldn't we catch any generic Exceptions also, just in case? Otherwise we would get a false positive.


Same as below comment.


https://github.com/styleguide/ruby suggests just using `_` but  sometimes I think leaving the name can help with clarity.


Just a user


saw approval from nullstyle
at https://github.com/graydon/stellar-core/commit/a30bf0bd038fc4c9388c1e426b7a09eb71a60f1c


merging graydon/stellar-core/process-failure-more-noise = a30bf0bd into auto


graydon/stellar-core/process-failure-more-noise = a30bf0bd merged ok, testing candidate = 4f042ddd


These changes to return the path should be a separate commit.


What happens with the DrawState which canvas->CurrentState() would return before? Is this not leaked?


#TEST-5 fixed


But you can just populate.


The generic exception will be caught by the test framework and the test will fail, just like before.


//test


I found that out today!
On Thu, Jul 30, 2015 at 1:57 PM Daniel Brooker <notifications@github.com>
wrote:

> That's fine, FYI apm publish handles all that
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DanBrooker/file-icons/commit/9901280775e3c0650a73e0879a39df4104d28194#commitcomment-12454420>
> .
>


Instead of "function argument" you can use the new "fixture" terminology.

```
... the recwarn fixture.
```


it should be 'run'


Possible bidirectional references. Your order had a reference to user and you are referring orders in user. Might want to leave orders out and keep user reference in orders. Also if this is the case there is inconsistency in referencing.


Does this code have side effects?  It looks like it might stop things being coppied out of the documents folder.

I think we need to move the background logic to another subclass.


Why a separate commit?  It seems clear enough.


Encapsulation again.


Эй, зачем marker трогать. Наша приложенька должна жить в модуле app и стартовать с AppActivity.
Верни, плиз, тут все как было.


I'm surprised not calling done passes these tests?


It is an unrelated api change to facilitate the background setter.  It is not the background setter.


Si este "md" lo ponemos como "código" mejor, que resalte en el texto. En vez de md que sea `.md`, con los acentos:

```
extensión `.md`
```


I don't quite understand. Does this mean BegingLayer() while already recording a BPicture only works if the picture is a Layer itself?


Same thing here also invoking the done function passing in the error would also provide correct error handling for testing.


We wrote quick fix hack to get around the http writers not backing off:
https://github.com/cloudfoundry/loggregator/commit/8cfe939abc0083085bb1471d002e63480386d28d#diff-6e841a009af30d713ee6dc7264f6fb64R44


It might be nice if `null === $row` resulted in a thrown exception here.


done is going to be called before tag is saved


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2175 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.19%25-yellow.svg)


Why is this check needed? If blockedStages is empty, wouldn't firstCompletedFuture return an immediate future?


Why is this not `.os-exercise .os-embed`? (or `.os-exercise [data-type='problem'] > p > .os-embed`)? `.autogenerated-content` does not define the link as an exercise link


Could the query parameter be anything other than `id` here?


don't we already check permission for the mempool? or is this to allow the permission to be granted earlier within the same block? I don;'t think that would be consistent with the other transactions (which will fail on mempool if no permission)


Basic Templating and  set-up From ScotchIO angular express stack


Something went wrong with the merge ?


This has nothing to do with the build system. I am sure it would be possible somehow to define the source of app_server only once and share it in both Jamfiles...


I agree that several very specific interpretations of OCP can be useful, but I don't really find OCP necessary for them as a first-class principle (eg one of the "a-ha" moments I had a year or so ago was that DIP applied to *behaviour* as well as just mocking out classes for testing; this leads towards the Strategy pattern in a very similar way)


looking at this, I would say you're no dummy. Thus, it is good you commented out the dummy resume link.


can't we just use an else here instead of the extra scoping and goto?


Buenas noches.

Me llamo Sergio. También estoy cursando el MOOC de node.js.

Sólo quería comentarte que me parece brillante la lógica que has implementado para desgranar las estadísticas del quiz. Con una sola iteracción con BBDD has calculado todo lo necesario (en vez del lío de promesas que he implementado xDD).

Sólo un detalle. Si por alguna circunstancia no se han insertado comentarios la sentencia de la línea 19 acabaría en una división entre 0. Lo que provocaría error.

Un saludo!


Honestly, I would prefer add the functionality of pick a image from the journal in the control panel background section than complicate more the journal palette and model with a secondary functionality.


@neappx

If it presents an active and real legal issue, then it should be removed. For example, jailbait
But hurting someone's feelings is not an excuse for removal.


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Maybe provide a default implementation?


@fpvandoorn I think this is a dangerous annotation.
If the user has a term such as `a + 100000` and runs `esimp`, then Lean will run out of memory. I think the user will not understand what is going on.
Similarly, a term such `10000 * 10000` will generate problems.


Oh yes, absolutely harmless.  Just wanted to mention it in case it was important.


Maybe default implementation for this too?


+1

Users who want to set there background would go the the cpanel anyway.  That is more intuitive.


This is my url it should not be shared with cleantommygunz @gmail or Tommygun 78


q


```
var mongoose = require('mongoose');
var Schema = mongoose.Schema;

//the custom validation that will get applied to the features attribute.
var notEmpty = function(features){
    if(features.length === 0){return false}
    else {return true};
}

var CarSchema = new Schema({
    name: {
        type: String,
        required: true,
    },
    features: [{
        type: Schema.ObjectId,
        ref: Feature
        required: true; //this will prevent a Car model from being saved without a features array.
        validate: [notEmpty, 'Please add at least one feature in the features array'] //this adds custom validation through the function check of notEmpty.
    }]
});

var FeatureSchema = new Schema({
    name: {
        type: String,
        required: true //this will prevent a Feature model from being saved without a name attribute.
    }
});

mongoose.model('Car', CarSchema);
mongoose.model('Feature', FeatureSchema);
```


You don't want that leading `/` on the `/include` that is being called by `os.path.join`.


We already have too many IMO..


I'm assuming this date will not change with every update on GitHub, right?


The url is for Schaubtomwendy@gmail.com Tommygun78 should not be attached please remove


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/73458585


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Reminder for me: Remove these newlines...


Closes #10


No need. We can use `#{version.to_f}` instead. Converting it to a floating point number is indeed a bit hacky, but it’s more readable and works,


Then I would need to do this inside ConsolePrinter. Since color availability is print target dependent.


Also saves post in background with spinner.


Change commit message to:
`printers: Delete ColoredLogPrinter`


J7 m8


There is no Windows 9, they went straight to 10


yeah so we pass None to everything and let the printer itself decide wether it is capable, makes it simpler doesn't it?


I am leaving out quite a few changes. @kyleam @npostavs if you think something else should be mentioned explicitly, then feel free to add. Or improve the existing points. I am now moving on to the manual. (And will later return here to describe the log/diff argument changes, and possibly add and/or improve other items.)


fast-forwarding master to auto = 4f042ddd


The link to your repo is wrong - might want to fix it :)


Including the host/port in the thread name doesn't make much sense when multiple hosts are specified.
I propose to simply set the thread name to `DEFAULT_THREAD_NAME_PREFIX`.


@ujuettner I'm also curious why this is here. Mapping a hostname to `127.0.1.1` seems like a bug to me. I would expect that on any machine within my stack I can refer to a given hostname to mean the same address.


Thanks for the help, I couldn't seem to figure out was going wrong when I was first changing the code. I've made the most of the changes, I'll look into changing the willFit function to check if its inside bounds, however I was having some problems with that initial but know i've fixed the other issues I may have more luck. I'll upload the new version once i've changed the willFit function.


Zgłupiałem. Przy commicie git zamienia mi kodowanie tego pliku na ansi.


In case the error messages may not do this already, we could maintain some reference to the original column in the output by utilizing `$index` or some transformation thereon.


ACID part:
http://paste2.org/Wez1HjaI


Thanks!


Yeah, sorry about that, but it's not lost. For now uzem is such a mess and hard to maintain, I had to cut stuff. I really have to reorganize the whole code in a more modular way. Then I'd be able to add back your visualization and other features.


right


I see now.... wow, how to solve this issue!?


open an issue, share your code, share your problem and then we can talk about it, sounds good?


@joeferraro
Here is my install log https://gist.github.com/steals/50a15026556f8db9b958
The same warnings exist if I run npm uninstall -g mavensmate first.


grgeer


CassandraClusterSession already has a member named 'cluster'.


Confusing logic.


Actually spaced the contents from the footer


Should we call this "AllAtOnce" or something more descriptive?


When the chef-run finishes with success there are two *node.save* calls are triggered:
1. by chef itself at the end of successful run
2. by LastRunUpdateHandler at the end of _any_ run

When the chef-run failures there is only one *node.save* calls is triggered:
1. by LastRunUpdateHandler at the end of _any_ run

Usually failed chef-client run means that some exception has been risen at the middle of the convergence. By that time node could be in "unstable" state. By that I mean that the node attributes could be partly updated.

To prevent that I fetch the node copy from the chef-server and update *lastrun* attribute. After that the fetched copy of the node is saved to the database.


That's what I originally thought too, but empirically it doesn't work. It looks like it _is_ forcing a rerender as expected, but I think it just reuses the old child SelectTable instead of making a new one like it's supposed to.


Missing documentation here.


ComponentSerializer must be static type


What is the purpose of bypass HD?


Maybe must be create a new constructor wiht the parameters(projectPath,fileName)


Yeah, I have the pull request all ready to go, I'm just waiting for this PR to close before I submit it (in case anything needs to change)


For a couple of the tests that I'd added for this PR - as well as for the tests in the pre-existing `jruby-puppet-internal-test` namespace - I was hoping to avoid setting up / generating SSL certs and keys in order simply to exercise a JRubyPuppet instance since it is irrelevant to what is being tested.  Before this code accesses `self.client.nil?`, `@client` would be nil.  `@self.client`, however, would end up creating `@client` because it does `@client ||= create_client`.  The `create_client` call ends up creating an SSL context - which would require good pre-existing certs and keys - and creating an Apache HTTP client.  For the tests that don't setup the good SSL certs and keys - for cases where the certs/keys weren't initialized by side-effect from some other test anyway - this code will lead into an `Exception` being thrown.

While we could work around this for tests, it seemed to me that having to do all of this work to create instances of objects that would immediately get thrown away anyway would be wasteful.  This could happen in production code, for example, in cases where no outbound HTTP calls are ever made from the master - in which case the client never gets created.  Granted, those cases in production may not be all that common anyway.  I'm open to just leaving this code the way it is and working around it in the tests if this is too concerning to others.


This still works in production?


wtf? PlayerTakeRealDamage


MemberArray_Reduce (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1738 of 1777 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.81%25-yellow.svg)


Should explain what kind of value the method returns


poprawione kodowanie, ale dziwna była ta podmiana kodowania. Sam nie wiem co się stało, że ten plik zmianił kodowanie na ansi


Just a brain misfire.


Some functions does modificate the entitydamage hook.


@thinkyhead is there a button that allows to synch my fork with yours? It seems the feature that I found on Github tries to synch it with the Marlin dev tree....


https://gist.github.com/steals/50a15026556f8db9b958#file-gistfile1-txt-L6

it looks like you're having an issue with your local compiler(s), which is preventing `keytar` from being installed on your system. this may help http://stackoverflow.com/a/17980786/429814


MemberArray_Reduce (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


call this method `process` so that it doesn't get mixed up with the PlanNode visitor methods


@mathieuchateau want to write the patch? It's quite simple to add the necessary yaml files here:
https://github.com/purpleidea/puppet-gluster/tree/master/data/versions


I liked the section headers that you did in the above, perhaps having section headers here as well?


Good catch.  This was an accident waiting to happen!  I did this to myself, trying to merge with Michael's latest code.


There are two colons in `''Note:'':`.


`@VisibleForTesting`


You're off to a good start, and I for one am interested since many of the existing OSC libraries leave many things to be desired. I wish you continued good luck!

Have fun, and take care.


Seems to. :+1:


_insertColumnAfterDropHandles should come before _insertGrid in alphabetical order.


starting


Jesus, only 12 more commits for me to figure out that 5.22 isn't supported yet. Grrrr.


The logic here combined with the overloading of () makes his routine confusing.


Normally, I would agree.  However, I want to check this code back into Michael's repo, and I didn't want to remove stuff he had left in.  I will check with him and see if he wants any of this comments left.

In general, the style of this code is not very LSST, and I only checked it in to DM so it would be convenient for me when I need to make changes.  If you are unhappy with that, I will come back after merging to Michael's repo and clean up the code.


Again, trying to keep things consistent with Michael.  I agree with your comment, the way we are using this script.


5058-fix-readvars-cli (nealkruis) - x86_64-MacOS-10.9-clang: OK (1771 of 1771 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


++

This causes a surprising number of bugs


this finished the subpart of https://github.com/TrinityCore/TrinityCore/issues/15181 - next barrens


What do the edges in the graph represent? "depends on" or "before->after"?


I removed this if statement and all test pass, so could you add a test when don't add this newColPosition?


Lets remove the ```--link="${NAME_PREFIX}redis:db"```


this is my favorite commit ever


It looks good

On Thu, 30 Jul 2015 at 15:46 Hadi Eskandari <notifications@github.com>
wrote:

> @johnsimons <https://github.com/johnsimons> I've made this change to use
> a bit more of the available real estate on the diagram nodes. It looks like
> this now.
>
> [image: node-saga]
> <https://cloud.githubusercontent.com/assets/132117/8976555/0e866e26-36d2-11e5-8aba-398b92a7d1a9.png>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Particular/ServiceInsight/commit/c521e45bca494ce5f8b8393dd5458f141b647951#commitcomment-12436573>
> .
>
--

*John Simons*
*Engineer, Particular Software*

Email*:*  john.simons@particular.net <karen.fruchtman@particular.net>
Web:    www.particular.net


Hey Jonathan,

I have a question regarding how I should implement the error message with passing variables.
Below are two methods I found that could pass variables using the language key.
Which approach do you think would be better for solving this issue?

**Note: Getting the error messages to display**
You are correct, currently in master, the error messages do not display.
You can get the messages to display through debugging.
**Steps in case you need to reproduce:**
```
1. Breakpoint on: SiteAdminPortlet.java
    File: D:\Repos\liferay-portal\modules\apps\site\site-admin-web\src\com\liferay\site\admin\web\portlet\SiteAdminPortlet.java
    Line: 329    if (SessionErrors.contains(
2. Execute Code at breakpoint
    Code: SessionErrors.add(renderRequest, GroupKeyException.class, new GroupKeyException())
3. Continue Loading Site
4. Errors for GroupKeyException should be displayed.


初期状態でビデオを開こうとするとfilename = Falseになってここで落ちるんだけど，なんでNoneを与えないの？
そもそもnameなんだから，StringかNoneにしないと駄目じゃない？


most formats, except .avi ...


This function "maps" _the value_ from this `Success`, but _"applies"_ the given function to the value.


@orso82 See this example of how to write a fortran namelist to a fortran variable.


Here is what my compiler outputs for the representation:
```
&INPUTS  I1=          1,  I2=          2,  I3=          3,  R1=  1.00000000    ,  R2=  2.00000000    ,  R3=  3.00000000    ,  /
```


fffffffff


Duplicate line.


Let's do no new line at the start of a method. The indentation catches the eye enough. We probably won't be able to enforce the class thing until we get a proper linter.

I tried hooking up uncrustify as a formatting tool, but I didn't get a chance to follow through on making sure it was what we wanted/applying it uniformly. Though you should be able to try it out with "gradle format" and at some point we should probably apply it and make it an lint error to violate it.


Alphabetical order.


Causing build error: cannot find symbol
            advancedPrefs.removePreference(mTapToWake);


I changed and tested it and no problems seen so far, so I made the change to use SafeDownCast throughout.
I also pushed another commit to do the lost data check in the Scene Views module restore.


MemberArray_Reduce (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (743 of 743 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.12%25-green.svg)


Small nit, but one process is always better than two:
```
print(hasattr(sys, 'real_prefix') and sys.real_prefix or sys.prefix)
```


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


cool!


Causing build error: cannot find symbol
                    .setNeutralButton(R.string.dlg_reset_android


This is an excellent change! :) Especially if #549 is going to kill this pattern of using `me.game.viewport` as a pointer region. :wink:


Ah, yes sorry about that, thanks :)


LGMT


It's "**MINUS**"-global ("-global")


Thanks!


ack


Changelog


Yes, forgot about that. Good catch!


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.95%25-red.svg)


So ein absoluter Pfad auf deinem Rechner ist natürlich auch keine Lösung. Der Pfad müsste relativ zu dem Verzeichnis sein, von dem die Binary aus aufgerufen wird.

Wieso werden die Files mit dem Mode "a+" geöffnet? "r" müsste ausreichen, da nichts geschrieben wird. Dann würden auch keine neuen Dateien mehr erstellt werden.


yo elimine este config porq actualmente no tenemos ningun sistema para evitar las mochilas o evitar un abuso de este config.....almenos agrega un config para habilitar o desabilitar esto


test UMatBasicTests, DISABLED_GetUMat probably can be enabled (successfully tested at least on Windows, Intel HD4400)


alphabetical


Heh, I realized this doesn't make sense now in the management app when showing a card entry form :/ Can you think of something generic that works for both and still makes sense to the user?


just a nitpick: i think the code will be cleaner if the no '.' case can be taken care of by the path() function as well


Updated XCode location but still have the same warnings...
Actually if I understand correctly KeychainService uses node-keychain lib instead of node-keytar according to this commit https://github.com/joeferraro/MavensMate/commit/4e420822c2e10ee84e7472607661e4e68c0b2d4b
Probably there can be an issue...


good idea


seems good


looks good


True. I should stop trying to write templates and exceeptions in C, it makes me think that I have the same power than in C++ when I do not.


@obiot jshint complains about using `new (Class())` We should not write one-off classes like this. I've been trying to cleanup the examples directory. I haven't enabled jshint on the examples, because it's still really noisy...

Anyway, move the class definition to a variable assignment like `var FooBar = me.Renderable.extend()` And then you can use the normal `new FooBar()` here.


get rid of this one


change this class to col-xs-1


change this class to 'col-xs-1 col-xs-offset-1'


@Trass3r
I'd rather this was split into two files

**CMakeLists.txt**
```
option(WITH_UTILS "Build utils" ON)
if (WITH_UTILS)
  message(STATUS "Building utils enabled")
  add_subdirectory(utils)
else()
  message(STATUS "Building utils disabled")
endif()
```

**utils/CMakeLists.txt**
```
halide_project(HalideTraceViz "utils" HalideTraceViz.cpp)
halide_project(HalideProf     "utils" HalideProf.cpp)
```

That was if we get more utils ``CMakeLists.txt`` in the root of the project won't grow


ack


@willsalz We do not intend to do any special routing with Hyperbahn. This would require Hyperbahn to take on the additional concern of monitoring the ring membership of the downstream service. The intent is for the service to relay based on sk itself, incurring a hop if necessary.


@frankduncan, I didn't open a PR for that, but you may want to give it a quick review anyway. Basically, `String.replaceFirst` takes a regex, but the model path was passed to it raw. I happened to have parenthesis in my model path, so the paths generated for `models/index.txt` ended up wrong. (Took me a while to figure out why!)


acl


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2212 of 2231 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.15%25-yellow.svg)


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


ReadVarsSmallDiffTest (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1601 of 1777 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-90.1%25-yellow.svg)


Instead of doing this, does it make sense to just append the css directly right here? That seems like it might be safer than intercepting requests and checking for file extensions?


I could turn your question around and ask, do you think it will bother the average user to have one more button?  And I do think it is an important button, if only to have a prominent indicator that recording is active.


Can you update the aui-form-builder's HISTORY.md file?


This change is for the IES app


@Trass3r

I noticed this issue whilst trying to build the apps under Windows and I left it. The issue is that ``Halide.dll`` isn't in the directories so the executable fails to find Halide at runtime. Somehow ``Halide.dll`` exists in the ``bin/`` folder so this works.

I personally don't like throwing everything into the same ``bin`` folder. The reason I set these properties is that I wanted the apps executables to be somewhere else. However I guess Windows support is probably more important right now than where the binaries end up so

LGTM


The code snippet in the "Executing F* code" section of FStar/README mentions this deleted file. Perhaps that section needs an update?


:corn: WHO WANTS TO SCHUCK?!?? :corn:


@ak-dxdy

`l_stream->m_bytes_in_buffer` is correctly initialized by `opj_calloc`

`l_stream->m_bytes_in_buffer = p_buffer_size;` is wrong, no bytes were read yet.


Could you use event simulate to add this col instead of use the API?


This change is for the ModelSim app


This change is for the Questa app


ah you're right, keychain has a typo, https://github.com/joeferraro/MavensMate/commit/31727b0c41f4edabc1c42ae3251ae22ad6b57296

thanks for pointing that out


Erroneous removal of the modeline


ReadVarsSmallDiffTest (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1688 of 1777 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-94.99%25-yellow.svg)


This change is for the VCS app


Not calling ``json_decref()`` on ``json`` when finished leaks memory.

You should also check whether or not the pointer passed to this callback is ``NULL``.


Nevermind. `make parser` produces this file by copying it from somewhere


Not calling ``curl_slist_free_all()`` on ``list`` during cleanup leaks memory.


This change is for the XSim app


Check out https://github.com/travis-perl/helpers

It will install unsupported perls on demand

--
sent from a rotary phone, pardon my brevity
On Jul 30, 2015 3:09 PM, "David E. Wheeler" <notifications@github.com>
wrote:

> Jesus, only 12 more commits for me to figure out that 5.22 isn't supported
> yet. Grrrr.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/theory/pod-site/commit/62721589e5cefe891c4d57d20f7c9d182771e1b5#commitcomment-12455883>
> .
>


Also, if we're going to switch to JSON API responses now, then we should do it universally and implement it for ``pb_remove()`` as well.


Why yes I did just change nagaqueen to allow for that because why the hell not.


The indentation for this and other similar calls is not following the usual pattern.
You don't need set a var to reuse CSS element on test, you can call CSS class normally when you need on test.
e.g Y.one('.layout-builder-resize-col-breakpoint')


TeamCity Bender :: Deploy [Build 3.0.21.0](http://build.mikeobrien.net/viewLog.html?buildId=2456&buildTypeId=bender&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3248, ignored: 5 Build time: 00:00:46
### Failed tests
```
Tests.dll: Tests: Nodes: Tests.Nodes.CharacterSeparatedTests.should_parse_csv: <no details avaliable>

```


Moved PathUtils to libuse because, well, it's not a very good place for it either but at least it means no spraying stuff like `path[0..-5]` all around


We should document these so we know they are hackfixed and should be tackled properly one day (ie see GSdx, we're running around trying to figure out how to dehack the hackfest and no one remembers where the hacks are anymore)


Need to update README.md also


Yeah turns out it's perfectly legit to *not* have a sourcepath in a useFile (ie. just a bunch of instructions for the compiler, like C libraries and whatnot — cf. `math.use`)


> махнах email частта, щото създаваше проблеми при създаването
Праща мейл за потвърждение, когато админ създаде потребител?


Probably want `0.3`, not `0.3-`


This is initialized in the constructor via semaphore(_semaphore) and therefore since this is Owned is not implicitly linked, should this not be Linked<> rather than Owned<> or use semaphore(LINK(_semaphore))?


Discussion at https://groups.google.com/d/msg/cryptopp-users/hbiW3N0MFJY/IQlTa2PFEwAJ.


Turns out I forgot to copy over that part when salvaging rock's use parser.. oh well.


Woo code re-use!


So I was thinking Travis might silently be using the system-provided GC and it might.. uh.. cause crashes when compiling cork in particular?

But it turns out, no, it still crashes. If anyone can figure out, I'm really really curious...


will return event map based on EventID


Hola @VictorJSV Exactamente cual es el cambio?

el shortlog del commit es muy largo y como parece que el commit no tiene cuerpo no se puede saber exactamente que cambio se esta confirmando en este commit, podrías comentarmelo por aquí por favor?

Gracias


Instead of create this new layout row, you use a config parameter to create a Layout Row without cols. You can use as example the aui-layout-builder-add-col-tests.


Noted. Will fix this later


ah, I'm being sloppy working on master, fixed in the next commit


:heart: :heart: :heart:


Would it be better to access the DOM less and save the password element in a variable?


Hey Mike,

This isn't always a list of batch requests. It could be a single method request called via invoke as well. Hence the two "instanceof" checks below.


5058-fix-readvars-cli (nealkruis) - i386-Windows-7-VisualStudio-12: OK (1777 of 1777 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's fine to mock these out, but we will want to test these helpers as well at some point


Also, the information at the top can be stripped, I'd love to have my name in it somewhere (if this file is used), but it's no big deal if it's not there, either. I'm not sure of the social norm when it comes to a project like this  :palm_tree:


Have you actually checked whether the new publications data are really added?  It seems to me that PC-miner fails to understand any of the HTML files available on the new DBLP design (even though I move each of them to data/ICFP/2014/icfp2014.html and successfully update ui/js/data.js importing the Eclipse .project and running PCMiner.java):

http://dblp.uni-trier.de/db/conf/icfp/icfp2014.html
http://dblp.uni-trier.de/db/hy/conf/icfp/icfp2014
http://dblp.uni-trier.de/db/hc/conf/icfp/icfp2014

See also: https://github.com/franktip/pcminer/issues/17


@lethalman: I did some git bisect and arrived on this "bad commit" (causing evolution build error, and although I didn't test it, I guess 64f3fb96d8950e4a63f8478c84dd51c126e38ae5 too):

```
$ git bisect bad
689897088ce3e9a80edfff10866a8c05459e0c1d is the first bad commit
commit 689897088ce3e9a80edfff10866a8c05459e0c1d
Author: Eelco Dolstra <eelco.dolstra@logicblox.com>
Date:   Sun Jul 26 12:44:26 2015 +0200

    cups: Don't depend on OpenSSL

    Afaict, it doesn't use OpenSSL, just GNU/TLS.

:040000 040000 fa60e7255ed5d68f4ee0665d09b65636d138c4ce 1e2782d826eca130cf2776a3b392540d12b4a26a M      pkgs
```

I had to skip some commits during bisect due to libsoup missing gnome support (or something causing "rest" to fail), but the "bad commit" seems plausible:

```
$ git show
commit 689897088ce3e9a80edfff10866a8c05459e0c1d
Author: Eelco Dolstra <eelco.dolstra@logicblox.com>
Date:   Sun Jul 26 12:44:26 2015 +0200

    cups: Don't depend on OpenSSL

    Afaict, it doesn't use OpenSSL, just GNU/TLS.

diff --git a/pkgs/misc/cups/default.nix b/pkgs/misc/cups/default.nix
index 0018a27..bcd27d6 100644
--- a/pkgs/misc/cups/default.nix
+++ b/pkgs/misc/cups/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchurl, pkgconfig, zlib, libjpeg, libpng, libtiff, pam, openssl
+{ stdenv, fetchurl, pkgconfig, zlib, libjpeg, libpng, libtiff, pam
 , dbus, acl, gmp, xdg_utils
 , libusb ? null, gnutls ? null, avahi ? null, libpaper ? null
 }:
@@ -19,7 +19,7 @@ stdenv.mkDerivation {
   buildInputs = [ pkgconfig zlib libjpeg libpng libtiff libusb gnutls avahi libpaper ]
     ++ optionals stdenv.isLinux [ pam dbus.libs acl xdg_utils ] ;

-  propagatedBuildInputs = [ openssl gmp ];
+  propagatedBuildInputs = [ gmp ];

   configureFlags = [
     "--localstatedir=/var"
```


FYI, _method isn't idiomatic ruby.  Use `private` instead to hide internal methods, or more verbose method names to avoid conflicts.


What do you mean by "created equal"?


Agreed, but ***not today***.


@neappx

I didn't realize "damage" caused by bigoted zealots was something we wanted
to blame on hosting services rather than on bigoted zealots. My mistake.

On Thu, Jul 30, 2015 at 5:36 PM Mike Lyons <notifications@github.com> wrote:

> [image: :corn:] WHO WANTS TO SCHUCK?!?? [image: :corn:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nixxquality/WebMConverter/commit/c1ac0baac06fa7175677a4a1bf65860a84708d67#commitcomment-12456274>
> .
>


I believe so.


dox inc


Im member but I cant find the code


I don't know but we can chat on email and we can discover it togather and by the way which country are you in now I am in Canada Vancouver


Just noticed this - the problem was that the argparser was passing strings to this function for numeric parameters, i.e. they would always raise the IOError.  I have no objections to a different solution.


It would certainly be cleaner and a good practice in general.  If you're worried about performance though, in this sort of implementation, it's a non-issue.


Should we split this out into a list of strings instead of a chain of 'or' operators.

could look something like

```
List<String> things = Arrays.asList("java", "com.sun", "sun", "org.xml", "org.wc3");

if(things.stream().filter(s -> name.startsWith(s)).count() > 0){
            // do things
}
```


Маленький ~~шаг~~ рефакторинг для функции, но большой ~~шаг~~ рефакторинг для всего API


Looking at this further. It's surely weird. I can import gbe.models (or
dependent objects), but I can't import gbe.tests (or any of its dependent
objects). Same problem holds for scheduler/tests

I've tried some experiments with __init__.py, but no luck so far.

On Thu, Jul 30, 2015 at 1:58 PM, Jon Kiparsky <jon.kiparsky@gmail.com>
wrote:

> Hm. Can confirm that this is an issue, not sure why. Will try to come up
> with an answer.
>
> On Thu, Jul 30, 2015 at 12:40 PM, bethlakshmi <notifications@github.com>
> wrote:
>
>> First test cases...
>>
>> Need help…
>> @jonkiparsky  - I am stupidly re-coding UserFactory and ProfileFactory
>> in my ticketing/tests/factories.py to make this work.
>>
>> What I want - is to figure out how to import and reuse your factories
>> in gbe/tests/factories - but I’m stuck.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/bethlakshmi/GBE2/commit/03c73269a9fa9581c9085b3ff9397794ce238e1f
>
>
>


typo in advanced


cout<<"i am gold";


It works just fine for me, using the current code and just removing `tableKey`.  Can you describe more specifically what happens for you without it?


function event:EntityTakeDamage(ent, dmginfo, original_dmg)


I like the look of that


Now I have another error :(
https://gist.github.com/steals/b620adb96a8223ea1688


This is not safe in the (unlikely) case when compiler generates code that first computes field offset, then calls caml_copy_int64 which triggers gc - should use `Store_field` instead


Okay.

On Thu, Jul 30, 2015 at 5:56 PM, Jon Mason <notifications@github.com>
wrote:

> FYI, _method isn't idiomatic ruby.  Use `private` instead to hide internal methods, or more verbose method names to avoid conflicts.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/conjurinc/cli-ruby/commit/d4ee2401239884ab1a8c6be3b8d9f373988a3b71#commitcomment-12456542


Messed around with getting the JSON file from the NIST databases.


Spelling? setNoBalancerSwitch() please.


With this line, the image was not displayed at my computer. Removing this line worked fine for me.


I answered somewhere else on the mailing list.

On Fri, Jul 31, 2015 at 12:56 AM, Bjørn Forsman <notifications@github.com>
wrote:

> @lethalman <https://github.com/lethalman>: I did some git bisect and
> arrived on this "bad commit" (causing evolution build error, and although I
> didn't test it, I guess 64f3fb9
> <https://github.com/NixOS/nixpkgs/commit/64f3fb96d8950e4a63f8478c84dd51c126e38ae5>
> too):
>
> $ git bisect bad
> 689897088ce3e9a80edfff10866a8c05459e0c1d is the first bad commit
> commit 689897088ce3e9a80edfff10866a8c05459e0c1d
> Author: Eelco Dolstra <eelco.dolstra@logicblox.com>
> Date:   Sun Jul 26 12:44:26 2015 +0200
>
>     cups: Don't depend on OpenSSL
>
>     Afaict, it doesn't use OpenSSL, just GNU/TLS.
>
> :040000 040000 fa60e7255ed5d68f4ee0665d09b65636d138c4ce 1e2782d826eca130cf2776a3b392540d12b4a26a M      pkgs
>
> I had to skip some commits during bisect due to libsoup missing gnome
> support (or something causing "rest" to fail), but the "bad commit" seems
> plausible:
>
> $ git show
> commit 689897088ce3e9a80edfff10866a8c05459e0c1d
> Author: Eelco Dolstra <eelco.dolstra@logicblox.com>
> Date:   Sun Jul 26 12:44:26 2015 +0200
>
>     cups: Don't depend on OpenSSL
>
>     Afaict, it doesn't use OpenSSL, just GNU/TLS.
>
> diff --git a/pkgs/misc/cups/default.nix b/pkgs/misc/cups/default.nix
> index 0018a27..bcd27d6 100644
> --- a/pkgs/misc/cups/default.nix
> +++ b/pkgs/misc/cups/default.nix
> @@ -1,4 +1,4 @@
> -{ stdenv, fetchurl, pkgconfig, zlib, libjpeg, libpng, libtiff, pam, openssl
> +{ stdenv, fetchurl, pkgconfig, zlib, libjpeg, libpng, libtiff, pam
>  , dbus, acl, gmp, xdg_utils
>  , libusb ? null, gnutls ? null, avahi ? null, libpaper ? null
>  }:
> @@ -19,7 +19,7 @@ stdenv.mkDerivation {
>    buildInputs = [ pkgconfig zlib libjpeg libpng libtiff libusb gnutls avahi libpaper ]
>      ++ optionals stdenv.isLinux [ pam dbus.libs acl xdg_utils ] ;
>
> -  propagatedBuildInputs = [ openssl gmp ];
> +  propagatedBuildInputs = [ gmp ];
>
>    configureFlags = [
>      "--localstatedir=/var"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/490979c7ce96e52e44268599014362df23717312#commitcomment-12456539>
> .
>

--
NixOS Linux <http://nixos.org>


não existe `$args` :-1: :crying_cat_face:


Can you please format properly before creating a pull request?


This patch doesn't work against versions with loggregator additions. I changed it to this:
```
@@ -151,7 +151,7 @@ oauth:
       secret: cloudcontrollersecret
       authorized_grant_types: client_credentials
       authorities: scim.read,scim.write,clients.read,clients.write
-      scope: uaa.none
+      scope: uaa.none,scim.userids
     doppler:
       id: doppler
       secret: dopplersecret
```


Wait a second? Won't this race if multiple hbck invocations are happening?


Just `<lineEnding>CRLF</lineEnding>` ?


This is awesome. Thank you!