This crash still comes in my Class on doing same scenarios for pushing and coming back to push again Viewcontroller


align arrows?


Most of this function's code could be reused for other sources: running a container is something that doesn't change much between sources. The things that would change are:
 * how to get the command to run
 * the disk location and format


call will execute the same thing?


displacWon?
meine Funktion heißt window_won(parameter)...


This should fix #118


I would rather see a `run_template()` function in the calling class that could handle all sources. This function would then just call functions from the sources to get the source-specific things


4: M120 missing empty line before bullet
4: M121 indentation of two spaces expected


27:1: I201 Missing newline before sections or imports.


It seems that throughout the whole code base the base Exception class is being thrown. It would be nice to have something like this. However, I deleted it from the code base as it was created in 2014 and had no usages.


Looks like 'Member' is allowed to add content, so your test doesn't cover the use case.


Wrong usage.
http://www.cmake.org/cmake/help/v3.0/command/option.html


`if` block would be more readable in the case. Also, it is better to explicitly compare values with `0` (`index != 0`).


Great catch on this one thanks.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.762.08bb783204b29b73f8c0aaa1fc542bc3bc295c98](http://build.palaso.org/viewLog.html?buildId=59726&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 376, ignored: 3 Build time: 00:02:59


Wow.


Maybe, we don't need the `zero_reached` variable, if we use signed type of `index`.


Do you have read Lars comments ?
"but the value should not be used for any checks in kodi, that's correct. it's something that's used by the add-on."


Yes I just found the same thing -- the rest of the form is unusable after making a selection to the dropdown, using this patch


Is it true that

    noPos.keys == allFiles.filter(!checkedFiles.contains(_))

If yes, choose the lhs. If not, we seem to need more comments to explain what's going on here.


I've never visited Oxide github and I don't think I will soon, but seems like you are very interested in Pluton. 2 hours after the commit, you had already commented.


For few so


For few seconds


I would factor the whole non-positioned error business into its own method.


Delete "the"


I've just noticed that this class doesn't have a destructor, even though it creates instances of other classes and attaches events. We need to add a destructor here that destroys the A.TabView and the A.Pagination instances and detaches all events. Then, A.FormBuilder should call destroy() on its A.FormBuilderPages instance.


Ah yes I remember now, I'll change that


I would change "marked" to "annotated"


"marked" => "annotated"


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


i'll merge this commit and take care of fixing this line ;-)


Yes, thanks.  I fixed this in the next revision of the topic.  This is not in `master` yet anyway.


@TedEwanchyna let's use http://materializecss.com/modals.html instead of browser popups. See packages:
`pfafman:materialize-modal` and `gildaspk:autoform-modals-materialize`

The first one comes with toasts too! `Materialize.toast("Glad to here it!", 3000, 'green')`


I would like to clarify what "this new mechanism" means, because now the result is very indirect?
You also mention a module tag, but that could be confused with `<module>` .
A suggestion:
> This module tag is specified to provide a new entry point for using module syntax in browsers. This is because normal `<script>` tags must remain backwards-compatible so won't support es6-module-loader's loading functionality (like using an ES6 transpiler).


To prevent the need to rename the `cautious_slugify` import, this could be rewritten as:

```python
from wagtail.wagtailcore.utils import cautious_slugify
register.filter(string_filter(cautious_slugify), is_safe=True)
```

or as

```python
from wagtail.wagtailcore.utils import cautious_slugify
@register.filter(is_safe=True, name="cautious_slugify")
@stringfilter
def cautious_slugify_filter(value):
    return cautious_slugify(value)
```


Well, since there is a typo here, might worth correcting it in FILTER_JWPLAYER_AUDIO_**HEIGTH** as well.


single and living free!


I think it would be more efficient to use SourceFile's machinery for getting to individual lines. In particular, using

    lineToOffset
    lineContents

should come in handy.


@TedEwanchyna on a second thought, I'd create a new About route/page for us: the team


Hi, Matthew!

Thanks a lot for your comment! I did indeed not regenerate the CSS. I thought the Report link was caused by some template incompatibility or something, so I just went for a quick fix.

I have now reverted the change and regenerated the CSS.

Take care! :)


this check_access() call still needs to go right after acquire_locks()


you already know that


@TedEwanchyna oh, I see what you're doing here, cool :-)


The while loop is needed for launching several scenarios


I'd use `posns` instead of `pos` to make clear that `pos`is a list.


우선순위 높은 테스크가 죽지 않나봄;;


"Returns **an** untitled page ..."


`rest` shadows pattern bound `rest`. Intentional?


The letter E for a rotation matrix is a little misleading. I perfectly understand, on the other hand, that we are trying to comply with the Featherstone notation. If we develop our own notation, however, we may simply change it, and then refer to is in the official documentation. What do you think guys? @traversaro @nunoguedelha


find out #gsub or #tr String methods.


This should go before _getTabView in alphabetical order.


Is it B - A? Probably, it would be better to write it explicitly.


`rest.drop(1) == rest.tail`


Corrigindo a issue #2


#partition - cool method. Isn't it? )) one condition - two separated results.


you can gather localhost with remote-process string


Yeah, see #14. I'm going to commit that fix so this stops coming up.


Ruby Style. )


ack


Good job.


Missing description.


ниочень. совсем.


запятая после кажется


неважно


This seems to be a BUG??


Needs a doc comment.


внутри свой парень - НЕТ) не надо вызывать ненужные ассоциации
в душе, например. но пожалуйста, не надо здесь парней внутри Агехи)


*.iml files should be removed as well.


This was not really clear to me. Probably, writing it explicitly would help the reader understand it.


remove absolute


I don't understand "all backslashes must be escaped in order..." in this context^^


Мы с Агехой на секунду уставились на него с недоумением

действующих лиц терять не круто. хотя вообще перефразировать норм.


у него на лице был написан вопрос, наверное. лица не говорят.


Аои


запятая после Агехи


@novalis `buf.len()` is changed only within the function itself, exactly like the original version (which already uses `buf.len() > 0` as the loop condition). See this small testcase:

``` rust
fn foo(mut buf: &mut [u8]) {
    println!("Inner: {:?}", buf);
    let tmp = buf; buf = &mut tmp[4..];
    println!("Inner: {:?}", buf);
}

fn main() {
    let mut buf = [1,2,3,4,5,6,7,8];
    println!("Outer: {:?}", buf);
    foo(&mut buf);
    println!("Outer: {:?}", buf);
}
```

You can see that modifying `buf.len()` that way (actually changing the `buf` binding) doesn't change it outside the function:

    Outer: [1, 2, 3, 4, 5, 6, 7, 8]
    Inner: [1, 2, 3, 4, 5, 6, 7, 8]
    Inner: [5, 6, 7, 8]
    Outer: [1, 2, 3, 4, 5, 6, 7, 8]

The current implementation of `write_all` (currently at https://github.com/rust-lang/rust/blob/master/src/libstd/io/mod.rs#L348-L360) does the same, only without the intermediary `tmp` binding (which is needed here because of the borrow checker).

...and looking at that, I see we should have used `!buf.is_empty()` instead of `buf.len() > 0`. Oh well, I'll keep it the current way for now.


повторяющиеся такие вот слова в русском языке пишутся через дефис


vales = values*


@Khelek ```@member_form.save``` выкидывает ошибку, если в ```type: nil```.
Думаю, здесь надо сделать отдельную форму ```CreateMemberForm```, у которой основная модель будет ```User```, чтобы можно было сохранять.


запятая после похоже


тире после парень, запятая перед или


Well, this saved some code :laughing:


This is causing an empty bounding box (class .yui3-form-builder-pages) and content box (.yui3-form-builder-pages-content) to be added to the body. That's because you're no longer passing the parent to render(), causing FormBuilderPages's bounding box to be added to the body instead, which shouldn't happen.

Also, as I said, FormBuilderPages's content box is being rendered empty. That's because you're no longer appending content to it, but to the **paginationContainer** and **tabviewContainer** elements you're passing to it instead. That shouldn't happen either. The contract for a Widget is that it should have all content inside its content box.

So, to fix these issues, instead of passing 2 separate containers to FormBuilderPages, you should keep passing its parent inside the `render`call like before (or pass either boundingBox or contentBox directly to the constructor). Inside FormBuilderPages you can then create and add to the content box the 2 containers you need, instead of passing them from FormBuilder, and append the right content to each.


Yep, definitely! :smile:


I don't disagree that this is not the correct place to make the change. But I do disagree that doing this elsewhere is necessarily better.

This is a general-purpose library. I've already seen a ton of microframeworks targeting PSR-7 start springing up that are using Diactoros. The fact is, sooner, rather than later, developers are going to take the URI instance from the current request and spit it out into HTML. Is this a good idea? Not really, not without some form of escaping. But the general newcomer to PHP and/or web development doesn't always know this, and may not know about tools that may be used to properly format and/or escape the URI for use in headers and HTML. And we end up with XSS vulnerabilities or cross-site redirects, and they end up blaming *this* library instead of their own practices.

That gives us two potential solutions:

- Leave the code the way it was, and document somewhere how to render URIs for headers and HTML, and/or leave the escaping to other libraries.
- Apply the patch used here as a [poka-yoke](https://en.wikipedia.org/wiki/Poka-yoke), and potentially end up with duplicate URIs pointing to the same resource.

The first case is essentially what Symfony has recommended. My problems with it are:

- Documentation discoverability. My experience in OSS is that no matter how well you document, significant numbers of developers never read it or are unable to discover the pertinent information.
- Tooling is great *as long as it is used*. Considering that tooling would be separate from this library, there's now a new discoverability issue, in that users need to know where to look for such tools, *assuming they recognize the need for them in the first place.*

We chose the second, poka-yoke, approach here because those problems are not insignificant. So now the question becomes: will duplicate URIs with varying amount of leading slashes pose a problem?

I have literally never seen a valid or working use case for multiple slashes. In the particular case Tobias presents here, we can, and likely should, resolve that at the web server level, setting up 301 redirects to the canonical URI via a RedirectMatch. This solves the problem while still having protections in the code against such issues.

I'll still willing accept an alternate patch, but I hope that the above illustrates why we made the decision we did.


dat feeling must hurt


I intended not to generate a refresh token on setup. Because a refresh token is issued only when an acces token is also issued. They really come together. It would be weird that a refresh token already exists when an access token doesn't yet.


друг детства


Why did you do this change? Although I think it is right according to `SOGoUserFolder.m:ownerInContext` method but just to understand it better.


It's not clear what author notifications are when presented with this option. I'm also unclear what an author alert is?


запятая после конечно


@timheap Cheers for the suggestions - I simply copied Django's `slugify` implementation here: https://github.com/django/django/blob/master/django/template/defaultfilters.py#L230 . I was keen to avoid doing anything too 'clever', to minimise the chance of bugs so close to the 1.0 release...


Não, eu quis dizer que o `before_filter` deve ser uma coisa genérica e por isso não deve ter regras específicas de um action como na linha `if action == "show"`. Neste caso, o `before_filter` não deve se aplicar ao show e algo específico deve ser feito no próprio action.

Por exemplo:

```ruby
 before_action :authorize_user, only: [:edit, :update, :destroy]

  def authorize_user
    @list = List.find(params[:id])

    redirect_to lists_path if @list.user != current_user
  end

  def show
    redirect_to lists_path if @list.tipo != "publica"
    # (...)
  end
```


and how you explain the test passes in Plone 4?


This is a reorganisation, so maybe lines don't appear on Github the way they really are.


пока мы не виделись должно быть в запятых


This could be replaced by `o_auth_access_tokens.create!.bearer_token`, couldn't it ?


I wondered about that, but thought it might be better to leave as is in case existing users have already put custom values in config.php.

Can change it if you think it's better to correct the typo though.


@zamar
Sorry about that...I resubmitted a clean version.


this file might be why you aren't seeing anything get added to the repository.  check out: https://help.github.com/articles/ignoring-files/

If I am reading this correctly, you have told it to ignore *.class as well as all the package files.  You probably need to remove these entries from this file, or perhaps remove this file all together.


Diffrent default settings? The Plone5 stuff runs on plone.app.contenttypes, Plone4 runs on ATCT.


OK, I'll finish the RPC sync work (which for now causes a false positive on Travis), and will then merge this into master once that branch is deleted. Got to get back to my day job now so will finish RPC work either this evening or tomorrow.


Yeah it can, I didn't think it was valid syntax at first.


Whoops... you're right. I'm leving the part that concerns reviewing-related materials.


It should be fine, I do not think this is a popular value to amend, for audio this is just the right size to show just the control bar. But in any case, I will state in 0.3 release notes that type has been fixed and user might need to change it. Of course we can do it more graceful way, e.g. support both and give warning that FILTER_JWPLAYER_AUDIO_HEIGTH will be depricated in next release, but I think for this non-critical change it does not worth effort.


No need for this condition IMO


What about ISSUES.PROJECT_UUID ?


would this work if `kwargs` already contained `headers`?


If we want to support python2.x and python3.x, this would only work for python2.x
Maybe something like
```python
try:
    from urllib import quote  # Python2.x
except ImportError:
    from urllib.parse import quote  # Python3.x
```


better, ack :)


Maybe something like a `ffi_platform.pony` that gets generated by the C compiler that contains definitions like:
```
type FFI_INT is I32
type FFI_UINT is U32
[...]
```


Yeah! I was afraid it wouldn't because of some of the characters, but it worked


Lack of string documentation (using Sphinx syntax like here for instance: <https://github.com/owtf/ptp/blob/develop/ptp/libptp/parser.py#L53https://github.com/owtf/ptp/blob/develop/ptp/libptp/parser.py#L53>)


I suggest to use StudentActivity


sqlite_timeseries (mbadams5) - x86_64-MacOS-10.9-clang: OK (1746 of 1749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


This change seems to contradict with [line 403][1].
What problem does it fix ? Where is the test :stuck_out_tongue:

[1]: https://github.com/angular/material/commit/2d6cc8a693f09895a62e14c4af7bf88a3c30ad6b#diff-a1919fe5ddcba0e8888df1ee8f3f3727R403


Nice catch!


Me going a bit nuts.  My main repo started going crazy.  I ended up just nuking it cloning fresh.

I think the end effect of the double revert is no effect at all... I hope.


The 80chars rule from PEP8 is the one we do not want to follow in OWTF. We have extended it to 120 chars like in Java. With 120chars, this ``if`` statement would fit in one line.


J'ai vu ton message sur IRC, merci d'éviter à tout prix les forcepush a l'avenir :)


Check if related_name is workiing and what  type of objects it's returning.


Same here, 120chars limit.


Is it needed ?


1024? pretty pls?


`ucwords` would imply there was spaces in a class name which is not something PHP provides. Also `ucwords` won't just look at the first character but subsequent characters making it read more then it needs to unlike `ucfirst`.  I know this is old code but I've just found it whilst looking for Joomla tutorials.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.763.b113b885ced2208b0b50fb7f9ac0453be9ea236e](http://build.palaso.org/viewLog.html?buildId=59727&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 376, ignored: 3 Build time: 00:02:27


`Either write student_id=student.id` or `student=student`


Why so manny empty lines ?


I think this was added in error...


For styling use the newsite.css file: https://github.com/johnajacob/infoq/blob/gh-pages/css/newsite.css


Why so many empty lines ?


It's dec vs bin.


activity or activities ?


For python2.x and 3.x compatibility, we might want to avoid using ``print``. If we do have to use ``print``, it would be safer to have this somewhere:
```python
from __future__ import print_function
# . . .
print(...)
```
That way, ``print`` would be a function everywhere, both for python2.x and 3.x.


@Info4Geek Have a look.


moz-calc and webkit-calc is 300px, but regular calc is still 290px


The turtle extension is always fixed.


вместо скромного тихого приветствия.


Аои


i wonder if a `setXY` function would not be convenient to just update the x an y components of a 3d vector


yup. I'm used to KiB/MiB/GiB, etc. aren't decimals used only for discription of hardware-sizes by manufacturers?


The value ``0`` means everything is/went OK if we want to follow usual conventions.
Better use
+ ``sys.exit(-1)``
+ OR define exit error codes somewhere to be able to document them later like ``sys.exit(INVALID_URL)`` (better)
+ OR throw an exception like ``raise ValueError("Please enter...")`` (better but depends on how the script should behave.)


We need to define metaExtentsion in the options, similarly to `options.suffixAcl`. Maybe options.suffixMeta


@rossluebe Thanks fam


should this not have become 1.3.0-rc1? or is RMT not handling this?


запятая после казалось


Yes, that's exactly what it should be. I will fix it! Thanks a lot for catching this, @victordzrz !


лишняя заглавная буква


Should we use '%s' in such cases? I am not sure what is easier to read and this is an open question.


I've pushed big changes to the AA branch and tested them on bgfx.
With DX9 (not OpenGL) now everything seems off by 0.5 pixels, not only the font. So while I can patch the font the borders/lines are off by 0.5 and that's quite noticeable when I expect a line to be aligned to a pixel.

So I believe my patch made progress because now its consistent :)
The projection matrix can be offset by 0.5 for DX9 and it should work (that's what I'm doing in the DX9 example for ImGui). Couldn't find how to do that in ocornut_imgui.cpp, that code seems not to affect anything

```cpp
		float ortho[16];
		bx::mtxOrtho(ortho, 0.0f, width, height, 0.0f, -1.0f, 1.0f);
```
(it's using another matrix)

If you can tell me how to alter the ortho matrix I can test it (and can prepare a patch for the AA branch).


Коллеги, давайте обсуждать перед засылом коммитов?


Без фильтра - намного лучше - так должно работать корректно
Вообще решение для уровня "студент" - уже великолепное
Но вскрылась еще пара случаев:
1) Если `currentValue = undefined` это еще не значит что он - дырка (попробуй `var arr = [ , undefined, ,]`)
2) Если дырки в начале массива, а `initialValue` нет - то `initialValue = array[0]` не прокатит

Сверившись со спекой заливаю в репозиторий вариант, полностью аналогичный работе `Array.prototype.reduce`


Using '%s' in this case would allow the line to be formatted properly and easier to read IMHO. This is an open question.


I think the previous implementation was the correct one?


This item should not be expandable.


but your show cert is in !first_activation, so even on first_activation it won't launch.


I know. I haven't committed the code yet.
this is normal


Whether it is ``print`` as a statement or as a function. But you cannot have both cases in one source file. See my comment about ``__future__``.


Docstring with Sphinx syntax


Nice: [![Build Status](https://travis-ci.org/junghans/kokkos.svg?branch=master)](https://travis-ci.org/junghans/kokkos)


@Federikko Im having a hard time understanding what you mean. Care to elaborate?


If other vendors have indicated interest in shipping the API, we might want to generalise this (atm we just cite Android).


@CallMeAldy It's me or this commit it's useless ? I don't see any changes :|


By default, iterating over a dictionary iterates over its keys. It would be less redundant to use ``for key in header_dict:`` instead.


Comiting the latest changes


Correct indentation per Jeff's comment plz.


A `NULL` item is only appended when things work correctly, from what I could gather (even if it's doing the correct thing, it's fragile code). This isn't a good idea. Just embed a `struct sol_ptr_vector` in `struct sol_conffile_entry`, it's pretty cheap and will avoid problems. Use the looping macros, clear the vector, done.


ткнул он его пальцем в нос


specify -> specifying


:D


No, tehre is only one epsSw, two epsLw ...


This query, will get very slow, if you have collect a lot data for this city.
I would use create a procedure on insert, to update a maximum counter for the slot in question.


перед как запятая


This is fixed at https://github.com/openwsn-berkeley/openwsn-fw/commit/ca6cf07509cfed9b2c7c726b0511518bfb30452c


The call to `iter` should be implicit if you write `for dir in &DIRECTION`. `for` uses the trait `IntoIterator` to get an iterator from something that can be iterated over and it is implemented for `&[T; N]`.


Docstring with Sphinx syntax.


here all rows will be loaded in to memory, which is also probably not a good idea.


I hacked together a fix. From what I could tell code within the blur.fs event was firing even for non-dropdown elements. Separating the if into two statements seemed to prevent that from happening.

```javascript
sel.on('blur.fs', function() {
        if (trigger.hasClass('open')) {
            if (!options.is(':hover')) {
                return setTimeout(function() {
                    return trigger.trigger('close.fs');
                }, 120);
            } else {
                sel.focus();
            }
        }
      });
```


моему папе.
отец - father


перед мы запятая


shouldn't there be two then?
I could for instance imagine the case where one side of the wall is black and the other side is white, which would result in two different epsSw?


the term "removed" is misleading. I suggest to replace by "disabled". Moreover the comment can be improved to describe what's the covered use-case. Currently we must guess what's tested.


перед забыв запятая


Thanks, please fix it [https://github.com/e-maxx-eng/e-maxx-eng.github.io](here) too.


Ведешь себя как маленький


I could not see this used anywhere


Umm.. Yeah... Both these things are actually horrible ideas. Who wrote this?! :joy:


In fact I realize that this for loop iterates both on the key and the value of the dictionary. In that case, it would be smarter to use:
```for key, value in header_dict.items():
    skeleton += """req['%s'] = '%s'\n""" % (key, value)
```
Also, think about naming key and value variables with more explicit names in this case.
Also, this could be onlined using list comprehension but that is not mandatory.


Of course it exists at wall (component) level, but we're talking about
material level here ...

On Wed, Jul 15, 2015 at 3:45 PM, Filip <notifications@github.com> wrote:

> shouldn't there be two then?
> I could for instance imagine the case where one side of the wall is black
> and the other side is white, which would result in two different epsSw?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/open-ideas/IDEAS/commit/f94355bd22fd3b5ebd2eed9782c3dd72547359d6#commitcomment-12179312>
> .
>


I think it would be better to set the number of threads with the command line than with a parameter inside the structure. What do you think?


@chelmuth, @nfeske: please add to staging


все остальные в кабинете/ классной комнате
иначе кажется, что речь про одноклассников, что будет фактической ошибкой


i am still figuring this out


This is done in `PoolGrad.__init__`. Remove the mode parameter of MaxPoolGrad.__init__ and remove line 612 that isn't useful.


This should be in a different PR.
This requires more work than expected, unless I do this PR some time soon, I will discuss this on friday


r+


While -moz-calc and -webkit-calc are 300px, it seems calc is still 290px


I’m pretty sure that this is the culprit… going to check some more…. btw, the ford branch still isn’t auto-deploying documentation… still working on that one…


здесь наверное не нужны кавычки


This will query for each slot all data known for the Lübeck, also slow


the test is there but not yet the code, once the code is in, the test will pass


Hi Rohan, i'd like to set the hours and phrase at the bottom of the screen, but I can't set it.
which setting I have to change?


As far as I understand "first_activation" is the one that happens on
autostart

On Wed, Jul 15, 2015 at 3:41 PM, Ronan Nello <notifications@github.com>
wrote:

> but your show cert is in !first_activation, so even on first_activation it
> won't launch.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/flyingrub/nuntius-linux/commit/a5667431ad0c4dd5fa854a79d5330caf7ad2b2d3#commitcomment-12179224>
> .
>


remove this condition and error.


It would be better to use this instead:
```python
if url.startswith('https'):
    return "\nhttp.use_ssl=true"
else:
    return ""
```


sqlite_timeseries (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1752 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


Genera error de pagina no encontrada al tratar de añadir comentarios


Docstring with Sphinx syntax


@peckomingo Die Asset-Pfade sind je Environment (Development, Test, Staging) verschieden. In Production/Staging werden precompiled Assets verwendet, die Font-Pfade aus den Sass-Files können aber dann nicht richtig zugeordnet werden.

Mit der Sass-Helper Methode 'font-url' gehts.


Instead of splitting two times, it could be better to split ``details_dict['proxy']`` before the return statement. This is an open question.


How can I clone a commit from here?


I feel that the overall source code lacks of comments. I am not saying that comments are needed for each line because some functions are properly named and it makes it easier to read through, but some part remain obscure because of the lack of comments.
Worth checking out IMO.


In the end I'll add a "gtfo" alias.


Clone this commit to your own dotfiles? I don't think that is possible unless you forked me


Would be good to see the type and a doc comment for `byLine`. The rhs is hairy, not clear what its type is by mere inspection.


sqlite_timeseries (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


could move the width and height parameters to the previous line... the one after is longer anyway...


Aw snap!

!reviewIssue :-1:


We have a duplicated case, I guess I removed the wrong one.


closes #6


Fix #43


Git+percol is good enough for me. I can't maintain magit if I don't use it.


1: M111 unrecognized component name: cds


Тогда и это MAX_VALUE


@jeffleeismyhero I guess this is better https://github.com/hyperoslo/Form/commit/ad7dc6664221d8e1b96dca14b85294e2cdf122bc


Why does this need to be a parameter on a private method? Could the method just access the instance variable directly?


LGTM


Надо удалить


If we remove this, then last update inserted in the batch will not be executed


See https://github.com/SonarSource/sonarqube/blob/master/server/sonar-server/src/main/java/org/sonar/server/db/migrations/MassUpdate.java#L85


Looks like you missed this spot - I think you can add `true` now as the last argument to `std_ajax_err`, right?


What is the effect on test times? Maybe drop the restoreScopes check to balance this out?


And also the keys in table should stay in alphabetic order :).


Thanks @Ogeon for your help. Of course I don't mind, on the contrary I'm happy for your interest and help!


onSpindleSpeed was missing from the post processor


Just spotted the typo (autocorrect) in the commit message. Should be Use a custom _regexp_ to tokenize words.


Please remove this header.


it seems like this was probably a pain to track down, kudos


why did you comment that? I think you need to keep that.


docker container still doesn't like it


Why not get the content type from the request the way the original code did?


reference to the Client instance variable needs to be passed to the APILogger method log_request


Ah. I am an idiot. :bulb:


Ah, ok so to move the entire widget down, edit the `.container` css, specifically the `margin-top`

```
.container
   margin-top:30%
   height:300px
   width:800px
   font-weight: lighter
   font-smoothing: antialiased
   text-align:center
   margin-left:30%
   text-shadow:0px 0px 20px rgba(0,0,0,0.3);
```

If you change it to `margin-top: 50%` you'll notice the whole widget move down.

However, if you would like to move individual components just move the following components to your liking.

Time: `.time`
Salutation + Name: `.salutation` + `.text`


The wording definitely needs to be improved but at the moment all examples require a token capable of permanent geocoding, which is currently synonymous with "capable of batch."  I did this because I was imagining most non-web/non-mobile uses of the ephemeral endpoint to be TOS violations. But I probably shouldn't assume that.


Вызовы читаются плохо из-за трех булов `boolean drawTop, boolean drawBottom, boolean ignoreCorners`. У меня два решения. Первое
- Первые два объеденить в один enum со значениями DRAW_TOP, DRAW_BOTTOM, DRAW_ALL
- Третий сделать отдельным enum'ом с двумя значениями

Второе
- Все три була объеденить в один enum, где значения будут набираться побитово.


ack


ugh, good catch, ty


Why not make this a parameter on the constructor? Is it likely to be different for each logging call?


think I did this too late in the day


As duplication happen when a module, directory or file is deleted then re-created, the project remains the same.
But if we want to be safe, we can indeed retrieve the project_uuid from the select and set it to the issue


unack


ah reack.


Fixed in 8fdb8c70


sqlite_timeseries (mbadams5) - x86_64-MacOS-10.9-clang: OK (1749 of 1749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ok, you're right


Extract content with Google BigQuery. Using Pandas I/O package to extract clickstreams, similarities, and durations


you might want to consider doing a documentation commit to Writing_Bears too


Code looks good. Do you have targets I could test this against?


fixed


запятая перед он
Аои


Аои =_=


Sorry, I read this wrong. Caffeine still kicking in. See my comment on the log_request/log_response calls above.


add


Ok, I've removed the unnecessary casting.


Add an assert that the mode is one of the 2 avg mode.


Reshape data into scipy sparse format
COO
CSR !!! the input format for scikit learn


Всеравно тяжко читать. Вынеси подготовку в локальные переменные x, y, width...


говори


запятая


The simple case basically boils down to "make an http request and parse JSON" -- pretty basic stuff. I suspect that the population of people who need that example might include people who don't know how to install `requests`; the example as-is will run without complaint on any stock python install, including OS X.

I could be talked out of this but right now am leaning toward keeping it maximally simple.


thank you very much. it work:)


Here is a neat iterator trick:

```rust
use std::iter::repeat;

//...

self.board.iter()
    .enumerate()
    .flat_map(|(row_n, row)| { //Flatten our nested iterators
        repeat(row_n) //Let's repeat row_n and merge it with the columns...
            .zip(0..row.len()) //Ranges are also iterators
    })
    .any(|pos| self.check_move(pos));  //Finally, check if any of the positions are valid
```

It's not something you have to do. I just wanted to mention it to demonstrate what you _can_ do.


Still seeing images on left.


大家好，这是第一次以这样的方式与大家合作共同完成项目，自己很是激动！在此，希望这次合作愉快，共同完成任务！
我是2016届毕业生，学习专业为：计算机科学与技术。专攻方向为：网站前端，希望在这次共同完成项目的过程中能有所提升、有所收获！
学习是一种乐趣，合作是一种能力，只有在合作中学习才能互相促进、共同提高！


лол) вернул справедливость в виде бенто)
а они не школьники разве? к уроку готовятся школьники


Tests run using en-US locale. Do we still need GettextCatalog?


@Info4Geek It's you, check again (order change and line changes) XD


is this one necessary? I don't see a guava dependency from spring-jdbc


although I don't like that, we sadly can't change theme in readthedocs so ack :(


пошла-пошла повтор с предыдущим предложением, ниочень вообще


Паттерн А


Extraction of the content type is not necessary if you're passing the request.


개쩌네요~~!


Okay, cool


Я здесь вижу два паттерна А, разделенные альфой. Если так, то оформи паттерн в виде метода, чтобы вызвать его из всех трех мест.


I think I'd like to see this method retained and called from format_content below. The name of it more effectively communicates the intent.


Since my alphabet skills are somehow limited, I didn't realized that the original table was not properly ordered ;-).


**CountHigherMemPoolFees:**

`GetTxSize` returns `size_t`, and `GetFee()` returns `int64_t`, which should be adopted.

But aside, I think this line could be replaced with plain integer math:
```c++
int64_t dFeePerKB = fee * 1000 / txSize;
```
*But*, that also aside.. :) If `amount.h` is included, it's probably easier this way:
```c++
const CTxMemPoolEntry& e = entry.second;
CFeeRate feeRate(e.GetFee(), e.GetTxSize());
memPoolFees.push_back(feeRate.GetFeePerK());
```
`CFeeRate` is sortable on it's own, i.e. it would also be possible to just push back the `CFeeRate` objects, and sort it then. But is sorting even necessary here? I can see your optimization, but on the other hand: sorting all fee entries isn't free either! I'm not 100 % sure about the locks, `CTxMemPool::estimateFee` can be called without one, but I think we need one for the wallet.

Thrown together:
```c++
unsigned int CountHigherMemPoolFees()
{
    std::vector<CFeeRate> memPoolFees;
    {
        LOCK(mempool.cs);

        // iterate over the mempool calculating fee/KB and adding it to memPoolFees vector
        BOOST_FOREACH(const PAIRTYPE(uint256, CTxMemPoolEntry)& entry, mempool.mapTx) {
            const CTxMemPoolEntry& e = entry.second;
            CFeeRate feeRate(e.GetFee(), e.GetTxSize());
            memPoolFees.push_back(feeRate);
        }
    }

    // get our fee
    CFeeRate myFeeRate;
    {
        LOCK(pwalletMain->cs_wallet);

        myFeeRate = mempool.estimateFee(nTxConfirmTarget);
        if (myFeeRate <= CFeeRate(0)) {
            myFeeRate = CWallet::minTxFee;
        }
    }

    // count how many transactions we've seen with a fee/KB value higher than ours
    unsigned int txCount = 0;
    for (std::vector<CFeeRate>::const_iterator it = memPoolFees.begin(); it != memPoolFees.end(); ++it) {
        if (*it > myFeeRate) {
            txCount++;
        }
    }

    return txCount;
}
```

**The dialog:**

The threshold actually seems high. There is a really nice website with node stats:

- http://statoshi.info/dashboard/db/transactions

The chart at the top shows mempool stats, and when you zoom out, to see the "pre-stress-test" values, then it looks like there are only about 1500-2000 transactions in the mempool in total usually.

In my opinion the language could be softened from `"very long time"` to `"long time"`, and `"highly recommended"` to `"recommended [to ensure a reasonable fast confirmation]"` or so.

Maybe a concrete number would be useful, too, like `"there are n transactions with a higher fee"`.

It would be great, if there were a quick note how/where to increase the fee.

Given that this dialog is probably also going to be used for the MetaDEx dialogs, I suggest to extract it, and potentially others, too, and create a file for all "simple" dialogs. Ideally there is no "written text" in any "method with effect" (like the send methods), so the actual logic becomes more visible, and we have a central place for user faced messages.


`e` -> `event`


yep


I'm not talking about removal of execute().commit(), but about the if > 0.


If it's forced to en-US it's fine, but not sustainable. :D

We should add at least a few tests that verify that the translation is being used given a different locale.


at least dragonblight is done now for 25%


I think this is a typo: yo uhave subject,_id and i think it's supposed to be subject_id,


That'd be great, but let's not hold this PR up any more - if you create an issue for that change we can do it later, add some documentation and release it as a package to PyPi. (That's also the plan for `info`, of course, as mentioned here: https://github.com/mysociety/pombola/issues/1121#issuecomment-32490786 )


:heart:


I have no problem with this. Feel free to change this file to your heart's content.


yeah that works


This was the root cause of the issue


should be uppercase, see http://asciidoctor.org/docs/user-manual/#admonition


Ждал этого замечания, но из трех не получится. Нам надо рисовать в таком порядке:

```
MAX
   зеленый низ
   зеленый верх

не MAX
   красный верх
   прозрачность
   желтый верх

   красный низ
   прозрачность
   желтый низ
```


Cool! We are safe now :)


For now it's ok to hardcode constant values such as "manipulator" but in later iterations we'll want to load configurable parameters from a yaml file.


What is "this" ?


nice job dude!


I would add the Karma stat to Player.java along with its respective subkarma addkarma methods. Makes more sense to me as Karma is a quality outside of class in that it is influenced on choices made not on things inherent to 'physical' qualities of a character. Also karma would always be initiated to 0 unless some classes would differ in base karma which would be odd although could work if each class had a back story in which lets say a Rogue class may have stolen from good people and feels guilt.
Sorry if this is a little rambly abut thought id give my vague 2 cents.


bracket closing in wrong line


Should this really be outside the scope of `main`?


если сделать метод
```
верх одного цвета
низ этого же цвета
```
То мы получим отвратную отрисовку из-за альфа-канала


I will think about this matching algorithm because it's far from being perfect :)


I'm not sure why you need this. `grep` does the job fine:
```bash
$ openssl s_client -help 2>&1 | grep -- '-no_tlsext'
$ echo $?
1
$ openssl s_client -help 2>&1 | grep -- '-status'
$ echo $?
0
```


The 64 here needs to be revisited. How many bytes will be needed for messages?


Ok !


An other iterator trick:

```rust
self.board.iter()
    .flat_map(|row| row.iter())
    .fold(0, |sum, cell| if let Cell::Taken { .. } = *cell {
        sum + 1
    } else {
        sum
    })
```

`fold` takes an initial value and a closure as arguments. The first argument to the closure is an accumulator that begins with the initial value. The closure should return the new accumulator value for the next iteration. The final value is then returned from `fold`.

This is also applicable for calculating the score.


oops; no; unintentional


missing a requirement about keytool


r+


I don't think embedding the NSS and NSPR header fields in mozilla::pkix is the best way to go. Instead, we should document how to pull mozilla::pkix and the crypto library separately into a project's repo and combine them together. I am working on exactly that, for BoringSSL/LibreSSL/OpenSSL right now.


Where is the configuration ? How do I change it ? Default values ?


If I'm reading this right, the default behaviour will no longer log JSON content.


It will just run


do we need this as well? I would think that excluding guava from spring-xd-extension-jdbc would be enough


This one should have been removed ... there was a -d parameter thats a reason why space sppeared.


From a stylistic point of view, wouldn't it be easier to read this code if you used `== "False"` instead of `!= "True"` ?


We don't really know what the added steps gives to the user. What does it give ? How I use it ?


Fixes #43


File names can contain spaces.


!reviewIssue WTF are you doing?


I was drunk, this will be fixed in next rebase.. sorry but we will have to live with this for now


got it. should I adjust function names as well or is that more of a gray area? lots of non-camel in carmen IIRC, but maybe that's an outlier


Cool! I have added a couple of more comments with some fancy iterator stuff. You don't have to use them, but I wanted to demonstrate how capable they can be.


@kablamo after this line I get <pre>ERROR:  there is no unique constraint matching given keys for referenced table "github_pull"
</pre> on psql (I'm updating manually from psql command line, looking at the diff)


It might be better to write:
```python
self.loggable_content_types = loggable_content_types or []
```
This will make it easier to check later since you won't need to worry about `None`.

However, I'm not clear why this wouldn't be:
```python
self.loggable_content_types = loggable_content_types or ['application/json']
```
in order to preserve backward compatability.


I am okay with this change, but why exactly are you checking them?


Because you were sick :heart:.


Is there a test case which was failing?


`" *(.*)$"` should work fine, afaict.


There can be NULL which come from application programmer


@kablamo

ERROR:  column "number" contains null values


r+ otherwise


ack


@gkalpak - The intent here is to return the $timeout() promise value; so developers can use `.then()` to chain actions.


r+


what about printing the full stack ?


while (tries-- > 0)


it would be nice to realize sending a page via remote proxy (eg Tor)


Why not:
```python
_, loggable_types = self.client.api_logger.log_response.call_args_list[0][0]
```


It is better to be more "careful" while working with pointers


This all looks fine to me. Did you try making ak4pf jets, or something like that, to make sure the changes don't affect the other jet collections?


Thanks! I have a working Makefile too that I will share with you.

Do you think there is a big advantage to providing a shared library? The Makefile I have been working on assumes static linking. I'm nervous about providing a shared library since there's no ABI guarantee.


Fine by me.


return


Would it not be better to add patches for this in the make / configure process for all distributions as a patch or to be used settings depending on the gcc version?


you don't need to put this in the catch if you return in the try


:clap:


In fact not ok -> removing the check made the execute().commit() when there's nothing to do


Тут судя по всему опечатка, нужно добавлять $item в массив $newItems, это проверка на существование товара


I think you have to rewrite the indexing in args array.


sqlite_timeseries (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (723 of 723 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.0%25-green.svg)


Eric, I think the problem is that you overwrote the `#initialize` method on a subclass of `ActiveRecord::Base`. If you do that, you'll need to do something like this:

    def


This contains many typos such as "convinience."


"This could have been cause by an API change." würde ich als Nebensatz hinter arise einfügen oder ganz weglassen


you need a tty here ?


Hi
Cant reach your site at www.42.co.nz, is it down ?


Why would that matter?


@KonstantinKo: Warum funktioniert das nicht? Der error wird geadded, aber gespeichert wird trotzdem...


Виж как в evaluateExpression имаш много пъти повтаряне на един и същи неща. Можеш ли да го изнесеш в отделна функцийка? : )


$query is defined in the `else` case. It will not cause a PHP Notice.


I guess I may as well reply as 'me'. I am not 100% sure I understand what you mean. On the one hand, I think it is at least very convenient to have the information about the number of threads passed within the code in a configuration variable like nThreads. (Just as an aside: I think eventually we ought to define separate structures, one strictly for the user-settable parameters, the second for general configuration information, some of which may of course be derived from the user-settable values.) On the other hand, if you are suggesting the user pass that information into the program via the command line rather than via the model file, then I have no objection.


you should add plugins before using them


asset_path vs image-url?


sqlite_timeseries (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1752 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


add *


Function names as well. camelCase has been a slow one to adopt at mapbox, in part because of our php/c++/python background


add "The problem is, that not only the API itself, but also both, the endpoint...."


dont you need to install mkdocs ?


Thanks for that commit, just bumped into that bug myself.

Could we expect that to be pushed to rubygems soon?


I prefer that than casting to UpsertImpl. If you really don't want execute() and commit() to be executed, it's up to UpsertImpl to handle the condition. That's not so important here.


Should be ``ng-pattern="/^(https?:\/\/.+|)$/i"``


Unfortunately, gradle doesn't seem to cascade the excludes - @wilkinsona is the guru - initially I only had the exclude on the extension and aggregator module but I saw guava was still pulled in to all modules using the extensions


@lowrykun you shouldn't use `print_r()` inside models. Please remove it.


hi


Not bad, you did it without functional implementation of Reference Expansion.


it matter if i need to access to site which my provider is blocked


@hodeyp - excellent catch (no pun intended). I will fix immediately.


Yea, but wouldn't you use tor instead of unblocker then, not both together?


This was fixed already in https://github.com/Baystation12/Baystation12/commit/cec16d75595cf4904d744dc396186863515d077b, see #10148 comments


Если вверх и низ - непересеющиеся области, то почему результат должен отличаться ?
```
   красный верх
   красный низ

   прозрачность

   желтый верх
   желтый низ
```


Might be best to strip this and go for asm-based enabling.


reack


Thanks. It is much better now. Now the only thing left to improve (ideally) is to use legal name instead of "dup2".


Fixed that with #28 - cheers :)


ack


ok


What is the issue you're trying to solve with this? If peer dropping is disabled, you have no way of getting rid of a malicious peer. I.e. I advertise a high TD and you're screwed, because you will try indefinitely to sync with me but I will never guve you anything, so the whole thing gets blocked.

Peer dropping should only occur when a peer does something very wrong. I'm sure there are tuning possible to reduce false positives, but disabling alltogether will potwntially cripple the downloader.


Fixed in https://github.com/ipeychev/lfr-amd-loader/issues/25


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1166 of 1166 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


исправлю


исправлю [1]


Tiny modifications? It looks like it took @cl3kener 40 lines of code less to get that working so there's that.  Then there's the fact that you have enough time to sit around and troll my Github, which is clearly the talk of the town, so I can see why you would be concerned.  Or is it because Chet is sick to death of hearing you complain and just deletes your comments and now you found someone else to harass. Go back to Gitlab and stop being such a pseudo-megalomaniac.


https://github.com/tork-a/spur/commit/cb5d3c230797db9c548493c5e46489991d73aa27#diff-970a490288fcd273e479d19d3d791211R15

do you really use this param on the system? it seems you're using turtlebot
settings

2015-07-15 1:47 GMT+09:00 Isaac I.Y. Saito <notifications@github.com>:

> According to
> http://wiki.ros.org/base_local_planner#Robot_Configuration_Parameters
>
> ~<name>/holonomic_robot (bool, default: true)
>
>     Determines whether velocity commands are generated for a holonomic or non-holonomic robot. For holonomic robots, strafing velocity commands may be issued to the base. For non-holonomic robots, no strafing velocity commands will be issued. ```
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tork-a/spur/commit/cb5d3c230797db9c548493c5e46489991d73aa27#commitcomment-12160147>
> .
>

--
--
!Happy opensource robotics!

TORK (Tokyo Opensource Robotics Kyokai Association, 東京オープンソースロボティクス協会)
http://opensource-robotics.tokyo.jp
+81-50-3748-1069


For a Gradle exclude to work, the exclusion has to be applied to every route to the dependency that you're trying to exclude. If you don't want to duplicate the exclude on multiple dependencies you could use a resolution strategy instead. That'll mean the exclude doesn't appear in generated poms, though.


Nice catch!  Thanks for the fix.


I think we can drop this, it's not used, right?


yes i agree, but it would be good to allow user to choose which method he want to access to site.


Here I think you could safely get rid of the `backend` variable.


I've reverted this commit to implement your solution, see commit 64900e4.


Another option: use my dependency management plugin. I think @nebhale was working on this but don't know where that effort ended up.


in my opinion this would be nice feature


*Sigh*... I'm sorry, but Pluton was really only known to us (at least me) when Dretax came around complaining about Python support all over Oxide's site and its GitHub. I'm not going to try to debate it any further, I just wanted to try to settle whatever the Pluton team thinks is going on. Good luck with the project though, you seem to have a talented crew of developers. :)


The matched filter is applied over the whole record length. It's not just ``|g_avg - e_avg|(t)`` it's also divided by the variance [here](https://github.com/BBN-Q/Qlab/blob/3fcc4d5bf44eaecb77d0aa157397547889424bad/common/%2BMeasFilters/SingleShot.m#L70) so it should take care of suppressing no information gain regions.


Fixed issue #09766: Blank page when trying to use the plugin manager


Hm, that requires xterm to be installed for one, and then of course you'll be stuck with gdb running in xterm instead of a good terminal... but it sounds convenient so I will add it to the error message.


Legal! Muito bom!
Só uma coisa! Acho que deveria ter um error handling, caso o arquivo seja inválido!


А нет ли тут неверно затесавшегося импорта?
Ожидаю, что класс Particle есть и в твоём API.


reack, just removed `platform` import because not used


`p.title` may be `None`, so this fails for me...


reack


@slabounty I commented on github, but I think you need to actually reference the fork by bcherrington, like this, rather than mine since it doesn't have the commit:

```
gem 'kiba', :git => 'git://github.com/bcherrington/kiba.git', :ref => '5f8fe89446f358b91961330ed79e87d227b354a7'
```

I haven't tested the fork though, but I'm investigating how to properly integrate that. Hope this helps!


Они должны пересекаться, иначе скругление углов даст дырки по центру справа и слева.


1. Calculation.java ---> Have package names in small-case. No EmployeeDetails like package names instead you can use edu.javalearn.domain.employeedetails or  employeedetails .
It is good practice to have classes in layered package names, which gives you information about project/tiername-in-which-that-java-file-is-used (ex: financials.model / educontain.ui / meminsure.service)

2. Employee.java ----> In public class, define the constructor(s) as public / if its a singleton pattern expose a public method, which user can use to instantiate objects of your class.

In the same class, i do not see setters/getters for all private member variables. This is a best practice / container will NOT be able to use reflection to set values of individual property. It will NOT call setDetails() method to set all values,

Annotate overridden methods to avoid unintentional overloading.

2. Testclass.java --->
Rename the class/filename. Use camel casing.
Method parameter names should also be meaningful, avoid names like s.

3. Employee.java--->
Exception handling,as you might have read works on delegate model. The business method which is throwing user-defined-exception should just declare in its signature about which all exceptions (user-defined-exception) it is going to throw. Handling those exception will be done by the class which is going to use that method. Read more about Checked/Unchecked exceptions.

4. GenericEmployee.java---->
What is access specifier for MAX_LEAVES ? Decide it according to requirement.

Overall, good progress.


Yes it is not used...sorry the delay on this patch but I upgraded to Mars and found a bug...already sent to the Eclipse bugzilla...


EvansHVACObjects (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


sqlite_timeseries (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1752 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


ILIKE is used twice.


I think dayOfWeekJulian  should return d.WeekDay  instead of (d-1).WeekDay


This `realloc()` is completely superfluous. It allocates exactly the same size than the `calloc()` above. It's still in the latest code. Should be removed to clean things up. Unbelievable how long it's in there this way.


Looks good!


Can we have keep the order of "test functions, helper functions" and move that below all `Test...` please.


I would group the special members together at the top for easy auditing


@guipimenta não sei se vocês estão usando alguma gem, mas o PaperClip faz esse tratamento no Model!


Suggested `operator- ()`


Useless comment.. lol


@Dani723 Can the handling of `relatedObjects` be added here?


Ok, I see. I don't think I can reasonably add that to unblocker because of how different the technologies and requirements are (Tor has to have client software installed on the user's computer, for starters.)

Unblocker is really designed to be a lightweight alternative to things like Tor and VPNs with the main advantage being that end users *don't* have to install anything to use it. Tor is, of course, always an option for users but I don't think there's any good way to make it a built-in feature of unblocker other than maybe providing a link to the Tor client software.

If you want to set up your own node-unblocker server though, feel free to work on it - I'd be interested in linking to it as an example if you can make everything work together.


The class deserves an explanation of the rationale (usage in currencies with high dynamic range) and choice of mantissa/exponent representation.


you dont need string-match like here:

  if (match(args->user_ptr1, ho_name(tptr))) {

setting args.name will do that for you, read the comments in halg_foreach

Re net: IMO no point in using array and going for one line
why not do

  net signal (optionalarrow) pin1
  net signal pin2

etc? (which is easier to change as these HUGE lines - extra bonus, style improvement :)

re threads: those are in the stock object list like all other objects so standard iterator applies - the reason for the hal_data->threads list is the priority sorting and nothing else (please dont touch that one)

save_nets: I dont get the arrow flag passing  - why dont you use args.user_arg1 as a flag, it's an int?

(there are 2 ints and 3 void pointers for passing back and forth)

hey, you're really on my heels ;)


These Javadoc markings are for grouping functions together with a comment - there's no comment here. Its not clear why they are being grouped.


reack


Are you sure it is the only place?


Ahhh ... that makes sense (hitting his commit). But I'm still not sure how you might get a parameter(s) to the script. It seems like you'd almost have to use ```instance_exec``` rather than ```instance_eval``` to get the params in.


Return here and other places are inconsistent.


Suggested:
`/** Returns true if the amount does not exceed the initial XRP in existence. */`


This looks good to me. It would be nice to have a test with a custom Filter since it looks like that was some of the intention here.


According to  https://en.wikipedia.org/wiki/GUID_Partition_Table
the GUID is 0394EF8B-237E-11E1-B4B3-E89A8F7FC3A7

which is what we now (fixed a few hours ago) have in code:
https://github.com/karelzak/util-linux/blob/master/libfdisk/src/gpt.c#L260

So I guess we can close this pull request, right?


Also, from this commit onwards, we no longer collect the first character of passwords.


Hi, some comments after checking the code:

1) Why do we dump the JSON into the filesystem? The XML was being dumped before so that the bibupload task could upload the record, not sure if it is needed now.

2) Why `seal` the SIP at the beginning and have to change all the calls to ```d.get_latest_sip(sealed=True)``` instead of ```d.get_latest_sip(sealed=False)``` ? That breaks all our tasks that were expecting `seal==False`


This loop could be improved using a "fast log 10" and a lookup table to eliminate all but one multiplication.


This loop could be improved using a "fast log 10" and a lookup table to eliminate all but one division.


Any interest in hosting it under `github.com/mozilla` ?


I'm fine with both of those. As for the if / else, I would have done that normally -- I was just trying to match the style I saw elsewhere in the cookbook.


This should probably be :audits.


Suggested:
`Throw<std::overflow_error>("IOUAmount::normalize");`


skip_str should be localized.


@ldworkin this is a little more robust as it doesn't depend on `toggleStatus` being called by the current user.


I built ls with this msim fix
its working but have some wired issue on lockscreen statusbar
Also its keep soft rebooting when I try to install app from sdcard
so I took log if you have time please look on this :)
https://drive.google.com/file/d/0B6XESmoubn3sWU5EejZSWHRhRm8/edit?pli=1


Probably worth removing it if you're commenting it.


These two loops can be replaced with a comparison and lookup table to eliminate all but one multiply/divide.


`mig scribe -scribe mytest.json` feels like we're repeating the word scribe without benefits. What about calling the parameter `-file` or `-path` which would indicate that the argument should be a path to a file?


wow, I didn't know you're also an Eclipse contributor ! Which bug by the way ?


Why ignore?


Since the boilerplate for generating each CSV file is the same, I'd be tempted to write a row generator function for each of these, calling them as something like:

```python

def constituency_office_row_generator():
    # FIXME: the rest of the old code to find constituency offices here, ending with:
        yield({
            'Constituency Office': office_party_name,
            'MzURL': 'http://www.pa.org.za' + office.organisation.get_absolute_url()
        })

def write_csv(filename, headings, row_generator):
    with open(filename, 'w') as fp:
        writer = csv.DictWriter(fp, fieldnames=headings)
        writer.writerow({h: h} for h in headings)
        for row in row_generator():
            writer.writerow({
                k: unicode(v).encode('utf-8') for k, v in row.items
            })

...

write_csv(
    'constituency_offices.csv',
    ['Constituency Office', 'MzURL', 'Keywords'],
    constituency_office_row_generator
)

```
Since the boilerplate for generating each CSV file is the same, I'd be tempted to write each of these as something like:

```python

def constituency_office_row_generator():

def write_csv(filename, headings, row_generator):
    with open(filename, 'w') as fp:
        writer = csv.DictWriter(fp, fieldnames=headings)
        writer.writerow({h: h} for h in headings)
        for row in row_generator():
            writer.writerow({
                k: unicode(v).encode('utf-8') for k, v in row.items
            })

...

write_csv(
    'constituency_offices.csv',
    ['Constituency Office', 'MzURL', 'Keywords'],
    constituency_office_row_generator
)

```


I forgot, what do we need the title for? It's already coming through in `header_html`... @aeschylus


Needs a Javadoc comment explaining exception behavior


You're responding with the same code in both case. It would probably make sense to put that code at the bottom (not within conditions).


Nit: not alphabetical


Makes sense.


We need to make sure that if we downloaded multiple files (by going back in the wizard and selectind a different update) thne all the downloaded files are being removed at the end of the wizard.


This change is missing from 0.6.4:

```
~/.gem/ruby/2.2.2/gems/service_manager-0.6.4 $  ag Quitting
lib/service_manager.rb
56:          puts "Quitting due to failure."
```


rpm targets are failing after these manual pages were added.
It seems that they have to be added to one of the existing packages or, perhaps, a new doc package could be created for them.
I would add them to `libzfs2-devel`.


@pbeeler it's very clear that only lines that are similar between SaberMod and these scripts is "#!/bin/bash" and "make install".  Trying to claim anything different is insulting to @drgroovestarr intelligence.  It's quite obvious to him and everyone that SaberMod is not the same thing and your link above only shows your ignorance on the subject.  AOSP sports all toolchain configurations (which I used as my base) and anyone can scripts a few short toolchain commands.  Assuming you created the first and ONLY custom toolchain which is 99.9% similar to AOSP and everyone else has copied you ever since is quite laughable.  Who's to say I didn't just copy AOSP just like you? Also you mentioned in a post last week that UBERTC is 90% similar to SaberMod.  Using that same logic at least I'm 10% different from SM and Google meaning I'm actually developing something new and unique.  Plus I have better things to do than troll github and most people recognize and respect me for that. SaberMod Development is currently 90% trolling and 10% code pushing and yet you wonder why nobody respects you?


@neutyp nope it's not -- and shouldn't be publicly visible anymore.  Thx for pointing that out!


Cleanup?


Amen


Added markers showing this was a flawed attempt. Still thinking about how to implement... :(


I think you can safely get rid both of the `backend` variable (i.e., the variable holding the backend name) and of the related command line switch. At this point, you can simplify use `backend` as the name of the backend module.


sqlite_timeseries (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1752 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


I feel like this entire section should be consistently using assignment rather than userId. But let's defer on that until later: #20


If it works also for install/downgrade the message ""Skipping upgrades" should change to something more general (e.g. "Skipping packages with dependency issues:").


Two different parameters, wildcard in front, wildcard in front/back.


In fact I do not know how to do : When removing the check, it's failing because no parameter has been set to the prepared statement, so we're trying to execute a query without setting the parameters.


Remember to set the default `datadir` in `main.py` equal to `utils_hier.LOCALSTATEDIR`.


I thought the scribe document was valid json. If that's the case, I'd vote for note compressing it, but instead inserting it into the modules parameters as is.

```json
{
    "name": "some scribe action",
    "target": "environment->>'ident' ILIKE '%ubuntu%'",
    "operations": [
        {
            "module": "scribe",
            "parameters": {
                       SCRIBE DOCUMENT GOES HERE
            }
        }
    ]
}
```


What about other nw cli options? Are you thinking the mocha counterpart would be used?


diese zwischenüberschrift würde ich weglassen


/Vote for lockfree producer consumer queue


Alignment


fancy :)


I think this is a better solution than my previous attempt.  While this generates an error
```
x <- list()
x[[1]]
Error in x[[1]] : subscript out of bounds
```
this returns `NULL` like I want
```
x[["colour"]]
NULL
```


Here you can retain backward compat like this:

```python
from ..config import CONFIG

PIECE_LEN = CONFIG["bittorrent.piece_len"]
```

This is not optimal, but it's a starting point to make everything work and later we could figure out how its best to actually do this (considering that here we cannot set variables at runtime, hence the initialization of `PIECE_LEN` only happens at the beginning and is forever).


since we depend on sol-fbp-to-dot we should conditionally include this like somehow, if we haven't built sol-fbp-to-dot it will certainly fail.


@gkalpak Good catch, I originally used a simple flag here, but later decided to return the timeout - line 403 is no longer necessary.


Same as above.


if json everywhere, let's keep it in cleartext (no base64, no compression).


The problem is that is breaks context rules that start with an uppercase letter. These rules, when they are compiled, must be stored under `uppercaseLetter->otherRules` I think. So when `curCharDef` is changed to the lowercase letter, the rule can't be found anymore.


besser sowas wie:
 "...we integrated USPS and FedEx, since it would not make any sense to enter the US market without an integration of the most important US shipping agents."


Removing in favor of upstream:
https://github.com/openstack/api-site/blob/e49094b3d0ad343ed5119793a47526c15e38e9e2/api-ref/src/wadls/orchestration-api/src/v1/samples/stack_find_resp.json
https://github.com/openstack/api-site/blob/e49094b3d0ad343ed5119793a47526c15e38e9e2/api-ref/src/wadls/orchestration-api/src/v1/orchestration-api.wadl#L1012-L1020


Please keep the previous colour scheme, so we do not confuse our users.


Don't be unusual, just `[NSMutableDictionary dictionary]`.


...vs Third-party web services


Why not strndup() instead?


xD Ca va le copiteur ? :3


Not related to your patch but since you're touching these things and it comes to my eyes, you could make use of a new argument and provide the $DESTDIR here, and replace this hardcoded $PWD/build/soletta_sysroot/ since DESTDIR is hard set.


The quest for abstraction is noble, but only when it is a manifestation of a quest for _truth_. If you work without abstraction, you well do a number of things that could be described as instances of a pattern. For example, there are many APIs in the browser that do some form of streaming, websockets, xhr, server-sent-events, but no consistent interfaces. Using an explicit abstraction in such cases has a big advantage, even if the implementation is still only half right (i.e. node streams)

front-end however, does not seem to be one of these cases. It's not at all clear there really are consistent true abstractions, when people attempt to apply abstractions those abstractions are therefor _LIES_.

You can live a lie for a while, but sooner or later reality will catch up with you.

better to not believe the too-good-to-be-true hypemen, and live honestly and simply,
until you discover the true abstractions.


I think you need to remove line 403, which sets `nextTick.timeout` to true.
Right now, the function will return the promise the first two times it is called and then on return true.


Extra whitespace throughout all of these doc comments needs cleaning up.


and third-party web service.


Apart from the review comments from Day1 assignments:
1. Avoid using import with *. Instead have specific import, this increases readability.
2. Make use of source->format option of Eclipse IDE.
3. For one variable declaration, you need NOT write a comment, unless comment is meaningful.
4. Write access specifiers for all member variables: be it static/non-static.


You could completely get rid of the pointer and directly use the object (as for `decayMomName`).


Truncation is not checked here


here also webservice instead of API


Must arping be in soduers ?


shouldn't you also test for -x somewhere?


not "most of the cases", better "often" or "sometimes" ;-)


> 1) Why do we dump the JSON into the filesystem? The XML was being dumped before so that the bibupload task could upload the record, not sure if it is needed now.

Because we don't have a way how to generate XML. SIP should contain data from user and user submits JSON via deposit.


Nevermind :)


@kalashnikovisme мб прокатит, да. а в params[:member] установить :type = 'Member' перед @member_form.submit params[:member] не прокатывает?


I had a feeling that wasn't the best name for that variable! I like your suggestion, I will change it up! :+1:


im receiver ist aktuell noch der debug modus "on" - außerdem tuns die regulären ausdrücke auf einmal nicht mehr.


actually - for save_net: have a look at halg_foreach_pin_by_signal(), that should be good enough to do the line-by-line 'net signal <optarrow> pin' thing

it's the same here: learning to think up iterators - this aint design, it's discovery ;)


i renamed them and removed the min argument for one of them. the other one uses the argument in a different way. also,. they are used in 2 non-test classes: CommonSuffixSplitter and SharedVertexSequenceSplitter. let's leave them here for now and find a better home at some point


@Khelek не прокатывает, когда выполняется save. Сперва выполняет SELECT запрос, вот на нём всё и валится, потому что SELECT ищет ```type in [ 'Member', 'Questionary' ]```


add tag "web service"


I tried following settings with this outcome (don't know if it's the same, because I don't have another log file)

default bucket | filesystem_templates
------------------- | ----------------------------
cloudman-dev | snap_id: snap-860915f6
galaxy-cip        | snap_id: snap-860915f6
galaxy-cip        | volume_id: vol-fb635132

galaxy-cip has cm.tar.gz with the master tip from yesterday and the cm_boot.py from the same.
volume vol-fb635132 is in the correct placement.

```
2015-07-15 14:42:20,716 DEBUG  cm_boot:428 - virtual-burrito seems to be installed
2015-07-15 14:42:24,361 DEBUG  cm_boot:25  - Successfully ran '/bin/bash -l -c 'VIRTUALENVWRAPPER_LOG_DIR=/tmp/; HOME=/home/ubuntu; . /home/ubuntu/.venvburrito/startup.sh; lsvirtualenv | grep CM''
2015-07-15 14:42:24,362 DEBUG  cm_boot:431 - 'CM' virtualenv found
```
After that, nothing seems to change. I found out that the next step in the log file should be that nginx is beeing started?


@kurtraschke Wanted to pick your brain on this - when consuming the GTFS-rt feed and per-stop predictions, was there any reason in particular that you set the `TimepointPredictionRecord` value based on the arrival time, and aren't doing anything with departure times?

In the [per stop prediction feed](http://97.76.252.61:8080/gtfsrt/trips?debug) we're working with, we see the following where a departure is provided for the first stop in the trip, and arrival times are provided for all subsequent stops in the trip - I believe this is a fairly common config:

~~~
trip_update {
    trip {
      trip_id: "1208451020"
      route_id: "CAT"
    }
    stop_time_update {
      departure {
        time: 1436969397
      }
      stop_id: "4995"
    }
    stop_time_update {
      arrival {
        time: 1436969428
      }
      stop_id: "1605"
    }
    stop_time_update {
      arrival {
        time: 1436969533
      }
      stop_id: "1606"
    }
~~~

In this patch, we'd drop the first timepoint prediction because its a departure, not an arrival.

In an attempt to fix this, we're currently implementing the following:

1.  Include both arrival times and departure times in `TimepointPredictionRecord` - This will allow us to output both arrival and departure values to the OBA REST API, in the case where an agency provides both values and they are different.
2.  If arrival time isn't provided, use departure time instead - with the above data, this would mean propagating the initial departure time downstream, if no other predictions were included in the trip.

Do you see any obvious problems with the above?

Also, FYI - current work on https://github.com/OneBusAway/onebusaway-application-modules/issues/127) is happening in https://github.com/CUTR-at-USF/onebusaway-application-modules/tree/develop-psta2.  @cagryInside is working on implementing the above two feature now (no commits yet for this).

cc @cagryInside @sheldonabrown


Write Access specifier for constructor.


If we really fix this issue including PVR API change like I suggested the comment is obsolete. 0 (or the new constant, then) is exactly want to want to check against here - an invalid client index.


vielleicht "The challenges" oder "Our challenges" ?


Fixed issue #09766: Blank page when trying to use the plugin manager


I was wondering what does `val` had to do.


Un-formatted code. Could be rejected.


dataset is not supported in IE<10, is it possible to use getAttribute instead?


PR done for v7 here https://github.com/anybox/odoo/pull/7


Not readable because of no formatting.


~~APIs~~ services


Yes, I know. I was too lazy to do that ;)


<meta name="keywords" content="gaku,wada,和田岳,wadagaku,ポートフォリオ">


avoid importing with *, use specific class/interface which you want to import.


done


No access specifier?


:smiley:


Made with love :)
Should we remove doc.txt? I will add user_doc soon.


Whitespace around conditions, please. Sorry, but I'm a little pedantic for style so that everything looks uniform.


And one more item to implement:

3.  If both arrival and departure times are provided for a stop, propagate departure time (not arrival time) downstream.


What's the purpose of changing `create.sql` to `create-script.sql`? Ditto for delete.


- Besser statt "e.g." den Satz mit "One example: A customer buys  sth..." oder sowas in der Art anfangen lassen
- ~~or DHL~~ and DHL


You named your Red Deer update site "eclipse-orbit-update-site" ?

Also, where did you define ${eclipse-orbit-update-site} ?


PR for v8 here https://github.com/anybox/odoo/pull/8


Make use of loop to accept input. What if you had to accept 100 employees' data?


it's used in 2 places. let's leave it here for now


This needs a constructor so that it wraps an ostringstream instead of std::cout.


Why void result replaced with `u32`? `pArg` is originally `void*` too. `ppFrame` being pointer-to-pointer would be `vm::pptr`.


:heart: : I like that these labels seem literate, seem like something I'd want to hear on a screen reader, that would be enough for me to understand what MyUW is trying to tell me about notifications.


base.html.erb was never designed to actually do much, it's what happened when I right click -> save as'd the website back when I made monkey


Missing an upper bound check (256)


@mbernat I am not going to add annotations to lines since it is pretty clear/commented. The overall idea is, though, to call `ParseReviewIssue` and get a `ReviewIssue`, add commits/blockers and update it after getting the content by calling `FormatTitle/FormatBody`. It is also possible to create a new issue by calling one of the constructor functions, then adding commits and calling `Format*` again. I mean, you don't need to start by parsing an existing issue...


shouldn't this be caught by `ValidateParameters` ?


EvansHVACObjects (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


add: "These are just a few examples of third party integrations at ePages. There are a lot more uses cases where both customer and merchant can use third party services."


Why does an article have to be assigned to the list to appear in the list? Isn't it enough to just assign the document to the list?


Ok. Thanks.


Need to cover single quote as well?


self ack hotfix revert


Please fix tabs to spaces.


That's what I mean. article=document


Forgive me. I see you addressed this in a later commit. I'm going to leave this comment here in case you see it in an email. I wish the GitHub review tool would let me see a summary of your changes *since* I last commented, but I cannot figure out how.


Tracking against https://github.com/tomchristie/django-rest-framework/issues/3115


I am guessing the goal here is to reuse an existing transactions to do these operations when we have one. :+1:


Yes, remove doc.txt


Test Data 2


:+1: :+1:

Nice Job!


Thanks for examples !


done


@DeepDiver1975 second argument is the default, so it's unnecessary


Submitted upstream
https://review.openstack.org/#/c/202149/


if `GrepResult` returns multiple lines, why not make it returns a `[]string` instead of a `string` that's `\n` separated?
if needed, the `[]string` could still be printed as a single line using `strings.Join()`.


I will remove these lines then.


noch ein satz dazu: "These circumstances keep us busy not only in integrating periodically new services but also in maintaining the existing integrations."


LGTM


Hi Zhihong.

Yes,,, we did agree to use Astat for the error of the asymmetry.

Nobuo

On Tue, Jul 14, 2015 at 10:28 PM, Zhihong Ye <notifications@github.com>
wrote:

> I confused. Did we all agree that the statistical error of the Asymmetry
> (A) should "Astat" but not "A*Astat"?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yezhihong/TMDs/commit/b61da283e3916509f5118f6f5dd2c55574589c1a#commitcomment-12170123>
> .
>


TeamCity DNN JavaScript Libraries :: CI [Build 35](http://teamcity.engagesoftware.com/viewLog.html?buildId=303&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 35](http://teamcity.engagesoftware.com/viewLog.html?buildId=303&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


rfgfg


fgfgf


Should this be "Initializes a CDTMutableDocumentRevision" to be consistent with the other comments?


EvansHVACObjects (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@DeepDiver1975 I suggest you create `$linker` in `Html`'s constructor – so that it is not initialised every time someone uses `convertLinks()`.


~~ must ~~ should never forget


document's


i think it would be more confusing here. This code is fully understandable as is.


c.f. https://github.com/hw-cookbooks/runit/issues/142


vcds


It should indeed only occur when the peer is behaving inadequate. However, if there's a bug, like now, this also drops perfectly healthy, good behaving peers.


Fuck people building from Windows, amirite?


do we need this?


deliberately


I like this change on restricting certain glyphs.
Any ideas on how I can add this visually on the website?


done


ok, done


keepalive runs as root and he's the one firing the script


reack


This can never return true.  If it was true on entry to the function you make them equal.
Suggest you just return true inside the if and false outside.


As I understand it, this is the function provided to the scribe package to invoke the file module as its file system scanner. Could you add a few comments to explain that whole logic in the code?


reacj


@avg-I I thought that I had added `lzc_promote()`. I must have neglected to commit it to the repository. I had been holding back `lzc_rename()` until i was saw that I had something sane.

As for the RPM targets, I had not tested them. I will see what needs to be done to handle the man pages there.


TeamCity DNN JavaScript Libraries :: CI [Build 36](http://teamcity.engagesoftware.com/viewLog.html?buildId=304&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


Have you tried to compile without ipv6? Are there any side effects like missing "data usage" menu in ROM settings?


TeamCity DNN JavaScript Libraries :: CI [Build 36](http://teamcity.engagesoftware.com/viewLog.html?buildId=304&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:5


mistake?


Original approach was to throw an exception if property does not exist, but that is not in-line with how the handlebarsjs library behaves. It treats non-existent properties as a perfectly acceptable case, hence our UndefinedBindingResult.


@DeepDiver1975 `$data` is a pretty general name – it doesn't really describe what's inside the variable.

IMHO it would be better with:

`public function convertLinks($html) {`

`$htmlWithLinks = $linker->linkUrlsAndEscapeHtml($rawHtml);`


done. technically `public` is also redundant but i find it's nicer to keep that.


Hi, there! I changed something in cm-12.1 tree. Those may be usefull, but no about that camera recording. Just a little thing: https://github.com/ferhung/android_device_kingzone_k1-turbo/commits/cm-12.1


I'm not sure if we should do it.
Isn't it better to try to use the file passed as arg and eventually fail so the user can try to solve the problem instead of fall-backing to default path?
It can be a missing permission, but it could even be other tool.


Using `s8` for `char` is bad idea, it's incompatible with strings and thus becomes hard to use. Probably @AlexAltea suggested using s8, but I strongly disagree. He may be right about `bool`, but `char` doesn't have any problems such as unknown size/alignment and using `s8` is just inconvenient and unclear.


vim fail! :trollface:


This is a breaking bug, can this fix be pushed to supermarket?


It's still very rough, but take a look at [django-postgres-copy](https://github.com/california-civic-data-coalition/django-postgres-copy). My goal is to make the kind of thing we're doing here as easy as possible.


my guess is that the `Path` has more than just the score and edges (eg the graph)


What is the purpose of this?


I'm pretty sure I tested this for #1207, so my compiler probably ignored the above since they were actually not used.


@gkalpak As for the unit test, CLEARLY, it's right here: https://github.com/angular/material/commit/f687475160eb17c17864f57c57c7ac95fa9b5658

>_>

<_<

>_>


sqlite_timeseries (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1240 of 1240 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.97%25-green.svg)


Shouldn't we accept 'average_inc_pad', 'average_exc_pad' and 'sum'?


Оформление кода!?


What is the purpose of this change?


Right, that should not be a problem in prod because there is no data there atm.  I recommend you delete all the data in all the github tables before upgrading your schema.


I think the idea here is to be able to run it in a standalone way.
$DESTDIR won't be set out of the build, right?
So in the end if you run this tool default path would be /usr/bin/sol-fbp-to-dot

If you're running in the build (make cheat-sheet), the correct directory will be passed as argument


So did it help you with fixing camera FC bug?


yeah, you're right


Actually right now is not needed because this userFolder is only used on rootFolders method. And this user context is activated before this.

If you remove the [self activate] method before the [self userFolder] call, the `lookupName` methods will use this container and the sogoobject returned will be wrong.

Long story short, it doesn't matter which value you use as container, won't be used, so better to use nil.


Yes.


Submitted upstream
https://review.openstack.org/#/c/202154/


Yes, you're right. We only need to write to the file if something's changed. Thanks.


> 8 minutes ago
> DeepDiver1975 pushed to master at owncloud/mail
> @DeepDiver1975 e187b23 Fix JS error - fixes #847

15. 7. 2015 NEVER FORGET


That should do it.


another way of doing this would be to call `file.ParamsParser()` with an array of arguments:
```go
    var fArgs = [...]string{`-path`, r, `-name`, p, `-maxdepth`, fmt.Sprintf("%d", depth)}
    run.Runner.Parameters = run.ParamsParser(fArgs)
```


Hey, thanks for making facetype!

I made this fork because I was having problems using Japanese fonts in three.js. Trying to convert the entire font produced a 30mb+ js file, so I had to use this workaround to restrict the glyphs to only a very small subset of Japanese.

I thought about working on something like an options panel that would let you select the range of glyphs you wanted to include and submitting a pull request for it, but figured it might be too niche of a feature. I imagine the simplest way to do it would be changing 12288 and 12543 into variables linked to another input field. I might revisit the idea before too long.


Inicio del repositorio


Inicio del repositorio . . .


`e` - предложенное эклипсом имя, оно используется у них во всех библиотеках и возникает в сгенерированных методах. И у майкрософта тоже. Это очень плохо гуглится в силу краткости запроса, но по какой то причине эта практика вообще везде. Я не очень понимаю претензии к названию конкретно этой переменной.


Hi, are you not planning to push those changes to the official repo?


I originally used u32 instead of void, because CellSailMemAllocatorFuncAlloc would need to return the address of memory allocated. I don't remember anymore, why I did replace all the other voids with u32. As for the other points, I will address them in a future commit.


Why not use the standard way of invoking a module?
```go
run := modules.Available["file"].NewRun()
[...]
results = run.Run(parameters)
```


OMG!!


done


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


At first glance, I'm not sure that we need to modify the `file` module to achieve this task, but I can be convinced otherwise...


It was causing issues at the time. I've checked again, and we missed a place. I fixed it in 8109bd85c0ff3fb01d81849e444894e44bf28eed. Thanks for reporting that ;)


Good job :+1:


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/15160/testReport/) for this commit**


This is just an empty file with no real purpose
42 is the answer


Blarg!!! One more fix.


The "install from sources" instructions in the manual need updating too.


I don't see any "Names" field in the objects returned as array by `/containers/json` --> https://docs.docker.com/reference/api/docker_remote_api_v1.19/

Is this an undocumented feature ?


Ah no no, just bug reporting :) this one:https://bugs.eclipse.org/bugs/show_bug.cgi?id=472597


How did you spot this?  Did something give a warning?


Yeah caught it right after I committed it! :fire:


So I wonder whether `QueryService.getContainerByName()` really works for you ?


пробіли після ком


this console.log is deleted in a later commit


Could you add an assertion that checks stdout for the error message?


Not consistent with instructions on [Jul 10](https://github.com/openhab/openhab/pull/2891#issuecomment-120445715) that only the UI controls how many digits to show.


yes.


bescht gramatick


вже немає self.tutor_email


I've had to use both, depending on the machine I use and the default system
Python.

On Tue, Jul 14, 2015 at 6:59 PM, Deepak Chandan <notifications@github.com>
wrote:

> It is quite interesting that the original code worked for you. Are you
> using python 2.7.x or 2.6?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NCAR-CISL-ASAP/PyReshaper/commit/df12add2eb77fb230df8759c9e39fc25e8aab45e#commitcomment-12169136>
> .
>

--
____________________________________________________________
Kevin Paul
The National Center for Atmospheric Research
Computational and Information Systems Laboratory
(303) 497-2441


Taking the time to report bugs in the official way is already a
contribution!

2015-07-15 17:29 GMT+02:00 Andrea Richiardi <notifications@github.com>:

> Ah no no, just bug reporting :) this one:
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=472597
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laurentpetit/ccw/commit/f7859929bc6f1d5826ebc3f1862c95b23838bf13#commitcomment-12181988>
> .
>

--
Laurent Petit


not a big deal. i'll leave as is


1: M101 signature is missing
1: M190 line is too long (52 > 50)


This should not be in this commit as it is entirely separate from the state machine work.


I think it would be clearer to make the variable `password_validated = False`


Done in the latest commit.


запятая перед "используя"


this should be done once per loop and use `count += 1`


Why the entire div is now a link without any href? It will stay as div and will just receive an ng-click event.


Using fs.statSync now.


Yep, I just saw that, fixed now, thanks!


add `continue` after this line so that no validation happens if the passwords don't match


yeah cmake build was complaining.


Thanks, Ben!

I'll check it out and incorporate the fix over the weekend!


Reask: Why does a document have to be assigned to the list to appear in the list? Isn't it enough to just assign the document to the list?

I wonder about the 'AND'. Why are there two condition that have to be met?


Hmm.  I understand that this might not be intuitive, but making this change results in behavior changes with the PyReshaper that are inconsistent with its documentation (see the PyReshaper's docs/source/manual.rst).  In particular, making this change means that a verbosity=0 will still print output, which seems counter-intuitive to me.


Do you remember which AMI was used? Try with `ami-c1ad79aa` (RC3; now the default on launch.usegalaxy.org with an update to `cloudman-test` bucket to yesterday's source tip). Some of the changes over the past week required a new AMI so it's likely that. The one-up-in-the-log-chain file to look at would be `/usr/bin/ec2autorun.log` and see if there's an error message captured there.


Passing the Request instance created on line 40 in place of the SymfonyRequest class given to the method caused the tests to behave as expected, with clean error logs, passing tests passing, and failing tests failing.
Seems like it works!


I don't think `ugettext` is needed.


> Filenames should only end in `.md`

He writes, in a file called `README`...


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/15161/testReport/) for this commit**


here is my comment.


@drgroovestarr I never left github in the first place.  Where do you get your information from?

@Cl3Kener The only thing in AOSP is gcc configuration which is not exactly to the tee like yours or SaberMod's.  And you came up with the renamed sysroot all by yourself right?  GTFO.


ок


так, вже виправив бо не працював Action


Might wanna look at the code for Male/ Female and see if there is another way of selecting?  Merging now


remove


Request for review.


Awesome work!!!

Once you've cleaned it up I'd love to offer some suggestions for other clean ups.


Shouldn't this be streetSuffix?


We've seen differences in behavior even with relatively new releases. The goal here is to ensure everyone is building using the same or newer version to avoid regressions, and avoid spending time investigating bugs that are a result of using an out of date compiler.

Is it a problem for you to upgrade to a newer release?


I agree the use of Sync could be a problem but I am not sure if it's possible to remove ALL instances of Sync. It's certainly possible in some parts of the code, but not in others. For example, ACL is designed to work sequentially and It would be nearly impossible to use the async methods without a rewriting of the code far beyond the scope of this PR. I say we leave this like it is for now since it works and we should aim for correctness before worrying about optimization.


Hey Awesome post in AntiPattern.

So I'm looking at your code and I'm unclear what direction you'd like me/anyone to take with the code review.  Is the point that the method works but that you feel it is a bit messy and you'd like to clean it up ?

Is there an edge case that is or is not working that you'd like better address ?

:+1:


Two kinds of selfs


I find "Schnellzugriffe" a bit weird in this context, don't you thinkg @mariobl ?


Can you explain the difference? For the purposes of this example they seem similar enough.


Плохо читается. Были места, где вложенные циклы работали с переменными `s`, `c` ... в общем хрен поймешь. Стандартный паттерн - имя переменной совпадает с именем класса. Если тебе кажется долгим писать, то заведи отдельную переменную `gc`. Где-то выше я делал пример. Не игнорь замечания.


@jdalton I've fixed most of these in https://github.com/reindexio/youmightnotneedunderscore/pull/7

Thanks again for the review!


Done


Done.


Can you make the description the same as on the front page, please? "MidoNet is an Apache licensed production grade network virtualization software for Infrastructure-as-a-Service (IaaS) clouds."


Isn't what I am doing right here ?


1: M101 signature is missing
1: M190 line is too long (52 > 50)


Made the changes.


I don't think so. Pluton was the first mod that supported Rust experimental and it was featured on some rust devblogs.


Is there any compelling reason to double the size of the script and effectively duplicate code just so you can add another dependency (argparse)?  I would be in favor of these changes if optparse could be removed completely, in favor of argparse, but keeping both around seems messy.


i never meant to lie i was tierd


This will still work sequentially, but it won't be blocking

```javascript
fs.statSync(function((err, smt) {
  fs.statSync(function((err, smt) {
    fs.statSync(function((err, smt) {

    })
  })
})
```

Ok for the optimization point


r+


Puedo hacer un PR sólo de esta parte?
No sé porqué ahorita que intenté hacer el PR también me jala dos 2 commits del PR anterior, que además lo hice en otra branch.


no bullet point needed here; maybe rather "Enter drücken um mehrere Namen hinzuzufügen"; also no exclamation mark


Rewrite links on apache2 and remove the useless "/index.php/"


Sweet :)


mixed tabs and spaces look like wrong indentation in github diffs


indentation


If we're using compiler features that are that close to the bleeding edge,
we're setting ourselves up for problems - that's the bigger, nastier,
meta-issue (from someone who has been cross-compiling with gcc for well
over 20 years.)

I would expect this to go over in the user community like a lead balloon.
Wearing my customer advocate hat, I want to say I think it's another
sleeper issue we're creating for ourselves.

I can upgrade, sure - but please make it obvious somehow when you bump the
dependency, because that will add time & complexity to everyones work.

On Wed, Jul 15, 2015 at 10:40 AM, Matthew McGowan <notifications@github.com>
wrote:

> We've seen differences in behavior even with relatively new releases. The
> goal here is to ensure everyone is building using the same or newer version
> to avoid regressions, and avoid spending time investigating bugs that are a
> result of using an out of date compiler.
>
> Is it a problem for you to upgrade to a newer release?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/spark/firmware/commit/bcd4e51f74f7b2a59bc24b641895b602193d0921#commitcomment-12182362>
> .
>

--
Andy


done


Need in formatting, why cant I do it from Github?
README.md support markdown?

Here can be some mistakes in names, please check it.
Should write duties of team members!


It does, the precision of the device is to 2 decimal places, and this is returning an additional level of precision. This is following to the Significant Figures and Significant Arithmetic rules which is widely used with scientific data. See the Javadoc above.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 144](https://teamcity.labkey.org/viewLog.html?buildId=261110&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 1 Build time: 00:03:55
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.initializationError: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


Okay, on second thoughts...I guess they should not be the same. And I guess putting the same as in the title is not good either, right? But this description is terrible - it doesn't say what the page is about at all.