Why this change?


This changes the behaviour. I don't see why this should be needed?


Fixes #15


Updated the wiki and changed the config.html to add a little note saying to
change it to 0.0.0.0 to allow outside connections
On Jul 8, 2015 1:47 AM, "Bas Stottelaar" <notifications@github.com> wrote:

> Don't forget to update the Wiki, as this will prevent access from outside.
> I can imagine a lot of issues on 'why can't I connect' :-P
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rembo10/headphones/commit/f131d316caf146fd145ec4ca947a80c073803b7e#commitcomment-12056411>
> .
>


Agreed. Keeping it for now and filing a bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1181705


sample_size is a better name.


boundarylist can be initialized outside this if/else statement.


Will put in form validation and error checking next


Both sounds good. I didn't see another property when glancing through `res`. I'll tack that in.


@leahpadgett DWMR. Nice job here. You've completed the major section of the foundation work. Yahoo!


:D You're welcome.


This is failing Scala style checks:

```
[error] /home/jenkins/workspace/SparkPullRequestBuilder/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala:342: File line length exceeds 100 characters
[error] (yarn/compile:scalastyle) errors exist
[error] Total time: 9 s, completed Jul 8, 2015 12:03:30 PM
[error] Got a return code of 1 on line 133 of the run-tests script.
```


"Throwing niggos" its rasist


[Deployment available online](https://s.brightspace.com/lib/ifrau/0.4.0/ifrau.js)


Will put this in readme later, but currently the client relies on MSMTP, technically it could work with any mail sender, but MSMTP seemed to work best. This does require a change in the servers php.ini, I'll write down the steps later.


:+1: Looks great. Thanks @gbinal


Thanks!  That is a much more elegant solution than the one I came up with.


It could be `COPY` everywhere, it seems.


It's a LBS (lazy bytestring), not a builder. So unless ppShow cannot show LBS's correctly, it should be fine.


oh, ok, no worries, thanks for doing that


It will be in beta-6. I expect to have **something** checked in for this today, but it's likely there will be lots of tweaking.


@abengelbrecht this change has been made to the docs: https://drill.apache.org/docs/using-jdbc-with-squirrel-on-windows/. Please close this pull request.


first answer will be `1` not `2`. `1*1=1`


Well, hell, I'm not sure in this case. My initial impulse is to follow the Puppet variable [naming standard](https://docs.puppetlabs.com/puppet/latest/reference/lang_variables.html#naming). But then we use things like `/var/log/pe-puppet` and `gem-home: /var/opt/lib/pe-puppet-server/jruby-gems` (latter from pe-puppetserver.conf). Digging through `/etc/puppetlabs` on a 4.0 build reveals more examples of dash-separated path and file names.

Let's go with dash-separated, so **this should be `/etc/puppetlabs/code-staging`**


Why these numbers?  If we are testing boundaries, then use the boundaries. 0 and 4294967295 or (2147483647 for signed integers).


I'm not sure what this is?


The amlogic default is ~32mb as it was, but an alternative amlogic codepath (unused) does put it as 3mb. Lets give it a try.


I think the original tablet and phone values were for each side. (I think the original intent of the desktop one was _also_ 60px on each side, but it should now be 30px on each side.)


Hi, thank you for your answer. Here's what I'm trying to do, hopefully you can't point me to my mistake:

I have this menu:

![captura de pantalla 2015-07-08 a la s 13 53 16](https://cloud.githubusercontent.com/assets/13223064/8579203/d1ae7468-2578-11e5-85eb-b90b4083a33a.png)

Everything is inside the text separator just for SEF url's purposes because I want the URL's to be mydomain.com/candidatos/item.html. This is something I usually do with joomla and works fine using the menu start level option.

Now, that's the menu for a specific section of the site, not all the site, so I created an override (or outline in Gantry5) for that section and assigned it to all the items in that menu, this are its settings:
![captura de pantalla 2015-07-08 a la s 13 51 10](https://cloud.githubusercontent.com/assets/13223064/8579335/976ad5c0-2579-11e5-8fc4-c4110cf95973.png)

But I get a white space in the menu:
![captura de pantalla 2015-07-08 a la s 14 01 31](https://cloud.githubusercontent.com/assets/13223064/8579388/e636c218-2579-11e5-929e-f2100d432dbe.png)

If I reset it to 1:
![captura de pantalla 2015-07-08 a la s 14 09 01](https://cloud.githubusercontent.com/assets/13223064/8579558/e89abd06-257a-11e5-8138-433599aff9aa.png)

I get this:
![captura de pantalla 2015-07-08 a la s 13 52 51](https://cloud.githubusercontent.com/assets/13223064/8579563/f1871540-257a-11e5-9ff2-7b445e01ac1e.png)

Thank you for your time.


:+1: Nice custom task! It looks like you even added a progress bar too. How well is it performing in comparison to the previous implementation?


I feel like this would be more clear if it said "Max content width: 1170px".


fixed


fixed.


it's a feature that is not fully implemented yet; each group will have an associated admin group; membership in a group will grant the ability to view and initiate scans, review issues, etc, membership in the admin group will grant the abillity to add/remove sites, add/remove users to that group, etc.


I know it's not part of FastClick, but I've looked lots of places on StackOverflow to try and find the answer to this and I see you're having the same issue: visit this page on an iPhone using iOS8 (really I think any iOS version will have this problem) and scroll down so that the A and B boxes are in view _and the input is out of view_. Notice that when you click the letters it doesn't scroll the page to center the input. _Only when you physically tap_ the input does it center. Again, I know it's not your focus (no pun intended lol) with this plugin (which I'm currently using and loving btw) but any ideas?


Probably going to make this a bit larger in the database.


Nice idea changing the brightness steps from 16 to 5. Before, going to max brightness took a bit of practice and many button presses, sometimes accidentally wrapping back to lowest brightness. Much appreciated!


Hm, I definitely ran scalastyle before I submitted this one. Let me see if this was a failure on the previous commit or this one.


thanks!


Is this where this is deployed? https://jtrans.meteor.com/


@srowen I think we're going to hotfix.


88737258-EPW-Ruby-Access (jasondegraw) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Huh! I didn't know diff's were so nice on gitHub!


Good to merge.


*state is always CELL_NET_CTL_STATE_Disconnected. you forgot 'else'.


typo


Nope, that's my fault x2 then. Just wrap the line earlier by one arg?
I really botched this merge.


Might be more Polymer-y to use

```
<style is="custom-style">

    :root {
      --tooltip-x-position: 10;
    }

  </style>
```


Does it make sense not to have the large icon in the notification?


Thanks :)


I have `HANDLE	Process;			//!< Handle to the crashed process.` so I think I could use `GetModuleFileNameEx`. However I'm not sure how safe it is being that the process is crashed.


> That way users know what they're asking for.

Sounds wise :smile:


Using 2>&1 works, and the output is processable: I'll use "J.*xz" as the pattern to match that line.


@astamp  :-)


HI @remdex,

Just a tip, im sure you would have already spotted it, but to have the field highlighted you need to use the CSS Class "has-error" on the container and add the class "control-label" on the label text, this make the both the field and label red.http://getbootstrap.com/css/#forms-control-validation

To get the checkbox highlighted you might need to do something like this:


Unless I'm mistaken this function and some others too are MFC.


We can replace this for using any GAM model, e.g. also LogitGAM, but also for GLMGAM we need keywords like family.

I wouldn't try to generalize this for other models than your GAM models in the first round, i.e. think about replacing the spline parts above at a later point.


This shouldn't make any change. The only relevant order should be the declaration in the class definition. To quote the standard:

>12.6.2.5
>
>Initialization shall proceed in the following order:
>...
> * Then, nonstatic data members shall be initialized in the order they were declared in the class definition >(again regardless of the order of the mem-initializers).


I would remove that part. Because it creates awkward pictures when rownames are turned off. Like this:
![blah](https://cloud.githubusercontent.com/assets/181403/8579783/972760fa-2584-11e5-81ba-748b25482d25.png)


:bell:


possible problem: do we get the same knots and basis functions for the test data as we do for the train data?
for example know selection depends on data min and max. ?


`SetWindowPos(m_hWnd, HWND_TOPMOST, ...)` I'm setting it top-most though so I'm not sure right now.


This still looks incorrect.  The **value** of ``self.valid_ssh_key`` is not being interpolated into the pattern string here as one would expect.


Hopefully this solves Issue #1 .


Not really a catch. Previously, speed was exported by MovableEntity. Since I removed this attribute and added it to the missile, I had to do that.


You are to late :) because code was already pushed, and yes it was done with control-label has-error etc stuff...


@Hypn0 Please, review it


```
src/filesys.cpp: In function 'bool fs::RecursiveDelete(const string&)':
c:/devel/home/Diego/src/tmp/minetest/src/filesys.cpp:145:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
```


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/d076ebf30042fa49447d4ecd1ea51c0774907434/index.html)


```
src/filesys.cpp: In function 'std::string fs::TempPath()':
c:/devel/home/Diego/src/tmp/minetest/src/filesys.cpp:186:35: warning: deprecated conversion from string constant to 'fs::LPSTR {aka char*}' [-Wwrite-strings]
```


```
src/util/srp.cpp:497:13: warning: 'void srp_pcgrandom_seed(srp_pcgrandom*, long long unsigned int, long long unsigned int)' defined but not used [-Wunused-function]
```


Ok.


I had created the function but forgot to call it (since no effect needed to restore any state previsously)


[Deployment available online](https://s.brightspace.com/lib/ifrau/0.5.0/ifrau.js)


yep. I will fix that


I would remove that section because it would give awkward pictures if rownames are turned off. See:
![blah](https://cloud.githubusercontent.com/assets/181403/8579912/6b45dbf0-2585-11e5-8714-35af6468aeb4.png)


Does this work if groupOwner is NULL?


Bah - I just introduced that bug (with the change to make-pins.py). Previously make-pins.py would calculate how many alternate functions existed, but I had to make the change when some of the af entries were controlled by #if's so make-pins.py no longer knows how many entries exist.


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/2585bc6a8e74f86fd2501f41e1248117c52c8978/index.html)


Nit - extra line


No, not the researchmanager. We have a RoomManager, TrapManager, SpellManager but not for research. However, I'm on it ^^


Good move, however common.h cannot be found from within src/client/c/io.c.


This commit introduces the following compile failure for me:

    dictionary_package-conjunction_entry_io.adb:18:14: error: missing body for "Put" declared at dictionary_package.ads:479
    dictionary_package-conjunction_entry_io.adb:18:14: error: missing body for "Put" declared at dictionary_package.ads:483
    dictionary_package-conjunction_entry_io.adb:42:14: error: "Put" conflicts with declaration at dictionary_package.ads:479
    dictionary_package-conjunction_entry_io.adb:47:14: error: "Put" conflicts with declaration at dictionary_package.ads:483
    dictionary_package-interjection_entry_io.adb:18:14: error: missing body for "Put" declared at dictionary_package.ads:504
    dictionary_package-interjection_entry_io.adb:18:14: error: missing body for "Put" declared at dictionary_package.ads:508
    dictionary_package-interjection_entry_io.adb:45:14: error: "Put" conflicts with declaration at dictionary_package.ads:504
    dictionary_package-interjection_entry_io.adb:50:14: error: "Put" conflicts with declaration at dictionary_package.ads:508


Since I am already on it, I didn't feel the need to create an issue. But you are right, it is better as it allows to know what I'm on.


Brilliant!! Thanks a lot for this demo. I'll try to implement it this weekend.


MCZipMac.mm is referenced twice here?


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/45302e5756d93879b9b435b223f5671f2e28e74a/index.html)


Yep. Every mode can know the hand position (allowing spells to check the closest entity to the hand and decide where to cast the spell)


add input and output file


xvbxgvb


fixed


don't happen mailcore2-XXXXX, just append mailcore2.
Also, please return a mailcore::String instead of a std::string.
MCO_FROM_OBJC() will convert an ObjC string to a mailcore String.


Indeed. :smile:


possible solution https://github.com/sugarlabs/sugar/pull/553


And please create the directory here.

Here's it's suggestion to append [[NSProcessInfo processInfo] globallyUniqueString].
http://nshipster.com/nstemporarydirectory/

Please follow what's described in this link.


Don't create the directory here.


haha, your too quick for me, very well done :)


“in these hook” → “in this hook”.  And possibly “execed” → “executed”?


+1 thanks for that


Я в ините обычно оставляю настройки приложения
Основные выношу в conf.py, а настройки базы и прочего здесь
Запуск произвожу через другой файл

run.py

from app import App
from werkzeug.serving import run_simple

if __name__ == "__main__":
    run_simple('0.0.0.0', 5000, App,
        use_reloader=True, use_debugger=True, use_evalex=True)

Эти настройки надо бы тоже вынести в conf.py


There are many merge conflicts :unamused:


To have a iOS and OS X version vs linux version, please use #ifdef __APPLE__ #else #endif


This is available as `resource.entity_set.filter(obsolete=False)`.


That one's on me. My bad. I had assumed jQuery returned undefined for a test of an unset attribute.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 120](https://teamcity.labkey.org/viewLog.html?buildId=259826&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:32:54


Instead of storing data, can we just have a start DATETIME, and then have the scan scheduler runner periodically scan and then execute the scans and then remove them from this table?


rax retry tests


https://bugzilla.mozilla.org/show_bug.cgi?id=1181626 applies here as well with regards to fetching entities and translations in a performant way.


FacilityTabGridView (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I use a subinterface for immutable because I don't want people to be able to cast it to mutable. Mutable an immutable should be siblings, not parents/children.


“hook are called” → “hooks are called”.

What happens if one of these returns a non-zero exit code?  Do we abandon any further cleanup?

It's probably better to outline the error handling for each hook in the per-hook section so someone using a given hook doesn't have to go up to the generic-hook level and try and guess about how their particular errors will be handled.


@DMalone87 this is going to be overridden by the specific entity title, right?


TeamCity LabkeyRelease15.2 :: CDS postgres 9.4 [Build 3](https://teamcity.labkey.org/viewLog.html?buildId=259824&buildTypeId=LabkeyRelease152_CdsPostgres93) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:36:01


I will admit that by "more readable" I mostly mean in my terminal, where all the unassigned points end up as `<U+0980>` and the like.


I'll try to remove it. This was aded by XCode, not sure why it doubled the reference.


Btw, you can supply a proguard file with instructions of what not to minify - specifically those properties which are getting animated... That's what Facebook are doing with Fresco


@Bertram25 Note that here, the goal was to have a spell that do not target a tile and selects the creatures on it but to allow player to have a spell that targets the creature closest to where the player clicks.
IMHO, that was a must have and now, we have all we need to easily create new spells.
Moreover, it was also a try for me to see what is needed to create a new spell with the corresponding research and see if we can handle researches on a more generic way.


Super!


o.0 I swear the tests were updated for this when it was commited


I've created the branch amfarrell/tad to test merging master with this.
Deploying to EC2 has 6 salt states that fail. Investigating


dead code, please ignore. I will remove in next push


I'd suggest using the terminology unmodifiable if it's not truly an immutable copy. It's used for other views of objects.

http://stackoverflow.com/questions/8892350/immutable-vs-unmodifiable-collection


This is a test for a commit in GitHub for my hello-woröd tutorial.


I wonder if ````use```` may be a good name, or perhaps ````run````?


@dmcgowan https://github.com/docker/docker/commit/8f56a8ed6876a705934e8f4c5cf8acbec3eb5275#diff-7cbe4277b9a08ded689d34eaae37655eL221


Using [[NSProcessInfo processInfo] globallyUniqueString] will be mixing Objective-C and C++ in a .cpp file; I'm not sure if the llvm compiler will give an error with the langue mix in a .cpp file instead of using a .mm file.


here is still 'one' instead of 'recovery'


It is meant to be immutable, the implementations in SpongeCommon use copies of the data and have no modifier code used internally.


hi. which champion?

2015-04-13 0:47 GMT+03:00 TheErgoProxy <notifications@github.com>:

> I can't really message you anywhere but recently when Laneclearing with Q
> it's been shooting them at the minimum distance every time :/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Esk0r/LeagueSharp/commit/4f64b83d6b48c08b1eba0dd3ff9c592f9e68cc02#commitcomment-10684399>
> .
>


Yay! I've wanted this forever.


Just a head's up: it's common practice not to add your node_modules directory to git, since your package.json should specify which node modules your project depends on, and anyone cloning/forking your repo can simply `npm install` them.


So use only totdissN if all components present - don't calculate totdissN if some components are missing.


I have not changed it to avoid repetition: recovery is just 5 words before.


Why do these have to be extension methods? Why not just regular functions? It's F#...


Love the styling/theme of this.


$ xsltproc --xinclude --stringparam chunk.level 0 ../xsl/mathbook-latex.xsl sample-article.xml
MBX:WARNING: could not translate string with id "introduction" into language for code "en-US"
MBX:WARNING: could not translate string with id "introduction" into language for code "en-US"
MBX:WARNING: could not translate string with id "conclusion" into language for code "en-US"


Wersja z CRUD postów i wyszukiwaniem. Wyszukiwanie zwraca pierwszą opcję pasującą do kryterium


👍 reset


👍 CSS comments. You'd be surprised how helpful these are.


beni oku deneme2


Than events will be implemented too, but onHurt(int damageLevel), onHurtByNPC(obj_npc who), onHurtByPlayer(obj_player who), onStomp(obj_player who), and other events are can be implemented with usage of special AI features - a detecors which detects some cases by C++ side which will work faster (for example, detect players in specific relative zone which needed for thomps and piranha-plants), detects contacts, etc. Detectors will be two types: manual and automatic. Manual detectors will be used for manual checking directly inside onLoop(float tickTime) function, and automatic detectors are calls defined lua function automatically when target condition happened.


What does this do? Where else is the !> operator used? (I'm not crazy on the similarity to the |> operator)


@XinyuHou Code style.


This is probably not going to work appropriately.


👍 using % to determine which symbol to add to the board


I think you could do this

```javascript
if (!string) return {args: {}, params}
```


I think src/client/c/io.c needs to include config.h for HAVE_* #defines otherwise sys/time.h won't be loaded.


ytryyyyyyu


Hi @alicetragedy Sorry, I will do that next time. Anika en Sara advised me to add them here in the comments. I'll do that for now, if that's okay.
Or do you mean you want a Pull Request anyway, also for this photo? Sorry, did not quite understand it.

![cheesy](https://cloud.githubusercontent.com/assets/6314687/8580417/d2472d06-25ba-11e5-8a54-833ab73745c0.jpg)


Is there anyway to get this exception code to report the line number?
`} catch ( const fc::exception& e ){ edump((e.to_detail_string())); }`


writeAuthFile returning false means user didn't pass authentication details


@XinyuHou Hard coded value


Some states also fail on vagrant.


If I were keeping my ES data in a data-only volume, this would conflict.


In fact, apparently `<subsection xml:id="subsection-intro-conclude">` doesn't even appear in LaTeX.  It does appear in html.


Though I have to note that
```
$ xsltproc --xinclude ../xsl/mathbook-html.xsl sample-article.xml
MBX:WARNING: could not translate string with id "note" into language for code "en-US"
MBX:WARNING: could not translate string with id "note" into language for code "en-US"
```
:smile:


A site _should_ only belong to a single group and _should_ be required to to be verified for each group.  So it's a one-to-many relationship and shouldn't require an association table.  This should be changed from how Minion currently works.


hi @F3PiX, that's fine, we can add them if you put them in here, too.
I meant the pull request for your next blog post :D by then we will also have updated instructions on how to do it, I'm working on it :)


right.  too many http libs with too many different request and response types...  sorry!  :)


But the main issue is that if you try to use it as param somewhere you asume its immutable, but someone thought hey i would like to change a block in there so he created a subclass that is mutable but still extends `Immutable`.
`public class MyBadBlockVolume extends SpongeMutableBlockVolume implements ImmutableBlockVolume`
````java
public doSomething(BlockVolume bv) {
if (!bv instanceof ImmutableBlockVolume) {
    // Create a copy for safety reasons
}
// use it
}
````

Also you cannot use it for casts very well


Nope. Not gonna happen


rename to `info`


@XinyuHou


I didn't think we had dispatch on parameter values like this... this error path doesn't look like it's being hit in the tests?


@DMalone87 i think there is some confusion with the order of tags here. This `div` tag has already been factored out in the template here:
https://github.com/permalife/tradewave/blob/darrell/tradewave/templates/tradewave/tw-main.html#L47


Should also have a verified boolean (as well as a verification method and verification key).


do this above your function, like this

```javascript
if (!info.params) {
  ev.listener(res.message);
  return;
}
```


should we just move this code to ua_server.c? just adding another folder "Matrix" next to "Scalar" and "Array"?


Which corresponds to this `div` in the old "home" template:
https://github.com/permalife/tradewave/blob/darrell/tradewave/templates/tradewave/user-home.html#L36


@olafhering why didn't you just replace .cls with .audio_remote_control_id - what does this other voodoo do? *yeah yeah i can rtfm i know...*


Also a description field.  :)


Similarly, this `div` has been factored out here:
https://github.com/permalife/tradewave/blob/darrell/tradewave/templates/tradewave/tw-main.html#L55


ahh now i see it ... those autoconf diffs are hard to read via github imo...


dist tag syntax is incorrect. Please modify it to  %{?dist}


And I think you have two titles somehow now.


@XinyuHou Still needed?


import letterFrequency

class Story:
    def __init__(self, *args):
        self.text = args[0][0]
        self.categories1 = args[1]
        if len(args) >= 3:
            self.categories2 = args[2]
        if len(args) == 4:
            self.categories3 = args[3]
        self.letterFrequency = letterFrequency.charanal(self.text)

class Category:
    def __init__(self, attack_type, keywords):
        self.attack_type = attack_type


better to do an undefined check so that `<TextInput editable={undefined}>` matches `<TextInput>`.


This should probably be longer, for sites that require things like LDAP DNs.


PII


omg aeoi y u do dis laten 2 me


It looks like `hieradata` is incorrect in the normal `/etc/puppetlabs/code` location, see https://github.com/puppetlabs/puppet-agent/pull/230, it would be good to fix that here too.


I think all we need is the text for the title because the `div` has already been factored out:
https://github.com/permalife/tradewave/blob/darrell/tradewave/templates/tradewave/tw-main.html#L48


@XinyuHou


My brain still thinks in terms of OOP. I can make them into functions.

Do you think these signatures make sense:

let findOne collection filter = ...
let findOneById collection id = ...
let insertOne collection doc = ...


OMG BCUS I SED SO GAWDMAYN


This will return a String representation of the current DateTime when passed `null`. Is this intended behaviour?


Basically, my idea was to override these two blocks:
https://github.com/permalife/tradewave/blob/darrell/tradewave/templates/tradewave/user-home.html#L37
https://github.com/permalife/tradewave/blob/darrell/tradewave/templates/tradewave/user-home.html#L39-L58

Let me know if you prefer to do this differently.


This is one of the odd times the C preprocessor can be useful: check_condition(condition) can be defined as a macro that calls check_condition(status, message) with message pasted together from the condition, __FILE__, and __LINE__.


“Hooks allows” → “Hooks allow”.


@bradenmacdonald Thanks, good to now for next time.  Since the UX review, this isn't yellow anymore, so I can't make this change. :-)


97648758-VentSlabCoolCoilOutput-4978 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1168 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


You're fine if you're doing it in MCZipMac.mm. mm = Objective-C++ and can mix Objective-C and C++.


@XinyuHou Code style


@masashiAbe
もしかしてはまってるのはここのロジックですかね？
ActiveRecore::RecordNotFoundはrescueしなくてもよいと思います。
ActiveRecore::RecordNotFoundは404が勝手に返るのと200以外はフロント側でレスポンスの内容は見ないのでよいと思います。


I think the == operator works on DOM nodes, and this for loop is a bit messy (`$(parent).parent()` is a bit confusing). I'd prefer to see something along the lines of...

    var curNode = staff, indent = "";
    while (curNode != rootNode)
    {
        curNode = curNode.parent();
        indent += "\t";
    }
    (add text node)


97643186-ABUPS-total-row-not-match-water (mjwitte) - x86_64-MacOS-10.9-clang: OK (1678 of 1678 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yeah. Best alternative is probably genericize it as I mentioned above. Pretty sure you can automate this as above, and I'm also pretty sure if this happens to occur at a different indentation level, you're out of luck.


Converting this value to static allows this value to be changed by '-connperip', but It looks like nothing is actually reading this value.


@nathansobo On the browser side you can call `browserWindow.webContents.copy/paste/etc()`.


你这太搞笑了
放点猫片


Neat!


Why do this?


そもそも、rowCount()は、SELECT 文だと動作保証されてないから、
query() を使って、SELECT COUNT(*) SQLを発行して、
fetchColumn() 関数で、件数取得しないとダメだと思う。
今のソースでも、とりあえずは動くみたいだけど。
http://php.net/manual/ja/pdostatement.rowcount.php


test


Confused; 1) I don't see how this is significantly simpler, really, just different; 2) I don't see any change that affects whether 'ubuntu' is a default anywhere.

Tests are good, but why churn the code without functional change?  Am I missing it?


merging now.

see [aurelia/binding/src/ast.js](https://github.com/aurelia/binding/blob/master/src/ast.js#L11-L17) for updated source

and [aurelia/binding/dist/amd/aurelia-binding.d.ts](https://github.com/aurelia/binding/blob/master/dist/amd/aurelia-binding.d.ts#L60-L61) for updated automatically generated .d.ts file :+1:


You seem to be really good about Allman styling, so I'm gonna ride you on it


de-indent?


why switch to double quotes?


When you call `build:inject-javascript` it's already calling `build:javascript`, so, there's no need to call both of them here because it will be called twice. Am I right?


I'd rather see .closest() or whatever the function is here instead of three parentNode calls.


for django-haystack==2.4.0 use


18行目のログイン判定、レコード数が1件かで判定しているけど、
テーブルの構造上、 同じメールアドレス・パスワードのレコードが登録される場合がある。
DBの定義を修正して、PKをメアドにするか、0でないなら成功と判定するかしないとバグる。


Ideally, no - vida gets the width of the page to generate the SVG, so it should never be bigger than the vida viewport.


这代码的前提是non-strict，显然不是很好。原来的写法不是挺好的。


Editing and merging...


paging Dr. @ahankinson - how do you feel about this ternary operator? I'm pretty sure this is code from Laurent cause this does not look like my style, but either I or Michael can clean it up if this looks too weird for you.


We use ReadFull because that's what the Go otr code is using - since it's an actual error if it can't read as much as it wants, I assume.

I'm completely fine with implementing the TrustworthyReader in terms of the ReadFull function and simply rewriting the ErrUnexpectedEOF into an EOF.

I guess the problem with the way Go handles errors in this cases is that in most IO, EOF is not really an error - it's something that happens sooner or later always when reading, while ErrUnexpectedEOF is an actual error.


483 行 有问题吧.应该为 this.settings[i] = key[i];


고생 많으십니다!


saw approval from JeetKunDoug
at https://github.com/basho/riak_kv/commit/eec608ff6ffb3a5eeb6c3f03cd2088f7b8acda91


merging basho/riak_kv/forward-merge/zl/2.0-into-2.1 = eec608ff into borshop-integration-1150-forward-merge/zl/2.0-into-2.1


basho/riak_kv/forward-merge/zl/2.0-into-2.1 = eec608ff merged ok, testing candidate = 081ecaa1


It is bad programming practise to commit code without testing!


Good points!


This seems like premature optimisation.  Postgresql does some aggressive caching anyway. I'd rather simplify this to just r/w directly to the database.


This glitch only happened when you were resizing the console, not when you resized the page?


这是一个新git


The CREATE TABLE for LeaderboardGlobals can have a CHECK constraint added to enforce the current_week value.

```CHECK (current_week > 0 and current_week < 54)```


Shouldn't we ignore `resources` folder?


remove this, and if you want, see if this works after removing 794-798 as I don't think this should apply with your new regex change.


nit - the triple quote should be on either line 16 or move the text from make the comment 3 lines including quotes.


I just realized that the cached_instance is also going to break sessions, so you're going to have to remove it.


docstring here please. It's unclear what is_week_rolling_over means to a naive reader of the code.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2168


I would change this to just something like :

```
def get_globals(session):
  return session.query(LeaderboardGlobals).one()
```


part of #2302


I assume you were using e2size as an example, please add it back :)


See https://github.com/formly-js/angular-formly/issues/383


```
with session.begin(subtransactions=True):
  lbGlobals = LeaderboardGlobals.get_globals(session)
  lbGlobals.current_week = actual_week
  session.add(lbGlobals)
```


97643186-ABUPS-total-row-not-match-water (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1684 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


See my project - https://github.com/edgardmessias/yii2-firebird


i hate dates.  i always screw up the base-0 or base-1 indexing. thanks for the comment.


testing...  sorry!!


What if filePath already ends with a slash?


Thanks. I would really like to get your fix the easy way, and appreciate
you asking upstream again.

On Wed, Jul 8, 2015 at 11:21 AM, Gary T. DuVall <notifications@github.com>
wrote:

> PR's been open for a while. b3nj4m#6
> <https://github.com/b3nj4m/hubot-react/pull/6>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pperez/hubot-react/commit/f9dfbac6ca664ea6356e901f3151c642b3994885#commitcomment-12051887>
> .
>


hahahahah


You are unlikely to need something like this since `image_path` should become an argument like so:

```c
static int get_node(const char *image_path) {
```

And then main would look like:

```c
int main(int argc, char *argv[]) {
    return single_mount(argv[1]);
}
```


97643186-ABUPS-total-row-not-match-water (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1679 of 1679 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Photo


Should be CoreOS, Inc.


This one shall not actually be removed..


show first learning about Github.com.How to use it,and how to get something good from it.


This is already merged...


project created


r+


Use ```return datetime.datetime.utcnow()``` instead of ```datetime.datetime.now()```.  I hate timezones.


No point to this header if the functions are static.


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/0d9cfcd68ce6085c2a0cdad3c29589dee0bf74ae


merging graydon/stellar-core/fix-fuzzer = 0d9cfcd6 into auto


graydon/stellar-core/fix-fuzzer = 0d9cfcd6 merged ok, testing candidate = 83e73503


I did about 45 minutes ago; no worries.


Ask I said in the requirement, the data used to transfer is PathTreeNodeData.


@puffnfresh this is now at https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/programs/command-not-found/command-not-found.nix#L47

just add `<nixos/modules/programs/command-not-found/command-not-found.nix>` in the imports (https://github.com/puffnfresh/nix-files/commit/65e35d1b263b017d757e6eaab765e0bfb7038650#diff-3bf66a45bd84fbb930215c94451201a3R6)


Can you update card-actions with triple equals?


Have you implemented?


Hrm.  We should double check to make sure that MozStumbler is sending in UTC times in it's payload too.  We probably can't even trust that android is properly writing UTC datetime fields.  Argh.


Do we need this? Does the requirement require?


looks good to me


Other than the get_globals change, pretty minor nits.  Nothing else I can see here, but I'd like a couple more docstrings here or there.


ERROR: Name 'FUGA' must match pattern '^[a-z]([_a-zA-Z0-9]+)*$'.


aaaaand, this is why you don't use beta apis. :smiley:


Shouldn't this go in the repository? Instead of mixing repository and model calls logic in the controller? Or why break the pattern for this method?


rax retry tests


I create one similar #3. And closed myself.


@luperezsa aqui puedes pasar el jugador en lugar de ficha y nombre ya que el jugador contiene ambas.


@luperezsa puedes hacer algo como if @jugador_previo!=jugador.ficha


aqui pasarias el jugador en lugar de la ficha.


How can you binding with this?


looks like discount is being passed in as an integer, so I think this is correct


Nice job


aqui recibes el jugador en lugar de la ficha es decir def validar_posicion(pos, jugador)


@DaedalusGame there's href-exploitable things everywhere because I haven't bothered to fix them yet :v


Nice, good to see no more hardcoding of Flights-specific params.


I'm curious to hear @Redjik's thoughts on this, but I do like that the controller at least gets to see an instance of the `$model` as it means that we can do other logic like adding relationships to other models in the scenario that a post request indicates a link to another model.


aqui en insertar tambien mandas el jugador en lugar de la ficha: insertar_jugada(pos, jugador)


Sobran los parametros ficha y nombre, ya que tienes el jugador. Queda algo como insertar_jugada(pos, jugador)


aqui accedes a la ficha del jugador: @posiciones[pos]=jugador.ficha


Remoing this variable will make the footer not stick to the screen in cases where you need it to be below content. This is how you fix the error i got.


Thanks! Unit tests are looking much cleaner now.


好有钱，我 900 多犯人的时候都穷。
被一场暴动产生的火灾烧掉了好多东西。


我都还没见过火灾……虽然经常没事干把犯人全凑一起关一整天让他们暴动


This breaks a custom download strategy based on `CurlDownloadStrategy` where cookie information needs to be passed with a `-b` switch. For example, [this one](https://github.com/indrajitr/homebrew-personal/blob/9d56839e960376145651584916f0fe6508838188/Formula/java-sdk.rb#L6). Any recommendation?


Yes, that's good.

As a whole, I like this PR. There's another open PR for the same thing, but I like this one a lot more. I need to look at it more carefully before I merge it, just give me some time.


Do we tear down the init-ed container on hook error?  E.g. unmounting mounts, closing namespaces, …


88737258-EPW-Ruby-Access (jasondegraw) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.76%25-red.svg)


@Optimusprimeums looking to do a release tonight if possible, are you available for that?


@XinyuHou Code style


Great, someone can report crashes as me now


test


why not use a `map` instead and create a few promises, then use `Promise.all` to detect when all promises are done to emit the actual listener. See this: https://gist.github.com/mdibaiee/0ccdf6259cadd203f8ea


\<OCD\>
Maybe this could be rephrased to be similar to the other spell tooltips: "Casts a spell that increases the speed of friendly creatures on allied tiles".
\</OCD\>


username and emailaddress seem to be the same, so we can probably kill one of them.


a.k.a it does not throw an exception with passed `null`


ok, here's what I would do:
```go
segment := sp.Segment
// if the segment is at the end of the file, we need to trim padding
if segmentIndex == leaves - 1 {
    segment = segment[:fc.FileSize % crypto.SegmentSize]
}
```


This is a comma splice. I'd make this: "...this repository. For more..."


FixDocLineEndings (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1676 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:+1:
Thanks @mlaval @btford


@XinyuHou Code style, should be const or enum hack.


Me gusta! tengo que reconocer que he visto mucho código Platanus que no cumple, pero prefiero el estilo que se propone aquí.


Hi, from what I understand that image was generated using a feedback loop, so you need to let that code block run longer than just one iteration. The particular image you selected is the 29th image in the feedback loop. It might take awhile, so you're not going to get immediate results (in case you're wondering about that).


Harmless.

On 07/08/2015 12:46 PM, kcrisman wrote:
> $ xsltproc --xinclude --stringparam chunk.level 0 ../xsl/mathbook-latex.xsl
> sample-article.xml
> MBX:WARNING: could not translate string with id "introduction" into language for
> code "en-US"
> MBX:WARNING: could not translate string with id "introduction" into language for
> code "en-US"
> MBX:WARNING: could not translate string with id "conclusion" into language for
> code "en-US"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rbeezer/mathbook/commit/cd290ddb8b4f6d4a523da1134e2622325e4ab905#commitcomment-12069936>.
>


Long-standing and harmless.

On 07/08/2015 12:50 PM, kcrisman wrote:
> Though I have to note that
>
> |$ xsltproc --xinclude ../xsl/mathbook-html.xsl sample-article.xml
> MBX:WARNING: could not translate string with id "note" into language for code "en-US"
> MBX:WARNING: could not translate string with id "note" into language for code "en-US"
> |
>
> :smile:
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rbeezer/mathbook/commit/cd290ddb8b4f6d4a523da1134e2622325e4ab905#commitcomment-12070009>.
>


Note that at least currently the C# compiler doesn't cache delegates created for method groups, so I believe each call to this method is going to allocate a new delegate to wrap GetAsn1StringBytes.  Same for all the other call sites here.  If you change the parameter instead to be:
```
(handle, buf, cBuf) => GetAsn1StringBytes(handle, buf, cBuf)
```
it should cache the delegate for you.


Hey @sdwrage why don't you PR this back to the original project?


@XinyuHou Seems like a bad idea


@XinyuHou Code style


:heart: that commit message!


E/MSM-irqbalance(16911): Unable to open /system/vendor/etc/msm_irqbalance.conf
E/MSM-irqbalance(16911): Error parsing configuration file /system/vendor/etc/msm_irqbalance.conf

I get this in my logcat


Actually is the `throws Exception` here necessary?


@digitarald how should I detect which implementation of `window.navigator.mozCameras.getCamera` is present ? (PR welcome) here I'm only using UA sniffing to detect an old implementationof `getCamera`, in all other case I suppose it's the new one. the "feature detection" here is thr `try ... catch` block


@XinyuHou Looks like a bad idea


In my mind, the idea was to do the same for all spell: to separe what the spell does and what it targets. But nice catch for the typo. I don't know where the comma comes from.


Unclky m8


I get an error on the calls to extract_drivers when it tries to mkdir /updates. Do the extract_drivers calls in test_driver_updates need to be called with a temporary directory as outdir?


I'm not sure what's causing the error, but I think the main problem with this is that meteor does not seem to detect changes to the imported files, only the ones that are directly included in the package. That would be very annoying for development. What happens if you add all of them to the package?


Works for me.

Update dev branch, make PDF and search for "Test Two," the title of an enclosed
subsubsection.

On 07/08/2015 12:50 PM, kcrisman wrote:
> In fact, apparently |<subsection xml:id="subsection-intro-conclude">| doesn't
> even appear in LaTeX. It does appear in html.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rbeezer/mathbook/commit/cd290ddb8b4f6d4a523da1134e2622325e4ab905#commitcomment-12070001>.
>


you can add this to your `~/.gitignore`


OK thanks @tilgovi. I'm just learning Docker and wanted to understand if there was some subtlety here.

To your earlier point about cached image (efficiency), it seems that the pattern should be to break the COPYs into multiple ones. The criteria is based on lifecycle of a file. If two files are likely to change together then put them in the same COPY if you can. Then order your COPYs from ones that change least frequently first, to those that change most frequently last.

If I have that right then the current line ```10 ADD . /via/``` it would seem is out of order. Shouldn't it come after the two COPYs on lines 11-12 since those copy files underneath ```.```

As it stands now, if anything under ```./templates``` changes then line 10 busts the cache. Similarly for ```./static```.  So it could be:

```
…
WORKDIR /via/
COPY requirements.txt /via/
RUN pip install -r requirements.txt
COPY ./templates ./templates
COPY ./static ./static
COPY . ./
EXPOSE 9080
…
```

Do I have that right?


Basically in Extensions.fs:26 Builders<'T>.Filter.Eq expects a FieldDefinition FieldDefinition uses C#'s implicit operator to convert from a string to a field definition. I think I have a way around using that though.


Yeah actually your formulation is nice to give a better idea of how to use the spell. My OCD can be put to rest, and maybe later on I'll try to homogenise all tooltips ;)


@jasondegraw I need assistance at line 2458 of daylight.  This was taken out when we added a function called setAlias.  Can you help me get that part working again?


doe this `isLocalToBlock` => `isLocal` change have a functional implication? Maybe we should pimp the `sym` and allow scala-2.11 to use the `*ToBlock` variant.


Mostly: the previous version did it this way. Also the docstring for `shutil.move` says:

> A lot more could be done here...  A look at a mv.c shows a lot of
> the issues this implementation glosses over.

Also, `shutil.move` raises IOError if `dst` exists, so we have to wrap it in a try/except.. but what if `dst` is a symlink? Do we have to unlink it first? We may be copying across a filesystem boundary, so os.rename() won't work, and... ugh. It gets complicated very quickly.

I'd take a patch that replaced these with python versions, but this runs in a pretty strange environment so I'm not yet sure it's as easy as "just use the shutil versions instead". Need more unit tests here, I guess..


Felt weird reading "Straight out of the .tar.gz."

"Straight ouf the tarball" reads more naturally to me.


great work! Did not find any problem/typo.


This is incorrect. When you start the app using `npm run desktop` both the app version and the web version is started. i.e. The app will also be available at localhost:3000


Done in latest patch!


Ok. Then, can I let it as is and let you handle the rephrasing ?


@XinyuHou Code style


I would have pimped `Type` so that you could access `normalize` in one and `dealias` in the other. This might be a common theme.


No good reason yet really. Maybe we don't necessarily have to spell this out in the README? Using packages to test simplifies our testing whereas I've found testing non-package code means trying to test less modular stuff and can be more difficult.

But we aren't necessarily opposed to that changing.


(added advantage of maybe losing a dependency on the reflection API?)


rax retry tests


@XinyuHou Wrong type


Thanks, Fixed

From: Divya Thaluru <notifications@github.com<mailto:notifications@github.com>>
Reply-To: vmware/photon <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, July 8, 2015 at 12:54 PM
To: vmware/photon <photon@noreply.github.com<mailto:photon@noreply.github.com>>
Cc: Alexey Makhalov <amakhalov@vmware.com<mailto:amakhalov@vmware.com>>
Subject: Re: [photon] Added devel package, dist tag. Use macroses part. (bbb1720)

dist tag syntax is incorrect. Please modify it to %{?dist}

-
Reply to this email directly or view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_vmware_photon_commit_bbb17209feb4c48b970bf36a5ef821fdb42d113c-23commitcomment-2D12070092&d=BQMCaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=-haYzmx278tKb9Xx1ELbeFxCo1wTihwGUppL0Nz2QtE&m=2_r3aqCG13tIvmw0XOq5vZMrqI1QgX04OVLayonr5SQ&s=1I0vCEZtfOFB2olik_br7zHngwxEH43kkQwK1nCcWTc&e=>.


Thanks!


Don't use the output of `ls`, its format is unreliable and can vary based upon configuration. Use `find -prune` or `for file in *-debug.apk`.


NB: resetdb uses the NEO4J_DB_PATH variable from the `.env` file


I hate you autocorrect ...


Technically speaking, you only need the one "GRAPHENEDB_URL".

The other variable is only used to reset your DB.


Calling `rows.Scan` leads to reflection.

https://github.com/golang/go/blob/f9ed2f75c43cb8745a1593ec3e4208c46419216a/src/database/sql/convert.go#L153


Is this already tested?


@jaredpar would you care to suggest which approach would make the compiler/output happier?  I'd believe the lambda, but it's contrary to my intuition...


ACID Part:
http://paste2.org/94FPXVWy

@Xfurry pls add this one "Author = @Ulduar"


I think the right lexer to use here would be [`text`](http://pygments.org/docs/lexers/#pygments.lexers.special.TextLexer) instead of `bash` as it is pure output.


97648014-DocIssues4906 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1671 of 1671 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can we move this to Common so you don't need the D2k DLL?


Hi,
I know it might not be necessary or it might degrade the performance of the code, but wasn't the original idea of this piece of code
```php
$this->db->query("DELETE FROM " . DB_PREFIX . "product_attribute WHERE product_id = '" . (int)$product_id . "' AND attribute_id = '" . (int)$product_attribute['attribute_id'] . "'");
```
is to prevent possible error to occur ? It can even correct the mistake made by developers. I think the idea was sanitary check anyway.


I believe this comment should pretty much be turned into a bug report. :)

(I didn't try to reproduce this here yet)


97647908-DocIssues4615 (rglazer2) - x86_64-MacOS-10.9-clang: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I have a patch for you that will do the above. I'll push in a moment.


Can we remove this? This makes it impossible to use the functionality of mapping properties described in https://github.com/elasticquent/Elasticquent#indexes-and-mapping.


Thanks! BitHub has sent payment of  $9.02USD for this commit.


Thanks for taking a look. I noticed that. I was trying to avoid having to add files/import in multiple locations but it looks like we'll have to add them in package.js too. I know stylus supports globbing but not sure Meteor does. I'll try it out.

I found what was causing the error...when I added the dollar signs to variables, I inadvertently added one to a property :/


Thanks for the review!


What makes the identity "trusted"?


FixDocLineEndings (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1682 of 1682 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yeah meteor does not support globbing - we'd be adding each file individually.


`nuke_prefixed_buckets_on_conn` will handle this for you


Strange. It compiles just fine for me - even after make clean.
This especially funny, cause "subprogram_identifier subprogram_formal_parameter_list is null" is just a shorthand for "subprogram_identifier subprogram_formal_parameter_list is begin null; end;".

Can I ask which compiler and what version of it you are using?


Simple or Sample?


LGTM


@bitpshr @itorrey I just noticed this repo is now live, Dylan did mention after the site redesign I'd see the CSS changes etc made but this is the first for me.
Would have been good to have seen earlier having looked through a few of the commits made, just concerned you're maybe pulling old generated legacy docs or incorrect data sources (tree.json/details.json). It's been a while since I looked at dapi but the generated datasources and legacy HTML became a bit messy with multiple repos based on differing requirements.

I'm sure I eventually set what the correct repos should be, also sure I updated the wiki to reflect that but there's still doubt in my mind. There were a number of issues with old generated docs (such as file case on different OS's for generated docs) which meant we modified legacy generated docs.
The fact the source node.js files are copied e.g. generate, refdoc etc, has there been many changes to these? I originally wanted dapi as an npm module, we decided standalone was fine so I guess that was impossible for you to add as a dependency and do any PR's for dapi.

Also noticed you have the .htaccess in there, are you planning on trying to run static API docs via an http server again? If so I'd recommend you don't. It was extremely painful trying to run the legacy generated static docs, with non legacy static docs as well as supporting the node.js runtime (from the datasources) together. There were many hacks (including in the htacess) to try to get this working correctly.
You should only run the legacy docs (which don't have easy to get datasources) with the newer docs (via their datasources) and served over node.js. Supporting an http server as well as node.js was no fun.

This isn't meant to sound hostile but I would have appreciated a way to feedback on what you were planning.

Are any of your changes possible to backport to dapi? e.g. the css?


last writer wins?  might want some comment on what we expect here.


Fair enough. Was following the above example (line 916).


Sooo, do you really want that to be public?


the 'pip' command


Going to be much easier to quantify as an integer: perhaps 1-7, 1-10, or 1-100?


This is a little interesting, due to eventual consistency we may need to loop and sleep for a fixed interval, e.g., 10 seconds.


Sure :)


Just curious, do you prefer "getX()" naming? Recently I've started to prefer the simpler "X()"


https://github.com/andrewgaul/are-we-consistent-yet shows that S3 can exhibit eventual consistency for overwrites in all regions.


Is there a specific reason why you use `mavenCentral` instead of `jcenter`?


Oh, I'm working on the API for converting between different views an mutabilities. Let me get to it first :).


I tried adding a 30 second sleep here before checking the blob and got the same result.


test test


This comment is wrong -- fixed.


would be useful to add labels to the arguments of this function to document what is their meaning. Currently it's easy to do a mistake :-)


This is too generic for all response.status, we need perhaps couple of things to wrap this up properly.  for example for HEAD on bucket operation

```go
        case resp.StatusCode == http.StatusNotFound:
                                errorResponse = ErrorResponse{
                                        Code:      "NoSuchBucket",
                                        Message:   "The specified bucket does not exist.",
                                        Resource:  "/" + bucket,
                                        RequestID: resp.Header.Get("x-amz-request-id"),
                                }
                        case resp.StatusCode == http.StatusForbidden:
                                errorResponse = ErrorResponse{
                                        Code:      "AccessDenied",
                                        Message:   "Access Denied",
                                        Resource:  "/" + bucket,
                                        RequestID: resp.Header.Get("x-amz-request-id"),
                                }
                        }
```

Similarly HEAD on object would have "NoSuchKey" , this way we can make HEAD operations consistent with GET/PUT counterparts in terms of error response up the chain.


typo here


Yes. It worked with the newlib test app.


Aight, but what happens if something else goes wrong? Do we bubble up into the application or should we catch it and log it to tracees logger? (Im not quite shure how we handle those cases in our other bindings)


Zammit approves


@ionosphere, you need to update your bundler gem `gem install bundler` to prevent this change


That's great.

Well done!


Heh! Whoops, you're right - it worked here because my system had `/updates` present. Fixed in latest commit.


Yes! We never got an answer from imgur if thats ok or not but other projects do it as well. Should be ok ;-)
And it makes it much easier to debug plotting issues on travis and on other user's computers.


If we organize styles in directories we'll need to name them so they load in the proper order (at least the core styles which I'm envisioning would be in a single folder). Do you think we should go this route or import each file individually in main.styl?


And...

The `pip` command has been know to raise the following error while installing Python packages:


I recommend piggybacking this on "PreArm: Check mag field," since saturation means mag field is too strong.


FixDocLineEndings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1682 of 1682 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Maybe this should be an arming failure as well?


This error is raised if you have no schema ...


You can raise from here and it will still execute the finally clause.


no, just tried to be consistent :)

I recently found this naming convention with which I pretty much agree: only use getX when a non-trivial result is computed for the returned value.
http://hpicgs.github.io/guidelines/articles/2015/06/21/getter-setter-naming/


To resolve the error, explicitly


Regarding issues with the...


I don't think you need the triple ticks.
You can get away with just one:
```
`/#apps?modal=about`
```


Meteor won't load them in the order they're added in package.js?


So now your name is against all these excellent errata :wink: - but no, seriously, thanks for re-running https://github.com/w3c/touch-events/pull/3 over the newly merged doc. my git-fu isn't strong enough yet, so was just about to manually redo the changes and submit afresh...


Also does your .gpr file have "-gnat05" switch in it? [Ada 2005 mode]
And does using actual bodies with just null inside them solve the problem? [in that case I can just change back to bodies with null noting down this problem for future with said compiler, as it may affect many more projects I'm working on]


{} x 2


Took a bit to track it down, but this should be the robust way to compute num_af anyway, as opposed to having to compute it in make-pins.py


:+1:  I have seen this one before and I agree with this.


FixDocLineEndings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nit: `s/proxie/proxy/`


What does "trailing a BASP header" mean?


BeefViewController also removed entirely


Thanks! It pretty much an exact copy of the procedure you wrote earlier so thanks to you as well!


Shouldn't be "my name".  Eg. see [the commit list for the branch](https://github.com/w3c/touch-events/commits/gh-pages), all your commits are there (there's just an additional 'merge' commit from me because there was a couple conflicts I had to resolve manually).


Finally a proper routing table :+1:


LGTM


You're welcome.


I believe that I do need to check the version since these 2 interfaces don't exist pre-1.09


The comment or even the name of the variable does not seem correct in view of the reset (to -1) at the end of the if block within the for loop.


Well i suppose main.styl is the only file Meteor is handling directly. The others are being imported into main.styl by Stylus.


Yes, first if ```lastLocation == null``` after try to get by ```LocationServices.FusedLocationApi.getLastLocation(googleApiClient);``` probably the GoogleApiClient has an error, then check if error is the Geocoder (``` !Geocoder.isPresent()```, the same as ```Geocoder.isPresent() == false```) and show a toast with string defined in xml as ```service_not_available```


I've repushed with the vector change and a minor change that might improve the top-most thing: https://github.com/Underground78/mpc-hc/commit/5f0c23e0c31a63cbd6d2197d5c080150c9a3d0a2.


Fixed in 49a5a355c24dbec2c427779de342dd94abed1c1c


Why retry? if first connection fails, then ping fails.


Is it possible to handle all of them with Meteor directly? I'm concerned that meteor will only recompile when main.styl itself changes, not any of the files it imports.


I think this change is causing an issue (for me!): https://github.com/riot/riot/issues/939


It means the data on the wire following the header (i.e., the payload).


Not that is matters for the purposes of this addition, but `0` is empty too.


It's gonna be under "Samples" sub-menu, so I think it should be "Platform Simple". I don't mind changing the name though.


Single line  and optionally use String.format


Checking the view class makes this behavior very fragile and prompt to fail if Apple make any internal changes. However we are already using this strategy in some other places. Ex: https://github.com/kif-framework/KIF/blob/master/Additions/UIView-KIFAdditions.m#L405

@phatmann Let me know what you think


Looks good. This should address the changes Pat wanted.


> Teraz się skup!


And that finally clause should be outside the loop anyway. Also, I'm not sure if it makes sense to support controllers with multiple targets - I do not see a use case for that.


aaa


Hi harrymoore,
yes I added it to npm as a scoped module, I didn't get any feedback from Jalalhejazi in months...

Sure, you can use it:

```
 var jsonfs = require('@webgap/jsonfs'),
```

I'm using it as development driver (https://github.com/webgap/database-dao/blob/master/lib/jsonfs.js).

Please let me know if you have any problem.


If this is just for testing, could be extract it from the production class into a testing class (extending the former) or a set of utility static methods in a Test helper class? Testing utilities should stay in testing sources unless proven to be useful in production.


huge method, but don't mind that much if this is moved to testing.


There are a few things I don't like about this.

From the figures it looks like at zero distance there is less cycling than at 2km (i.e. it peaks at 2km).  This looks like you are just measuring the distance between MSOAs centroids.  Does that figure included origin to destination trips in the same MSOA and allocate a distance of zero to these trips?

To me it makes sense to think of alpha as the maximum proportion of cyclists.  As distance increases then beta expresses how people are put off.  As hilliness increases theta expresses again at what rate this proportion drops off.  We believe distance to be more important and to account for more sensitivity in peoples willingness to cycle long distances we added x^0.5 (although I think this might be because we have failed to take into account inter-MSOA trips).

E.g. (from around https://github.com/npct/pct/blame/master/load.Rmd#L141 )
```r
> flow # all flows in Manchester LA
> sel <- flow$All > mflow
> all_in_sel <- flow[sel,]
> summary(all_in_sel$Bicycle)
   Min. 1st Qu.  Median    Mean 3rd Qu.    Max.
  0.000   1.000   2.000   3.789   5.000  55.000
> same <- flow$Area.of.residence == flow$Area.of.workplace
> same_in_sel <- flow[same,]
> summary(same_in_sel$Bicycle)
   Min. 1st Qu.  Median    Mean 3rd Qu.    Max.
  0.000   2.000   3.000   5.045   6.000  48.000
```
If we counted these same MSOA flows I think the distance might become a better predictor.  Sorry for the rambling comment.  I'd like to help on this in Phase II more!


Works fine now. Thanks!


@Underground78
You can use ``GetModuleFileNameEx()`` by default and fall back to hardcoded value if it fails. Just make sure it doesn't fail and not uses the fallback in your environment.


I don't know if code will be needed, with tags.


ah, mire usted! yo cierro inputs con `/`


@bcdonovan  Can you update the truth sequences?


NPE to IAE


I don't think anything in this file is derived here, so it could be an elkarte alone header ?


Yeah, I guess I will do that. I'm a bit afraid of the call hanging in some cases depending on how the process crashed.


Che! Todo bien!? Qué raro un argentino por estos lados? Haces kernels no? Yo tengo una rom (basada en omni), desarrollo un poquito en el framework y settings! Tenes hangouts asi nos ponemos en contacto? hace falta mas argentinos por aca jajaja me siento solo


move this to a private method on PopoverFloater, you'll get your binding then can delegate the event to `onHide`.


Shouldn't happen, really.


Wait, why did they have both manifest.xml and package.xml files? This could just be my bad; if there's a reason to keep both, let's revert.


97647908-DocIssues4615 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1671 of 1671 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This if-else-if-else can be changed to ```return Integer.compare(o1.length, o2.length);```


Ok then.


Yes, mongo code is not anymore in doorkeeper's master.


make loc and start final and use ```Utils.nonNull``` on loc.


Hmm, this seems to imply that TCP is more commonly supported than UDP for DNS. Is this really true? Isn't this more like "most support UDP, many support TCP, and a good chunk supports both"?


On Mon, 2015-07-06 at 21:31 -0700, Jeffrey Altman wrote:
> Is it known which clients send authenticators without checksums?

It is a "Huawei Unified Storage System S5500 V3".  I'm guessing that
they, like Samba in earlier days, felt it was easier to hand-build the
GSSAPI than to use the full GSSAPI libraries.

> Please refactor so using the ap_options to guess the flags block is
> not repeated.

Certainly.

> I have no specific objection although I am curious about which clients
> are sending authenticators without checksums and under what
> circumstances.

In this case it is a domain join of a NAS to a Samba AD domain.  I
presume it would continue to do the same once joined whenever it used
LDAP.

Andrew Bartlett

--
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


make loc and stop final and use ``Utils.nonNull``` on loc.


please add a #define for the 6h timeout. Maybe call it DNS_SERVER_FEATURE_RETRY_USEC or so...


Probably not. I refactored the code to not add to attrs array if owner or desc not provided


Added self.x and self.odo to pull x and y values for curve fitting.

The previous iteration used a line of best fit as a zero for the Gaussian. This revision still displays the line of best fit but builds the normal line on the x axis.


Looks good. How many times has this gone through tsan? Can we get it through like 100 times in a row?


Dispatching on `AbstractVector` is effectively the same as dispatching on `AbstractArray{T,1}`.  I just double-checked and it works.  But you're right it needs tests.


Defines strings for enum fields that aren't known in thsi commit yet...


don't need a method for this, have it inline in `render`


Javadoc missing,
check arr with Utils.nonNull.


please add a #define for the "2" attempts, too!


Ça a pu d'affaire là, ça causait une erreur qui empêchait le jQuery d'exister.


Assigner la bonne responsabilité à la bonne classe.


# XXX
#YYY

*1
*2


FixDocLineEndings (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1682 of 1682 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hmm, I'd really just write "0" instead of "_DNS_SERVER_FEATURES_INVALID + 1" here. enums are integers in C after all, and thus "0" is the first value of any enum, so, you can write that directly.

(This is not C++ after all, where enums are much more type-safe than in C...)


This breaks GitLab url, see https://github.com/gitlabhq/omnibus-gitlab/pull/24#issuecomment-119517366


@Hypn0 Если я тебя правильно понял:
> Я в ините обычно оставляю настройки приложения
> Основные выношу в conf.py, а настройки базы и прочего здесь

Такой подход к хранению настроек  считается небезопасным. Лучше всего глобальные настройки приложения хранить отдельно от кода приложения. На то есть несколько причин:
* Безопасность: Ты коммитишь в публичный репозиторий, и данные о том, как настроен сервер, как приложение подключается к бд и с какой учётной записью доступны всем желающим. Достаточно вспомнить про ботов на гитхабе, собирающих ключи к AWS из репозиториев.
* Гибкость. Захардкоженность настроек приведёт к излишним трудностям при развертывании приложения в разных условиях.

Я предлагаю использовать в качестве хранилища настроек использовать либо переменные окружения ОС, либо конфигурационные файлы, которые будут храниться отдельно от проекта (типа `dev.conf`, `test.conf`, `prod.conf`)

На данном этапе `init.py` является только точкой входа в приложение (переменная `app`)


@stephentoub is correct.  The compiler as is doesn't cache lambdas for method group conversions, only certain delegates.


Including removal of non-free Nintendo Gameboy BIOS.


:ok_hand: :ok_hand: :ok_hand:


This method is only use in testing, is not proven to be a general utility.... I would move to a private method in that test class.


maybe add _DNS_SERVER_FEATURES_WORST and _DNS_SERVER_FEATURES_BEST as aliases for the first and last value of the enum, and then reference that wherever we need to reference the best/worst feature sets?


What `*` parsing problem is that?


Heck, you are reading pull requests very well! LOL

Yep, you are right, will drop it (and in the meantime I'll add a pair of { } to a foreach below. :angel:


I'm confused too. Basically though, you should have been working with the cakinize branch, which has `package.xml`s and no `manifest.xml`s. It wasn't explicit in the instructions, but `wstool update` should have put you on the right branch.


on_cancelButton_clicked() is standart slot of Qt


Thanks. I searched npm earlier but didn't find it. New to node and npm so may have done something wrong. I'll try again.

This module is almost exactly what i need. I am a little concerned about performance though when i get to a few 100k. Any issues you are aware of?

> On Jul 8, 2015, at 4:46 PM, Manuel Martins <notifications@github.com> wrote:
>
> Hi harrymoore,
> yes I added it to npm as a scoped module, I didn't get any feedback from Jalalhejazi in months...
>
> Sure, you can use it:
>
>  var jsonfs = require('@webgap/jsonfs'),
> I'm using it as development driver (https://github.com/webgap/database-dao/blob/master/lib/jsonfs.js).
>
> Please let me know if you have any problem.
>
> —
> Reply to this email directly or view it on GitHub.
>


Maybe the enum should be called DnsServerLevel rather than DnsServerFeatures, since the latter suggests this was a flag bitset, but it's really more of a linear set of levels, no?


good point


woah, changes are a-coming. Asaf told me you guys were gonna start over the summer - I'd be happy to help in some of my spare time over the weekends. Maybe we can set up a skype call so I can sync up with ya'll.

Cheers


@jisqyv Out of curiosity, why gcs.bucket property is needed when code is retrieving the bucket-name from AppIdentityService? Having this in tag in web.xml will add additional step for developer to get the bucket-name from dashboard and copy value into gcs.bucket property? Actually, this property could contain any value and its value be ignored by the code. Shouldn't use.gcs be sufficient?


FixDocLineEndings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (650 of 650 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.34%25-green.svg)


This looks much better. :+1:


It's shame we need to basically reimplement http://docs.oracle.com/javase/7/docs/api/java/util/LinkedHashMap.html here. I was hoping .NET would provide such collection.


Why change the name??


Nothing special, we just need a render callback because otherwise `CounterApp` won't receive the `Provider`'s context. This will be fixed in React 0.14. Right now it's similar to how you use React Router, for example—you give it the rendering callback.


cs


I have a question here. I don't know other way to convert from double to String, but I feel that isn't good code, can you help me in this part ?


To make git actually ignore phone_table.sql you will have to `git rm --cached phone_table.sql`. See here for more details: http://stackoverflow.com/questions/1274057/making-git-forget-about-a-file-that-was-tracked-but-is-now-in-gitignore


Quick tip: An instance variable is set to `nil` by default. So you don't really need this line.


Bailing early like this:

    if (lease->vendor_specific)
        return -ENOENT.

… saves you one level of indent and an extra `return`.


Why is this check necessary?


Unsure whether that's opinion or fact.  Likely many files within the sysstat repo would revising to reflect that GNU/Linux moniker.

https://en.wikipedia.org/wiki/GNU/Linux_naming_controversy


Unknown


Never mind me, my understanding of git is obviously too basic to spot this sort of stuff. In short, it's all good.


Is a merge to the master planned soon @keradus?


POST


Rather throw if garbage is passed in.


Yes, I in the middle of resolving conflicts :D


I never saw a compelling reason not to.


Awesome. :)


Well, `nokinds` has a big problem -- currently it changes how `*` is parsed:

  https://ghc.haskell.org/trac/ghc/wiki/DependentHaskell#Parsingnamespaceresolution


I was thinking of preserving order more because this is more comprehensible to the users (you populate the map field and after serializing e.g. to JSON, you will get the same ordering), than just for the sake of being useful for testing.

btw, proto3 doesn't seem to impose any restrictions on ordering of map field entires (wire format or iteration order).


Well, nokinds has a big problem -- currently it changes how * is parsed:

  https://ghc.haskell.org/trac/ghc/wiki/DependentHaskell#Parsingnamespaceresolution


Do the `free()` on the caller side, please.


j'avais oublié :D


Change to `if (context.afterEach)`


LGTM


ditto


THis patch looks good otherwise.


You need to free that buffer in `sd_dhcp_lease_unref`


post


`s/form/from`


Did the color of the original BuildCraft textures change? I already did all of the pipes in /buildcraft/textures/blocks.


in opencv 3.0 gold there is no opencv.h only opencv.hpp found here ./opencv-3.0.0/include/opencv2/opencv.hpp so how to resolve this issue plz


@GrahamCampbell cs?


Yup. From the formatter.


Комментарий нужно вернуть:
```php
/**
 * День недели расписания.
 */
```


Please remove the unnecessary {}...


I'm being persnickety, but putting the packaging and version nodes below the modules is just weird.


Yes, I think user would expect that retrieving Keys and Values collection wouldn't make a copy of the collection. I am tempted to create an issue specifically for this.


Actually, you can fold the code from `lease_parse_binary()` into here. There's no need for that function.


Normally I would It should have been coded as (sizeof(p_af) / sizeof(p_af[0])) and then the type doesn't even enter into the equation. But, there are places that pass NULL which breaks that.

I just realized that I could have created a null AF array:
```
const pin_af_obj_t pin_null_af[] = {};
```
and used pin_null_af that instead of NULL and then I could have used sizeof(p_af[0]), but its probably six of one and half a dozen of the other.

Technically sizeof(NULL) will be 4, and as long as sizeof(pin_af_obj_t) is > 4 then it still evaluates to zero.

So I'll leave it to @dpgeorge to decide if he'd prefer the "correct" implementation or not.


? get, since it refers to path / args?


> May be the "multiple unsequenced modifications" warning is only a problem for 32bit builds, not for 64bit builds?

No, regardless of arch size it was a problem in some versions of byteswap.h, which was used in some circumstances. If eg. bswap_64(x) is a macro, and we call it as `bswap_64(*keyp++)`, chances are we'll do the increment several times when macro is expanded. I'm pretty sure that's what the warning was about and I thank them for that.


Conflicts resolved, but... tests won't pass (`Tokens collection built on expected code must not be marked as changed after fixing.`).


+1 typo


88737258-EPW-Ruby-Access (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (2187 of 2214 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.78%25-yellow.svg)


Javadoc missing,
just used once outside testing and this can be implemented with streams only:

```...stream().sorted(Collections.reverseOrder()).collect(Collectors.toList())```


post?


https://github.com/yiisoft/yii2/commit/e88170ab825f19cc9ca63ad137a8f3d690e53eeb. Thanks.


Something like that.


post, since ajax?


I would just inline it in the only non-test place it is called.


Patch looks fine.


as far as i know some products like phpstorm are still using 1.6 by default ...


self.file is just a variable. It isn't capable of locking the file. The file is already .close()'d and there's no reason it should matter. To further it, I even set self.file to None - so it has ABSOLUTELY ZERO affiliations with the file object at this point and could not possibly be further from it. The lock is happening else where - this has to be a Python bug or a Windows bug. It is *not* unlocking when it should be. This sort of crap drives me insane. I *still* don't get why you're using Windows for hosting servers... this is the exact reason why it's so awful for it. :P


97648014-DocIssues4906 (rglazer2) - i386-Windows-7-VisualStudio-12: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think if we let Meteor handle it then mixins and variables won't be accessible.
Here's one way that works (meteor recompiles):
```
  api.addFiles('globals/1_variables.import.styl');
  api.addFiles('globals/2_mixins.import.styl');
  api.addFiles('globals/3_extends.import.styl');
  api.addFiles('globals/4_globals.import.styl');
  api.addFiles('header.import.styl');
  api.addFiles('main.styl');
```
```
@import 'globals/*'
@import 'header.import'
```

Maybe this is overorganization?


get I think?


Yeah I saw. Very strange. Until someone spots a problem with this commit I will regard it as a coincidence (eg. some other still existing bug was affected).


post based on similarities to others


so, you kill both audio/video with one stone.


This is surely a good change, but is it really true that there was a "header injection possibility"? In the absence of the [`re.MULTILINE`](https://docs.python.org/3.4/library/re.html#re.MULTILINE) flag, the only newline that could have passed through would have been one at the last position in the string, so I don't see how that could be used to construct a malicious header.

Or am I missing something?


post


I just did a quick scan and don't see anywhere in our stack where we're using this library; have you confirmed its licensing is Codice-appropriate?


Issue is [here](https://github.com/TheRPiGuy/SmashCode/blob/master/main.cpp#L5). Never `#include` .cpp files!


cool.


That because of `TransUnitUpdateRequest` is a shared model from GWT and used for any translation update. It has no access to `org.zanata.model.type.EntityType`. The best type to have in shared model is primitive type as I'm trying  not to include zanata-model in GWT.


perhaps here a place holder later. (maybe you already did this on another commit)


Ahh, contexts. Thanks, appreciate the answer.


created a reference to the root of my Firebase database


97647908-DocIssues4615 (rglazer2) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


really cool, this comes through the intent. very "androidsistico"


{} x 5. You might be better off creating a new utility function in utils to do the check here for a valid range, something like:

```
public static final void validRange(final int to, final int from, final int size) {
 ...
}
...
    Utils.validRange(leftOffset, leftOffset + length, left.length)
```
Perhaps the size should be the first parameter but this makes is more in agreement with Utils.validIndex.


fail commit name :)


@tkrokli, haha not bad. Though I am one of many others who has been putting time to http://wow.gamepedia.com/Public_client_builds. Build 12880 never existed, which is oddly weird, but @Shauren has his point.


Why use `$HOME/.meteor`?


remove


Ok, I understand. I just want to make sure nobody is confused by what is meant ;-)


See my comment above. TransUnitUpdateRequest is mainly used for GWT processing.


```
Testing: strip-opencl, STRIP Password Manager [PBKDF2-SHA1 OpenCL]... (8xOMP) Process 38094 stopped
* thread #1: tid = 0x122c38, 0x00000001001d158a john`get_salt(ciphertext=<unavailable>) + 74 at opencl_strip_fmt_plug.c:249, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x00000001001d158a john`get_salt(ciphertext=<unavailable>) + 74 at opencl_strip_fmt_plug.c:249
   246 		ctcopy += 7+1;	/* skip over "$strip$" and first '*' */
   247 		p = strtokm(ctcopy, "*");
   248 		for (i = 0; i < 16; i++)
-> 249 				cs->salt[i] = atoi16[ARCH_INDEX(p[i * 2])] * 16
   250 					+ atoi16[ARCH_INDEX(p[i * 2 + 1])];
   251 			for (; i < 1024; i++)
   252 				cs->data[i] = atoi16[ARCH_INDEX(p[i * 2])] * 16
(lldb) print cs
(custom_salt *) $0 = 0xafafafafafafafaf
```
Bloody hell, I see the problem. We should now return `cs`, not `&cs`. I'm sure I tested this but I can't have.


amend


cool interface the `Target` one


get


97647908-DocIssues4615 (rglazer2) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Cool!


Forgot to mention that the valid pages for the application are now defined within the routes.js.


The command arguments seems not quite consistent. "inspect" and "rm" take [driver] [volume], "create" take [-d driver] [-name volume], and seems "list" take filter differently. I think "driver" should be able to be omitted, then default to docker driver. So mostly "volume" should comes first. I am thinking something like:

docker volume create vol1
docker volume create vol2 -d volume_driver --opts size=10G
docker volume rm vol1
docker volume rm vol2 -d volume_driver
docker volume inspect vol1
docker volume inspect vol2 -d volume_driver
docker volume ls -f driver=volume_driver


Fair enough. I've merged this into HEAD to eliminate the need for the branch.


Nice! Great query!

Here's a tip for working with SQL queries. When you work with long strings you can split the string up on several lines to make the string more readable.

```ruby
sql = "
SELECT phone_name, phone_number
FROM contact_phone
JOIN contacts ON (contact_id = contacts.id)
WHERE contacts.id = $1;"
```


hibernate-validation was failing here because NotNull constraint can't be applied to a void method, so I removed it.


This commit also includes deleting the keyword irwas.
irwas has been changed to sigverse


check for nulls allBytes or any of its components.


ConstructorSignature#getConstructor() returns a raw, non-generic Constructor instance, so I had to use casting here.


Fixed in 808dbdb.


typo "fdor", please consider fixing it in some of the current pull requests


Given that dns_scope_get_dns_server() has side-effects, I think it would make a lot of sense to change dns_scope_emit() to return the used DnsServer object via an additional argument:

int dns_scope_emit(DnsScope *s, DnsPacket *p, DnsServer **ret_server_used);

*ret_server_used should be filled in by dns_scope_emit() to the server actually used.

Similar, dns_scope_tcp_socket() should also have the same new parameter.

I think I would prefer that, since it abstracts the picking of the server away into the scope, where it should be, while letting the caller still know what precisely it picked.


Great! I thought to better postpone this suggestion. So then, should we introduce this change incrementally when working on a class?


Patch looks fine otherwise.


Because there might be a race condition between the start of the controller (and the fact that it starts to listen for clients) and the ctrlmgr trying to connect to it.
So I would propose to keep this retry.
The retry would not be needed for the next connexion (for each target), but since we are going to remove support for multi targets for the ping ...


Fait !

Antoine

2015-07-07 11:32 GMT+02:00 juju921 <notifications@github.com>:

> Les trois commande à éxecute quand tu as télécharger les mises à jours
>
> php composer.phar require friendsofsymfony/rest-bundle (Bundle api rest )
> php composer.phar require jms/serializer-bundle
> php composer.phar require nelmio/api-doc-bundle
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juju921/E-Lycee/commit/dad65c5e9cfbb80dd3b41afbb9f58383c47b73d4#commitcomment-12035119>
> .
>


It is better to use FALSE instead of 1 here. Also please note that you have to run ps_reinit after you add all words.


I would propose that the first ping happens a ping period after the process has been started. Then it should be fine...


This method name is a bit generic. How about renaming it to something like `save_numbers`?


It is not a good idea to store decoder in the search, it is better to keep only required pointers.


@Mouvedia thanks.
I'm testing the new version of tmpl.js yet, supporting full iso-8859-1 for js var names & class shorthand names. Unicode code points > \u00FF can be enclosed with quotes, the browser will parse these.


should be : appcirclebar


Not bad now. Only took a couple hours to get this done, and solid.  I did flush out a bug here and there, but mostly, these simply dropped in, then I could search the code for a couple known strings to insert macros where they need to be.

It is SO nice to write just a single line macro in 30 or so locations, instead of 4 to 400 lines of code in each of those 30 locations.  Makes maintenance MUCH easier.  It was a full day (to several days) to add a new hash before.  Yes, if I was adding 4 of them that were almost all the same (like the Skein family), it did not take 4x as long, but now, it is SO much easier.    I should have used the pre-processor a long time ago.


It is better to place this function in the dict.c and make it a part of the dictionary, not a part of fsg_search.


This define is not DNS specific is it? Maybe just call it UDP_HEADER_SIZE?


It is better to use existing logmath ps_search_logmath


Looks good besides the nitpicking about the name...


Thanks ^^


function name do not follow coding style, they also better be the part of sphinxbase utils


Hey, they are being added, but here's the slight difference.

Genesis way:

```<head profile="http://gmpg.org/xfn/11">
<meta charset="UTF-8" />
<title>Sal Ferrarello - Programming, parenting, and an abundance of other topics</title><meta name="viewport" content="width=device-width, initial-scale=1" />
<meta http-equiv="X-UA-Compatible" content="IE=edge">```

IE-8 Compatibility Fix:

```<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>Sal Ferrarello - Programming, parenting, and an abundance of other topics</title>```

Basically the issue isn't whether it's loaded, but specifically WHEN `X-UA-Compatible` is being loaded. It needs to load directly after head or utf-8 or it can break in ie-8 compatibility mode.

I actually notified Genesis about this as well so hopefully they make the change soon themselves


You left some merge error markers in boat_launch/src/boat_launch/mission/find_shape.py


void * is not required

in pocketsphinx we use ckd_calloc/salloc/ckd_free instead of free


I just counted. There are 28 'spots' (not including adding #includes) for adding a new hash.

I need to write documentation so I remember this.  It is now easy.


it is C++ style to define variable within the loop


Fait !

Antoine

2015-07-08 1:17 GMT+02:00 juju921 <notifications@github.com>:

> php app/console generate:doctrine:form ElyceeElyceeBundle:Contact
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juju921/E-Lycee/commit/969bcd8a159b9891ffa27e9b89b25184045a3b09#commitcomment-12050680>
> .
>


It is not compatible with MSVC to define variables inside the code, they must be declared in the beginning of the block


gnatmake --version says:

GNATMAKE 4.6

which is /usr/bin/gnatmake on my Ubuntu here; this is the version that reported the error.

I also have GNAT GPL, if I manually add it to my $PATH, whose gnatmake --version gives

GNATMAKE GPL 2014 (20140331)

The latter has no trouble compiling this code


It is better to read the model once, not on every g2p invocation


hmm true, like the suggestion.


This line does a lot. How about splitting up in two lines?

```ruby
@phone_numbers = phone_numbers
new_contact.push_to_db(phone_numbers)
```

`save_phone_numbers_to_instance` just assigns the instance variable, so I think you can get rid of it.


Patch looks good.


Patch looks good!


You can refactor lines 37-40 into one line. Give it a shot!


Update class name to match constructor.


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1164 of 1164 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This would be a nice security issue in Firefox, I dont' believe it will pass the review. Instead of fixed arrays it's better to allocate memory dynamically.


This is what `SCons.Util.flatten(stuff)` is for. It'll handle all kinds of lists, nested arbitrarily deeply.


This patch LGTM. If you want you can split this up and send it as a pull request to be merged.


Looks fine!


The best commit message.


as you say naughty but nice. saves a lot of note(:e4)+12 stuff needed previously
Thanks


Sorry but this was also done for a reason and using a coordinated move here is wrong. I specifically need to move the probe back by the exact number of steps it moved down. using a coordinated move here is the wrong thing to do.
It may not be obvious as to why, but trust me it is wrong.


We don't use size_t in our code, we mostly use int32/uint32


strange, I never had that problem with gcc. I can check in a couple of weeks (if I don't forget)...


Just for the record, I'd really love support for uc($p) and lc($p)  :wink:


Isn't is usually a good idea to use a qmutexlocker incase the thread dies unexpectedly?


This commit was released in the 7/07 build, and doesn't work anyway.


part of #2302


Oops.  Gotta shrink the #'s too.


Nice refactor!


Just curious, why not just iterate over the array returned by listFiles() instead of converting it to an ArrayList?


Thanks. Makes output much more useful when you can remove the cue stuff. Previously couldn;t see the wood for the (cue) trees.!


Updated thx :+1:


All getters should be prefixed with Get


I wonder, isn't this creating a global instead of creating the `self` var inside the prototype scope?


You can just use string interpolation here:

```ruby
"#{@first_name}, #{@last_name}, #{@email}, #{@phone_numbers.join(' ')}\n"
```


Sure. With my penchant for meanings in numbers, I should have noticed that 12880 = 12340 + 512 + 32 ;)


nope, I think the repetition is better than the model knowing about the course settings configuration.

You can always pass the settings object around. This is unnecessary coupling.


Looks good


This commit breaks my config, see this issue: https://github.com/saltstack/salt/issues/25268


Ideally this data would be loaded in the Contact class not the ContactDatabase.

Something like

```ruby
contacts = Contact.find_by(search_term)
contacts.each do |contact|
  puts "Id: #{contact.id}, #{contact.phone}...etc"
end
```


Do we need this ? Can we get away without having to store this as I don't see its usage anywhere except in the constructor assuming we dont need it later.


There's an issues section one click away...

BTW leaking's been brutal lately. I couldn't watch a video last time I tried with YTC. Hopefully this will help it.


It would be nice to use `#defines` for all these numbers, to make it more readable, but I understand it was never done so if you don't want to change it that's fine. :/


final for all arguments in all methods/constructors in all classes in this file.


well, that needs to be changed to read out the real hdop/vdop values.


check for p == null. Same for all other similar methods in this file.


I think it should be something like this (sorry, but I'm absolutely not a python/salt-pro :D):

```
scope = cols[cols.lower().index('scope') + 1]
```


> We also ned to check whether your change does have a performance impact on (64bit) Linux systems.

That's not important enough to care about. It only affects some really old compilers.


Leave in catalog/images - AFAIK this is a global exclusion not just for a local repository


Change this file to:
```
/datum/event/heart_attack/start()
	var/list/candidates = list()
	for(var/mob/living/carbon/human/G in player_list)
		if(G.client && G.stat != DEAD)
			candidates += G
	if(!candidates.len)	return
	var/mob/living/carbon/human/H = pick(candidates)
	H.give_heart_attack()
```
Also properly indent it :P


Any reason *not to* send this to 1.10?


You are my personal hero!  I just wish this had been announced somewhere.


good catch! That semicolon should be a comma. I will fix.


a const for `@"smartspace"` here as well?


I think many of the components (inner classes or methods) here are actually never used, I think you should do some culling; and bring it to the minimum necessary.


You can check the performance test from Jalalhejazi here: https://github.com/Jalalhejazi/jsonfs#time-taken-to-process-x-number-of-objects-in-ms-vs-action-performed

An important feature missing is the query selectors (as in mongodb http://docs.mongodb.org/manual/reference/operator/query/). I would say it works fine for simple, small and non critical projects.

Please keep me updated if you plan to make some improvements, as I can try to help or reuse it.


https://msdn.microsoft.com/en-us/library/windows/desktop/aa364526(v=vs.85).aspx

Notes: split up classes, add access modifiers, use new dictionaries, etc...


This looks like it's still broken when idx == 0


It uses the Apache License, Version 2.0: http://www.lingala.net/zip4j/about.php


`scopes`?


http://jekyll-windows.juthilo.com/3-syntax-highlighting/

The 'this' referenced in the description.


The scope should only contain one or more routes. The `acls` references a scope.


check rawCigar is not null.


HEADS UP! Haml 4.0 has many improvements, but also has changes that may break
your application:

* Support for Ruby 1.8.6 dropped
* Support for Rails 2 dropped
* Sass filter now always outputs <style> tags
* Data attributes are now hyphenated, not underscored
* html2haml utility moved to the html2haml gem
* Textile and Maruku filters moved to the haml-contrib gem


Where is this used?


The ownership doesn't look clear to me. Can you explain as to how this memory will be eventually released ?


Closes #3


I'm curious why you moved BN after the non-linearity, rather than before as is described in the original paper. Did this give better results empirically?


How did I miss that?


DatagramSocket(poert, laddr) calls InetSocketAddress(laddr, port), which has a check for port and laddr:
http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/6-b14/java/net/InetSocketAddress.java#InetSocketAddress.%3Cinit%3E%28java.net.InetAddress%2Cint%29

I don't thunk you need the check for iface against null here.


Add error message in case is null.


Humm all right, it seems to be the case already.
And that period for now is 1 sec, is that OK?


Yeah, and you’d still have to use the numbers in the plist, which is the more “user facing” part anyway. I’d just use strings, but you can’t `switch` on those.


"cigar is null" or "cigar cannot be null"


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.737.2574066754f5af08342c0899ae8b89037974198d](http://build.palaso.org/viewLog.html?buildId=59483&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 363, ignored: 3 Build time: 00:05:34


is there an easy way to toss a change w/o having to re-commit?


same.


your suggested fix seems to work; I've applied it and merged


Check arguments for nulls.


works but there's probably a better way


Edward, sorry, but I'm not sure if it's enough, I didn't finish building the thing yet.. there's something.. I need to learn before I can do that completely..


Fixes #2


Removed commented out code.


unordered_map is usually faster than map


@rtrauntvein code style :)


this seems like it's a mistake, have you forgotten that sometimes changed values necessitate a re-eval of the showifs?


hmm interesting. We want to avoid un-necessary ipc calls. Can we get allowed bounds from GPU and feed it to Datadevice ?


Why did you put timing first anyway? Are we going to do it that way around? Timing first -> then translation?


Done


FixDocLineEndings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1167 of 1167 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


I don't get the use of the interface. Instead I replaced it with a class Context and the static methods getCurrentBrowser and getCurrentWebDriver


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 121](https://teamcity.labkey.org/viewLog.html?buildId=259849&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 1 Build time: 00:02:59
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.initializationError: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


response = response.trim();
You keep calling that function, minimize repeated code.


final refIndex and company.
Check for nulls and valid indexes.


Not that it matters much, but i think ENXIO would be a nicer error to throw here...