Hi @alexmoore , thanks for taking time to review my PR.

It is not only a matter of performance, but a matter of thread synchronization correctness as well.
For example, the hasIndexes() method is *not* synchronized. So there's nothing preventing hasIndexes() and getIndexes() to be called concurrently.

In my PR, since the field `riakIndexes` is declared `volatile`, this (minor) thread-synchronization issue is fixed.

Now, to answer your question:

This double-check pattern comes mainly from this book [Effective Java 2nd Ed](http://www.amazon.com/gp/product/0321356683?ie=UTF8&tag=javaconcu-20&linkCode=as2&camp=1789&creative=9325&creativeASIN=0321356683).
If you take a look at the item 71 in this book, you could read:

*This code (double-check locking) may appear a bit convoluted. In particular, the need for the local variable result may be unclear. What this variable does is to ensure that field is read only once in the common case where it’s already initialized. While not strictly necessary, this may improve performance and is more elegant by the standards applied to low-level concurrent programming. On my machine, the method above is about 25 percent faster than the obvious version without a local variable.*

To be honest, while re-reading this book, I think there's no need to use lazy initialization for `getIndexes()`, `getUserMeta()` and `getLinks()` methods. We could simplify the code even more by just removing lazy initialization and replacing with direct instantiation where the field is declared in the class (and add the `final`keyword as well by the way).

From the same book, here is the conclusion of item 71:

*In summary, you should initialize most fields normally, not lazily. If you must initialize a field lazily in order to achieve your performance goals, or to break a harmful initialization circularity, then use the appropriate lazy initialization technique. For instance fields, it is the double-check idiom; for static fields, the lazy initialization holder class idiom. For instance fields that can tolerate repeated initialization, you may also consider the single-check idiom.*

What do you think ?


1) You need to add ```"scriptencoding utf-8"``` since it contains utf-8 characters.

2) Below is the recommended setting by Syntastic itself. Using below, one would know what the actual errors are, what's the line and column number etc.
```
set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*
let g:syntastic_always_populate_loc_list = 1
let g:syntastic_auto_loc_list = 1
```


Here are the steps to disable the strict name checking [according to this article](https://support.microsoft.com/en-us/kb/281308):

1. Start Registry Editor (Regedt32.exe).
2. Locate and click the following key in the registry:
 > HKEY_LOCAL_MACHINE\System\CurrentControlSet\Services\LanmanServer\Parameters

3. On the Edit menu, click Add Value, and then add the following registry value:
Value name: DisableStrictNameChecking
Data type: REG_DWORD
Radix: Decimal
Value: 1
Quit Registry Editor.
4. Restart your computer.


typo "increases"


o.k. ignore the comment, did not realze that os.removedirs only works on empty directories.


@acrymble I've edited the new-author-workflow to bring it fully up to speed with the Wiki. Please see if anything looks amiss.


I actually think `batch` is better here, `group` sounds way off the existing terminology :smile:


Meinte natürlich @drschaf


I usually see Txn or Tx, not Tnx.


I would call it "BasicPasswordSpecEncoding".


@krancour now I remembered why I'm using this and not a drop-in. In the default service is not possible to specify the parameter `-iface` so by default it uses eth0 and that doesn't work in vagrant


this looks like it will crash


I'm not sure what this comment means.  Perhaps:
// error is empty unless the operation failed, in which case it's a human-readable description of the failure.


At first, both fields are optional and this functionality is already implemented on SEI (WebService class annotation). No it's not redundant. Imagine method in SEI:
```java
    @DocDescription("Example operation")
    @DocReturns({
            @DocReturn(description = "Expected result of operation", typeDescription = "Represents flight destination")}
    )
    public Destination foo4b(@DocIsRequired @DocDescription("ID of flight") @WebParam(mode = WebParam.Mode.INOUT, header = true) Holder<String> flightId)throws AirserviceFault{
        return null;
    }
```
Field **description** describes whole output, which is composed from **Destination** and **String** in this case. But **typeDescription** describes only **Destination** type and **@DocDescription** describes only **String** type. So in general there can be different text.


In PHP7 Beta 2 the line with 'struct berval lvalue;' is directly after the 'int errno;' I will try to see if thiz fixes the breakage.


The best and cleanest way to resolve relative URLs is like this:

```java
URL x = new URL("http://www.foo.com");
URL y = new URL(x, "bar.html");
y.toString() -> "http://www.foo.com/bar.html"
```

See http://stackoverflow.com/questions/2534124/java-uri-resolve

Can you revert this commit and use this constructor?


I think there should at least be a public ``encode`` method which accepts a PasswordSpec directly - or maybe all of the encode*PasswordSpec methods should be public (but accept the corresponding PasswordSpec, *not* the Password).

The intention is that the caller has the Password and a PasswordFactory already.  Then they use the PF to test what kind of PasswordSpec can be produced for the Password, and then directly call the target encode method.


How does the user know whether the response contained all the keys in the range, or only those up to the limit?


This way we don't ever have to have knowledge of which Password types can be converted into which PasswordSpec types, which allows new Password types to be added which will still work (provided that they support one of the standard PasswordSpecs).


This is better written as ``identifier = iterator.next()``.


Since the clear password has only one field, it doesn't need a length field.  You can just return the ID plus the bytes directly.


This improves performance greatly. Opted to allow the user to simply change the color using the color picker.


Good catch - looks like it's neeed in Python 2.x only then. I'll do some further testing and try to fix it for good.


This seems overly convoluted.  Try: ``byte[] u = keySpec.getUsername().getBytes(StandardCharsets.UTF_8);``


If the comparisons succeed, then the success requests will be processed in order, and the response will contain their respective responses in order.
If the comparisons fail, then the failure requests will be processed in order, and the response will contain their respective responses in order.


Note: This is pretty inefficient, as we copy the memory for qualities out and then index it at every single aligned position. Gross.

Maybe I can change RegisteredAlignment to automatically already parse it out?


Hi,

I've added some results from my ancient laptop.  It's running Ubuntu 14.04 and seems to benefit from the change from `cp` to `fs` copying. From ~45 seconds to ~7 seconds.

https://gist.github.com/gitgrimbo/950f3301ce7b9d8ce18f


What happens if some of these requests succeed and then one fails?  Is the entire sequence rolled back?


Don't want to be that guy...but...there should be a space here :)


Extra new line


Or better yet, skip the byte arrays and directly do ``...).appendUtf8(CodePointIterator.of(keySpec.getUsername())).append(...``


`getLogRotator` should actually be kept here, the build discarder is already handled via a different code path.


should be above `munkres = Munkres()`


In Firefox, the target does not have a `offsetHeight` or `offsetWidth` property. For now, default them to 0 to keep code from breaking.


Maybe something like this is possible:
```
            for key,value in job.items():
                env_dict['DRQUEUE_%s' % key.upper()] = value
```


@poettering
I did not intend to create a bug report at the time. And I did not comment on "some random commit" but on the commit that introduced a problem for me and probably many more. I just wanted to note that the commit is not as free of side effects as assumed.

It's interesting and unexpected for me to see two quite important people in the Linux world reacting to my comment (and that fast). I thought you're short of time. Anyway, maybe I'll file a bug report next week if nobody else does it.

Sounds like @gregkh already found the problematic part of psmouse, but I'll try to find it myself.


move this comment down next to mod_index?


Yeah, you're probably right. Create an issue or send al pull request if you've got time :smile: so I don't forget about it!


@jrnold I was wrong about the contributor agreement, since we established before that the work uses the same license as Ace itself we just need the correct attribution in the sources which I've done here: https://github.com/rstudio/rstudio/commit/aaf43567f1083d696fa006d355294fd3dcb17d0c


ack


Se ve mejor.


What is progress_notification?


@ntc already done, thanks again!


You may use https://steamcommunity.com/my where you need the "cookie owners" profile (https://steamcommunity.com/my/edit should work here). :+1:


explain


Use .bind(this) instead of var self;


this broke staging :-(


Actually, forgot to change to ByteStringBuilder.


This could be more flexible by replacing `7` with `postSaveMenuItems.length`


Yes, looks much more elegant. But sadly not all variables follow the same structure, for example DRQUEUE_SCENE and job['scenefile']


Did you test it with success on your buildings ?


Ok.  That makes sense.  I had a brief glimmer of hope that `ExecStart` could actually be overridden in a drop-in, but after researching that a bit-- no such luck.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 193](https://teamcity.labkey.org/viewLog.html?buildId=262137&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 16, passed: 3 Build time: 00:06:46
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

##### there are 6 more failed tests, see build details
```


Gotcha. Maybe add "(and must be installed in a separate yum invocation)" to the comment a few lines up.

Also, let's combine these into one `RUN` statement with an `&&`. (I just double checked that does work.)


Use reset or rebase on your own repo. Stops the clutter from excessive reverts.


ack - but I still think numbers like 10,11,2 need a better guessing method


Whenever a number needs units, prefer a field with a name or a type that enforces those units.
Here, ttl_secs would be fine.
Another option would be something like https://github.com/google/protobuf/blob/master/src/google/protobuf/duration.proto, but it's probably overkill to use that here unless you have a bunch of other time-related stuff.


Hmm, I should probably add a drain(count) method which directly produces a byte[]...


ack
Yay for json \^_^/


Sling v1.6-mrdg10


:trophy:  Achievement Unlocked: Bash wizard! :neckbeard:


@jbachus lol very nice :)


Just that one `logRotator`/`buildDiscarder` change commented on above needs to be reverted, the rest looks good to me.


Actually, I'm not sure that this is a good idea.

It couples us to specific formats. Adding additional formats will be tedious, error prone, and really broadening the responsibility of the `range` module beyond what it should be.

I think it makes more sense to handle this in `leadconduit-rules`, as the PR for that repo is currently.


Isnt cindex part of LLVM license ?


There's already a little section about deployment in the commit. This could definitely be improved with more background information.

The cool thing is: It's really that simple. All the configuration is already present and all you have to do is to build and run it.


Yeah, I tried the same thing :)

I'm sorry that I forgot to mention this "detail" but it's been more than a month since I started this PR


why? empty bundles can exist


Sounds good.  I'll make the change.


ack, if you say so


Thanks :-) Not yet because I'd like to test it in OPNsense before, how can I test it ?


cli-bug-fix (nealkruis) - Win64-Windows-7-VisualStudio-12: OK (1754 of 1761 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.6%25-yellow.svg)


The `feature()` method does load the dependency modules.


Hmm if it's an empty bundle it won't go through here right? Because there won't be any files in the bundle. But if there are files in the bundle, they shouldn't be empty I would imagine


Isn't the new prebuilted binaries becoming LGPL by default because of this?


Hi! No I was just familiarizing myself with Git.

On Wed, Jul 22, 2015 at 1:03 AM, Ed Solis <notifications@github.com> wrote:

> @davidsmith2045 <https://github.com/davidsmith2045>, did this do
> anything, or are you just testing things out?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bill-tracker/bill-tracker/commit/6672016c5e0af8db72693ba56d46eb90ffcd4874#commitcomment-12291307>
> .
>


Yeah I will remove it just a sec, I can't build at home my internet is way too slow


the LLVM license is GPL compatible i.e. derivative work may be GPLled


It's not really ready for looking at yet, I just pushed to this other branch because I needed to go to bed last night. =)  What issues are you seeing though?


`add_include_paths` is a very bad name. It has a verb - and variable names shouldnt have verbs

I think you meant additional_include_paths ? - but the "add" is confusing
Maybe "more_include_paths" or "extra_include_paths" is more appropriate ?


if you want proof you can read my thesis, that's only 65 pages :)


@glassez Since we were both baffled by this, I post what I found. From the libtorrent docs about `peer_info::country`:
>
**country[2]**
    the two letter ISO 3166 country code for the country the peer is connected from. If the country hasn't been resolved yet, both chars are set to 0. If the resolution failed for some reason, the field is set to "--". **If the resolution service returns an invalid country code, it is set to "!!"**. The countries.nerd.dk service is used to look up countries. This field will remain set to 0 unless the torrent is set to resolve countries, see resolve_countries().


ah, nice.

ack


Sounds great. Maybe that's what you mean, but we didn't match distributions of wages and profits but their correlation with theta. Either way I think it would be good if we can still access the solution in a similar way to the table we had in the notebook before so we are flexible in case we want to match different things.


Probably just easier to use rspec.


riiiight :)
I'm surprised that the tests' results didnt change though.


it's short for additional_include_paths indeed. I'll better change it,
thanks for the suggestions.

2015-07-22 23:02 GMT+02:00 AbdealiJK <notifications@github.com>:

> add_include_paths is a very bad name. It has a verb - and variable names
> shouldnt have verbs
>
> I think you meant additional_include_paths ? - but the "add" is confusing
> Maybe "more_include_paths" or "extra_include_paths" is more appropriate ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/1d36cc313c4ea481ebb774f408d53a54587476dc#commitcomment-12307743>
> .
>


Point's to https://github.com/hdd/drQt/issues (**hdd** and not **kaazoo**) ;)

and the issues tracker here is not active ;)


well fitness is a bit better.

2015-07-22 23:03 GMT+02:00 AbdealiJK <notifications@github.com>:

> riiiight :)
> I'm surprised that the tests' results didnt change though.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/48951273fc42cde8f306a30d80edf8f938df6423#commitcomment-12307764>
> .
>


I use IDEA. So that's probably a "no".


A git squash would make things easier to review next time!


I love you for this


ooh all good sorry. my fault. was thinking of something else.


@SecUpwN  WTF is this? Why is there a new commit with all the old ones?

Can you turn this Weblate crap off please, it annoying as hell, seeing a commit every time somebody translates one word. It's better if the translation is pushed when completely done...


Looks good!  Nice work.


Yup this was for a reason, however I can engineer it another way.
Basically I had a plan to move all the programmatic tests out to another file so that sri-toolbox could share the same tests to reverse them to check their algorithm.

This test will 'pass' however it won't match the code of `service-worker-check.js` so that it checks the passing service worker output.


Good catch, I meant to do that.


@annevk yup, this was mostly a tester to check I was on the right path :+1: - I will add in all the changes mentioned here to another commit.


what a weird name, how about UniversalPermissionError?


There are benefits to using factories over fixtures, especially as the data & relations become more complex, or constraints are added/removed.


-> it shouldn't be specific to this usecase


In the future you actually want this last one


ideally


Yes, after I realised what Alexandre was actually trying to do, I realised that this will not help.  I'll revert it.


I don't either.  I'm guessing either `TMPDIR` gets clobbered by `File::Spec->tmpdir`, or `File::Spec->tmpdir` complains if `TMPDIR` isn't set.  Under certain versions.


I just reverted and it should be all good.

Laurent

On Wed, Jul 22, 2015 at 1:51 PM, Don Byrd <notifications@github.com> wrote:

> Dumb question: Presumably I should just revert view_mensural.cpp to the
> previous version, commit, then push, yes? But I don't see how to go back
> to a previous version in SourceTree, nor do I see a commit (in Git view)
> for this change or a commit with the hex number in the subject line
> above. ??
>
> --Don
>
>
> On 7/21/15 8:15 AM, Laurent Pugin wrote:
> >
> > This needs to be changed back, sorry for this. The problem is that
> > there is no default value for all the MEI attributes, including for
> > boolean. As a result, data_BOOLEAN can be "true", "false" but also
> > "NONE", which means that no value is given in the MEI. Then it is up
> > to us to decided what to do for each individual case. So HasColor()
> > can be used to check if there is value (true or false) in the MEI and
> > GetColor() to get the actual value. I know this is confusing but I
> > think it is the best we can do.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/rism-ch/verovio/commit/75a7ea6d8ee66de821c3918058a9f2198a19247b#commitcomment-12273569
> >.
> >
>
> --
> Donald Byrd
> Woodrow Wilson Indiana Teaching Fellow
> Adjunct Associate Professor of Informatics
> Visiting Scientist, Research Technologies
> Indiana University Bloomington
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rism-ch/verovio/commit/75a7ea6d8ee66de821c3918058a9f2198a19247b#commitcomment-12303886>
> .
>


LGTM.

There was a reason I set all files in egs/ to LF-only style eof in `.gitattributes`. You may want to do same to this .pl script. But to recover from this change (whether done to the repository by yourself) you'll need to rebuild the index, or Git will endlessly report the file as changed, even though it is not.

Generally you remove the index either "git way"

    git rm --cached -r .

or simply  (I usually do it this way)

    rm .git/index

Of course, your staged changes would evaporate.

Then, if your worktree is clean, the easiest is the hard reset, which rebuilds both index and the worktree, setting EOL per .gitattributes in process

    git reset --hard

If you have worktree changes and want to rebuild the index from these files, then the "mixed" (the default) reset is needed, but you'll have to convert to correct EOLs manually first:

    dos2unix myfile.pl
    git reset


probably more readable with :warn or :info, etc.


This deserves an explanation. Basically, the keyringmgmtmini panel appears in two places: (1) the setup flow when the user first installs E2E and (2) the preferences page. In (1), we want to hide the export button because the user has no keys to export. We also want to hide the FB import button there, because it's not something most users want to do at setup time.

So checking `this.exportCallback_` is just checking whether this panel is constructed in a context when the user has setup keys already.


PS You see the commits in GitHub only if you have selected the correct
branch if it is not in the default (master) one. This might be the reason
why you are not seeing it.

On Wed, Jul 22, 2015 at 5:08 PM, Laurent Pugin <lxpugin@gmail.com> wrote:

> I just reverted and it should be all good.
>
> Laurent
>
> On Wed, Jul 22, 2015 at 1:51 PM, Don Byrd <notifications@github.com>
> wrote:
>
>> Dumb question: Presumably I should just revert view_mensural.cpp to the
>> previous version, commit, then push, yes? But I don't see how to go back
>> to a previous version in SourceTree, nor do I see a commit (in Git view)
>> for this change or a commit with the hex number in the subject line
>> above. ??
>>
>> --Don
>>
>>
>> On 7/21/15 8:15 AM, Laurent Pugin wrote:
>> >
>> > This needs to be changed back, sorry for this. The problem is that
>> > there is no default value for all the MEI attributes, including for
>> > boolean. As a result, data_BOOLEAN can be "true", "false" but also
>> > "NONE", which means that no value is given in the MEI. Then it is up
>> > to us to decided what to do for each individual case. So HasColor()
>> > can be used to check if there is value (true or false) in the MEI and
>> > GetColor() to get the actual value. I know this is confusing but I
>> > think it is the best we can do.
>> >
>> > —
>> > Reply to this email directly or view it on GitHub
>> > <
>> https://github.com/rism-ch/verovio/commit/75a7ea6d8ee66de821c3918058a9f2198a19247b#commitcomment-12273569
>> >.
>> >
>>
>> --
>> Donald Byrd
>> Woodrow Wilson Indiana Teaching Fellow
>> Adjunct Associate Professor of Informatics
>> Visiting Scientist, Research Technologies
>> Indiana University Bloomington
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/rism-ch/verovio/commit/75a7ea6d8ee66de821c3918058a9f2198a19247b#commitcomment-12303886>
>> .
>>
>
>


Colin Walters <notifications@github.com> writes:

> We only need `libcrypto`, not the full `openssl`, no?
>
I'm not terribly familiar with these libraries. All I know is that I
encountered an undefined symbol and google took me here,
http://www.openssl.org/docs/crypto/EVP_DigestInit.html


I like this!!!


@Espurna I think you mean "unselect".  Can't find any usages of this keyword though.

@xispa please can I have collaborator access to the equigerminal fork?


Jak ładnie modułowo :)


The classes offered by caching-compiler are just helpful base classes to use with registerCompiler if they are a good fit. You don't have to use them! That's why I tried to make the actual registerCompiler API simple and flexible and move the plugin sensitive caching logic to the plugin itself, where you can choose whatever caching strategy you want.


Did the weather-big data not work for you?


good catch, thanks


I'm not sure what's going on here, but if it's similar to the Safari issue we had then the console will tell you about the CORS header problems.


(The core API is processFilesForTarget which gets called with all the files for a target (client or server). compileOneFile is part of the classes in caching-compiler.)


Raul,

Esta chave de criptografia você pode gerar no seu ambiente e compartilhar com a equipe que usa a mesma base de dados. Isso é usado para criptografar as senhas dos usuários.

 Não estou querendo fazer o Merge final para não ser um gargalo no processo. Vamos acertando os ponteiros aos poucos e com o tempo vocês vão me ajudar nessa tarefa.

Abraços,


@tyrael or @jpauli Moving the struct line a few lines higher triggers another error:

    oldap32_a.lib(controls.obj) : error LNK2005: _ldap_control_find already defined in ldap.obj

This is with the oldap32_a.lib that is working fine with PHP 5.6.11 and 5.5.27. OpenLDAP 2.4.33 from http://windows.php.net/downloads/php-sdk/deps/vc11/x86/


What other formats would we add? We'd really only need to add things here when we wanted to support range operators for different kinds of values. I can't think of anything other than numbers or dates...


We're now ready to go when solar takes off in Antarctica!


pretty sure this breaks other platforms which rely on that include path...


fixes_for_VS2015 (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (729 of 729 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.13%25-green.svg)


Also i am not sure - you removed the include from the audioengine but the code changes are in dvdplayer - are you sure the makefile change for audio engine is needed?


I got something better for you :)


I hear they have 24-hour sun in the summer. Pretty good for solar!


closes issue #1


Do we need this close?


Sure.


good point. I'll try and test eclipse-> idea formatting, but google doesn't give me much hope


@samsymons ^_^


Blz, vou criar aqui e faço um novo commit com o acerto do cript.
Abraço

Em 22 de julho de 2015 18:12, Victor Azevedo <notifications@github.com>
escreveu:

> Raul,
>
> Esta chave de criptografia você pode gerar no seu ambiente e compartilhar
> com a equipe que usa a mesma base de dados. Isso é usado para criptografar
> as senhas dos usuários.
>
> Não estou querendo fazer o Merge final para não ser um gargalo no
> processo. Vamos acertando os ponteiros aos poucos e com o tempo vocês vão
> me ajudar nessa tarefa.
>
> Abraços,
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Plataformas-Cidadania/mapaosc/commit/c27bf0031e6e51d8d68fe2a5acf12eaee99465bd#commitcomment-12307953>
> .
>

--
Mestrando em Engenharia de Sistemas e Computação UFRJ
Bacharel em Ciência da Computação UFRRJ
Linkedin <http://www.linkedin.com/in/raulsenaferreira>
Portifolio <http://www.raulferreira.com.br>


Should we still handle errors if the path can not be written?


I prefer enumerations as indexed strings over magic numbers... just makes it easier when reporting or otherwise dealing with the data. (just a preference)


Yeah I just like to stay up to date. No specific reason. I know keeping up to date with changes can be hard. Thanks for creating this gem.


Suggest the name "Storage".


sweet... factories!


Why is this indexable? Also why is Edge indexable?


I couldn't access `o` inside `isCopy` as a global variable in my testing, so I pass it as first argument. Then depending on the status of the drag ,the container and the target are not always there, `null` is passed it one doesn't exists.
It all works fine in my integration, I'll be interested to get some feedback though.


Log 1:

In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:42:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:41,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from Interfaces/AE.h:23,
                 from AEFactory.h:24,
                 from AEFactory.cpp:22:
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:153:15: error: field 'm_language' has incomplete type
   std::string m_language;
               ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:154:15: error: field 'm_territory' has incomplete type
   std::string m_territory;
               ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:155:15: error: field 'm_codeset' has incomplete type
   std::string m_codeset;
               ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:156:15: error: field 'm_modifier' has incomplete type
   std::string m_modifier;
               ^
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:42:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:41,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from Interfaces/AE.h:23,
                 from AEFactory.h:24,
                 from AEFactory.cpp:22:
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h: In member function 'const string& CLocale::GetLanguageCode() const':
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:63:55: error: 'm_language' was not declared in this scope
   const std::string& GetLanguageCode() const { return m_language; }
                                                       ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h: In member function 'const string& CLocale::GetTerritoryCode() const':
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:67:56: error: 'm_territory' was not declared in this scope
   const std::string& GetTerritoryCode() const { return m_territory; }
                                                        ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h: In member function 'const string& CLocale::GetCodeset() const':
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:71:50: error: 'm_codeset' was not declared in this scope
   const std::string& GetCodeset() const { return m_codeset; }
                                                  ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h: In member function 'const string& CLocale::GetModifier() const':
ARCH=arm
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/locale.h:75:51: error: 'm_modifier' was not declared in this scope
   const std::string& GetModifier() const { return m_modifier; }
                                                   ^
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:41:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from Interfaces/AE.h:23,
                 from AEFactory.h:24,
                 from AEFactory.cpp:22:
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale: At global scope:
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:53:11: error: '::lconv' has not been declared
   using ::lconv;
           ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:54:11: error: '::setlocale' has not been declared
   using ::setlocale;
           ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:55:11: error: '::localeconv' has not been declared
   using ::localeconv;
           ^
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from Interfaces/AE.h:23,
                 from AEFactory.h:24,
                 from AEFactory.cpp:22:
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h: In function 'int std::__convert_from_v(int* const&, char*, int, const char*, ...)':
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:60:19: error: 'setlocale' is not a member of 'std'
     char* __old = std::setlocale(LC_NUMERIC, 0);
                   ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:60:34: error: 'LC_NUMERIC' was not declared in this scope
/*
     char* __old = std::setlocale(LC_NUMERIC, 0);
                                  ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:67:2: error: 'setlocale' is not a member of 'std'
  std::setlocale(LC_NUMERIC, "C");


Same issue is also occuring on ariesve too? İf yes then we should revert this commit https://github.com/arco/android_device_samsung_ancora/commit/0e8a314eff74aa2d241ece4b184c63b3e37f9f73 our devices(ancora & ariesve) are hdpi devices so we should get hdpi asset not xhdpi
But i dont really know the issue %100 so it might not be...


+1 please add to NPM


Log 2:

CPP     xbmc/epg/EpgInfoTag.o
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:42:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:41,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from ../guilib/LocalizeStrings.h:33,
                 from EpgInfoTag.cpp:22:
../utils/locale.h:153:15: error: field 'm_language' has incomplete type
   std::string m_language;
               ^
../utils/locale.h:154:15: error: field 'm_territory' has incomplete type
   std::string m_territory;
               ^
../utils/locale.h:155:15: error: field 'm_codeset' has incomplete type
   std::string m_codeset;
               ^
../utils/locale.h:156:15: error: field 'm_modifier' has incomplete type
   std::string m_modifier;
               ^
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:42:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:41,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from ../guilib/LocalizeStrings.h:33,
                 from EpgInfoTag.cpp:22:
../utils/locale.h: In member function 'const string& CLocale::GetLanguageCode() const':
../utils/locale.h:63:55: error: 'm_language' was not declared in this scope
   const std::string& GetLanguageCode() const { return m_language; }
                                                       ^
../utils/locale.h: In member function 'const string& CLocale::GetTerritoryCode() const':
../utils/locale.h:67:56: error: 'm_territory' was not declared in this scope
   const std::string& GetTerritoryCode() const { return m_territory; }
                                                        ^
../utils/locale.h: In member function 'const string& CLocale::GetCodeset() const':
../utils/locale.h:71:50: error: 'm_codeset' was not declared in this scope
   const std::string& GetCodeset() const { return m_codeset; }
                                                  ^
../utils/locale.h: In member function 'const string& CLocale::GetModifier() const':
../utils/locale.h:75:51: error: 'm_modifier' was not declared in this scope
   const std::string& GetModifier() const { return m_modifier; }
                                                   ^
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:41:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from ../guilib/LocalizeStrings.h:33,
                 from EpgInfoTag.cpp:22:
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale: At global scope:
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:53:11: error: '::lconv' has not been declared
   using ::lconv;
           ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:54:11: error: '::setlocale' has not been declared
   using ::setlocale;
           ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/clocale:55:11: error: '::localeconv' has not been declared
   using ::localeconv;
           ^
In file included from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/localefwd.h:40:0,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/string:43,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/stdexcept:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/array:38,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/tuple:39,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/bits/stl_map.h:63,
                 from /Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/map:61,
                 from ../guilib/LocalizeStrings.h:33,
                 from EpgInfoTag.cpp:22:
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h: In function 'int std::__convert_from_v(int* const&, char*, int, const char*, ...)':
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:60:19: error: 'setlocale' is not a member of 'std'
     char* __old = std::setlocale(LC_NUMERIC, 0);
                   ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:60:34: error: 'LC_NUMERIC' was not declared in this scope
     char* __old = std::setlocale(LC_NUMERIC, 0);
                                  ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:67:2: error: 'setlocale' is not a member of 'std'
  std::setlocale(LC_NUMERIC, "C");
  ^
/Users/y.tal/kodi-build/arm-linux-androideabi-4.8-vanilla/android-17/include/c++/4.8/arm-linux-androideabi/armv7-a/bits/c++locale.h:83:2: error: 'setlocale' is not a member of 'std'
  std::setlocale(LC_NUMERIC, __sav);
  ^
make[1]: *** [EpgInfoTag.o] Error 1
make: *** [xbmc/epg/epg.a] Error 2


So generally tests are easier to maintain if you have only 1 assertion per test. I would suggest using only the assertion that best tests the description.

BetterSpecs.org has a lot of good testing recommendations:
http://betterspecs.org


Since multiple timezones intersect at the poles, a single solar system at the pole would conceivably span multiple timezones!  Antartica is probably better than ETC/UTC - chosen since it was an unused UTC timezone with no DST.


Log 3:

CPP     xbmc/cores/dvdplayer/DVDCodecs/Video/libstagefrightICS/StageFrightInterface.o
StageFrightVideoPrivate.cpp: In member function 'void CStageFrightVideoPrivate::loadOESShader(GLenum, const char*, GLuint*)':
StageFrightVideoPrivate.cpp:47:73: error: 'CLog' has not been declared
 #define CheckGlError(x)  while((glerror = glGetError()) != GL_NO_ERROR) CLog::Log(LOGERROR, "GL error in %s: %x",x, glerror);
                                                                         ^
StageFrightVideoPrivate.cpp:151:3: note: in expansion of macro 'CheckGlError'
   CheckGlError("loadOESShader");
   ^
StageFrightVideoPrivate.cpp: In member function 'void CStageFrightVideoPrivate::OES_shader_setUp()':
StageFrightVideoPrivate.cpp:47:73: error: 'CLog' has not been declared
 #define CheckGlError(x)  while((glerror = glGetError()) != GL_NO_ERROR) CLog::Log(LOGERROR, "GL error in %s: %x",x, glerror);
                                                                         ^
StageFrightVideoPrivate.cpp:248:5: note: in expansion of macro 'CheckGlError'
     CheckGlError("OES_shader_setUp");
     ^
StageFrightVideoPrivate.cpp: In member function 'void CStageFrightVideoPrivate::InitializeEGL(int, int)':
StageFrightVideoPrivate.cpp:272:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s: InitializeEGL: no display\n", CLASSNAME);
     ^
StageFrightVideoPrivate.cpp:47:73: error: 'CLog' has not been declared
 #define CheckGlError(x)  while((glerror = glGetError()) != GL_NO_ERROR) CLog::Log(LOGERROR, "GL error in %s: %x",x, glerror);
                                                                         ^
StageFrightVideoPrivate.cpp:286:3: note: in expansion of macro 'CheckGlError'
   CheckGlError("stf init");
   ^
StageFrightVideo.cpp: In member function 'virtual void CStageFrightDecodeThread::Process()':
StageFrightVideo.cpp:211:13: error: 'CLog' has not been declared
             CLog::Log(LOGERROR, "%s - Invalid buffer\n", CLASSNAME);
             ^
StageFrightVideo.cpp:274:9: error: 'CLog' has not been declared
         CLog::Log(LOGERROR, "%s - decoding error (%d)\n", CLASSNAME,frame->status);
         ^
StageFrightVideo.cpp:310:13: error: 'CLog' has not been declared
             CLog::Log(LOGERROR, "STF: No free output buffers\n");
             ^
StageFrightVideo.cpp: In member function 'bool CStageFrightVideo::Open(CDVDStreamInfo&)':
StageFrightVideo.cpp:399:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"null size, cannot handle");
     ^
StageFrightVideo.cpp:411:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"cannot allocate MetaData");
     ^
StageFrightVideo.cpp:477:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Cannot obtain source / client");
     ^
StageFrightVideo.cpp:487:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Cannot connect OMX client");
     ^
StageFrightVideo.cpp:498:7: error: 'CLog' has not been declared
       CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Cannot allocate texture");
       ^
StageFrightVideo.cpp:530:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "%s::%s - component: %s\n", CLASSNAME, __func__, component);
     ^
StageFrightVideo.cpp:536:7: error: 'CLog' has not been declared
       CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Blacklisted component (software)");
       ^
StageFrightVideo.cpp:542:7: error: 'CLog' has not been declared
       CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Blacklisted component (MP4)");
       ^
StageFrightVideo.cpp: In member function 'int CStageFrightVideo::Decode(uint8_t*, int, double, double)':
StageFrightVideo.cpp:618:7: error: 'CLog' has not been declared
       CLog::Log(LOGWARNING, "STF: Cannot get input buffer\n");
       ^
In file included from /Users/y.tal/kodi-build/kodi-git/xbmc/Application.h:27:0,
                 from StageFrightVideoPrivate.cpp:31:
/Users/y.tal/kodi-build/kodi-git/xbmc/settings/AdvancedSettings.h: At global scope:
/Users/y.tal/kodi-build/kodi-git/xbmc/settings/AdvancedSettings.h:412:31: warning: 'g_advancedSettings' defined but not used [-Wunused-variable]
 XBMC_GLOBAL(CAdvancedSettings,g_advancedSettings);
                               ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/GlobalsHandling.h:223:22: note: in definition of macro 'XBMC_GLOBAL'
   static classname & g_variable = (*(g_variable##Ref.get()))
                      ^
StageFrightVideo.cpp: In member function 'bool CStageFrightVideo::GetPicture(DVDVideoPicture*)':
StageFrightVideo.cpp:683:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - Error getting frame\n", CLASSNAME, __func__);
     ^
StageFrightVideo.cpp:704:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - Error getting picture from frame(%d)\n", CLASSNAME, __func__,status);
     ^
StageFrightVideo.cpp:763:9: error: 'CLog' has not been declared
         CLog::Log(LOGERROR, "%s::%s - Unsupported color format(%d)\n", CLASSNAME, __func__,p->videoColorFormat);
         ^
StageFrightVideo.cpp: In member function 'void CStageFrightVideo::LockBuffer(EGLImageKHR)':
StageFrightVideo.cpp:920:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "STF: LockBuffer: Unknown img(%p)", eglimg);
     ^
StageFrightVideo.cpp: In member function 'void CStageFrightVideo::ReleaseBuffer(EGLImageKHR)':
StageFrightVideo.cpp:941:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "STF: ReleaseBuffer: Unknown img(%p)", eglimg);
     ^
StageFrightVideo.cpp:947:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "STF: ReleaseBuffer: already unlocked img(%p)", eglimg);
     ^
make[1]: *** [StageFrightVideoPrivate.o] Error 1
make[1]: *** Waiting for unfinished jobs....


Log 4: StageFrightVideo.cpp: In member function 'virtual void CStageFrightDecodeThread::Process()':
StageFrightVideo.cpp:211:13: error: 'CLog' has not been declared
             CLog::Log(LOGERROR, "%s - Invalid buffer\n", CLASSNAME);
             ^
StageFrightVideo.cpp:274:9: error: 'CLog' has not been declared
         CLog::Log(LOGERROR, "%s - decoding error (%d)\n", CLASSNAME,frame->status);
         ^
StageFrightVideo.cpp:310:13: error: 'CLog' has not been declared
             CLog::Log(LOGERROR, "STF: No free output buffers\n");
             ^
StageFrightVideo.cpp: In member function 'bool CStageFrightVideo::Open(CDVDStreamInfo&)':
StageFrightVideo.cpp:399:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"null size, cannot handle");
     ^
StageFrightVideo.cpp:411:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"cannot allocate MetaData");
     ^
StageFrightVideo.cpp:477:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Cannot obtain source / client");
     ^
StageFrightVideo.cpp:487:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Cannot connect OMX client");
     ^
StageFrightVideo.cpp:498:7: error: 'CLog' has not been declared
       CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Cannot allocate texture");
       ^
StageFrightVideo.cpp:530:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "%s::%s - component: %s\n", CLASSNAME, __func__, component);
     ^
StageFrightVideo.cpp:536:7: error: 'CLog' has not been declared
       CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Blacklisted component (software)");
       ^
StageFrightVideo.cpp:542:7: error: 'CLog' has not been declared
       CLog::Log(LOGERROR, "%s::%s - %s\n", CLASSNAME, __func__,"Blacklisted component (MP4)");
       ^
StageFrightVideo.cpp: In member function 'int CStageFrightVideo::Decode(uint8_t*, int, double, double)':
StageFrightVideo.cpp:618:7: error: 'CLog' has not been declared
       CLog::Log(LOGWARNING, "STF: Cannot get input buffer\n");
       ^
StageFrightVideo.cpp: In member function 'bool CStageFrightVideo::GetPicture(DVDVideoPicture*)':
StageFrightVideo.cpp:683:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - Error getting frame\n", CLASSNAME, __func__);
     ^
StageFrightVideo.cpp:704:5: error: 'CLog' has not been declared
     CLog::Log(LOGERROR, "%s::%s - Error getting picture from frame(%d)\n", CLASSNAME, __func__,status);
     ^
StageFrightVideo.cpp:763:9: error: 'CLog' has not been declared
         CLog::Log(LOGERROR, "%s::%s - Unsupported color format(%d)\n", CLASSNAME, __func__,p->videoColorFormat);
         ^
StageFrightVideo.cpp: In member function 'void CStageFrightVideo::LockBuffer(EGLImageKHR)':
StageFrightVideo.cpp:920:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "STF: LockBuffer: Unknown img(%p)", eglimg);
     ^
StageFrightVideo.cpp: In member function 'void CStageFrightVideo::ReleaseBuffer(EGLImageKHR)':
StageFrightVideo.cpp:941:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "STF: ReleaseBuffer: Unknown img(%p)", eglimg);
     ^
StageFrightVideo.cpp:947:5: error: 'CLog' has not been declared
     CLog::Log(LOGDEBUG, "STF: ReleaseBuffer: already unlocked img(%p)", eglimg);
     ^
In file included from /Users/y.tal/kodi-build/kodi-git/xbmc/guilib/GraphicContext.h:48:0,
                 from StageFrightVideo.cpp:30:
/Users/y.tal/kodi-build/kodi-git/xbmc/settings/AdvancedSettings.h: At global scope:
/Users/y.tal/kodi-build/kodi-git/xbmc/settings/AdvancedSettings.h:412:31: warning: 'g_advancedSettings' defined but not used [-Wunused-variable]
 XBMC_GLOBAL(CAdvancedSettings,g_advancedSettings);
                               ^
/Users/y.tal/kodi-build/kodi-git/xbmc/utils/GlobalsHandling.h:223:22: note: in definition of macro 'XBMC_GLOBAL'
   static classname & g_variable = (*(g_variable##Ref.get()))
                      ^
make[1]: *** [StageFrightVideo.o] Error 1
make: *** [dvdpextcodecs] Error 2


you might need to rebase, I believe the test image is already at 0.12.4

https://github.com/taskcluster/docker-worker/blob/master/test/images/test/Dockerfile#L1


This is the method pundit calls internally to find which user to check against for the policy. It was defaulting to current_student and thus always failing and redirecting. Causing the react component to never get an okay response and thus appear to hang.


Thanks!!


@tomsmeding what do you think of this?


So if this works, we can switch out our use of ETC/UTC for the 'genability localdate signal'.  But maybe something like 'tariff timezone'.


@cmrberry All sync'd up to master. The changes seem minor.


Use of the hat (^) will break compatibility with the version of npm that ships with Node v0.8.x


@drhenner @hstove thanks for helping to improve this gem.


Are we ready to drop support for Node v0.8.x?


This remained unanswered. Shall we just drop it?


Yes,

Replacing GetSize/SetSize with GetClientSize/SetClientSize help for the missing 2 lines I'm seeing here and it seems to make DC mode works but it badly breaks in opengl mode if the vp height is adjusted, even the piano rollover has issues!

Moreover a lot of place assume that canvas size and vp size are the same ( grid/bar scale and so on) but currently vp height modif change the scale.


Can you describe what that would look like?


OK, can we put asserts that it's main thread when we access the widget then?


These are four separate issues that were fixed, all related to building android on osx. Not sure why it should fail on other platforms... maybe Windows, if the include path are different in the Visual Studio project?


It might be a little more complicated in MO if you're doing calculations based on the date. This usage is *only* a signal to chop the time off of the serialized form of the DateTime.


CONGRATS!  Proper move!


then they must be inserted a extra case for this... But code parts that looks like this, must be optimised ;)


Yes, I think it should just be using the throttled timer. I'd be very worried if we don't have a widget timer for some reason.. I would think this should be a MOZ_CRASH thing?


Wersja Final spełnia wszelkie wymagania.


make sure when adding a comment to add -m "message" to leave a comment


Yes, not really conclusive. Something seems to be limiting to get really good performance on these boxes.
Thanks for running!


The last assertion is the important one. Alternatively, you could use:
```[@ryan, @john, @matt].each { |u| assert xbox_users.include? u }```


` I wasn't 100% sure exactly what their use cases were`

Mmm maybe I need to have a look at the documentation... If you look at that, can you give suggestions what I should improve so it would be clearer?


Using file naming conventions


:+1: :+1: :+1: :+1: :+1:


Looking now.


i don't understand your comment.

This is a common trait that is shared by the protocols for both placement-`in` and for desugaring-based `box` (which is not in this PR but I think the foundations for it are still here...)  Is that what you mean by "base trait"?

In any case, I'm not quite sure what change you are asking for in this comment. (Though I do see some typos in it, to be honest.)


Marcello, what have you done? This took me way too long to find :scream:


Shouldn't that be "binary key" not "binay key"?


Why would this happen? Do refresh drivers switch widgets? Is this the case when I move one tab to another window?


I like these types of tests.


Trzymanie tego w głównym repo to błęd.


On 07/22/2015 02:08 PM, robled wrote:
> Can we change this to exit 1 since Windows has crashed the terminal?

lol


We should be able to delete sRegularRateTimer in general.


return your new interface, to minimize the number of things that have to deal with an .*etcd.*


return nil, err


Still produce a helper.


Why do we need the mLastActiveTimer? Sorry, I'm confused as to what it's used for.


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This code needs to go. If it's making your life hard, take it out now. There's an issue filed about it already.


Yeah fair point, I was expecting various failure messages from the service worker, which I'm not sure if that is any better than what you are suggesting.


This should be done in processTx as it should have all the necessary information


@tdas I see that build 14 failed, and this commit was the sole change introduced in that build. However, it appears to me that earlier builds had been failing. Looking here:

https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Test%20(Dashboard)/job/Spark-Master-Maven/AMPLAB_JENKINS_BUILD_PROFILE=scala2.11,label=centos/

I see builds 7-13 failed as well. Why do you say the build started breaking with build 14? Perhaps I'm looking at the wrong page?

Cheers.


lgtm thanks


I'd put an assert for null/empty sql strings, it's never supposed to happen


excellent


I'm not sure if understand.
I reckon git does not have eol-style=native (which svn does).
so am I supposed to set the gitattributes on the windows/* files so that
they are always checked out with CRLF? Or always with LF (which I would
prefer, unless windows perl won't run those)
y.

On Wed, Jul 22, 2015 at 5:09 PM, Kirill Katsnelson <notifications@github.com
> wrote:

> LGTM.
>
> There was a reason I set all files in egs/ to LF-only style eof in
> .gitattributes. You may want to do same to this .pl script. But to
> recover from this change (whether done to the repository by yourself)
> you'll need to rebuild the index, or Git will endlessly report the file as
> changed, even though it is not.
>
> Generally you remove the index either "git way"
>
> git rm --cached -r .
>
> or simply (I usually do it this way)
>
> rm .git/index
>
> Of course, your staged changes would evaporate.
>
> Then, if your worktree is clean, the easiest is the hard reset, which
> rebuilds both index and the worktree, setting EOL per .gitattributes in
> process
>
> git reset --hard
>
> If you have worktree changes and want to rebuild the index from these
> files, then the "mixed" (the default) reset is needed, but you'll have to
> convert to correct EOLs manually first:
>
> dos2unix myfile.pl
> git reset
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jtrmal/kaldi/commit/9d8a10abbf1e06903cf98604b572893c9f6b7a15#commitcomment-12307900>
> .
>


You can see the most updated version of this class here:

https://github.com/playframework/playframework/blob/master/framework/src/play-json/src/main/java/play/libs/Json.java

This method had not changed that much and your points are still relevant. Do you mind submitting a pull request to solve them?


What's the difference between the mWidget and mObservedWidget? Is this the child widget? I'm kind of confused as to why both the mObservedWidget and mWidget exist. I would've expected only the "this" widget.


yout took out xbmc/utils from the audioengine makefile - this means on linux any audioengine code that includes log.h would fail


I believe this is still a duplication of `ReturnsTrueOnGetter`


I think the import is on top of some functions in order to only require pymongo to be installed where it is really needed. For example the render slaves also use this class but don't need pymongo.


@koying @wsnipex - i don't like it - what about you?


you should remove that line


Can you put a blurb here on how the widget topology actually works? I don't know it well enough so I may be commenting wrong things here. Thanks!


`void` should be on the previous line


@evilsocket Haha, that was fast! Nice work!


This analysis from 2013 also goes with this report, but does not belong in the repo.
http://eromang.zataz.com/2013/03/24/osx-pintsized-backdoor-additional-details/


I would suggest tests for non-200 responses also (invalid id's, etc).


It should not be used by default since this binding can be already used by applications or the shell.


Please, see the 1st comment.


I saw all the .cpp files compiled to a .o, but in theory you're right that something could be #ifdef-ed. Is there a way for me to run a build on all the platforms with this change on jenkins somewhere?


Should have been 'One final reversion...'


@alexmamonchik version `1.22` added support for `Stripe::BankAccount`, and I need that. I completely understand that trying to keep code updated for an updating API is tough work, I really appreciate it! I'm also interested in contributing to this project, so maybe I'll look into `stripe-ruby-mock` support for `Stripe::BankAccount`.


I'd prefer "Reset scroll".


Ah, gotcha! I began to realize that. The new isopack-2 format is so much nicer too! (:


Can you ignore the bin folder?


I'd like to turn this into a directive at some stage to stop repetition.


Why did you remove the packages folder? Is there any other way to sync the packages?

Thanks!


And committing inconsistencies.


the comment would be better as part of the test name... (just my opinion)
```should "not create 2 users with the same name" do```


Created github repository, listening to 3rd-eye binaural beats, project dev


Where does this new colour come from?


we utilise jenkins if some other devs confirmed that the general approach of altering the include paths is feasible - if not we try to suggest a different approach.


Is it possible to quickly get something together for Java 7?


The explanation of autoSize is pretty clear. When I get to the explanations of the force options its a bit confusing figuring out what the difference is between them and autoSize. Or why you'd choose to use them over autoSize rather.


Shoot. I should be able to do this through binding instead.


I've created a pull request that removes this dependency here: https://github.com/mbedmicro/mbed/pull/1259

Thanks for pointing this out!


Heh, I don't mind a bit bigger :P

Nagas are a bit higher level, so could probably increase Lib/Cha up to 40, maybe Spi/Dex up to 30, decrease... Sta/Str to 20?


You should not touch the backlog at all, just set `sd->scroll` to 0.


I noticed it because I ran tests on a machine that doesn't have R installed and it failed.


com.qualcomm.location.apk causes titan to crash 15sec after boot
log: http://pastebin.com/8swyQ1Gn


What exactly do you want to do?


Yes, if the Tide comes back I'll add it back than.


Right, so I guess the problem is just with rhino, and relatedly, there's a bug in the existing builder code where https://github.com/dojo/util/blob/master/build/fs.js behaves differently on rhino vs. node when encoding === undefined.

Looking at https://github.com/dojo/util/blob/master/build/transforms/read.js to try to understand this sadly undocumented code, it seems like `undefined` is supposed to mean "treat the file as raw" rather than "use the default encoding", so maybe https://github.com/dojo/util/blob/master/build/rhino/fs.js should be updated to behave that way.


Not quite sure what this is doing in this part of the patch, maybe just a leftover from a different commit?


why this as opposed to reset_session ?


Also /system/bin/netmgrd and /system/vendor/lib/libnetmgr.so breaks mobile data


What is the reason you don't send `&pods` directly instead of building a new `kapi.PodList{}`?


@hstove you are welcome! Best way to contribute gem is add required features for you. We can discuss it in our gitter chat.


Side note: I didn't realize you could put a comment here. In a bash script, you can't, because it breaks the above and below into two separate statements. Docker must strip out this line entirely, not just everything following the `#`.

Very helpful to learn.


Bad link


Does this need to be exposed? If not, change to `runListPods`.


otherwise it's fine :3


Return your new interface and make EtcdHelper private.


develop (lefticus) - i386-Windows-8.1-VisualStudio-14: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ruby convention #already_logged_in? for booleans


Please add a test that makes a fake widget or something and ensure the compositor / refresh driver get ticked if we're going to delete these tests.


ah actually I disagree :) first system import, then coala import. munkres however is closely related to the munkres import so I think it makes more sense there. :wq


Yeah, I think you should do this TODO as part of this PR, unless it's really hard for some reason?


/me should stop using things like `/me` or vim commands in github comments...


Hmm, I'd be worried if this wasn't found. Should just be an assert.


Uz ide vsetko

HangMan

Po spusteni hry sa sputi casovac musite uhadnut slovo co najskor pokial uhadnete budete sa moct zapisat do Hall of fame kde su ulozene vysledky


Reordering the file like this makes it hard to read the diff :/


Test description confusing... redirecting to user page, not home in this case.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 194](https://teamcity.labkey.org/viewLog.html?buildId=262147&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 16, passed: 3 Build time: 00:07:04
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

##### there are 6 more failed tests, see build details
```


Still can't understand the reason of diverge.
@gorhill says
> because of serious incompatibilities in the spirit of the project.

and [this](http://www.wilderssecurity.com/threads/ublock-a-lean-and-fast-blocker.365273/page-33#post-2476324)
and stoped contributing here.
Just looks like somewhat disappointment in...
In what?
Coding? Devs? Or all the people? Or etc.
Actualy it's still *utterly strange sequence of events* and *strange set of circumstances*.


I meant to say small change in wording, changing the term position to index since index is more accurate.


Already defined [on line 204](https://github.com/thefourtheye/io.js/commit/7a15aefc0c1d5aec52326d88f3fe6e51feacb388#diff-b13d72249263845d8e8341db0426f9d3R204)?


Change `one` to `single` or `singular`, I think it reads better.


Yeah, I think the reason the `read` transform has not had a problem with encoding and binary files is because a binary file is never passed through the `read` transform (I could be wrong though).


fixes_for_VS2015 (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1763 of 1763 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


reack


seen this twice now... could become a before_action


Could be... obviously it was designed to handle binary files though, but maybe no one is using that functionality.


HAHA :beers:


:cocktail:


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/8239206ec5e283e525d91a8f2fe72cb91e541a5e/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/8239206ec5e283e525d91a8f2fe72cb91e541a5e/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/8239206ec5e283e525d91a8f2fe72cb91e541a5e/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/8239206ec5e283e525d91a8f2fe72cb91e541a5e/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/8239206ec5e283e525d91a8f2fe72cb91e541a5e/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


From what ive seen it looks like curl is most common, although wget is what ive used for a long time. Most shipped scripts are curl.

Sent from my iPhone

> On Jul 22, 2015, at 3:50 PM, Matt Drees <notifications@github.com> wrote:
>
> Side note: I didn't realize you could put a comment here. In a bash script, you can't, because it breaks the above and below into two separate statements. Docker must strip out this line entirely, not just everything following the #.
>
> Very helpful to learn.
>
> —
> Reply to this email directly or view it on GitHub.
>


This should be kept in here, we really have to make sure we do these things on the main thread only. The baked in assumption when enabling / disabling vsync has been, it must be on the main thread.


@crisla and @Falter89

Take a look at this notebook, particularly the code for computing distributions towards the end.  I think that it is correct, but am not entirely sure.  I will think about how to write some tests.


Yeah, it looks like a caching issue; sorry for the noise.


Yup worked perfectly


I was thinking of different date formats, since this example really only supports YYYY-MM-DD.


Add this again pls :3


This completely breaks "log in and place hold" but I know what's wrong and will probably fix it tonight.


develop (lefticus) - Win64-Windows-8.1-VisualStudio-14: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The working assumption we've been doing is that the vsync thread notifies an observer, and the observer then posts things to the correct thread (compositor/main), where the work is done. Try not to do any work on the vsync thread other than post a task.


Please keep things on main thread.


**[phpUnit_trunk_ExternalIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunk_ExternalIntegration/1463/testReport/) for this commit**


I also have james looking at a centos image that we can keep up to date for you.

Sent from my iPhone

> On Jul 22, 2015, at 3:50 PM, Matt Drees <notifications@github.com> wrote:
>
> Side note: I didn't realize you could put a comment here. In a bash script, you can't, because it breaks the above and below into two separate statements. Docker must strip out this line entirely, not just everything following the #.
>
> Very helpful to learn.
>
> —
> Reply to this email directly or view it on GitHub.
>


Does not belong to this commit:
`ClangFunctionDifferenceBear.run()`: The documentation is slightly not correctly indented :D


You can just call ```convert(Dict{K,V}, d)```


fixes_for_VS2015 (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1763 of 1763 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can we just add the categories (:headcount, :finances and :compensation) w/o adding the keys? Reason being... a value of 0 for cash is not really the same thing as cash not being reported.


Make sure we test this on b2g and NUWA.


AddCalcCoilSurfTempSource (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1757 of 1757 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yeah, and the default fall-through UTF8 encoding for `rhino/fs` has been in the code since the first GitHub commit https://github.com/dojo/util/commit/c6ba5f999f475e4689ab9ccce62fa10426d62f39.


ah let me do a commit on top


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 195](https://teamcity.labkey.org/viewLog.html?buildId=262150&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 16, passed: 3 Build time: 00:06:50
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

##### there are 6 more failed tests, see build details
```


Why is it directly connecting to the vsync source? I thought it was going to be on the parent base widget?


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I have been a bit fast with search and replace. Care to submit a PR maybe? :)


S = "${WORKDIR}/git"


wow, I'm surprised browsers allow `new` as a bare key literal like this!


this won't be valid.


Also package structure... perhaps move all etcd specific code into pkg/tools/etcd, leaving only this interface and the stuff you're about to write in pkg/tools?

In the future we'd probably want to rename this package to pkg/storage or some such, but this is already a lot of renaming :)


ack


Very interesting notes.
I'm seeing lots of "he/she", maybe you could take a look at https://en.wikipedia.org/wiki/Gender-specific_and_gender-neutral_pronouns#Singular_they


Wow, now that you mention it I kind of am too. I guess there's a difference for the parser between keywords and keys?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Are you sure? This is going to get messy when DMM releases new ships and your SQL doesn't have them, requiring an update... Unless you have a ship2sql dumper.

Also, if ships exist in the DB and you go to update the DB, does it get nuked or will it skip ships already in the database?


FacilityTabGridView (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Ahh, OK.
Want to povide a pull request?


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (lefticus) - i386-Windows-8.1-VisualStudio-12: OK (351 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


:+1:, ack


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (352 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks =D


RadianceRefactor (rpg777) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@embray - This commit seems to be missing from the v1.0.3. Is that right?


I guess it should be ```isa(res, fitness_type(problem))```


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I added this line to allow the connector access to the full context stream, if they wanted (I needed access to RR)


Feature Count: 10225738
Accuracy: 0.875395578136


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/15402/testReport/) for this commit**


fixes_for_VS2015 (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1246 of 1247 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.97%25-green.svg)


It still needs `title: ` before the title and location: ` before the location.

After that it'll be good to go.


RadianceRefactor (rpg777) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


I don't think that they will come back in the near feature. As far as i can see all bitbuckets and github-repositories are removed (!).


"Baaaaa-sh" :sheep:


likely need this for after_update as well


develop (lefticus) - Win64-Windows-8.1-VisualStudio-12: OK (351 of 352 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


No need to wrap this line


I'll see how easy that is to do, happy to help if I can! Thanks.


Hey. What version of paste are you using?


Thanks.


Incredibly severe that this was not caught by tests.


Good point.  I am hopeful that by that point, we will also have gotten rid of our use of astrometry.net.  If not, we could pursue KTL's suggestion of using a sqlite database instead, or I think we could use afw table to read and write these, or we could use astropy.


o-oh


Thanks!


brunchrey,

Did you ever finish the background check API you were working on? Our team is working on a background check project and is looking for a criminal records source and was hoping you may have some good leads.

Thank you,


This looks like a typo, you probably want `lxc.log` here.


can we move common code to base class? something like
```
  def build_common_uri(*args)
    url = File.join(Azure::Armrest::COMMON_URI, subscription_id)
    url = File.join(url, *args) unless args.empty?
    url << "?api-verson=#{api_version}"
  end
```
Then each manager class can have its own build_url method such as `build_image_url` which composes an argument list to pass to the base class method.


hmm, yes, for some reason I had assumed that if there was no annotation then we default to unstable, but regardless of whether that is the case, better to be explicit about this.


I think I just fixed it. Now smithlab_cpp must be updated.


(facepalm)


Adding a note around running msbuild command


Since it modifies ```params```, Julia guidlines suggest calling it ```check_valid!()```


I would write this as `>= 130` rather than `> 129`.


key: 'searchResultsContainer' duplicated.


From the `ConnectorMetadata` javadocs:

> For each layout, connectors must return an "unenforced constraint" representing the part of the constraint summary that isn't guaranteed by the layout.

So, this should return `constraint.getSummary()` as the "unenforced constraint"


That's fine with me, but let's save that for a separate refactoring PR.


>>
>> Annotation processing can be turned on using regular JDT
>
> Are there any code examples I can look at for this?

Please poke around m2e-apt code, I am afk now.
>>
>> But i think it is enough to support the general case.
>
> Interesting, how can we identify these folders?

I mean we already support the general case with this approach.


i'll give it another shot, its been a while.


because I put too much faith in LLVM


@pearkes I updated the vault demo server, but the tutorial may need it yes. I forgot about that.


Typo: thread_cancel


It looks like ```update_params!()``` is not used anywhere. Also, unless some additional logic is implied, it is equivalent to ```merge!(parameters, kwargs)```


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1244 of 1244 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


in any case the comment there is a lie at this point, since there are `push_unsafe!` and `pop_unsafe!''s mixed in there that are not reflected in the comment.


I still need the sessionID, but this does save me from needing bs4.


Alright, good luck!


Instead of using the macro STORAGED_DRIVE_LSM repeatedly, I would suggest creating a variable of type StoragedDriveLSM* and doing this once and then using the variable in all of these locations.


Nice refactoring.
Better to explicitly name it get_plot_bounding_box or something like that.
"min_max" has a specific mathematical meaning; best to avoid.


Magic number, use a constant here and in the functions that are taking it as a variable or pass the length to them.


To get the associated `IvyModuleSetBuild` you should use `((IvyBuild) build).getModuleSetBuild()` and even then, you still need to do a null check on that. The issue is that modules can build multiple times after their modules set has built, so an `IvyBuild` build number may not actually match up with an `IvyModuleSetBuild` build number. That `getModuleSetBuild` method finds the nearest `IvyModuleSetBuild` rather than looking for an exact match. And even then, there is still a (very remote) possibility of getting `null` back.


If Microsoft.DataConnect/connectionManagers does not have a child resource type, please put it with "resourceBase", after line 54.


Change `;` to `.`


Ahhh yeah, pod specs for everyone :100: :stuck_out_tongue_winking_eye:


Right now all this tests is whether the right template is used, not if the right error message returns. Unsure how to do that.


The main problem here is that the name generator just isn't able to produce that many unique names. A better solution might be to check that the name is unique within the given sector, which would have the added advantage of not requiring a database lookup each time since the stars are all generated at the same time for each sector.

If you wanted to get fancy, you could check that it's unique within the given sector and any surrounding sectors as well. But if you wanted to do that, I would load up a HashSet containing the names of stars in surrounding sectors first, then use that in the generate() method above. That way there would only be one database lookup for each sector generated, instead of one per star.


Works for me.


Typo? You're overwriting $options!


Thanks @kbenne.


FYI, the convention I use in my code is 2 spaces for indentation. I wrote a post about it a while ago, http://www.war-worlds.com/forum/development/war-worlds-coding-conventions though I admit I'm not following perfectly either :)


Would it be better to utilize the std. properties interface and just emit the PropertiesChanged signal when the state of one or more of the attributes change?


@mmatts Could you do a git pull on this branch and re-build the package and try an installation?  I'll do the same on Linux, and @kbenne was testing this on Mac, so this could merge if it's all working.


wait! a "fleshlight" is another thing! XDD


that may not work with CI 2.x, I would keep the associative array.


Isn't the sessionID in `self.session.cookies` already?


It is, it's the one that was used when logging in the first time. It's completely incorrect for any future request.
Also, there appear to be duplicate cookies in self.session.cookies.


Thank you
On 23/07/2015 12:55 am, "Loz Calver" <notifications@github.com> wrote:

> @sunnysideup <https://github.com/sunnysideup> That’s because it’s not in
> 3.1.13, it was merged into the 3 branch so will be in 3.2
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kinglozzer/sapphire/commit/203f77116b6bb79e52f4ec40e0e6e6e8c5ee95fd#commitcomment-12297432>
> .
>


Don't forget to bump the version of knife-windows itself (i.e. to 0.8.6).


needs a test


hmm interesting, I'm not sure pure red is the best color for testing retina (something about how they build the screens)... Have a look at this on a Retina: (based off your fiddle):
http://jsfiddle.net/9dsvmd6r/6/
As you can see the bottom circle is much clearer...


dependencies {
   compile 'com.umeng.analytics:analytics:latest.integration'
}


ok


Thanks. Was a leftover that was not needed. Will delete.


Not able to install for me due to em-winrm (you may need to do a git dependency to get things to work):

```
ERROR:  While executing gem ... (Gem::DependencyResolutionError)
    conflicting dependencies winrm (~> 1.3.0) and winrm (~> 1.2.0)
  Activated winrm-1.2.0
  which does not match conflicting dependency (~> 1.3.0)

  Conflicting dependency chains:
    knife-windows (= 0.8.5), 0.8.5 activated, depends on
    em-winrm (~> 0.6), 0.6.0 activated, depends on
    winrm (~> 1.2.0), 1.2.0 activated

  versus:
    knife-windows (= 0.8.5), 0.8.5 activated, depends on
    winrm-s (~> 0.3.0), 0.3.0 activated, depends on
    winrm (~> 1.3.0)
```


Thx for the mention!


ah, I forgot to push master along with the tag


Can you provide the FCC ID of the meter in question? As well as how you determined the frequency it transmits on?


this is probably going to be too old, which version of automake are you using?


Out of habit I usually put the @FXML annotated globals at the bottom of the class. No real reason why, just so that I don't have to scroll through them all the time


Not it isn't i copy the configfile to /var/log/lxd/<container>/lxc.conf


Commenting here to remind me tomorrow, but I should actually refractor the add case clean up into such a method as this


Do we need to hide the FB login button before do this ??


Neat! Thanks!


please no backporting until something has been on master for a few days - and needs a test here too


you need to use bundler. em-winrm requires a gem release

On Wed, Jul 22, 2015 at 5:55 PM Adam Edwards <notifications@github.com>
wrote:

> Not able to install for me due to em-winrm (you may need to do a git
> dependency to get things to work):
>
> ERROR:  While executing gem ... (Gem::DependencyResolutionError)
>     conflicting dependencies winrm (~> 1.3.0) and winrm (~> 1.2.0)
>   Activated winrm-1.2.0
>   which does not match conflicting dependency (~> 1.3.0)
>
>   Conflicting dependency chains:
>     knife-windows (= 0.8.5), 0.8.5 activated, depends on
>     em-winrm (~> 0.6), 0.6.0 activated, depends on
>     winrm (~> 1.2.0), 1.2.0 activated
>
>   versus:
>     knife-windows (= 0.8.5), 0.8.5 activated, depends on
>     winrm-s (~> 0.3.0), 0.3.0 activated, depends on
>     winrm (~> 1.3.0)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chef/knife-windows/commit/aee4c244a285c76ed5c8193febab7b60322366ad#commitcomment-12309716>
> .
>


AddCalcCoilSurfTempSource (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1763 of 1763 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Starting this project with GNU GENERAL PUBLIC LICENSE Version 2, June 1991. Will revisit licensing decisions as the project evolves.


This commit broke checkout for monodroid:

```
*** git checkout mono-4.2.0-pre2-branch
error: Your local changes to the following files would be overwritten by checkout:
	mcs/class/System.Configuration/System.Configuration_test_net_4_x.dll.config
Please, commit your changes or stash them before you can switch branches.
Aborting
error: Your local changes to the following files would be overwritten by checkout:
	mcs/class/System.Configuration/System.Configuration_test_net_4_x.dll.config
Please, commit your changes or stash them before you can switch branches.
Aborting
*** git reset --hard b956524379f0e4ca34952cca18f5b61fcb96e571
HEAD is now at b956524 bump referencesource
*** git submodule update --init --recursive
Submodule path 'external/binary-reference-assemblies': checked out '7120b21603354fced392a43ab7c581d0114fecac'
Submodule path 'external/referencesource': checked out '6aee8b4760179dc96259c7948760a4b451bb09ec'
Warning: make reset-mono does not automatically clean up mono. You may have to run 'make clean-mono' separately.
```
cc @jonpryor


1. The example needs to be updated.
2. Can we automatically append request.getServletContext() so that sendRedirect() and forward() act the same?


**[phpUnit_trunk_ExternalIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunk_ExternalIntegration/1465/testReport/) for this commit**


This should be fixed on master – let me know if it seems like it's working to you.


AddCalcCoilSurfTempSource (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


nevermind, looks the same as https://github.com/JuliaLang/libuv/blob/julia-uv0.11.26/compile


I dunno ... how about `release_the_kraken`


That part's not checked in yet


Weird. I had selected the mensural branch, and I could swear that commit wasn't on the screen before, but it's there now. Oh well. Thanks.


hmmm so strange... have a look at this (forked from your fiddle):
http://jsfiddle.net/9dsvmd6r/7/
As you can see the first circle is blury (like retinaScaling has been turned off)
Any idea whats causing this?


Are we using the latest BatGen?  I thought we got rid of the map based searches.  Hang made a change very recently.


Not so bad, to move most of important Values to userspace .. but to be honest i don't see any automatic detection for both batteries... (no proper default profile)
U should also consider that most of 3rd-party batteries are 3.7V .. and even so called org. SAMSUNG 3.8V (the cheap version) are fake cells, so they have also 3.7V. But both Battery tables should be approx OK for most of combinations ...
btw: 4.2V term._volt for the org. battery isn't a bit low ? 4.25V should be enough :-)


Kleine Überraschung :p, da waren die Tests wohl nicht ganz vollständig.


@cathay4t In your comment you state "Create a monitor thread for each LibStorageMgmt URI to monitor
RAID status changes."  However, when I look at storaged_linux_drive_lsm_update it seems to be creating a new monitor thread for a given WWID?  How does this not end up being multiple threads for potentially the same HBA?  What am I missing here?


لما تترجمت حط الكلمه الإنجليزي الأصليه بين قوصين عشان الشخص اللي بيقرأ يبقي عنده القدره إنه يبحث عن معلومات زياده في الموضوع عن طريق الكلمه الإنجليزي


IPv4Address class in c&c.


ده مثلا مثال أقوي في الموضوع ده، يعني أنا لما قرأت مكنتش فاهم إيه نظام النوافذ ده :)


ahhh ha!
I figured it out... its this line:
canvas1.setWidth(100);
canvas1.setHeight(100);

If you change the code so the "width" and "height" is set on the actual canvas HTML tag, the blurry goes away! I guess there must be something in fabric.js the prefers the width on the element rather than setting it via the "set" functions?


Was this comment ever addressed?


AddCalcCoilSurfTempSource (kbenne) - x86_64-MacOS-10.9-clang: OK (1756 of 1757 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


This is just whitespace changes - can you rebase to lose this please?


remove rx from server tests


لفظ نظام التشغيل، إنت تقصيد بيه النواه بس ؟ و لا النواه و كمان اليوسر سباس ؟

لإن الوصف اللي إنت كاتبه بيوحي إنك بتتكلم عن النواه، و بعد كده المثال بيتكلم عن السيستم كامل، فأعتقد إنك لازم تضيف كلمة "نواه" في البدايه و في الأمثله


Partially in cc001eaac3865a06889aad9068c4b676c53eef66


@rexissimus: This might be close to what you needed for the .vtl files, although perhaps a separate function is needed? (vtls point to a single version?)

I use it to test MongoDB #1106


My bad that I mixed renaming of some fields with the fix that the comment of this commit claims. :-1:


No we are not moving to VS2015 yet. And yeah I can't compile the extensions any more.


有些图片不一定需要


*إشباع هذا الفضول


This will evaluate as true by default. You probably need to do two things:
1. validate $config is a hash
2. check if it's empty


For what it's worth, `npm run build-debug` works for me with the transform and not without.


What are the group names improvements we are trying to get here ?

We could just change the regex ?


Probably don't want to hard-code the name of the config file here


أعتقد "المتطلبات" بس كفايه و ممكن تحط جنبها
prerequisites
لو تحب يعني.


No, since the text field clear button already adds a lot of padding to the end of the field.


Why?
I added the counter for exact this reason, so we publish the fact that we finished performing that operation but it could be that no reclassifications were done.


Yeah just "a few" :P


I mean will it really go anywhere else? this is hardcoded in the ::defaults file.


Does ruby treat a empty dict as truthy? Normally this is treated as a falsy thing.


This method disappeared somehow. I'm working on a PR.


أعتقد إنك هنا مُعتمد علي السلسله بتاعة محمد أنور اللي لسه مخلصتش، و لازم علي الأقل يكون فيه لينك و لا حاجه ليها


@glasser What happens when multiple plugins registered with `registerCompiler` specify the same `extension`, f.e. `'js'`? Do multiple compilers get applied in some order?


The new line at the end of a file is just good to do for diff purposes.


أنا أعتقد إننا محتاجين نحط قواعد في موضوع الترجمه ده، لإني محاولة ترجمه المصطلحات ممكن يضر فعلا بسبب إن الشخص اللي بيقرأ المقال معندوش أي قدره إنه يكمل لواحده بسبب إنه معهوش أي
keywords in english
يعني المجمع و الرابط دي صعب إن حد يتخير إنك تقصد
compiler and linker :)


What is the error list for?


أعتقد إن بعد النقطه دي ممكن تضرب مثال مثلا إزاي تقدر تنزل الحاجات دي علي توزيعه زي أوبونتو، أو أي توزيعه إنت هتستخدمها في السلسه، أو حتي تشاور علي مقال بيوصف الموضوع ده