Any particular reason we do dup here? The default isn't to have it in place.


Good to know. :+1:


Yeah, that decision still makes sense to me. Less potential redirect problems. Any counter-arguments @fantasticfears ?

If we have Breadcrumbs in the future that's the best way to give the User a "sense of location" anyhow.


please fix these issues where you replace tabs with spaces


moved this to a function in next commit since it was duplicated for exclude


if you change the game like that way, why do you keep `Math.min()` in else snippet? Please tune it up some time.


**Additional waterway conflation UI changes required**
The following fields should also be disabled when the Waterway Auto Calc Search Radius checkbox is turned off:
* Waterway Rubber Sheet Minimum Ties
* Waterway Rubber Sheet Ref


I think it should be Wi-Fi


Updated.


@biocross: Is [this](http://jtrans.meteor.com/) the one?


I think without them there were some failing test cases (because of older cobs in the test data directory). I took that as a sign that we might yet have some older assets about too, but maybe we shouldn't worry at this point? We have a similar fallback in `TransformOp` which we took as descendant for keeping this.


Not sure if using requireConfig is really legit or not (though I also don't really know why it wouldn't be).

Works though


are required devices still executed like we'd expect when topology is not in use?


LGTM on this commit.


Should probably be able to just use requireConfig here


Use strict mode.


Changes made and pushed for your review.


please use setproperty instead, see http://www.cmake.org/cmake/help/v3.1/prop_tgt/CXX_STANDARD.html?highlight=cxx_standard


why get a Long and then cast to int?


JSHint should run also in this file.


Good point on base. I'll fix the text and file a followup issue to change the terminology elsewhere as well. I'll also update the rest of the text as you suggest, I think that's a better way of describing things.


Are there any scenarios in which this isn't true?


You can use .size(0) rather than the shape() same for strides if you have to deal with them.


Yeah, I figured the directive refactoring was a minor enough change to not bother separating it out.


hello world


Again size(1) rather than shape()


In line 219-220 why is there both a "return 1" statement and a "continue" statement. I believe there should only be a continue there. Can you confirm this?


Please remove the file core/gerbil_cplusplus.h from the sources and replace the macros where they are used with their respective counterparts (e.g. nullptr instead of GBL_NULLPTR.


`location: BBQ at Andrew's house`


```
var snippetButtons = document.querySelectorAll('.snippet-caption .copy-to-clipboard-button');
// ...
[].slice.call(this.snippetButtons).forEach(function(...) { /*do work in here */ })
```


I've written enough C to have this scare me, but it only wouldn't work if moduleName wasn't a string..which could happen if somebody messed up their config file? Do we care about that?


> This should probably defined somewhere above as a "constant" with some explanation.

Yeah, you're right. I'll move it, and add a big explanatory comment.

> And shouldn't it be '21.0' now?

It _should_, but:

1. the previous version hardcoded to "19.0", and
2. I think the "spec" (i.e. whatever we tell customers and/or our internal docs) expects this will be "19.0", and changing it might break existing driver disks?

Naturally I'll put that in the comment as well.


I'd move this to Silme, too. It's support for .inc doesn't work very well, but if we switch to our own fork, that's no longer a problem. https://bugzilla.mozilla.org/show_bug.cgi?id=1181604


that definitely helps with the fact that you didn't get permission anyway


Я как раз к `init` все и привел, чтобы было как там. В скрипте много таких мест, где могут возвращаться неявные значения.


Better distributions for random numbers


@everpeace why is this needed? Can't find it in the vagrant documentation


Might be better to implement a Layer(int) in MultiLayerNetwork?


Why commented out?
Can you either change it to have the test committed (but disabled if you like) ? with a TODO block on why it's disabled?

If it's moot code, lets just leave it out?


Same here..


Why commented out?


Thanks, now it works.
On Jul 8, 2015 1:53 PM, "Vitaly Litvak" <notifications@github.com> wrote:

> @mpele <https://github.com/mpele> I have fixed compilation errors in
> 4204266
> <https://github.com/vitalidze/traccar-web/commit/4204266ccf424036746035238af621075bdb7289>
> Please try latest dev branch.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vitalidze/traccar-web/commit/04bf12a62b5b41e2b60ff4e57d4bf7aa97bfa4e0#commitcomment-12059639>
> .
>


I'm still partial to `get_entry` but understand this is a bit overloaded.


:)... the issue here is that only knows why these are commented out.. it would be hard to collaborate with you on those.


972124-2NewDetailedIceStorage (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1161 of 1161 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.82%25-green.svg)


> You use kwargs in the DeviceInfo class later on to prevent having lots of args.

Well, kwargs gets used there because the keys output by `blkid` aren't predictable - they vary wildly depending on the block device.

But the output of `dd_list` is well-documented and completely controlled by us, and I prefer to have at least a _little_ type-safety if I can.

I could maybe use `namedtuple` here, though, but I wanted to avoid pulling in more dependencies?


People have wanted `key` on VacantEntry fwiw, maybe out of scope.


These were actually rosbuild packages which is why there were manifest.xml files. They should probably actually be catkinized, but if they work like this, than that's fine for now.


Why did you need this class?

We have a nice class, called ReusableLatch that could maybe be used here?

Or Regular latches?


雄爷提到糗百 我发现全公司 除了各组长 我是工作上接触到同事最多的了 没有之一
近到设计妹子 远到北京渠道的 视频的 看个病qq不停歇
因为前端确实是个枢纽 同时也是糗百根基 再就是前端确实没人


Он выполнялся 2 раза. Первый раз до загрузки DOM
Тогда тут нужно

```js
	if(!nav) {
		initNavFuncs();
	}
```


Hey @dragondz - thank you for these changes and additions. Are you willing to continue being an official Textpattern translator for `ar-dz`? See here for more information: http://forum.textpattern.com/viewtopic.php?id=45789


What if someone rename binary name? I know people do that to have different configurations and so on.


oops, my local dev stuff :-)


The one what?

Sent from my iPhone

> On 08-Jul-2015, at 9:22 pm, Aneesh Neelam <notifications@github.com> wrote:
>
> @biocross: Is this the one?
>
> —
> Reply to this email directly or view it on GitHub.
>


Use braces rather than '\' to spread an expression over multiple lines:
self._asn1_cert["tbsCertificate"]["extensions"] = (
  filter...
)


how is it okay that this block is removed?


Wow, really? z-indices never cease to amaze me...

Changes look good code-wise, I assume you've done the cross-browser testing round?


Shouldn't `resource` here be be dynamic, like it is for Add Resource on the header? (So it can be `Watershed Solution` or such?)


If requestCachedPwos is false here (as called in NearbyBeaconsFragment in onRefresh), does this mean that the fragment won't get the cached pwos, and only newly discovered pwos?


const


Adding a property to the Resource model might make sense, but that bug made it sound like you're suggesting a new model, which is a bad idea; it'll incur extra query time for data that doesn't change (whether a format is asymmetric or not, etc.).


Hmm... interesting.


I'm not sure I agree with the changes on line 150 and 152. I believe you are trying to find the peak of a distribution whereas I was trying to find the mean of a distribution. My histograms are Gaussian, whereas your histograms more closely resemble an asymmetric Gaussian, if remember correctly. Can you implement a ternary operator with a command line option called mpv (most probable value), much like in the jet_l2_correction_x program? I think this would allow you to have the peak finding ability while not changing the functionality for other users.

In line 230 and 276, why did you manually limit the range to 1 TeV? This seems dangerous to me. We would need to remember to change this every time we change energy. What didn't you like about the automatic range finding ability of the program?

Also, why is there the comment on line 229?


const ;-)


tracForce - вектор, а scSpeedFirst - число


hello world


Should this be a minor version bump since new features were added?


Ah, great :)


del


I was planning to ask @dboyer for text confirmation, but yes, that at the least.


nit: key_hash rather than keyhash (two words).


I'm not opposed to this change, but please remove the commented out original lines. This is more a cosmetic change and limits some confusion.


наверное, присваивание лучше запихнуть в else


Here is a pull request which embeds the image: https://github.com/strongloop/strong-swagger-ui/pull/5


fwiw this is unspecified behaviour


Done!


:cool:


Gonna cry about it?


Looks good to me!


If you are simply removing something why did you comment it out and not remove it all together. Will you be adding it back in at some point?


Word


А. Ну да. Тут же у нас домен указан.


This block short-circuited processing if ndevices <= 0. The new approach calls add_result() only if ndevices > 0 instead. So processing continues past this point now, and a host that reports ndevices <= 0 is (mostly) treated the same as other hosts, which works out to the same behavior as this block but with more consistent logging.


hello world


![barbrady](https://cloud.githubusercontent.com/assets/2228052/8575457/52641edc-259c-11e5-9220-6b89b6e177eb.jpeg)

Egg in face. Want to un-embarrass us by making a PR, @tpinne? :)


Awesome to see the the leaf temperatures available - however I'm noticing that when the 'heat' or 'cool' is not the last one enabled, it returns a ridiculous value of either 0 (cool) or 1000 (heat). Any thought to changing this to output a false rather than the ridiculous value?

 'auto_cool' => ((float) $this->last_status->device->{$serial_number}->leaf_threshold_cool == 0) ? false : ceil($this->temperatureInUserScale((float) $this->last_status->device->{$serial_number}->leaf_threshold_cool)),
            'auto_heat' => ((float) $this->last_status->device->{$serial_number}->leaf_threshold_heat == 1000) ? false : floor($this->temperatureInUserScale((float) $this->last_status->device->{$serial_number}->leaf_threshold_heat)),


This should live in a separate file, as (so far) we've kept the cert module non-CT specific.
Also doesn't seem like it has to be a part of the Certificate class - as the return value is ultimately the TBSCertificate, you can just return it and let the caller manipulate it.


Right, and I'm somewhat concerned about that. I opened rust-lang/rust#26888 to at least get this documented, but if it's unspecified, then I guess it's not a breaking change for us to alter the behavior because no one could legitimately be relying on it? If it is a breaking change, then I think it's best to maintain the current situation and add the separate `replace` method, but we'll have to revisit this topic again when we get generic collection traits.


Since ADD copies the whole directory (recursively) here, it seems that this single ADD is sufficient. Couldn't it be moved to line 6 and all the other ADDs and COPYs be removed then?


it has to


Have you considered using `CMonitor::CenterWindowToMonitor` instead of duplicating it?


Resolved by https://github.com/meanjs/mean/commit/05d4c1c5464d47d514e947603ad04a49a7a4d53f and https://github.com/meanjs/mean/commit/39f330d976eb11d6eae7f064d28027979b458339


maixuanhan: If the following what you mean?
```this.mass = Math.min(this.mass + n,this.owner.gameServer.config.playerMaxMass);
if(this.mass + n > this.owner.gameServer.config.playerMaxMass && this.owner.cells.length < this.owner.gameServer.config.playerMaxCells) {
this.mass = (this.mass + n) / 2;
this.owner.gameServer.newCellVirused(this.owner, this, 0, this.mass, 150);
}```

If so, then ```this.mass = Math.min(this.mass + n,this.owner.gameServer.config.playerMaxMass);``` would be a waste of CPU cycles when addMass is called frequently.


`slice` refers to the `line[:7]` part, and it returns a string with the first 7 characters removed, which is what you really are trying to accomplish with the `lstrip` call. Your goal is to get rid of the `#define ` at the beginning of the string. Slicing is for removing specific text from the beginning or end of a string, whereas `lstrip` is for removing _types_ of characters, usually whitespace, where you don't know exactly the contents that you want to remove.

While strip does, in this specific case, get the same end result, it's not the right tool for the job, which is why I suggested slicing the string instead.


Resolved by https://github.com/meanjs/mean/commit/05d4c1c5464d47d514e947603ad04a49a7a4d53f


Thanks a lot for the quick review!


I'm expecting a whole bunch of naming suggestions on the actual RFC, so you may get your wish.


So I haven't gone through all of the changes and in principle I'm not opposed to adding back in the tau code. However, you seem to have commented out or removed a lot of the code used for other JEC work. Did you mean to do that? For instance, by merging this commit I would be removing the doProducer flag and a majority of the non-tau jet collections.

What were you trying to accomplish. If I know this I might be able to suggest an alternative change.


We also don't want outer forms handling this


You could use 'existsRole' here.


It is ok for now as is. Analog output was mostly requested with touchscreen combination. And this part will be included only in my images (tslib library + my touchscreen input daemon + evtest).


Missed this - resolved by https://github.com/meanjs/mean/commit/39f330d976eb11d6eae7f064d28027979b458339


existsRole*


Komentarz do hW


I think this message should be 'Success.'.


s/Weave Net/weave
s/protocol-min-version/min-protocol-version


I'm not happy with this change - it should say mcp2525@1. If this in some way fixes a problem then it is by accident.


No, good catch. I'll add a commit to fix.


Sure. Nothing against that.


These lines could be defined outside of this function.


This change is wrong. It is saying to write a 32-bit value 1 byte into the "interrupts" property, which is not what you want. Leave this line as it was.


OK, just checking because it is a different thing if existing pieces break. In the past, this has been solved by keeping an ````"..._old```` version. Not sure if it is necessary here, but we do need a rather clear instructions how to convert old parameters into new, which should go into the helpfile. Do you think you could provide such a little formula?


Were you working off an old version of addAlgorithm? Some of the edits being added back in seem familiar; as if they were there a year or two ago and before a lot of the new features were implemented.


You should return here or an unexpected behavior will happen.


existsRole "throw" error if the role doesn't exist, in this case I need the error if the role exists


You can pass directly 'done' as the second argument here.


Ahaha. I forget to remove these things.


that's just for testing


You can also pass 'done' directly here.


Sorry, yes - I'm used to reading C where the style guide puts each case on a separate line.


Same here. Pass 'done' directly.


@sgomes Yup, fine everywhere.


And here (pass 'done' directly).


+1, si une âme charitable veut bien s'en occuper :)


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


:+1: maybe the semantics of this flag should be flipped, so the assumption is non aws, but let's unblock now.


There's another typo in this very line: `ELement`. ;)


I like equations in groupbox titles. It says much more than some weird name of transformation.


@lrnzcig I'm not clear why you removed the `repeat` parameter from `TweetWriter` initialisation. Is there something else that gets the same result?


This problem was caused by a PHP bug.

https://bugs.php.net/bug.php?id=70027


This is perfectly fine, but why not simply `std::vector<TCHAR>`?


97643186-ABUPS-total-row-not-match-water (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1684 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Has this been resolved meanwhile by the developments ?


Can you put a comment that indicate that the test of login stats here? like the comments  /** config **/ and /** signup **/


@mikemcquaid I’m not comfortable with the idea of ignorable audit problems. We should be able to run `brew audit --strict` on a formula and fix all the issues. But I agree it’ll be a good info to have when deciding to boneyard a formula or not.


I'm good with that text as long as Resource is dynamic and changes based on the terminology the map owner has set. Do we use "Warning" as the header for other messages? We should be consistent in what we use for that header.


0 and 1 mean nothing to those who do not understand zabbix.  It would be better if you had some constants for zabbix_true = 0 and zabbix_false = 1


I suggest a separate method for handling certificates with embedded SCTs as they'll have to be stripped out first. Could be named something like verify_embedded_scts and take only a chain, not an SCT.


Change List<any> to String[]


What is this?


questo produce un errore di compilazione (almeno su Mac). La versione corretta è:
```
#if (QT_VERSION < QT_VERSION_CHECK(5, 5, 0)) && defined(Q_OS_MAC)
```


Same, comment that these check /api/users


@tomsmeding btw for future reference, `Board::at` doesn't care about bounds, it just iterates over every bot and checks if the x and y is the same as the given ones.


I checked with your test build and is seems to be not on top. Weird because IIRC DrDump were on top before now both dialogs aren't.


Do all that in a separate method - we don't want this method growing too big.


you need to do this change in the bridges now?


Vectors of small types are terribly inefficient. But with such short strings... depends on preference.


Yes, we do using the same header/text.


The zap delete stuff isn't correct yet it seems!


This doesn’t look like `0.5.0` that you’ve written in the commit message. ;)


Also not clear why we need `retries_after_twython_exception` as a parameter of `_search_tweets()` since it is not used in the body of the method.


В этой строке и выше зачем-то в treeview передается список точек доставки, хотя они должны браться из модели представления. Вообще что бы завершить переход, нужно полностю исключить ображщение к списку из контрагента и убедится что в мапинге для списка точек проставлено lazy. Если оставлять обращения то VM не уменьшает количество обращений к базе а увеличивает. Ниже в этом же файле забыл удалить SetCell функцию.


97643186-ABUPS-total-row-not-match-water (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


М-м-м. Кто-то коммитит даже без компиляции


That's a good point. It's worth testing, but it may be that the biases in the current proposal distribution work better in practice. IIRC, MrBayes selects a subtree to move uniformly at random, and then moves away from that node repeatedly with a given extension probability. When this random walk finishes, the original subtree is moved to this final point. Depending on the extension probability, this method may be biased towards shorter moves, in addition to the general NNI bias caused by not avoiding SPRs that lead to the same topology. How about something like:

This stands in constrast to the sampling methods used in current software programs such as MrBayes which do not propose SPR moves uniformly, although it remains to be seen if the inherent biases in such proposal distributions are better suited to typical posterior distributions.

Or maybe just the first half of that?


Sure, I forgot.


YES!


We should avoid calling FunctionWrapper.apply unless we have to. Such calls are a lot slower than regular functional calls.

Why don't you just do the following:
```
var digits = ListWrapper.first(args);
return NumberPipe._format(value, NumberFormatStyle.DECIMAL, digits);
```

It applies to al the pipes.


awesome! such an easy fix to a complicated problem :) :+1:


So these tasks are provided by Pliny now?


Попизди мне тут в моих домашках по осям =\


Недавно заходил, все норм и с активным скриптом.


true


ok


Все редиректит на 2ch.hk, кроме 2ch.pm


Always were, but the have fixed dumping already.


@amorag @fergunet por favor revisad lo de la respuesta a los revisores antes de hacer git pull. Lo único que he hecho yo ha sido resolver un conflicto en el paper normal, este .tex aún ni lo había tocado. Le he enseñado a Fergu todo lo que he ido haciendo y ha visto que me ha salido de repente la respuesta a los reviewers incluida en el commit. Intenté hacer checkout pero nada...

Así que mis disculpas y a ver si no se ha borrado mucho.


Тут в TreeNode нет необходимости. Думал успел поудалять, то того как ты начал работать с VM


Oh, fixup, you know.


s/specifying/specify


Currently we are using a different way to implement simple stateless pipes (see json_pipe). Can't we use the same approach here?


No, simply remove `Math.min()` in else and use a normal assignment like `this.mass = this.mass + n` or `this.mass = this.owner.gameServer.config.playerMaxMass`.


Oh yeah I think you're right. Sorry about that, it was super late when I was coding it, and kept adding more stuff. I originally just wanted to fix #2260, then when I was about to close it I found #2129, etc......


oh


But do we have such preprocessor definitions to use here?


I've attempted to use VoatKit in a Swift project, which requires the use of frameworks, so I ended up having to change the import statements for the dependencies. I'm not sure if this would work in a non-framework based Podfile.


Yes, I'll get this in.


And renamed binary == unofficial build.


@jglovier Why does the scroll-container have an overflow of scroll vs auto?  Here is what I see on my screen:
![screen shot 2015-07-08 at 12 26 08 pm](https://cloud.githubusercontent.com/assets/609052/8575920/91df42a6-256c-11e5-9729-1beb4f4e1565.png)
Notice the (unneeded) scrollbar around the navigation.


No problem. I don't have time to code, but I don't mind reviewing from time to time :-)


This is quite odd, why the `string` isn’t a symbol or class?


tabbing is weird here, and other places too I think.  Notice in the first block how the description is indented more than the summary, and in the second block, it's the opposite problem.


Do you wanna submit this as a PR to the main project? Nice catch.


Those are module methods, very simple: https://github.com/interagent/pliny/blob/13a94a3fc7e093ec811de3d3fb09543d4bf28494/lib/pliny/config_helpers.rb#L18-L36


Would yo mind if I order these variables by alphabet? You know… OCD…


Cool


Ah, I see, this is clever.


Looks good, you can merge to master.


Yes, I would mind.


В корне неправильный подход, доменая модель нее может линковаться на Gtk и QSTDI она не может обращаться к любому GUI вообще.


It was commented and not used I believe.


Please add footer style


This looks much better than before.   I was thinking that rather than passing in the `oldContext`, that `_getContext()` could just return 0, to indicate that it's a weak character.  Then I suppose the function would be better called `_getType()` rather than `_getContext()`.


beseder....


ref tyru/caw.vim#20


It seems to be that `Term.Name.Quasi` is wrong here. We need to change the type of the quasi according to the spec.


Se puede ver en los commits correspondientes.

El 8 de julio de 2015, 18:24, Paloma de las Cuevas Delgado <
notifications@github.com> escribió:

> @amorag <https://github.com/amorag> @fergunet
> <https://github.com/fergunet> por favor revisad lo de la respuesta a los
> revisores antes de hacer git pull. Lo único que he hecho yo ha sido
> resolver un conflicto en el paper normal, este .tex aún ni lo había tocado.
> Le he enseñado a Fergu todo lo que he ido haciendo y ha visto que me ha
> salido de repente la respuesta a los reviewers incluida en el commit.
> Intenté hacer checkout pero nada...
>
> Así que mis disculpas y a ver si no se ha borrado mucho.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/2014-2015-COMCOM-MUSES_vs_SotA_BYOD_Systems/commit/f4c6d6c054941e5d208f51a04e59c2458b51cd9a#commitcomment-12065999>
> .
>

--
JJ


Extraneous end of line


It's being redone by @rafaneri.


> Vectors of small types are terribly inefficient. But with such short strings... depends on preference.

Disregard this. They're fine if you're aware of all (re)allocation and initialization quirks.
Brainmeltingly hot here...


Oh. That's not pretty. Can we do this differently?


I be damned, you are right


Could you dig up the children on line 19, rather than in the template?


This `if()` statement seems mainly redundant with the `if()` statement below.  If you just modify the `if()` statement below a little bit then you don't need lines 48-50.


Done


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17649/testReport/) for this commit**


Last four lines can be changed to:

```js
} else if (shaperType === "Contextual") {
    return this._shapeContextual(text, textDir === "rtl" ? 2 : 1);
} else {
   return text;   // eliminates need for lines 48-50
}


Antonio, en vez de cambiar el quotation (que es, literalmente, una cita) podías haber arreglado los saltos de línea. En cualquier editor bueno es eimplemente cuestión de configurarlo. Por favor, no cambies las cosas de esta forma porque todo tiene su razón de ser.


Hemos estado mirando Fergu y yo y al final es que en los merge salen los cambios como si los hubiera hecho yo, pero está todo bien :)


Nb. osrm v0.4.5 requires this '-c' flag (so this change breaks the daemon for this version of osrm). Maybe it would be good to be more explicit about which versions of osrm this cookbook supports?


It's not a compatible update. zf-mvc-auth depends on ~1.0 of zf-oauth2, and expected the service manager to return an instance of Oauth2\Server when asked for the key "ZF\OAuth2\Factory\OAuth2ServerInstanceFactory" - this includes ALL version 1.x of zf-oauth2. It has changed incompatible, and must be tagged with a major version increment. Yes, I do consider configured objects in the service manager to be part of the public API of a module. Tagging it as 2.0.0 would have avoided the whole issue, because zf-mvc-auth could have the change applied and at the same time change the dependency from ~1.0 to ~2.0 for zf-oauth2. Please stick to semantic versioning at all times.

Best way to get out of this mess: Create a new tag that is the same as the last compatible tag in version 1, and create a new version 2 tag for the incompatible change. Moving all useful and compatible changes since then into the newest compatible version is optional.


Not sure you need this `if()` statement at all, but if you do, then it shouldn't return `undefined`, because that will map `""` --> `undefined`, whereas `""` should just be mapped to `""`.


See - https://visualstudiogallery.msdn.microsoft.com/20b80b8c-659b-45ef-96c1-437828fe7cf2

This tool for Unity integration with Microsoft Visual Studio is very commonly used by Unity developers, and ignoring associated files in the Project's Assets folder is worth doing.


@pranavmathur I wasn't planning on taking very much of your code anyway. This was going to be quite separate.


How you set up circle-ci deployment to gh-pages ?


No need to declare `c` here.   Just say `var c` on line 114.


Suggestion:

This stands in contrast to the sampling methods used in current software such as MrBayes, which do not propose SPR moves uniformly.


how do you set up circle-ci deployment to gh-pages ?


Además, ahora estoy viendo que has dejado partes de nuestro texto en negro, así que ahorae es súper confuso. Por favor, déjalo como estaba.


this is a brilliant line of code


Actually, required devices were never executed for non-topology operations. op->devices is always NULL for non-topology operations. So it appears to be a non-issue.

Whether that is the ideal behavior is open to question, but I guess the reasoning is that without topology, the originating stonithd doesn't select the device(s) used.


Pero poner americano si estamos usando "behaviour" y demás queda feo T_T
Precisamente me pasé mil de tiempo dándole coherencia al británico :( ¿la Elsevier es americana? si es que sí, pues nada...


I've now updated the docs on the new "custom-play" branch. I'm still waiting for ReadTheDocs to pull the latest code (unless it won't due to this new branch?) so for now here's the relevant commit:

https://github.com/hashbangcode/vlad-docs/commit/d53ece58b5f2cde702f11490210e4750d0e8704a?short_path=0fe7724#diff-0fe7724d88850537ee5bf17152ca0c75


Since the methods that convert full tweets to CSV are typically going to reduce the file size by a couple of orders of magnitude, I'm not convinced that gzipping their output is a big priority. So I'd be inclined to set the default value of `gzip_compress` to `False` in those cases.


is conflicting_cb_names used anywhere?


good


Somehow indentation went screwy.


newly discovered, but these are not mutually exclusive categories because the fact that the scanner has picked up a beacon once doesn't mean it won't pick it up again.


Yikes...I'll take a look.


Sorry, I didn't mean to alter the text. I meant: maybe not show this whole piece of text at all unless `webrtcDetectedBrowser == 'chrome'` in the code :)


IMO the Immutable interface is useless.
If a class does not have mutators its immutable.
But if you extend a class that calls itself immutable and add some mutator its no longer immutable. If need this for parameters please consider this and it also note that it would be harder to use.
The valid way would be copying the the volume to be sure.


This line is imo "better" C++ if you write it like this:
const  SortAttribute sortAttributes (SortAttributeIgnoreFolders | SortAttributeIgnoreArticle);


Work on this some other time because after finally getting it to build on Windows now `grunt test` is giving me guff about mocha


Strange, I'm not seeing that in my IDE, loading up in VIM see what the whitespace turned out to be. Very weird.


updated styles


note for posterity: this should be numbered PDB-1730


Rename this to be more accurate "RelevantDeployments" or "RecentDeployments".  Don't use "Get" in method names - it's a lazy verb and usually is a placeholder for something more accurate, and when it isn't it's unnecessary.  Same for builds.


This was first commit


Don't we want to make sure that there are no spurious artefacts even when we aren't doing a clean?

That is, we're always fine with ignored files (hence the --exclude-standard option to git ls-files) left around after the build, but I think we want to fail if there are modifications to tracked files or new non-ignored files after the build, even if we didn't start with a clean build.

In fact, rather than removing this check here, I think we might want to add it up where we otherwise do the clean at the beginning, since it is no longer guaranteed when we don't clean. Or does that not work for your use case?


I'd like to benchmark this code too, like I benchmarked `_shapeArabic()`, but what kind of strings you are expecting in the common case?

For example, if the common case will be to process strings without any digits, then an initial check for `/[0-9\u0660-\u0669]/` would be useful to avoid a lot of unnecessary work.

On the other hand, in the common case if most of the characters are digits, then the above code is probably written more efficiently as

```js
return text.replace(/./, function(c){
   // same sort of code as above, but return the new character (or the original character)
});
```


:sparkles:


De eso no ha dicho nada el comprobador. Se ve que es aceptable. Analyse,
todo eso, no le ha gustado.

El 8 de julio de 2015, 18:40, Paloma de las Cuevas Delgado <
notifications@github.com> escribió:

> Pero poner americano si estamos usando "behaviour" y demás queda feo T_T
> Precisamente me pasé mil de tiempo dándole coherencia al británico :( ¿la
> Elsevier es americana? si es que sí, pues nada...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geneura-papers/2014-2015-COMCOM-MUSES_vs_SotA_BYOD_Systems/commit/32e6fbd6ff942a5430def0dd0d86d96d8bfdcace#commitcomment-12066306>
> .
>

--
JJ


Vamos a dejarlo así, porque deshacerlo es más trabajo que dejarlo. Son
temas de detalle que no creo que den ningún problema.

El 8 de julio de 2015, 18:45, JJ Merelo <jjmerelo@gmail.com> escribió:

> De eso no ha dicho nada el comprobador. Se ve que es aceptable. Analyse,
> todo eso, no le ha gustado.
>
> El 8 de julio de 2015, 18:40, Paloma de las Cuevas Delgado <
> notifications@github.com> escribió:
>
>> Pero poner americano si estamos usando "behaviour" y demás queda feo T_T
>> Precisamente me pasé mil de tiempo dándole coherencia al británico :( ¿la
>> Elsevier es americana? si es que sí, pues nada...
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/geneura-papers/2014-2015-COMCOM-MUSES_vs_SotA_BYOD_Systems/commit/32e6fbd6ff942a5430def0dd0d86d96d8bfdcace#commitcomment-12066306>
>> .
>>
>
>
>
> --
> JJ
>

--
JJ


Perfect, thanks!


OK


Oh I'm stupid - I was looking at the commit diff instead of the entire pull.


Shall we use unordered_map instead of map


Leaving the `println` intentional?


Ditto.


Primer comentario del proyecto


@lokeshrathor

Using @lokesh is sending me an email notification. :-P


@SvenRtbg We messed up. However, we've had *several* `1.1.*` releases at this point, and the 1.1 versions are explicitly referenced by several modules for use in the Apigility 1.1 release. At this point, we must cut our losses and move on, as removing the existing tags will break code for anybody now on 1.1.

At this point, I've detailed how you can update your code if you are affected by this problem. In the future, we'll be more careful about tagging BC-breaking changes as new major versions.


That's weird, I'm not seeing anything close to this...still looking.


I can ignore via Github. Just noting. No big deal.


あれ？overviewってuser毎の処理だっけ？id指定してそのユーザのoverviewを取得する感じ？


グループ全員のを取得するイメージだった。
今実装してくれてるのををグループ全員にやって配列で返す感じ


Ok


I'd be inclined to revert this line and the next. The point of this method is to provide a simple intro to Twitter processing for beginners, so I'm not convinced that we need the `retries` and `location` parameters.


jeszcze trzeba cos dodac do tej notatki


I realize they didn't before, but shouldn't all these reference parameters have a space before and after the ampersand?  See "Spacing" section on http://mooseframework.org/wiki/CodeStandards.


What is driving the 33 limit? Can it be more than 33?


se debería especificar versión


Looks like I should have kept input#id - I removed it not so long ago because if there are more than one AutocompleteInput per page they might be conflicting, we would need to address this at some point


Appreciate that. I think it still works though because it's just calling
library scan with one argument. But still needs to be fixed.

The whole code base is a mess though. It's all still based on code I wrote
when I was learning to program... you think it's worth doing a rewrite?
On Jul 8, 2015 9:27 AM, "Bas Stottelaar" <notifications@github.com> wrote:

> No problem. I don't have time to code, but I don't mind reviewing from
> time to time :-)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rembo10/headphones/commit/65019d8323e85dd0ecb94a669f2d5fc252eea2c8#commitcomment-12066058>
> .
>


This business with comparing on the prefix was meant to accomplish *something* (maybe just making the `Equal` instance behave differently than `==`?) Is that no longer needed?

If this correction stands, then the comment a few lines above should be corrected/deleted.


> Why not ```open(filename).readlines()```? Or just ```list(open(filename))```.

To ensure that the returned list doesn't contain newlines, so they match the items passed to `append_line()`:
```python
>>> items = ['one', 'two', 'five']
>>> for i in items: append_line(filename, i)
...
>>> items == list(open(filename))
False
>>> items == open(filename).readlines()
False
>>> items == open(filename).read().split('\n')
False
>>> items == open(filename).read().splitlines()
True
>>> items == [line.rstrip('\n') for line in open(filename)]
True
```
That last one is a bit clearer about the intent; I'll change that, and add a comment (+ test case).


Can someone easily make a very basic "web" unit test to transfer 1 BTS from "nathan" to maybe 1.2.0 (committee-account)?   I'm hitting road-blocks trying to test from "dl" .. I think we might as well just test using components in the "web" .. I'll use that as a template to make my tests in web...


sdfsfdsf


@jimbobhickville updated, ready now.


If we plug in a camera, the loop rate will be the camera's own fps value,
and this value may change depending of the camera being used. It should
work anyway, but we can use the kinect's frame rate instead (30 fps).
Both 25 and 30 fps are considered "standards" in the TV and cinema
businesses, but there isn't a single universal frame rate value, as far as
I know.

On Wednesday, July 8, 2015, Matheus Vieira Portela <notifications@github.com>
wrote:

> That's alright but is 25 a universal frame rate? For instance, if we plug
> in a camera, will it still work?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/unball/ieee-very-small/commit/83b1641a9b12a1b2b0d9a242fc12c79443657bd3#commitcomment-12052737>
> .
>


why are you doing it this way? This should just be

```
Subscriber.find(params[:id]).update_attributes(
  name: params[:name]
)
```
or whatever


Единственное мы говорили что количество должно суммироваться. В услугах из залогах.


@ewan-klein

1. `retries_after_twython_exception`: indeed I did not test that one, it is a bit difficult to reproduce (unless you wait for quite a long time, usually one night is enough, or you modify `twython` behavior). Just by looking at the code I see I did break it. Let me fix it and test it (I'll touch `twython` in my machine to force errors)

2. `repeat` is now in `_search_tweets`.  It is a bit difficult to see, the change log is quite big. I had to change it to be able to reuse `search_tweets` (which returns the generator) in `_search_tweets` (which is used internally when the json file is generated the old way). However, I've been reviewing my list of tests and I did not test than one either. I'm sorry, I'll test it again now

3. Ok for the `gzip_compress` to `False` in `json2csv` functions. I'll change it and test it


the main point being that `update_column` will skip validation, which isn't ideal.


So the usual problem with this sort of thing is that you generate trees with a *depth* determined by `size`, and the size parameter defaults to 100, and things blow up. Obviously what you want is a way of generating things with the *number of nodes* determined by `size`. I'm not following this well enough to know whether you've cleverly achieved that.


What's this `--boot-directory` option? It's not documented anywhere in grub-install.


97643186-ABUPS-total-row-not-match-water (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (652 of 652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.34%25-green.svg)


This really isn't a big change, I just increased the version and built crossroads.js. I wanted to push this, because I needed Simon's change that allows multiple query paramaters with the same name


I think we can't make it "easily", jest's approach is to test components in isolation


Leave out the else here if you're just going to pass.


Is this issue been fixed? I'm thinking of reverting everything down to the first decent grub install.


This will fail the PEP8 check since you're not using logger anywhere.  I recommend removing it.


Ideas welcome.


Typo. ;)


Does it fix that issue ?
https://github.com/RestKit/RestKit/issues/2242
If so, we should consider to make a pull request with this commit.


See `DataGen` in codec.scala.


Perhaps we coul loosen it up to `~>3.3`? Dunno, RSpec seems kinda stable for semver to me.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17652/testReport/) for this commit**


Okay.


Не надо так считать сумму. В идеале она вообще не должна хранится. Должно быть одно место ее подсчета. Считать итого по всему заказу нужно в getter суммы, да и вообще судя по названию это не та сумма.


yea it should totally be update_attribute.

The problem... I was encountering was that `Subscriber.find(id).update_attributes(...)` returns true. Meaning that grape returns `true` as it's response instead of the subscriber object hence the `tap`. I'll change it to update_attribute.


Add a default case for error handling. Throw an error or something, saves you debugging time :)


This `Destructible` seems to be a recreation of `is_destructible`, except that `is_destructible` is `false` for arrays of unknown bound as for other incomplete types. If I want `is_destructible`, why wouldn't I just use it directly?


Docker will cache intermediate images and generate an image for each step. Doing it this way allows rebuilds where there have been code but no dependency changes to skip reevaluating the `pip install` step, avoiding downloading and unpacking all the dependencies.


It was designed wrong?


@hellroy Yes, but no. I explain more here: http://craigfreeman.net/blog/2015/07/karten-1-1-1/


But it is working. I'll leave the comment in there though.


Stylistically though do you think I ought to just set it to a variable and then return it? `tap` sometimes can confuse more than it cleans things up.


merge


RadianceRefactor (rpg777) - i386-Windows-7-VisualStudio-12: OK (2173 of 2202 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.68%25-yellow.svg)


Andrei's update


Ok, I see your point. We could leave this method as "extra-simple". Then use the `retries` parameter for the `search_tweets` method, which returns the generator and thus is for more advanced users. The `locations` param would be removed completely. Do you agree?


Учителей с такими идентификаторами может не существоват


Duhas


Я бы советовал исполняемый код из объявления класса


Эти файлы не должны быть в репозитории. Можете их удалить ?


Yeah, just do something like

```
sub = Subscriber.find(params[:id])
sub.update_attributes(name: params[:name])
sub
```


That makes sense. And so long as the scanner keeps scanning after the call to requestCachedPwos, the cached pwos could eventaully get to the caller. I guess that happening is heavily based on hardware and low-level scanning software (e.g. when a scan happens, how many scan results does one receive for a given unique pwo across a given number of seconds).


no, these are unit tests, their purpose to test one unit of the view layer - component, isolating them from environment makes it easier to write tests and run them faster


Судя по наванию переменной, не совсем понятно, что она содержит только количество


@dietzc with this `in.duplicateTypeOnSameNativeImg()` I get a NullpointerException when trying to access the value. It seems that the underlying data access is null?

What I'm trying to do: Copy the type (including its index and underlying img) to basically use it as an offset for the neighborhood iterator. (So all movements are relative to the current pixel in the input image).

I also have the feeling that this doesn't actually copy the underlying index either.

`copy()` threw an `ArrayOutOfBoundsException`. But if that at least copies the reference to the underlying data, I could set the index correctly after.

Any hints?


I looked at the file via the web browser, and I checked it out from GitHub and it looks fine on my end, I'm not sure why your seeing what you are.


Заполнять стринги вроде как уже не надо, если поле реализован интерфейс IPropertyChanged биндинг работает, надо проверить что это так, и удалить везде где использовалось.


I personally tend to steer away from judicious use of tap. It's more subtle then just assigning the thing to a variable and therefor easier to miss when code cruising.


Sure thing, PR created.

-Cliff

On Wed, Jul 8, 2015 at 12:29 PM, Keith Horwood <notifications@github.com>
wrote:

> Do you wanna submit this as a PR to the main project? Nice catch.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laucliff/NtSeq/commit/a9e889da86235ed037f385016d209bd9bb8887df#commitcomment-12066100>
> .
>


Ici c'est la logique en jquery pour envoyer un champ. Il faudra ajouter les autres au array {qte:..., autrechamp:...}


just FYI we could also do `json_cache[cache_key] ||= job.publishable.serialize_for_portal(self_url).to_json`


So, obviously actually having some sort of test in here is a good thing, but what exactly is this testing? We implement `traverseImpl`, but also `map`, `foldMap`, and `foldRight` (for performance reasons, I think). Any idea if they're all getting tested? I see new coverage in `foldRight`, so that's a good sign I guess.


OK... so... just realized PR = Pull Request (and not PR)
Hey - I was promoted to CEO from CMO - I'm responsible for the _Big Picture_

My focus is on stuff like mergers with patent trolls (ANYONE who wants to exit - watch out!  pay us, or never exit again!)

Sooo... If someone could pull my request - I can't figure it out - From what I can tell I'm too forked up.


Utulise les ' au lieu des " le plus possible. Ça simplifie la vie avec le HTML


Yea me too for the most part. Thinking that mcnelson rubbed off on me :trollface:


Fiksa i følgende commit: https://github.com/armandg/ligabot/blob/5c8d56a31ffe7b3265d6a1f8ad0d9a4d51e134dd/ligabot-runde.py


Aussi, j'ai ajouté la classe "savable" pour que le jquery bind l'event change dessus pour l'envoyer en ajax.


C'est bien de faire ça


You did not try to merge changes for mtk OMX (libhardware and libstagefright libs) from alps kk source code?


C'est juste pour te montrer comment aller chercher les champs en POST avec PHP.


La prochaine étape, mettre tes affaires de database dans un fichier db.php et dans un objet, que tu pourra instancier dans index.php et dans save.php


fuck u https://en.wikipedia.org/wiki/John_W._Nystrom


I fixed the .net 4.0 build.


+ Fixed bugs in issue query
+ Support custom tracker when create project


Yeah, I really wasn’t sure what that was testing. I created arbSymbol which uses arbString, and it was generating strings that didn’t work with that definition (because they were shorter than 3 chars). Just seemed simpler to get rid of `substring` than to handle the lengths properly.

I’m happy to restore the previous definition, adding a comment as to why it’s done that way (and “different from ==” seems reasonable enough).


`Constructible` looks like `Constructible` from the TS, with maybe a workaround for DR1467 in that second `requires_` overload? Is the deleted overload necessary to avoid a hard error when instantiating the third overload with `int[]`/`int&`? I.e., does `T()` not properly fail substitution when `T` is `int[]`/`int&`?


This will work fine if we have one worker.

There might be a race condition if we have more than worker iiterating through `PortalPublicationJob.all.each` and deleting one row at a time. The results from the query I don't think the `all.each` iterator will evict rows deleted by another process.


Out of curiousity, why don't we just use something like ListenServer.Clients to get all of the clients? This way, we are not making the interface responsible for the back-end's responsibilities. :)


Я против, должен быть одно перечисление с НДС в программе. В номенклатуре уже есть одно. Но это формлено правильно в отличии от предыдущего. Иначе будет путаница и невозможность сопоставить. Тебе вообще повезло, и это сработало так как разное пространства имен.


This is a stable build, just without the teacher name list or logic on index that will insert the alternate emails into the database.


fucking skid.


check out this repo.
https://github.com/neo/middleman-gh-pages


Yes, the menu_ticker_line function need to be adapted for non fixed width fonts.


Now we need to get those aspects of the program to work without throwing errors


Suck a dick.


Whut? Google translate is the perfect translator. Always picks the appropriate word for any occasion :-b


Actually this is now a dupe of commit cd0d5c1f06a69c115e674f87254cc7e056c9891a from bmr-tupperware; I've rebased and merged all those changes now so this is redundant. Thanks for submitting anyway!


you should log something


Typo: sendling -> sending


It would be also nice to change the return type of the _DbgBreakCheckNoThrow and _DbgBreakCheck to bool.


you -> your


I think this should be xwiki.getWebAppPath()


I am using PatientProfileResource.update() --> getUpdatableProperties(). If there are a list of relationships to be updated, in which few of them are to be deleted -- "voided"=true would be helpful.


Didn't you mean PN_OUT_OF_MEMORY here and below (since you went to the bother of defining it!)


inttostr is the class that method that almost does all the job. It's called in IntToString where the main is as well as exceptions handling and the javadoc


On the issue of defaults and detecting if a config value has been previously set in the current code base I believe there are several issues:

First of all, for the set of boolean flags  the secure, dump_session and dump_saml_response all use 0 as their default values (I copied that idiom).

The legal set of values from the config parser is 0 or 1 for a boolean and a new config structure is initialized with default_xxx which is either 0 or -1 If the default is 0 you can't distinguish between unset, default, or the user set to false. It seems to me the logic only works if the default is TRUE (e.g. -1).

auth_mellon.h defines two relevant macros CFG_VALUE and CFG_MERGE which utilize two constants instead of just one, a default_xxx and inherit_xxx. It seems to me keeping value indicating "inherit" independent from the "default" value is the only way to unambiguously implement the desired behavior (with initializing the config struct with the inherit_xxx value).

Currently there are only two config items which use the CFG_VALUE and CFG_MERGE logic, subject_confirmation_data_address_check and post_reply, both happen to be boolean flags).

Shouldn't all (especially newly added) config items use the CFG_VALUE and CFG_MERGE logic?

Why are the subject_confirmation_data_address_check and post_reply constants defined in a different location (auth_mellon.h) than the other config constants which are defined in auth_mellon_config.c?

I will fix the ecp_send_idplist config item, but shouldn't I follow the CFG_VALUE and CFG_MERGE idioms?


In this case `<<` is fine, but can we change this to `+=` instead. There's a danger when using `<<` that it modifies the global permitted_attributes in place.


Added in: https://github.com/campusdomar/PuMuKIT2/commit/48b73afb96197897f4e9aa64a6c01aaff006ca85


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 118](https://teamcity.labkey.org/viewLog.html?buildId=259807&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4 (2 new), passed: 21 Build time: 00:31:24
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorAxisSelector: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySavedGroupPlot: <no details avaliable>

```


IMO should throw a RuntimeException instead


Если в доменной модели правильно прописано описание класса и указан род, тут заполнять названия вкладки не надо, она заполнится автоматически по объекту доменной модели.


It's documented for grub2 and I fixed it by using root directory on grub1.
There was a bug in the install code for partitions which don't support
symlinks but that should be fixed now.

On Wed, Jul 8, 2015, 10:01 lethalman <notifications@github.com> wrote:

> Is this issue been fixed? I'm thinking of reverting everything down to the
> first decent grub install.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/fd5b273e82cf7e78a94479730cf1f51d3a19c637#commitcomment-12066739>
> .
>


Here's the test (along with the two that follow) that cared about the substring business. I think I was just trying to get different behavior than `==`, maybe for my own understanding.


Although documented in the README.md as rewritePath, the code is actually using pathRewrite.


Thanks for the explanation! Nice.


Hopefully there is good test coverage on this behavior (presumably there is, given that we caught this change..). For now, though, it's clearly part of the public API that `ActiveModel::Model` exposes, so we wouldn't expect any breaking changes without a major version bump (in which case, anything is possible..)


This depends on the scenario in which you use property mapping.
The call
```objc
[mapping addPropertyMapping:titleMapping]
```
as I see does not involve copying titleMapping. So my commit probably will not fix your issue.
Try to put a breakpoint on RKPropertyMapping copy method to see what happens


I am a bit worried about the implications of this change since this code is shared with desktop and some third party testing apps may rely on the formatting of the debug output.


I am a bit worried about the implications of this change since this code is shared with desktop and some third party testing apps may rely on the formatting of the dialog title.


Fair enough, how about if I change it to:

/* RFE: should have a mechanism to obtain this value */


you only to catch EvalException here, I believe.


This particular check would previously fail with this PR not implemented.


`Yes` and `No` strings should be localized.


I am so sorry about the situation


As a hack, you may be able to throw a new exception that has no stack trace...


solid.


I wonder why restoring the default handler and restarting the int 3 instruction would not have the same effect. But the change is ok to me.


Although the ```(void)``` will silence the ignoring return value warning (if you are getting one), we don't do this elsewhere in the source and it looks somewhat messy IMO,  for no huge gain.


##  subproject on fork commit


eat my butt hole


@alandekok good points, i will do that!


I was not sure what the "arm.neon" was here (assuming it is the one from APKMirror : http://www.apkmirror.com/apk/google-inc/google-text-to-speech-engine/google-text-speech-engine-3-5-5-2050975-arm-neon-android-apk-download/)


There really isn't anything to be done.  We are the handler and there is no one else to notify.  So suggest removing the Fixme and simply note that we return and stop processing.


I think we should mention the image name and a optional tag.


Not needed


This should instead use the `$yellow` variable from [lms/static/sass/base/_variables.scss](https://github.com/open-craft/edx-platform/blob/master/lms/static/sass/base/_variables.scss#L137)


Just created a Repository..


I think we're clashing with appc_discovery_local_dir default value here. We should move this early (+ /docker perhaps) so we don't run into problems.


новый игрок создается без аргументов, вроде же это некорректно, поскольку игрок коннектится с логином и паролем их и надо передавать в конструктор.


Please move from UA sniffing to feature detection.


I followed this API documentation when I created a fix for this in a different branch (prior to Naomi's fix):
  - http://api.rubyonrails.org/classes/ActiveModel/Callbacks.html

I did follow that advice to include the `extend ActiveModel::Callbacks` in the class.  So now we will have to address this include or not-to-include issue when it is merged.


aca en realidad deberias hacer
foreach ($data['Persona'] as $persona ){

porque el array lo tenes dentro de la clave Persona de la variable $data que tambien es un array con 1 solo item (el array Persona)

por eso es que te traia solo 1.

Si el $data lo armabas asi, te traeria 2 items

$data['Persona'] = array( ..... )
$data['Legajo] = array( ..... )


I think we should comment here that the only supported uri is a local file uri.
And add TODO for supporting URI fetching from external.


minor: I couldn't find any use of the "defines" field. I guess you changed it to use the cflags to do what you want (define _GNU_SOURCE).


This is completed


`boot2docker ssh sudo /etc/init.d/docker restart` also fixes this.


look good


As above (and below)


running media queries


This applies to all cases where you are updating properties.  All the Radio properties are intended to be KVO compliant.  This means that when not using a synthesized setter, we must call willChangeValueForKey and didChangeValue for Key either side of the change to the property.

Moreover, these calls need to be issues on the default run queue as normally a KVO user is going to be updating the UI based on the changes in the model.

So - this is the reason for updateAndNotify (the macro).  Change this to:

NSString *antListRef = [[stringVal componentsSeparatedByString@"," mutableCopy]];
updateAndNotify(@"antList", _antList, antListRef);

Also, while we are at it, these arrays probably don't need to be Mutable as the user can't change them.


rax retry tests


Ever, that is, not every :laughing:


See my note below about updating properties.


source code style:
use ```} else {``` (on single line)
[A number of other places in this change too]


Question: is any of our tests using "defines"? I couldn't find any.


![carbon-relay-rep-fixed](https://cloud.githubusercontent.com/assets/4226049/8577356/2acc950a-2576-11e5-9c42-a5a1b59b1a9f.png)

carbon-relay use to not behave like this... weird.


Maybe you can change the method name to "getClassifiedFiles"


ARM neon = arm version 7a, you can safely assume that all devices running kitkat support v7a and have neon support. Within all the scripts I also treat all 'arm' APKs equal and assume that devices always have this arm v7a support.


Update comments


end with period


xD


This commit is a mess, **please do not use it.** For some reason very few of my changes were actually committed, leaving this script a godawful crater of errors.


And also what does restore do? you should probably leave a few sentences here too.


Let's move this to be /tmp/mesos/store/docker so we don't clash!


Are you sure this addresses issue #3103? Although I haven't tested it yet, it looks like this addresses another issue I opened, which would be #3286.


A simple timeout is sufficient here.


ContainerUtil.getFirstItem
+
You wanted to try an approach with @TestOnly method


Is
    trigger_error('Error: Could not connect to database ' . $database);
    exit();
better than
    exit('Error: Could not connect to database ' . $database);


Oh no!

What are you trying to do?


Maybe we can use the method removeAll of the File class


lol :hankey:


return the error value received?
``` C
int r = pn_data_put_list(data);
if (r!=0) return r
```
No need for ```else``` at all here.


When I translate it back it says something like: "Clicking the button below makes the 'Torrent stop carbon brushes " manage only launched the torrents via DuckieTV."


Ok let's give all this a try to make a proper decision


Use the symbols [] for initializa the array


Use the symbols [] for initializa the arrays


Notwithstanding the 'else' code style comment. There should just be an early return here with no else.


@saurabhsjoshi: I've just finished what @karthikb351 was supposed to do and I have also cleaned up some of the code and fixed the build. Check it out now. There are a few things left, all referenced by TODOs.


improve comment


:laughing:


whoops.


Maybe you can call this method into another method like be "copyFilesChanged"


> This could use a generator expression instead of constructing the temporary list.

Hmm. Also, this would cause an exception: `extract_drivers(repos=repolist, drivers=driver_generator)`

I think I'll refactor the repo extraction to a different function:
```python
def extract_repos(repos, outdir, pkglist):
    extract_drivers((d for repo in repos for d in dd_list(repo)), outdir, pkglist)
```


FYI this works on any Samsung kernel no matter the charger chip, no need to restrict it to MAX77843.


Here it could be just one line, no? Using ```headers-$(HAVE_PIN_MUX)```, I mean.


라이즈 콤보 타겟팅이 좀 멀리보네요. 이전버전은 사거리 체크하는게 있었는데 이번버전에서 없어져서
그냥 콤보모드로 사용하는데, 아주 애매하게 서폿이 완전근거리 원딜이 560정도의 거리였나 그랬는데,
아무것도 않하고 무빙만 비비고 있네요. (오브워크 어택을 껏을시..)


how about just:
``` C
r = pn_data_enter(...);
if (r!=0) return r;
r = pn_data_put....
if (r!=0) return r;
...
```
As a pattern for this style of code - I think it reads a lot more easily. However note that the existing code doesn't back out its changes on error as it doesn't check, and the new code copies that - it probably doesn't matter.


Maybe? `./module` can be relative to the module's path


Hmm, this username==password here is sub-optiomal, because we print the same "first time" message to user which doesn't help him (The text `The username and password MUST NOT be the same.` is hidden in the middle)... But this should be solved elsewhere.

Tested ACK otherwise. More lines removed than changed :-)


In this function there are repeated code


Agreed.


fast-forwarding 2.1 to borshop-integration-1150-forward-merge/zl/2.0-into-2.1 = 081ecaa1


Yes, when I resized the console.


Improve this function


I have been using APCu in production (without this fix) and have no issue with sfAPCCache.

I believe APCu 4.0.7 [has fixed this](https://pecl.php.net/package-changelog.php?package=APCu&release=4.0.7) and with it, the API is the same as APC.

Unless I'm missing something, this fix only makes it compatible with older versions of APCu, and sfAPCCache is now incompatible with the latest one.


implicit casts considered harmful?


As above return the actual error code.


This is the list of all connected Clients, there can be clients which are not authenticated yet (means not shown in the listview).


Why do you need to do this? It's a shallow copy as well, btw


I also noticed that the code seems to work correctly without any of the do-while loop, lines 789-804.  Is that what you meant?  Or is there a benefit to removing only the /zone/g regex code?


The behavior actually running it on Linux (not sure about the other platforms yet) was to restart after the int 3 and continue execution.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Wednesday, July 8, 2015 10:28 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Fix recursive asserts in coreclr. (b9755fd)

I wonder why restoring the default handler and restarting the int 3 instruction would not have the same effect. But the change is ok to me.

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/b9755fd81cb477087934a685b0820495e68b7c2f#commitcomment-12067178>.


genius


I would just do `if (node.modifiers && node.parent.kind === SyntaxKind.ObjectLiteralExpression)`


i would delete this function and add `operator=`.


any particular reason to mix ADD and COPY here or could COPY have been used everywhere?


Instead of MethodInObjectLiteralExpression, consider ending with ObjectLiteralMethod


Looks like it is fixed as of ember-data 1.0.0-beta9 by adding uniqById check in line 1416.
Removed some nasty override from our app.


`col-xs-6` -> `col-sm-6` のtypo?

xsで表示しない意図なら`hidden-xs`を追加するのもありです


Ex __a__ mple in English :p


The goal was to implement `Constructible` from the TS. Yes, the hackery is to work around language bugs and compiler bugs.


这次commit有冲突没有手动解决就交上来了


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 119](https://teamcity.labkey.org/viewLog.html?buildId=259815&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 1 Build time: 00:03:07
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.initializationError: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


I think this will still have problems with multiple portals.  when the first PortalPublicationJob is processed it will call republish_for_portal.  Which will update `publishable.publication_hash`.  So now on the second PortalPublicationJob the computed hash and the publication_hash will match, even though this portal hasn't been published too yet.  Currently the only place the correct publication_hash is stored is in the PortalPublication objects.


I really hope not.  We can assume that this doesn’t happen for Linux, etc.  I did consider that the DDRs and our tests on Windows may do this so I’ll run the DDRs on it.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Wednesday, July 8, 2015 10:25 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Fix recursive asserts in coreclr. (b9755fd)

I am a bit worried about the implications of this change since this code is shared with desktop and some third party testing apps may rely on the formatting of the debug output.

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/b9755fd81cb477087934a685b0820495e68b7c2f#commitcomment-12067134>.


I don't really remember, sorry. I think I wrote this when the concepts were still in flux.


I think you're safe to remove that as well, and that'll fix a bug I just filed on the main repo. The issue was that it I wanted it to go past the "facs zone='id'" bit, and that's irrelevant now - perfect example of how I wanted this generified and can't follow my own instructions.


This is great; can you assign the copyright to either aw2.0 Ltd; or put your own copyright at the top of the file and you are assigning this to the OpenBD project and releasing this under GPL


Hm, is this right? asserting x == x - 1? do you mean to get the size again?
I am not 100% sure about exposing `ssc.env.metricsSystem.sources` just for this test but I suppose it's still private to spark.


Improve method name


嗯嗯嗯，@wangqr 说的对↖(￣▽￣")
建议补充补充冲突方面的知识


It should be canola !


This adds initial support for #1388.


Misspelling here with "diaplsyName"


KeyError when there are no attached items at all


this runs mocha locally as the global cmd line functionality requires an ```npm install -g``` and probably authentication


same here


97643186-ABUPS-total-row-not-match-water (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


This would be even harder to do if the title actually ends up on a GUI dialog box. The windows coreclr build it is still text based so there is a chance that there is some screen scraping going on.

All of the formatting changes I made make (I think) a  lot more readable and more professional.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Wednesday, July 8, 2015 10:25 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Fix recursive asserts in coreclr. (b9755fd)

I am a bit worried about the implications of this change since this code is shared with desktop and some third party testing apps may rely on the formatting of the dialog title.

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/b9755fd81cb477087934a685b0820495e68b7c2f#commitcomment-12067135>.


`audit --strict --online` sounds reasonable to me. We can use the `--online` flag with other audit checks to come as well, such as checking URLs for SSL/TLS potential, etc.


It was just an attempt at solving it, but I suspect the problem is in the regex library.  I didn't reproduce the problem or test it.  At a minimum, this is the better way of building the regex string.


I think that "getClassifiedFiles" isn't a good name, because this method isn't returning nothing.


yep...
it accepts both formats...
could be headers-core-$(HAVE_PIN_MUX) := ....


You could structure these portions of code so that all 4 of these variables can be final. That way it clears up where they are declared.


or even:
headers-$(HAVE_PIN_MUX) += .....


Done.

From: Jan Vorlicek [mailto:notifications@github.com]
Sent: Wednesday, July 8, 2015 10:21 AM
To: mikem8361/coreclr
Cc: Mike McLaughlin
Subject: Re: [coreclr] Fix recursive asserts in coreclr. (b9755fd)

It would be also nice to change the return type of the _DbgBreakCheckNoThrow and _DbgBreakCheck to bool.

—
Reply to this email directly or view it on GitHub<https://github.com/mikem8361/coreclr/commit/b9755fd81cb477087934a685b0820495e68b7c2f#commitcomment-12067058>.


When will there be a build with this fix in it?


`~Attachment,is_deleted` would be prettier


I was not able to process the output of "tar --help" in recovery (passing it through grep always gave me an empty string). Also in BusyBox's tar the switches are not listed with the leading dash, and searching for "J" would be error prone.


This should be fixed by https://github.com/zaach/jison/pull/290


I think that is method (createDeploymentDirectory) shouldn't be on copyFilesChanges function to uncouple


Can this code be reached by an unauthenticated user? In this case `getUser().user` would fail


Random whitespace change here. Was it because of formatting?


You'll also want to add `.options(joinedload(Attachment.legacy_mapping))` here so accessing `attachment.legacy_mapping` doesn't trigger one query per attachment


I'm not sure if you meant to include this block or not, but it shouldn't be committed if the code was supposed to be left out.


Go Pundit!


Do we even need to include the folder id here? Should the attachment get a different uniqueid when moving it to a different folder?

Also, when uploading a new file the id remains the same atm... if you want to avoid that, add its `file_id`


Wait a minute.....that json is totally wrong. There's the problem. The devDependencies should not be under the jspm key. How did that happen?


Contrived examples are fine as long as they are reachable. As far as testing goes, users will always find random edge cases.


Will push today :)


I'd like to see a `UnanimusUser extends ParseUser` class


Nice!


`getRecursiveManagerList()` never returns groups?


Ça, ça irais pas là normalement. Faudrait les envoyer en dependency injection, mais ça prendrait le front controller avant donc on va faire avec ça pour l'instant.


ACK.


Also, we should probably add a file name and we'll need an association between artifacts and sessions.


#20814

this changes how arrays are encoded in form fields


Pour avoir les exception. Perso j'aime mieux PDO pour ça, mais la bonne nouvelle c'est que maintenant on peut plus facilement switcher mysqli/PDO sans changer tout le reste du code étant donné que notre classe Database est un genre de patron proxy.


@tmat The last few PR builds show the Windows CI build completing with the same time as other Windows CI builds.


Thanks! This helps a lot.


I'll test this.
The warnings with clang on a 32bit AVX2 build, like
```
hmacSHA512_fmt_plug.c:249:33: warning: multiple unsequenced modifications to 'keyp' [-Wunsequenced]
        while(((temp = JOHNSWAP64(*keyp++)) & 0xff00000000000000)) {
                                       ^~
./johnswap.h:35:34: note: expanded from macro 'JOHNSWAP64'
#       define JOHNSWAP64(x)    bswap_64((x))
                                          ^
/usr/include/byteswap.h:37:33: note: expanded from macro 'bswap_64'
#define bswap_64(x) __bswap_64 (x)
                                ^
/usr/include/bits/byteswap.h:128:37: note: expanded from macro '__bswap_64'
           __r.__ll = __bswap_constant_64 (x);                                \
                                           ^
/usr/include/bits/byteswap.h:98:25: note: expanded from macro '__bswap_constant_64'
     (__extension__ ((((x) & 0xff00000000000000ull) >> 56)                    \
                        ^
```
disappeared.
Unfortunately, this didn't help fixing issue https://github.com/magnumripper/JohnTheRipper/issues/1273.

May be the "multiple unsequenced modifications" warning is only a problem for 32bit builds, not for 64bit builds?

We also ned to check whether your change does have a performance impact on (64bit) Linux systems.


"real_query". Don't ask.


Oh, I see.
I would make GetAllClients() load values into a List of Clients from ListenServer.Clients, then add filtered Clients into a new List that is returned at the end of the method. While it may seem a bit degrading to performance, using the Tag property of the interface's item is not the best idea with regard to dependability. Also, there is a large amount of casting and null-checking already in this current way.


Using the message.owner as the user id allows for the file owner/deleter to remove other user's messages. But in this case it is allowed, as the message is just a link to the uploaded file.


@karthikvijay Fix those merge conflicts !!


The option rotate_x_labels is called x_label_rotation in the default options (same for y) - one of these should probably be changed so they are the same?


Which bit are you referring to?


La différence c'est que real_query va exécuter directement la query plutôt que d'essayer de juste aller chercher des données. Une autre raison pourquoi je préfère utiliser des libraries comme Doctrine2 à la place des libraries natives.


Later we can change the property in UserState so that, when the variable that tells the server is changed to true or false, to add or remove it from the server's List of VerifiedClients, or a name similar.


Tous les credentials sont dans la classe Database.


I've changed it locally, if no objections I'll apply without sending another pull request for that...


Fix broken test


Comme on peut voir, ça simplifie beaucoup les chose quand on veut avoir la database à plusieurs endroits.


One final nit: it would be clearer if the message referred specifically to the config item that is bad; something like
"Expected list in 'tasks'; instead got" just to make it bleedingly obvious to the user, who is clearly pretty confused.  Otherwise it looks great.


Missing $ before {1}


Fixed #2


Finish #276


Leads to
ERROR: CDVDPlayer::OpenInputStream - error opening [http://www.hoster.com/file/ENCODEDFILEIDHERE=|User-Agent=Mozilla/5.0 (Windows; U; Windows NT 5.1; de-DE; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3]


It might be cleaner to write a helper like `is_asymmetric_filename`:

```python
matched_files = [fn for fn in filenames if is_asymmetric_filename(fn)]
for filename in matched_files:
    #blah
```


Reviewed PR and good with merge.


This was WIP, resolved by https://github.com/meanjs/mean/commit/280e8627bf872cdf2cbd3221a547ffb0a71e07f1


No problem, updated with copyright release, making new pull request


lol wut :hankey:


97648758-VentSlabCoolCoilOutput-4978 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1683 of 1683 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


thanks, ross.


Nope, it still crashes.

> At a minimum, this is the better way of building the regex string
:+1:


Ah cas ou tu es pas sûr, oui ça c'est le constructeur. Il doivent toujour s'appeler __construct().


Keep it up :+1:


This is my mistake in cherry-picking -- this was not the correct commit. I'm pushing the fix right now.


a


Just checking- but I'm assuming that this will generate a zero-overhead value class as though I'd extended AnyVal?


> Haven't looked at the ruby source for the respected methods but how is this different than block-vs-to_proc? (Well, Method#to_proc returns a lambda and Symbol#to_proc returns a Proc).

This is about passing the collection's member to method, and not calling method on the collection's member.

> I think it's somewhat obvious that slow would be slower as the test is comparing a method that calls 3 methods to a method that calls 2.

I agree. Also `method(:do_something)` gets an instance of `Method` class. I think this method object costs a lot, so slower.

I added this benchmark because people may use this syntax and think this is faster like the case you mentioned: [block-vs-to_proc](https://github.com/JuanitoFatas/fast-ruby/tree/cf64ab7e51bab12e4daf5956f2a7e93ace7665a4#block-vs-symbolto_proc-code).


Au cas où tu es pas sûr, oui, c'est le constructeur. Ils doivent tous s'appeler __construct().


> This will return the shortname for anything with a simlink, where below it is only returning it for /dev/ -- maybe use basename for both cases and remove the /dev/ check?

the `islink` case is there for things like `/dev/disk/by-label/OEMDRV` or `/dev/block/8:3` (although maybe I could just use `os.path.realpath` to resolve any symlinks first..)

After that, though, we don't want `os.path.basename` because of things like `/dev/cciss/c0d0` and `/dev/i2o/hda` - the kernel's `disk_name` for those devices is actually `cciss/c0d0` and `i2o/hda`, and especially the latter would be confusing if you also have a `/dev/hda`.


97648758-VentSlabCoolCoilOutput-4978 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I did now check in TWRP tar --help
and it gives output that can be parsed, but all operation modes are surrounded with a weird character that cannot be properly displayed (you can test it on your device, go to TWRP -> Advanced -> Terminal ) but after that is the text: (De)compress using xz

Als there is the line Usage: tar -[cxtzJjahmvO] .....

So I see two possiblities:
* check if the line which contains 'Usage:' on it also contains J (between square brackets).
* or check if there is a line containing "compress using xz"

About the empty string for grep, it could be that it is outputted to a different pipe maybe? You could try redirecting 2 to 1.

About the text: "or switch to another one." we could maybe replace with "or switch to another recovery." or maybe we could even explicitly mention TWRP?

The error handling itself looks good!


All poolside


why was this comment removed?


I'm personally in favor of leaving comments like this in-line, helps put the canvas functionality in context


목 =  Korean Thursday
금 =  Korean Friday
토=  Korean Saturday


The set of possible CLDR plurals presumably doesn't change, so I don't think having a model for the 4 different possible values is a good idea. Instead, I'd suggest an IntegerField with `choices` to constrain the possible values.
If you wanted to be fancy, you could even have the field named `_cldr_plurals` and add a read/write property `cldr_plurals` that does the translation between 1/2/3/4 and one/two/few/many.


as a future upgrade, you should probably have this in a map<Country,<Code,Name>>.

e.g.:
```javascript
currencies = {
'Afghanistan' : ['AFN','Afghani'],
'Albania': ['ALL','Lek'],
...
````
It'd probably be more useful and efficient to use when you need to fetch a currency, no linear search necessary.


I think the response body may be rendered as something like `<<bytestring builder>>` here.


@Zidane I made the `PlayerMessageEvent` an event for when a message is sent both to and from a player, the `MessageTransmissionEvent` is directional, from CommandSource to MessageSink. Messages sent from a player will extend both `PlayerMessageEvent` and `MessageTransmissionEvent`.

I'm thinking these hierarchy changes don't really belong in the PR so I'll remove it and create a new PR for further discussion


Very nice simplification.


@gwbarrett Nice catch!

Will update the docs.


Oops, doesn't line #22 `VERSION: '0.6.29'`  need to change to --> `VERSION: '0.6.30' `??


please, leave it as default y and never get forgotten by the bots...


ditto...


the remapping


doesn't this sample depend on something? i.e !PLATFORM_RIOTOS


![Alt Text](http://gfycat.com/EnviousSlipperyAtlanticspadefish)


ditto


RadianceRefactor (rpg777) - Win64-Windows-7-VisualStudio-12: OK (2177 of 2202 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.86%25-yellow.svg)


Thanks. It's fixed in #10937


暫時工具


It looks like some quick and dirty CSV parsing is happening here. Would it be cleaner / less error prone to use a CSV parser?


@Tchanders Fixed and updated the wiki.


Y las estadisticas??


please, also add this to warning-targets


Everything else in this function can be de-indented, once `f.read()` is called you can exit the block without any issues.


No, it's livesync. There's always a user (which IIRC is an admin)


remove version and type. This should be defined in the parent pom.xml under dependecyManagement


Looks good, wondering if I should be strict to check for password as well.  For now this is fine.


I must honestly admit that I had forgotten about the `CFG_VALUE` and `CFG_MERGE` macros. They should probably be used here yes. (They were included in a patch by someone else, and they looked like a cleaner way to solve the inherit-or-override logic. I was hoping to use it elsewhere as well, but never got around to it.)

A couple of other clarifications:

> First of all, for the set of boolean flags the secure, dump_session and dump_saml_response all use 0 as their default values (I copied that idiom).

Those are most likely broken then. Shows that I can miss stuff as well :smile:

> The legal set of values from the config parser is 0 or 1 for a boolean and a new config structure is initialized with default_xxx which is either 0 or -1 If the default is 0 you can't distinguish between unset, default, or the user set to false. It seems to me the logic only works if the default is TRUE (e.g. -1).

It is a bit more convoluted to use -- instead of `if (cfg->param)`, one has to write `if (cfg->param > 0)`. That way the default value (-1) becomes false. It's ugly, but it works.

> Why are the subject_confirmation_data_address_check and post_reply constants defined in a different location (auth_mellon.h) than the other config constants which are defined in auth_mellon_config.c?

That is because the `CFG_VALUE` macro accesses those two values directly, and that macro can be accessed from anywhere. Thus they need to be globally available.


Created by /u/noise_filter (aka proxyrax) on 6/29/15


> Do we even need to include the folder id here? Should the attachment get a different uniqueid when moving it to a different folder?

Good point.

> Also, when uploading a new file the id remains the same atm... if you want to avoid that, add its file_id

Livesync will be triggered anyway, and the record replaced. We want it to be replaced, not a new record.


since you're keeping it aligned, please align the := on -deps eval...


Whoops. Nevermind. ingnore my last comment


For some reason using librespot::util::SpotifyId; didn't work here, even though util/mod.rs has pub use util::spotify_id::{SpotifyId, FileId}; Ideas why?


So I had to pub this one, see above


Please use the `mono_counter` machinery for registering these counters instead of printing their values manually.


`_In_z_`, maybe?


HTTP Server OS X/Server/Controllers/UserController.swift

Hey @groue! I had to change some things in GRMustache to make it work with the framework. Mainly because the goal is not to depend at all on Foundation. The goal is a pure swift framework. So I striped all the dependencies I could, and rewrote some of the string methods, regex and errors. It worked, but I had some trouble with the NSDictionary extension which was used here:

```swift
    public func contextWithRegisteredKey(key: String, box: MustacheBox) -> Context {

        let registeredKeysContext = (self.registeredKeysContext ?? Context()).extendedContext(box: Box([key: box]))
        return Context(type: self.type, registeredKeysContext: registeredKeysContext)

    }
```

So I made Dictionary, Array and Set conform to MustacheBoxable. Of course I had to deal with this:

> No Swift collection of boxable values can adopt any protocol, actually, because Swift won't let any specialization of a generic type adopt a protocol

My solution was far from the best, but it did the trick. I've made the check if the collection holds mustacheboxables at runtime:

```swift
    public var mustacheBox: MustacheBox {

        var dictionaryValue: [String: MustacheBox] = [:]

        for (key, value) in self {

            if let k = key as? String {

                if let v = value as? MustacheBox {

                    dictionaryValue[k] = v

                } else if let v = value as? MustacheBoxable {

                    dictionaryValue[k] = Box(v)

                } else {

                    Log.warning("Tried to use a dictionary as MustacheBoxable, but the dictionary is not boxable.")
                    return Box()

                }

            }

        }

        let keyedSubscript = { (subscriptKey: String) in

            dictionaryValue[subscriptKey] ?? Box()

        }

        return MustacheBox(
            value: self,
            converter: MustacheBox.Converter(dictionaryValue: dictionaryValue),
            keyedSubscript: keyedSubscript
        )

    }
```

I know this is horrible, but it was the only thing I could think to make it work.

About this:

> [...] now your library has married GRMustache.swift for good, and your library users are exposed to an alien library.

I guess it's not that much of a problem, maybe a typealias like this below could give hide the *alien library* so others don't get too scared, haha.

```swift
// Hidden somewhere inside the library
typealias TemplateData = MustacheBoxable

...

struct UserController: HTTPRequestController {

    func any(request: HTTPRequest) throws -> HTTPResponse {

        let info: [String: TemplateData] = [
            "URI": request.URI,
            "method": request.method.description,
            "headers": request.headers,
            "params": request.pathParameters
        ]

        return HTTPResponse(status: .OK, body: try TemplateBody(template: "user.html", data: info))

    }

}


patch looks good, just minor issues, however, we're about to integrate a patchset #278 that will possibly break stuffs here, mostly due the cflags + ldflags shuffles, you should adapt to follow that...


according to the spec, any alphanumeric segment is strictly greater than any numeric segment


@kevva Do a patch release?


:shipit:


![Alt Text](http://www.reddit.com/r/HighQualityGifs/comments/3biix5/i_made_a_gif_of_michael_jordan_going_super_saiyan/)


@NKMR6194
ここでは，画面サイズによっての表示・非表示をするようにはしていないので，
また下の方に新しくセクションで追加しておきます


Got it, Will wait for #278 and rebase. Thanks.


Yay! Simpler code!


ouch... yep, no test using that for now. There's a bit of history involved but long story short, we changed the only user we had but I left it since I guess we'll have use for that soon. But if you feel unhappy with that I can drop it until we have an actual user.


qué es esto


creo que no cambiaste nada...???


Shouldn't line 466 match line 447? (`||` missing)


Test


Calculator-android-app
Basic Android Calculator
This app can perform only simple arithmetic operations.
I have made my algorithm to solve mathematical expression by converting them from a string.
You can download this app from https://drive.google.com/open?id=0B-gmCTzNujxJT1RDRUF2dXNGd1U


Maybe a bit more on this simpler nesting, before diving right into that massive one down below. Something along the lines of look! it's just nesting arrays. If we do `flatiron_school[instructors]` we get an array and now we can do `returned_array[0]` to get `"Avi"`


`MONO_PERF_STATE_UNKNOWN` is never used.


can you give an example where wf_skolem is necessary?


Should be on NPM now and on CDNjs tomorrow.


Hello. Sorry I write it here, but I don't know how to contact you… I have a problem with YTC, sometimes there are two instances of player. I can see only one of them, but I hear second instance of sound, which plays simultaneously, but a little bit delayed, and if I pause the video, sound of second instance continues to play. Can you please help me somehow?


![Alt Text](http://gifshost.com/342sw003300.gif)


It looks like @uzquiano fixed this bug a few days ago:  https://github.com/gitana/alpaca/commit/104e226f988476cbc4d895ac15d47cbaee879901

I assume it will be in the next release.


Just curious. Why do we force restore for RebuildAll action on a UWP project? We don't do this for non-UWP projects


@ryankaplan88

![Alt Text](http://gifshost.com/342sw003300.gif)


shouldn't you have some subtyping slack? in the simple-rules.txt, it uses the typing judgement.


nice win here now that we upgraded redis too


have you published your fork to npm? i would like to add it as a dependency in my project's package.json


Warum steigst du hier auf Eclipse Link um?


I agree that the `if value.present?` condition in the setter is confusing, and it might make sense to be removed.


CHAR(45) because of ipv6


:+1:
Thank you a lot!


Only a default, so, sure


ditto for slack


@magnumripper This caused a segfault on Travis:
```
Testing: strip-opencl, STRIP Password Manager [PBKDF2-SHA1 OpenCL]... make: *** [check] Segmentation fault
```
for the clang build:
https://travis-ci.org/magnumripper/JohnTheRipper/jobs/70097112


YES gimmie that extra 30px.


This is a duplicate with line 262. A new mailmap entry needed?

Same for `compat`.


A very similar feature is provided through the ModelBuildable interface for which one could implement PostBuildModel(m *swagger.Model) *Model on a struct.  However, that will result in a dependency to swagger. Was this part of the reason for creating this extension?


I'm frankly not super sure. It just seemed like a reasonable escape hatch in case you're stuck and we incorrectly guess we don't have to restore.


Schau dir dazu mal flyway an. Da kannst du die DB direkt befüllen. Solche Konstrukte sind unschön.


change this to 'mds'


and this can be "MDSAuthCap " probably


back tick keys


Few nit-picks BUT THIS IS SO COOL I'M EXCITED FOR THE REPL


Please remove the blank between the var name and the opening bracket


uhh ok it justs seems like youre ripping off my project :P

Thanks,
Pranav M.

On Wed, Jul 8, 2015 at 9:37 AM, Daniel Grimshaw <notifications@github.com>
wrote:

> @pranavmathur <https://github.com/pranavmathur> I wasn't planning on
> taking very much of your code anyway. This was going to be quite separate.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/danielgrimshaw/Befunge/commit/ecd2af0d56e39bc9c0a0f221c623531bd4d401b3#commitcomment-12066257>
> .
>


uhh ok it just seems like youre ripping off my code :p


sortAttributes |= SortAttributeIgnoreArticle; is shorter.


Wir hatten ja schon mal drüber gesprochen - ich denke es ist noch eine 'Altlast', aber nur zur Vorsicht: An die Methode muss eine Permission dran (die es genau einmal, nämlich für diese Methode gibt - Namenskonvention ausdenken). Das Mapping zur Rolle wird über die DB gemacht.


Was macht da hier genau?


Test


Du kannst keine Permission anlegen. Was soll die machen? Permissions hängen immer an den Operationen. Für jede Operation gibt es genau eine Permission. Es macht also aus meiner Sicht keinen Sinn neue PErmissions anzulegen.


I wish I could see a better commit message here :)

@vlm , why did you remove these functions? The prototypes are still in skeletons/constr_SET.h btw.


Do you want me to open a PR? On master?

On Wed, Jul 8, 2015 at 8:39 PM, Tute Costa <notifications@github.com> wrote:

> I agree that the if value.present? condition in the setter is confusing,
> and it might make sense to be removed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/doorkeeper-gem/doorkeeper/commit/22f51d4705a57af53db97c97f9bf91136d5565ef#commitcomment-12068625>
> .
>

--
Andrea Campolonghi

Cell : +39 347 2298435
acampolonghi@gmail.com


For the final commits, there's no reason to keep the "(fixup)" entries. They just confuse the reader. Remove them all from the commit messages.


we should also make the same 2.4 change in wait_for @cwhetung


This code is `Mongoid4`, I assume something similar exists in `ActiveRecord`. I assume too we don't want it for any reason, in that case I will merge the PR soonish!


Super minor nitpick - would you mind adding a comma at the end of this line? And maybe bump it up one line so they're in alphabetical order?  (Sorry - I can be a bit of a perfectionist haha)


So yes, PR to master sounds good. I'm not entirely sure if there is no reason why we'd want the condition, that's why I don't say I'll merge it right away. Thank you!


Will this create a value class?  js.Any does not extend AnyVal, unsure how to do this in scala-js.


Fixed random value picking. Before, would pick first value of domain every time because "(int)Math.random()" would always be 0.


This doesn't follow the coding conventions. We don't surround parenthesis with spaces.


Did you intend to commit this file? I'm pretty sure this is either a vim or emacs temp file which should be ignored.


Sorry.
Das ist halt das Tolle, wenn github die Unterschiede komplett unterdrückt ...


Take a look at ES6 style imports instead of CommonJS


I will make the PR but I think there must be a reason for this to be there
:)

On Wed, Jul 8, 2015 at 8:49 PM, Tute Costa <notifications@github.com> wrote:

> So yes, PR to master sounds good. I'm not entirely sure if there is no
> reason why we'd want the condition, that's why I don't say I'll merge it
> right away. Thank you!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/doorkeeper-gem/doorkeeper/commit/22f51d4705a57af53db97c97f9bf91136d5565ef#commitcomment-12068865>
> .
>

--
Andrea Campolonghi

Cell : +39 347 2298435
acampolonghi@gmail.com


Also doesn't follow the coding conventions; change to "} else {".


@aslagle Is this structure going to work for the styles package? Currently there is a compile error when importing the globals file.


@jdwelch UX thumbs up/down on use of underscore (vs. dash)? I'm still trying to understand when each is appropriate so I would appreciate commentary if you can provide it (thanks!)


See: http://babeljs.io/docs/learn-es2015/#modules


@chelmuth: works for me with a iso


Oh, I forgot to remove the 'throws' tag


Nice catch.


Thanks, was just about the make a PR for this...


See https://github.com/gurgeh/selfspy/pull/126 for another approach to this issue.


Why not, but why did you removed the *.swp* exception? This corresponds to the temporary files from vim.


Likewise take a look at ES6 style exports. Also, there's no need for the self invoking function wrapper in the new world order. That's from the old jQuery days, nowadays each file is auto wrapped in it's own closure as a higher order abstraction. So if you wanted to set a global variable you would have to do so explicitly with `global.key = value;`.


You do not need to check the version since the addGroup() has to handle NULL.


es6src/ui/.tools.js.swp did you intend to commit that file?


We should still print the message directing the user to localhost:8000


Fix for #2328


Oh, a fix for potential crashes?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.736.2574066754f5af08342c0899ae8b89037974198d](http://build.palaso.org/viewLog.html?buildId=59473&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 363, ignored: 3 Build time: 00:03:43


Typo?


Thanks for the info!


This commit contains tons of unrelated formatting changes to the lua files. Those should be dropped.


Awesome! All the commits since yesterday were covered already in the ts! :+1:


:scream:


I agree sortAttributes |= SortAttributeIgnoreArticle; is shorter.
Unfortunately it wouldn't compile: Something about permissive conversion from int to SortAttribute.
I tried to get creative with type casting but this was the best I could do. :-(.
Does this mean an overloaded |= operator for the SortAttribute type would be needed?


will do.


The comment could be made better to reflect the changes:  "Step 2 Create tables/indexes etc".


Futur? Isn't the research manager already functional thanks to your previous PR?


@dtex This was the silver bullet.


Yiiiiikes.


Ah, I see know.


Hi @remdex,

Thank you for taing a look at this and pointing me to the correct file.

i did look for some sort of validation script before i started on this route but i guess i didnt look hard enough :p.

i'll take a look at implementing this tomorrow so that we can get this feature added.

thank you again for the help


:+1:  - will merge as soon as the build is green


Updated.


I am not ripping off your code. Besides, its currently completely OSC. I could download your program, package it into a jar file, and sell it; legally, you would have no power to stop me.


You made it common to every modes, right?


@tute Do I need to make the PR on doorkeeper-mongodb?


Actually you can do not bother, i'll push update in a hour or two by myself :)


@gregra81 Can I get this propagated to the (//code.spark.autodesk.com/autodesk-spark-sdk-0.0.2.min.js)?
Please and thank you :D


97648758-VentSlabCoolCoilOutput-4978 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (651 of 651 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.35%25-green.svg)