Font-sizes should adjust, not remain fixed so you need a different unit, e.g. em.


This is comment for example


There's extra space at the bottom of the page for the blog.


Note the totally legal trailing comma.


See how we don't have to maintain this (out of date) comment about the accepted options anymore!


I think you mean to say `xXxnoSc0pesWallHaxxXx`.


Missing close ```}``` for media query.


Look at all these shorthand keys!


No, this doesn't increase the main comment page nesting, but increases the single comment view.

Yes, we will completely redo the comment system once we launch the API code.


I do believe that you're correct.


There's extra space at the bottom of the page, after the breakpoint, for the blog view.


That's nice but this is not a requirement. This doesn't add value, I don't care you add my name, commits speak by themselves :)


@u3games No está funcionando esto.


Cool. Is that [this](https://github.com/PuttItOut/voat/), or somewhere else? Is there a rough timeline?


Hahaha ok!


This commit caused a failed build due to rubocop violations:

https://travis-ci.org/umts/jobapps/builds/69010092


Why would you use a linked list! :( Bad practice. Use a data structure where it makes sense to use it. Linked List are meant to be used when you want your elements to be linked to each other, as in you can reach the next element to you always. Agreed that the current implementation of LinkedList in java might even let you fly, but doesn't mean you'll use it where you need some data structure. Code design is another thing that is focussed a lot upon. Just getting the solution isn't enough.


<h4> Oh, one more thing.<h4/>


@ratasxy buuuu


> If set to true and no span children elements are found, the specified image source on the parallax element will be used and it will not be responsive. The parallax mirror aspect ratio will be updated as the images are updated.

Maybe this wording was clear initially. I'll merge in this documentation and add further clarification to add a `data-image-src` to the parallax element `<div>`


Yes, we are working right now to get this fork over into the voat repo. Once this happens we will transition dev to it. We still have a lot of work to do to that fork and hope to have it ready for the community by week's end.

We will also be significantly refactoring what is currently present in that fork, as we need to run the API from a dedicated server and the current code was written to run it from the website. None of these changes have been done yet.


You need a margin-left on the div containing the benefits text on the homepage.


*description


Better like this:
`if ( in_array( array( 'current-menu-item', 'current-menu-ancestor' ), $classes ) $class_names .= ' active';`


i % 2 == 0 why? why are you pushing vertices in different sets based on their vertex number? Also, you are recursing for every vertex. I tried your solution on an example. Look at the number of times, I inserted the same vertices in the list, 4 is inserted 3 times, 2 is inserted 3 times...and so on. Mind you, this is when I used a very simple graph. What if the graph was really dense? Like a million nodes. Imagine the size of your list. The ideal solution should let me figure out whether the graph is bipartite or not as soon as a vertex is inserted in both the sets. Your solution runs for all vertices then tests if any of those exists in both sets. This is O(V^2) even in the best case.
![img_4752](https://cloud.githubusercontent.com/assets/13079520/8447494/409d8896-1f7f-11e5-93ea-16f0c1383035.JPG)


Ouch ... damn copy and paste errors =( *thumbs up*


I think there's missing some shared example initialization and global before/after each initializations.


it should still be able to parse a comment in config repo that contain edition.


hello @tde-banana-odoo , This code is committed by CHM to fix the data-chatter-id issue(when editing blog previous comment is disappearing in blog paragraph level comment). and this issue is now fixed by JKE using different way so this code is useless. so just remove Dead Code.


https://www.salesforce.com/form/soc-poc/profile2.jsp?provider=LinkedIn
--

Simona Pinkova


Generally all strings in html have double quotes "". We also need commas after each attribute-value pair (e.g., rel="stylesheet", type="text/css").


If we are making this request to the CDN for jQuery, we don't need it locally as well in our repository.


closes #3


Doesn't this already exist in Swift?


This is a pretty gnarly pattern.


A comment about why (sync on Desktop doesn't include them?) would help.


All script tags should go at the end of the body. If they are in the head, then the browser has to stop and wait until it's loaded before it can even start looking at the content in the body. When we have tons of javascript, this will prevent the user from seeing the page for a few seconds. Putting them in the body, but at the end after the content allows the user to see stuff on the page while the browser is loading the JS.


Probably don't need the article tag here. Header will suffice since it is the header :)


Try to avoid spaces around the = in html, should be href="#"


1679-DualDuct (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2182 of 2216 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.47%25-yellow.svg)


The problem with that solution is that it is actually overriding a default 'magical' finder, which everyone expects to work exactly like `find_by(name:`, but now it doesn't, and that is error prone.

I would recommend to use something like this: http://nandovieira.com/using-insensitive-case-columns-in-postgresql-with-citext

But I don't like to add an extension to the DB because of deployment issues.

I would instead use a more explicit method name like 'find_by_name_ignore_case`, or better, `find_by_ignore_case(name:`, like here is described: http://billpatrianakos.me/blog/2013/10/19/case-insensitive-finder-methods-in-rails/


`db:migrateRAILS_ENV=` – @razum2um no space after migrate


There's this weird domain / name mismatch where the *order* of entries in the non-commutative list is arbitrary.  Perhaps make that clear by returning a set?

I don't know of a term for what you're doing.  I can think of vague analogies with finitely presented algebras, but let's not...


and something strange ... looks like double paste


DTCoreText 1.7.5  bug  Please  look


I suggested 'hashkat', but this was if we were going to have run.sh as well only. I strongly prefer run.sh and build.sh otherwise.


Iphone5s Not running


Oh, Richard, this is gnarly.  You're indexing the lists by the type tag, so you essentially have a map associating the delta type to the details.


Have you try to undervolt low freqs (146 & 223)? is it correctly applied the new voltages?
i have a problem with my kernel.
thanks


`bLatest`?  Give me a chance.  You mean `preferBoverA` or something like that?


Somedays, it's like you never left, Jeff.

Thanks for the keen eyes.


None of these things include remote in the name.


Why is the ! necessary?


Why would the click already exist? This might be someone else’s click from the same time.


At the time I didn't care about the absolute/relative difference, only about the kind of redirect.

But considering that the .well-known URIs only work in the root of the server, maybe the original author wanted to express that by using absolute paths anchored in root on purpose? I.e. since the match will only happen if owncloud runs in the root directory, make the redirect starting with / as well.


added


I expected you to stamp all records at one time, even though it's a lie.  I guess this interacts better with foreground code.


This 1 is a little fragile -- can this be symbolic?


This is pretty nice.


This doesn't work because it's not wrapped in $(document.ready(function(){}); Since this isn't in the document ready and the script is at the top of the page before the content, when it gets all form tags ($('form')), the form doesn't exist yet, so there is no submit handler actually registered on the form when the browser finally loads the form.


We need to add a span tag in the html for this to work. Right now it's selecting all spans but no spans are in the html.


I'm confused by this return and indentation.  I think you wanted to bump the >>> below in, right?


Ah yes, do this in the previous commit, where I asked for it.


hello @tde-banana-odoo , If you can remove the hidden from DOM of comment Box and post button then comment box and post button will appear but it will not allow to post comment to you. it will give you a error on console reaise user error.

 File "/home/mba/odoo/master/addons/website_blog/controllers/main.py", line 259, in _blog_post_message
    raise UserError(_('Public user cannot post comments on blog post.'))
UserError: (u'Public user cannot post comments on blog post.', None)
"


Looks like you misspelled "canola"!


You might want to make it clear that PV is a reference to networked storage at this point.


Marking all local data as new this way is odd to me.  I feel like this is error-prone -- what is really wanted is, when a *new* account is created (not just reconnected) that all data is marked as new.


Instead of using .d which is for viruses, you can use .A which tells you if something is dead. Those values are obfuscated now, but you can look at the old version of Launcher since the variables are written in the same order as back then: https://github.com/Apostolique/Agar.io-bot/blob/7cfb3e144eeea9ebf43e3cd472e0d7d43f969cdd/launcher.user.js#L1311


Huh.  You learn some new SQL every day.


On second thought, the loot is due for a redo, I just looted a 239-ilvl item in normal mode


@daton buenas noches profe perdon por molestar espero y si me pueda ayudar a resolver el error o q esta mal para q quede bn la tabla gracias por su apoyo


What happens to the pod if the PVC is unfulfilled? Will the pod go to Failed state? Will it recover automatically when a suitable PV becomes available for the PVC?


got someone to add:
	["STEAM_0:0:120941798"] = "IPod/BooBoo Keys, C++ hacks, mpgh",
	["STEAM_0:1:71209027"] = "IPod/BooBoo Keys alt, C++ hacks, mpgh (Alt of STEAM_0:0:120941798)"

you seem to already have STEAM_0:1:71209027, update info.

this user is in the cheating group "DANGO Mafia" by the way.


Does it hurt to be safe and specify the `sync_status` as well?


so far you have this:

![](https://zapier.cachefly.net/storage/photos/6be08d117f40c809b41edec4969e53b4.png)


You will notice that i added a few extra columns that are not given in the database design, some of them are expert_id, user_id, question_type. Will add contract table when necessary


Where did this come from?  I don't see it in either of our other clients.


s/sane/reasonable/


Worth being explicit about the line: "local store is logins, remote store is passwords".


Made sure that question model , is accessible to the user only. Though i changed this behavior in the ability.rb later for better access restrictions.


Chainer is already depend on `setuptools` isn't it?


I'm a little surprised you're manually chaining.  I get that you want to try both even in the face of failures, to avoid early errors taking down later collections, but this makes me think you're doing something fancy.


We must have seperate set of rules for quest user. Will make that soon.


I'm merging this but I have a question about whether or not this directive should be placed in this file. I feel like it could be better modularized but not knowing anything about angular I don't know how.


Fold into earlier?  You have a plan for coalescing anyway, I think.


Created a controller for message model, and then in the controller added the "create" method. Adding messages within questions is simillar to blog where each post has comments. Reference is http://guides.rubyonrails.org/form_helpers.html


7am, my brain is derp. closes #155
>_>


Could you maybe add this in the Mson suggest and Command methods? Something like
Mson#suggest(MassiveCommand mc, String... args)
{
    return this.suggest(mc.toMsonString(args));
}

and the same without any parameters.

Maybe this method should ignore its args in case it is a parentcommand? This way the method would be more safe to use imo. What do you think? :)


 A message can only made if it is user's turn and user is viewing the page or
it is expert's turn and expert is viewing it


Yes, d5a3e95 does not exist in this repository.


Hola Josue, claro que si dejame revisarlo :)


@dbpercona please see https://github.com/codership/mysql-wsrep/issues/149 , will be merging it in shortly.


Update of Read Me - Exodus'Assault


it doesn't get mutated right now.  could just be assignment.  but i think for hotkey assignment it would get mutated?  (I was looking ahead a bit, maybe a bit too much?)


卧槽居然留了 console.log...


causing error on MacBookPro 10.10.2


causing error on MacBook Pro 10.10.2


Don't put non-free programs at GitHub, otherwise you might violate the terms of fair usage.


I haven't gotten a chance to profile it. I'll check it out.
On Jul 1, 2015 3:36 AM, "S.Ananth Natarajan" <notifications@github.com>
wrote:

> Did you see any performance gain when moving from SimplePool to futures?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ssundarraj/ImageScraper/commit/cfb933077d3b6763571a07758cf08bbc530144f9#commitcomment-11942329>
> .
>


The commit msg
Made source code modifications to make asyn record revert to the prev..
may be written shorter:
Make asyn record revert to the prev..


Ok @amundo I whipped up a JSON-schema spec based on what we have. In fact, I whipped up two of them: one with everything in the singular to start, just because it was simpler, and one with everything in the plural. So here are the actual JSON specs:

singular: http://digitallinguistics.github.io/spec/textSing.json
plural: http://digitallinguistics.github.io/spec/textPl.json

Then, I tried out the docson library just to have an easy way to render them. I made a separate page for each:

singular: http://digitallinguistics.github.io/spec/textSpecSing.html
plural: http://digitallinguistics.github.io/spec/textSpecPl.html

*NOTE:* I included a number of non-required, non-core fields in here, just because they were already either in our spec or came from decisions we made and I had in my notes. But I've noted in the spec which fields are required and not. And more importantly, this does (to the best of my knowledge) include everything that's part of the core spec, all the way down through morphemes and their properties. The core stuff is marked required, and everything else is optional.

So, the gist of it: If you go [here](http://www.jsonschemavalidator.net/), and paste the JSON text spec on the left, then paste some actual data in the right, then if I've done my job right, it should tell you whether you have valid DLX-format data or not. You ought to be able to leave off any non-required fields without it throwing any errors.

That said, it's possible the JSON-schema version has some kinks to work out that I didn't catch the first time around. So as you're looking around, let me know if anything seems odd.

Oh, and finally, I made a list of unresolved questions, none of which seem particularly crucial. I made temporary decisions on each of them for now, but I'm not committed to any of them. Here's the list of questions: https://github.com/digitallinguistics/digitallinguistics.github.io/blob/master/spec/OutstandingQuestions.txt.


@andyjmaclean , was this file supposed to be removed?


@steelbrain Would love your opinion on these.


test


I was offline and was writing the new code without semicolons so just removed for my convenience. Can revert that commit and put them back for unchanged code and can add in after this discussion.

@sonic78 here are some no-semicolon style guides which talk about your issue.

https://docs.npmjs.com/misc/coding-style
https://github.com/styleguide/javascript
 But basically:
> Don't use them except in four situations:

> for (;;) loops. They're actually required.
    null loops like: while (something) ; (But you'd better have a good reason for doing that.)
    case "foo": doSomething(); break
    In front of a leading ( or [ at the start of the line. This prevents the expression from being interpreted as a function call or property access, respectively.

Some good articles on the subject:
 - http://blog.izs.me/post/2353458699/an-open-letter-to-javascript-leaders-regarding
 - http://inimino.org/~inimino/blog/javascript_semicolons

The main reason to use semi-colons is to make your js more c/c#/java like which makes switching between those languages easier. If we decide to use semi-colons then I suggest we try and follow airbnb's style guide. https://github.com/airbnb/javascript

We should try and align to one of the style guides, semi-colons or no.

Whatever we decide I will switch by the end of this PR


I would like to know as well.


> it also makes the PR impossible to review. :(

There is very very little which has not been changed even with the semicolon change, but whatever we decide I will make this PR consistent with the decision before we merge it


Hmm. This is different from ReadableStream. But I think the only time ReadableStream calls ReleaseReadableStreamReader while closed/errored is in the constructor.


nothing change


Might need to check if currenct trace function is the one we installed. This code equals to `sys.settrace(None)`


should be two empty lines here.


Tooltip text will be without "Spell mastery"


Make sure the exception bubbles up to the original script. Keep in mind the exception will appear at the current frame!


Good catch!  Fixed in [0.17-a0-1470-g474c87d](https://github.com/crawl/crawl/commit/474c87db9304).


I tested your code and had the same issue; connection refused. You may have had a background process running with the server socket open and listening. Check out the code on my branch, and see if the tests pass for you.


(Sorry I missed this comment for so long)

Unfortunately I don't think that's feasible.  We switched to C++11 to simplify our codebase.  The changes are too pervasive (range-based for throughout the code, for example), and keeping both versions would make the code less maintainable than before the switch.

What are the older systems in question?  It might be possible to cross-compile with a newer g++, since gcc's backend targets almost everything.


`event` undefined.


Since I had reverted that major Devfreq commit, Things like this have been a major pain in the ass. Once I get the freq table working properly, I will test and let you know.


Thanks!

Quick note on adding code to swagger....
We only accept PRs against the develop_2.0 branch
And the PR should include the built files ( take a look at how to build in the README.md) tl;dr = just run `npm run build`


I have raised a pull request.. Is it possible for you to check and merge those changes.


noted. I originally had it but it gave me an error. After changed $db to a global variable it allowed the function call instead. Fixed on next commit


Makes sense, I changed it. Also added true/false return although did not use the value for anything.


You may be right, I kind of put that there because I think we will need session variables for state. I think you may be able to AJAX them across to the client. We can look into it more.


Unused. Should have been removed once `dist` was setup.


Note: this line was faulty


This line was not used in general. No idea why I had put this in here.


# タスク
* ローカル用テストデータを入れてテストをワンストップで出来るようにしたい
* ロギングちゃんと入れる
* コメントちゃんと入れる


Found this missing fallback out by faulty _.g function. Better to have a fallback anyway.


Fixed if _.g path contained a userdata object. This line may be improved in the near future.


What's the flag do?


This API will cause a lot of errors.


In general it's best to use semantic names where possible, i.e. names that describe what an element represents or does, as opposed to name that describes its implementation (e.g. names of HTML elements). For example, "p-color", "top-bar-300px" and "centered-text" are bad names, while "album-link-color", "navigation-bar" and "notification-text" are good ones. This is applicable not only to sass variable names, but also to css class names (and even javascript functions and variables).


HTC 816W机型如果重启后不能挂载，请将脚本名称的.sh删除。


Hey @sgolemon what's with these proto comments? They are getting pulled out by the various doc scripts used by IDEs and other tools and they aren't the right format


Don't really use this `action.Action` anywhere in the end, but it's implemented in the GitHub module, so let's just keep it there...


`gh.String` just turns `string` into `*string`. They use pointers everywhere.


I wonder, what's the purpose of this line? All branches below set bus count anyway, so it looks surplus to me.


@LorDClockaN check your hangouts man......


`with` means that this block is included inly when `.ReleaseNotesManagerKey` is not empty.


Thanks for the shout out! =)


I remember seeing somewhere, hence I knew about it. And by itself it uses Ubuntu.

But other than the base image, any other comments?


Please, use UTF8 charset. If you are working on a Windows environment, try another text editor like Notepad+ or SublimeText.


It is hahaha @bdogg718k


Thanks @westcripp


大神，我一直跟着你这教程弄，代码也编译成功了，在eclipse也没有报错了，但是在运行的时候居然报错如下：
Exception in thread "main" java.util.MissingResourceException: Can't find bundle for base name mondrian.resource.MondrianResource, locale zh_CN ，不知大神有遇到过没，求指点，弄了好久了，好想哭


lines 330-333: coordinates should be parsed as double, not integer!


Shouldn't the underscore from the label be removed too?


@xiphiaz the raw() method grabs everything, including hidden fields. So I unsetted the password here. Another option would be to use ```$user = $factory->make(App\Models\User::class)->toArray();``` which would respect the hidden field setting. Though then we also get the virtual fields, like self, which would have to be removed instead.

Depending on if using raw() had any specific purpose?


`Samuel Giddins`. Also, let's link to the issue?


hehe, nice addition...

`var godPattern = re.MustCompile("(?i)(?:where|what).*god")`
`conn.Privmsgf(channel, "%s: God? What God?", e.Nick)`


Technical critiques/drawbacks of this proposal:

1.  You might want to make the notifications stick around for more than 10 seconds.
2.  It's not clear at all that by moving the mouse or hitting the keyboard, the logout will be canceled.
3.  I'm not sure everyone will intuitively figure out that "xautolock" is the name of the program that is spewing these notifications, and that furthermore they can stop them by opening up a terminal and typing "killall xautolock".
4.  It would still be nicer to have a countdown. "59 seconds" means more to me than "3:29:14 PM". (I do agree that this is so far the most difficult thing to support.)

Having said that, overall, I still think having notifications is less obtrusive than having dialogs.


This makes the runner so convenient


这里是将获取到的部分数据返回？


You actually can, but I think this is the only case where you can do so (return type being a super class).
See http://try.haxe.org/#a8A4F


Daylighting_Speed (DeadParrot) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.44%25-red.svg)


@artstorm ah, no I just didn't think of using the `->toArray()` method. Feel free to change that.


@P-Kito : if you are referring to https://github.com/TrinityCore/TrinityCore/pull/12984 (Core/Spells: Prayer of Mending should scale with talents), that one got closed and did not make it into the source. The THANKS file contains usernames from the commits log where the usernames are in the source. (That is all I know.) If you are able to dig up something that did make it into the source, or if you changed your github username after some really old commit, perhaps it can be found in the file? (You should find your old name in the file, if you had an older username, though.)


1. もともとの全体でのcity の index
2. 各 group 内での city の index

1 と 2 のどちらを使用するかとても、悩んでいる感が伝わってきます。:)
混同しない限り、どちらでもよいと思います。

ぱっと見た感じ、オススメは、1 ですけど。そちらのほうが楽そう。

その場合は、このあたりのコードは
```python
current_city = groupup[0]
unvisited_cities = set(grouptup[1:])
```
のような感じになると思います。
また、dist[][] は、各Groupごとに計算する必要はないはずです。全体で使いまわせるはず。


The freqs table is populated correctly, but for me undervolting isn't applied to freqs < 268Mhz.


don't give extra space here


Does it resolve the problem on your end, too?


I can not find any Library/Formula/osslsigncode.rb file in my package


Because you only set `user:email` as the default scope and don't add it to the scopes list when the developer sets the scope them selfs, there is a risk that `_.findWhere(emails, {primary: true});` might be `undefined` because `emails` would be empty in that case.

When this happens `primaryEmail.email` would throw and error that `email` of `undefined` isn't accessible or something like that.

So we need to either `_findWhere(emails, {primary: true}) || {};` or always add `user:email` to the scope list, even if the developer set their own scope


You're right, we can remove this line.


@tbueno why did you change them? They are actually correct. They are trolley buses going to the airport. OTP and our backend handles them correct.


Another fix would be to always have `email` be the publicly visible email even if `user` or `user:email` is in the scope. i.e. `email: identity.email` as before, the result will be that the `email` field might be empty even if you get a list of emails in the `emails` field.


don't give any extra line and properly arrange all closing braces with  opening braces


developing


Why not use a ConcurrentHashMap instead? Besides the thread-safe operations on the ConcurrentHashMap, it also does not support null keys/values, as does the HasMap.


Also with the current implementation you can end up in the scenario that you get no email when you login because you didn't set a scope and you don't have a publicly visible email set at GitHub, then when the app later requests more scope and you re-authorize you get an email all of a sudden, which might be fine?


Review 완료.. develop 브랜치로 merge 하세요.


ok


math.exp(1 - r / c), r and c are integers, e.g. 3/2=1 (not 1.5) in this case.


Damn... it doesn't work...
It only accept files from "composer.json" not from options...


en


simple or stupied ,you known,i want not to say it


@hws-aoyagi
"sys_user_files" → "_FILE.permission" に変更してください。
※ 一階層下がるので注意。　→　daoArgs['doc']['permission']['_owner']
　→ _owner ってアンダースコア"_"必要かな？


Thanks.


@cobyism I just pushed a PR! Cheers!


Is this PR in an official ansible release?  Thx


@ppowalowski  Thank you for this change :)


This changes are very nice.
More Promisses like `ThenTry` in code can increase the readability, thanks for that PR.


@giano Thanks for the request, and sorry for the delay in merge. This is definitely helpful. I will release a new version in npm with the changes


It's explained in this section of the manual: http://haxe.org/manual/class-field-override-effects.html


Yes this is a solution, but i tried to reduce teh dependencies of other Frameworks. Did you have any idea to implement this pattern without Rx?

And an other topic. I think it is smoother if we write `aggregates.PublishNewStateTo(sampleEventHandler)`. This is shorter and more readable. I don't like the technical words like `Subscribe`in top of Frameworks. ;-)


Either we always even if users provide scope add `user:email` to always have the primary email available, and in that case we use the primary email for the `email` field.

Or we always use `identity.email` for the `email` field even if the scope gives us the list of emails for the account, in that case we only add that list of emails to the `emails` field. Doing it this way developers who
set the scope to include `user` or `user:email` will have list of emails in `emails` and should just not use the `email` field.

One of these two solutions are the most sane, I personally would prefer the first option but I don't know how other developers would feel about only being able to override all scopes except `user:email`.


You guys might want to update this since this has a bug on it where the icon will stay enabled even after disabling screen pinning in settings

Here's the updated commit with this fixed and more improvements :-)
http://gerrit.dirtyunicorns.com/#/c/16768/


はやとさん@hayatoito

アドバイスありがとうございました！
おかげさまで、予測した結果が出力されるものができました！
まだルートに無駄があるので修正していきます。


@davydotcom - Did you intend to write `.files(f -> f.dir("assets"))`


Merge of Readme.md file


а де моделька `Technology`?


You may want to update this commit because currently with what you got, there's a bug where the icon stays on even after disabling it in settings

Here's the updated commit with a vector and fixes :-)
http://gerrit.dirtyunicorns.com/#/c/16768/


if result[attach.id] is None then give This Error
File "odoo/master/openerp/addons/base/ir/ir_attachment.py", line 193, in _data_get
    result[attach.id] = int(result[attach.id])
TypeError: int() argument must be a string or a number, not 'NoneType'


// what


dd


Made modifications to meet PEP8 requirements


commnet test....


May be there ist a way to build a subscription chain like

    aggregates.PublishNewStateTo(firstEventHandler)
        .And(secondEventHandler)
        .And(thirdEventHandler);

What is your opinion?


@martijnwalraven, just a mention so you actually see these comments =)


I don't understand this change?


Please remove unused imports & try to use from_string() , to_string() function for Date class for date formation.


![Де моделька?!!!111](https://cldup.com/ql98oeEZ9e-3000x3000.png)


Daylighting_Speed (DeadParrot) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.61%25-red.svg)


Hi @likitha

How was it tested? Could you please describe the steps you took to make sure it works?

If I look at the code solely, it seems fine - although I miss some unit/integration tests.

Please let me know how you tested and I will perform the same tests before giving a LGTM.

Cheers,
Wilder


Thanks for the heads up. I appreciate it.


This should probably perform a redirect?

` z_render:wire({redirect, [{location, "/location"}]}, ContextLoggedon)`

See: https://github.com/zotonic/zotonic/wiki/Zotonic-:-useful-snippets


With that file you have to help me. I could not recover that one.


I'd have a preference for a `zoomAdapterMap`with string keys associated to its adapter object. It is exactly what you do with the `switch` but in an easier fashion:

```js
// folder name -> adapter object
var zoomAdapterMap = {
  'animated': AnimatedZoomAdapter,
  'static': StaticZoomAdapter
}

if (zoomAdapterMap[ that.peaks.options.zoomAdapter ] === undefined) {
  throw new ...
}

...
```


爲什麼要刪掉這行呀


Should the below return be `TEE_ERROR_OUT_OF_MEMORY`? I would prefer `TEE_ERROR_BAD_PARAMETERS` or `NOT_IMPLEMENTED`. What do you think?


good！


Using the overflow-safe variant of SlopeDiv() caused one (1!) demo out of ~10000 to desync when testing Crispy Doom with Choco's `statcheck` test. So, if you are not striving for 101% demo compatibility, you could just as well use SlopeDivOverflow() for everything throughout the whole code.


Please move everything into org.dbpedia.spotlight.wikistats (this would be  org.dbpedia.spotlight.wikistats.wikiformat).


1: D100 Missing docstring in public module


4: L102 copyright year is outdated, expected 2015 but got 2013


@carlosfrodriguez Please always make a full sentence with a final "."


Hi @likitha

The issue says "Failed to migrate volume from zone-wide to cluster-wide storage.", but looking at your changes they don't seem to fix the problem. Either the problem is badly written or your changes do not tackle it at all.

On DefaultEndPointSelector you added another hypervisor to the if clause. Before, it was checking only for HyperV, but now it also checks for VMWare.

On VmwareResource you only changed the message that is logged and used in the Exception.

Could you give me a hint on how those 2 changes will fix the volume migration?

Cheers,
Wilder


This and the next file can be deleted I guess.


``assertj`` is your friend here :)


1: M101 signature is missing
1: M111 unrecognized component name: legacy


What is nice about JWTs is that they can be used in a way that does not require storing them on the server side. I have implemented a JWT OAuth2 backend and validator that does not need DB for storing tokens, but had to reimplement this function to be able to completely skip the expiration timestamp.


Done https://github.com/nicosomb/smile-magento-elasticsearch/commit/d79300cb2ebe7a1b49d7469a8405b590f6c82b1b


Sure. That way we would maintain consistency.


I am still testing it,this is not working.

Actually the problem is when a user clicks on the link the uuid is getting
checked but it is not logging him in.Something error 500  Reason:
*function_clause is appearing.*

--
Cheers,
Anant

On Wed, Jul 1, 2015 at 12:21 PM, Arjan Scherpenisse <
notifications@github.com> wrote:

> This should probably perform a redirect?
>
> z_render:wire({redirect, [{location, "/location"}]}, ContextLoggedon)
>
> See: https://github.com/zotonic/zotonic/wiki/Zotonic-:-useful-snippets
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/anant2047/zotonic/commit/153b0c1a3ec8bfdecc138c6830a25f56c0c30cf8#commitcomment-11946932>
> .
>


这里也被删掉了……


It's based on Debian, not Ubuntu :)
Other than that, just push it to our organization on dockerhub


@carlosfrodriguez Maybe we should change this interface. Udo suggested that we add a MaxTries (or whatever it is called in the daemon) parameter here. So we could have something like Function => ... Params => ... MaxTries => ... (default 1)


```
$ rake db:migrate
$ rake db:seed_fu
$ rake db:seed_fu
```

こっちの方がいいかもですー


We could probably omit DaemonModules from the command path?


this is my firttime study


I have removed it and it passes the tests.  The only special handling needed was to look at the raw path of a passed in URI to look for // to determine if "" or null should be set. checked in now.


Responses:

1. Sorry, I had -t 300000 before.
3. Most people won't but you and I would appreciate it, i.e. it doesn't hurt.
4. Agreed, though a minutes timer would be better if the notification appears more than 60 seconds before the logout.

A dialog wouldn't be too bad if it would automatically disappear when there was activity like you suggested.


Hey @drewbrokke if you don't set the mvcPath, if you get an error while you are adding or updating an expando, you will be redirected to the default view, in this case to the view.jsp


@liancheng, any idea here?


What I really like in Carsten example is that I can route specific events to specialized handlers. I can't to that with subscription chains.


Daylighting_Speed (DeadParrot) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.37%25-red.svg)


@valib I can't remember exactly, but I think I added that parameter because the PS3 was timing out if we sent the stream too soon? Definitely something to test before releasing IMO


I think you need to leave the original copyright in the license blurb, so something like

Copyright 2014 Gogs
Copyright 2015 Gitea


I know, this was a headache. But I wanted to resist to add a new dependency. I will change it in next tests.


Not sure if this was intentional, but `data_frame` is assigned to a **vector**.


Cool, thx :+1:


No idea. I borrowed that from the MapServer .travis.yml


You are right, that looks like the only place where i did it wrong :)


1: M101 signature is missing
1: M111 unrecognized component name: legacy


A thread's owner will be informed(will receive a email) when it's form was succesfully created.
A post's owner will be informed(will receive a email) when someone comments his post.
Administrators can deactivate the notification for all the forms and all the threads


This is a web-based system whose main aim is to facilitate in management of attendance records


@AntJanus Exactly, I need to declare it otherwise `foundationRoutes` is undefined. Apart from that, the fix works for me.


When trying to upload a file, Http/MediaFileUpload.php adds "/upload" to the url: `$this->request->setBaseComponent($base . '/upload');`.
This results in a double "/" in the url, breaking the file upload. This may also cause problems in the other services.


I'd prefer `save!` here. Also, since you `build` and `save` in succession then just use `create` instead.


Finally! Thx!


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 98](https://teamcity.labkey.org/viewLog.html?buildId=258739&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 0 Build time: 00:14:56
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSUpgradeTest: <no details avaliable>

```


there is `` from __future__ import division`` on line 11, so it's true division in this case


How about saving ourselves a lot of headaches and fixing the sim environment first? As I said earlier, if you can simulate things its easy to test, and if its easy to test transformation errors don't go unnoticed.


this is an another test


Remove old line?


manged -> managed


Added a method that prints the SVD with the reaction IDs (to make it easier to match the IDs to reactions in case you don't know what they are).

Added a function that creates new colormaps (the inputs are specific colors and how many intervals to put in between them using a linear gradient). The script create_colorbar.py is one example.

Changed the regular doMapReactions function so it will also adjust the width of the arrows, and use a very light grey when the flux is 0.


`.build(post: @post)` is a shorter version


For more readability


Generally don't put spaces before or after parenthesis, so this looks more natural:

```ruby
expect(@user.favorited(@post)).to eq(nil)
```


remove DAT and get SAFE


Jep, you are right. Using it for 6.2 atm moment only. Not sure which vendor name to be used.


Thx, jep, your version fits better in general.


Ignore my previous comment. You are returning a #context{} from the controller, this causes the `function_clause` error. You need to wrap it in `?WM_REPLY`.

To perform the redirect you can use something like this:
```
    AbsUrl = z_context:abs_url("/logon", Context4),
    Context5 = z_context:set_resp_header("Location", AbsUrl, Context4),
    ?WM_REPLY({halt, 302}, Context5).
```


you can just do
```javascript
new Date().getTime();
```
The () is not needed


@federvieh
I think it makes more sense to only add decks via the DECKS URI, and update the deck here by ID rather than by name. The advantages of changing the behavior to this are:

* Decouples the URIs, so `update()` in `NOTES_ID_CARDS_ORD` doesn't affect the return values in `DECKS`
* More intuitive / obvious when a new deck has been created
* If a 3rd party app creates a deck, they can store it's DECK_ID, and not have the reference break when a user renames the deck
* More consistent API, since the model is also specified by ID

What do you think?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 97](https://teamcity.labkey.org/viewLog.html?buildId=258736&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 2 (1 new), passed: 24 Build time: 00:34:06
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyYAxisSelector: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

```


No I meant the change of the URL. You are creating an invalid URL  this way (`http:/domain`), it needs two slashes. Also the `{% url %}` tag always returns a url that starts already with a slash.


If the task was successfully cancelled, why do we still throw an Exception?

In that case, a RuntimeException, which should not be the case.


Hello,

I was wondering if downgrading / removing the thread.sleep should improve my app perf.
Is this ok for you ?

Romain


css and format


Here the "retVal" variable becomes true. However, even after saying the the task was completed successfully, you check if the request was cancelled - line 359. In that case, a RuntimeException is thrown.


Still, ```/usr/lib/autobuild3/filter/elf.sh: line 14: filter_elf_elfdep: command not found```


You started using tabs for indentation here. You need to configure your editor to use 2 spaces (refer to previous checkpoints or google it).


@kayabendroth Please do NOT update the Gradle version without any notice b/c we have a plugin that depends on this specific version.


I think a `unique_ptr` would fit better here


Thx


Added the opportunity to call vote view without action for case when we need to output num_votes without update. Before we were forced to carry a significant part of vote view into in own project.


RIP


Ok pour moi


You're missing `require 'rails_helper'` line at the top of the file. Without it you can't run this single test with `rspec spec/models/topic_spec.rb`


With this I managed to build everything including Geant3. It still fails in install, though, I guess because we go above the size of the docker image.


It seems to be 2 years old, and you could install via PyPI.


commenting in the pull request? I think?


It seems to be not necessary to return a result from `inc()` and `dec()`?


Yes.


Which commit of matlab swig did you used to use this feature? Apparently this is after the memory refactor that caused all those problem, and if try to generate the matlab code I get the error:
~~~
[ 98%] Swig source
swig error : Unrecognized option -redirectoutput
Use 'swig -help' for available options.
make[2]: *** [bindings/matlab/../iDynTreeMATLAB_wrap.cxx] Error 1
make[1]: *** [bindings/matlab/CMakeFiles/iDynTreeMATLAB_wrap.dir/all] Error 2
~~~


Just read through possibly another way that wouldn't involve a separate tmpfile `RuntimeDirectory=, RuntimeDirectoryMode=` Going to test this out and see. Should create the directory while the service is running and tear down after service stops. Need to see if that causes problems with lighttpd serving up the JSON's.


Zend brought in since ZH Healthcare is doing a lot of work in Zend to support MU2. The Zend code does fulfill the new security model(binding and escaping) and the flags are "centralized" somewhere in there (note this was not automatic and was dealt with via code reviews before the Zend module imported was brought in).


_send wants a message, not a packet. I'm not sure if you need the tunnel prefix, probably not


On Wed, Jul 1, 2015 at 8:52 AM, Pascal Brand (dev) <notifications@github.com
> wrote:

> Should the below return be TEE_ERROR_OUT_OF_MEMORY? I would prefer
> TEE_ERROR_BAD_PARAMETERS or NOT_IMPLEMENTED. What do you think?
>

TEE_ERROR_BAD_PARAMETERS seems better indeed because we get here as a
result of the TA calling either TEE_PopulateTransientObject() or
TEE_GenerateKey(). The GP spec for both functions documents
TEE_ERROR_BAD_PARAMETER for the case "an incorrect or inconsistent
attribute value is detected."

I will push a new patch.


awesome :+1:


please see: https://github.com/joomla/joomla-cms/issues/7296


TBH i hink this is attemt from March of War: Face Off to get more players and if it is gg, they did a really good job !


Those defines are not part of the standard FreeRTOS package, so it will not build unless the user of libcsp also has the plus-trace included. I suggest that we rename the define in libcsp.


大神是厉害啊！


Would it be possible to make this configurable? We do bundling of vendor dependencies in development and would like to have the option of setting the value to `development` in our bundling script.


As suggested by Eric you might want to log at debug level for granted access, but at info for denied requests.


Silverlight is not known as Windows Store apps.


No, because that cog wheel is white, not red, so I'd have to have some massive hacks to override the paint function of the icon just to color it red, otherwise you can't see it because the background is also white.


CrossCore is already Profile 259


What does this mean?


I got my phone repaired, and I now also tested it, and it works as it should.
Also the log (now) works, which was because the remove-command was not properly executed and everyting in /tmp got wiped during the installation.

Still for some reason though, I missed some non-Google applications after my first reboot. But that might have been another issue. I will check that later again, to check the package did cause this issue, or something else.


`%~2` - expand `%2` removing any surrounding quotes (")
http://ss64.com/nt/syntax-args.html


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


1: M101 signature is missing
1: M111 unrecognized component name: legacy


ok, I'll look at doing this. The current implementation has got the sequence of execution wrong, as we'll need to check for ```ftrackAssetType``` and ```ftrackAssetName``` before trying to find any asset on the task.


i don't like it


comment
저기 지워


이거 지웠으면 좋겠어


this is always `true`.


테일링 라인이 들어가는것이 좋겠구만.


태일링 라인이 들어가는 것이 좋겠군.


ㅁㅁ


`RuntimeDirectory=dump1090-mutability`
`RuntimeDirectoryMode=755`

Creates the directory under `/run` when the service starts, dump1090 has no problem writing it's JSON and lighty reads with no problem. The directory is deleted when the service stops and re-created when it starts again. The only issue I can think of right now is if the service is reloaded the JSON files would be deleted, but that may be a good thing to get rid of stale data.


Please use Pull Requests so we can review your stuff.


없어도 될 거 같은데


A generic "Worker" doesn't have a priority. Create these constants in UpdateFeedsWorker.


No, there is a good reason why we use False instead of [] or {} in default arguments of Python functions. Please read this: http://effbot.org/zone/default-values.htm


I am not an  experienced Pythonist but I would rather use 0 instead of None.


This seems like the safe choice, but it seems if there are visible results of the function call it should be marked as has_side_effects=true?


@martijn00 +!, you're using the old NuGet restore here too. See MvvmCross/MvvmCross/pull/985


Are projects names `test-1` and `test.1`  equivalent?


Instead of doing twice if(enable_mesh_cache && f->mesh_ptr[0]), in if and in else if, do the enable_mesh_cache && f->mesh_ptr[0] globally on the two conditions


The React element can be created just as object literal:
```
{
  type: String | ReactComponentType,
  props: Props
}
```
The factories and `React.createElement` calls are just for validation which is unnecessary if purescript can provide static guarantees.


Yep. When the "/init" in the ramdisk loads .prop files, it also loads the /system/etc/[boardid].prop. Now the model is overwritten.


I am adding the whitespace, so it is indented at the same level as everything else. What is wrong with that?


I am not even sure if we need that list anyways. A better readme would be how to use it.

As @martijn00 mentions Pull requests are much more preferable so stuff can be reviewed before pulling into the repo. You can do this by creating a branch or a fork. Commit to that branch/fork and create a pull request through GitHub.


nvm, seems to be removed from the overall PR. (the trouble with the commit by commit review)


please remove whole this condition


I should add it in MsonEvent and Mson, that is true. Now that you say it, I could provide a whole lot of type security, for invalid args and so on.


Is the std::vector move-constructor guaranteed to clear the source vector?  I honestly would not be surprised either way.


@ghoshbishakh I just noticed this. When you give added info about commit message, please sure you give a blank line between your original commit message and description. For ex: Above commit message format should have been:

> Fixes #4 display greeting message only when user not logged in
>
> In new threads list page check if a user is logged in. If not add a
> message at the top of the threads list requesting to sign up.But
> if the user is logged in do not show such message.


@hajoeichler Is that correct `parentBY` ? Or `parentBy`?


If you want I can commit my modified version of this example in which I also added the conversion from iDynTree vectors to numpy arrays (using numpy.fromstring). @traversaro


Yes please! You still have write access?


I do not understand why 'min_count' is an optional argument in this particular function?


Redirection !


Nice adds !


This is still work in progress!

I'm basically trying to migrate all the stuff that is "Results" from the "Material & methods" section.


Ok!


You ignore 1 here. I am not sure if it is a good idea but I do think you should reflect this fact in the help.


Ok. Fine then !


This is a bug :)
ENOBUFS - is not the same as "Out of memory". Example -- receiving NFQEUEUE messages. When queue is  under overflow, `nl_recvmsgs_default()` returns `-5` (i.e. NLE_NOMEM) due to `recvmsg()` returns `-1` and set `errno` to `ENOBUFS`.  Is it indistinguishable from real out of memory situation.

Can you add `NLE_ENOBUFS`  or something like that ?


This works, although personally I don't like this. By checking against `Topic.all` you're almost repeating the actual code you're testing.

My approach is to make tests as simple as possible, even dumb. So simple in fact that they cannot be wrong. In this case I'd use:

```ruby
expect(Topic.visible_to(user)).to eq([@public_topic, @private_topic])
```

Similary in the next spec I'd use a literal array to check the condition.

When your tests have logic similar to the actual code then you're not really testing much, are you?


dfbdfbdfbdfbdfb


dfbdfb


@mvidner AFAICS this commit should be reverted.
Then changes like done in libyui-qt-pkg can be applied:
Rename "Dependencies/Install Recommended Packages for Already Installed Packages" to
"Dependencies/Install All Matching Recommended Packages (Temporary Change)" .
And adapt changelog.


I'd like to use LGTM (looks-good-to-me) to indicate acceptance.


Is there any reason why Object.keys(wasteCounts[i].reason[products[j]])).forEach() is preferred over the simplifier and self-explanatory form:
``Javascript
for(va key in wasteCounts[i].reason[products[j]]){

}


From the file mode changes I can see this is when you moved your code to the Windows partition. You should use `git config core.fileMode false` command to ignore those file mode changes. See this answers: http://stackoverflow.com/questions/1580596/how-do-i-make-git-ignore-file-mode-chmod-changes and http://stackoverflow.com/questions/19620335/what-is-gits-filemode


we can flatten the promises here without calling deferred.resolve() and var deffered  = $q.defer();


Restored.

On Wed, Jul 1, 2015 at 7:23 AM, dan entous <notifications@github.com> wrote:

> @andyjmaclean <https://github.com/andyjmaclean> , was this file supposed
> to be removed?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/europeana/europeana-channels-blacklight/commit/92cf204f3bff0fd501512003a295eccc24986a44#commitcomment-11946258>
> .
>


does throwing an exception count as a 'side effect' for our purposes here?


Rename to IsController?


Afaik erdgeist's method is not only proposed but deployed in practice, e.g. in opentracker and some clients implement that already.

Dual-stack nodes can simply announce v4 and v6 separately. Which may also be beneficial since 2 reply packets can hold twice the payload (different address lists) without having to prioritize one over the other.


thanks, it should be fixed in 7.0 with https://github.com/odoo/odoo/commit/45faa3a9414631f73764a2e6fbf3b7ecb93c8a7e and will be forward-ported soon.


Won't this command generate a new secret on every single request meaning that the token will be authenticated against a different secret?

We also should be using RS256 signatures which will require us to use a different secret generating command anyway.


西山娃娃，最近咋不更新了？


where is _destroyed actually set? Socket uses destroyed without the underscore. At the point where the ssl connection is shutdown there still needs to be the SSL close handshake so shutting the socket down seems like a bad idea until this has completed. Or am I missing something?


Not needed and fixes the error: Cannot use TYPO3\CMS\Core\Utility\ExtensionManagementUtility as ExtensionManagementUtility


0으로 나누면 에러 날텐데...


Considering that you do product_obj.id on the previous line, product_obj is a singleton recordset, which means that it contains only one record. I don't understand why you have to loop on it then ?


rename pf to p too


I think the name suggested by Bloc would be more intention reveling here: `up_vote_link_classes`.

"helper" is so vague and general that there's always a better name.


I think the fact that Pandora generates unique tokens for stations and playlist items is something that we can leverage to make lookups easier. The usecase can be something like this:

1. consumer calls ```client.get_station_list()```, and potentially caches the result for use later on
2. the user then selects a station to listen to, either using a numbered list (as is done here: https://github.com/mcrute/pydora/blob/5ab0a04eb9c4e51e33f11f3433a84f968f098f26/pydora/player.py#L60-62), or clicking on a link in a web interface (in which case the station token will probably be embedded in the URL as a way to identify the station uniquely)
3. the way the API is written now, one needs to either (a) know the position of the station in the list or, (b) iterate through the list and compare tokens one by one or (c) request the station from the Pandora server using ```client.get_station(station_token)```.

I agree that it is less relevant for the play list as the default behaviour is just to iterate through the list in the order that Pandora provides. I wonder however if there may not be a general expectation by consumers to be able to retrieve model items using their unique token identifiers whenever they form part of a collection.


That is one possibility, which is easier to implement.
However, I had in mind a slightly different thing: change it to an action (like I did in the Qt UI, and the mode of operation of `zypper inr`), similar to Verify System Now -> Install Recommended Packages for Already Installed Packages Now.


Okay, thank you. The reason I'm asking is that the first parameter specifying the NSIS build is probably no longer needed. So in case I remove that, both `%2` and `%~2` (I wasn't sure about the latter). Unfortunately, the build system does not/no longer work on my Windows machines, so I couldn't simply test it myself.


You could even move `glyphicon glyphicon-chevron-up` into the helper methods as well, in which case your view file wouldn't need to interpolate any strings at all.


Ciao @ktf, so: I don't need a special, "dummy" Git repository in order to compile AliEn? I do not see any `source:` line in the recipe.


basically [this](https://github.com/oli-obk/rust/blob/master/src/compiletest/runtest.rs#L957) looks for "filename:linenum:" which can only happen in the error/warn/note line, not in the lines that show code, since those don't have a trailing colon. If that would exist, we'd have issues with code that contains something that looks like an error message


Ah right the dynamic call to `to_f` expects a Ruby frame, but the `#pack` frame is different.
Looks good, the method should be filled with `Array#pack` if possible.


OK I will rephrase.

From: Tomasz Cielecki [mailto:notifications@github.com]
Sent: Wednesday, 1 July 2015 5:50 PM
To: MvvmCross/MvvmCross-Forms
Cc: peter j c. burke
Subject: Re: [MvvmCross-Forms] Updated Readme and also Xamarin PCL Reference as a new release is out today (7ae85ff)

Silverlight is not known as Windows Store apps.

-
Reply to this email directly or view it on GitHub<https://github.com/MvvmCross/MvvmCross-Forms/commit/7ae85ff8871d4535de8fb3e041287869f8bd15b9#commitcomment-11947641>.


Indeed it is.

From: Tomasz Cielecki [mailto:notifications@github.com]
Sent: Wednesday, 1 July 2015 5:51 PM
To: MvvmCross/MvvmCross-Forms
Cc: peter j c. burke
Subject: Re: [MvvmCross-Forms] Updated Readme and also Xamarin PCL Reference as a new release is out today (7ae85ff)

CrossCore is already Profile 259

-
Reply to this email directly or view it on GitHub<https://github.com/MvvmCross/MvvmCross-Forms/commit/7ae85ff8871d4535de8fb3e041287869f8bd15b9#commitcomment-11947648>.


use find_devices() directly


Yes, you are right, also a good solution to make it similar to Verify System Now.


b is never used


dead code?


Yay another thing I screwed up. Good thing I don't do dev for SM any more, so that this can't be a problem any more.


1: M111 unrecognized component name: legacy


This is incorrect.


only return 2 here, because this function is only used to determine the length


1: D100 Missing docstring in public module
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils
41:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
43:1: I201 Missing newline before sections or imports.
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio_records.api
44:1: I201 Missing newline before sections or imports.
45:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly, warning_page, write_warning
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
49:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webuser
51:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
52:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, guess_primary_collection_of_a_record, record_exists
53:6: E126 continuation line over-indented for hanging indent
56:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio_records.access
56:1: I201 Missing newline before sections or imports.
59:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
61:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.collections.models
66:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
66:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
66:1: E402 module level import not at top of file
67:6: E126 continuation line over-indented for hanging indent
73: D101 Missing docstring in public class
75: D102 Missing docstring in public method
111:90: E203 whitespace before ':'
113:29: E127 continuation line over-indented for visual indent
113:94: E502 the backslash is redundant between brackets
113:75: E203 whitespace before ':'
113:91: E203 whitespace before ':'
117:56: E502 the backslash is redundant between brackets
118:45: E127 continuation line over-indented for visual indent
118:49: E251 unexpected spaces around keyword / parameter equals
118:51: E251 unexpected spaces around keyword / parameter equals
147:17: E266 too many leading '#' for block comment
148:17: E266 too many leading '#' for block comment
166:13: E266 too many leading '#' for block comment
190:37: E266 too many leading '#' for block comment
191:37: E266 too many leading '#' for block comment
194:45: E128 continuation line under-indented for visual indent
201:107: E203 whitespace before ':'
203:37: E122 continuation line missing indentation or outdented
203:102: E502 the backslash is redundant between brackets
203:83: E203 whitespace before ':'
203:99: E203 whitespace before ':'
204:41: E128 continuation line under-indented for visual indent
239:13: F841 local variable 'cc_id' is assigned to but never used
265:25: E128 continuation line under-indented for visual indent
265:79: E502 the backslash is redundant between brackets
266:41: E127 continuation line over-indented for visual indent
267:54: E502 the backslash is redundant between brackets
268:25: E128 continuation line under-indented for visual indent
270:25: E126 continuation line over-indented for hanging indent
277:25: E127 continuation line over-indented for visual indent
278:25: E127 continuation line over-indented for visual indent
279:25: E127 continuation line over-indented for visual indent
280:25: E127 continuation line over-indented for visual indent
283: D400 First line should end with a period (not 't')
283: D205 1 blank line required between summary line and description (found 0)
283: D208 Docstring is over-indented
295:1: E302 expected 2 blank lines, found 1
295: D210 No whitespaces allowed surrounding docstring text
295: D202 No blank lines allowed after function docstring (found 1)
295: D400 First line should end with a period (not 's')
304:13: E203 whitespace before ':'
311:13: E266 too many leading '#' for block comment
323:17: E266 too many leading '#' for block comment
338: D101 Missing docstring in public class
342: D400 First line should end with a period (not 'd')
342: D200 One-line docstring should fit on one line with quotes (found 3)
363:22: E126 continuation line over-indented for hanging indent
363:50: E203 whitespace before ':'
364:55: E203 whitespace before ':'
374:9: E122 continuation line missing indentation or outdented
427:96: E128 continuation line under-indented for visual indent
438:50: E502 the backslash is redundant between brackets
458:5: E128 continuation line under-indented for visual indent
466:26: E251 unexpected spaces around keyword / parameter equals
466:28: E251 unexpected spaces around keyword / parameter equals
469:111: E502 the backslash is redundant between brackets
469:34: E251 unexpected spaces around keyword / parameter equals
469:36: E251 unexpected spaces around keyword / parameter equals
470:37: E127 continuation line over-indented for visual indent
471:25: E251 unexpected spaces around keyword / parameter equals
471:27: E251 unexpected spaces around keyword / parameter equals
472:24: E251 unexpected spaces around keyword / parameter equals
472:26: E251 unexpected spaces around keyword / parameter equals
477: D202 No blank lines allowed after function docstring (found 1)
477: D400 First line should end with a period (not 'e')
477: D300 Use """triple double quotes""" (found '-quotes)
492:16: E127 continuation line over-indented for visual indent
496:35: E128 continuation line under-indented for visual indent
497:35: E128 continuation line under-indented for visual indent
507:13: B901 blind except: statement
513:13: B901 blind except: statement
518:17: E128 continuation line under-indented for visual indent
519:17: E128 continuation line under-indented for visual indent
520:17: E128 continuation line under-indented for visual indent


38:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
45:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 45
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 45
45:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 45
45:1: F999 redefinition of unused 'CFG_LOGDIR' from line 45
45:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 45
45:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
45:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
45:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
45:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
45:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
45:1: F401 'CFG_OAI_ID_FIELD' imported but unused
45:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
45:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
45:1: F401 'CFG_SITE_RECORD' imported but unused
45:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
45:1: F401 'CFG_INSPIRE_SITE' imported but unused
45:1: F401 'CFG_BASE_URL' imported but unused
45:1: F401 'CFG_LOGDIR' imported but unused
45:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
45:1: F401 'CFG_BIBSORT_ENABLED' imported but unused
45:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
45:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
45:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
45:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
45:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
45:1: E402 module level import not at top of file
46:6: E126 continuation line over-indented for hanging indent
80:1: E402 module level import not at top of file
81:1: F401 'get_most_popular_field_values' imported but unused
81:1: E402 module level import not at top of file
82:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
82:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils
82:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
82:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
82:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
82:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
82:1: E402 module level import not at top of file
83:6: E126 continuation line over-indented for hanging indent
87:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors
87:1: F401 'get_fieldvalues_alephseq_like' imported but unused
87:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
90:1: I201 Missing newline before sections or imports.
90:1: F401 'record_xml_output' imported but unused
90:1: F401 'create_record' imported but unused
90:1: E402 module level import not at top of file
91:1: F401 'DataCacher' imported but unused
91:1: E402 module level import not at top of file
92:1: I101 Imported names are in the wrong order. Should be perform_external_collection_search, print_external_results_overview
92:1: F401 'perform_external_collection_search' imported but unused
92:1: F401 'print_external_results_overview' imported but unused
92:1: E402 module level import not at top of file
93:1: E402 module level import not at top of file
94:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS, VIEWRESTRCOLL
94:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
94:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
94:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
94:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
94:1: E402 module level import not at top of file
100:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.modules.access.local_config
100:1: F401 'intbitset' imported but unused
100:1: E402 module level import not at top of file
101:1: I201 Missing newline before sections or imports.
101:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
101:1: E402 module level import not at top of file
102:1: F401 'deserialize_via_marshal' imported but unused
102:1: E402 module level import not at top of file
103:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.utils.serializers
103:1: F401 'acc_authorize_action' imported but unused
103:1: E402 module level import not at top of file
104:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine
104:1: F401 'register_exception' imported but unused
104:1: E402 module level import not at top of file
105:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
105:1: F401 'encode_for_xml' imported but unused
105:1: F401 'wash_for_utf8' imported but unused
105:1: F401 'strip_accents' imported but unused
105:1: E402 module level import not at top of file
106:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
106:1: F401 'bibrecord' imported but unused
106:1: E402 module level import not at top of file
108:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
108:1: F401 'wash_table_column_name' imported but unused
108:1: F401 'get_table_update_time' imported but unused
108:1: F401 'run_sql_with_limit' imported but unused
108:1: E402 module level import not at top of file
110:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
110:1: F401 'collect_user_info' imported but unused
110:1: E402 module level import not at top of file
111:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webuser
111:1: E402 module level import not at top of file
113:1: F401 'apache' imported but unused
113:1: E402 module level import not at top of file
115:1: F401 'DatabaseError' imported but unused
115:1: E402 module level import not at top of file
120:22: E203 whitespace before ':'
120:14: E225 missing whitespace around operator
121:24: E203 whitespace before ':'
122:24: E203 whitespace before ':'
123:28: E203 whitespace before ':'
124:30: E203 whitespace before ':'
125:24: E203 whitespace before ':'
126:23: E203 whitespace before ':'
127:29: E203 whitespace before ':'
128:26: E203 whitespace before ':'
129:33: E203 whitespace before ':'
130:30: E203 whitespace before ':'
131:30: E203 whitespace before ':'
132:30: E203 whitespace before ':'
133:30: E203 whitespace before ':'
134:30: E203 whitespace before ':'
135:30: E203 whitespace before ':'
136:41: E703 statement ends with a semicolon
138:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from sqlalchemy.exc
138:1: F401 'collection_restricted_p' imported but unused
138:1: E402 module level import not at top of file
139:1: F401 'restricted_collection_cache' imported but unused
139:1: E402 module level import not at top of file
140:1: F401 'get_permitted_restricted_collections' imported but unused
140:1: E402 module level import not at top of file
143:1: F401 'check_user_can_view_record' imported but unused
143:1: E402 module level import not at top of file
145:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio_records.access
145:1: F401 'get_coll_i18nname' imported but unused
145:1: E402 module level import not at top of file
146:1: F401 'get_field_i18nname' imported but unused
146:1: E402 module level import not at top of file
149: D401 First line should be in imperative mood ('Create', not 'Creates')
149: D400 First line should end with a period (not 'n')
149: D205 1 blank line required between summary line and description (found 0)
156:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
156:1: E402 module level import not at top of file
159: D401 First line should be in imperative mood ('Return', not 'Returns')
159: D300 Use """triple double quotes""" (found '-quotes)
180:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers
180:1: F401 'get_collection_allchildren' imported but unused
180:1: E402 module level import not at top of file
183: D400 First line should end with a period (not 'o')
183: D205 1 blank line required between summary line and description (found 0)
183: D208 Docstring is over-indented
228:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names
228:1: E402 module level import not at top of file
231: D209 Multi-line docstring closing quotes should be on a separate line
231: D400 First line should end with a period (not 'y')
231: D205 1 blank line required between summary line and description (found 0)
231: D208 Docstring is over-indented
244:38: E203 whitespace before ','
275:1: E302 expected 2 blank lines, found 0
275: D209 Multi-line docstring closing quotes should be on a separate line
275: D400 First line should end with a period (not 'g')
275: D205 1 blank line required between summary line and description (found 0)
275: D208 Docstring is over-indented
304: D209 Multi-line docstring closing quotes should be on a separate line
304: D205 1 blank line required between summary line and description (found 0)
317:1: E303 too many blank lines (3)
317: D103 Missing docstring in public function
327: D401 First line should be in imperative mood ('calculate', not 'calculates')
327: D209 Multi-line docstring closing quotes should be on a separate line
327: D202 No blank lines allowed after function docstring (found 1)
327: D400 First line should end with a period (not 'e')
327: D205 1 blank line required between summary line and description (found 0)
338:20: E261 at least two spaces before inline comment
342:17: E261 at least two spaces before inline comment
369:1: E302 expected 2 blank lines, found 1
387: D210 No whitespaces allowed surrounding docstring text
387: D400 First line should end with a period (not 'n')
393:25: E261 at least two spaces before inline comment
394:13: E222 multiple spaces after operator
417:10: E261 at least two spaces before inline comment
434:1: E266 too many leading '#' for block comment
436: D103 Missing docstring in public function
437:25: E128 continuation line under-indented for visual indent
438:25: E128 continuation line under-indented for visual indent
439:25: E128 continuation line under-indented for visual indent
440:25: E128 continuation line under-indented for visual indent
457: D401 First line should be in imperative mood ('Set', not 'Sets')
457: D202 No blank lines allowed after function docstring (found 1)
457: D400 First line should end with a period (not 'l')
457: D200 One-line docstring should fit on one line with quotes (found 3)
458:23: E128 continuation line under-indented for visual indent
459:23: E128 continuation line under-indented for visual indent
460:23: E128 continuation line under-indented for visual indent
461:23: E128 continuation line under-indented for visual indent
462:23: E128 continuation line under-indented for visual indent
500:9: B901 blind except: statement


1: D210 No whitespaces allowed surrounding docstring text
27:1: I101 Imported names are in the wrong order. Should be CFG_SITE_ADMIN_EMAIL, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.config
28:1: E402 module level import not at top of file
29:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.base.i18n
29:1: F401 'config' imported but unused
29:1: E402 module level import not at top of file
144:16: E126 continuation line over-indented for hanging indent
192:15: E126 continuation line over-indented for hanging indent
195:1: E402 module level import not at top of file
226:17: E203 whitespace before ':'
227:20: E203 whitespace before ':'
228:18: E203 whitespace before ':'
229:22: E203 whitespace before ':'
230:20: E203 whitespace before ':'
231:23: E203 whitespace before ':'
232:19: E203 whitespace before ':'
233:20: E203 whitespace before ':'
234:21: E203 whitespace before ':'
235:37: E203 whitespace before ':'
249:4: E131 continuation line unaligned for hanging indent
278:1: W391 blank line at end of file


39:27: E261 at least two spaces before inline comment
40:28: E114 indentation is not a multiple of four (comment)
40:28: E116 unexpected indentation (comment)
41:28: E114 indentation is not a multiple of four (comment)
41:28: E116 unexpected indentation (comment)
42:28: E114 indentation is not a multiple of four (comment)
42:28: E116 unexpected indentation (comment)
56:33: E225 missing whitespace around operator
141:1: E731 do not assign a lambda expression, use a def
144: D203 1 blank line required before class docstring (found 0)
148: D401 First line should be in imperative mood ('Return', not 'Returns')
148: D400 First line should end with a period (not 's')
233: D401 First line should be in imperative mood ('Filter', not 'Filters')
244:5: E301 expected 1 blank line, found 0
244: D401 First line should be in imperative mood ('Searche', not 'Searches')
244: D400 First line should end with a period (not 's')
244: D205 1 blank line required between summary line and description (found 0)
270:9: E303 too many blank lines (2)
277:28: F821 undefined name 'CFG_SITE_LANG'
284:5: E303 too many blank lines (2)


24:1: F401 'os' imported but unused
25:1: F401 're' imported but unused
26:1: F401 'shutil' imported but unused
28:1: F401 'iteritems' imported but unused
30:1: I100 Imports statements are in the wrong order. from invenio.ext.script should be before from six


3: L102 copyright year is outdated, expected 2015 but got 2014


3: L102 copyright year is outdated, expected 2015 but got 2013


4: L102 copyright year is outdated, expected 2015 but got 2014
30:1: E402 module level import not at top of file
31:1: F401 'zlib' imported but unused
31:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be CFG_INSPIRE_SITE, CFG_OAI_ID_FIELD, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_FULLTEXT_SNIPPETS_CHARS, CFG_WEBSEARCH_FULLTEXT_SNIPPETS_GENERATOR
33:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS_CHARS' imported but unused
33:1: F401 'CFG_OAI_ID_FIELD' imported but unused
33:1: F401 'CFG_INSPIRE_SITE' imported but unused
33:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
33:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS_GENERATOR' imported but unused
33:1: E402 module level import not at top of file
34:6: E126 continuation line over-indented for hanging indent
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: I100 Imports statements are in the wrong order. from invenio.utils.text should be before from invenio.utils.url
41:1: F401 'encode_for_xml' imported but unused
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. from invenio.utils.shell should be before from invenio.utils.text
42:1: E402 module level import not at top of file
43:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.utils.shell
43:1: F401 'get_fieldvalues' imported but unused
43:1: E402 module level import not at top of file
45:1: E302 expected 2 blank lines, found 1
45: D202 No blank lines allowed after function docstring (found 1)
45: D400 First line should end with a period (not "'")
60: D210 No whitespaces allowed surrounding docstring text
60: D400 First line should end with a period (not 'g')
67:1: E302 expected 2 blank lines, found 1
67: D401 First line should be in imperative mood ('Return', not 'Returns')
67: D202 No blank lines allowed after function docstring (found 1)
67: D400 First line should end with a period (not 's')
67: D205 1 blank line required between summary line and description (found 0)
101:1: E302 expected 2 blank lines, found 1
101: D401 First line should be in imperative mood ('Return', not 'Returns')
101: D202 No blank lines allowed after function docstring (found 1)
101: D400 First line should end with a period (not 'n')
101: D205 1 blank line required between summary line and description (found 0)
112: D401 First line should be in imperative mood ('Grade', not 'Grades')
130: D401 First line should be in imperative mood ('Grade', not 'Grades')
143:47: E225 missing whitespace around operator
165: D202 No blank lines allowed after function docstring (found 1)
165: D400 First line should end with a period (not ':')
165: D205 1 blank line required between summary line and description (found 0)
212:29: E261 at least two spaces before inline comment
213:31: E261 at least two spaces before inline comment
214:31: E261 at least two spaces before inline comment
215:31: E261 at least two spaces before inline comment
218:24: E261 at least two spaces before inline comment
220:26: E261 at least two spaces before inline comment
223:22: E261 at least two spaces before inline comment
227:22: E261 at least two spaces before inline comment
232:26: E261 at least two spaces before inline comment
234:22: E261 at least two spaces before inline comment
238:22: E261 at least two spaces before inline comment
244:1: E302 expected 2 blank lines, found 1
244: D401 First line should be in imperative mood ('Return', not 'Returns')
244: D400 First line should end with a period (not 'd')
244: D205 1 blank line required between summary line and description (found 0)
313:1: E302 expected 2 blank lines, found 1
313: D400 First line should end with a period (not 'e')
313: D205 1 blank line required between summary line and description (found 0)
322: D209 Multi-line docstring closing quotes should be on a separate line
322: D400 First line should end with a period (not 'r')
322: D205 1 blank line required between summary line and description (found 0)
359: D400 First line should end with a period (not 'd')
359: D300 Use """triple double quotes""" (found '-quotes)
365: D400 First line should end with a period (not 'd')
365: D300 Use """triple double quotes""" (found '-quotes)
386: D400 First line should end with a period (not 't')
386: D205 1 blank line required between summary line and description (found 0)
435: D202 No blank lines allowed after function docstring (found 1)
435: D205 1 blank line required between summary line and description (found 0)
459: D400 First line should end with a period (not 'r')
459: D205 1 blank line required between summary line and description (found 0)
475: D210 No whitespaces allowed surrounding docstring text
475: D400 First line should end with a period (not ':')
475: D205 1 blank line required between summary line and description (found 0)
475: D208 Docstring is over-indented
485:15: E261 at least two spaces before inline comment
486:16: E261 at least two spaces before inline comment
507:55: E261 at least two spaces before inline comment
510:95: E261 at least two spaces before inline comment
519: D210 No whitespaces allowed surrounding docstring text
519: D400 First line should end with a period (not 's')
519: D205 1 blank line required between summary line and description (found 0)
519: D208 Docstring is over-indented
528:52: E225 missing whitespace around operator
535:36: E225 missing whitespace around operator


22:1: F401 'current_app' imported but unused
23:1: I201 Missing newline before sections or imports.
23:1: F401 'intbitset' imported but unused


Patch author is Danny Kirchmeier <danny@kirchmeier.us>, just committed by me.


same here


D'accord


Yes thanks, corrected in the latest commit


If attribute values are larger than the maximum size specified when the object was created, the Implementation SHALL panic. You should keep TEE_ERROR_OUT_OF_MEMORY.


It's just unreliable, as far as I know, which is why I'd prefer a different way of building it.


instead of "fix problem in open" use something like "fix parallel open with multiple devices"


@Hassan829 See http://php.net/manual/en/function.file-put-contents.php.

file_put_contents($path_to_file, $data_uri);


These maps should be concurrent, or the locking needs to be different.
Mutating methods are synchronized, but the maps are being accessed in different methods (for example chunkReaderFutures.put and chunkReaderFutures.remove)


I think this isn't the correct error message (copy paste error?). It should be 'only one _cable lift hill_ per ride'.


Use `choices` http://docs.python.jp/2/library/argparse.html#choices


And, set `required`


asdf


nice fail :)


ça je peux m'occuper du decord de ce niveau mais comment le recuperér ?


I suppose that this error is coming when running tests from simphony framework only ?


Works now, thanks


То мій rubymine криво закомітив, не додавав нові створені файли, тепер все гуд я надіюсь ;)


for in take more time to loop than the basic for (var i = 0; i< whatever.length; i++) sineced we have so many loops, I think we should go with whatever is fatsest.
https://blogs.oracle.com/greimer/entry/best_way_to_code_a


It would actually be a good idea to:
- wipe out the `auth_context` when `create_handshaker` is called.
- Assert here that `auth_context` is `NULL`.


<vragenlijstsleutel>_location ?
En dat is een kolom waar alleen de afdelingsnaam in staat? Rare naam.


ghh


Ah, duh, right.


fdfggd


Nope. I fixed that. `source` is now not mandatory.


是高亮库


最高に細かい話ですが、コメントなどの英数字は半角でお願いします。


Thanks for the clarification.


Just performed the indentation here


This is a test program for using git


その本が古いのが問題ですが、数年前からObjective-Cのリテラル値の
記述が少し変更になっており、以下のようにかけますので、この書き方も覚えておいてください。
NSArray *newArr = @[now, tomorrow, yesterday];

詳細
http://dev.classmethod.jp/smartphone/iphone/ios-modern-nsarray/


self.state it's a fresh reference to the state and will be the context of the action. If the action tries to manipulate the state asynchronously (ajax), if another update had ocurred meanwhile, it won't update the state tree because it needs a fresh reference to state.


This is a test comment for using Git


@chrisndodge I moved the JS code related to facebook into a separate file. can you please look into that.
cc: @mattdrayer
Thanks


you don't need parenthesis here


@catong I updated the string.


renamed accidently file (->repaired)


The code touches more than one hash map so a concurrent one does not help to make those operations atomic.
I will use a `synchronized(this) { }` block instead of synchronized methods to make this less confusing.


this keeps mocha re-running the tests whenever changes in the file system occur


上の3行ですが、各アクセサメソッドがプロパティとして定義されているのであれば
以下のように書くことができます。最近はこのような書き方が主流になっています。
(貸した本が古いから…)

comps.year = 1990;


`type=FileType`? http://docs.python.jp/3/library/argparse.html#filetype-objects


@sonalkr132 I think I had given a blank line. As far as i remember.
Else how could github split it into a title and a description?


You going to play with Pinos by any chance?! XD


handleAuthRequest ?


Don't like orange ? ;)


Are you referring to the case the batch was small enough to be loaded all upfront, or which drive's "feature" are you referring to?


Do we need to check that `batchsize > 0`?


I would just use execute.


This is an error case, so I'm fine with that.


Just a basic weather app


lgtm


Does it need? I feel it's a little complicated. Is is too slow without multi-threads?


hehe


And BTW, I'm fine with the fact that we reuse the security connector as long as the target_name (and overridden_target_name) stays the same (which I think is now guaranteed).


o


Considering that you do product_obj.id on the previous line, product_obj is a singleton recordset, which means that it contains only one record. I don't understand why you have to loop on it then ? You can directly write product_obj.name, I don't see why it wouldn't work, considering that product_obj.id does work. You don't need to loop so you don't need the join either, and can directly assign res['info_field']. Also, according to the Python documentation, you don't have to str() the arguments to % format, see the %s entry of https://docs.python.org/2/library/stdtypes.html#string-formatting.


Removed jquery dependencies as Moodle 2.9 natively implements jquery


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: templates/columns_definitions/column_adjust_privileges.phtml


Good catch!

As for the third case, if the old app wasn't code signed then it doesn't matter what's the state of the new, since it fails at that step and it's essentially unrecoverable.


Could this method be made to accept a file path as an argument? This way, it is not tied to a specified file and you can use a different file to handle your phrases or words for the Hangman game.


That depends whether if you have any bugs.


Do you start here all further queries at once?


Haha. That is a crazy description of the model there! Would really like to see how that look XP


Makes sense :+1:


My mistake actually. I did not see this one.


While this makes sense, probably best to only crash in debug builds, and still try to handle the error in some way in production (even if it's just a "whoops, uninstall the app" dialog).


ưqwqrqeqrqửqwrqwrqwrqwr
rưqrqrqwrqrrqrqr

qrrqrqrqrqrqwr


eqweqeqeqeqweqweqeweqweqwe
eqeqeqweeqeqweqwe
qeqweqweqeqweqwe
eqwewwqeqweqweqweqwewq
eqeqwewqewqewqeqweqweeqeweqe
qeqwewqeqeqwewqeqe
eqwewqe


Is this an obfuscated loop?


looks good!


It's a `stream`


READNE


This is a *general* comment.

The commit message could be improved by writing the message on multiple lines. For example:
```
chore(main): Code cleanup
- Define test spec that ensures generated random word is in list of words available.
```
(This was taken from Angular's Git commit message conventions [here](https://docs.google.com/document/d/1QrDFcIiPjSLDn3EL15IJygNPiHORgU1_OOAqWjiDU5Y/edit#))


Yes, but the things going on is like a loop.


用`prev(m.end())`更加安全些。


We are already pulling in the bootstrap stylesheets and js from a CDN (another server) - look at  layout.jade.

As such, we don't need any of the bootstrap files here.


Yes, the result set fetch size essentially is only a hint to drivers. E.g. H2 locally ignores it (which makes sense in a way since everything is in memory anways).

I thus think it's a good thing - as "safety net" - to check periodically whether the TX is still open, otherwise the producer will continue to emit ids which it has fetched before also if the TX has timed out since then. For most drivers it won't make a difference in practice as they fetch data periodically and will raise the TX timeout exception themselves then.


Good work removing the redundant module. :+1:


This file is unneeded. See above.


26~29行，只要 `++ m[t]` 就可以了。其他都是多余的。


A little improvement:

Could you utilize test suites to manage your tests? This will ensure you don't have to create too many files for the tests.


This file is unneeded. We are already pulling in jquery from a CDN. See above.


am  not sure i understand how this solves the problem of retrieving waste count since last stock count. I was thinking of something like

1. Get all waste count since last stock count date, the stock count used in calculating stock level.

`var dateInfo = utility.getWeekRangeByDate(new Date(countDate), reminderDay);` gives you a range and this range does not necessary imply since last stock count unless am reading it wrong.


This is a *general* comment.

You could use a `Hangman` class to manage the game.


Yes, it does, but what's wrong about that?


I would wrap it into a CompletionException.


Mine was just a random attempt, sure I'm going to set it to 960 right now. Let you know @isaak654


承知しました。以降注意して記述します。


What do you mean with "at once"? It's a loop, so the pages are queried iteratively.


@jqs7 抄就是啦www 嘛不过感觉还需要改进的样子嗯('・ω・')


The original Object.keys(obj).forEach() which i talked about is still there, you change others, it is at this link https://github.com/musamusa/move/commit/53f2febebc8812e30da0491e1b6879b15d746f7c#diff-179bbee20f79741a3ee9146d5757798dR197


The bootstrap and jquery files are not needed.

Also, the .DS_Store file is an OSX file that has nothing to do with our project  - https://en.wikipedia.org/wiki/.DS_Store

Please remove all of these things in a new commit, and push to the same branch on your origin. The new commit will automatically be added to the PR.


I am now thinking, that updating the 'arm' sources could also imply a new arm64 build, if it is a 'fall back' package.
I think I might have to write a report_sources-derived script that could simply check if any package that is used in a specific architecture's build has been updated, which would then trigger the creation of a new release.


I will, I auto-generated the try/catch and completely forgot to change it.


실수했습니다..


@jqs7 不过这一版有个小小的bug 你可以到HEAD去瞧瞧w


Can you really send 125MHz through the SCSI stuff?


IIRC this is a debugging artifact, right?


Thank you.
I will fix that.
I didn't find the list of possibilities for `stability` property.
**Where do you find the Thelia's `XSD` files ?**


make a commit


do hedersów można wpisać kilka pod ten sam klucz


When I test here, they are. Could it be that somehow these _*.css files are in an lproj folder?


撤销


The code is broken - examples are not running


Would be better to use print() and sys.exit(1) to be more consistent with the way argparse deals with command line argument problems.


```core/lib/Thelia/Module/schema```

Moreover, if your module is stable maybe you can tag it with version ```1.0``` ?


Зачем здесь использовать enumerate? idx в этой функции не используется, нельзя обойтись просто "for val in string"?


I will play with Pinos https://blogs.gnome.org/uraeus/2015/06/30/introducing-pulse-video/ http://cgit.freedesktop.org/~wtay/pinos/tree/src/modules/gst ;P


`execute` or `run` like in the transaction script pattern? http://ptgmedia.pearsoncmg.com/images/ch9_9780321127426/elementLinks/09fig01.gif


For a lot of pages you create a big list of numbers where you just could use a counter.
Also, I think it should be easier to spot that you start all requests at once.


教えて頂いた記述で修正したものを、再度commitしていきます。


"client...MUST NOT".
That'll need to move to the client-behavior doc, won't it?


why `!!` ?


saw approval from kuenishi
at https://github.com/basho/riak_cs/commit/6dffb89c22b35ae2d1379c8613e6a67004adbb98


merging basho/riak_cs/feature/add-deprecated-warning-to-old-clis = 6dffb89c into borshop-integration-1175-feature/add-deprecated-warning-to-old-clis


basho/riak_cs/feature/add-deprecated-warning-to-old-clis = 6dffb89c merged ok, testing candidate = c116e17b


I still have a problem with what you mean with "at once" :P


ack


This one is created for Venkateswari Muthukrishnan


30eb8be7b674ee1b8d53e44b7d734023d569b414 fixed.


ok, run.


sir i think u need to add space after />? just asking


aa


Would you please change this to `#if TARGET_OS_IPHONE`?

It is quite confusing but `TARGET_OS_MAC` will be `1` for building either Mac or iPhone application.
http://stackoverflow.com/questions/3181321/which-conditional-compile-to-use-to-switch-between-mac-and-iphone-specific-code
This means that `LBPushNotification.h` is not imported at all, but still the build worked OK and the tests run successfully when I tried PR too.  However, it is failing with the automatic build (I'm not sure what is causing the difference).  In any case, the intention is to import the header for iPhone, so `#if TARGET_OS_IPHONE` should be used.


让 git 忽略掉编辑器生成的配置文件啊。
你把 .idea 提交上去干嘛。。


@Okiilemon 你怎么这么二


You start async computations in a loop, one iteration does not wait for the result of the previous iteration.