what's happening here?  you're assigning the value of `entry_index` to `index`.  so in the first iteration of the loop, `entry_index == nil`, so `index` will be set as `nil`.  i'm not sure that's what you want.


Good use of jQuery event listeners. You got these down! 👍


The contract of CloseDependentDatasets() is that it can potentially be called several times, so you should clear the container after the first time. You should also return TRUE if you closed at least one dataset (i.e. you cannot only rely on the return value of GNMGenericNetwork::CloseDependentDatasets() to form the return value of the method)


rm -rf mnt.admin/foo mnt.admin.bar


For your callback function, I would either use an anonymous function or define a named function elsewhere and reference it here. The way you have it know, you declared a named function as the callback argument. This technically works but I would suggest using one of the first two methods.


# things in /foo/ are allowed
mkdir mnt.foo/foo/x
mkdir mnt.foo/foo/y

# everything else is not
expect_false mkdir mnt.foo/bar/x
expect_false mkdir mnt.foo/food


An example where `ln -nfs -T <target> <link name>` makes completely sense.


before you remove the entry, it's sometimes to good to make sure the change that you'll be testing is in the right state.  so maybe test that `book.entries.size` is 1 at this moment.

also, because you only have 1 book entry, even if the test passes, you'll only be able to confirm that the method deletes a book.  you won't be testing that it deletes the right book.


My opinion on this is, that I don't see a convincing advantage in having accumulated includes. With that argument, the STL should be ~5 huge include files that contain everything so you don't have to include as many individual headers ;)
On a more serious note, fewer includes mean a shorter include section (true), but that doesn't really improve readability imho as #includes can be easily skipped over while reading anyways - in contrast to code and comments; those require attention to detail and cannot be easily skipped without losing context.
Another reason against "include all", is compile time. Having a tight list of includes reduces compile time. This might not be a major issue depending on the size of the project, though.
How about a single include file that in turn includes the most frequently used headers? If you insist, I can of course bring back the list of include files - it's your code after all ;-)


`is_platform_windows` is a function, you missed the `()`


I would use the `eq` method here.


This is really PG specific, but not sure how to do better. Does this mean that GNMDatabaseNetwork can only be used with database drivers that have a concept of schema/namespace, and not with Spatialite, FileGDB, etc... ?


I have repushed with the changes: https://github.com/Underground78/mpc-hc/commit/9c47e0d482a4f5bede7e4af6e41102acf9d594bd.

![crash_dialog](https://cloud.githubusercontent.com/assets/371636/8625460/3a9bd4d0-273f-11e5-8a28-1eb82d3556d5.png)


ok


Didn't know this ... way shorter ^^


What is the ```identifityMapper``` is for? and why we no longer have to check for equality?


Welcome Kuldeep.


Not using `+=` correctly here. I believe what you're trying to do is set 'newCheckingMoney` to the sum of `dollarAmount` and `checkingBalance`. In that case, all you have to do is switch this `+=` to a `+` and you're good to go.

If you do want to use `+=`, you would use it like so...

`checkingBalance += dollarAmount`

...which is the same thing as...

`checkingBalance = checkingBalance + dollarAmount`


@ojacques @hanleys If you want to reformat and add new things, please send a separate PR for the formatting changes. I'll get that merged quick so the swift driver changes won't get held up.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.755.3750ffc851cbe78677e24449bfd512a284addfd8](http://build.palaso.org/viewLog.html?buildId=59627&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 369, ignored: 3 Build time: 00:02:32


Yeah, ln has many secrets, i.e., heuristics, it reveals bit by bit. I'd never ever call it a _simple_ tool ;-)


Yes it does. We're ironing out one last bug in reveal, but both work independent of order now.


Is there any site where I can download the newest build? Or is it still "derped"?


This file does not exist


I think these extension points should be in adminui module, what do others think?


Missing OGRFeature::DestroyFeature( poFeature );


This function should not deal with locking mechanism


Wouldn't these be better defined on the class? Or even better, `cID` defined on `\Concrete\Core\Controller\AbstractController` and `bID` on `\Concrete\Core\Block\BlockController`?


Залил коммит


Same as above


probably we need one for warn with and without `Throwable`


It'll be okay.


nao sei porque eu criei nun vai muda nada mais ta ae


It seemed like a roundabout way of doing things, since the sub-plugins are the ones that really interact with statscache, with the main plugin acting as a sort of a manager. I'm not saying that it necessarily needs to be changed; I was just commenting my thoughts as I went through the code and accidentally left that in :)


If the plan for using this function is to find an open port, and then binding something to it, you have a pretty obvious race condition here.


e ainda fiz o favor de mistura ingles com portugues ((e fica uma merda))


Forgot a `$` here. If you fix this plus the `+=` error I mention before, I think you'll be very close to being able to keep adding money to your checking account.

One other thing you have to consider is whether your `checkingBalance` variable is being updated after every deposit!


This is a flaky test because of the race condition explained above.


LGTM.


I'm curious about the use case here and how this interacts with the default-outcome field in the source definition. Is what you actually want here a link level default?


Yes but if there is no internet connection it wont reach that far, it will return immediately: `if (!hasConnection) return;`


Yes, but if there is no connection it won't go that far, will return immediately:
`if (!hasConnection) return;`


:+1: :zap: go get 'em!


s/point/event


wrong, i checked sniffs, 194314 spawned while sif was there


@ifermon can you open a github issue - comments on commits tend to get lost.
It's not immediately obvious if this is a kernel or firmware commit, but the vchiq change looks like the most likely candidate. Create the issue here:
https://github.com/raspberrypi/linux/issues


This was actually intentional as it suggests the contributor is cloning their own fork rather than the artsy remote.


Sorry I meant this link in the description: https://www.noip.com/integrate/request


Can you please explain why?  I'm fairly new to Minecraft modding.  Also, I have the try-catch in order to prevent deadlock with the synchronization I added. Without said synchronization, I often got a NPE as it would attempt to serialize the energy value map on the player logged in event before it was done calculating. The only other solution I can think of is to send the player a dummy energy value map and re-sync with the player when it is done calculating.

> On Jul 10, 2015, at 7:56, "IntelliSun" <notifications@github.com> wrote:
>
> Try-catch block are the worst thing in Minecraft modding, never ever put a general try-catch block, if you expect a certain exception to be thrown handle it separately, and log any other exception.
>
> —
> Reply to this email directly or view it on GitHub.
>


Once you nail down the deposit functionality, you should have no problem taking care of withdrawals. Just need to tweak the arithmetic so that money is subtracted from the account. Also make sure your `checkingBalance` variable reflects the new bank balance.


Will destruction of `std::thread` instances stored in `workers` not cause `std::terminate()` be called immediately?


Missing DestroyFeature()


I know Matthew you want to do something good, but we cannot cache this here, sorry. Index service have to collect fresh informations. Caching is required only on application runtime where could be even milions of users online at once.


We could still check for equality, and it would be equivalent to checking the context. We have to do either one, but it doesn't matter which.

There are 4 possible values for a mapper. Let's go through each one of them:

1. undefined - this means we are not doing inferential typing, but we may do contextual typing, which could cause us to assign a parameter type
2. identityMapper - means we want to avoid assigning a parameter type, whether or not we are in inferential typing (context is undefined for the identityMapper)
3. a mapper created by createInferenceMapper - we are doing inferential typing, we want to assign parameter types and fix type parameters (context is defined)
4. an instantiation mapper created by createTypeMapper or createTypeEraser - this should never be passed as the contextual mapper when checking an expression (context is undefined for these)

So isInferentialContext is detecting if we are in case 3


Looks good :+1:

> The DLL is loaded manually so I don't see why it would require relinking MPC-HC. It's possible that the project reference on the DLL is indeed causing this though.

Right. But if it's set as dependency for MPC-HC project it will trigger linking. I say we leave it as is. CrashDialog code will not be changed often anyway.

Ps. Can't reproduce on-top bug anymore, it was probably some other software that was messing it up. I will keep an eye on if it happens again.


Whenever you add a new callback, make sure to add it to add it to `source/nagaqueen/callbacks.ooc` and `source/nagaqueen/OocListener.ooc` as well :)


To revert those changes you could do:

```
git checkout master
git revert 674ec89649ef91ecfe4fa37d384e0b3d02fdc463
git push
```


s/points/events


Actually checking identityMapper would detect cases 3 and 4. I think it's more accurate to just check 3.


Check `reason` only outside the loop: it won't ever be anything but `OK` at this point.


OK, you will probably never see this comment, but (a) thanks for posting this trackball code 3 years ago which helped me get my OpenGL program going quickly, and (b) after treating it as a black box for a while, I was doing some refactoring and looked at how this routine was implemented. I had to switch from using the GLM library to Eigen (another linear algebra library) so these are not compatible with your code. Here is an equivalent version that is a bit less complicated:
```
Eigen::Vector3f trackball_t::map_to_sphere(const Eigen::Vector2f &point)
{
    float length = point.norm();
    float radius = (length > _radius) ? length + 1 : _radius;
    float x = point.x() / radius;
    float y = -point.y() / radius;
    float z = sqrtf(1 - x*x - y*y);
    return Eigen::Vector3f(x, y, z);
}
```
and here is the version I use now, not exactly equivalent, but more elegant in the way it handles points outside the trackball sphere:
```
Eigen::Vector3f trackball_t::map_to_sphere(const Eigen::Vector2f &point)
{
    float plane_offset = _radius / 2;
    Eigen::Vector3f input_on_plane(point.x(), -point.y(), plane_offset);
    return input_on_plane.normalized();
}
```
By the way, I found I needed to add a set_radius method to adjust the trackball size when the user reshapes the window.

—Craig Reynolds (cwr@red3d.com)


s/point/event


See the [zshexpn](http://linux.die.net/man/1/zshexpn) explanation for that syntax.

Interactivity is enabled for safety. I have got burned enough times from removing or overwriting files.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.756.ba3f1a94bf8a4839644c73171ac8f9d520e6f35a](http://build.palaso.org/viewLog.html?buildId=59628&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 369, ignored: 3 Build time: 00:02:43


fast-forwarding develop to borshop-integration-62-bugfix/invalid-command-error-formatting = e332c8ff


^

This made it easy to use Ionicons as pseudo-elements...


You're on a roll :star:


Workers are joinable threads, so yes, their destruction invokes std::terminates. But this happens after pool destruction, so the **terminate** flag skips waiting for the threads to finish and forces termination earlier.


Can anyone send me the .zip with a chat working ?


`reason` not checked here.


This looks very very similar to GDALDataset::CopyLayer(), perhaps with some reprojection logic added. Couldn't that be factored with the base implementation of GDALDataset::CopyLayer() ?


I do not see how is that beneficial or useful. I can imagine less convoluted ways of calling `std::terminate()`. :)


It's not a `GKeyFile` anymore; this should read `sol_conffile_load_json_from_dirs`. Please change other occurences of `keyfile` to `json` where appropriate.


poCT is never freed


Not a fan of these functions having side effects (adding things to the given list). They should instead be designed to *return* the event/datapoint from the input. Then you can a function that tells you if the input is an event or not.


Ahh that's what I wanted to do all along :) (have if-else chains be linked lists). Thanks a lot!


:metal:


without admin code change?

```php
if (class_exists('currencies')) {
```


JsDoc these functions?


Same here. JsDoc


I'm not sure we want to expose internal component codenames in public code.


Ah! I see your point now... You're right.


Let's try it :)


hpwh_residential (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1677 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


It is a pretty crude way of naming threads. I would be okay with that if it worked reliably but:
1) It fails if you name a thread before the debugger has attached.
2) It fails if you name a thread before the debugger has received the thread-started notification (race condition when naming child threads).
3) It isn't usable by profilers.

So yeah, pretty terrible. They should have added a Win32 function to do it properly about a decade ago.


Ideally, if one of these allocation fails, this function should fail somehow. The entry values will be inconsistent if one is set and the other is not, which is most likely not a good idea.


Same remark than for other class w.r.t CloseDependentDatasets() that should be able to be called safely several times


this works, but is there another iterator function that you can use that will make this easier?


Unrelated to the patch; just a reminder to add to my TODO making `sol-json` work with `sol_str_slice`. (It has been written before that existed and we forgot to fix that.)


This does not seem to be used in the class.


I would check whether the type of account id is a string or not. Since this function is called from the public API and its JS, we could potentially see non-string values.


`workUnit.getProp(ConfigurationKeys.TASK_ID_KEY)` will return `null` here if you delete the lines above.


I'll explain why with an example - say you have an application in which the client is uploading files. Now you have a method called `Send`, it reads the selected file and uploads the information, now you may expect that the user will enter a wrong path so you check for `FileNotFoundException` so you can inform the user that the information is wrong. But if you put an ambiguous `catch` you can be sure what the problem is, maybe the user does not have the required permissions? Or maybe there's a lock on the file as someone is using it.
This scenario have nothing to do with Minecraft, it's just a bad practice. You can google it for a better answer.


Similar check should be done for the `id` value


Since this function can fail, make it return either an integer (and use some value from `errno.h`), or a `bool` value. It's better to refuse to work than try to work in an inconsistent state.


Did you set a default max rating of 2500? That may piss of galacticfear with all the notifications lol.


Kool. Was about to open a pull request for the same!! Kudos!


Why? =[


Hum… same thing here… maybe I'm missing something.


в принципе, мне всё понравилось, молодец


Minor: Stray ` ` after `- 2`.


#noescape


hub: uncaught exception: Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/ryu/lib/hub.py", line 52, in _launch
    func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/ryu/topology/switches.py", line 821, in link_loop
    self.links.link_down(link)
  File "/usr/local/lib/python2.7/dist-packages/ryu/topology/switches.py", line 329, in link_down
    del self._map[link.src]
KeyError: <ryu.topology.switches.Port object at 0x7f92d4c5df10>

Do you why line (329) produces that error?


That is an excellent question, I was given access to the GitHub repo, but I cant push the releases to the Supermarket.


Most efficient protocol ever.


Yes, I think we should add a User to the Download and Upload Actions. But that affects the receptor API as a user-facing feature (and potentially breaking change, since we likely want it to be required), so it should be a separate story. Will add that soon.

Previous garden-linuxes had this user hardcoded to 'vcap' internally, so this just moves it up to the executor, like we did initially for the Privileged-to-User Garden API change. We'll have deeper problems with docker-image support, since that also hard-codes 'vcap' as the user on RunActions, and only works while garden-linux still makes the vcap user if it's absent.


I've updated the comment to include the explanation I gave below


Oops.


Please merge this! The current version crashes for me in line 11.


Perhaps `std::move(ss)`?


-1. As I said in IRC, this should (and is) being pushed upstream. No need for it here.


Returning `pv` here is not what you want: clean up what has been done and return an error code so that inconsistent state won't be allowed.


hmm well then ^^ I set this to 2800 initially (in the create game) but tatsu reduced it to 2500 :P


also warning flagged now if beam with same beam properties as previous beam loaded into GUI


Great! Maybe you could make travis fail if a contributor fails to comply ? Here is [an example](https://github.com/sonata-project/SonataAdminBundle/blob/master/.travis.yml#L56)


@yanex When do you plan to release this? I have 0.6.2-15s and it's not available yet. Is there a way to get the latest version?


Let's try again: ca2c88b90142226876e3adbfdfbd25d9f63f51d2


@Jermolene, `$:/plugins/tiddlywiki/tiddlyweb/save/offline` and it's ` $(publishFilter)$` should be mentioned somewhere as well. Thanks.


Exactly! Thats the plan :)


Unrelated to the patch, but we really need a function to stitch a path from components.


This commit should be squashed with the commit that broke the tests if possible.


Honestly just set it to 10k and forget about it for 20 years


Can you explain how `Console.WriteLine()` is doing any conversion?


Right off the bat, your ATM app works and implements all the readme's user stories. Great job!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17813/testReport/) for this commit**


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/7880/testReport/) for this commit**


Why the for loop running in parallel?


Patch looks a lot better, thanks. There are still a few things that I'd like to see fixed before getting it merged; comments have been made in the appropriate places.


(Especially since your program works) If you're not going to use all these test statements anymore, go ahead and get rid of them. Makes looking through your code a lot easier!


I was using the C# book, I wasn't sure so I added it.

Sent from my Sprint Phone.

On Jul 10, 2015 2:36 PM, Melissa Avery-Weir <notifications@github.com> wrote:
Can you explain how `Console.WriteLine()` is doing any conversion?

---
Reply to this email directly or view it on GitHub:
https://github.com/MrsCappy/Kata/commit/d201e935ee65bb3db9bc820f5cbc614e1fd0c932#commitcomment-12111508


See also silverstripe/silverstripe-userforms#271


Imagine you're using threads for jobs of unknown duration which may need to stop immediately (no cleanup required), f.e. a chat server. This flag won't be used often, but it's a small & cheap feature.


threads will now be named in top / htop / ps / ...
should not work with windows, osx i dont know (not really necessary, but nice to have)
example with linux htop (custom thread names have be enabled under setup)
![screenshot_named_threads](https://cloud.githubusercontent.com/assets/7888201/8626139/39ef9bc6-2743-11e5-9729-27e666134cff.png)


@cbeer yeah, we won't merge this;


I could stand to be incredibly wrong here, but whilst doing TDD for this, it painted a picture that if the permissions were specifically checked in this file, it would adhere, so therefore if no mention of admin was made, it would allow global edits. So when specifying Owner It would only look for owner edits and leave admin alone effectively.


这是段落。

这是段落。

这是段落。

段落由p标签定义。


Is the options vector guaranteed to be `NULL` terminated?


## This is a markdown file


Y U remove this?


Prefer the W variant of this function, for Windows Phone support.


Thats great.  What was the key?


So based on [this gist](http://pastie.org/10285001) with that the browserified+uglified bundle size is 6kb gzipped compared to 5kb gzipped for es5-shim

```bash
browserify --plugin bundle-collapser/plugin -o bundle.js test.js
```
``bash
uglifyjs -m -c "warnings=false" -o min.js bundle.js
```


Fresh


is this suppose to be the same?


Hey @arunthirupathi,

The change looks fine, but can you fix the formatting before merging it in? It seems like your IDE inserted a bunch of tabs instead of spaces like we usually do elsewhere in the codebase. GitHub looks pretty messed up like that...

Thanks!

-F


No test? :-1:


"I wasn't sure so I added it" -- usually a sign that the code isn't what you need. The reason for the katas is to work through understanding what the solution is and how to solve it. Adding code that you don't understand won't help.

Can you explain what `Console.WriteLine()` does? (Google can help if you still don't know.)


Addressing some of the issues with #43


swallowing even


The C# book, same as earlier. I thought it would loop over the element. I'll research for a different loop.

Sent from my Sprint Phone.

On Jul 10, 2015 2:36 PM, Melissa Avery-Weir <notifications@github.com> wrote:
Why the for loop running in parallel?

---
Reply to this email directly or view it on GitHub:
https://github.com/MrsCappy/Kata/commit/d201e935ee65bb3db9bc820f5cbc614e1fd0c932#commitcomment-12111522


onUse(player ... ?


В данном случае (когда запрос возвращает не более 1 строки) правильнее было бы обойтись без цикла:
```php
$maxOrder = 4;
if ($results->count()) {
    $maxOrder = $results->current()['max'];
}
```


This is a link


I'm ok with leaving it for now. Can we actually reliably change it whille goroutines are running (go routine still in the background and we reset GOMAXPROCS)?


93469234-DemandResponse2 (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1693 of 1693 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


hpwh_residential (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1167 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.91%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.79%25-green.svg)


There's an example of a for loop in the `main()` method. There were also examples in the `String.Join()` and `String.Split()` code we looked at in that C# book.


Wouldn't `kErrorAccessDenied` make more sense?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.333](http://teamcity.monogame.net/viewLog.html?buildId=8633&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@jtrmal: looks like my user id not mapping between SF and GitHub user in your import script.. `kkm` on SourceForge  -> `kkm000` on GitHub. If you are rather using the e-mail, that can be `kkm@pobox.com` or `kkm@smartaction.com`.


Changed to text(). Now works on both chrome and webOS.


Does `%#x` not work?


you don't see a hidden intention behind it?


I think `lpBaseOfDll` is pointer-sized. You should cast to unsigned long long and change the format specifier to `%llx`.


Oh, please. Always `.toLowerCase()`


Are you able to trace where that substring `lib/udisks2` comes from? I can't see any relevant reference neither in the udisks resulting binary package nor in nixpkgs.


Тут нужно поправить форматирование, чтобы было проще читать цепочку вызовов:
```php
$where->equalTo('id_timetable', $timetableId)
      ->AND
      ->nest()
          ->equalTo('weeknum', $weeknum)->OR->isNull('weeknum')
      ->unnest();
```


engine_cart 0.7.0 should fix this.


i cant... i need to dash..


This filter can be removed. Except that commit looks ok.


Similar comment as before. `ExceptionAddress` is pointer-sized, I think.


Со вложенностью if-ов перебор :)


Good point :D


<html>
<body>
<img src="/i/eg_w3school.gif" width="300" height="120">
</body>
</html>


Sure will do.

Thanks,
Arun.

On Fri, Jul 10, 2015 at 11:40 AM, Felix GV <notifications@github.com> wrote:

> Hey @arunthirupathi <https://github.com/arunthirupathi>,
>
> The change looks fine, but can you fix the formatting before merging it
> in? It seems like your IDE inserted a bunch of tabs instead of spaces like
> we usually do elsewhere in the codebase. GitHub looks pretty messed up like
> that...
>
> Thanks!
>
> -F
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arunthirupathi/voldemort/commit/d70ed85e51620620b7ad2f21ca71f5e3537d01e8#commitcomment-12111626>
> .
>


because spec searching should be case sensitive. fuzzy results are case insensitive so you get the best of both worlds


Usually the codes are written in hex. `STATUS_ACCESS_VIOLATION` is `0xC0000005`, for example.


Лишний комментарий. Следует избегать однострочных комментариев, описывающих очевидные вещи.
По имени созданного класса `new Where()` и так понятно, что тут создаётся WHERE часть запроса


it is now done in the fuzzySearch function.


Переменная `$sql` уже получена выше, её не нужно создавать для каждого запроса.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17814/testReport/) for this commit**


Здесь достаточно просто комментария с примером запроса, который будет создан, остальное лишнее:
```php
// SELECT `id_event` AS `id` FROM `events` WHERE `id_timetable` = ? AND (`weeknum` = ? or `weeknum` IS NULL)
```


This should be a `final` field, not `volatile`. `final` makes the field immutable as long as the object it references is immutable, and `volatile` disables cache values and forces the jvm to read from memory each time.  Since we're only ever setting it in the constructor, we should use `final`.


why track currWorkspace as a variable, and also getCurrentAccountWorkspace()? Why not just put getCurrentAccountWorkspace's logic in this variables's set method?


Has anybody worked on adding support for max31850?


variable used


method used


Lines 339-343 were already changed upstream.


Emailed Mike to see how we can reconcile this difference
https://github.com/openstack/api-site/blob/master/api-ref/src/wadls/orchestration-api/src/v1/orchestration-api.wadl#L799


> [If the *dwFreeType* parameter is **MEM_RELEASE**, *dwSize* must be 0 (zero). The function frees the entire region that is reserved in the initial allocation call to **VirtualAllocEx**.](https://msdn.microsoft.com/en-us/library/windows/desktop/aa366894%28v=vs.85%29.aspx)

`s/size/0/`


I pushed back on another contribution a couple days ago for having one-off query appending logic – could you find something in a library for this? Perhaps in http-types?


Accidental commit? ;)


I would like to avoid plugin stuff, because it will make pain for other developers and to make it multiplatform. Plugins have to be recompiled for every platform and installed in the system (to have it available in Qt Designer). That's why I have stayed with promoted widgets which are easy to use.


Yes, I agree. My problem was to determine the accessibility of those properties: public or protected?


should AutomationRunbookManager only be used in ISEClient? I think this UI controller just talks to ISEClient?


bubi


Text search should almost never be case-sensitive (look at your browser's ctrl+f behavior).


learn to use git please. seeing 'added all files' makes me sad :(


ohoho;


Would it make more sense to start maintaining a NixOS github fork of systemd, which is now maintained in github, since that they are no longer providing release tarballs? (http://lists.freedesktop.org/archives/systemd-devel/2015-July/033485.html)

That way we don't have these massively changing patches in our nixpkgs tree and we can just use fetchFromGitHub to pull down a tarball of all of the changes at once.


"I wasn't sure so I added it" -- usually a sign that the code isn't what you need. The reason for the katas is to work through understanding what the solution is and how to solve it. Adding code that you don't understand won't help. => excellent point

Can you explain what Console.WriteLine() does? (Google can help if you still don't know.) =>
This will simply output a blank line to the Console window. This is an elegant way to output an empty line. You do not have to specify the
newline character.
In my own words it reminds me gets.chomp in javascript.

Sent from my Sprint Phone.

On Jul 10, 2015 2:41 PM, Melissa Avery-Weir <notifications@github.com> wrote:
"I wasn't sure so I added it" -- usually a sign that the code isn't what you need. The reason for the katas is to work through understanding what the solution is and how to solve it. Adding code that you don't understand won't help.

Can you explain what `Console.WriteLine()` does? (Google can help if you still don't know.)

---
Reply to this email directly or view it on GitHub:
https://github.com/MrsCappy/Kata/commit/d201e935ee65bb3db9bc820f5cbc614e1fd0c932#commitcomment-12111633


You repeat this CSS modifier code a number of times in your application. In the spirit of keeping things dry, maybe you could encapsulate this into a function...


Done.


I pretty much just left the method because it was already there, I didn't really think about it. It would make sense to move it into the property's set method, I'll do that.


same


Believe it or not, I had this bug in mind when I made that suggestion. I had tried to submit a patch for you, but my Java is not what it should be


@paulofaria Anko 0.6.3 is available now! :) https://github.com/JetBrains/anko/releases/tag/v0.6.3


^ Read: s/almost//


oops, meant to use the property instead.


I have this:
kkm = Kirill Katsnelson <kirill.katsnelson@smartaction.com>

I can change it for the future commits. I cannot do anything with the
commits already done -- but you could claim the
kirill.katsnelson@smartaction.com e-mail to get the commits attributed to
you in the github stats
y.

On Fri, Jul 10, 2015 at 2:44 PM, Kirill Katsnelson <notifications@github.com
> wrote:

> @jtrmal <https://github.com/jtrmal>: looks like my user id not mapping
> between SF and GitHub user in your import script.. kkm on SourceForge ->
> kkm000 on GitHub. If you are rather using the e-mail, that can be
> kkm@pobox.com or kkm@smartaction.com.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/1cb64585ef597d78b6e9f04ed4cd01369966682d#commitcomment-12111701>
> .
>


There's a race condition here, the last deque item could get taken by another thread, and your add could fail on the next line.  Try branching on the `.add()` function instead, it will return whether the add was successful or not.

```
if(this.operationQueue.add(operation)){ logger.debug("cool beans");
```


can you explain this comment?


> Перед и **после** объявления пространства имён НЕОБХОДИМО оставлять одну пустую строку.
https://github.com/27cm/beta/blob/develop/CONTRIBUTING.md#php-code-style-namespaces


static


I think you're mixing languages. `gets.chomp` is from Ruby, and it does the opposite: it consumes user input from the console.

So if `Console.WriteLine()` is for output (which we also talked about last Sunday), is that what you need?


Glad to see you are finding time for this!


With this and https://github.com/ZdrowyGosciu/kernel_d802/commit/51934244c5c5135024e5ec70754d67ebaba28af2 I don't have dmesg SPAM :tada: ;)
Not getting any problems with DT2W :ok_hand:
But "does it improve" - can't confirm. I have downgraded it because of non stop i2c dmesg's.


Can a more detailed explanation of the problem be provided so that the root cause might be fixed?


Yeah. Actually `fixes.patch` is generated by diffing https://github.com/edolstra/systemd/ against the baseline, but we could just fetch that repository directly. And we can move that repository to the NixOS organization.


Approved


I'm not 100% sure what I think on this, it's a tricky one. Nevertheless I've [bumped the thread](http://talk.commonmark.org/t/requiring-a-blank-line-between-a-paragraph-and-list/657/20?u=jack_douglas) (and made a possibly-impractical suggestion for getting the best of both worlds).


hpwh_residential (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1677 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


can we use JSON.Net serializer? Otherwise the file looks ugly and isn't easily modifable in a text editor.


Нужно найтия ряды - это тег tr
Ряды преебрать в цикле foreach
Из рядов достать ячейки с текстом
Достать максимум возможной инфы фамилии имена телефон почту.


perhaps move this to appui so it's reusable


Yes, sounds good.


sorry, meant for this to be on the serialize line, not deserialize


`O_CLOEXEC` won't work on the generic linux nightly buildbots, we'll have to find the right flag to fake it in


Glad to see your feeling comfortable with jQuery. Also showing a lot of progress on the concepts you had trouble with on tic-tac-toe. Keep it up! 👍👍👍👍👍


this works fine


Should this be in Constants.cs?


Does coreapps add any extensions to this point? (If so, presumably it should be here. If not, I agree about moving them to adminui.)


Cool thanks. I got in the habit of condensing the Main method.

Sent from my Sprint Phone.

On Jul 10, 2015 2:43 PM, Melissa Avery-Weir <notifications@github.com> wrote:
There's an example of a for loop in the `main()` method. There were also examples in the `String.Join()` and `String.Split()` code we looked at in that C# book.

---
Reply to this email directly or view it on GitHub:
https://github.com/MrsCappy/Kata/commit/d201e935ee65bb3db9bc820f5cbc614e1fd0c932#commitcomment-12111684


> Открывающую фигурную скобку (методов и функций) НЕОБХОДИМО располагать на отдельной строке
https://github.com/27cm/beta/blob/develop/CONTRIBUTING.md#php-code-style-methods


move this all to a separate scss file. :-)


Thanks. Updated.


There is already a method call that initializes all these to false. We should do one or the other but not both.


in terms of is enabled,that is


check whether king is in check has to be done before board is changed - i.e. king does not end in check but starts in check


why remove this?


话说Qt Creator如何调用NDK自带的-lz。。。


Подпись иконки, в которой экранированы специальные символы HTML ~~атрибутов~~.


@jtrmal: There will be never a perfect interoperation between programs doing binary I/O in pipes, given the abominable Windows EOL arpeggio. There are some things to live with. As someone who used `SY:[1,54]TKB` to link executables--or, rather, _build tasks_--I am rather happy we have _only_ two OSes do deal with ([the bad news are](http://www.jwz.org/doc/worse-is-better.html) these two are Unix and Windows, but that's the topic for a whole another rant).

@danpovey: Thank for doing a second eye-over my changes. Really appreciate. I collected all changes into 2 PRs on GitHub, so you can view either as raw diffs

https://github.com/kkm000/kaldi/pull/1.diff and https://github.com/kkm000/kaldi/pull/2.diff

or side by side.

https://github.com/kkm000/kaldi/pull/1/files and https://github.com/kkm000/kaldi/pull/2/files

The latter view is very convenient for line by line comments in patches.

>  if you install cygwin as 64 bit I think it uses a different location e.g. c:\cygdrive64. Is this a problem?

No, no paths are hardcoded. The only hardcoded string is the prefix to the unix root path used to "mount" Windows drives in Cygwin: `c:\` is seen as `/cygdrive/c/` and so on. This prefix is same in either 32 and 64 cygwin, and, although can be changed in config, I have yet to see one who would.


@sbotman PR [created](https://github.com/schubergphilis/nagios/pull/406)


Is the L & R and L2 & R2 right here? It seems they are swapped. The L2 and R2 (LT and RT) should be analog axis, instead of digital buttons:

```
input_l_btn = "4"
input_r_btn = "5"
input_l2_axis = "+2"
input_r2_axis = "+5"
```
```
input_l_btn_label = "LB"
input_r_btn_label = "RB"
input_l2_axis_label = "LT"
input_r2_axis_label = "RT"
```


OK, we should absolutely avoid plugins.
but shouldnt this code work out of the box and make the fields in qtdesigner editable?
am i missing something, or would we need to make some qt foo to enable this?
if its the foo, then we better stick to what it was...


ok, this was just one example, its used in other places too


It's not added all files, it's adding the main files. This program actually is based on one of my older projects, PyMessenger so I didn't really have to code that much for it.


Do we really need a constructor like this?


There's uv__cloexec, which we could probably use.


@pweil- can you help me formulate a sane router upgrade path or point me to anything you have on the topic? I couldn't find anything


yeah, I noticed that. I'll do a more thorough scrub when I fix this.


Because I haven't implemented it yet :) I am leaving buttons disabled until I implement them.


`Signal.never` is actually [allowed to deallocate immediately](https://github.com/ReactiveCocoa/ReactiveCocoa/blob/72854649533c4df644a896df7070a0cb835f8d60/ReactiveCocoaTests/Swift/SignalSpec.swift#L35), but this doesn't impact its semantics, since it will still never send an event.


Removed.


Collaboration page can be found on `http://192.168.50.50:8000/collaborate/`


Unfortunately this code will work only with plugins. Qt Designer doesn't read header files for promoted widgets.


@cbeer :clap: :fireworks:


Ok, I'll move the disabling into the xaml.cs constructor


You're right...gets.chomp is Ruby. My bad.

I thought it was part of what the loop was putting out.

Sent from my Sprint Phone.

On Jul 10, 2015 2:55 PM, Melissa Avery-Weir <notifications@github.com> wrote:
I think you're mixing languages. `gets.chomp` is from Ruby, and it does the opposite: it consumes user input from the console.

So if `Console.WriteLine()` is for output (which we also talked about last Sunday), is that what you need?

---
Reply to this email directly or view it on GitHub:
https://github.com/MrsCappy/Kata/commit/d201e935ee65bb3db9bc820f5cbc614e1fd0c932#commitcomment-12111978


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.333](http://teamcity.monogame.net/viewLog.html?buildId=8633&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:23:22


You might have forgotten this one! http://i.imgur.com/wBaZLdL.png


Hey. I know you want batch/bash-like scripting, but if you want, ive written a crappy batch interpreter with scripting support in C++. It might give you some ideas if you want it. kookerus/batch-interpreter


argh, is there no `brew -q` or somesuch? - reducing output by piping output away is not very elegant.


Yeah, should have left a comment, I am planning to make that change.


Can't we delete TC here?


the parsing is temporary anyway. it's a hack


may want to just comment it out instead of delete so we remember to put it back later


Right, that's what I wrote in the comments. It's no longer supposed to be removed, per the change in the .java code further down here... However, part of this commit had to be rolled back, but the `build.xml` was not. That's the current problem due to #3359 and #3360.


typo


See! No longer removed. But unfortunately, this isn't the code that's currently in the appbundler.jar that we're including. So we'll have to add those earlier lines back to build.xml.


We probably should yes.


My claim is when you define a `comment.*` scope you cannot use the `decreaseIndentRegex` any more, because it will be skipped right here. I used this technique [here](https://github.com/4ourbit/language-ledger/blob/master/settings/language-ledger.cson#L107) before, but my indentation tests started to fail after this change was introduced. It's not a big issue to fix this individual settings file. What I am trying to say it's a bit unexpected that within certain scopes some indentation regexp will not apply. Maybe I am missing something?


Hi! I've committed only the MatchStick-related changes here: https://github.com/ConnectSDK/Connect-SDK-iOS/tree/feature/matchstick_support, based on this commit.


Not positive I understand the rational for the name change, but everything else looks ok.

Also I recommend formatting your git commits with a short (<72 character title) and if necessary a blank line with a descriptive paragraph underneath.  See http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html for a discussion of why formatting them this way works well with git tools (including GitHub).


C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_29 1 2
Process started >>>
A = 1, B = 2.
The sum of all integers from A to B inclusive: 4

C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_30 2 3
Process started >>>
A = 2, B = 3.
The product of all integers from A to B inclusive: 12

C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_32 2 3
Process started >>>
A = 2.0, N = 3.
Line: 1.0 -2.0 4.0 -8.0 16.0  <<< Ну и чему это равно? В задании написано - найти значение выражения....

C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_37 7
Process started >>>
False!                                      <<< А должно быть True...

Всё остальное - хорошо


true, any word on a proper api?


Can we have a source for this???


this is to avoid the dashboard layer depending on itself during the dashboard scaling.


hey! Just curious, did you see a performance bump once you had made these changes?


This change went into master. Stable releases are cut from the 1.2.x tree.


In the copyright, instead of

+// Copyright 2015 Smart Action Company LLC

you might want to do

+// Copyright 2015 Smart Action Company LLC (author: Kirill Katsnelson).

In the top-level COPYING file it's explained that the (author: XXX) is
just informational.

I am going to check in a change to the COPYING to make that slightly
clearer.  But it's your choice how you do this.

The patch looks good so would be OK to commit as far as I am
concerned, assuming you have checked things.

Dan

On Fri, Jul 10, 2015 at 12:00 PM, Kirill Katsnelson <
notifications@github.com> wrote:

> @jtrmal <https://github.com/jtrmal>: There will be never a perfect
> interoperation between programs doing binary I/O in pipes, given the
> abominable Windows EOL arpeggio. There are some things to live with. As
> someone who used SY:[1,54]TKB to link executables--or, rather, *build
> tasks*--I am rather happy we have *only* two OSes do deal with (the bad
> news are <http://www.jwz.org/doc/worse-is-better.html> these two are Unix
> and Windows, but that's the topic for a whole another rant).
>
> @danpovey <https://github.com/danpovey>: Thank for doing a second
> eye-over my changes. Really appreciate. I collected all changes into 2 PRs
> on GitHub, so you can view either as raw diffs
>
> https://github.com/kkm000/kaldi/pull/1.diff and
> https://github.com/kkm000/kaldi/pull/2.diff
>
> or side by side.
>
> https://github.com/kkm000/kaldi/pull/1/files and
> https://github.com/kkm000/kaldi/pull/2/files
>
> The latter view is very convenient for line by line comments in patches.
>
> if you install cygwin as 64 bit I think it uses a different location e.g.
> c:\cygdrive64. Is this a problem?
>
> No, no paths are hardcoded. The only hardcoded string is the prefix to the
> unix root path used to "mount" Windows drives in Cygwin: c:\ is seen as
> /cygdrive/c/ and so on. This prefix is same in either 32 and 64 cygwin,
> and, although can be changed in config, I have yet to see one who would.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12112079>
> .
>


Please use do…end here.


ParseError happens only if the programmer supplied an invalid suite string.
DataInputError happens only if the programmer supplied datainput that did not match the suite. in both cases i would argue. that these are exceptional cases (programmer error, either by supplying outright wrong stuff or by not checking user supplied input).


Shouldn't the constants that are relevant only to a particular class be located in that class? Like you did with AutomationAuthoringItem?


selections from dropdowns are already valid dates, so checking again is unnecessary...is there a particular bug that this is addressing?


@nerandell it turns out that the way to do this is to use a policy to switch the loop in asyncio itself, so the api doesn't change. hence you should remove self._loop and use asyncio.get_event_loop


hahha still works which is odd :)

want to do a pr to fix?


Can we get this merged back through a pull request?


C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_29 1 2
Process started >>>
A = 1, B = 2.
The sum of all integers from A to B inclusive: 4

C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_30 2 3
Process started >>>
A = 2, B = 3.
The product of all integers from A to B inclusive: 12

C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_32 2 3
Process started >>>
A = 2.0, N = 3.
Line: 1.0 -2.0 4.0 -8.0 16.0 <<< Ну и чему это равно? В задании написано - найти значение выражения....

C:\Program Files\Java\jdk1.8.0_05\bin\java Ex_37 7
Process started >>>
False! <<< А должно быть True...

Всё остальное - хорошо


This will be an exact-match AND of all search terms provided as query-param arguments. I think this will be much too limited; in practice we often pass a JSON-format string in PARAM1.


haven't asked sheeo yet, but mabe he reads this.. ;)
On Jul 10, 2015 21:11, "Cheyan Setayesh" <notifications@github.com> wrote:

> true, any word on a proper api?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/micheljung/downlords-faf-client/commit/b602d5d2267ab5d6946b8d057d2b2fa5f8cc5966#commitcomment-12112261>
> .
>


In which cases does it return a single item? That sounds wrong - either a bug or a Ruby-1.8-ism where an array with one element can evaluate as that one element.


Now]t uiframework?


Ok, sorry missed this line. Thanks for pointing me to the changes. So the idea would be to use the build.xml  workaround temporarily, at least for a11, until the other issues with the appbundler are solved, right?


(minor, code style)
if (expr) ss << "message"
It looks weird to split after "ss". I would rather move "ss" to new line, so that "if (expr)" is on the first line, and the rest is on the second.


I agree: passing an array by pointer rather than returning an element and adding to the array looks strange.


There is a `msgs_labels` helper method that returns these values.


extra semicolon


From the code changes, you can see that there was an existing  extension point but it didn't work as we want since it displays big icons and didn't support grouping


Well, I was using those as enums. The problem is that some of these here are already in Constants.cs, like LocalAssets.json and SecureLocalAssets.json. We don't want to duplicate.

I think Constants.cs makes sense for things used in multiple places, I guess we could remove some from Constants.cs and reference them here instead, and update the other code to reference them here. But shouldn't have them in two places.


Lets not, lol


nice.


You probably made a typo.


I kind of implied, but to be explicit - LocalAssets.json and SecureLocalAssets.json strings are used by LocalAssetStore.cs as well


This documentation is strange.  Remove it?


Oh what a nice touch for documenting what the `Bool` does :)


Reuse LoadMessage() code:

#include <artm/core/helpers.h>
DictionaryConfig config;
BatchHelpers::LoadMessage(args.file_name(), &config);


Sehr gut!
On 10 Jul 2015 21:00, "Tomas Rehak" <notifications@github.com> wrote:

> check whether king is in check has to be done before board is changed -
> i.e. king does not end in check but starts in check
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trehak1/chess/commit/0b3c23bad134bd9525b7ded5053b7d6c0e5b52ce#commitcomment-12112070>
> .
>


I was getting some errors when selecting the date from the popup. Changed
this to _parse but will push when I get home l. TBH, I didn't spend a lot
of time grokking the code so a code review is probably a good idea.

On Saturday, July 11, 2015, Jason Quense <notifications@github.com> wrote:

> selections from dropdowns are already valid dates, so checking again is
> unnecessary...is there a particular bug that this is addressing?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/aleemb/react-widgets/commit/8ee69590ea6b0a8f531a323ea2300400778e5565#commitcomment-12112302>
> .
>

--
Aleem


Couldn't a dataset have multiple FileSets with absolute paths?
In that case, you don't want to return as soon as you find the first one, right?


Yes, as currently implemented: 1) if the account workspace already exists, but the assets files do not, then they won't get downloaded when the user logs in. 2) If the account workspace and the assets files already exist && the user has not modified them && updates to the assets have been made in the cloud, then we should sync those updates to the assets files on login.


Just do

```
return &JsonEvent {
 EventType: event.eventType,
 ...
}
```


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.757.10c2d4635ff93f107105a9a623202b4d665e972e](http://build.palaso.org/viewLog.html?buildId=59631&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 370, ignored: 3 Build time: 00:02:37


Check err before you append buffer


@gsfr, looks like your .gitconfig was on the server that I pushed this from. Sorry about that.


execute 'Helpers::Validate(dictionary_config)' once you parsed the message


“teared down” → “torn down”.


could also just ifdef out that line


Oh, I didn't realize they were used elsewhere and were already in Constants.cs. I will take another look and probably move them into Constants.cs since they're getting used in multiple places.


BTW, I might just be really confused, but are the changes against the most
current HEAD? It seems to me I see changes (especially w.r.t cuda
compilation) fixing things that have been already resolved by me?
Other than that, looks good.

On Fri, Jul 10, 2015 at 3:12 PM, danpovey <notifications@github.com> wrote:

> In the copyright, instead of
>
> +// Copyright 2015 Smart Action Company LLC
>
> you might want to do
>
> +// Copyright 2015 Smart Action Company LLC (author: Kirill Katsnelson).
>
> In the top-level COPYING file it's explained that the (author: XXX) is
> just informational.
>
> I am going to check in a change to the COPYING to make that slightly
> clearer. But it's your choice how you do this.
>
> The patch looks good so would be OK to commit as far as I am
> concerned, assuming you have checked things.
>
> Dan
>
>
>
> On Fri, Jul 10, 2015 at 12:00 PM, Kirill Katsnelson <
> notifications@github.com> wrote:
>
> > @jtrmal <https://github.com/jtrmal>: There will be never a perfect
> > interoperation between programs doing binary I/O in pipes, given the
> > abominable Windows EOL arpeggio. There are some things to live with. As
> > someone who used SY:[1,54]TKB to link executables--or, rather, *build
> > tasks*--I am rather happy we have *only* two OSes do deal with (the bad
> > news are <http://www.jwz.org/doc/worse-is-better.html> these two are
> Unix
> > and Windows, but that's the topic for a whole another rant).
> >
> > @danpovey <https://github.com/danpovey>: Thank for doing a second
> > eye-over my changes. Really appreciate. I collected all changes into 2
> PRs
> > on GitHub, so you can view either as raw diffs
> >
> > https://github.com/kkm000/kaldi/pull/1.diff and
> > https://github.com/kkm000/kaldi/pull/2.diff
> >
> > or side by side.
> >
> > https://github.com/kkm000/kaldi/pull/1/files and
> > https://github.com/kkm000/kaldi/pull/2/files
> >
> > The latter view is very convenient for line by line comments in patches.
> >
> > if you install cygwin as 64 bit I think it uses a different location e.g.
> > c:\cygdrive64. Is this a problem?
> >
> > No, no paths are hardcoded. The only hardcoded string is the prefix to
> the
> > unix root path used to "mount" Windows drives in Cygwin: c:\ is seen as
> > /cygdrive/c/ and so on. This prefix is same in either 32 and 64 cygwin,
> > and, although can be changed in config, I have yet to see one who would.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12112079
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12112279>
> .
>


lol


It'd be nice to put these in UIConstants.


C:\Program Files\Java\jdk1.8.0_05\bin\java OlgaG28 9 3
Process started >>>
Zodiac is Aries <<< А должны быть - Рыбы...

result+=Math.pow(i,2); - А кто разрешал использовать Math.pow() ? :)

А в остальном - мне очень всё понравилось, молодец


godep copies test files even though they are never run.  We can remove godep when we use go 1.5


Also, I think it would be cool to add hiding the nematic of the player in the next version bump


You probably don't need to make this a function. i.e. class var Insets: UIEdgeInsets { // stuff } should work?


I've fixed the context issue and some bootstrapping problems in my current version.
https://github.com/trautonen/logback-ext/commit/8a3d6827683e3507b23bf8106cf88ae71fc9d3b7
https://github.com/trautonen/logback-ext/commit/3abc5ffed059e7cdb70d093eea031d3a65dc13b1


I know, but sometimes APIs need a real port not zero and since we usually reuse the port after asking for it in practice this has never been an issue.


installed PhalconPHP
Enabled mod_rewrite
set Allow Override to All

still gives me 404 ;-(


Missing call to ->GetRules() here


Should we maybe log the exception at least? Otherwise LGTM.


I don't mind writing pure CSS, and I'm not too big a fan of preprocessors anyway.


Confused, what's this module about? Assembly or something?


if we have multi os now, we can move this script back to linux


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.758.1ca3031ce01fdc2a30582af57aee35f30a4cd53c](http://build.palaso.org/viewLog.html?buildId=59632&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 370, ignored: 3 Build time: 00:02:40


![focus-loss](https://cloud.githubusercontent.com/assets/8161919/8627244/ffc2bd46-2749-11e5-8cd2-b886e07a7c71.png)

Unfortunatly I couldn't determine which element triggers these events, so I deleted them all :dancers:
Please deal with my selfish decision :cat2:


Here's the change


I don't think so. I think it makes sense to separate out the logic for the various kinds of resources to multiple classes, and let the controller directly use whichever ones are necessary. Why hide all of them behind the ISEClient class? I initially only meant the ISEClient to keep track of 1) authentication stuff and 2) user session stuff (current account, workspace, etc.). We may have to sync on this one offline if you have concerns.


Thanks!  I come from C, so I'm not super familiar with the do's and don't's specific to Java.  Also, what would you recommend to prevent server hang in the event that an exception is thrown?


It's a new version. You can lock to 0.1.x on projects you don't wish to upgrade yet. We're upgrading the app to latest System.js, and I've already upgraded the seed project.


Wouldn't that mean that we have to read the database of QuoteCategories everytime we load a quote? What do we need a the whole data type for anyways?


I summarized things a little better here: https://gist.github.com/whitlockjc/28b49ddc7558adbea77b  Like I said there, I could be fixing something that doesn't matter.  I need to look at that bundle-collapser/plugin...maybe that's what I was missing.


Nice! Love how you changed the CSS using a class name. Keeps all those confusing color codes in your .css file.


Slow down there, cowboy.


Arquivo do Nova.conf


This file is in the wrong place.  You have successfully merged the copy that I moved for you.
So, please delete this improperly named version of the translations.


Hey Andrew, we were looking at your fork and we couldn't remember why this fix was needed.  Do you remember why we needed this fix at Interactive?


:scream:


I think either works but right now we do it both places, so one of us should move :).

Do we know if WPF controls can be used by VS add ons? If not, right place is probably automation ise client, since we wouldn't be able to reuse WPF and want to port this to VS as well. (I assume our UI is WPF, I don't know much about WPF)


This doesn't look right to me.  This flat-out rejects IPv6 or IB GID addresses.


Fair, though this is probably a one off style (maybe that doesn't matter?)

Happy to move them though.


They could be, the rationale behind removing this label for v0.12.7 is that previous OpenSSL upgrades haven't been labeled as such, and I thought that v0.12.6 was labeled critical because it affected more users, not only users who where doing certificates verification. This reasoning is probably broken though.

Anyway, it seems that instead of only labeling the _current_ release, we could maybe mention what the latest release with a critical security fix is. For instance, let's say v0.12.8 is released without any security fix in it, should we remove this label, or just say: "The latest release that we consider safe to use is v0.12.7".?

A lot of users also don't upgrade to latest, but might be interested in upgrading to the latest "safe" release.


Ok, good to know. Important part is that it's not cached (we need accurate insets based on orientation)


New value is written only every 50ms, filter is applied each loop time..


4973_heatpump_defrost_bug (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1682 of 1682 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Зачем везде написал [Reqired]?


Привет - всё хорошо, молодец, замечаний нет


So you added a space?  Whats the point?


> hahha still works which is odd :)

The function reference evaluates to True, so if-clause condition is never met even on non Windows platforms.

> want to do a pr to fix?

I working on #10151, I will include the fix there...


Зачем перезатираешь значения, введенные пользователем, старыми значениями из сессии?


Great job handling withdrawals/deposits!

If you decide to revisit this assignment and make the code a bit more DRY, think about how you could handle all deposits -- whether they're checking or savings -- using a single function. Definitely a bonus but would make your code short and clean!


I got this crash, ended up having to reflash.

starting hotplug handler
[Timer] Record RecordTimerEntry(name=Saathiya, begin=Fri Jul 10 18:57:00 2015, serviceref=1:0:1:CB8C:8FD:2:11A0000:0:0:0:, justplay=0, isAutoTimer=1)
EXCEPTION IN PYTHON STARTUP CODE:
------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/enigma2/python/mytest.py", line 660, in <module>
    runScreenTest()
  File "/usr/lib/enigma2/python/mytest.py", line 469, in runScreenTest
    nav = Navigation(config.misc.isNextRecordTimerAfterEventActionAuto.value, config.misc.isNextPowerTimerAfterEventActionAuto.value)
  File "/usr/lib/enigma2/python/Navigation.py", line 38, in __init__
  File "/usr/lib/enigma2/python/RecordTimer.py", line 749, in __init__
  File "/usr/lib/enigma2/python/RecordTimer.py", line 829, in loadTimer
  File "/usr/lib/enigma2/python/RecordTimer.py", line 953, in record
  File "/usr/lib/enigma2/python/timer.py", line 200, in addTimerEntry
  File "/usr/lib/enigma2/python/timer.py", line 239, in calcNextActivation
  File "/usr/lib/enigma2/python/timer.py", line 309, in processActivation
  File "/usr/lib/enigma2/python/RecordTimer.py", line 762, in doActivate
  File "/usr/lib/enigma2/python/RecordTimer.py", line 287, in activate
NameError: global name 'debug' is not defined
------------------------------------------------------------
<   116.417902> [MAIN] (exit code 5)
]]>
		</enigma2crashlog>
	</crashlogs>


TeamCity LabkeyRelease15.2 :: CDS postgres 9.4 [Build 5](https://teamcity.labkey.org/viewLog.html?buildId=260260&buildTypeId=LabkeyRelease152_CdsPostgres93) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:34:13


4973_heatpump_defrost_bug (nmerket) - i386-Windows-7-VisualStudio-12: OK (1682 of 1682 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ну я решила раз не запрещено, то разрешено:)))
Я переделаю без math.pow тогда:)))

пятница, 10 июля 2015 г. пользователь brus-fabrika написал:

> C:\Program Files\Java\jdk1.8.0_05\bin\java OlgaG28 9 3
> Process started >>>
> Zodiac is Aries <<< А должны быть - Рыбы...
>
> result+=Math.pow(i,2); - А кто разрешал использовать Math.pow() ? :)
>
> А в остальном - мне очень всё понравилось, молодец
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OlgaGrygoryan/homework/commit/e786f662407b7c1f4167dacb08ff65ba053a5a2f#commitcomment-12112471>
> .
>


Good call encapsulating the CSS changes in a single function.


Зачем отдельно хранишь в БД общую сумму заказа? Как будешь поддерживать ее соответствие сумме элементов заказа?


Even using the collapse plugin, file sizes are marginally better:

```
 44K	    browser/json-refs-min.js
 60K	    browser/json-refs-standalone-min.js
408K    browser/json-refs-standalone.js
284K    browser/json-refs.js
```


4973_heatpump_defrost_bug (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Thanks, and I'll claim this e-mail too. Do not know how it gets into our mail system.


accidently saved over this


I thought it would be more aesthetically pleasing


Hmmm, projectGeneratorSimple/bin/projectGeneratorSimple_debug should have been caught by gitignore -  was that not the case?


You don't need curly braces for ifs/elses. Can you remove these?


It would be better to have two spaces.

—
Sent from Mailbox

On Fri, Jul 10, 2015 at 12:35 PM, wh1pch81n <notifications@github.com>
wrote:

> I thought it would be more aesthetically pleasing
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wh1pch81n/FoolsGold/commit/dd502301552fc0239a099b5d8c369ed3a3033e22#commitcomment-12112712


Почему бы не использовать здесь AutoMapper?


This looks great man. Your JS skills have gotten a lot better since tic-tac-toe. Keep up the good work. Let me know if you have any further questions about this assignment.


Ok

—
Sent from Mailbox

On Fri, Jul 10, 2015 at 12:36 PM, NoWritingNoLife
<notifications@github.com> wrote:

> It would be better to have two spaces.
> —
> Sent from Mailbox
> On Fri, Jul 10, 2015 at 12:35 PM, wh1pch81n <notifications@github.com>
> wrote:
>> I thought it would be more aesthetically pleasing
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/wh1pch81n/FoolsGold/commit/dd502301552fc0239a099b5d8c369ed3a3033e22#commitcomment-12112712
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wh1pch81n/FoolsGold/commit/dd502301552fc0239a099b5d8c369ed3a3033e22#commitcomment-12112725


ah i see, it's the PG repo ^^ - yeah, the gitignore should be adapted to exclude the /bin folder contents...


Thanks man! Feels good to be back... :muscle:


Well if an exception if thrown either you catch it or app is going to crush. You should always release locks on a finally block, that way, regardless of what happens, we don't have a deadlock.


Зачем вынес эти 2 метода из контроллера в отдельный класс?


EpgTimer側の変更は次のコミット
EpgTimerNW側のini設定を排除 78aa8693c13653da3bc6749b2f9295b22fdd8420


quality code.


Adam, I really like your cryptic commit msgs every now and then :P


@jiwalker, I understand why it might have been confusing to implement this at first because you have to operate on an array of arrays of arrays (time series collection-> a time series' data->[x,y]). If you have any suggestions for improving the TimeSeries* classes' APIs I'd love to hear them. Mary and I are hoping to improve the interfaces.


:+1: perfect!


Will leak panMap


@arturoc I don't know if that makes sense to you, but maybe we should run the PG compile in the OF build job? It has OF as a dependency (right?), is already pulled into the build repo by Travis, and we could skip one OF compilation, since that would already be compiled from the compile_OF build step - so that would save time.


This caused only one modtype to be averaged. Multiple modtypes are common, so flattening the array out with the TimeSeriesCollection's getDataMerged() method did the trick.


Please feel free to improve/clean this code!
* It is slow, especially the grid.garnish part.
* I would like multiline tooltips, but "\n" and "<br \>" didn't work (at least, in R studio).


If I remember correctly, numbers were coerced into strings and then the binary representation was incorrect. Something along those lines at least. Do you know Austin Kelleher? It’s funny you emailed me, because 45 minutes ago I got an email from that guy about forking my fork.

> On Jul 10, 2015, at 3:29 PM, Matt Lavin <notifications@github.com> wrote:
>
> Hey Andrew, we were looking at your fork and we couldn't remember why this fix was needed. Do you remember why we needed this fix at Interactive?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/cava23/node-avro-io/commit/262653cf0a7f2a20e7222b52a7588525116c6fd7#commitcomment-12112600>.
>


Не уверен, но мне кажется, эта инициализация не отличается от значений по умолчанию (null). Что дает присваивание пустых строк?


Where is @event coming from here? You should be creating an event, assigning it's name (params[:event_name]), and assigning it's application, then saving it.


on the other hand, we would build the PG on every OF build - this may be unnecessarily often. should we only build it on every change of the PG, not OF, or is it critically dependent on stuff within OF?


no need to change the function prototype.


Obj-C code from Apple.SE: http://apple.stackexchange.com/a/123738/16016


@jtrmal No, it's not against the current HEAD, few weeks old. I'll be careful not to step on your fixed, of course. Thanks for the heads up.


You should be able to simplify this to `getProperty` call which allows a default value;

`repoFolderName = System.getProperty(ARTIFACT_BASE_CONFIG_PROPERTY, ConfigParser.parse().getString(ARTIFACT_BASE_CONFIG_PROPERTY));`


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 129](https://teamcity.labkey.org/viewLog.html?buildId=260255&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **SUCCESS**
Summary: Tests passed: 25 Build time: 00:33:57


instead of passing in cpp_std as a param, extract it here
char* cpp_std = getopt_get_string(lcmgen->gopt, "cpp-std");


Lazy loading deveria ser:

if (null === $this->request) {
    $this->request = new Request();
}

return $this->request;

(Instanciar a request somente se já não tiver uma injetada)


@kookerus - I meant to have scripting based on the terminal commands like how bash is terminal commands and batch command prompt commands. But I will look at it and see if I it will help me implement it. I can't do any kind of scripting right now anyway because I can't access files.


javadoc exceeds 120 char margin


Library.ParseCollection deserialize the dictionary into Python. This is slow... and unnecesary. I suggest to remove the following lines:

        dictionary_blob = ctypes.create_string_buffer(length)
        HandleErrorCode(self.lib_, self.lib_.ArtmCopyRequestResult(length, dictionary_blob))

        dictionary = messages_pb2.DictionaryConfig()
        dictionary.ParseFromString(dictionary_blob)
        return dictionary

And I think this is OK that ParseCollection stops returning the DictionaryConfig.

Note that current method is ArtmRequestParseCollection. I suggest to create a new one --- ArtmParseCollection, which does not return any dictionaries. Later (in v0.8.0) we will delete ArtmRequestParseCollection.


slip


`if` выше проверяет была ли "BACKEND_MEDIA_FOUNDATION" опция указана, но ты вывел декларацию этой опции после ее использования. Опцию нужно декларировать до ее использования, как это было до твоего изменения.

В оригинале всегда выводился "Media Foundation backend..." и потом уже либо "...ENABLED", либо "...DISABLED", но с твоим изменением оно будет "...DISABLED" без названия модуля выводить.

`if (BACKEND_DIRECT_SHOW)` выше повторяет все эти ошибки.


(usually means i didn't press `C-x` hard enough)


missing space


Suggest autogenerating a comment here to assist folks who don't immediately know to use the --cpp-std=c++11 flag.  e.g.,:

emit(2, "// If you're using C++11 and are getting compiler errors saying things like");
emit(2, "// ‘constexpr’ needed for in-class initialization of static data member");
emit(2, "// then re-run lcm-gen with '--cpp-std=c++11' to generate code that is");
emit(2, "// compliant with C++11");


Any reason for reversing these changes?


remove


preproccessors are love. preproccesors are life.


no need to make this change, see above


Sorry, it was my mistake when merging. I am fixing it now.


I don't quite like adding an extra parameter "load_dictionary" to this method. This is probably not a big deal because we are going to remove this method soon anyway... However, I think the cleaner solution is to keep this method as it is, and just stop using it in all of our examples. Switch them to use Library.ParseCollection.


Этот тэг означает цитату (!!!), зачем в него обернул таблицу?


I think you have to try this commit again, I see only deletions.
Best thing you can do, is:
git add *
git commit -a --amend     (that will add those changes into this last commit)
git push --force      (which will force that new updated commit to replace this one)


27 line me Script Tag hta
ar baki response thk lag rha he ab to


Sorry, I intended to do a PR but it seems I committed this change directly. It fixes execution of basicat:

```
sudo ./snabb snsh apps/basicnat/main.lua apps/packet_filter/samples/v4.pcap /tmp/output.pcap
145.254.160.237 10.10.10.2link report:
                  43 sent on basicnat_app.output -> output_file.input (loss rate: 0%)
                  43 sent on capture.output -> basicnat_app.input (loss rate: 0%)
```

It seems it's necessary to guard the processing packet code which a check that link.input is not empty or the link.out is not full, because it happens that sometimes link.input is empty and not packet is processed. I think a guard with and if at the beginning should work, but this is how all other Snabb apps do.

I was also having a strange number as a result before and it happened to be the value of ```external_ip``` being printed in main.lua. I also increased the level of verbosity (to see how many packets were processed and written to the new file).


Doh!  I forgot about the finally block.  (Like I said, not used to Java).


simple test for castling


shouldn't this be !=  ?


yeah, seems to be working fine. Thanks, guys, and sorry for the noise


Or wait... it did change the files, but not the filenames??? how is that possible???


Check whether enemy pawn does not endanger fields that must not be endangered in order for castling to be valid.


How about 'forceSameCount' instead of 'filterNum'? Also do we want to hang onto filterNum as a decrepit parameter or just switch?


ok


I still get an issue when using Poppler 0.31.0+:

```
/tmp/pdf2htmlex20150710-20032-80yn83/pdf2htmlEX-0.13.6/3rdparty/poppler/git/CairoFontEngine.cc:424:45: error: cannot initialize a parameter of type 'PSOutputDev *' with an rvalue of type 'bool'
  if (!(fontLoc = gfxFont->locateFont(xref, gFalse))) {
                                            ^~~~~~
/usr/local/Cellar/poppler/0.34.0/include/poppler/goo/gtypes.h:36:16: note: expanded from macro 'gFalse'
#define gFalse false
               ^~~~~
/usr/local/Cellar/poppler/0.34.0/include/poppler/GfxFont.h:244:51: note: passing argument to parameter 'ps' here
  GfxFontLoc *locateFont(XRef *xref, PSOutputDev *ps);
                                                  ^
1 error generated.
```

Maybe you need to update `3rdparty/poppler/git`?


Just noticed that the "The" after "passed," should be lower case.


Remove extra parenthesis, `_groupTypeCountArray select _forEachIndex select 0` does the same thing.


Same error as made in arm64:

I think you have to try this commit again, I see only deletions.
Best thing you can do, is:
git add *
git commit -a --amend (that will add those changes into this last commit)
git push --force (which will force that new updated commit to replace this one)


nit: enought -> enough (and again at line 66)


There isn't something like "versioned Recommends" in Debian i.e. dpkg and apt. There is only "Recommends + versioned Breaks":
Recommends: scummvm
Breaks: scummvm (<< 1.8.0)


Remove extra parenthesis, `str count _count` does the same thing. Also needs space if you would have used it as `str (count _count)`.


Remove extra parenthesis, `str count ([] call ...)` does the same thing. Also needs space if you would have used it as `str (count ([] call ...))`.


RIP in peace memory


Nevermind, it seems like its usage is just like as if the return value were a boolean (the returned value isn't being used, but simply compared with null).


Yeah, I think the multiple modtypes weren't supported when I added this, it is definitely a smell that I was doing the 0th one, thereby assuming a singular array.


Ahh Very nice.  That works then.  I was curious. ^^  And yes, full composer support and on packagist as well now ^^  You are welcome for the code!  Glad it has provided good use for you. =]


I see that ParseCollection lacks the "batches_found == 0" part. I think its OK to copy it into all of our examples as follows:

if not glob.glob(target_folder + "/*.batch"):
   Library.ParseCollection(docword=..., vocab=..., target_folder=...)

And Library.ParseCollection needs to became more user-friendly:
 def ParseCollection(self, collection_parser_config = None, docword = None, vocab = None, target_folder = None):


@mattyx14 yes, I did not start coding the Lua part yet


I'm not sure that has a lot of value once the message has been decoded. I
can see it being useful while you're still looking at the bit stream and
could try correcting the error, after that it reduces to being a simple
flag that this message is probably correct or that message is probably
damaged...

On Fri, Jul 10, 2015 at 6:26 AM, Wolfgang Nagele <notifications@github.com>
wrote:

> How about simply adding the parity result in the response message? In case
> somebody wants to use that actual result instead of the good/bad
> information?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ckuethe/gr-adsb/commit/f4a3d03207295154d512a0c2cf5935cbbeb6f947#commitcomment-12105750>
> .
>

--
GDB has a 'break' feature; why doesn't it have 'fix' too?


Merci pour cette première contribution.


chi shod?


great, but now its give warnings on gcc :/

src/Engine/OpenGL.cpp:300:43: warning: the address of 'OpenXcom::glCreateProgram' will always evaluate as 'true' [-Waddress]

This mean that you don't check for value but for address of value that always is not 0.


(in this and in other examples) use artm.library.Library().ParseCollection(...)


Yeah, that's ok. We were all doing stuff like that at the beginning. Any suggestions on what to improve?


:heart:


uiframework doesn't know about appframework. appui is the module that pulls the two together.


@dukesrg patches.h is generated during compilation and I'll add it to .gitignore and make clean.


I mean: were there any _extensions_ for this point in the coreapps module? Or did it just define an empty extension point?

If it defined an empty extension point, I agree that we should move it to the adminui module.


У тебя не передаются количества товаров на сервер по 2 причинам:
1. Инпуты с количеством не находятся внутри формы
2. Для них генерируются неправильные имена. Нужно указывать поле модели через параметр m, примерно так

'''@Html.TextBoxFor(m => m.Items[i].Count)

т.е. цикл должен быть for, а не foreach, чтобы можно было отрендерить индекс элемента в имени поля.


The comment suggests that this should not have been a long term solution.  I think the goal at one point was to do some fancy averaging (excluding censored data, etc) that would be stored for each station and constituent to get the long term average.  This might still be something to go into a service, but if this works then I think the way you changed it is fine.


There's a simiar issue down where we try to pop an item off the queue, we should be using `poll` instead of checking the size and `pop`.


wierd. that RETI is generated by the toolchain...
But yeah perhaps they have something bizare. Perhaps the logic should be changed, or made optional. It's too bad it's very nice to be able to trace what the CPU is doing when in handlers and such...


A non-approved user is not suppose to be found or manipulated by the system.


@alicetragedy O Laura, I am sorry to bother you again. I never looked at the photo credits, and especially the funny team photo was a lot of photoshop work done ALL by Roos. Is it possible to change the name of the photographer to Roos de Bildt? Can I do it myself?


Looks well :+1:


Background
---
I am working on system security and evaluating our system running under openssl-fips lib. As known that, in the fips build of openssl, MD5 is deprecated, so marco **OPENSSL_NO_MD5** is defined.
Issue
---
We are trying to use libssh under fips mode which disabling MD5, but I find once OPENSSL_NO_MD5 is defined, there comes a compiling error:
``` shell
/bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H   -I../include -I../src   -g -O2 -MT hostkey.lo -MD -MP -MF .deps/hostkey.Tpo -c -o hostkey.lo hostkey.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I../include -I../src -g -O2 -MT hostkey.lo -MD -MP -MF .deps/hostkey.Tpo -c hostkey.c  -fPIC -DPIC -o .libs/hostkey.o
hostkey.c:240:5: error: \u2018MD5_DIGEST_LENGTH\u2019 undeclared here (not in a function)
     MD5_DIGEST_LENGTH,
     ^
```
**MD5_DIGEST_LENGTH** is not defined here, so I just put the definition if **OPENSSL_NO_MD5** is defined and the compile passes.


So the background will always be a solid color with optional border? I was thinking a 9 slice plus the arrow.


Two methods doing the same thing?


Please remove.


Laravel / Symphony actually uses to dictate AJAX requests.

     /**
     * Returns true if the request is a XMLHttpRequest.
     *
     * It works if your JavaScript library sets an X-Requested-With HTTP header.
     * It is known to work with common JavaScript frameworks:
     *
     * @link http://en.wikipedia.org/wiki/List_of_Ajax_frameworks#JavaScript
     *
     * @return bool true if the request is an XMLHttpRequest, false otherwise
     *
     * @api
     */
    public function isXmlHttpRequest()
    {
        return 'XMLHttpRequest' == $this->headers->get('X-Requested-With');
    }


Paramters :)


destroy済みのeditorがconstructorに渡された場合に解放されません。


Same thing... please find a way to refactor.  :)


Seems to be defined in Audacious's makefiles from here

https://github.com/audacious-media-player/audacious/blob/3ad7887cf24d29fa6f32fcbadce36a80def27ee2/acinclude.m4


Insert space before opening curly brace.


@smo-key It's like this for serialization reasons in MonkeyUtil. It works fine how it is.


Make abstract.


Convert to
```javascript
methodName(args) {
  ...
}
```


Same comment as _getRef


Looks good.


Seems fine too.


I'd forgotten that it was Jump for a few days before MathProg


@smo-key It's a class with static methods... Why exactly do we need it abstract?


I think the creating logic of `requires` should be separated as a function like `_get_requires_from_file(f)`, which returns `requires`.


So it looks like we can't write-on-the-fly, but only after all instructions are created.  That's fine - we'll have to integrate with the FIRST / LASA Robotics App (should we decide to go that route).


TeamCity Gensokyo Lobby :: Lobster Server [Build 5](http://pixelated.design/build/viewLog.html?buildId=20&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:05


@dreammaker @jminardi this sped up slicing a bit for me.


To prevent instantiation.  I'm trying to avoid giving the user any loopholes.  :)


Please update the ```setState``` call so that the contents appear on multiple lines.
```javascript
this.setState({
  zDepth: ...,
  hovered: ...,
});
```


Yeah Jilp -> Jump -> MathProg -> JuMP I think? haha


Space pad the single entry to remain consistent with the rest of this file.


我使用的IMac编译。
$ make
g++ -c -std=c++0x -g -O3 -Wall -Wextra -pedantic -fPIC lexer.cpp -o lexer.o
cc1plus: error: unrecognized command line option "-std=c++0x"
make: *** [lexer.o] Error 1

gcc version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00)


Yay!  Hashtable!  :+1:


@nitrobin yes, it fails to compile to C++


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.6](http://pixelated.design/build/viewLog.html?buildId=21&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 40 Build time: 00:00:13


试试下面的测试代码：
```
import bs4
import urllib2

def __get_blog__(txt):
    soup = bs4.BeautifulSoup(txt)
    post_string = __get_post__(soup, '')
    return post_string

def __get_post__( post_html, str):
    for post_child in post_html.descendants:
        if post_child.string and type(post_child) == bs4.element.NavigableString:
            str += post_child.string

        elif post_child.string and type(post_child) == bs4.element.Tag:
            if post_child.name == 'a':
                str += "<" + post_child['href'] + ">" + '\n '

        elif not post_child.string:
            str += __get_post__(post_child, str)
            if post_child.name == 'img':
                str += post_child['src'] + '\n '

    return str

txt = `"<p>[1] <a href=\"http://isocpp.org/wiki/faq/ctors#static-init-order\">http://isocpp.org/wiki/faq/ctors#static-init-order</a><br />[2] <a href=\"https://gcc.gnu.org/onlinedocs/libstdc++/manual/io.html#std.io.objects\">https://gcc.gnu.org/onlinedocs/libstdc++/manual/io.html#std.io.objects</a><br />[3] <a href=\"https://gcc.gnu.org/onlinedocs/libstdc++/libstdc++-html-USERS-3.4/ios__init_8cc-source.html\">https://gcc.gnu.org/onlinedocs/libstdc++/libstdc++-html-USERS-3.4/ios__init_8cc-source.html</a><br />[4] <a href=\"https://social.msdn.microsoft.com/Forums/vstudio/en-US/637a4c27-3e30-4b88-b36d-b5b720cf0d04/why-are-cout-cin-initialized-once-and-only-once-given-the-scheme-below-in-the-iostream?forum=vclanguage\">https://social.msdn.microsoft.com/Forums/vstudio/en-US/637a4c27-3e30-4b88-b36d-b5b720cf0d04/why-are-cout-cin-initialized-once-and-only-once-given-the-scheme-below-in-the-iostream?forum=vclanguage</a><br />[5] <a href=\"http://www.petebecker.com/js/js199905.html\">http://www.petebecker.com/js/js199905.html</a><br />[6] <a href=\"http://blogs.msdn.com/b/ce_base/archive/2008/06/02/dynamic-initialization-of-variables.aspx\">http://blogs.msdn.com/b/ce_base/archive/2008/06/02/dynamic-initialization-of-variables.aspx</a><br />[7] <a href=\"http://cs.brown.edu/people/jwicks/libstdc++/html_user/globals__io_8cc-source.html\">http://cs.brown.edu/people/jwicks/libstdc++/html_user/globals__io_8cc-source.html</a></p>"`

print __get_blog__(txt)
```


OK. It was only needed by some testing code added in commit e9c14a0 and is removed in 6dd52f1 along with the code that used it. I can try to rewrite the commit history to get rid of this if you don't want it in the commit history.

I was a bit confused by the style for getters and setters, since Google's [style guide](https://google-styleguide.googlecode.com/svn/trunk/cppguide.html) and the [Chromium style guide](http://www.chromium.org/developers/coding-style#TOC-Inline-functions) both say to use lowercase_and_underscores() for them, but I see the GetUppercaseVariable() style used regularly too. I'll use uppercase in Ozone-Wayland from now on.


Nope, that's handled in foods/index. This is all boilerplate headers.


The reason is unclear for me. It could be error in hxcpp.


It's indeed used later.


As I said the previous review, don't access to class member variable directly. Create a function to set it.


Remove this hard code.


多个mapreduce工作的时候，前一reduce的输出是上一个map的输入，reduce的输出value不是Text类型时，应该用SequenceFileInput(output)Format.class,一个reduce对应多个mapper输入时，应用 MultipleInputs。这个核心就是用共现矩阵的i列向量乘上用户向量的第i个元素


Rawr...  How does git in windows work?  does it open vi as well or is it another text editor?


what is this??


It should just be a one line to get the formatting right for the whole file.  See "Pretty Printing" on https://docs.python.org/2/library/json.html.


Please rename to treeViewExplorer


I see that all definitions are placed at the top of the block. These two new are defined in the middle. Just wanted to bring that to your attention.


yes. em know and i am planning implement it today.


How about if we create a constructor has 2 parameter Path and parent node?


Actually I removed it in 5e3e97f, one commit later than I should have. I rewrote the commit history a fair bit to try to keep it clean, but some things slipped through. :)


Why do clear here?


Please rename to treeViewFilter


ok a. It's only use to test


This has caused a whole zoo of unit test errors. I haven't done a visual inspection yet of the mismatches, but I suspect this has shifted a number of markers by a few samples.


TeamCity DNN JavaScript Libraries :: CI [Build 30](http://teamcity.engagesoftware.com/viewLog.html?buildId=298&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 30](http://teamcity.engagesoftware.com/viewLog.html?buildId=298&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:6


TeamCity DNN JavaScript Libraries :: CI [Build 31](http://teamcity.engagesoftware.com/viewLog.html?buildId=299&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 31](http://teamcity.engagesoftware.com/viewLog.html?buildId=299&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:7


Please don't do this. The logic and GUI is mixed here.


And this was removed intentionally, right?


I don't see the use of iNode here.


I really don't like this Subfunction class here.


Ok, good. I started to do this in the first place but wasn't sure which was more obvious for a simple example.


Looks good to me. If you have the access to a linux box, please try to
apply patch, there and recompile and re-run texts to see if it's still
working.
As far as I can judge everything looks reasonable, but we do not want to be
surprised.
If you don;t have linux, I can try it tomorrow noon-ish.
If Dan will approve, you can commit -- but please test the linux
compilation and tests first.

BTW,  by any chance is there a way how to make the ios::binary flag default
on win?
y.

On Thu, Jul 9, 2015 at 9:53 PM, Kirill Katsnelson <notifications@github.com>
wrote:

> @jtrmal <https://github.com/jtrmal>, @danpovey
> <https://github.com/danpovey>: I added the KALDI_CYGWIN_COMPAT macro as
> you proposed. PTAL. Since we started this discussion on GitHub under a
> commit, w/o creating a PR, I cannot add a commit under this. I opened
> kkm000#1 <https://github.com/kkm000/kaldi/pull/1> with both commits
> listed. The post-discussion changes only are in kkm000@c026c89
> <https://github.com/kkm000/kaldi/commit/c026c89>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12097269>
> .
>


I'm having a bit of trouble understanding this. Are you piping vi commands to the editor? That seems pretty fragile.

Might be better to set the editor to a custom process controlled by ungit instead (e.g. another instance of node which does the editing, then exits) by setting the `GIT_EDITOR` variable. Or, better yet, use `git diff` with `git apply --cached`.


I was just thinking of getting a bare-bones version up and running first before I started messing with 9-slices. It should be simple enough to add them later.


ok a. I will check it.


ok


Este en un hack-fix para quitar el espacio en blanco después del footer


Any reason you didn't just have the configuration default those variables to current uid/gid?  Removing the bits there pulls out the prefix bits (incomplete admittedly)- if you just do the config/settings route, you get what you want w/out having to dig prefix out


This was changed in the old file (not in tree directory) on the iter_refactor branch.
Are there other changes we made on the iter_refactor branch that are un-made by this merge?  How can we check?


I regretted writing this almost immediately, but it's hard to think of a better way to handle it!

The call to `WaylandDataDevice::OnDataOffer` is guaranteed to be followed by either `WaylandDataDevice::OnEnter` or `WaylandDataDevice::OnSelection`. They both have code to adopt the ownership. For example, in `WaylandDataDevice::OnEnter`:

```
self->drag_offer_.reset(static_cast<WaylandDataOffer*>(
    wl_data_offer_get_user_data(id)));
```

The `WaylandDataOffer` allocated in `WaylandDataOffer::OnDataOffer` was assigned as the user data of the `wl_data_offer` by the constructor `WaylandDataOffer::WaylandDataOffer`, and it's now adopted by `drag_offer_`, a `scoped_ptr`.

Problems with this approach:

* It's confusing.
* If the compositor is broken and fails to send the required enter or selection event, then the memory is leaked.

One possible solution would be to add a third member variable to keep track of the `wl_data_offer` between the call to `WaylandDataDevice::OnDataOffer` and the subsequent `WaylandDataDevice::OnEnter` or `WaylandDataDevice::OnSelection`. I think that's a bit messier than the current solution, though.

Note that there are two separate data offers: the drag offer and the selection offer, with independent lifetimes. (The drag offer is valid during a DnD session; the selection offer is valid whenever there is data on the clipboard.)


OK, I'll rename it in a separate pull request.


Yeah, the logic in these two functions did the same thing but 'evolved' differently, I don't think it's necessary for the replacement.


Right now Main-Italic is using cmti10's glyphs for `\imath` and `\jmath` which are in italics so that's good.  The skew for these is `0.0`, but it should probably be `0.02778` so that the accents are in the right place.  I think this can be fixed by getting Main-Italic to use cmmi10's glyphs for `\imath` and `\jmath` instead.


I would suggest a comment like "ProjectMemberDAO.hasProjectRole".


OK, thanks for showing me how this should be done.


TeamCity Gensokyo Lobby :: Lobster Server [Build 7](http://pixelated.design/build/viewLog.html?buildId=22&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **FAILURE**
Summary: Exit code 14 (new) Build time: 00:00:05


OK


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.8](http://pixelated.design/build/viewLog.html?buildId=23&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 40 Build time: 00:00:10


Why do this?


Are you aiming for "business key equality" in the sense used by the Hibernate docs?  If so, it might be worth putting that in the javadoc.


Can/What if `peer_addr()` fails to unwrap?


It's pretty much always best to specify the encoding for `String.getBytes()`, even if it's just to keep the habit for when it does matter.  Actually, I think it might be safer to pass the value parameter to this method as bytes.


It' really better with a constructor.


Um you need mixer paths for non legacy alsa

See here

http://review.cyanogenmod.org/#/c/87846/


Good catch, I'll move them for consistency.


Having these extra debug statements might come in if people try adding more fonts.  Thanks for adding them in.


This only seems to be running through HMAC once, not twice.


I tried. If you can make it work, PRs welcome.


So, in the case of at least a few of these, all that has happened is that the trailing edge of the gating pulse is extended a bit. This would make sense if the physical channel had a non-zero gate min width parameter. But, that doesn't appear to be the case. So, I'm not yet sure what is going on.


You don't need to update rtts_assert to .30 as well?


Thanks. Fixed.


What is `serverPath`, and how is it different from url?  The name doesn't really clarify.  Is it a complete URL, and could we pass it around as a URL object?


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.9](http://pixelated.design/build/viewLog.html?buildId=25&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 40 Build time: 00:00:10


temp fix until hw-cookbooks/route53#67

I'm watching https://github.com/hw-cookbooks/route53 to get notified when it's updated. I'll revert this when that happens.


Btw don't mind me asking but what app do you use to get notifications and
have them stored?

On Fri, Jul 10, 2015 at 12:01 AM, Shuaib Hussain <10shuaib@gmail.com> wrote:

> Hey mate,
>
> Thanks a ton! I really appreciate the reply!
>
> On Thu, Jul 9, 2015 at 8:59 AM, Ullrich Schäfer <notifications@github.com>
> wrote:
>
>> I wasn't planning to. It's been a long time since I worked on this the
>> last time. Also I haven't been using much Growl myself since upgrading to
>> Yosemite.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/stigi/MountainGrowl/commit/2b956165685acc4c8d70c9096f7578fb04594f86#commitcomment-12076361>
>> .
>>
>
>


I have a powerful linux box, where I do most of actual kaldi experimentation. Indeed, I'll run pre-commit tests.

> BTW, by any chance is there a way how to make the ios::binary flag default on win?

Probably not in a compiler-independent way. Here's a leftover from my initial porting efforts (great minds think alike, uh? :-) ):

A library conains just one file:
```c
#include <fcntl.h>
#include <io.h>
#include <stdio.h>

static int initbinstdio(void) {
  _setmode(_fileno(stdin), _O_BINARY);
  _setmode(_fileno(stdout), _O_BINARY);
  return 0;
}

#pragma section(".CRT$XIU", long, read)
__declspec(allocate(".CRT$XIU"))
int (*binmode_stdio)(void) = initbinstdio;
```

`.CRT$XIU` is one of "magic" section names; these sections contain pointers to initialization function, and these functions are called quite early by `crt0`. Any binary compiled with this library and force-referencing the `_binmode_stdio` will have its stdin and stdout open in binary mode. Not sure if it will set `cin` and `cout` to binary mode, but I have a hunch it will.

I thought about compiling OpenFST with this trick, as the fst* programs are often used in scripts with pipes.

I do not know if the Intel C compiler honors these special sections. It is also likely, as they went quite far in making their compiler pretty much a drop-in replacement for the Microsoft one.


I tried importing the library with the browser globals method but I kept getting an error.  I will try installing with npm.  I fixed the issue though: `className={"alert" + " " + this.props.bsStyle + " " + "alert-dismissible"}`


Maybe it's just better to `client.write()` all the strings instead of building/mutating a big string. Also we may need to create a wrapper function around `write` that makes sure all the bytes are written and doesn't ignore the return value (this is a standard thing to do in sockets with C code).


それは、`@editor` が Destroyed Editor の reference 持っているからです？
`@editor = null` としない限り、開放されない。この理解であってますかね？


Ah, cool, I forgot about that. I'll fix it.

Sent from my mobile phone.
On Jul 9, 2015 8:40 PM, "Isuru Fernando" <notifications@github.com> wrote:

> raises is already there in symengine.utilities
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/certik/symengine/commit/4b8f2944cc687a500c684a4cc84eb50003dba2ea#commitcomment-12097158>
> .
>


ロープの長さを適切に変更する

コメントを入れた例を作りたかったから書いただけなので無視してよい


We should probably not continue if `length` is not big enough for later code


Why do this?


長さはどれくらいにすればいいでしょうね。


@lynnaloo  Technically, I _think_ they are still Particle "Spark Core" and "Photon" devices. i.e. "Spark Core" is now that particular device's name, even though overall company name has changed. See repo description here (among other places on their website) as reference: https://github.com/spark/firmware

I might change this first line to be "... for Particle's Spark Core and Photon devices..."

Still somewhat confusing, but technically correct.


This looks wrong, I'm pretty sure the JavaScript won't be trigger with this escaped.
It's inconsistent with the other test pages, is this problem unique to this PR or does it have something to do with JSTL / godmode now?


rax retry tests


should be `#status`


should be "includes status"