In my experience maintaining C glue is too much of a pain in the ass unless it does something truly impossible in Rust (e.g. accessing bit fields of a struct).

Speaking of how things are done in Rust, it would be more Rusty to isolate the client from all the ffi details and raw pointers. Imagine a trait
```rust
pub trait Metric {
    fn has_params(&self) -> bool; // not sure how best to handle this
    fn process(&mut self, request: AgentRequest) -> Result<AgentResult, ()>;
}
```
(`AgentRequest` and `AgentResponse` encapsulating any unsafe operations) and the `rust-zbx` library expecting `dummy` to export a single function
```rust
extern "rust" fn init() -> Vec<(String, Box<Metric>)> { ... }
```
`init` would create the metrics and return pairs of (key, metric) that would from that point on be managed by `rust-zbx` (e.g. a `HashMap` indexed by `key`).


Can we change it so it will be easier and less files?


I highly recommend using sets instead of lists for anything related group IDs and user partitions.


@gregra81 yes


The `@details` should not be necessary. The first sentence is the digest and the remaining ones are the details anyway unless the comment is arranged into a different order (which we don't do).


Physical width and height of the tile sprites, not the abstract pre-transformed tile sprite


sorry, commit message should have said that only the man pages have been modified.


sunny days the watercolor painting


funny egg!


Hello


It looks like, 'deleted' Boolean is never used.


Batch size of how many documents will be pulled


When building for lm32:
 LD       bios.elf
../../software/libbase/crt0-lm32.o: In function `_crt0':
(.text+0x108): undefined reference to `_gp'
../../software/libbase/crt0-lm32.o: In function `_crt0':
(.text+0x10c): undefined reference to `_gp'
Makefile:19: recipe for target 'bios.elf' failed


原来不止我遇到这个编译问题。。hhhhh


Fixed.


I'd move the staff check to the top of the function, because if the user is staff then you don't need to do any computations.


As I said yesterday, I think this method should be a member function of SSubscription instead of CHTSPDemuxer as it massively operates on data of the subscription - do you see all the m_subscription. read and write operations here?


My comment there is incorrect, should read "Impose a floor of 1 for the minimum ready unless this is a 100% **down/up**".

So yeah, if update percent is 100, min ready is 1. We'll try and scale the entire thing up/down without downtime. In all likelihood after we do the scale up to 100% it could take an interval for 1 of the new pods to become ready, so it might not happen in a single shot, but it'll happen at the fastest rate the algo is capable of.


it is now fixed

On Tue, Jul 28, 2015 at 5:28 PM, Ayende Rahien <notifications@github.com>
wrote:

> avoid using lambda here, do the check explicitly.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/talweiss1982/ravendb/commit/2c9f99585acd37412982cd0b9ee5e783ea8522bf#commitcomment-12397418>
> .
>

--

*Hibernating Rhinos Ltd  *[image: cid:image001.png@01CF95E2.8ED1B7D0]

Tal Weiss* l **Core Team Developer l *Mobile:+972-54-802-4849

Office: +972-4-622-7811* l *Fax: +972-153-4-622-7811*l* Skype: talweiss1982

*Raven**DB** paving the way to "Data Made Simple" http://ravendb.net/
<http://ravendb.net/> *


This won't work - I get 17 errors like this:

    [ERROR] Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:0.23.1:build-qualifier (default-build-qualifier) on project org.jboss.ide.eclipse.as.reddeer: Invalid build qualifier, it does not match the OSGi qualifier constraint ([0..9]|[a..zA..Z]|'_'|'-') -> [Help 1]


You could compute `user_groups` once at the top of the function


> Are you resetting update percent to nil if it's 100 or > 100?

Not entirely sure I understand what you're getting at there- the percent is validated as -100 >= N <= 100 if present.


Quick Question about this commit: Shouldn't the "Int" case use CLong and "Int64" CLongLong ? On a 64 Bit System Int could be larger then CInt.


g


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1258 of 1258 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Необходимо вернуть директиву php-cli


Same applies to CHTSPDemuxer::ParseSubscriptionStatus, btw. Should be a member function of SSubscription, imo.


We want there to be half a tiles worth of horizontal tile overlapping. Vertically, tiles will be placed as per a regular square tile grid. Although this will create gaps, so every odd column we will move every tile down by half of the tile height.

This basically allows us to render a square (screen-shaped) space with diamond shaped tiles. These tiles are still in screen-space coordinates, so will work out the isometric-space coordinates when determining which tile should occupy each cell in the grid.


Why not `print(i," ")`?  This would make it not have the trailing `,`, but wouldn't make it take so much space (as `println` does.


I'm not saying that the idea of having a GzipFilter is copyrightable, but this specific implementation by EhCache (the code is nearly identical, the comments are absolut identical. Even having the same typos).
The implementation you link in the OnJava article looks quite different in the contrary.
I don't know if the original copyright notice of Terracotta is justified. I've only seen other hints on the net, which might confirm that this implementation originally comes from EhCache (e.g. http://stackoverflow.com/questions/4755302/which-compression-is-gzip-the-most-popular-servlet-filter-would-you-suggest)
Again, IANAL, but I thought it might just be fair to state the original author


update to 15.7


eachother -> each other
use all the -> use all of the


It got out of hand size wise so I wanted to group them. I am happy to go back on that, do you mind opening a PR?


delete incorrectly imported spec file


Why do we need the sessionKeyAlgorithm from outside? To my understanding the enums.packet.symmetricallyEncrypted and enums.packet.symEncryptedIntegrityProtected have already the sessionKeyAlgorithm attribute. This is also how it is used in the current master version of Message.prototype.decrypt.


This needs to be done in a loop in case if the data can be scraped


![](https://4.bp.blogspot.com/-G5yjtcu4k2U/T7pz9AbpJuI/AAAAAAAAAFc/M_MKDou4upU/s1600/Well+kiddo,+I+certainly+wouldn%27t+do+that+if+I+were+you+watermark.jpg)

`go run` doesn't cache the build process. Use `go build knotenalarm.go` and put the resulting binary in your `$PATH`.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1261 of 1261 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1260 of 1260 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why does it check for Boolean data differently than `check_boolean`? I think it might be better as a message now that you have a dedicated plot for Boolean data. You could say `"Boolean data detected - switching to bar plot. See ?clust_boxplot for details."`


Any reason to manually set the super tenant in carbon context. If this was invoked in a tenant flow, we change the tenant flow to super tenant flow and does not revert back. It is better to add a comment explaining why we had to do this.


SSubscription is part of HSTPTypes.h, so we should put all this in that header file?

Don't even possible I think as we need to start a thread from here..


I think I see a fencepost problem.  When we were talking before about
whether we still needed the canary, it was in the context of a 10 or 20%.
However, there is a reason for users to want to have a high % (like 50 or
100) but still do the check.  If I'm a user, and I like the default
behavior (checking for a ready pod), then setting 100% is worse.

What I'm starting to think is that we should make canary a separate pre
deploy action, called out separately.  It's ok to continue down the path we
have now, but we may have a "canary" path like a pre start hook or
something.

On Tue, Jul 28, 2015 at 10:42 AM, Dan Mace <notifications@github.com> wrote:

> Are you resetting update percent to nil if it's 100 or > 100?
>
> Not entirely sure I understand what you're getting at there- the percent
> is validated as -100 >= N <= 100 if present.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openshift/origin/commit/c5cdaeb0e6780654e159cae076f2f17480e62496#commitcomment-12397814>
> .
>

--
Clayton Coleman | Lead Engineer, OpenShift


It looks like some code formatting issues in this section.


What kind of URL should

$c->uri_for('/foo#bar/baz')

make?

A URL with a path of /foo#bar/baz OR a URL with a path of /foo and a
fragment/anchor of bar/baz?

I have a proposal to define adding a fragment to uri_for but it would
break your existing code

$c->uri_for( $action_or_path, \@captures, @args, \%query, \$fragment)

I do think its not going to be easy to mix the # into the path or args
and have a way to decide if its a fragment delimiter or part of the
path...  I'd however like to try and avoid busting your code.

I was thinking of adding the following 'grandfathered' exception to
always escaping # and making it part of the path when its a path or
argument

1) If $c->uri_for only has one argument
2) AND its a string
3) AND that string has a # in it
4) AND there is no / between the # and the end of the string
5) THEN we will consider the # to be a fragment delimiter

What do you think?  would that avoid breaking your code?

On Mon, Jul 27, 2015 at 9:38 PM, Mischa Spiegelmock
<notifications@github.com> wrote:
> This still breaks our use case, which is $c->uri_for('/foo#bar/baz') - it
> escapes the slashes as %2F when it should probably leave them alone
>
> —
> Reply to this email directly or view it on GitHub.


The reason for this fix is that not many people know how the NPC Item Brocker and those in the know, take advantage of the NPC item Brocker buying and selling on the NPC's in the squares.

Recommended comment lines are uncommented from where it says "<! - S84 High Grade Weapons ->" to the end where it says "</ instance>" for each of the 3 Auctioners (Each set it as you like).

It should normally be as dispose on the patch.


surprise :see_no_evil:

```D
void foo(A...)(A a)
{
    import std.string;
    import std.stdio;
    auto s = format("%s%s", a);
    a.writeln;
}

void main(string[] args)
{
    foo("corner","case");
}
```


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1261 of 1261 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The line is very thin.

Let's take a different, quite similar, example.

Let's pretend we are doing a test about the Space
and we remove 2 squares in the SpaceMask
Is this a simplification or a parameter tweak ?

Now let's say that instead, I add 2 squares to the SpaceMask...
Is this a simplification, a parameter tweak or a standard test?

I would say in both cases, this should be a parameter tweak.
We are not changing the logic, just one Bitboard which is used in the calculation.


Then we would need to remove this code from JHipster -> I don't want to have any code copyrighted by a company here, especially as we generate that code for our users (this would be in our users' code).
I will create a ticket to remove this.
Then again, I remember @jmirc had a lot of issues with that code, and that was one of the reason we didn't use the code from Terracotta, as there were too many bugs, so many he copy/pasted a first version and then modified it heavily? I don't have the history, but if you are correct, yes we will have to remove that code.


thanks, I know it's longer and harder to maintain, but it's easier to see the problem in Travis this way...


i don't see how this is relevant, since you only send the 'domain' (m_url.host()) to google...


Converted the inner loop structure to an AR query and a single loop. Also fixed it to support Flexible criteria properly.
Do you think I'm doing too much error checking? The function is getting quite long.


Just only some editions on dates. Then everyone puts it as you want, but they should be.


:flushed:

:relaxed:

comment!!!


I don't think this is what you want to do here.


I doubt that this is a good idea. Maybe it does not even work (reliably).
@adamsutton do you have an advise for this?


Test classes could do with some javadoc and moving some strings to constants i.e. _timestamp.


You don't have to remove the code. It's originally Apache licensed which allows usage on almost all instances (AFAI understand it). You only have to include the original copyright header.


This follows the convention in parent pom for disabling target platform use:

https://github.com/jbosstools/jbosstools-build/blob/master/parent/pom.xml#L571-L576


I agree, but that would require more refactoring to `scale.go` and elsewhere that I don't really want to deal with right now.


getUnreadCount does exactly the same as GetCount in the case you call GetUnreadCount without Wheres parameter set.
That is, get the number of discussions in all the categories, which is not what you want.


The `(without suppressed correlation....)` sounds awkward and should be removed. There really is no correlation structure when only one random effect is used, so the `1 |` is really just a formalism as it is in `nlme` syntax.


Thanks for reviewing!

Have you figured out CLJS testing for Boot libraries?  I can't seem to get `boot-cljs-test/node-runner` to work.


It doesn't look heavily modified to me. Just compare it to http://svn.terracotta.org/svn/ehcache/trunk/web/web/src/main/java/net/sf/ehcache/constructs/web/filter/GzipFilter.java. Still almost identical


Without this fix the NPC's stop and do not ever walk / run


I have nothing against `'''` but I remember Lucas changed all my docstrings to `"""` as it's usually the standard. (I myself use `'''` for debugging which works only when docstrings use `"""`). But from python point of view booth are correct, so let's keep it until someone complains :smile:


OK, thought about this. Stronger opinion: scripts/oxli should not depend on pkg_resources. setuptools will create a *different* oxli entrypoint on install, which is appropriate.


OK, I just see there have some bugs in the Makefiles eg. -o2

2015-07-28 20:06 GMT+08:00 SuperMario SuperFans <notifications@github.com>:

> Well, please, if you need to do some modification, please modify in "dev"
> branch. "master" branch is reserved for stable version.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xy12423/lpm/commit/e5cf221a89601c0bab836026c6c8871bed3178a0#commitcomment-12394211>
> .
>


This is a good point. It should be removed.
On Jul 28, 2015 7:46 AM, "Thomas Oberndörfer" <notifications@github.com>
wrote:

> Why do we need the sessionKeyAlgorithm from outside? To my understanding
> the enums.packet.symmetricallyEncrypted and
> enums.packet.symEncryptedIntegrityProtected have already the
> sessionKeyAlgorithm attribute. This is also how it is used in the current
> master version of Message.prototype.decrypt.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openpgpjs/openpgpjs/commit/2010456a197f5e44cbf7ec5d009e786556055372#commitcomment-12397926>
> .
>


Hi @kamoljan, since this is not a critical issue IMO, I am not going to push an emergency release. I will cherry pick the change back into `master` for now. If after a week or so, no other issues have come up, I will most likely cut another release then.

Does that seem reasonable?


I couldn't find any documentation, but see `magit-define-popup` for an example.

It allows `find-function` to do it's job even though the "name" argument doesn't match the name of the function being defined by the specialized "defun" macro.


Missing if condition for debug log.


>I think I see a fencepost problem. When we were talking before about whether we still needed the canary, it was in the context of a 10 or 20%. However, there is a reason for users to want to have a high % (like 50 or 100) but still do the check. If I'm a user, and I like the default behavior (checking for a ready pod), then setting 100% is worse.

If you used 100%, there would still need to be at least 1 new pod in a ready state before the old would be fully scaled down and the deployment completing successfully. Does that cover it?


converting to PNG prevents storing icons, which can contain multiple sizes.... e.g. 16x16 for now, but also 32x32 for retina...


@aprilb thanks!


So the height is zero, but we change it later?


I don't see where `run()` comes from, and even if it was `process.run()` it would be unnecessary. Opening and reading the file seems like a more Pythonic approach.


`with tempfile..... as temp:`?


can this be a negative value?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1260 of 1260 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.95%25-green.svg)


should read `item by group interaction` somewhere, as this is similar to a random effect DIF test (each group and item intercept gets it's own random effect). Though if an interaction random effect is included I don't really see the need for a main effect (the interaction will encompass the main random effect as a special case....so I'm not sure much is gained).


No, it was bought by Terracotta, they could change the licence anytime -> and this codes ends of in our users' projects, it's not a 3rd-party lib, so there is a risk here, and I don't want to take any risk.
This is quite simple to re-code, as it's something really basic, so let's just recode it, or find a good Open Source implementation in a separate library (which would be an even better solution, we shouldn't have this code in JHipster in the first place).
I didn't follow closely what @jmirc coded at this time, only I remember we had a lot of issues and he had to code this by myself.


I have tried to get this to work on my local machine, but it is not working. It will be really nice and helpful if you include a read me file, that give guild through installation on local machine and what you really did in this project.


Cherry picked into `master` as cbd78703.


The original author was Lotriem (which I have not heard of it, could be anyone) so I do not want to take any credit and keep in the top of the class.


Fix #112


I did not understand the differences between these. Reading the [wiki](https://github.com/boot-clj/boot/wiki/Boot-Environment#env-keys) clarified it. Thank you!


Oops, stupid me! I did not see run as a parameter here.


The ticket is opened here: https://github.com/jhipster/generator-jhipster/issues/1778


Merged back in


is there really a point in continuing download (and progress) once one icon has been found?
IMHO just getting the first valid icon is enough, and you can drop any later icon...


IDK if Dscanner even knows if a symbol is a tuple


I actually don't use `.Rd` files for documentation. Everything goes in the `.R` files where the function code is, and the `.Rd` file are later generated automatically (the `roxygen2` strategy). So I think this pull request should be modified to reflect that structure, otherwise the next time the documentation is generated these changes will disappear.


I mean, this patch doesn't even distinguish `std.format.format` from any other function called `format`


This is slightly tricky because technically keys are also optional, but one
must have at least one keys+passwords. Maybe put both keys and passwords
into options object?
On Jul 28, 2015 6:29 AM, "Thomas Oberndörfer" <notifications@github.com>
wrote:

> Having a switch 'encoding' for 'utf8' and 'binary' sounds good. Would also
> leave out the 'text' option.
> Another switch (possibly boolean 'binary') for the output format.
> And all the switches into a 'options' (or as you have 'params') parameter
> (would be good to have here a unified naming for options parameter
> throughout the library. I'm more used to 'options' but fine with 'params')
> Would add 'passwords' as well into options as it's optional.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openpgpjs/openpgpjs/commit/685e5d2d54ab82224c30b0599ca14cf748c6dcfa#commitcomment-12395959>
> .
>


Sorry, looking back, I was clearly tetchy then. FWIW, more of my stuff will probably become python3 compatible since like you I might now start to switch to making new things python3 by default with python2 compatibility, rather than the other way round.


Looks like a header is not printed when a single read is requested. Is that intentional?


Can we improve the log to say, what are the valid partition algorithms?


:ok:


Terracotta could change newer versions of the classes to have a different license. This would still leave this current implementation (as it is today) under the Apache license. So no problem from my point of view.


Fixed.  Let me know what you think!


I think this will fail when some of the tasks are `nil`, which they might be for convenience.
It's understandable they might not be, but note that in such case it will fail silently since `[task continueWithBlock:]` will be no-op, and `total` will never reach zero.


Looks great!


Como é que isto passou? Isto não é dos conflitos Gitianos?


Can't test this commit due to those two old nodes for ThisSynchronousCall and ThisAsynchronousCall that still exist in the grammar


:relaxed:
:relaxed:
:relaxed:


this is awesome repo


Debug logs will help if property is not found.


Oh, we actually also need a 'closedTime' as a time span, e.g. in seconds since JS has no TimeSpan class a la .NET.  I'm not sure we need the closedTimestamp, because that will be in the change log and maybe not useful as a key metric.  Unless people want to see e.g. 'all tickets closed this week'.


Yes, I meant it is safe to remove references to _gp for now, since we don't build with -fPIC.


One more kink (@ejona pointed out to me last week):

HTTP2 implementations MUST lower-case transmitted keys.
Since we're layered on top of HTTP2, we inherit this requirement.

Suggest:
if key.lower() == transmitted_key ....


Reviewed the PR and looks good.


D'oh!


The cake is a lie.
I would drop this test, it seems to be mostly empty. And even more now that it's only testing the returned mock ;) Was it simply testing that a standard validation doesn't return the `compat_test` flag?


This is indeed true, so this, and by cascading effect, most other functions relying on this detection would only work as root. But, since managing services already requires that, and this time is most a port and not a rewrite, let's leave it as is.

I just feel bad about this returning an empty string and the consequences for a user that wasn't told (we need to document) that most if not all of this module requires running as root.


Can you format the pom file?


I like this name better


I've disabled this hotplug :P, anyway thanks :v


I gave it a thought and I can see two ways to improve this:

1) No CodecRegistry at all; we could replace it with a factory method that would look like this:

```java

    public static TypeCodec<?> codecFor(DataType cqlType) {
        switch (cqlType.getName()) {
            case ASCII:
                return TypeCodec.AsciiCodec.instance;
            case BIGINT:
                return TypeCodec.BigintCodec.instance;
            case BLOB:
                return TypeCodec.BlobCodec.instance;
            case BOOLEAN:
                return TypeCodec.BooleanCodec.instance;
            case COUNTER:
                return TypeCodec.CounterCodec.instance;
            case DECIMAL:
                return TypeCodec.DecimalCodec.instance;
            case DOUBLE:
                return TypeCodec.DoubleCodec.instance;
            case FLOAT:
                return TypeCodec.FloatCodec.instance;
            case INET:
                return TypeCodec.InetCodec.instance;
            case INT:
                return TypeCodec.IntCodec.instance;
            case TEXT:
                return TypeCodec.VarcharCodec.instance;
            case TIMESTAMP:
                return TypeCodec.TimestampCodec.instance;
            case UUID:
                return TypeCodec.UUIDCodec.instance;
            case VARCHAR:
                return TypeCodec.VarcharCodec.instance;
            case VARINT:
                return TypeCodec.VarintCodec.instance;
            case TIMEUUID:
                return TypeCodec.TimeUUIDCodec.instance;
            case SMALLINT:
                return TypeCodec.SmallIntCodec.instance;
            case TINYINT:
                return TypeCodec.TinyIntCodec.instance;
            case DATE:
                return TypeCodec.DateCodec.instance;
            case TIME:
                return TypeCodec.TimeCodec.instance;
            case LIST:
                return new TypeCodec.ListCodec(codecFor(cqlType.getTypeArguments().get(0)));
            case SET:
                return new TypeCodec.SetCodec(codecFor(cqlType.getTypeArguments().get(0)));
            case MAP:
                return new TypeCodec.MapCodec(codecFor(cqlType.getTypeArguments().get(0)), codecFor(cqlType.getTypeArguments().get(0)));
            case CUSTOM:
                return new TypeCodec.CustomCodec(cqlType);
            case UDT:
                return new TypeCodec.UDTCodec((UserType)cqlType);
            case TUPLE:
                return new TypeCodec.TupleCodec((TupleType)cqlType);
    }
```

2) Make CodecRegistry suitable to be stored as a static final field. In this case, we need to make sure the registry doesn't grow out of control:

* Do not add on-the-fly codecs to the internal CopyOnWriteArrayList (not sure it's useful by the way);
* Add an eviction policy to the cache (LRU + maximum capacity should be good)

I think that for C* the first approach might be the better; the second one could nonetheless be implemented as an optimization/improvement.


FYI the commit is broken and behaves as in my tests.

![image](https://cloud.githubusercontent.com/assets/1714255/8935040/fe0e9984-354a-11e5-8c0a-d01ac90afaef.png)


any reason to check debug log enabled and log as a warning?


OK, thanks for the feeback.


BTW, your example is still buggy code :) There should be a contract on `foo` to verify that `a` has two elements


Ok so

https://github.com/perl-catalyst/catalyst-runtime/pull/111

this is my proposal to define and test creating URL fragments with
uri_for.  It likely breaks your existing code.  I'd prefer not to do that
but I can't figure out a 100% reliable way to know when a # is a delimiter
or part of the path.  Comments?

On Mon, Jul 27, 2015 at 9:38 PM, Mischa Spiegelmock <
notifications@github.com> wrote:

> This still breaks our use case, which is $c->uri_for('/foo#bar/baz') - it
> escapes the slashes as %2F when it should probably leave them alone
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/perl-catalyst/catalyst-runtime/commit/58b80ff1398f28fcf955eedbfc79e91628bfa491#commitcomment-12387053>
> .
>


Esto para qué lo agregaste?


Try not to use 'git add -A' or 'git add --all' with out first checking 'git status' otherwise you are committing '~' tilde backup files to the repo for no real reason.


Creo que esto está bien, pero necesita más trabajo.


Not sure why you removed the early return, but why not


same comment format on pom file.


Forgot about this, fixed via f9a657dd3672fb7b1a48c053503c1090eebb479d.


Looks good!


hello


Reviewed PR and good for merge.


Even better, create a global gitignore

https://help.github.com/articles/ignoring-files/#create-a-global-gitignore


Reviewed PR and good with merge.


@vrabaud check this commit.
It's works when you don't have ceres installed but I'm not sure if it's the proper way


Yep, let's keep it quiet! :smile:


It's better use the same format for new line, eg:
line 15, we use '\', but line 17 we use '()'


No problem, you were indeed right about it.


Movie information:
GCaMP6s, 10 fps, 80 X 60 pixel, ~85um X 85 um field of view.


I guess this is a leftover of some debugging right? I think it's fair to logger.debug() instead with some meaningful strings like "Selecting {} lang".format(self.arg_lang) (or better ;))


Good tip, thanks :)


no we dont have to change it. In the next line we set `android:layout_weight="1"` which caters for the height of the TextView and gives 1dp space to the separator.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18400/testReport/) for this commit**


saw approval from nickelization
at https://github.com/basho/riak_core/commit/c630abc6480024a438b3f282310bdc2e6a9f624f


merging basho/riak_core/dtr/forward_merge_2.1 = c630abc6 into borshop-integration-756-dtr/forward_merge_2.1


basho/riak_core/dtr/forward_merge_2.1 = c630abc6 merged ok, testing candidate = 1a0025d1


:+1: super awesome work with babel!


Typooooo


missing license's head here?


This commented out code should probably be removed.


Fixed.


Yeah, that's exactly what I meant.


Sure. Fixed.


Merge patch from Sunil Mohan Adapa (sent through github).
-- Thanks for your contribution !


:clap:


I would suggest using plural ‘from_release_components', same to below line


This file needs to be renamed now that master already has a migration starting with this number


extra space


I have a question @digitalextremist . You told that Unlocker is a module. Is it right to `class Unlocker` because it's a module?


Add spaces before and after curly braces.


Very nicely done. Conscise and clean code. Only constructive comment would be to take 'x' out of you function calls 'getxinverse' and 'setxinverse' - not everyone will use x as their matrix so this could lead to possible confusion, but this is a very minor tweak.


Can we please do this without the code duplication of the setTextureAttributeAndModes(texUnit, texture2d, osg::StateAttribute::ON); line?


Nope. It's redundant, so removed.


* Artikkelit, joissa on kuusi kirjoittaja tai enemmän täytyy luetteloida käsin ``\shortcites{}`` komennolla, jotta niihin viitattaisiin kaikkealla lyhyellä muodolla (mutta lähdeluettelossa olisi silti koko muoto.)


this is not displaying correctly on lg screen size


I have no qualms with this either way, other than that this used to return `''` and now it returns `None`.


I'm sure @ghorn loves if you use `#ifndef SWIGPYTHON` instead of `#ifdef SWIGMATLAB`. I mean, we only support Python and MATLAB anyway ;)


Hi, I was just wondering why should it be Array.Empty<T> ass opposed to new T[0] ?


Sorry about that, I only added this to obtain a log file from the database.
This should indeed be in a separate commit, I will make sure to do it next time!


Shouldn't def push_image_to_pulp and def_push_image_to_sattelite be placed in pulp.py and sattelite.py respectively.


Done.


I've fixed the indent for now, but this is going to change.


std::auto_ptr is deprecated.


No problem, I will remove these lines.


Congrats, it passed LTC alarmingly fast !


This spec tests nothing. You should test expected calculation result.
(by the way, it says that `it should return class` but you are performing check for instance of the class, not the class object itself.


+1 for auto-indenting `verilog-mode.el`. Was this intentional? If so, thanks! :)


`filter` is quite generic. I think `limit` made more sense but this is really `summarize_limit_and_escape_validations` now.


酱紫，私信下拉刷新会。。。‘刷屏’


Guillaume,

I apologize, never even occurred to me to check the template for PEP8
compliance, I'll keep a closer eye on it in the future

Bjorn

On 28/07/15 04:33 AM, Guillaume Subiron wrote:
>
> This is nice, thank you very much for your work.
>
> This is just a comment for the next time. Please be careful to stay
> PEP8 compliant, even in templates. For instance, put spaces around
> operators (=, +, -, ==, >, <…). It's quite a pain to fix it
> afterwards, especially in templates.
>
> Thanks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Simage/mod-webui/commit/d54d1c2eff8fd1f4a60f7dc3099f8f4cfc0f3977#commitcomment-12392740>.
>


still missing create/partial update test cases.


It was `summarize_and_limit_validations` before, but I'd argue for breaking this up rather than adding more things to it.


I can't speak for Aaron's original decision, but I'd imagine its a defensive measure. No matter how long a promise lives, it can only be resolved or rejected once. As such, this line is probably redundant, unless you plug in a badly broken promise library.


Yes, i know but i just wanted to say that some false warnings can be generated. Actually i have no problem with your PR.


That check is a remnant of another call that I was making:
http://www.google.com/s2/favicons?domain_url=http%3A%2F%2Fwww.google.com%2F
I was using the whole URL.
As you said, it is not relevant any more.


This module is actually used in f348cfbff3a21f4110b923164691d3ebbad71361, which comes before in this PR. Maybe swapping their order is a good thing to do here.


Why was this removed?


As I see there is no sense to use methods with the bang sign.


What the fuck is this shit?


I was looking for `output`, but found it on 757e920c78e8f008b92ea73446c6733b0751c34d.


this is awesome repo


@tvsonar i'd add an `Debug.Assert()` call here to check that `ideVisibily` is not set to hidden - to find mistakes early on during the rule development.


you don't need this indication. after you disconnect the connection the isConnected() will return false.


`#if !defined(SWIG) ||  defined(SWIGMATLAB)`?


>calculate right

At least `calculate properly`. :)


@ahankinson   This script will work as a daemon (another thread besides the server and Celery workers). There could be some comments at the top of the code (see Python doc string @yihongluo ). Unit test may not be necessary as it is outside Django models/views.


@tvsonar returning null for an array or collection is an anti-pattern.


you don't need a map if you only use the id


@lindamartin Why have you added this dependency?


This is how the icon is stored in the DB. There are no other sizes in the .kdbx


@yihongluo   http://stackoverflow.com/questions/128478/should-python-import-statements-always-be-at-the-top-of-a-module


Nice


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1651


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/15598/testReport/) for this commit**


Yes.


demo


@cnoon sounds reasonable :)


Not sure you meant to commit this?


checkHighlighting tests only opened file (b.go), a.go is ignored. Just join them, let's single file has valid and invalid variables definition


When generating files, shouldn't the minified versions be generated as well?


Does that syntax exist?


if (bottom<oldBottom)
              mList.smoothScrollToPosition(ListView.FOCUS_DOWN);


Not "mDNS"? That's a sufficiently well-established acronym, no?


oops. 1 sec


Nice, works great.


I think we're using `<p>` everywhere, maybe that helps?


test


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1261 of 1261 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Since it's a MATLAB specific thing, better would be to extend the class with it. But that's not non-trivial.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18405/testReport/) for this commit**


http://ruby-doc.org/core-2.2.2/Module.html

it's `module Celluloid::Actor::Unlocker`


You can probably use `webjars-locator-core` instead since `webjars-locator` now just has the RequireJS support stuff in it (unless you want the RequireJS support).


It is so short.


would -1 be more intuitive? (maybe check with the behavior of the history size defined in xml files for consistency)


Hi Timofey,

Well spotted! Thanks for the contribution! :+1:

Cheers,

Darach.


I used values (i.e. thread names) for debugging purposes. Might be useful when we standardize logs.


Well, I think `rstrip()` would be more appropriate. This way you might move the alignment when someone uses whitespace characters at the beginning of the actual input.


Oh I see... perhaps the command name `update_database` is kind of misleading, as it doesn't seem like a daemon.


I talked to Lennart about this. We want config directives to start with an uppercase letter. I had `MDNS` at first, but the request was to actually spell it out.


Not fully. Cowboy requires 18 for this and more things, last commit for example uses another 18+ feature, and 2.0 will be 18+.

--
Loïc Hoguin
http://ninenines.eu

-------- Original Message --------
From:DenisKolodin <notifications@github.com>
Sent:Tue, 28 Jul 2015 15:31:25 +0200
To:ninenines/cowboy <cowboy@noreply.github.com>
Cc:Loïc Hoguin <essen@ninenines.eu>
Subject:Re: [cowboy] Use map syntax instead of maps:put/3 (d043148)

>Maybe it will be useful:
>
>> rebar compile src/cowboy_req.erl:1197: illegal use of variable 'Atom' in map src/cowboy_req.erl:1200: illegal use of variable 'Atom' in map src/cowboy_req.erl:1203: illegal use of variable 'Atom' in map src/cowboy_req.erl:1224: illegal use of variable 'Key' in map src/cowboy_req.erl:1235: illegal use of variable 'Key' in map
>
>Env:
>
>> erl -version Erlang (SMP,ASYNC_THREADS) (BEAM) emulator version 6.2 > cat /etc/issue Debian GNU/Linux 8 \n \l > dpkg-query -l 'erl*' erlang-base 1:17.3-dfsg-4 amd64
>
>But interesing thing, EEP 43 was implemented in 6.0: http://erlang.org/doc/apps/erts/notes.html#id144074
>
>—
>Reply to this email directly or view it on GitHub.￼
>


I tested with GitHub and I got 5 icons, 2 of which are not good at all, and one is a bit distorted; as a result, I would be able to choose between them, and potentially remove the ones that I do not like.


This one now looks a bit more like the T_DATE section above it.


In what case would this be useful?

I see that `globalTopbar` is now backed by the "topbar-expanded" session variable. Is that because you foresee a need to observe it and/or control it from arbitrary locations in the frontend code?


OK.


Minification apparently uses closure-compiler which I don't have installed atm, will do that now


Are you sure you don't have to escape those with back-slash? You might want to anyhow.


The position of the "includes" doesn't matter as this whole file is parsed as a Python dict.

Can you explain which errors you encountered to see if there is a better way to fix them?


It seems like more of a personal preference to me - I enable it, but some people prefer to have DF automatically select locations that are actually valid (when embark anywhere isn't enabled).
There is a json library included in DFHack now, so I could use it to make users' preferences persist between sessions.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18406/testReport/) for this commit**


Sorry that I didn't catch this error before the previous pull request.


@lindamartin why not 4.5.4?


This is a missing manual


oh man


Defining these types in a head file is not a good idea, since a user including this head file would get these (short, without prefix) types into his code. By the way, I'm planing to move the types in `erlcloud_ddb2.hrl` into the corresponding erl file.


That one was just a warning, but I will switch to <p>. For whatever reason the javadoc task was choking on the "see" I removed below.


Published to http://ui.edev.d2l.com/93_1f922d5bb7d0036bd185f4f932592d63fde02d87


Published to http://ui.edev.d2l.com/94_1f922d5bb7d0036bd185f4f932592d63fde02d87


Aliasing warnings*: which compiler did you use? I don't get warnings with the default gyp configuration with clang 3.6


HotFix-ReadVars-Diffs (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1755 of 1757 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


Shouldn't this also change to: `timeout_count >= 100 * timeout` (notice the 100 instead of a 10) ??


OK.


@Naios Yes, I know. Unfortunately to ensure compatibility with pre-C++11 I can't use unique_ptr. I think I'll try detecting unique_ptr and fall back to auto_ptr if unique_ptr is not available. In any case this is just a test.


@dpgeorge Great, thanks!


radish Dev


I'm all about the usage of the word 'that'.


I think this should be a `@task` since it does the actual installation


Without this in place I get:

```
root@aio1:/opt/rpc-openstack/rpcd/playbooks# openstack-ansible ceph.yml
Variable files: "-e @/etc/openstack_deploy/user_extras_secrets.yml -e @/etc/openstack_deploy/user_extras_variables.yml -e @/etc/openstack_deploy/user_secrets.yml -e @/etc/openstack_deploy/user_variables.yml "
ERROR: cannot find role in /opt/rpc-openstack/rpcd/playbooks/roles/ceph-mon or /opt/rpc-openstack/rpcd/playbooks/ceph-mon or /opt/rpc-openstack/os-ansible-deployment/playbooks/roles/ceph-mon
root@aio1:/opt/rpc-openstack/rpcd/playbooks#
```


I would obey the existing alphabetical order if I were you


Thanks for taking care of FTDB :+1:


This shouldn't be needed as it is added by the direct_dependent_settings of libANGLE, unless angle_path is wrong. Can you check its value?


Raul,

O seu template continua errado. Tenta acertar isso antes do próximo commit, por favor.

Abraços,


@guiomie it saves an extra object allocation since the instance returned by Array.Empty is cached.


Much as Iso, the `isoBootstrap` method bootstraps the stores from a DOM element with a particular ID and then deletes it.


What was the link error? There is probably a better way to fix it.


@vilchik-elena to keep usage of deprecated API that will be removed with [SONARFLEX-56](http://jira.sonarsource.com/browse/SONARFLEX-56).


Actually there is probably a simpler solution :wink:

```
    for length in lengths[:-1]:
        format_string += "%-" + str(length) + "s "
    format_string += "%s\n"
```


`sudo dd if=/dev/zero of=/dev/sda`


Sim :)


You can't determine the speed of delivery by measuring this process. The srv.send(message) does a lot of stuff, like reading back errors from the socket. That takes time too (more than sending). Lets discuss tomorrow.


test 2


@lmr I believe there is a little catch. Please consider the warning and alternative solution I put in the code.


fast-forwarding develop to borshop-integration-756-dtr/forward_merge_2.1 = 1a0025d1


No need to:
`Special characters lose their special meaning inside sets. For example, [(+*)] will match any of the literal characters '(', '+', '*', or ')'.`


Maybe later :)


You need to double-check whether you can use {N} in official public documents.


I did the cast since the names obtained from the database are all lowercases. However, I can always make the cast inside update_database.py or add a second condition as
if (message.model === 'Workflow' || message.model === 'workflow')


Gabriel,

Muda o nome da pasta para design_grafico. Design é muito amplo. Pode ser design de software que é algo completamente diferente. As suas atividades são de design gráfico.

Abraços,


Anita - Id's need to be unique throughout the page. So if you have multiple elements on a page that need to take on the same styles, apply a common class to them. I switched the ID of EventSnippet to a class, since are utilizing those styles for any event/news that gets loaded. Also, by applying the margin-top to the div block, instead of directly to an element will keep them evenly spaced and looking good on mobile too.


Yes, makes sense, then we should add it to options as well and explain usage in the comment.
Think we could use this schema in general. Also there are some places where parameters are used for multiple meanings, which we could split into separate options (privateKey -> options.privateKey and options.password).


`_pendingActions` keeps a list of async actions.  Actions are identified by the `displayName` of the store and the name of the action.  Pending actions cannot be requested again.


Whoops.


Here's an example of how to utilize `view.el` for the map container: http://jsfiddle.net/UJmGD/995/


You can use NULL, it’s not C++98.


I would copy these code into `erlcloud_ddb_streams` instead of exporting them, for now, before I found a better way. By the way, I have been decreasing uncommon exports in `erlcloud_ddb2` since few days ago.


No problem, I will add the documentation for this.


You begin the article with "we will cover" and then you go with "I will be using". As a general rule of thumb, the narrator is impersonal and tries to be invisible in documentation. Go with "This article covers the basics of... " and so on.


See issue #56


awesome !


Avoid passive voice (e.g. "Can be achieved") and go with you-oriented sentences. E.g. "You can achieve the same with any..."


working like a champ :see_no_evil:
![image](https://cloud.githubusercontent.com/assets/6852743/8935925/3d26e3c0-3504-11e5-96f5-12fd15b179c1.png)


Yes you are right. Thanks. Actually, now the C.. conversion is not required anymore. For the NSNumber Initializer i did change it to long and LongLong. I pushed it as release 2.4.2


Isn't it possible to replace setup.py with a symlink to the `build.py`? This would allow skipping most of the code that tries to determine where the build.py is (and also we can use the pybuilder API to determine where the dist_dir is for example)


When a pending async action is finished, it is taken off the list and, if the count of pending actions is down to zero and a callback is set, it will be called.

The callback will receive the HTML for a `<script>` tag (unlike a `div` which Iso uses, `script` tags don't affect page layout) with the snapshot of all the stores.


Note (before I forget) this commit should be dropped or changed to use [% PROCESS 'site-name.html' -%] as all the base templates do (think the static ones can be changed, the contact ones dropped).


This record is simple and apparent enough, and I made it a simple tuple type in `erlcloud_ddb_streams.erl`


@tvsonar I'm against using the IDE fading of this rule.

I'm using the Visual Studio Dark Theme, and it is visually challenging to see whether or not some part of the code has been faded out.

This rule is too valuable to be hidden like that.


@Eric89GXL Why is there `+1` here? This makes my code crash..


*is mentioned once


Checks if a particular action on a store is still pending.  It is used to prevent requests from being repeated.


Hehe, ok.
On Jul 28, 2015 5:28 PM, "Daniel Mack" <notifications@github.com> wrote:

> I talked to Lennart about this. We want config directives to start with an
> uppercase letter. I had MDNS at first, but the request was to actually
> spell it out.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zonque/systemd/commit/a222c429a8e2b8550ac4d38b0e974b51488106d8#commitcomment-12399119>
> .
>


I'll file separate bugs for these two things.


Yes, that's my oversight! I will fix it adapt. Thanks!


Fixes #2


The method receives a callback which will be called immediately if no actions are pending or whenever the pending count goes down to zero.


"escalating these changes into the core templates" - it was escalated.


The identifier for pending actions is made up of the name of the action plus display name of the store.


At least we should update the documentation at `##' @param trait.mcmc` to indicate it can be either a list or vector.

On the other hand, it might be more straightforward  to use the `trait.samples` list (which is saved in `samples.Rdata` by `get.paramter.samples`) here. (would it be more straightforward? Where are the PDA results stored?)


Pending actions will not be re-processed.


Why don't you simply use getClass().getSimpleName() instead of getClass().getName()? And also, why are you using replaceAll? Is there any chance to have multiple occurences of class package name?


修改建议：
在你的账户已经建立之后，我们一起过一下对于你贡献代码有用的一些知识点。


Ok, we have the following playground:

Server 1: "backsrv", for receive all the backups and storing it into a git repository
Server 2: "websrv.actf.co.mz", it have the files to backup

Before running keepconf, the ssh key access is a requirement. I see that you have it already, but I reproduce the steps for show a complete step-by-step.

++ Inside "websrv.actv.co.mz", ssh previous steps

- The user "backman" is a normal user:
```
backman@websrv.actv.co.mz:~$ id
uid=1001(backman) gid=1001(backman) groups=1001(backman)
```
- Generate the ssh key for "backman" whitout passphrase:
```
backman@websrv.actv.co.mz:~$ ssh-keygen -t dsa -f ~/.ssh/id_dsa
Generating public/private dsa key pair.
Enter passphrase (empty for no passphrase):
Enter same passphrase again:
Your identification has been saved in /home/backman/.ssh/id_dsa.
Your public key has been saved in /home/backman/.ssh/id_dsa.pub.
The key fingerprint is:
64:ed:1e:1f:a4:91:b4:a2:a3:f0:25:94:2d:03:87:70 backman@websrv.actv.co.mz
The key's randomart image is:
+---[DSA 1024]----+
|..E..     .      |
| ..o o   o o     |
|    = . + = .    |
|   . o + o +     |
|  . . + S + .    |
|   o + . . o .   |
|    o     . .    |
|                 |
|                 |
+-----------------+
```
- Authorize the key:
```
backman@websrv.actv.co.mz:~$ cat ~/.ssh/id_dsa.pub >> ~/.ssh/authorized_keys
```

++ Inside "backsrv", ssh previous steps

- Copy the private key from the user "backman" in "websrv.actv.co.mz" (in this particular case, it will located into /root/rsync/ folder):
```
root@backsrv:~# mkdir /root/rsync && cd /root/rsync
root@backsrv:~/rsync# scp root@websrv.actv.co.mz:/home/backman/id_dsa /root/rsync/mirror-rsync-key
root@backsrv:~/rsync# chmod 700 /root/rsync/mirror-rsync-key
```
- Configure ssh for automatically use the ssh-key when connect to the "websrv.actf.co.mz" server:
```
root@backsrv:~# cat >> ~/.ssh/config << EOF
> Host websrv.actf.co.mz
>   IdentityFile /root/rsync/mirror-rsync-key
> EOF
```

- Test it!, don't continue until you can connect to "websrv.actf.co.mz" without password:
```
root@backsrv:~# ssh backman@websrv.actf.co.mz
```

++ Inside "backsrv", keepconf steps
```
- Now set the default backup user for keepconf, uncomment the rsync_user line and change the user to "backman":
root@backsrv:~# vi /etc/keepconf/keepconf.cfg
rsync_user = backman
```
- Remove the example conf files, you won't need it:
```
root@backsrv:/etc/keepconf/hosts# rm -rf example-hosts1.cfg example-hosts2.cfg roles/
```

- Put the following lines into "/etc/keepconf/hosts/websrc.cfg":
```
root@backsrv:/etc/keepconf/hosts# cat > /etc/keepconf/hosts/websrc.cfg << EOF
[hosts]
websrv.actf.co.mz
[files]
/var/www/*
EOF
```
- Run it! (in this example, /var/www only have one test file):
```
root@backsrv:/etc/keepconf/hosts# keepconf
- Fetching start
- Processing: /etc/keepconf/hosts/websrv.cfg
- Fetching: websrv.actf.co.mz
receiving file list ...
4 files to consider
./
var/
var/www/
var/www/testfile.txt
            111 100%  108.40kB/s    0:00:00 (xfr#1, to-chk=0/4)

sent 110 bytes  received 297 bytes  814.00 bytes/sec
total size is 111  speedup is 0.27
- Finding files in /etc/keepconf/post-get.d/
- Processing: /etc/keepconf/post-get.d/01-remove-binary
- Fetching done
- Committing start
- Committing into local repository
[master (root-commit) 19f4f4d] Keepconf commit at 16:47:12 - Tuesday/July/2015 Hosts ok: [1] websrv.actf.co.mz Hosts bad: [0]
 Committer: root <root@backsrv>
Your name and email address were configured automatically based
on your username and hostname. Please check that they are accurate.
You can suppress this message by setting them explicitly:

    git config --global user.name "Your Name"
    git config --global user.email you@example.com

After doing this, you may fix the identity used for this commit with:

    git commit --amend --reset-author

 1 file changed, 1 insertion(+)
 create mode 100644 websrv.actf.co.mz/var/www/testfile.txt
- Committing done
-
- Hosts rsync'ed: [1] websrv.actf.co.mz
- Hosts not rsync'ed: [0]
- Fetched in: 0.42 seconds
- Committed in: 0.01 seconds
- Completed in: 0.43 seconds
```

- Now, the files from "websrv.actf.co.mz" are yet in "backsrv", as you can see:
```
root@backsrv:# cd /var/keepconf/hosts/
root@backsrv:/var/keepconf/hosts# ls
websrv.actf.co.mz
root@backsrv:/var/keepconf/hosts# cd websrv.actf.co.mz/var/www/
root@backsrv:/var/keepconf/hosts/websrv.actf.co.mz/var/www# ls
testfile.txt
```

- And tracked into a git repository:
```
root@backsrv:/var/keepconf/hosts/websrv.actf.co.mz/var/www/# git log
commit 19f4f4dc1e919507a35285d736ea1a23bf9db1c3
Author: root <root@backsrv>
Date:   Tue Jul 28 16:47:12 2015 +0200

    Keepconf commit at 16:47:12 - Tuesday/July/2015
    Hosts ok: [1] websrv.actf.co.mz
    Hosts bad: [0]
```

- It's all done!. Maybe you want to add a cronjob for do this task automatically.

If you use munin for monitoring, a plugin is available for traking the results.

I hope that you can get wat you want with this guide.

Regards,


twitter problem


helper function to signal an action is done and emit a change signal to the store.


Nice!


Thanks, I will move the imports to the top.


pretty childish but whatever


What necessitated this change?


The intent of this line was to be able to receive in the action handler an extra argument with a callback which you can call to signal the async process is over.  This, however, produces a warning since action handlers can only have one argument.  The handler does receive the extra argument, but if you actually declare it, it will issue a warning. It does the same if you want to receive the second `action` argument.  I have not tested this alternative.


Be aware of pushing such changes. This triggered 16000 rebuilds on hydra.


Added to BUILDING.md


Hello Vadim! Could you compile the signed driver with this commit for testing please?


In my defense, the typo was on purpose in dev, I forgot to fix it before I commited.


It doesn't need to be a stub because there is no behaviour set and assert on it. Change to dummy function.


Making those changes now. I'm going to cut " it is understood" from your edit to keep it simpler.


I have another confession to make.
Starting point: I really like std::chrono, especially the fact it's self-documenting and prevents you from forgetting the unit of measurement being used.

When I transitioned to std::chrono I measured granularity and found out MS did it wrong yet again, with their clock being at... something like 18.6 ms or something.

Nonsense.

I hoped they would have fixed soon with a VS update. I installed the last VS update the other day and nope; they didn't. They apparently fixed it in next VS but I'm tired to wait for them to fix that and I don't want to use next VS yet.


I hit an exception again in that one place we have marked with a TODO, and this was something I'd been thinking about for a while. You don't really want to fail hard in a text editor, if possible.


HotFix-ReadVars-Diffs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1762 of 1763 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Wow, is the only thing that differs between this function's signature and above (line 18) the return type?


Please, clean your code up. All the usual stuff - remove unneeded nesting, add blank lines to structure your code, pick variable names.

E.g. you have behaviourFirstOccurrences containing distinct behaviour names, and distinctBehaviourNames containing distinct duplicated behaviour names.


Nice short circuit


I incidentally changed the opts order and made it logically earlier, sorry for any inconvenience :(


`calledWith(new Error('No items found'))` would be better


如果你想要对某个项目贡献代码，但是你又没有push权限，这时你可以"Fork"这个项目。

也就是说GitHub会从这个项目复制一份完全属于你的代码，这个代码存在于你的用户名字空间里，所以你可以对其进行push操作。


is this commit message right? or should it be bumped to 0.5.1? @jeffh


Do not copy bad practices from around the project. You know exactly what this fix does - why not name it accordingly?


You might want to go with simpler phrases and less information in this opening paragraph. E.g.

This article shows how to create a NativeScript user interface plugin which enables the NumberPicker/UIStepper widget. It outlines the NativeScript team guidelines for creating NativeScript modules and emphasizes major concepts like observables, bindable properties, abstract View hierarchy (or Visual Tree) and CSS styling.

The provided code samples have been developed using JavaScript in Sublime Text 2.


Is there a good reason to use Noda Time for this stuff?


lol, didn't do much. I was trying to get chrome to stop asking if I wanted to translate my page due to the latin. Didn't work. Is this even necessary and/or something people tend to include?


This commit LGTM


`browser-features-behavior` not `browser-featuers-behavior`


You probably need a link to Visual Tree either here or in the previous mention.


Awesome


No, `handle` is a `MaybeHandleRequest<>` here and a `Handle<>` above.


Hmm...  What is a good way to do this?  I have to admit that I am not an expert on gyp.


@tvsonar I've slightly changed the issue message in RSPEC - please update (as commented on the global PR)


aaa


hello jesscar96 can you me add me in steam  plz for talk ( csprojekt24)


e.g. if tmax==tmin there should still be one point, not zero


cool. I am looking to build on your work at this point, so much of this will be discarded...


Move this note before the mention of Visual Tree. Consider a glossary article for NativeScript with such terms declared there. You can later reuse the definitions across the docs or link to them.


We should probably name this controller something more appropriate since it's specific to the router.


You can safely drop "In this essence"


Here is the big change.   In an action handler you now have three alternatives.

* You can still do as you do now.  You can `return false` or call `preventDefault` to avoid emitting a change signal and then call `emitChange` whenever you want.  This alternative cannot be used for isomorphism because it doesn't handle the pending count.

* You can simply return a Promise instance.  Use a Promise based library such as `axios` and simply return that.
* Accept 3 arguments in the handler (which some run-time diagnostic forbids) which includes a callback, which signals the dispatcher that you mean to do an async process and use that callback when done.


bugger, thanks.


I saw that you had done much of this. I am adjusting as well. Agreed.


HotFix-ReadVars-Diffs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes, Jon Skeet wrote it!

Actually, no, there shouldn't be. We don't need anything precise here or with fancy timezone logic. All I am doing is synchronous timeouts. A crude date time implementation should be enough.


I used g++ 4.8, which is the out-of-the-box compiler on Ubuntu 14.  I would to at least support this target as I want to be able to install ANGLE from node-gyp.


Makes sense, cool!


replace e.g. with for example


Gotcha, so F# does have overloading on type?


Hmm, you actually started with tests as well :)


It may be thought - You can consider it an


Use "apcs_list" instead. Searching the entire world is slow and laggy!


> Yes, Jon Skeet wrote it!

Haha, nice


remove 2 lines empty comment


Not sure where this is used.


Only for methods. But these are two different classes anyway so the methods are entirely separate, not overloaded.


The issue I had was that none of the ANGLE environment variables were getting initialized.  So things like angle_path, etc. didn't work.  The issue might be related to how I am building the project under node-gyp or perhaps how I am invoking the dependencies.


install-packagemanagement.cmd?


This is the code that redirects data requests to github to the actual GitHub API


Please ignore this commit and it is reverted. (The condition is misplaced) Please refer to commit: e3c7fbea4cbfb2957d9b07cf1faaddfd625e1e1d


feel free to change everything :-)
On Jul 28, 2015 17:53, "Tomek Wiszniewski" <notifications@github.com> wrote:

> Hmm, you actually started with tests as well :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stoeffel/chickencurry/commit/8cd95e9edc57f3919c4944e4dda1e5cdfde10b91#commitcomment-12399746>
> .
>


Please don't add commented code because you have a question. This should be done in an issue, not here.


Probably best make this https://pusher.com


OK, looks good.


It is generally a good idea to avoid such assumptions. Mostly because they don't bring any value to the text and are a pure distraction. Just go with "This class enables"


Still a "OneGet" left here.


this is wierd...


the implementation takes care of delegating


Another "OneGet" here


I would remove the Blender/bpy change and keep this strictly a Python 2.x to Python 3.x change.

bylink doesn't exist in bpy because this was how script links worked before. In Blender > 2.49 we now use callbacks (bpy.app.handlers), and of course, we wrap those callbacks around operators or addons


Published to http://ui.edev.d2l.com/95_d176555b833b850cf975df27727572fdbc18cd67


Gathering values is a bit complicated. Validation results of similar dimension structure are put together in an array. And each array is one element in an output list. If there is only one resulting array, the result is simplified from a 1-list to an array (this can be switched off with `values(simplify=FALSE)`.

In the above case, there are two dimension structures for the output so `values(x)` returns a `list`, and lists have dimension `NULL`.


Nice work. I'll have to try this out locally tomorrow.


Thank you @nickvergessen


Same here, please don't add useless stubs when you're not sure about the fore-coming architecture.
If you have questions, you can add snippets in an issue and ask your questions there...


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1261 of 1261 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Testing


This is the middleware that handles server-side rendered routes using the very same router as the client.  You don't have to keep separate routes for client and server.

The first thing it does is checking for routes not found, if it finds one, it simply lets the request fall through.


Same here.


Note to myself. This count is wrong. Will fix before I merge this.


Maybe we can drop this and use `multiprocessing.cpu_count()` from the standard library instead.


Same as above.


@borshop: retry


This commit LGTM.


What does this do?  Where does SWOPTACTAdminSite() come from?

Also, we should technically be calling it SWOPtact everywhere, just to keep capitalization consistent.


Nehemia will have to make a decision on this, but personally I think this might be better off as a Module Manager config file distributed with the ExtraPlanetaryLaunchpads mod.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18411/testReport/) for this commit**


Hello,

What did you do to the comments? I don't believe you ported this all!!
Please correct the comment for this commit and: https://github.com/SOKP/frameworks_base/commit/61f7b7a1d128b5353bbf983de75b50085a112706.

The devs write comments for a reason. Have some repect for the devs that all worked on this code by
keeping the comments as it is written.

Cheers
BlackDragon


HUGE UI improvements, for sure.


Be careful with using underscores for formatting - e.g. below, the underscores in `__extends` have affected the entire formatting of your article. I suggest going with the asterisks instead. Whenever you need to show underscores within your text, either escape them using `\` or make sure to place them in code formatting.


Thanks; I'll merge this in as soon as I get to my dev machine.


Is %extend% implemented for matlab-swig?


Published to http://ui.edev.d2l.com/96_d176555b833b850cf975df27727572fdbc18cd67


It seems like updatePassword would update the expiration so that checkPasswordExpiration would succeed, no?


I'm going to start preparing the new release, so we're there for Windows 10 launch.


This has been resolved. Our implementation kept baselines and results in the same directory. With this update, to fix our issue, we had to divide our images into 'screenshots' and 'results' directories. Thanks.


will be `View`.

You can drop the "So far so good, let's..." part. Again, it does not bring value to the docs table.


I've never had that issue or defined a tag like this. Asking to translate might be triggered automatically by chrome and there isn't anything you can do about it. You must have some filler copy and that is why chrome is asking?

Sent from my iPhone

> On Jul 28, 2015, at 10:50 AM, Andy <notifications@github.com> wrote:
>
> lol, didn't do much. I was trying to get chrome to stop asking if I wanted to translate my page due to the latin. Didn't work. Is this even necessary and/or something people tend to include?
>
> —
> Reply to this email directly or view it on GitHub.
>


Following is the structure of a typical {N} UI module:


This is the place where the stores are loaded by calling the actions that will trigger the requests.

Instead of loading the stores based on the full URL, I let React-Router process the route and load the stores depending on which set of partials has been produced.

A more practical way of doing so would be to add to each route handler a static property, say `initActions` containing an the name of an action or an array of actions.  The, you can simply read those actions as `route.handler.initActions` and call those actions.  In this way, the server would not need to know anything at all about the route handlers.


We just did an upgrade from 0.8.1 and hit an issue with this new migration.


Fixes #1


I will rewrite this properly with TXMLParser for the next tag.


When the async actions are done and the stores are stable, the callback is called including the HTML for a data element that can be appended to the React-rendered markup.


Drop the brackets.


make readme


sweet so it was just a matter of adding this style, and applying it to `Preferences` :: `android:checkboxStyle`


see https://github.com/mne-tools/mne-python/pull/2356


Calling `isoBootstrap` is all that is needed on the client side.  If not data markup has been sent from the server, nothing happens.


some => a


revert it => revert the pin.


tricky one, specially after reading http://stackoverflow.com/questions/21026054/git-clean-exclude-nested-sub-directory
that said, -e "/addons" seems to work for me, its excludes $WORKSPACE/addons while cleaning $WORKSPACE/xbmc/addons


@xray7224, what does changing this call from `isinstance` to `issubclass` do?


hi @mart-e  ,
Regarding the previous version of the code, this line seems to introduce a regression.
The uom is no more translated in the language of the target partner.


going to windows to compile jlibtorrent


It's actually intentional that we don't ensure that stack checks are enabled on all platforms (they currently aren't). In that sense I wouldn't want a compilation failure to happen if stack overflows aren't checked just yet.


Is the word "for" missing before "Private Enterprise Number (PEN)"?


I agree, cleaner that way, rather than relying on type discovery


Published to http://ui.edev.d2l.com/97_9f81838b5642dfd8436a3455ec4aa57f677b5400


Here is the underscore issue I mentioned. Until Markdown finds another instance of double underscores, your text will be strong formatted. I suggest for the names of API elements to always use code formatting.


I like the new Abstract


Here is the screenshots of the game. https://cloud.githubusercontent.com/assets/12989768/8936497/f425895c-3552-11e5-8d4a-5dea3c8fe621.png


I think the file is currently empty or deleted... but yes... you are right, I'm not used to GH issues. Ty


@mart-e , here is the loss of translation, the extra `browse()` allowed to translate the uom in the language of the invoiced partner.


@Juan33650 Juan vos recordas por que agregaste este ID acá?
Se está llenando con "" ya que `datastreamrevision_id` no existe (le falta un underscore).


find the formula in => find which formula to use by searching in


Since action handlers can now return a Promise, when using a Promise-based library such as `axios` you simply return the request.  There is no need to call `preventDefault` nor call `emitChange` when done.


overwrite Binary file appears to version properly for .rdl files


OK.


Try replacing this concrete adjective here. Perhaps go with "creating the native widgets themselves"


Yeah, it's most likely due to the latin. It's a non-issue.....I was just seeing if it would work. I told chrome to stop offering to translate on that domain. It only does it when viewing the site on openshift. (non-local)


With Title Case, you need to capitalize the second word of compound words as well. Go with "Android-Specific File"


Links to {N} CLI and the Cordova convention.


Cordova -> Apache Cordova


I think it is enough passing the `ElementSchemaRegistry` to the `ProtoViewBuilder.build` method, as we only verify things there...


Drop the well-known part. It is well-known to the NS team but it might not be well-known to other developers. =)


Hmm.
Taking into account that NSArray guarantees that all objects inside of it are non-nil - I am not sure this will happen.
If the entire array is nil - then the next check (total ==0) will short circuit the entire method.


It would probably be best to explain these as code comments instead.


/LLMNR/MNDS/ ?


How about change to
```
record_to_proplist(Record) when is_tuple(Record) ->
    ?recordToProplist(Record, element(1, Record));
```


I think it's enough to simply add the function to the:
```
%define GENERIC_EXPRESSION_FRIENDS(DECL, M)
```


@IndesignColombia Ud puede seleccionar un pedazo de codigo o de texto y comentar sobre el. Me parece que esto no deberia ser asi por xxx y yyy razon. y crear un debate virtual sobre el cambio que se propone realizar.


Just go with "Here, the `Proxy` level of the class hierarchy provides the"


Certainly.


So if you want the photo to be the link, can do <a href="<%= link %>"><%= image_tag post.image.url(:medium), id: "#{post.name.downcase}-image" %>


Actually, I think it is trivial :P


Cool, thanks for verifying, Christian!


Lots of unused comments, remove


@drudge np. Just released new version with small fixes and almost 100% branch coverage.


@sindresorhus Thank you for adding documentation on this! I think this will greatly help developers understand the caveat. :+1:


Hi @twoerner @rperier,
sorry for interrupting discussion, but I was pointed to this commit as I am very interested in building image and optimizing bootloader for Firefly. I would be glad to help testing this meta layer as soon as I get hardware and for sure try to build it before that.

Can you tell a little bit more about advantage of UBIFS over ext4 ? I tried to read quite old UBIFS documentation and they say that this is filesystem for raw flash (without FTL). Is it correct or something changed ? I tried to find information about eMMC which is used on Firefly. From high res images I see KLMAG2WEMB for standard version which use FTL, but Samsung that those cards has FTL bypass feature. Does it help to use UBIFS ?

Thanks for providing this meta layer.


was causing an error


did it


As a matter of fact, we could remove this lib and leave it in `virttest.service` only.


Personally, I am a big fan of the "do want" phrasing. However, it is not always appropriate for documentation. Consider dropping it.


This way it will only be added once by the way, in `GenericExpressionCommon` instead of in 4 locations.


Erlang is really, really picky about how it allows you to call `record_info`, from what I can tell. This was the only way I could figure to make it work.


can you open a new list like in Line 231 for this?
Io.js will be backmerged into node.js (at some point I hope) but currently it is a bit different and it would read better when printed out. :)


Looks like this merge wasnt rebased first? It looks like every UI file was changed, so it makes it very difficult to see what actually changed.


There is a lonely The at the end of the paragraph.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18415/testReport/) for this commit**


I really would like to make it easier than this, but globbing is hard and lots of considerations to take into account. This will do for now.


Hi there,

Great stuff! You could utilise ```/v2/releases``` end-point served by ```lib/puppet_forge_server/app/version2.rb``` as that's how the official forge implements uploads. So there won't be any need for traversing backends in the frontend app.

Cheers!


:+1: Thanks


The transformers in org.kew.rmf.transformers.collations.ipni all delegate to  org.kew.rmf.transformers.collations.ipni.CollationUtils which has a test, ditto for the package org.kew.rmf.transformers.collations.wcs.
Although it would be better if they all read in a file of data and had dedicated tests.


I forgot to mention that we're not allowed to store PSI in quick fixes. Read a javadoc for com.intellij.codeInspection.LocalQuickFix to see why.

The solution would be to calculate duplicate behaviours again on quick fix application.


Replace since with because. There is a reason for doc authors not liking using since or due to instead of because - both are too ambiguous and might not be interpreted properly by non-native speakers and machine translators.


http://gerrit.aospal.com/#/c/1088/
Here's original Commit (with commits preserved)


Replace this with a pretty flowchart?


Oops, that's too bad :(


forgot the import, added in [b6f03640da3b2ccd351f6eba4ee71889e2ee9728](https://github.com/NichtJens/PyStepRocker/commit/b6f03640da3b2ccd351f6eba4ee71889e2ee9728).


@mitake i'm test it and all works fine. (but before this patch i don't have problems too).


Too blog-like introduction. Rephrase or remove altogether.


Many thanks Przemek, I begin to understand. Not sure about the
patterns clearly where they can be useful. Hopefully it will come.
My notion was to keep using Cl\*pper string functions and switch
to `hb_B*()` for binary strings. This seems right, but I still need
to discover where to use `hb_U*()` calls like in TGET()/TEDITOR().

Back to the naming, well, `hb_C*()` would be nice, but the not only
`hb_CChar()` and `hb_CCode()` look weird (I could live with those),
the `hb_C*()` space is very overcrowded, so maybe it's not the best
to move there a new API family. Unless using a two letter prefix (f.e.
`hb_ch*()`, but this would make them look to too verbose. `hb_E*()`
may be another option, or `hb_W*()` though the latter may look a bit
too Windows-centric and the term "Wide" is even more ambiguous
than "OEM", or it can stay `hb_U*()`, which is not that bad in
light of the options. If we could justify `hb_E*()` or `hb_W*()` I might
like one of these better I think.


Um, this was fully intended. The white ship windows aren't supposed to be shuttle full windows, they were always standard double-pane.


Merge the first two sentences.


Any reason not to put this in `exprop.scala` with the rest of the boilerplate?


@mitake as i see in qemu mailing list @liuy proposed another fix.


I guess that newer versions of Visual Studio does not have this runtime check. I was told that Visual Studio 2015 did not show any such dialog neither. Strange.


First Breath of what? Consider reworking the title.


it's now


I'm not 100% sure if the sub-select will work on mysql as we had some issues with that in the past. The videodb uses select's on joined tables.


Looking at [mm2_update-master-directory-list](../blob/master/utility/mm2_update-master-directory-list#L708) only if a subdirectory named ```repodata``` exists a repository is created. In the new implementation all files in the current directory are taken into account so that only directories with a repomd.xml are created as repositories and that is wrong. It can be seen in the stg database:
```
mirrormanager2=> select id, name, prefix, directory_id from repository where name like '%repodata' limit 1;
    id    |                        name                        |           prefix           | directory_id
----------+----------------------------------------------------+----------------------------+--------------
 27707287 | pub/fedora/linux/updates/testing/23/SRPMS/repodata | updates-testing-source-f23 |        72549
(1 row)

mirrormanager2=> select id, name from directory where id = 72549;
  id   |                        name
-------+----------------------------------------------------
 72549 | pub/fedora/linux/updates/testing/23/SRPMS/repodata
(1 row)
```
Normally a repository points to the directory above the repodata directory.


I've defined this above, we need it to limit password changing to the "can_change_password" group. It's just our custom version of Django's AdminSite.


carrierwave with s3! awesome!!


Markdown is smart and lets you use just 1. as an indication of the next element in a numbered list. It's very handy maintenance-wise.


Explain this part... if we've already asked for motion (`askedMotion` is true) then we run `triggerMotionStatusUpdate` where `askedMotion` is set to true? This seems counterintuitive, don't we want to know when we *have not* asked for motion previously?


`MONITOR_DEFAULTTOPRIMARY`? Don't you want dpi of a monitor where window is?


:ok: :1234:


It didn't work before, i noticed model was being passed in is the model class and not an instance of the model. isinstance only works for objects not classes.


Why `typedef`? Are we going on C party?


Move commands below the step. E.g.

```
1. Create a new sample project named _myApp_.

    ```Shell
    tns create myApp
    ```
1. Navigate to the newly created folder.

    ```Shell
    cd myApp
    ```
```


Could you please remove dead code instead of commenting it out? Thank you!


This controls how many repomd.xml are listed in the metalink. Without the call to ```age_file_details()``` the number of repomd.xml entries would grow indefinitely. This is a central part of the metalink logic.


Cool use of `_.debounce` here, I didn't know we could define view methods this way.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 1045](http://build.osmsharp.com:8080/viewLog.html?buildId=5128&buildTypeId=bt16) is now running


webhook test


List the files. Don't assume the users are really keeping track of what they've created or done.


Apple say it is their most personal device yet to appear. (without "the" or without "their")


I guess this is for coming options?


basic state perhaps


Taken fresh from windows header which we can't include because of xp support.


Nice catch, thanks.


And on first read I didn't get the "for example it does not synchronize changes in its `value` property on the JavaScript side, coming from the Native world when the user interacts with the widget." part.


of handling / to handle


I guess I can change it to MONITOR_DEFAULTTONULL with rollback on error.


concrete - current


We probably have to decide if we move everything into UMDL or if we make a separate script for each functionality. Right now we already have multiple script which do repository maintenance, so that we could also move the cleanup to its own script. UMDL would then be the script which runs from cron and all other manual tasks are in separate scripts. Makes sense.


Ademas, incluso agregando el _ tendrias otro atributo con el mismo valor.

On Tue, Jul 28, 2015 at 1:06 PM, Gastón Avila <notifications@github.com>
wrote:

> @Juan33650 <https://github.com/Juan33650> Juan vos recordas por que
> agregaste este ID acá?
> Se está llenando con "" ya que datastreamrevision_id no existe (le falta
> un underscore).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/datal-org/datal/commit/95e4b39d317ead74d15e7118bb9f133705ff4515#commitcomment-12400204>
> .
>


HotFix-ReadVars-Diffs (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (729 of 729 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.13%25-green.svg)


Not really important, but last `,` in not needed.


Your last sentence is unfinished.


@Dwar3xwar DWMR (done with my review). Good here. Press on.


That was my train of thoughts as well.

I also prefer to have few scripts doing a limited number of actions rather than a big one doing everything. Give us more flexibility and in the long term should be easier to maintain (if we do it correctly and place the logic of the script in mirrormanager2.lib)


Yes, burns some cycles, but makes the code more comprehensible. Although, I have no strong opinion regarding this.


So that the new entry is not going to pollute diff view of the previous? Pretty much needed :p


I am beginning to think that this will become a very, very long and complex article. You might want to consider splitting it into a series with distinct Next: sections at the end.


@Dwar3xwar DWMR. Compact code. :+1:


That is probably why I didn't commit it back when I was working on this!


is it ever possible for size to be greater than SIZE_MAX? The other checks in the file are also checking greater than SIZE_MAX.


Yet the most exciting feature, typo


Added at e53bd0b2d6c02a73e7337258d12fa32d565de1ce


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.4.0.1045](http://build.osmsharp.com:8080/viewLog.html?buildId=5128&buildTypeId=bt16) outcome was **FAILURE**
Summary: Tests failed: 7 (7 new), passed: 540 Build time: 0:0:0
### Failed tests
```
OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Graph.DirectedGraphTests.TestGraphSerialize2: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Graph.GraphTests.TestGraphSerialize2: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Graph.GraphTests.TestGraphSerialize3: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Serialization.RoutingSerializationTests.RoutingSerialization: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Serialization.RoutingSerializationTests.RoutingSerializationCHEdgeData: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Serialization.RoutingSerializationTests.RoutingSerializationRoutingComparisonTest: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

OsmSharp.Test.Unittests.dll: OsmSharp.Test.Unittests.Routing.Serialization.RoutingSerializationTests.RoutingSerializationRoutingTest: Test(s) failed. System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.
   at System.IO.MemoryStream.set_Capacity(Int32 value)
   at System.IO.MemoryStream.EnsureCapacity(Int32 value)

```


@arw180 @SOAP1914 I made the changes per Alans comments and rebased/forced pushed my changes to this branch. Instead of extending the global array object I created a new MaxArray array object and extended that, so pulling the Maximum value from an array is now only part of that object.


Did iiiitttt


@Dwar3xwar DWMR. All good here. Press on.


You sure it was intended, or a mere oversight when the white ship was mapped? This looks a million times better, in my opinion.


This caused everything go stale besides maybe the first magic number found.


Anyway much better now, it works independent of translations!


Ok.


@Dwar3xwar DWMR. Continued success.


Массив из строчек в обратном порядке


need to complete the proper code up of this program


@igrigorik yeah, i'm not a fan of the special case there either, but i wanted to be as unobtrusive as possible; maybe not the best idea in this case. i welcome any and all advice on refactoring that.

please correct me if i'm wrong, but i believe the known-http2 over cleartext is already working? `nghttp -v http://127.0.0.1:8080/` and `ruby example/client.rb http://127.0.0.1:8080/` both connect directly over h2/cleartext?


#158 I think this fixes the cluster issue for the jump drive. How do I use this in my mod?


@Dwar3xwar  `<=` instead of `==` would be better. no need to change the code.


Done https://github.com/alexmarsev/mpc-hc/commit/28fafbf2efd825a391433c7abffc8bd19258a24e#diff-aacb12e26c12cc36a4ed6d7d2f32d3c7R48


Why? Remember to include the why, not just the what, in commit messages.


This looks good to me, except for the one very minor comment. I think breaking it up with just the case classes and syntax in one file and any other functions in the package helps quite a bit, as does putting DocVar in it's own file. I guess it didn't hurt the coverage too much.


@Dwar3xwar DWMR. Keep the momentum up.


Вот тут забыл вернуть итем стак. в итоге в руку попадал null


This magic `5` could be scalled?


:heart:


You seem to have a migration for a model that doesn't exist


We didn't do it before, so...
Will add it then.


@brandonly101 You aren't technically inside a core edit in here. Also, it is part of a different core edit. So yeah, keep this.


artwork is generally handled externally when it requires specific images etc.
you'd be best off creating a thread at http://forums.bannister.org/

the artwork folder we distribute is for very generic graphics only, this avoids any problems with image copyright and also allows people to distribute high quality images without it making our distribution huge.


You're not alone:
https://github.com/getmillipede/millipede-go/commit/0e9417bfc68071a33a02d0aa05498cc634bc828c

![](https://raw.githubusercontent.com/getmillipede/millipede-go/master/assets/millipede.gif)


nullptr or NULL instead of 0?


No longer true after #23.


programmer's


@brandonly101 This only confirms deletion for everything, but not individual items.


Done https://github.com/alexmarsev/mpc-hc/commit/b89eaa1a16ceb2896a8bfe2d8a708be49ca78e32#diff-c99efec2c7098c0a5c238e98be89aa14R924


Thanks for the heads up :+1:


how does Apple Watch differ from other devices?


Sorry, totally missed they were numbered.


@delta98 you reverted the change?

`gulp.src(paths.sass)` should be `gulp.src(['./scss/ionic-material-design-lite.scss'])`


Very nice. Coming along...

Question: Can we cut out a step and when the item is in the "right" place, it automatically places itself. Eliminate the need for an OK button.
Thoughts ?


saw approval from JeetKunDoug
at https://github.com/basho/yokozuna/commit/d09a6ffcf8fa048f3fcc2e10b490fce1424011d2


merging basho/yokozuna/bugfix/zl/fail-to-reindex-on-non-indexable-document = d09a6ffc into borshop-integration-527-bugfix/zl/fail-to-reindex-on-non-indexable-document


basho/yokozuna/bugfix/zl/fail-to-reindex-on-non-indexable-document = d09a6ffc merged ok, testing candidate = 16611614


Busted :D
I would prefer NULL, are you okay with it?


This line should not have been removed, but changed to:

```python
        f.readline().split()  # headers
```

I will open a PR to fix this.


Which apps should have a Watch extension and which are the most important concepts that should be clear when deciding to create one? (ONE)


Add `SWP_NOACTIVATE` ?


You'll probably want to wrap all these functions into an object so they're not hanging around in global space.


@Blackskyliner Can you please open a new issue with some steps to reproduce your issue?


This is not backwards compatible


I really should have, nice catch!


Could be const reference.


Validations should be in the model since the model should be the only thing that knows what makes it valid.


I noticed you use NULL for handles in your code. I'm fine with that.


@Markolie Given that it's the same style on -tg- and Bay, when both of those have shuttle windows as well, I believe so. I know I intentionally put the window spawners there.


Because handles are not really pointers...


FAGGIEEE


FAG FAGGGGGGGG FAGGGGGGGGGGGGGGGG

![](http://t2.gstatic.com/images?q=tbn:ANd9GcRPmI3zXZWcdrh7WyyJEIQ-f4WPhiGh7Z8msP1gI0R4BIrjatlF)


See https://github.com/Alamofire/Alamofire/issues/527


@notwaldorf why was this update made? This is causing an issue for me where my post body comes through as `[object Object]`, instead of a JSON string.  What's the best way to handle this?


I don't think `ApiClient` itself should change to an interface. I think it should remain a class that contains all the functionality it currently has, but with the addition of having a

```php
/** @var HttpClient */
private $httpClient;

public function setHttpClient(HttpClient $client) {
  $this->httpClient = $client;
}
```

and then the `HttpClient` interface would be:

```php
interface HttpClient {
  public function execute(...);
  public function useApiClient(ApiClient $apiClient);
}
```

then, in the `CurlHttpClient` class, or any other implementation of the `HttpClient` interface, there doesn't have to be duplicate functionality of maintaining header dictionaries, or handling any of the other stuff (api keys, for example, should not differ between implementations).

what do you think?


i think that the UX should work like this:
- clicking "RSVP" in the nav should always take you to `rsvp-search-view`
- in `rsvp-multiple-results-view` and `rsvp-search-results-view`, the "Search again" link should take you to `rsvp-search-view`
- we should probably print the response in `rsvp-confirmation-view` in a more human-readable way than a json blob?

i'm having trouble getting it to work consistently in my local -- sometimes searching turns up results, sometimes it does not, so haven't been able to consistently test the entire flow yet!


This should be in a different template file, so auto loading works correctly


Thanks. Looks like that does work. Why does Amount need to be a class
though? I still don't see the purpose of it.

On Tue, Jul 28, 2015 at 2:48 AM Bobbilee <notifications@github.com> wrote:

> this needs to be a class method so...
> def self.default
> end
>
> thats why u can't call Amount.default
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/voltaaage/Blocipedia/commit/8bed8d609a8eed5c5496308994b72080884e8303#commitcomment-12389799>
> .
>


Oh yes, I didn't mean to say that the window spawners weren't put there intentionally, but whoever designed the white ship so many years ago may not have had access to white shuttle windows or didn't know they existed. Either way, it doesn't really matter if it's intentional or not - I do think shuttle windows are an improvement over the reinforced windows as these are the windows that are supposed to go with the white shuttle walls.


You're gonna need 2-space tabs when this goes into Firefox, according to style guidelines: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style


Thanks, removed.


+1. I think that RULE_WEIGHT was > 1 in the past.


Isn't that going to fail for older Nix versions?


possible solution for https://github.com/dgageot/simplelenium/issues/10:
`CHROME(() -> new ChromeDriver(new ChromeDriverService.Builder().usingPort(9515).build())),`
Always starts a new ChromeDriver on port 9515


My experiences with rendering them to HTML output says that @details and the other tags ARE necessary. The Doxygen scripts get confused when they are missing.

Maybe worth asking: when an action will fix HTML but break Xcode (or vice verse), which do we prefer? We may have to give priority to one in order to keep things DRY.


Hum, maybe there was a good reason to not to use "hide" function...


ref #298


unrelated change?


No, because `inherit` is lazy (so it only fails if you actually use `genList`.


HotFix-ReadVars-Diffs (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1761 of 1763 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


hey, what's the point of this change?
This new key isn't in locale when the previous one already is + this var makes sense in the object meta labels for this placement and it won't necessarily be the exact same text as in global.facet.header
here it is on locale: https://www.localeapp.com/projects/7916/translations/4731039?in_locale=23833


should this change be squashed with the previous commit?


savior


Changed.


since one can not go without the other?


Always...but because of the assert(DSP == 0).  If it didn't enforce that, then a Halt would not offer an error to this.  Instead the error macros would keep passing up to the enclosing level.  (Or that's the idea anyway.)

If there *were* nested calls, then a catch/quit living in a higher call stack wouldn't get an opportunity...because this one would just OS_EXIT.  So the reason for the assert is basically because the caller isn't doing any CATCH/QUIT-ting because it doesn't have an RL_API for doing so.  Hence for quit to be caught, it has to be done in this routine.

Initially I tried to get around this, by putting the main quitting catch in RL_Init().  But if you notice the all-caps DROP_CATCH_SAME_STACKLEVEL_AS_PUSH, you'll see that I realized that does not work.  Don't try returning across setjmp/longjmp.  Anyway, this is why Ren/C clients like Ren/C++ need their hands on the CATCH macros.


Sorry. I don't know how I missed it in the swagger spec yesterday. It's fine then.


data.load() is addon-specific and synchronous. We'll want to use `OS.File.read()` in Firefox:
https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/OSFile.jsm/OS.File_for_the_main_thread#OS.File.read%28%29


Dammit, meant "master branch" instead of "gh-pages branch" in the commit description.


This record name should be `ddb_streams_stream_record` according to the [document](http://docs.aws.amazon.com/dynamodbstreams/latest/APIReference/API_StreamRecord.html), I've changed it.


maybe we should require and say that we install into same environment as borg and that the borg installation has to be done first. borgweb does not use any cython, so it is strange to have this here.

or we keep it completely separate...


Thanks for the quick move.

It works perfectly now.


Actually, maybe this is not a bug. The sniffer of the `gg` datatype was broken and got fixed in https://github.com/galaxyproject/galaxy/commit/fa7c5c531e07056cbf194b514ea9ccee5c214e18#diff-5cc3a3fc4993e14cc64a579a5b724234 as part of https://github.com/galaxyproject/galaxy/pull/454 .

In fact, `s/true/True/` and `s/false/False/` in `lib/galaxy/datatypes/genetics.py` for release_15.05 make Galaxy sniff `test-data/1.txt` as `gg` datatype.


![screen shot 2015-07-28 at 18 46 01](https://cloud.githubusercontent.com/assets/1495211/8937507/3556d63c-3559-11e5-9834-35a805a047c5.png)


Thanks copying the extra text across. My focus yesterday was on making sure that we had lean and meaningful comments on everything FIRST. That is why I left them out. I will test them in Xcode later.


Because these are preprocessing errors; they are written to stderr, which is captured in `Test/baseResults/preprocessor.cpp_style_line_directive.vert.err`.


The user cannot interact with them and if he taps on a glance then the app will be launched, where the user can interact. -> it doesn't sound before the comma


Good catch! It somehow got dropped during a rebase and became stale for a while. Thanks! Updated.


Thanks for your assistance.


Could really use some help text here


Okay, thanks for the clarification.


Looks good otherwise. Can't really test it or compile atm.


saw approval from JeetKunDoug
at https://github.com/basho/yokozuna/commit/d09a6ffcf8fa048f3fcc2e10b490fce1424011d2


merging basho/yokozuna/bugfix/zl/fail-to-reindex-on-non-indexable-document = d09a6ffc into borshop-integration-527-bugfix/zl/fail-to-reindex-on-non-indexable-document


basho/yokozuna/bugfix/zl/fail-to-reindex-on-non-indexable-document = d09a6ffc merged ok, testing candidate = 0bcae88c


file paths such as `payload_lica.json` should be in constants


Ótimo.


let's extract some of this out to it's own method in the model...

Maybe we can pass up "challenger" or "challenged" as a string to the controller instead and then have a method called, ```vote_for(challenged_or_challenger)```.

Then the +1's can happen in the model.


What is this for?


You'll probably want to store these payloads in `OS.Constants.Path.localeProfileDir` when you move this over to Firefox like we do with `directoryLinks.json` here: https://dxr.mozilla.org/mozilla-central/source/browser/modules/DirectoryLinksProvider.jsm#901


Hmm, looking at this a bit closer, the roadshow SDK as-is seems a bit dubious; it includes stuff like errno.h, which is already provided by the CRT. This seems a bit strange to me, and possibly a bit dangerous...


Yep, it's added here: https://github.com/dashpay/dash/blob/v0.12.0.x/src/main.cpp#L1566

The superblock is calculated to only allow the 10% of the minimum number of coins generated per month. I figured that was a much safer way to calculate the maximums. https://github.com/dashpay/dash/blob/v0.12.0.x/src/masternode-budget.cpp#L723