Seems like you intend to store user roles in `config.json` - won't this be better stored inside `memory.json` instead? Users always default to the lowest-level of access i.e. user with no roles.


muss \t3lib_div::
mist


Give that this is in the `RenderProcess`, is it possible for there to be a circular reference? If so should the change be made in the `BrowserProcess`? Much easier to report errors to the user then.


17 and 19 of the same line, you make a mistake?


수정 관련 내용은
https://github.com/sparcs-kaist/araplus/issues/9\
에서 확인하실 수 있습니다.


Not seeing why you would need `:users` and `:projects` here, when you only need `:projects` in [message.rb](https://github.com/myabc/openproject/commit/787a35c9db0e3de38b40cbd4d7c65cd8850275f7#diff-2be4d1bffeaeb1ee18de8b5e0ef20867R76). Both seem to be using the same where-clause (`Project.allowed_to_condition(...)`).

In general I am not sure whether the caller (of `Project.allowed_to_condition`) should know which references it needs. How about a companion method for that? e.g. `Project.allowed_to_references` that returns the references required.

But probably the best approach would be to route the caller through a single method doing it all, e.g.:

````ruby
def Project.clever_scoping_method(scope, user, permission, options = {})
  scope
    .includes(:whatever, :is, :needed)
    .where(Project.allowed_to_condition(user, permission, options))
    .references(:whatever, :is, :needed)
end
````

Client code:
````ruby
def self.latest
  scope = limit(count).order("#{News.table_name}.created_on DESC")

  Project.clever_scoping_method(scope, user, :view_news)
end
````

Of course you are free to dislike the silly names I chose, but I think you get the idea...

On an unrelated note: Wow, `allowed_to_condition` is a hell of a method!


Hey - you might be interested in https://github.com/chef-rbenv/chef-rbenv ; we've forked the original and applied various fixes for this and others. Pull requests would be quite welcome :)


I don't think that's correct... We don't want to remove the whole chroot on unmount (we still want to be able to access it).

A good way to fix this kind of bug is to start from a failing test: First, find manual instructions that trigger the problem, e.g.:
 1. create an encrypted chroot
 2. edit-chroot -l looks fine (chroot marked as locked)
 3. mount-chroot
 4. edit-chroot -l looks fine too (chroot is marked as unlocked)
 5. umount-chroot
 6. edit-chroot looks fine (chroot is marked as locked) <=== This is where the bug should trigger, if I understand correctly.

Once you have manual instructions, update the test in tests/test/12-edit-chroot to cover this case (it is really extensive, but it seems like we forgot some things...). Run the test => the test fails. Good. You solved half the problem here.

Then, I'm not sure where the problem is. If unmount-chroot does not lock it back, or if edit-chroot does not report the status properly.


Code から明らかな場合は、自明なコメントはつけないほうがよいです。
```
line.split(",",0);
```
で十分意図が伝わりあmす。


This bit essentially lets us define which version of XAudio we want to use in a precompiler definition. The next commit specifies the default as 2.4, which is the earliest version that I can confirm that works properly. (Note that I am testing in wine, which means that earlier versions might actually work just fine. Still, I would recommend defaulting to 2.4, 2.5, or 2.6, as this ensures compatibility with wine.) I do not recommend using 2.7, as the DirectX web installer will sometimes not install 2.7, nor does it work with wine out of the box; and I do not recommend using 2.8, as it is only available in Windows 8 and above.


I have to remove this because of line 269 added it back before start the interaction.


I think this is missing an 'authenticated' check.


Should this be 'res.json(result)'?


(Having this sort of change split out into it's own commit makes it so much easier to review :+1:)


miss the copyright.


alpha sort?


Line feed is not needed.


extra spaces.


ditto.


ジャンルは genre_id (Integer) で管理するつもりでした。
つまり、Book には genre_id を持たせて、ジャンル名を参照するときには、Genreからgenre_idを使って name を取ってくる予定です。
そうすることで、表記ゆれの防止やデータの独立性を向上の効果があります。


line feed is not needed.


```JavaScript
res.json({
    message: 'Success.'
});
```


```if (mBridge.mNativeContentsClientBridge == 0) return;```


My comment above provides a way out, otherwise you might want to add `references` to the list of things to "remove from here"


This becomes "ServerId({})" instead of "Server({})". Not sure which is better here...


You might be interested in https://github.com/chef-rbenv/chef-rbenv - a few of use decided to fork the original repo as a group. Pull requests etc very welcome :)


alpha sort.


Tab was used.


Need blank line after this line.


Extra line.


one space is needed after ```)```


need 8 spaces.


this works fine


please adjust the indent.


Et un nom d'utilisateur avec un espace ça choque pas ? :p


tab was used.


``if (!encoded_chain_ref || !private_key_ref)`` or ```if (encoded_chain_ref == nullptr || private_key_ref == nullptr)```


You are only stopping the container if taking the screenshots succeeded. The container will remain running if something goes wrong somewhere. Even if it gets stopped, it will never be removed. If you consider this a feature, not a bug, then you should also list existing but stopped containers up front, and try to re-use an existing selenium container if possible.


@NobodysNightmare as a very general note, the best solution is to replace SQL strings with condition hashes, wherever possible.


extra line.


cool, thanks.


hp15adl.htm update
01hp15adl1.htm 大友さゆり 川上ゆう(森野雫 原幹恵/01good 原幹恵/01good/02jyouou
大友さゆり, 川上ゆう(森野雫), 原幹恵/01good[02jyouou](蒼井そら)
02hp15adl2.htm root 原幹恵root exptSubdir
03-


I wonder if instead of 'roles' you should use 'acl.options.buckets.roles' here.


multiple?


genre_id への変更に伴い、ここも修正忘れずにー


y u commented


I am not sure for which condition you are referencing the `:users` here.

Probably we should agree on a best practice to always put the `references` immediately after the corresponding `where` clause.


Does the formatter insist on the newline before `unwrap`?  Better to get rid of it if we can, for consistency (and searchability of the codebase).


コメントに
```java
/*nearest neighbor*/
public static void Tour()
```
と書くよりは、関数名にそれを反映させたほうがよいです。
```java
public static void nearstNeighbor() {
```


yup, good catch.


yeah, good idea. we keep using this in all our other projects.


This commit seems to have caused the Travis build to segfault immediately after the dynamic_50 test (with gcc and clang):
```
Testing: dynamic_50 [sha224($p) 128/128 XOP 4x]... PASS

make: *** [check] Segmentation fault
```
So, now we fail faster on Travis.


- no need to prefix it with "b" - prevStateFail is sufficient name
- it is better to use the same as what you compare it with. E.g. you do at the bottom "!success && !prevStateFail". More readable it is to write "!success && prevSuccess"


@Whoaa512 my editor was definitely doing some funky stuff here. Thanks.


```
 Length = 0;  // 距離
```
コメントをつかうのではなく、変数名にそのコメントを反映したほうがよいです。
```java
total_distance = 0
```
のほうが良いです。


I was kind of expecting the only call to `getAbbr()` to appear in the custom Hibernate type, purely for use in the database.  Why are we dealing with Strings here?


I prefer it when dealing with something that's really a list. and when the fact it's eventually a string is the less interesting part.  This probably isn't the best example given the `%w{}` syntax, but being able to do things like splitting arrays over multiple lines can make for easier additions and cleaner diffs.


Again I don't see where this `references` is needed.
If I understood it correctly, you only need references if you use the corresponding table in a `where` clause. And also only, if you don't have a where clause that makes it explicit. E.g. the following does not need a `references` clause, but the `includes` still seems to be required:

````ruby
WorkPackage.includes(:type).where(types: { id: 4 }).first
````


Actually my main concern is that `rm -rf` may accidentally remove lots of things. Doing `rmdir "$CHROOT"` would be much safer.


uytu


for loop の中身が複数行の場合は {} をつけるのがいっぱんてきです。
```java
for (... ) {
  ...
}
```


Likewise, the only place we should need to call `EntityType.getValueOf()` is in the Hibernate conversion code.


FYI @catong


@andrew do you remember why this change was necessary? Why do we need (long) and (double)?


I could not directly test this with libxml2 2.7, because the lxml tests won't run:

    ImportError: dlopen(/Users/opottone/omat/code/lxml/src/lxml/etree.so, 2): Library not loaded: /opt/local/lib/libxml2.2.dylib
    Referenced from: /Users/opottone/omat/code/lxml/src/lxml/etree.so
    Reason: Incompatible library version: etree.so requires version 12.0.0 or later, but libxml2.2.dylib provides version 11.0.0

However test in C indicates that libxml2 2.7.2 works like the latest version. Git blame tells that `xmlCtxtResetPush()` has had encoding detection since 2003-10-28.

The BOM handling here is somewhat wrong, though compatible with libxml2 also being wrong, so the end result is correct. Let us say the encoding is little-endian UTF-16 (with BOM). Then `xmlDetectCharEncoding()` will say it is UTF-16LE, which it is not. UTF-16LE and UTF-16 are two different encoding schemes; UTF-16LE does not have a BOM. Assume libxml2 actually gave the correct answer, UTF-16. When lxml strips the BOM, the mechanism for distinguishing between little endian and big endian is broken.


okkk


I remember I wrote this :tongue:


コメントを使用するのではなく、`min_j` をわかりやすい名前にしましょう。


Shall the flag of Gaethology stand on the land of AOSC! (foggy) @biergaizi


What about *Base*


Java では boolean の配列は 自動的に false で初期化されるので、この行は必要ないです。


This is a special one that doesn't touch pointerification, but we could certainly do with some refactoring..


Je ne vais pas toucher à analyse-R pendant quelques jours (plusieurs
réunions et déplacement). Donc coit libre de faire des modifs.

Précision : s'il y n'y a plus de préfixe, il faudrait peut-être au moins
ranger toutes les figures dans un sous-répertoire "knitr" de "images" (et
peut-être tant qu'à faire créer aussi un sous-répertoire "captures" pour
les captures manuelles). Ainsi, on pourra effacer le contenu de
"images/knitr" dans le fichier Makefile.

Cdlt

 Joseph

Le 7 juillet 2015 23:30, François <notifications@github.com> a écrit :

> Si tu as envie de t'amuser en jQuery... ;-)
>
> Je vais y réfléchir :P
>
> NB : il me semble important d'être uniforme entre tirets haut ou tirets bas
> dans les noms de fichier. Il faudra faire un choix et éviter tout mix des
> deux.
>
> Vu que la racine du site utilise un tiret, ce serait plus cohérent d'avoir
> des tirets partout, je pense…
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/larmarange/analyse-R/commit/c2b0066fffbaac6a1800babecdcb811e814f0835#commitcomment-12049007>
> .
>


/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package helloworld;

/**
 *
 * @author lucas
 */
public class HelloWorld {

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        System.out.print("HelloWorld");
    }

}


You can create the color binary in to_edges_raw, you will never need to update it.


Absolutely not clear to me why you need to specify the `references` here...


I'm not quite sure of the status of upstream raster support. I know there was extra work needed on the firmware side for the Arduino.
app_raster.js is part of Stefan's work and I think it is intended to support a hatch like raster fill of polygons (text, polys etc).
For my raster implementation you need to import a .png file into Inkscape as embedded data - there is no additional option in the UI.
Please see the youtube link here for a quick example:
https://www.youtube.com/watch?v=yWbxf66_u_o


Why do you use this kind of constructor for the base page? Do you think it is common for all the pages you have?


Really, not obvious that your variables are parts of the url


Please. Rebase and remove this commit.


How about `^` —> `~`?


create separate class to validate


Why this method is void?


Can you check if IE 9 is catched as unsupported_browser_ie.
I prefer you remove the code if not needed.


<!DOCTYPE html>

<meta charset=utf-8>
<title>首頁</title>
<link rel="stylesheet" href="index.css" type="text/css">

World War II

歷史沒有消失，只是被遺忘

首頁

二戰傷亡表

二戰德軍

copyright

made by Joe


Thank you. Your PR helped me to forget about segfault :)


Please, add reason of the failure to the log


Currently it is more common than an ion storm (15) and as common as anomalies.


`notauthorized` is commented out - is this intentional?


comment was left here


`getDriver()` method is a better place to add this log message, isn't it?


`l` がどういう意味で使用されているのか、一見、わかりにくいです。
// 交差がないように
というコメントはここではあまり役になっていないので、（それは `notcross` が使用されていることからほぼ自明）、それよりは、 `l` がどういう意味で使用されているのは説明したほうが、助かります。


typo


couldn't they be just this?

    eqTests["add"] = ()=>pair(parse("1 + 2").ToString(), "3");


SALUT


It was a good while ago, but I seem to remember it complaining about that during compilation, not sure if it's still needed.


saaamsaaami


there is no situation when you need to work with HTML in the test itself. This should be a part of the page class


This not my code as far as I remember. Clean it up as you need, no problem


Alright! Let's review that together then ;)


Same as above - encapsulate all that related to the visual representation into page - this way you'll be able to update locators just in one place in case of UI changes.


@ytokas  please review


typo `currentUsed` -> `currentUser`


So thats why I couldn't find it. Thanks for the video; I'll try it later today.


インデントの量などが、おかしいところがあります。


Ok, because I am now [cleaning up C++ namespaces and some headers](https://github.com/sass/libsass/pull/1310) and I was wondering why aren't we just using normal [int std::abs(int)](http://en.cppreference.com/w/cpp/numeric/math/abs).

Don't want to (re)introduce  bug though. If this is just a compilation problem, will go ahead.


interesting construction, but the common use looks like this:
```java
switch (authorize) {
    case "authorized":
        String name = authorizedUser();
        list.add(name);
        break;
    case "not authorized":
        // do something
        // you are free to use more than one line of code
        break;
}


全体的に空白いれたほうがよい部分がそこそこあります。
Java のスタイルガイドなどを参考にしてみてください。
```
private static void printTour(String outputfile) {
```


Ezt még fordítsd le, kérlek.


well we can have multiple routes. the one which will go into _self variable will be named, so we can remove entity inner knowledge of it's route
check api/app/Models/BaseModel.php
i removed entityRoute()
so the config of the route will be here in routes.php and we define the route also here in one place

if we leaving it like it was before then in case we want to change the route for the entity we will have to change it inside Entity


`print` という言葉は、なんとなく、「標準出力への出力」を連想してしまいますので、ファイルに書き出すのであれば、使用しないほうが無難です。


Yeah it wasn't due to any sass related bugs, I think you'll be fine to carry on and clean it up.


логгер не будет работать как CommonJS модуль или глобальная переменная. Погугли про universal module definition (UMD)
я бы ещё добавил реализацию функции noConflict (как в jQuery) чтобы была возможность не перезатирать глобальную переменную


Why do this?


Think about polymorphism... Is there something that prevents you from being able to work with `LinkedList` for example?


можно создать для appender функцию-конструктор, в которую передовать реализацию конкретного appender. Получится более абстрактный код в контексте ООП


Spider简介


please DO NOT send you code for review until you are done with all the changes, and tell this to everyone.


где взять http? используй XMLHttpRequest


не забудь послать сообщение


продумай добавление события не только к window.


Indentation is broken...


It was not the point of setting maven.remote.repo.

It is basically to tell maven where to look for the plugin for the first time before we have http://mavenrepo.openmrs.org/nexus/content/repositories/public in settings.xml in order to download the plugin.

To test it you need to drop your maven local repository at ${user.home}/.m2. And try running the setup.

So you need to remove it from here. It's not a property for our plugin rather for maven.

Please see http://stackoverflow.com/a/1193664


подумай, как это всё можно связать, чтобы вернуть из модуля только функцию-конструктор (используй прототипы). Все методы, что ты вернул из модуля, нужно добавить в логгер. Обычно экспортируется только одна переменная (в нашем случае - функция-конструктор Logger)

не реализованы задания: 9,12


luolinhan


I know, too. I have had to fix many problems of pdksh myself. And this is the reason why I have an interest in mksh. ^^


@NobodysNightmare is it?


i think, that it is no need in list of projects or reports. u can insert single record in database.


加个空行。这两个之间完全没有关系，加空行看起来更方便。


Here after enqueue(7), when check first number of queue, there is problem, it display None, not 7.


```fl``` がなにをさしているかわからないです。:)

```c
bool visited;
```


Ok, I see


very first contributions. All after that time should just say Red Hat.

Browsersim for sure is 100% red hat on the initial contribution/work.


If you do this, then PHP bug 55169 is irrelevant and you may use just `if (defined('MCRYPT_DEV_URANDOM'))` above.


Haven't added all constants. Need to add them.


Generally, you can try to use `@ClassRule` instead of the `@BeforeClass` and `@AfterClass`, the same thing with `@Before` and `@After`.
And one more: what happen with idea to check whether the user is logged in after the test and dynamically add it to the cleaning list?


k


Why do this?


It is remotely possible that this unwrap will get the error case from the reregister. In such case, the warn message will be a lie. It was able to read, it wasn't able to re-register. Considering the cause would be much more interesting for debugging, it might be better to do some more verbose error handling.


Without this commit trying to execute AddContest.py contest -U would result in an error "Contest already exists in database".


there is no need to initialize list of result wrappers. you should do something like following : List<ResultWr > resulyWrappers = pageHTML.doParse();


Assume you tested this


Note that by using `List<>` directly, you cannot call `make_sequence<int_<0>, 2, next, std::pair>`.
You may create a `list<int_<0>, int_<1>>` and then replace it by `std::pair<int_<0>, int_<1>>` to fix it.


= の両側はスペースをいれるのが一般的です。
```c
int point_num = 0;
```


use `String.format` - it will solve your issue


You should have this set to NULL in order to be sure that it was `openssl_random_pseudo_bytes()` that set it to TRUE when you call it.


What about a solution wherein I would show all the files within an event (and checkboxes next to it) in a tree view like:
* Top Folders
    * Folder1
          * File1
    * File1
* Sessions
     * Folder1
           * File1
     * File1
* Contributions
...


@hajoeichler this is how u wanted or?


Are mare bhai this app is not working.


Backward compatibility apparently...


Please give me best way to run shipping webservice api


Use Date/Time API from Java 8


Again, the length check kind of makes the `$buf !== false` one useless. :)


Sounds a bit complex... and lots of clicking if you want to get e.g. all slides folders from everything in the event.


Actually you can easily run a js code like this:

```js
(function(){var s ={}; s.a = s; return s;})()
```

For example in a EvaluateScriptAsync call which makes the render process crash. At least with this change this won't happen, of course the serialized result will be {a:null}. Maybe it would be a good idea to transfer this as an error, like it could result in a failed Task. I'm not sure.


Native screenshot's extension should be "png" - it is mentioned in documentation


ok


Remove hardcode, I could have no drive "D" on my mac, but I still want screenshots


Ah you want the comment readded - well its there to be picked - note: https://github.com/joomla/joomla-cms/pull/6234#issuecomment-81148739


`FileUtils` class is not a part of JDK


Do you really need `Description` as a parameter to this method? I mean you're only using test method's name from it. What if you'll need to take screenshot in some other place, where you'll have no `description` object?


I'd use `extension_loaded()` here instead.


那就叫临时牢房吧。
在游戏中，这种牢房不能增加可用牢房数量。
参见 http://www.bilibili.com/video/av2362215/ 中效果。


> ensure swagger-ui remains reusable for our many teams that aren't using LoopBack, but still leverage swagger*

That's a valid argument.

I would personally ask the other teams to join multi-line values themselves and produce valid Swagger descriptions, because AFAIK, Swagger Spec 1.2 does not allow multi-line values via JSON arrays. But then I understand that such change would require extra effort with low ROI, thus I'll add support for multi-line values to our fork too.


Please, remove 'p_' prefix from parameters names. This style is differ from code style of project. It rather important because customer can think, that this code was copy pasted from another place and refuse to pay for this work (on real projects)


I think you should set your file encoding to utf8 first and see if that makes a difference before doing this.


This needs to take a write lock since we are incrementing `peer.localRefCount`. Otherwise concurrent calls to this function for the same peer will cause havoc.


Why do this?


Check for white spaces. Example, where they should be :
{ get; private set; }


+1 for using Handlebars logic


`# -*- coding: utf8 -*-` add that to the top of the file


I will update to use `viewForKey:`. I saw @albertschulz did that but I did't pay much attention to it because it is not related to PR but now I see.


Nice to meet you. I had tried to contact you with mailing list. However, at that time, it was temporary unavailable. Anyway thanks for your concerns.


sometimes get crash here
```data parameter is nil```


No need in white space between types in map declaration


SinThis is not important, but ... the comment here is a bit "wrong". It doesn't matter if it is FALSE; rather, in the same spirit as your result length checks, it matters because `$buf` may've been set to a string that wasn't returned.

Also, this doesn't need to be inside an `if`. :)


done


985行还都是看守长。


LGTO


Just to avoid rejected pull request. That's how it should be done. In your case you again are broking exsiting implementation, because e-mail can be optional field. What you have to look at is
https://github.com/LiveHelperChat/livehelperchat/blob/master/lhc_web/lib/core/lhchat/lhchatvalidator.php#L58

There is cases then same field can be requered, and then it can be optional. Making checks your way just will break existing functionality. My plan would be just modify this method. And instead of Errors[] = 'asd' set as
Errors['field_name'] = 'Error';

then in templates just check if isset (Errors['Username']) ? 'Rest of your logic'. This way it will be available everywhere and won't break anything. Same way you can add error outline also to additional fields etc.

Hope it helps :)


Thanks for this clarification! After going back and forth over the parsing logic and the QueryBuilder implementation I got confused where the EmptyQueryBuilder was supposed to be returned automatically.


I see, the examples make sense. Since the image is set via CSS, I am thinking about embedding the image directly inside CSS via [data URIs](https://css-tricks.com/data-uris/). Can you see any reason why that would not work for you?


Meant to write it in appium-support PR.


ok fefar


Actually, it's kind of important that it's not inside an `if ($buf === false)` (because of what I wrote above)


Sudo's commits are already pushed by gerrit on mainstream, he just merges them in his repos, in fact this one is already applied in my sources.


Alright!


# datasciencecoursera
This is a repo for COURSERA's "The Data Scientist's Toolbox."


title should be Mashape_Analytics everywhere to keep consistency.


Wouldn't it be more useful to log `res.statusMessage`, or perhaps both?


same


Try to avoid id's to identify elements. Since we're working in the limited scope of a view, this usually isn't necessary. This way you can avoid hard-to-debug things like id collision


似乎Alpha 34更新后算容量了，你可以试试


I was thinking that this `Browser->Render`, rather than `Render->Browser`, so that's my mistake.

It does raise an interesting question. Returning an error gives for a more explicit behavior, though this behavior is likely consistent with some `serialization` implementations. Something to ponder.

At some point I'd like to rename these from `Serialization` to something a little more accurate.


ok


Hook for selenium tests in the form of dummy style class.

Any idea about better way to do it? I need something to be able to find specific element (the div containing the table in this case) in the sea of nameless divs.

DOM element's ID attribute would be ideal, but AFAIK gwt doesn't enable assign unique ids in UIBinder templates. ID can be set with widget.getElement.setId("bla") in the procedural code, but I'm not sure how to make the id unique (because more DataSetEditors can be opened at any given moment in UI). Perhaps adding some UUID of the data set def? But then I'd have to inject stuff and complicate the stuff unnecessarily. Hence using the dummy css class name.


不如放在source->can_publish()里面检查，可以把vhost_is_edge传进去。
因为再加一个proxy_can_publish函数不是很明确到底是干嘛的，
相反从函数职责上讲，can publish就包含了origin和edge两种情况是否能publish。


It's a good thing that you check for required options.

The && should be replaced with || though or it will throw an exception when options is undefined


@hussainweb I am sorry i will make sure this wont repeat!


sorry, I was messing up with hybrid svn/git local repo -_-


This is perfectly fine but the new best practice is to bind events like this:

```
this.listenTo(this.model, 'change', this.render);
```

It basically does the same thing, but it will automatically stop listening to events on this model when you remove the view. It hasn't always been available in Backbone so your course might still use it like this.


These methods were taken from Reimporter.py. I'll try to refactor it, but not sure when this will happen.


based on http://www.snippynotes.com/note/2


Nice that you extend the appScheme here, makes the ap-object more complete in the background without noise.


Since `cumulative_weight == midpoint` is also checked below after the loop, why do you call `i += 1` here? Can you just ajust the `middle(v[permute[i-2]], v[permute[i-1]])` expression?


It is, at least looking at it via github:
````
+              where(find_conditions)
+                .includes(searchable_options[:include])
+                .order(find_order)
+                .scoping do
+
+                ~~results_count = count
+                ~~results       = all
+
+                ~~if options[:offset]
+                ~~  results = results.where("(#{searchable_options[:date_column]} " + (options[:before] ? '<' : '>') + "'#{connection.quoted_date(options[:offset])}')")
                 ~~end
+                ~~results = results.limit(options[:limit]) if options[:limit]
               ~~end
````

You see? The last `end` is not aligned with the start of the `do`, but with the `where`.


I'd make it an `else if`.


Haha, why...


This is definitely not Groovy way ;-) Please use GStringImpl instead.


@bwo Hello! I'm the original author. Unfortunately, this package hasn't received the love it deserves so when we released servant 0.4 with multiple content types support and what not, some problems might have gone unnoticed. I will gladly look at any patch that improves on that! This is a good first step but I'm hoping someone with a good knowledge of JS/jquery can make the package support arbitrary content types, eventually =)


I'd make it an `elseif`.


Then, should I test MZ/LX//NE magic only on OS/2 ? OS/2 cannot execute any other exectuable format.


Same here.


毎回、malloc するのは若干違和感があります。きっと使用するメモリ領域を節約しようという思いからきていると思うのですが、malloc はできるだけ呼ぶのを避けたほうがよいです（遅い かつ エラーの原因になりがち）。

1. 一回だけ double * point_num サイズだけ malloc してそのメモリ領域を使いまわす。
2. あるいは `coordinate points[POINT_MAX]` や `path[POINT_MAX]` のように一度だけ割り当てておく。その場合は、point_num じゃなく、POINT_MAX分だけ割り当てておかなかればならないので、無駄ですけど、こちらのほうが速度的には早いです。空間と速度のトレードオフです。


This one needs a real clean up.


Why do we use the $PKGDIR version of xxx.pl? because this scripts may update.
Please revert it.
The modification in base-perl/perl-xml-parser is acceptable.


Try to play a bit around with the "wait" option. This will delay the action (updates, creation of models, removing of models etc) until API request returns with a success. It makes the interface less responsive but also makes error handling easier. We've implemented some helpers in our codebase to make working like this easier so you'll get there soon enough :)

```
this.model.destroy({wait: true});
```


Погуглю


Regarding Usage: I'm running Atom 1.0 and in Settings->Packages there is no Settings. So does "Atom's packages management" not mean going to Settings->Packages?


this working??


Осознал


@Icenowy I believe you have misread the commit. Instead of making the scripts on the fly, he created them before the build, in ```overrides```.

And yes, keeping them is useful, and updating is just not an issue that's to be worried, at all.


Your [colour_with_cluster_means] is gone in test_slic.cpp


Looking to see if Fortran will work at all... hoping for it.


Try to avoid assigning IDs to elements. This is usually not needed when you've set up your app correctly.

Tip: there could be other types of models that have the same id, resulting in id collision. It's better to use "this.model.cid" as it's always unique within your app.


感想ですけど、ここで再帰を使用するのは、珍しいなーと思いました。こちらのほうが好みですか？


@ChessQuake - is something similar already happening here:

// Adjust bonus based on the king's proximity
            ebonus +=  distance(pos.king_square(Them), blockSq) * 5 * rr
                     - distance(pos.king_square(Us  ), blockSq) * 2 * rr;
@Rocky640 let's see!


Unfortuantely, this is required on OS/2. As you know, we cannot force users to create shell scrtips with LF-only line ending. Anyway thanks for your note.


@isuriupeksha be careful next time, the syntaxes for assigning roles have changed


Nevermind then, in case let's do follow up commits.


Can you make pull request?


why does this need a form ?


Well if you take a look at the other side there is the same kind of solution applied for .net objects. But it just hit me it doesn't really make sense as we only convert value types there. I'll remove it.


:+1: nice tests


@jushe
I adjust the function name from `clearPiece` to `ClearPiece`


Using a global selector like $("a[href='clear']) for the click event handling leads to an unwanted side effect: Each time the "init"-method is called, another callback function is added to the $("a[href='clear']) object. Whenever the user clicks one of the anchors, all these callback are executed, which imho is not what we want to achieve here. By using an object which only points to the newly created anchor, we can make sure that a single callback function is executed with each click.


No worries!


使用されていない？


Это имплементация задумывалась такиом образом что сам логгер оперирует только сетом лог левелов и мифическим рендером который умеет формировать правильно мессагу, рендер в свою очередь имеет массив апендеров которые умеют эту мессагу куда-то складывать. при необходимости расширения в лбой логгер просто скармливается кастомная реализация рендерара, или в рендерер кормится массив кастомных апендеров если, например, писать логи на ремоут. Т.е. тут фактически засэтаплены контракты взаимодействия компонентов и их ответственности, не думаю что создание рендерера и апендеров сильно напряжная работа при использовании логгера, да из коробки он вполне мало что может предоставить.


ok


NewParserBatch is not speaking name.


Косячек, апендеров тут нет, должен быть просто ретурн строки.


Просто для понятности разнес в 2 строчки, так вобще просто функция конструктор должна быть большая.


pageSettingsName should be a constant


Not sure what the "standard" is for this but it's better to bind these events after you render this view. Otherwise you might end up rendering things in a container that doesn't even exist yet


no need in white space between types declaration in map


Don't forget to update the Wiki, as this will prevent access from outside. I can imagine a lot of issues on 'why can't I connect' :-P


Will this come bcak to `path`?


But aren't most filters that affect S3 based on subdomains?

    ||s3.amazonaws.com/draftset/banners/

would be the only filter affected by that override in Fanboy's Ultimate list, I didn't check the other lists, but most seem to match subdomains (```||analyticsengine.s3.amazonaws.com^``` etc).


I think it's cleaner if you keep track of views like this:

```
var view = this.views[todoItem.id];
if(view){
   view.remove();
   delete this.views[todoItem.id];
}
```


下の for loop でまとめてやったほうがよいかも。

```c
double min_total_distance = なにか大きな値;
for (int i = 0; i < point_num; i++) {
    visited_point_num = 0;
    initialize_fl();
    total_distance = solve(&points[i]);
    if (total_distance < min_total_distance) {
        min_total_distance = total_distance;
        start = i;
    }
}


On Tue, Jul 07, 2015 at 10:50:40AM -0700, Vittorio G (VittGam) wrote:
> Protocol is actually documented [here](http://www.tinc-vpn.org/documentation/tinc.pdf). There's also a beta version of tinc described [here](http://www.tinc-vpn.org/documentation-1.1/tinc.pdf), but it's not been finalized yet.

Nice job! I'll add a reference to that document in the
source.

It's not clear to me how we end up with the first message
starting with "0 " though; I'm guessing that's implicit in
the sentence "Each request has a unique number and several
parameters" (p32), but I'd think that's lacking of an
example as sequence numbers are not mentionned again in what
follows. My understanding is that you'd get messages in
ASCII like:

> 0 ID tinc_client 12
< 0 ID tinc_server 12
> 1 META_KET ...
< 1 META_KEY ...
[..]
> 5 ADD_EDGE foo bar 21.32.43.54.655 222 9
> 6 ADD_SUBNET foo 192.168.1.0/24
> 7 ADD_SUBNET foo 192.168.100.0/24
...

and "0 " is just the mark for the first message... and in
fact I guess it always starts with authentication so we
could probe for "0 ID " instead.

If that's the case, I think that should be clarified, maybe
with a complete example of a session establishment. If
that's not the case, well, that's at least one persone who
doesn't understand the protocol description ;)

Probably the fact that messages end with CR (or CR/LF,
or...) should be better specified.

Disclaimer: I only had a quick look at the document, so I
might have missed answers to my questions.

Cheers,
Y.


It's not necessary to pass a model to collection.create(). Just pass the attributes:

```
this.collection.create({
   title: ...
});
```


I think weight should be sum(weight) here


Uhm, sorry, this is nothing weird. If you "local" the variable inside of an if, it will only exists inside of the if. This also happens with other blocks, e.g.:

```
$ lua -e 'do local i = 42 end print(i)'
nil
```


should n() be sum(weight)? Note weights don't necessarily sum to n - we shouldn't assume anything regarding what they sum to


elseif does not follow Moodle coding style: https://docs.moodle.org/dev/Coding_style#If_.2F_else


When initializing constructor with too many parameters, put each parameter from a new line with 1 tab.
Example:
HtmlParser.NodeWrapper nodeBody = new HtmlParser.NodeWrapper(
      String.valueOf(parsingConditions.get('startTag')).replace('&','"'),
      String.valueOf(parsingConditions.get('tagName'))
);


Hello!

Why we can remove --no-scripts when we use capifony_copy_local? I want to deploy on lot of servers et want to centralize the build of our deployment? I don't want to overload my web servers to build when I have a dedicated deployment server to do it.
How can workaround?

Regards,


Please add one space after commas in function parameters.


Looks like this commit can be backed out. A better was my made in this PR and extracted into https://github.com/sass/libsass/pull/1312.


you should declare valid_transaction in this context.


@NobodysNightmare this seems to be a bug with rubocop. I've reported it here: https://github.com/bbatsov/rubocop/issues/2021


and invalid in this context.

It will be much easier to find proper let declarations.


I think SCRIPT_PATH is wrong or not even necessary?


Comment should have the same indent as the body of the function.


I think we don't need node_js in linux, right?


fixed


Doesn't one of the lines 310 to 312 need to be the other way round? Either 310 should be >, 311 should be descending, or 312 should be last I think


The default is not 0 on my Windows box, and apparently not in Linux either: http://www.diag.com/reports/TCPWindows.html


KO Myung-Hun dixit:

>Nice to meet you. I had tried to contact you with mailing list.
>However, at that time, it was temporary unavailable. Anyway thanks for
>your concerns.

Hm, this sounds like you use Googlemail, or another of those
providers that are too stupid for Internet eMail.

Try writing via http://news.gmane.org/gmane.os.miros.mksh in
that case. The GMane webinterface may trash non-ASCII characters
occasionally, but at least the messages arrive. You can also read
and post via NNTP there, which is the technically best solution,
if you can do NNTP.

bye,
//mirabilos
--
“It is inappropriate to require that a time represented as
 seconds since the Epoch precisely represent the number of
 seconds between the referenced time and the Epoch.”
	-- IEEE Std 1003.1b-1993 (POSIX) Section B.2.2.2


Thank you Mathieu.
Could you make the following modifications:
  1. make the pull request on the "devel" branch,
  2. use upper case for cmake commands for homogeneity.


Good idea!


No you cant leave null value. That was out of the blue. But its ok.


Here's the real addition of this commit.


この下の for loop ふたつ、ひとつにまとめたほうがよいかも。こちらのほうが一般的です。

```c
    int nearest_point = -1;
    double nearest_distance = なにか大きな値;
    for (int i = 0; i < point_num; i++){
        if (dist[i] != 0 && points[i].fl==0 && dist[i] < nearest_distance) {
            nearest_distance = dist[i];
            nearest_point=i;
        }
    }
```


Why do this?


Isn't a `force` strategy still needed, to allow updates that overwrite uncommitted data, the opposite of `GIT_CHECKOUT_SAFE`? For example how would you force a merge that would overwrite uncommitted changes, in case you want to?


Feel free to do so :+1:


And it is very useful, I have adopted it as a pattern now but I have in mind a couple of modifications.


Merge branch 'master' into staging


good！


Вот сет оправданий :)
5. As a developer I want to have an ability to send log information to abstract Web API endpoint.
Не стал это реализовывать по причине того что очевидно что нужно просто отнаследовать базовый апендер и реализовать в нем отсылку мессаги на ремоут, потом его скормить в конструктор рендерера.

6. As a developer I want to have an ability to select from built-in logging methods.
В дэфолт логгере есть стандартный сэт: инфо, еррор, фатал... Или здесь про что-то другое?

7. As a developer I want to be able to extend the library with custom logging methods.
Наследуется дэфолт логгер (или базовый) и в прототип пилятся новые лог методы.

8. As a developer I want to library to automatically log all unhandled client-side exceptions.
9. As a developer I want to have an ability to extend library with my own instrumentation methods so that the library can monitor not only exceptions but other events too.
Два пункта сразу. Не совсем понял что тут конкретно по академической реализации требовалось, а по-хорошему это не очень хорошо когда логгер сам подписывается на события и реагирует на них. Нужно залогировать событие - используй логгер в своем обработчике. Не видел смысла держать коллекцию ивентов и их обработчиков в логгере т.к. это не его сфера ответственности. Если есть вполне разумное оппонентное мнение то готов выслушать/посмотреть бест практики.

10. As a developer extending the library with my own logging or instrumentation methods I want to have established contracts in a form of base class of API documentation so that I can easily know how to extend the library.
На доки времени не хватило (хотя если бы я знал что проверка будут только теперь конечно же залил бы). По факту все контракты уже применены в пути от базовых до дэфолт реаизаций в самом DefaultLogger-e.

12. As a developer I want an ability to access the library through global variable, AMD module or CommonJS module.
Погуглю про UMD, но казалось что "global.Logger = logger;" быдет достаточно.


this.pageSettingName should be a constant


This (and the followup commit) should probably be backported to the release branch.


Why do you use 'New' word in batch class name?+


No need in white  space between types in map declaration


Можно будет сделать простую админку: active admin + papertrail, cancan для ролей (админ, редактор ) и т.д. Туда же ckeditor типо rich. И в том же духе. Просто пока не известно, что с самим контентом. Я проспамил по сообществам, пабликам по делу откликнулся только ты (за что респект :) ) и Макиевский. Он сказал, что подумает и со мной свяжется его ассистент. Тут либо ждать чьей-то помощи из драм сообщества (сомневаюсь), либо самостоятельно формировать курсы :)


There are two ways of having `cumulative_weight` equal to `midpoint`:
1) We "hit" it directly during the enumeration. This happens in the special case addressed here, and then the index needs to be adjusted.
2) We can get there after substracting the last weight `cumulative_weight -= wt[p]`. Then, the index is fine.
Checking for `cumulative_weight == midpoint` after the loop doesn't tell us which case happened. I think that the way it is handled here is the simplest one and has little danger of introducing new special cases.


This var was only ever used in the Vagrantfile so I moved it.


`vlad_custom_play` is the new var that determines whether the custom play will run or not.


Makes sence, I'll change that.


nodes variable declared, but never used


`vlad_custom_play_path` can be used to position the custom play above, beside or within Vlad itself. No more preset locations.


Please move this to dedicated std.regex.internal.tests and see the infrastructrue for data-driven tests there.


Mashape Analytics


I pulled the actual code changes from this into https://github.com/sass/libsass/pull/1318 and shipped it.

After you rebase master squash this commit into the previous one.


vlad_custom_play_file allows any acceptable name to be used for the main YAML file within the custom play.


thanks!


It would be better something like: Create `hooks.rb` file with hook.


@NobodysNightmare reverted change in 8fd535769a7f0ad8c3f3b7647fd81b1a77f583b9


Added feedback to help debug scenarios where `vlad_custom_play_path` and/or `vlad_custom_play_file` could be misconfigured.


For ncurses text mode is was "Dependencies/Install Recommeded Packages for Already Installed Packages".
I would write to changelog:

Changed "Dependencies/Install Recommeded Packages for Already Installed Packages" from an option to a command.


KO Myung-Hun dixit:

>Then, should I test MZ/LX//NE magic only on OS/2 ? OS/2 cannot execute
>any other exectuable format.

No, not like that.

You should leave this particular block of code alone. Instead, you
should test for the magics supported on OS/2 in the exec() code you
wrote.

This block of code detects executables of “many” operating systems,
and, if found, doesn’t run them as script. This is to avoid mistakes,
like accidentally trying to, say, run a Linux executable on BSD, or
even OS/2.

Does OS/2 support LX/NE files without an MZ header?

Thanks,
//mirabilos
--
„Cool, /usr/share/doc/mksh/examples/uhr.gz ist ja ein Grund,
mksh auf jedem System zu installieren.“
	-- XTaran auf der OpenRheinRuhr, ganz begeistert
(EN: “[…]uhr.gz is a reason to install mksh on every system.”)


Yes, these should be constants.


whoops, sorry! I guess I didn't do as good of a job as I thought matching the existing style. Thanks again!


It would be good to update docs: http://api.highcharts.com/highcharts#legend.useHTML (that since 4.1.7 it's supported).


Fixed with 318b56b1ddae78439c7951a9f8b53778304bc063


is gcc 4.9 available on travis nowadays?


@garvinhicking
Shouldn't we do this in include/db/mysqli.inc.php for core too?
```php
function serendipity_db_reconnect() {
    global $serendipity;

    if (isset($serendipity['dbCharset'])) {
        mysqli_query($serendipity['dbConn'], "SET NAMES " . $serendipity['dbCharset']);
        @define('SQL_CHARSET_INIT', true);
    } elseif (defined('SQL_CHARSET') && $serendipity['dbNames'] && !defined('SQL_CHARSET_INIT')) {
        mysqli_query($serendipity['dbConn'], "SET NAMES " . SQL_CHARSET, $serendipity['dbConn']);
    }
}
```


Thanks a lot Christian your help and your comments helped us a lot to install the programs on the BBB !! Thanks !!  We will try to figure out and disable the SLAC and set up the test rig. I would like to ask you if it is possible to send us a copy of your thesis in order to find some tests to run with same equipment and to use your thesis as reference in ours.

email: tsiannis-a@hotmail.com


This is very informative, and you bring about very valid points. Thanks. I will definitely work on a plugin and I will update you on this thread.


STC performance looks good so probably the subtle approach does the job


Отправил тебе на email приглашение в slack


I found this is wrong actually. In some cases it removes something unexpected.


Here we go


`fin` がなにを意味するのかわからないです... 。 :)

コメントじゃなくて、変数名に反映させましょう。
```java
boolean[] finished = new boolean[n]
```

変数名のまずさをコメントでごまかしちゃだめです！ :)


I confirm at least NOT didn't work even before I branched out with an obscure error of unexpected EOF.
I'll try to fix these tests anyway when I'll get the time.


Just wandering if you're still going to post that project


Indeed


`fin` がなにを意味するのかわからないです... 。 :)

コメントじゃなくて、変数名に反映させましょう。
```java
boolean[] finished = new boolean[n]
```

変数名のまずさをコメントでごまかすのはよくないです。


you should check for empty collection before execute report.get(0) instruction


I don't get it about using "unicode_literals" in 'crispy_forms_foundation/forms.py', what's the purpose ?


Non-core RM sessions are managed by the components locally. Is it correct to assume the core RM session a special case not affected by this interface? If not, we'd have to investigate.


`m` は76行目まで使用されないので、ここで宣言する必要はないです。なるべく使用される直前で宣言しましょう。


Sort the merge conflicts?


Мало б бути
`Open Browser   ${USERS.users['${ARGUMENTS[0]}'].homepage}   alias=${ARGUMENTS[0]}`
`Set Window Size   @{USERS.users['${username}'].size}`


コメントは変数名に反映させましょう。適切な変数名をつければコメントはいらないです。
```java
double total_distance = 0;
```


Done.

A

On 07/07/2015 23:20, Jeroen Ketema wrote:
>
> @afd <https://github.com/afd> please document this (and also the new
> fields)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mc-imperial/gpuverify/commit/8f4423917ee541284ef5fa5b587c8b1d57d16ac5#commitcomment-12049834>.
>


Agreed.  Done.

A

On 07/07/2015 23:19, Jeroen Ketema wrote:
>
> @afd <https://github.com/afd> |if data not in ["little", "big"]:|
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mc-imperial/gpuverify/commit/8f4423917ee541284ef5fa5b587c8b1d57d16ac5#commitcomment-12049819>.
>


The reason I didn't do this is that gvki currently doesn't log constantness.

However, it should, so I've added this check in the JSON loader for the
future.

A

On 07/07/2015 23:14, Jeroen Ketema wrote:
>
> @afd <https://github.com/afd> or constant?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mc-imperial/gpuverify/commit/8f4423917ee541284ef5fa5b587c8b1d57d16ac5#commitcomment-12049763>.
>


Oké.


you can combined two soql queries in one


Thanks @andrew, this function seems to be unused anyway so I went with https://github.com/sass/libsass/commit/732999f35184226d13452913a92967a875fa3f59

By the way, very strange idea with 1-based indices...


Would `/bin/sh dynamic_big_crypt_generator.sh` or `sh dynamic_big_crypt_generator.sh` been better than `./dynamic_big_crypt_generator.sh`?


0.13 起要求 docker 1.6 所以不用处理 `-l` 参数的兼容性问题了


should be a constant


I don't think we want to drop `docker-io` until we're sure there are no systems out there using that package name; it does us no real harm and avoids loss of support data.

We should just add the new 'docker' variant for the RedHatDocker class.h


no need in white space between data types in map declaration


add the check for PageSettings__c record's presence in database


remove system debug statemnets


no i don't think so i think that's just a remain from the docs, i'll remove it


Missing \n


@NobodysNightmare ok, I see it now. Changed in 1bcbad9. I wasn't sure if to align with the initial `where` or the `do`, but I'll go with your suggestion.


The patch title need update, actually all patches need update patch descriptions. Will update after passing test cases.


nope


Double money = NumberUtils.roundOffTo2DecPlaces(Double.parseDouble(args[0]));

a może takie coś?
Nie jestem pewien czy da rade, ale powinno :>


It might be a good idea to add a checkstyle configuration that prevents the use of .runtime in other packages.


Anything new in this flowgraph - why add it?


In Python3 all strings are Unicode. When marking a string as translatable, it should be unicode as well. You also avoid string and Unicode concatenation issues.


i'm installing it through a ppa since the one in ubuntu 12.04 won't support c++11


ここのwhile ループがわかりにくいです。`t` が意味ない気がします...。
```java
while (true) {
  ...
    if (k >= n){
        break;
    }
}
```
で十分かな。

または while (true) じゃなくて
```java
for (int k = 0; k < n; k++) {
   ....
}
```
のほうがよいです。かならず、n 回ループが走るように見えます。


novaguilds nie govaguilds :)


next time we meet, we need to chat about nix: I cannot run the test suite with zarith commented, and lately I cannot run it at all.


Also add a note to adapt SWF to take weights


This should be `/srv/prop/gigaspaces/current/`


Adding a newline after rendering the partial results in 5 failing regression tests. I've added a more comprehensive explanation in commit 74c3849fc6517d5f6bb8c0c7378746dd679e54e2.


@Sunilkumarr what /* here?


Missing line return


let's create `deployer` user and group. Add `vagrant` to group `deployer`. Set 775 for this directory and all of the ISODENV-related directories as well.


Użyłbym tutaj switcha


Why its called size() and not count() like in the API?


@tsing 那应该加个判断，如果版本小于1.6就提示用户升级docker，否则不允许安装csphere?


In JSON output - shouldn't we omit the fields that are empty alltogether instead of setting them empty? Maybe compile the JSON output with a library programmatically and to that?


remove these files it's just for test


you can use contains method instead


Can Ansible access some host environment variables? We don't want any of these addresses public and static.


Static fields should be above instance fields


Quarks.isInstalled is going to cause unix filesystem commands.  much better here is to use `\StaticIntegerSpec.asClass.notNil`


yep, the regression tests failed :laughing:


See comment re java installation


nice one


Now that the file is built during make, that comment is somewhat misleading.


ah, so this is on a private travis instance (because you're caching which is only available on non-containered private instances)?

btw, might be worth it to ask travis for enabling multi-os, despite the help text saying they don't do that currently - it says they are capacity-limited with macOS workers, but we are already using a macOS worker, so adding a linux worker shouldn't hurt them I think?


2MHz bandwidth == 2Msps. We should reword this a little to be more specific.

"The input to the ADSB framer expects the bit sequence at double the actual data rate (to discern the falling and rising edges). If you want to sample at higher rates you will have to ensure that the eventual bit stream matches that rate (2Msps)."

Could you update?


Are the special cases for P, Pref and N still necessary after this change? It feels a bit odd to have them still, since they're kindof a hardcoded type hint.


the problem is not the new quarks system, its the unixCmds that are screwing up. this is causing corruption in memory. moving this statement only moves the memory around slightly and means that something different is being corrupted.


Is the template  still broken without "-Wno-unused" flag?


why are you use this method?


Isn't `minUDPSize` the minimum DNS response size? Shouldn't this be higher? Because you are using it as a higher limit for truncation...


should be moved to constants


@mountkin ok 可以加一下判断


@Sunilkumarr remove this log statement.


care for white spaces in for loop


@Sunilkumarr remove this line if not used.


Should probably stick this in an anonymous namespace or make it static since it doesn't need to be used outside this file?


ok sir


Fixed in 12d891ceb8fec0f911d882ba005e76bff350f702


Should probably keep nix files local, that's what I do for projects


I'm using it as the maximum response size unless the request has the EDNS fields set.  AFAICT this is the same logic as the existing DNS server.


We'd review a PR to allow this to e.g. take custom arguments.


> there instead of the width, will that cause performance issues?

Apparently we can just remove this rule completely. The width of the other elements is enough to keep this aligned properly and not setting a width takes care of the overly large badges.

Incidentally, ```float: right``` messes up vertical alignment.


行の最後に `//`  でコメントをつける場合は、そのコメントはその行の内容について説明するときに使用するのが一般的です。

このコメントは、名詞で終わっていない、つまり「変数名 min」の説明としては不適切です。
むしろ、この後につづくfor loopの「処理内容」のコメントなので、独立した行に書くべきです。
```java
// distの中の最小を求める。
double min=Double.MAX_VALUE;
for(int i=0;i<n;i++) {
```

さらにいうなら、適切な変数名をつけると処理内容は自明になりますので、コメントはいらないです。

```java
double minDistance = Double.MAX_VALUE;
for(int i = 0; i < n; i++) {
    if (minDistance > dist[i]) {
         minDistance = dist[i];
         m = i;
    }
}
```


Hi Chris,

What happens if you add back in `repo: Cimpress-MCP/deployment-tracker` without removing `all_branches: true`? My .travis.yml is [here](https://github.com/vaibhavsagar/resume/blob/master/.travis.yml) and that's the only difference I can see.


v v v v


Nice styling? Right?? :dancers:


Yes, I think we should harmonize that. Only for 2.1+ though, not for 2.0, to try it out.


@vpeter we could add as builtin... if it dont breaks devices without this hardware, can you check and if it works make a PR?


oops missed this, will change to `{*}` afterwards


What policy stands for in the response of REQUEST_RECORD_UPDATE?


Shouldn't this be
```
var values = $scope.$getCollectionReactively("things");
```
?


what a handsome board :+1:


We should consider filter-branching this, if it is still on a branch.


Can we put braces around this please? I know it's more verbose, but I really think doing it without braces is error prone, especially for people who spend half their time in Python and half in C++.


You tell me :) this was already here, I just changed it from:

> -and **record-version** **policy** is:

which I guess didn't make lots of sense. I have no idea what **policy** is.


@zero-24 Lost in rebasing... :-) Feel free to fix it!


This comment is outdated now :)


Why are we `sass_strduping` those strings at all?


```python
if uselog:
    log(errormsg)
else:
    print(errormsg)
```

kan trekkes ut som egen metode som tar inn errormsg, disse linjene går igjen (minst) fire ganger i skriptet nå.


I guess this is not needed


I think I would try to add it in the  `macstore.bork` instead. This way you don't need to wait for the cask maintainer to adapt the updates.


> Well if you take a look at the other side there is the same kind of solution applied for .net objects

I have no problem with the implementation, just like for the code to be as clear in it's meaning as possible. There isn't a whole lot of documentation, so method/function/class names become very important.


FWIW, the fixed length was to align the columns so that it's easier to read for humans #54.
The values were obtained by largest string+4 to the closest multiple of 4 to ensure there's free space and alignment. Of the two columns with fixed length, the second column containing the DPIs was the only one at risk of possibly having a larger string in the future IIUC.
I'm not at all against this commit, in fact I proposed the same thing in #54 for discussion since I wasn't happy with hardcoding it, but I also didn't want to add width detection for cosmetics, I just thought I'd explain my rationale :kissing_closed_eyes:


oh, didn't read that :)  just removed the caches then.

yeah i think it would make sense to ask them since we are already using osx and could even move some of the builds like docs and android to linux if they allowed us to use multi os.


Inline-styles; no good. If this is used often, consider creating generic class/rule for this. Otherwise adding .auth class to the top-most <div> and adding the padding there would work.

I didn't check how that padding actually affects, I'll pull+test this a bit later.


Hi,

Thank you for this pull request.
To maintain a overview we have a workflow to make pull requests.
See https://bundles.kunstmaan.be/documentation/contributing/pull-requests -> Step 4. Send a pull request
Would you mind updating the pull request with it?

Have a look at other pull requests as example :smile:


Fixed in bbd6943


herf didn't update


Nice!


лл


:) Thanks Alex. @Propanu this module should still be removed, it's completely broken and serves no purpose in it's current state just adds to confusion.


Here dataSet.Type is set to DataType.Storage, but I think it will be changed to DataType.Disk on line 179 below.


@NobodysNightmare no. we consider methods that modify the object that they are called on to be _procedural_, according to [this article](http://devblog.avdi.org/2011/07/26/the-procedurefunction-block-convention-in-ruby/).


Well I haven't edited that much, but... Maybe just a bug of github


right, going to remove it. thanks


We don't need to handle truncation for recursive responses. See how we were doing it so far [here](https://github.com/weaveworks/weave/blob/master/nameserver/server.go#L373).


Typing is hard


Later we have to consider internationalization for api requests.


@NobodysNightmare see https://github.com/myabc/openproject/commit/df51b6ed99a46f34052321ab10b6234146ceefee#commitcomment-12057481


:heart:


So did you do this commit with a password?


You could check out some [basics of less](http://lesscss.org/). ;-)

E.g. FB button could be written like this:
```less
.btn-facebook {
	color: #fff;
	background-color: #3b5998;
	border-color: #3b5998;
	&:hover {
		background-color: darken(#3b5998, 3%);
	}
}
```

or if that color has to be inside hover, wrap it with this:
```
&, &:hover {
	color: #fff;
}
```

etc. Same goes for nesting `.sign-page` stuff, you can nest them.

`.sign-page` could be `.auth` instead to match controller name? Or even better would be to follow module names `.user-auth`, `.user-profile` etc.


@NobodysNightmare should be fixed in 0ad3cfb


Do you mean global flag in file mk/flags.mk? No, it's fixed. The template feels fine without this flag now.


fixed in 0ad3cfb


Added console.registerIfNotRunning(parent, name, Task)


I think we don't use this kind of `{ ... }` blocks...


Remove this


Comment should be removed.


Now it is clear why I can't reproduce with a debug build.
A clang build segfaults exactly at this strcasecmp.
```
 Testing: dynamic_39 [md5($s.pad16($p)) (net-md5) 128/128 AVX 4x5]... PASS
Testing: dynamic_40 [sha1($s.pad20($p)) (net-sha1) 128/128 AVX 4x2]... PASS
Testing: dynamic_50 [sha224($p) 128/128 AVX 4x]... PASS

Program received signal SIGSEGV, Segmentation fault.
0x00007ffff64fe7c1 in __strcasecmp_l_avx () from /lib64/libc.so.6
Missing separate debuginfos, use: dnf debuginfo-install gmp-6.0.0-9.fc22.x86_64 keyutils-libs-1.5.9-4.fc22.x86_64 krb5-libs-1.13.2-3.fc22.x86_64 libcom_err-1.42.12-4.fc22.x86_64 libgcc-5.1.1-4.fc22.x86_64 libicu-54.1-1.fc22.x86_64 libselinux-2.3-10.fc22.x86_64 libstdc++-5.1.1-4.fc22.x86_64 nss-softokn-freebl-3.19.2-1.0.fc22.x86_64 openssl-libs-1.0.1k-10.fc22.x86_64 pcre-8.37-1.fc22.x86_64 zlib-1.2.8-7.fc22.x86_64
(gdb) bt
#0  0x00007ffff64fe7c1 in __strcasecmp_l_avx () from /lib64/libc.so.6
#1  0x000000000055cf0a in benchmark_all () at bench.c:554
#2  0x000000000056b2fe in john_run () at john.c:1373
#3  0x000000000056ad83 in main (argc=2, argv=0x7fffffffe0b8) at john.c:1759
(gdb) print options.format
$1 = 0x0
```
Fixed in commit 2331e9ea020bb3d3e1304c31781695ccd177269f


Please move this below Majordomo Executus


`+` not needed if its within brackets :)


Add a blank line above the test.


Add a blank line here


Still gotta remove this :)


authTokenChanged seems to this.set('currentUser', null) too, so the line above is redundant?


This section should be moved to less file at user-module, where the html/js etc is.


please remove this and add the globals specifically on each file, this is intentionally


Is this intentional?


If the given radius is more than the radius_limit it returns an empty dict? Maybe it should set radius to the radius_limit and continue


Why did you remove this?


thanks, missed that


@Fuuzetsu isn't it nice to be able to just `nix-shell` after cloning this repo? Why keep it local? It looks generic enough to me.


Start comments with `# ` (a space after the #)


Why not using $.ajax()


Modifying these without using Bootstrap's less mixins can be dangerous, test carefully scaffolding with different screen size breakpoints.


Offline discussion revealed: The fix is appropriate ;-) Merged it.


Yeah no problem, shoot them over :+1:


I'm curious why catch all possible exceptions? Probably this need to be revised and what will be possible failures that we need to recover for silently.


Why not? I find them useful in these kind of situations to ensure we're not accidentally reusing a previous error value.


would you do that (you at least have an of.cc address)?
Btw, interesting stuff I found: [there is a](http://next.travis-ci.com/) Ubuntu 14.04 beta which you can ask to participate, could be useful for us (e.g. gcc).


Chosen init was removed here accidentally.


please omit aldryn.events, we know that already. Ideally describe what it does: ``spec.article.create.js`` or ``spec.login.js``


should we also put maximum animals to show and break out of the loop once it hits that?


ZeroClipboard init was removed here accidentally.


I'm not 100% consistent about keeping `format` blocks one-line. Where possible, I tried to look at the other `respond_to` blocks. In the end, it's all a bit subjective.


We currently test the same cases but for recursive queries too (with a mocked fallback server).


Oh wait ignore that, I get how it works with the recursion, thought it was some protection against someone requesting radius 10000 or something


Why not do it?  This is protecting against misbehaving upstream servers.


Ony for system with systemctl .. centos7  or Fedora and some others


looks awesome, good job


pass


Given that they use exactly the same code to handle truncation, its not clear to me the extra test is worth it.


It is a common style thing. For example, we don't use named return values either (eg, `func X(some int) (v int, e error)`). But you can rise the question to the team, in case we all agree...


Do we want `strings.clear()` here as well?


テストコメント


warum?


const


@NobodysNightmare `.where(statement)`


Why is it module and not a class?


We do not care about _misbehaving upstream servers_: we are just acting as recursive resolvers, so we do not modify the contents of the response...


`const InterestPoint& p` ist wesentlich effizienter.


Referenzen sind gut :+1:


Alle const?


I quite like it, actually, Though frankly this is crying out for a helper function since
````
request.SetQuestion("foo.weave.local.", dns.TypeA)
response, _, err := udpClient.Exchange(request, fmt.Sprintf("127.0.0.1:%d", udpPort))
require.Nil(t, err)
````
is repeated three times. With a helper, instead of
````
udpClient := dns.Client{Net: "udp", UDPSize: 65535}
request := &dns.Msg{}
request.SetEdns0(65535, false)
request.SetQuestion("foo.weave.local.", dns.TypeA)
response, _, err := udpClient.Exchange(request, fmt.Sprintf("127.0.0.1:%d", udpPort))
require.Nil(t, err)
require.False(t, response.MsgHdr.Truncated)
require.Equal(t, len(response.Answer), 100)
````
we would have
````
request := &dns.Msg{}
request.SetEdns0(65535, false)
response := exchange(dns.Client{Net: "udp", UDPSize: minUDPSize}, request)
require.False(t, response.MsgHdr.Truncated)
require.Equal(t, len(response.Answer), 100)
````


Ich mag const :)


At the moment _min_positive_signal in dti.py is defined as a function of the class object TensorFit. To import this helper function from dti this had to be defined out of the TensorFit class, right?


just test add other comment


The DNS server has two parts: the _local resolver_ and the _recursive resolver_. I think we cannot consider that the DNS server is properly tested with only one of those parts being tested. And I think they are quite different...


in my perspective, instead of implementing some functionality like paginating, using those mature and well-tested library is way better.
for instance
http://getbootstrap.com/components/#pagination


Ah damn, just realized you broke the formatting by omitting a '/' before code.  Pro-tip - one benefit of you using your gh-pages branch is that I should have easily been able to preview the output before merging the PR <grin>.

No worries though, I'll fix it.


yes, caused some touch miss behavior in my device =p
so is there any value to reduce lcd power ?!!
ps:just searching your commits and found this, tnx


FacilityTabGridView (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@akhilnarang , you should fix your download link. Android File Host has multiple servers on which it continuously moves and stores uploaded files. You cannot use a direct link because downlod mirrors will be removed and replaced by other servers. You must self-host if on your website like me or upload the kernel to github and use the raw data link for the file directory.

The error is present in both opo & sprout jsons.


I'm not too sure about this.
Are they really interchangeable?
If I follow:
- SearchContext#findElement
- RemoteWebDriver#findElement

I get to `by.findElement(this)` => it looks like they are interchangeable?


sweet :star:


Actually it cannot, since the first part of the error is message type specific and the calling code does not have that information. Also if an error occurs else where in the function, then there would be no way to know whether the error that was being reported was related to the call to `write` or something else within the `publish__...` function.


nice


Why do this?


@liqianggao - what does this fix?


Hold up, we don't want to do that. "Clones" are not accessible by the user as they are guaranteed to be identical to the original. If you want something you can modify, use "Copy"


If I understand correctly, this update will move data out of custom tables and store in resource's properties column in site_content?


This is tricky, it means that now memory profiler should not be run in an environment where we were already tracing, I guess it is correct.

I think we need to add a clear before we start our trace then.


looks good


The errors that this is failing with are the ones related to pulling down and running docker containers as follows:

----------
          ID: elasticsearch-pulled
    Function: docker.pulled
        Name: elasticsearch
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1563, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/states/dockerio.py", line 271, in pulled
                  returned = pull(name, tag=tag, insecure_registry=insecure_registry)
                File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 1599, in pull
                  client = _get_client()
                File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 277, in _get_client
                  client._version = client.version()['ApiVersion']
                File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 922, in version
                  return self._result(self._get(self._url("/version")), True)
                File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 75, in _get
                  return self.get(url, **self._set_request_timeout(kwargs))
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get
                  return self.request('GET', url, **kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
                  resp = self.send(prep, **send_kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
                  r = adapter.send(request, **kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
                  raise ConnectionError(e)
              ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /run/docker.sock/v1.12/version (Caused by <class 'socket.error'>: [Errno 111] Connection refused)
     Started: 19:49:59.743188
    Duration: 9.759 ms
     Changes:
----------
          ID: tika-pulled
    Function: docker.pulled
        Name: continuumio/tika
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1563, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/states/dockerio.py", line 271, in pulled
                  returned = pull(name, tag=tag, insecure_registry=insecure_registry)
                File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 1599, in pull
                  client = _get_client()
                File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 277, in _get_client
                  client._version = client.version()['ApiVersion']
                File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 922, in version
                  return self._result(self._get(self._url("/version")), True)
                File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 75, in _get
                  return self.get(url, **self._set_request_timeout(kwargs))
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get
                  return self.request('GET', url, **kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
                  resp = self.send(prep, **send_kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
                  r = adapter.send(request, **kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
                  raise ConnectionError(e)
              ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /run/docker.sock/v1.12/version (Caused by <class 'socket.error'>: [Errno 111] Connection refused)
     Started: 19:49:59.755326
    Duration: 3.631 ms
     Changes:
----------
          ID: kibana-pulled
    Function: docker.pulled
        Name: continuumio/kibana
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1563, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/states/dockerio.py", line 271, in pulled
                  returned = pull(name, tag=tag, insecure_registry=insecure_registry)
                File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 1599, in pull
                  client = _get_client()
                File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 277, in _get_client
                  client._version = client.version()['ApiVersion']
                File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 922, in version
                  return self._result(self._get(self._url("/version")), True)
                File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 75, in _get
                  return self.get(url, **self._set_request_timeout(kwargs))
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get
                  return self.request('GET', url, **kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
                  resp = self.send(prep, **send_kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
                  r = adapter.send(request, **kwargs)
                File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
                  raise ConnectionError(e)
              ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /run/docker.sock/v1.12/version (Caused by <class 'socket.error'>: [Errno 111] Connection refused)
     Started: 19:49:59.760747
    Duration: 3.216 ms
     Changes:
----------
          ID: elasticsearch-running
    Function: cmd.run
        Name: docker run -d -p 9200:9200 -p 9300:9300 -v /vagrant/source/container_volumes/elasticsearch/data:/data --name=elasticsearch_1 elasticsearch
      Result: False
     Comment: One or more requisite failed: memex-docker.elasticsearch-pulled
     Started:
    Duration:
     Changes:
----------
          ID: tika-running
    Function: cmd.run
        Name: docker run -d -p 9998:9998 --name tika_1 continuumio/tika
      Result: False
     Comment: One or more requisite failed: memex-docker.tika-pulled
     Started:
    Duration:
     Changes:
----------
          ID: kibana-running
    Function: cmd.run
        Name: docker run -d -p 9999:80 -e KIBANA_SECURE=false --link elasticsearch_1:es --name kibana_1 continuumio/kibana
      Result: False
     Comment: One or more requisite failed: memex-docker.kibana-pulled
     Started:
    Duration:
     Changes:


looks good, but perhaps move guess gem to its on class and just through away the instance later automatically, the Helper.reset call irks me a bit.


As we revising transformer generation, do we even need built-in context parameter `C context`. More than half of usages have `Void context`, remaining usages could get away with context being implemented by a field. If someone ever need to pass contextual context, then simple stack could be used. Better yet, new instance of transformer subclass could be created and transformation along with context passed to it. That is just an alternative of having invasive but unused context (think `Void context` most of the time).


looks good!


Merging master back to my branch.


Uh oh, I don't think it renders properly on https://azure.microsoft.com/en-us/documentation/articles/search-howto-connecting-azure-sql-database-to-azure-search-using-indexers-2015-02-28/


Could you open a centalized issue so we can track the problem more easily? Thanks


Here you probably need to use the information which variables are integer vs. continuous.
(Add a doctest for that as well.)


I don't see the writer type to be a very helpful information. Imo it would be more important to include the message type for every error message of this function.


api wise its a bit odd to have 2 implementations, what perf diff are we talking?


Pls. fold this into 3d1d72342dba133476edbfda36057b1e91db887c!


interesting, sure looks good


cool, if we need later we can add


Not sure that I fully understand you, but I'm in favor of removing that context


cool


Hey StanTRC, are you going to give support again to dorimanx kernel?


as long as we clear all the stats here this should be good.


upgrading docker is not a clean process.  there are a few files that need
to be removed, etc...  I think I left some notes somewhere on how to do
this.

On Wed, Jul 8, 2015 at 8:12 PM, Andrew Farrell <notifications@github.com>
wrote:

> The errors that this is failing with are the ones related to pulling down
> and running docker containers as follows:
> ------------------------------
>
>       ID: elasticsearch-pulled
> Function: docker.pulled
>     Name: elasticsearch
>   Result: False
>  Comment: An exception occurred in this state: Traceback (most recent call last):
>             File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1563, in call
>               **cdata['kwargs'])
>             File "/usr/lib/python2.7/dist-packages/salt/states/dockerio.py", line 271, in pulled
>               returned = pull(name, tag=tag, insecure_registry=insecure_registry)
>             File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 1599, in pull
>               client = _get_client()
>             File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 277, in _get_client
>               client._version = client.version()['ApiVersion']
>             File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 922, in version
>               return self._result(self._get(self._url("/version")), True)
>             File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 75, in _get
>               return self.get(url, **self._set_request_timeout(kwargs))
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get
>               return self.request('GET', url, **kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
>               resp = self.send(prep, **send_kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
>               r = adapter.send(request, **kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
>               raise ConnectionError(e)
>           ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /run/docker.sock/v1.12/version (Caused by <class 'socket.error'>: [Errno 111] Connection refused)
>  Started: 19:49:59.743188
> Duration: 9.759 ms
>  Changes:
>
> ------------------------------
>
>       ID: tika-pulled
> Function: docker.pulled
>     Name: continuumio/tika
>   Result: False
>  Comment: An exception occurred in this state: Traceback (most recent call last):
>             File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1563, in call
>               **cdata['kwargs'])
>             File "/usr/lib/python2.7/dist-packages/salt/states/dockerio.py", line 271, in pulled
>               returned = pull(name, tag=tag, insecure_registry=insecure_registry)
>             File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 1599, in pull
>               client = _get_client()
>             File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 277, in _get_client
>               client._version = client.version()['ApiVersion']
>             File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 922, in version
>               return self._result(self._get(self._url("/version")), True)
>             File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 75, in _get
>               return self.get(url, **self._set_request_timeout(kwargs))
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get
>               return self.request('GET', url, **kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
>               resp = self.send(prep, **send_kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
>               r = adapter.send(request, **kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
>               raise ConnectionError(e)
>           ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /run/docker.sock/v1.12/version (Caused by <class 'socket.error'>: [Errno 111] Connection refused)
>  Started: 19:49:59.755326
> Duration: 3.631 ms
>  Changes:
>
> ------------------------------
>
>       ID: kibana-pulled
> Function: docker.pulled
>     Name: continuumio/kibana
>   Result: False
>  Comment: An exception occurred in this state: Traceback (most recent call last):
>             File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1563, in call
>               **cdata['kwargs'])
>             File "/usr/lib/python2.7/dist-packages/salt/states/dockerio.py", line 271, in pulled
>               returned = pull(name, tag=tag, insecure_registry=insecure_registry)
>             File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 1599, in pull
>               client = _get_client()
>             File "/usr/lib/python2.7/dist-packages/salt/modules/dockerio.py", line 277, in _get_client
>               client._version = client.version()['ApiVersion']
>             File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 922, in version
>               return self._result(self._get(self._url("/version")), True)
>             File "/usr/local/lib/python2.7/dist-packages/docker/client.py", line 75, in _get
>               return self.get(url, **self._set_request_timeout(kwargs))
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 467, in get
>               return self.request('GET', url, **kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
>               resp = self.send(prep, **send_kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
>               r = adapter.send(request, **kwargs)
>             File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
>               raise ConnectionError(e)
>           ConnectionError: UnixHTTPConnectionPool(host='localhost', port=None): Max retries exceeded with url: /run/docker.sock/v1.12/version (Caused by <class 'socket.error'>: [Errno 111] Connection refused)
>  Started: 19:49:59.760747
> Duration: 3.216 ms
>  Changes:
>
> ------------------------------
>
>       ID: elasticsearch-running
> Function: cmd.run
>     Name: docker run -d -p 9200:9200 -p 9300:9300 -v /vagrant/source/container_volumes/elasticsearch/data:/data --name=elasticsearch_1 elasticsearch
>   Result: False
>  Comment: One or more requisite failed: memex-docker.elasticsearch-pulled
>  Started:
> Duration:
>  Changes:
>
> ------------------------------
>
>       ID: tika-running
> Function: cmd.run
>     Name: docker run -d -p 9998:9998 --name tika_1 continuumio/tika
>   Result: False
>  Comment: One or more requisite failed: memex-docker.tika-pulled
>  Started:
> Duration:
>  Changes:
>
> ------------------------------
>
>       ID: kibana-running
> Function: cmd.run
>     Name: docker run -d -p 9999:80 -e KIBANA_SECURE=false --link elasticsearch_1:es --name kibana_1 continuumio/kibana
>   Result: False
>  Comment: One or more requisite failed: memex-docker.kibana-pulled
>  Started:
> Duration:
>  Changes:
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/memex-explorer/memex-explorer/commit/6d5ca8665384e593a5a821a98e90b39828451e91#commitcomment-12074321>
> .
>


I think the upcoming Values behaves differently. I'd get with @gabizou and decide.


Thank yoy kuzukami


Thx :)


indexメソッド、使ってないなら削除して大丈夫ですよ


97647908-DocIssues4615 (rglazer2) - Win64-Windows-7-VisualStudio-12: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks! spent a long time trying to fix this issue before i found this


97647908-DocIssues4615 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


how come you added nesting here?


Well, that message as is gives all the context you need to know what the message type is, and you still need to know that this occurred in the `write` function. The full data writer type before the `write` is not necessary, but I don't see that it hurts either. Seems to me that being explicit is more helpful than not.

So you're proposing `"@(__ros_msg_type) write failed with: ..."` instead? That hard to parse for me, do have a concrete alternative.


I guess I'm not getting the purpose of clone.  create_clone creates a
molecule with a unique copy number, so why wouldn't it be accessible?

If I have a molecule, m1, and then do:

> m1.create_clone(chain_id='B', transformation=trans)

I can access the cloned molecule with the following statement:

> m2 = m1.state.molecules[molecule.get_name()][1]

which is equivalent to the object I get when returning the cloned molecule
in create_clone.

Is there another way I should be doing this?

On Wed, Jul 8, 2015 at 5:10 PM, Charles Greenberg <notifications@github.com>
wrote:

> Hold up, we don't want to do that. "Clones" are not accessible by the user
> as they are guaranteed to be identical to the original. If you want
> something you can modify, use "Copy"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/salilab/pmi/commit/52ae303b9943599c4c070552e2c5b06786676a88#commitcomment-12074291>
> .
>

--

Daniel Saltzberg
Post-doctoral Scholar
University of California at San Francisco
Lab of Andrej Sali (www.salilab.org)

T: 415.514.4258

*Mailing Address:*
UCSF MC 2552,
Mission Bay, Byers Hall
1700 4th Street, Suite 503B
San Francisco, CA 94158-2330

saltzberg@salilab.org
ds229@bu.edu


i finally got it working. thanks for your help!
my npm was older which caused the issue. but i couldn't update. turns out i had to sudo su before running the curl ...
I assumed sudo curl ... would work but that just left my npm in an unusable state. All set now thanks


Отлично


You need to apply this patch https://github.com/kalyankondapally/ozone-wayland/commit/f4f72d4e5ba932c04ec714942f9e75ed5b54d271

Implement these new apis in DesktopRootWindowHostOzone, where you will mostly be just forwarding the calls to the draganddrop client.


97647908-DocIssues4615 (rglazer2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


YOU SON OF A BITCH... :-p


Because this method is called when ```googleApiClient.connect();``` was successfull, once Api connection was established we obtain the last known location through the GAC, if not exist last known location (we can put here a method to show new input field to the user can enter origin manually) and... [this gist](https://gist.github.com/diego-d5000/055892f9ecad2e944144#file-gaconconnected) explain all that I want to say. What do you think ? do you think that is wrong implemented what I want to do ?


The variable name "notStep" confuses me a little bit.  Could we call it aStep or something similar, since it is a step?


ここはControllerのmethod名をあらわすものなので、
small letterでいいとおもいます。


97221720_32BitInstaller (macumber) - Win64-Windows-7-VisualStudio-12: OK (2192 of 2213 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.05%25-yellow.svg)


With this protocol removed the cancel functionality stops working. To properly resolve this the abstract protocol should be removed and the 'unclockWasCanclledForPadLockScreenViewController:' method should be defined by setup & implementation delegate


Is this safe for older salt?


It's complicated. Sometimes we want multiple copies of a molecule to have exactly the same internal representations, and sometimes we don't. We figured that we'd distinguish these cases with two different functions

create_copy(): create a new molecule with the same name, copies the sequence, and gives it a higher copy number (so selection works). The user has to set representations and coordinates themselves, so this function returns the created Molecule.

create_clone(): does everything for copy, but is tagged internally to copy *representations* (including structure coordinates) after all the building for the original is done. if the user tries to change anything about the molecule it could mess things up. So we don't return it.

It's true that you can access the internal molecule, but that's due to a quirk (or feature) of python - you can't make class variables private. All we can do is gently encourage the user to access everything in PMI via functions.

I'm open to other ideas if you have it, I realize the nomenclature is not great here.


Shouldn't this and line 99 be 0.05f?


That looks nicer that I though it would - I've addressed in a commit that I will push soon.


maybe a better thing is to just return the molecule when you call create_clone() but then have an error when the user tries to change anything. I guess that's also good because you may want the Molecule handle for other classes like Degrees of Freedom.


gotta love the carrierwave


Hey Sam, Looks like you didn't actually commit the hw here.


This is just too awesome!


categorizings is a hard word


This is a construct I've never seen before--I'm clearly not as experienced with Go as you.  :)  What is ```struct{}{}``` and why are you sending it to the update channel?  It looks like you're just trying to signal an update--is there a reason not to use ```chan bool``` instead?


You could have also done a `killings[killings.armed == 'No'].shape(0)`


isWhitespace cannot work in build test. ToTitleCase works same as ToUpper in these cases(verified in Scala console).


Nice work!


I was unable to find a one pager for you here! Have you submitted it yet?


Hi, everybody! Badly I speak English. Such question. And whether it is possible to make gopro 4 black 4k in the ratio 4:3 and with opportunity to expose исо 100 and 800. If such already I ask to eat share the link.


Could this function be moved into javaRosa? I think that's the only module that uses it now. (fine to do it in a separate PR)


I'm just thrilled and grateful that you took the time to add support for
initialization of a Row from a dict.

I meant to do it a while back, but got sidetracked on other projects.

As for thinking about Python 3 compatibility -- this is the first project
where I've been concerned with that at all.  Mostly because Ted Berg (the
other main contributor) cares about it and did all the heavy lifting -- now
I'm just trying to make sure I don't undo his good work.

I'm looking forward to seeing your next pull request!

Thanks again,
Scott

On Wed, Jul 8, 2015 at 4:29 PM, cheneric <notifications@github.com> wrote:

> Thanks for reviewing and merging my changes, Scott. I appreciate the help!
>
> I apologize for not writing some unit tests myself. This is my first
> project in Python, and thinking about Python 3 compatibility and unit tests
> are a little too much to grasp all at once.
>
> I'll have another pull request soon to support editing a Column. I'd
> appreciate you looking that over for me too. Thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cheneric/smartsheet-python-sdk/commit/729a4ea3a8a33e90de3c97662b2856c83f25ec90#commitcomment-12073827>
> .
>

--
Scott Wimer
scott.wimer@gmail.com


`"write for @(__ros_msg_type) failed with: ..."`?


you can also cast as a float! `float(killings.shape[0])`


you could also plot my average median salaries!


Nice work on this one!


HW/Course Project/Course Project 1-Pager.md

What kind of customers?


Is your data private or open to the public?


No, I would drop everything before the colon and prepend information on the caller side of this function.


# Now advanced

* Better Buttons
 * enableModSave
 * removeRemoveConfirmation
* comment
 * hideRemoved
 * highlightTitles
* modbar
 * compactHide
* modbutton
 * globalButton
* modmailpro
 * autoThread
 * autoThreadOnLoad
 * customLimit
 * filterBots
* notifier
 * modSubreddits
 * unmoderatedSubreddits
 * modmailSubreddits
 * modmailSubredditsFromPro
 * straightToInbox
 * consolidatedMessages
 * checkInterval
* queuetools
 * reportsOrder
 * reportsThreshold
 * reportsAscending
* usernotes
 * maxChars


Can't wait to see it!


`len(killings[killings.armed == 'No'])` Would also work and returns an int.


careful you may need to cast one of these as a float to make sure you avoid integer division!


`majors['sample_employment_rate'] = majors['Employed']/majors['Total']`

`majors['sample_unemployment_rate'] = 1 - majors['sample_employment_rate']`


Nice work on this!


Is it an issue to read a file off the disk every time we validate a Widget?


current.log is no longer a file that we will constantly write to - it's a brand new file every time it's started or setup, and I just use `w` to make sure that it's created and starts from scratch.


Ignore what I said. You are following the rest of the API.


Just wondering: Are you trying to improve the hash function distribution by seeding with a random prime?


I wasn't able to find your one pager yet, have you uploaded it?


Perfecto :v


I wonder if the latest build something changes?
N7100XXUFOE1


@antinucleon @mli Sure


you could also just do `majors.isnull().sum()` to show them all at once in one line!


you can also read from Github directly:
`majors = pd.read_csv('https://raw.githubusercontent.com/sinanuozdemir/SF_DAT_15/master/hw/data/college-majors.csv')`


it depends on the widget & how frequent that widget being used.
numeric widgets(NumericTextBox, DateTimeTextBox,...) will contain digits with a little or no letters. while the other input & output widgets will mainly contains letters.
so I think the common case here is to process strings with a little or no digits at all.


remember you can set the number of bins manually to change the appearance of the histogram!


My pleasure =)  My first contribution to an open source project that I wasn't working for too!

Just for the sake of the backstory, I had to implement support for creating rows from a dict because the sheets I am working on have columns of type SystemColumnType MODIFIED_DATE.  I ran into the problem  when trying to create rows from lists that I could not set SystemColumnType MODIFIED_DATE cells - nor could I skip over them using None - so I was left with no other choice than to implement the dictionary approach.


I wasn't able to find a one pager for your project idea, did you submit one yet?


Yikes, you are right they should be. Excellent spot. Changing the percentage of the last entry will actually not matter as the spell count can never go over 100%. It will act as if they are 0.05f even though it's very confusing. Missed it while I was refactoring earlier today, I'll fix it up now. Thanks.


yes it shouldn't be there


remember the `inplace = True` to make sure that is actually gets changed!


yes, this shouldn't be there too


using System;
class NewHouse
{
    static void Main()
    {
        int n = int.Parse(Console.ReadLine());
        string freeSpace = new string('-', n / 2);
        Console.WriteLine("{0}{1}{0}",freeSpace,'*');
        int j = 1;
        int k = n / 2;
        for (int i = 1; i < (n/2); i++)
        {
            j += 2;
            k--;
            string roof = new string('*', (j));
            string aroundRoof = new string('-', k);
            Console.WriteLine("{0}{1}{0}",aroundRoof,roof);
        }
        string baseOfRoof = new string('*', n);
        Console.WriteLine(baseOfRoof);
        string tower = new string('*', n - 2);
        for (int i = 0; i < n; i++)
        {
            Console.WriteLine("{0}{1}{0}",'|',tower);
        }
    }
}


Great work on this! I wasn't able to find a one pager for your project idea though, have you uploaded one yet?


Great work on this!


I'm not sure about the use case. Could we use `vector<pair<string, string>>` ?


remember you can put all of this in one line if you want!

`top10unemp=majors.groupby('Major_category').Unemployment_rate.mean().sort().tail(10)`


Try putting all of that in one line! `top10unemp=majors.groupby('Major_category').Unemployment_rate.mean().sort().tail(10)`


Try putting all of this on one line!

`thing = majors.groupby('Major_category').Median.mean().sort().tail()`


Also "thing" maybe isn't the most descriptive variable name? :)


If you were to extract the logic in this callback to another method, do you think a descriptive name would be something like ```tryToEnsureGeolocationCanBeObtained```?

As for the implementation itself, I'm confused: shouldn't the following line be testing the opposite condition (i.e. that ```lastLocation == null```):

```
// If we can't get the last location...
if (lastLocation != null) {
```


I don't think you need a `map` here, since you're not returning anything from the iterator. You could probably just use an `each`.


Which map are you talking about? the argument or the map used in copy graph?


Apliqué los mismos cambios que en elegirset.html en el header


This is interesting!

Perhaps you could even:
1.  make a map of the best tacos in python
2. Identify words that people use when naming great tacos
3. try to predict if a taco place will be good or bad based on comments/words used/location/etc


I like the overall look of this code! You wrote well-named variables and method names, and you've got a clean, well-indented style. I left a few small comments up above for how you might consider cleaning the code up a little further.