Yes it usually works for people if you have a standard setup. In my case I can have msgpack installed outside of the normal lookup locations for certain platforms.


Sorry I missed it in the review.


97902934_ZoneMixing (macumber) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


:laughing:


1.9.3 and I think 2.0 don't garbage collect symbols; you're symbolizing all the keys of a limitless hash

probably not a huge deal, but if someone uses this with user input of some sort, it would slowly eat up memory


It seems rather confusing to call a `double` value `floating_`, someone reading the code would believe it were a `float`...


97902934_ZoneMixing (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17821/testReport/) for this commit**


Oh, yes, right.

Yeah, the impetus should be on the developer to make sure they're not passing user-generated data to this method.

However, that might not always be possible. I can look into using `ActiveSupport::HashWithIndifferentAccess` instead of a `Hash` with all symbolized keys.


This will cause errors simply because the FlagType MODIFY does not exist in Plots and will cause a NPE


Can you make this and the previous assignment a switch statement instead?


Would rather use var since let doesn't really give us anything here.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17822/testReport/) for this commit**


WHY DO WE HAVE TWO HTML DOCUMENTS


super edge minor issue though; :+1: whatever you choose


@manfrin Better?


No, I think you're right to be concerned about it.


@shtaft, @skadyansna , I've added a new branch to the git repository, "mape". It has the changes we talked about during the meeting earlier.

checkout the code.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17823/testReport/) for this commit**


Oh, I see you copied this from AngularJS $http. Why didn't you include the other logic to make sure it should actually be 200 instead of 404?


This is intended to catch the item usage not the block placement that is why the check for ItemBlock is there.


This breaks `ogit clone git://github.com/mirage/ocaml-git` so I'm keen to fix this by changing the interface instead of getting all the refs. I'll try to push a fix with all the refs shortly.


I'm old, I hate long names. Perhaps not `isint()` (for current isdecu) and `isuint()` (for current isdec)?


@LDX-MCPE Woops sorry


@dbarashev, готово, мелкие недочеты исправлены.


The problem with this, is that you can't then unset the flag later. It may not be common but I've found cases where I want to do it.


yep +++

:+1:


***Markdown Cheat Sheet***
https://guides.github.com/features/mastering-markdown/


All right, killed it dead.


f7d3572 fixes pruning the hash.


Putting it back?


optimizedStream is null, therefore should be logging stream.MediaItem.MediaPath, this currently throws an exception which is re-caught further below.


Change


"q" might not be the best letter since that's also used for exiting dialogs.


93469234-DemandResponse2 (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1173 of 1173 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


as


I did not know that, sorry!


You can find this on GitHub as a Gist: https://gist.github.com/JamesSkemp/fa2a9bd79a1d6336b247


instead of comment, you can make it a named argument.. useAnalyzers: true,


@rpavlik At one point, yes. But I may have missed this line. (I was clang-formatting blocks of code and not the whole file.)


Done.


after updating to plone 4.3.6 i get errors on my site where there previously have not been any problems.
(i see others do have the same problem [here](https://community.plone.org/t/having-an-orphan-size-higher-than-batch-size-is-undefined/761) and [there](https://jira.bikalabs.com/browse/LIMS-1931))

isn't it perfectly fine to call batch on a list of items when `len(items) == 1` and orphan is 1 or even higher?


Please rename button1 to something more meaningful


empty line after variables initialization


So I've been experimenting with using an array with 1024 locations as a file system, but I can't get it to print the string I store in one of the elements, and I was wondering if you could help. I included a screenshot below, the only part that hasn't been included is where I initialized loaction with `int location=-1;`, and where I initialized the array as `char *files[1024;`. If you want the code, I pushed it to the dev branch of my fork.

![screenshot from 2015-07-10 19 35 32](https://cloud.githubusercontent.com/assets/8160403/8631009/87c37aaa-273b-11e5-824a-b45ebe9f5ebc.png)


empty line before if


You also need to update the README file for this
https://github.com/lavab/api#license

Is there any specific reason for this change?


use string.IsNullOrEmpty


Change textbox1 to something more meaningful
Change folderBrowserDialog1 to something more meaningful


Why is `redirect_field_name=None` here? Does it do anything? [Relevant documentation](https://docs.djangoproject.com/en/1.8/topics/auth/default/#the-login-required-decorator)


Also includes argument re-ordering changes


Ok, this commit LGTM.


right now you can't do `T{}()` but that should be allowed syntactically.


Add folderbrowserdialog as a form control


What is the purpose of this if?


Without this || addition, only the first row of a repeating section was getting a change triggered.


Before doing this, a field in a repeating section would total all occurrences of a field when it was shown.


Not sure why jQuery(this) wasn't in there, but it seems important. Do you see any problems with that?


Quitar este bloque y agregar la llave abierta por mientras


will try and report! ;-)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17824/testReport/) for this commit**


Is this the proper way to instrument classes in hibernate-entitymanager, or should this be done some other way?


Thanks for cleaning this up!


I would prefer that you keep the original naming for the first interface. This name ends up becoming too long. You can add an additional parameter to rename the subsequent interfaces that are created with _ns_add_ifc.


This has been temporary removed.
Will add it back during the performance evaluation


Line length is quite long here, please try to shorten.


Just curious ... What is this line is checking for? Is a `Type` different from an object?


Instead of having the test cases as separate cs files, why not make them as const strings in a separate file? Then we just need to look at a single file for each rule. If we are to keep separate cs files, then the size of the project is increasing, and for adding a new test case, the cost is more, create new files, add them to the project, etc and finally when we remove the rule based system entirely, we will be left with a lot of cs test case files, that are not meaningful anymore, since we don't have to share these files between 2 different systems, then it doesn't make sense to have all this complexity.


rddTable --> rdd table (why use camel case in description?)


Same thing applies to other unit tests.


austin we need to get back to work


No need to track this here - the navService will only add an item once


I forgot to mention that we have a programmatic solution for this with `$mdConstant.CSS.TRANSFORM` which at runtime initialization internally makes calls `vendorProperty()` and uses `$sniffer`...

```js
styles[$mdConstant.CSS.TRANSFORM] = 'translate' + axis + '(' + newPosition + 'px)';
```


它有4大核心特性


It's the method name.


Is essentials availiable for sponge now?


@yourteamneedsadam I fixed this in a branch that I have been working on (to get the code pushed up to pypi). I will look at yours as I just hard-coded the version in mine (but yours is a better solution as it doesn't require manual updates).


修改后的意思错了！英文的意思是鼓励使用外部连接池


+ <title>Fork-Spork</title>


anytime you want @YelonixDaHero


perhaps this is a debug print?


Gravatarから画像を呼び出すヘルパーメソッドを定義し、ビューからそのメソッドを呼んで、画像を呼んで来ています。認証の通ったメアドだと設定した画像が来るらしいですが、DBには適当にメアドを登録したのでデフォの画像が来ています。


点赞点赞


init


Python packaging is a mess. I will look at this.

Note, I have a separate branch where I have been working (slowly) on adding Netmiko to pypi so I will work on this issue there. The branch is called pypi_test. I will push this branch up to GitHub.


fdgfdgfdgfd


It would be perhaps nicer to do it in the iterators themselves, since we need to do this even for

ListMultipartUploads{}

```
- key-marker
- upload-id-marker
- prefix
- delimiter
```


We might want to make it attribute driven. Let's say in settings.php we have $registration_type, if it set to open then we do reg.php as in this commit, if it is closed then print the message stored in $registration_message. Thoughts?


Gravatar側のハッシュ化アルゴリズムはMD5だぞ（笑）SHA256って書いてあったら認証済みでも画像引っ張れないから、

- ハッシュ化アルゴリズム修正
- 試しに自分のメアドをGravatarに登録
- DBに登録アドのユーザを追加、画像の確認

ここまでやってみてください


@jwvg0425 와우 감사합니다! 민망해서 공개는 못 하고 뒀는데 ㅋㅋ

1. 제가 링크해둔 글들과 비슷한 맥락이군요. 그래도 뭔가 믿을만한(?ㅋㅋ) 사람이 난 이렇게 쓴다, 한번 얘기해줬음 했는데, 감사합니다.
2. 테스트 해봐야지. 혼자 급하게 이해하느라 사소해보이지만 큰 부분을 놓쳤네요. 감사합니다.
3. 'range-based for문'은 찾아보고 반영해서 커밋할게요.
4. 오, 저도 (매우 예전에..) 배울 때 `sizeof(members)/sizeof(members[0])`로 했던 것 같은데, 2년이 지나니까 다 잊었.....ㅋ...... 크기를 쉽게 읽지 못 한다는 개념을 잊지 않기 위해, 당분간은 일부러 (표준도 아니니까!ㅜㅜ) 매크로는 자제할게요.


Yeah. I literally logged into opscenter and tested out a bunch of inputs to make sure it works. ☺

From: Ben Lackey [mailto:notifications@github.com]
Sent: Thursday, July 9, 2015 7:58 PM
To: mahthi/azure-arm-dse
Cc: Mahesh Thiagarajan
Subject: Re: [azure-arm-dse] Fixing Regex for opsCenterAdminPassword (dd74d08)

Is this correct? While we don't have a proper schema, every one I've seen meets the 15 char letter and number rule.

—
Reply to this email directly or view it on GitHub<https://github.com/mahthi/azure-arm-dse/commit/dd74d0895b28fc3900f40ff5df1e1304c810dd01#commitcomment-12097799>.


toma en cuenta que ese col-lg ayuda a que la pagina sea responsive y se vea ordenada no los borres a la ligera


kkk


How about just isset($registration_message)? Or is_null? Thursday, 09 July 2015, 08:18PM -07:00 from BGmot < notifications@github.com> :

>We might want to make it attribute driven. Let's say in settings.php we have $registration_type, if it set to open then we do reg.php as in this commit, if it is closed then print the message stored in $registration_message. Thoughts?
>—
>Reply to this email directly or  view it on GitHub .


You're right. There is a problem on cpp target. It seems hxcpp cannot compile code generated for "cast(value,Int64)". Unsafe "cast (value)" should help. :)
Please check new "protohx/MessageUtils.hx" https://github.com/nitrobin/protohx/commit/1aae84c19726a2b811b5bde6f7b6ccb10803d9ec


wow nice gonna sue that guy


Thought about this while implementing, but decided against it. Idea is it is better to do this at the source since there should be no instance of an unencoded key or marker used. Reduces the chance of future bugs. We also do date parsing at this level too, so it is consistent.


good catch, i'll remove it.


Thanks for pointing it out. I copied it from the comparison panel. Didn't know it won't work.


That would work I guess. I just thought introducing $registration_type would give us more flexibility - open-simple, open-email-driven, closed etc.


Run it on godmode, it should be fine now.


These lookups should be done on init, and the component's context should be bound to them instead of passing `self`


I have no problem with this. Good job!  Thursday, 09 July 2015, 08:30PM -07:00 from BGmot < notifications@github.com> :

>That would work I guess. I just thought introducing $registration_type would give us more flexibility - open-simple, open-email-driven, closed etc.
>—
>Reply to this email directly or  view it on GitHub .


why name make it a subtype of the real arm blade?


I know Java uses this convention of adding the "is" prefix for Boolean values, but I think a more readable name would be ```shouldAddToBackStack```


we should use spaces instead of commas

e.g. `rules="min-length max-length"`


done


Interesting.

When I was playing with parallel generation ( https://github.com/fasterthanlime/rock/pull/848 ), I found that __sometimes__ rock generates incorrect (incomplete) c sources, but can not find out why.


typo `@param {Dictt}`


To account for a missing `rules` property the mixin should add an empty `rules` property to begin with.
When angle bracket components land, we'll need to add it as a default `attr` instead since those aren't proxied.


> Thought about this while implementing, but decided against it. Idea is it is better to do this at the source since there should be no instance of an unencoded key or marker used. Reduces the chance of future bugs. We also do date parsing at this level too, so it is consistent

Okay, that makes sense.


- [ ] task1
- [ ] task2
- [ ] task3
- [x] task4


While I'm not 100% sure what the final export will be, I'm pretty sure it'll need to be an object with more than just the validation function if we're going to support masking and active feedback.  Make this an object with a `validate` method.

```
{
   validate: function minLength(value) {}
}
```

During `init` we'll bind the appropriate component context onto the methods.


PS: I also reduced texture size back down to 24x24. The new rendering system scales them up fine so I didn't have to do it by hand. This might slightly improve performance? It's certainly easier on me.


I don't think that a merge can un-make a change. I think this happened because this file was moved. Hence these changes look like they are reverted back.


SHEEP IT :P


closure name should be `PDFDataWriter_endStream`


The space police is sad :tired_face:


The true cost of per-project style guides. I've also been trying to re-train my brain to not put the `{` on the following line after my previous project.

Or is it more that `snake_case_is_so_very_unconventional_for_objc` ?


Is it possible that this update has broken `AlignGroupDoubleArrow`? It appears to have stopped working for me.


RadianceRefactor (macumber) - Win64-Windows-7-VisualStudio-12: OK (2174 of 2204 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.64%25-yellow.svg)


Salam va inke man taze varedam too inja nemidoonam asan chi be chiye girhub


好的


Using xml query is much easier. Updated the unit tests.


What I meant is that users use their own editor, and we can't control them. Anyway, editors saving LF as EOL are many on OS/2, too. ^^

I think, we have no other choices about this. On OS/2, processing CR/LF is **MUST**.


hi, i have ML_lab1_review_student.dbc (corrected example for (4c), but do not appear the text
only the exercises, it is good for Submissions?  and  what do i do for text appear. Thanks for you help.
onesimo


@magicae 嗯？没懂


Thanks. ^^


aa a


Right, I should've put this in a branch instead, it was meant for testing out the functionality.


Ah.  Got it.  Was confused and thought it was the DSE password.


個人パスになってしまっている気がしますが大丈夫ですかね・・・？w


You should never check-in commented out code: it's ok to delete. History remembers anyway.


@jushe
Merge the `deal_SpecPiece` function into `clearPiece` function.
Do ***NOT*** make it as the member of `Map`


`PDFDataWriter_ appendTrailer`


Hold up, I can't find documentation for `_CRT_NON_CONFORMING_WCSTOK` -- where's that coming from?

Google even thinks that I mean `_CRT_NON_CONFORMING_SWPRINTFS`:
![google_wcstok](https://cloud.githubusercontent.com/assets/2142308/8611955/ef5ddf70-2696-11e5-8f13-a7e874cf7639.PNG)


Does this mean that all your indexes are stored in one giant table? Ouch. That will be a problem.


Python 2.7


大丈夫じゃないっすねｗ
修正しましたーあざっす！

https://github.com/dealforest/Tuna/commit/05438a0bee988a57c128ff4ce2e773956fb8e2d7


Ah, hmm... I'll abandon this change.


4 executors launched requiring 1 core and 512MB of memory each. 1024MB of memory per worker needed.


Isn't that starting to look good? :)


@lukewagner The compiler should be able to hoist bounds checks for multiple loads/stores with the same base using the guard page(s) trick without any need for traps/signal handlers, if the semantics for out-of-bounds memory access are: oob loads return an undefined value, and oob stores put values into an undefined location. In that case

 load_i32(base+4)
 load_i32(base+8)
 store_i32(base+N, value)

could be turned into something like

 tmp_base = clamp(base, limit)
 load_i32(tmp_base+4)
 load_i32(tmp_base+8)
 store_i32(tmp_base+N, value)

given N+3 bytes of guard memory (the VM is free to pick appropriate sizes, and could even adopt dynamically to some degree). The advantage of this approach is that it should also work well with 64-bit addressing in the future.


Ooops... Yes. OS/2 kLIBC defines ``` __KLIBC___ ```. And MKSH_NO_SIGSUSPEND is defined.


@Crepusculo
Your commit message is not qualified.
Please be careful next time


After you create a `3.1.2.4` tag, you should bump the `$version = `3.1.2.5`. It forms the first part of a pre-release version.

Let's take this example:
![image](https://cloud.githubusercontent.com/assets/80104/8611948/aac57f44-267d-11e5-914a-0ec2096ed001.png)

In chronological order, it should have been:
 * 3.1.2.4-b224
 * 3.1.2.4
 * 3.1.2.5-b226

NuGet treats anything that has a pre-release suffix to be earlier than a stable build with the same version. A `3.1.2.4-b224` is a pre-release build of a `3.1.2.4` build. This is a minor detail that only matters if you are wanting to use the latest pre-release version.


Assignment Branch Condition size for run_test is too high. [20.12/20]


Align the elements of an array literal if they span more than one line.


first commit


largest number


Yeah, I didn't know at first either. But for features with full support I add some info that can be discovered on search requests, so I did that for location.search too:
http://caniuse.com/#search=location.search


This path through the code prohibits relative imports in Python modules dropped into `library/`. What's the intent?


곧 IndexError 처리도 필요할 것 같네요


It is not proper to determine if a file is executable or not with the file extension. Because there is no way to restrict a sort of extensions.


I'd remove unneeded code rather than commenting it out.

In the long run these comments will just be noise, and if somebody wants to look at what the code looked like before they can just ask git.

This goes for a number of other commented out lines as well, please remove all of them (or none if you really want them in here).


Hello knoy i'm french and my english is not very well excuse me .
i have got a teensy 3.1 and macbook 13 azerty keyboard .
code is working only i change manually keyboard on desktop .(french to american).
After the reboot keyboard is french and the code doesn 't work .
What can i do please ?
thanks for your work .


Dead comment. Please remove. :-)


Haha, indeed! I was pretty tired when I wrote that yesterday! Thanks for spotting it!


In the interest of somewhat limiting the scope of this PR, I'd agree with postponing this for now.

Good call!


@bmeurer Those of us striving to reduce sources of non-determinism would *really* like the semantics for OOB to be "always trap".  This is especially important for OOB since it's such a common bug and we expect a plethora of impl strategies across hardware and browsers so you run a real risk of apps becoming dependent on the impl details of one strategy (certainly we see this in native C++ apps).


**GJ!**
![Minion](http://octodex.github.com/images/minion.png)


Maybe open another ticket for this case?


Better to just pass the binmode flag manually than do all that weird stuff
with sections.
The intention with the binary I/O etc. was to always read in binary mode,
and for cases where files were written in text mode and become corrupted
with \r characters, we just try to ignore the \r's when reading things in.
Can you explain  your plan for checking this in?  You understand that the
svn is still upstream from the git, right?

Dan

On Thu, Jul 9, 2015 at 7:48 PM, jtrmal <notifications@github.com> wrote:

> Interesting -- but that seems too magical to include it, you're right.
>
> BTW, I was just thinking about the compatibility of the files. The binary
> files should be fine, i.e. you should be able to download the system build
> from kaldi-asr.org and start using it in windows -- my question is about
> the text files -- these won't probably be "portable", right? Because of the
> different line ending.
> But I think it shouldn't matter much -- the text files are usually used
> only for debug, AFAIK. And, unless things changed, I believe Mac has
> different line ending as well and we didn't have any complaint about that.
>
> y.
>
> On Thu, Jul 9, 2015 at 10:40 PM, Kirill Katsnelson <
> notifications@github.com
> > wrote:
>
> > I have a powerful linux box, where I do most of actual kaldi
> > experimentation. Indeed, I'll run pre-commit tests.
> >
> > BTW, by any chance is there a way how to make the ios::binary flag
> default
> > on win?
> >
> > Probably not in a compiler-independent way. Here's a leftover from my
> > initial porting efforts (great minds think alike, uh? :-) ):
> >
> > A library conains just one file:
> >
> > #include <fcntl.h>
> > #include <io.h>
> > #include <stdio.h>
> > static int initbinstdio(void) {
> > _setmode(_fileno(stdin), _O_BINARY);
> > _setmode(_fileno(stdout), _O_BINARY);
> > return 0;
> > }
> >
> > #pragma section(".CRT$XIU", long, read)__declspec(allocate(".CRT$XIU"))
> > int (*binmode_stdio)(void) = initbinstdio;
> >
> > .CRT$XIU is one of "magic" section names; these sections contain pointers
> > to initialization function, and these functions are called quite early by
> > crt0. Any binary compiled with this library and force-referencing the
> > _binmode_stdio will have its stdin and stdout open in binary mode. Not
> > sure if it will set cin and cout to binary mode, but I have a hunch it
> > will.
> >
> > I thought about compiling OpenFST with this trick, as the fst* programs
> > are often used in scripts with pipes.
> >
> > I do not know if the Intel C compiler honors these special sections. It
> is
> > also likely, as they went quite far in making their compiler pretty much
> a
> > drop-in replacement for the Microsoft one.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12097695
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12097740>
> .
>


I think, it is easy to use '/' all the time, and all users using mksh(or other unixy shells) may accept it. However, drive notation is not. This is not a problem that mksh alone can solve.


自分も今まで曖昧にやっていた側なので全然です、、
今回もたまたま気付いただけです！


Could you add a test case for "accents could be found by their base char"?

As someone with accented letters in [the language](https://en.wikipedia.org/wiki/Swedish_language), I'd like to specifically note that:
* Searching for `a` and finding `å` is *good* (especially if there is no `å` key on your keyboard).
* Searching for `å` and finding `a` is *bad* (no matter what your keyboard looks like).


@oubiwann or @rvirding, is there a better way to express this in LFE? I had trouble with the pattern matching..

```lfe
(defun is-anagram?
  (((tuple lowered sorted))
   (lambda (other)
     (let (((tuple lowered* sorted*) (normalize other)))
       (cond ((=:= lowered lowered*) 'false)
             ((=:= sorted sorted*)   'true)
             (else                   'false))))))
```


I think we may want to keep this argument even though it is currently unused. May be useful for optional state asserts. But @sparhami should decide.


@danwall it is possible. Please, open an issue with configuration file and code snippet that I will investigate for you.


Use proper indentation. Shift Case statement to next line to increase readability.


Use meaningful names


@Wafer-Li
I'll make it as a FRIEND,but it won't be used outside clearPiece function,are you sure to expose it?


Yes the rest was fixing indentation and removing unused imports


I removed it from the PR.


@jtrmal, @danpovey: Modern Windows C runtimes, both MS and Intel, have no trouble reading text files with either Unix or Windows style line ending, so no problem there really. Unix-style '\n' is fine in all cases.

What really breaks in OpenFST is something like e. g. `fstcompile myfst.txt - | fstprint - -` because in the pipe, the file is binary, and, in the default text mode, the C runtime will helpfully replace each '\n' with a '\r\n' on output, and every '\r\n' with '\n' on input. It looks like a reversible operation, but I have seen it breaking, although I am not sure exactly under what conditions.

Also, Windows style line endings are not palatable to cygwin ports, do not work in bash or perl scripts.

The initialization sections are documented, and Microsoft is known to maintain very good backward compatibility in compilers; what worries me is that other compilers, Intel C in particular, might not handle this.I do not like the outward weirdenss of this approach, but patching every fst binary is arguably worse, and Win32 is not officially supported there. So I am not dismissing it, this might be a pisk your poison case. For kaldi no question, setting the `ios::binary` flag is the way to go.

> Can you explain your plan for checking this in?

svn, of course, and indeed only after all tests pass with linux/gcc.


Why do this?


do you need \\. instead of \. ?


Use meaningful aliases


Use proper casing.


@jushe
It's a ***submodule*** of `clearPiece`, but ***NOT*** a member of `Map`


@jtrmal, @danpovey A question on svn commit messages. Should they be one-liners? I usually give a "paragraph" style commit descriptions, with the first line a one-sentence description and the rest of lines elaborating if needed. Are such multi-line comments acceptable?


r=MonsieurNicolas


always create a newInstance static factory method for your fragments..


Is it sensible to lower the values, or reconfigure the end point sin the radio? I lowered to 895 since the DX6i was putting out a value at that value that could not be changed in the radio AFAIU. I'd like to keep it where it is?


Output is not as desired. Alternate highest paid employees are expected.


string literals must always be defined in your strings.xml


Ok. Enterada. Muy bien.


saw approval from MonsieurNicolas
at https://github.com/graydon/stellar-core/commit/17d206b29183eedc44860aaec85cd15a213686ea


merging graydon/stellar-core/debug-txset-mismatch = 17d206b2 into auto


graydon/stellar-core/debug-txset-mismatch = 17d206b2 merged ok, testing candidate = 8ec93e6c


Paragraph-style is OK.
Regarding the issue with OpenFst binaries breaking: wouldn't it make more
sense to just compile the OpenFst tools for cygwin?   Does it even compile
in Visual Studio?
Kaldi itself does not have a problem, and it opens FSTs in binary mode.

Dan

On Thu, Jul 9, 2015 at 9:42 PM, Kirill Katsnelson <notifications@github.com>
wrote:

> @jtrmal <https://github.com/jtrmal>, @danpovey
> <https://github.com/danpovey> A question on svn commit messages. Should
> they be one-liners? I usually give a "paragraph" style commit descriptions,
> with the first line a one-sentence description and the rest of lines
> elaborating if needed. Are such multi-line comments acceptable?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kaldi-asr/kaldi/commit/5d2cc33b614294c36aa6e7e0e5619d69e9ca7aaf#commitcomment-12098556>
> .
>


string literals should always be defined in strings.xml


Use Alias for the column which shows the count of the employees


string literals be declared in strings.xml


@jessica-azgs I'm revisiting this issue and I've just tested this on both my Nexus 4 and my iPad.  Both devices can detect the touch draw event and I can encircle a group of spots just fine.  When you run this on your S6, are you actually drawing on the screen or drawing in the Chrome Developer ?


this should be executed in onViewCreated callback method..


Test


"aw"? kinsa na si aw?..

variable names should be descriptive even how simple it is..


let's add "protected" or "public" here ?


Same use alias name here as well


Thanks for the heads-up, I'll remove this for now since it looks like it has to be done in settings for Yosemite.


This should be `#include <range/v3/utility/semiregular.hpp>`


@danpovey: there is an unofficial OpenFST port, and this is what recommended by the Windows README in kaldi.

What I am also interested in, time allowing, is compiling everything using dynamic libraries. OpenFST has a dll support (sans weight type class registration), kaldi does not. The difference is the treatment of externs: all externs are exported from an .so in linux, but in Windows all exports must be explicit. There are [good arguments](http://gcc.gnu.org/wiki/Visibility) for explicit exports in linux as well. With statically linked binaries and full optimization, the compile time is godawful, especially with the Intel compiler.


Click here for cat photos.


You had earlier suggested getting rid of `frameBufferOffset` and encoding an `int`(four bytes) instead of a `byte` at a time into the frameBuffer.


Things cats love:

cat nip

laser pointers

lasagna


I can't find a standard way to do this by default.

* In Tomcat, it's a property of the connector.  That could work.
* In Jetty, it seems to default to a system property. :-1:


Did you get any further denials for chkpwd_t reading tmp_t lnk_files? That permission isn't granted any longer. Neither is the chkpwd_t sysfs_t:file { read open };

The filetrans looks good.


I'm not sure where I got Oath tokens from, sounds rather mediaeval, thanks for the fixes!


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/70330667


This query will not return departments with no employees so instead of this use joins


@tomik-dev Please suggest how to resolve class `NavigationMarkerProvider` to use both `butterknife.InjectView` (v6) and `butterknife.Bind` (v7).


DSpace needs this too, so that's good.


Shouldn't this be `var Console = require("./console.js").Console`?


Hermano disculpa como se utiliza esa base de datos? Ayudame por favor.


fast-forwarding master to auto = 8ec93e6c


And it shows the errored scrapers on the home page as well


Ahh, thanks @mlandauer.


msbuild will not exist on linux systems. The correct incantation there is `xbuild Npgsql.csproj /t:RewriteAsync`. Possibly, the build instructions should tell people to create an alias?


hey there, thank you for your fix! regardings its implementation, I would rather define an ARM9_FCRAM_EXTSIZE constant (holding the additional FCRAM size on n3DS systems instead) and change the code to something like
u32 size = ARM9_FCRAM_SIZE + isN3DS() ? ARM9_FCRAM_EXTSIZE : 0;
then:
result = dump_mem(...)
maybe you can find a more elegant solution than mine


The name of the table should be Orders not Customers


Please insert some more Orders for different Customers so that queries can be evaluated.


Suspect to change ^^ thought that aswell yesterday while looking over it.


Functions:
1. Sample at sender
2. record sent packets in hashmap
3. read FIFO, get received seqid of flows at receivers. Compared to sent packets in 2, calculate flow total_volume, loss rate, get target flows
4. When the number of sent packets % NUM_PKT_TO_SENT_CONDITION, send the target condition information to the network.
5. TODO: add code to plug-in the upper features into tcpreplay.


Yes - I asked them to replace it since this broke the app for the current active users.


Very helpful pointers, thanks!


Yeah, I do want to add an assert sometime soon.


Use convert function to display date details.


For that add below code in this function
options.on('click.fs', 'li', function(e) {
   trigger.trigger('close.fs');
 }


This is a WeakAuras 2 UI. I'm still working on it.


yes,

Sorry I wasn't watching this thread... I commented in https://github.com/mgreter/libsass/pull/4#issuecomment-117070530

issues
https://github.com/sass/libsass/issues/1304
https://github.com/sass/libsass/issues/1303
created


Also display the employee details with the 'Yes' or 'No'


yes there are issues, I can create a spec for it

https://github.com/mgreter/libsass/pull/4#issuecomment-117070530


I think we're using 1.10.4, not 1.11.4. If this is intended, make sure nothing breaks/looks out of ordinary.


`Founder`


Is `toLowerCase()` necessary here?


I updated this in a commit dzung2t/module-magento@393bb600e9bf25aadc707c143f68f81e4f350c67.
Thank you!


I think this is the natural way to write it because we need to go through the whole loop to calculate the number for the exception.

I'll fix the bug and add some explanatory comments


咦


a


Want to document the step property with \br_property while you do this?


But, this must be a regression from FAF work,I guess? How did we break this?

... The game surely hasn't always done this?


nice :)


Hi,

Meaby it is better to do it this way, since it is also an option to make the dictionary case insensitive in the constructor:

        protected virtual bool IsAcceptableBreak(String s, int fromIndex, int candidateIndex)
        {
            if (_abbriviations == null)
                return true;

            foreach (var abbriviation in _abbriviations)
            {
                foreach (var token in abbriviation.Tokens)
                {
                    var stringComparison = _abbriviations.IsCaseSensitive
                        ? StringComparison.InvariantCulture
                        : StringComparison.InvariantCultureIgnoreCase;

                    var tokenLength = token.Length;
                    var tokenPosition = s.IndexOf(token, fromIndex, stringComparison);
                    if (tokenPosition + tokenLength < candidateIndex || tokenPosition > candidateIndex) continue;
                    return false;
                }
            }

            return true;
        }
        #endregion

And in the Dictionary . ToList . do it this way:

        #region . ToList .
        /// <summary>
        /// Converts the dictionary to a <see cref="List{T}"/>.
        /// </summary>
        /// <returns>A string list object.</returns>
        public virtual List<string> ToList() {
            var toList = new List<string>();
            var e = GetEnumerator();

            while (e.MoveNext()) {
                toList.AddRange(e.Current.Tokens);
            }

            return toList;
        }
        #endregion


send_udp_conditon_pkt(): to optimize, the packet to be sent should be initialized outside of this function, save time


здесь видимо `$` в конце нужно поставить?


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.10](http://pixelated.design/build/viewLog.html?buildId=26&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 41 Build time: 00:00:09


I don't think this actually crashes, it just doesn't do anything that the user can tell from the gui. Wondering if in this case we should pop up some sort of dialog letting the user know that it failed instead of just failing silently.


I think one thing is missing `.ToLower()`


I believe the previous change to the file caused it.
It looks like that change also removed the fade-in fade-out of the window.


It crashes because `desktop_file` is a variable that doesn't exist, hence the NameError.


What the line does is that it logs which desktop file name failed to copy.


Yea.. but your newest release adds another lib support that we would have to implant into it as well.
Like the FloatingActionButton libs......

This is the top most used in roms rated Kernel controler..
Everyone uses it......

Sent from Mailbird [http://www.getmailbird.com/?utm_source=Mailbird&utm_medium=email&utm_campaign=sent-from-mailbird]
On 7/9/2015 9:33:22 PM, Will Nozick <notifications@github.com> wrote:
Nice work guys. So this now supports completely inline building via the make command?
—
Reply to this email directly or view it on GitHub [https://github.com/Eliminater74/KernelAdiutor/commit/5d4e400e4cc272bebe30be6c64c0eb7096f5f673#commitcomment-12097086].


Yes I know, I made the mistake in the first place :) I'm still not sure if failing silently is the best thing to do here. On the user side it just seems like nothing happens.


I think it would be better to map from List<skills> to list<SkillModels>

from collection -> to collection


I think you can use existing materialize class for that

`.left`


see materialize `.right`


this commit looks good to me


this commit looks good


Wait, you added me to the contact information? I'm not working with Radirius right? I'm just a contributor to Mercury, not all the projects by Radirius.


I'll take a look and see if tests can pass, it shouldn't be a problem thought, cause it requires v1.6 jQuery and above and we have that.


I think this should be `rx_attr` instead.


I'm considering,

could we check this for only `IsRecruiter()`?
because when user is not a recruiter, we don't care who he is. just redirect to AccessDenied page?


AccessDenied page?


This also adds support for audio files without an index (happens sometimes)


Weak vote to remove this, as it compiles without it. (Not sure if best practice to leave in?) /shrug


Will do, thanks!


that looks pretty nice


I'm just consider about naming....

What about OfferListViewModel ?


why?


only one thing :
 - I think it would be better to map from collection to collection, so we can reuse this method


@Optimusprimeums thanks for fixing it up mate! :) Have a good weekend


Resolves #1.


inline css is Ok, but it's difficut to maintain?
what about using our validation css class for this purposes or create dedicated class ?


Why do this?


5 - is just magic number, one day it would be hard to other developer to find and change it to 42,
why don't keep top 5 of skills in view model for ex. TopSkills?


@apalsapure

Please do not check.
Still working on suggested changes. Will inform once done.
Thanks.


better to start of ret with -1 ask karthik for this way of exception handling


These location handlings may be done with a proper handler with it's methods. It's not necessary but it could compact the code. Is it fine for you?


- git push


would be better to use
AreSkillsDuplicate*d* ?


@budpi I had trouble with this also.  Firstly you need to make sure you remove the inequality signs "< & >" so you should just have "your@emailaddress.com" and "yourusername" etc.

There is no need to forward local ports as it is a standard TLS email port used in all email applications.

The last thing I had trouble with is that I had it from and to the same email address which didn't seem to work..  I changed to send it from a gmail account to a icloud account and it started working fine.

When you are testing, drop the "time_to_wait" to 60 so you only need to wait a minute between tests. When you know that it works put it back to the correct time to wait. Make sure you restart each time.

Hope this works for you.

Cheers


I don't know yet how to test this but it seems like the 'existingVPC' logic is broken with this commit.
Shouldn't it be something like the following instead?
<#if existingVPC>
   "DependsOn" : "PublicRouteTable",
<#else>
  "DependsOn" : [ "PublicRouteTable", "AttachGateway" ],
</#if>


add condition for non empty fields only, otherwise it will keep going on


whe do we need this?


The on the fly code formatter only treats code fragments.


Done.


@mp911de the collection stuff is handled in SD-Redis [o.s.d.redis.support.collections](https://github.com/spring-projects/spring-data-redis/tree/master/src/main/java/org/springframework/data/redis/support/collections). The repository abstraction could do something quite similar to https://github.com/josiahcarlson/rom.


why do we need this ` !IsCandidate()` ?


Ok, you are right. But as i understand it, you have to checkout the target branch first, pull it afterwards and than you can push the changes. So uncommited changes are not possible before such a task.


@frankdiox Please add a unit test for this method.


isRightRecruiter - is not good name? what we mean by right?
I would name this: if current user an owner of offer


Nice !:)


logic is ok, name is not


@gotnull I ran into the same error, but I eventually got it working. First I ran [the mono uninstall script](http://www.mono-project.com/docs/about-mono/supported-platforms/osx/#uninstalling-mono-on-mac-os-x), then I manually removed all of the mono-related binaries from `/usr/local/bin/`. (El Capitan won't allow `/usr/bin` to be modified anymore, so I had installed mono into `/usr/local/bin` instead.) After that I tried running `mcs` and `mono` from the terminal to make sure they weren't in my PATH.

At this point I started building mono from scratch. Here are the commands I ran, in order:

```
git clone https://github.com/mono/mono.git
cd mono
PREFIX=/usr/local
PATH=$PREFIX/bin:$PATH
./autogen.sh --prefix=$PREFIX --disable-nls
make get-monolite-latest
make
make install
```

`mcs` is now working nicely, and the mono binaries successfully reinstalled into `/usr/local/bin`. Hope this helps! And thanks to @dmccaffery for steering me in the right direction.


Have you tried just change 'activity_main.xml' ??
<img width="1680" alt="activity_main_layout" src="https://cloud.githubusercontent.com/assets/693098/8613058/66a06f6a-26a8-11e5-8b55-3331addfad1f.png">


Est-ce que c'est volontaire de déclarer ChallengeDb en global ?


Why?


remember not to leave this in production :)


@errordaiwa Would be better to assign NotNullPosIntegerValidator.class since it should be positive integer value.


Ah, I see. I don't think this works afterwards since later code depends on the file at `user_desktop_file` to exist. A notice would be nice, but that would probably be a different PR (this is just a quick fix for a crash).


hi


As far as I can tell, this is the first commit to master that caused a freeze during bootstrap on win64 appveyor. No idea why, and currently bisecting locally to confirm, but may need to revert and find a different way to accomplish this (going through CI first instead of directly to master).


I disagree with this sentiments. There is plenty of literature that points out why constructor patterns are pretty terrible. Since python is dynamic and offers default value to properties it avoids a telescoping constructors problem so there is something nice. However, without a clear interface on object is ready this guarantee is absolutely false.

instead of
action_db = ActionDB(pack='mypack', name='myaction', enabled=True)
action_db = ActionDB(pack='mypack', name='myaction')

woudl still be ok. So where is the guarantee?


Would `record.send(:"#{column}").present?` work here? Would read better.


Hi @romracer, thank's a lot for helping me... But I'm sorry I didn't get your point: I have a Moto X first gen, not a 2nd Gen. In any case, I put on an OTA captured by a XDA user, and the Ota file 212.44.26.ghost_row.Retail.en.EU only is not available anymore


Can this be uploaded to supermarket now?


;-)

Finally, yep. Please have a look at the newest issue and give your opinion.


No, it's alright but there are still some links in the file, I'll remove them.


We're starting to use these in other places, so I'd like to make this an argument to the function. i.e.
getSitesByFrecencyWithLimit(limit: Int, andMinIconSize iconSize: Int)


What if we have a uid in caps.. right now it won't be allowed on removal of return true..


nit: use `fmt.Errorf()` since we're doing formatting.


I think I'd rather this was iconWidth == nil, don't get the icon, iconWidth == MAX_INT, get widest icon. You need to be careful in here that if we only have a 16px icon, we return it even if you ask for a 32px icon.... I think. But you might look and see if anyone ever doesn't want icons. If they always want them, just remove the nil option entirely... (Top Sites is going to use them soon).


```python
groups, centers = kmeans(cities)
```
で一度に結果を受け取れますよ。


Yes, It's best.
I modified.


Thx. Found the collection stuff right after my comment.


If we do use these Int-constants here, we should define them as consts in here. i.e. public let WidestIcon = -1


Maybe you could remove the usage of body.total?
`if _.size(body.results) < limit` ?
Then you could optimize the query with ` withTotal=false`
(http://dev.sphere.io/http-api.html#paged-query-response)


Thx!
:+1:


A line break was cause for a memory leak?


typo `amke install` -> `make install`


@rootree: Could you try with the current version? If you can reproduce it, please open a bug report with code to reproduce it.


1. Использование двух типов кавычек чем-то обусловлено?
2. После запятых следует ставить пробелы (у нас такие правила оформления кода).
3. Для чего здесь модификатор «m»?
4. Корректней было бы привязать открывающую конструкцию к началу файла, а закрывающую — к концу, это избавит нас от ряда возможных проблем (мало ли кто, где, как и что использует в тексте, быть может мне вывести куда-то «<?php» требуется).
5. Чтобы подсветка в редакторе работала и в чанке всё было хорошо, достаточно всего-лишь делать так (по крайней мере, в тех редакторах, в которых я проверял, работает):
//<?php
//?>
Так есть ли вообще смысл в этой операции?


I think rnewman already said he'd rather a view here? I don't really like sql views, but I'd defer to him if he wanted one...


Note that calling endStep is not necessary when the next startStep has the same source.


Может быть в этом случае «$.ddMM.fields[field].fieldtype» у custom_tv должен содержать правильный соответствующий тип? Или я что-то неправильно понял?


Is it faster to group by siteId than to do two joins? I wouldn't be surprised I guess, just curious. historyID and siteID are kinda confusing here...


Note that popLevelProgress will automatically close the current step so endStep is not required.


right, i'll fix that


I wish we could just get all the icons for the site here and let callers do the sort... Also, some tests for this would be really nice.


You are correct that because of they way mongoengine base class works there are no code guarantees right now. It's a convention we need to follow.

Now that we have that convention in place we can add more guarantees ourselves (e.g. throw if you pass in unsupported field, etc.).


ここの2行、とても違和感があります。

```python
centers = [[0 for k in range(2)] for i in range(n)]
initcenters(centers, n, cities)
```
の方が意図が明確になります。`initcenters` は戻り値を返さないように。

または
```python
centers = [[0 for k in range(2)] for i in range(n)]
```
の部分は、initcenters の中でやってしまって、ここでは

```python
centers = initcenters(n, citis)
```
の方がよいです。この場合、`initcenters` は別の名前にしたほうがよいかも。


You can take a look here: https://github.com/samg/diffy

It returns a `Diffy::Diff` instance which supports several output formats, so we have to specify that we want the plain text output here.


Git to know you are a git buff.  People have different preferences.  Personally, I like to avoid merges unless they are necessary as it makes reading the history easier.  rebasing and cherry-picking both are ways to straighten out the history before pushing and I noticed you are using merging instead.


export HUBOT_SLACK_CHANNELMODE=blacklist


This broke the test suite.  And why do we want this? This will make my graph have holes every time a node is restarted. I dont want that.


It's rescued here: https://github.com/SUSE/machinery/pull/1111/files#diff-6ba1d3059a6b2950025cdb8ab2bdb4f9R173


@thatpixelguy Thanks for the detailed steps. Unfortunately I still get that `make[7]: *** No rule to make target `../../external/ikvm/reflect/*.cs', needed by `../class/lib/basic/basic.exe'.  Stop` error.


Yes, it is on purpose. I couldn't get it to work anymore without having the gem in the Gemfile, presumably because we have to use `bundle exec` now because of the github source of one of the gems.


This defaults to 0, right? Maybe you should note that.


@franklingu Could you explain what is this for? It seems it doesn't make the test failed when removed.


WOW!!!

nice job!!!!!!


So we can't use this in a shared libraries? This is not compatible with the MS Permissive Use License?


Not a `static` or anonymous-namespaced variable?


if only github highlighted these more loudly - no tabs in base code, with the exception of the couple of places they need to be tested for


I could see no way to have it include line breaks everywhere else but not on the innermost level. And having 6 lines per glyph made reading harder again in my opinion. And it made debugging harder, since one couldn't simply grep for the line matching the glyph in question to see all its data.


Well I'm expecting you to change it then!


I'm still astounded that this is the *recommended* way of naming threads.


Github is happy now.
All hale the mighty Github


Why? It is very necessary adjustment.
Return please...


how could I miss that :)


one commit


This didn't really change anything, you still have application specific code in Flame.


I see no reason why aging does not scale. However, the whole History implementation itself does probably scale badly, because the History pool size is fixed and gets lets effective at longer TCs and multiple threads.


试试看用Markdown吧，如果原文有图片可以很方便插入。


One reason I don't like the piping is that the moment one of the tools decides to report an error and die, e.g. the first one, then all the others will complain loudly about invalid input, including stack traces, which will drown out the original error message. The `Makefile` line is also in violation of the 80-character length limit, and escaped line breaks still don't make for very readable rules. I guess I'd design things in such a way that each file can be used both on its own and as a python module, and then have one python tool use them as modules without the serialization/deserialization overhead in between.

If the perl code comes from MathJax, does this mean that we should take our improvements to it back to MathJax? If not, then it sounds as if we were to maintain our version independently from here on, perhaps porting the occasional modification, and we might as well do so in Python.


From what I understand, this method can be replaced by using the default EntityReferenceSerializer.


@ytokas  please review


Tagged string or slip?


@terrawheat Hot Damn. Just a thought, if a Team has the same Player on a certain Week in different Season (very likely), then it may not return the correct instance as a Team also belongs to a Season.


Instead of going trough a complete SpaceReference with fake wiki you could directly create a local space reference and use default serializer.


This doesn't seem to compile and also is not called anywhere. You want to use this block when you do (or instead of) the other animation.


5. не знал :)


このechoはいるのかな？


You could use a SpaceReferenceResolver and pass the WikiReference as parameter.


nice !

I was also looking at that line and was wondering if thsi was correct :
https://github.com/melonjs/melonJS/blob/master/src/particles/particlecontainer.js#L63

if `dt` is modified by the function, is the variable scope only then local ? (not sure anymore)


We should check the expiry of the token here.
```exp <$> claims mJwt ```


" instead '


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.330](http://teamcity.monogame.net/viewLog.html?buildId=8611&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@chelmuth: forgot this in the original commit, please add to staging


Была привязка к конкретному html элементу - input, textarea и тд.. Соответственно когда ставиться custom_tv, который может быть чем угодно, это не срабатывало - я это заметил во время использования виджета choise_tv с новой версией MM


Fixed the commented errors.

About unit test, these are scripts to delete resources and the methods are basically calls to Openstack APIs.

What is the point of testing methods like this?:

def delete_image_list(self, images):
        """delete a list of images, provided by id.
        :param images: a list of image ids
        :return: nothing
        """
        for image in images:
            self.glance.images.delete(image.id)

(self.glance is an external object)

Any possible test requires a lot of mocking and don't say nothing about the code is working or not


Plenty of errors ;)

target  C++: content_content_browser_gyp <= external/chromium_org/content/public/browser/download_manager_delegate.cc
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:121: error: cannot find symbol
                    ImsConfig.WifiCallingValueConstants.ON :
                             ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:122: error: cannot find symbol
                    ImsConfig.WifiCallingValueConstants.OFF;
                             ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:126: error: cannot find symbol
                        ImsConfig.WifiCallingPreference.WIFI_PREF_NONE :
                                 ^
  symbol:   variable WifiCallingPreference
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:141: error: cannot find symbol
                    ImsConfig.WifiCallingValueConstants.ON :
                             ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:142: error: cannot find symbol
                    ImsConfig.WifiCallingValueConstants.OFF;
                             ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:198: error: cannot find symbol
                wifiCallingStatus = ImsConfig.WifiCallingValueConstants.OFF;
                                             ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:199: error: cannot find symbol
                wifiCallingPreference = ImsConfig.WifiCallingPreference.WIFI_PREF_NONE;
                                                 ^
  symbol:   variable WifiCallingPreference
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:221: error: cannot find symbol
        if (status == ImsConfig.WifiCallingValueConstants.NOT_SUPPORTED) {
                               ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:223: error: cannot find symbol
            if (preference == ImsConfig.WifiCallingPreference.WIFI_PREF_NONE &&
                                       ^
  symbol:   variable WifiCallingPreference
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:239: error: cannot find symbol
                mImsConfig.getWifiCallingPreference(imsConfigListener);
                          ^
  symbol:   method getWifiCallingPreference(ImsConfigListener)
  location: variable mImsConfig of type ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:241: error: cannot find symbol
                loadWifiCallingPreference(ImsConfig.WifiCallingValueConstants.OFF,
                                                   ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:242: error: cannot find symbol
                        ImsConfig.WifiCallingPreference.WIFI_PREF_NONE);
                                 ^
  symbol:   variable WifiCallingPreference
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:253: error: cannot find symbol
                mImsConfig.setWifiCallingPreference(wifiCallingStatus,
                          ^
  symbol:   method setWifiCallingPreference(int,int,ImsConfigListener)
  location: variable mImsConfig of type ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:268: error: cannot find symbol
            case ImsConfig.WifiCallingValueConstants.ON:
                          ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:270: error: cannot find symbol
            case ImsConfig.WifiCallingValueConstants.OFF:
                          ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
packages/services/Telephony/src/com/android/phone/ims/WifiCallingSettings.java:271: error: cannot find symbol
            case ImsConfig.WifiCallingValueConstants.NOT_SUPPORTED:
                          ^
  symbol:   variable WifiCallingValueConstants
  location: class ImsConfig
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
16 errors
make: *** [/home/joshndroid/temafloundersource/out/target/common/obj/APPS/TeleService_intermediates/classes-full-debug.jar] Error 41
make: *** Waiting for unfinished jobs....
# In case value of PACKAGES is empty.
Reading library jar [/home/joshndroid/temafloundersource/out/target/common/obj/JAVA_LIBRARIES/telephony-common_intermediates/classes.jar]
Preparing output jar [/home/joshndroid/temafloundersource/out/target/common/obj/APPS/WAPPushManager_intermediates/proguard.classes.jar]
  Copying resources from program jar [/home/joshndroid/temafloundersource/out/target/common/obj/APPS/WAPPushManager_intermediates/classes.jar]

#### make failed to build some targets (01:11 (mm:ss)) ####


It's a big break change, will anyone use absolute path in nunjucks?


@Alfwich I added some more structure to the work I'm doing on composing a card-game engine draft. Please let me know what you think. :blush:


.35s 有点慢啊。


lol..haven't finish


You actually didn't create a label that displays the like count.


@rpcme No problems at all. Making mistakes on dev-releases is more or less without consequences (this is why they are dev releases). However - can you please upload a fixed _004? There are **many** smokers who "front-run problems" by treating any dev-release as part of the index (i.e. they install the latest tarball, no matter its status). Currently these smokers are essentially stalled, as 003 is not installable on anything < 5.20.

Thanks!


So let me see whether I understood this correctly. Computer Modern for TeX has 𝚤 and 𝚥 in two places: in the text italics font cmti10 at positions \x10 and \x11 and in the math italics font cmmi10 at positions \x7b and \x7c. They look very much the same. KaTeX_Math-Italic doesn't have these symbols at all, but KaTeX_Main-Italic has them at \u0131 and \u0237. Right now, our metrics for these two are based on cmti10 but they should be based on cmmi10, since it's being used for both and the information in cmmi10 is more valuable in our use case. Right so far? I'll get this translated into code…


Thanks for your reply. @haxcop   I tried your solution,but it didn't work. Now it notices that password not accepted from server.
![smtp](https://cloud.githubusercontent.com/assets/13131511/8613663/fd7e900e-2713-11e5-9d0f-6ebca5b61a56.jpg)
![notice](https://cloud.githubusercontent.com/assets/13131511/8613681/1822bb6a-2714-11e5-9dab-2f4790933b6e.jpg)


Have to specify int for division in python3


oops


Fixed


almost certainly confusion. what is the right thing to have done? i think i was trying to do it.


Hi,

You are right this could cause troubles in case of existing VPCs, so we are investigating and if needed than fix this issue.
Our hosted version hasn't contained this change yet, so you could create clusters in existing VPCs through the UI. I tested it few hours ago.

Thanks for reporting this issue!

Br,
Tamas


Done.


Maybe you should check if the directory exist before you call mkdir?


changge password inti "*"


"-p" does that nicely. :) running the setup all the time allows run time fixing as well in case permissions got clobbered along the way.


indeed; that was bonkered in 08f1e153 when i was still starting to learn hy...
apparently that code path never was executed...

fixed with a7804502b


I think most of the build time is still used fetching the OF repo from github...

> mostly gstreamer that are not whitelisted.

you can add requests for packages to be added to the [whitelist](https://github.com/travis-ci/apt-package-whitelist). In the case of gstreamer, 0.1.0 [is already](https://github.com/travis-ci/apt-package-whitelist/blob/622548e93b9a1b0f2af9eaa9c8b458d548c987f8/ubuntu-precise#L3807) in the whitelist, so getting 1.0 to be added shouldn't be a problem I'd think.


This condition is quite duplicated in the code. For readability I proposed to change it in a method:
~~~
bool isJointElastic(int i)
{
    return (m_numberOfMotorJoints > 0 && joint_motor_map[i] != -1);
}
~~~


I like that you tied things up and moved this functionality into its own class.
But I feels slightly negative about the "unshade" name.  Feels a bit too unspecific to me.  I liked the old "unshadedName" better.


This is a new Commit for New-Rep


I got the impression this was what you meant by table header. I'll figure out something to get it out of flame totally.


Use WarnException here, so we'll have the exception in the log too


it's better to add `/` to `searchPaths`


Thanks fixed.  Still working on the PR.


コメントあまり役にたってないです。:)
この行を読んでも、pointer がなにをpointするのか実際に使用される箇所を見るまで、わからないです。

あと、c で pointer というとどうしても、`int*` のような実際のポインタをイメージしてしまうので、ポインタでないのなら、変数名としては避けたほうが無難です。

pointer だけだと、なんの情報量もないので、具体的になにを指すかを変数名に反映させたほうがよいです。


Nit: No newline at end.  Causes this nasty warning sign in the review tool.
Ditto for NestedListTestService.java below


thanks。


This is trying to do recovery, right? But how likely is it that we _can_ recover from this?
Why not just reset the index?
The good thing here is that we'll have a new directory for the index, and not run into trouble.


Nit: missing newline at end.

Ditto for various other files below.


You should maybe make sure the passed reference does not contain any local or in that case only delete the passed locale.


Can't be removed because is the last one.


just delete.


You could use [fenced code][1] blocks here for nice syntax highlighting by some markdown parsers:

[1]: https://help.github.com/articles/github-flavored-markdown/#fenced-code-blocks

```go
func toBinary(x uint64) string {
    s := strconv.FormatUint(x, 2)
    s = strings.Repeat("0", 8 - len(s)) + s
    return s[0:4] + " " + s[4:]
}

func printRanges() {
    for byte_index := uint64(0); byte_index < 32; byte_index += 1 {
        low_int := byte_index * 8
        high_int := low_int + 8 - 1
        low_str := toBinary(low_int)
        high_str := toBinary(high_int)
        fmt.Printf("%02d %s -> %s\n", byte_index, low_str, high_str)
    }
}
```


is the `<p></p><i></p>` wrong?


while ループよりは、ここは、for ループを使ったほうが、ループの意図が明確になります。

```c
for (int passed_n = 1; passed_n < LENGTH; passed_n++)
```

または
```c
for (; passed_n < LENGTH; passed_n++)
```


Definitely; so far, it's just a hack anyway


cmsz项目中，应用名称校验


Not sure this should be hardcoded; imho a definite candidate for configuration


May you please add a feature that will stop the bot for a while at the end of the game so that facebook can save the score to upgrade the level?


cmsz项目中，应用名称校验，用到了正则表达式。


You could have closed the ticket automatically :)


who are u


The correct URL for the online version of the DTD is now: http://data.udger.com/uasxmldata_old.dtd


All sorted now - the problem was the wrong CRS was assigned. In ogr2ogr they were using -a_srs instead of -t_srs.


It's not perfect, but it works ;) I'll enhance this soon


I thought #1989 fixed this, but looks like I was mistaken. cc @rrosenblum *could* we make a cop for this?


thank you


I am also using these classes in jQuery


How about using the tag? https://github.com/springmeyer/mapnik-c-api/blob/0.0.1/mapnik_c_api.cpp


宣言と初期化はここでは離れた場所でしないほうがよいです。ここで同時にしたほうが読みやすいです。
```double min = 1000000000```

最初に
```double min;```
を見た時には、これがどのように使用されるかがわかりにくいです。

なるべく、変数の宣言は、その変数が使用される直前におこなうほうがよいです。


v.get("ping_timeout", 2)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.330](http://teamcity.monogame.net/viewLog.html?buildId=8611&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 501, ignored: 6 Build time: 00:25:27


There's a public `getLayer` function you can use.


主要用到知识点：自定义属性动画(TypeEvaluator 实现贝塞尔效果)、PathMeasure(计算Path长度)、drawBitmapMesh用法、一元3次方程求解。


I think the overlay should be created in the test function. We should even have tests that create multiple overlays.


Just realized that you have tests that create a second overlay. So this is good.


@rowChooseChecked 这东西


You're right about this.

The right way to do this is to run the async rewriter as a DNX-integrated command and not a script (a bit like how Brice Lambson does with T4: http://www.bricelam.net/2015/03/12/t4-on-aspnet5.html). I'm just concentrating on other things at the moment, the regular csproj build should work on mono...

You're right that build instructions may be helpful though, I'll try to get around to it...


建议加个`@functools.wraps(f)`以保持原来函数的`__name__`不变


I agree that masking everything with a `try` block is not ideal and leaving it out would help users on tracing errors. I guess Aurri saved a few keystrokes with that.

We can absolutely simplify the shorthands if it makes `tmpl` smaller and simpler! Agree fully, even if it breaks backwards compatibility. I made a quick search for shorthand expressions on my code. These are my use cases:

- variables: `{ is_loading: is_loading, is_error: error }`
- negations: `{ current: !tab }`
- equality: `{ current: tab == 'profile' }`
- functions: `{ hidden: hasErrors() }`
- array access: `{ multiple_forums: forums[1] }`

I think we can leave out functions if necessary.

Thank you for explaining the `-c` flag for me!


If we are dropping QT3 testing on all platforms, we should also not install it in the containers to keep dependencies and image size down.


Yes, it is. I wanted to try to recover - taking advantage of the commit points should be very likely, I think. Resetting the index here doesn't provide a user with any useful experience. When he see that an index is errored, he can just reset it manually.


You can use `overlay.getLayer().getStyleFunction()` to a reference to the main style function. And you can then test that your features are styled as expected. For example you can create two overlays and you can test that features are styled differently based on the overlay they were added to.


Stufy for iOS development.


That file is missing from the repository.


The idea is that he needen't _wait_ until he sees that.
but yes, we should try reusing the index.
See if the note about lucene not closing files helps.


And good news. Tests are now passing on windows.
After: https://open.cdash.org/testDetails.php?test=352262907&build=3896854
Before: https://open.cdash.org/testDetails.php?test=352115728&build=3896042


зайві параметер в методі mailService.sendSuccessfulRegisterEmail
можна запихнути generatedPassword в newUser


このあたり、あまりコメントが役になっていないです。..:)

```
int[] road; // 通った道
```
「通った道」とコメントを追加するよりは、むしろそれは変数名に反映させて、このコメントを削った方がよいです。「通った道」程度の長さの単語なら、それは十分、変数名にできるはずです。


Yup.  My bad.


Why do this?


タブじゃないです。コンマです。:)


@ytokas. Please review


SceUID auxfile;

auxfile = sceIoOpen ....

file_ = &auxfile;


Oooh, I didn't know we had this parameter :)


Dockerfile best practices recommend to pipe downloaded tars directly into `tar`, else remember to remove the tar file after unpacking it as well.


рефактор коду
багато параметрів приймає метод mailService.sendEmail(string x3, boolean x2)????


Note that here, this is still a manual operation - a user changes the index priority. How would you like to do it automatically, without user's interaction? How to recognize that the corrupted index needs to / can be recovered?


Scanner sc 使用されていない？


I am sure is it something like

   hn = *hostname;
        if (!hostname_is_valid(hn)) {
                log_syntax(unit, LOG_ERR, filename, line, EINVAL, "hostname is not valid, ignoring assignment: %s", rvalue);

                free(hn);
                hn = NULL;
                return 0;
        }


it's new ;)
The result of one of my experiment to optimize our queries.


コメントと、関数名がマッチしていない?
適切な関数名をつければ、特にコメントはいらないです。


забыл удалить


呵呵呵


认识的发


同仁堂


still waiting on that mountforge linky....


I'll take a look at this in a little bit. Thanks for the commit :)


Should they? I wonder if entire <img> tag is needed in this case.


ok we will not do this again


Warning: code duplication detected :imp:
Time for test refactor :)


There's a TableHeader subclass, CubeTableHeader, which is only used in cube tables. For consistency's sake, it would be nice if the methods worked the same as TableCell's cssClasses/cssClassesString.


I believe it would be better to define DiscoveredCharacteristic::hasMatchingUUID(const UUID &uuid);
we should not be explicitly comparing against short or long UUIDs. Your proposed change will ignore long UUIDs completely. Would you be willing to work on DiscoveredCharacteristic::hasMatchingUUID?


@tomspilman Its ok ?


ここだけ `(int)Math.pow(2,nodes.size())` なのは、若干違和感が。
bit shift でよいと思います。


yes but it's like when we overriding the hostname which hostname we set . Should we set the dhcp hostname or the config supplied hostname  ?


fixed .


yes fixed .


Good! :)


Not sure what benefits we are getting from this one:
* if power button stays pressed all the time, the radio looks like it is not powered, but it is still using battery power and will eventually drain the battery without any warning.
* the only new feature I like is that power on is not instant, that it requires a press of at least one second. This might prevent unwanted startup. But even this is perhaps unnecessary.


Run
"bower install angular-chart.js --save"
to download chart library


This can also be expressed using a [HQL](https://docs.jboss.org/hibernate/orm/3.3/reference/en/html/queryhql.html#queryhql-aggregation) query, which is better as it is database independent. See also http://grails.github.io/grails-doc/2.4.0/ref/Domain%20Classes/executeQuery.html


I see that your construction works - but I strongly prefer naming like:
```C++
BOOST_CHECK_THROW( state->hasIntGridProperty("INVALID_DOES_NOT_EXIST") , ...)
```
in situations like this.


This was tested with node v0.12.2.
The previous regex implementation did not catch anything, the second argument thus being the offset of the match and not the entity itself.


Hello @Mathew78540 !
Without this acceptedFile line the checkExtension function in the dragController.js drop an error.


The preferred way to pass data to the views would be to retrieve the data in the controller and pass it to the view using the default mechanism. That way, views are better decoupled from the controller and services.


Quick note :
1) I'll remove the html comments inside the script tags because it's not a recommended practice (just discovered why here actually :  http://stackoverflow.com/questions/808816/are-html-comments-inside-script-tags-a-best-practice and here : http://www.javascripttoolbox.com/bestpractices/#comments)
2) I'll add a comment for us to remember we've added this for the rare users disabling js in their browsers :)
thanks


We _know_ that the index is corrupted, since we detected that already.
What we want to do now is to try to see if we can recover from that, hopefully without user intervention.

Forcing the user to do something about it would be self defeating


My bad, i will fix this. Thx :)


But how would you test that the features are styled as expected? How do you get the style for a feature?


I already have it (changed in another commit I think):
https://github.com/arekais/ravendb/blob/RavenDB-3549/Raven.Database/Indexing/Index.cs#L1928


you think it makes sense here to add a `node_saved` bool and further only do a `databag.save` if it is True?


menuda mierda


It would be better to have an ExecutionLink here, meaning that given the input "my config name" to "algorithm category" it returns "algorithm name to use". Of course there are many ways to represent that information, but I guess it would also be more consisten with the URE configuration format.


My guess this is not going to work because this line will be executed *after* the component is initialized with empty `@props.notes`.


good job!!!


:D
1) Ahah, great : I added after having seen somewhere it was a good practice : http://www.w3schools.com/tags/tag_noscript.asp (see Tips and Notes)
2) yep


если хочешь юзать Boolean, тогда называй поле, например, is_admin
или юзай https://docs.python.org/3/library/enum.html, а поел role делай Integer
потом расскажу


I agree this API would be better. But as it is now, we cannot change ABI/API.

Only the changes that add a "const" are acceptable, like you did for nfnl_queue_msg_set_timestamp() and nfnl_queue_msg_set_hwaddr().


Yes, I saw that, I reviewed this one commit at a time


w3schools.com is really not a good site !
mozilla developers or stack overflow are way more reliable


Thank you for the idea about nil and MAX_INT. It makes code more clean.

 For the case "if we only have a 16px icon, we return it even if you ask for a 32px icon", I think how about:
1. Change Site.icon to Site.icons: [Favicon]
2. Fetch all favicons for the site from DB and save it into Site.icons
3. Let the tableView(_:cellForRowAtIndexPath:) or imageView.setIcon(_:withPlaceholder) choose the fittest icon. For the later one, change its signature from setIcon(icon: Favicon?, withPlaceholder placeholder: UIImage) to setIcon(icons: [Favicon]?, withPlaceholder placeholder, UIImage) maybe add a third parameter called stratergy with a enum type such as .Fittest/.Widest and so on.


jajajaja cuando vamos hacer la conexion con la db, profe!!!!


also the w3c specifications is the ultimate source : http://www.w3.org/


Awesome, thanks!


Lol, the buffs are temporary until I can work out what effect I actually want.


I still think these should be defined inline in the files that raise them.


Yep you're right, I wasn't doubting about your choice anyway :) Just wanted to highlight how many misleading info you (me) can find on the net :D


Also, that's a teapot not a teacup!


Thanks :)


あんまり解法そのものにはコメントしないのですが、いちおう...

memo[sets][i] が state (sets, i) における最小コストを覚えているのと同じような感じで、
answer[sets][i] のようなものを用意して、 state (sets, i) におけるその最小コストを実現する次に訪れる都市の番号を覚えるようにすれば、訪れる都市の順番は、後から再現することができるはずです。


shouldn't be in this engine, see #1


right, we can have as it is.


@wesj Thank you for your advises. I have found maybe a bug and pinged you in the IRC yesterday.
For the HistoryTests in UITests, after visited the two numberedPage.html, only the icon for the first one is right in History Panel. The icon of page 2 appeared to be the default placeholder icon.


this robot haven't a gif common
/image
this is a jpeg no gif


Everything user-related should not be in here by default.


I know I am nitpicking here but you can omit the scope arg as `function` is the default.


Ah, okay, this is what I was missing I guess.


hmm ya.


@blueyed afraid not.

I'm not really familiar with vimscript and apologies if I'm telling you stuff you already know, but I notice that if I remove [this line](https://github.com/tpope/vim-fugitive/blob/master/plugin/fugitive.vim#L1707) the problem goes away.

The issue seems to be that normally the plugin figures out that it has to close one of the diff windows when I request the second diff. This seems to be the [line](https://github.com/tpope/vim-fugitive/blob/master/plugin/fugitive.vim#L1337) that does not - ie. if I comment that out, then the window does not close correctly.


I've tested your fix with a Fortinet WiFi 40C and IRC user fanhanes with a Fortinet 1500D device. It works!


yeah 99% of the web content is kind of approximative, very true in the development area
http://www.quora.com/In-what-way-is-W3Schools-com-a-good-resource-for-learning-HTML-CSS-and-other-languages


better:

```ruby
Rails.application.config.x.facebook.tap do |facebook|
  facebook.app_id     = ENV['FB_APP_ID']
  facebook.app_secret = ENV['FB_APP_SECRET']
  facebook.graph_url = 'https://graph.facebook.com/v2.3'
  facebook.redirect_uri = 'http://localhost:4200/login'
end
```


You should be able to take a Func<T, int> rather than an Expression<Func<T, int>> - this way you don't need to compile the expression and avoid the performance hit.


@zhaihj Did you find any particular performance improvements with parallelgen ?


This shouldn't be a dependency of the engine itself as it's a matte of how the host app is run/deployed.


упадет если u == None


This functionality is already implemented. I don't understand the change.
:?  is equivalent to the [\:]?
and
\d* is equivalent to [0-9]*
furthermore, the parenthesis () are missing which tells the regular expression
to score this pattern inside the .group() so I could read the value later.


all requirements should be restricted to `~<latest>` versions (allowing patch level updates)


Le'ts consider out of disk space issue. We know that the index is corrupted, but even if we try to recover then we will always fail. User's actions is necessary to recover from that. Try to do it periodically?

BTW I don't know any other reason an index can get corrupted in runtime, however I believe we can never recover then without user's intervention. My intention was to provide a way to allow users to reload an index without need to restart the entire server.


Let's consider it when we faced problems with it?
A similar situation with `createTraitNow`.


`logged_in` is maybe a bit misleading as having an associated login actually only means that the user can login not the he is actually logged in.


определитесь с отступами. или 2 или 4 пробела


I don't like this method but I don't know how to do it simplier.
"hello" ++ A = 10 - this is correct
"hello" ++ " goodbye" ++ A = 10 - this is also correct
"hello" ++ 1 + A = 10 - this is not correct, and addition would also report it. And 1 + A will be reported twice.
So this code is checking whole ListOpExpression recursively and then, if it is not correct for any reasons, it clears history of reports and add only one big report on whole ListOpExpression.


These should be required by bundler already.


On 7/10/15 1:22 PM, Raphael Pierzina wrote:
> I know I am nitpicking here but you can omit the scope arg as |function|
> is the default.

I will fix this now. Since this is the first time I am writing tests
using py.test, I tried to be careful by mimicking one of the existing
tests :)


Check it please.


This value is a number, right? Better be a NumberNode then.


Please explain why you do that in the commit message


I think the casts to int here should be unnecessary.


There are some issues with "not to play with session data in requests that are likely to be simultaneous" - Laravel itself is rewriting some session data (presumably, last request time to use for sliding session expiration window) on every request. So, I still experience lost sessions for some simultanous AJAX requests even if I don't modify any session variable explicitly (on Laravel 5).


Should be removed as bundler should handle all requiring anyway.


GG::Wnd already provides means to set a window name/identifier, so please drop this attribute. It can be set with `SetName` and accessed with `Name`.


Yep, better be a NumberNode.


Actually I'd rather take the bleeding edge so I can track any new features.


Seems that __noreturn__ would be preferred:
https://stackoverflow.com/questions/28552467/is-there-a-way-to-use-gcc-attribute-noreturn-and-stdnoreturn-h-sanely-i
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53182

Also, __attribute__((noreturn)) only works for clang and gcc. I think we need to define the attribute only conditionally. For that we could define a macro _NL_NORETURN, similar to how glib does:
https://git.gnome.org/browse/glib/tree/glib/gmacros.h?id=27fae8390946e73e8343a7fd7505796f3599ee23#n87


Yeah, as you noted above it came down to that missing `this.notes = [];`.


Note that NumberNode can represent floats as well.


This shouldn't be part of the engine - should be up to the host app to decide what a forbidden request is anyway.


Okay, in that case, we'll need another error mode (Failed), and we will throw an error indicating that we need user action, and the studio should give a big button on "recover failed indexes" after the issue is fixed.


I'm so sorry about w3schools :/ I think I have some problem lately.. I'm too much sensitive to the the misfortunes of others. :)


Nitpick: This refactoring would make a great separate commit ;)


can we use http://api.rubyonrails.org/classes/ActionController/HttpAuthentication/Token/ControllerMethods.html#method-i-authenticate_or_request_with_http_token here?


We already check when to save the databag: that's whenever there's a _remove role. That's because when that happens, we do the `databag[...].delete()` call a few lines above unconditionally, which means we'll have to save the database.


The fuel indicators now block something!
![asdasd](https://cloud.githubusercontent.com/assets/13047748/8614390/c6aaf27c-271b-11e5-9a41-46fd28de7f26.jpg)


Yes, I had this change sitting in my code for quite a while and didn't notice that you 've already implemented it.
Feel free to ignore this PR then :)

Yiannis.


OK, does not change much though :)


I think enabling interaction for hidden layers is not ok, I'd go with the alternative. Why do you think is scary?


:+1:
Is it time for TypeScript to consider a broad compatibility as an explicit goal (rather than a nice-to-have driven by disjointed sporadic community efforts) — all things like host, ES version, strict mode?


Anyway it continues polluting object -- we'll see `$metadata$` when use `Object.getOwnPropertyNames`

What do you think about just overwrite `constructor.$metadata$.type`?


V 1.0


3000 でいいんじゃね？


Why do you differenciate between windowed and fullscreen mode?

It does not matter, unless you want to indicate that you want to store different window positions for every possible screen resolution, which is just unfeasible. If the user changes the screen resolution invalidate the stored attributes and let the layout take over.


i just thought if there was some error in `NodeObject.save`, it would still be on the runlist.


haha, okay. I'll try not to rename it again :)


This isn't goind to work - we need to keep the existing behaviour of being able to pass in a Regex instance and use that same instance all the way through. A better option would be to store the existing regex inside the regexFunc:
```
this.regexFunc = x => regex;
```


0, 2560? Way to small for big resolutions screens or multi-screen setups.


> Apparently clock interrupts can now occur in all kinds of weird places?
Indeed they can, as we can come out of bmk_cpu_block() before the clock interrupt fires. I had a hunch there was something wrong with the interrupt handling, but didn't have the energy to figure it out yesterday. Thanks for fixing this!


I think we don't need another error mode. The current we already have is ok - if the index priority is `Error` then we will provide an option "try to recover failed index". If the index won't be corrupted, then the operation will not have any additional effect - it will just reload it and won't attempt to recover or reset.


Why do you save on `Hide` and on `Show`?


:joy:  NICE!!!


あまり、コメントするところがないので、ここだけ:

```python
for i in range(N):
    total += dist[solution[i]][solution[(i + 1) % N]]
```
のほうが、ミスしにくい気がします。 (N == len(solutions))
一行で書くなら、
```python
       sum(dist[solution[i][solution[(i + 1) % N] for i in range(N))
```


Where do those numbers come from?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 126](https://teamcity.labkey.org/viewLog.html?buildId=260200&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 1 Build time: 00:03:09
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.initializationError: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


Indentations need to use tabs instead of spaces (same for other files too)


yeah! ;)


@kalashnikovisme зацени, здесь http://railscasts.com/episodes/154-polymorphic-association в comments/index.html.erb  record_type и record_id автогенерятся походу


It seems that you forgot to remove this one :)


The folks seems to be opposed to this style of comments in general.
But check with @danquirk , he's doing tslint.


ah ah no problem! :)
I went a few times on w3shools also (they're almost always the #1 result on Google! ) but I've discovered better since then


docker-machine create --help


Oke, well if you can update the logic to handle an array and create a pull request I will be more that happy to merge your request.


Perfect.


@kalashnikovisme а зачем тебе record_type как enumerize?


pourquoi t'as fait ça et pas simplement déréférencé la page ? car du coup, quand je vais faire mon rebase sur la branche speakers, je vais perdre les modifs :(


The commit message was funny, but eh, I'm sure you did that to make sure I was following. ;)


This is temporary until I put something like Lucene in - but yeah, ouch!


Ahah,
must be because w3schools has an H1 in the front page, or it has the author, date and so on. :P


Why do this?


Seems you used a '#' here instead of a '*'


Yes sir it is! I want to move it to

public abstract object Data {get;set;}

And push the responsibility to the IContentStore.


Unless I am wrong, I added `-DWITH_CGAL_Qt3:BOOL=OFF` only in the container that do not have Qt3 installed.


Thanks @madhuracj for fixing this.
I could not look into it earlier. But now realized that, you already have fixed this.


typo: Manages error codes.


(N-1, 0) を特別扱いしたくないなら、
```python
for i in range(N):
  total += dist[solution[i]][solution[(i + 1) % N]
```
なども可能です (N: len(solution))。ミスを防ぐためにわりとよく使われるテクニックのひとつです。
一行で書くなら
```python
  total = sum(dist[solution[i]][solution[(i + 1) % N] for i in range(N))
```


Error can happen because the index itself is erroring. For example, the index has a divide by zero for some documents, and errors because of that.


Hi F!
If it can be useful, here i added a dependency for this setting, so the switch it's unavailable when slim recents are enabled: https://review.slimroms.eu/#/c/3196/

Bye mate!


Also, we need this to be for _all_ failing indexes, not for each one.


Hello Word


dd


at least this one is incompatible in units and requires *100


Ah, I see. The thing is, if `NodeObject.save` can fail, then crowbar will explode in other ways that are much more visible :-)


@ProfYaffle
Should be programme, not programmes. I fixed this in another commit.


I wonder if this means that the overall message will contain double square brackets somewhere like "[[bar]]" , see toString method of Index class.


Note that the functions in above patch should have a dummy empty implementation and not pure virtual. This is to avoid having to maintain a patch with changes to other ozone in tree implementations. I will update that patch tomorrow.


> On 09 Jul 2015, at 18:39, Hans Fast <notifications@github.com> wrote:
>
> :bitingnails:

we still have no VPS..

i’ll see what i can do!


that was actually intentional: mixing up integer and double grid properties is probably quite common and the implementation of has*GridProperty()` could (in theory) not distinguish between these two kinds of properties. I'm open to renaming, if you still want it, though.


Hmm thanks for the explanation. I will get back to u on this.


このファイルに限らず、全体的に（他のSteppers と比較して）、キレイにかけていてとてもよいと思います。

若干、細かいスタイルのミスがあるくらい？ スタイルチェッカーなどを普段から使用するようにしておくと、よいと思います。

あと、Python だとやはりここは2行にわけて書いたほうがよいです。
```python
if i==len(solution):
    path=solution[i:0]
```
else も同様。


I am not sure about this, I think the expression with wildcards should get returned untouched instead, not filtered out. What made you make this change though?


Can we create WaylandDataOffer in OnEnter ? instead of here.


is this supposed to throw an error or not? it seems like it would work either way now, cause we have the catch and no fail() after the call.


CentOS-7 has qt3-devel, and CentOS-5 has qt-devel those should both be Qt3. I suspect that it is simply the find file failing unless QTDIR etc. are set. See the Fedora image.


this code is bad and you should feel bad


can we rename all the loop variables too? :)


@SubJunk you too mate, pleasure is mine :)


Are you sure it's not used for anything else?


cool. Will try later


#500 commit :dancers: :lollipop: :D


Oops. Fixed in cc29800.


It does matter, since the majority of people will select a single fullscreen resolution and stick with it, and the fullscreen resolution is usually much larger than the windowed one.  There is no "layout" for these CUIWnds, so when the user switches from the fullscreen mode to windowed mode (or starts the game in windowed mode) all of the windows would be squashed together in a haphazard layout.


Those are the defaults from app-width and app-width-windowed.  You can change those all at once if you like.


Both shouldn't required anymore (present in `PaymentInternalEvent`).


Forgive my ignorance, but is this line (53: `alias rm="${aliases[rm]:-rm} -i"`) what's creating the alias `rm -i`? I don't understand why rm should default to interactive mode with prezto. Am I just misreading?


Because I plan to have these windows remember if they were hidden when you restart the game.  It's on the todo list.  I know I at least always open the sitrep window and close the messages & empire windows whenever I load a game and I'd rather not have to do that every single time I start the application.


ちなみに、Python だと itertools.permutations が今回の総当りの目的では使えたりします。

https://docs.python.org/3/library/itertools.html#itertools.permutations

この他にも、itertools にはなにかと便利なものがそろってたりするので、目を通しておくとよいかもしれません。


This is the only place in the code where index priority is set to `Error`:
https://github.com/arekais/ravendb/blob/RavenDB-3549/Raven.Database/Indexing/Index.cs#L1917

Errors like divide by zero etc are counted and then failureRate is used to determine if index is invalid (invalid index isn't the same as Errored, however in the studio both values are used to indicate that an index has errors)

To be more precise: I meant that we don't need to add another IndexingPriority.Failed, just apply "try recover failed indexes" operation for all ones which have priority IndexingPriority.Error


Well, when I write "backwards compatible" just mean that I *think* it's backwards compatible. If you give me the content of how you run luigi. I might be able to fix this for you. Thanks for reporting this @tym-oao! :)


Please add these in common/data/packages_extra.json file if they are not going to be installed by default, but available in CD.


I agree. I forgot to remove the tarball itself. Fixed in 3094fc9.

I want to verify the downloaded tarball. I did not want to trust a tarball downloaded from an unsecured web site. That is why I use `md5sum` to verify the MD5 sum. It seems that `sha256sum` is distributed with `centos:centos5`. I should switch to that better cryptographic hash.


Looks like we do conceptually the same thing in setup and here, with different mocked methods.
My idea for that would be:
* resign from having a file-wide $this->infoboxRenderService
* each test uses getInfoboxRenderService instead
* getInfoboxRenderService accepts a map of configuration values, i.e.
```
getInfoboxRenderService(
'isWikiaMobile' => false,
'getThumbnail' => false
)
```
and extract getMockThumbnailImage the same way. There's a lot of mocking in those tests as we touch core very deeply, so let's make the test body as explicit and simple as possible.

What do you think?


They are the default for most of the top-level CUIWnds on the map screen (see SITREP_PANEL_HEIGHT and _WIDTH in MapWnd.cpp, similar ones were used for CombatReportWnd).  I plan to move these to constants somewhere else where they are more accessible but I need to decide exactly where.


remove superfluous cat


Hmm, the problem I have with this is that it is an Ubuntu-specific bug that we are now solving by adding a global dependency. A simple platform.system() == "Linux" check would at least reduce it to "just" Linux but for Fedora or Arch users that would still introduce an additional dependency. Ideally this would just be fixed upstream, but until it is I would be fine with introducing this workaround as long as it is limited to Ubuntu/Debian based systems.


Shouldn't this be:

```
$directories = $this->app['files']->directories(config('stylist.themes.paths', base_path() . '/Themes'])[0);
```

?


N == f になったタイミングで、path_length を計算していますが、毎回、全部を計算するのではなくて、ここまでの path の長さを計算しつつ、df_sub に渡してあげるようにすると、若干、無駄がはぶけます。

```python
df_sub(f, path, path_length_so_far):
   ....
   ....
   df_sub(f + 1, path, path_length_so_far + dist[current][x])
```
のような感じ？


At this moment, Google Maps V2 can render maps offline, caching previously the necessary tiles.
(March 2013)Resolved Issues:    Maps can now be rendered offline (Issue 5017)
       Issue5017 : https://code.google.com/p/gmaps-api-issues/issues/detail?id=5017
Workaround for rendering local tiles: https://speakerdeck.com/toidiu/offline-maps


Use markdown to style this document: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet


Okay
On Jul 10, 2015 11:33 AM, "Arkadiusz Paliński" <notifications@github.com>
wrote:

> This is the only place in the code where index priority is set to Error:
>
> https://github.com/arekais/ravendb/blob/RavenDB-3549/Raven.Database/Indexing/Index.cs#L1917
>
> Errors like divide by zero etc are counted and then failureRate is used to
> determine if index is invalid (invalid index isn't the same as Errored,
> however in the studio both values are used to indicate that an index has
> errors)
>
> To be more precise: I meant that we don't need to add another
> IndexingPriority.Failed, just apply "try recover failed indexes" operation
> for all ones which have priority IndexingPriority.Error
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/arekais/ravendb/commit/b99f2454a355ab93e1aad428a9552d6299fab691#commitcomment-12101191>
> .
>


pull request


Is it worth still extending `CompletionTaskBase`? Do we still share some code?


Please pay attention to your commit messages when rebasing. Conflict markers should be removed accordingly. Moreover always test your "last changes before commiting", even changing an xml_id can break the runbot.


This fixes #1171.


Also, thank you very much for using luigi HEAD. I'll make sure we don't release luigi to pypi before this is fixed. :)


全体的にとてもキレイでよみやすかったです。ありがとうございます。 :+1:


To be discussed but I would be more aggressive during the first day, especially for HPPs, so the order for the customer can be fulfilled ASAP.


what CF release the fix has been planned for?

thx


Can this be inverted? What if this is not true? Try getting rid of the nested ifs unless it makes the code less readable.


ok


Looking at the call stack, I don't think `IOException` is still thrown.

Otherwise, it would be nice to push down the handling of such exceptions as low as possible, because at this point here, it's a bit unclear what to do (should we re-throw to try to process the event later?).


just making the point, if you batch-process variables like this, it helps readability and reviewability if they stay in order:

```c++
  FILE* certFilePtr = fopen(certFile.c_str(), "w");
  FILE* keyPairFilePtr = fopen(keyPairFile.c_str(), "w");
  FILE* p12FilePtr = fopen(p12File.c_str(), "wb");

  PEM_write_X509(certFilePtr, m_x509);
  PEM_write_PrivateKey(keyPairFilePtr, m_pkey, NULL, NULL, 0, NULL, NULL);
  i2d_PKCS12_fp(p12FilePtr, m_p12);

  fclose(certFilePtr);
  fclose(keyPairFilePtr);
  fclose(p12FilePtr);
```


There are no additional changes for plugins ee-7.0.x


@ytokas
PLEASE REVIEW


Why are you using "exit 1" instead of "die".


Detta virket som noe artige saker! :100:


yesss
On Fri, Jul 10, 2015 at 00:50 Adam Pearce <notifications@github.com> wrote:

> homepage zoom scaling, thx @tophtucker
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/1wheel/roadtolarissa/commit/ed9b77e225ab329720ee5a446ad7f02f55bb42f5
>


Ah. Ok. Could you ask them to add the url to sessions on web also? Would be great for sharing.

Vennlig hilsen
Webstep AS

Ronnie Nessa | Seniorkonsulent
Tlf: +47 970 69 512 | ronnie.nessa@webstep.no

> Den 10. jul. 2015 kl. 07.11 skrev Chris Searle <notifications@github.com>:
>
> Yes - I asked them to replace it since this broke the app for the current active users.
>
> —
> Reply to this email directly or view it on GitHub.
>


Why is the default `on`? IMO it should do nothing if not configured -> also in the configuration it should be possible to configure "do not touch numlock state"


It is unsuitable test. Because `Groonga::Flushable#flush`'s return value is explicitly undefined.


don't we need it hardcoded here while it's not configurable?