1: D400 First line should end with a period (not 'd')
1: D205 1 blank line required between summary line and description (found 0)
35:1: E402 module level import not at top of file
36:1: E402 module level import not at top of file
37:1: F401 'urlparse' imported but unused
37:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. import socket should be before import urlparse
38:1: F401 'socket' imported but unused
38:1: E402 module level import not at top of file
39:1: I100 Imports statements are in the wrong order. import smtplib should be before import socket
39:1: F401 'smtplib' imported but unused
39:1: E402 module level import not at top of file
40:1: I100 Imports statements are in the wrong order. import re should be before import smtplib
40:1: E402 module level import not at top of file
41:1: I100 Imports statements are in the wrong order. import random should be before import re
41:1: F401 'random' imported but unused
41:1: E402 module level import not at top of file
42:1: I100 Imports statements are in the wrong order. import datetime should be before import random
42:1: E402 module level import not at top of file
44:1: F401 'Request' imported but unused
44:1: E402 module level import not at top of file
45:1: I201 Missing newline before sections or imports.
45:1: F401 'iteritems' imported but unused
45:1: E402 module level import not at top of file
46:1: I100 Imports statements are in the wrong order. from socket should be before from six
46:1: I201 Missing newline before sections or imports.
46:1: F401 'gaierror' imported but unused
46:1: E402 module level import not at top of file
47:1: I100 Imports statements are in the wrong order. import os should be before from socket
47:1: E402 module level import not at top of file
48:1: I100 Imports statements are in the wrong order. import binascii should be before import os
48:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
51:1: E402 module level import not at top of file
52:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_ACCESS_CONTROL_LEVEL_GUESTS, CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_ACCESS_CONTROL_LIMIT_REGISTRATION_TO_DOMAIN, CFG_ACCESS_CONTROL_NOTIFY_ADMIN_ABOUT_NEW_ACCOUNTS, CFG_ACCESS_CONTROL_NOTIFY_USER_ABOUT_NEW_ACCOUNT, CFG_BIBAUTHORID_ENABLED, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_SITE_ADMIN_EMAIL, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_NAME_INTL, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_SUPPORT_EMAIL, CFG_SITE_URL, CFG_WEBSESSION_ADDRESS_ACTIVATION_EXPIRE_IN_DAYS
52:1: F401 'CFG_WEBSESSION_ADDRESS_ACTIVATION_EXPIRE_IN_DAYS' imported but unused
52:1: F401 'CFG_SITE_NAME_INTL' imported but unused
52:1: F401 'CFG_SITE_RECORD' imported but unused
52:1: F401 'CFG_BIBAUTHORID_ENABLED' imported but unused
52:1: F401 'CFG_INSPIRE_SITE' imported but unused
52:1: F401 'CFG_SITE_SECURE_URL' imported but unused
52:1: E402 module level import not at top of file
53:6: E126 continuation line over-indented for hanging indent
76:1: E402 module level import not at top of file
77:1: E402 module level import not at top of file
80:1: I101 Imported names are in the wrong order. Should be gettext_set_language, wash_language, wash_languages
80:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.serializers
80:1: F401 'wash_language' imported but unused
80:1: F401 'wash_languages' imported but unused
80:1: E402 module level import not at top of file
81:1: E402 module level import not at top of file
82:1: E402 module level import not at top of file
83:1: E402 module level import not at top of file
84:1: I201 Missing newline before sections or imports.
84:1: E402 module level import not at top of file
86:1: E402 module level import not at top of file
97:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from sqlalchemy.exc
97:1: E402 module level import not at top of file
110:1: E302 expected 2 blank lines, found 1
110: D400 First line should end with a period (not 's')
110: D208 Docstring is over-indented
126:1: E302 expected 2 blank lines, found 1
126: D202 No blank lines allowed after function docstring (found 1)
173:5: E303 too many blank lines (2)
189:1: E302 expected 2 blank lines, found 1
189: D205 1 blank line required between summary line and description (found 0)
189: D208 Docstring is over-indented
205:42: E701 multiple statements on one line (colon)
206:42: E701 multiple statements on one line (colon)
213:22: E261 at least two spaces before inline comment
243:1: I100 Imports statements are in the wrong order. from invenio.ext.login should be before from invenio.modules.access.local_config
243:1: E402 module level import not at top of file
244:1: F999 redefinition of unused 'getUid' from line 189
244:1: E731 do not assign a lambda expression, use a def
247: D200 One-line docstring should fit on one line with quotes (found 2)
256:1: E302 expected 2 blank lines, found 1
256: D200 One-line docstring should fit on one line with quotes (found 3)
262:1: E302 expected 2 blank lines, found 1
262: D200 One-line docstring should fit on one line with quotes (found 3)
268:1: E302 expected 2 blank lines, found 1
268:40: E251 unexpected spaces around keyword / parameter equals
268:42: E251 unexpected spaces around keyword / parameter equals
268: D205 1 blank line required between summary line and description (found 0)
275:1: E302 expected 2 blank lines, found 1
275: D200 One-line docstring should fit on one line with quotes (found 3)
281:1: E302 expected 2 blank lines, found 1
289:1: E302 expected 2 blank lines, found 1
289: D205 1 blank line required between summary line and description (found 0)
310:1: E302 expected 2 blank lines, found 1
310: D209 Multi-line docstring closing quotes should be on a separate line
310: D205 1 blank line required between summary line and description (found 0)
323:1: E302 expected 2 blank lines, found 1
323: D400 First line should end with a period (not 't')
323: D208 Docstring is over-indented
339:1: E302 expected 2 blank lines, found 1
345:1: E302 expected 2 blank lines, found 1
355:1: E302 expected 2 blank lines, found 1
360:1: E302 expected 2 blank lines, found 1
368:1: E302 expected 2 blank lines, found 1
368: D205 1 blank line required between summary line and description (found 0)
368: D208 Docstring is over-indented
383:1: E302 expected 2 blank lines, found 1
383: D205 1 blank line required between summary line and description (found 0)
383: D208 Docstring is over-indented
398:1: E302 expected 2 blank lines, found 1
398: D209 Multi-line docstring closing quotes should be on a separate line
398: D400 First line should end with a period (not 'e')
398: D205 1 blank line required between summary line and description (found 0)
417: D202 No blank lines allowed after function docstring (found 1)
417: D400 First line should end with a period (not 'd')
417: D205 1 blank line required between summary line and description (found 0)
417: D208 Docstring is over-indented
418:9: E128 continuation line under-indented for visual indent
443:5: F841 local variable '_' is assigned to but never used
462:18: E261 at least two spaces before inline comment
464:74: E261 at least two spaces before inline comment
468:26: E261 at least two spaces before inline comment
470:26: E261 at least two spaces before inline comment
473:5: E303 too many blank lines (2)
490:23: E261 at least two spaces before inline comment
491:21: F821 undefined name 'uid'
494:1: E302 expected 2 blank lines, found 1
494: D400 First line should end with a period (not 'd')
494: D205 1 blank line required between summary line and description (found 0)
511:1: E302 expected 2 blank lines, found 1
521: D202 No blank lines allowed after function docstring (found 1)
521: D400 First line should end with a period (not 'r')
521: D205 1 blank line required between summary line and description (found 0)
537:1: E302 expected 2 blank lines, found 1
537: D202 No blank lines allowed after function docstring (found 1)
537: D400 First line should end with a period (not '1')
537: D200 One-line docstring should fit on one line with quotes (found 2)
549: D205 1 blank line required between summary line and description (found 0)
559:1: E302 expected 2 blank lines, found 1
573:1: E302 expected 2 blank lines, found 1
573: D209 Multi-line docstring closing quotes should be on a separate line
573: D400 First line should end with a period (not 'e')
573: D205 1 blank line required between summary line and description (found 0)
582:1: E302 expected 2 blank lines, found 1
582: D205 1 blank line required between summary line and description (found 0)
592:11: E127 continuation line over-indented for visual indent
597:1: E302 expected 2 blank lines, found 1
597: D209 Multi-line docstring closing quotes should be on a separate line
597: D400 First line should end with a period (not 'e')
597: D205 1 blank line required between summary line and description (found 0)
606:1: E302 expected 2 blank lines, found 1
606: D209 Multi-line docstring closing quotes should be on a separate line
606: D205 1 blank line required between summary line and description (found 0)
629:1: E302 expected 2 blank lines, found 1
629: D400 First line should end with a period (not ')')
629: D205 1 blank line required between summary line and description (found 0)
643:1: E302 expected 2 blank lines, found 1
643: D400 First line should end with a period (not ')')
643: D205 1 blank line required between summary line and description (found 0)
667:1: E302 expected 2 blank lines, found 1
667: D103 Missing docstring in public function
672:42: E261 at least two spaces before inline comment
674:1: E302 expected 2 blank lines, found 1
674: D103 Missing docstring in public function
680: D400 First line should end with a period (not 'y')
680: D205 1 blank line required between summary line and description (found 0)
717: D202 No blank lines allowed after function docstring (found 1)
740: D202 No blank lines allowed after function docstring (found 1)


The problem is that `Base.Random.GLOBAL_RNG` only exists on julia 0.4-dev, not any 0.3.x release.

I'm finding the alternative right now, should just take a couple minutes.


29:1: E402 module level import not at top of file
31:1: E402 module level import not at top of file
33:1: E402 module level import not at top of file
34:1: E402 module level import not at top of file
43:1: E402 module level import not at top of file
44:1: E402 module level import not at top of file
46:1: E402 module level import not at top of file
47:1: E402 module level import not at top of file
48:1: E402 module level import not at top of file
51:1: E402 module level import not at top of file
52:1: E402 module level import not at top of file
53:1: E402 module level import not at top of file
54:1: E402 module level import not at top of file
55:1: E402 module level import not at top of file
59:1: E402 module level import not at top of file
61:1: E402 module level import not at top of file
146: D210 No whitespaces allowed surrounding docstring text
398: D210 No whitespaces allowed surrounding docstring text


32:1: I100 Imports statements are in the wrong order. from invenio.utils.hash should be before from invenio_accounts.models
32:1: I201 Missing newline before sections or imports.
34:1: I100 Imports statements are in the wrong order. from random should be before from invenio.utils.hash


34:1: I201 Missing newline before sections or imports.


1: D200 One-line docstring should fit on one line with quotes (found 3)
24:1: F401 'cached_property' imported but unused
25:1: I100 Imports statements are in the wrong order. from six.moves.urllib.parse should be before from werkzeug
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
29:1: I100 Imports statements are in the wrong order. import hmac should be before from sqlalchemy.orm.exc
31:1: I100 Imports statements are in the wrong order. import re should be before import time
38: D103 Missing docstring in public function
40:1: I101 Imported names are in the wrong order. Should be basejoin, urlencode
44:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from invenio.utils.hash
58: D203 1 blank line required before class docstring (found 0)
58: D204 1 blank line required after class docstring (found 0)
79: D401 First line should be in imperative mood ('Create', not 'Creates')
79: D400 First line should end with a period (not 't')
79: D205 1 blank line required between summary line and description (found 0)
102: D401 First line should be in imperative mood ('Make', not 'Makes')
102: D400 First line should end with a period (not 's')
124: D400 First line should end with a period (not 's')
124: D205 1 blank line required between summary line and description (found 0)
138: D202 No blank lines allowed after function docstring (found 1)
138: D400 First line should end with a period (not 'e')
138: D205 1 blank line required between summary line and description (found 0)
163: D102 Missing docstring in public method
171: D401 First line should be in imperative mood ('Look', not 'Looks')
171: D202 No blank lines allowed after function docstring (found 1)
171: D400 First line should end with a period (not 'e')
171: D205 1 blank line required between summary line and description (found 0)
203:9: F841 local variable 'path' is assigned to but never used
255: D202 No blank lines allowed after function docstring (found 1)
255: D205 1 blank line required between summary line and description (found 0)


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.orm.exc
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio_records.api should be before from invenio_records.models


4: L102 copyright year is outdated, expected 2015 but got 2014
34:1: I201 Missing newline before sections or imports.
35:1: I100 Imports statements are in the wrong order. from invenio.modules.cloudconnector.errors should be before from invenio_accounts.models
35:1: I201 Missing newline before sections or imports.
73:17: B901 blind except: statement
83:13: B901 blind except: statement


4: L102 copyright year is outdated, expected 2015 but got 2014


1: D200 One-line docstring should fit on one line with quotes (found 3)
4: L102 copyright year is outdated, expected 2015 but got 2013
25:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from werkzeug.utils
26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. from invenio.ext.login should be before from invenio_accounts.models
27:1: I201 Missing newline before sections or imports.
27:1: F401 'login_user' imported but unused
27:1: F401 'logout_user' imported but unused
30: D203 1 blank line required before class docstring (found 0)
30: D204 1 blank line required after class docstring (found 0)
39: D200 One-line docstring should fit on one line with quotes (found 3)
45: D401 First line should be in imperative mood ('Load', not 'Loads')
53: D401 First line should be in imperative mood ('Store', not 'Stores')
63: D200 One-line docstring should fit on one line with quotes (found 3)
70: D203 1 blank line required before class docstring (found 0)
70: D204 1 blank line required after class docstring (found 0)
70: D200 One-line docstring should fit on one line with quotes (found 3)
74: D102 Missing docstring in public method
83: D102 Missing docstring in public method
100: D102 Missing docstring in public method
105: D200 One-line docstring should fit on one line with quotes (found 3)
126:19: E231 missing whitespace after ','
134: D203 1 blank line required before class docstring (found 0)
134: D204 1 blank line required after class docstring (found 0)
134: D200 One-line docstring should fit on one line with quotes (found 3)
138:14: E261 at least two spaces before inline comment
138:15: E262 inline comment should start with '# '
139:30: E261 at least two spaces before inline comment
139:31: E262 inline comment should start with '# '
140:24: E261 at least two spaces before inline comment
140:25: E262 inline comment should start with '# '
142: D102 Missing docstring in public method
143:9: E266 too many leading '#' for block comment
147: D102 Missing docstring in public method
150: D401 First line should be in imperative mood ('Load', not 'Loads')
150: D200 One-line docstring should fit on one line with quotes (found 3)
156: D401 First line should be in imperative mood ('Store', not 'Stores')
156: D200 One-line docstring should fit on one line with quotes (found 3)
162: D200 One-line docstring should fit on one line with quotes (found 3)
168: D102 Missing docstring in public method


1: D200 One-line docstring should fit on one line with quotes (found 3)
4: L102 copyright year is outdated, expected 2015 but got 2012
31:1: E302 expected 2 blank lines, found 1
31: D203 1 blank line required before class docstring (found 0)
31: D204 1 blank line required after class docstring (found 0)
35:17: E128 continuation line under-indented for visual indent
37:17: E128 continuation line under-indented for visual indent
39:17: E128 continuation line under-indented for visual indent
41:17: E128 continuation line under-indented for visual indent
43:17: E128 continuation line under-indented for visual indent
45:17: E128 continuation line under-indented for visual indent
50:1: E302 expected 2 blank lines, found 1
50: D203 1 blank line required before class docstring (found 0)
50: D204 1 blank line required after class docstring (found 0)
54:17: E128 continuation line under-indented for visual indent
55:17: E128 continuation line under-indented for visual indent
57:17: E128 continuation line under-indented for visual indent
58:17: E128 continuation line under-indented for visual indent
60:1: E302 expected 2 blank lines, found 1
60: D203 1 blank line required before class docstring (found 0)
60: D204 1 blank line required after class docstring (found 0)
64:17: E128 continuation line under-indented for visual indent
65:17: E128 continuation line under-indented for visual indent
67:17: E128 continuation line under-indented for visual indent
68:17: E128 continuation line under-indented for visual indent
70:17: E128 continuation line under-indented for visual indent
72:17: E128 continuation line under-indented for visual indent
76:1: E302 expected 2 blank lines, found 1
76: D203 1 blank line required before class docstring (found 0)
76: D204 1 blank line required after class docstring (found 0)
80:17: E128 continuation line under-indented for visual indent
86:17: E128 continuation line under-indented for visual indent
88:1: E302 expected 2 blank lines, found 1
88: D203 1 blank line required before class docstring (found 0)
88: D204 1 blank line required after class docstring (found 0)
92:21: E128 continuation line under-indented for visual indent
93:21: E128 continuation line under-indented for visual indent
95:21: E128 continuation line under-indented for visual indent
96:21: E128 continuation line under-indented for visual indent
101:1: E302 expected 2 blank lines, found 1
101: D203 1 blank line required before class docstring (found 0)
101: D204 1 blank line required after class docstring (found 0)
105:17: E128 continuation line under-indented for visual indent
106:17: E128 continuation line under-indented for visual indent
108:17: E128 continuation line under-indented for visual indent
109:17: E128 continuation line under-indented for visual indent
112:17: E128 continuation line under-indented for visual indent
119:1: E302 expected 2 blank lines, found 1
119: D203 1 blank line required before class docstring (found 0)
119: D204 1 blank line required after class docstring (found 0)
123:13: E128 continuation line under-indented for visual indent
124:13: E126 continuation line over-indented for hanging indent
126:13: E128 continuation line under-indented for visual indent
127:13: E126 continuation line over-indented for hanging indent
131:1: E303 too many blank lines (3)


27:1: I201 Missing newline before sections or imports.
28:1: I100 Imports statements are in the wrong order. from invenio.modules.messages.config should be before from invenio_accounts.models
28:1: I201 Missing newline before sections or imports.
37:1: I100 Imports statements are in the wrong order. from invenio_groups.models should be before from wtforms


1: D200 One-line docstring should fit on one line with quotes (found 3)
4: L102 copyright year is outdated, expected 2015 but got 2012
29:1: I100 Imports statements are in the wrong order. from string should be before from invenio.ext.sqlalchemy
30:1: I201 Missing newline before sections or imports.
31:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from invenio_groups.models should be before from sqlalchemy.ext.associationproxy
36: D203 1 blank line required before class docstring (found 0)
36: D204 1 blank line required after class docstring (found 0)
38: D102 Missing docstring in public method
40:41: F821 undefined name '_'
41:37: F821 undefined name '_'
41:13: E128 continuation line under-indented for visual indent
42:13: E128 continuation line under-indented for visual indent
45:17: E128 continuation line under-indented for visual indent
46:17: E128 continuation line under-indented for visual indent
48:17: E128 continuation line under-indented for visual indent
49:17: E128 continuation line under-indented for visual indent
51:17: E128 continuation line under-indented for visual indent
53:17: E128 continuation line under-indented for visual indent
57:9: E128 continuation line under-indented for visual indent
57:46: E261 at least two spaces before inline comment
59:9: E128 continuation line under-indented for visual indent
66:13: E128 continuation line under-indented for visual indent
66:29: E231 missing whitespace after ':'
69: D210 No whitespaces allowed surrounding docstring text
69: D401 First line should be in imperative mood ('Alia', not 'Alias')
74: D210 No whitespaces allowed surrounding docstring text
74: D401 First line should be in imperative mood ('Alia', not 'Alias')
79: D102 Missing docstring in public method
81:13: E128 continuation line under-indented for visual indent
89: D102 Missing docstring in public method
91:13: E128 continuation line under-indented for visual indent
99:5: E303 too many blank lines (2)
100: D102 Missing docstring in public method
106:65: E502 the backslash is redundant between brackets
107:17: E128 continuation line under-indented for visual indent
108:17: E122 continuation line missing indentation or outdented
108:51: E502 the backslash is redundant between brackets
111:13: E731 do not assign a lambda expression, use a def
116:54: E502 the backslash is redundant between brackets
117:17: E128 continuation line under-indented for visual indent
117:5: E129 visually indented line with same indent as next logical line
122: D102 Missing docstring in public method
128:58: E502 the backslash is redundant between brackets
129:17: E128 continuation line under-indented for visual indent
130:17: E122 continuation line missing indentation or outdented
130:48: E502 the backslash is redundant between brackets
132:13: E731 do not assign a lambda expression, use a def
139:5: E129 visually indented line with same indent as next logical line
144: D102 Missing docstring in public method
148:13: E128 continuation line under-indented for visual indent
151: D102 Missing docstring in public method
155:13: E128 continuation line under-indented for visual indent
160:1: I100 Imports statements are in the wrong order. from invenio.modules.messages.config should be before from invenio_groups.models
160:1: F401 'CFG_WEBMESSAGE_EMAIL_ALERT' imported but unused
160:1: E402 module level import not at top of file
161:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.modules.messages.config
161:1: F401 'CFG_WEBCOMMENT_ALERT_ENGINE_EMAIL' imported but unused
161:1: E402 module level import not at top of file
162:1: E402 module level import not at top of file
163:1: I100 Imports statements are in the wrong order. from datetime should be before from invenio.utils.date
163:1: I201 Missing newline before sections or imports.
163:1: E402 module level import not at top of file
165:1: E302 expected 2 blank lines, found 1
165: D210 No whitespaces allowed surrounding docstring text
165: D401 First line should be in imperative mood ('Send', not 'Sends')
170:18: E222 multiple spaces after operator
171:20: E127 continuation line over-indented for visual indent
175:9: E731 do not assign a lambda expression, use a def
176:21: E128 continuation line under-indented for visual indent
178:21: E126 continuation line over-indented for hanging indent
182:5: E125 continuation line with same indent as next logical line
187:28: E251 unexpected spaces around keyword / parameter equals
187:30: E251 unexpected spaces around keyword / parameter equals
188:28: E251 unexpected spaces around keyword / parameter equals
188:30: E251 unexpected spaces around keyword / parameter equals
189:29: E126 continuation line over-indented for hanging indent
191:13: B901 blind except: statement
207: D203 1 blank line required before class docstring (found 0)
207: D204 1 blank line required after class docstring (found 0)
211:17: E128 continuation line under-indented for visual indent
212:17: E128 continuation line under-indented for visual indent
214:17: E128 continuation line under-indented for visual indent
215:17: E128 continuation line under-indented for visual indent
216:17: E128 continuation line under-indented for visual indent
218:17: E128 continuation line under-indented for visual indent


32:1: I201 Missing newline before sections or imports.


25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be Client, Token
30:1: I201 Missing newline before sections or imports.
66:31: E712 comparison to False should be 'if cond is False:' or 'if not cond:'


23:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.utils.forms should be before from invenio_accounts.validators
25:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from sqlalchemy_utils.types.encrypted
27:1: I201 Missing newline before sections or imports.
29:1: E302 expected 2 blank lines, found 1
29: D101 Missing docstring in public class


29:1: I201 Missing newline before sections or imports.


30:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
24:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from invenio.testsuite
25:1: I100 Imports statements are in the wrong order. from invenio.ext.restful.utils should be before from invenio.ext.sqlalchemy


35:1: E402 module level import not at top of file
36:1: I101 Imported names are in the wrong order. Should be request, request_started
36:1: I201 Missing newline before sections or imports.
36:1: E402 module level import not at top of file
37:1: I201 Missing newline before sections or imports.
37:1: E402 module level import not at top of file
38:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
38:1: I201 Missing newline before sections or imports.
38:1: E402 module level import not at top of file


Is this commit complete?  It looks like it's using ev.NodeIP but nothing sets ev.NodeIP because that code is commented out?


actually we are doing exactly that with the current implementation :)


@ldoktor If I'm not mistaken pep8 should be brought up by inspektor.


right


Not done yet :)


Yeah, whoops, wasnt supposed to push that.  Maybe change it to "../llab-config.js".  I should be able to come up with an httpd.conf tweak for my setup...


This doesn't read very well. Maybe `was_connected` would be better?


Kudos to @dariodippi for helping with this one! :beers:


Thanks Richard.

I will check these changes and accordingly will merge into repository.


I noticed because there was a blip to white background on experiment load, because of that variable not being defined


Space inside parentheses detected.


Done.


Yes, that's right.  for pywintypes and friends pkgutil returns weird filename that ends with .py and not dll. The pywintypes module then gets not bundled.


@miankhalid: @aleffert wants to remove the interception logic that is currently used to inject the CSS. I'm fine either way with it. Synchronously loading it shouldn't cause much of an issue, as he noted.


This list of bullet points should not be here yet, because they don't serve any purpose.  Even though you know in your head they will become links in the future, you don't need them yet!  Please delete them.


Maybe `taskText.trim()` before `isEmpty()` ?


LGTM - I'm surprised that `.subset` doesn't do this already :/


@Tr4pSt3R like this?


@flavour Please review


One of the big things with Spring Boot is [auto configuration](http://docs.spring.io/spring-boot/docs/current/reference/html/using-boot-auto-configuration.html) which you might want to look into.  [Here is a good video](https://www.youtube.com/watch?v=HoCYQv9cQjE) where a project is set up that uses it.


@codewarrior0 I didn't know about this option.

My goal was that for py3.3 and py3.4 the travis build should fail when the test fails. With global xfail it might not fail the travis build if the test fails with python 3.


@fasterthanlime Will this fix the "incomplete struct" errors at the C compilation stage as listed in the troubleshooting section?


The only thing I'm concerned about with this patch is upgrades.  Once you pull a new Origin or OSDN with these commits, a couple things will happen:

1) your node policy will be wrong, and you may have to replace "sameMinionRestriction" in your config to get things working
2) your Vagrant environment will be wrong, since oyu'll probably have OPENSHIFT_NUM_MINIONS defined, so when you 'vagrant up' without changing anything, you won't get the minions you expect
3) all your minion names will now change, even if the hostnames in your existing vagrant machine haven't changed.  plus your muscle memory of 'vagrant ssh minion-1' will not work anymore...

Maybe that's fine and everyone needs to rebuild their Vagrant cluster after doing this pull, but I don't know the OpenShift community well enough to know if that's OK or not.  Rajat should make that call, and we should ensure that the commit message indicates this so people have warning?


Missing a semicolon at the end of this line.


I would recommend making a Transformer class that will take a results set and return your arraylist of books.  This will really help declutter your DAOImpl as well as prevent code duplication since you will end up using it in multiple service calls.


Interesting, I don't know about the formatter. It seems like if we stop ignoring some of the stuff in .idea we might be able to share it. That said, we need ultimately something that can run on the command line, so it can be a part of our CI workflow. Hopefully there's a way to just define the style once, though I suppose it'll be pretty stable so if we do have to do two different description formats its not the end of the world.


By mistake the commit was done together, So I have left inline comments with the changes.


2 directions.


Created the method to edit the text mesh that is created.


Please add a bit more information to the description. Network access to the pulseaudio server is not enabled by default and it might be needed to enable the mdns service also in firewalld to use it.


If you have a service call to retrieve books written by author, what is the point of keeping that data inside this author object?  Won't you already have an arraylist of books attached to that author returned to you from the database?


I don't say that "it's not right". I say that's a bit ambiguous for someone who had never seen URI:

- one link is about table URI (that Blaze and so gtabview accept)

- one other link is about database URI (that can be use directly by Blaze and so gtabview but can be good example to create a table URI for an other dialect)


ten odsazení tam ve skutečnosti není, jenom se to tak zkopírovalo


This doesn't make sense.  If Not In Database is false, it means this name is in the database.  That should mean that the name is invalid.

By the way, it's clearer to call your function something positive, not negative, e.g. IsDuplicate (you'll need to change the implementation slightly to match the name).  That way you don't have to think about double negatives so much.


It addressed a problem against RDP6-era servers (e.g. Server 2003, unpatched 2008) that sometimes when composing a long string of text (e.g. > 100 characters, spaces okay), you'd press the spacebar and the space would appear somewhere else in the string instead of at the end.   The application, of course, still had the correct data, but it was displayed incorrectly on the screen.


This works like a charm so far great!


@t-woerner it's not need to add mdns service in case of tcp port. it's needed for avahi (separate zeroconf module). I will fix description


Seems fine... played for several hours


@Controller denotes that Spring Boot should look here for a request mapping.  As this is a model, there is no reason to have this annotation here.


Mam tam preklep $porduct
spravne $product


Looks like this is going to be harder to track down that I thought....

In all the 0.3.x releases the concept of `GLOBAL_RNG` doesn't exist. We could just define our own local one for use on 0.3 by doing something like

```julia
if VERSION < v"0.4-"
    const GLOBAL_RNG = MersenneTwister()
else
    const GLOBAL_RNG = Base.Random.GLOBAL_RNG
end
```

This may or may not be the simplest solution... comments welcome


Yep, sounds like `data-lt` is the way to go. I'm sold on @sideshowbarker's and @andreastt argument to keep the HTML source conforming... even though I'd prefer people don't put the pre-processed HTML online (because then "confused" people complain about the FOUC).


@Controller denotes that Spring Boot should look here for a request mapping. As this is a model, there is no reason to have this annotation here.


Ok, I got it. Done.


Please delete this commented-out code as you don't need it any more.


`make` を実行した時に生成される一時的なファイルを無視させる為であれば `texfiles` リポジトリ内の.gitignoreにこれらを記述するのが正着手だと思います。そしてこの改行は。


Semi-colon needed at the end of this line.


I feel like you might be better served having Category just be a string or array of strings inside a book object.  You can easily iterate over a list of books to determine category.  What do you gain by breaking this out into its own object?


AndreiLux has tipped me to tune something.
It may hurt battery, be careful.

On Fri, Jul 31, 2015 at 11:21 PM, Janson Kang <notifications@github.com>
wrote:

> Seems fine... played for several hours
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android_kernel_samsung_hlte/commit/33aaff38a3f15d12a95d17ed33e490f3e4a1f947#commitcomment-12467452>
> .
>


You probably shouldn't call your database "whatever1234"... doesn't look very professional! :)


A nesmysl to urcite neni


Gracias @VictorJSV ahora si me queda claro, muchas gracias!


I think this should be a conditional assignment, as if a proxy is not specified (which seems reasonable), this will throw an error.


@dpoe thanks for the heads up! That will help a lot.


@smn The try, except block was removed since  the user`s profile creating in User model using signal handler post_save method.


won't this complain if the wheelhouse is not found?
can WHEELHOUSE be an http(s) uri?


We aren't supposed to do design patterns until week 9 but since we're seeing DAO creep in here I need to talk about it as well as factories.  We can either use Spring DI to inject the DAO or at the lease we should be using a factory to completely decouple the DAO code from this controller.


This and [line 57](https://github.com/dpla/heidrun-mappings/commit/dc7f7e22b3825a2d5edc0f84c8677bff0f88ea48#diff-1e2b1d1a0a1dbcafbf93eb16e16bb19cR57) doesn't seem right (i.e., delimiting keys/elements with a comma in this syntax). Can someone confirm this for me?


1: D100 Missing docstring in public module
25:1: I101 Imported names are in the wrong order. Should be MembershipState, PrivacyPolicy, SubscriptionPolicy
29: D101 Missing docstring in public class
87: D101 Missing docstring in public class
106: D101 Missing docstring in public class
124: D101 Missing docstring in public class


I don't think this change was necessary?


ok, then revert this change.
I'm on windows.

2015-07-31 17:05 GMT+03:00 Markus Ånöstam <notifications@github.com>:

> Hmm.. When I added better-npm-run it worked fine on windows just using the
> name, but on my macbook not so much.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/erikras/react-redux-universal-hot-example/commit/926db1d1bb1111f96f8fc5201d2d0c3bbd819f04#commitcomment-12467032>
> .
>


@t-woerner updated description in second's commit in Pull Request


write a thrue request and pull it on readme


Remember to create a .gitignore file and add your target directory.  There is no reason to include any generated class files/jars/etc. to your github repo.


Your comments are all correct--if you could make the changes for me that would be ideal.

Thanks,

E.


Is this a working build?


Tag people in commits


Nitpicky, but won't each book have a unique ID?  IF so this should be findBookById and not findBooksById


As you can see, there's a tension between what Eclipse tries to impose and
what we're able to do thanks to parsley/paredit: since we always have a
working parse-tree at hand, it's easy to know if we're inside a symbol, a
comment, a string literal, etc., without additional cost.
So it's easy to just do the "content type" switch at the clojure level.

If there were a lot of out-of-the-box Eclipse Text Editor frameworks
strategies we could plug into the clojure editor, I could see the interest
of following eclipse convention with partitions.
Code folding is one of the examples where it is certainly interesting to do
so.
Activating spell checker is probably another.

2015-07-31 16:21 GMT+02:00 Andrea Richiardi <notifications@github.com>:

> This works like a charm so far great!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laurentpetit/ccw/commit/5b0af570e7f164af75c1368bcf4ac6a42524467a#commitcomment-12467446>
> .
>

--
Laurent Petit


Please delete this line, if you're not setting the background colour to anything.


OK, I interchanged the 2 bench numbers. Re submitted.


To go along with a comment further down the line, why not add a service that does findBooksByAuthor and returns an arrayList of books with that author's name attached?  Then you don't have to save lists of books in your Author object.


@miltontony Thanks for sharing with us. We could see this has been already merged with develop branch. Please advice on the same.


Default arguments are shared between all instance of a function. For example:

```
>>> def foo(x=[]):
...   x.append(1)
...   return x
...
>>> foo()
[1]
>>> foo()
[1, 1]
>>> foo()
[1, 1, 1]
```

This means that all msg_getdatas that are created without an inv argument will share the same inv variable, which is probably not what you meant. You could do this instead:

```
def __init__(self, inv=None):
  self.inv = inv if inv != None else []
```


I am trying to build with 4.9 google TC but i cant seem to find the repo. Where did you find it at? All i can find is google 4.8 TC


Removed the scaling from the moveBlockRelative, scaling is not required in mouse clicks anymore as scaling is incorporated in bitmaps.


@triceo not at the moment, all tests in this class are ignored to not be executed in regular builds. We might at some point enhance it so it first deploys kie server before the test runs.
Ignore was set on method level as on class some how it did not work well with PaxExam runner...


The indentation here is weird. Highlight all but the top row, and press ALT-SHIFT-Tab three times to unindent everything.


Changed the function to use text tool created.


See my comment on msg_getdata.__init__, although it doesn't look like a problem here, since headers and inv aren't saved or modified.


In few places you're using flagsIds name while refering to flagTypesIds, I'd advice to adjust names in those casses.


Changed the container position in the move Block and move block relative functions.


The title is a bit misleading. The whole chapter contains a lot more that deserves to be presented on dedicated pages. Important methods, like creating product types and creating products, are hidden from ToC of Overview page in this way.


Removed the redundant code.


Minor stage to client edit in mouse handling


Search by server_search_query didn't work properly. Result was written to node.graylog2[:web][:discovery_zen_ping_unicast_hosts] which isn't used anywhere.


Remember to create a .gitignore file and add your target directory. There is no reason to include any generated class files/jars/etc. to your github repo.


Loop through the children to find the child with media and remove it.


Please click "alt shift F" to fix formatting errors.
Also, variable names should begin with a lowercase.


well that's the thing i am trying to explain from the start, if we want to include the CSS file from assets folder, we have to inject it like I have done. If we try to include it by giving its path, it isnt possible due to security reasons defined by the platform.
Here's the exception log that gets printed if we try to give CSS file's path:
`Mixed Content: The page at 'https://mobile-dev.sandbox.edx.org/'; was loaded over HTTPS, but requested an insecure stylesheet 'file:///android_asset/handouts-announcements.css';. This request has been blocked; the content must be served over HTTPS.`
p.s. I got this log by overriding the `onConsoleMessage(ConsoleMessage cm)` method of `WebViewClient`


That looks like for rom, i was looking for the kernel one...as this commit shows


I agree that setting MEIPASS in bootloader is a good idea.


Set the image position to 0.


Yes it has, so you can remove this from this branch.


The file had a mixed spaces and tabs indentation. I asked Maxime to fix that and use all spaces. But he probably forgot and so I changed it to all spaces.


why are these needed?


As stated in my email to you, this commit does not cause a functional change in Dynare


Yes, I'm sure of this, misc_mission doesn't have any geometry anyway (since it doesn't contain any brushes), so that was only causing problems — can walk in and out of it, but can't shoot in or out of it — anyway they spawn a child trigger — much like doors — which is what triggers them, we could do away with the trigger and make the misc_mission the trigger itself, like in the case of trigger_rescue, but even then we would need SOLID_TRIGGER instead of SOLID_BBOX


This was discussed with @mbiarnes on IRC.. I didn't think it worthy of a PR.


maybe: "Each name/type pair must be unique across a SPHERE.IO project, so if you ..."


I don't see you use kxml2 anywhere in the code.


Since we don't have a lot of control over the content of the announcements - they're just arbitrary HTML entered by course staff, I'm trying to be extra cautious about what might be loaded. Though I don't *think* there's an actual issue since ``link`` tags can only appear in the ``head``.


@ljharb Awesome! :boat:

(I think you can remove the `/*jshint evil: true/false */` comments now)


can you highlight **book** and **tshirt** somehow?


Why are there two different versions of JaCoCo in the pom?


fyi, #68.


If the whole purpose of these tests is to verify the `kie-server-client`works in OSGi container, maybe we could mock the kie-server? Basically just return predefined XML/JSON data which would simulate the running server?


Okay, if I can figure out why a test in branch p466 is failing I will fix
it and put in a pull request.

On Fri, Jul 31, 2015 at 9:21 AM, Marcos Caceres <notifications@github.com>
wrote:

> Yep, sounds like data-lt is the way to go. I'm sold on @sideshowbarker
> <https://github.com/sideshowbarker>'s and @andreastt
> <https://github.com/andreastt> argument to keep the HTML source
> conforming... even though I'd prefer people don't put the pre-processed
> HTML online (because then "confused" people complain about the FOUC).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/w3c/respec/commit/85e2f950d69028a7300033fa05aee3281a64c0db#commitcomment-12467462>
> .
>

--
Shane McCarron
halindrome@gmail.com


:heart:


Working on folding I am revamping the Reconciler idea, that is the place where you reconcile between the changes on the editor and the parse-tree.
In particular, ideally (but I am not following this approach at the moment as it would change too much):
 - ClojureDocument: text buffer and parse state
 - ClojureEditor: which contains no state in this sense and could potentially be reused (idea taken from ```jdt```
- ClojureReconciler: updates the tree state according to the calculated ```DirtyRegion```


Good idea, but this only affects background additions which is why I asked in #277. However I have added this in a commit.


please also highlight the attribute names somehow (maybe in bold)


yes, @nprevette420 me too.


We don't have an `availability` model (so far). Any reason for this to be here?


Considering all code analysis is static, you shouldn't need to install Theano on Scrutinizer at all. For blocks I use this in `.scrutinizer.yml`:

```yaml
build:
  dependencies:
    override:
      - pip install -r req-scrutinizer.txt
```

Which just installs this:

```
flake8==2.3.0  # rq.filter: <2.4.0

--allow-external pep257
--allow-unverified pep257
git+https://github.com/bartvm/pep257.git@numpy#egg=pep257
```

For Theano, you can probably just use

```
flake8==2.3.0  # rq.filter: <2.4.0
nose
```


> Okay, if I can figure out why a test in branch p466 is failing I will fix it and put in a pull request.

I'm on IRC in #specs if you need any help with anything.


Most of the results were already Harbour specific, so these simply need to be updated, see: https://github.com/vszakats/harbour-core/commit/911ce167e76e7aa5934fb07b32ff29fb09c9527f
There remains 5 tests which seem to have broke.


That does seem wrong. Interesting that I was even able to run this mapping. I can't see why it wouldn't fail outright, here:

https://github.com/dpla/KriKri/blob/develop/lib/krikri/parser.rb#L55-L61

I believe that `#select` builds a `ValueArray`, so you can probably change this to

```ruby
.select { |name| name.fields('mods:role','mods:roleTerm').map(&:value).include?('Contributor') }
```

The best way I know to play with this is: `.select { |name| require 'pry'; binding.pry }`. Because your `pry` is in a block, it won't be called until the actual record is passed in and the mapping is executing, so you should be able to inspect actual values.


P.S. The reason we use flake8 2.3 is because of what I mentioned here: https://github.com/Theano/Theano/pull/2697#issuecomment-87534046


please highlight attribute names and values.


Yeah, I surmised as much from looking at your `.shed.yml`s, figured I'd ask in case you had tried it :)


Talvez `$LOCALIP` não seja o melhor nome para essa variável: a **idéia** é utilizar esse parâmetro para se conectar ao banco local, remoto, docker container, etc.


Check github.com/ArchiDroid, he has a collection of TCs over there
Anyway these might not be GCC, might be uber or sm or linaro too
And ROM tc works works for kernel too for me xD
On Jul 31, 2015 8:07 PM, "mrhainavn" <notifications@github.com> wrote:

> yes, @nprevette420 <https://github.com/nprevette420> me too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ResurrectionRemix-Devices/android_device_samsung_n7100/commit/4beaa0ff68353580eee3d80c3f3e26e37b82027f#commitcomment-12467805>
> .
>


Ok I wanted to ask your opinion about this as well, but the keyboard didn't collaborate :smile:


.... can point to products **that** are similar ....


The test is failing on master!


Code in this (and other) function(s) doesn't fit into GitHub code pane, which I consider a _reasonable_ indicator of lines being too long (approx. 130 characters max):

![](https://s3.amazonaws.com/uploads.hipchat.com/15025/1268738/7iBKAcyhXFbB8zC/Screen%20Shot%202015-07-31%20at%2016.22.51.png)

I'm not arguing for a hard 80 or 90 characters limit, but would suggest not routinely exceeding 100 characters.

A refactoring I'd go for in this case:

```erlang
-import(escalus_pubsub_stanza, [create_request_allitems_stanza/1,
                                iq_with_id/5]).
-import(pubsub_tools, [wait_for_stanza_and_match_result_iq/3]).

request_all_items_from_node_success(Config) ->
    F = fun (Bob) ->
                RequestAllItems = create_request_allitems_stanza(?NODE_NAME),
                DestinationNode = ?NODE_ADDR,
                Id = <<"items1">>,
                RequestAllItemsIq = iq_with_id(get, Id, DestinationNode, Bob,  [RequestAllItems]),
                ct:pal(" Request all items (Bob): ~n~n~p~n", [exml:to_binary(RequestAllItemsIq)]),
                escalus:send(Bob, RequestAllItemsIq),
                {true, Res1} = wait_for_stanza_and_match_result_iq(Bob, Id, DestinationNode),
                ct:pal(" Requested items for Bob: ~n~n~p~n",[exml:to_binary(Res1)])
                %% see example 78
        end,
    escalus:story(Config, [{bob,1}], F).
```


I was thinking about this also, but I see that you're on an interesting
track. I'll focus on something else. Maybe moving lein out of CCW sources
and communicating with it via private launchers only. This will also clean
the place for adding boot to the play

2015-07-31 16:37 GMT+02:00 Andrea Richiardi <notifications@github.com>:

> Working on folding I am revamping the Reconciler idea, that is the place
> where you reconcile between the changes on the editor and the parse-tree.
> In particular, ideally (but I am not following this approach at the moment
> as it would change too much):
>
>    - ClojureDocument: text buffer and parse state
>    - ClojureEditor: which contains no state in this sense and could
>    potentially be reused (idea taken from jdt
>       - ClojureReconciler: updates the tree state according to the
>       calculated DirtyRegion
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laurentpetit/ccw/commit/5b0af570e7f164af75c1368bcf4ac6a42524467a#commitcomment-12467791>
> .
>

--
Laurent Petit


I think `s/Hintjen's/Hintjens'/`.

Also, the book has its own website (http://cultureandempire.com) where you can read it and it is licensed as `CC-BY-SA-3.0`, which I think is preferable to a link to a paywall (Amazon, in this case).


Thanks, will  give it a try


Thank you, I modified the loop as you suggested. As you know, I have an implementation of `funm` for Symmetric/Hermitian/Diagonal matrices, but not for general matrices yet (it's the one we discussed yesterday). Do you think it would make sense to add it on its own or it would be better to wait until I have an implementation for general matrices as well?


don't we have the same lines below?


(whatsnew would also be nice)


except lambda is just plain ugly :/


yep, every time en engine needs something from `Shared` it will have to explicitly declare it. Although maybe the right place could be in the engine `ApplicationController`. In this case for example in `Account::ApplicationController`, bt only if all (or the majority) the controllers will need it.


better: All available attribute types you can find here: ...


Another refactoring I'd suggest to conserve screen real estate:

```erlang
-import(escalus_pubsub_stanza, [iq_with_id/5,
                                retract_from_node_stanza/2]).
-import(pubsub_tools, [publish_sample_content/5,
                       wait_for_stanza_and_match_result_iq/3]).

request_to_retract_item_success(Config) ->
    F = fun (Alice) ->
                {true, RecvdStanza1} = publish_sample_content(?NODE_NAME, ?NODE_ADDR,
                                                              <<"abc123">>, Alice, sample_two),
                RecvdItemId = pubsub_tools:get_publish_response_item_id(RecvdStanza1),
                io:format(" Received ItemId: ~n~p~n",[RecvdItemId]),
                %% see example 100

                %% ------retraction test-----
                RetractFromNode = retract_from_node_stanza(?NODE_NAME, RecvdItemId),
                IqId2 = <<"retract1">>,
                RetractFromNodeIq = iq_with_id(set, IqId2, ?NODE_ADDR, Alice, [RetractFromNode]),
                ReportString = " Request RetractFromNodeIq: ~n~p~n",
                ct:pal(ReportString, [exml:to_binary(RetractFromNodeIq)]),
                io:format(ReportString, [RetractFromNodeIq]),
                escalus:send(Alice, RetractFromNodeIq),
                {true, _RecvdStanza} = wait_for_stanza_and_match_result_iq(Alice, IqId2, ?NODE_ADDR)
                %% see example 115
        end,
    escalus:story(Config, [1], F).
```


Ops, I just saw the mistake. You changed the wrong value ;)


Requires the openssl library on Linux and common crypto on Macs.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1262 of 1262 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


:boar:


This doesn't work for me.  A breakpoint inside NotInDatabase gets hit after ValidateName finishes.  NotInDatabase returns true all the time.  @jamiehumphries what's going on here? Is it doing this asynchronously?


@MichelJuillard This is actually the culprit that broke the decision rules at first order. See #1008


please introduce this with a new headline here as it is an important method, like:
"Check if product type with the same name exists"


this is what I tried to describe during the stand-up earlier today as "runtime react class creation"....but I'm not 100% sure if that correctly describes this code.


Thanks!


Ability to change vehicle tires using active hydraulics muscles bionics as jack.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 240](https://teamcity.labkey.org/viewLog.html?buildId=263820&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 0 Build time: 00:09:39
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


if we mock it wouldn't it mean we are not going to issue actually http request and involve marshaling etc? It might deploy but when you execute you could get runtime errors due to used libraries etc. Anyway it might be worth trying ...


Hey why are we returning ctx.acces_token here (and below too)?


I don't think you need this - it's a boolean so you can just do if (IsLengthRight && ... )
That's equivalent to

if (true) {
// do some stuff
}

You don't need if (true === true)...


@nouiz


What do we do about iplog cleanup then?


I don't see how `did_change` can ever be `false` at this point. So variable `did_change` is not needed. Is this needed for some other vim patches that are not yet included?


Wonderful, I had a look there while trying to make WorkspaceJobs cancelable and I saw that by having some fun with high-order functions you can achieve more flexibility in the project creation/building.


I'm curious why my usb speed is so slow?   How can I test the difference speeds in the source? not the nomial portbaud apparently.

There is always someone who has to break out of the group and push new frontiers.
One of these days you will push yr topas-branch  (that will lesser the gap.)
One of these days the reveng PR will be commited (that will lesser the gap)
then.. I have my minor quirks indeed like the SIM for NTAG..
I just haven't gotten around to finish it.  Maybe put into a  "hf mfu sim".
You yourself mentioned the weather and having a life away from keyboard.  ;)

And as a last defense, I claim that with my tests we have found out strange deep bugs in the firmware that might not have been discovered and ppl would be dissapointed in the PM3 device.
But the most strange bugs found, you are the one that fix them all.


В книге Мартина "Чистый код" в главе 7 как раз рассказывают про исключения.


This is missing the format string value target_file


ok


Maybe you can use GLib.timeout_add_seconds(with 1, 10 and 100 values) given that is designed to cause less cpu wakeups:
http://pygtk.org/docs/pygobject/glib-functions.html#function-glib--timeout-add-seconds


Intéressant :)


will the documentation of the "htcondorSchedds" configuration be also is some other place than the comment on a commit ? I suspect this comments will never be read, nor found if someone is looking for documentation


And do you mean that the CMD_DOWNLOADED_RAW_ADC_SAMPLES_125K  should not be "storedCommand(UC) in UsbCommandReceived()  ?


yes, just delete it.


I though about it, but I want to use 100ms delay, and that is not possible with _seconds.


Does this commit not in essence make the mongo logs module the default, and in fact remove the need for the module as far as the webui is concerned??


Great work!


@marcinkosiba kxml2 is used by RemoteAndroidTestRunner, from ddmlib.  cglib-nodep and objenesis are leftovers from my EasyMock experiment, I'll remove them from here.


Absolutely no idea, but its in all of them! It shouldn't be returning just a variable either, should be using the callback. Want me to create a fix for it?


Anything for vim that uses babel highlighting?


OK, as @jpkrohling suggested, I am deferring this, till https://youtrack.jetbrains.com/issue/IDEA-142468 is fixed.


You can see them in the live log:
https://ci.appveyor.com/project/vsz/harbour-core/build/3.4.376#L2254


:+1: :)


This file is not related to your change, and should not be part of the source (note the ~ suffix)


> And similarly when an optional value is passed as argument to a Java-implemented method.

No I disagree with this one. But what you _would_ want is a warning when a value returned from a Java method is assigned to a parameter of a Ceylon method.


Yeah, it's not needed here, only in the classpath.  I'll remove it from here.


The calls to Firebase are asynchronous. I'm leaning towards suggesting a `localStorage` based solution for the first iteration. Then rewriting for Firebase later.


Ah, no, I see how you misunderstood. `GM1Percussion` is not to be an instrument. It is a company in the new MIDI library you are making. It's like a module. It is like _the definition of General MIDI 1 Percussion_! So just make a class that doesn't extend `Instrument`. It will _define_ several instruments, but it itself is not an `Instrument`.


There is another validation preventing isInsideTheTable to be true. This function never will called unless the user manipulates the DOM. I will remove this condition.


Before creating a product type it's advisable to check ...


Ok, what is the rationale to use 100ms delay?


We don't need to instantiate the `GMPercussion` class. It is just a place to collect our definitions.


This additional line is unneded and not related to your change


Leave the empty line here to avoid noise in the patch


Nah don't worry, it'll be fixed in v1.0.


Done.


Hum... there is no license header in that file


Well, I assume most developers will be using latest version of browsers for development, they will figure out a way to deal with it ;)


2014.11.02:
	1.执行make menuconfig对配置进行修改时出现错误：
		错误提示：  HOSTCC  scripts/basic/fixdep
				  HOSTCC  scripts/kconfig/conf.o
				 *** Unable to find the ncurses libraries or the
				 *** required header files.
				 *** 'make menuconfig' requires the ncurses libraries.
				 ***
				 *** Install ncurses (ncurses-devel) and try again.
				 ***
				make[1]: *** [scripts/kconfig/dochecklxdialog] 错误 1
				make: *** [menuconfig] 错误 2
		解决办法：yum install ncurses-devel

2014.11.04:
	1.使用open函数时提示找不到fcnt1.h
		解决办法：印刷错误，应该是fcntl.h，是英文字母l

2014.11.07:
	1.已经搭建好win7以及和台式机器fedora之间以及和开发板的ftp,telnet登陆，但是未尝试Fedora和开发板之间的nfs挂载；乱码问题没解决；

2014.11.11:
	1.常用：linux常用编码为UTF-8，而往往windows下常用ANSI格式，这里需要转换，请注意；

2014.11.13:
1.Fedora关闭防火墙：
 重启后生效
开启： chkconfig iptables on
关闭： chkconfig iptables off   或者 /sbin/chkconfig --level 2345 iptables off

 即时生效，重启后失效
service 方式
开启： service iptables start
关闭： service iptables stop
iptables方式
查看防火墙状态：
/etc/init.d/iptables status
暂时关闭防火墙：
/etc/init.d/iptables stop
重启iptables:
/etc/init.d/iptables restart
2.ubuntu中如何关闭防火墙
sudo ufw disable 关闭防火墙
sudo ufw enable  开启防火墙
sudo ufw status  检查防火墙的状态
3.利用FlashTxp时发现登陆不上ubuntu，查看是否是选择“主动模式”、“被动模式”错误；

2014.11.15
1.两台linux机器之间利用ftp传输文件时需要若提示：
425 Can't open passive connection: Permission denied.
Passive mode refused.
解决方法：
passive mode off；即可；原因？
2.当在linux下编译好arm的可执行程序后，下载到arm板发现提示：
-sh: ./button: Permission denied
解决办法：传文件过程中文件属性发生修改，要把文件修改成可执行文件才可以被执行；

2014.11.18;
1.union数据结构;
公用内存，但只能取到一个变量；
2. 如何在sourceinsight里面显示行号
option->document option->editing options中，show line numbers
2014.11.20:
1. printk和printf的区别：
 printk是在内核中运行的向控制台输出显示的函数，Linux内核首先在内核空间分配一个静态缓冲区，作为显示用的空间，然后调用sprintf，格式化显示字符串，最后调用tty_write向终端进行信息的显示。
printk与printf的差异，是什么导致一个运行在内核态而另一个运行用户态？其实这两个函数的几乎是相同的，出现这种差异是因为tty_write函数需要使用fs指向的被显示的字符串，而fs是专门用于存放用户态段选择符的，因此，在内核态时，为了配合tty_write函数，printk会把fs修改为内核态数据段选择符ds中的值，这样才能正确指向内核的数据缓冲区，当然这个操作会先对fs进行压栈保存，调用tty_write完毕后再出栈恢复。总结说来，printk与printf的差异是由fs造成的，所以差异也是围绕对fs的处理。
2. unix 中的EBUSY什么意思：
这是一种标准的错误值，表示 “设备或资源忙”错误。

2014.11.22:
1.编译驱动模块时可以只编译单个文件，如：
比如编译自带的驱动演示，qq2440_hello.c，可以在配置了Makefile和Kconfig之后执行
make drivers/char/qq2440_hello.o  (注意这里是.o不是.c)
然后make drivers/char/qq2440_hello.ko
编译就完成了，只需要几秒钟时间
参考链接:http://www.arm9home.net/read.php?tid-2670.html
2.编译nrf24l01驱动时出现警告：
warning: passing argument 2 of 'SPI_Write_Buf' discards qualifiers from pointer target type
note: expected 'uchar *' but argument is of type 'const uchar *'
解决方法：
主要是因为uchar SPI_Write_Buf(uchar reg, uchar *pBuf, uchar uchars)定义的时候为uchar,而我真正在用这个函数的时候却实际赋值的是：uchar const，导致实际的不对应；改成一一对应即可；
2014.11.28:
1．编译第一个程序：
（1）编译模块：
	现在Makefile里面修改添加上：obj-m +=NRF24L01.o;
	在linux3.0.8下面执行make drivers/char/NRF24L01.o;生成NRF24L01.o文件；
	接着，执行：make drivers/char/NRF24L01.ko; 生成NRF24L01.ko文件；
	将ko文件利用ftp传入到开发板/lib/modules/3.0.8-FriendlyARM/;将权限改成777；
	进入开发板/lib/modules/3.0.8-FriendlyARM/目录，在当前开发板上执行：insmod NRF24L01.ko
	加载NRF24L01模块，再运行下列命令：
	cat /proc/devices；
	即可发现多出了“NRF24L01”这一行，找到它的主设备号后，接着运行：
	mknod /dev/NRF24L01 c 241 0;(备注：241是驱动申请的主设备号，其它照常，c表示的是字符设备)

2014.11.29:
1.static定义的静态变量的作用是：
生命期延长，即相比自动变量而言，虽然局部函数已经失效，但是static定义的变量仍然存在，但是也不能引用，再次调用该函数时才能继续引用该静态变量；
2.关于如何卸载模块：
（1）使用命令：rmmod /proc/devices NRF24L01，应该是要加上/proc/devices才行；
对于杂项设备，需要这样子输入：rmmod mini210_leds，就是把驱动后缀去掉，才能卸载，上一行的方法不行；
2014.11.30：
1.对于NRF24L01的理解：
（1）本机地址和接收地址，本机地址是指发送出去时对外宣称的本机地址，而不是要发送目标的目标地址；接收地址是指接收哪个地址的数据；
（2）在C语言的编程中，一个函数若带有返回值，则遇到return语句函数终止执行，已经退出了，所以不会执行函数后面的语句；
2014.12.1:
(1)在使用talnet时，发现串口能够输出很多信息，而利用talnet则不能显示很多信息，而且，在用talnet时竟然连plg主文件夹都显示不出原来的文件，只显示了NRF24L01.ko,和test两个文件，而用串口则显示正常，是网络的问题吗？之前都没遇到过；
2014.12.4:
1.驱动函数注册时有两种注册方式，各有特点：
参见：http://blog.csdn.net/lanmanck/article/details/4713978
杂项设备（misc device）
杂项设备也是在嵌入式系统中用得比较多的一种设备驱动。在 Linux 内核的include/linux目录下有Miscdevice.h文件，要把自己定义的misc device从设备定义在这里。其实是因为这些字符设备不符合预先确定的字符设备范畴，所有这些设备采用主编号10 ，一起归于misc device，其实misc_register就是用主标号10调用register_chrdev()的。
也就是说，misc设备其实也就是特殊的字符设备，可自动生成设备节点。

字符设备(char device)
使用register_chrdev(LED_MAJOR,DEVICE_NAME,&dev_fops)注册字符设备驱动程序时，如果有多个设 备使用该函数注册驱动程序，LED_MAJOR不能相同，否则几个设备都无法注册(我已验证)。如果模块使用该方式注册并且 LED_MAJOR为0(自动分配主设备号 )，使用insmod命令加载模块时会在终端显示分配的主设备号和次设备号，在/dev目录下建立该节点，比如 设备leds，如果加载该模块时分配的主设备号和次设备号为253和0，则建立节点:mknod leds c 253 0。使用register_chrdev (LED_MAJOR,DEVICE_NAME,&dev_fops)注册字符设备驱动程序时都要手动建立节点 ，否则在应用程序无法打开该设备。
2014.12.11:
(1)在C语言编程中，当定义了unsigned char时，如果我们在赋值的时候赋的是十进制的数，那么也就相当于赋值了一个字符，在ascall表中有一一对应关系，这时候重点就是要注意如果调用printk函数时要注意如果用%d则显示的是十进制的数，如果用%s显示的是字符串的格式，如果用%c显示的是字符的格式，以此类推；
（2）printk有时候显示有时候不显示的问题未解决，而且用dmesg也查看不到全部的信息；难道真的是没有执行到？需要再次检查；
首先，查看printk的等级命令如下：cat /proc/sys/kernel/printk，修改printk等级命令如下: echo "7 1 1 7" > /proc/sys/kernel/printk;如果需要查看所有的未打印的信息，输入命令：cat /proc/kmsg；
参考链接：http://blog.csdn.net/zhenwenxian/article/details/4336211
（3）已经调试好nrf24l01的驱动和应用程序，保存在linux program\nrf24l01调试成功代码；
2014.12.13：
（1）今天开始重新书写usb 摄像头关于v4l2的驱动以及应用程序；
(2)在C语言当中，enum是表示的是枚举类型；查找资料有：http://blog.csdn.net/logogcn/article/details/7879398
2014.12.16:
(1)在C语言的文件编程中，运用哪个read和write函数需要参考不同的情况，参见教科书393页；
2014.12.18:
(1)对于misc的驱动应该是如何去卸载和动态加载呢，这点需要学习的；：
解决方法：将设备名字改成不同的，还是insmod加载；
2014.12.19:
1.看帮助最重要看三点，一点是看函数描述和函数参数类型，二点是看包含的函数头文件，三点是看返回值，英文为return values;
2.如果命令只有一个含义，则可以直接man来查询帮助，如果该命令或者函数有多个含义，则这样子查询：man n　命令；如果ｔｉｍｅ（３）代表函数，则这样子输入：ｍａｎ　３　ｔｉｍｅ；即可实现查询帮助；

3.这个图标可以看成是个ｍａｎ帮助的结构解读：

4.#include <stdio.h>　表示存放在系统默认位置，即／ｕｓｒ／ｉｎｃｌｕｄｅ位置存放的；
#include “myinc.h”表示存放在当前其它位置；需要再次确认该定义；
2014.12.21:
(1)今天开始配置apache服务器，现在记下来每一步所做的：
1.修改设定apache服务器的网页根目录: /home/zhangsan123456；

2.设置最大连接数：注意，这里有两个.c文件，貌似都要设置；

3.设置主机名：（前提是已经改成这个主机名了，要不然会出现错误）

4.设置为big5语言：

改成你想要的即可；
5.开始设置个人认证，参考鸟哥的804页，设置好后，我应该输入的是：
http://luotuxiu2012130138:1080/protect/，这里容易因为拼写错误而导致访问失败；
参照794页设置个人主页；设置好个人主页后，应该输入的是：http://luotuxiu2012130138:1080/~luotuxiu2012130138/
如果设置了/home/www为网页认证文件夹，则需要这样子输入：http://luotuxiu2012130138:1080/~luotuxiu2012130138/html/
(2)设置linuxz终端为护眼模式，如下：
点到color, 将background color颜色改为#CCE8CF即可；

2014.12.23:
1.如果需要将驱动程序编译进内核，那么需要linux-3.0.8目录下执行make menuconfig进行配置，配置选项有三个，功能分别如下：
  Y－-将该功能编译进内核
N－-不将该功能编译进内核
M－-将该功能编译成可以在需要时动态插入到内核中的模块 ；
接着,进行make，就能够在arch/arm/boot下编译出内核文件；
2.关于linux 出现内存错误：
参照网址：http://www.cnblogs.com/justacoder/archive/2010/04/14/segmentation_fault.html

造成segment fault，产生core dump的可能原因

1.内存访问越界
 a) 由于使用错误的下标，导致数组访问越界
 b) 搜索字符串时，依靠字符串结束符来判断字符串是否结束，但是字符串没有正常的使用结束符
 c) 使用strcpy, strcat, sprintf, strcmp, strcasecmp等字符串操作函数，将目标字符串读/写爆。应该使用strncpy, strlcpy, strncat, strlcat, snprintf, strncmp, strncasecmp等函数防止读写越界。
2 多线程程序使用了线程不安全的函数。
3 多线程读写的数据未加锁保护。对于会被多个线程同时访问的全局数据，应该注意加锁保护，否则很容易造成core dump
4 非法指针
a) 使用空指针
b) 随意使用指针转换。一个指向一段内存的指针，除非确定这段内存原先就分配为某种结构或类型，或者这种结构或类型的数组，否则不要将它转换为这种结构或类型的指针，而应该将这段内存拷贝到一个这种结构或类型中，再访问这个结构或类型。这是因为如果这段内存的开始地址不是按照这种结构或类型对齐的，那么访问它时就很容易因为bus error而core dump.

5 堆栈溢出.不要使用大的局部变量（因为局部变量都分配在栈上），这样容易造成堆栈溢出，破坏系统的栈和堆结构，导致出现莫名其妙的错误。
例如，我的数组引用了越界的数据，就会这样子，必须注意；

2014.12.24:
1.今天查到210上面的video的说明如下：

S5PV210会在/dev/下生成几个video相关的设备节点，分别为
/dev/video0, /dev/video1, /dev/video2
/dev/video14, /dev/video21, /dev/video22

video0, video1, video2的作用是和Android camera/overlay HAL密切相关的，HAL层来决定这三个设备的具体作用，也就是说在设备驱动层并不会定义他们的具体作用。
/dev/video0 被android camera HAL用于capture和preview时，获取camera sensor数据
/dev/video1 被android overlay HAL用于视频输出，参见samsung/proprietary/liboverlay/overlay.cpp，overlay_createOverlay函数，v4l2_overlay_open打开设备节点/dev/video1
/dev/video2 被android camera HAL用于录像时，获取camera sensor数据
/dev/video14 是TVout mixer的video设备
/dev/video21 是TVout overlay1
/dev/video22 是TVout overlay2

2014.12.25：
1.关于fprint的用法：
参考网址：http://baike.baidu.com/view/3233662.htm
【unix】标准输出(设备)文件，对应终端的屏幕。进程将从标准输入文件中得到输入数据，将正常输出数据输出到标准输出文件，而将错误信息送到标准错误文件中。在C中，程序执行时，一直处于开启状态。
可能的使用方法有：fprintf(stderr,"error message")
stderr -- 标准错误输出设备
stdout -- 标准输出设备 (printf("..")) 同 stdout。
　　两者默认向屏幕输出。
　　但如果用转向标准输出到磁盘文件，则可看出两者区别。stdout输出到磁盘文件，stderr在屏幕。
　　例如：
fprintf(stderr, "Can't open it!\n");
　　fprintf(stdout, "Can't open it!\n");
2.关于linux函数的退出方式提示：
EXIT_FAILURE是C语言头文件库中定义的一个符号常量，在vc++6.0下头文件stdlib.h中定义如下： #define EXIT_FAILURE 1 .
EXIT_FAILURE 可以作为exit()的参数来使用，表示没有成功地执行一个程序。
EXIT_SUCCESS 作为exit()的参数来使用，表示成功地执行一个程序。
注意：记得包括头文件：stdlib.h
3.xioctl函数对于ioctl函数的封装：
参考：http://www.jayrambhia.com/blog/capture-v4l2/
#include <sys/ioctl.h>
static int xioctl(int fd, int request, void *arg)
{
    int r;
        do r = ioctl (fd, request, arg);
        while (-1 == r && EINTR == errno);
        return r;
}

2014.12.26:
1如何查看linux系统版本号等信息：
方法一：命令：cat /proc/version
2今天在虚拟机时发现yum安装安装不了，出现的错误提示如下：
Error: Cannot retrieve repository metadata (repomd.xml) for repository: fedora. Please verify its path and try again
经过谷歌，找到解决方法：
参考网址：http://forums.fedoraforum.org/showthread.php?t=223472
修改文件：vi /etc/yum.repos.d/fedora.repo

 正如最后一行所言（最后的https打错了，应该是http），将出现错误提示的段的https改成http就好了；
即可解决；
那么问题来了，我的另一台电脑也是一样的配置，为啥不可以呢？
3.如何开启linux的telnet服务：
对于fedora:
先yum install telnet-server;
然后就是修改配置文件：
vi /etc/xinetd.d/telnet
service telnet
{
disable = yes
flags = REUSE
socket_type = stream
wait = no
user = root
server = /usr/sbin/in.telnetd
log_on_failure += USERID
disable=no	//仅修改了这里
#disable=yes
}
4. stat函数讲解（转）

表头文件:    #include <sys/stat.h>
            #include <unistd.h>
定义函数:    int stat(const char *file_name, struct stat *buf);
函数说明:    通过文件名filename获取文件信息，并保存在buf所指的结构体stat中
返回值:     执行成功则返回0，失败返回-1，错误代码存于errno
5.ioctl函数的返回值：
ioctl函数的返回值是一个整数类型的值，如果命令执行成功，ioctl返回零，如果出现错误，ioctl函数应该返回一个负值。这个负值会作为errno值反馈给调用此ioctl的用户空间程序。关于返回值的具体含义，请参考<linux/errno.h>和<asm/errno.h>头文件。
参考网址：http://www.cnblogs.com/noaming1900/archive/2010/10/20/1856581.html

2014.12.29:
1.下面介绍视频的相关知识点：
5.1.1  RGB与YUV格式简介 （1） RGB格式简介  RGB色彩模式是一种颜色标准，是通过对红(R)、绿(G)、蓝(B)三个颜色通道的变化以及它们相互之间的叠加来得到各式各样的颜色的。图像中每一个像素的RGB分量都分配一个0~255范围内的强度值。这个标准几乎包括了人类视力所能感知的所有颜色，主要应用在显示器上。 （2） YUV格式简介  YUV是一种颜色编码方法。Y'UV, YUV, YCbCr，YPbPr等专有名词都可以称为YUV。“Y”表示明亮度（Luminance、Luma），“U”和“V”则是色度、浓度（Chrominance、Chroma）。RGB诉求于人眼对色彩的感应，YUV则着重于视觉对于亮度的敏感程度。采用YUV色彩空间的重要性是它的亮度信号Y和色度信号U、V是分离的。如果只保留Y信号分量去掉U、V分量，那么这样表示的图像就是黑白灰度图像，从而实现使黑白电视机也能接收彩色电视信号。  YUV主要的采样格式有YCbCr 4:2:0、YCbCr 4:2:2、YCbCr 4:1:1和 YCbCr 4:4:4。因为摄像头常见的输入格式为YUV 4:2:2,所以本文主要介绍YUV4:2:2.  YUV 4:2:2采样格式的每个色差信道的采样率是亮度信道的一半。例如两个像素点的Y,U,V值依次为：[Y0 U0 V0] [Y1 U1 V1]。采样后的码流为：Y0 U0 Y1 V1。 最后显示时的像素点又还原为：[Y0 U0 V1] [Y1 U0 V1]。显然舍弃了V0，U1，这样可以减少传输时占用的带宽，而且对画质并没有很大影响，因为人眼对彩度的敏感度远不如亮度，而亮度信息并没有减少。 （3） YUV与RGB格式的转换  本设计中需要将摄像头输出的YUV格式的图像数据，通过libjpeg压缩为JPEG。但是libjpeg不支持直接压缩YUV，所以本文先将YUV数据转换成RGB再调用libjpeg库来压缩成JPEG。   YUV转换为RGB只需要通过公式简单换算即可，具体换算方法见YUYV压缩为JPEG的函数compress_yuyv_to_jpeg。
若是基于libjpeg库将YUYV图像转换为jpeg格式进行网络传输，则参考下列网址：
http://wenku.baidu.com/link?url=ea_bUrwm2HyS0Rgn6NzBBuQLALSKld_bWG9Mbuj3lteXySknGinm0sGObIL4uhsPHtklk3Z-ovtkGQzPmMuSwmjSpo4CGjFlL8BYiBqLkva
2. gzip: stdin: not in gzip format 解决办法
今天解压文件时出现如下问题：
# sudo tar zxvf ./jdk-7ull-linux-i586.tar.gz -C /usr/lib/jvm
gzip: stdin: not in gzip format
tar: Child returned status 1
tar: Error is not recoverable: exiting now
问题解决方法如下：将z参数换成j参数问题解决
bz2格式用j
gz格式用z
c是创建
x是解压缩
v是详细信息
f是指定文件
3.一开始在开发板上面提示找不到:
./camera_h264encode: error while loading shared libraries: libx264.so.122: cannot open shared object file: No such file or directory
所以我将libx264.so.122放到/usr/lib，解决；
还有一定需要注意：最后面的122要和程序的对应，要不然会报错，所以有可能网络传输后解码会有问题，因为ubuntu的貌似是140的（编译的时候发现它提示_140错误）；
4.代码错误在这里：

初步判断是内存非法使用导致程序退出；

2014.12.30：
1.make时提示"make: 警告:检测到时钟错误。您的创建可能是不完整的"的警告；原因是有文件的时间比当前时间还要晚，解决方法：（对该文件夹或者文件使用）
 [root@luo camera]# touch .
2.今天开始搭建gdb的环境，尝试找出段错误的地方；
参照网址：http://www.arm9home.net/read.php?tid=1396
在开发板上输入：gdbserver 172.31.101.222:2012 /home/plg/camera/bin/camera_h264encode（172.31.101.222对应的是linux的地址，/home/plg/camera/bin/camera_h264encode表示要调试的那个可执行文件）
搭建好后，在linux上输入arm-linux-gdb /home/luo/camera/bin/camera_h264encode（/home/plg/camera/bin/camera_h264encode表示要调试的那个可执行文件，这个文件是在linux上的），进入gdb调试模式后，再输入target remote 172.31.101.180:2012（172.31.101.180对应着开发板的ip）；初步即可调试；
3.添加共享库的寻找命令如下：

4.在用gdb调试时发现出现错误：
Error while mapping shared library sections:
/lib/ld-linux.so.3: No such file or directory.
解决方法：
参考网址：http://blog.csdn.net/harry_helei/article/details/5740456，安装完毕后，成功；
5. GDB的基本指令：
load：装入一个程序
symbol-file：装入符号库文件，可以是用-g参数编译的可执行文件。
f(ile)：指定一个可执行文件进行调试，gdb将读取些文件的调试讯息，如f a.exe
l(ist)：列程序出源文件
r(un) ：装载完要调试的可执行文件后，可以用run命令运行可执行文件
b(reak)：设置断点（break point），如b 25，则在源程序的第25行设置一个断点，当程序执行到第25行时，就会产生中断；也可以使用b funcname，funcname为函数的名称，
当程序调用些函数时，则产生中断
c(ontinue)：c命令可以另中断的程序继续执行，直到下一个中断点或程序结束
p(rint)：输入某个变量的值，如程序定义了一个int aa的就是，p aa就会输出aa的当前值
n(ext)：程序执行到断点时中断执行，可以用n指令进行单步执行
s(tep)：程序执行到断点时中断执行，可以用s指令进行单步执行进某一函数
q(uit)：退出GDB；

2015.1.4：
1.今天继续完成linux的期末大设计：
（1）学习wireshark来分析网络协议：
参考网址：http://www.cnblogs.com/tankxiao/archive/2012/10/10/2711777.html
封包详细信息 (Packet Details Pane)
这个面板是我们最重要的，用来查看协议中的每一个字段。
各行信息分别为
Frame:   物理层的数据帧概况
Ethernet II: 数据链路层以太网帧头部信息
Internet Protocol Version 4: 互联网层IP包头部信息
Transmission Control Protocol:  传输层T的数据段头部信息，此处是TCP
Hypertext Transfer Protocol:  应用层的信息，此处是HTTP协议
（2）完成6.1题
Uniq的用法：
参考网址：http://blog.51yip.com/shell/1022.h
文本中的重复行，基本上不是我们所要的，所以就要去除掉。linux下有其他命令可以去除重复行，但是我觉得uniq还是比较方便的一个。使用uniq的时候要注意以下二点
1，对文本操作时，它一般会和sort命令进行组合使用，因为uniq 不会检查重复的行，除非它们是相邻的行。如果您想先对输入排序，使用sort -u。
2，对文本操作时，若域中为先空字符(通常包括空格以及制表符)，然后非空字符，域中字符前的空字符将被跳过
1.	[zhangy@BlackGhost ~]$ uniq --help
2.	用法：uniq [选项]... [文件]
3.	从输入文件或者标准输入中筛选相邻的匹配行并写入到输出文件或标准输出。
4.
5.	不附加任何选项时匹配行将在首次出现处被合并。
6.
7.	长选项必须使用的参数对于短选项时也是必需使用的。
8.	 -c, --count              //在每行前加上表示相应行目出现次数的前缀编号
9.	 -d, --repeated          //只输出重复的行
10.	 -D, --all-repeated      //只输出重复的行，不过有几行输出几行
11.	 -f, --skip-fields=N     //-f 忽略的段数，-f 1 忽略第一段
12.	 -i, --ignore-case       //不区分大小写
13.	 -s, --skip-chars=N      //根-f有点像，不过-s是忽略，后面多少个字符 -s 5就忽略后面5个字符
14.	 -u, --unique            //去除重复的后，全部显示出来，根mysql的distinct功能上有点像
15.	 -z, --zero-terminated   end lines with 0 byte, not newline
16.	 -w, --check-chars=N      //对每行第N 个字符以后的内容不作对照
17.	 --help              //显示此帮助信息并退出
18.	 --version              //显示版本信息并退出

2015.2.5:
1.fedora14的miniCOM出现了问题，在谷歌后找到一点解决方案，如下：
在用户账号下输入sudo minicom -S ttyS0 –o，即可进入超级终端；
2015.3.5:
1.发现一个现象，插入usb摄像头后，程序中使用video0或者video3都是一样的效果，这是为什么呢？
2.不管我在main函数或者在设置fmt那个结构体的变量的宽度和长度的时候，该摄像头都会自动设置为176*144的大小，可是上个学期的时候我是可以根据程序来调整图片宽度的，这又是为什么呢？只有我在设置为160*120的时候，它就会调整为160*120，这样在压缩为h.264时才不会导致出现段错误，内存错误退出。
3.更换了网站上面新的内核后也没有改善实验效果。
2015.3.12:
1.在Ubuntu下重启samba的正确命令是：/etc/init.d/smbd start，网上面许多写的/samba是错误的；
2.vs对应的版本如下：

注意不要搞错；
2015.3.15:
1.vs2012更改字体参考网站：
 http://www.cnblogs.com/lushuicongsheng/archive/2012/07/17/2595006.html
 2._T的作用是：_T是一个宏，作用是让你的程序支持Unicode编码
用法：wchar_tStr[] = L"Hello World!";
2015.3.20:
1.在mfc界面输出printf信息需要加入一下步骤：
3）将标准输出定向到自己创建的控制台
      #include "io.h"
      #include "fcntl.h"
        void InitConsole()
      {
            int nRet= 0;
           FILE* fp;
           AllocConsole();
           nRet= _open_osfhandle((long)GetStdHandle(STD_OUTPUT_HANDLE), _O_TEXT);
           fp = _fdopen(nRet, "w");
          *stdout = *fp;
          setvbuf(stdout, NULL, _IONBF, 0);
    }
  将此函数在MFC程序初始化的地方调用，即可使用控制台查看printf函数的打印信息
2015.05.08
1. typedef与#define的区别
              typedef：类型定义，其功能是用户为已有数据类型取“别名”。
              如：typedef  int  INT; 意思是将int重新定义为INT，以后使用INT a；就相当于int       a；
       用typedef定义数组、指针、结构等类型将带来很大的方便，不仅使程序书写简单，而且使意义更为明确，因而增强了可读性。例如：typedef int a[10]；表示a是整型数组类型，数组长度为10，然后就可用a定义变量，如：a s1，s2；完全等效于：int s1[10]，s2[10]；
define：宏定义。
       如：#define PI 3.14 意思是以后程序中出现PI的地方将用3.14代替，这个替换是在编译预处理阶段完成的，注意#define最后没有分号，否则编译时将分号一同带入PI中。

2015.07.31
1.linux下删除文件夹：
rm命令
-r 递归删除
-I 互动模式，提示是否删除
-f force的意思，忽略不存在的文件，不会出现警告信息；
2.


What you have defined is not an acoustic bass drum. You have defined the _key_ of an acoustic bass drum. Why not just make an acoustic bass drum instrument itself? And we're making a library of public definitions --- we want everyone to happily use our definitions, so no need to make it private. We want to share!

    public static final Instrument ACOUSTIC_BASS_DRUM = new Instrument("Acoustic Bass Drum", 35);


There is no license header in that file


There is no license header in that file... I guess we need one here too


Minimum delay IMHO, but is just as arbitrary as any other number.


hmm ... you're solution seems to be a better idea, now that you mentioned the arbitrary behavior of the HTML. I will implement it on Monday.
Thanks again for the insight :)


But DefaultWorld is just the generator settings when you use /p generate [name], it's not the name of the plot world. When a plot world is generated these settings will be used and saved for that world. Editing this won't change the settings in the already generated worlds, for that you need to edit the  config file of that world in the /worlds folder.


One modification I would make is to just not reference ``ignore`` - I consider it deprecated at this point since it should do the same thing as ``exclude`` right but ``include``/``exclude``are better names.


@duselmann,

Thanks for putting this together


Please rename this so it reveal your intent, for example, score_out_of_lane_punishment


:auth_token, deleted.


r=matschaffer


But DefaultWorld is just the generator settings when you use /p generate [name], it's not the name of the plot world. When a plot world is generated these settings will be used and saved for that world. Editing this won't change the settings in the already generated worlds, for that you need to edit the config file of that world in the /worlds folder.
Maybe we should rename DefaultWorld to something else to avoid confusion?


Isn't that constant defined somewhere else? I think we'll need to have it factorized


100 seconds would be too much, BTW.


I just checked what Babel is -- apparently it's JavaScript. :) I tested a couple snippets in vim and the usual highlighter works fine.


> we might think that we can safely pass a null value though a function parameter might not support a null argument.

But that's the same as with Java itself!

To me it seems that if we give too many warnings we've ruining the ability to deal nicely with non-optional types. We did this so we shouldn't always have to do:

```ceylon
Foo f = javaMethod();
assert(exists f);
```

If I now have to write:

```ceylon
suppressWarnings("javaNullCheck")
Foo f = javaMethod();
```

I don't see what the advantage is anymore.

Btw, in the case of `value f = javaMethod()` maybe we could say that the inferred type should always be optional?


This is how I started out doing it, creating the actual instruments. But I changed it around to what you see now. This is the 3rd or 4th attempt at this.
Thanks for the pointers, keep'em coming if you can :)


But can it be `protected set`?


remove `.py` in that line


I mean, if it's really malformed there's only so much we can do, but the idea is to keep it so there are as few parts as possible that can go wrong.


Hi, I am affraid that htmlentities() is not enough to produce xml safe encoding : http://stackoverflow.com/questions/2822774/php-is-htmlentities-sufficient-for-creating-xml-safe-values


seems your forgot?


😃

> On Jul 31, 2015, at 10:36 AM, Christopher Corley <notifications@github.com> wrote:
>
>
> —
> Reply to this email directly or view it on GitHub.
>


dito


This empty line is ipmortant, separating from the comment bellow.


saw approval from matschaffer
at https://github.com/graydon/stellar-core/commit/24ed57f6397e4d25018fb1390fa67f579b0abd8a


merging graydon/stellar-core/slightly-less-noisy-exit = 24ed57f6 into auto


graydon/stellar-core/slightly-less-noisy-exit = 24ed57f6 merged ok, testing candidate = 232dc9ed


I think you mean: "adding attribute values to a ..."


Sources implementation, doesn't belong to the man page. The description should rather tell more on the use cases, like a complete scenario to get a simple docker container downloaded and running.


Is there a reason you convert the iterator returned by cert.certs_from_pem_file into a list? The iterator will work just as well here.


@kurtisnelson I wanted to leave it so I could jump into dummy accounts and set things up. Is it better to be testing lots of real passwords?


Ok with the nits fixed


Bloops! Good catch! Fixed in c4ac440 :)


Exciting! :+1:


I really think this will need to be configurable at build time. I'm expecting this to vary with linux distros. Maybe something to ask on the IRC channel or mailing list.


unrelated and in a file that is not modified anymore in this commit, so git blame will just yell here.


Please remove this print, we already log the lane when adding a player.


В оригинале *объект*, а не файл.


This paragraph expects the user to look at the code to know the available sources. Better document and implement something like --source list that would show the list of available sources and exit.


It was in the earlier version of this PR.
You wont see it in PR compare


Para que fué modificado el tamaño?


If you want to pass the creator, I'd highly recommend making this interface generic - `IRenderPackageSource<T>`. Then `NodeModel` would implement `IRenderPackageSource<NodeModel>`.


could you please add kxml2 as a dep of ddmlib then? That would be closer to the truth


修改信息


This seems to be unused


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: dojson


@mfsny can you please add your commit e-mail to GitHub so it knows that this is you?


Good find!


1: D100 Missing docstring in public module
21:1: F401 'bd69x' imported but unused
21:1: F401 'bd01x09x' imported but unused
21:1: F401 'bd2xx' imported but unused
21:1: F401 'bd9xx' imported but unused
21:1: F401 'bd7xx' imported but unused
21:1: F401 'bd5xx' imported but unused


66:42: E261 at least two spaces before inline comment


30: D401 First line should be in imperative mood ('Statu', not 'Status')


See comment below on --source details


1: D100 Missing docstring in public module
21:1: I100 Imports statements are in the wrong order. from dojson.contrib.marc21 should be before from dojson.overdo


See comment below on --source


I will update https://twiki.cern.ch/twiki/bin/view/CMSPublic/CMSCrabRESTInterface#External_dynamic_configuration

Thanks for reminding me, I meant to do it but I forgot. I put it in the commit as well to help the review.


Are --registry, --username and --password actually implemented? if not, don't mention them here for the while


93469234-DemandResponse2 (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1783 of 1783 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Agreed! See my previous snippet for a super safe output ;) !


did you try to compile...?


Yes but in the old backend we always check the error.  Here I want to make it optional since it introduces a synchronization point that is not really needed.

If a previous call that did not check error actually had an error then we need to reset the buffer to 0 before checking it or it could have some old error.  Also, this function is currently the only one that uses the error buffer, but that will not always be the case.  The buffer can also be used by other random things outside the library.

I still think this will be faster than what the old backend is doing since we don't allocate/free a buffer each time.


I think it would be appreciated if you could update this to be in line with the overall coding style (see [here](https://github.com/koreader/koreader-base/wiki/Coding-style)).

```lua
if lfs.attributes(filename) ~= nil then
```

Same for the `and f~=".."`


a question : why would there a need to modify this part ? if `dirname($auxPath) == '.'` then `str_replace('../', '', dirname($auxPath))` would just return `.` right ?


marca? a que hace referencia?


Ok for that, doesn't cost much.


if you are actually logging in that makes sense.


It's a C&P from the other place I found the CHAIN_FILE being used.


will change to "the session ID" per July 31 meeting - a new pull request will be generated for this.


marcas? a que hace referencia?


It's not mandatory but helps do the usual dance to figure out the appropriate use flags for a kernel that will work with the specified type.

Basically it helps avoid copying this code everywhere.


Thank you, fixed it!


No, but h_malloc() is malloc() + some other work so I can't see it being slower.


All these changes touch a function that is not actually touched in any of the commits, git blame will yell here.


I just to compile, my server need to use this mod.


updated version of lcfr2main with production paths @mbougie


I will improve style next time.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/73570453


Предпоследнее предложение переведено неверно (да и слух очень режет, особенно то что в скобках). Вариант:
*Когда не возникает неопределенности (например, если вы не работаете с несколькими таблицами), вы можете выбрать - указывать имя таблицы или нет.*


Now that I'm there and since I have an open PR, I will change that myself ^^


that is but an open ended question : maybe I am missing something ...


:smile:


Para que fué modificado el tamaño?


@wires Kijk hoe mooi en kort 't nu is!


Sure, done.  Only in the buck files though, it is still needed here, otherwise `buck test` in a project with an `android_instrumentation_test` will fail with a `java.lang.NoClassDefFoundError`.


is this change needed?


If you pass a struct type with req/res constructor to a web interface method, maybe we could call that and get similar behavior to @before in a more intuitive way?


Thanks, `random_probvec` works now, and I am happy with this for the `GLOBAL_RNG` issue.


Hi Alex,

Thanks for the feedback.

- SHA, I assume you mean the commit-hash? Definitely a possibility to group by commit-hash, or by build ID? The chart might get overcrowded for longer timeframes (month, year), though, but should be OK for week or day : https://github.com/buildtimetrend/python-lib/issues/102
- kiloseconds : it's on the todo-list to display in 'xxh yym zzs' format, just like the badge in the top right corner : https://github.com/buildtimetrend/python-lib/issues/39
- travis buildstage labels (script.1) : as far as I know, the Travis stage names can't be customized. But there are other possibilities. The chart could show the executed command (fe. './scripts/ci/build_and_test.sh ${MODE}' in case of 'script.1'), is that something that could work for you?
Another possibility, is to generate custom timestamps with labels during the build (that's how Buildtimetrend recorded timing data before Travis started adding timestamps to their logs), but you'll have to add those to your .travis.yml file and the script that parses the logfile has to pick them up (currently not supported).

Currently the charts show averages of builds during a timeslot (per hour on the 'day' timeframe, per day on the week and month timeframe), so digging into specific builds is not possible at the moment, but definitely something I'd like to add.
Would a chart with maximum times be useful?

BTW : auto-refreshing the dashboard is almost finished.

I hope Buildtime Trend, with some improvements, can be useful for you to find the culprit for the increased build time. Feedback and new ideas like your use case, will make Buildtime Trend a better tool.


Yes, this is what I was aiming for.


this should has been never written


dito


1. please decapitalize 'Alternative'.
2. better "... your attributes at the same place ..."


I love seeing whitespace go away.


unrelated


fast-forwarding master to auto = 232dc9ed


Wystarczyło zakomentowąć w layoucie :-) Potem będziesz musiał robić revert. W NaszRzecznik.pl w ten sposób zakładkę media kasowałem.


oh man. thats embarrassing for me. .


done


Lol, I have a custom state that changes it... never bothered to fix it in the formula (had actually completely forgotten this).


mantap artikelnya... btw kalo saya biasanya pakai [webptser/laravel-uuid] (https://github.com/webpatser/laravel-uuid) mungkin bisa ditambahkan sebagai alternatif? cara penggunaannya juga sama hehe.

terus, kalau saya sih biasanya tetap menyertakan id (auto increment) pada tabel untuk keperluan indexing dan sorting dan UUID menjadi field sendiri yang nantinya akan digunakan sebagai public id (untuk diletakkan di dalam URL). kenapa? soalnya secara storage size integer (4 bytes) memiliki size lebih kecil dibandingkan dengan varchar 32 (32 bytes) sehingga ketika menggunakan int, dalam satu block index mampu menyimpan index 8x lebih banyak dibandingkan ketika kita menggunakan varchar(32) untuk data yang jumlah recordnya sangat besar hal ini tentu sangat dipertimbangkan :)

sumber: [mysql 5.7 docs] (https://dev.mysql.com/doc/refman/5.7/en/storage-requirements.html)


Hi,

I've just committed the fix.

best regards,
Przemek

On Fri, 31 Jul 2015, Viktor Szakats wrote:

> You can see them in the live log:
> https://ci.appveyor.com/project/vsz/harbour-core/build/3.4.376#L2254
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/harbour/core/commit/9e318add44ec844a54bc15f4e475e7d74e0f294f#commitcomment-12468100


я бы использовал *изящный* вместо аккуратный


I'd let the rotation here if it comes from the stylesheet, it could come from the stylesheet.


Se debería renombrar esta variable utilizando el tipo de componente al inicio, en este caso seria "chk_condicionDividir"


LGTM


I think just returning the percentage would be better that assigning it to a variable then returning it.


OK


Can you please explain why those tables are useful? is it meant to be used on a command line for quick check or for logging?


перед *это* всегда ставится тире


Actually it'd better be an member of sprite, nvm


es una prueba


I do not want to support ice cream sandwich. I want to eat one, 'cos it is
getting hot here. :) And what is the competition I have not noticed there
is one ongoing? BTW, I pulled the apks from an old Samsung S2 used for
development once. It was not turned on for months, battery seems to be
almost dead. But there is some use for it. :)

2015-07-31 15:01 GMT+02:00 Nicholas Buse <notifications@github.com>:

> I'll fight him if he suggests that we support ice cream sandwich [image:
> :wink:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opengapps/arm/commit/e6d7550e244696f2847d799c8d6043dddef3b95f#commitcomment-12465879>
> .
>


Ok thanks


maybe better: "Update attribute values of a product"
just to make clear this is not about updating attribute definition


91 columns!


CORS issue to fix !


This is a lot simpler than I expected.  Nice job.


Why not use a scope instead of an explicit unlock.


Yes, we don't have access to the `XMLHttpRequest` object, only the promise is returned. However  you could use the `beforeSend` callback to access the request object. Then we don't have to patch the abort function to the promise object.

```js
this.$http.post('url', function (data) {}, {beforeSend: function(xhr) {
    // use XMLHttpRequest and add xhr.abort callback
}});
```
Would this work for you ?


shouldn't this be `static const` or does it make a difference in compiled code?

also - all caps is reserved only for macros.  Call it `maxInt` perhaps?


This is nice :) Please try to get this merged into the etsy version


You can just do

```
return chainActive.Tip()->GetBlockTime() > GetAdjustedTime() - consensusParams.nPowTargetSpacing * 20;
```


If `dirname($auxPath) !== '.'` will be `.` then without this condition it will became `./` but this is not the same path. In this case, images included to the item package will have path `/./image.jpg` instead of `image.jpg`


The stats for the 'competition' you can find here, after every daily build it is refreshed: http://mallorea.student.utwente.nl/~maarten/opengapps/source_competition.txt


this update addresses issue #29, but still needs to be verified and tested with different setups to see if it solves the issue ...


sx.el is going pretty well :) it's slowed down a bunch seeing that Artur and I don't have much time anymore, but I've got another idea for an enhancement I'm investigating.

In short, Big-O (and little-O) notation is asking 'given N elements in my collection, how many steps am I going to take to finish the algorithm? Big-O is worst-case, little-O is best-case. Does that help?

As for a solution, think about the array a chain of carabiners (properly called a 'linked list') instead of a collection of memory cells. How does this change how you think about 'shuffling' this chain?


Try this please @toreyheinz
```ruby
describe Setup do
  let(:person) { FactoryGirl.build(:person) }
  let(:params) { ActionController::Parameters.new({
       person: :person,
       domain_name: 'church.io'
     })}
```

The main point of FactoryGirl is to reduce the clutter :)


please revise word order, like: "In orders you provide the full value for enum-like types instead of just the key as done for all other types."


Setting change


That was exactly it! Thank you


5058-fix-readvars-cli (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (744 of 744 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.14%25-green.svg)


"four" times?  I don't see a constant `4` here.


@smcgregor @SummerWish
Hey, the current `tc_message` doesn't work with Firefox because of some differences in the extension architecture. So, I'm planning to write a different test case for Firefox. I should be writing those tests as unit tests using Jasmine and not integration tests using Selenium, right ?


Tu nie zamierzam wprowadzać poprawek w kółko. Nie płacą mi za to.

Wysłano z urządzenia mobilnego.
31 lip 2015 17:15 "mik-laj" <notifications@github.com> napisał(a):

> Wystarczyło zakomentowąć w layoucie :-) Potem będziesz musiał robić
> revert. W NaszRzecznik.pl w ten sposób zakładkę media kasowałem.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ad-m/petycja-faoo/commit/c708a96a5e8ddb9e677525fda5450b10e0012652#commitcomment-12468699>
> .
>


I don't really get what `uRemFee` is...  what's the `u`?  Why is it `Rem` if it might be the `mClusterTxnLoadFee`?

Can you perhaps comment or rename it so I at least know the purpose?


cool


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.878.763cf428fa5702533d6a9163d1dd0abe38d4741f](http://build.palaso.org/viewLog.html?buildId=60415&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:03:54


Ok, can do!

fre. 31. jul. 2015 kl. 09.57 skrev John Chilton <notifications@github.com>:

> One modification I would make is to just not reference ignore - I
> consider it deprecated at this point since it should do the same thing as
> exclude right but include/excludeare better names.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/galaxy-iuc/standards/commit/d49e7ca4d7d5c2150d4a35181fec2352e01492f8#commitcomment-12468212>
> .
>


Sorry, here's the `4`.  So - why `4` hardcoded?  Does it have a meaning?  I know we don't like named constants around here, but I personally find them very helpful in cases like this.


I think it is still worth to write some words about it. A general explanation can be found in the tutorial: http://dev.sphere.io/tutorials-nested-types.html


Fees are sometimes 32 bits, sometimes 64 bits. This seems dangerous to me - one day we're going to forget a cast and get silent overflow.

`d` isn't a good name either - it's a fee, yes?


The extra braces are unnecessary here.


should we put some comments inside those JSON files ? sort of like:
http://stackoverflow.com/questions/244777/can-i-comment-a-json-file
and one json example in git (part of a unit test?)
or in the code that reads the JSON ?

sort of GIT should be fully consistent, no need to read twiki to understrand code


Looks a bit better, thanks


Yes, otherwise it segfaults


This isn't even close to 80 columns!


92 columns.


Nope, it's not (tested on fresh F20)


82 columns.


97902934_ZoneMixing (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


86 columns.  We have so few absolutely style rules, we could at least follow the 80 column rule.


Probably. We should call it "WorldSettings" instead


Looks good


Why isn't this locked?  I can guess from the code, but a one-line comment here would help us when we're auditing commits in the future, trying to figure out some race condition.  :-)


That's not the right format for a field name


ccc


Perhaps we could have a _less_ terse comment that wasn't repeated three times?


Cool. I hope people aren't weirded out by the jsdom dump (this will look different from Chrome or Firefox but eh).


Bug position, should reset ERROR_CODE every running.


May not be a bad idea. I though about something like that for the REST interface, but didn't go further with it, because some design decisions were (and are) still unclear.


Not sure about that outer thing. Should it really compete with trenchcoat?

And if it should, so should wool hoodie.


Why do we need a minFragmentSize? I looked through the OTR code and couldn't see a reason for this to even exist.


This brings up a good question.  If someone wants to see all the books written by the author, I would have thought that making a query for it would be smarter than programmatically delivering it.  What do you think?


It seems more in line with the web development style of angularjs http://fdietz.github.io/recipes-with-angular-js/controllers/sharing-code-between-controllers-using-services.html


You should make sure to run gofmt before committing!


yes, gook point


Still waiting on the Android version :-)


We should move the function to the test helpers, actually.


could be `auto` without loss of correctness or clarity.


Ack. Well, main reason is several professions use a hoodie over a normal shirt, so it seems logical that you'd wear it over other clothes. And...ack. Should've remembered wool hoodie. @_@


Yes, I think when any error happens we should actually tear down the encrypted channel and revert to initial state. I'm not sure what libotr does in these situations - we should check.


I'm inclined to suggest the same thing @eranmes did on the last PR - having an assertEqual with a string literal of the hash you're expecting.


True. We could maybe find a better name for this, or remove it completely and just use parseMessageHeader directly. =)


rather, have an early return here for the special case and lose the very long clause and all that indentation:

    if (fee == 0)
        return 0;


better: "To define the category tree in a CSV format we start with the top level categories so that each parent category appears before its child categories:"