It is set unconditionally in line 113 of soundsourcem4a.cpp, before anything else uses it; what value do you think this should have as a default, considering it needs to be read from the file?


Esqueci de comentar: mas a idéia é ter um manifesto pra basear o famoso quem somos, como funcionamos e para onde vamos.


Would an effect of this line be that `__getitem__` now fails with normal singular (non-iterable) indexes?


Why do this?


No, you can't. You don't have write acces on this repository


when code generator makes  XWalkResourceClient, it will makes a function with name contains "[]", and failed the build. I tried to fix this from code generator, but I didn't figure out how to do that.


`cotocheck` on steroids

/cc @shaneog


### A simple way to allow HTML in checkboxes
Starting with a similar problem [posted also in your site](https://ultimatemember.com/forums/topic/simple-option-checkbox-custom-validation-text/), I fixed it simply stripping html in the tag value.
This is very useful when an user want to create a "[ ] By checking this one you accept the terms agreement (link)..." checkbox field.<br />
Simply `strip_tags()` on the input value variable in [Line 1681](https://github.com/wp-plugins/ultimate-member/blob/master/core/um-fields.php#L1681), like this:
```php
$output .= '<input type="checkbox" name="'.$key.'[]" value="'.strip_tags($v).'" ';
```

The result is showed below (image in italian):
![schermata del 2015-07-13 03 18 52](https://cloud.githubusercontent.com/assets/746559/8641078/f7370a40-290d-11e5-96ed-01302ea546e6.png)


![captura de pantalla_2015-07-12_22-21-13](https://cloud.githubusercontent.com/assets/733715/8641093/5644f6e8-28e4-11e5-9f9f-d9baf119ca3f.png)

:grin:


According to updated Tiled documentation:

> *x*: The x coordinate of the layer in tiles. Defaults to 0 and can no longer be changed in Tiled Qt.
> *y*: The y coordinate of the layer in tiles. Defaults to 0 and can no longer be changed in Tiled Qt.
> *width*: The width of the layer in tiles. Traditionally required, but as of Tiled Qt always the same as the map width.
> *height*: The height of the layer in tiles. Traditionally required, but as of Tiled Qt always the same as the map height.

http://doc.mapeditor.org/reference/tmx-map-format/#layer


Nice --- someone serious about attention to detail and clarity. Appreciate the fixes.


Minor. Why is there a `w` named return variable that is completely unused? It looks like it might be unintentionally defined. If so, better to remove it to make the code less error prone in the future.

I can see the signature for [`ast.Visitor`](https://godoc.org/go/ast#Visitor) also has `w` return variable predeclared, which is likely where this is from. But given it's unused, I think it's better to remove it.


For completion, ar -T first appears in binutils-2.19
OpenBSD (and some, but not all, of the other BSDs) use binutils-2.17, as it was the last version released under the GPLv2 license.
Apple's binutils are likely even older, coming from FreeBSD.


inJava ? without space ?


@seiyria: few ways to do this:
1. Someone out there made a fluxible plugin that gives store contexts access to executeAction(). Could use that
2. Move creation of the Client to the AddServerAction, and send the client in the payload.
3. Let AddServerAction generate the id of the server, pass it along with the payload and have the store use that id. Then in the executeAction callback back in AddServerAction, register the .onAny event handler.

idk, thoughts?


This is the final version of plot 4


add
R4 save in quest file is http://puu.sh/iX42c/9280e18ba1
korean quest file is http://puu.sh/iX45f/c9c3b27e75


I like plugins, #1 sounds appealing.


Battery performance will still be horrible -- The [Premium Version](http://christocracy.github.io/cordova-background-geolocation/) is 10 times better.


Open an issue in the repo for optimizing the inclusion of the sendKeys library. It isn't worth the time until the end when we can profile across the whole extension and prioritize what we optimize.


Thanks for the proofreading. I think this is ready for review now.


@richdmartin Could you provide more details, please? A (to my knowledge working) sample can be found in the [DemoActivity](https://github.com/TR4Android/AndroidSlidingUpPanel/blob/master/demo/src/com/sothree/slidinguppanel/demo/DemoActivity.java). Does it provide any log output?


ご指摘の通りに修正。


Comment is incorrect (4 should be 5).


Thanks, @monkey101 -- this fell through the cracks.


This class is proved useless and is currently removed along with its dependency, project "Download".


@bmag What was the purpose of the underscore here?


You guys are wasting your time on my crappy old Android version.  How long does your battery last while simply sitting idle before completely drained?  24 hours?

Compare the performance to my [Premium Version](http://christocracy.github.io/cordova-background-geolocation/) Demo App in [Google Play Store](https://play.google.com/store/apps/details?id=com.transistorsoft.background_geolocation.ionic).  The premium version has little impact on the battery while sitting idle.


why requirements/edx/post.txt is gone?


slight nit, seems like you could save this `tag` in the `mqCmd` and not have to call into `getHudTag` with the settings each time you need it. just generate it in the `Config` step maybe and print out `couldn't find tag` or something if it had issues. i guess you'd still have to check whether it's empty string to print out the hud url -- so i guess it doesn't gain much, but seems slightly simpler, and there is a network call in there.


TEST


Why do this?


Might want to use outerHeight(true) in-case there's a border too.


there should be only one space after `|`


Fixed it here instead: https://github.com/sindresorhus/ps-list/commit/637dbb2a18ddd2e507caecde4ce7706cec3d4d94


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 574](http://build.prxm.it:8811/viewLog.html?buildId=3455&buildTypeId=Jarvis_DocumentStore_CI) is now running


Moving this stuff into `issueTracker`, see the code later.


正しく遷移行列がかけていれば、定常状態は理論上リスク支配均衡(戦略1のほう)にほぼ確率1でいる、ということになるはずなので、遷移行列の計算が微妙に違ってるかもしれません…
遷移行列の計算少し見なおしてみるといいかも


Здесь должно быть просто 102.


Хорошо, только минорные замечания. 5


You already catch backslash in tSpecials, escapeChar is not needed.


... so that we don't need to pass the client and the project ID.


hm in case we need to use them in other places I'd go for all-lowercase here


Is this change necessary? I can't immediately see the effect this has.


Do a `/[\x20-\x7e]+$/` do be more explicit.


Do you understand why the email address looks like this? Is it govspeak/something else that's doing it?


:+1: :+1: :+1: :+1: :+1:
:clap: :clap: :clap: :clap: :clap:


I don't like this conversion. Please use "id-to-title" filter instead. See https://github.com/platformio/platformio-web/blob/develop/app/scripts/filters/type-to-name.js
```js
{{ id | idToTitle : vm.plugins }}
```


The forward declarations of the new functions aren't really necessary as nothing refers to them before the actual definitions.

Other than that, looks fine to me.


Do you know why `’` has been replaced with `’`? I can't see that change in this pull request.


Following the naming convention, the name should be `profile-me`


Hey @bbatsov. Thanks for fixing the CI setup! I just forked the repo to do the same thing in the hope that'll reduce the changes of typos getting out in future. What are your thoughts on keeping master green at all times by only accepting changes from feature branches that have a green build?

 Is there anything else I can do to help get a fix pushed out via Melpa?


+1) got it. thanks


Symfony follows the standards defined in the PSR-0, PSR-1, PSR-2 and PSR-4 documents.
Nope PSR-2, see http://www.php-fig.org/psr/psr-2/


This part is the main menu.


`DenyUncoveredHttpMethodsWebXmlMappingTestCase.class.getPackage()` could be extracted to a variable, because of readability.


Done


This check is not necessary, since the view takes care of authentication via the permission classes.


там еще была строчка для русского языка. Потерялась куда-то.


Thanks, it works! Please merge it.


`goog.string.(starts|ends)With`. It might be a little slower, but it's way easier to read and we're not in a tight loop here.


done


// Protocol Identifiers


Please add some tests for the header characters filtering logic.


Am I right in thinking that you are monkey-patching the existing `ActionView::LogSubscriber#render_partial` method? And that you are duplicating all of the implementation of that method in order to add the extra context to the log message? I can see why it's nice to add the extra context within the existing message, but I think it might be better to avoid monkey-patching by adding a new `LogSubscriber`.

If you do go for the monkey-patching approach, I think I'd prefer to make it clearer that that's what you're doing by e.g. naming the initializer `monkey-patch.rb`. Also it would be good to fail fast on initialisation unless the exact version of `ActionView` is being used.

The regular expression and the String manipulation method chain looks as if it might be quite brittle. How sure are you that it works on any machine and for any template? I'd prefer to see some tests around it and/or for this feature to be only enabled in development.

My comments above I haven't addressed the underlying need for this. Ideally we'd be able to structure the smart answers in such a way that this logging wasn't necesary, but that's probably a discussion for another day.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17841/testReport/) for this commit**


Hi Ashok Vishwakarma

Is this module valid for INR ?
I Try to create cscart_payment table but i got error #1054 - Unknown column 'params' in 'field list'. will you please help me out this. other two tables are created successfully. Thanks in Advance


Depending on what namespaces you're 'using', one needs to write something::anything::somewhere::function(x), which is clearly less readable than x.function(). Additionally, I deem function(x) less readable in more complex expressions.


A nicer way would be to use `RetrieveAPIView` and `get_object`.

Something like:

```
class MyProfileView(RetrieveAPIView):
    serializer_class = ProfileSerializer

    def get_object(self):
        obj = get_object_or_404(Profile, user=self.request.user)
        self.check_object_permissions(self.request, obj)
        return obj
```


Avoid pushing commented out code.


Please use 2 spaces for indentation in JS


Is this change necessary?


Które lepiej używać? Tutaj chodzi tylko o wygode?


2 lines between top level: https://www.python.org/dev/peps/pep-0008/#blank-lines


when the amount is more than 1000 please present it in GHz


15: M102 unrecognized bullet/signature


when the amount is more than 1000 please present in GB


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 574](http://build.prxm.it:8811/viewLog.html?buildId=3455&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 288 Build time: 00:14:10
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.BackgroudTasksTests.ImportFromFileTests.poll: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_html_to_pdf("v2").verify_htmlToPdf_old: <no details avaliable>

```


As Arnaud said, "Intro tracks" is not very helpfull to user or translators. For me as a translator, if nothing said, I would translate this as "Introduction tracks" of an album, but it has nothing to do with it. I also don´t think "Preview tracks" is an accurate term for it. So does this repeat mode plays tracks for a constant amount of time? If so I would suggest "First N seconds os each track". And why is this on repeat mode?  Is´n this a play mode instead?


I'm sure to understand why this did send 2 messages before the fix. The `processed` event emitted by `self` shouldn't be catched by `emitter` even if it has the same event name, right ?


can we DRY here?


indentation; also in 14, 19 and 29; can you switch to tabs for indentation?


waooo


Вокруг `adjacent_element->up()` кажется скобки не обязательны: . и -> имеют одинаковый приоритет и вычисляются слева направо.


To the contrary, you don't have to specify the whole namespace because of Koenig lookup (https://en.wikipedia.org/wiki/Argument-dependent_name_lookup). For example, that's why std::string s = "NARF" works, even though the std::string& operator=(const char*) to convert to std::string lives in the std-namespace ;)
The namespace issue applies to the class itself: once you declare it, or instantiate it, it has to be specified (unless you have some using declaration)


Looks good to me, date and time were accepted.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17844/testReport/) for this commit**


dojo.query の第2引数で、絞り込むようにしましょう。
全体を検索すると重いですし、意図しないところに処理が影響してしまうことがあります。
class は id と異なり、HTML の中で複数指定することが許可されていますので・・


Bir de burada :other düzgün çalışmıyor. Ona da bir bakarmısın


```
def test_send_email(outbox):
    # mocking things
    to = make_user()
    template_dir = 'proposals/email/comment'
    context = {}
    emailer.send_email(to, context, template_dir)
    assert len(outbox) == 1
```
Would this be the expected way then.


aimluck.io.msgboard.finFilterSearch
↓
aimluck.io.finFilterSearch
が正しいです。


For the sake of modularity, the each directive should live in their own files.


NOT FIXED


filterInputField の中身は配列ですので、ループで回すようにしましょう。
動作しないブラウザがでてきてしまいます。


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17845/testReport/) for this commit**


Please order the dependencies according to https://github.com/dangerfarms/process/wiki/Best-Practices#conventions


NAK. We have a perfectly good interface for substitutions in files matching a pattern: please use it.


+1 Will be taken care in future


Hm, not sure we want a default here. How often are people going to even want a `t2.micro` anyway?


I think you might need to create some more unknowns on AxisDirection and Axis. And how about EnumFaceDirection in client package? This change breaks some features, I have tried to do the same thing you have done but I gave up.


+1 Will use Descriptive Aliases in future


Does this completely leaves the memory blank after each sending/receiving operation ? From what i have read of CMGD command, i believe it should.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17846/testReport/) for this commit**


If this is the AWS resource identifier, most resources have a default based on the deployment uuid and resource name: https://github.com/projectorhq/nixops/blob/master/nix/ec2-keypair.nix#L10


It turns out that GH is displaying the order of the commits chronologically rather than topologically. In fact the commits are topologically in the correct order i.e. the parent commit of 1a3b73e12b47106ae6575a5f3016e60a844a962c is 2ccf8564dfc9338f6cc9ba26a91d18779ff7a482, even though for some crazy reason they appear in the opposite order.


I want to ask you now as I put this module engine_amxx.dl and started giving me errors plugins ago where I had no such mistakes here.

L 07/13/2015 - 09:405: [ENGINE] Entity out of range (-1)
L 07/13/2015 - 09:405: [AMXX] Displaying debug trace (plugin "DeathrunManager.amxx", version "3.0.3")
L 07/13/2015 - 09:405: [AMXX] Run time error 10: native error (native "find_ent_by_class")
L 07/13/2015 - 09:405: [AMXX] [0] engine_stocks.inc::remove_entity_name (line 114)
L 07/13/2015 - 09:405: [AMXX] [1] DeathrunManager.sma::plugin_init (line 173)


Password is deltaphase


Have a valid length is not a proper description.

I suggest something like: ' have the same length as the exampleTimeslot "2015-17-11T20:00:00" '


Having the password here in cleartext is probably not the best idea. Maybe if it's unset we can prompt for it (in python) at resource creation time or some such?


Hi Robert,
Thank you for the pull request. I'll merge your changes and make a small change, since there's a better way to display errors changing the 'error' function instead of setting a local signal handler.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 575](http://build.prxm.it:8811/viewLog.html?buildId=3458&buildTypeId=Jarvis_DocumentStore_CI) is now running


Might be worthwhile to default this based on the value of `engine`. Not a big deal though.


Does not work on local ips. Also for public hostname has to be initializated to NULL before.


I'd actually prefer if this would focus the last used field instead of always focusing one field or the other. Personally, I sometime find myself using this dialog in add tags mode and sometimes in filter tags mode depending on the batch of books I am currently working on.


@ewnd9 Might be better to do this in https://github.com/ewnd9/progress-control ;)


Obsolete comment?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17847/testReport/) for this commit**


+1) did correction.
CREATE DATABASE BACKUP_DB;

use [SqlTraining]
SELECT *
INTO [BACKUP_DB]..[Employee_Backup123]
FROM [Employee_Backup123]


I should have created a better command in the function documentation. This fails when echoing string with line breaks and piping the result to another function (arc in our case).


+1)Thanks, will correct


I don't understand why we need to allocate 256 here and below. What's the benefit for this case?


Is this used anywhere?


This test is wrong.
On non ascii characters (but non chinese or similar), it will also delete 2 chars instead of just 1.


Obviously. ;-)
After running some longer benches, I already get a tiny speedup with 7 cores. Though I doubt this will show up at this very short tc used in fishtest, I'm gonna resubmit the test with 7 cores.


I'm not sure this is a 100% reliable solution and I currently don't have anything better in mind. Having double instead of single parentheses around the LIKE statement in the DB query would cause unexpected results, for example.


+1) Thanks


It's interesting to see the explicit use of `<br />` elements in the contact boxes here.


use `dnf.utils.is_glob_pattern`, please


This isn't exposed in the nix options as far as I can tell, should it be?


0 offset doesn't enought?


wildcard shouldn't print **not installed** packages


Why? If the list is empty for client case, then the code is harmless.


Ah, interesting, I never thought about why the assignment operator works without a namespace annotation :-D.


`except ~~when it's wildcard,~~ it considers installed packages only.`
No need to add there a condition


Небольшое стилистическое замечание: на мой вкус многовато скобок.
`(element_to_fix)` — скобки вокруг одиночной лексемы вообще не нужны (только если синтаксически вроде `if (lexeme)`).
`(element_to_fix != root) and ...` —  логические операторы имеют более низкий приоритет чем сравнения как раз чтобы в таких случаях скобок не писать. Засада только с битовыми операциями, которые имеют более низкий приоритет чем логические и в случаях вроде `(fields & bitmask) == result` где скобки обязательны. В некоторых языках эту ошибку C исправили.
`(adjacent_element->up()).lock` — тут скобки нужны только в вызове метода `up()`.


I think elsewhere we've taken the approach of introducing a new `precalculate` block to ensure that a particular "variable" is available in the template. While the use of `defined?` seems ok, I think it is inconsistent with what we've done elsewhere. Also I think there might be some benefit to the `precalculate` blocks for an outcome being an explicit list of all the "variables" that the template needs.


Looks perfect, cheers!


Кажется отступ потерялся.


Actually, now that I'm thinking about it one of the easiest things might be to add elapsedDuration into the Tapiriik waypoint metric list. That way it's just a field like any other. If a service wants to (or can) provide it, then the location and duration of pauses will be transferred, if not then things remain as they are.


I think it might be useful to include the explanation about trying to extract partials that you included in the PR description either in the commit note for this commit or at least in the PR merge commit note.


where is the implementation for tutorial1? I guess you didn't do it.


awesome. in theory things like scala can sneakily throw checked Exceptions without declaring them, but this si robust enough.


this update is a really huge improvement since a656263.

in this version, i make the freshplayer-installer functions like a real command. in this way, you can pass some parameters and guide it's functionality, like activate or deactivate some feature (in this case, use some specific library in the compilation like gtk3 or angle). this new functionalities improves much more the script, and can help you a lot to get easily some specific feature in the freshplayer-plugin that you want, like a debug mode, or a backtrace, even if u want to install an specific commit of freshplayer.

not every commit of freshplayer-plugin supports all features, but it is not a problem, since the cmake can just omit the unrecognized parameter.

now, the final part that is missing, is the modifiers that allows to edit and personalized the freshwrapper.conf file. after doing this, maybe, and just maybe, that commit would be the last commit for the freshplayer-installer (unless it requires some other modification or new feature on it).

i really hope this be useful. please enjoy it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17848/testReport/) for this commit**


Ha, yeah. I hadn't picked up on those.


Good example of TDD


@hubertlepicki Note that I have reverted this patch as the original behavior was correct. For the LongPoller case, we indeed want to replace ws(s) with http(s)


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 575](http://build.prxm.it:8811/viewLog.html?buildId=3458&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 290 Build time: 00:12:47


TeamCity Jarvis Framework :: CI-GitFlow [Build 27](http://build.prxm.it:8811/viewLog.html?buildId=3459&buildTypeId=CqrsFramework_CiGitFlow) is now running


This is something that belongs to the frontend, as corrected in a later commit.


@davidlonjon I noticed that `render_data_metabox` above is using `wp_kses` and a set of `<pre>` tags to format the output so I was wondering if we should do the same here.


Should we not also include `requirements/dev.txt` here?


Not good because it actually *removes* multimedia parameter tests from a branch that has them.
My suggestion to fix: start this branch from scratch using latest OpenPTV HEAD (which has parameters tests I believe), then use `git cherry-pick` to take only the commits *after* this one, then make a new clean PR.


+1) thanks


showing byte... which is not implemented for, since its not a known character.


+1)thanks, got it


The www/ folder is intentionally not part of the repo, and it should stay that way.
No generated files should be in the repo.


So, what did you change? compare with the main repo before making a pull request.


![Uploading 导航机制.png…]()


mala decision de colores


ИМХО, лучше сразу сделать `lock()`, ты же знаешь что элемент тебе понадобится:
`std::shared_ptr<Bin_Tree_Element> tmp_el = tree_el->up().lock();`
(А то вдруг его удалят в другом потоке, если будет многопоточное приложение.)


Also fix pom.xml not filtering plugin.yml


Sender is the first argument. Sender, command, and params are easy to remember and in a logical order, but IMHO it gets too much to be a memorable API if we add tags and timestamp... we can always extend it later if we need to?


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.0.3](http://build.prxm.it:8811/viewLog.html?buildId=3459&buildTypeId=CqrsFramework_CiGitFlow) outcome was **SUCCESS**
Summary: Tests passed: 109 Build time: 00:02:39


KOmmentoin kommittiä


Hi! I'm afraid I don't entirely understand what you mean.

"Opting out of containers" is the whole point of his commit. All Travis checks were failing on the new infrastructure. [They still do.](https://travis-ci.org/nckx/nixpkgs/builds/70714997)


Tutorial1 implementation? I guess none.


add .col-xs-offset-1 to control the gap between


I actually renamed it from `IAssignment` to `IBadge`. I agree that both are unfortunate.


@JanTvrdik it seems again failing https://travis-ci.org/nette/utils/jobs/70549389


Test case `DenyUncoveredHttpMethodsAnnotationsTestCase.java` is nearly the same. Use abstract class for common base for both test cases.


Please follow: test naming convention `test_should_...`. Since the class name already tells us which part is under testing, the implementation details (whether it is the view or the serializer that does the job) are not important here.


I see Travis has added a [spooky warning](https://travis-ci.org/NixOS/nixpkgs/builds/70656186) to its builds. That's nice, but if we can drop `sudo`, I don't know how.


:cool: :1234:


See https://github.com/NixOS/nixpkgs/pull/8770

--
Sincerely,
Arseniy Seroka

On 13 July 2015 13:42:56 Tobias Geerinckx-Rice <notifications@github.com>
wrote:

> Hi! I'm afraid I don't entirely understand what you mean.
>
> "Opting out of containers" is the whole point of his commit. All Travis
> checks were failing on the new infrastructure. [They still
> do.](https://travis-ci.org/nckx/nixpkgs/builds/70714997)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/NixOS/nixpkgs/commit/8bf4be4c3010887e48cb1b6749f9c08ebfda4767#commitcomment-12130458


Finally! :+1: :D


Move filter to a separate file, and add tests.
One test to consider especially: it should return `"false"` if the `input === false`.


Unsatisfactory implementation


The print statement should be removed


Probably wasn't clear enough in the task, but please add a group separator (start a new profile detail list element with divider title: "Queues")


I was just curious. It's fine with me


Wow this change actually found a bug in our tests!


The removal of **requirements/edx/post.txt** broke the ansible process, which still requires this file (for example [here](https://github.com/edx/configuration/blob/master/playbooks/roles/edxapp/defaults/main.yml)


Nice :smile: I see the Pull Request now and will have a look at it as soon as possible.


`if/else if` => `if/else in` :smile:

--
I feel myself so guilty everytime I notice typos, because you are doing a lot of great work,
and I am sort of a hindrance :blush:


Why two secured servlets?


pff.. now I feel yet more guilty :blush:


Yes, it is initialized only if used.

There is no need to keep track of it after the splitpoint is discarded, so the stack is ok. BTW this is one of the thing I don't understand in your code: why to clear at the beginning if the splitpoints are already all freed and discarded upon returning to root?


Typo here.


Since Flame is a public project, it doesn't make sense to use internal ticket numbers here.


Fix pom.xml please


Is it better to do that rather than use `var Dygraph = require('dygraphs')` ?


If there is more than one submodule with the same case type, the case ID will include an "_n" suffix to keep IDs unique. We need to do here what suite_xml.py  does in [avoid_duplicate_ids()][1] to get the correct case ID.

  [1]: https://github.com/dimagi/commcare-hq/blob/child_module/corehq/apps/app_manager/suite_xml.py#L1966-1966


Purpose?


Thank you, but no tabs in the indentation, please.


This revision is clean.


Float->int truncation rounds toward zero. We want to round toward -inf.


Connected component


still a senior? lol


is it necessary?


use StringUtils.isEmpty


Invariant is that before any access, there is a valid topology


update


What's the purpose of this Manager?


reverting the deletions


@craftpip yes, using 2 dots or a space does the same thing.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17849/testReport/) for this commit**


Если ты до присвоения temp_list среза в 206 строке ничего с ним не делаешь (вроде .append()), не нужно присваивать ему пустой список.


I'm a bit worry if we directly returned 'Unknown service'. Bluetooth specification allows developers to customize UUID and service name. Based on Bluetooth Assigned Numbers document, we can only validate pre-defined UUID here.


@Khelek вот это логично. Поправлю.


Здесь мы тащим за собой болезненное легаси. А если мы играем не в терминале, а в web-view, например? Там ведь не будет X и 0, там будут какие-то спрайты, или картинки. Здесь ты втащил элементы view в контроллер. Когда нужно будет писать web-view ты на практике столкнешься с тем, как много времени может сэкономить точное следование MVC


in this case I do mean "if/else if" its a sequence of if statements and 'else if' statements


Lage en test som fanger denne typo'en?


Почему в этой функции ничего не возвращается?


As actions under the conditions of the `if` and `else if` blocks are the same, and conditions are not complex, it is better to merge the blocks.


It is better to merge the blocks.


Likewise.


Er det en test?


Такие простые условия можно писать лаконичней:
```
return False if turn in self.moves_list else True
```


@chrismccord  but does it mean there is no issue here at all? If that's the case why https://phoenixchat.herokuapp.com/ still fails over HTTPS (yet works over HTTP).

I got a feeling the behavior is indeed correct for long polling but incorrect over websocket/relative URLs?


Eller er det en [***TEST***] (http:nyan.cat)


добавил "!",  для того что бы до создании выполнялся колбек, и правильно форматировал имена.


Зачем?


Pushed.


might want to `chmod +x` this script. this is what i have:
```
$ ls -l ./openstack-bootstrap.sh
-rw-r--r-- 1 kefu kefu 1197 Jul 13 19:09 ./openstack-bootstrap.sh
```


Зачеееем?


What issues did you have? You never reported any bugs to me. I'd have happily fixed them for you.


2015-07-13 08:07:06 DEBUG    MAIN :: The name Show.Name.S02E03.HDTV.XviD-RLSGROUP.ext parsed into Show Name - S02E03 [GROUP: RLSGROUP.ext] [ABD: False] [ANIME: False] [whichReg: ['standard']]


typo "acessible" -> "accessible", same in filename


To wygląda na śmieci..


Сам придумал?


ok


Could colouring be made optional? I *really* like having it for console output for for file output it's quite a hindrance.


and an argument is required to specify the openstack provider. currently only "ovh" and "entercloudsuite" are supported.


No: `requirements/dev.txt` isn't used in the `Dockerfile`; it's only used on booting the dev containers, so isn't a dependency for building, just running.


init 時にsynchronization.browserを取得することができないので、callbackのデフォルト実装のロジックはそのままにしました


+1 Will use naming conventions properly.


+1) will use naming conventions properly


+1 Will use descriptive aliases from next commits


delete


I'd actually *still* like to fix whatever issues you had, if you tell me what they are.


[As of 12 July] that's just a trivial patch moving /etc to /tmp (while still leaving two `sudo` calls...).

Sorry, I still don't understand how this solves /nix. :confused:


Open for ideas. A module hook? What would the signature look like?


OT: why is "assret" allowed? I can't see this "spelling" in any codebase, surely it's not meant to be a legal alias...


Not correct, read the question again


Not correct, read the question again, department name should also, be there.


project/lib/orm/types.py - скорее как-то так


Missing Question 3 and 5 of section A


@hodgestar ready for re-review


Надо путь к модели вынести в константное поле класса.


Лучше сформировать новую строку конкатенацией, и сделать один `write`.

А еще лучше не использовать стримы напрямую вообще, потому что они работают с бинарными данными, а не с символами и у нас могут возникнуть проблемы с кодировкой (см. http://stackoverflow.com/a/4069104/4764971).


Стоит попробовать перенести это в блок `finally`.


Можно объединить в один `catch` с помощью побитового "или" (`|`).


+1 Will make id's auto incremented from next time


I think for all help sections in this file, this needs to be changed to:

     .PARAMETER StartupProject
        Specifies the start-up project to use. If omitted, the solution's start-up project is used.


+1 Will add Project in select query


+1 Will add department in the select query


And if you need something like this http://exmaple.com  - frontend and http://exmple.com/admin - backend.
http://mickgeek.com/yii-2-advanced-template-on-the-same-domain-2   -- Nice POST))


I know, it was change to make it compatible with PHP 5 (https://github.com/php/php-src/commit/f30503ce4e0482d638a2561ca3ddc6e1291a104a). Reverting should make it work.


Awesome
Thanks.


why have you added { strict: true } validation?
Now it raises exception when :name is empty.
So if user send empty name he receive weird exception instead json object.


i know some of these words


undefined or null?


Why did this change the coding standards for everything?


Should I therefore revert it? (It's not important)


Well you cant have a product with an empty name. A product has to be unique right?


We need to figure out how to handle writing embeds. With primary key, it's not properly generated when inserting, without we can't cast it.


>  do mean "if/else if" its

in the comment you use the `"` - quotes :stuck_out_tongue_winking_eye:


note to self: Looks like I'll have to separate the Flask stuff from the server.py


Hello Akshay, Please add more specific points why you are not satisfied with this solution?


Is this ok, or should `nil` be included here?


If we returned "Unknow Service", the size won't be |sizeof(rec->name)|, right?


The common ting is rebase, so rebase please =)


<apex:page title="Search" controller="queryBuilderController" showHeader="false" sidebar="false"  id="thePage">
<apex:form >
    <apex:pageMessages />
    <apex:pageBlock title="Query Builder">

     <apex:pageBlockSection title="Object Type" columns="2">
     <apex:pageBlockSectionItem >
     <apex:selectList multiselect="false" size="1" value="{!obj}">
        <apex:selectOptions value="{!PickListValue}" />
        <apex:actionSupport event="onchange" action="{!selectObject}"/>
     </apex:selectList>
     </apex:pageBlockSectionItem>

     <apex:pageBlockSectionItem >
     <apex:outputLabel >Query Builder </apex:outputLabel>    <apex:inputTextarea id="newDesc"/>
     </apex:pageBlockSectionItem>
     </apex:pageBlockSection>

     <apex:pageBlockSection title="Standard Object" columns="2" rendered="{!Standard}" >
     <apex:selectList multiselect="false" size="1" value="{!stdObj}">
        <apex:selectOptions value="{!StandardObject}" />
        <apex:actionSupport event="onchange" action="{!selectStdObject}"/>
     </apex:selectList>
     </apex:pageBlockSection>

     <apex:pageBlockSection title="Standard Object Fields" columns="1" rendered="{!StandardFields}"  >
      <apex:selectList multiselect="true" >
       <apex:selectOptions value="{!StandardObjectFields}" />
      </apex:selectList>
     </apex:pageBlockSection>

     <apex:pageBlockSection title="Custom Object" columns="1" rendered="{!Custom}">
     <apex:selectList multiselect="false" size="1" value="{!custObj}">
        <apex:actionSupport event="onchange" action="{!selectCustObject}"/>
        <apex:selectOptions value="{!CustomObject}" />
     </apex:selectList>
    </apex:pageBlockSection>

    <apex:pageBlockSection title="Custom Object Fields" columns="1" rendered="{!customFields}">
     <apex:selectList multiselect="true" size="1">
        <apex:selectOptions value="{!CustomObjectFields}" />
     </apex:selectList>
    </apex:pageBlockSection>

    </apex:pageBlock>
  </apex:form>
</apex:page>


Hey,
i couldn't find a way to write you..
First of this is a a awesome fix i have been needing for a project,
Also do you know if this fix will be part of the standard later ? so we dont have to reapply this fix if we update jquery ui?


seneca-auth should have no knowledge of other auth plugins


The V2AppDefinition is the definition for the outside world, the AppDefinition for marathon internal world. In that regard I would call it rather natural to alway have a chain unmarshal(V2AppDef) -> work(AppDefinition) -> marshal(V2AppDefinition)


@sindresorhus Definitely gonna do it later :+1:


Добрый день.
Если бы Вы все-таки объединили эти алгоритмы в один класс (что является не столько критичным, сколько разумным подходом), то, возможно, Ваши методы были более унифицированы с точки зрения их вызова, применение делегата отыграло бы более мощно.
DateTime рекомендую заменить  на Stopwstch.


I don't see why this function needs the `userId` param? it isn't used, so it doesn't make any sense.


Since there is always only one step, i would argue no.


Нельзя объединить, падает с ошибкой.


Im not sure this is any better


While `Oo.id (object end)` is indeed supposed to be a thread-safe unique ID, it wasn't until earlier this morning :)


![screenshot from 2015-04-18 23 17 58](https://cloud.githubusercontent.com/assets/10350072/8648841/866c7384-2964-11e5-9fb3-233267ebd106.png)


@twistor IDE messed up, I've tightened the .php_cs file.


You missed some aliases.  But generally I would not go this way. Just create a new type nova_t and use all calling from nova_domain_template().

Also I would merge other nova domains and have only nova_t as we have for neutron for example.


I'd recommend using more of the phpdoc fixers. :)


Код этого метода абсолютно не читаем, нужно разбить его на методы, руководствуясь тем, что должен выполнять именно этот метод


You kidding me?


Excellent :+1:

@theolaurent


it looks fine. I have 2 suggestions I'd like to see:
- indentation = 4 spaces
- class name (and filename) ConsoleWidget -> TerminalWidget (to keep the naming consistency)


Which ones? I don't see so many on the website.


This is a theme problem?

The hierarchy widget itself works in inline forms.


А если arg не int?


Ahh I see... I don't know for sure, but for what I saw in the docs it doesn't. So GPS only provider is the way to go...
Still, if GPS provider is disabled, show a dialog to enable it.


a typo: diname -> dirname


The name "Intro Tracks" comes from foobar2000 where this feature is well known from. It is meant to mean "an introduction to your new tracks", an accelerated way of getting to know them. I agree that this probably doesn't translate well, but I was going under the impression that those looking for the feature could find it under the usual name. I think calling it "Play the fist half of each song" makes it look unpolished, as if we couldn't come up with a better name. Assuming that most users probably leave the OSD enabled in some way, we could put that as the description when they turn it on. Preview is not a bad term IMHO, but again I can't speak for the translation.

This was put in the repeat menu because the shuffle menu made less sense and we don't really have a dedicated play mode menu. It also integrates well into the code this way. I can move it, I'm just not sure where.


=)I understand now. Never used NMA before, good to know =)


```
phpdoc_indent
phpdoc_no_access
phpdoc_no_package
phpdoc_params
phpdoc_scalar
phpdoc_separation
phpdoc_short_description
phpdoc_to_comment
phpdoc_trim
phpdoc_type_to_var
```


I would call this function cmd_login
people use _foo to indicate private methods - this function is a different sort of thing


@tcrsavage hm, not sure I can see a case where `$current_level < 0`. Am I missing something?


The website's horribly out of date. Look at the actual readme instead. :)


The entity is tested and should be the expected app.


Did not understand why we need to intimidate core domain model for the sake of search, all information with respect to complaint is available with in the complaint. If our current search indexing won't work then better we create a separate class which holds all these information. This will poise our core domain structure and service layer to add these extra information to patch up the search indexing. @srivastava-manu @elzanmathew @satyamashish please add your views regarding this.


Definitely not, thanks for spotting it!


I have a style preference for else statements that makes them easier to cut and paste, and also keeps the code structure more consistent:

``` js
if( ... ) {

}
else {

}
```


搞啥啊，rc－select 不用，用 jq 和 arale2


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17851/testReport/) for this commit**


I'd removed the `assert_state_variable` calls that related to the phrases that I've removed in this commit. However, your question made me realise that this didn't really make sense - because phrase keys aren't accessible as state variables anyway.

I'm now going to remove all these `assert_state_variable <var>, nil` calls in a separate commit.


实现了功能再说。


seneca.fail is deprecated
please use https://github.com/rjrodger/eraro
see seneca and seneca-transport for examples


I had to change it otherwise pre-commit checks would fail.


@hubertlepicki This function in particular is only applicable to long polling, so if there is a bug, it would be elsewhere. That link works for me. Can you provide more info on the error(s) you get?


hope this helps. We'll see


``` js
}
else {
```


A typo fixed in subsquent commit.


this is not the way that seneca plugins work  - as above, the user will write code like so:

seneca.use('auth')
seneca.use('twitter-auth')
seneca.use('facebook-auth')

integration is always via action patterns


sorry...should have read your code more carefully. I see now WaypointType.Pause. And that the duration is just the waypoint.Timestamp minus the pause interval.


Prac. Modulo 8


бл


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17852/testReport/) for this commit**


I'll take care of this since I have another changes what I will commit to
the story-tools repo... I have it fixed locally..

On Fri, Jul 10, 2015 at 10:15 AM, Bart van den Eijnden <
notifications@github.com> wrote:

> right I forgot to adapt the test
>
> Sent from my iPhone
>
>
> > On 10 jul. 2015, at 16:18, Tyler Garner <notifications@github.com>
> wrote:
> >
> > @bartvde, this change breaks the tests:
> >
> > loadFromGeoJSON
> > ✗ works
> > Expected 1000000000 to be 1000000.
> > Error: Expected 1000000000 to be 1000000.
> > at /Users/s30226/projects/story-tools/dist/tests.js:30035:0 <-
> test/test-pins.js:64:0
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/MapStory/story-tools/commit/87b4db5d9496e3c60ff85c8c8ba7c72f5efec354#commitcomment-12108042>
> .
>


Their docs mention it as part of the signature of the function. Without it, calling the function fails.


expecting keyword_end :-1:


As per my comment on the previous commit, your question made me realised that I hadn't completely understood the removal of these calls to `assert_state_variable`. I've now removed all these unnecessary assertions in a separate commit before converting from YAML to ERB.


I agree. Let's discuss it whenever you are free.


I do not understand how to use ContainerUtil.immutableSet().
Also I doubt with changing private to public in ErlangPsiImplUtil, but it's the only way to use that method.

Other mistakes are fixed.


Looks more correct to me. :+1:


This patch seems as if it is breaking things for me, as the `only_if` is tested at compile time, at which point all the files do not exist in case we are doing the initial installation, having no mysql packages installed yet.


Can you remove the extra /// ?


Ниже - очень странная конструкция, - Вы делаете проверку, затем по результатам выбрасываете исключение, которое сразу ловите, и все лишь для того чтобы вернуть форматную строку?


'krai' can be 'isGameOver'


аналогично


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17853/testReport/) for this commit**


Done


Данный метод отвечает только за форматирование, поэтому всю логику получения 16-го представления нужно выносить в отдельный метод


@yale2a1 `pe.chalk.takoyaki.filter.Filter`를 구현한 클래스들의 `protected abstract List<T> filter(Document document);` 메서드랑 `pe.chalk.takoyaki.Target` 클래스의 생성자를 적절히 수정하시면 돼요


Be consistent, create a README.rst instead ;-)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17854/testReport/) for this commit**


hrm/group doesn't work - no data ever saved, doesn't seem to be a theme issue.
Basides there is logic issues in terms if multiple=False & the widget having multiple select options


wrong spelling, should be application.appkeyspace


一会我搞下，三天没写代码了...


Good catch. It takes more to test this method with all optional properties.


@yale2a1 `[https://namu.wiki/여성시대]` -> `[여성시대](https://namu.wiki/w/여성시대)`


Problem is solved now. Something got inconsistent during merge.


> I think elsewhere we've taken the approach of introducing a new precalculate block to ensure that a particular "variable" is available in the template.

You're quite right. The use of `defined?` is a hangover from the first version of this branch that I opened as a pull request. I'll change that now.


前缀不要加的，有工具会自动加


Je ne suis pas d'accord.


remove the \ at the end of each line.


@Moridin997 I think we relocalised and used the imperial reconquest casus belli because it is a feature only in the Legacy of Rome DLC, and so using this CB requires this DLC. I think we need to add a limitation that these Cbs can only be used by owners of that DLC to comply with Paradox policy,


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


What about `assertThat(contentOf(response), is(CONTENT_FROM_HEAD));`?


Pas faux
Je t'en prie tu peux le faire vu que tu es en vacances :p

Le 13 juillet 2015 11:26, hastou <notifications@github.com> a écrit :

> On aurait du coder la partie réseau avec qt et pas avec la sfml
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tbmc/NoMoreFloppy/commit/73592387c4f659b7c9f72b0890cde0fd2d1d3d75#commitcomment-12129195>
> .
>


Hmm, is that different from using store by passing false as the task? E.g. line 48 of testRunnerExample.php $scheduler->store(false, "directly stored data", "directStoreName", "directStoreParent"); which stores the string "directly stored data" under returnObj["directStoreParent"]["directStoreName"]? Could also forgo parent and use $scheduler->store(false, "directly stored data", "directStoreName") to store under returnObj["directStoreName"].


Description of test case would be helpful.


Wouldn't it be better if this was more generic, meaning that we could specify any type as nil?

`mrb_get_args(mrb, 'n!')`


So I was running into an issue on the line that you were passing false. Passing false was perfectly fine, but the issue was that when it was entering the conditionals, it was trying to pull a task ID that didn't exist, because it's all cached data and there wasn't a task, per say, created at that time.

So I hashed this up so that you can pass true to it for just storing a cached item. If you wanted to work it a different way that's fine, but it was the easiest solution for me at the time.


* Est-ce que `/js/bbl-locations.js` va subir le même sort ?
* Est-ce que je peux utiliser de manière sûre http://data.brownbaglunch.fr/baggers.js ?

Merci :)


Why two methods?


Chrome:
![wss](https://cloud.githubusercontent.com/assets/33274/8649016/35382f4c-2966-11e5-9294-641de03cd126.png)

Firefox:
![wss2](https://cloud.githubusercontent.com/assets/33274/8649024/46d12a06-2966-11e5-8a77-665780380150.png)

So on Chrome the exact error in the console is:

    Mixed Content: The page at 'https://phoenixchat.herokuapp.com/' was loaded over HTTPS, but attempted to connect to the insecure WebSocket endpoint 'ws://phoenixchat.herokuapp.com/ws'. This request has been blocked; this endpoint must be available over WSS.(anonymous function) @ phoenix.js:613disconnect @ phoenix.js:603connect @ phoenix.js:612init @ app.js:8(anonymous function) @ app.js:60m.Callbacks.j @ jquery.min.js:2m.Callbacks.k.fireWith @ jquery.min.js:2m.extend.ready @ jquery.min.js:2J @ jquery.min.js:2
    phoenix.js:613 Uncaught SecurityError: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS.

You do specify relative /ws path in app.js. As far as I can tell, the app tries to connect via ws:// protocol no matter if served over HTTPS or HTTP. I don't really undersand how this can be happening by looking at the phoenix.js code, it should just work.


remove all call to `.make_variable()` inside make_node() methods by just `()`. This isn't pep8, but a needed "fix" to get better error message now.


> I think it might be useful to include the explanation about trying to extract partials that you included in the PR description either in the commit note for this commit or at least in the PR merge commit note.

Good point. I'll include it in this commit as this is where it's most relevant.


Regarding "remove progressManager.endStep() calls that were not needed ":

* If it's not needed then we should remove the endStep() method probably as otherwise I would say that not using it is a bad practice


Do this for all class in that file.


Before doing this we should probably assert that partialDecodeNeeded and fullDecodeNeeded are set as expected?


@jecluis thanks for your excellent comment. =)


I agree "Preview track" might not be very good as well. If "Intro tracks" exists in another software, at least we have some consistency here. "Play the first half of each song" maybe looks a bit too long indeed, so I'm not sure what is best.
I also agree that while it's strange to have this in the repeat menu, maybe it's not worth to have a separate entry in the UI for this.
So I don't have a strong opinion about this: I just wanted to share my thoughts :)


cc: @despiegk @grimpy This is an example of how long text will be broken up into lines and represented as multiline TOML strings when the string field is set to the file using this module.


I think so, but i don't think this code use something from LoR? Not sure by the way.


- ตั้งชื่อ test method แปลกๆ จริงๆ ถ้าเป็น java เค้าจะไปตั้งชื่อ test กันละ เพื่อมี @Test บอกอยู่ละว่าเป็นเทส
ควรตั้งชื่อเพื่อบอกว่า ทดสอบอะไร ป้อนอะไรไป และ ต้องการอะไรออกมาเช่น testWith1() ควรจะเป็น
give1shouldReturn3 อะไรประมาณนี้

- assertEquals ผมว่า message ไม่ต้องใส่ เอาไปตั้งเป็นชื่อ method  เลยจะดีกว่า เพราะ ยังไง 1 method ก็มีแค่ 1 assert อยู่แล้ว ทำให้อ่านชื่อ method ก็เข้าใจเลยว่า method ป้อนอะไร ต้องการอะไร ประโยชน์แฝงอีกอันหนึ่งคือไว้
cross check ว่า input / output ในโค๊ด กะ ชื่อ method ตรงกันไหม

- จะเห็นว่าโค๊ดใน test ซํ้ากันเยอะมาก เช่น testName, message ใน assertEquals อาจจะ refactoring ให้ไปเรียก helper_assert แทน ประมาณนี้ https://github.com/ibotdotout/coe-pairing/blob/master/tests/vasya_clerk_test.py

- ไม่ควรทำ random test เพราะ
1. มันทำให้มี logic ในเทส มีทั้ง random , loop บลาๆ แล้ว แล้วคุณรู้ได้ไง ว่า loop คุณ จะทำงานถูกต้อง ต้องอีก Test มาสำหรับ Test loop ในเทสอีกทีไหม เพื่อขจัดปัญหา เหล่านี้ดังนั้น ไม่ควรมี logic ให้เทส เขียนเทสให้ simple ที่สุดพอ
2. random test ทำให้บางครั้งรัน test pass/failed ทั้งๆ ที่โค๊ดยังเหมือนเดิม ? ทำให้ เทส และ โค๊ด นั้นไม่น่าเชื่อถือ
3. ที่เราเทส เราต้องการรู้ว่า โค๊ดทำงานได้เหมือนเดิมไหม (Regression Test) / ตรงตามที่ต้องการไหม
ไม่ใช้หามา input ไหน ที่จะทำให้ failed

ลองดูเรื่อง FIRST Principle of Unittest
http://www.somkiat.cc/good-unit-test-with-first/


remove the use of \ at the end of lines.


and put the + at the end of the lines.


Pour bbl-locations.js oui on peut les migrer de la même manière sans soucis. Si tu veux le faire vazy sinon je le ferai à l'occasion.

Sinon oui tu peux utiliser data.brownbaglunch.fr/baggers.js de manière sure pour le moment.


@chrismccord I suspect you might be using Safari or older versions of Chrome/Firefox where mixed content HTTPS/WS was allowed? I think Safari doesn't even give you any warning. Older Chrome did warn you on console but nothing else. Up-to-date Chrome just refuses to do insecure connection...


cc: @matefh this is needed to have correct post layout


Hmm, that's very interesting since the version I compiled with LoadingCache compiled and worked. Oh well :p


no


もしadvertisingIdフィールドがない時サーバーエラーになるなら、コールバックにはnullを代入した方がいいかもしれません。


Add internals to your project:
```
// Declare internals

var internals = {};
```

You will not use internals in the script, but  you want to get used to hapijs style of using
this variable to control the amount of variable is a modules global space.
Douglas Crockford in 'JavaScript the Good Parts' calls this <b>Global Abatement</b>.
If you are going to work through the assignments at hapijs/university, I recommend you read this book.
You will find it helpful.

See solution for example of internals use:
https://github.com/hapijs/university/blob/assignment2/lib/index.js


thanks!


Need to test for errors:
 ```Hoek.assert(!err, err); ```


Если есть params, то зачем в этом методе первые два параметра?


а зачем менять стиль объявления переменных?


It's not a good idea to use 'this' here. Please replace it with something else, instead you would experience problems  with this context ...


Что делает в  проекте типа ClassLibrary Console.WriteLine? А если у Вас этот метод будет использовать код, не являющийся консольным приложением?


hallo world


probably "setup" without hyphen


@PeterBjuhr I'm not sure if that's the right approach. It does what it suggests: deactivate the music_sync_cursor action when the document doesn't support it, but I'm not sure if this shouldn't be a property of the *viewer*, regardless of the file in it (and I think the music view implements this the same).

If we'd go that way we'd have to add logic to set the option to `False` and should consider restoring the value upon the loading of the *next* document etc.

So maybe we should simply leave it alone? the option will always be enabled, and on or off but will simply have no effect if the document doesn't support it.


packages/apps/Settings/src/com/android/settings/cyanogenmod/StatusBarSettings.java:312: error: cannot find symbol
                    (Boolean) objValue ? 1 : 0);
                              ^
  symbol:   variable objValue
  location: class StatusBarSettings


Console.WriteLine?


I think you switched the tar and xz errors.
Later today I'll take a further look at the code.


Unnecessary space.


good improvement !!!


thank you


ok, i see. So the problem was passing a parent but not a name, which causes the task id function. So store(false, "the data", false, "parent") would definitely cause an error. Is that right? One way we could rewrite the conditional is
```php
if ($name)
    $this->returnObj[$parent][$name] = $data;
else if ($task)
    $this->returnObj[$parent][$task->getTaskId()] = $data;
else
    $this->returnObj[$parent] = $data;
```
would that do it? That'd be good for expanding how the signature could be used. I think that store(false, "the data", "parent") would also have the same effect, though it's not as intuitive if you do mean to extend that object later. Am I on target here at all, or do you mean something different?


```
ssh -i ubuntu@$HOME/teuthology-admin 167.114.240.138 tail -n 2000000 -f /tmp/init.out
```

might need to add `ubuntu@` ? in case `whoami` is not ubuntu?


好的，这段已经删掉了。
改了前缀用现有的样式了。


Yeah, that should definitely be debug or trace. Can you go ahead and make the change?


Remove it


seneca.pin will be deprecated - it is a failed approach
the reason is that it does not transfer the context `this`, so tracing is lost
just call the actions directly using seneca.act


Using just store(false, "the data") should also do something. Maybe just store under first unused numerical index. like returnobj[0]


Todo el desarrollo de este 'commit' lo he realizado en la rama 'creditos', como se pide en el ejercicio, lo que ocurre es que al pasarme de nuevo a la rama 'master' y subirlo todo aquí (GitHub), no me aparece esa otra rama... no sé si es así o si debe aparecer.. me imagino que para que hubiese aparecido, tendría que haberlo subido aquí antes de hacer el 'merge' con la rama master, y despues haber actualizado todo...


A couple of typos, rest is ok :+1:

As a personal question, is there any reason for not having for instance ```create_edge``` and similar functions for both lattice and mesh objects?


I wanted to have a set of strategy plugins that are "official" plugins and can be integrated directly by just adding to config/service array. There can be also implemented other plugins.

I agree that it is better to have it completely separated, and seneca-auth do not have then any information about existing plugins.

In this case we need to specify also in documentation that auth-strategy configuration must be provided to each plugin separately not as part of seneca-auth's config.


Add it in .gitignore


seneca.util.recurse is also deprecated
better to use async.series


this and below isn't correctly formatted.. @param is below the method description and each param needs a description.


commit


Although this displays the errors, this is not the typical way to handle this scenario when a form fails. It is customary to render :new rather than redirect, that way you don't lose all the data you've entered. This works fine in any other cases that don't involve errors in the nested models. I was hoping I missed something silly but if you are having the same problem, perhaps we solicit help from the cocoon author or community, or search stack overflow for the scenario.


I am going to punt on orthographic policies like this one. As long as you and @hflynn are on the same page, happy to push a commit (or find a synonym :) )


Thank you! Definitely clearer. I also think `forceSameCount` would be a lovely parameter name.


The options object is already being passed in, why not use that? This seems redundant


game


the comment should probbaly be removed too :smile:


`window.System`?


1: M111 unrecognized component name: utils


Haha yup


thank you for your help


//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
//===========================学生个人信息类================================
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
#include <iostream>
using namespace std;
class Student
{
private:
	char stuname[20], stunum[20],clanum[20];//姓名 学号 班级
	int bed;
public:
	void Input();
	void Input1();
	void Input2();
	void Input3();
	void Input4();
	void Print();
	char* Stuname();
	char* Stunum();
	char* Clanum();
	int Bed();
};
//====================================================================//
void Student::Input()
{
		cout<<"   **********************"<<endl;
		cout<<"   姓名:";
		cin>>stuname;
		cout<<"   学号:";
		cin>>stunum;
		cout<<"   所在班级:";
		cin>>clanum;
		cout<<"   所在床位:";
		cin>>bed;
		cout<<"   ***********************"<<endl;
}
//====================================================================//输入修改后的姓名
void Student::Input1()
{
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
	cout<<"   ";
	cin>>stuname;
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
}
//--------------------------------------------------------------------//输入修改后的学号
void Student::Input2()
{
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
	cout<<"   ";
	cin>>stunum;
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
}
//--------------------------------------------------------------------//输入修改后的班级号
void Student::Input3()
{
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
	cout<<"   ";
	cin>>clanum;
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
}
//--------------------------------------------------------------------//输入修改后的床位号
void Student::Input4()
{
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
	cout<<"   ";
	cin>>bed;
	cout<<"   ~~~~~~~~~~~~~~~"<<endl;
}
//====================================================================//输出姓名 学号 班级号
void Student::Print()
{
	cout<<stuname<<"\t"<<stunum<<"\t"<<clanum<<"\t"<<bed;
}
//====================================================================获得姓名
char* Student::Stuname()
{
 return stuname;
}
//====================================================================获得学号
char* Student::Stunum()
{
 return stunum;
}
//====================================================================获得班级号
char* Student::Clanum()
{
 return clanum;
}
//====================================================================获得床位号
int Student::Bed()
{
 return bed;
}
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
//==============================宿舍信息类=================================
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
//#include "Student.h"
#include <iostream>
using namespace std;
class sushe
{
private:
	int sunum;

public:
	int num_live; //实际住宿的人数
    static int num_contain;//可住的人数
	Student st[4];
	int Sunum();
	void Input();
	void Print();
	sushe();
	int badchazhao(int badnum);
};
sushe::sushe()
{
	sunum=0;
	num_live=0;
}

int sushe::badchazhao(int badnum)
{
	for(int i=0;i<num_live;i++)
		if(badnum==st[i].Bed())
			return i;
		cout<<"没有找到该床位！"<<endl;
		return -1;
}

int sushe::num_contain=4;
//====================================================================获得宿舍号
int sushe::Sunum()
{
	return sunum;
}
//====================================================================输入宿舍信息
void sushe::Input()
{
	cout<<"   *************************"<<endl;
	cout<<"   宿舍号:";
	cin>>sunum;
	cout<<"   可住人数:4"<<endl;
	cout<<"   实住人数:";
	cin>>num_live;
	cout<<"   *************************"<<endl;
	cout<<" 请输入他们的姓名、学号、所在班级及所在床位(床位请按顺序输入):"<<endl;
	for(int j=0;j<num_live;j++)
	{
		st[j].Input();
	}
}
//====================================================================输出宿舍信息
void sushe::Print()
{
	for(int j=0;j<num_live;j++)
	{
		cout<<"------------------------------------------------------------------------------"<<endl;
		cout<<sunum<<"\t"<<num_contain<<"\t\t"<<num_live<<"\t\t";
		st[j].Print();
		cout<<endl;
		cout<<"------------------------------------------------------------------------------"<<endl;
	}
}

//*******************************************************************************
//++++++++++++++++++++++++++++高校宿舍管理系统+++++++++++++++++++++++++++++++++//
//*******************************************************************************
//#include "sushe.h"
#include <iostream>
#include <string>
#include<fstream>
using namespace std;
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
//================================操作类===================================
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
class Operat
{
private:
	sushe su[10];
public:
	static int a;
	static int d;

	int menu_select();
	int Input();
	void Print();
	int ChaXun_sunum();
	int ChaXun_stunum();
	int Insert();
	int XiuGai();
	int Total();                           //统计所有信息
    void	ReadIn(char *filename);        //读入文件
    void WriteToFile(char*Filename);      //写出文件
	void order();
};
int Operat::a=0;                           //记录当前宿舍数,初始化宿舍号为零
int Operat::d=0;
//======================================================================主菜单
void Operat::order()
{
	int max=0,i=0;
	sushe s;
	for(int i1=0;i1<a;i1++)
	{
		max=su[i1].Sunum();
		for(int i2=i1;i2<a;i2++)
		{

			if(su[i2].Sunum()<=max)
			{
				max=su[i2].Sunum();
				i=i2;
			}

		}

//		Print();
//			cout<<"最小"<<max<<"最小"<<endl;
		if(i!=i1)
		{
//			cout<<"i "<<i<<"i1 "<<i1<<endl;

		s=su[i];
		su[i]=su[i1];
		su[i1]=s;
//			cout<<"交换后为"<<endl;
		}
	}

}

int Operat::menu_select()                              //显示主菜单
{
		int g;
	do{
		cout<<"  ***************高校宿舍管理系统******************"<<endl;
		cout<<"    请选择操作:"<<endl;
		cout<<"    1、输入档案"<<endl;
		cout<<"    2、显示所有档案"<<endl;
		cout<<"    3、查询"<<endl;
		cout<<"    4、插入新信息"<<endl;
		cout<<"    5、修改信息"<<endl;
		cout<<"    6、统计所有信息"<<endl;
		cout<<"    0、退出"<<endl;
		cout<<"  ************************************************"<<endl;
		cout<<"  请输入您的选择:(0-6)";
		cin>>g;

	}while(g>6||g<0);
	return g;//返回选择
}
//======================================================================//输入宿舍信息
int Operat::Input()
{
	int i=0;
	char sign;
	while(sign!='n'&&sign!='N')
	{
		su[a].Input();
		cout<<"   是否还要继续输入？(Y/N)";
		cin>>sign;
		i++;
		a++;
	}
	return i;
}
//======================================================================//输出宿舍信息
void Operat::Print()
{
	cout<<"------------------------------------------------------------------------------"<<endl;
	cout<<"宿舍号\t可住人数\t实住人数\t姓名\t学号\t\t班级\t床位"<<endl;
	cout<<"------------------------------------------------------------------------------"<<endl;
	for(int j=0;j<a;j++)
	{
		su[j].Print();
		cout<<"------------------------------------------------------------------------------"<<endl;
	}
	system("pause");
}
//======================================================================//按宿舍号查询
int Operat::ChaXun_sunum()
{
	int l,low=0,high=a-1,mid=(low+high)/2;
	cout<<"\t\t\t请输入要查询(修改或插入)的宿舍号:";
	cin>>l;
//	int j=1;
	while(low<=high)
	{
//		system("pause");
//		cout<<"high  "<<high<<endl;
//		cout<<"low  "<<low<<endl;
//		system("pause");

		mid=(low+high)/2;
		int i=su[mid].Sunum();

//		system("pause");
//		cout<<"i=su[mid].Sunum()  "<<i<<endl;
//		system("pause");

		if(i==l)
		{
			cout<<"\t\t\t查找成功！"<<endl;
			cout<<"------------------------------------------------------------------------------"<<endl;
			cout<<"宿舍号\t可住人数\t实住人数\t姓名\t学号\t\t班级\t床位"<<endl;
			cout<<"------------------------------------------------------------------------------"<<endl;
			su[mid].Print();

//					system("pause");

//					cout<<"返回值为  "<<mid<<endl;
//
//							system("pause");
//
			return mid;
		}
		else if(l<i)
		{
			high=mid-1;
		}
		else if(i<l)
		{
			low=mid+1;
		}

//		system("pause");
//		cout<<"high  "<<high<<endl;
//		cout<<"low  "<<low<<endl;
//		system("pause");

//		j++;
	}

		cout<<"\t\t\t对不起,没有发现您要查找的宿舍！"<<endl;

	return a;
}
//======================================================================//按学号查询
int Operat::ChaXun_stunum()
{
	char c[10];
	cout<<"\t\t\t请输入要查询的学生的学号:";
	cin>>c;
	for(int i=0;i<a;i++)
	{
		for(int j=0;j<su[i].num_live;++j)
		if(strcmp(su[i].st[j].Stunum(),c)==0)                  //C-串比较
		{
			cout<<"\t\t\t查找成功！"<<endl;
			cout<<"------------------------------------------------------------------------------"<<endl;
			cout<<"宿舍号\t可住人数\t际住人数\t姓名\t学号\t\t班级\t床位"<<endl;
			cout<<"------------------------------------------------------------------------------"<<endl;
			su[i].Print();
			return i;
		}
	}
	if(i>=a)
	{
		cout<<"\t\t\t对不起,没有发现您要查找的学生的住宿信息！"<<endl;
	}
	return i;
}
//======================================================================//插入操作
int Operat::Insert()
{
	int n,i;
	i=ChaXun_sunum();
	n=su[i].num_live;
//	cout<<"好"<<n<<"阿訇"<<endl;
	if(n>=4)
		cout<<"   对不起,该宿舍人员已满！"<<endl;
	else
	{
		cout<<"   请按提示输入您要插入的信息:"<<endl;
		if(i==a)
		{
			Input();
		}
		else
		{
			su[i].st[n].Input();
			su[i].num_live++;
		}
	}
	cout<<"------------------------------------------------------------------------------"<<endl;
	su[i].Print();
	return n;
}
//======================================================================//修改操作
int Operat::XiuGai()
{
	int k=0,e=0,f=0,badnum=0;
	do{
		cout<<"\t请输入相关操作(1、按宿舍号查询;2、按学号查询;3、修改;4、退出):";
		cin>>k;
		switch(k){
		case 1:
				d=ChaXun_sunum();
			break;
		case 2:
			    d=ChaXun_stunum();
			break;
		case 3:
			do{
				cout<<"请输入您要修改的选项(1、修改学生姓名;2、修改学号;3、修改班级号;4、退出):";
				cin>>e;
//				cout<<"好"<<d<<"好"<<endl;
				switch(e){
				case 1:
					cout<<"\t\t\t请输入要修改的学生的床位号:";
					cin>>badnum;
					f=su[d].badchazhao(badnum);
					cout<<"\t\t\t请输入修改后的姓名:"<<endl;
					su[d].st[f].Input1();
					su[d].Print();
					break;
				case 2:
					cout<<"\t\t\t请输入要修改的学生的床位号:";
					cin>>badnum;
					f=su[d].badchazhao(badnum);
					cout<<"\t\t\t请输入修改后的学号:"<<endl;
					su[d].st[f].Input2();
					su[d].Print();
					break;
				case 3:
					cout<<"\t\t\t请输入要修改的学生的床位号:";
					cin>>badnum;
					f=su[d].badchazhao(badnum);
					cout<<"\t\t\t请输入修改后的班级号:"<<endl;
					su[d].st[f].Input3();
					su[d].Print();
					break;

				case 4:
					break;
				default:
					cout<<"\t\t\t对不起,您的选择有误！"<<endl;
					continue;
					break;
				}
			}while(e>4);
			break;
		case 4:
			break;
		default:
			cout<<"\t\t\t对不起,您的输入有误！"<<endl;
			continue;
		}
	}while(k>4);
	return d;
}
//======================================================================//统计所有信息
int Operat::Total()
{
	cout<<"\t\t\t宿舍的总数为:"<<a<<endl;
	int k=0;
	for(int i=0;i<a;++i)
		k+=su[i].num_live;
	cout<<"\t\t\t所有住宿人数为:"<<k<<endl;
	return 1;
}
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
//==============================主函数=====================================
//+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
void main() //主函数
{
	Operat ss;    //定义一个operat的对象
	ss.ReadIn("宿舍管理.dat");          //读入文件
	int k=0,i=0;
	for(;;){
		switch(ss.menu_select()) //选择判断
		{
		case 1:
			cout<<"\t\t\t请按提示输入有关信息:"<<endl;
			ss.Input();
			ss.order();
			break;
	       // ofstream out("a.txt");

		case 2:
			cout<<"\t\t\t显示所有信息:"<<endl;
			ss.Print();
			break;
		case 3:
			do{
				cout<<"\t\t请选择您要查询的方式:1、按宿舍号查询;2、按学号查询;3、退出:";
				cin>>k;
				switch(k)
				{
				case 1:
					ss.ChaXun_sunum();
					break;
				case 2:
					ss.ChaXun_stunum();
					break;
				case 3:
					break;
				default:
					cout<<"\t\t\t对不起,您的选择有误！"<<endl;
					continue;

				}
			}while(k>3);
			system("pause");
			break;
		case 4:
			cout<<"\t\t\t请按提示输入您要插入的信息:"<<endl;
			ss.Insert();
			system("pause");
			ss.order();

			break;
		case 5:
			ss.XiuGai();
			system("pause");
			break;
		case 6:
			ss.Total();
			system("pause");
			break;
		case 0:
			cout<<"\t\t\t*******************"<<endl;
			cout<<"\t\t\t\t再见！"<<endl;
			cout<<"\t\t\t*******************"<<endl;
            ss.WriteToFile("宿舍管理.dat");//////////////////////////////////////////
			exit(0);

		}
	}
}

/////////////////////////////////////////////////////////////////////////////////////////////////////////////
//&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&************************************************************************
void Operat::ReadIn(char *filename)//从文件读入数据
{
	fstream file(filename,ios::in | ios::binary);
	if(!file)
	{
		cout<<"无文件:"<<filename<<'\n';
	}
	else
	{
		sushe s;
		//su[0]= new sushe;
		int m;
		file.read((char*)&m, sizeof(int));
		for(int i=0; i<m; i++)
		{
			file.read((char*)(&s), sizeof(sushe));
			su[i]=s;
			a++;
		//	s= new sushe;
		}
	//	delete s;
		file.close();
	}
}//----------------------------
void Operat::WriteToFile(char*Filename)//将链表中数据写入指定的文件
{
	int i=a;
    //int p=sizeof(sushe su[]);
	fstream file(Filename, ios::out  | ios::binary);//|ios::trunc
	//while(p)
//	{	i++;p--; }
	cout<<i<<endl;
	file.write((char*)&i, sizeof(int));//存储元素个数
	while(i>0)
	{
		file.write((char*)(this), sizeof(sushe));
		i--;
	}
	file.close();
//	cout<<"将链表中数据写入指定的二进制文件\n";
	cout.flush();////////////////////
}


:smiley: http://grammarist.com/spelling/set-up-vs-setup/ suggests one word as a noun, but I think that might actually be more common for computer things than for other things?


Always in-scope in controllers/models (This is part of web2py, like request/response/session, gluon/*)


Yeeeeah, no idea why I did that.  Will updated.


@hubertlepicki Can you try https://phoenixchat.herokuapp.com/ again? It was running a very old version of the app. I just pushed latest and all looks good on safar/chrome/ff over ssl


session is in scope already (web2py)


+This is an App of FM.


use http$ object as per latest seneca-web


records["id"]?
Sounds more like record["id"], no?


fixing


Существуют методы класса Assert, которые позволяют сравнивать double-ы с заданной точностью, здесь они были бы предпочтительнее, на мой взгляд. Кроме того, я не стала бы добавлять приватный метод, поскольку это дополнительная функциональность, а мы нацелены на проверку Calculator.NewtonRoot - лучшим решением (помогут избавиться от копи-паста) будут Data-Driven Unit Test (https://msdn.microsoft.com/en-us/library/ms182527.aspx)


Why read this & then not use it?


@chrismccord yes, this solves it. I was confused because when I pulled the code, made the commit and deployed to *my* instance of heroku it started working. But it was not thans to my commit, but thanks to newer overall version.

Please revert the commit and sorry for bothering you with this one, should have realized it ealier :)


hard coded group_id!?
No, no, no ;)


Для лучшей читаемости кода есть смысл обратить условие в if)


Changes
 - Images added for view pager controls.


D'accord je te laisserai le faire (ou non) car ça implique peut être de plus gros changements :
Typiquement, `bbl-locations.js` est fortement couplé au repository `BrownBagLunch` car toutes les images des villes se trouvent dans ce repository.

Si l'on migre `bbl-locations.js`, il faudrait peut-être aussi migrer les images, car un commit pour rajouter une ville devra se faire dans les 2 repositories.
D'ailleurs certaines photos de baggers sont des images relatives vers le 2e repo

Enfin, pendant la migration des `baggers.js` je pense qu'il y a eu quelques oublis :
* Le `js/baggers.js` du `Gruntfile.js`
* et les `<script src="baggers.js"></script>` dans `tests/baggers-rh.html` et `tests/baggers.html`.


assumes cookies, but we also want to support header tokens, and other mechanisms
this needs an abstraction layer, and an option setting


Floor21〜25の作成 #448


I didn't realise urlparse had such an awkward API. I think this code would be clearer like this:
```python
def full_url(self, endpoint):
    url = urlparse.urljoin(self.root_url, endpoint)
    params = {'token': self.auth_token, 'format': 'json'}

    url_parts = list(urlparse.urlsplit(url))

    query_dict = dict(urlparse.parse_qsl(url_parts[3]))
    url_parts[3] = urllib.urlencode(dict(query_dict, **params))

    return urlparse.urlunsplit(url_parts)
```


Have you intentionally indented this line? I thought we'd agreed not to indent this level of code.


You are right, I will fix that.


ок


all of these could have aliases from the options.urlpath


Вместо <b> используй <strong>. Тэг "b" в современном стандарте - deprecated.


> As a personal question, is there any reason for not having for instance create_edge and similar functions for both lattice and mesh objects?

Mainly a personal preference. For utility functions I tend to only factor out when I feel that such operations are needed and are used elsewhere. So the main reason is me trying to avoid creating utility functions "for consistency" without having concrete needs and use for them. I also tend to delay refactoring out early (similar to optimizing for speed early). I think that code needs to settle a little before a re-factor/optimization task is applied.


I find the naming of `no_content` very confusing but I can see that it was confusing before this change so don't think you should change it in this branch.


perhaps the stray fails that have started showing up again on the CI server are triggered by this test - the test gobbling up all of available memory doesn't seem to make the CI server happy - it seems to take longer than the test execution itself to recover sometimes


Why is the raise exception removed? This is a very critical part of the code and this is an unrecoverable error that should stop further mark processing.


bla


Для диагностики лучше использовать Stopwatch (https://msdn.microsoft.com/ru-ru/library/system.diagnostics.stopwatch(v=vs.110).aspx), и возвращать точнее ElapsedTicks


Hello Akshay,

Updated the code as per the requirement. Kindly check .


great, this helps a lot I think.


I'm not clear on why this function is being created?

The process already defined uses this method:
https://github.com/flavour/eden/blob/master/modules/s3/s3crud.py#L1902

In general, better to reuse the one method than create alternate copies around (eases maintenance, less chance of edge case bugs to creep in)


Why is the error message after the return? It will never execute this way: the code will silently fail and corrupt the data without warning.


Why all the parametrize? the id parameter should be able to convert the id to the appropriate type; if the problem is that id is nil it should be checked for that.


there's the abstraction layer - awesome!!!

however - use pattern:
role:auth,set:token,token:..
role:auth,get:token

this is more consistent with other plugins

"role" should definitely be auth as this is only to do with the auth plugin


```
}
else {
```


double semicolon


Suppression here is the correct thing.  We really do want exactly equal for bspline functions.

Good evaluation.


same here


A CMake/Configure Option for this is overkill. Users can just set the default with `set_scheduler<policy::work_sharing>()` in main if needed or use a (runtime) config file.


I extracted cookies implementation as separate plugin as an example

https://github.com/mirceaalexandru/seneca-auth-token-cookie


почему id не сделан обязательным?


Maybe these items should get the translatable flag?


Да, ты прав, сек


Why lower `z_loc` if `Z_RAISE_BEFORE_PROBING + 5 > z_loc > Z_RAISE_BEFORE_PROBING`?
What is so special about the `5` constant?


res, res should be part of the inbound seneca.fixedargs as res$, req$ - I wonder why I originally passed them in?
it would be better to pass the seneca context
putting req,res in as normal properties means they will get printed in the logs - which is not good for clarity


A better fix would be to detect PowerVR (only older devices) and turn off gl_extensions.ANY_shader_framebuffer_fetch in native/gfx_es2/gl_state.cpp .


OK to suppress here.


Already staged in the RHEL-7.2 update:
https://github.com/haraldh/dracut/commit/77ffc465b9c5615040b427dfdf35a3487ef9943c


Zero is a valid FD number. I'd suggest setting it to -1 on allocation (create_bo_handle) and checking if (handle->prime_fd < 0) here.


LGTM


As above, please use -1.
return (handle) ? handle->prime_fd : -1;


I think that maintaining the original (old) behavior as a default is the safe thing to do, and does not make the code worse.

Changing to FloatAlmostEquals when it is justified makes the code better, but it is not wrong to not do it.


And here.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 342](http://192.168.30.225:8111/viewLog.html?buildId=1627&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


The map size is only 2 if the ID is set and here the ID is needed. So it has to be 2 if I want to set the ID of an xnat object here.
Map(content) & Map(ID, content) are the possible maps.
If the map size is 1 there will happen nothing in this file.

Map(content) & Map(ID, content) are the possible maps.


No. You're right. Well spotted. I'll fix it now.


Seems like we never got to fixing libdrm_freedreno. It still has if (!bo->fd) { // assume that this is a valid FD }


@rockbot Code style preference question -

```JavaScript
subscription.privateModules = !!subscription.npm_org.match(/_private-modules/);
```
instead?


ok - we do want seneca-auth to work "out of the box"
so the simple version (cookies, headers) should be included in the main plugin
abstracted behind patterns of course


NOTE:  m_MatrixScale is in the denominator, so this is a test to avoid NaN's in the computation.

This is a case where FloatAlmostEquals would improve the logic of the code.


Add Install to readme


Please, merge this PR - this is critical :(


+1 !!!


Well, the address actually make sense. My point was it's a required field and that was not to allow to remove it.

Anyway moving the line that includes the predicate for hidden for the cause of death field should be AFTER row is added to section otherwise the EditPatientForm crash at launch, It's a weird bug and it doesn't happen in their examples, I investigated it and made much sense that is has to be AFTER the row is added to section and made an issue for it here: https://github.com/xmartlabs/XLForm/issues/414


If node is close to zero, don't push it on the list (we don't want zero elements in the nodes list).

FloatAlmostEquals would be good here.


the rendering on github does not look right. see https://github.com/dachary/teuthology/tree/wip-6502-openstack/#manual-testing-and-usage


OK


if (fd >= 0) {
As in the libdrm call we use drmIoctl(returns -1 on error), and dup (again -1 on error)


OK as ==


OK as !=


Let's name it "burnt mustard" or "scorched french-fry"! :wink:


I understand what you are saying, but I think the sentence needs to be rewritten slightly, for example: "The original file will not be updated, instead we will create a new version of the same file and update the new file instead."


Easy fix, unsure if it's been fixed already locally by @gabizou


put all requires at top of file
don't use term "config" - use "options"
rename file to default-options.js

well - I think you have invented a new convention for seneca plugins!
this is a really good idea, putting it in a different file :)


@dorfe DWMR (done with my review). All is well here. Press on!


FloatAlmostEquals


Fixed in 3bd7f11d0e70c4187c6d8d9e6fbfdc452e3aa130.


Kuddos for adding test coverage and helping limit Regressions in the future :+1:


so strategy plugins should load them selves instead by calling well-defined registration "hooks" that seneca-auth provides


Is this to get testing working? We will need to modify the .travis.yml file to download and install composer_manager ourselves then, otherwise everything will fail.


I copy wrong,correct fix should be
https://github.com/sum2012/ppsspp/commit/c6c247a2371e6e4d9578bda297ac5b73dbb69e5a.
I think I do not need shinemu test again until you (or @unknownbrackets ) change the code


This doesn't disturb our domain structure at all, as these fields are annotated as "Transient" which clearly means it is not involved in persistence.

Although, it would be wise to have such additional information in a separate entity as more additional information may be required in future(looking at the existing use case, which started with ULB and District and now require 6 more fields).


Should be this check negated?

if false === get_option site_icon then show make's favicon


Looking at the native_handle_t declaration I'm not sure why anyone would bother, yet nicely done for checking these up !


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 342](http://192.168.30.225:8111/viewLog.html?buildId=1627&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:24


Метод очень плохо читается, возможно стоит
1. изменить условие if (format == "X") на обратное
2. постараться разгрузить блок внутри try
Метод  Format  не должен содержать логику создания 16-го представления


`double_ended_queue` is optimized for hight throughput with enqueue and dequeue operations using different spinlocks to minimize interaction between sender and receiver. Combining this queue with a `std::mutex` gives you no benefit. In fact, you even *add* overhead to the one mutex you use anyway. You could use a protocol as used by `single_reader_queue` that signalizes the caller of `enqueue` whether or not the queue was empty before adding the element. This would give you the opportunity to call `condition_variable::notify_one()` only if necessary. However, this scheduler is meant for low-concurrency scenarios, so personally I would try a `std::list`-based design first, then do some benchmarking on low-end devices (e.g. Raspberry Pi) and see if it suffices before investing too dedicating more time on this.


@srimanob that's what I mentioned in chat


@al-martinez This method is missing the final closing brace ` } ` And that's causing errors.


Shouldn't this be `return this.key;` (no underscore)? You're peeking into your privates.


@al-martinez We'll cover this when we talk Monday evening.


You can always use os.path.join
In [2]: os.path.join('/a/b/', '/a/b/c.txt')
Out[2]: '/a/b/c.txt'

If the second path is absolute, it returns it.


But in general I am surprised that gfal2 doesn't take relative path. Can you check the doc and test please ?


Please add phone extension.


Один набор данных - один тест, если не хочется создавать copy-paste, то Data-Driven Tests https://msdn.microsoft.com/en-us/library/ms182527.aspx


@jeffcai, it would be great if you felt like submitting a pull request to get this back into the original project...?


>@PeterBjuhr I'm not sure if that's the right approach. It does what it suggests: deactivate the music_sync_cursor action when the document doesn't support it, but I'm not sure if this shouldn't be a property of the viewer, regardless of the file in it (and I think the music view implements this the same).

Do you mean if it should be in the parent class?

>If we'd go that way we'd have to add logic to set the option to False and should consider restoring the value upon the loading of the next document etc.

Do you mean when there is several documents in the document-chooser?


Thanks for the quick response guys, Awesome work


Isn't this overwriting `$` when `Dom7` is defined? Won't this mess with stuff outside the library?


Don\'t saving -> No saving


Can you fix the commit message to comply with the current style:  In particular you want a <= 80 characters subject line.  Something like:

```
docs: Use consistent generated ID values

This makes the output of this stylesheet reproducible across identical invocations on the same input.
```


@ashcrow Bingo! That means the registry part of tutorial is all wrong. I'll patch it.

So if I get it right. The `--mount-host` option will work only in case there's default service account with privileged SCC. Which I don't think will happen often. Does the option still make any sense? If yes, I believe we should at least check whether the active service account is privileged and fail immediately if not.


fixes ticket 3332


Account closed


Purpose?


Needed for `strncmp`


<!doctype html>
<html>
<head>
<meta charset="utf-8">
<title>a demo</title>
</head>
<body>
hahaha
</body>
</html>


update .gitignore


saw approval from bkerley
at https://github.com/basho/riak_kv/commit/bff8681d6beb9aa8252a1b3b3582c8e485562c81


merging basho/riak_kv/gg/add_ql/timeseries/tmp = bff8681d into borshop-integration-1152-gg/add_ql/timeseries/tmp


basho/riak_kv/gg/add_ql/timeseries/tmp = bff8681d merged ok, testing candidate = bfb97073


Although I will change to `cstring` for consistency.


Hey, don't forget to add this to the ports-mgmt/Makefile as well, so it gets built :)


Bikeshed: please keep the order(condition) the same in both places. The n in "ifndef" is rather easy to miss out :-)

Thanks for sticking with my suggestion and keeping the old code around. It made made me notice that i915g/ilo are broken with FDs. Seems like st/xa and st/dri could use some fixing as well.


Ist schon ne Weile her, dass ich das implementiert habe. Aber ich habe in Erinnerung, dass es mir als nicht nötig erschien, die anderen Ports (TLS & DTLS) konfigurierbar zu machen, da man für Verschlüsselung sowieso noch viele andere Dinge bräuchte.

Man könnte die zufälligen Ports abfragen und ausgeben, aber ich denke das ist unnötig, denn man braucht die Ports nur, wenn man sich direkt verbinden möchte. Und wenn man sich direkt verbinden möchte, dann konfiguriert man am besten einen festen Port, um nicht nach jedem Start kucken zu müssen, welcher Port gerade verwendet wird.


12: M102 unrecognized bullet/signature
13: M102 unrecognized bullet/signature


Any progress on this here reflexive issue?


how to run **N** workers? just start n instances of `teuthology-worker`?


i don't have `$(pwd)/teuthology/test/integration` in `$HOME`, probably you mean  `cd teuthology` before running `teuthology-suite` ?


Fixes #18


`contentOfTestHeader` -> `testHeaderContentOf`

What about length check and returning the first element or null?


Could you please use PSR-2?


But it's incompatible with std::exception.
If any body make:
```cpp
try {
    throw LoaderStateError(FileSetRuntimeError::ProjectAlreadyLoaded)'
} catch (const std::exception& err) {
    std::cerr << "Something gone wrong, error is: \"" << err.what() << "\"" << std::endl;
}
```

He will be very surprised and confused about message's informationally.


add max len


Rename link to: "Gelly: Page Rank"


Shouldn't `glu.h` be `GL/glu.h` as well?


did you remove this because it was not required?


so you had to add additional migrations to mine in order to get it work? what was your process there?


crap, i forgot -Woverloaded-virtual....

    warning: ‘virtual void CModule::OnJoin(CJoinMessage&)’ was hidden [-Woverloaded-virtual]
    warning:   by ‘virtual void CFooMod::OnJoin(const CNick&, CChan&)’ [-Woverloaded-virtual]


Rename link to: "Reply Graph Data Set" and a comment that this is the result of the Reply Graph exercise (with link)


Wappalyzer analyzes the HTML it gets from the `outerHTML` property of `document.documentElement`, which is always using double quotes for attributes. (That's the way it works in the browser extensions, at least.)


Great! I'm glad you got it sorted out!


awesome, you just have to adapt the comments, there is still "aldryn_events" mentioned


Maybe `"I" * arabic_number` would be useful here. In Ruby, multiplying strings by a number repeats them. Try it in `irb`.


how did you "generate" this part?


Hold & operate on system wide variables.
This will include real time debug toggling options, access to window properties, among other things.
Really just a place to put things that either do not belong anywhere else or could potentially be needed everywhere else.

A couple of things I plan on using it for now are with:
- #23 to control persistent main loop to avoid using GLUT's.
- Enable the user to set the title of the Window (And other properties, width, height, etc) from Implementation.c
- Collect all scattered debug variables into one place

Alternatively, it is true I could have made several managers for these things. A window manager, a debug manager, an engine manager-- but each would have been so small.

Let me know your thoughts.


This looks different logic from the method name. Does it mean that path can be "/someapp" or "someapp" or even something like: "/context/someapp" ?


I think this is a great right approach, Sparsh. You're adding scenarios, and making the algorithm more general as you go. As you observe more cases, the best code emerges. And the tests help you to refactor confidently.


It would probably be better to set it dynamically depending on user CPU, though I haven't found any "nice" way to do so yet.


Why `anil`? Why not
```xml
<security-role>
    <role-name>gooduser</role-name>
</security-role>
```


Hi Josh Bendavid,
                                                    Is there any suggestion regarding to this commit? Waiting for your reply anxiously.

Cheers,
Sarmad Masood Shaheen


Purpose of `marcus`?


yes, also flak8 says it is not used =) if that will be needed - someone else will add that.


I'm not sure whether we should rely on that: e.g. if a user has set it to `letter`, this might be off. Please just copy-paste this from your install if possible.


You should do the os.FindProcess ONLY on RegisterMachine returning an error.  Don't do it always.
If it shows no process then return nil otherwise return log the message.


I tried waht you suggest it doesn't work


Closes #3


@addyosmani I tried in IE 10 in Windows 7 and it looks fine. See this [screen shot](http://f.cl.ly/items/1O3Z0L3o330c2G3z1B1s/Screen%20Shot%202015-07-13%20at%2008.23.08.png).


Purpose?


Was this intended?


@tombatossals I think this modification creates an issue when dynamically setting the visibility (and potentially other) properties.

The point is that if you have already a registered layer

```javascript
{
   ...
   source: {
      ...
   },
   visible: true,
   ...
}
```
and you change the `visible` property, then you'll end in this line here. However, given that you compare for the inequality of the `source` property the code flow won't enter the if (where later the visibility would be set). This, because the `visible` property is a sibling of the `source` property.


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/2187


Ok! I didn't do it initially, since it is a float. I will adapt...


`python src-17-31/manage.py makemigrations --empty aldryn_jobs`

and then renamed to more appropriate name (though it can be made in the same command)
after that just almost copied migration which does exactly the same thing from aldryn-events. It should be extracted to aldryn-common or maybe to aldryn-apphooks-config because i can see  more usages of that migration and it is pretty general.


You didn't actually use this css?


wat is dit?


Too bad - I'll fix that.

However, for this use-case, S3SQLInlineLink (with widget=hierarchy) would be more appropriate anyway, right?


-1
inserted after altering the table


This fix will hopefully, sort out the metadata request timeout.

Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 552, in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/threading.py", line 505, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/home/mmphego/src/casperfpga/casperfpga/utils.py", line 199, in jobfunc
    rv = target_function[0](fpga, *target_function[1], **target_function[2])
  File "/home/mmphego/src/casperfpga/casperfpga/utils.py", line 178, in dofunc
    rv = eval('fpga.%s' % target_function[0])(*args, **kwargs)
  File "/home/mmphego/src/casperfpga/casperfpga/katcp_fpga.py", line 538, in get_system_information
    device_dict = self._read_design_info_from_host()
  File "/home/mmphego/src/casperfpga/casperfpga/katcp_fpga.py", line 485, in _read_design_info_from_host
    reply, informs = self.katcprequest(name='meta', request_timeout=self._timeout, require_ok=True)
  File "/home/mmphego/src/casperfpga/casperfpga/katcp_fpga.py", line 125, in katcprequest
    (request.name, self.host, request, reply))
KatcpRequestError: Request meta on host roach020A0A failed.
	Request: ?meta
	Reply: !meta fail Request\_meta\_timed\_out\_after\_2.069240\_seconds.


for django 1.6 and south `models = {`  is a frozen ORM, so south generates that by itself.


Great Scott! That would have been a good idea. I've updated the Makefile.


hoe doe je dat?


huh?


No idea really...what's here is working


Looks like there's an error here:
https://travis-ci.org/celery/celery/jobs/70524126#L293

self._frozen can be None, and thus not tuple expanded.


It doesn't allways consider only installed packages, so I think there should be condition


alright thanks :)


When I /start
I want him to return in Arabic

like " اهلا بك "

How do I that?


This adds back the mistakenly deleted Slovenian files.


1) Since complaint contains all the information then what is the point in
adding these kind of fields
2) What is point in creating non persisting field to create a search index,
how do we recreate the index if it get corrupted.
4) Adding such extra information will always add code clutter and confusion
at service layer and to those who is going to maintain the code.
5) As you have mentioned we will keep on adding more fields to this entity.

We should think about a non intrusive design for this, and better do not
encourage changing core domain entity to patch for other thing.

--
Thanks & Regards

Sreekanth S Nair
Java Developer
-------------------------------------------
eGovernments Foundation <http://www.egovernments.org>
Ph : 9980078913
-------------------------------------------
<http://in.linkedin.com/pub/sreekanth-s-nair/b/946/5a0/>
<https://github.com/sreekanthsnair>   <sreekanthsnair@hotmail.co.uk>
<sreekanthsnyr@gmail.com>
-------------------------------------------

On Mon, Jul 13, 2015 at 6:29 PM, Rishi <notifications@github.com> wrote:

> This doesn't disturb our domain structure at all, as these fields are
> annotated as "Transient" which clearly means it is not involved in
> persistence.
>
> Although, it would be wise to have such additional information in a
> separate entity as more additional information may be required in
> future(looking at the existing use case, which started with ULB and
> District and now require 6 more fields).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/egovernments/eGov/commit/7fbcecce6fe8cc68d6da3288109bfe4827b479a9#commitcomment-12132491>
> .
>


上面的_layout.swig加上评论之后，about、tag、categories里面都有了评论，但是貌似会跟post里面那个冲突，然后文章页打开就变成两个重复的评论栏了


Monitor sends a message to the local NC:
```Haskell
monitor' :: Identifier -> Process MonitorRef
monitor' ident = do
  monitorRef <- getMonitorRefFor ident
  sendCtrlMsg Nothing $ Monitor monitorRef
  return monitorRef
```
So I don't think you are earning any ordering guarantees.

There is one other place in tests when waiting for monitoring is [done](https://github.com/haskell-distributed/distributed-process-tests/blob/5e426233313a532c237f2b22edce5d8d1fa1b916/src/Control/Distributed/Process/Tests/CH.hs#L120).


so basically ``--empty`` did all the thing


The problem isn't gfal2 but e.g. os.path.isdir doesn't handle relative paths. And the code checks whether or not the source file/directory exists.


I don't understand what you mean here with `models = {`, whats the command process?


Elzan, kindly do not format code using your eclipse... from the above commit we could not understand which line of code you have changed.


Done.


@yardenr @gregra81 If I view this file on the web at github.com, the indentation is messed up and makes the file difficult to read, probably a tab/spaces difference. We should standardize this. I see this in other files, too.


Make it OnJoinMessage or something...
Also it will be better for modperl/modpython that way.

2015-07-13 14:19 GMT+01:00 J-P Nurmi <notifications@github.com>:

> crap, i forgot -Woverloaded-virtual....
>
> warning: ‘virtual void CModule::OnJoin(CJoinMessage&)’ was hidden [-Woverloaded-virtual]
> warning:   by ‘virtual void CFooMod::OnJoin(const CNick&, CChan&)’ [-Woverloaded-virtual]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jpnurmi/znc/commit/913798c095a202a683bb5f9cc077c5bfbc2a392b#commitcomment-12132865>
> .
>


I don't agree with this rename, at least based on the implementation. There is one `WorldProvider` per world, but this seems to imply that there is exactly one `DimensionType` for the overworld, one for the nether, one for the end, etc.


may be better so: vm.newPlaylist.addMode = !vm.newPlaylist.addMode;


@yehudasa That's right, thanks. Going to refactor this PR.


resloves #19 and #20


I came across the same problem.


Works


The path where glu.h resides does not match that: /libs/glu/include/glu.h, vs. libs/glew/include/GL/glew.h