@joncalhoun why is the JSON given as the error message? It doesn't make any sense since internally the APIError class uses the second parameter (self, the api_method instance) to get the JSON error response. Why not provide the standard "reason" from the JSON as the message for the APIError? That has been standardized in the SynapsePay API: http://synapsepay.readme.io/v2.0/docs/errors. In its current state it makes handling errors very problematic since `error.message` outputs:

```
{:reason=>"Invalid SSN information supplied", :success=>false}
```

Rather than the expected:

```
Invalid SSN information supplied
```


Yupp. This bit is not acceptable. The pointer might be uninitialized and thats ok.


I will, once I have my computer. The actual event trigger is commented out for now, so.


Nope. It still goes past 2 gigs on a video page load. This time I ran out of virtual memory at 2.8 gigs for youtube's content process. (I'm using FF nightly with e10s right now.)


The fallback to TCP was based on the logic in BIND (see link), assuming they have the field experience. My take is not that TCP is necessarily more common to support (I seriously doubt that), but that it is what we would least like to use. I.e., only if we have no other option (i.e., UDP failed) we even attempt TCP (the alternative would be to give up I guess). It could also be that some paths may struggle with UDP even though the server supports it, and TCP may have a better chance (but that is pure conjecture).


Check read and readG


I was just debugging this issue based on failing tests - no wonder I couldn't find it in the current source code. =p


alright that makes sense.


is overflow necessary if they are equal? O_o


Thanks, it was typo... I hope, i've fixed it


I don't see a reason to make the interface that complex / flexible. especially all the string allocation to handle dynamic messages.

I think it would be sufficient if the function returns a char * if an error occured and `0` is it was successful. Since these function are only called from within the rmw implementation itself it can catch the error and "enrich" the message before passing it to `rmw_set_error_string`.


This patch LGTM


Must have slipped through the cracks :cry:.

Just be careful, from what I remember, there were quite a few places where Toolbox relied on our weird JSON+HTML escaping to prevent XSS (especially in the domain tagger / usernotes stuff?) A lot of other API clients have the same problem (which admittedly was our fault in the first place.)

That was the reason I ended up adding & then commenting out https://github.com/creesch/reddit-moderator-toolbox/blob/d1bb131e33b9cb4977ad92f932ec8a354f352b13/libs/redditapi.js#L150 back in the day.


@czerasz This is for [vagrant-hosts plugin](https://github.com/oscar-stack/vagrant-hosts).  This plugin adds host entries to `/etc/hosts`.


needs to let `rm --dir` work after container has been removed.


There are a few things that we need to discuss on the ACID part.

1. I agree that we need to find a way to make certain creatures behave like target dummies
2. I agree that sometimes we need to do this from SD2 or core side. So from this point of view using NullAI is perfectly fine.
3. I am not sure, if it's the best way to have this in the ACID file. So let's discuss where is the best place to have this.


seeing as the function signature changed:

```js
if (navigator.mozCameras.getCamera.length === 1) {
  // new Promise based API
} else if (navigator.mozCameras.getCamera.length === 3) {
  // old api
}
```
Tested in 3.0 simulator and 2.0 simulator.


Hmm, I think we need to enable it now and live with the fact that demoting an admin requires doing a bunch of manual work. Otherwise, when we implement this check some day, it will immediately break existing Sandstorm instances that had admins demoted in the past, unless we do some sort of migration where we remove all unsatisfied admin requirements, which seems weird.


npm install fails:
npm install @webgap/jsonfs
npm ERR! Invalid name: "@webgap/jsonfs"

maybe it is not public?


Use: `"userIsAdmin" in requirement`

Much easier to read that way.


can you reduce the size of this method; ok if you don't know how.


Same


» There's an issues section one click away...
Yeah, sorry, I was not sure if anyone actually reads it…

Since last update (or the one before last update) FF crashes sometimes when I try to watch video on youtube, don't know what's happening. But this issue with two instances of video playing simultaneously makes me really mad.


Why not have this as self.has_cookies()?


Looking at the various call sites, it seems like throwing an exception here is not the right thing to do, and will not be handled gracefully.


missing , in the end


@simeonradivoev can you fix bug resized texture in game. I said that bug.


Some code with different results:

    2 3 # 1
    2 # i. 3 3


@TheVizzy Can you submit an issue? https://github.com/simeonradivoev/MatterOverdrive/issues/new


The problem here is the response is not 403 StatusForbidden. Instead, the server is returning 400 BadRequest. I added a test for both 403 and 404. Not much we can do about 400 though, since multiple things can return this.


Extraneous `NSLog`.


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1167 of 1167 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It is the right thing for `restoreInternal`. The only other place it's used is in admin.js, where you're right, it will bail out of the helper instead of rendering "no user" as it should. I'm loathe to change the signature just to fix it for the arguably less important use case...

I'll fix admin.js to have a try block unless you have objections.


against, not again...


1. It will print out each second that passes by until it gets to 10 secs.
2. They probably intended it to display an alert after 10 seconds.
3. The for loop goes through each second while displaying an out put instead of waiting till 10 seconds are up.
4. I would place the console.log outside the loop.


hi


Thanks @AxelNennker !
I'll revert it.


you really must have time to waste tkrokli


Can you open an issue with a bit more detail?


Sure.


Hi,
Wasn't it already the case?
And won't you lose the annotation titles if you also turn legends off?


I don't get what this is doing. Why is result being passed by reference and modified in the closure?


1. Breaking up many changes into multiple commits makes `git bisect` easier.
2. The problem is _probubly_ that line 639 never gets reached. in the case where `defaultData` **used** to be returned it now returns `undefined` because the switch statement doesn't have a `default: return defaultData` and so returns `undefined` and the `return` on line 624 means in this logical branch line 639 doesn't get reached when it did before this change.

This is in response to issue #1873.


Jo, und wo ist jetzt die weibliche Form? Hatten wir uns nicht „der Wächterin“ zugewandt?


Patch LGTM


Random comment... this is currently dead code since Drill doesn't yet support an alternative to using repeatedvarchar.


> 2) Concepts that are implementations of xCard definitions now use uppercase symbols.
Only some of the symbols have been changed. But it's a start.


Not to sound ungrateful, but will you be releasing a MountainGrowl for Growl 2.0?

I know developers need a lot of time to work, etc., I am only wondering.


Fixed.


I globally breaks melee weapons in certain cases.


TODO: Fix this mess. I just copy-pasted the `lucid` function from `Main` since I didn't know where to put it


whoops. fixed the issues in the file but have a typo in the commit message...


Ya, we should probably look at reducing/removing unnecessary static funcs here.

LGTM


Yeah, fixed that too (also spotted by @dvdhrm).


97648014-DocIssues4906 (rglazer2) - Win64-Windows-7-VisualStudio-12: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


#rienàvoiraveclecode
Hé cool, ca y est on peut utiliser Stripe en France !
Beau travail en tout cas pour l'intra !
++


Bei dieser Änderung bin ich dagegen.


You can add more tasks. Can be found here: "Tools -> Options -> Environment -> Task List".


@LorDClockaN  fix 1


@LorDClockaN  fix 2


Brain teaser of the week: Are `begin(Range)` and `end(Range)` equality preserving?


Well ... reason why I asked, for this.. is  that even if i'll add this in UDB...
Our InstallFullDB tool will install ACID  after... and if im correct here, Acid file will DROP.. all EAI scripts(and names) and use data from that file....
so.. thats why i think .."AIName" column should be filled up only by ACID.


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1167 of 1167 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


hehehe. I am lightning-fast.


Wie doch so ein kleiner Fallunterschied die Bedeutung komplett ändern kann :)


97648014-DocIssues4906 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I was trying to avoid memory allocation by allowing the caller to pass in storage, which was to support dynamically created error strings which were already there. I'll refactor it again to just return `const char *` and have completely static error messages.


OK, I guess I now have more questions than before :)

1. Why are we testing this in the ```onConnected``` method? Doesn't the mere fact that this callback was made mean that there is indeed a geocoder present?

2. Assuming that we do need to test it, is it possible that ```location == null``` and ```Geocoder.isPresent() == false```? Because if those two conditions can happen simultaneously, then no error message is being shown to the user.


The attribution information is already in the commit itself - there is no need to add it to the test content.


Yeah 400 is perfectlly fine not to handle,  but what i was looking at was the following.

For a bucket
~~~
curl -i -X HEAD https://s3.amazonaws.com/ferenginar
HTTP/1.1 403 Forbidden
x-amz-bucket-region: us-east-1
x-amz-request-id: 590553D72754F7AC
x-amz-id-2: mKlNrv3ux4MVcSwoew4bHqf6IHIxQFwrK3gSZs36DnKOr0Az9Ljt80e9PB/ORuz9
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Wed, 08 Jul 2015 22:28:51 GMT
Server: AmazonS3
~~~

or Object
~~~
curl -i -X HEAD https://s3.amazonaws.com/ferenginar/test
HTTP/1.1 403 Forbidden
x-amz-request-id: DD6ED9F53646991E
x-amz-id-2: zfnspK9zoYk+C0i8+1WXS51ngMF9EaZvbF+ECfRZ+cfcqjwnhBAqXRMDNyWE3lNv
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Wed, 08 Jul 2015 22:29:57 GMT
Server: AmazonS3
~~~

~~~
curl -i -X HEAD https://ferenginar.s3.amazonaws.com
HTTP/1.1 403 Forbidden
x-amz-bucket-region: us-east-1            ----> Very interesting new x-amz header.
x-amz-request-id: B5FE041A98C042DE
x-amz-id-2: 97ulqJfg49vLrdj3uzNvlAIHPPiqPvNZaDG4O7hX7Lb9xi1H25TIM45SwchQkrFvKQ9Pkyp8vrc=
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Wed, 08 Jul 2015 22:31:12 GMT
Server: AmazonS3
~~~

~~~
curl -i -X HEAD https://s3-us-west-2.amazonaws.com/goroutine-py
HTTP/1.1 403 Forbidden
x-amz-bucket-region: us-west-2
x-amz-request-id: F127D11E3EDD4F7C
x-amz-id-2: EGO3N5K7GuyEe2PS4ccf07ePah40E4F+lZbyt6WGl+2MKyMMIT37B4+UYZtx2ushAAq5JI9yobw=
Content-Type: application/xml
Transfer-Encoding: chunked
Date: Wed, 08 Jul 2015 22:34:21 GMT
Server: AmazonS3
~~~

So a 403 is easily plausible when the request was sent without access keys, or wrong access keys were used.


97648014-DocIssues4906 (rglazer2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Mein Highlight bisher. :)


`metaTags` sounds weird now, since this could be any kind of element now.


Certes, mais c'était le plus récent lorsque je suis tombé dessus. Il y a encore 2 jours (avant la nouvelle traduction), la phrase avec "Réfrigérant" était encore là, mais la discussion a continué après la modification, je te l'accorde.
Toutefois, je ne suis pas convaincu par la nouvelle traduction:"Elle" pour désigner "l'air" me dérange:"Les deux côtés doivent être exposés afin de permettre à l'air de circuler." Je trouve toutefois dommage la disparition du nom de l'objet, on ne sait plus trop de quoi on parle du coup: du climatiseur/système de refroidissement ou du ventilateur?


Whoa... so the `react-runtime` package brings in two copies of React, regardless of if we're in production or development? We're alright with just doubling that code?


> x-amz-bucket-region: us-east-1            ----> Very interesting new x-amz header.

Undocumented one, couldn't find it anywhere in their official docs.


It still bombs out after 10 seconds. Note: You wouldn't see it unless you do something to make the tests run longer.


I think it would be better if findAdminUserForToken() returned null or something rather than throw an exception, per the discussion of exceptions in the KJ style guide.


@RafaelC DWMR (done with my review). Press on!


I'm confused about why you made this comment here. Did we cause an issue with this commit?


Should the implementation details be ending up in the serialized code anyways? I thought in IERendering we're doing some jiggery pokery to make sure that doesn't happen, in case we want to change the implementation after the fact?


Hi, I will work on a full google-fluentd release but I did just push a new gem with this change, you can update your existing installation using:
```
/usr/sbin/google-fluentd-gem update fluent-plugin-google-cloud
service google-fluentd restart
```


You can look at this https://github.com/01org/ozone-wayland/blob/master/ui/events/window_change_observer.h

Perhaps we want to rename this interface as window_notifier as something. You can extend this to support drag drop requirements as we dont want views dependencies in events. The interface is implemented here
https://github.com/01org/ozone-wayland/blob/master/platform/window_manager_wayland.cc WindowManager Maintains a list of all open windows, this makes sure we dont unknowingly drop on a invalid/closed window.
I will add comments in u other patch where u introduced GetDragDropClientAcceleratedWidget as to how we want to implement this interface.


Yeah noticed that. I don't remember how exactly I found myself in this class :) but thought of fixing it before it manifests itself.


To avoid recompiling these regexps every time the function is called, you should move the declaration out of the function, like right after the `define(.... ` line.


Thanks!


Can you split these changes to another patch ?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.322](http://teamcity.monogame.net/viewLog.html?buildId=8579&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


You've got a space character at the end of the regexp.  Probably that shouldn't be there?  It seems more like weak latin than weak Arabic.


We want to do checks that x,y are within window bounds ?


Ideally, you should be able to do ```userOrigin.getLongitude().toString()``` but in Java ```double``` is a primitive, not an object, so you can't call methods on them, and auto-boxing to ```Double``` (which is its wrapper class) doesn't happen here. C#, unlike Java, does support auto-boxing in this scenario, so you can write expressions like ```10.toString()```

So, in conclusion, I guess this is the cleanest code you can write in Java. You can certainly write shorter code, but not necessarily more elegant or efficient (e.g. ```userOrigin.getLongitude() + ""```, but see the caveats http://stackoverflow.com/questions/5766318/converting-double-to-string)


drop this line: "use imp_db_dev;"


This is awesome! I was thinking of making some modifications like this myself yesterday.
I was wondering about more of a points based system though.
It would be great if collisions could be detected with specific bones to allow more points/damage for blows to the head for instance. Hope to dig into this a bit more at the weekend, En garde!


@peterhurford - turns out this is what we could have done! Piggybacking on the unused pref_url made it much easier. Do you guys think we should say '(EA Profile)' rather than '(Profile)'?


There's a space character at the end of the `weakLatin` regexp too.   Unintentional?


I'm going to assume it's the default install location for the `curl https://install.meteor.com/ | sh` command


Only in development.


Work on this is happening in https://github.com/sul-dlss/triannon/pull/209


For input ranges, probably not. For the others it depends on the range. E.g. a generate view would not be equality preserving of its generator function is not. (Off the top of my head.)


rax retry tests


Ah, cause there's no `prodOnly` flag like the `debugOnly` flag


Yes, soon


Thanks!

When I first stubbed out this method, I hadn't really paid attention to the complexity that I was glossing over.
I have made some tweaks around your changes and added a couple of unit tests.
Where things are a bit messy is making this work with a dict as a single argument (instead of `column_title_name=value` arguments).

I also accounted for the Python 3 support changes that Ted submitted (but I was late incorporating).


We shouldn't need this. What we need to do is add the needed apis to window delegate (I will provide a patch for this), implement it in DWRHOzone.Will get back to u on this.


Forgot a zero :(


Yeah, exactly.  We could just add one though.


can use slaveselection to determine where speedtests go by subdirs so this shuld do fine


:turtle:


^fixed but logger msgs not perfect.


@kehrwoche Fixed, thank you!


Should `bidiSupport/all` be included in `tests/unit/all`?


Niceeee


This comment should be moved to the next line since it applies to `wildProto`, not `approximator`.


hmm it is public https://www.npmjs.com/package/@webgap/jsonfs

I tested in an old machine and I guess your problem is related to the npm version you're using.

Try updating your system and then run:

```shell
curl -L https://npmjs.com/install.sh | sudo sh
```

My test:

```shell
[webgap@wnode001-webgap test]$ curl -L https://npmjs.com/install.sh | sudo sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   193  100   193    0     0    186      0  0:00:01  0:00:01 --:--:--   186
100  6239  100  6239    0     0   3423      0  0:00:01  0:00:01 --:--:--  3423
[sudo] password for webgap:
tar=/bin/tar
version:
tar (GNU tar) 1.26
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by John Gilmore and Jay Fenlason.
install npm@latest
fetching: http://registry.npmjs.org/npm/-/npm-2.12.1.tgz
unbuild npm@2.12.1
/bin/npm -> /lib/node_modules/npm/bin/npm-cli.js
npm@2.12.1 /lib/node_modules/npm
It worked
[webgap@wnode001-webgap test]$ node -v
v0.10.36
[webgap@wnode001-webgap test]$ npm -v
2.12.1
[webgap@wnode001-webgap test]$ npm install @webgap/jsonfs
@webgap/jsonfs@0.1.7 node_modules/@webgap/jsonfs
├── merge@1.2.0
├── node-uuid@1.4.3
└── chalk@0.4.0 (has-color@0.1.7, strip-ansi@0.1.1, ansi-styles@1.0.0)
[webgap@wnode001-webgap test]$
```


Oh. Actually Buildcraft pipes are separated in a different module (Buildcrafttransport). I never knew that because it wasn't showing on mc. My work was pretty much useless then i guess :\. Want me to move those texture to the right module or u want to?


Just ran across this while researching- there is a 'precise' storage class modifier, which tells the fxc to not do IEEE unsafe optimizations.

https://msdn.microsoft.com/en-us/library/windows/desktop/bb509706(v=vs.85).aspx

Not sure that would be relevant here as an alternate solution, but figured it wouldn't hurt to mention it.


Wouldn't be the worst! Analytics packages come to mind as another use case


@delynn I just pushed out v0.5.0 which will include the testStep as the fourth parameter to the action. Hopefully it will get you what you need.


[![Food vessel dou, one of a pair](http://api.artsmia.org/images/11972/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11972)


[![Food vessel dou, one of a pair](http://api.artsmia.org/images/11973/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=11973)


[![Ritual bell bo](http://api.artsmia.org/images/1139/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1139)


[![Ritual bell bo](http://api.artsmia.org/images/1142/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1142)


![captura de pantalla de 2015-07-08 18-00-41](https://cloud.githubusercontent.com/assets/11724478/8584354/45406860-259b-11e5-884f-d97281af20f8.png)


does this actually work?


I expect that autocmake users will be mostly developers which should have Git installed.


97648014-DocIssues4906 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (647 of 647 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.33%25-green.svg)


Thanks! BitHub has sent payment of  $8.86USD for this commit.


I would just leave the button alone, without "Click to deploy" title, next to the travis-ci badge


ok


@X-Savior any thoughts?


r+ if you make a PR out of this.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.322](http://teamcity.monogame.net/viewLog.html?buildId=8579&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 497, ignored: 6 Build time: 00:24:31


I think we dropped uses JSON+HTML for the very reason it's weird.

But, yeah, I'm not just gonna drop this in, I'm gonna use it to do a full audit on our API calls.  They need it anyways, and this is a great excuse to do it.


@azturner is there any reason why we (I) can't move all our various enums into the Model's namespace?  I'm trying to use the Docu tool to generate the class documentation and have run into problems with these unqualified (namespace) enum classes.


dont write this 7 times, find a better way to do this...


now only print it to the screen if its a multiple of 10


@ready no es true nunca y no entiendo el motivo


Adjacent string literals are implicitly concatenated in Python but I don't know about the relative precedence between the string format operation and the concatenation.  I assume that @darabos tested this, but we could check in the shell just to be sure.


This commit adds two interfaces to be used for AsyncPrettyPrinter. It also adds DefaultAsyncPrettyPrinterRegistry which will be used to register header name to their respective async pretty printers.


Setting actionbarController and trying to keep it in sync might lead to bugs and unexpected behaviours. ES: push a native Fragment, the actionbar will continue to trigger button press on the old controller as it's only updated by onResume of axemas Fragments, not by all fragments.

Instead of using the ``actionbarController`` variable and trying to keep it in sync, just get the ``activeFragment`` from ``NavigationSectionsManager`` and trigger ``actionbarRightButtonAction`` on its controller.


Released 0.9.7.2 today.


If `BIOSTAR_HOME` is empty on heroku, it solves the collectstatic issue, do you know why?:

```
(...)
OSError: [Errno 2] No such file or directory: '/app/pwd/biostar/static'
```

See the problem?


Hows the work going any luck?


Hey!

I'd like to use Orly for my research. I tried hard to find one of the Orly developers email, but no success! Could you please point me to one of the developers/owner email?

Thanks a lot!


Updated README pushed to npmjs


The recipe should be there now. See https://github.com/meskarune/cookbook/blob/master/crepes.md


I would appreciate it if you could move the textures to the correct module as I am a bit swamped with other projects right now. If the original BuildCraft textures have changed please feel free to overwrite my work.


We opted to show the entire response_json in case there was more context in it, and because we didn't think it really made the error less readable if you are in the console or looking at the error stack trace.

Eg if the error in the future becomes:
```ruby
{ :reason => "Invalid SSN", :field => "user[ssn]", :success => false}
```
this would be more useful than just "Invalid SSN", especially if you hadn't wrapped your error in a begin/rescue block.


YAY GEMSETS!!!


fix #7


I need more to go on if I'm going to help solve this :P


Yay postgres, Eventually you'll want to get postgres onto local environment so that your local and production will be more similar. For now sqlite3 is fine.


Committing to master without creating a develop and issue branch first, for shame. Y'all need to break them bad habits before they get to be to ingrained.

Also, pls to be following my github. I'm commenting on one commit a day until you do. That's not a threat. That's a promise. XD


Cool thanks! I do wrap the error in a begin/rescue block to handle it.


I checked with like following code.

```
def test_func(str):
  print str

test_func("hoge {0}\n"
     "fuga".format(100))
```
And I get the result as follows.

```
hoge 100
fuga
```


[Huh...](example.com)


Yup.


Yeah, most devs prob will, but when experimenting with the API (esp in console) it is less likely, and those users tend to be the ones who understand the API the least.


my bad. this was added because I wanted to be able to access organism from the parameters for gff3 exports too but it wasn't complete. pushed another change to fix that


please use Jade for templates


I got the OrbitControls file from https://gist.github.com/mrflix/8351020. I was having trouble using the full module, as it is designed as an npm module and I would prefer to avoid node and extra libraries for now.


Great clean commit. It is a good idea when you are learning to do repetition to get things solid in your brain. So I like that you set up all your basic models and started your controllers here.


please use coffeescript


I hope you changed your password.


@cmdcolin   No worries . . I already fixed it.  Feel free to close this branch unless you are doing more work on it.


Just curious why you switched the file open from append to write?


Beautiful table.


true


trailing comma


Thanks for reviewing and merging my changes, Scott.  I appreciate the help!

I apologize for not writing some unit tests myself.  This is my first project in Python, and thinking about Python 3 compatibility and unit tests are a little too much to grasp all at once.

I'll have another pull request soon to support editing a Column.  I'd appreciate you looking that over for me too.  Thanks!


1 or 2?


Hmm, I'd add everything in the parentheses as a note underneath. There should be an example somewhere above


related to the `pip` command...   the word "the" is missing.


thanks :+1:


I noticed the DC1 is off. It's firing rate should be like the lasers, not the rockets.


Ok I'll move the texture to the right place as soon as i can.


Will the copyright holder be basecamp? Note that any of the rails frameworks have basecamp as copyright holder.


cc @dhh


Do we rely on this to get next drag notification ? I mean does this result in any kind of lag as we are dependent on IPC calss.


Your revert added back this line which should be removed again to properly test implicit search.


rax retry tests


other :
- moving list's initialisation after the ctx check.


name for the Dashboard should be Ping Check


We define MIN_NEG_INT32 in prim_type.h in sphinxbase for that


What did I mess up haha ;)


This can be done when you load the model, it is not a good idea to remove symbols again and again.


This kind of error message could be improved with information from the context, like `type_name`.


fixed in 19047e9


This totally works!
There are many ways to do this.
One way to consider is:
<%= link_to 'Market', markets_path %>
Named routes are awesome and save typing. :)


Hm, this will be ugly in the follow-up patch. There dns_transaction_make_packet() depends on the destination DNS server, would need some more refactoring...


I am not sure if the error message should only contains the second line. The first line could be generated by the caller instead which then also can include more context.


Updated incorrect name for dashboard.


I love this change! While not necessary it does a good job of conforming to rails conventions


Missing newline character.


It's in the right direction!

TemporaryDirectoryForZip() doesn't return a char*.

I was thinking about something like that:

```
#ifndef __APPLE__ // will be defined in MCZipMac.mm on Apple platforms.
String * mailcore::TemporaryDirectoryForZip()
{
    char tempdir[] = "/tmp/mailcore2-XXXXXX";
    result = mkdtemp(tempdir);
    if (result == NULL) {
        return NULL;
    }
    return String::stringWithFileSystemRepresentation(tempdir);
}
#endif

String * mailcore::CreateTemporaryZipFileFromFolder(String * folder)
{
    String * tempDirectoryString = TemporaryDirectoryForZip();
    String * path = tempDirectoryString->stringByAppendingPathComponent(folder->lastPathComponent())->stringByAppendingUTF8Format(".zip");

    ErrorCode err = CreateZipFileFromFolder(path, folder);
    if (err != ErrorNone) {
        unlink(path->fileSystemRepresentation());
        unlink(tempdir);
        return NULL;
    }

    return path;
}
```

Could you make the change and test on iOS platform (simulator / device)?
And then, submit the pull request.
Submitting the pull request will try to build it for Linux.

Thanks!


Sorry. Check out PR #858 . It has additional extended tests that take over 10 seconds to complete. At around the 10 second mark an  error is thrown:

```
Testing stepper.js.................OK
Testing switch.js...OK
Testing temperature.js...............OK
Testing wii.js........OK
Testing piezo.js.....OK
Testing led.js............OK
Testing servo.js...Fatal error: Uncaught, unspecified "error" event.
Donovans-MacBook-Pro:johnny-five dtex$
```
But the error isn't coming from ```extended/servo.js``` it's being thrown by the ```explicit``` test in ```test/board.js```. The call to ```new Serialport()``` is timing out.

Sorry I was unclear. Is this helpful?


You don't really need to save `conn` here, since you're only using it once. You could directly use `new_connection`:

`Connection.new_connection.exec("SELECT ....)`


This is clean, I like this!


@DDoS

Whichever the approach, this should be unified across the API. Immutable and Mutable as children or Mutable extends Immutable? Choose one and make the changes elsewhere.


97647908-DocIssues4615 (rglazer2) - i386-Windows-7-VisualStudio-12: OK (1677 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Fix padding in `ol` list


It's generally not a good idea to convert your contact instances to strings inside of a method like `#all`, since you may conceivably want to use this method in a different situation where you're not printing them out as strings, but manipulating them in a different way.

It would be a good idea to split up this functionality then. Have this method simply return a list of Contact instances (`all_contacts`), and then convert them to strings only when you need them to be strings (so for example, in some presentation logic, just before you need to print them - line 127 for you here).


Wow, that's fine.


Is the order of your methods arbitrary? I can see class and instance methods in no particular order. It might be a good idea to write them together (for example, all the instance methods first, then all the class methods).


hey, I came across this while exploring what people are up to in their forks via the Network tab. check out https://github.com/facebook/flow/commit/444dbd08f0851f617b88ef00b141f2adc628ee59! it's not perfect, so if you're using flow on a project with symlinks, would love you to try it and file any issues you find.


Okay.  I think we should look at whether zanata-model ought to be available in GWT code (they're just POJOs after all), but not as part of a backport.

But I do think `entityId` and `entityType` should be `copiedEntityId` and `copiedEntityType`.


Oops, that's right I classified it as a "missile" instead of a "laser" internally. Quick fix underway.


Why did you delete this line? Without it there are no instructions on what to replace!


Why did you delete this line? It cuts off the sentence in the middle!


If I could +2 this I could, so I'll settle for :+1::+1:


Why did you kill these two lines? They are critical information!


Why did you kill this line?!?!?


Why was this removed?


Same with this line!


The other problem is that, I can pass the Announcements settings around from course -> A -> B -> settings. In B, I don't have the course settings. I cannot then create a Course Announcement Settings object.


LGTM


FacilityTabGridView (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


pls add doujinmoe.us/


NP,

Ursache waren zwei "" hintereinander, und evtl der doppelte Eintrag.


Ah, I wasn't really paying enough attention to the code when I copied it I guess...
I forgot to remove the os cli.


We had already decided this when first adding the buffer interfaces that this would be the standard. I adhered to the same when replacing them.


[History lesson here](http://stackoverflow.com/a/22848148/201952)


Please revert this entire change to the file. It completely shredded it! Lines are cut off. Important information is deleted. It's a mess. Please roll it back.


@kkashi01 The gcs.bucket property pre-dates the default bucket. So originally we had to manually create a bucket and have the gcs.bucket property tells us its name. So for example in our production service we are not using the default bucket, so we must use the gcs.bucket property to configure its name. If you leave it as the empty string, then we will lookup the default bucket name from the AppIdentityService and use that. If we fail to get a name from the AppIdentity service (the default bucket hasn't been created for the app) we generate an error which is logged.


97648014-DocIssues4906 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1163 of 1163 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


cherry picked

Bobby Brennan
bobby.brennan@gmail.com

On Tue, Jul 7, 2015 at 12:02 PM, Ivan Goncharov <notifications@github.com>
wrote:

> Can you merge this commit to master?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lucybot/api-spec-converter/commit/89731413306ec66edd11117d652b9228c6e8766b#commitcomment-12043943>
> .
>


That's alright but is 25 a universal frame rate? For instance, if we plug in a camera, will it still work?


As worded it sounds like a magical special case "or the recursive flag is on". How about this wording instead, to make it clearer why it works this way:

 Note that multi-threading/multi-processing is only done when the named URLs
 refer to objects, which happens either if you name specific objects or if you enumerate
 objects by using an object wildcard or specifying the acl -r flag.


DOESN'T EXCUSE THE COLONS


Yeah, sorry about that! And thanks for working through the beta issues.


What do you expect this to do? Couldn't figure out


Test1 Comment


Why do this?


llllll


Fixed in last version...


can you change `m.Source` here too?


97643186-ABUPS-total-row-not-match-water (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1684 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


>> Having bigger value may not necessarily be an advantage.

> Indeed. We don't want a too big number to limit the size of the `IN` query, but we want it large enough to limit the number of queries to the DB.

There are several things to consider:
1. Yes, in principle increasing the value *may* limit the number of round trips we do to the database (we need to instrument it to understand if that limit is actually used or if we end up being way lower because there are not enough entries in the Q)
2. The tradeoff however is that if we take too many per-thread, there is a risk of killing the level of parallelism because now all these entries are processed sequentially by that thread

So in the end, i don't know what the right value is, but this is what i mean by 'a bigger value may not necessarily be an advantage'. We need to i/ instrument and ii/ run tests with different values.


android system


@misakwa is this even allowed?


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/70000309


I would vote against using (p Point) to define the return variable here.  While it's nice, you're technically allocating a Point and not always using it (for the cases where you return nil).


send()自体が、いらないと思う。


Nope, I intentionally avoid implied multiplication because my use case is
not pure mathematical calculation.

I use your code to provide user customize-able product price function.

I review your changes and it seems improved on many sides. One huge changes
is now your repo fully support composer right? Thats cool. Two thumbs up!

And lastly, thanks for your code.. it's really helps.

On Fri, Jul 3, 2015 at 12:27 AM, Jon Lawrence <notifications@github.com>
wrote:

> Just wondering since you can have 0-9 in your variables.. does the implied
> multiplication still work? Since you removed the lazy operand, I think it
> would require a defined operator for the separation now?
>
> Side note, lots of things have been added since you forked, if you are
> interested in looking through it and adding some of the functionality to
> yours. Gamma calculations can now be done (meaning all positive real
> numbers can be used for factorials, and unlimited nesting of parenthesis
> are two from this week.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/airlanggadurenworks/EqOS/commit/09562154c4958532653c58f5d36632782f927a68#commitcomment-11980393>
> .
>


@synthesizeは書かなくても動く


I can't see this working. You are not telling it how to produce dynamic_big_crypt.o. It can't guess that from the dependency.

And actually, I think you could use the same stuff as in Makefile.in now.


Cool :-) Thanks for contributing back anyway, plenty more to do as I bet there are lots more bugs to find!


fast-forwarding master to auto = 83e73503


I'd vote against defining "err" as a return var here as well.


Why do this?


Since then you can change this to just be "return errors.New..."


BTW we must delete dynamic_big_crypt.c in "distclean" target in Makefile.in


Don't add the extra spacing in the func comment.


NO need any more


see also issue #319


missing the %v variable in Sprintf.  Running "go vet *.go" against your code caught it.


What's going on?
On Jul 7, 2015 8:31 PM, "Jeon.GyoJin" <notifications@github.com> wrote:

> hahahahah
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pcduino/c_environment/commit/9df734aaf84053ad79bc52b3a2d06acaa117bdd2#commitcomment-12052528>
> .
>


Done :+1:


Missing \param comment for new parameter


Using %v instead of specifying the type can be a lot easier, no need to worry about the type being printed, as it will (almost always) be right.


hello world


nice


>attach logging. kek


remove unnecessary comments


If you know a group is going to be a certain size, you can use the 3 param make.
make([]Point, 0, 10)
for example, will create an array of 0 size, but have capacity of 10.  Can be useful so it doesn't need to keep reallocating the array on an append.  But at the same time, for small size arrays, reallocating takes almost no time at all.


I corrected it. Still, it is a separate function because it also has the drawback of lacking a precision parameter for the returned angle.
https://github.com/gitMarky/openclonk/commit/226e97c782c131d2526f94a75848100bce59f53f


I probably would have chosen this instead: ```<{if $xo_sys_navigation|default:false}>```

That issue has shown up in lots of places, and that has been my standard fix, but isset() works, too :smiley:


For future reference:

```scala
scala.tools.nsc.util.stringFromWriter(pw => trace.p).trim
```


export file excel with many sheets


i am not sure if we need this flexibility in the ceph.spec or in debian/rules. IIUC, the intention of checking bash-completion.pc is to allow user to specify the directory to install bash-completion files using the pkg-config.

but, IMHO, this does not apply to packaging where we adhere the FHS and other well accepted standards/specification/policies (for example, the Desktop Entry Specification from freedesktop.org). in other words, the location of a certain installed file is hardwired. so we can always assume a file's location if it is installed by a package. that's why we can rely on the predefine macros for the dest directories like `_mandir` without worrying where user put the man pages.


Salt command was using a group, in case that's relevant.

comand :       salt -N group1  cmd.run "/home/test/test.sh" --batch-size=70%
result:
                     Executing run on ['192.168.3.26', '192.168.3.30']
                    192.168.3.26:
                     this is a test!
                     retcode:
                             0
                     Executing run on ['192.168.3.10']
                    192.168.3.30:
                     ----------
                     192.168.3.10:
                     ----------


@SimonDanisch I am thinking to make this easier we can switch to import everywhere so we can easily see where names are colliding. As it is I needed to remove MeshesIO.


This gives me a syntax error due to an extra ]


Why do this?


Richard, please go ahead and change it to your standard. I prefer that we use consistent ways of doing things - it's much easier then to understand the code :smiley:


test 2


![prefix](https://cloud.githubusercontent.com/assets/12292476/8562453/0693720a-2565-11e5-8c78-dd3d2b38510b.gif)
The Bug

![prefix](https://cloud.githubusercontent.com/assets/12292476/8562484/3f7c79ea-2565-11e5-8e05-93631b2eac23.gif)
After Fix


对了，这个忘记说了，是不是都统一成集体牢房比较好


Wouldn't this extend MessageTransmissionEvent?


This event should provide the original sink and the current sink.


Fixed a super dumb typo


等碰到火灾了，你就知道防火喷头有多么的重要。


参考 [这个讨论](http://steamcommunity.com/workshop/filedetails/discussion/472866886/530646080858185660/)，拘留：一般不超过十五天,是一种行政处罚。
我也觉得集体牢房比较好。


As far as I know, on the vanilla servers when you reach the max for 1 cell, you just don't gain any more mass. Unless you have proof otherwise somewhere...


Fixed this, not sure how that happened


That's a good point. URL is updated at commit e2da4927bfbb3180e9b298a67c1939f0b8b6c5c9. Thanks for pointing that out :)


it was a work in progress to stop you from plagiarism of great ideas


Cool, thanks.

What's the memory footprint look like on a worker? May be a dumb question, but have you tried running multiple workers in a single dyno? [Resque-pool](https://devcenter.heroku.com/articles/ruby-resque-pool) seems to be the preferred way, although I can't vouch for it personally.


As I read it, this catches uses of indy with other bootstrap methods, which would fall through the previous case.


Thanks for the great plugin.

I tweaked it to call an 'end' callback, for when all typing completes (providing, not infinitely looping)

here's the patch:

--- teletype.js	Wed Jul  8 04:39:51 2015
+++ teletype_.js	Wed Jul  8 03:54:26 2015
@@ -91,6 +91,10 @@
 					window.setTimeout( function() {
 						window.setTimeout( type, delay( settings.typeDelay ) );
 					}, settings.delay );
+				}else{
+						if ( typeof( settings.callbackEnd ) == 'function' ) {
+							settings.callbackEnd( letter, current, object );
+						}
 				}
 			}
 			if ( typeof( settings.callbackType ) == 'function' ) {
@@ -154,6 +158,7 @@
 		loop: 0,
 		humanise: true,
 		callbackNext: null,
		callbackType: null,
+		callbackEnd: null,
 	};
 }( jQuery ) );


getLanguageComponentInOption declared in options.h can be used. It helps you to get <LANG> component from an option string.

Look at  processAliasOption as an example.


@zhouyuan i am not sure if this fixes the issue. `-1` will be casted to `uint_8`, i.e. 255. and then it will be converted into an `int`, as a parameter of `Objecter::create_pool()`, where its value is still 255, but as an `int` this time. and it will in turn be passed to `OSDMonitor::prepare_pool_crush_ruleset()` as you put.


Why should we compare to qoh? When `quantityChange > 0`, We can always add it to the last asset. This compare fails when `quantityChange < qoh` of last asset, It will cause add up the qoh of last asset not the quantityChange.


Why do this?


added this script per @rajcz


It has been since I first did it.  I do it here, so if gcc fails or the exe won't run, that make will copy file from unused. The script is only being run if file is not there, or its out of date. This will not cause a always compile situation


This has already been tried. Several times.


added this service start script per @rajcz


It's a rails process. I've never set that up. Ideally I'd like people to be able to run this for free for personal use.


Doesn't make have rules for .c.o ?


I'm embarrassed that I never noticed this PR and the problem still existed. The python interface has since been moved from ``include/`` into ``python/``, and so I couldn't directly merge this PR. But I committed an equivalent fix:
https://github.com/elemental/Elemental/commit/c9f1b57bc57fb744099c54e6c966bfd73a45d91b


I added this space to separate the line above from the foreach block, otherwise it looks like the comment applies to the whole code block, but it really applies to just that line.


I'm not opposed to the blacklist feature, but can you add a blurb to metadata.rb corresponding to the new attribute?

Also, I'm not so hot on including the new blacklist feature in the same commit as the other stylistic changes.  (And for stylistic changes, I'd like to hear more on why you think they're important and see them changed project wide rather than piecemeal.  I'd like to minimize churn.)


This should probably move to a sub-routine, but for now I've taken the blank lines out to group this block of code together so that the reader understand that it is one thought distinct from the activity above it and below it.  Of course decomposition is a much stronger way to make that distinction, but someone times it doesn't make sense to do that.  I generally try to use new lines to break up each distinct thought of the method.


Ideally, you shouldn't have whitespace at the end of a line.


Added method to change global precision, stores value in the Global_Container


Goog catch. Thanks.


You are correct! Will update these.


The style I'd like to follow is that when an array is broken over multiple lines you leave the "array(" on the line where it is being assigned or whatever, then do one item per line, indented one level, and always with a comma at the end, including the last item.  Then put the closing ");" on it's own line like the close of a code block.  Applies to nested arrays also, though there the closing line will be "),".  It's important that you always put a comma after even the last item, so that we don't have to remember to add it if we rearrange the items or add a new one.


@misakwa i know this definitely isn't possible, need a better quick fix for cards that have "Æther" in their name.


@karlmikko I think I was mistaken about `*read-eval*`. It looks like that may only be a feature of the Clojure variant of `tools.reader`. When I compile I get

```
WARNING: Use of undeclared Var replete.core/*read-eval* at line 41 /Users/mfikes/Projects/replete/ClojureScript/replete/src/replete/core.cljs
```

And prefixing it with the namespace alias `r/*read-eval*` will just cause it to complain about the lack of `cljs.tools.reader/*read-eval*`. So, I think the binding part can be dropped. What do you think?


Why do this?


/me reverts.


+1 looking forward to seeing how this pans out. I'm looking into doing my first React / Famous project in the near future.

Seems I'm coming in at the right time as Famous just did a major rewrite.


I get a crash here where `view` is an RCTView. I can reliably repro but don't have an isolated example yet.


ä missing at Qstring tA[]


A little hacky, but LGTM


I think you should hide the detail of appending ".jpg" before passing to this function. also, why not use word `upload`? does it have to be a jpg?


@jpdesigndev It's in pending mode right now as there are still unresolved issues in engine itself to support clean integrations. As of now you can still use this WIP as a convenience abstraction on top of react to build Famous scene graphs.


first commit


it should be a `path`


Removed the "X time ago" on the views. The idea is to show the latest podcast update.


use default coverage report format. travis can handle that. (no more xunit)


=> neglects


=> instantiating


just found a small typo by accident: "The are more options that can be provided" I guess it should be "There are more options"


I initially thought this had to read "shouldn't" instead of "should". Hence the change


cc/ @ItsMeAndrew

It shows unless you explicitly set it not too. I can image 99% of the time the grid will include some sort of dates


We have theoretically lost watching the environment file, but I have yet to see Salt do the right thing when it comes to restarting services (particularly on systemd), so LGTM.


cc/ @ItsMeAndrew


is the response json a File?

I think it may be better not polluting Client with non system function, and the url and file name should only be a part of File? ```
extension File {
    func upload(contentOfFile: NSData, closure: File? -> Void) {
        Client.request ...
    }
}
```


realmente no es necesario una sincronizacion en los votos, en el unico caso en q se requiere es cuando se vota mediante el npc y el mismo lo quiere visualizar dentro de un html luego de ejecutar el voto....ya q es el unico caso es q es accedido desde otro thread, por eso solo sincronize el metodo para obtener los votos y no perder rendimiento en las demas acciones


Welcome back :wink:


if it is a URL, use NSURL. also the file data can be retrieved by path or URL, so `contentOfFile: NSData` can be omitted then.


is there a reason why we don't define io.cattle.platform.core.addon.ServiceUpgrade in import?


why was this needed? i thought your last commit (937894c28e3af7070400f9f60312aca1575673d0) seemed better (although I haven't tested either yet).


This function should be moved to be above `is-readable?`, which uses it. Otherwise you get
```
WARNING: Use of undeclared Var replete.core/repl-read-string at line 41 /Users/mfikes/Projects/replete/ClojureScript/replete/src/replete/core.cljs
```


Эти поля надо сделать приватными и добавить для них публичный геттер.


CollectionView should just be adding/removing to the ContainerView to match the underlying content, it should not be destroying children while looping over childViews. This fix may solve this test but it does not solve the issue.


@pilwon Ah, I see. Perhaps by the time I make it back around things will have shaped up a bit more. Otherwise, I'll dig in as well. In any case, thanks for the hard work you're putting into this integration work. It looks promising thus far.


Ah.  So we can remove that now


Should add canceling-upgrade to the list of start states


@markturansky, Why do we have to change it to `dockerfile/nginx`. It seems my cluster cannot pull this image. Thanks.


ok


Hello,

I think you could capture the arguments sent to utils.log via arguments, so he could receive more than one parameter resembling a real console.log.

Thus:

```js
exports.log = function () {
    if (!comander.quiet) console.log(arguments);
}
```


Good point, that change was a hack and not adequate; fixed in commit #a10ff82.


Good idea! Removing MeshIO is fine by me right now :)
On 7 Jul 2015 20:31, "Steve Kelly" <notifications@github.com> wrote:

> @SimonDanisch <https://github.com/SimonDanisch> I am thinking to make
> this easier we can switch to import everywhere so we can easily see where
> names are colliding. As it is I needed to remove MeshesIO.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JuliaGeometry/Meshes.jl/commit/3b6aa46154a684dd20ec76851199241ffb9abc73#commitcomment-12052984>
> .
>


r+


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/2fc6f0479c6cfd7716a9049632631de078449d58


merging graydon/stellar-core/bug-257-collapse-duplicate-entries-in-buckets = 2fc6f047 into auto


graydon/stellar-core/bug-257-collapse-duplicate-entries-in-buckets = 2fc6f047 merged ok, testing candidate = 1424af8d


Is "not nullable" flag in addOn for the IntervalMillis implies that this parameter is required? If not, there is a chance for NPE here


While you created a proper button, you added it to the wrong view controller. See the assignment description:

    "Add a button to the upper-right corner of the full screen view controller"


This won't compile because you didn't create the activityVC


Need to ensure this is initial metadata - no point adding this metadata to the trailers.
Right now the best way to do this is to keep a flag on call_data (seen_initial_metadata) - I think it's a common enough pattern that that need will go away 'soon', but not yet - I want the current round of refactorings to settle.


I'd call out the break; here, and below the NO_OP... it doesn't hurt the generated code and is a little easier to scan quickly


probably break; here too - easier to scan quickly than a single semi-colon


You hooked up the gesture recognizer correctly but now you're doing the exact same that you also do in tapFired:. Instead you want to be downloading the media image. The Datasource class already has a method to download the image. You could call it directly from here.


cute, but probably better to take a few more lines and write out an if/else:

```
if (did_compress) {
  finish_compressed_sopb(send_ops, elem);
} else {
  finish_not_compressed_sopb(send_ops, elem);
}


@Gambini007 Sure thing! Here it is: https://dl.dropboxusercontent.com/u/21757911/vbsp-funcdetailblocker.zip


any special reason for choosing this over beberlei/assert - just curios


This wasn't even need in Pre 0.1


I usually prefer '!= 0' to !! because I've had to explain the latter idiom once too often


Here we return true when service-to-upgrade is removed, but we call updateLinks, preceding doUpgrade(), w/o this check? Meaning that the service links would get created for the removed service. Is it the plan to not prevent from upgrading to the removed service (harmless, but meaningless)?


INFO was a local function in the boot file, thus could not be called by the global shutdown function.
(Info isn't a callable function, thus crashing the system)


There was supposed to be less inside this commit, sorry.


This is similar to the above, only SaveHash was a local variable in the boot file where RitLock is located.
(SaveHash wasn't set globally, thus the global shutdown command saw it as unset)


Thanks :p I'll add


I don't quite follow what you mean, should I move all of this to the debugRender method?


'__RitLock___Save___Hash___Value_' is a global variable that should be called by shutdown.
(The global shutdown sees '__RitLock___Save___Hash___Value_' set, and will use it)


RitLock would cause the system to crash if it was not to shutdown fast enough after deleting the backup files.
(RitLock would still run even after the backup files were removed, thus causing it to crash the system when attempting to read a non-existent file)


Epic readme!


" RitLock would cause the system to crash if it was not to shutdown fast enough after deleting the backup files.
(RitLock would still run even after the backup files were removed, thus causing it to crash the system when attempting to read a non-existent file) "


이부분 아직 처리안된부분이라 추후 커밋하겠습니다.


따로 이슈를 만들어서 처리하겠습니다.


This variable was needed to be global, therefore to avoid interference,  '__RitLock___Save___Hash___Value_' was used.
(The SaveHash value was needed for both the global shutdown and restart)


so your first version of this was correct :)


thanks. looks like the correct API is to use object::computeSymbolSizes, and iterate over that result instead of `obj.symbols()` http://llvm.org/docs/doxygen/html/namespacellvm_1_1object.html#aca696f32a2d376d424a8defd14db9041

@Keno FYI.


This change is due to the install script.
(Nothing important)


Is there a particular reason why we call service.activate, and then fix the scale  only to call activate again (from within changeScale)? Any implications of dropping lines 117 and 118?


Before your commits :

1. The following tests where not working yet :
TestCodeElements.Check_EntryCodeElements();
TestParser.Check_ParserIntegration();

2. BUT the two tests above where working perfectly fine :
TestCodeElements.Check_NOTCodeElements();
TestCodeElements.Check_ONCodeElements();

You did something in you commits that broke thèses two tests, they should not be commented out.


File was not removed before upload.


File was not removed before upload.
This was a test of the RitoOS API


File was not removed before upload.
Sample file


현재 파라미터 타입이 Iterator 인터페이스 타입아닌가요? EventScene이라는 구체적인 타입을 말씀하는 것인지요?


Line was not removed before upload.
Testing the recovery mode


Mojor update. From what I can remember and see, re-wrote most everything.


第二天的作业（刚刚上传的时候有问题）


nvm, the field also has a default value


I know that error messages can change over time, so we might have to maintain the tests accordingly, but we still should check that a meaningful error message is produced by the parser in this case.
If we want the message to be more explicit, we can allow literals as 2nd operand in the grammar, and produced a specially designed error message when the parser recognizes this case.
It's very important to produce good error message, as helping the developer is the very reason we started to build this compiler in the beginning.


Shouldn't that be ```return sigil.copy()``` ?


Haha... I killed my old blog - and this was the only piece of content I wanted to keep alive. Figured this would be the best place for it.


I needed to list all services available in the container. So I took this file from the sf project and added the sf header for license issues. I do not remember if I changed something. I think this is the file from the last sf version at the time of the commit.

The problem is that this command is in the FrameworkBundle. It is kind of overkill to add a dependency to this bundle for this command only.


익명 내부 클래스의 경우 이벤트 작업이 완료되면 각 클래스별로 모아서 처리할 예정입니다.


You could even take the StringBuilder as an input parameter of the Dump method, and avoid the ToString() call below. The StringBuilder is really useful when used inside a loop.


The type of the key to this Dictionary should really be SymbolReference instead of Token


@taherismail, please make sure you always have a blank line at the end of the file.


It's never been in there? How strange......


You could use `Option::map`, just do `id: id.map(|i| i.to_json())`.


I don't know if this will be necessary eventually because the session table is just a temporary solution. I want to make it more attractive eventually.


MACアドレスの場合は左辺を変換し、
IPアドレスの場合は右辺を変換しておりますが、
期待値(本来の正解値)は左辺、右辺のどちらなのでしょうか？
期待値はなるべく変換せず、そのまま比較対象にできると良いと思いました。


@femee24 y? we have proxy servers cache these links right?


Acked-by: scui@redhat.com


lol 9.4.7.r2


'local repo items' uses local connection so i dont think its necessary to cache it :)


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/70009321


the two line are transferred to jeff.pp on my latest commit :D


:+1: okies


sample code review comment


Never forget: 104.97%


This class and the addon have the same name...  writers block.


I think this mod Will be the best


Is there any particular reason why you are reversing a well-established interface? I would prefer:

`virtual void copy(void* out, const void* in)=0;`


fast-forwarding master to auto = 1424af8d


This is a repo for COURSERA's "The Data Scientist's Toolbox.'


df


rax retry tests


bu  bols   sinaq   tima


:+1: @allucardster :beers:


I think it seeming rude is less bad than suggesting to install old version of ZNC with all the security issues it has.


Hmm. So if a person installs both a comparator and a copier for "MyClass", you'll get two nodes with the name "MyClass". How do you plan to hande that situation when searching?


Yeah, not a lint fix. Intellij really wanted it to have that title.


Misc @paulp utils FTW!


what is this doing here?


Good point, I should check removed earlier


these aren't quite the friendly `id`'s i had in mind, why not just `is-member-of`?


> Dann würde ich sie "amtlicherGemeindeschlüssel" und "regionalschlüssel" nennen. Ich denke wir sollten die Begriffe nicht ins englische übersetzen, da es feststehende Begriffe sind.

Auch aus internationaler Sicht finde ich das ok - obwohl ich grundsätzlich englische Bezeichnungen besser finde. "regionalKey", "germanRegionalKey" oder "germanRegionalschlüssel" fände ich jedenfalls schlechter.

Es gibt zweifellos in vielen Ländern nationale numerische oder andere Identifikationssysteme oder Notationen für Gebiete, Gebietskörperschaften u.dgl. Gelegentlich gibt es sogar mehr als ein System (z.B. eines aus der statistischen Welt und eines zur Abbildung von Regierungsstrukturen und eines aus dem Bibliothekswesen, eines aus der Archivwelt ...). Die Konvergenz solcher Systeme schreitet zwar voran, aber das ist ein (nicht einfacher) Prozess der sich über einige Jahre hinziehen wird.

> Wäre es nicht besser, eine Dictionary-Eigenschaft zu haben, die Bezeichner und Wert von (zusätzlichen) IDs wie diesen erfasst? Das würde einerseits die Notwendigkeit eines deutschen Bezeichners eliminieren, andererseits aber auch genug Flexibilität bieten, um die verschiedenen regionalen Systeme zu unterstützen.

Aus LD-Sicht würde das die Sache nicht vereinfachen, sondern eher komplizierter machen. Ein JSON-Dokument ist ja bereits ein Dictionary. Darin kann man beliebige zusätzliche Schlüssel/Wert-Paare aufnehmen.


The intention of 117 and 118 is just to ensure that things have "settled" before continuing on.  We could have slept 30 minutes and there is now some services in a funky state.


:tada: Thanks!


This fixes a non-issue; libgen.h is already included via ptrash.h.
Use autotools(1) OR -> $ cc -o ptrash ptrash.c ptrashdb.c -I. -D_GNU_SOURCE to build the ptrash binary.

Thank you.


@rashtao these git commits are associated to `michele.rastelli@jamgling.com`, which github doesn't recognize, you'll want to associate the email to your github account so the contributor creds link back to you (you may also want to change your local git config settings to point to your primary email address).


What's the SESE property?


> If you want to set error level, you can start line with <3>

Wow, I didn't knew of that feature !
Control of the identifier is lost, but the error message is easy to understand.

```
 else:
-    cat = Popen(['systemd-cat', '-t', 'systemd-cron', '-p', 'err'], stdin=PIPE)
-    cat.communicate(bytes("can't send error mail for %s without a MTA" % job, 'UTF-8'))
+    print("<3>can't send error mail for %s without a MTA" % job)
     exit(0)

systemd-run --user ./src/bin/mail_on_failure.py test
Running as unit run-13249.service.
tchet@antec:~/git/systemd-cron$ journalctl -n 3
-- Logs begin at mer 2015-07-08 07:11:46 CEST, end at mer 2015-07-08 07:41:04 CEST. --
jui 08 07:41:04 antec systemd[12422]: Started /home/tchet/git/systemd-cron/./src/bin/mail_on_failure.py test.
jui 08 07:41:04 antec systemd[12422]: Starting /home/tchet/git/systemd-cron/./src/bin/mail_on_failure.py test...
jui 08 07:41:04 antec mail_on_failure.py[13250]: can't send error mail for test without a MTA
```

"can't send error mail for test without a MTA" comes in red.


that's cool :+1:


what is this for?? remove!


Not that I disagree, but is there a specific reason for this commit ? What advantage do we have versus the 'if (db)' stuff ?


OK pass


YEAAHH!!!! that's coorect:+1:


This would make it easier to work with only the keyboard while working on the exercises and needing to reference the Schema. Thank you for the great site.


decorator の方が意図が明確になります。

```python
@momoize
def tsp(p, v):
   ....


Why commented out?


so now you can remove this `if ` when you have a range attribute


Comment and code do not match


Instead of creating a new shape renderer you can use the one that was initialized by the scene, which passes it down through the parameters of the debugRender method. Make sure to override Entity.shouldDebugRender and return true so that the debugRender method is called every frame.

You don't necessarily have to put all of the code inside of the debugRender method (just the stuff that uses the shapeRenderer), but you might as well


Use pydoc instead of a comment


Ah, thanks.


Ah, I see. Clever. I wrote a test to break your code and I couldn't :)


lalala


Yeah, with `RunWithFakeThreshold`.


this id is not pretty enough :)


dp という略称も、このあたりの code も、 競技プログラミングになじみがある人にしか伝わらないと思いますので、微妙なラインな気がします。
他の stepper が見た場合、意図が伝わらないかも。


Nit on code style: I would keep this method short by having all non-trivial update paths moved to their own method (e.g., _update_list, ...)


please remove code.


he-he, what about range attribute?


ahhh... so wrong, we don't want use context in controllers any more.


idinax


Hi @kenton ,

Hope this note finds you well. I just wanted to do a quick check-in and follow up on the solution I sent a few days back.

I would love to give you a quick walk-through over a Skype call to discuss the next steps and answer any questions. What would be a best time to connect?

Looking forward to hear from you.

Thanks,


() の中なので、行末のバックスラッシュいらないです。


The title of the commit doesn't look like it's correct... or is it?


Du coup, le nom d'utilisateur peut contenir un espace ?


membership and set links are confusing to name since they actually are the same concept but we split them into two separate relationships. possible options that come to mind (including what we've used in the past):

membership:
- member <link> group
  - `belongs-to`
  - `is-member-of`
- group <link> member
  - `includes`
  - `has-member`

set:
- subgroup <link> parent-group
  - `is-part-of`
  - `is-subgroup-of`
- parent-group <link> subgroup
  - `contains`
  - `has-subgroup`

i'm most keen on the `is` and `has` versions (`is-member-of` + `has-member`; `is-subgroup-of` + `has-subgroup`), i have no empirical data but intuition tells me these would be well-understood names for these relationships.


I only just now noticed that you are dropping these corosync/pacemaker specific "ha-cluster" scripts.  I am using corosync+pacemaker for my cluster and am using your ocf metadataserver script.  But I did not use your lizardfs-cluster-manager "wizard" script, rather I manually configured the corosync/pacemaker services and configurations.  With that said, I do agree that they are not very user friendly.  I'm still at a lose for how it is supposed to coldboot/bootstrap/initialize the lizard cluster, I just haphazardly manage to bring it online.  I would love an explanation about how this was supposed to work.

I also notice that there is an error in the ocf metadataserver script which would prevent it from working properly without patching that error. Perhaps this was intentional in order to prevent the less motivated from using this method and getting into trouble...

I also learned that the way the Debian7 distributes corosync and pacemaker is not compatible with the way your ha-cluster scripts expect those services to behave and interact.  So I have a set of sed commands which fix the stock corosync and pacemaker services such that they work as expected.

In my experience my corosync/pacemaker driven ha-cluster had been very reliable (with the bootstrapping exception).  I can confidently reboot any member of the cluster at will without worrying about the effects which are imperceptible.  I'm still working on migrating two moosefs systems to lizardfs, but I would really like to have automatic failover, so for the moment I intend to continue to use corosync+pacemaker.

I understand your dropping this stuff, but it appears that you kept the ha-cluster-managed personality for the master service intact?  Which I expect needs to stay in place regardless of which type of ha cluster technology you end up using.  I sort of expected LizardFS to remain semi failover technique agnostic such that one might use carp, or corosync/pacemaker, or any number of raft implementations.  Can you speak to that point?  I see mention of uraft, but would appreciate pointers to exactly what that is.


左辺が変換後の値、右辺が期待値ですね。
となると、期待値を変換してしまっているのは
eq_(action.nw_addr, _ipv4_to_int(act["nw_src"]))
側ですね。
> 期待値はなるべく変換せず、そのまま比較対象にできると良いと思いました。
確かにそのとおりですね。
to_actionの変換処理の中でint_to_ipv4しているので
テスト処理の中で文字列にもどして比較するように修正してみます。


````
if v[0] > x[0]:
    v = x
````


[Here's a gist of what I'm talking about](https://gist.github.com/BrianErikson/ffd94c37f91061280719.js)


Was it intended that this limits the background to just the text instead of the whole line?


remember to redirect to Error page


What is this for exactly?


发


@ytokas
please review the changes


发阿飞的


I don't like name `GetIdFromRequest`, what id? recruiterId? candidateId? my id?


Yes you are right, no way for obusing, though it seemed possible to me at first.
Checked php-src and http://www.tutorialspoint.com/c_standard_library/c_function_tolower.htm

Will return that back.


I took a stab at setting up resque-pool. My heaven setup isn't sufficient to really say it was tested. But I made a PR for it anyway if you want to take a look.


この関数だけを見た場合、何をしたいのかさっぱりわからないので、`min0` じゃなくて、もっとよい名前が必要です。


sss


in C# we use capital letter for every method name

GetAuthManager()


min0 がこのtsp_dp1 の中だけでしか使用していないのなら、この関数内で定義してもよいかも。
モジュールレベルで定義する必要性があまりない気が。


This is not refactoring. The commit message erroneously indicates that the change is refactoring.


yes, everyone in our project knows about it


`1e300` が複数回登場しているので、わかりやすい名前をつけたほうがいいかも。


if you know why haven't you make it correct?


fyi, there won't be a `1.23` package anyway; there's a `CABALVER=head` package though that's supposed to work together w/ `GHCVER=head`


I do not plan to fix the commit message.

Moral of the story: Perhaps it's not a good idea to reuse terminal command history, without fully deleting the commit message...


@ss23: I copied an existing cache-related build task as a base, and this was part of it. I suspect it's there for when the developer doesn't have direct crontab access (e.g. CWP, Platform) but wants to be able to disable the task.


I'm not 100% this is the right call here... get_by_link says it returns SiteTree objects, but what if we've published /SiteTreePage/actionOnSiteTree? Will this work as we expect for this task? A common thing is /paginated-page/1 for pagination when doing static publishing, etc.


showing profile in case of errors is not good enough, It'll be better to show what exactly went wrong.


Yes, not entirely satisfied with this patch


A bug was identified during LQA with French where using `parse()` was causing the subject lines to look like this: `Félicitations pour votre nouveau wikia Jsutterfield Wiki !`.

This had to do with the French subject lines which have a space before the exclamation point (eg, `Félicitations pour votre nouveau wikia $1 !`). The parser was looking at that and converting that last space to a non-breaking white space (` ` is the numeric reference for the entity reference ` `) since it assumes you'd want the exclamation point on the same line as the sentence that it's making exciting. Converting these calls to `->text()` fixes that.


Show and hide don't seem to be working. You can tell because when you open the chat window you still see the black stripes.


この関数は以下と同等でしょうか？
addrconv.ipv4.text_to_bin()


The compilation error has been fixed from String to Object mapping.
Please update your wrapper to continue the services.


I would prefer if ```filePath``` would not already include a slash but I'll add a check :)


One of the fields has wrong value - you say something is wrong, but exactly? in case of big profile user can just lost himself on page with such error


So here's the catch.

Repository is just a storage for persisting entities.
It's single responsibility is to store Entity and retrun Entity by some criteria. (Btw I got really good way of hadling criteria queries via Specification pattern).

I'm breaking a bit it's responsibility by adding it ability to create blank Entity. Some factory should do that. It's lesser evil though as we need model inside controller, otherwise we will end up in
1) Either making custom controllers with custom methods for each resource
2) Or adding EntityFactory to constructor (maybe we should go like that thoug it's another constructor injection)


엉 근데 이거 araplus가 아니고 sparcssso였네
여기는 그냥 araplus랑 똑같이 설정해뒀어요


maybe it's just me. but in my case, osxfuse.pkg installs the header files into `/usr/local/include/osxfuse/`, so would be better to locate the osxfuse headers in configure script, and define `LIBFUSE_CFLAGS` accordingly.
```
libclient_fuse_la_CXXFLAGS = ${AM_CXXFLAGS} $(LIBFUSE_CFLAGS)
```

but i am very happy with this patch and the branch. at least i can compile the tree with

```
make -j4 CXXFLAGS="-Wall -g -D_GLIBCXX_USE_CXX11_ABI=0 -I/usr/local/include/osxfuse/"
```

to compile on my mac.


I've experimented a bit further with some redesign, but eventually I took a different approach instead of working further on this SQI fork.

Initially I looked into SQI because it has a fairly good interface for querying, and it seemed suitable to make available as part of scripting support for SMW. And in the scripting extension I work on, [PhpTags SMW](https://www.mediawiki.org/wiki/Extension:PhpTags_SMW), there's support for your old SQI version. (That extension adds SMW things to [PhpTags](https://www.mediawiki.org/wiki/Extension:PhpTags), which provides a PHP-like scripting language inside a wiki.)

I wanted to extend functionality: recursive querying, building graph data structures of page relationships, etc., and also adding semantic data to the current page. But eventually I had different ideas for how querying might be done, and it also seemed best to implement it directly in the scripting extension.

SQI does querying in a very straightforward way - and it's been useful to look at to better understand how querying can work - but I think it's a bit inflexible, and extending it would mean reinventing a lot of things. So a new idea is this:

A result format can be made which allows accessing the query results through PHP, and then re-"printing" them with any result formats. (This might become the first "meta result format" for SMW.) The result could also be turned into an array, similar to in SQI or perhaps a slightly different format.

Then, some class to construct a query, a bit like the SQI class, can be made. The main difference would be that querying is done using the new result format, and all code to handle the result would be elsewhere.

Then recursive querying could be built on top of this.

Finally, a different way of constructing a query could also be added: a nested array format for conditions. Classes could do conversion both to and from SMW's query description objects. (In turn, this means conversion to and from SMW query strings is then also possible.)

However, I've not yet been able to put all the time needed into this, and the ideas have also only gradually developed. So currently, I only have a bunch of half-finished code for several of the things above. If/when developed further, the current plan is to add the classes that implement it directly to PhpTags SMW, though they could also be used in other extensions (either copying them or accessing them directly when PhpTags SMW is installed).


「dp といえば、ビット演算」というのが定番なので、ビット演算でもOKなのですけど、ビット演算を使わないで、よりわかりやすい抽象的なデータ構造を使用してもいいかも。bitsets のようなものあれば。

まあ、ほとんどの人は、dp のコードを見るときは、ビット演算が使用されていても違和感がなく見れるので、いいのですけど、強い理由がない限りは、避けたほうが無難です。

dp であることは、その強い理由のひとつとは思いますけど。:)


What do you mean?


![](http://images.akamai.steamusercontent.com/ugc/692776302216820893/376EC84F0700D37F76481D29F97108AE74BF62A4/)
这一段对应的是【部署】里的这几个按钮，我觉得翻译成巡逻队不太合适


i = 0, j = 0 の初期化必要ない？
106行目、直接、0 を使用していいかと。


Yes. That's C++/Java but not Ruby!


Here I'm thinking of the way to make routes for entity.
Me can do that with http://lumen.laravel.com/docs/routing#named-routes

So the only thing me need to decide is how to handle that.
If not to look at this code now we got 2 places where we assaing path to the entity.
1) router
2) model

I think we can do it like
$app->get('/entities', ['as'=>SomeNamespace\TestEntity::class,'uses'=>'App\Http\Controllers\TestController@getAll']);

And then to get the route via
route(get_class($model),['id'=>$model->id])


you can change from GPL ?


Was it intended that this limits the background to just the text instead of the whole line? I think it looks much cleaner the way I had it initially, and gives the benefit of making the sender's name easier to read as well as the text.


なんか、無駄感が強いので、直接、iterate すればよい気がします。
\\\
for i1 in list1:
     for i2 in list2):
         dis = math.sqrt(i1[0] - i2[0]) ** 2 + (i1[1] - i2[1]) ** 2)
         if dis < min_dis:
              min_dis = dis


Makes sense, missed that =)
Will fix


厳密に PEP8 に従うならば、 演算子の両側にはスペースをいれたほうがよいです。
たぶん、スタイルチェッカーに通すと、このあたり、全部怒られます。

```group_num = (point_size / 20) + 1```


Single entry single exit.


We should try to avoid adding dependancies of the application into service.
It's called Service Locator and considered to be antipattern.
Instead of injectiong the full Dependancy injection container we can add only what it really needs.


我觉得还是饮食良好比较好，毕竟是提供最丰盛的食物才能得到这个状态，不仅仅是吃饱了这么简单


I would also suggest onHurt(), onHurtByNPC(int ID), onHurtByPlayer(), onStomp(), onHurtByMelee(), onHurtByBlock() and similar algoithm events to describe NPC`s reaction on getting damaged by various dangers


why do you need a delay of 60 seconds after package is already done and before starting ONOS? May be you intended to add delay before main.step( "Start ONOS cli" ) correct?


@JerryCai We can exclude certain plugin IDs from the update center. Do you want `ssh2easy-plugin` removed?

Also, could you tell me how this repo was created? Whoever did this forgot the `-plugin` suffix.


hoge


embrace the named params, don't fight them.


`g = 0` 必要ないです。


You don't really have to remove the controllers view yourself. UIKit does this for you, depending on the presentationStyle.

And also you shouldn't use the viewControllers view property directly for that matter. Thats, what @albertschulz 's PR was about. Since iOS 8 the view Controllers are wrapped in some sort of transitioning container view.

Thats why you should use [transitioningContext viewForKey:] instead of accessing the controller's view directly. Removing the view from the transitioning container view can lead to black screens, when you return from the ModalController.


`s = 1` で十分？


You are right. It could also be a png ... or in a later stage, any NSData? However Parse implemented image-uploads differently from other file uploads ...


このあたりも、list の各item は直接、iterate しましょう。
```
for g1 in group_lists[:-1]:
    ....
```

こまかい、範囲チェックは私はしていないですけど、

```
```


Why do this?


@ytokas  please review


I did not understand this one. I tried just putting the filename there, did not work. What is the path? It is not used ... is it?


Sounds good ... however, should be a class func.
The response of the Parse call is the URL at which the image can be downloaded. This is not a File, however, it can be createf drom it, as the File is the URL and a separate filename.


See https://support.google.com/mail/answer/10313?hl=en&ctx=mail


@rapperskull could you confirm that awk still works with this?


if count == 0:
    break


I have a case where I need to be able to delete the cache dir, 3.0.0 has public deleteCacheDir, but this changes it to private. Is this intentional?


I wanted to commend you for the effort you've put into coming up with a good readme and hence a good documentation. It's quite extensive and well-written - kudos! :smiley: :+1:


I have the dependency with path-util already


If we can find a way to phrase it in less technical language, it'd be nice
to convey the message that such a control structure is "closed" somehow.

On Wed, Jul 8, 2015 at 8:19 AM, JF Bastien <notifications@github.com> wrote:

> Single entry single exit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WebAssembly/design/commit/83677951a31b98cfb6196e8959ccccede119fe2c#commitcomment-12054283>
> .
>


In the case the mentioner put in these comments, how do you process it?
For example:
1. John post new activity
2. Add John add the comment and mentioner to @Mary both of them
3. Deletes the comment
Expectation: The mentioner (@Mary) MUST be removed the activity out.


지적 감사합니다.


Hi Martijn van Dijk

Started looking at the Windows Store Presenter and Example again. There are very many issues and I have resolved quite a few. I think the best way to document them would be in a PR describing the reason for each change, which possibly only the reviewer would be interested in reading.

Not finished yet, I may not finish tonight and in that case you will not get the PR for 24 hours.

Once that pull is done, the next involves getting a simple c# ViewModel and matching View into all 4 targets, but that should be quite easy.


This could use ``os.path.join()`` which I'd like better than the concatenation, but both work for me.


Cory deleted a node.


Out of curiosity, why have you used a map<map> instead of only 1 map with a prefix on the items ? Do you think a map<map> is better than harcoding 4 maps ?


ごちゃごちゃ感がつよいので、

```python
def d(i, j):
   return dist[path[i]][path[j]]
```

のようなローカル関数をこの関数内に定義して、それを使用してもよいかも。

```python
l1 = d(i0, i)
l2 = d(i, i1)
...
```
のほうが見やすいし、間違いに気づきやすいです。


This should probably defined somewhere above as a "constant" with some explanation. And shouldn't it be '21.0' now?


Thanks for the test. I have uploaded a new "master" version which should
fix this.

--
-- Matthias Urlichs


this could be inlined, no ?


@Kubik-Rubik any reason to not commit the doc block change form: https://github.com/joomla/joomla-cms/pull/6234/files


Oh yes, it does. So how is it now, provide some examples please


Thanks!


オススメはしないですけど、一行で書きたいなら
```python
i0 = (i + size - 1) % size
```

とかがあります。


Checks if RitLock is even enabled before copying files from it.


AFAIK, the location of the bash completion files is not defined by FHS. Without this patch, the build would fail as 'make install' installs the bash completion files to the location where pkg-config points to (and that is no longer /etc/bash_completion.d/). Also if we changed the location and hard-coded it to the new one (/usr/share/bash-completion/completions/) then we would lose backwards compatibility with older bashes.

We should also stop marking these as config files as the bash completion files are no longer marked that way (and imo they never should have been). I'll revise the patch.


Bedrock API wasn't used here.


Since you forced $entryDistribution to be EntryDistribution in the method signature and you didn't allow null as default value, you can be sure that $entryDistribution is not null here, no need to validate it.


If there is no user, force the creation of one.


No longer needed as a user is forced to be created.


You don't need `FlexibleInstances` or `StandaloneDeriving`. See below


@peyerluk I currently have no assets.basePath in the design.json. We still need that, right?


Testing out comments...


@teward will the world Pleeease help? ;)


I think naming these two with UPPERCASE letters would help to make things clearer in places where they're used.


closes  #1


I did that at first, but it got in the way when I wanted to only (and simply) cleanup the video user settings for instance.
I would have had to check each parameters manually for the prefix and it wasn't elegant.


yep :) I'll add that.


You can put `deriving (Data)` even for types that take parameters. Incidentally, we should probably derive Typeable too for all the syntax types.
```
deriving (Eq, Read, Show, Functor, Foldable, Traversable, Data, Typeable)
```


These two should also be defined as "constants" with UPPERCASE names and the ``module_updates_dir`` should use the ``KERNELVER`` constant instead of ``os.uname()[2]``


左辺（変換後の値）をIPnetworkで変換するよう修正してみました。

https://github.com/takahashiminoru/ryu/commit/852157b31f9a00cd8bc4dfb12d2b5144685cab3c


Why not to use python here?


Why can't I see these commits in the code view?


そういえば、ここ
```python
    for i in range(N):
        for j in range(N):
            dist[i][j] = dist[j][i] = distance(cities[i], cities[j])
```
じゃなくて、
```python
    for i in range(N):
        for j in range(N):
            dist[i][j] = distance(cities[i], cities[j])
```
または
```python
    for i in range(N):
        for j in range(i, N):
            dist[i][j] = dist[j][i] = distance(cities[i], cities[j])
```
でよかった気がする...。もともとのcode、修正しておきます...。m(__)m


Same here.


And here (``shutil.copy2`` as long as ``shutil`` could go to the initrd.img)


FYI, this is a really really bad idea, this causes explosions, and can break other economy plugins.

This was added mainly for testing, and should never be used on a production server.


ここだけ変数名が大文字なのは違和感が。`graph` で。


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 116](https://teamcity.labkey.org/viewLog.html?buildId=259720&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 1 Build time: 00:02:52
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.initializationError: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

```


just delete the line, don't leave comments laying around.


Дефолтный роут air


tryrtyrtyrty


Нужно делать через обсервер на не через роллбек


Will the Startup.cs API experience changes be made by the end of this week?


Why not ``open(filename).readlines()``?


@chelmuth: please add to staging, in case this is ok for base-linux to implement it empty


We typically split 'active' config file settings into two 'getters' and add the setting to reload.  This seems to slightly reduce lag when settings are being read 'often'.  See the other 50 examples in this file.


That would have it break if the prefix URL is a different one. I have to get webassets to rewrite that path instead. I thought I'd taken care of that, but of course, what I did was only to rewrite less imports, not the other URLs too.


Should be 'DD' here instead of 'LSV'


Why not

```js
// 1. modify the parameters of the search..
'code example'

// 2. ...
'code example'

// 3...

'code example'
```

This would have been less of a headache than trying to inline <pre>```js code ```</pre> in a markdown list

YAY!


This could use a generator expression instead of constructing the temporary list.


backup


You can annotate a mandatory property with `@Mandatory`


add comment


I always find that firing other plugin commands, is best done as a scheduled task, rather than blocking ess until the command completes.
This also seems to fix confusing errors when the resulting command throws stack traces, and it shows as an ess stack trace.


Ajout du fichier test.hrml


'showError' already throws stack trace...


Ok nice to hear! I'll wait for that then.


Yes, it's just a matter of time. I'm not satisfied by the state of this state either.
I'll customize these errors soon !


you missed the delete key here :wink:


This is kind of the shortest possible message chain. Wouldn't it be cleaner to replace this by a simple `receive`?


@jushe
Why do you make the `ClearPiece` function as the member of `Map`?


heh
I guess I was a little *too* atomic on this commit ¯\_(ツ)_/¯


Would be nice to have a unit test for this one


前端有如此高的评价，心里还是蛮激动的
朝着方向努力吧


Okay!!!! :D


Oy. hahaha


Oops.... I have no idea what I was thinking


I'd appreciate to see ``4 * ' '`` here instead of having to count the spaces manually.


I think this looks good.   I will hopefully be able to merge tomorrow.


Very minor comment: may be better to make it `is_irreducible(mc::MarkovChain) = is_strongly_connected(DiGraph(mc.p))` to be consistent?


FYI, just a cname, it was so we could 'kill switch' metrics remotely.


Why do this?


Added a new line


For me it worked just fine; but I only tested active menu. What is your use case?


The 'missing mandatory feature' message also appears when using WizardConfig.


Thanks! :)


Unit tests for this feature would also be nice.


There is an additional $ for $uri_noext and also format the white space around things such as assignments etc... as it's best we stick to the conventions of CI3


if variable 'numSamples' and 'numMapTasks' are int type,than the result of 'numSamples / numMapTasks' must be an integer ,it makes no sense of Math.ceil function


good point, I see. For my part, when it is a fixed number of maps like this, I usually prefer to use a vector<map> instead of map<map>. But I don't think it is worth changing.


Please update the [API documentation for third party panels](https://django-debug-toolbar.readthedocs.org/en/1.3.2/panels.html#api-for-third-party-panels) as well.


should be done now.


good ^^


@NobodysNightmare fixed in 851f23712fc67e10b73dbd5b8eab9f151458da52


[OT] nit: might want to pass the `auth.protocol` to `ms_deliver_verify_authorizer()` instead of wiring it to `CEPH_AUTH_NONE`. and reutrn right away if `ms_deliver_verify_authorizer()` returns false.

yes, this does not make any difference, since `AuthNoneAuthorizer`'s `protocol` is always `CEPH_AUTH_NONE`. just for semantical correctness.


Done.


Dne.


Please put strings "https://engine.elixir-idp.ics.muni.cz/authentication/idp/metadata", "@elixir-europe.org" and "login-namespace:elixir-persistent" at the beginning of the class as constants.


I think we should go the mysqli_set_charset route then (even though we don't use the real_escape() functions)


Gotta admit I saw this one coming hehe. Done.


I could use and enum indeed. Ok, let me do that for my next PR. It's a small change. :)
Hopefully, there will be a surprise with it. ;)


`old` should probably be renamed to `base` here, and elsewhere too as appropriate.

`that there is a regression` should probably be changed to `that the indicated performance difference statistically meaningful`.


!!1one

Done.


I'm all for fixing randomly failing tests and I'm grateful that you're fixing my mess, but that solution looks a bit fragile. Just `INVALID_PROFILER_FUNC = '_lsprof.Profiler'` would be more robust already.


teasing ? ^^


Our bindings generator can bind to most c++ classes as long as you're not using templates. (and if you use templates, you can use them if you only use them for types)


et tu changes pas de code côté backend ??


Wrong issue link @desandro!


Could we also add this to export (and test it): ```
````
const fs = {
  open: B.promisify(_fs.open),
  close: B.promisify(_fs.close),
   ...
};
```
Feel like we are duplicating this everywhere.


:cry:


Me? Never.


You said that what I need to change is add the function as the member of Map.
@Wafer-Li


This would be a BC for existing adoptions of this library. I think this should be optional.
And how about other validations? Size? Extension?
Also be aware that we can not trust mime type specified in this file parameter.
Maybe we could just add a callback function which would do all custom validation you need? Because we can not cover all the cases.


I'm thinking about out-of-bounds test hoisting which wants to move the constant addition after the test and into the load.


In general, it'd probably been better to separate the actual changes from the refarctoring, but this is small enough...


for #127 OSX


Поговорили и решили поменять опять на очередь, но в самой фабрике заменить счетчик месяцев на месяц постройки. Сравнивать с текущим месяцем.


what is the significance of this line change? altering it may adversely affect legacy plugins that rely on the commands.register() decorator - since the original assumption that a call to it will only register a user-level command


attr_accessor :headers, :table
attr_reader :row_count, :col_count


This is the line that has me worried the most. The way I read it, this would be the first (in many cases public) IP address of the host machine. But what if incoming traffic through the NIC is subject to a very restrictive firewall? Or if my physical network is IPv6 only? Or if I'm not connected to any network at all just now? Or if my weak WiFi connection suddenly goes down while I'm taking screenshots? I'd prefer to keep the IP address of any physical NIC out of the loop.


row_idx1 ..row_idx2 => row_idx1..row_idx2


a distinct or filter would be necessary here as you will have the vertex itself several times in there.


In general I agree on the interface. The only point of discussion I see is whether the neighbors method is directly included in the DiscreteDomain trait (which forces you to implement the empty neighbors method in the UnstructuredPointsDomain trait), or if it shouldn't be in a separate trait (e.g. GraphDomain) that gets mixed in for meshes and images. The advantage of the second would be that it is clearer to extend the trait by adding shortestPathMethods, geodesicDistanceMethods, etc ..


А зачем генерировать айдишник игроку, это для локального сервера только? А то на глобальном все в базе данных лежит.

Как тогда коннектится игрок, если ему айдишник выдается, когда его объектное представление создается в сессии?


Уберем. Сессия у нас будет контроллером, а рынок это как бы игрок.

У нас рулсет хранится в сессии, пусть она и рулит всем.


This is merged upstream - d6a3afab1.


def fill_json_from_config(file_name = Dir.pwd + File::SEPARATOR + 'config.json')


Looks good to me. Did you test it?

Your commit message should have more information, though, and should contain something like "Fixes #1591" in the text, so that we get a nice clickable link to the original issue, and github can magically close #1591 once you push this.


IMO if would be easiest/best to do have nixos VM. We can also easily rig up node as daemon/service. What do you think of that?


href=""/auth"" => "/auth"


File::SEPARATOR


Yuo


Hi


There's currently no argument to `read_spss` that preserves `NA`s when loading the data, right?


For once, the wiki is ahead of the core. The new stats system for damage is not yet effective.
It is effective in core for health/mana stats and only for creatures marked as OK by DB developers.

Thus, for damage stats, we need to set correct min/max and other values to ensure that the core calculates correct values in-game.

Once we move to the new damage stats system core-side, only the DamageMultiplier will be used, though the other values will be nice to have as safety check or at least for information purpose. And the wiki recommends so.


OK, I will take it.


TeamCity NEventStore :: SQL :: Build [Build 6.1.0-PullRequest.10+5](http://build.prxm.it:8811/viewLog.html?buildId=3357&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:56


Don't upload docs to Rust CI, I meant to say.


多个mapreduce工作的时候，前一reduce的输出是上一个map的输入，reduce的输出value不是Text类型时，应该用SequenceFileInput(output)Format.class,一个reduce对应多个mapper输入时，应用 MultipleInputs。这个核心就是用共现矩阵的i列向量乘上用户的i向量


yes, the next is five.


Si mais ça peut pas commencer ou finir par un espace


全体的に読みやすく、スタイルも統一されていて、とても助かりました。:)


Ok yea I see your thinking, however there is one issue that a restful API might have multiple (redundant) routes to the same entity. This isn't as bad as it might sound; a good example would be with a one-to-one relationship where the entity is can be defined in terms of it's relationship, eg `UserCredentials` only relates to one `User` so the client should be able to access the model from `/user/{userId}/user-credentials`, but it might also be accessible directly from `/user-credentials`.


this is comment on a line of code.


I give you a quick answer yesterday, maybe I was tired. Is it not better to use the fTimeRemaining on the timer bar instead of the message bar ? or both ?


遵循CC协议


If you wanted to duplicate my approach with the random port number, you'd use [`PublishAllPorts`](https://docs.docker.com/docker/reference/api/docker_remote_api_v1.15/index.html#start-a-container) (equivalent to `-P`) followed by [`container.inspect`](https://docs.docker.com/docker/reference/api/docker_remote_api_v1.15/index.html#inspect-a-container) to identify the port bindings which are actually being used. Using `node-openport` would leave you subject to rare race conditions, since there is a delay between checking for an open port and actually opening that port yourself.


Hi Günter,
Thank you for all these explanations. The conclusion is that it is impossible to do such a deduplication with MF/Metamorph.
I would just need one precision: you mean that the "unique"-function doesn't work [here] (https://github.com/linked-swissbib/mfWorkflows/commit/007a41f53709cb34b4cd1d0b330a10f100ba5b84#diff-ca9fab3ce406e91c37774d8ba92e7af1R28) because there has been a "postprocess"-function before? The postprocess transform a literal into a non-literal?
Because I thought that the [source="@key"] (https://github.com/linked-swissbib/mfWorkflows/commit/007a41f53709cb34b4cd1d0b330a10f100ba5b84#diff-ca9fab3ce406e91c37774d8ba92e7af1R25) would also be considered as a simple literal by the "unique"-function...
But indeed, it still doesn't work.