Keep the closing paren on the last argument rather than wrapping it


Unfortunately, I wasn't able to test it, so this migration can possibly have some bugs.


We should try to make this generic as I can also use this for my page.


Ingestion rate averages ~50K rows/second on a laptop with 2.3GHz i7 and 8GB of RAM. Uses ~500MB of RAM.


RIP something went wrong


Now I can see this case, but there are others, like `$scope.id` when we already have `$scope.project.id`


rename to blueacorn_ajaxproductcompare


ack, that looks good.


Yeah. I have no idea why the 'path' code was here. I removed it because there is no 'demo.warning.filepath' in the localization strings, so 'path' is always null. It is from some very old code that I think @ctsims wrote.


should be nvabar


Excellent, @garyrussell !
Don't we have the same issue with SFTP too?


Ankur, a number of the issues you had (equation formatting, stepping back through figures) go away if you 'knit' the document in RStudio.  The equations are in Latex format and are rendered when the file is knit. That's about the only thing that the Github view isn't rendering automatically.

FYI, you can scroll forward and backwards through plots by using the arrow icons at the top of the Plots window.

I didn't have them plot the data first because they will do a bunch of that early this week. But easily added.

Yeah, I should explain the "No AQ" and "No ACi" warnings -- what's happening is that it processes the ACi file first and doesn't find any AQ data in that file, and then it processes the AQ file second and doesn't find any ACi data. Overall these warnings can be ignored and I'll add a note to that effect.


this is a form, not a button... and why are you wrapping around frag? also the return type is wrong..


Think I fucked up in the merge


cleanup_unit_test (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (727 of 727 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.03%25-green.svg)


why don't you replace it in this line and the others too?


cleanup_unit_test (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1759 of 1759 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Looks like there is lots of duplication here calling $$('.sidebar .actions...'). Why not call select on the container $$('.sidebar .actions').select('a')?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 173](https://teamcity.labkey.org/viewLog.html?buildId=261697&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 0 Build time: 00:07:26
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


OK


No; I didn't feel it necessary to duplicate the tests in SFTP this time since we're mocking the session to simulate the failures.


Very nice use of pre-existing Magento functionality.


They're different ... this is the object path, that is the bus name
These need not be universally same - hence im a little reluctant to do that


I think it's saver to not go the "take everything and exclude" way, we might end up serving temporary/generated stuff, can't you simply take coalib and bears packages and subpackages?


Why not create a layout file that targets this specific route and instead call getBlock() on layout object?


This should go away.


Also,this uses `/` that uses `.` ... i could do a replace ... but still reluctant


Can you explain what is happening here?


@jramapuram Wouldn't this cause in loosing precision for floating point types ?


This is incorrect. Will yield "0.75%" instead of "75%".


Same issue as above for %


Che, esto funciona? tenia entendido que el sizeof te da el tamaño en bytes, no el tamaño del array.


Needs to be divided by 100


I'd rather see an IAnnotationAwarePentahoMetadataDomainRepostitory with store/load/has annotation methods. PentahoMetadataDomainRepository can implement this interface directly.


Create a method in class that is private that is called _isEnabled() this should eliminate some of the duplicated helper method calls across your three functions.


```python
return response.status_code == 200
```


Is there any python style rule against it? Otherwise, it's a minor change that can be done.


so then we want a Constants.DBUS_OBJECT_NAME too?


how about DBUS_NAME or DBUS_BUS_NAME to make clear that this is dbus specific?


should be navbar


@ldoktor the commits are in the correct order, github just likes to show commits on a seemingly random order (I can't figure why they do that for the life of me).


What if I called turn() twice, would it go from right - left - right?


This var should be instantiated outside of dom:loaded to allow it to be public to the window.


@theengineear is this what you had in mind about making just one create_ohlc ?


Could the `(success, result)` be some thing like the type `ConcurrentResult = collections.namedtuple("ConcurrentResult", ['success', 'result_or_exc'])` or would that change the semantics or the return value too much?


Attention : si `&` apparait dans un accord (géré par le paquet LaTeX songs), tout va bien. S'il apparait ailleurs, ça va poser problème (c'est un caractère réservé en LaTeX).


that was my initial thought. but I was trying to avoid adding another interface for PentahoMetadataDomainRepository to implement. But if you're okay with adding an interface, I can do that instead..


hey @marcioj, can you make an issue on https://github.com/jayphelps/graffiti, with a copy of your component class definition so I can reproduce? thanks!


I thought BUS_NAME was sufficiently clear - I'll do DBUS_NAME if you think
its confusing.

Also,the OBJECT_PATH is not being reused anywhere else - so, that's why I
didnt want to make it into constants. The bus name is needed to make dbus
service files

On Mon, Jul 20, 2015 at 11:07 PM, Lasse Schuirmann <notifications@github.com
> wrote:

> how about DBUS_NAME or DBUS_BUS_NAME to make clear that this is dbus
> specific?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/5b9818b17cba77b66ad2dd9287cfcf5e308ce8eb#commitcomment-12257963>
> .
>


Write unit tests to verify your Bug.java code


tested, the player not teleport ...


Feel free to add things to them.  For example, I completely forgot to say anything about braces.

And, we need to describe the sections that we want to have in the target platforms' documents.


This fixes issue 23.


Ha, I just fixed this in my PR - time to rebase!


Extra import


Is this a form? Will you be adding a button to it. What is this form for?


Oh woops, good catch. I thought that was the ptr param. Will in a push.


Adding window.js here but calling fancyBox in js.


what if I have a house number to be "33 1/2"?


First commit


Why did you turn them to json from serialize?


if my zip code is 00335, would your output display "00335" or "335"?


and you used the correct tyrgettype in sai and the correct effectindex in spell_target_position?


Sure


This prevents the undesirable behavior described in #52. I am going to merge this and close #52.


Phase 2
Conditioning
Cutting Drills
Road to happiness


public class Address


write unit tests for your class


Old autotest code. I never actually tested it. It's quite surprising there arm is nowhere to be seem in /proc/cpuinfo.


will roll out to play soon


Careful in the heat-bring water


public class Letter.
Class name is always capitalized in the first letter


The point of the original was that you can do `/places/nearby` or `/places/search`


No me da 5 minutos para hacer mi presentación


effectindex = 0 ?


I believe the exit can be removed too, because it will never get executed.


The code below this line duplicates the code above this line. I think, they should be factored out into a separate function.


Looks like `Printable` has been deprecated and changed into `CustomStringConvertible`. As `NSObject` already implements  this protocol, there's no need to declare it. Overridden `description` property.


`FieldName` should be camelCased here => `fieldName`


Fixed in commit https://github.com/CUTR-at-USF/onebusaway-application-modules/commit/b610d986a645c4dddf6d01177321b79002e4f343#diff-905837ad77d25451c46d1ab5a58d9148R23


indentation


yes, will file a pull request tomorrow. Have one more item that I am working on, and maybe we could bundle all three to one pull request.


fyi error is this:

    src/data/mod.rs:124:58: 124:75 error: illegal cast; cast through an integer first: `bool` as `f64`
    src/data/mod.rs:124                     af_constant(&mut temp as MutAfArray, *self as c_double,
                                                                                ^~~~~~~~~~~~~~~~~
    src/data/mod.rs:117:1: 132:2 note: in expansion of cnst!
    src/data/mod.rs:136:1: 136:16 note: expansion site


it should be ldflags instead of ldflags... will send a v2 fixing so...


Checking function by analyzing its func_name() is 1. Slow and 2. Not how the rest of the codebase does it.
Why not make Item_func_year::functype() return a special constant and check for that constant?


Minor nitpick: Should be `def create_payload(user)` with parens around the arguments.


also here...


Fancy


lulz


This will not work when the game is running outside of you dev env, use access transformers to make this public and it will run just fine and save you using reflection.


This could probably check the last element of `self._results_queue` for failure? Then there's no need for have a special variable for the lists implementation. This looks kind of funny though:

```python
if not self._results_queue[-1][1][0] and self._fail_fast:
   pass # raise error
```
That's a lot of indices though. Maybe using a named tuple for the result part will make that a bit clearer?


pushed to fast to master
@yhwu could you please check this commit 28df850ab4b8c1a4ae0d0e8e680f127dbcafacd4


Nitpick: I'm guessing this was meant to say "should remove **an** object[...]".


Queries that use "Range checked for each record" can run range optimizer O(#enumerated_rows) times.  If we allocate something on param->old_root every time, we will use O(#enumerated_rows) memory. This is bad.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.775.2e6cf055efc92e2821399e3b79bf5a7547485826](http://build.palaso.org/viewLog.html?buildId=59837&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 380, ignored: 3 Build time: 00:02:38


FixCopyrights (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1755 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


In this case I wanted a mutable reference-type good old class. `name` gets mutated though the initializer. Didn't want to confuse the reader with Structs and value types: one Playground, one main idea


I don't think this needs to be added --- we're not even supplying instructions for setting up sqlite, so it's just extra/confusing info.


Line 60:

```js
$description.html(),
```

Will return a string. I assume later on we set the html of the info panel to that string. Unfortunately, all of our events will be lost because we're essentially mounting a "copy" of `$description` instead of `$description` itself.

If we can somehow pass the jQuery object (just `$description`) in and *append* that to the info panel (instead of setting its `.html()`), we should be good. Make sense?


Does singularity not specify those dependencies properly?


This was recorded from the ground on a phone then, correct?


I had to define it to get bundler to install the gems correctly.


The schema is on the classpath. I'm using IDEA as well and it picked it up just fine. I guess if auto-complete isn't working, just view the schema:
https://github.com/vt-middleware/ldaptive/blob/69b607aeda57ef79d154c9f71f844a1773540e11/beans/src/main/resources/org/ldaptive/beans/spring/spring-ext.xsd


For real life scenarios, I don't think this is a good idea to tell the user "oh, you have unlocked first code". You only tell them if it is unlocked when they ask(in real life it will be pull the lock).


Yes that is correct.


Thanks for this suggestion Sarah!  If these docs were just displayed via GitHub this anchor-link nav would be great, but we are porting these docs into the modern.ie site and there is a side nav set up that already does this job for us. You can see it here: http://dev.modern.ie/platform/documentation/f12-devtools-guide/  Please keep 'em coming though! REALLY appreciate your input.


Yeah, I changed fonts and wallpaper.  Commented out stuff so I have options, but don't have to retype stuff.


HI Edgar,

Thanks - bundling together is a good idea.

Howard

2015-07-20 11:47 GMT-06:00 Edgar Gabriel <notifications@github.com>:

> yes, will file a pull request tomorrow. Have one more item that I am
> working on, and maybe we could bundle all three to one pull request.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/open-mpi/ompi/commit/b484784dca723b9bd8cc3b10fec94474cbb4b123#commitcomment-12258150>
> .
>


Wouldn't it be nicer to break the lines here? Something like this maybe?:
```ruby
if request.format != 'json' &&
    response.status.to_s[0..2] == '200' &&
    response.headers['Content-Type'] !~ /.*\/json/i &&
    response.headers['Content-Disposition'] != 'attachment'
```


My aim here was to be consistent with established usage. Unfortunately, that's not consistent with itself! The [how-to documentation](https://confluence.lsstcorp.org/display/DM/How+to+document+a+Task) and [examples](https://github.com/lsst/pipe_tasks/blob/66f227f8924a01fa8161b69f0b7eb041d2c681e7/python/lsst/pipe/tasks/exampleCmdLineTask.py#L54) uses `\` to prefix Doxygen commands; the [other markup](https://github.com/lsst/meas_base/blob/f3abd3c241559e832f89f600186ff1a9926aefd4/python/lsst/meas/base/sfm.py#L161) in `SingleFrameMeasurementTask` uses `@`.

I note that in at least one place I managed to combine `\` and `@` in the same block, so I'll at least fix that and take another pass through with an eye for consistency.

I didn't realise that `@` was preferred to `\` -- do you have a reference for that? I'll check the coding standard...


how about
```java
this.dial = (this.dial + ticks) mod 40
```


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.776.a441367504d0a89ecfbe218508ef115d269564b6](http://build.palaso.org/viewLog.html?buildId=59838&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 380, ignored: 3 Build time: 00:02:41


Does this mean that the client might lock for 5 seconds on startup?


@pavanky Jason mistook it for a pointer variable. He is going to fix this soon.


Same as above: in this case prefer regular reference type class with mutable fields


I thought that was the case but I was getting redirected back to the login page when trying to use those three urls. I've just went back and changed them and they seem to be working fine now so I don't know what the problem was before, I'll push the original again


See comments below.

I believe your shouldUnlock method should not need any parameters.


An initializer getting also the city?


Not sure if your approach would work, nice try though. This is a tricky object to design.

Think about combo lock in real life. You have a lock, and provided with 3 secrets to unlock.
You can only unlock the lock by strictly follow the sequence of
- turn right
- to code 1
- turn left
- to code 2
- turn right
- to code 3

even if the user get 3 codes right, but did not follow the order of the directions, the lock won't unlock.


here's the exception -- keep this `org.fcrepo.kernel`


Also, write unit tests for your class


Great! Thank you!


Slugs should only contain only letters, numbers, underscores or hyphens (no spaces) so I don't think changing the name to a slug here is the best approach.  If you want to use a slug to make the url pretty, add an additional slug field and logic to slugify the name when the Community object is created/updated.


see above about keeping this as `org.fcrepo.kernel`


Thank you for explaining.  *Very* last comment, I promise.  Just for
consideration.. no need to respond.

I'm huge on your concept of SplitDefendeRs and SplitDefendeD enemy pieces.
What do you think of a nested additional bonus for attacking *both* a
SplitDefendeR and a SplitDefendeD?  I tried it with pre C++ source and it
looks somewhat promising locally. (Excuse the renaming and non-use of &= ,
it helped my process.)

        weakDefendeD = pos.pieces(Them)
                & ei.attackedBy[Us][ALL_PIECES]
                & ~pos.pieces(Them, PAWN)
                & ~pos.pieces(Them, KING)      // Thanks for your comment,
I will remove this
                & ~ei.attackedBy[Them][AT_LEAST_2]
                & ei.splitDefendeds[Them];

        if (weakDefendeD) {
            // Check if indeed some are defended by a single defender
           b = ei.splitDefenders[Them];

            if (b) {

   // **We've established that we are attacking a splitdefendeD enemy
piece. Give an extra bonus if we are also attacking a SplitdefendeR  **//
             weakDefendeRs = b & ei.attackedBy[Us][ALL_PIECES] ;
               if (weakDefendeRs)
                   score+= TacticalBonus;
                    }

            while (b)  {
               Square s = pop_lsb(&b);
               if (more_than_one(pos.attacks_from(pos.piece_on(s), s) &
weakDefendeD))
                            score += TacticalBonus;
                   }
           }

On Sun, Jul 19, 2015 at 12:16 PM, Rocky640 <notifications@github.com> wrote:

> ChessQuake, when eval is called, it is never when the King is in check.
>
> Same comment about your post on
> https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/B_m3GXp4lTg
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Rocky640/Stockfish/commit/e6b99e2ada43c03d1d1cf3f7291bbec6314ea894#commitcomment-12242951>
> .
>


I am not sure at all. I don't know of any features UseLATEX.cmake is using that are not supported by CMake versions earlier than 3.0, and I think it should work with most versions of 2.8 at a minimum. It is just that I have not kept track of feature changes in CMake that well and I have not tried on earlier versions.


@jaron-turnbull I just pushed latest version to http://fabricjs.com/ and I see that it's definitely crispy on my screen. What about yours?


Also allow fine in handlers


Well. That is better than locking for ∞ seconds.


/me is a derp


key


It's funny that the completion list actually shows toString, and it shows two signatures unioned together in the details, but then when you try to call it, they're gone...


Makes sense. This would entail editing the `info-panel/index.js` to check if the description is a jQuery object, and if it is, to manually append it to the rest of the error template, correct?


I would just change the behavior of info-panel so that it always accepts a jquery element.


I recommend setting this to 3 or 4 in case your blocks happen to implement interfaces other mods like Computronics add drivers for as well.


Sounds good.


Merge


How do you want docs done for the website?


I'd put a comma after "properties" just to break things up.


Apart from the priority it looks good to me.


```
             if self.inspect["State"]["Running"]:
                 return self._running()
```
Shouldn't you handle else?

I think we need to setup the different use cases, before we can verify the code.


*analyses


I would provide a comment about `*const Void` vs. `*const ()`


Thanks :D But this address is useless because R2 addr same as R2-1.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.777.93a57c6a7c8dd66cafbb9f8f815e29c1609c6bfd](http://build.palaso.org/viewLog.html?buildId=59839&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 380, ignored: 3 Build time: 00:03:25


try 1 cuz: Effect 1: Id 5 (SPELL_EFFECT_TELEPORT_UNITS)


What is the reason for aliasing `React.PropTypes` to `ReactPropTypes`?


This looked strange for me. :c


u mean bracket should line up vertically?


:+1: Concordo com o aproveitamento disso.


#1 File "1.txt" is added


The jpg files are mostly 100% images, if we reduced this to 75% (i cant see a difference on most images)
we could reduce the filesuze by 60%

jpegoptim -ft -m75 *.jp*g
-->
Average compression (86 files): 62.74% (2980k)

this makes quite a difference on overall program size / image loading inside the program. Though we would loose some quality.

Any opinions?


This commit is actually mislabeled - it is supposed to be `SONARCS-545 Embed SonarLint 1.0`

As we are not allowed to `git push --force` to the master - I am leaving the mistake as it is.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.778.bcdd2f02a981d88901eac6b64c2c7fe3ca2e8e7e](http://build.palaso.org/viewLog.html?buildId=59840&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 386, ignored: 3 Build time: 00:03:34


no good reason, pattern was copied from some old code that got codemodded multiple times (where proptypes were originally in a different module)


There is no `update-rc.d`-like required?


The trivial fix doesn't seem to work. I.e. :

```rust
    *self as f64 as c_double
```

It is having an issue converting the bool (which is a non numeric type in rust) to a double


Interesting thing is that when the input field on RUNDECK is empty, the value of `issueKey` is `"${option.JIRA_ISSUE}"`.


Here is the original guide on how we designed atomic run command.

https://docs.google.com/document/d/14U03ggEjerBhG-PAdWhxJsnpLu04rVVzoHbXppjsHhk/edit


Cool! :)
More than i expected.


> Any reason for the extra space before <a href...?

Yes, it gets added to another string which ends with a .


What's the advantage of this over Jeet?


You can write this simply `options.delete(:script_name) { '' }` or `options.delete(:script_name).to_s`


yea


same result...


looks like 1.10 branch needs this as well? see https://github.com/mate-desktop/mate-sensors-applet/commit/22e467495f3953d8537ebd4b33ccb584918b3e23


should change to console.error, also do u want a better err message?


Thanks yeah just fixed that.


@jramapuram Lets talk on gitter.


Then I would have to change all the other plugins to pass their descriptions as jQuery objects too, correct? Not against it, just making sure it's necessary.


updated bundle url


I'm not sure I'm happy with my array remove function anymore.  I also wonder if I ought to just include something like underscore.js instead of writing this stuff myself.  I'll add a work item for that.  But in the mean time, I see this removal function as having 3 possible return states:

1. successfully removed: returns the newly smaller array
 * This one I'm fine with other than the possibility of race conditions.  For example, if we're in this function removing a room because everyone quit, but then at the same time, a new room comes online and manages to pick the same name, we could end up with an odd bug.  We could use locks or something else.  Could be this isn't even an issue though.  I just thought of this and haven't had a chance to look into it.
2. item could not be found in the array: return false
 * I'm not sure about this return type.  Seems like we should just return the original array.  That way if we're trying to remove something that was either a) never there or b) already removed, we don't think an error happened in the remove function and we keep on processing.  I haven't thought much about the scenario in which we're trying to remove something that doesn't exist but that seems external to this function's contract.
3. some other error such as object was not an array, or indexOf doesn't exist (ex < IE 9).
 * Here maybe returning false is fine?  I'd have to think about this some more.


1. The above code occurs in two places and should be factored out.

2. creating an Item_func_between (which is then analyzed again) doesnt  look like a straightforward solution.

I've already mentioned that creating objects on param->old_root is bad.  However, switching to range analyzer's mem_root might be not sufficient if we are creating objects derived from class Item.  Item::Item registers itself in THD::free_list, and probably somewhere else.

I would very much prefer if this new code did what already existing code does. For example,  "field IN (c1,c2,c3)" does not create "field=c1 OR field=c2 OR field c3".  It calls appropriate functions to construct the ranges directly.


Isn't this redundant now against the [config loading in Gruntfile.js](https://github.com/forumone/web-starter/blob/1.1.x/Gruntfile.js#L19-L22)? I had originally tried this approach of explicitly defining it in a file for readability and general awareness, but I ran into race condition issues when tasks dependent on the package.json configuration tried to run.


and which sai do u used? or do u used the corepart?


@jcasner This is causing a test failure because the function signatures don't line up with AWSResourceAdapterBase and the decorator fails.  Why did you change it?


Could you please use and add this variable for the binary path? Can be useful to debug or when pm2 is not in `/usr/local/bin`.
```
PM2=%PM2_PATH% #binary path
```


@9prady9 : I think its a simple fix, take a look at the new commit. Just needed to specialize on bool


thanks @kangax for considering my doubts!

i have some gradient stroke last minites checks to do. when are you planning 1.6.0?


HEY NOW THIS IS  A BAIT AND SWITCH THIS ISN'T WHAT I SIGNED OFF ON ;-)

(SLGTM)


I think I took that line from your original work. I didn't have any trouble with it, but we can probably remove it.


```
-- Target Position For Spell 74100
DELETE FROM `spell_target_position` WHERE id=74100;
INSERT INTO `spell_target_position` (`id`, `effIndex`, `target_map`, `target_position_x`, `target_position_y`, `target_position_z`, `target_orientation`) VALUES
(74100, 1, 648, 534.50, 3273.40, 0.23, 4.79);
```


Fixed in https://github.com/numenta/numenta-apps/pull/132


Yep, exactly :)


@kensington Thanks. This was on my 5.5 TODO list. I'll follow up with gst-1.0 support. Actually, I'd rather drop gst-0.10 altogether, does KDE require a specific gstreamer SLOT?


I'll guess they are sloopy....  :-)


I think I fixored it later on, dunno :O


INSERT INTO `spell_target_position` VALUES (74100, 0, 648, 534.5, 3273.4, 0.23, 4.79);
INSERT INTO `spell_target_position` VALUES (74100, 1, 648, 534.5, 3273.4, 0.23, 4.79);

the result is = bloqued on black screen, not teleport !


If it becomes unmanageable let me know.


u missing spell linked spell


This works too, thank you for catching this.


@claudiosmweb For instance if I am editing the *Post ID - 6* and performing seach for `006` as we need 3 character in search term. And what happens is shocking it shows the result of currently edited Post ID. If I am not wrong this commit is for excluding the search result for currently edited post ID, right :)


INSERT INTO `spell_linked_spell` VALUES (74100, 91847, 0, 'Life Savings: Teleport & Bind to the Lost Isles');


Added in d24275372624bac897c4131fd1507a58c09a1483 on `master` & 9c373c31410deb8e4a11aa7ce226d5e9169c7852 on `compat`. Thanks for noticing!


Probably not, as ```YEAR(column)= date_const``` is never true, so the rewrite should not apply to such conditions..


Ping @troydai - I think I covered everything that needed to be updated from your change, but please take a look. ICompilationMessage has been turned into a POCO and RoslynCompilationMessage was removed


Good idea!


type should be 1 HIT


This is basically the replacement for RoslynCompilationMessage. Instead of a custom implementation, it just has a factory method to create the DiagnosticMessage POCO from a Roslyn Diagnostic (and now, target framework).


I was under the impression that bins are calculated from the full dataset, not only the unique values. I had a conversation about this here: https://github.com/CartoDB/cartodb-postgresql/pull/80


I accept the commit if you fork this guide style https://github.com/NYTimes/objective-c-style-guide#init-and-dealloc and add the rule about how to deal with arrays


Yes, you make valid points here. This seems OK from my first glance.


Do we want this `return` in the transaction block?


The second Twitter should be capitalized.


Thanks Sal. This should not affect the already produced data samples though.


Hm, not yet sure. Do you think we can get iText "oninput" in as well?


`static`


un-faved instead of unfazed.


good idea, just added that


Hi
I will send a pr.
Regards

Sent from mobile device. apologies for typos.
On Jul 13, 2015 9:53 PM, "Aslak Hellesøy" <notifications@github.com> wrote:

> Sounds like a good idea. Want to send us a PR?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cucumber/cucumber-jvm/commit/bc215fee21ea92739688f65ce49fff1b21847ff7#commitcomment-12142679>
> .
>


Does this convert an object to a JSON string then back into an object?


even getId() and getTexturesId() or getDrawId() ?


cleanup_unit_test (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1244 of 1244 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.98%25-green.svg)


good typo


I seem to recall there being a very important reason why this was a `bytes` object on Python 3, @bartvm?


getId should be a generic name on every gl object, shaders, vao...


Only if the crab configurations were also set up wrong and used an "MC" global tag ;). I would double check, although if it is wrong it would simply fail immediately.


Converts a buffer string into a json object


__Helpful hint for contributors:__ `REPODIRECTORY/.git/info/exclude` can be used as a local .gitignore (Create the file if it does not exist)


Should this callback receive the new token?


Maybe this shouldn't use an async pattern if it's not asynchronous.


If this isn't async, it doesn't need a callback.


I think so. It's the fast redirect that's causing the conflict because when getting DomainSubscriptionView, the current subscription is fetched and it's at that point that it checks to see if other subscriptions exist and throws the error


MVP should have information from Goals instead. Goals can cover a lot of future features, but the ones listed there currently are what we discussed for the MVP to get it out there.


We could iterate through the array once and count both `ProtectedKeyword` and `InternalKeyword`


It could, do you think that would be better than having the above getToken function? line 18


These are great list ideas, but I think six is too many for right now. I remember us talking about just having three simple lists that were accessible from the Segmented Control. "To Read", "Have Read", and "Favorites". Archived/deleted articles could be accessed through the settings.


Probably a good place to provide a default.


no teleport too


cc @karissa


Conditioning


still black screen ?


i prefer to avoid any call at all to ofGetGLRenderer if possible that way if you work with explicit renderers and draw/bind objects through them, there's no singletons used anywhere.


Nope, wasn't cryptic at all.  Let me know if/when you get a chance to see if adding the try/finally fixes it.


I don't agree. If that query is allowed the user might be allowed to edit any blogPost, which is exactly what we're trying to prevent.

Whenever I add the OwnershipAssertion I want to be certain that it actually asserts ownership or completely fails.

Or maybe I misinterpreted your use case?


yes


Heh, yeah was going to do something more with this project, but it has turned into just an experiment app to mess with backbone. Also didn't realize this was still commented out.


GreatId (pun intended) - yes that would be nice and consistent.


Link starts up a download rather than displaying. Can you upload it to an image share site like imgur.com and then link from there?


Done.


just added it :)


Yeah should probably update, started this project last november. heh.


Looks good to me.


please call me the issue number


I wonder if we could highjack the dockerfile before creating the tar file. I agree with @jfrazelle doing the taring twice looks suboptimal.

Having a separated goroutine modifying the tar looks indeed very racy. If we're going to do this it should be synchronous.


This is an implementation-specific test. Calling .then on elementArrayFinder returns a list of raw webElements, wrapped in elementFinders. This test makes sure that isPresent returns false.
See https://github.com/angular/protractor/issues/1903


The token is probably just `payload.access_token`.  I'd imagine it will always be a "Bearer" token, which needs to be prepended when adding an authorization header.


91847 should trigger 74100 not diffrent ^^ u swapped them :)
try it like this and remove your fix
```
INSERT INTO spell_linked_spell VALUES (91847, 74100, 0, 'Life Savings: Teleport & Bind to the Lost Isles');
```


right! thanks for explanation


INSERT INTO `spell_linked_spell` VALUES (91847, 74100, 0, 'Life Savings: Teleport & Bind to the Lost Isles');

work !!!!


How about I leave the other three there and strikethrough them?


:+1: Could you create pull request please? Thx


not again maksis!


Is there a header named `body`?  Or is `body` meant to be the separate, `payload` option?


The goals are within ##MVP


Great idea. Let me do that.


Make 'HandleDeclaration' static? I kept it similar to the SA105 implementation.


This is all missing URI encoding.  Should probably use `Querystring` here.


Sure thing.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.779.45cc00669137fd85837c0fd13b46bfd6aec14fb5](http://build.palaso.org/viewLog.html?buildId=59841&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 386, ignored: 3 Build time: 00:02:57


Do we actually need the max_len parameter? I think we could just go for the MAX_PLAYER_NAME length (Was it 16?)


There is a header named body


Yes, you're absolutely right. :)
BTW  https://github.com/cmsb2g/B2GAnaFW/blob/master/test/CRAB/crab_jetht2015B.py#L12
has had the correct GT before the warning was inserted, I donot think the JetHT dataset I processed is affected.


Let me take a look.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 174](https://teamcity.labkey.org/viewLog.html?buildId=261721&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 20 Build time: 00:37:03
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySavedGroupPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


Again, is `body` a header, or should it be the separate `payload` option?


I assume you mean Happy Grid in general, not this specific commit. It's based off Cory's Lost Grid so I'll point you to his own words... http://webdesign.tutsplus.com/tutorials/calc-grids-are-the-best-grids--cms-22902

The short version is this... by using `calc()` you don't have to pass context ratios to nested grids, i.e. `column '1/2'` instead of `column 1/4 1/3 1/2 1/2`.

I also like that this version is simpler and you don't have to remember a ton of params to pass to the mixin.


Sort of, I'm a little confused why there are so many additional options in the call signature though? The old call signature required `(open, high, low, close, **kwargs)` and there were *two* options, don't you logically only need a single new keyword argument to differentiate now: `(open, high, low, close, direction='increasing', **kwargs)`?

I think I mentioned this in Slack, sorry if I'm missing something. Are you just adding these as a convenience? Can't you just set the color/name based on the new conditional?


I think this is a pretty straightforward app. Do you think its too much to add the other three items to MVP.


FYI, looks like I missed checking in a file. See e665c9f


:+1: one less type of messages


IdRecruiter and ModificationDate must start with lower case letter, to follow code standards


`self` is not necessary here– in the same scope as the surrounding prototyped function.  Same with the headers value below.


Same question about `body`/`payload`.


The currently longest TLD is 24 characters, 15 chars if you ignore puny code TLDs, not 6. So using {2,63} here is a safer bet. This also doesn't handle Punycode in hostnames or TLDs, but that might be ok.

There's a list of current TLDs at: http://data.iana.org/TLD/tlds-alpha-by-domain.txt


That's true. That's more efficient. But I tried to use existing search methods instead of implementing my own. Should I add my own 'search algorithm' (using a for-loop) directly into this method?


if it is something you like i ll give it a shot again before other things.


I know, I showed you this case, but it would be better to write an extension or HTML helper for this.


Hey @buro9 - thanks! I actually felt this pain myself the other day, and was planning on merging this in soon. I took a different approach, where you'd pass in the mux you wanna use. Thoughts?

https://github.com/wblakecaldwell/profiler/commit/5ac8e2a5a0bfbc35af842b3f23cfe32ed199a970


Are binary literals really necessary here? What's wrong with '0', '1', and '2'? Better yet, let's avoid magic numbers.


Just wondering, does running tests like this cover up errors? Do we need an upon() at the end to catch them?


Looks good to me with the additional file update.


> Why? Removing this should be as easy as a .replace() call.

Good point, my brain isn't firing on all cylinders this morning. Because there's a comment above, instead of removing the line, what if we replace it with a commented out version `// require('web-component-tester').gulp.init(gulp);`. That way the user could bring it back if they want (though they would need to add it to their package/bower.jsons


why model is used? I think id would be enough for this action


I believe delayed_job only works on Unix and will always use this path but this is a good time to mention that had this not been the case, it's important to mention to the rest of the team anytime you're introducing platform-dependent features.


Personally, I think it's over-complicating things to add all of those options. If I were using this I would want to get access to my articles as soon as possible with a few taps as possible. Can we keep them to the side as possibilities?


`self` not necessary here.


:shipit:


File names must be lowercase, such as `action.cpp`


I don't understand this.


I don't understand what was fixed here. Was it line-ending?


I prefer to submit the next step separately.  It will be easier for others
to see and verify the progression of changes.

So go ahead if you are happy with the output of this version of the patch.

david

On Fri, Jul 17, 2015 at 1:37 PM John Kessenich <notifications@github.com>
wrote:

> Looks like it works.
>
> Do you want to do the next step that perturbs the test results more before
> I merge in, or I should do two separate merges?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/glslang/commit/31945a35c20ca7ec0c1c4fc9192b91a57878b84b#commitcomment-12230045>
> .
>


Well, I feel like it's the only thing preventing us from supporting text with accents at the momet


sortBy enum members must start with Upper case

SalaryAsc,
SalaryDesc, ... etc

and also place it to separate file


I don't understand how this can happen. Can you update your PR with the current code and tell me the command to run to see this? I need to investigate. To my knowledge, what you see should not happen.


it looks better now, but not perfect


`self` not required here or in headers below.  Sorry I kept commenting that.  You should just peek through the file for similar stuff.


This creates shared state between the test cases below and requires that the test cases run in a very specific order. This will definitely make it harder to add more test cases in the future and could make it difficult to track down the source of problems. It would be better to setup and tear down these mocks independently for each tests case. This should be pretty straight forward since you have separate `describe` blocks for each test case.


See issue #2.


Heh. Definitely should be a PR next time :). No ninja commits please :P.


# Design of class implementing Provider\<T\>
Reuse already existing annotations and add some new only for WebServiceProvider
## Class annotations
* @DocDescription - description of web service (same as on SEI)

## Invoke operation annotations
* @DocDescription - description of web service operation (same as on SEI)
* @DocReturn - used for customizing Java return types and (same as on SEI, but DocReturn.type will be required for this scenario)
* @DocReturns - if more than one return option can be returned use this wrapper for them. It means standard return type and list of exceptions (faults). (same as on SEI)
* @DocSOAPBinding - optional, same fields and meaning as JAX-WS @SOAPBinding (new for WebServiceProvider)
* @DocParam and @DocParams - in principle similar as @DocReturn and @DocReturns. Fields of DocParam are:
 * header (boolean)
 * required (boolean)
 * type (Class\<?\>)
 * description (String)

## Example
```java
@DocDescription("WebServiceProvider description")
@WebServiceProvider
@ServiceMode(value = Service.Mode.MESSAGE)
public class SimpleWebServiceProvider implements Provider<SOAPMessage> {

    @Override
    @DocDescription("Operation description")
    @DocSOAPBinding(parameterStyle = DocSOAPBinding.ParameterStyle.WRAPPED, style = DocSOAPBinding.Style.DOCUMENT, use = DocSOAPBinding.Use.ENCODED)
    @DocParams({
            @DocParam(header = true, required = true, type = Destination.class, description = "Destination object description"),
            @DocParam(type = User.class, description = "User object description")
    })
    @DocReturns({
            @DocReturn(type = Destination.class, description = "Some description", typeDescription = "Destination object description"),
            @DocReturn(http = 500, type = AirserviceException.class),
            @DocReturn(http = 500, type = User.class)
    })
    public SOAPMessage invoke(SOAPMessage request) {
        System.out.println(request);
        return request;
    }
}
```
Thanks for comments.


Ok, so here is how I perceive this rule - `$acl->allow('author', 'blogPost', 'edit', new OwnershipAssertion());`:
- author is allowed to edit blog post, in sense that authors should have edit permissions *in general*
- additionally, ownership should be taken into the account if it is available

IMHO throwing exceptions would be too restrictive approach. Maybe I should change that early `return true;` into something like `return $this->isPermissive;` where `$isPermissive` is some flag through which OwnershipAssertion can be configured to be permissive or not.


something like `joins(:o_auth_application).where(o_auth_application: {client_id: client_id}, refresh_token: refresh_token).first` should work.


This depends heavily on the test state [created above](https://github.com/trueblue2704/service-maker/commit/9a6a8192a2647696377f7cbbc1ad37aa3946681f#commitcomment-12259372).


nothing


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 348](http://192.168.30.225:8111/viewLog.html?buildId=1688&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


wrong:

must be Model.SearchParams.SortBy == SortBy.SalaryAsc,

The main idea is to use only enum values everywhere, instead of strings.


Looks good to me.


Sweet! =)


I would prefer to have <input value="@SortBy.SalaryAsc.ToString()" ... />

I don't want to remember any magic  string values, I want to compiler remembers it for me.


@Maikuolan thanks for the hint, I will translate the strings this week.


Done.


Hah yeah, sorry. Should've specified, I added the checkbox fix, but didn't see any code for select fix until I looked at your PR more closely.


```rb
OpenIDConnect::ResponseObject::IdToken.new(claims).tap do |token|
  ...
end
```


That's funny. I just always assumed it used calc().

I actually haven't run into any nesting issues with it yet.

Why did you rename gutter to margin?


that's ok


Yes, `HandleDeclaration` doesn't require any state.


Isn't this suppressing vulnerability and info messages?


Seems to work here, too, both compilation and running the GUI afterwards. Thanks.


Never heard of it!  Mind linking me to the printchomp API docs or some other spec describing this?


Are these paths demanded in this exact variant by the spec? Else I'd prefer to see the `_path` helpers be used here.


Done


Good with inheritDoc here!


Also remove any additions when done using test data.


yeahh, tha't cool


Kill the & here and elsewhere please.


Probably return the token in the callback and also keep the `getToken` method.


I still don't think that this test case and description are clear. What are we really testing here? It looks to me that we are testing the ability to update an existing instance. AWS is not involved at all in this part of the code (even though this code was created to support an AWS related use case). If this is true, I believe that the instance creation should be part of the test setup since it is a precondition and not actually part of the flow being tested. Similarly, default values seem to not really be relevant here since the call to `updateInstance()` is explicitly populated with all fields.


Ah!  Gotchya!


I added just after you closed it.


@sjellis this is a little surprising.

One thing that jumps out is that the marker is being initialized with a [`Place`](https://developers.google.com/maps/documentation/javascript/reference#Place) rather than a `LatLng` object (`Marker` [supports both](https://developers.google.com/maps/documentation/javascript/reference#methods_48) `setPlace(p: Place)` and `setPosition(l: LatLng)`). That shouldn't matter: the marker should normalize its position and return a `LatLng` whenever `getPosition()` is called, but it might be worth extracting the position from the `Place` _instead of_ the `Marker`:

    bounds.extend(markerArray[i].getPlace().location);

I'll be a little surprised if that fixes it, though—you should be (correctly) seeing a `lat, lng` pair when logging `getPosition()` below, yeah?


Nobody meant to ignore that file though. :P


1670-HeatPumpWaterHeater (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Yep. `foreach` against `ChildTokens()`


Fuck it I don't even care anymore, TAKE ME NOW, MEPHISTOPHELES


atest


Done.


test


Done


Solid changes with better details


You can use jsonify here now! ;-)


Maybe better to remove this ambx plugin as-well like OpenPLi did:
https://github.com/OpenPLi/openpli-oe-core/commit/fed0c5adfd908acef8cdeb051fd95a62b5898a3f


I ran into the same trouble in Linux, but it's possible to get your original desired behavior, without throwing; I was about to commit a fix for the previous version of this.   What works on linux was simply replacing the 2 plain
```            return;
```
statements with
```            return TemporaryPtr<Field>();
```

Assuming this also works in Windows, I suggest reverting this commit in using the fix I propose.


hey


Are there potential timing issues here? How do we know that both instances have been created successfully?


Is `files` meant to have be array that contains a single array?


I think there are timing issues here.


Good point; I will try that.

My only concern is that we probably really need some of the X11 dependencies to make Weston run on X11. But jhbuild has conditional variables, so it should be possible to make that optional.


I published this now.


Yeah, we just spent some time working with Evan on this and still have not found a solution. marker.getPosition() return undefined. I tried implementing your suggestion with getPlace().location and that still returns the error 'cannot read property 'lat' of undefined. Not sure where the problem is.


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1620 of 1761 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-91.99%25-yellow.svg)


@klappradla Bin jetzt auch nur bis docker gekommen. Pure Vagrant wäre eventuell wirklich vorerst der einfachere Schritt. Ich werde mir das auch parallel nebenbei anschauen.


Move it into the if block


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 348](http://192.168.30.225:8111/viewLog.html?buildId=1688&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:10:47


How did you trace this issue?
A logcat doesn't show anything, so without errors I can't see a clue.


Nevermind...seems to be working. Looks like getPlace().location is the fix. Phew, thanks RJ!!!


Thx.


I really liked the concept too.

But apparently, this is too much to ask to a static evaluation.
I have never seen an eval patch succeed where more than 2 pieces were involved,
Possibly the computational cost is too high for the not so clear benefit.
Also, these things are probably better sorted out in search, where the capture sequence will eventually be played out.

My original patch did not worked, so just adding more stuff into it will not work either.
Unless we also change the value of the bonus. Originally, I used Hanging,
and I'm quite sure I tried other smaller values locally.

Back to your last comment, a simple test could be:

if (ei.splitDefenders[Them] &  ei.attackedBy[Us][ALL_PIECES])
   score += TacticalBonus;

if (ei.splitDefendeds[Them] &  ei.attackedBy[Us][ALL_PIECES])
   score += TacticalBonus;


This is looking better. However, I'm worried that there could be false positives due to timing issues. When testing asynchronous code the test framework needs to be notified to wait for the asynchronous code to complete. When using promises, this is usually as simple as returning the promise chain to mocha (see http://mochajs.org/#working-with-promises for more info).


sir i am not able to locate oauth.R file.


That sounds like a kernel bug with the psmouse driver, it needs to create the attributes before userspace is notified the device is present.  And in looking at the kernel code, yes, it is not correct, and should be fixed there, not in udev.


Totally makes sense. Additional comment you suggest seems appropriate to me. Thanks for clarifying!


97902934_ZoneMixing (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I read the issue thread. Is this the direction that the project will be taking, where protractor will be responsible for continuously re-fetching web elements on behalf of the user to avoid stale element reference errors?


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


```
init(name: String, age: Int, town: Town) {
    self.name = name
    self.age = age
    self.city = town // also inconsistent, but...
}
```


Nope, shouldn't be, that should never be hit. It's only there as a precaution against a misbehaved GPU process, for the same reason we added the conditionals in b0988bbf0edae58e2fd80b4b34b32b5dec82999c

In general, I tried to sanity-check the IPC messages with conditionals in the browser process, and with DCHECKs in the GPU process.


You already noted in your later commit that this made link problems on Windows (it did on Linux as well).  I've mentioned a solution in that later commit but thought I should note it here as well: instead of simply "return;",
```
             return TemporaryPtr<Field>();
```
(and the same thing towards the bottom of the function)


Okay. I now even see a remark to this effect on the `ClientCall` interface. Sorry for the noise.


why do you prefer using old versions...?


@samseaver, can you please review and make sure the code is handling the pkas and pkbs correctly.


Will I be able to check this return result with `if (!returned_reference)`?


Discarding, see above.


`SelectNextMimeType` returns the next MIME type to process, or an empty string if there are no MIME types left to handle (all the drag data has been collected).


Because we are actually setting the margin and I'm not a big fan of using `_` prefixes when calling named params while using a mixin.


Thanks for the comment :)


Actually I'm not sure where this is going. No, protractor never re-fetches web elements for the user. But, if you use elementFinder/elementArrayFinder, protractor will retrieve your webelement only when you perform the action. If you have a specific issues, where this 're-fetching' thing you're talking about is causing a problem, please file an issue.


Cool, looks good! In this case, you could do:

```c++
map->nudgeTransitions(map->renderSync());
```

But perhaps that's more obfuscated.


exported function SOMELINTERISSUE should have comment or be unexported


Indentation?


Excellent, this enhancement should add hodorability for a much wider range of devices


I don't think there's a reference.  I've generally been one to recommend `@` to others (though I think I'm not the only one) just because it clearly sets of Doxygen escaping from other kinds of escaping.


Docs are auto-generated from the source + snippets over at https://github.com/BrowserSync/browsersync.github.io

We're just about to release a complete redesign in the next couple of days, so you may want to hold off until then :)


Sorry, I don't quite understand. This isn't a question of reference types or not; I'm emphasizing the best practice that `let` should be used, unless, in the playground, you anticipate modeling `Town`s that can change their names. Regardless, you should not be providing the default property value of `"NYC"`. If you want the `name` property to be mutable, then, at minimum, this class definition should be:

```
class Town {

    var name: String

    init(name: String) {
        self.name = name
    }

}
```


I see the changes and they look good except for the '.'. It should be a ',' after 'me'


Superb code, very hodonic


s/install/install W3M/

(otherwise this may read like you're asking the reader to install the Sony blobs instead of W3M)


Overriding a private method should not have any effect on other libraries. Are there any test with this code on coursemology2#349?


Querying a skip list has to chase more pointers, so it's less cache-friendly. So I rarely see its use unless ordering is actually needed. Note that `ConcurrentHashMap` is lock-free for queries, and in Java 8 the lock granularity is very fine so that collisions are unlikely even for locking operations (mutations).

I guess, for this particular thing, performance is not really a concern since none of these operations will be used in high frequency and will never be in any hot code paths.

About requiring servers to shutdown and not needing weak references, sounds good to me.


I would use custom 'decorate' function to decorate string with '`'.
See https://github.com/TheOneYouDontLike/Klesk/blob/master/app/handlers/showStatsHandler.js#L26


I _think_ you might be missing out on the fact that constant properties can be assigned initial values by any initializer. It does not have to be `var`, nor should there be an explicit default value of `"John Doe"`. (This issue isn't about value types.)


@robotmlg lololol dordex, I appreciate that you are keeping with Hodonic naming conventions.


Why not from `viewWillAppear:` to give it a bit more time to load?


Beauty! :100:


True, it remains from previous code, would you remove it?


I don't think we need this change.  By convention, the OpenStack Heat docs do not include headers in response samples.  The response code should be sufficient.


I haven't yet seen it be anything other than a bearer token. Which would mean in this case I do not need to be prepending the `token type`, correct?


Fail, wrong branch
How can I revert?


See comment in the wadl file on line 865


tanks


exported function SOMELINTERISSUE should have comment or be unexported


Accidental revert of libsodium; omit this.


But of course.  Gotta keep the names consistent.


Well, if it doesnt collide with my latest PR, I wont revert.


Looks like we have this issue in all callers of emitSerializedTypeNode. possibly move the check there.


`printchompsdk` should probably be `UpperCamel` since it's a prototyped object.  This is something sam put in the style guide https://github.com/yarn-co/yarn-style/blob/master/javascript.md


TIL --- very cool.

Thanks Shish! \o/


This has been merged into the main project so grab the updated code with
```
devtools::install_github("geoffjentry/twitteR")
```


Yeah– you could store the token type if you want, but it's not part of the token.  It should always be a bearer token if they're using oauth2.


Ok, I'll move the check in the inner method, using the same branch.


I had already checked & saw that's how you were using the result, that's why I said I thought this fit your intentions better.  It doesn't look awkward to me.  You can throw if you really want to, I guess, but I thought that we had a practice of simply logging errors rather than throwing exceptions in this kind of content handling.


Excellent, thanks!


In the X11 version this is used to make sure `target_window` is not destroyed during the DnD session, and set it to null if that happens. I can't think of any way that might ever occur, but it would be a good idea to handle that, just in case. Currently `CreateDropTargetEvent` assumes that `target_window_` is nonnull.


My fear is that I might mistakenly query the Acl with a string, and a few months later realize that a rogue author have been editing everybody else's posts. No warning will be given and I won't discover it because I forgot to test the application in the role of an author.

A strict mode might be good enough, but usually I prefer to have my applications to crash and burn whenever I do something wrong. That makes it easier to discover and fix bugs.

Those are my thoughts. So maybe there could be an even stricter mode where exceptions are thrown? :)


The javadocs are incomplete here.


Updated. Now it only takes a few seconds to run.


I made some changes on top of this in https://github.com/docker/notary/commit/c78b405d3b382ea47ba3f42382bf48c795b74e70

I fixed RemoveKey to purge the cache entry, added mutexes in case there are ever concurrent calls to keystore operations, combined GetKey/GetKeyAlias like I suggested in the earlier PR, and fixed some tests that were affected by the cache.


this update should be done before you start working :smile:


I was following the style from [here](https://github.com/rails/rails/blob/65bebde80cf5e323486ac5c01c8c5eeed47eb5f8/actionpack/lib/action_dispatch/routing/route_set.rb#L771). I can change the style if everything else is good.


Missing check that a creature died?


On the awkwardness and checking point-- this is the same kind of thing as is returned for something like GetShip(not_a_ship_id)


might be late but I just noticed this, why exclude daily development 2 and daily construction 2?


Does this add an extra space after "for"?


If you write ['Basic', 0] then you don't need to do the preSet


What exactly do you mean by "drag type" -- the drag action (move, link, copy -- impossible to set without changes to the Wayland protocol, so I always assume copy), or the MIME type sent by the drag (which will never be empty here)?

The update is sent immediately after enter because the documentation of `DragDropDelegate` says to call `OnDragUpdated` immediately after `OnDragEntered`. It seems silly/redundant, but maybe it's useful for other ports. That's what the X11 code does too, in `DesktopDragDropClientAuraX11::CompleteXdndPosition`:

```
  DragTranslate(screen_point, &data, &drop_target_event, &delegate);
  if (delegate)
    drag_operation = delegate->OnDragUpdated(*drop_target_event);
```

(`OnDragUpdated` is called inside `DragTranslate`.)


There is nothing we can do to stop him at this point. I believe he is now resonating directly with [Indra's Net](https://en.wikipedia.org/wiki/Indra%27s_net) and the grid systems are simply oozing out of his very being.


You typed `||` when you presumably meant `&&`.   Relatedly, I guess this is missing a unit test?


This should have defaulted to true for origin deployments in ec2.


I feel like I would rather not put metaEditLevel and metaEditView in core.  At least not yet.

It's pretty easy to just put a map of PropertyType to EditView in the MetaEditor, as well as from PropertyName to EditLevel.

Then core doesn't need to grow.  Plus MetaEditLevel in particular is very specific to this one type of model detail view.


Do you know if this ami id is consistent for all users who "purchase" the CentOS image through the marketplace?


Yes, pushed there as well. thx


For those svn repositories I uploaded some tar balls extracted from my local sources directory. You can extract them by yourself if interested:

http://pb-download.com/sources/tuxterm-enigma2-plugin_rev257.tar.gz
http://pb-download.com/sources/tuxterm_rev257.tar.gz
http://pb-download.com/sources/tuxcom_rev344.tar.gz


10250 is actually the kubelet port for nodes.


Both here and above, you are doing unnecessary work by evaluating both sides of the condition every time.  In this instance, if `res1` is true there's no reason to compute `res2`.

So saying

```
res = this._isQueried(item, index, tab, query.args[0]) || this._isQueried(item, index, tab, query.args[1])
```

would be better


You managed to fail plugin.yml :-1:


MetaModelView isn't really the right name.

You're making a distinction between the meta level "Model/Property" and the non-meta level "EMail/Contact/etc."

But the whole idea of FOAM is to not have this distinction.  Model is a Model just like EMail.  If the default DetailView is not good enough, then this should be called. ModelDetailView as a more specific detail view of "Model"


Doesn't make a difference in this case – they're presented without animation, so there's probably two or so run loop invocations between the two.


Happy to change though!


What is FRONT_SQUARE[][] ? Add comment maybe


@shivapoudel this need to exclude just the post ID.


Please, don't add font style here.


Very nice!


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 349](http://192.168.30.225:8111/viewLog.html?buildId=1694&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


In the future, it will be possible to specify different drag operations (or "drag actions") in Wayland. The drag operation would then be sent from the GPU process to the browser process in a new message, and it would indeed be necessary to add it as a parameter to this function. But in the meantime, it's impossible to specify drag operations (see the comment a bit below which links to patches for this from Red Hat); we have to pick just one drag operation and use it always, so I don't think it needs to be a parameter yet.


You can cut 30% of the lines by just using return statements, ex:

```js
case "eq":
   return item[prop] !== query.args[1];
```


cleanup_unit_test (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1759 of 1759 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Gotcha and good point then :+1:


This function likewise is doing too much work, it should be returning `false` as soon as the first `indexOf()` test fails.


nice commit message too 10/10


Why was the dependency bumped here? The code changes above work just fine with older mail.


Yeah


does 'id' need quotes around it?


come to think of it, do any of these need quotes around them?


typo "existimg"


:bow:


Oops.  reread the license.  will apply for commercial use privileges.
Sorry guys


I've been using this as a reference:
https://confluence.lsstcorp.org/display/LDMDG/Documentation+Standards#DocumentationStandards-Python


Error in this code - which will reveal itself with any values beyond a single word
```javascript
elem.find('option[value=' + option + ']').prop('selected', true);
```
should be
```javascript
elem.find('option[value="' + option + '"]').prop('selected', true);
```

Basically you have to encapsulate in quotes because the value could contain brackets


I don't understand the purpose of this `new-query-asked` event.  AFAICT no one is even listening to it.


Hm, I don't think that it is wrong to query Acl with a string. Why that possibility even exists? I think it is for those use cases when you only need to check whether some role has permissions in general, within the context when the actual resource object is not available.

Essentially, I got your point, it really makes sense, but my fear is that OwnershipAssertion designed that way won't be flexible enough. I don't know, maybe it shouldn't be flexible at all. :smiley: I would like to hear a second opinion.


Absolutely right, and there's one more here too.  Opening a PR and then looking for even more we may have missed.


But there is another issue with this logic all around... the issue is that its still valid HTML to do this

```html
<option>the value here</option>
```

This code will only find
```html
<option value="the value here">the displayed value here</option>
```


Isn't all the data available from the beginning?  ObservableArrays (and plain arrays) aren't asynchronous.


Drag operations are something different. You would use DRAG_MOVE to indicate, for example, that the object being dragged (e.g. a file in a file manager) is to be deleted from the source process after the drag is accepted. The other actions in X11 are copy and link (which tells the target process to create a symlink; only really makes sense for file managers). I've hardcoded DRAG_COPY since it is nondestructive. I might have to change this to DRAG_NONE when I add support for drags from Chromium, not sure. But it has to be some hardcoded value until support for drag actions is added to Wayland. See: http://lists.freedesktop.org/archives/wayland-devel/2015-June/022517.html


hpwh_residential (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (727 of 727 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.02%25-green.svg)


I used this because some people still not merged to Java 8


In some uses, it needs a solid border for example, if you type:

```factor
IN: scratchpad aslkdfj;lasjdflasf
```

it pops up a restart and needs a border.


Fixed <i4> type error and now this works on Windows!


97902934_ZoneMixing (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I guess all this commented code should just be removed?   I don't see the purpose, and also it's in dojodoc format not jsdoc.


Should be `duration`


Likewise, I guess this commented code should just be removed? I don't see the purpose, and also it's in dojodoc format not jsdoc.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 349](http://192.168.30.225:8111/viewLog.html?buildId=1694&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:10:42


@yaronyg `jx.core.js` is required for this example and will pull it in automatically I believe upon creation.


spelling error.


Not a bad idea. Tuple semantics are maintained, and I guess that would improve the API. My only reservation is that it's somewhat slower (8x). It might be a small enough thing that it doesn't make a big difference, but I would want to make sure. I think this could be introduced as a separate change. I created an improvement ticket to follow-up: https://datastax-oss.atlassian.net/browse/PYTHON-362


Thanks, this looks better.


@claudiosmweb If I am not wrong when we search via ID then *"No matches found"* should be displayed. Unexpected result is within the first screenshot while searching product via post ID =/

![exclude-id-1](https://cloud.githubusercontent.com/assets/3774827/8785382/1525a464-2f47-11e5-948d-b4ab84a60d09.png)
![exclude-id-2](https://cloud.githubusercontent.com/assets/3774827/8785385/19299d2c-2f47-11e5-885c-9f4cb92fb579.png)


Ah, I see the pun now. I thought it was "memorizing" the meme reference.


NOOOOO!!!! %X is for `int` and here we have a `PVOID` which is not compatible with `int` - not even guaranteed to be of same size. `%p` is the best thing I could find. Maybe (I'm not sure) this is an FP in Coverity.


r+


If you use `%r` instead of `%s` it'll automatically do `repr` instead of `str`.


I fixed the encapsulation issue. The other issue is perhaps to fallback on .val() instead of the attribute value.


saw approval from graydon
at https://github.com/jedmccaleb/stellar-core/commit/b61983ae0e1057ab87c45a9073a9d6b971cc0747


merging jedmccaleb/stellar-core/master = b61983ae into auto


jedmccaleb/stellar-core/master = b61983ae merged ok, testing candidate = f377b61d


/usr/bin is always in the path.  I'm not as sure about /usr/local/bin.  Perhaps this is an occasion for conditional processing.


Yeah this is an attribute of a feed. Thanks for catching that.


Hmm.  At one point Webkit only supported the old createDelayNode() call; I can only suppose this was a poor attempt (on my part) to support this, which I later fixed; but no idea.  Thanks for the cleanup.


So, what clears out the manifest, now? When does it get cleared out?


Blank Panther


Perhaps:

```
                                    elem.find('option[value=' + option + ']:not(:checked), option:contains("' + option + '"):not(:checked)').prop('selected', true).trigger('change');
```


What LDAP server?


(づ｡◕‿‿◕｡)づ


develop (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I tested this, and the API returns a 302 status code.


I don't know what that means.  If you define it in markup, isn't it just a plain array?  It seems like you shouldn't have removed lines 180-190.


> this update should be done before you start working :smile:

It's inevitable that work will be done in parallel. I'm very experienced with merges, so when working on this project the best advice I have is the following.

:memo: These rules are specifically intended to make things as easy as possible for both developers and reviewers of changes.

1. When you create your branch to start working on a new feature, create your branch at the current **master** commit
2. Avoid rebasing or squashing commits after the code review process is started
3. Avoid merging **master** into your working branch unless the reviewer specifically asks for it


it's part of the build process


Changed now


I would either invert this and name it "insecure" or name it reviewstate and put the raw value in there.

I'd opt for "insecure" (-1) and "outdated" (-1)

Besides that, I'd put it in extra->typo3/ter->insecure and extra->typo3/ter->outdated
and not directly in extra


See comment in wadl line 1044


besides my inline comment, I like this change


Thanks to @dequis for reminding me of this bug with his GlowstoneMC branch, https://github.com/dequis/Glowstone/tree/fix-red-sandstone-stairs-and-slabs


I'll see if I can implement this functionality. This commit also contains several other things (fixing whitespace, adding a .gitignore entry) that should be in a separate commit.


Ditto line 865


The accept message is no longer relevant once we receive the leave event; it's used to tell the source process whether the drag would be accepted _for the current pointer coordinates._

But I agree that the accept message doesn't need to be sent on every motion event if it hasn't changed. The current code will call `IndicateDragWillBeAccepted` many times in a row for the same motion event, but there's probably no need for that; instead, I should not call `IndicateDragWillBeAccepted` again until `IndicateDragWillBeRejected` has first been called (and vice-versa).


I don't think I can assume it was the last one that errored. (?) We may get multiple results in since last iteration.
Am I thinking about this wrong?


What do you think of using "Last-Modified-Millis-UTC" instead of "Last-Modified"?


(○’ω’○)


Better than what I would have come up with I believe.

I have noticed there are some many workarounds that we (the three of us) have to predict. It's becoming tiring =)


Note that until I push #420 `this.source` will always be null at this point.

More importantly, `preRender()` won't be called if `StoreMap` is defined as a `CustomElement` rather than as a `Widget`.   So probably this code should go into `createdCallback()` etc.?


Agreed. What would work best? All the args (except for `context`, `width` and `offset`)? Or just the `&str` ones?


The construct here is:

```
let deferred = …
XCTAssertTrue(deferred.value.isSuccess)
```

(down on line 66). That `.value` blocks execution until the `Deferred` is filled, so we don't need `upon` (or an expectation).


Even fancier


Line up code


I....  somehow managed to never learn that.  Cute.  Mind you, I keep meaning to start using the new-style format stuff, but still, that's handy.  :)


"Failed changing last-modified date {0}", params.get("Last-Modified")


Oh Krager


LOLOLOLOL ^^


check for null before calling Long.parseLong


Oops, there's a more modern way of doing this..

```js
elem.find('option:not(:checked)').filter(function( value ){
     var $option = $(this);
     return ($option.val() == value || $option.html() == value );
}).prop('selected', true).trigger('change');
```

This is the best solution - the [text] selector isn't suggested anymore according to the docs I found.


Hey there!  I use `ioObjectToArray` for a massive performance increase on lists (kudos!).  Is there a reason this has disappeared in recent versions of io-value?  Is there a simpler workaround, or has polymer 1.0 accounted for those performance issues?  Thanks!


It's "safflower"!


True, I only tried it building in `pythonPackages`, but I haven't tested `pypyPackages` at all.


save the displayUrl string passed in, compare using equals on strings, if param didn't change then avoid call to new URI and setting


The refactoring of the `keyAction` method is spilling into the margins of the code block.

<img width="587" alt="screen shot 2015-07-20 at 12 53 54 pm" src="https://cloud.githubusercontent.com/assets/4524175/8785699/693496a0-2ede-11e5-86e5-699dddd403a3.png">


I actually deleted this script line in my project and it worked just fine. I think it's auto-loaded. We don't need to explicitly reference it.


I am not sure here, but shouldn't be the `scannotation` brought automatically as it looks like transitive dependency of resteasy? I would expect the assembly to pull in all the transitive dependencies as well, but maybe it is just not the case (or we have bug there).


Okay, I'll work on it tomorrow.


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/71827708


"Failed changing display URL {0}", params.get("Display-URL")


how about "Display-URL" as the name?


Thank you. Couple of minor points.  Also, have you tried the code out?


Yeah, I keep meaning to learn the subtleties of `.format` too but I've done printf style formatting for too many years...!


IP and xpath are existing filters. Is it possible for having other filters (such as lock type, duration, etc) in the future? To hold more filters, Could we use a name/value array as the input of getLocks() and pass the name/value pairs in the msg?


@yaronyg the reason I kept it in was that the postcard app and others had it referenced.  Better safe than sorry as it doesn't error to have it in there https://github.com/thaliproject/postcardapp/blob/story_0_matthewp/www/index.html


Why == and not ===?


if no error on this callback, a timeout error is caused since _macutil.interruptwait() is called without assigning self.error


Just tested this.  This is incorrect response output.  Upstream is correct https://github.com/openstack/api-site/blob/master/api-ref/src/wadls/orchestration-api/src/v1/samples/resource_metadata_resp.json


@dira DMV is Department of Motor Vehicles. It's essentially driving license information.

With that comment I was wondering if the DMV information, mentioned in [new model field](https://drive.google.com/file/d/0B9FzRTnVcR_MdDllblY2eE95b2M/view), is related to AutoRecord. cc: @whitman


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 175](https://teamcity.labkey.org/viewLog.html?buildId=261738&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 20 Build time: 00:37:06
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySavedGroupPlot: <no details avaliable>

```


You can probably use strings as well, but I wonder if just casting to a string here doesn't cause some weird behaviour in the SQLite backend, since I guess it's now sometimes saved as a string, and sometimes as a binary blob? If you want to save it as a string, it's probably better to use `self.b_uuid.hex` so that you get the hexidecimal representation.


My mistake, I fixed that above.


See wadl comment line 1113


"hmm is this received as a result of sending RequestDragData from here ?"

Yes.

"In that case why do we need to send a special request for it, can we share the fd along with enter event ?"

No, a different pipe is created for each MIME type to be transferred.

"or as soon as we have the info about fd available in GPU process and have ongoing dnd operation ?"

It's actually called multiple times per DnD operation, once for each MIME type to be transferred. Ideally we would only transfer data once, in one MIME type, and that is most likely what other Wayland clients will do, but `OSExchangeData` expects us to fill it up with each type of possible data prior to calling `DragDropDelegate::OnDragEntered`. I don't see a way to avoid the need for that without writing an `OSExchangeData::Provider` that blocks the browser process for the data transfer when the data is read from the `OSExchangeData`, and that surely wouldn't be acceptable.


This and the previous line won't work. Need to create variable `quantumoutput_uis` with `surfacedialog.ui` and `newsurfacedialog.ui` (similar to `quantumouput_srcs`) and place on line 19. I am commenting here so I remember to fix this later!


What is this effectively doing? Adding all of the config object params from launchModal() to the main player config settings?


Any reason for not filtering the locks in server side using the setFromXPath() and queryConnection()?


"existing" fixed.


Sweet.

Bet you didn't think you would be working on this library today? =)


Is this also affected by the same CVE as https://github.com/rubysec/ruby-advisory-db/blob/master/gems/backup_checksum/OSVDB-108569.yml or is one of these wrong?


No worries. It is a curve like anything else. I do appreciate the code contributions.


Just tested this, and it returns a 302.


:+1: thanks


changing event handling technique from event bubbling to event capturing.


Ditto line 865


Are you saying that the person might have a user with a username of `me`?


@renpillay Sorry, the comment is not very clear. This is to break one line into two, it will be used when the screen size is too small


lol. If have any other problem please let me know.


Yea, selecting BT_tel is a bad idea when the HFP device isn't expecting it.  BT_Music should probably only be used when the A2DP has been activated as well.

Btw, are there any xdauto compatible devices that would use DVB_in and DVD_in?  Might not be a good idea showing things that can't be used either.


I still get the same error as in the [original report](https://groups.google.com/d/msg/zotero-dev/9SgumomoVOQ/F1cKzzDkdPMJ), unfortunately. Are you sure the OS code for filename-too-long is 63, [and not 36](http://www.virtsync.com/c-error-codes-include-errno)?


Think I may have commented on this approach in the last submission: These look like model methods to me.


> 我理解应该是opener.forwardTo会返回Container
这个地方之所以没有默认返回，是因为考虑并不是所有时候都是有container这货儿的，比如直接跳转。所以弄了一个统一的接口。

> 我还没明白要有多个container的原因？因为这个container确实就是对应的以前的那个actionPanel，只不过因为并不是都是这东西，起了个名字叫container。


#1 予測株価を保存するDBアクセサクラスを追加


Could you add a more complete reference?


lines 82 and 83 of this commit are causing issue 6295: https://github.com/rg3/youtube-dl/issues/6295


What's the point of meticulously transcribing the RFC's BNR, and then throwing in some non-RFC stuff?


This breaks deployment if a revision is used instead of a branch.

```
executing locally: "git rev-parse --revs-only origin/ad9f3e9"
# returns nothing
/Users/felix/.gem/ruby/2.2.0/gems/capistrano-2.15.6/lib/capistrano/recipes/deploy/scm/git.rb:245:in `query_revision': Unable to resolve revision for 'ad9f3e9' on repository '.'. (RuntimeError)
```


Don't ask me if the added skinning_template is proper, I have no idea about skinning.


No `AutoSelectionSize` on this?


This is interesting...
I wouldn't have thought to convert to dplyr here, but I suppose that we can probably angle it so that *every* numerical summary of data comes out of the summarize command.


加急


I don't agree with the need for these helpers, and want to remove them.   Such convenience methods aren't provided by other classifiers in Spark ML and they leave no way to set parameters.


Strikes me that we should probably use the American "summarize" over the commonwealth "summarise" since the two are aliased.


`.Where(n => n == "Sequence")` ?


Can confirm that intuition. Changed the value to 36, and the sync is now proceeding smoothly.


What if you used `each_with_index` here?


@lzz5235 从 Rick Wash 的 ... 可以找到一个 NetBSD 驱动和一些有用的链接。


s/目录/分类/g


Just a note.. most people use 2 spaces for indentation, not 4.  This is a style, not code, issue, but its important to follow a consistent style.  I generally follow [this guide](https://github.com/bbatsov/ruby-style-guide), as its an easy way to avoid arguments among co-workers.


we will keep this style of rescue as it is expected in the story


will fix it.


I don't like this commit at all. `WithSpriteBody` should be a basic thing that doesn't care about buildings, power state, building placement and such. And this is awfully specific - it ties it to player power state, to `IPlaceBuildingDecoration`, `Building`, `BaseProvider` and `INotifyBuildComplete`.


@miigotu I'm not trying to argue you on this, as you know better and have written the book on this, but some rules I've tried to pick up on in the past with these exceptions were:

- & = and
- If " , : ; - or any other punctuation are included in the TVDB name but are NOT connecting two words or letters, an exception NOT INCLUDING the punctuation's is NOT needed.
-If a punctuation IS connecting two words or letters, Like M.A.S.H. or S.H.I.E.L.D. , an exception MAY be needed.
- Based on the "Editing Instruction" on the exception page, SR will ignore (   ) around the years and Country at the end of a TV Series? Is this true? Example: Shows.Name.2010 -> Show's Name! (2010)
     So Ballers.2014 on any nzb site should have a proper exception of Ballers (2014) and () will be ignored?

If I can lay some "ground rules" I'll go back and start from the beginning. It really didn't take as long as I thought it would.


A one rail structured pipeline with fanout and fanin paths


Could this be improved with `each_with_index`?


Some sites auto replace & with and, some do not. This is regardless of the actual torrent name because on some sites we actually parse the page.

Usually if it's not separating a word like the apostrophe in it's, the punctuation doesn't matter.

We try to avoid as many exceptions that would provide identical results, but when in doubt we would rather have a dupe or 2 by erring on the side of caution than to not get results.


Es-tu sûr de ça?
Ça cible les classes certes, mais aussi les générateurs et les templates. Le masculin l'emporte ici.


Practice committing


This also work with with [reject!](http://ruby-doc.org/core-2.2.0/Array.html#method-i-reject-21)


@calebamiles ,we can fix the code like this, but we need to modify all the expect in the let block, because we still have another test case in the same context that shares the var definition


Can we change this to something along the lines of `Plays a charge-up animation on the actor when it's about to attack.` or something of the sort that explains what it *does*.


Good job!!!!


Wow, i have not used Opera in years, i used to have it installed and test melonJS with it, but when I changed my MBA couple of years ago, it just did not make it through :)


The remaining task is to add a flash or HTML5 image uploader for creatives uploads.


J'ai push a l'arrache pour sauvegarder, je vais l'enlever en effet. composer.json est bon j'ai changé la méthode justement.


You'll need to put this back. :-)


What does this do for us?


Can't see anything in initial commit


It's okay to store the entire date, but we'll only be searching/sorting on the year.


[Player]
ImmediateHoldLetGo=false


Wrong pattern to push code, weak SCM concepts. Commit an empty project first, then start working on it.


var express = require('express');

var app = express.createServer();

app.use(express.staticProvider(__dirname + '/public/andescandes.hp)
![canvas](https://cloud.githubusercontent.com/assets/210672/8769266/37940936-2e67-11e5-8681-afb4f9e43d4c.png)
'));

app.get('/', function(req, res) {

    res.render('index.html');
});

// spin up server home 606_goldmining
app.listen(8080, '127.0.0.1')


@dfish3r I started to take a pass at this, and thank you for following up. Problem I have for now, is that for some reason auto complete in IDEA does not work, which prevents me from knowing what's available and what is not. Is that because the schema is not published anywhere public? What is the best strategy to approach this?


There's no reason to assume that the user will order the searches this way.  "<2015,>=2014", "<=2014,>2013", ">2013,<2015", etc., are all valid.


Sample not simple....

s/Sample/样例/g

样例和开放源码


I don't see any error checking here.


The database field has an underscore, the search form does not.  Is this the same way other multi-word fields are handled?


Focus on streaming, but this would be very cool to have


用来阻止动态缓冲区溢出的开放工具对比


Please add a simple description.


This looks like test code that you probably want to remove. :-)


Explain to me again exactly why you're making this change?


Would it make more sense to `Require<WithTurretedSpriteBodyInfo>`?


This enables to  print into CLI


コーヒースクリプトしかなかったけどいいかな？


LGTM


Yeah, once it's ready for merge, i will :)


Woo! :)


It's 63 on OS X, but yes, looks like it's 36 on Linux. Added in da5e1272f783f535762ddf80e309355d138a61bd.


Where I can found all the presentation?
could you send the link, please?


Actually I discussed this with @ElijahCaine . We were thinking of specifying the format besides this field on the search page.. But yeah, it'd be better generalizing it :+1:


Please set members to null


Could see the whole project changed, specify reason for this. UI not good, need to learn layout.  Code undocumented. Standard Gallery practice for iPad not followed. Code not optimized.


Ah! You caught me :P


rax retry tests


Need a call to deinitialize in destroy ()


Also, get the app verified by me running on a device.


I like this commit. Good job


we may want to make this endpoint configurable (along w/ all the other endpoints in the system?)


None of the fields in the protein section have an underscore. So i thought of maintaining the nomenclature..


I don't know of any that have DVB or DVD but there might be something out there.  I've always hoped we could find a way to identify which type of HU was installed so we could present different options to them but so far I haven't seen anything.  Might be something we could just have the user select in the config.


Could see the whole project changed, specify reason for this.


This seems wrong, should be a URL?


@miigotu I get it now. I go through again at some point in the new future, remove all exact duplicates, doubles, etc.

What about (2015) and (US) (UK)? Do you think SR is likely to find more info with the () left out or to include them so SR exception look "nicer"?


we will add the previous generation mapping.


Yes, please submit a pull request. Feel free to credit yourself in the README file. I've never used Nix and (clearly) don't know my way around it at all. Thanks!


Replace with `matches`?


Rotation breaks UI.


Yeah, have also discussed this with @ElijahCaine . The lower bound will have the month and date as 1/1 , the higher bound will have month and date as 12/31. (I don't have the higher bound format correct, will keep in mind and change it in my next PR)


Can


学习中


I would say if it is already 'US' leave it 'US', if it is already '(US)' leave it '(US)', if there is both 'US' and '(US)' just leave 'US'

Dupes are the most important thing, and having exact matches here and on TVDB.


J'avoue, on s'est posé la question. Mais in fine, etant donné que personne dans l'equipe n'est vraiment familier avec Piwik, que tout le monde connait deja GA, qu'on est dans un timing serré et avec des ressources limitées, on est parti sur GA. Restons focalisés sur le renouveau de la politique française, on s'occupera du cas de Google après ;)


Ты заводишь переменный $firstnumber и $secondnumber, а в условии всё равно достаёшь данные из массива. Зачем?
И почему проверяешь на ноль только делитель?
По стилю всё хорошо, только на 7 линии косячёк.


This closes #1


Resolves issue #19


Resolves issue #18


Not sure, may want to ask @PEMapModder about performance issues.

On Sunday, July 19, 2015, Philip Shilling <notifications@github.com> wrote:

> Do you think an ExecutorService would do the trick?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RedstoneLamp/RedstoneLamp/commit/8b9ef386141946ca6f7f5495959355cee582d43e#commitcomment-12245036>
> .
>

--


This commit does effectively nothing since the base `cmd` is overridden on all OSes.


Does this only occur for 5.4 or perhaps also 5.3?


dsf


After re-reading the [orders documentation](http://docs.printchomp.apiary.io/#reference/orders/orders/create-an-order?console=1) I believe that each array contains a front image(required), and a back image(optional) for your order. So for an order with multiple image parts I think it would be something like this
```
[ // images for first part of order
  {front image},
  {back image}
],
[ // images for second file
  {front image}
]
```


Old fileLocks() can filter locks by ip. But, not in this new code. Any concern?


Hmm, this file is using a different test format than the rest of decor, i.e. `expect(splices).to.deep.equal(...)` rather than
`assert.deepEqual(splices, ...)`.   Should we fix it to be consistent?


@acarella @ultimatezachgrafton do these comments allow the XML to render properly? I imagine they cause an error. These should not be copied along with everything else.


I'll murder you


Tabbing is off here.   Also, the example I see of `ObservableArray` pass the data to the constructor, so it's probably more canonical, efficient, less code, etc., to do it that way:

```js
this.source = new ObservableArray(this._source.map( function(item) {
    return new Observable(item);
}));
```


seems like this test case is missing `//~ ERROR` messages...?


Excellent. I added the comment.


also, if this is a cross crate test, isn't it missing an `extern crate` etc?


ACCESSORY_Baphomet_Hat = 1311,
[ACCESSORY_IDs.ACCESSORY_Baphomet_Hat] = "_바포메트투구",


Thanks for your suggestions. I will change them, as they are indeed more compact and easier to read.


We tend to use this now

```
var React = require('react');
var {PropTypes} = React;
```

Which can become this with ES6 imports

```
import React, {PropTypes} from 'react';
```


authenticationService.IsAuthenticated( ... is not necessary here


I don't mean to be a stickler, but is there a reason we're not pinning this to the commit? It seems like that was the convention here


seems like we could reduce code duplication here with a helper method, but otherwise looks good


There is a constant race condition going on between idea and eclipse, both of them are shuffling the imports. Yesterday I resolved merge conflicts and most of them are shuffled imports.


seems like we know the answer now...?


yes, this looks correct, but not perfect.

I would like to have one document.ready function.


Makes sense, OK


Sure


forgot to modify code fix provider. will do so later today !


Nice progress. :) Are you ready for a first PR?


@vcunat Ah, good point. Fixed in 4d36b10.


it would be great to have enum also for this values: Recruiter, Candidate


Wow...we really haven't been needing these here?

If not, I'm guessing this is the sort of clarity you're trying to bring to this bit of the code?--as I think reasoning about those not being needed was previously harder...mayhaps?


lgtm


I agree. No more pushing to the master directly.


when you don't need to access to loop index `i` it always better to use `foreach` loop


... disgraceful


I understand that this is refactoring, but can both AVro and Json key/value be valid for a job.


Thanks for this :)


From looking at https://github.com/harbalk/delite/blob/4652d7f2a0e00ce78ba5e68a62f832efe4111252/tests/unit/all.js it seems you broke the indentation rather than fixing it.


TeamCity LabkeyRelease15.2 :: CDS postgres 9.4 [Build 11](https://teamcity.labkey.org/viewLog.html?buildId=261742&buildTypeId=LabkeyRelease152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:35:14
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


Spelling looks good


Remove cast.


Done in effbfc83 thank you @lelouch22 :+1:


We should store `sigma_t` in `values`.


See http://seclists.org/oss-sec/2014/q3/174

From MITRE:
> The vulnerable parts of these two Gems seem to be direct copies of
code from something called "The Backup Ruby Gem" and thus the
codebases are not independent.
>
> Use CVE-2014-4993 for the report about both backup-agoddard and
backup_checksum.


LGTM


Serious business, guys :D


It appears in the example to be an array of files rather than an array of arrays of files.  But whatever it says!  I just flagged it because it looked like an easy mistake to wrap an array in an array.


That's fine though. Back then, `nsis_build` specified whether to use the official NSIS version (ANSI) or the  fork (Unicode) to compile a script. In NSIS 3.0 this is specified within the script, not by choice of compiler.


I would use cond, block, label, pat, and the strs, but leave the context, width, and offset (which is your first option).


Yeah. I have an updated version of all of this in https://github.com/hapijs/joi that I want to pull in. Things are just...busy right now.