Hm, the intention here is for the first loop to wait for the device to appear, and the second loop to check if it is actually  configured... I.e., the condition:
`                if (streq(l->state, "configuring")) {
                        log_debug("link %s is being processed by networkd",
                                  l->ifname);
                        return false;
                }`
should make sure that we don't return early.

The difference your patch introduces is that we will now also wait for links not managed by networkd, was that your intention?


unsigned


space after instr,


Matching flow is as follows:

- If database is specified explicitly as prefix for table name (e.g psql.nation) then requirement for table in that database will be generated. Note that database must have a table_manager with type matching table manager of a table or error will be thrown.
- If no database is specified explicitly then if there is only one database with table manager of type equal to table type then this database will be picked up.
- As fallback database to which test query would be send is used. Database type manager type vs table type checking is done.


Use instr.EffectiveOpCode() here instead and compare for equality.


fix spacing in this file


Check this diff for an example:

+    if (border_mode == 'valid' and subsample == (1, 1, 1) and
+        direction_hint == 'bprop weights'):
+        # Special case: We are asked to use GpuDnnConvGradW. We need to set
+        # up a suitable 'fake' convolution to compute the gradient for.
+        img = gpu_contiguous(img.dimshuffle(1, 0, 2, 3, 4))
+        if conv_mode == 'conv':
+            # We need to flip manually. These 'kerns' are not the kernels
+            # that would be flipped by conv_mode='conv' in GpuDnnConvGradW.
+            kerns = kerns[:, :, ::-1, ::-1, ::-1]
+        kerns = gpu_contiguous(kerns.dimshuffle(1, 0, 2, 3, 4))
+        shape2 = shape_i(img, 2, fgraph) - shape_i(kerns, 2, fgraph) + 1
+        shape3 = shape_i(img, 3, fgraph) - shape_i(kerns, 3, fgraph) + 1
+        shape4 = shape_i(img, 4, fgraph) - shape_i(kerns, 4, fgraph) + 1
+        out = gpu_alloc_empty(shape_i(kerns, 1, fgraph),
+                        shape_i(img, 1, fgraph), shape2, shape3, shape3)
+        desc = GpuDnnConvDesc(border_mode='valid', subsample=(1, 1, 1),
+                              conv_mode='cross')(img.shape, out.shape)
+        conv = GpuDnnConv3dGradW()(img, kerns, out, desc)
+        return as_cuda_ndarray_variable(conv.dimshuffle(1, 0, 2, 3, 4))

This is inside the dnn_conv3d method. Do similar for the gradi.


"1MB ought to be enough for anyone" :)


Multiple table manager definitions for same type.


I do not get this method name


"Jit" is a crappy name, even thought we use it to talk casually. How about "JitCompiler" or something instead?


Oh - I did not know that. Do presto guys use this. Or they keep using guava?


@prettyboymp after 1.3 we were using GH releases to track updates. Can you update this and do a release here?

FYI, I had a 1.6.5 release that was draft (because I always seem to forget to publish) that I released so this is closer to .org now.


nice, ack


`StringJoiner` was introduced in Java 8, so strictly speaking it's only missing up to Java 7.


Please see the raw dataset because the data is too big to be displayed


again watch ur spacing (@post.id) )


please change color to blue


@skaraga-coder change to blue


Version 2.3.5(?) is not available and the vulnerability has been available since 2014-09-08. Not sure how to write "secure_version" in this case. Any ideas @fgeek ? : )


!blocker I don't like this...


@onebone 여기 잘 고친거 맞나 확인좀 해주시면 안되나요? :heart: :heart: :heart:


!blocker I don't like this either!


Ok


Probably... C code isn't my strong point :)

Have you tested it since you made the change?


Do we need some javadoc here?


Well well, this is not the optimal algorithm, is it?

!blocker Use the a better algorithm


Use more meaningful error message. Like:
"Invalid syntax for table name. Expected <database_name>.<table_name> where <database_name> is optional."


i wouldnt comment stuff like this, just look in schema for that.


:ok:


put on one line if its one line


put on one line if its one lined


動作確認できました。


Something wrong with indentation here. That file uses tab indents, not spaces.


Thanks for the hint and the support.
As you said here is probably not need but I'll test the alternative.


watch ur spacing in the curly braces


this function can also reside at top level making this one shorter


Left align is the default. You can remove this.


do you use this, I think it is better to don't drag jar dependencies if it is not needed


*I'm super confused* - hasn't it always checked SAL? I've been working on [a whole project related thereto and entirely built thereupon](https://github.com/ariccio/SQLite-Test-SAL)?


While I agree that this is surprising, this is not the proper fix.  Collapsing the last dimension buys exactly nothing in terms of execution speed and the collapsing code is costly.  It would be better to bail out of the dimension remove loop if nd gets to 1.


Instead of `find_by` you can use `find`, which searches for an instance based on its id. It would look like this...

`@apartment = Apartment.find( params[:id] )`


jjjj


Pretty sure different people prefer different styles here. I myself prefer the way you changed it. But appreantly the original author did it differently.

Starting an actual discussion on this level is probably bikesheding... at least I do not see a major gain in discussing it...


validate that TableDefinition.class matches table manager type here and in line 54


In ES6 `finally` do not recieve the resolved value, nor the rejection reason as argument.


@mbernat Yeah, but it's a bit messy later so that this can look great :D


can you paste the curl command you used as an example just to help debug?


@danielblazevski

The trick turned out to be that the netcdf "getVar" routine requires a contiguous block of memory to work with. So I created a 1-D array that had space for the 2-D data, used getVar on that, copied the result to a more useful vector of vectors and then deleted the 1-D array.


I wonder whether this line-reading could be refactored too, since it's duplicated ten times. Perhaps not possible though.


Can use LockSupport


how do u do that


hi


기존 컨벤션에 맞게 마지막에 콤마 붙이시는게... (깔 게 있다!)


done, done


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18349/testReport/) for this commit**


:help:


I used this one:

`curl -X POST -d '{"url": "http://www.mojotech.com"}' -H "Accept: application/json"  http://localhost:8989/sites`


:sos:


done


Done.  :)

On Mon, Jul 27, 2015 at 9:32 AM, sareg0 <notifications@github.com> wrote:

> Hi @melissarebooted <https://github.com/melissarebooted>, is this file
> necessary for being committed to the repo?
>
> Do you think you could remove it?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/melissarebooted/skillcrush-104/commit/64f09a797757df3135b12578ca29f18d41c9f12c#commitcomment-12372184>
> .
>


:fire:d


lgtm % comments


@zhouyuan you're hiding an error code here. I'd rather the prefetch_data() only handles the range related stuff, not call get_params() here, just cherry-pick the range param.


`using CompiledShader = void(void* state)` and then use `CompiledShader*` throughout. IMO it's much more readable on both ends.


tset


sorry I didn't catch this earlier. you can't hardcode `plot.ly` since folks might be using this from different domains that they're running plotly on. you can find this information via the `session.py` module. `get_session_config()['plotly_domain']` should be what you want. It'll return something like `https://plot.ly` (can't remember if there's a `/`). In general, we need an update on how we handle these strings, they're pretty fragile. This is what we're working with for now though.


Ahh, I see why it might be wonky, you'll want to use either 136 or 196. Also, you can just set it for the heading style and the cells will fall in line with the same widths.


Based on the man page, lgetxattr does not NUL-terminate the string. Instead s specifies the length of l. And I'm not sure that value cannot contain zeros. So memdup should be used instead.

Also, please change NAME_MAX to sizeof(l) in lgetxattr() call. It is less error-prone that way.


We can remove `jsDoc` rules from yandex preset, how is that sounds?


Couldn't this just be `from octoprint_authentise import printer`?


Looks good!


Wow, those files are huge.


コンパイル問題なかったです。
コードもいまのところ問題ないと思います。


what am I going to do


Also, shouldn't this take an actually type as a param, not `void`?


in the new design, the batch should not do that and is not allowed to do it, right?


Should work just fine with the way I have done it also.


:camel: (the backwards compatibility camel) this isn't backwards compatible, we need to keep `width` and `height` as optional.


at least somebody noticed. the fact that you don't notice up front is extremely troubling.


@dukesrg for Unicode font.. I suggest just one with CJK support so all characters included already, and ready for use. And for language codes i prefer to let user set it up, instead of auto setting. (I know many guys in China have a J/E/U console.)


For a PVR API bump, you also need to update https://github.com/xbmc/xbmc/blob/master/addons/xbmc.pvr/addon.xml


You've skipped the "**:**"
```python
def add_player(self, player_key, team_key):
```


Services can't use an angular's `$scope`.
So I define myself one variable to act inside the service as an angular's `$scope`.
I use it only for basic allocation, and find it kind of consistent like this.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18351/testReport/) for this commit**


No, we do not need to pass mc.
We can pass a boolean that says whether we support multiple hops which will be generated in this case with ((mc != NULL)) and then is_mech_allowed() needs to know whether the mechanism requires multiple steps. We'll have to hardcode that for now, as GSSAPI has no way to tell us that...


Both the Buffer toolbar button and the keyboard shortcut now toggle the visibility of any open overlay (if there's no open overlay, they continue opening a new one).

@djfarrelly I'd love your thoughts on this, especially if there's any edge case I haven't thought of :)

Testing:

- Check that if no overlay open, clicking the Buffer toolbar button opens a new overlay, and subsequent clicks toggle its visibility (hence instant feedback, and any data in the overlay is preserved)
- Check the same thing happens when opening that overlay from any embed (new overlay gets loaded, then clicks on the Buffer toolbar button toggle its visibility)
- Check that when an overlay is *hidden* (after opening it and clicking the Buffer toolbar button), pressing <kbd>Esc</kbd> doesn't close it (it isn't closed if pressing the Buffer toolbar button again brings it back rather than loading a new overlay)
- Check that if an overlay is *hidden*, clicking any embed button will first close the hidden overlay, before opening a new one with the embed's data pre-filled


Well, you could take it one step further and simply pass a function for processing the next line, but not sure I feel like spending more time on this :-)


`(i >> 0)` (my time for OCD :V)


I don't see any change is that direction in the latest version of this PR. Did I miss it?


Cool.  I think it was working for the 2D array, if I recall correctly.  But was definitely not working using only a 2D vector.  I was looking for a workaround to use only the vectors I had defined, but perhaps that's not possible (unless maybe using malloc/calloc or something for vectors...).  But what you did shouldn't slow things down and the arrays are deleted right away anyway.  I'll incorporate this with the main code base.

I've been doing a test run of he wdot module with inputting both your aorsa E-field and the corresponding edqsk file.  Before I just put your E-field and whatever eqdsk file Fred had.  1K cores + 3 minutes is what I asked edison about an hour ago, and still in queue...


I wasn't sure whether to pass those through or not. I believe jQuery's promise.finally does pass those through which was what I was modeling against at the time.

I can certainly modify this to not pass those arguments in.


Excellent work keeping the `application.example.yml` in sync with required config for new developers/environments benefit, well done.


Agree with @dgenr8.


@knbk @timgraham Isn't that highly backwards incompat? Unless I missed something this seems like a nogo to me. Did any discussion happen about this somewhere?


@daducci Thanks for the quick reply.
I reverted numpy version to 1.82 and removed .dipy, and tested again.
Both issues have been solved.
The modifications looks perfect.


@Syphurith Ideally is to set the default console language on the first start and anyway left the setting available to user.
I already got an idea how to quickly integrate Unifont :) CJK is already there!


Just one question. What is this branch for? I think I remember that you had something like Gantt charts planned for some future version.


Consider using the model objects in `*_path` helpers, this would also work:

```ruby
redirect_to topic_post_path(@post.topic, @post)
```


Update files


Did you delete `jsonfield` by accident?


Maybe this link doesn't belong on the homepage. It only allows you to add a tenant to an apartment with id 3. Best left to the individual apartment show pages which can pull the apartment id from the URL.


I think this commit is a good place to improve test descriptions. Perhaps it would be slightly better to  use "should 'return XYZ commodity code given <inputs>" or anything else really, because the current description is not adding much value. What do you think?


This should be `play.ws.ssl.enabledCipherSuites` to reflect the examples.


Oh great @unpairestgood, this is very interesting. I look forward to implementing all that ... Very good Paul


while the current way is 'easy' for programmers its not very efficient on memory/file space.. just food for thought.
you could store this as a delimited list.. then just unpack/pack when read/write: `pushbullet_settings = 0|1|0|0|0|0|0|0`
and then if you ever add a new setting you just add it at the end, and you can do a simple string length/item check to see if it exists or default to a value and iterate x times.


加油


done


Hey @rplessl

Is there any particular reason why you require puppetlabs-apt >= 2.0.0 ? This might conflict with other module's dependencies.

Thanks!


A couple recommendations:

replace
 "These experiences are typically learning experiences, but the API can be used to facilitates(remove s if you keep this word) communication about any kind of experience"  with "This specification was developed with learning experiences in mind, but it is understood many other kinds of experiences could be tracked using xAPI"

-just wanted to get stronger learning language in there - massage if needed

"guidlines" should be "guidelines"

Otherwise I say +1


한줄이라서 아닌데요? ㅋ


I just check the installation myself and the status is ok at the end:

# dpkg -i keepconf-1.2.00.deb
Seleccionando el paquete keepconf previamente no seleccionado.
(Leyendo la base de datos ... 184600 ficheros o directorios instalados actualmente.)
Desempaquetando keepconf (de keepconf-1.2.00.deb) ...
Configurando keepconf (1.2.00) ...
Procesando disparadores para man-db ...
# keepconf -V
keepconf version 1.2.00
# dpkg -l | grep keepconf
ii  keepconf                              1.2.00                             all          tool for backup and track files from remote hosts

Can you send me your email address for deep better into your particular case?

Thanks,


Needs to be confirmed.


Why is line 92 in the evaluateFinalScores needed if it is appending an empty string?
How are you defining, "Winning by a nose?
What if the scores are equal?


you may want to cleanup the body.. stop people from doing stupid things/encoding it so something in it doesnt break your post..

`body = msg.strip().encode('utf-8')`


This also needs to be confirmed.


@chrisscott, I'm not sure what you mean.  I see the tags in git and on .org.


@Aran85 I wonder if this is the correct approach, I wouldn't expect formatter() flush to dump anything if no data was written.


We must remember to change this after we have an appropriate icon.


Octave builds if I change `suite-sparse` in `suite-sparse421` and the test passes!


Are you actually allowed to inherit from std types? I have a feeling you're not supposed to do that.


This also broke automated mode, it will be fixed in the next release.


:D


Very nice :+1:


:heart: :heart: :heart: :heart: :heart: :heart: :heart:


This breaks everything under `pkgs.gnome3` (and probably several other packages) depending on libsoup. Random example:

```
~$ nix-env -iA pkgs.gnome3.gnome_control_center
...
checking for SOUP_GNOME... no
configure: error: Package requirements (libsoup-gnome-2.4 >= 2.25.1) were not met:

No package 'libsoup-gnome-2.4' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
```

[This](https://github.com/nckx/nixpkgs/commit/72ffcbbc8151c6a700ddb54b2dbaa57237bc31fd) fixes the issue for Gnome 3 only, but I'm not sure if that's the best approach.


Awesome Paul, but i think we will drop out the ***json_builder*** since it isn't supported by Yahoo ( which pitty though )


Mkay then, let's leave it as it is :)


done


maybe a note about how `you must have admin privileges on the file for this to work`


This is a public repo


Seem like this should be a PR for master...


This whole thing is great!  +1


Glad to see experimentation with `before_action`s and `get_authorized_post`. Make up your own mind about whether you find this DRYing up is worth the trade-off in making it clear what the dependent actions do.

For some developers they find this usage of populating the most important instance variables in `before_action`s hard to follow. Others like it.

There's a middle ground which is to tweak this so you call `@post = get_authorized_post` as the first line in each of the dependent actions. That way you get the DRY benefits and you make it as clear as possible for a developer to follow the steps executed in each action.


I appreciate the mention @johannesboyne thanks!


Ok, in this case though I would rather initialize a little local configuration structure allocated statically on the stack and intialized at start accordingly to cfg and req->proxyreq

Something like:

struct mag_req_cfg {
   bool use_session;
   bool send_persist;
   const char *auth_header_prefix;
}

void mag_req_cfg_init(struct mag_req_cfg *mrcfg, request_rec *req,
                                    struct mag_config *cfg) {
    if (PROXYREQ_PROXY == req->proxyreq) {
         mrcfg->use_session = false;
         mrcfg->send_persist = false;
         mrcfg->auth_header_prefix = "Proxy-Authenticate";
      ... etc...
   } else {
         mrcfg->use_session = cfg->use_session;
         mrcfg->send_persist = cfg->send_persist;
         mrcfg->auth_header_prefix = "WWW-Authenticate";
      .... etc ...
   }
}


17 additions and 159 deletions.

That's what I like to see!


You don't need to include `edit` in your PUT route. You do need to include it in the GET route for the page containing your edit form, although in your app you incorporate that into your Apartment show page.


Oh wait I didn't see the many additions in the previous PR. Still, good to remove stuff!


I don't think that `?` belongs there? `*` matches 0 and up, and `?` matches 0 or 1


(I made edits on the previous post to clarify)


this logic seems overly complicated, why do we need to check this?

why not just shoot out a nice warning when `share_key_enabled and current_plot_options['world_readable']`?

I don't think there's anything wrong with enabling the share key if the plot is public, it's just not very useful?


@adrienne-pind-invenia: Correct me if I'm wrong, but I think if we use `cleanup_easy_context(ctxt)` in `finally`, that would break the persistent connection when we call those functions.


We should have an explicit case for `EInRangeStrategy.INTERPOLATE` also, which will be the same as the `default`.


No delete route! Although I'm guessing you didn't get to it because you time-boxed yourself, which is 100% okay!


Thanks :)


Is MIN_THREADS used?


Including plsnts, etc.


Pretty sure it's allowed but often considered bad style (the latter which I wasn't aware of when I suggested this construction). I think it's fine in this very specific use-case, though.


So this commit is really bad.  Since this commit... This commit will undo the changes that I have done if merged back into develop/master.  I want to remove this commit from the repository.


At the end of https://groups.google.com/d/topic/django-developers/B68wBMpGX20/discussion. I didn't see any practical problems, but of course I could have missed something.


In fact, I think we should assemble `current_plot_options` completely and just raise a warning. I don't think there are truly conflicting plot options, are there?


IMO, this should be a major API bump, as addons break, if their code will not be updated. @opdenkamp?


@marcinkosiba I took a closer look now.  I found two problems with this approach.  I think it could still work, but I'm not sure it's not better to keep the test part separate in the `AndroidInstrumentationTest` class.

1. The name of the test rule has to end with `_test`, so we have to rename this to `android_instrumentation_test`, otherwise it won't get picked up by `buck test`.  Unless we want to change the way buck recognizes test rules, but I think having rules end with `_test` is most understandable for the users as well.
2. Is there a way to have a rule build itself, before the tests are executed?  When having `android_instrumentation_test` separate and `android_instrumentation_apk` as a dependency, the apk is built automatically, but when everything is in one rule, the apk is not built.

What do you think?


Because you didn't create a GET route for your edit form, clicking this link results in an error. If you update your controller you should be fine.


I'm totally in the wrong here. By using finally `cleanup_easy_context` will get executed at the end regardless of whether an exception is thrown.


I think self->contents is freed later on? So if you're trying to free non-malloc'd memory it will goof, so you might want to change this to not free the contents or something.


:cactus: you can't add a new required positional argument to `plot` this will break a lot of folks' code. This is definitely our bad if we somehow aren't testing this?! Appears to be tested: https://github.com/plotly/python-api/blob/ee0590572af383c0bde4c45b83602b47c344e3b6/plotly/tests/test_core/test_plotly/test_plot.py


Good catch!

This should be `username`.


#error


Heil the travis master thank u based kiljacken


You can measure this in CBot, using object.destroy(), object.busy() and abstime()


:cow2: We should just keep `_plot_option_logic` idempotent. Then we don't need this at all :smiley_cat:


Just got caught out by this change - does make more sense this way though.


You can commit to nixpkgs master, thanks.


i think you didn't want to do the change here


and here


Never mind, they are all there. :)


EconomyS v5.6 FTW!


:cow2: please don't delete `TODO`s in the code unless they've actually been cleared. We should really be using a different method here. If you want to fix it, consider using `six.moves.urllib.parse.urlparse`? https://docs.python.org/2/library/urlparse.html#urlparse.urlparse

Note that we need to use `six` because python 2 has `urlparse` in a different stdlib location than python 3. `six.moves` is just a handy way to still get access to the same function, indifferent to the python version you're using.


I found 3 functions which had finally blocks which I now believe should be catch blocks.


@henryju this means that from the jar file we won't be able to tell which version it is, right (for download, deployment, or publishing an in-between version e.g: for vote) ?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 213](https://teamcity.labkey.org/viewLog.html?buildId=262789&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 4, passed: 0 Build time: 00:07:17
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


done


It looks like some of these precalculate blocks are still used in the views in the master branch. Have they been removed in another branch?


@prettyboymp there is no 1.6.6 git release, but the changes are on master, it has a stable tag of 1.6.6, and 1.6.6 has been pushed to .org


What does this mean? How would I use it?

```
// package.json
  "jspm": {
    "dependencies": {
      ...
      "semantic-ui": "semantic-ui",
```

Would this "just work" by looking up in registry.json and resolving to the package override shown above?
How would I use this from my code?

Currently I'm using these imports...

```js
import 'semantic-ui';
import 'semantic-ui/css/semantic-ui.css!';
```

Thanks :)


Seems to be an odd error I haven't encountered yet. Would you be able to open up an issue against the project with this information? It's a bit harder to track as a comment on the commit. Thanks!


It still requires some time: Test of readiness of the system for TLS 1.1 or 1.2 and a more clear test of disabled SSLv3. The tests should be run easily, but with every automated test.

typo
%s/Hoever/However/

What is "soon": https://help.salesforce.com/HTViewSolution?id=000221207&language=en_US
> Starting in the first quarter of calendar year 2016, Salesforce will begin disabling the TLS 1.0 encryption protocol...

 (sandboxes in February and March 2016, production instances in April)

More clear:
If you must install PyOpenSSL on these Python versions FOR SOME REASON...
(There is no important reason for `pyOpenSSL` on a new Python, except dependency of another package.)

I want also to fix in v0.6.1 a regression caused by v0.6 in the test `salesforce.tests.test_integration.BasicSOQLTest.test_only_fields` with Django 1.8. The subject of test is less important, but the bug is really ugly. It makes a few hundred times repeated the same query about one minute until the exception `RuntimeError: maximum recursion depth exceeded` is raised.


Does status need to be propagated?


@cagryInside Do you know what the remainder of these calls to `interpolate()` are doing?

From a quick look I think `calculate*Deviation` are related to frequency-based transit, and the interval between arrivals/departures?  I'm not sure about that.  It would be good to understand what is happening here before we change over to the `PREVIOUS_VALUE` method.


missing gettext


In reference to https://github.com/mcmonkey4eva/Denizen/pull/32


gettext here


it is gonna break the build !
far from useless


não use 'this', caso precise acessar um item que esteja dentro da classe chame ele diretamente, caso precise mude o nome da variavel que você recebe por parametro. por exemplo...
void ChartGrid::setPen(const QPen& p)
{
      pen = p;
}


Ooh, any place I could read up on this? sounds interesting, will change it thanks :)


try adding the content type header.  You didnt set it on your request and as such the handler probably didnt infer it as json.  The `Accept` header simply says what type of response you will accept, but not what your request was, you need `Content-Type` for that.

    `-H "Content-Type: application/json"`


Mesma coisa do comentário acima.


Well using the build in visual studio test suit just returns a blank window for me.
And there is no documentation that I can find in the kodi docs about what kind of unit testing/framework is being used.


http://stackoverflow.com/questions/1452934/what-is-the-meaning-of-xxx

I think you'll only find `FIXME` and `TODO` in plotly stuff, i could be mistaken though. We don't have any dev-docs contributors guide information on it. These are the two most-standard (is that a thing? least-non-standard?) code tags though.


Aqui é impossivel não usar o 'this', então é tudo bem.


if true?


Le ToQuaternion() n'est pas nécessaire, c'est implicite.


Should the change to register_a_birth_test.rb be in this commit? It looks like the renaming of `embassy_result` to `north_korea_result` only applies to the register-a-death outcome.


@64FF00 :+1:


For this function, `finally` is needed because the caller has no idea of what `ctxt` is and has no way of cleaning it up. I think there's a few other functions with the same idea. Some functions are persistent and others aren't.


(8d6ba15f5ae134b02f1df2adda3b26e422a66183) This line has more than 100 chars (100 < 103) : fix(registration): Correct erroneous link for Zip export of EEC registration configuration (refs #5620)


Essa forma que você fez de pintura é a mais fácil, mas é a menos boa. você está repintando a tela toda a cada paintEvent. quando um mouse anda de um lado pra o outro da tela de pintura, ele ativa um paint event para cada movimentação do mouse, a melhor coisa seria só redesenhar o pedaço da janela modificado ( e fazer isso é bem dificil, por isso falei pra usar uma biblioteca pra ajudar )


Tente não comitar código comentado.


Was wondering why I couldn't see any info on the Apartment show page! I think you could easily implement this given you were able to display Apartment and Tenant information elsewhere in your application.


Sure, I'd be happy to.

[Tools:251](https://github.com/abarisain/dmix/commit/87ab84a2fb3a016c820a3e52460b37f6642694c3#diff-6a0ba79e4b103033be320b43f99fe6c5R251): The common code that makes sure the status is valid (which is a step beyond making sure we have a connection). If not, it will set up a connection lock, run the command, then remove the connection lock. We had two separate instances of this code (one in WidgetHelperService, one in RemoteControlReceiver), I've just combined these into one tool.

[PhoneStateReceiver:203](https://github.com/abarisain/dmix/commit/87ab84a2fb3a016c820a3e52460b37f6642694c3#diff-730e7b663b01eaab2f9e85b2c420ee5fR203): We introduce the actual fix.

If I was unclear or you require more clarification, don't hesitate to ask.


CheckStyle police. Methods have to come after constructors or else they remove your chest hair one by one.


You can actually do argue.add_argumnet('cluster'), and then it would automatically require it, so that you can avoid doing args.pop() and separating it from the reminder.


Thanks for spotting this out! I mentioned you in the commits so that you'll be acknowledged for that. Let me know if you have idea and want to collaborate on this code!


Missing gettext here too


Ahh OK, yeah that worked.  Thanks for pointing that out.


numeros constantes - o widget não funcionaria caso você redimensionasse ele - o tamanho do desenho sempre seria igual. será que é isso que você queria no código? não sei.


Well, they are in their own separate output so it looks like we should keep them separately but maybe mask the outputs to only install $out at the top-level?


when accessed over MTP. Fixes#95


Would be more useful to display a specific piece of information about the apartment (e.g., address) rather than just saying Apartment #3. Otherwise, hard to tell what exactly you're clicking on.


The problem is that the second loop just checks if *any* interface is already up. I. e. if I have an "eth0" already up (e. g. from NetworkManager), and I now add a "veth42" and want to wait for it with `s-n-w-o -i veth42`, then s-n-w-o immediately succeeds due to the second loop.

It indeed doesn't make that much sense to call s-n-w-o on an interface that isn't managed by networkd itself, but it works nevertheless.

The primary intention is of course to actually wait for the given networkd-managed interface to be up, regardless of whether another one is already up (that's what the documentation suggests too).


Pamela is right. I'd prefer it if we **don't** use jQueryUI. For sliders, Pamela linked to this: http://imagine-it.org/svg/sliderplugin.html

Perhaps you could take a look at that?


800 constante


foi só um teste pra desenhar uma linha de forma direta sem ter que chamar pela interface.


Why restrict to 2 or 3 digits, and not, at the end, have (\.([0-9)+)? to allow any number of digits? That's permitted in TTML and EBU-TT-D for example, and also works with the more limited spec in SDP-US.

Then you'd end up with `^(0[0-9]|1[0-9]|2[0-3]):([0-5][0-9]):([0-5][0-9])(\.([0-9])+)?$`


Connard


Having gone though a couple more commits, it looks like the change to register_a_birth_test.rb should be in the commit titled, "Rename register-a-birth/embassy_result to north_korea_result".


Missing gettext


@joekarl -- remember the reason behind this version?


Dot Net Induction/File Handling And Mails/Assignment21/Assignment21/ReadingCSV.aspx

form1??
Name should be proper.


why is this fixing anything?


It would be better to name it PNCConnectorImpl to be consistent


You can use postman to simplify interacting with the api as well. https://www.getpostman.com/


That's only for SVG. I'm fine with not using jQuery UI, but I'd like to use [noUiSlider](http://refreshless.com/nouislider/) as our other option.


erro meu.


#define ARRAY_LEN( array, data ) sizeof(len) / sizeof(data)
for(int i = 0; i < ARRAY_LEN(leg, legend); i++)


The term `Records` could be misleading here since `rule` objects can hold cross-record or cross-dataset validation statements. This is why in the `summary` method, for each rule, the number of validated 'items' is listed with passes, fails, ans missings. The number of items is determined from the dimension structure of the output.


Wasnt really aimed at you but rather still not having tests run on jenkins after years.

It is gtest based.


Incidentally, there's another bug here - it should permit 60 seconds to allow for leap seconds. Adding this as an explicit option gives:

`^(0[0-9]|1[0-9]|2[0-3]):([0-5][0-9]):([0-5][0-9])|(60)(\.([0-9])+)?$`


Is this intentional or accident?

See: https://hg.mozilla.org/mozilla-central/diff/e8afdde798c3/gfx/layers/ipc/PLayerTransaction.ipdl#l1.63


That is to allow the array to contain "https://www.theverge.com" and if you
open "theverge.com" the Portal won't open. The same goes in reverse.
On Jul 27, 2015 5:49 AM, "Israel Hill" <notifications@github.com> wrote:

> this is interesting.... why do you have to check item.indexOf(source) and
> source.indexOf(item) ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Project-Portal/Portal/commit/b02ef437d78704e3d5f6bd43c28723b88c6be73d#commitcomment-12371199>
> .
>


!blocker WAAAAAAA


`?` also makes the previous quantifier lazy. It does not just have one meaning.


Dot Net Induction/File Handling And Mails/Assignment21/Assignment21/StudentDataHandler.cs

Delete these unused blank lines.


Aqui está tudo sendo feito manualmente, mas no código do subsurface tudo virá de um YearlyStatisticsModel


Good - also use `@comment` in the `locals` hash on line 27 instead of `Comment.new`.


qual o propósito de 'flag' ser boolean? o que é o flag?


como disse era tudo teste, depois de ver funcionando eu iria remodelar justamente por causa de coisas como essa. Quando eu disse que tava mas ou menos pronto só era pra te mostrar que dessa vez eu vou participar mesmo.


@joehuchette, this is failing tests: https://travis-ci.org/JuliaOpt/JuMP.jl/jobs/72842293#L6704


linha em branco


Because you are iterating through all tenants (not just those in Apt #3), this link will not work for any tenant you click on that does not live in Apt #3.

You have access to each tenant, however, do you should replace that `3` in the url with their `id`.


We think @drjova can remove this line :wink:


Dot Net Induction/File Handling And Mails/Assignment21/Assignment21/Utility.cs

Read about int.TryParse() method and use it for parsing.


Pra quê um destrutor se não utiliza nada nele?


I'd leave the word "priority" at least in the description, as this sign has nothing to do with dangers at the next intersection as far as I know.
It just makes the road you're on temporarily a priority road until the next intersection (if it isn't a priority road already).

The categorisation of the sign depends on where you look it up, so either category should be fine:
* In Germany, it is categorized as priority sign, even the official name of the sign is simply "Vorfahrt" (German for priority) (see http://www.gesetze-im-internet.de/stvo_2013/anlage_3.html)
* In Sweden, it is categorized as warning sign (see http://www.notisum.se/rnp/sls/sfs/20070090.pdf on page 11)


Many thanks Nigel, it is fixed!


Ah, I get it, thanks :)


Maybe we should check here if the tunnel command did not finish with non-zero return code right away....


Creating a tenant will always error out because you are redirecting the user to the show route for Apt #3, but you don't have a show route set up.


Não entendi o motivo do pen, brush e flag.
pen e brush variam a depender do item que está sendo desenhado, flag é só um boolean que não me diz pra que serve.


@myleshorton What is the rationale for this commit? I cannot successfully run the new command:

```
$ git clone git@github.com:getlantern/www.git
Cloning into 'www'...
The authenticity of host 'github.com (192.30.252.128)' can't be established.
RSA key fingerprint is 16:27:ac:a5:76:28:2d:36:63:1b:56:4d:eb:df:a6:48.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'github.com,192.30.252.128' (RSA) to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
```

Maybe this repository is only for team members?


It's not directly related to this commit, but it looks as though register-a-death-files.yml should also include registrations.yml. It already includes registrations_data_query.rb but not the yml file that it uses.


You're welcome!


Porque setPen e setBrush estão como slots publicos?
No caso, esse widget de estatistica não deve receber nada de fora, a não ser os mergulhos que devem ser exibidos.


I've tested it, and it appears to work ok.


Nunca tinha pensado em não utilizar constantes no for, legal.


Argh same bastard different logins;)


I don't have a reference at hand (search ia 64 abi if you want more), but essentially, the compiler will try to align fields of size N on addresses multiple of N. This is needed for efficiency on Intel architectures, and is even mandatory on some CPU (Spark IIRC segfaults on unaligned 32 bit accesses). For example

    struct foo {
        char a;
        /* 3 bytes of padding will be inserted here */
        uint32_t b;
        char c;
        /* more padding will be inserted here so that an array of foo has each elements properly aligned */
    }


exato, não tava pegando ainda os dados do model.


@tonihele like this?


Thanks! I added quite a bit more to it over the weekend. At some point I'll put a little more effort into the AI as well (right now it just moves randomly and doesn't shoot).


This cause the SMACCM build-of-builds to fail:

``` cc1: error: unrecognized command line option ‘-std=gnu11’```

We are using "gcc-arm-none-eabi-4_9" though maybe the wrong compiler is being picked up on Travis. Any ideas what we can do to fix thi?


hey @andrewjgremmo did you want to put in a PR for this?


Porque o dialog já não é o ChartGrid, considerando que ele é um QWidget?
você pode fazer esse setup via Qt Designer , é só colocar um QWidget dentro do Dialog, clicar com o botão direito nele e ir em 'promote widgets'


It's run daily http://jenkins.kodi.tv/job/TestMulti-All/

https://github.com/xbmc/xbmc/blob/master/tools/buildsteps/win32/run-tests.bat


linha em branco


get { return "vn"; }
is correct


I SWITCHED TO THE BINTRAY PLUGIN GET OFF MY CASE


I'm guessing that you're adding this to ensure that scribe has a paramsparser to talk to, but it can also be checked by verifying that HasParamsParser is implemented.

```go
        op.Parameters, err = run.(modules.HasParamsParser).ParamsParser(modargs)
        if err != nil || op.Parameters == nil {
                panic(err)
        }
```


precisei dele pra testar algumas coisas. A maioria dos erros citados por vc, são testes. Só comitei esse código pra vc dar uma olhada de forma geral.


OK.


espaço antes do ( e após o )
foreach (YearlyStatisticData *data, dataList) {


Awesome. This, paired with an easy-peasy backup/restore process for MySQL is a match made in heaven! https://medium.com/@cobbers/backup-restore-all-databases-in-laravel-homestead-41475a3d7d7a


NEW: https://github.com/spaceone/pysaml2/commit/a9b85587aa0677b6df875dce4a5eddf7131cdcab

don't look into here!


BUT YOU SWITCHED THE DAY YOU WENT ON VACATION

OF ALL THE TIMES!


Would there be a way to just remove the self-reference type from the drop-down list so it's never an option?


erro grave.: Cada vez que você conecta as coisas aqqui, os métodos vão ser chamados uma vez mais cada vez que um index for ativado. primeira vez que passar por aqui, 1, segunda vez, 2. se eu abrir a tela 20x, iria chamar 20x esses mmétodos.


This form won't work because you don't have a POST "/tenants" route set up. You're already on the right track in your controller though. You need to tweak this form and that controller action (included a comment on that) so that they match.


não entendi o setFlag();


espaço em branco a mais


Eu deveria ter tirado, era porque eu tava mudando a cor da linha de fora da interface. Desconsidere esses erros, foram resultados de testes.


It's 0-indexed and the current implementation works as expected. In any tests I've run, all elements have a chance to be selected.


I think PGSERVICEFILE will get you directly the path to the file, not a directory. Per the documentation:

PGSERVICEFILE specifies the name of the per-user connection service file. If not set, it defaults to ~/.pg_service.conf


Use o YearlyStatisticsModel que já tá pronto.


All fine and dandy if people acted on it. But this has been left for over a month - it is time to force the issue and run on the normal trigger.


Use o YearlyStatisticsModel que já tá pronto.
Não utilize typedef em C++ ( ele não faz o que vocẽ acha que faz ).


Useless to test the deployment. I do not want to wait all theses actions to be done before testing connection to upload the archive.


Looks good.


Good comments and questions.
It sounds like I haven't done a good job of explaining how I intended new production instances to spin up.

My current (undocumented) instructions for creating a new instance are:

1. Install scitran via `./live.sh`. Currently, this requires editing `bootstrap.json`, ref #37.
1. Allow a default instance to be spun up.
1. Kill the script, edit `config.toml`, follow each section of the [configuration chapter](https://github.com/scitran/scitran#configuring).
1. Run `./live.sh` again to receive a configured production instance.

This keeps a couple qualities:

* No prompting by default; exiting with non-zero on fatal error. This makes the scripting (and any individual parts) much more amicable to automation. We [had this problem before](https://github.com/scitran/scitran/issues/11) and I'd rather not resurrect it.

* Zero choices made from "knows nothing about the project" --> "running something approximating a demo". The previously mentioned #37 interferes with that, which I intend to fix as soon as I have time. This is a quality I look for in all open source projects.

* Reinforces our ability to have a single source of truth for configuration. If we always spin up a default instance, *then* set ports, keys, etc, we will always have a project that we understand how to reconfigure. I've found that failing to do this tends to result in state hiding away in unexpected places & results in team/admin frustration.

* All files in `templates` are (ideally) never edited, unless something unavoidable in production is required. This reinforces the team's ability to understand the full range of production environments and avoids maintenance burden. Anything important that requires a template change (eg - ssl terminator?) should be surfaced as tickets and closed by improving the templates + config keys. We must have the ability to change templates in arbitrary ways at any time, and I don't want each production instance to maintain what amounts to a fork of scitran.

What this doesn't cover well (additions to list accepted):

* Currently, bootstrap users & example data is unconditional. If you want to have an instance without either of these, manual remediation is required after completing the instructions above. Depending on your reaction to this limitation, I'll file a ticket about making some or all of that part optional.

* I haven't made the above workflow clear in `README.md`.

* I should add the contents of this extensive comment to a rationale doc somewhere.

---

Regarding the default secret, I do intend to basically sed out `change-me` for a random password when copying over the `config.toml` template. This should be a ticket; I'll file one shortly.

Regarding the shared secret, I would really rather not print superuser credentials to stdout by default. There is a [`./live.sh secret`](https://github.com/scitran/scitran/blob/b51838fd41b2e15c0a3fa3112e25090dbae417eb/scripts/3-targets.sh#L60-64) target added as per Gunnar's request, but if we really want the option I could add an environment variable that prints the secret right before launching. `SCITRAN_PRINT_SECRET=1 ./live.sh` or similar.

Regarding `code/www/app/custom/config.js`, the browser template is [web-config.js](https://github.com/scitran/scitran/blob/master/templates/web-config.js) and is [placed](https://github.com/scitran/scitran/blob/b51838fd41b2e15c0a3fa3112e25090dbae417eb/scripts/1-install.sh#L144-L146) in `code/www/app/`. @rentzso should have an email from me with title "Web Spec" detailing how to make sdm compatible with the new infrastructure. Among other things, this was done to mandate there be no infra-visible distinction between any scitran web apps. I will file a ticket for documenting the 'spec'.

---

Whew! The more I wrote, the clearer it was I should have written this sooner.

I hope this is helpful; let me know what you think :)


Essa QList não deve existir, use o YearlyStatisticsModel.


*calona* not canols


No caso do flag era só pra teste. O pen e brush eu tinha colocado ai, pra não ter que declarar como variáveis locais em cada função que fosse criar, não tinha pensado no que vc falou.


1 I got what you said. I will reimplement the application.


Can you please give the mouse it's own enum?


HOLIDAY*


I think you have to take OS X into account, there, the path is:
~/Library/Application Support/piu/piu.yaml (just use ~/Library/Application Support/ instead of ~/.config on Linux).


done


WHAT'S THE DIFFERENCE?


This is to add Bootstrap styling to the "successfully updated" confirmation message after updating Joomla via com_joomlaupdate.


Sure, will do now


I see, will search around, thanks a lot for explaining :+1:


@kidatsy ah yes, forgot about this one :smiley:


YOU SPELT IT WRONG YOU ILLITERATE AMERICAN


removed


Good call. I've documented changes I intend to make to the use of this template in #37; would be interested in any comments there.


baka


Ok, não sabia disso valeu. A idéia do ChartGrid era criar um widget que pudesse receber uma coleção e desenhar um grafico, assim poderia ser usado mais pra frente, mas iria ser melhorado em uma versão posterior, isso é claro depois que eu tivesse terminado.


I thought that was hard for some reason but looking at it again I don't think it is. I'll give it a shot.


ok.


Yeah... I've been up for too long, that commit message was awful.


This kind of line wrapping will cause lots of diff noise when the README is changed.


Beleza.


imho nowadays with wide screens upto 150 can be convenient.


We should add a `FIXME` to remove this dependency once `react` fixes the issues this plugin solves.
The author claims this plugin and its repository with disappear once the issues are solved.


```cpp
object destr = radar(Destroyer);
produce(destr.position, 0, Titanium, "");
wait(1);
float start = abstime();
destr.destroy();
while (destr.busy())
{
	wait(0.01);
}
float end = abstime();
message((end-start)+"");
```

0.00 - didn't work :P


era só retirar o if.


You are free to have your opinions in the plugins you maintain. My opinion is 120 characters. Code style debates can be a rat-hole


Much more readable.


Tudo acerca da variável flag foi para teste.


@marcinkosiba Would you add this to the ExecutionContext?  Add it for all tests in `TestCommand`?
`ExecutionContext` is also an Immutable, and `AdbHelper` needs the `ExecutionContext` as parameter, which I think would make adding it a bit awkward.

I think the best way to avoid creating a new object in so many different places would be to either create it in this class in the constructor, or create a helper method to create it.  This object could then be passed to the ApkInstallStep and the InstrumentationStep.  Thoughts?


Why do you dispatch to the context in set_property() and not here? Also why don't you just call this function here from set_property()?


Issues filed: #45, #46


OK.


Porque não? o que ele faz?.


Good idea, but please do a separate commit to change all properties to have a #define for the default value. Let's keep it consistent :)


woohooo!  how long before we can d/l binaries from julialang.org?


Ok.


Don't you also want to check if the setting actually has an effect? By running a pipeline and checking the position update callbacks?


count +1


Thanks pushed a fix


@mkortstiege another ping - are you around atm?


Default image is big.


And checking the *times* between callbacks I mean


You can specify the service= in addition to the --host and --port parameters. The explicit host and port will take precedence over the values in pg_services.conf, the other values will be just appended.
For instance:
cat ~/.pg_service.conf
[foo]
port=5432
host=127.0.0.1
dbname=bar

psql -h foo.example.com -p 5432 "service=foo"
will still result in a connection to foo.example.com and not localhost


Good Commit


Some of your tests report compilation warnings. Please, get rid of them.


Added these because I'm working on mouse wheel right now, I'm doing research on it so it will be a bit


Ele cria um tipo novo baseado em um outro tipo, só que no C isso faz sentido:
struct statisticsData { ... };
pra você usar no código você faz
struct statisticsData blah;
ai você usa um typedef pra não ter que ficar escrevendo 'struct' sempre,
no caso de C++ você pode fazer
struct YearlyStatisticsData {}; e usar diretamente o YearlyStatisticsData, sem precisar de typedef.


count is used not only 2 places it also used more than 2 times.
OK as of now.


If it were me and I were doing it again, I'd probably make this an
Optional<Integer> containerCap;

So we could have Optional.Absent if it wasn't specified (Integer.MAX_VALUE was a bit of a hack really).


hope this code is tested with SDN controller


Done (8129a40). Thanks!


@Memphiz, busy with other things right now.


this is great addition. I'll gladly accept PR, and make appropriate changes to sample.


I have to admit that amber mask is hard to remember but once we get used to it, it's very convenient.


One you have the tunnel established, you can use requests, that can output the response to json natively.


Declare this variable below nearer where it's assigned to.


- suggestion: in chats.js, i found a function .push() to add new data in array rather than for cycle.


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


26:1: I100 Imports statements are in the wrong order. from flask_login should be before import pypeg2


This looks very much like the GzipFilter from EhCache:
http://svn.terracotta.org/svn/ehcache/trunk/web/web/src/main/java/net/sf/ehcache/constructs/web/filter/GzipFilter.java

IANAL, but shouldn't this include the original license headers?


38:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
45:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_SOLR_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_XAPIAN_ENABLED
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 45
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 45
45:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 45
45:1: F999 redefinition of unused 'CFG_LOGDIR' from line 45
45:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 45
45:1: F401 'CFG_XAPIAN_ENABLED' imported but unused
45:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
45:1: F401 'CFG_OAI_ID_FIELD' imported but unused
45:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
45:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
45:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
45:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
45:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
45:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
45:1: F401 'CFG_SITE_RECORD' imported but unused
45:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
45:1: F401 'CFG_INSPIRE_SITE' imported but unused
45:1: F401 'CFG_LOGDIR' imported but unused
45:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
45:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
45:1: F401 'CFG_BASE_URL' imported but unused
45:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
45:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
45:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
45:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
45:1: F401 'CFG_SOLR_URL' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
45:1: E402 module level import not at top of file
46:6: E126 continuation line over-indented for hanging indent
89:1: E402 module level import not at top of file
90:1: F401 'get_most_popular_field_values' imported but unused
90:1: E402 module level import not at top of file
91:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
91:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils
91:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
91:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
91:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
91:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
91:1: E402 module level import not at top of file
92:6: E126 continuation line over-indented for hanging indent
96:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors
96:1: F401 'get_fieldvalues_alephseq_like' imported but unused
96:1: E402 module level import not at top of file
98:1: E402 module level import not at top of file
99:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
99:1: I201 Missing newline before sections or imports.
99:1: F401 'create_record' imported but unused
99:1: F401 'record_xml_output' imported but unused
99:1: E402 module level import not at top of file
100:1: I101 Imported names are in the wrong order. Should be get_bibrank_methods, is_method_valid, rank_by_citations, rank_records
100:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.record_sorter should be before from invenio.legacy.bibrecord
100:1: F401 'rank_by_citations' imported but unused
100:1: F401 'get_bibrank_methods' imported but unused
100:1: E402 module level import not at top of file
105:1: I101 Imported names are in the wrong order. Should be calculate_reading_similarity_list, register_page_view_event
105:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.downloads_similarity should be before from invenio.legacy.bibrank.record_sorter
105:1: F401 'register_page_view_event' imported but unused
105:1: F401 'calculate_reading_similarity_list' imported but unused
105:1: E402 module level import not at top of file
106:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_stemmer should be before from invenio.legacy.bibrank.downloads_similarity
106:1: F401 'stem' imported but unused
106:1: E402 module level import not at top of file
107:1: F401 'BibIndexDefaultTokenizer' imported but unused
107:1: E402 module level import not at top of file
108:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_utils should be before from invenio.modules.indexer.tokenizers.BibIndexDefaultTokenizer
108:1: F401 'author_name_requires_phrase_search' imported but unused
108:1: F401 'get_field_tags' imported but unused
108:1: E402 module level import not at top of file
110:1: I101 Imported names are in the wrong order. Should be lower_index_term, wash_author_name, wash_index_term
110:1: F401 'wash_index_term' imported but unused
110:1: F401 'wash_author_name' imported but unused
110:1: F401 'lower_index_term' imported but unused
110:1: E402 module level import not at top of file
111:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibindex.engine_config should be before from invenio.legacy.bibindex.engine_washer
111:1: F401 'CFG_BIBINDEX_SYNONYM_MATCH_TYPE' imported but unused
111:1: E402 module level import not at top of file
112:1: F401 'create_download_history_graph_and_box' imported but unused
112:1: E402 module level import not at top of file
113:1: F401 'DataCacher' imported but unused
113:1: E402 module level import not at top of file
114:1: I101 Imported names are in the wrong order. Should be perform_external_collection_search, print_external_results_overview
114:1: F401 'perform_external_collection_search' imported but unused
114:1: F401 'print_external_results_overview' imported but unused
114:1: E402 module level import not at top of file
115:1: E402 module level import not at top of file
116:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS, VIEWRESTRCOLL
116:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
116:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
116:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
116:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
116:1: E402 module level import not at top of file
122:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch.adminlib should be before from invenio.modules.access.local_config
122:1: F401 'get_detailed_page_tabs' imported but unused
122:1: F401 'get_detailed_page_tabs_counts' imported but unused
122:1: E402 module level import not at top of file
123:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.legacy.websearch.adminlib
123:1: I201 Missing newline before sections or imports.
123:1: E402 module level import not at top of file
124:1: I201 Missing newline before sections or imports.
124:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
124:1: E402 module level import not at top of file
125:1: F401 'deserialize_via_marshal' imported but unused
125:1: E402 module level import not at top of file
126:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.utils.serializers
126:1: F401 'acc_authorize_action' imported but unused
126:1: E402 module level import not at top of file
127:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine
127:1: E402 module level import not at top of file
128:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
128:1: F401 'encode_for_xml' imported but unused
128:1: F401 'wash_for_utf8' imported but unused
128:1: F401 'strip_accents' imported but unused
128:1: E402 module level import not at top of file
129:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
129:1: E402 module level import not at top of file
131:1: E402 module level import not at top of file
134:1: I101 Imported names are in the wrong order. Should be calculate_cited_by_list, calculate_co_cited_with_list, get_cited_by_list, get_citedby_hitset, get_citers_log, get_records_with_num_cites, get_refers_to_list, get_refersto_hitset
134:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_searcher should be before import invenio.legacy.template
134:1: F401 'get_citedby_hitset' imported but unused
134:1: F401 'get_records_with_num_cites' imported but unused
134:1: F401 'calculate_cited_by_list' imported but unused
134:1: F401 'get_refersto_hitset' imported but unused
134:1: F401 'get_cited_by_list' imported but unused
134:1: F401 'get_citers_log' imported but unused
134:1: F401 'calculate_co_cited_with_list' imported but unused
134:1: F401 'get_refers_to_list' imported but unused
134:1: E402 module level import not at top of file
139:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrank.citation_grapher should be before from invenio.legacy.bibrank.citation_searcher
139:1: F401 'create_citation_history_graph_and_box' imported but unused
139:1: E402 module level import not at top of file
140:1: I101 Imported names are in the wrong order. Should be get_self_cited_by, get_self_cited_by_list, get_self_refers_to_list
140:1: F401 'get_self_refers_to_list' imported but unused
140:1: F401 'get_self_cited_by' imported but unused
140:1: F401 'get_self_cited_by_list' imported but unused
140:1: E402 module level import not at top of file
141:55: E126 continuation line over-indented for hanging indent
144:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
144:1: F401 'wash_table_column_name' imported but unused
144:1: F401 'get_table_update_time' imported but unused
144:1: F401 'run_sql_with_limit' imported but unused
144:1: E402 module level import not at top of file
146:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
146:1: F401 'collect_user_info' imported but unused
146:1: E402 module level import not at top of file
147:1: I101 Imported names are in the wrong order. Should be create_error_box, pagefooteronly, pageheaderonly, write_warning
147:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
147:1: F401 'pagefooteronly' imported but unused
147:1: F401 'create_error_box' imported but unused
147:1: F401 'write_warning' imported but unused
147:1: F401 'pageheaderonly' imported but unused
147:1: E402 module level import not at top of file
148:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webpage
148:1: E402 module level import not at top of file
150:1: F401 'apache' imported but unused
150:1: E402 module level import not at top of file
152:1: I100 Imports statements are in the wrong order. from invenio.legacy.websearch_external_collections should be before from invenio.utils
152:1: F401 'do_calculate_hosted_collections_results' imported but unused
152:1: F401 'calculate_hosted_collections_results' imported but unused
152:1: E402 module level import not at top of file
153:1: F401 'CFG_EXTERNAL_COLLECTION_MAXRESULTS' imported but unused
153:1: E402 module level import not at top of file
155:1: F401 'DatabaseError' imported but unused
155:1: E402 module level import not at top of file
160:22: E203 whitespace before ':'
160:14: E225 missing whitespace around operator
161:24: E203 whitespace before ':'
162:24: E203 whitespace before ':'
163:28: E203 whitespace before ':'
164:30: E203 whitespace before ':'
165:24: E203 whitespace before ':'
166:23: E203 whitespace before ':'
167:29: E203 whitespace before ':'
168:26: E203 whitespace before ':'
169:33: E203 whitespace before ':'
170:30: E203 whitespace before ':'
171:30: E203 whitespace before ':'
172:30: E203 whitespace before ':'
173:30: E203 whitespace before ':'
174:30: E203 whitespace before ':'
175:30: E203 whitespace before ':'
176:41: E703 statement ends with a semicolon
178:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from sqlalchemy.exc
178:1: E402 module level import not at top of file
179:1: F401 'collection_restricted_p' imported but unused
179:1: E402 module level import not at top of file
180:1: F401 'restricted_collection_cache' imported but unused
180:1: E402 module level import not at top of file
181:1: F401 'get_permitted_restricted_collections' imported but unused
181:1: E402 module level import not at top of file
182:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.utils
182:1: F401 'get_all_restricted_recids' imported but unused
182:1: E402 module level import not at top of file
185:1: F401 'check_user_can_view_record' imported but unused
185:1: E402 module level import not at top of file
187:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.records.access
187:1: E402 module level import not at top of file
188:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.collections.cache
188:1: E402 module level import not at top of file
189:1: F401 'get_field_i18nname' imported but unused
189:1: E402 module level import not at top of file
191:1: I100 Imports statements are in the wrong order. from invenio.modules.indexer.models should be before from invenio.modules.search.cache
191:1: E402 module level import not at top of file
192:1: E402 module level import not at top of file
198: D401 First line should be in imperative mood ('Create', not 'Creates')
198: D202 No blank lines allowed after function docstring (found 1)
198: D400 First line should end with a period (not 'n')
198: D205 1 blank line required between summary line and description (found 0)
206:33: E261 at least two spaces before inline comment
215:1: F401 'get_synonym_terms' imported but unused
215:1: E402 module level import not at top of file
217:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
217:1: E402 module level import not at top of file
220: D401 First line should be in imperative mood ('Return', not 'Returns')
220: D300 Use """triple double quotes""" (found '-quotes)
241:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers
241:1: F401 'get_collection_allchildren' imported but unused
241:1: E402 module level import not at top of file
244: D401 First line should be in imperative mood ('Return', not 'Returns')
244: D202 No blank lines allowed after function docstring (found 1)
247:5: E266 too many leading '#' for block comment
251:5: E266 too many leading '#' for block comment
252:5: E266 too many leading '#' for block comment
254:34: E261 at least two spaces before inline comment
271:13: B901 blind except: statement
276:9: E266 too many leading '#' for block comment
288:9: E266 too many leading '#' for block comment
293:17: E266 too many leading '#' for block comment
302: D400 First line should end with a period (not 'o')
302: D205 1 blank line required between summary line and description (found 0)
302: D208 Docstring is over-indented
347:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names
347:1: E402 module level import not at top of file
350: D209 Multi-line docstring closing quotes should be on a separate line
350: D400 First line should end with a period (not 'y')
350: D205 1 blank line required between summary line and description (found 0)
350: D208 Docstring is over-indented
363:38: E203 whitespace before ','
394:1: E302 expected 2 blank lines, found 0
394: D209 Multi-line docstring closing quotes should be on a separate line
394: D400 First line should end with a period (not 'g')
394: D205 1 blank line required between summary line and description (found 0)
394: D208 Docstring is over-indented
423: D209 Multi-line docstring closing quotes should be on a separate line
423: D205 1 blank line required between summary line and description (found 0)
435:1: I100 Imports statements are in the wrong order. from invenio.modules.search.models should be before from invenio.modules.search.searchext.engines.native
435:1: E402 module level import not at top of file
440: D210 No whitespaces allowed surrounding docstring text
440: D400 First line should end with a period (not 'h')
440: D205 1 blank line required between summary line and description (found 0)
458: D401 First line should be in imperative mood ('I', not 'Is')
458: D400 First line should end with a period (not '?')
469:1: E302 expected 2 blank lines, found 1
469: D205 1 blank line required between summary line and description (found 0)
469: D208 Docstring is over-indented
476:1: I101 Imported names are in the wrong order. Should be CACHE_SORTED_DATA, SORTING_METHODS
476:1: F401 'CACHE_SORTED_DATA' imported but unused
476:1: E402 module level import not at top of file
479: D205 1 blank line required between summary line and description (found 0)
479: D208 Docstring is over-indented
493:20: E127 continuation line over-indented for visual indent
495:25: E126 continuation line over-indented for hanging indent
546: D103 Missing docstring in public function
556: D401 First line should be in imperative mood ('calculate', not 'calculates')
556: D209 Multi-line docstring closing quotes should be on a separate line
556: D202 No blank lines allowed after function docstring (found 1)
556: D400 First line should end with a period (not 'e')
556: D205 1 blank line required between summary line and description (found 0)
567:20: E261 at least two spaces before inline comment
571:17: E261 at least two spaces before inline comment
598:1: E302 expected 2 blank lines, found 1
616: D210 No whitespaces allowed surrounding docstring text
616: D400 First line should end with a period (not 'n')
622:25: E261 at least two spaces before inline comment
623:13: E222 multiple spaces after operator
646:10: E261 at least two spaces before inline comment
663:1: E266 too many leading '#' for block comment
665: D103 Missing docstring in public function
666:25: E128 continuation line under-indented for visual indent
667:25: E128 continuation line under-indented for visual indent
668:25: E128 continuation line under-indented for visual indent
669:25: E128 continuation line under-indented for visual indent
686: D401 First line should be in imperative mood ('Set', not 'Sets')
686: D202 No blank lines allowed after function docstring (found 1)
686: D400 First line should end with a period (not 'l')
686: D200 One-line docstring should fit on one line with quotes (found 3)
687:23: E128 continuation line under-indented for visual indent
688:23: E128 continuation line under-indented for visual indent
689:23: E128 continuation line under-indented for visual indent
690:23: E128 continuation line under-indented for visual indent
691:23: E128 continuation line under-indented for visual indent
729:9: B901 blind except: statement


28:1: F403 'from hit_counter import *' used; unable to detect undefined names
47:14: E261 at least two spaces before inline comment
50:20: E261 at least two spaces before inline comment
70:20: E128 continuation line under-indented for visual indent
81:20: E128 continuation line under-indented for visual indent
117:21: E261 at least two spaces before inline comment
120:22: E126 continuation line over-indented for hanging indent
124:22: E128 continuation line under-indented for visual indent
188: D209 Multi-line docstring closing quotes should be on a separate line
188: D400 First line should end with a period (not 's')
188: D205 1 blank line required between summary line and description (found 0)
188: D208 Docstring is over-indented


1: M111 unrecognized component name: recordext


:ok:


Probably better to loop until it's not ready (or timeout)


I'm reaaaaally not sure about this.


remove console.logs please :)


It doesn't make a big difference, but would it be better for this to check `if ($out)`?


I think it worked fine for a statically allocated 2D array - what was in your initial coding, but dynamic allocation is likely a different story if I had to guess.


What was the reason for this change? Consistent behaviour ([as discussed (#69)](https://github.com/bcosca/fatfree-core/pull/69)) or something else?


Владик, будешь писать методы в конструкторе - закончиться вся память (особенно с кроликами актуально): вынеси в прототип ;)


Do you know any other way to specify a dependency version without `hard coding` in a properties file or `build.gradle`?


Jason, I've made several syntactical changes along these lines in order to get past linting.  For example, I've changed "use strict"; to 'use strict'; single quotes, consistent with the rest of the project.  Also, I've added many ; semi-colons, and have fixed at least one bad selector.
However, I'm trying to run a build, but I can't get past the Jekyl portion of the build process.  I do get compiled bootstrap.min.js file, however should I expect a min bootstrap_prototype.min.js file?  I don't see it.  I'm ready to fix several things with this library, I just need to get past the build process.  Am I close?


- may we git branch and pull request to update?


Thanks for acknowledgements!! I just tested AMICO and only gave a very very small feedback. So the acknowledgements might be too much :)

I'll almost certainly use AMICO/NODDI (maybe also ActiveAx) for my job, so I can test the codes on some machines and with some brain images. I'll give a feedback when I find some issues. It's my pleasure.

At the moment I don't fully understand the background mathematics of AMICO, so I don't know how much I can contribute in collaboration. But of course I'm interested in.

Thanks again for this great package!!


Will it even get here, given that you have a custom SIGINT handler?


This is a little overkill. We're already getting the $node object from the hook. Checking the values on $node should be enough to determine if this particular node is what we're after.


Please remove commented out code.


Tadas 0:1 git rebase

Thanks, Chris :)


For reference, I noticed that [this Pong demo](http://forums.nesdev.com/viewtopic.php?f=20&t=13053) by @nicklausw was not working in GBE+, like at all. Turns out GBE+ has several issues (not emulating ROM+RAM, not resetting scanline pixel buffer during drawing, and not properly emulating DMG and GBC/GBA I/O differences). The following commits after this rectify the above mentioned problems.

To note, even when GBE+ sets the emulated system type to GBC, it will boot DMG games as if it were actually running on a DMG, if not using Boot ROMs. So, that's why the demo plays correctly when setting the emulated system type to GBC.


This could be `chomp @tps;` instead of the loop.


Doesn't that spec say all multilingual characters should be escaped?

  "Any character may be escaped.  If the character is in the Basic
   Multilingual Plane (U+0000 through U+FFFF), then it may be
   represented as a six-character sequence: a reverse solidus, followed
   by the lowercase letter u, followed by four hexadecimal digits that
   encode the character's code point.  The hexadecimal letters A though
   F can be upper or lowercase.  So, for example, a string containing
   only a single reverse solidus character may be represented as
   "\u005C"."


I see no reason for having object instead primitive. <= 0 should be treated as no capacity, max is max (i don't think that somebody needs having 0 as Integer.MAX_VALUE).


Problem :
Notice: Undefined variable: row in D:\Applications\xampp\htdocs\dam.int\assets.inc.php on line 1707


Please remove the extra newline between the conditionals.


Yeah, sorry, should be fixed now. This is what I get for making edits in the Github editor...


I am doing like for gst_player_set_rate if I am not mistaken.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.829.b8aec5e17973d2603f994b2ae04594874fc7d454](http://build.palaso.org/viewLog.html?buildId=60058&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 395, ignored: 3 Build time: 00:02:40


A message without a method is received
https://github.com/kodi-pvr/pvr.hts/blob/master/src/HTSPConnection.cpp#L250


Also, a think this could use a comment saying why this is a special case.


`! -z` is the same thing as `-n`


These are the product URLs for Moosejaw.com. Put this in a .txt file and use it as the input for site_scraper()


Problem :
 Notice: Undefined variable: row in D:\Applications\xampp\htdocs\dam.int\assets.inc.php on line 1681.


how about creating a `post_params` method like this?

```
def post_params
  params.require(:post).permit(:title, :body)
end
```


This looks more like a Tenant new route than a show route!


I do that ("... actually has an effect ...") in second test. I can improve it to measure time between 2 callbacks if this is ok for you ?


This is excellent code Jon


They've been removed in https://github.com/alphagov/smart-answers/commit/588a3a55ea86000776557958cf86bff63c7292ef#diff-5ddf47ddaef32b833936253245328fa8,  so I just got the order of the commits wrong when rebasing.


how about creating a `summary_params` method? :)


What happens if $2 contains spaces?


I'm aware and it's been fixed, I haven't pushed it to github yet.

@@ -1704,7 +1697,7 @@ class Device {
                }

                // If you changed cabinets then the power connections need to be removed
-               if($row["Cabinet"]!=$this->Cabinet){
+               if($tmpDev->Cabinet!=$this->Cabinet){^M


Isn't it better to not even have 'mso-list' style set at all, which is done in code, breaks the editor and requires this sort of fixing?


ff


Too big


I, Michael Francis Preedom, President/CEO, of Preedom North American Telecom/Northern Research Scientific Microelectronics/Networks Canada, thank you for this free license from your organization.


what is the path to a summary? Something like `/topics/2/posts/4/summaries/8`? Does it make sense? If a post only has one summary, why do we have to use the id to identify that summary? Would something like `/topics/2/posts/4/summary` make more sense? How would you do it?

:D


In the beginning something is wrong.
who takes the first entity?


whitespace ...


// este es lo que tiene que parecer


Doesn't look like you have a show route set up in your Tenants controller to support this link. Would need to add something like...

```rb
get "/tenants/:id" do
end
```

or

```rb
get /apartments/:apartment_id/tenants/:id do
end
```


Hmm, no, I believe your version now creates a new anonymous class that extends HashMap and that is rather bad.
Like:
private static final HashMap<String, String[]> cutscenes = new HashMap<String, String[]>(3);
static {
cutscenes.put(...)
....
}

This how the contents is initialized in a static content.


Super easy, done.


Clean up this comment please. [Coding Standards](https://www.drupal.org/coding-standards/docs)

Format is:
/**
* Short Summary
*
* @param TYPE $variable
*    Short variable description.
*/


only handle one of request in the batch request case?


ingresar otra calificacion


Good idea.


Too complicated. Linux users are fairly tech savvy so I feel something like

#####Linux
1. Unzip
2. Copy the .ttf files in your fonts-directory
3. Run `sudo fc-cache`

Should be enough.


I think it will work for valid URLs.  If some code might be sending it
garbage, pythonic is for that code to catch the exception.

The use case question has me thinking.

The short answer is I don't want to store the ID and other bits separately.

Long answer seems too long for this issue but here it is:

I need to email/tweet/export the url that people should click on to see the
video.
It may or may not be a richard site. like it could be a youtube url, or a
link to the file:

http://meetings-archive.debian.net/pub/debian-meetings/2014/debconf14/webm/Adhoc_crossbuilds_and_multibuilds_Xen_NetBSD_in_Debian_as_a_nonarch.webm

I have code that figures out what that URL is.. kinda like this:

if use richard site:

   from steve.richardapi import  create_video

            vid = create_video(self.richard_endpoint,
                    self.host['api_key'], video_data)
            url = 'http://%s/video/%s/%s' % (
                    self.host['host'], vid['id'],vid['slug'])

else use youtube
   url = "http://youtube.com/v=" + id
else use mirror (what debian calls their video host machine)
   url = something...

ep.public_url = url
ep.save()

I like that after that I have a URL in my db.  I can go into the admin or
other UI to look at the data and see the URL.   I can write more code that
puts a URL into the db.  I can cut/paste URLs in/out of the django admin.

I could move all that logic somewhere else and store the parameters in my
db and construct the URL when needed, but I don't like the sound of that.
and I would have to re think rewrite my code, and that isn't going to
happen any time soon.

On Mon, Jul 27, 2015 at 8:34 AM, Sheila Miguez <notifications@github.com>
wrote:

> Decide how to handle cases in terms of what to return/throw when split
> doesn't return a list > 1. I haven't thought through that yet, but on first
> reaction, I don't like letting it blow up like this.
>
> I'm also wondering about the use cases that has you working the url rather
> than having a json element from interacting with the richard api, thus
> having an id already available to you.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CarlFK/steve/commit/26782ca88be0329aeb8d9963f3a7f2a5282b5ad0#commitcomment-12372237>
> .
>

--
Carl K


Mac + Linux with font-viewer installed


This is not a batch request. This is the parameter list.

For batch requests, just handle it one by one by calling the `dispatch` method.

Please refer to `raw-server.rs`.


still missing a `(` on the start. group your statements together.
```
else if ((name.equals("entity") && (entity != null)) {


as above


@Meowmaritus WPF is only available on Windows, but Mono has WinForms, too.


I'm not sure exactly what you're describing. Read through the db-related rake tasks by running:

```bash
bin/rake -D db
```
One of those may fix the problem you're seeing (if you're still seeing it). Especially note the `rake db:reset` task mentioned in the description for `rake db:setup`.

Add a bit more detail and ask further questions if there's anything I can clarify/answer.


wtf


Looks great Ashley but, we need to download Jonathan's changes from the latest update


It's not new functionality. I merely expanded its reach. Pull up the tip of develop and look for occurrences of `SF_SIGGOOD` and `SF_BAD`. E.g. https://github.com/ripple/rippled/blob/develop/src/ripple/app/misc/NetworkOPs.cpp#L657-L693


Seems reasonable.


more WTFs


Well, it's the usual semantic reasons. It's valid to not have specified a container cap (empty string), and a single (int) doesn't tell you that. You have to look at the code to know if the 'user didn't specify' value is zero, MAX_INT or some other 'magic' value (even 'null' if it were Integer rather than int - but that then gives you three possibilities rather than two).

<0 is probably an invalid anyway.

In fact, as it stands, won't saving the config without a cap result in the value being shown as 2147483648 on next page load? That's why the UI was separating it out into getContainerCapStr.


I agree, so rename it to 'failed_items' in stead?
I changed the show method because check_that and confront  just printed how many confrontations were done, but nothing on its success or failure, which is kind of strange from user perspective :-)


reack


I should add to that comment, highlighting that it applies to HHVM 3.5 as well.

I don't think it's worth dropping support, if this is at all accurate: http://w3techs.com/technologies/details/pl-php/5/all For a string library such as this one, there's little to be gained, right? Especially when it's trivial to do so. I'm not aware of any new language features that would help.


You can take a look at this: http://www.catb.org/esr/structure-packing/


Shouldn't you either mask or check the range, from preventing the shader from doing out-of-bounds accesses?


Ты работаешь только с JS. Поправь require.


Great work @pentateu!! I'm going to test this long waited plugin right now. Many thanks for taking my idea into consideration. This addon is a must have for inputting text into the apps


`thrift_sasl` shouldn't be mandatory dependency for the same reason `python-sasl` is not mandatory. `thrift_sasl` is used only when SASL-based auth method is choosen.


From what I understand, Bower doesn't even use the version number. I'd prefer to just remove this from `bower.json` than to continue managing the version in multiple places.


"Oops, I pushed an old patch yesterday."

*write fix*
*push fix*
*...rejected?*

Thanks :wink:


Это вообще что такое и что оно тут делает?


Gonna remove these and it will be good to go for now, we can't get a MouseWheel event because the Control can't receive focus.  We will have to use the Mouse/Key listener hook to do the mouse wheel stuff


ack


@udan11
Please have a look at https://github.com/phpmyadmin/phpmyadmin/issues/11325 .


int


Please clean up trailing whitespace here.


...and here.


...and here, too.


Да просто задумался куда их класть, и забыл копипастнуть. Всё добавлю.


No braces needed here


Инклюдить надо из бандла :) Теперь ясно, чего оно не работает.
![Bad Pony](http://i.imgur.com/Xd8Ox.jpg)


Hey @arturoc, testing this out in and older project; I'm getting this cryptic compile error on Xcode 6.4:
```
In file included from /Users/oriol/Desktop/LP/REPOS/PG_REPO/apps/PG_WALL/src/TexturedObjectScrollView.cpp:9:
In file included from /Users/oriol/Desktop/LP/REPOS/PG_REPO/apps/PG_WALL/src/TexturedObjectScrollView.h:12:
In file included from ../../OF/libs/openFrameworks/ofMain.h:9:
In file included from ../../OF/libs/openFrameworks/utils/ofURLFileLoader.h:2:
In file included from ../../OF/libs/openFrameworks/events/ofEvents.h:5:
In file included from ../../OF/libs/openFrameworks/events/ofEventUtils.h:4:
../../OF/libs/openFrameworks/events/ofEvent.h:33:51: error: indirection requires pointer operand ('of::priv::Function<ofxAnimatable::AnimationEvent>' invalid)
                                return std::unique_ptr<Function>(new Function(*f));
                                                                              ^~
../../OF/libs/openFrameworks/events/ofEvent.h:156:7: note: in instantiation of member function 'ofBaseEvent<of::priv::Function<ofxAnimatable::AnimationEvent>, std::__1::mutex>::ofBaseEvent' requested here
class ofEvent: public ofBaseEvent<of::priv::Function<T>,Mutex>{
      ^
5 warnings and 1 error generated.
```
ofxAnimatable::AnimationEvent is a regular ofEvent argument; it looks like:

https://github.com/armadillu/ofxAnimatable/blob/master/src/ofxAnimatable.h#L177-L186

Not really sure whats going on... This compiles fine in the previous OF commit.


I believe there is a race condition on nameMap here (and in the other methods which use a similar nameMap pattern). Go maps are not thread safe and although you only have one goroutine for each subtask (rev-list, cat-file x 2) it is possible you can be trying to be writing to and reading from nameMap in parallel from the 2 places. Checking the guidance on this suggests that even in a single-reader-single-writer situation you should have locking on maps; only multiple readers (no writers) is safe.


Wouldn't it be better to use an even number so that it divides by 2 correctly?


I think I just ran into the issue that this fixes. For some reason, for me, in Chrome, when using browserify, `this` was some random empty object instead of `window` or `global`.

I can confirm that this commit fixes the problems I was having (in both mocha test cases and in browser with browserify). Any reason not to merge to `master`?


So your landlord app does add a tenant to the Tenants table. BUT, it does not add it to an apartment, so each new one exists in the Tenants table without an apartment_id.


Just stylistic, but this might be clearer with a `continue` here (and no `else:` on the next line).


This is in master and live on npm (as of about 30 minutes ago)


Adding a new tenant currently returns an error because you are redirecting the user to a route -- `/tenants/` -- that does not exist. Instead, try redirecting them to the appropriate Tenants index page using the route you already create at the top of this controller file.


Should I revert these whitespaces? As you can see I removed them (actually my editor does it automatically).


DOPE COLOR.


Yeah, this should go into Ability and be simplified into can? :delete, msg


I don't think the comment is useless, but I guess it could be expanded a bit to be more explicit.


@parasyte @agmcleod hi guys, while refactoring this code I realised that the pointermove and pointerenter event do not really work together.

As it's kind of late here, is there something I'm not seeing, even just in terms of how to use it ? (as I keep looking at the code, but i'm not really understanding what is wrong)

here is an attempt fix, but it was not super successful either (more like some code cleaning) :
https://github.com/melonjs/melonJS/commit/6da62b25d099bddf934280a812aeeba84a8d9233


yep, same here...


I think your code, and set_rate(), don't need to be called from the main context. Can you fix that up in a follow-up commit for set_rate()?


mvn install or mvn deploy will still use the full Maven coordinates (including version). Only the temporary file in target dir will miss the version. And if needed you can still rename the file before uploading it ;)


Sounds good :)


Jeśli chcemy wyrównać, to nie tabami, tylko spacjami. W pycharmie zrób sobie Ctrl + Shift + A i wpisz whitespace, wybierz pierwszą podpowiedź. Zobaczysz, czym są wypełnione puste przestrzenie. W plikach *.py mają być tylko spacje, w *.html tylko tabulatory.
Żeby zamieniało tab na 4 spacje: File -> Settings -> Code style -> General -> Tab size ustaw 4


These all need short comments explaining what exactly they are for. I also think there should be a comment saying what roles registers that aren't here have. (Scratch integer regs, etc.)


Remove ._.DS_Store files. I don't use mac.


@garethrees It is using an even number - the width here is 246px for the @2 version - do you mean use an even number for the @1 version too?


fixed :wink:


I'm missing here privacy-protection.ariaLabel, see https://hg.mozilla.org/integration/gaia-central/diff/710d5cd606b1/apps/privacy-panel/locales/privacypanel.en-US.properties


Maybe instead of `current_limit` use `processed + bounced`?  That way the tracers don't count.  Also, should the limit be part of the mailin configuration?


Looks good as far as I can tell. I cannot really test this though.


Use the [`dependency-management-plugin`](https://github.com/spring-gradle-plugins/dependency-management-plugin). You can use `org.springframework.boot:spring-boot-dependencies` for the BOM (with the Spring Boot version you are using) and all the dependency management that boot exposes will be applied.

If you have a regular Spring Boot application, adding the plugin has the same effect. You can also create a project from start.spring.io and choose any cloud dependency to showcase what happens when an extra BOM needs to be added to the build.

HTH.


Indent by four from return.


> On Jul 27, 2015, at 6:07 PM, Tres Seaver <notifications@github.com> wrote:
>
> Maybe instead of current_limit use processed + bounced? That way the tracers don't count. Also, should the limit be part of the mailin configuration?
>
You’re certainly right that I got lazy and hardcoded the number, instead of getting the setting from karl.ini. You’re also right on the logic for processed+bounced….99.999% of the time it won’t matter, but recently we’ve had backlogs (due to someone mailing in a 17 MB attachment cc’d to 17 lists) where we couldn’t finish the transaction without getting a conflict error. And so, tracers and emails piled up into the +1,000. So getting it right is important.

—Paul


Actually <> is correct. Again, sorry, nitpicking.
https://docs.oracle.com/javase/tutorial/java/generics/types.html - The Diamond


ah, nah that makes sense! I thought it was going to drop down to 123/2 (so 61.5)


I think this function in general needs more/better comments.


Yeah, thanks for the feedback, I'll apply your suggestions. I appreciate it.


Does this work?


@osahyoun thanks, this fixed it!


What else would be worthwhile testing for `.upgrade_account`?


You checked in commented code!


so? what is easier? write 10 lines manually and possibly make a mistake as you can forget about some field or just delete old method and generate new method by one click?


Why not keep if-else?


line 38, nice work. Null check after comparing it to some sheit.


done


What is this required for?  This is not my understanding of "it just works"...


Rusha.js is several orders of magnitude faster than forge, so yes, keep it. It's within a factor of 2 of the native node crypto library, which is written in C.


can you try if the last commit fixes it?

On 27.07.2015 18:02, Oriol Ferrer Mesià wrote:
> Hey @arturoc <https://github.com/arturoc>, testing this out in and older
> project; I'm getting this cryptic compile error on Xcode 6.4:
>
> |In file included from /Users/oriol/Desktop/LP/REPOS/PG_REPO/apps/PG_WALL/src/TexturedObjectScrollView.cpp:9:
> In file included from /Users/oriol/Desktop/LP/REPOS/PG_REPO/apps/PG_WALL/src/TexturedObjectScrollView.h:12:
> In file included from ../../OF/libs/openFrameworks/ofMain.h:9:
> In file included from ../../OF/libs/openFrameworks/utils/ofURLFileLoader.h:2:
> In file included from ../../OF/libs/openFrameworks/events/ofEvents.h:5:
> In file included from ../../OF/libs/openFrameworks/events/ofEventUtils.h:4:
> ../../OF/libs/openFrameworks/events/ofEvent.h:33:51: error: indirection requires pointer operand ('of::priv::Function<ofxAnimatable::AnimationEvent>' invalid)
>                                 return std::unique_ptr<Function>(new Function(*f));
>                                                                               ^~
> ../../OF/libs/openFrameworks/events/ofEvent.h:156:7: note: in instantiation of member function 'ofBaseEvent<of::priv::Function<ofxAnimatable::AnimationEvent>, std::__1::mutex>::ofBaseEvent' requested here
> class ofEvent: public ofBaseEvent<of::priv::Function<T>,Mutex>{
>       ^
> 5 warnings and 1 error generated.
> |
>
> ofxAnimatable::AnimationEvent is a regular ofEvent argument; it looks like:
>
> https://github.com/armadillu/ofxAnimatable/blob/master/src/ofxAnimatable.h#L177-L186
>
> Not really sure whats going on... This compiles fine in the previous OF
> commit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openframeworks/openFrameworks/commit/73b65edcceb359a47e45598cef2d8f4fee9bbf12#commitcomment-12376058>.
>


Not my code.


Sounds good.


I wold make indent_size = 2 by default, not only for package.json


Sorry, I stopped developing for os x.


Seems a bit unfortunate that the `pk` URL parameter is ambiguous now, is there a way to rename it to `pk_or_slug`?


Looks like you understand how the views work, but you didn't include any information in your controller beyond which views to render, so none of this will work.


Agreement. Will be fix


Do we really need to blindly follow en-US here and put it all enable-full-dev-mode-first-warning-msg- strings in upper case?


Hi Przemek, what is the reason to switch to `hb_URight()` for such strings as `::colorSpec`?


Do this by value and do away with the casting entirely:
`SwizzlePattern swiz = { g_state.vs.swizzle_data[operand_desc_id] };`


Thanks!


Nice form. But again, you need to have corresponding information in your controller for this to work at all.


Ah, I see.


It's true that it's a separate topic, but given the extent of the rewrite for 2.0 anyway I'd rather leave it in so it doesn't get lost. If you want to split it out into a separate branch we can review and merge separately that's fine too, but that strikes me as more trouble than it's worth.


IMO, better to fail if it doesn't exist than create and march on.


text/javascript


Return is unnecessary.


This `hb_ULen()` usage will generate an RTE, because `::aText` is an array. Or am I missing something?