- we have the C version of librados. the counterpart of this function is ` rados_pool_create_with_all()`. maybe we should sync up them also, to avoid diverging in these two sets of APIs.
- and this changes the signature of the `pool_create()` method. i am a little bit concern about this. as this is a public API. we need to bump the so major version, see https://github.com/ceph/ceph/blob/master/src/librados/Makefile.am#L31 .
- maybe we can take this chance to use standard `int16_t` instead of the linux specific `__s16`? or simply use `int`. i am not sure why we choose `__u8` at the very beginning.


Todo esto por que entró en este commit? Yo venia cambiando las comparaciones en el booleanEvaluator creo, pero capaz que esta bueno usar este equals para eso. Hay que reverlo


better use calloc as it assigns ZERO's to all the allocated bytes.


:scream:


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.326](http://teamcity.monogame.net/viewLog.html?buildId=8595&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Also you need check that the admin can't delete his Admin role


@georgemccann try: jQuery(document).ready(function($){


1: M111 unrecognized component name: docker


I would identify everything in the generic, then use `@describeIn xxx description of xxx method` to include the method in the generic's help.


The web app has to start up with the desktop app just because of the way Electron works. Essentially Electron is serving our app from inside a web view wrapper in Objective C. In order to do that our app needs to be running. When we go to distribute the app it'll compile all the web files inside of our bundle using meteor's "--bundle" command and then serve the app from it's file:// directory location.

We just use the hosted app to serve to the desktop out of convenience. Otherwise you would have to bundle all files everytime and then copy the bundle to your /Users/username/Library dirs.


Don't forget to `rerturn`.


You need check that the admin can't lose the Admin role.


предпочтительнее хранить ключи в отдельном от файлов, которые лежат под git'ом


There are calls to `run_shell_command` that need to be updated in `run_maintenance_scripts`, `update_code_to_master`, `checkout_commit`, and `bundle_install`.


Also Matt if you want me to see something the easiest way is put `@jimhester` in a comment, then it will email me about the mention.  See https://github.com/blog/821

On that note you should never put bare '@' whatever in a comment, as it will then mention that person.  So you sent poor Calvin Hill (`@return`) a email with your comment.  Simply put backticks around the text that you don't want to be a mention.


:+1:
We should really use the django admin more


Add ppa (Preview Pending Approval) to the Blender Addon


You can't really say that if you're catching all errors here.


At least check if the path is really for the tmp folder and not the tmpsomething folder and make sure the path does not contain the /../ sequence.


Reviewed the PR and looks good.


@haroldp Removed until this is fixed: https://oc.tc/forums/topics/559cb0f167d522a3db009dbf


thanks Sir. will check

On Thu, Jul 9, 2015 at 6:21 PM, avindsilva <notifications@github.com> wrote:

> Don't use capitalized letters for variables/identifiers. Full caps are
> usually used for constants.
> Read more about java identifiers.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Aadilmusavir/Basic_java/commit/ee0374e005667cd016318960e0ed4c6f0f95f3a5#commitcomment-12083788>
> .
>

--
With Best Regards
Aadil Masavir
Bca ,Mca
Ejipura Bangalore,India


You can remove this patch due to:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4e93b9a6abc0d028daf3c8a00cb77b679d8a4df4


Update config:

```
cache-store:
        type: \redis-store
        host: \localhost
        port: 6379
        database: 10
        expires-in: 2 * 86400 # 2 days
```

or

```
cache-store:
        type: \js-store
        expires-in: 2 * 86400 # 2 days
```


зачем за пользователя решать как ставить ansible? не лучше оставить ссылку на документацию в ридми


Shoudn't this use localized formats?


The reason why I did not put it at the top is because I like to put constants as close as possible to where they are used. However, each to their own. I just thought I'd explain why.


On top of that, you might also want to have some information on why the app crashes. Here is where the Android logging system is available to help you.


@psytronx DWMR. Press on.


Éventuellement, il va falloir ajouter un sélecteur pour être sûr que tu ne prend qu'un seul ".id". Genre, pas ceux de tous les <tr>, juste ceux dans le tr modifié. Ex de sélecteur: $(this).closest("tr").find(".id").


The reason why it was protected is because I could imagine a derived class might want to explicitly prune, although it shouldn't be a public API for consumers of the stream.


`get_sql_location` needs to be passed the domain as well, unfortunately.


Thanks, I've just looking for the place where this hard-coded `1000` value lives :)


i think this is a mistake. Clearly we are dealing with a single byte, not "data" in the abstract sense. It's also more consistent with the `Hybi` implementation.


I don't agree with the first one (that with the comma it's wrong)
OK with the second one


ugh, yes. my mistake.


please, remove


аналогично https://github.com/AydarGareev/ansible_aws_provision/commit/133e20c2625bb61ac0a3276c93ec2eed9bb7e899#commitcomment-12084878


Call me pedantic, but I think it's worth a discussion to change our style _include guards_ rather than sneaking those pragmas in. Unfortunately, I missed them during the platform_drv work.


What is this??


The Go convention is that errors in a package start with "Err".
See this, for example, http://golang.org/pkg/database/sql/#pkg-examples.
All of the standard library uses that, so I recommend we do the same.


Sinon, il est aussi possible de générer un champ de data pour chaque champs selon leur id, ex: <input ... data-rowid="'.$i.'" et ensuite tu prend le sélecteur $(".id[data-rowid=2]")


@santiagofm, @m-revetria what do you think about the first one?


wow..


Don't use magic numbers


Ferme pas le PHP


WHat's this ? You deleted parts of cheery trees ! (stair/slab)


Thank you for your pull-request, it has been merged.


Because we're delegating to the shell here (`shell=True`), presumably because we trust the contents of the `cmd` variable, then you needn't do the above and simply `subprocess.Popen(cmd)` even when `cmd` looks like `['cat', 'hi.txt', '|', 'grep', 'hi']`. See https://docs.python.org/2.7/library/subprocess.html#replacing-shell-pipeline – the same section is present in the documentation for v2.7 through v3.5.

I feel like I should ask why we're specifying `cmd` as an array…


98451462_Humidifier (Nigusse) - x86_64-MacOS-10.9-clang: OK (1678 of 1678 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The bot was already connected in all three networks and joined to the channel on two networks when issuing `relay join` which says that this fix is wrong.

Previously when I issued `relay join` the bot joined the channel in no network automatically, so this won't fix #1133.


Then leave it as `ENOENT` for now. We can still update them all at once later.


Yes sorry about that. I should push a release soon.


According to http://www.php-fig.org/psr/psr-2/: "The closing ?> tag MUST be omitted from files containing only PHP." Et c'est pour éviter des bugs, par exemple si l'ordre d'inclusion de tes fichiers tu as un fichier avec un closing tag qui a un espace après, et que tu veux envoyer un header au browser, ça va planter.


This commit updates the scikitlearn version to 0.16.1 in name but not in the URL. Can submit PR but don't have my nix machine here right now


I'm add the "use this instead" but leave the "And" here, I think it gives a flow


you mean by attaching to zImage etc ?
nope.

the docs are saying:
```
In /boot you will find a .dtb for each base platform. This describes the
hardware that is part of the Raspberry Pi board. The loader (start.elf and its
siblings) selects the .dtb file appropriate for the platform by name, and reads
it into memory.
```

so I assumed it IS working.


the idea was to be able to search by substring. Method signature:
```java
public UserPage search(String token, String expectedItem) {
    // e.g. Put "t" (token) into search field, wait for the list of available options to appear,
    // click on the option which is equal to expectedItem, press Enter
}
```


Lets remove this code since it is not needed.


Lets remove this line.


I thisnk here it's better make False instead of 0.
Serialization can be buggy. But possibly it's ok....


why do we create long messages and then truncate them here ? Shouldn't it be responsibility of each piece of code which generates a message to make it fit 7k chars ?

How do you know that an arbitrary 7.5k char string will never be more then 10k when encoded ? This will only make problems more rare and more subtle. But the real problem seemed to me that when http server refuses a message because it is too long, we fail terminally, instead of trying again with a shorter one. Like "full message was too long and was truncated. Here are the first 5k chars of it".


Good catch though that should probably just be in the DB init SQL rather than manually done.


You won't be able to know about it. To make matters worse, it will get logged in the users' device, consuming memory space for a non-existent reader.


And replace file removal with wxRemoveFile().


how it works!


Hi! I can't get default_date: false to work in multiple mode. I need the calendar to open on the current day, but when no dates are set it shouldn't have new Date as default value. I need an empty value...

$('.calendar').pickmeup({
		flat		: true,
		default_date: false,
		mode		: 'multiple',
		calendars	: 3,
		select_month: false,
		select_year: false
	});

Please help me out. Thanx!


to search ALL data


typo: find -> fine


смысл? в этом плейбуке к этим хостам не обращаются


I'm not really sure about ZERO being always a long, here.
As decimal and floating point Values are doubles, I feel zero should adapt (long/double) for the addition to be correctly evaluated.


How about trying pixz, just like adding pigz to the build?
https://github.com/vasi/pixz


If it doesn't join all networks when this variable is True, then it's a(nother) bug.

And I don't see the point of `relay join` if it does not join a network.


Ok


Done


This is used internally by datepicker widget. Format of the date returned by datepicker which is then displayed in form input is defined is JS: https://github.com/paweltin/saleor/blob/fa1f9d83569724a50b78008e813584319d2c9e4b/saleor/static/js_src/dashboard.js#L96
To enable translations, we need to load relevant translation file provided by the datepicker lib: https://github.com/amsul/pickadate.js/tree/3.5.6/lib/translations


good call here


Probably true for the create extension script, but not for the install postgis extension. I'm not sure if you can automate that part.


And later you should make a pull request. Now this is not a pull request.
Green button with arrows in your forked https://github.com/g-LuL/cgru


You need to define new module in ./build.js as well.


This block seems to have 1 extra level of indentation (i.e. 4 spaces instead of 2)


Looks good, thanks for implementing this.


@al-martinez The problem is this line. First, this line duplicates line 23, which shouldn't be. Second, this line loads an empty UIViewController, which will show nothing. Comment it out to see what happens.


98451462_Humidifier (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1684 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We never noticed because the Install method was still installing everything in that folder, it just doesn't return  every file installed, just the directory so MB_INSTALL_TARGETS was incomplete


Good advice!


Yep!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.326](http://teamcity.monogame.net/viewLog.html?buildId=8595&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 501, ignored: 6 Build time: 00:22:49


Thanks for this!!!


This is a bug, because the behaviour changed from working to broken.

> And I don't see the point of relay join if it does not join the channels.

There are two use cases:
* relaying #channel between network1 and network3, but not network2.
* as workaround to broken LinkRelay not punishing other relaybots. https://github.com/ProgVal/Supybot-plugins/issues/11#issuecomment-1569072


I don't really like Value being declared as an object here, just because it can be double or long.
It's not that bad for now (as Value is only used by ToString), but I'll probably come back here later.


PSTEC?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.740.dda9f43100acbe97d4175351b4a7f7f481cb7da3](http://build.palaso.org/viewLog.html?buildId=59504&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 368, ignored: 3 Build time: 00:02:35


On 09/07/2015 16:06, Mikaela Suomalainen wrote:
> * relaying #channel between network1 and network3, but not network2.

Then don't set this to True and don't use `join`.


@Raesu DWMR. Looks good here. Press on.


I take the first sentence, not the second as it's too formal :smiley:


Yes, i know this doc.
But it only works if the kernel image is prepared for this. And this is done by `mkknlimg`
You can test it for yourself with an RPi2:
If `/sys/class/leds/led1 `exists, .dtb is loaded, if it does not exist, .dtb is not loaded automatically and has to be specified on the config.txt manually. Only led0 is still hard coded in the kernel, led1 not.
I tested it a few weeks ago with your 4.1-rc kernel, an led1 did not appear


98451462_Humidifier (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


`+new Date` ugh is that some crazy coercion happening here? like `+[]` equals 0?


For more information you could catch an exception and print its stack trace:


You can do:

```
var result = { message: '' };
```

which is ever so slightly faster.


I'm unsure about ZERO being always represented as a long, either.
It might have to adapt wether it's used in a operation with a Decimal/Float or with an Integer, thus switching between double and long respectively.
We'll see.


`s/(){/() {/`


haha @tudor8210j


's/desc){/desc) {/'


Is this gonna create new timer for each post?


It's expecting fewer parameters than we're giving it for some reason.


Badziewie do badziewia


Added new blank page to the recipe url link


Ok thx Stani


> Then don't set this to True and don't use `join`.

The issue is that I have set it to False (which is also the default) and it still joins channels when that means don't do it. `relay join` must be used, because the plugin has no other command to start relaying.


I regret, both are too formal for me :smile:


It's missing ARGS_KEY entry at the top of the ViewPanelWdg and TableLayoutWdg so that no_results_msg can be visible in the UI for Manage Side Bar


@hodgestar Ready for review


visual of performance boost:

![image 3](https://cloud.githubusercontent.com/assets/1051390/8597429/55f0e580-2623-11e5-821f-bf8eed826ab0.png)


Elves use normal aim first.


screenshot:
![cellrpg-texture-cells-demo](https://cloud.githubusercontent.com/assets/1051390/8597443/6b47694a-2623-11e5-8b83-e713ff7ccb9a.png)


`promise` -> `Promise`


Right, I meant the SQL command to add it to a specific database.  PythonAnywhere actually didn't need any steps to install the extension because apparently they just provide it for you out of the box.


You are correct, good find. Wow. I'm really glad that got caught. For all the time Copy and Paste saves me, it surely could have cost me quite a bit of time trying to figure out what was going wrong...

Thanks!


Use `then().catch()` instead of two arguments `then()`


while this approach does cut down renderTime dramatically, it makes the time of creating a new generation prohibitively long (110-120ms)


This extra line is unecessary.


\r-


Are you still planning to merge this commit?
The key_hash fn will be useful for stuff I have coming up.


I'll check it out this afternoon - it's possible I forgot to copy-paste a
few lines of code.
Emma

On Thu, Jul 9, 2015 at 12:57 AM, Jiaoling Chen <notifications@github.com>
wrote:

> Emma, I have emerged the two changes, and right now I have a NameError
> which says name 'User' is not defined. I didn't see the class User in the
> files. Should we create one?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jiaoling/gdi/commit/b961cd68a481264f17e6f2dcf9ec5c59e2050b07#commitcomment-12076766>
> .
>


What do you mean "first"? I don't have CombatSetAim2 in any of my logs o.o


Using latest Vagrant with atomic support, it skips the error about `/usr/sbin/biosdevname` and then hangs later on:
```
DEBUG guest: Searching for cap: network_scripts_dir
DEBUG guest: Checking in: atomic
DEBUG guest: Checking in: fedora
DEBUG guest: Found cap: network_scripts_dir in fedora
 INFO guest: Execute capability: network_scripts_dir [#<Vagrant::Machine: default (VagrantPlugins::ProviderVirtualBox::Provider)>] (atomic)
DEBUG ssh: Re-using SSH connection.
 INFO ssh: Execute: /usr/sbin/biosdevname; echo $? (sudo=true)
DEBUG ssh: stderr: bash: line 2: /usr/sbin/biosdevname: No such file or directory

DEBUG ssh: stdout: 127

DEBUG ssh: Exit status: 0
--- SKIP ---
 INFO ssh: Execute: which nmcli >/dev/null 2>&1 && nmcli c reload enp0s3 (sudo=true)
DEBUG ssh: Sending SSH keep-alive...
DEBUG ssh: Sending SSH keep-alive...
DEBUG ssh: Sending SSH keep-alive...
DEBUG ssh: Sending SSH keep-alive...
```

[***Full output***](https://gist.githubusercontent.com/errordeveloper/b5bda200ef0cecee6ab2/raw/d5282c1cf7c892998248098acc6ade5eae8fd19d/vagrant.log)


Qué tal? Si, me podés ubicar en Hangouts: masia.fer@gmail.com


It's probably best to also do `if original_poll:` before declaring the poll object and PollResult object. And the monkey patch needs to be updated to conditionally remove the original poll and PollSelector if poll is not available.


Here is a nice reference: https://docs.djangoproject.com/en/1.8/ref/applications/#for-application-authors


зачем это использовать как template?


### Gemfile

```ruby
source 'https://rubygems.org'

group :development do
  gem 'vagrant', git: 'https://github.com/mitchellh/vagrant.git'
end
```

### Vagrantfile

```ruby
FEDORA_RELEASE = 22
BUILD_VERSION = 20150521
MIRROR = 'https://download.fedoraproject.org'
MIRROR_PREFIX = "#{MIRROR}/pub/fedora/linux/releases/#{FEDORA_RELEASE}/Cloud/x86_64/Images"

Vagrant.configure('2') do |config|
  config.vm.box = "fedora-atomic-#{FEDORA_RELEASE}-#{BUILD_VERSION}"
  config.vm.box_url = "#{MIRROR_PREFIX}/Fedora-Cloud-Atomic-Vagrant-#{FEDORA_RELEASE}-#{BUILD_VERSION}.x86_64.vagrant-virtualbox.box"

  #config.vm.guest = :atomic

  config.vm.hostname = 'test-1'
  config.vm.network :private_network, ip: '172.17.85.94'

  config.vm.provider :virtualbox do |vb|
      vb.gui = false
      vb.check_guest_additions = false
      vb.functional_vboxsf = false

      vb.memory = 1024*6
      vb.cpus = 2
  end
end
```


Try to aim for prolonged time


@humaton I am not sure whether applying the fix above will work actually...


ok


зачем это хранит в git'е?


:point_right: :kissing_heart: :see_no_evil: :point_left:


En general no está bueno declarar funciones con el mismo nombre. Sería mejor que una se llame `reverseStr` y otra `reverseArray`.


Squashed in to one commit.


ok
noted


...Thanks for letting me know I somehow forgot to put them on TortoiseGit. Those are very important too... :D


I am happy to see test data providing an alternate solution with equal or better performance results.  Like all performance testing, without actual test data to back up a claim it is just speculation.


Fixed in #69


Since this was straightforward to do, it has been fixed in commit f0a03fcd1b


```js
return [].concat(switcherMix, dropdownMix || [], dropdown)
```


TeamCity Selenium POM :: CI [Build 29](https://teamcity.sponte.uk/viewLog.html?buildId=242&buildTypeId=SeleniumPom_Ci) is now running


Shouldn't there have been a `man/knitrBootstrap.Rd` file added as well (complementing the `man/primerTree.Rd` file removed)?


TeamCity Selenium POM :: CI [Build 29](https://teamcity.sponte.uk/viewLog.html?buildId=242&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:47


@HelOlhausen @mtnbarreto what do you think now?


myHolder?


huhu :p


I don't know whether anyone else is experiencing this problem, but I find this commit is causing me problems when going down a list of changes in the Gstatus window using diffsplit.

Before this commit, I could go down a list of files, pressing ``D`` or ``ds`` against any files I like, and I always keep 3 windows, the Gstatus one and the two diffs. Now it seems to get confused with the windows...


TeamCity Selenium POM :: CI [Build 30](https://teamcity.sponte.uk/viewLog.html?buildId=243&buildTypeId=SeleniumPom_Ci) is now running


TeamCity Selenium POM :: CI [Build 30](https://teamcity.sponte.uk/viewLog.html?buildId=243&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:31


That's really good :+1:


Ok


Please do not modify the `dist` files - they are generated by a build procedure. I am also not sure how wise it is to also copy the `original` property, but since it is hidden behind a config option I guess it is OK.

Please create a pull request on the src file.


I'm currently porting full mtk av to cm11. But there are many files missing and also some errors.


closed #317


Why do you need lots of lines with the same calls? Maybe it's better to extract this logic to the base method?


Until I figure out how I can contribute to this exact PR (and not open a new PR with the same changes), I'll post some suggestions right here.

```
# __init__.py
default_app_config = 'path.to.apps.Config'  # This is the file described below
```

```
# apps.py
from django.apps import AppConfig

class Config(AppConfig):
    name = "python.path.to.app"
    verbose_name = "App name"

    def ready(self):
        super(Config, self).ready()
        import python.path.to.app.signals  # Import signals
```

I have not worked with the way you're "offering" models and mixins (`from .models import SimpleEmailConfirmationUserMixin, EmailAddress`), so I can't comment on that, other than it might help out to have a look [here](https://docs.djangoproject.com/en/1.8/ref/applications/#django.apps.AppConfig.models_module)

I'm looking forward to a new release since our system is upgrading to Django 1.8 :-)


That's what `rhsType isGeneric()` does.. I fixed the code and left the comment... *sigh*


TeamCity Selenium POM :: CI [Build 31](https://teamcity.sponte.uk/viewLog.html?buildId=244&buildTypeId=SeleniumPom_Ci) is now running


TeamCity Selenium POM :: CI [Build 31](https://teamcity.sponte.uk/viewLog.html?buildId=244&buildTypeId=SeleniumPom_Ci) outcome was **SUCCESS**
Summary: Tests passed: 35 Build time: 00:00:29


this is a comment just for test


@amorag  ¿Por qué el cambio del tipo de lista? ¿Por qué hay que usar siempre el mismo? Me parecía que quedaba mucho mejor presentado como definiciones.

Vaya, no me parece bien a menos que sea algún tipo de regla de estilo obligatoria que desconozco. Si es así, indicádmelo. Si no, por favor déjalo como estaba.


aa


Now to clean the rest of the codebase this way...


MI 3/4 should change to MI 3C


test


If this is deprecated, how are you supposed to use it now?


Hi again, https://github.com/hrydgard/ppsspp/issues/4199 fix ideas on Adreno ?


@aleksclark This should fix the problem you noticed. Thanks for reporting it.


I wanted to make it faster in the case where it finds a match, it won't keep testing them all. Feel free to change it for whatever reason though.


that's why I wrote /sys/firmware if empty. cause complete read out of dtb must be present under /sys/firmware/devicetree.

do you know what this "preparation" is ? because for standard arm machines this works since kernel ?3.10? with no special care.

just rebooting to see it.
yes, /sys/firmware/devicetree/ is there


Having both of "DevMode" and "boot into SysNAND" might be confusing.. Well i haven't tried so. So i could make mistake about it. From "MyThread.c" Roxas tried to patch the region-lock code in FIRM. And i don't know if there is a present location already in the decrypted + patched one.


@Yoshitsune please stop commenting on random commits, I see all comments. I don't have any news on #4199 unfortunately, it's quite mysterious.


commento


:)   we replaced HornetQ here by ActiveMQ through the donation.. I never thought about grammar changes because of renaming HornetQ as Activemq...nice change! :+1:


When you have a model in a subdirectory : $foreign_model like (model\submodel)

$this->model\submodel->table     <- without underscore
$this->model_submodel->table    <- with underscore


ok, kernel is no longer complaining about missing informations on some places.
good !

go for merge


Wouldn't this lead to a problem when using then().catch() with callback functions? In case of exception in callback, callback will be called twice, check http://www.es6fiddle.net/ibwal0s3/


No problem :).


sysNand =/= DevMode. rxMode in sysnand has firmlaunch (infact, it has mythread and stuff), while Devmode just patches sigcheck


Hi, See that you are working on AutoComplete feature for this library. This is very important and keep up the good work. Do you plan to submit this support as a PR or its just for your own use?

Thanks.


98451462_Humidifier (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (652 of 652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.49%25-green.svg)


Those dictionaries are actually sent to all the plugins once; then whenever they are updated the data backend for each plugin always has the latest one. There are some plugins like the parser that call ToList on it for finding player character data on PCWorkerDelegate hence the private set.

I was thinking based on some other discussions of making a local lock variable or just moving to a concurrent dictionary. The parser itself extensively uses a concurrent on.

There are multiple delegate/ui threads accessing it :)


No errors.  It's working for me.

On Wed, Jul 8, 2015 at 11:04 PM Dallas Peters <notifications@github.com>
wrote:

> image uploader
>
> @mark-bradshaw well I broke something so I’m quitting for the night. :)
> Can you do me a favor and see if you get several js errors when you
> visit http://localhost:3001/keystone/lessons
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/dallasbpeters/tiny-love/commit/30b244ab713b0223c0c25507cb86b7be9296d618


html will be learn here


Hyphens were added to identifiers in 2012!
I need to get with the times.


French: I'd use tu instead of vous


woo neat


sha256(password + app.config['SALT']).hexdigest()
в отдельный метод set_password()


I think we could go a step further...

Rename `checkArgument` to `checkTrue`

```
Preconditions.checkTrue(name != null && !name.isEmpty(), "Table name cannot be empty.");
```


That's not me : 169327a


нужно указать версию psycopg2


> do you know what this "preparation" is ? because for standard arm machines this works since kernel ?3.10? with no special care.

Not exactly. I assume this is RPi specific. The RPi loader looks if this trailer exists and then knows if the kernel is DT ready or not.
u-boot based systems, like CuBox does not need this trailer


I will do the remapping now, was on a plane all of yesterday


Holy shit, that is amazing, I gotta test this.


return render_template(
    'login.html',
    title='Sign In',
    form=form,
)


Yep just removed them ;p


@madebymunsters DWMR. Good to see you doing the work. Press ahead.


I think you're going to want the `match` instead of `eq` method. That way order won't matter on the internal arrays.


Yes


@mark-bradshaw Weird. Maybe you can carve out ten minutes sometime today to have a peek at my machine.


You're not even expiring the namespace in the expire method....


Based on some exceptions I've seen I will probably go concurrent however.


- Fixed bug displaying quiz and result interface for true/false questions
- Added target _blank on 'show notion' link on results view
- Calendar events now set up only for user


я бы использовал str.format()


`match`


Funny how simple things can get so complicated. How about:
var responseType = isImplicit ? 'token' : 'code';
var apiRedirectUrl = _apiUrl + '/oauth/authorize?response_type=' + responseType + '&client_id=' + _clientiD;


Wrong issue reference. Relates to sixsq/tasklist#337 instead.

@loomis This fixes the issue identified during the demo. I'm moving the task to "Done".


Hi Stefano,

yes, each piece of code should take care of the len of the message, but I think we also need a protection here because shit happens. For example, you set 5 retries intead of 3 and suddenly, since you report all the single failures, your error message becomes too large!

About the 7500. The way the Base64 encoding works is that it take 3 bytes (padding if necessary), and then it splits the 24bytes in chunks of 6 bits and spit back the corresponding character (usualli a-zA-z0-9 and othe two chars). That means that every three bytes of the original message became 4 in the encoded one, and that's where the 7500 limit comes from.


Isn't there something like getChildByType()? But this works too.


Hi, I see you have pushed the code, please send a Pull Request to me. :+1: There is a logo in right hand side.


there is a typo in remov


Commenting on the old script...


Just noticed: we shouldn't return here.


oh i see is fixed. Super. Thanks!


I have helped you to create a PR. :)


Okey then. So my mistake. BTW Find the original code what RxMode tried to patch for region-free, at 0x0007A5A8 of 0004013800000002.bin (2.6). I don't know if there would be anyone to try patch it first.


Comment on the 2nd commit


This does not change the text-color of the hamburger icon. You are setting the text color of the icon above the paragraph "Modern Features". But that is unnecessary, as it is already set in the `h2` element. See `<h2 class="center light-blue-text">` on line 100.


looks good!


See? There is no `TAG` parameter it's automagically assigned as the caller class name by Timber.

This way the next time a user complaints about a crash you won't have to start blindly on finding the fix for it, with Timber and Crashlytics you will be notified when an issue occurs, you will also have the tag which gives context, its stacktrace and any additional information you may want, both in development and also in production!

So, simply using Timber and Crashlytics will make your life easier when looking for those ugly crashes that keeps you awake at night, and your users happy too!


I know this code is clumsy - but I couldn't come up with something better.
At least it works. In principle this holds for all $$a subfields.
I couldn't figure out how to set up a unit_test for this convoluted change.

Browsing through records "year:2012->2016" ( I don't think old records are affected) and checking ["084__a", "6531_a", "65017a", "695__a", "980__a"] shows it's mostly subjects and keywords:
980: 2
084: 5
695: 7
653: 58
650: 155
I don't know how often this should run and whether more fields should be checked.
Would it make sense to check the full record on rare occasions?
If manny tags are checked at the same time this code needs to be different - or it will re-write most of the record.


This loop can be replaced with ```clauseBody.accept(new ArgumentChecker(holder))```


Local lock variables would be useless, since you'd be locking on something only in your scope to begin with.  Of course, maybe I don't understand what you're talking about exactly.

Concurrent is nice because you also have AddOrUpdate() method, and your whole wrapper classes could be removed.


このメソッド、インスタンスが保持しているtodosプロパティ引数にしているから、インスタンスメソッドの方が良いかも！


It's not an argument checker - it checks expressions in function bodies as well.


Is this on purpose? So we don't have to enable it manually in the future?


gotcha. Then do not simply take the first 7.5k chars, but take a few less and add a header saying "message truncated to 7.4k chars" or similar.


98451462_Humidifier (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1684 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This methods belongs to ArgumentChecker - why is it in outer scope instead?


This one's expression checker


Are these 3  ?: operators needed? Do these values need to be null instead of undefined?


@mjwitte I made test runs with existing code and your revision. The test file was modified based on Plenum.idf by adding CO2. I uploaded 4 files in GitHub\EnergyPlusDevSupport\DefectFiles\5000s\5009:

PlenuCO2.idf
Current.csv (existing code results)
CR5009.csv (based your revision)
ProposedChange.csv (based on my proposed change)

Here is my view.

Your revision is OK with me theoretically. However, since the value in the zone node is the value at the previous time step, the outlet node value is not updated. I think we should update node values as much as we can in HVAC section simulations. Then let the corrector calculate zone values only.

It is observed that the value differences between in outlet node and plenum node in ProposedChange.csv are much closer than values in CR5009.csv when the mass flow rate in plenum > 0.

However, when the mass flow rate = 0, your update is better. Here is my proposed change:

		if ( Contaminant.CO2Simulation ) {
			if ( ZoneRetPlenCond( ZonePlenumNum ).OutletMassFlowRate > 0.0 ) {
				// CO2 balance to get outlet air CO2
				Node( OutletNode ).CO2 = 0.0;
				for ( InletNodeNum = 1; InletNodeNum <= ZoneRetPlenCond( ZonePlenumNum ).NumInletNodes; ++InletNodeNum ) {
					Node( OutletNode ).CO2 += Node( ZoneRetPlenCond( ZonePlenumNum ).InletNode( InletNodeNum ) ).CO2 * ZoneRetPlenCond( ZonePlenumNum ).InletMassFlowRate( InletNodeNum ) / ZoneRetPlenCond( ZonePlenumNum ).OutletMassFlowRate;
				}
				Node( ZoneNode ).CO2 = Node( OutletNode ).CO2;
			} else {
				Node( OutletNode ).CO2 = Node( ZoneNode ).CO2;
			}
		}

The code revision will be similar to Generic Contaminant section.

Please let me know what you think.


Add tests for cases we've spotted before. (send expression, ++, etc.)


I've hesitated on that...
$user->allcaps contains only true/false key/value pairs, for example :
cap_1 => true
cap_2 => true
cap_3 => false
cap_4 => true
(and in real conditions we have a lot of caps that are false in this array)

For me on app side having cap_3 => false or not having cap_3 at all (which is what the code does) is functionally equivalent.
So I figured we save webservice bandwidth if we don't include false caps, and it's simpler and clearer when we check caps on app side to be able to only do (pseudo code!) :
if ( in_array('my_cap', caps )
and not having to test if the cap is in caps AND checking if it is true.

But maybe I'm wrong somewhere, if any doubt let's just use $user_permissions['capabilities'] = $user->allcaps; directly :)


You are not right here, free(fpr) should be in the "else" branch.


this will fix #1


Where is `clashes.scala`?


Here I got: Fatal error: Class 'string' not found


哈哈哈  会了


啥


This case is not covered.
```erlang
comprehension() ->
  [A || A + 1 <- []].
```


このTodo、他のsaveメソッド以外で使わないのなら、saveメソッド内で生成して方がよいかも！


Yup I think I prefer this method.


faster? possibly, but I doubt you could even measure the difference with a millisecond timer!

The reason I'd prefer to avoid it is that the nesting is that it's error prone and pretty hard to read compared to the non-nested version.  If we for example applied to the check for product ID we'd end up with nesting over 10 levels deep. Really convoluted code for little gain. Please revert it. Thanks!


yes, standard arm = uboot based.
I checked the difference and it is really just DTOK info and then uname -a


viewDIdLoadで生成すると、新しくTodo作らない時もインスタンスが生成されちゃってあんま良くないかも！


private


me gusta :+1:


duh! commit to my fork instead.


In your example, let them first update to the latest minor/patch first. From v2.5 -> 2.6.x -> 3.x -> 4.x -> 5.x


この１行上で
``let todo = Todo()``
すれば、本当にTodoを作成するときにインスタンスが作られて良さそう！


Course Project 1


Mirá lo que encontre.. interesante: http://www.usingenglish.com/forum/threads/40172-Proper-use-of-quot-Complain-quot-and-quot-Complaint-quot


This code will also change the behaviour for IPv6, which is not mentioned in RFC 3021. Not that /127 networks would make much sense...


ok

On Thu, Jul 9, 2015 at 9:47 AM Dallas Peters <notifications@github.com>
wrote:

> @mark-bradshaw <https://github.com/mark-bradshaw> Weird. Maybe you can
> carve out ten minutes sometime today to have a peek at my machine.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dallasbpeters/tiny-love/commit/30b244ab713b0223c0c25507cb86b7be9296d618#commitcomment-12086193>
> .
>


yes


Nice work! I see that that everything is properly abstracted from the internals. :-)


Then you have a virus installed.


> go for merge

Who?


That looks like it will work, although the difficulty is probably in the  search function; I'm not sure about how much the specific features of the backends overlap, and its quite possible that the different backends will return different results, because differences in stemming, ngrams, etc. ( Does Sqlite support ngrams? )


Those special variables are automatically set. :wink:


jaja entonces es COMPLAINTS no?


MSG Parser produces weird output and links


The .size property of an IPNetwork is always at 1 or higher, so this should be a simple "else:".


no, sin "t". Es con "t" cuando es un sustantivo y sin cuando es verbo


Same modification to be applied at line 77


@ehzhang I think this line was accidentally removed, fix: https://github.com/facebook/fixed-data-table/pull/198


What does implicit login mean?


Good catch !


es como practice: el verbo va con "s" y el sustantivo con "c".


Too, i tried this in my server


There's a fair bit of duplication with regular callbacks. Look at `txp:article.php`. There's an `update_lastmod()` call if the status is >= LIVE, then the very next line after the conditional is a callback that raised under the `article_posted` event. It passes `$rs` too. The only difference between the two callbacks is that the `article_posted` fires regardless of status. But you can detect status in the hooked code by inspecting `$rs['Status]`.

So in a fair few places, we'd have callbacks immediately adjacent to the `update_lastmod()`. Is this overkill?

In some cases I've chosen different variables to pass than in the nearby callback. For example, in `txp_css.php`, there's this kind of flow:

    if ($savenew) {
        update_lastmod('css_created', compact('newname', 'name', 'css'));
    } else {
        update_lastmod('css_saved', compact('newname', 'name', 'css'));
    }
    ...
    callback_event('css_saved', '', 0, $name, $newname);

So as you can see, I'm passing the actual content to the `update_lastmod()` function in addition to the new and original Stylesheet names, which then raises the callback as proposed in the forum thread you linked above. That's acceptable because you might well want to cache the content to disk, so having a copy thrown into the callback is handy.

The good thing about hooking into `update_lastmod()` is that you can subscribe to them all and cherry pick based on `$event`, or only subscribe to specific ones: they only fire when stuff is actually updated that matters to the cacheability of content, whereas the more generic "something happened on this panel" calls always fire.

Maybe that's fine. Just seems like a bit of redundancy, but maybe the two callbacks do have different use cases so it's justified having them both in close proximity with very similar signatures..


It fixed #29


@helOlhausen @mtnbarreto what about now?


You can also use `(System/getProperty "os.name")`


@macumber for some reason this line being in the code breaks the expanding tables for each chart. This happens even if I'm online.


TeamCity DNN JavaScript Libraries :: CI [Build 27](http://teamcity.engagesoftware.com/viewLog.html?buildId=295&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


You could just assign this directly
``` node->next = std::make_unique<Node<T>>(value); ```


TeamCity DNN JavaScript Libraries :: CI [Build 27](http://teamcity.engagesoftware.com/viewLog.html?buildId=295&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:6


TeamCity DNN JavaScript Libraries :: CI [Build 28](http://teamcity.engagesoftware.com/viewLog.html?buildId=296&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 28](http://teamcity.engagesoftware.com/viewLog.html?buildId=296&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:5


TeamCity DNN JavaScript Libraries :: CI [Build 29](http://teamcity.engagesoftware.com/viewLog.html?buildId=297&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 29](http://teamcity.engagesoftware.com/viewLog.html?buildId=297&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:6


I put the test for the time being in ignore so it doesn't break anything.


ahh I assumed that a class method couldn't use instance variables but now I googled it and you totally can. rad!


wow, we were really out of date, I assume this is necessary for .json loading


saw approval from JeetKunDoug
at https://github.com/basho/riak_pb/commit/620bc7001dc788e5530078aa8be53c9d15d4fdb4


merging basho/riak_pb/zl/merge-develop-into-2.1 = 620bc700 into borshop-integration-125-zl/merge-develop-into-2.1


basho/riak_pb/zl/merge-develop-into-2.1 = 620bc700 merged ok, testing candidate = f67c5b73


What's this ? You deleted parts of cheery trees ! (stair/slab)


var useProductionService = false;
Client.initialize(APP_KEY, useProduction, ...


@gotnull Have you tried compiling mono from an older version of OS X? I usually still compile from OS X 10.7 Lion to get the best compatibility with older OS versions.


this commit should be merged back to regular ROSS.


:ok: :1234:


Please notice that directories passed in --files-from are ignored. When using --files-from ONLY existing FILES will be copied to storage.


I have just deleted the test.

I started testing the Transaction since I have a prd on my name for 3.6 that deals with the transaction and wanted to get started putting the transaction in serious tests before making any changes. But apparently that back fired :)


Debugging.

-[Unknown]


TeamCity Ybackend :: synteny/ybackend [Build 60](http://192.168.30.225:8111/viewLog.html?buildId=1559&buildTypeId=Ybackend_SyntenyYbackend&guest=1) is now running


I was thinking eventually removing all of the piping someday.


Why is to_s needed? What does diffy return?


EvansHVACObjects (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


@madebymunsters I've never seen this solution before. I love it!! Very efficient.


@madebymunsters DWMR. :+1:


This else clause is unnecessary.


Hey Rui,

just noticed that this branch was not merged into the master branch while it was done for the other build plugins. Can you please do so when you got some time left for this? Meanwhile I will go with the dynamicTestPort branch.

Thanks!


Very minor, but why the update from `size_t i` to `unsigned i`?  Also, why the reorder of `ep` declaration (I saw this in other patches too)?  You don't need to amend the PR over this, just trying to understand why the additional diff churn is present.


The message and style are showing up but the colour is not.  I don't think `{this.props.bsStyle}` is being added to the components `className`.  I ran `console.log(this.props.bsStyle)` to make sure the value was being passed in and it is.  I am not sure why it is not being added to the components class.


EvansHVACObjects (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Where is this rescued? Was the code for this always there?


Makes sense, I'm OK with this.


This is actually a grammatical error rather than a misspelling and "mispelling" is actually misspelled.


Please do not include pathutils.c


I could not get this to work properly without the `else` statement.  I tried your recommended loop approach but I could not get it to work.


@hu-yue apparently this commit never made it to master, even if it is fundamental.... I don't understand what happened.


This is not default value for slave ports and it is necessary. If I remove it slave ports fail to build (they will take pkg-plist from master port).


Me too. And turning that ugly Perl thingy into some nice Python. But at the moment it's very useful to have a separate tool do the JSON formatting. I'd postpone that for later.


"1 bottles of beer on the wall"? Is that what will happen at 1 bottle left? (if you didn't have  the modulus on).


Correct, as the commit message states. (Does anybody even read those?)


Thanks for the pull request, I really like the idea behind this. This would however break backwards compatibility. I'm just weighing up the option of keeping the original name private_key (instead or private_key_source).. Do you have any thoughts? :)


EvansHVACObjects (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Also closes #4


It appends mfs. I will try to add a workaround at pkg-plist level (for backward compatibility) so fresh installs will use /var/db/mfs/


all tests pass:
success: http://buildbot.bos1/builders/test-riak_pb/builds/147


Should this check move into `_usdf_dgram_send_iov`?


TeamCity Ybackend :: synteny/ybackend [Build 60](http://192.168.30.225:8111/viewLog.html?buildId=1559&buildTypeId=Ybackend_SyntenyYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:11


Something seems off here. I get an ArrayIndexOutOfBoundsException after this commit in WriteOp markTileAsHandled() while running a simple Calibrate and Write graph from GPT:
```
org.esa.snap.framework.gpf.OperatorException: 7
	at org.esa.snap.framework.gpf.graph.GraphProcessor$GPFImagingListener.errorOccurred(GraphProcessor.java:373)
	at com.sun.media.jai.util.SunTileScheduler.sendExceptionToListener(SunTileScheduler.java:1646)
	at com.sun.media.jai.util.SunTileScheduler.scheduleTile(SunTileScheduler.java:921)
	at javax.media.jai.OpImage.getTile(OpImage.java:1129)
	at com.sun.media.jai.util.RequestJob.compute(SunTileScheduler.java:247)
	at com.sun.media.jai.util.WorkerThread.run(SunTileScheduler.java:468)
Caused by: org.esa.snap.framework.gpf.OperatorException: 7
	at org.esa.snap.gpf.operators.standard.WriteOp.computeTile(WriteOp.java:329)
	at org.esa.snap.framework.gpf.internal.OperatorImage.computeRect(OperatorImage.java:80)
	at javax.media.jai.SourcelessOpImage.computeTile(SourcelessOpImage.java:137)
	at com.sun.media.jai.util.SunTileScheduler.scheduleTile(SunTileScheduler.java:904)
	... 3 more
Caused by: java.lang.ArrayIndexOutOfBoundsException: 7
	at org.esa.snap.gpf.operators.standard.WriteOp.markTileAsHandled(WriteOp.java:384)
	at org.esa.snap.gpf.operators.standard.WriteOp.computeTile(WriteOp.java:297)
	... 6 more
```
It tries to access the [7][0] element in a 7x6 tilesWritten array.


I will move this to cgiserver section (see bellow).


Hi Jan,

Unfortunately, this change is not good for Windows. &key_len is used in the function zend_parse_parameters with the spec 's' (line 330), it means that it will assign `char *` to `key` and `size_t` to `key_len`. So, I just get segfault here.


Argh, didn't mentioned this extra space, sorry.


Good catch. I wil move this.


are these causing issues?


Yeah I removed those now :) Using concurrent; though I hate the add/update method because it's not clear in the msdn docs what is supposed to be done with the old value; So I have it like this:

```csharp
public static void EnsureNPCEntity(UInt32 key, ActorEntity entity)
{
        NPCEntities.AddOrUpdate(key, entity, (k, v) => entity);
}
```

Keep in mind these wrappers are only for me using it in the main application. The plugins themselves will have public get access directly to the dictionary.


@mjgiarlo Was this tested in an instance that did not have zotero integration set up? I haven't thoroughly investigated, but am seeing a stack trace when going to any user profile, that could be related to this change.  See https://github.com/gwu-libraries/scholarspace/issues/10  (I can point you to my AWS instance if you'd like)


I would remove the news entry because this sounds like we support Debian inspection.


Also, should this comparison be against `USDF_DGRAM_DFLT_SGE` (or some value derived from it) or `txattr->iov_limit`?

In general though, fixing that needn't be a blocker for accepting this change.  This is still a big improvement over where we were without this PR.


Tested on osx 10.10.4 x64 with node.js v0.12.5


I have a bad habit of jumping to the code.  Thank you for mentioning it in the commit message.  I will make an effort to read the whole commit message and not just the title.


@sdumitriu forgot to address these comments to you


ahh ahi va! aprendiendo con Santi legrand


Broken pkg-plist. Startup scripts shouldn't be present in pkg-plist


Nice, please try and recreate a specified curve XML.

Thanks.


nit: extra ` ` (space character) here


I want to put this jet category in "runNana_h2mu.py"


Was thinking all the time whether repositories for Spring Data Redis would be feasible. Nice!
One more thing: What about Redis-backed Collections (List, Set, Map)?


Why - in -NATIVE_TIMER_MIN_RES ?


Note - i'm not sure this section has ever been tested at all so some bugs might be present.


Can we split out these non-material pbx changes?


The head operator is also included in the list when you call getChainedOperators, so you don't need this. (It actually double commits the head in this case).


The old value is provided to you for whatever your desire is.  A contrived example is a counter:
`ThreadCounter.AddOrUpdate(Thread.CurrentThread.Id, 1, (k ,v) => v + 1);`

If you don't need the old value, then it serves you no purpose.  Same with the Key, which I've used when my value provider is another function.


Hey Fabian,

It was merged, but to the branch with the same name, not master. I have merged it now to master.

Thanks!


You don't need `return` here. Single expressions implicitly return.


I realize this code came out of specutils (I think?) and that you didn't write most of it.  But I'd like to try to avoid adding this kind of cryptic code if at all possible--the kind of code that promotes the habit of scientists calling their algorithms "codes" as if it's something to be decrypted or a black box of some sort :)

Now, I realize that a lot of these numbers are just fitted parameters and don't really have any direct physical significance.  But I think we can do better all around on variable and constant naming, and documentation.  I'll look at the relevant papers and see if I think of better ways to describe some of these models...


jaja gracias por la ayuda


Thanks!


jet category ends up here


No worries, just trying to see if I could help.

What about my second question?


Another variable, named $thelevel, is initialized (about 80 lines earlier) to $out[0]['level']+1 - is this what was supposed to be used here?


<noob-question/> Wouldn't be cleaner/better if We just miss **&block** argument in this function? I think that there's no need to add possibility to pass **&block** parameter just to raise error when this parameter was passed...


This seems wrong. You'll default every outgoing record to the attributes of *this* device! These are optional fields; let them be missing.


Great, thx!


Nit: newline.


Actually, the processing graph also includes a Subset op. Read->Subset->Calibration->Write.


98451462_Humidifier (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1684 of 1684 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@tchaikov Kefu, thanks for the comments!
to my understanding, the C/C++ API will call the RadosClient, so there's no need to modify the two? I also saw there's some different usage of int64_t and off_t, things like that. The reason for __s16 was there's some field in MPoolOP struct(__s16 crush_rule), which looks like another protocol change if we change to int or other type


Nit: space after type-colon, throughout. (`foo: Bar`)


Calls to `usd_post_send_XXX` take a `flags` argument that could include `USD_SF_SIGNAL`, not a boolean for completions.  Everything is working as coded because it just so happens that `USD_SF_SIGNAL` is equal to `1`.  Please introduce a ternary like `(ep->ep_tx_completion ? USD_SF_SIGNAL : 0)` or equivalent logic.


Comparing against `txattr->iov_limit` would be better. The weird thing here is that the checks for prefix vs non-prefix are different `count > USDF_DGRAM_MAX_SGE` vs. `count > USDF_DGRAM_MAX_SGE - 1`. Really `iov_limit` should probably be getting set differently for the two...


None of this should be at the model level.  These should be determined at the class level of those models that use them (if more than one model use them they could go in a common base class for those models.


ditto about `USD_SF_SIGNAL` here


:wink: :bomb: :rocket: :rocket: :guitar: :8ball: :boom:


98451462_Humidifier (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Ugh, probably need to revert this :disappointed:


Fixes #38


Yes, that's a mistake. Will fix.


Comment these?

Presumably you optionally point to the destination client row ID (I wouldn't bother) and the DB row ID for this command after insertion? The latter is kinda clunky, and I've tried to avoid it where I can :/


is this safe at all? will look into it tomorrow


Fixitfixit


Yes, I think oredict stuff is going to be moved over, but one thing at a time.


I think we have no choice otherwise, what does that lock give us?


maximum


EvansHVACObjects (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Yes, i actually meant to fix that, and forgot. Will do.


There's generally no reason to pass default values into the `evaluate` arguments.


for byte slice equality, you can use bytes.Equal()


version 4.0.70142


Yes this is better. Will do.


Ok that works. Wil do.


Oh, wow, you've gone super relational! I'd denormalize here. We'll usually have one other client. Even when we don't, we'll usually have one client being sent a command. And denormalizing removes the need to worry about cleaning up that relation.


resolves #51


This doesn't seem right.


This is a bit awkward...  just from `from ..utils.data import get_package_data_filename`


不要太机智哦


Should this comparison be `if ((len - padding) <= USD_SEND_MAX_COPY)`?


If you're interested, I decided to create a Java one as well. Created on my own time and not part of an MoJ project but perhaps it could be useful to someone.

https://github.com/Netsensia/postcodeinfo-client-java


`custom_model` doesn't seem to be used anywhere...


iphone可以装一个codehub。。。


Sorry, hit save too soon.

This is a very formulaic factory. Can you express it as a one-liner, maybe involving Self?


isEmpty


EvansHVACObjects (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


You forgot something...
SocketParser.swift =>
private static func checkNSP(nsp:String, _ socket:SocketIOClient) -> Bool {
        return nsp == "/" && socket.nsp != "/"
}


I don't think so because all the fields we are looking at are immutable. However, it is true that if we were to make a code change down the line, that suddenly starts relying on non immutable fields (createdDate, Id, accountRecordId, transactionType, amount, currency), we could introduce a bug easily. So we have the choice to rehydrate (but one more query), or make it move obvious that this object might not represent the latest state.


Surely storage can do all of this in one step? Have storage give you a list of pairs, or a map, from clients to their commands. You never need to upload client records unless you have a command to send.


Mmmm....this would mean that I couldn't set e.g.  `--dm.fs=ext2` or `--dm.basesize=100G` on node initialization, *before* d-s-s runs.

Maybe it would work to have a systemd service that runs *between* d-s-s and docker, and goes in and appends to the config option, but that'd be not-obvious.

Can we have this look for specific things like `-s` and `--dm.thinpooldev`?


It looks like this update of OpenLayers breaks our Goobi.Presentation:

After an update to the latest version, the page view no longer works.
Reverting this commit fixes the page view.

Working example with old OpenLayers:
http://goobi.bib.uni-mannheim.de/seitenansicht_sammlung//dlf/159/1/?1436440632

Not working example with new OpenLayers:
http://134.155.36.32/seitenansicht_sammlung//dlf/159/1/?1436440632

The Firefox developer web console shows these errors which could be related to our problem:
TypeError: P is undefined Class.js:64:3
TypeError: OpenLayers.Control.ZoomIn is not a constructor ZoomPanel.js:47:12

Is the code with the new OpenLayers version somewhere working in a production environment?

Regards
Stefan


tu peux ajouter un commentaire par ligne, c'est génial hein


very nice @Cneubauern


We won't even get here on real failure. I'd log here that the upload succeeded but there was no timestamp; an unexpected oddity.


That's one of the things I was going to ask about. So in the new way were doing things we are setting `wp_len = len` which includes the padding. I still can't tell what `wp_len` is even used for...but I wasn't sure what length I should be using for that check.


et un commentaire sur le commit


This whole function could probably go a way.  It seems to me the common parameterization of all these models into A(V) and R(V) is a case for a common base class for them.


@indera Puppet uses `librarian-puppet` to manage dependencies. The fix for these issues was in the `puphpet/puppet-puphpet` repo, commit e2e45ce:

https://github.com/puphpet/puppet-puphpet/commit/e2e45cee3fa48638538c94020907f357ef229a02


Our mappings rely on unicode so we should probably just throw an error if the font doesn't have Platform 0.


This isn't a comment on your test at all, but I noticed that we're using a string for the upgrade which is prefixed by `,` so you end up with `,MaterialButton,MaterialRipple` as your upgrade string. We should probably clean this up at some point but can do so separately :)


@Cneubauern  I liked the banana :D


@certik, I am getting [this error](https://gist.github.com/abinashmeher999/2670ba31deead6010341) while trying to print all the elements of the result of free_symbols. Something is freeing the data in the variable `x`. I am not able to figure out why. Any hints?


@srosenbrand, this is known issue: https://github.com/nazar-pc/PickMeUp/issues/74#issuecomment-100024945.
Feature was added by contributor and works only with `mode: 'single'`, it doesn't work for other modes and for `flat: true`.
PR is welcomed, also you can create separate issue about this bug.


Test fails because http://user-agent-string.info/rpc/uasxmldata.dtd no longer exists.


The value in `y` and `z` get printed though.


зачем ты закомментировала ср? для экономии места?


reverted, thx for reporting


EvansHVACObjects (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


:+1: more consistent with the current naming scheme.


Is `getCommands` ever used? If not, simplify. We can make this super simple: a table of command strings and guids, and an interface here that gives them to the caller as pairs of `(client, [command])`, right? That's what we end up needing…


fast-forwarding 2.1 to borshop-integration-125-zl/merge-develop-into-2.1 = f67c5b73


Line 39 and 40 change the login to `User ID:[database name]` which I think might be confusing. It really should be a user name with access to the database, not the name of the database itself.


I thought we were done with wca-documents-extra?


resolves #51


I have done this myself now, because I wanted to apply some changes to other DSEs. I have also compared the output and it should be equivalent.


Responded on that issue with a temporary workaround. Thanks for raising this!


énorme :)


Not really the same as lines[0] could be null or empty...


Developing a real-time web using Node js


Here's a script to schedule that gets you your server IP when your ISP goes and changes it on you!


Obviously a SQL Arena log..


Yes, this change fixed the problem.


(Not sure why i get your comment 4 times ;-) ? )

> * About the Janitor iteration (not the GET path), is there any performance impact to consider regarding taking the lock at each iteration, for each transaction? Would it make sense instead to take a lock based on a range of transactions ids (might be tricky with our current lock API though)?

I thought about it (and that's why i was a bit resistant to introduce the lock here in the first place); we could order transactions based on account_record_id, but this is not so easy if we want to stream the results, and ii) this would potentially hold the lock much longer, which i think is a problem.

> * I think this fix addresses your concern in https://github.com/killbill/killbill/issues/338, i.e. race condition between GET path and Janitor iteration, but it doesn't address (my poorly worded) https://github.com/killbill/killbill/issues/342, which is regarding race conditions between Janitor runs between nodes. If several nodes are running the same Janitor query at the same time, for each transaction, one will win the lock and all others will wait on it. Once the lock is released, another node will process the same transaction (already fetched from disk, so the state would actually need to be re-hydrated) and either re-update the same state or re-call the plugin which will return again `UNKNOWN`/`PENDING`. This is where a notification queue would help (I know there are other issues with introducing yet another queue, maybe there is another way of doing this), as we really need a flag "node A is taking care of this transaction already".

Yes agreed for i) my concern in #338, and the your concern about multi-nodes (where we potentially keep doing the same thing across nodes, assuming timing is bad). We could introduce a sticky flag (where we only look for entries created on that node. Meh... Not that great neither.

Actually, there is another solution: We introduce a new lock type (JANITOR), that only one node can have at a time... (and that is held for the whole duration of the loop.


I think this should be reverted


This code seems to implement the same routine as the [`ccm89like`](https://github.com/anizami/astropy/commit/87187b3b76e8316b4153322b9714d1f1e1b534a0#diff-9bb2b9a31c3f17a2e9de8bf2ecb5a6d1R18) function in the Cython code.  This version does do a little bit better on the variable naming and documentation.  It will also handle array broadcasting better, though it's probably a little slower than the Cython version.  Might be worth doing a performance comparison.  The Cython code could be fixed to handle multi-dimensional arrays better too (though in either case that would be lower priority I would think).


Yeah, this has been around since the very beginning. All our original unit tests expect the same string layout.


But `transactionStatus` might have been updated in the meantime by someone else (other node)?


@cgwalters

I am working on another set of patches which look for specific storage driver by searching for "-s" and "--storage-driver" and also look for --dm.thinpooldev.


The platform 3 encodings I named are just as much Unicode as platform 0 is, as far as I can tell. While I agree that fonts should support platform 0 encoding 3, the issue I'm trying to address is a different one. I believe that Microsoft products at least would use the information from platform 3 in preference over that from platform 0, so it would display glyphs using that information. If this is not what platform 0 says, then we have a potential conflict, where different environments yield different results. That's what I'm concerned about.

But perhaps I should not be testing this here. Perhaps I should just pick one of the tables, and then have a separate test which checks *all* characters of these fonts, not just the ones we need to extract metrics for, and verifies that all their Unicode cmaps agree. But until I get such a test in place, I'd rather leave this check here in place.


All the `with_*` fns do this. I think it's much better to give the users clearer information about what's gone wrong than to make the argument list cleaner.


Great :+1:


Assignment


Totally agreed! :-)


This is making me wonder even more if we shouldn't change the plain ol' `Gaussian1D` to specify its width as fwhm instead of sigma, just for consistency's sake.  Or at least allow it as an alternative.


You can test this new feature with:

```lua
local uv = require('luv')
local timer = uv.new_timer()
local function a()
  error("oops")
end
local function b()
  a()
end

uv.timer_start(timer, 10, 0, function ()
  b()
end)
uv.run()
```


> (Not sure why i get your comment 4 times ;-) ? )

GitHub wants to make *sure* you got it :-)

> Actually, there is another solution: We introduce a new lock type (JANITOR), that only one node can have at a time... (and that is held for the whole duration of the loop).

Ah, interesting - the main downside though is that only one node will be able to process `PENDING` payments, which is the common use-case for Adyen, HPPs, etc.


This outputs:

```
Uncaught Error: test-error.lua:4: oops
stack traceback:
	[C]: in function 'error'
	test-error.lua:4: in function 'a'
	test-error.lua:7: in function 'b'
	test-error.lua:11: in function <test-error.lua:10>
	[C]: in function 'run'
	test-error.lua:13: in main chunk
	[C]: at 0x00404d90
```


You rule :+1:


Since you are setting a default value for RUN_SUBDOMAIN and APPS_SUBDOMAIN it could be that in provision.sh the else branch of the checks you introduced are never reached. Am I right?


I don't think this should be hard-coded or specified as such in the docs.


哇塞 真的可以装手机版的！！太神奇了！！惊呆😱


Oh i see.., scratch my comments. We do use mutable fields of the object so to do things properly we have no choice but to rehydrate.. Ok will do as well...


For people wondering why the extra regex: `parse_str()` takes a stab at parsing nearly everything. It even returns results for a `JSON` encoded string.


@valib Ok then __mediaRenderer.isTranscodeToMPEGTS()__ means remuxing is used instead of transcoding as name says :-)
But from this I expect also transcoded file can be TS and not PS (without reading the code) :-)
```
#    Profile            Video           Audio   Container   Notes
#    ------------------------------------------------------------
#    MPEGPS-MPEG2-AC3   MPEG-2          AC-3    MPEG-PS     VLC only outputs 2-channel AC-3 audio
#    MPEGTS-MPEG2-AC3   MPEG-2          AC-3    MPEG-TS     VLC only outputs 2-channel AC-3 audio
#    MPEGTS-H264-AC3    H.264 (AVC)     AC-3    MPEG-TS     VLC only outputs 2-channel AC-3 audio
#    MPEGTS-H264-AAC    H.264 (AVC)     AAC     MPEG-TS
#    MPEGTS-H265-AC3    H.265 (HEVC)    AC-3    MPEG-TS     Only FFmpeg outputs H.265, others will output H.264
#    MPEGTS-H265-AAC    H.265 (HEVC)    AAC     MPEG-TS     Only FFmpeg outputs H.265, others will output H.264
#    WMV:               WMV 2 (WMV 8)   WMA 2   ASF
#
# These profiles are supported by the MEncoder, FFmpeg and VLC engines.
# Default: MPEGPS-MPEG2-AC3
TranscodeVideo =
```
I understand why there is mime change - to fool renderer if it doesn't like some mime types. But also if user must change mime type, there is a small chance that extension can play here too. But I agree in most cases there is no need to change mime with extension too :+1:


@bloatware Please try that: https://github.com/textpattern/textpattern/commit/097eb2bb8053f7162a443a189aee85e0933562cf and report if there are any tweaks required.


The leading comma is an artifact from a particular place in the code. We
can assess removal for the next major. That is a BC break for any tests
that may exist now outside. :(
On Jul 9, 2015 11:54 AM, "Surma" <notifications@github.com> wrote:

> Yeah, this has been around since the very beginning. All our original unit
> tests expect the same string layout.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/material-design-lite/commit/213ae4df3d44698ffee35072e4e0db9d3ccc160b#commitcomment-12087970>
> .
>


I don't think the initial modules need any of these #defines. If my understanding is correct, they're just a bunch of static arrays. I'm a little confused that they exist as a separate target though - they should be in libHalide


yrtytreeuyt


Cool this commit makes ALL perft cases pass, looks like we now have fully valid chess engine!


Heya, sorry about this.  I believe this change was just lacking the + 1 at the end, and 41 base map units are correct.

For Ingaret in Coerthas Western Highlands (http://i.imgur.com/8yuuRj2.png, 32, 35), with the missing + 1 added to 41 units, I get 32.452119770803, 35.8526370556731.  With 40 units, I get a position of 31.6849948983443, 35.002572737242.  This is for Level key 5787540 if you'd like to check.

Btw I also made a similar change to FishingSpot, happy to fix or revert that too if you agree.  FishingSpots had another problem where multiplying the new size factor would push them off the edge of smaller maps.


"sigma is as specified"--specified where?  In relation to the FWHM, or...?


I think we are filtering users by membership id instead user id. So it's better to use project.members (User model) instead project.memberships (Membership model).


Joseph, I found that offsetHeight isn't accurate enough in IE and this is the reason the side floating column drifts out of sync with the table. I fixed this (on top of your code) as follows:

                var allHeight = node.getDOMNode ?
                    node.getDOMNode().getBoundingClientRect().height :
                    node.get('offsetHeight');


Thank you for the explanation... it is a product of confusing names for repos :)


In this method we check project is not none twice


This patch not working and is outdated. See [PR7160] (https://github.com/xbmc/xbmc/pull/7160)

.bimsarck


Does this specific definition of sigma really belong here?  Where does the number 2.354820044 come from? (When I google it the absorptiongaussian model from Sherpa comes up, which also doesn't say anything about this number...?)


Yay!
On 9 Jul 2015 18:02, "Tomas Rehak" <notifications@github.com> wrote:

> Cool this commit makes ALL perft cases pass, looks like we now have fully
> valid chess engine!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/trehak1/chess/commit/ebaa2fa2258c3fa2e350dceaf837e4c40b7d39bc#commitcomment-12088133>
> .
>


Can you figure it out and consolidate this to one place?

Can you start documenting your organization and what you discover about the existing organization into some README.md files?


Looks good, don't see any reason not to merge.


You might want to use the delay timer api to wait for 2us. That would involve implementing the backend for the API as well. But you will be able to use `udelay()` which will be cleaner.


I'm concerned about introducing an unconditional call to `usd_post_send_one_copy` for small messages at this point.  `usdf_dgram_prefix_send` is the primary TX path used by OMPI, so this is a very important function for our MPI latency.  `usd_post_send_one_copy` will end up doing two things that are probably undesirable here for the non-`FI_INJECT` case:

1. it will unnecessarily decode the `flags` (which should be flags below, not the boolean)
2. it will introduce an extra memcpy of the buffer for non-PIO sends

The advantage of introducing this here is that if we *are* using a PIO queue then performance will be better, but I don't think we have the PIO mode enabled in libfabric yet at all.

I'm still thinking about it, but it would probably be better to only call this routine `if (ep->e.dg.tx_op_flags & FI_INJECT)`.


With this patch applied I'm still occasionally hitting an error which I believe shows that this only partially fixes the issue.

    An error occurred while executing multiple actions in parallel.
    Any errors that occurred are shown below.

    An error occurred while executing the action on the 'group2-0002'
    machine. Please handle this error then try again:

    Vagrant can't use the requested machine because it is locked! This
    means that another Vagrant process is currently reading or modifying
    the machine. Please wait for that Vagrant process to end and try
    again. Details about the machine are shown below:

    Name: group1-0001
    Provider: libvirt

I believe this suggests that something during the vagrant run for group1-0001 is communicating with the ssh channel of group2-0002 preventing the vagrant run for group2-0002 from accessing the ssh channel.

    ==> group1-0001: Running provisioner: ansible...
    ==> group2-0002: Running provisioner: ansible...
    ==> group1-0002: Running provisioner: ansible...

    <lines from other machines getting provisioned with ansible>

    ==> group2-0002: An error occurred. The error will be shown after all tasks complete.

    <few lines from the other machines being brought up at the same time>

    PYTHONUNBUFFERED=1 .... ansible-playbook .... --limit='group1-0001' --inventory-file=.....

    PLAY [all] ********************************************************************

Based on the output that the error for group2-0002 appears between the ' group2-0002: Running provisioner: ansible' output and before the ansible command being executed is printed to the console, I'm guessing that the source of the ssh channel being communicated with is somewhere in here.

I'm not sure whether it's the action in the vagrant-libvirt plugin that provides the response for ssh_info or something in this provisioner that is causing the problem, but it does seem that the parallel provision is a little more complex than just ensuring the creation of the inventory file is managed by locks. I may try locking the retrieval of the ssh_info as well to see if that avoids the problem.


Exclude deleted users and system users.


ok


I hope my change here in terminology makes sense: having the first one 'win' but not giving an error on a subsequent registration looks like a bad idea to me, hence the alteration.


I just discovered an interesting thing - frontpage uses template names with dashes _everywhere_.


nit: you meticulously separated the variable declarations from the body statements in all the other helpers, but not this one


BTW, this patch now exists for core: https://rt.perl.org/Ticket/Display.html?id=125586


We we calculate watchers and assigned to if we send to all members
members


DomainListener service does not resolves our problem. using superior symfony routing system is more useful for us with routing conditions like https://github.com/okulbilisim/ojs/blob/master/app/config/routing.yml#L4.


Is it worth adding `hasQualifier()` method to `GLSLQualifiedType`?


FWIW, IA has been using this 11-field format as pretty much standard for new CDX files:

`CDX N b a m s k r M S V g`

(You can see it as the default in their CDX-Writer:  https://github.com/internetarchive/CDX-Writer/blob/master/cdx_writer.py#L37)

An older 9-field format that was in use a few years back was: ` CDX N b a m s k r V g`

I think most of the other fields are obsolete, and date back to an even older Alexa .dat format.


I was in the midst of a hacking session, and I may be conflating this with a different issue. If I have time today, I'll verify if this is actually a problem.

Until then, let me describe how I'm using your stuff.
I'm starting up ES with a data-only container. The data-only container has one volume, _/usr/share/elasticsearch/data_. The command looks something like this;

    docker run --volumes-from es_data_container ..... deviantony/elk-elasticsearch

Like I said, I'll have to test it out, but I'm not entirely certain this is a problem. You would expect the volume in the data container to take precedent over the volume in the ES container.


This patch not working and is outdated. See [PR7160](https://github.com/xbmc/xbmc/pull/7160)

.bimsarck


留个空


```clj
user=> (def a "Hello")
#'user/a
user=> (def b "Hello")
#'user/b
user=> (= a b)
true
```

Last time, I promise. ;)


I nominate Arthur or Seth.


nit: no point in initializing these variables.


Brauchen wir das?


Should be calculated from chain parameters.


@madebymunsters DWMR. `return @"to the next checkpoint!";`


I'm going to redo this logic, it's confusing


I had a quick look at UCS-2 and UCS-4 and they're just a different way of encoding the same unicode endpoints.  I assume that fonttools handles the decoding so we should get the same characters for the same code points regardless of which platform they're for.  Disregard my previous comment.


@javisantana This commit is very scaring. I'd be great if you could please share your thoughts with me. Please read the message of the commit for a brief explanation of the issue I'm trying to solve here. Thanks!


is the *buffer* actually the size of `USDF_DGRAM_MAX_SGE`?


This approach is sensitive to the maximum confirmation rate of txes in KB/day, which is good.

But it is not sensitive to the actual fees being offered, which could easily lead to the increased fees not making any difference.


Did this change?
In this commit: https://github.com/rmetzger/flink/commit/c8de6568d1522dc2aa4c10353634e2978edaaafa you actually added the chaining case to the method.
I think we should add more test cases ensuring that the checkpoint confirmation is working properly for the chained case (ensure they are called exactly once).


I should preface this by stating that threaded programming is _not_ my forte, so it's entirely possible that I'm missing some key items; I'd appreciate a pointer to a decent reference.

So, ll. 194-211 are for initializing the min & max on the first addition of data to the bucket, correct?

In that case, `b.min` and `b.max` will be at their zero values, and thus `cur := b.Min(); cur == 0` and `cur := b.Max(); cur == 0` will always be true, right? I'm unclear on why the check is necessary in this case; does this protect against misbehavior from within the package, or against wraparound on the counter?

Now, on l. 196 we're checking to see if `b.min` is equal to `cur` (which is always zero, due to the check on l. 195)), which it will be unless another goroutine or thread modified it after l. 195 executed; if it _is_ zero, we unconditionally set `b.min` to `val` in the `CompareAndSwap`, and if it's not zero we set it to `val` on l. 197, but only if val is less than 0. I think what this is getting at is 'if this is the first addition, then set `b.min` to `val` as long as someone else hasn't already set it behind our back,' right?

Finally, on line 200 we set `b.min` to `val` in the case something in this package _did_ modify `b.min` improperly, or in case of a wraparound.

All of that is necessitated by the fact that `b.min` starts out as zero when no data have been added to the bucket, right? Could it be avoided by setting `min` to `math.MaxInt64` in `NewBucket`? In that case, `Bucket.Add` could just call `Bucket.setMin`, and even if another caller is adding data, so long as `setMin` is safe `Add` is safe, right?

Likewise, could `max` be set to math.MinInt64 in `NewBucket`, allowing `Bucket.Add` to rely on `Bucket.setMax`?

`setMin` and `setMax` look good. If I read them properly, they're a standard test-and-set to keep from losing data.


Good point.


How does that work? Was my analysis on #1602 wrong?


Hey hey! I am Sira lol. Mostly my work here :P


@rafaelfranca, why does @matthewd get to rage close this bug?  His opinion was backed up by nothing (just declared) and was clearly wrong, it is not "more useful" to loose the ability to decode the array, I actually provided a coherent argument.


See https://github.com/projecthydra/sufia/issues/1235


The alternative would be:
```
var index = layerView.getLayerNumberByIndex(i);
if (index !== -1) {
  layerView.setInteraction(index, true);
}
```


Did you mean for the name to have the word "app" and "id" ? if so, you are missing a P and you should capitalize the I of ID.


надо у модели сделать вычисляемое свойство с нужным форматированием


Puh, gemäß Kommentar eher nicht. Ist ja nur ein HTML Cleanup. Kostet das Zeit?


We could also check if the `sublayer` is visible here... and skip this whole thing if the layer is hidden.


Gabriel,

This pull request includes changes to the framework, was this intended?


чем double плох был?


TODO: _ev3; の後にスペース挿入


Yes, just updated to the latest framework.


You're the best

Sent from my iPhone

> On 09 Jul 2015, at 18:06, matejferenc <notifications@github.com> wrote:
>
> Yay!
> On 9 Jul 2015 18:02, "Tomas Rehak" <notifications@github.com> wrote:
>
> > Cool this commit makes ALL perft cases pass, looks like we now have fully
> > valid chess engine!
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/trehak1/chess/commit/ebaa2fa2258c3fa2e350dceaf837e4c40b7d39bc#commitcomment-12088133>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>


Error message on `rspec spec`:
```bash
.........x**y
SYMENGINE_ASSERT failed: /home/abinashmeher999/gsoc/symengine/symengine/symengine_rcp.h
function operator->(), line number 93 at
ptr_ != nullptr
Aborted (core dumped)
```


Wow. Thanks!


Что за Pos? лучше не использовать сокращений в названиях. и классов и переменных


Hi @JorgeFerrer, you're right. We no longer need to display the tabs. I've removed the tabs and sent a pull to Brian https://github.com/brianchandotcom/liferay-portal/pull/28120. Thanks!


camelCase гораздо лучше смотрится, чем подчёркивания


Perfect - works for me!


Same happens for `get_args` [here](https://github.com/abinashmeher999/symengine/commit/df0f56bc8bb73d1498979ec252e21b86aeac4576).


Move this into _includes/head.html


Varada,
I think we need to add a config option for the sync and async..HDD world will be a problem if we go for sync route..


related to open issue #1


Why not `modules.remove('mapreduce')`? Side-effect of writing too much Scala? But a functional language should not have side-effects!


`85 additions and 145 deletions.` :+1:


Looks good. any tests?


No, they include templates through the router I guess, or by passing arguments to Template.dynamic. So it works everywhere _except_ `{{> template-name}}`


Why not just use the linked list and write a stack interface over it?


Already in there—I'll remove it from the local file (just needed it for local testing).


Did you just release with tests [failing](https://travis-ci.org/hemanth/hosts-lookup/jobs/70207219) (and in fact a totally broken module)? There's a reason you have CI and write tests ;)

Tip: use [`np`](https://gist.github.com/sindresorhus/8435329) :)


So you didn't have to change everything else?


O link da organização é privado. Só quem está na organização tem acesso.


Please be aware that while disabling `USE_COHERENT_MEM` will save you around 4K worth of memory, the bakery lock implementation will use software based cache maintenance to make the locks work. On Juno we have seen that this adds to the latencies in the power up/down code paths. Have you had a chance to do some measurements at your end as well?


почему public?


The nature of `diff` means that it's nearly impossible to review this patch.  I'm just trusting you that you only reordered the functions and added comments, per the commit message.

Hopefully nobody else at Cisco has pending patches to this file :wink:


You might also want to add a message announcing these changes in the app. Like a popup after updating to a version before this one.


:ok:


@Raesu DWMR. Good good. Press on.


зачем редирект?


и тут зачем редирект?


Fair enough.


I changed that as a refactoring later to make it cleaner. If you check the setInitialState method in the current master you can see this.


neutral*, sorry for the typo


Here is a trace of incomplete merge


I think the old copy loop was slightly more readable, but you don't need to change it.


What i wanted to do is display the helplines in a hoverfield so we can use these to really describe the command in bigger detail. :)
I used the if ( !hasNext) ... to only create the mson if there are helplines ;)


I've created an issue for this problem.


oops, fixed in c104bc2


This will print `/n` without a newline.  Did you want to print a newline (`\n`)?


Yes. I like calling a voltism a voltism, at least in the short-term.
OTOH, the "Expression." qualifier when accessing a locally defined or inherited static method seems noisesome --
like using "this." or in C++ "this->" , the benefit escapes me.


I wouldn't need an iterator though... I'll fix that ^^


FWIW, NaCl's x86-64 sandbox [allocated 84GiB of virtual address space for this](https://developer.chrome.com/native-client/reference/sandbox_internals/x86-64-sandbox#x86-64-sandbox). NaCl lives in its own process though, this is unlikely to be a good idea when the process' address space is shared!


@tw2113 I'm pretty sure you don't want to `return` here. I'd place the `add_filter()` in here and check for `if ( bp_is_active( $object ) ) {` instead.


1. имхо очень странно, что неавторизованный человек впринципе может что-то такое на UI нажать, чтобы заказ оформлять
2. давай везде { } расставлять. даже если из 1 строки тело оператора


delete the file


o good


FYI, this broke `brew update --rebase` - `git pull origin --rebase` isn't valid.


Normally I'd suggest replacing this check with a call to a function, which is configured by build tags (like in `node_linux.go` etc.), but for tests I think this is easier and clearer.


Seems like we now should enclose the ref to daemons in try/except


To clarify:

```php
if ( bp_is_active( $object ) ) {
	add_filter( 'wp_ajax_' . $object . '_filter', 'bp_registration_hide_ui', 1 );
}
```

Otherwise nothing below will run


Fixed it, my bad heh heh


Btw, make sure you use `WITH_SYMENGINE_RCP=no` when Developing. I just enabled it by default in #513.

We need to debug it to see what is going on.


You can just shorten this to `<meta charset="utf-8">`. #protip


You were completely out of line on your tone and your indignation. I don't care what kind of bug you found, that's no justification for such antics. Nobody here owes you anything.


Will amend later.


Hi! Just noticed you've changed to the trial app, any legal reasons for that?


:bitingnails:

On Thursday, July 9, 2015, Bert Spaan <notifications@github.com> wrote:
> @wires : I think new API is ready! Deploy! <
https://ci5.googleusercontent.com/proxy/pA9KwOWPaoArvGg9KGOQGSWAB40wGycnUjKGDpKRDMyv377olqcp--ys6gxLz3BF9ftOn1Cc4nYDkDVqN4oZ_2PJ93yjx1ImgSuC-VG1_svLs2mZ3xcwZg=s0-d-e1-ft#https://assets-cdn.github.com/images/icons/emoji/unicode/1f4be.png
>
>
> —
> Reply to this email directly or view it on GitHub.<
https://ci4.googleusercontent.com/proxy/VK9KKVyilTFKA5yZPDmgcnJWoXmqw6-nmhqi3hwmY1hrWe552AqZlaTEsF4FxnocWJkUn6HbKSj4E0KYN1RCAltbWaz3AknytAfw4QhbSbXjMBWVspXe0E_iZXkk9bRDURMgsDsjRCaSFdtgTyRYahGf9zsE0A=s0-d-e1-ft#https://github.com/notifications/beacon/ADfUaqutiIP2lNnJ2qxjBTJI1RaIooQtks5oblvYgaJpZM4FVNwX.gif
>


@luke: what about making this check instruction an actual bytecode, which
could then be placed by producers, e.g. to guard loops as well?

On Thu, Jul 9, 2015 at 5:33 PM, JF Bastien <notifications@github.com> wrote:

> FWIW, NaCl's x86-64 sandbox allocated 84GiB of virtual address space for
> this
> <https://developer.chrome.com/native-client/reference/sandbox_internals/x86-64-sandbox#x86-64-sandbox>.
> NaCl lives in its own process though, this is unlikely to be a good idea
> when the process' address space is shared!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WebAssembly/design/commit/57bdfbe7d8beef86bccf5af4854dfb1f6968651d#commitcomment-12088800>
> .
>


Should not be current date. `throws` I think is inherited from the superclass, it's not needed by this code, and could be removed.


It's :green_heart: now (:


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/14889/testReport/) for this commit**


@DmitryLeo WTF?


@Gigozzo dfddf


This case is still not covered. (And others where an expression with incorrect pattern is in the right part of the assignment)
```erlang
foo() ->
  X = [A || A + 1 <- []]
```


Thanks!
On do 9 jul. 2015 at 18:40 hemanth.hm <notifications@github.com> wrote:

> It's [image: :green_heart:] now (:
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hemanth/hosts-lookup/commit/c68e0bec33630e2d7b6eb6c2bd195979f00d4f19#commitcomment-12088922>
> .
>


Yes, I moved rpi2-jessie from staging to stable to build Debian/Jessie native RPi2 images (so not to have main/staging included). But this happened early in the morning ~800CET. I wanted this be available after some other things when I return to continue on build-img configs but - I don't know why - the previous content was correctly removed, but new not read - only for rpi2 in stable. this happened at 12CET but then at 16CET it updated OK.

really no idea.


This line needs one more space in front.


Why two nested ifs here? Use &&.


I think these actually require a target where ``POOTLE_SETTINGS`` is defined much like ``:djadmin:`` so not sure this actually does what you think it does here.


I need to talk to Perry about this. This is his code, but it doesn't seem to produce decent results.


You have your code duplicated 4 times. Extract a method.


Not sure if isinstance is the right thing, but this breaks my test for finding the Lambda nodes generated by mesh_distances.py (in core). The above would work if I do something like

        from ch import ChLambda
        import chumpy as outside_chumpy
        for node in self.traverse():
            if isinstance(node.ch, ChLambda) or isinstance(node.ch, outside_chumpy.ch.ChLambda):
                node.ch._call_on_changed()

which seems like something I shouldn't need to do. Should lambda nodes just be given some special flag? I'm not sure what's going on because if I open a random shell and run

>>> import chumpy
>>> chumpy.__path__
['/Users/eerac/Code/chumpy/chumpy']
>>>

I see that I should be importing my local install of chumpy from core


What's a good way to do a performance comparison?


Why?

Am Donnerstag, 9. Juli 2015 schrieb Ramon Smits :

> In your example, let them first update to the latest minor/patch first.
> From v2.5 -> 2.6.x -> 3.x -> 4.x -> 5.x
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Particular/docs.particular.net/commit/51bc4588512f4dfd21f9e6fce0e51c90917ea887#commitcomment-12086540>
> .
>


This is going to make multiplayer fun to merge!


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.402.94ce61c40440c1a08e42d56dc316d48ca0bc174f](http://build.palaso.org/viewLog.html?buildId=59512&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3319, ignored: 130 Build time: 00:10:38


Thank you!


Yeah, I just kept it in here to discuss this. I was considering making an extinction model base class and working with that.


According to http://sphinx-doc.org/markup/inline.html#role-envvar there is no need to have a target. My aim was to just style this properly.


@zhouyuan, i see. i withdraw my comment w.r.t. the API things. `RadosClient` is only the internal implementation of librados. so your change does not impact the API at all.

so, only one comment now: how about `int16_t` ?


I think this change could lead to crashes as `GLOBSET_parse` does not do any sanity check. Check this for details:

https://github.com/openchange/openchange/blob/jkerihuel/fxbuffer-parser/libmapi/idset.c#L258


Doesn't this also impact some docs or are there no docs for ``flush_cache``? If it just clears stats that doc might be pretty easy to write now.


:) done


Don’t remember. Looks like an error.


At this point, if I have a nation whose poses are not all sacred/elite, should the sacred/elite poses be #theme "sacred"/#theme "elite", or #sacred/#elite?


Please don't bring this requirements rubbish back, I spent ages removing it as its of no use to us at the moment.


No. There are no docs for this command. See issue #3500.


Can I PR with the non trial url? And correct app name?


... are all available table settings <b>showing</b> their respective values at the time of the execution...


Yup, it fails, with the error message hardcoded into the following lines.  Searching for "cygwin setrlimit RLIMIT_DATA" yields a doc which says it always fails on cygwin. (Known bug; WONTFIX) Still can't get dnscache to run. Haven't tried tinydns yet, though others have reported success.
On Jul 9, 2015 07:15, P J P <notifications@github.com> wrote:Hi,

Does it throw any error upon failure? And with the above change what would be the default value??

—Reply to this email directly or view it on GitHub.


or until they make a bow with different attributes


#theme "sacred" and #theme "elite" are how it's done everywhere.

Do note that if you want sacreds or elites from poses you should just use #role "sacred infantry" etc instead. #sacred and #elite or the #theme equivalents do fairly little if anything right now.


Согласен, просто там столько писанины, мне показалось проще клонировать.


Yes.

There’s another needed addition, though (likely why this was changed). Above `url`, add the line `# pixelcut.com is the official download host per the appcast feed` ([example](https://github.com/caskroom/homebrew-cask/blob/3c4e24bc227449d856dc7226f512e9a61537e279/Casks/slack.rb#L5)).


@ktrzeciaknubisa see TODO for test output


I've deprecated the name "simpleASR" in Flocking, and it will be removed in a future release. That unit generator has been renamed to <code>"flock.ugen.asr"</code> instead. Both names work, but better to use the new one if you can so your code won't break in the future.


Kinda figured. The Abysian changes I made last night went heavily in this direction, but since I was redundant with both roles and tags, they should work fine. I'll clean up the now-meaningless tags at some point to make the files less confusing, though.


:+1: You're welcome bro ;)


There was no indignation, the tone is your interpretation and was not intended.  I simply saw a worthless opinion backed up by nothing, and stated it was wrong.  If you are going to claim something is more useful than you should show how it's more useful.  Otherwise it is argument by authority.

I also did not claim someone owes me something, I would have done a pull request if that's what @rafaelfranca asked.


Thanks for the feedback, I've added more tests in: https://github.com/balaclark/validity-validate-each/commit/d474e762f85c85cbb1c3b4c44cf5099fba4ff6e1


Good point, I've changed it now.


IIUC the check is security-critical, so adding it to the IR doesn't mean that the compiler has less work to do. Unless it gives us a useful hint? I'm not sure I see it at the moment.


@embray - This is something I was trying to refactor but had a hard time getting the code working. In the original specutils code, the WD01 and D03 models when instantiated, based on the value of ```r_v```, read a data file and set the ```_spline```, and this clearly doesn't need to be done every time ```evaluate``` is called. I can't figure out how to set ```spline = = interp1d(xknots, cknots)``` as an instance variable. Can this be done with the model class? It's not a parameter but it's used when ```evaluate``` is called.


From what I've understood from the `VOLUME` command, it tells Docker that the specified directory will not store any data in the container and that it requires a a volume mount.

So by mapping your data-only container, either in this version or the one before it should have worked/work perfectly.


Usage:
Attach it to the search box text field
```javascript
$(window).load(function(){
    $("#searchbox").awwtocompleet();
})
```

Made specifically to work in our case only, for now. Testing on server is required.


An update of crate can set/reset the table default values. Therefore it is the case that the settings...


Change this URL suitably


rederap http://hiphopgerais.blogspot.ca/
Direccionado ao intercambio de informações e noticias referentes a Cultura de rua, nos locais onde a mesma é praticada, também para ser intercanbiada.


You're clearly oblivious to your own actions. Please spend some time developing your social skills before attempting to comment on another Rails issue.