Nit: we prefer using the C# keywords rather than type names for things like "string", "int", etc.  I realize the rest of these files still doesn't follow that guidance, so it's fine if we just want to do a pass later to fix all of them at once.


What on earth were you thinking here?


glad to see it was temporary. Thanks.


It is private... I don't understand what you mean by 'remote the _'?


Ugh... sorry


I agree with @rweiss42: it would be better to call this function getAllSliceWidgets()


Oh, nice, I didn't realize you'd done this.  This should make it a bit easier for me to merge with my System.IO.Path changes.


It is optional, all code should work exactly as before (if the new, optional arguments are not used)


Okay.. Did some quick benchmarks and while I knew `preg_*` functions could be slow, I didn't realize just **how** slow they are.

Benchmarks are 10000 iterations of `preg_replace` and `mysql*_real_escape_string` (listed below as "with") and 10000 iterations of just `mysql_real_escape_string` (listed below as "without"). Times are in seconds, obviously. The tests were done on Debian 7 in a virtual machine with 512 MB of RAM and 1 core. The content filtered was a 108K HTML document with a handful of 4-byte characters.

### MySQLi

With: 65.132974147797
Without:  5.0039069652557

### MySQL

With: 65.506618022919
Without:  4.9950969219208

I was planning to do more tests and include PDO as well, but the difference is so large I think the answer speaks for itself. Adding the code to the DB class is going to have a massive performance impact. In fact, even running it on the `$article` array for every article is probably going to hurt for users with a large number of feeds, though I think the code needs to stay there to prevent data loss.


Ther is some more "stuff" here.


Ok, interesting : http://www.rubyinside.com/what-rubys-double-pipe-or-equals-really-does-5488.html


What Is the Class of an Object?
Every object in Java belongs to a class. You define a class in source code, which is compiled into a binary format
(usually a class file with the .class extension). Before a class is used at runtime, its binary representation is loaded into JVM. Loading the binary representation of a class into JVM is handled by an object called a class loader which is an instance of is an instance of the class java.lang.ClassLoader. A class loader reads the binary format of the class definition into JVM. Then, it creates an object of the java.lang.Class class, which represents the binary representation of the class in JVM. A class inside a JVM is identified by the combination of its fully qualified name and its class loader.

The **getClass()** method of the Object class returns the reference of the Class object. Since the getClass()
method is declared and implemented in the Object class, you can use this method on a reference variable of any type. **Check the Class class methods**


What does the turbolinks data attribute do? Is it necessary to submit the form without clicking "Search"?


In-Flight Request I have changed this now.

On Mon, Jul 6, 2015 at 9:05 PM, Chamila <notifications@github.com> wrote:

> *Requests In-Flight or In-Flight Request Count
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ashandk/stratos/commit/bfc7b468e7b666b5a1ef15a661da949c5058fbff#commitcomment-12019217>
> .
>


@InnerFire didn't understand what you mean :p
I initially thought, that if any core goes below that, it'll go offline
But then I didn't see full file so was confused o.O
We'll have to go through it
Anyway, since 1800MHz the original frequency isn't min/max of any of franco's devices, means we too should put something in the middle
1040000 should be fine


thanks! https://github.com/plone/mockup/commit/b66348399c9c8ee25c4118fb8d2b7d708e8d1a50


Typo (my -> may)

Also, you don't have to refer to 'before' since nobody will remember this.


This test accurately tests the current behavior, but this behavior should change. If the create succeeds (and it does here because we are returning 201), the call to create should not throw an error. This will be a future change though.


perhaps a better name would be scheduleAllViewRender()?


Does this actually work with Path.Combine like this?


hi theire is a bug
if you browse around from the left menu
the 311 panel do not display the right stuff
it will show the last one u selected until you select another one
the problem is comming from the mod u did on the Skin.SetString
if i go back and replace the Skin.SetString (movieshome, tvhomes ....)
and mod the Includesvars with the StringCompare(Skin.String (movieshome, tvhomes ....)
we don't have the right description


You could set **Access-Control-Allow-Headers** to the value of **Access-Control-Request-Headers**. The addon would respond with whatever you send.
Credits: http://stackoverflow.com/questions/13146892/cors-access-control-allow-headers-wildcard-being-ignored


Perhaps the comment should say `Bug2159Boolean` instead of `MyBoolean`? :)


or scheduleRenderForAllViews() ?


just curious - you moved import glob, but not import shutil - is there a reason?


I'm surprised this is hardcoded in the .csproj; it's quite fragile.  I'd have thought that these property groups would just be empty, letting the build system provide the common properties, as is done in other projects, e.g.
https://github.com/dotnet/corefx/blob/master/src/System.Console/tests/System.Console.Tests.csproj#L14-L15
Maybe this project was just missed?  Could you verify and update accordingly?


Yes. Copy and paste mistake. I'll fix now.


### What is hash code?

A hash code is an integer value that is computed for a piece of information using an algorithm. A hash code is also known as a hash sum, a hash value, or simply a hash. The algorithm to compute an integer from a piece of information is called a hash function.

Computing a hash code is a one-way process. Getting the original piece of information from a hash code is not an easy task and it is not the goal of the hash code computation either.

#### What does a hash function look like?


I find the old style notation more clear.  Is there a compelling reason to define as a dictionary literal like this?  If so, breaking the parameters out onto separate lines i think would make it a little more readable.


No it does not; it just removes those characters when it combines the paths. Those prefix characters ended up not working at all for me, so I ended up just modifying the lengths of my path names to be more reasonable.


Fuck comments. They're a sign of weakness. Commenting is like testing: it's doubting.


100 たすの？


110もたすの？


Any reason to rewrite this one here? Maybe just import it from dti?


Same with this `forEach`. `list` is empty here so this doesn't do anything.


And one more thing. This https://github.com/solnic/transproc/blob/f2df67867d9c7b0440f784b01a9ca8e932703b43/lib/transproc.rb#L43 is the line that crashed jruby


btw... This should be "graviton/json-schema"... "libgraviton" only exists due to "graviton" being taken on github....


プラスの下にコメントがでるのね。


こっちこっち


Thanks for fixing these :)


`jit` is a global in luajit, no need to require it.


Capitalization:   typogrify ---> Typogrify


:ship:


Better to omit function.  Passing `nil` or nothing is better if you just want to ignore a signal.


I don't understand this. This is to be used by the java beans spec (when constructing UIs for example). Could you explain?


To use Grunt and LiveReload on an alternative port, use syntax, e.g. `grunt serve --port 8001` or in my example, the default is `8000` …LiveReload is set to `35730` manually although I'm sure I could make that dynamic also.


もうちょっとみなおしてください


The third condition takes care of the scenario where the user returns the wrong value the first time and goes back to search for the correct person and then returns that value.  Without that condition, the person and person ID is not null then does not do the person search; therefore, it just returns the value that is already stored in person (which is the first - incorrect - value) and returns it to the page. With the condition, if personId is not null, it will enter the IF statement and continue with line 57. (See comment below)


Oh, I have completely messed up file offset and function offset. Now I understand, thank you!


This one is a bit weird because I build the Enumerable tests for EnumerateFileSystemEntries and EnumerateFiles on top of my existing GetFileSystemEntries and GetFiles code. However, I have yet to rework GetDirectories, so I left the existing tests for the Enumerables so that they would catch tests for EnumerateDirectories. I'm focusing on fixing the tests that are causing errors or temp files before I return to redo the ones that are (mostly) acceptable in their current state, so I left this as is for now with the intention of removing all of these probably extraneous tests later.


Spelling:  recitified ---> rectified


very cool! I didn't know you can do it this way!


@stuartc , I'm rake db:migrate is bombing out here, and I can't figure it out. Can you check into it?

```
== 20150123112011 AddFieldAttributesToSalesforceFields: migrating =============
-- add_column(:salesforce_fields, :properties, :json)
   -> 0.0009s
rake aborted!
StandardError: An error has occurred, this and all later migrations canceled:

uninitialized constant AddFieldAttributesToSalesforceFields::SalesforceField/home/taylor/OpenFn-Site/db/migrate/20150123112011_add_field_attributes_to_salesforce_fields.rb:5:in `up'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:605:in `exec_migration'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:586:in `block (2 levels) in migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/2.1.0/benchmark.rb:279:in `measure'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:585:in `block in migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:294:in `with_connection'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:584:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:759:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:998:in `block in execute_migration_in_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:1044:in `block in ddl_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/database_statements.rb:201:in `block in transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/database_statements.rb:209:in `within_new_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/database_statements.rb:201:in `transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/transactions.rb:208:in `transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:1044:in `ddl_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:997:in `execute_migration_in_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:959:in `block in migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:955:in `each'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:955:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:814:in `up'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:792:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/railties/databases.rake:34:in `block (2 levels) in <top (required)>'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:240:in `call'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:240:in `block in execute'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:235:in `each'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:235:in `execute'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:165:in `invoke'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:150:in `invoke_task'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `each'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `block in top_level'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:115:in `run_with_threads'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:100:in `top_level'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:78:in `block in run'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:176:in `standard_exception_handling'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:75:in `run'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/bin/rake:33:in `<top (required)>'
/home/taylor/.rbenv/versions/2.1.5/bin/rake:23:in `load'
/home/taylor/.rbenv/versions/2.1.5/bin/rake:23:in `<main>'
NameError: uninitialized constant AddFieldAttributesToSalesforceFields::SalesforceField
/home/taylor/OpenFn-Site/db/migrate/20150123112011_add_field_attributes_to_salesforce_fields.rb:5:in `up'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:605:in `exec_migration'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:586:in `block (2 levels) in migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/2.1.0/benchmark.rb:279:in `measure'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:585:in `block in migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:294:in `with_connection'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:584:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:759:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:998:in `block in execute_migration_in_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:1044:in `block in ddl_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/database_statements.rb:201:in `block in transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/database_statements.rb:209:in `within_new_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/connection_adapters/abstract/database_statements.rb:201:in `transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/transactions.rb:208:in `transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:1044:in `ddl_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:997:in `execute_migration_in_transaction'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:959:in `block in migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:955:in `each'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:955:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:814:in `up'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/migration.rb:792:in `migrate'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/activerecord-4.1.9/lib/active_record/railties/databases.rake:34:in `block (2 levels) in <top (required)>'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:240:in `call'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:240:in `block in execute'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:235:in `each'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:235:in `execute'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:179:in `block in invoke_with_call_chain'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/2.1.0/monitor.rb:211:in `mon_synchronize'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:172:in `invoke_with_call_chain'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/task.rb:165:in `invoke'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:150:in `invoke_task'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `block (2 levels) in top_level'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `each'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:106:in `block in top_level'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:115:in `run_with_threads'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:100:in `top_level'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:78:in `block in run'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:176:in `standard_exception_handling'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/lib/rake/application.rb:75:in `run'
/home/taylor/.rbenv/versions/2.1.5/lib/ruby/gems/2.1.0/gems/rake-10.4.2/bin/rake:33:in `<top (required)>'
/home/taylor/.rbenv/versions/2.1.5/bin/rake:23:in `load'
/home/taylor/.rbenv/versions/2.1.5/bin/rake:23:in `<main>'
Tasks: TOP => db:migrate
```


that's already called from _start


Could you explictly comment on the "untyped Configuration.getData().TEST_PORT" why we are doing that? If I recall correctly, it was to make the feature backwards compatible.

That seems to be the only needed change, and it is shared between the other pull requests for the targets as well.

So just add the comment on all the targets, and we can merge everything.


Clever use of %. I like it!


What are bridges of a bridge?


restructured text ---> reStructuredText


Hi @svaksha, I would suggest taking my NeoVim.jl package off this list. Now that @bfredl's is moving forward I'm going to delete mine soon.


could  explain why we shouldn't serialize them? They're caching variables that are reconstructed?


Why does this method need to be ```synchronized```?


there is a potential for inconsistency here - class variable vs setting. Does it make sense to always use self.getSetting() in place of direct access to class variables that are stored in settings? What do you think?


`list` is also empty here.


I think it would make more sense...

You wouldn't need the long textual change you added on that case.. unless you really care about it (which I wouldn't mind if you do).. just looking for what makes more sense.


Const.isWindows() ?


へらしすぎじゃないですかね。


There's no need to use three temp nodes.
Just two will do.


:hear_no_evil: :see_no_evil:


I actually think the previously language here was clearer. Passive voice makes this awkward and difficult to comprehend.


Maybe you are right. There is no special reason.


just find out: putting "!!" at the end of your commit text copying the last command line you've typed in add to the commit text...


# start the ssh-agent in the background
ssh-agent -s
# Agent pid 59566


can you remind me what is the reason that the selected item number changed here?


fix this commit message
subject must be at most 70 chars
use the description to put the rest of the information (after an empty line)


@snordhausen : variant 2 is LSB compatible but does not work with yadt. That's exactly my point. If a service, say tomcat, is starting and starting tomcat immediately succeeds then either

* status returns 0 and we will start dependent services that will fail (this is not allowed to happen!)
* status returns 1 (service not healthy) and your deployment fails

Thus we need this for **all** init systems. You're right that the current implementation only handles sysv but that merely means we need to implement it for upstart and systemd as well.


It might be because we build the Microsoft.Framework.Runtime.Sources into the assemblies.


yes, either there, or in the constructor (but `parse()` seems better to me, we already to some parsing in there), as this can all be encapsulated into the `PluginHandle` class...


dynamic allocation is forbidden please allocate a static array


A couple of things:

- [ ] `test_setup` tests the same thing as `test_setup_instance_iface`. We should delete `test_setup`.
- [ ] We should use `self.assertTrue(...)` rather than `assert ...` because it prints nicer errors and isn't removed by running Python with optimizations turned on.
- [ ] At the moment `test_get` doesn't call the `get` method.

The `test_get` method should do something like:

 1. create an empty opt out store store
 2. add an opt out
 3. retrieve the opt out
 4. assert that the retrieved opt out has the value we expect


GMail is flagging your comment as:

"Be careful with this message. It contains content that's typically used to steal personal information." =)


Again, just trying to enumerate the risks here.  It's up to server ops to decide what risks they tolerate.


This shouldn't be included; I missed it. Updating now.


Yeah, NuGet probably needs to port our "rename framework assemblies" fix...


What, good advice?


is this on the Compute Engine page? it there a ticket for it?


I didn't mean to imply that it was worse than a link.  How about:

> If the server requires a user to respond to a message sent to a contact address containing a secret value,
> then the contact channel will need to ensure that an attacker cannot observe the secret value and spoof
> a message from the contact address.


The scenario where the user returns the wrong value the first time and goes back to search for the correct person and then returns that value.  With the third condition added on line 56, if personId != null, it makes the if statement true then continues to this line.  This line checks to make sure person is not null and if the person.personId is the same as personId.  If they are the same, it will return the value already in person (the first searched value), but if they are not the same value (which happens when you do a second search for a person and return that value), then it will do a new person search with the value in personId.


This code works fine, but instead of having to use `start -= 1` when a player clicks on an already-clicked square, maybe you can get rid of line 19 and just move `start++` into the X/O if-else blocks that begin at line 8 + 12.


Just updated it. Things got a little messy after the reorg, but hopefully a few changes I just made will clean them up.


>have been used each last module

I don't understand this sentence


any email or JIRA to work out this question?


Hmmm, if you rerun bapv2 you see everything again.


I think that the inputDataDir is only set once in step 1. Therefore we could use the class member. Or might the setting get changed from outside so that we always need to retrieve the settings?


The word "static" is a Java specific keyword. While this is using a similar concept in JavaScript, there is no such thing as a "static method" in JavaScript. I think a more accurate description of what is going on here would be something like "should update a call using its ID without performing a GET".


This change BETTER get things working again on CircleCI......


A la place de "climatiseur" pourquoi ne pas mettre "système de refroidissement" ?
et je voulais vous saluer car c'est ma première participation a la traduction de RimWorld ^^

Sent from Mailbird [http://www.getmailbird.com]
Sur 06/07/2015 10:04:16, Némo <notifications@github.com> a écrit :
Le truc c'est qu'après quand je pense à une climatiseur, je m'imagine mal un truc qui peut faire descendre la température hyper bas (pas quelque chose qui descend jusqu'à -5°C en tout cas). Enfin c'est peut être ma conception d'un climatiseur qui est foireuse aussi... ^^
Après c'est peut être mieux quand même effectivement, ça fait peut être plus «français» (moins traduit mot à mot je veux dire). :)
—
Reply to this email directly or view it on GitHub [https://github.com/Ludeon/RimWorld-fr/commit/64c94f4232e712d90e8cb363c71072c40b142622#commitcomment-12010578].

---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus


Please capitalize all type names. Names starting with lowercase are reserved for variables only.


Proper indentation please! Sorry, I'm a stickler for it. But it makes reading code so much easier, not only for me but anybody else who might take a look.


#### If your class is mutable, you should not be using objects of your class as keys in hash-based collections.
Check what mutable means.


Any particular reason you are starting at version 1.0.0? Are you familiar with http://semver.org/


Please fix typo in the name (```GeocodedResultReceiver```)


Please fix spelling mistake: ```addressData```


I did that, because shutil is only used locally in that method. Glob is used several times across the source file.


Addresses #13.


Note, the regex needs to be changed in classes/regex.php as well.


theoretically, it is not necessary to override `createForFile`, we will never visit a File


Ok, I understand your vision. In my mind, it was is a technical error to query a non existing parameter (like calling a switch that do not handle a specific value). That's why I was thinking of an error log. And allowing to know if a specific key exists before calling the get function (as you did) is enough to guarantee that there should be no call to the get function is the key do not exists.
Sorry for bothering you about such details but it's just that I think it is always good to print an error log if something that may break the game happens. In this case, as a developper, if I call the hasKey function and it returns true, I wouldn't expect the value to be invalid or empty. And, thus, printing an error message seems more appropriate to me.
That being said, that's just my vision. I understand yours and, if you prefer to stay like this, I will follow your judgement.


Can you also add `"private": true` so you don't accidentally publish this to npm?


You did a great job with this! You knocked out the minimum requirements and I think you could easily start taking on the bonus questions. Happy to talk about this assignment more during our one-on-one meeting.


input_up_btn = "-1" will be the same as  input_l_y_minus_axis = "-1", will it work? There are some conflicts here


what is the advantage/reason to use property instead of staticmethod here?


I don't know but I copied it from the test above this one. I'll fix it


But I never use "we" in my comments - so using it here will change things. I will reword it if necessary...


I would be careful about using auto generated resources, there's a lot in here that does not apply to your repo, and likely never will.


Finally!  Now both the CI's are ok with the generated dyna_big_crypt.c code.


done


That ANALOG led is ON or OFF ?


Please name and move to a central location the magical constant 3


I agree with Robin.


@mikesaurio hay que eliminar estos comments para que no queden en la vista. Si es necesario los agregaríamos después.


Please name these constants in an even more explicit way, so as to explain what they represent, or, at the very least, add a comment to explain them.


I would go back to EXT4 for testing purposes. There may be a hangup with the init binary to handle the lookup for F2FS. It may need to be updated in the ramdisk for it to work first.


I know I arrived after the discussion about "sut" took place I saw the emails), but I really don't like this practice. It defies rule n°1 of variable naming: it must be clear.
I prefer using a name such as "underTest", same intent in naming but it is clear as plain English and there is no debate to have about "system" or whatever (there is no system here anyway, it's just a single object)


test comment


#### How should you implement a hashCode() method for a class?

How should you implement a hashCode() method for a class? Here are some guidelines to write the logic for the hashCode() method for your class, which is reasonable for most of the purposes:
- Start with a prime number, say 37.
int hash = 37;
- Compute the hash code value for each instance variable of primitive data types separately
using the following logic. Note that you need to use only those instance variables in the hash
code computation, which are also part of the equals() method logic. Let’s store the result of
this step in an int variable code. Let’s assume that value is the name of the instance variable.
For byte, short, int, and char data types, use their integer value as:
code = (int)value;
For long data type, use the XOR for two halves of 64-bit as
code = (int)(value ^ (value >>>32));
For float data type, convert its floating-point values to an equivalent integer value using

code = Float.floatToIntBits(value)

For double data type, convert its floating-point value to long using the doubleToLongBits()
method of the Double class and then convert the long value to an int value using the
procedure as described above for the long data type.

long longBits = Double.doubleToLongBits(value);
code = (int)(longBits ^ (longBits >>>32));

For boolean data type, use 1 for true and 0 for false.


test comment 2


Well, it's useful as long as the code contains any pr_xx calls.


format 123


It probably won't be changed from outside. But I am thinking more about how the interface to these variables is defined to be more uniform to simplify code understanding. inputDataDir is a setting, and it might be more intuitive to have a uniform way to access/change settings.


none of the other IDs were off by 1 ?


Yes this is Java bean serializers like the JSON serializer is based on Java bean.


I did some research and only found that pitch needs to be >0 for OpenAL. Can you direct me to somewhere where I can find the maximum allowed value or explain why it needs to be limited in this place?


They terk his jeeeerb!


Makes sense, thanks!


修正しました．


gratis


gratis jefatura ocurrir ilusión


HBIRE_vector_take2 (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1675 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Needs to be changed I think.


Hi @elpaso, may I know where PIL is being used in the code base? I tried to find ```from PIL import Image``` or ```import PIL``` but couldn't find it. I couldn't install PIL (there are some work around to get this installed), but it seems that this is not active anymore and should be updated to Pillow


예전에 [IsArray 에 대한 글](http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/) 을 읽었는데, 여기서 언급되는 ['Duck-typing' 기법](https://en.wikipedia.org/wiki/Duck_test)인 거죠..?


I would use a small `e` in `_or_exit` for consistency with other state names.


Probably meant to be if (fn2) free(fn2);

I can make this change if you wish.


Yes those are not EntityReference properties. It's just caching commonly constructed representation used by various EntityReference helpers and which don't need to be serialized.


I think that doesn't make a big difference. But in my opinion it's better to use a property because it looks for users like a class member and not like a method. Maybe that is a matter of taste.

Properties are very useful to hide logic from the user. The user assumes that the property is just an attribute. Very useful is that when code might change and you want to hide that from the user to stay backward compatible.


prefere restart the server, cause database setup load all auths in cache


commemtnt


I think this can just be a `ChoiceState`, since the number of options is small and constant.


Please take a look at 5a36c5b

Don't mess with the config. I'm pretty sure that it was all right.


Valeu, grande capitão! Espero que te seja útil.


Okay. How about:

> since the plugin doesn't know how to handle other Generator types.


Your `script.js` is short, readable and gets the job done. Nice!


what are you doing? i see you tried to consolidate the three calls into one, but there is no point.


Well it does a better job than current way so I guess we can say it works.


> In this case, as a developper, if I call the hasKey function and it returns true, I wouldn't expect the value to be invalid or empty. And, thus, printing an error message seems more appropriate to me.
That being said, that's just my vision. I understand yours and, if you prefer to stay like this, I will follow your judgement.

I understand that very well. :) Another way to do that maybe would be to integrate hasKey and getKey function as one. I've thought some more about it, and everywhere I went, I usually ended up seing that, more or less:

`const std::string& getValue(key, param, defaultValue = std::string()) const;`
This will return the given default value when not found and will trigger a warning/error if so.
To make everybody happy (at least us two), I can change the API to this.

I also wondered whether it would be best to move all the settings in the same map, and use prefixes to differenciate the param families. The code would look less naive that way.

WDYT?


👍 `event.target`


inside the `.then()` you need to return `Parse.Promise.as(someObject)`


After discussion with Rory and Ben it seems that no-one can remember why the checkbox was being hidden and agreed that the logic is not needed.

Leaving the table submit handler intact as it is applied to several events ('click', '.js-datatable-submit, .js-datatable-delete') on the tables parent form.


What is the standard notation for settings? I thought it is something like modulname/settingname

We could also invent something like
getSetting(moduleName, settingName)
setSetting(modulName, settingName, value)


Could you export this method and write a spec or two to directly test its behavior?


This should not be included here @jonasheinrich


TeamCity Jarvis Framework :: CI-GitFlow [Build 14](http://build.prxm.it:8811/viewLog.html?buildId=3359&buildTypeId=CqrsFramework_CiGitFlow) is now running


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17553/testReport/) for this commit**


HBIRE_vector_take2 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1681 of 1683 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


I guess that's guaranteed in this case, an int won't render
to more than 19 characters, right?

+++ Nick Wellnhofer [Jul 06 15 05:25 ]:
>   If you're sure that the buffer won't overflow, you can simply use
>   sprintf on all platforms.
>
>   —
>   Reply to this email directly or [1]view it on GitHub.
>
>References
>
>   1. https://github.com/jgm/cmark/commit/09e312abd6dca9e2e55050d3d4eacfd52fea8d73#commitcomment-12014957


não serve, tem que fazer direito antes de comitar, palhaço.


I've meant that it is too slow. They have 40 minutes limit for single build. Coverity would take few hours at least, it take very long to build and you need to upload that later.


Look at all that red! Love it.


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.0.1-beta.1+2](http://build.prxm.it:8811/viewLog.html?buildId=3359&buildTypeId=CqrsFramework_CiGitFlow) outcome was **SUCCESS**
Summary: Tests passed: 108 Build time: 00:01:53


Opening this in Android Studio, I see a warning complaining that logging tags can only be 23 characters long. What happens when you exceed that length?


In fact I went with the other solution thinking it would be cleaner after all. I used a static global function inside that namespace: https://github.com/Underground78/mpc-hc/commit/ce1baba3394af9d369c46e005b5fde09d0e2dfad#diff-e9ff33aa321f356b331477a9d11662e9R140.

I can go back with the other solution though.


핵심 기술을 정한다면 (2)를 중점으로 해보고 싶습니다.
그런데 개발에 대해서 어떤 센서 데이터를 가져오고 어떤 API 가져와야할지 방향을 못잡고있습니다.
여기에 대해서 도움 부탁드립니다.


This looks really nice!


@helloheesu
어. 맞아.
사실 난 duck typing 보다도 in 으로 판단하는 부분을 얘기하고 싶었어. ^^;


ack


Whoops https://twitter.com/michaelschultz/status/618085605050748928


HBIRE_vector_take2 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This should only apply when using the touch screen on the pump itself. You can use ´Util::isLocalSystem()´ to determine this.


Because in the test case that I added this evaluates to `NA`, breaking the `if` statement as in the error message that I included. If there's a better way of converting this to a "truthy" value, feel free to edit.


To be clear: if status returns 0 when "program is running but service is not ok" you have a system that is impossible to instrument


"Lucas Werkmeister" is a bot. But you already knew that.

On Mon, Jul 6, 2015 at 5:50 PM, Stéphane Épardaud <notifications@github.com>
wrote:

> What, good advice?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ceylon/ceylon-compiler/commit/30d05d5b1a7c404a1f17d5bb8c0ca315320420f0#commitcomment-12019588>
> .
>

--
Gavin King
gavin@ceylon-lang.org
http://profiles.google.com/gavin.king
http://ceylon-lang.org
http://hibernate.org
http://seamframework.org


get rid of these


and  these


Ah, I didn't consider that it could be overwritten later. You mean moving the test `if (!dynamic_pif_lim)` to top of `tcp_rdb_register`?

As long as `dynamic_pif_lim` can be modified at runtime, it would have to handled when initializing `struct rdb_cong` in `rdb_cong_init`. What what about just changing permission to read only for all?


and even these


Is supported always returned false, so it was not necessary -> eliminated that function


At first glance, it looks as if ```locationReceiver``` were a local variable. To avoid that effect and make it much easier to read (i.e. to avoid double takes as much as possible), include ```this``` when you're referring to instance variables.


Primer despliegue de la aplicación


do you really need this --color ? can't we assume it's always colorized and change the behavior if --no-color or sys.stdout.isatty() ? like we do with check-style.py ?


This always returned false -> eliminated that function, simplified logic


remove extra space


Could also eliminate this and have workspace go straight to specific tool flash_project


Comentario para @pacastillo : me marcaste los "Data Miner"(componente) como para sustituírlos por "DM". No lo he hecho pero para que no se confunda con DM de Data Mining (técnicas).


The comment was incorrect to begin with. As I was modifying the code, I realized it and updated the comment.


Als het in het hoofdstuk Evaluation onder de sect process staat, dan is het zo goed


This breaks the irace tuning, see https://github.com/berndbischl/mlr/issues/369


`if(!todoLabel)` 이렇게 할 수도 있어요.
* 변수의 값이 **0이거나 빈 문자열("")이거나 null이거나 false**이면 if 문에서 _false와 비슷하게(적절한 표현을 모르겠습니다...)_ 취급할 수 있는데, `!` 연산자로 그걸 뒤집어서 그 때에 true가 되도록 만드는거죠.
* 가끔 값이 실제로 숫자 0이어서 false 로 취급되면 안 되는 경우도 있는데, 이 코드에서는 그럴리는 없으니까 써도 괜찮을 것 같아요. (사용자가 0을 입력하면 숫자 0이 아니라 문자열 "0" 이 넘어올테니까.)
* 저는 이게 더 깔끔해보이는데다 예전에 [airbnb convention](https://github.com/airbnb/javascript#comparison-operators--equality)에서도 이렇게 한다길래 안심하고(?) 쭉 써왔어요. 그런데 의미가 덜 명확해보인다고 싫어하시는 분도 있긴 하더라구요.


Great job here. You condense all the functionality into separate, short functions. Very easy to read (which is very helpful). Definitely give the first bonus a shot -- I think you can handle it!


Moving this logic to line 14 would be a more efficient approach.

```
if (!isPresent(method) && isPresent(providedOpts)) {
  method = providedOpts.method;
}
```

Then when creating the `new RequestOptions`, replace `providedOpts.method` with `method`.


Yet another passthrough to tool.py, could go straight to the flasher's flash_project function


TeamCity Jarvis Framework :: CI [Build 98](http://build.prxm.it:8811/viewLog.html?buildId=3360&buildTypeId=CqrsFramework_Ci) is now running


Instead one can set Input grabbing to 'dynamically' in RoRConfig->Debug


Sad Panda :( Was just going to add a PR for this, to solidify your point :)


That's correct. The IDE actually was the one that removed this import statement automatically.


Ah, terribly sorry, I will add it to Travis and fix it.
6 лип. 2015 18:59 "Michael Snoyman" <notifications@github.com> пише:

> Disable hprotoc, lacks GHC 7.10 compat. Pinging @k-bx
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/fpco/stackage/commit/05429ecb95d93574ae6975dd89a432316ffeeb91
>


Retested with out lines 36 and 37 and setting the fieldValues to the principalId.  It seems that these lines are not needed.  Removing the lines.


Never used


Please name your methods as action verbs, not as nouns (e.g. ```buildUrlDirections```)


TeamCity Jarvis Framework :: CI [Build 98](http://build.prxm.it:8811/viewLog.html?buildId=3360&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 119 Build time: 00:01:07


@akbargumbira I don't know where and if it's actually still used, I found it in pip freeze and it might be a dependency from other 3rd party apps/momdules, I can only assure that it's not used in the plugins app. I'm not the author of the user map app so I can't tell. Maybe @timlinux knows more. Maybe feedjack uses it...


This might actuallly be wrong - ignore - will change back


The person’s name is “Lukas Werkmeister“, and @FroMage knows that too ;)


The application should actually **not** do this! It should throw a `MissingCredientialsError` in this test, as it does if you were to actually try to initialize a `client` this way from your own code (not a test). However, this test actually passes, so that means there is something wrong with the tests. When running either this test, or this test file individually the test fails the way I expect it would, but when I run all the tests with `mocha` or `gulp` they all pass. That means some other test file is probably altering (via a mock or otherwise) some standard behavior and not cleaning it up properly.

Running just this file by itself also has three failing tests:
```
  1) client tests #constructor should create client instance:
     Missing credentials.
Use new Client(<userId>, <apiToken>, <apiSecret>) or Client.globalOptions to set up them.

  2) client tests #constructor should create client instance when userId is null:
     Missing credentials.
Use new Client(<userId>, <apiToken>, <apiSecret>) or Client.globalOptions to set up them.

  3) client tests #concatUserPath should return formatted url:
     Missing credentials.
Use new Client(<userId>, <apiToken>, <apiSecret>) or Client.globalOptions to set up them.
```

So, two things need to happen here:

 - We need to track down where the application state is being  modified and not reset by another test
 - The three failing tests need to be fixed or altered to accurately test the expected behavior of the application


new class variable to be accessed by tools in stead of passing this around/going through same logic in three different functions (build,flash,export)


The old file outputs a verbose output to System.out indicating the size of the file to be downloaded and the progress each time it receives a package. Now it is removed.


Add it as a failsafe?  Makes sense.  I can add it to this one since it does cover the code area.


I think this bakes too much knowledge into what should be a simple function. I.e. what if a user has overridden the `BaseRequestOptions` with the method defaulting to "POST" for some reason? If it were appropriate to safeguard against null methods here, it would be better to assign method to `defaultOptions.method`. But, I think my previous comment would be more effective at preventing the null method case, so this logic shouldn't be necessary.


yeah thats right but this has to go in one of the requirements regarding to eclipse plugin...so thats why referenced with this requirement


Yikes!


This is pretty ugly. Have you tried setting `baseURL`?


Weird function that did nothing but return passed in paramter


I think the lines are supposed to read as follows... im such a doosh
# CONFIG_KEXEC is not set
# CONFIG_KEXEC_HARDBOOT is not set
# CONFIG_PROC_DEVICETREE is not set

so I changed them to those values now..


No use for just return False


The simplification was that lines 422-429 were removed. The code used to do special logic depending on the appointment type. By removing these lines, the code behaves the same way for all appointment types. The other alternative would have been to add another setting for the Ranked Faculty appointment.


Isn't this line the root cause of the problem?


Logic happens in workspace now


Added some comments. Would you mind opening a PR?


At first I was like, "I reckon you could use mixins to make this more concise." Five minutes in, NOPE


Also, please avoid abbreviations if possible (use them only when the resulting name would become too long without adding much descriptive value)


The ranked flag was added to Job.hbm.xml and Job.java. This method comment is a bit verbose to help document where the data is coming from.


Haven't seen too many guidelines on this. Could just remove the INET part.


Hmmm... :+1:


can you add return self here?


The description to what it does is not well explained. What didnt work was the directional keys on the left, not the analog/joystick. With the analog led on or off. At least on mine gamepad. This way it works both the left directional and left analog. Did you test this config ?
But feel free to revert the changes back.


@diego-d5000 I left you some comments/suggestions. Let me know when you push back changes so I can take a look again.


The space was there since I originally had it broken up into multiple lines. I can easily remove it.


I think this has broken `md-stretch-tabs`, it is not a boolean attribute, it is a string.


It's an issue Evan and I have been struggling with. I WILL use
baseUrl...this is some cleanup I will make an issue of.

On Mon, Jul 6, 2015 at 12:21 PM, Andrew Hankinson <notifications@github.com>
wrote:

> This is pretty ugly. Have you tried setting baseURL?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ELVIS-Project/vis-client/commit/18066316c1bf03e5c40ac980cf39f0c3d8b6f011#commitcomment-12020239>
> .
>


I believe it will confuse many developers who do open the dev tools. When I see something interesting (which is common for pixi implementations), the first thing I do is open dev tools. I'm sure I'm not in the minority here. For a library that logs to the console by default to 'sayHello' I think assumes this as well. With this change, every hello will be accompanied by a 404.


오옹 정리하는 김에 [`<script>` 태그의 defer 속성](http://appletree.or.kr/blog/web-development/javascript/script-%ED%83%9C%EA%B7%B8%EC%9D%98-async%EC%99%80-defer-%EC%86%8D%EC%84%B1/comment-page-1/)도 같이 생각해보면 좋겠네요..!


Nice~


I think it would be better to have a
bool CallHomeSettings.TryParseStringToDateTime(string s, out DateTime d)
method created to get rid of the catch block here


Renaming package name (uppercase to lowsercase) is not easy in MacOSX. I am sorry for the below 4 dirty commits. Otherwise, MacOSX does not recognize Resave with resave folders at the same time. Even rebasing them had a lot of problems. I should be careful in the future for naming package names.


Hmm...I thought I had fixed that some time ago, but maybe it was some other place.


Thanks for your question! <!DOCTYPE html> is a reference of HTML5 (Last version of Hyper Text Markup Language) This helps the browser to recognize some properties that in
previous versions it wasn’t possible. This link will interest to You: http://anavallasuiza.com/share/presentations/html5/#what-is-html5


Using CSS classes to re-use style’s, awesome.


It will also encourage developers to include the min sourcemap. Which is 1.5 MB, and should not be taken lightly.


Out of curiosity, what systems modify errno in free()? The current linux implementation does nothing with errno and the C standard itself doesn't mention anything about errno within free.  POSIX doesn't necessarily forbid errno being modified in free, but it does forbid it resetting errno back to zero.


When I run your tic-tac-toe game, in the console I get the error `Uncaught ReferenceError: Invalid left-hand side in assignment` @ line 38 of `script.js`.

If you're going to change a DOM object's CSS properties using Javascript, you need to use the format `object.style.property`. So in this case, `clickAction.style.backgroundColor` or `clickAction.style.background`.

You also need to set the new background color using a strong, like `"red"`.


This function was added for valinor, I can't recall their functionality. I believe the pgen knows the output build path (where executable is stored).


related to #185


Awesome. Lest check it out in class today.


Yeah, this is a rather crude hack, though. Maybe we can just stub-implement the missing virtual methods instead.


저는 가끔 document ready / window load 차이가 기억안나면 빠르게 (속도차를) 보려고 [코드펜](http://codepen.io/helloheesu/pen/dodNro) 만들어뒀던 게 있어요 ㅋㅋ. 맨 위에 == document window 하고 뜨는 데, 결과로 바로 보이니까 더 직관적이어서 좋더라구요.


Yeah, I have had a lot of trouble with that too in the past! Gotta be very careful!


Went ahead and pushed this w/o review:
1. It's used for one call only and I verified it's not changed in a way that affects us.
2. Security vulnerability in current version.


If we add workspaces, all this functions should be like build(builder, project_workspace), flash might be just a single project. But builder, and exporter - workspace


LGTM!


Good call.


Ah yeah probably forgot to do this when we switch to components/* views/*


Yes, Sir!


If you put in a PR for changing this value to be based on a cli param I'd merge it.


You don’t have to forget about the use of indentations because it makes your code more understandable.


Done as requested.


Yes this is true, I considered that using that tool api as "test what we have", but for those should be tests ;) And tool.py will be used by other external tools if needed, or we might find a way to eliminate it :-)


good catch! When I was working with this code, I thought it was plain sql, and that's why I used 1 as the value to compare. Since this query is actually hsql, I will use true instead.


Fancy


Can we make the UserID param optional, e.g. `const String& userId = ""`? Or alternatively, can we have two methods, one with a UserID param and one without?


Previously, a jar file containing only native libraries (for instance /net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5-natives-windows.jar) will be downloaded along with another nonexistent jar file, in this case, /net/java/jinput/jinput-platform/2.0.5/jinput-platform-2.0.5.jar, though this file shouldn't be downloaded.


Not at all go for it!


Good catch. r+


eslint was complaining about using the array without any definition of what was in it.


@axelstudios @macumber Yikes!  Sorry guys I meant to push this up on my new branch, but since there is no code changes this is pretty harmless.  Rather than rolling back the repository forcefully, I'm just going to leave it be unless there are objections.


Can it default to false? :wink:


Hi Saeed, how can I help?

On 7/2/15 7:44 PM, saeed wrote:
> can u contact me please
>
> need some help on this.. ready to pay
>


Closes #7


Sí, bien pensado.


For future reference it's generally better to bump the version when we publish. This will be fine for now, so no need to change it just advocating to be cautious about this. If time permits me tonight then I'll get this published.


Thanks for your question! <!DOCTYPE html> is a reference of HTML5 (Last version of Hyper Text Markup Language) This helps the browser to recognize some properties that in
previous versions it wasn’t possible. This link will interest to You: http://anavallasuiza.com/share/presentations/html5/#what-is-html5


It looks like `box[i]` is supposed to represent a box that is clicked in the game. But it doesn't look like you define it in your `script.js` file. I think you need to do something along the lines of `var boxes = document.getElementsByClassName( "box" )`, and then access the appropriate values within that returned object.


这一行是什么情况？


Lets keep in mind that the scope for the Linux service management is Linux
processes. If a process runs but does not perform its primary business
objective, then the Linux service management can't help with that.

On 6 July 2015 at 18:13, Maximilien Riehl <notifications@github.com> wrote:

> To be clear: if status returns 0 when "program is running but service is
> not ok" you have a system that is impossible to instrument
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yadt/yadt-minion/commit/e64232abdb2dd55da3174951d9c00acd2dd995e2#commitcomment-12020069>
> .
>


总体是完成作业了，但是不够认真


This patch also renames `startup` -> `services`. Is that intended? If not then it should have its own commit and a descriptive message. If it is intended in this commit then it should be mentioned in the commit message.


I think you should not call load_job_data here but instead redirect immediately.


Because `box[i]` isn't defined, everything involving `clickAction` doesn't either.


很不错！  视频的素材是不是可以放到一个大家可以下载的地方？


s/and spoof a message.../

On Mon, Jul 6, 2015 at 8:50 AM, bifurcation <notifications@github.com>
wrote:

> I didn't mean to imply that it was worse than a link. How about:
>
> If the server requires a user to respond to a message sent to a contact
> address containing a secret value,
> then the contact channel will need to ensure that an attacker cannot
> observe the secret value and spoof
> a message from the contact address.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/letsencrypt/acme-spec/commit/dbe22743eca2e8bd382cdbbfeeb4baa28e749bc1#commitcomment-12019598>
> .
>


Once you figure out how to set up the event listeners, I think this `whoWins( )` would ultimately end up working.

Although in general, I would refrain from tackling the bonuses until you take care of the minimum requirements first. Remember, less code that works is better than a lot of code that doesn't!


HBIRE_vector_take2 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (651 of 651 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.47%25-green.svg)


cherypicked to stable. Not sure how to do that in github but I can do it from the command line, locally...


How does $bytes indicate that the secret needs to be encoded?


I don't think this 301 will work as there's no indication of where to go from here. You can use https://docs.djangoproject.com/en/1.8/topics/http/shortcuts/#redirect and just pass the destination url.


hi @kristiana-rendon I see that you have committed your ruby file into the root directory of the repository. We would like it to go into the 'ruby' fold of the repo.

Could you please pull the file into the appropriate older locally, add it, commit it, and then push it and it will join your other changes in this pull request.


I know the game doesn't work but this was a great try. I think once you figure out how to get the click listener working properly then everything else will fall in place. Happy to talk about this more during our one-on-one meeting.


Splitting the string like that is a bit confusing at first glance - I know it works but it's a pattern we try to avoid in sos. I'd rather something along the lines of:

```python
    clocksource_path = "/sys/devices/system/clocksource/clocksource0/"
[...]
        "/proc/misc",
        "/var/log/dmesg",
        clocksource_path + "available_clocksource",
        clocksource_path + "current_clocksource"
    ])
```

Strictly we should us `os.path.join` here but that hurts readability even more.


added description for stages.


Looks good to me. Thanks.


Done.


link: https://dribbble.com/shots/2132065-Restaurant-Website/attachments/388880


The change from a function bam_index_build to a macro breaks the ABI as is easily demonstrable (samtools calls bam_index_build).


Sure.


Observers have been removed from Rails 3.

Can you think of a different way of writing this code?


What is `ActiveType`?

Can you think a Rails-specific way of writing this code?


Maybe note that you visit http://localhost:4001 to see the styleguide.


Can you find or explain a way to cache this or any other view or partial?


I changed the behavior in case CGAL_TEST_SUITE is defined. I also checked the warning issued were expected.


Na gerne. Meinste da kommt noch ne Version nach Mittwoch ;)


Order is not sequential, so it's not true that `layer.order == layers.length` for the layer on top. To determine the order of layers, we use different weights, so you can find something like:

```
basemap (tiled) -> order 0
layer1 (cartodb) -> order 1
layer2 (cartodb) -> order 2
torque layer (torque) -> order 101
labels layer (tiled) -> order 1001
```


Still a lot of overhead...

As you probably know (guessing from the patterns found all over the place) property lookup is very costly compared to upvalue (=== closure scope variable) access. From what I once benchmarked it's about a factor of 20.

We could make it

```javascript
var _renderInfoEnabled = false;
// ...
this.requestRenderInfo = function(enable) {

    // [...] reset info structure
    _renderInfoEnabled = enable;

}
```
in the contructor and then wrap every update in
```javascript
if (_renderInfoEnabled) {

    // [...] update info structure

}
```
. Same for memory info - or one global switch for both.

What do you think?

I'd love to extend the info facility to finally get GLSL errors back from the renderer, but this will be the reward for tidying up ;-).


You also renamed the file but not the class...:

```diff
--- a/sos/plugins/startup.py
+++ /dev/null
@@ -1,56 +0,0 @@
-class Startup(Plugin):
-    """System startup
-    """
-
```

Vs.:

```diff
--- /dev/null
+++ b/sos/plugins/services.py
@@ -0,0 +1,59 @@
+class Startup(Plugin):
+    """System startup
+    """
```

For now at least classnames and module file names need to match (ignoring .py/_ etc.).


What is a good practice to make sure that this link does not stop working if the URL to log in suddenly changes to something else (e.g., '/new-auth/google_oauth2')?


HBIRE_vector_take2 (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1681 of 1683 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


with the current code, cosystem or deploy jobs will get the signal. That's just jobs which are neither cosystem nor deploy, and with 0 hosts, that will not get the signal.

Look correct to me...


The new code should be tab- rather than space- indented. Also this would look neater with a space before `Some`, i.e. `| Some x -> Printf.sprintf "remotely at %s" x);`


Why do we even need to check this? Can't we just trust that the FE is going to send us the right layers?


It is our convention for documenting binary data.


Can you explain what is the purpose of `attr_accessor` here?


I think it would be more effective to do this with a macro from `Base.Cartesian`, rather than building the `Expr` manually. For example, `define_indices` will be the same function if defined as

```
function define_indices{IT, N}(::Type{IT}, ::Type{Val{N}}, pad)
    @nexprs N dim->:($(define_indices_d(iextract(IT, :dim), :dim, padextract(pad, :dim))))
end
```

except for the fact that this errors out since there is no method `_nexprs(::Symbol, ::Expr)`, and adding a constraint `N<:Int` doesn't fix that. Is this the reason you built it this way instead? I do think the macro version is easier to understand, but maybe it's just that my gut reaction when I see a manually built `Expr` is "whoa, we're doing something really odd here..."


This method is a little long to be a simple action. Can you make it shorter (while maintaining its functionality)?


@sebmck You do what you have to do. Babel didn't have any clean way to do this when I wrote this stuff. Now with Babel 5 there are "plugins" etc, but then the API seem to have changed (I tried building with babel 5 but it's API is quite different from version 4.) Maybe some rainy day in the future this project can use Babel with plugins.


![default](https://cloud.githubusercontent.com/assets/12625315/8527873/1ab605f2-244a-11e5-81ea-7a1cce562765.PNG)
![2](https://cloud.githubusercontent.com/assets/12625315/8527872/1ab4f194-244a-11e5-9b8d-db57347dceb6.PNG)

seems version change 0.4.5(2015-05-24) is mistyped as 0.3.3
or just foobar2000 components repository problem i guess.

anyway, thx for keep developing components.


Can you write code that avoids this?


Yes, it should.


Thank you, it's a pain to figure out how to get that precisely right. Will fix today.


What is the purpose of saving the user?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17559/testReport/) for this commit**


Since you are storing an Array here, can you use a different data type?


The comment is a bit misleading to begin with - the plugin doesn't actually collect any log files at all, just command output: we might as well fix that while we're here.

I'd suggest either deleting it entirely (few plugins have a comment like this - we tend to use the class metadata for that since it is reported to the user) or something like:

```
# Collect information from IPR adapters and devices
```


오옹 윤지수교수님이 '예쁜괄호'라고 부르시던 걸 mustache 라고들 하는군요.
교수님은 왜 mustache.js 가 아니라 handlebars.js 를 추천하신 거지..?


Are we saving the PlainTextPWD of Facebook/Google-Users here? or in "setPlainPassword"? Thought it's handled with Tokens.


:heart:


Good to know!  Thanks!


Since Heroku is not primarily intended to serve static assets, what code would you write here if your assets were hosted somewhere else (e.g. Amazon S3)?


Also, by the way, you should change it back to `lenses.scrbl` because documentation files are "global" in the package system, and two packages with the file `main.scrbl` would be in conflict.


Please delete these comment lines, they contain sensible data


I think adding an empty checkbox in a list element makes it very hard for any other programmer to contribute to your code, since there is no way here to understand what this checkbox is supposed to do.

Can you rewrite the code to avoid this kind of confusion?


The patch looks good - just a couple of style points:

* Only use a format tuple if strictly necessary
* If a line is too long for the format tuple place the `%` as the first char of the continuation line (indented as you've indented the `device` variable above).
* If a patch subject is `collect more information` the commit message /must/ describe that information. Otherwise I would suggest going with `add performance, battery, and device information`.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17560/testReport/) for this commit**


[toggleClass](http://api.jquery.com/toggleclass/) 라는 것도 있습니당


This would be neater as

```
match remote address with
| Some x -> begin
  ... do remote stuff ...
end
| None -> begin
  ... do local stuff ...
end
```

That way the `local` and `address` values wouldn't be needed at all.


Thanks for taking the time to review my code, Claudio! active_type (https://github.com/makandra/active_type) is a gem that makes a Ruby object like an ActiveRecord one.


In general, it's a good practice to use the same DB locally and in production.


Can you explain this line change?


Again, reference or missed?


This is kind of nitpicky, but can we keep these alphabetized?


Is this file intended to be here?


Every other use av do_div (I've found) has a u64 as a dividend. Also the comment above the [do_div macro (used on )](https://github.com/bendikro/net-next/blob/miller-net-next/include/asm-generic/div64.h#L43) in div64.h states that `n` must be 64bit. This macro has a pointer comparison to warn when using u32 , but the version of the macro used on 64bit doesn't have this, resulting in no warning on compiling on 64bit. Maybe a bug?


This is for Issue #40


Same question for all the following files…


Good point.


In the long term, we could test that a given data set *does* trigger a warning, by using a special error handler, just before the test of the case that should warn, and setting the handler back to its initial value just after.


Can we store the clientid in our parameters.yaml? For better config/code split


There are 4 conflicts now. It does not make sense have the same numbers/ID for both dir buttons and analog:

```
input_up_btn = "-1"
input_down_btn = "+1"
input_left_btn = "-0"
input_right_btn = "+0"
[...]
input_l_x_plus_axis = "+0"
input_l_x_minus_axis = "-0"
input_l_y_plus_axis = "+1"
input_l_y_minus_axis = "-1"
```

Try PPSSPP core and you'll see the mess.

You need to turn ON that LED first, pressing the Analog button, then you can use normally the joypad or reconfigure.

And you need to see if it's the same joystick, run lsusb and see if it's the same input_product_id (I think you'll need to convert from hexa to decimal)

Only original PS3 has analog but in the D-pad, not these generic joypads.


This partially answers my previous question. Is there any way to get rid of the `url` part too?


Can we store this config in our parameters.yml?


TeamCity NEventStore :: Core :: Build [Build 5.3.0](http://build.prxm.it:8811/viewLog.html?buildId=3335&buildTypeId=NEventStore_CI&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 279 Build time: 00:01:40


I'll send private :)


Ok… files deleted… ignore my previous comment on this…


Warum?! :-1:


Can you change the code so that someone else reading your code can immediately understand that this line means:

> Only destroy a video if no other user has picked it for his/her playlist.


HBIRE_vector_take2 (jasondegraw) - i386-Windows-7-VisualStudio-12: OK (1681 of 1683 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg)


Can you achieve the same without using external gems?


I thought only the names were global, and if you didn't provide a name it would be derived from the filename. Is that not the case?


TeamCity NEventStore :: SQL :: Build [Build 6.1.0-unstable.1+1](http://build.prxm.it:8811/viewLog.html?buildId=3336&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:46


I think we should maybe not use existing, real Facebook-account for testing (User/Password in OPenSource-Code!)


I deleted this later. At the time I was using a "playlist" Array attribute.


Hi @Wingslikeagles4031
I see that you have committed your ruby file to the root directory of the repository. We would like it to be in the 'ruby' folder of the repo
Could you please pull this over to the 'ruby' folder, then add, commit and push the changes. They will join the others in your pull request


This is boring


I think we should not use active, real Google accounts for testing. (Username/Passord public!).


Should be ```let scrollableCustomActions```


replace use_manual_internal_ref by "auto_default_code"


So, is this working now? Right now my script checks whether we're in a PR and doesn't report coverage for PRs. Can I take out that check now?


Should include Fix #30 in the commit message ....


Agreed, it's not the service management's job to do monitoring.
I added "with yadt" to my previous comment to clarify what I meant.
But yadt (as of now, anyway) does manage systems through the linux service management lens. And since with reboots we face service mutations external to yadt the band-aid I mentioned is totally required, it's not enough to have a blocking start function.


http://docs.racket-lang.org/raco/setup-info.html
> scribblings : (listof (cons/c string? list?)) — A list of documents to build. Each document in the list is itself represented as a list, where each document’s list starts with a string that is a collection-relative path to the document’s source file. A document name (which is derived from the source module’s name by default) is intended to be globally unique in the same way as a package or module name.


I deleted the "playlist" attribute later. What data type would I use for an array in the database, besides a string? I'd  serialized it in the model.


# 'mustache 계열'. 그 중에 왜 하필 handlebars.js?
https://github.com/milooy/2015-02-HTML5/commit/3b8c2ec835baba51a569f13a281b5716c7320733 ,
http://stackoverflow.com/questions/10555820/what-are-the-differences-between-mustache-js-and-handlebars-js , ...


Oh, okay, sure :)


Ok you're right. I haven't used the document name separately yet, so I had thought they were the same thing.


Move this field on the product.template


typo ``seted`` -> ``set``


looking forward to your PR


add the boolean here for computing the default code


TeamCity NEventStore :: SQL :: Build [Build 6.0.0](http://build.prxm.it:8811/viewLog.html?buildId=3338&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:35


I later changed these lines to `background-image: url(asset-path('off.png'));`


Probably none, but POSIX at least says you can't depend on that.  [In the next revision POSIX will fix this](http://austingroupbugs.net/view.php?id=385) but at present pedantically better safe than sorry…


972124-2NewDetailedIceStorage (RKStrand) - x86_64-MacOS-10.9-clang: OK (1667 of 1670 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


Could you research to see if any database would allow you store an Array in a more _native_ way?


LGTM


I'd rewrite this method as below, for both delete and create, although I still don't see the purpose of having both a personId and a Person object in the maintenance docs:
public KcPerson getPerson() {
		if( personId != null) {
                        // Same person, avoid retrieving it
			if (person != null && personId.equals(person.getPersonId())) {
				return person;
			}
 			person = getKcPersonService().getKcPersonByPersonId(personId);
 		}
         return person;
}


On Mon, Jul 06, 2015 at 10:03:20AM -0700, John Marshall wrote:
> Probably none, but POSIX at least says you can't depend on that.  [In the next revision POSIX will fix this](http://austingroupbugs.net/view.php?id=385) but at present pedantically better safe than sorry...

Fair enough.  It's basically harmless anyway as it's a nop on our
systems, but it got me wondering!

I checked the rest and temporary "ahah!... oh nm" aside it all looks
fine to me. Merging.
--
James Bonfield (jkb@sanger.ac.uk) | Hora aderat briligi. Nunc et Slythia Tova
                                  | Plurima gyrabant gymbolitare vabo;
  A Staden Package developer:     | Et Borogovorum mimzebant undique formae,
https://sf.net/projects/staden/   | Momiferique omnes exgrabure Rathi.

--
 The Wellcome Trust Sanger Institute is operated by Genome Research
 Limited, a charity registered in England with number 1021457 and a
 company registered in England with number 2742969, whose registered
 office is 215 Euston Road, London, NW1 2BE.


If there is an error, it should be passed along and the client should be informed


This Gemfile is starting to get big.

Could you review it and delete any gem that is not strictly necessary?


Should be
```javascript
let Dialog = require('../dialog');
```


Ya Ive done that. It fails always even with those deleted properly... see my newest commits. If anything, I can always commit where im at now so you can look too


TeamCity NEventStore :: SQL :: Build [Build 6.0.0](http://build.prxm.it:8811/viewLog.html?buildId=3340&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:43


Rails 4.2 has deprecated "serve_static_assets." I got this deploy warning in Heroku to change it: https://github.com/heroku/rails_serve_static_assets/issues/11


> @hferentschik might remember some more details

Not at all. First time I hear about `EliasFanoDocIdSet`. If I ever dealt with this before it is completely wiped from my memory.


Type attributes are innecessary, html implies the. Refer the Udacity Nanodegree Style guide in the link below:
http://udacity.github.io/frontend-nanodegree-styleguide/


That makes sense, I will do that,


Lines 2 - 9 should use let instead of var.


:+1:

On Mon, Jul 6, 2015 at 10:07 AM, Raymond Gan <notifications@github.com>
wrote:

> Rails 4.2 has deprecated "serve_static_assets." I got this deploy warning
> in Heroku to change it: heroku/rails_serve_static_assets#11
> <https://github.com/heroku/rails_serve_static_assets/issues/11>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rayning0/rayplay/commit/06780a255123d5fec2627ed20af662830f353b7e#commitcomment-12021138>
> .
>

--

 Claudio Baccigalupo  | Software Writer  |  Fullscreen, Inc.
<http://Fullscreen.net>  |  +1.310.202.3333


Done.


No. I later deleted all of them. I was having troubling showing the images in Heroku and was trying different ways to get my precompiled assets to be called correctly.


Yes it should be possible, however I'm not quite sure what the syntax would be, as I just copied the one for Forge by looking at a few other mods. I'm sure they have documentation on the annotation somewhere if you look for it.


Functions should follow the pattern
```javascript
functionName(optionalProps) {
  ...
}
```


I didn't use a `Maybe` as that doesn't model the reality; in fact, there is always a `search_type`, defaulting to `query_then_fetch`.


Normally it shouldn't fail, so you should be more descriptive and say why it should fail here.


LGTM on this commit.


Why do you need the `# noqa` here?


changed to port if test


Done


Is this testing that a list is returned? Or are you testing an empty list in this case?


Can you also indent this line like the one above?


Yeah, this is actually from earlier where there was another mode. Now it's not needed.


I decided later to not destroy any videos in the DB. Originally I was trying to only allow videos in the DB that users had actively picked for their playlist, and I deleted them completely for all users, if not a single user had picked them. But that increased a video's ID# too much and kept changing it. So I said "Forget it, I'll leave all videos in the database, every after someone deletes it from his playlist."


TeamCity NEventStore :: SQL :: Build [Build 6.1.0-unstable.1+1](http://build.prxm.it:8811/viewLog.html?buildId=3341&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:01:53


I assume your changed `asTuple()` accounts for this change, but the documentation of `TypeList.defaulted` still says that

> A possibly-empty variadic type element is also considered defaulted

which is now, afaict, wrong.


Did this dt didn't work ?


Revisiting the code for 973, I'm not sure why we need to keep a personId and a KcPerson object when the second one already holds reference to the personId? It makes the getter and lookup unecessarily complicated...
Same for delete....


This field shoudld be not here but in a custom module


Is this needed?


@samnazarko I suggest not log transmission to journal but to a file only for that. Otherwise transmission will polute system logs. Just my 2c.


It was saying __path__ does not exist. I guess this is a global variable, so I silenced the warning. Is it good to you?


1712-AvailabilityManagers (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


ahm, this might look a bit stupid, but how can i install "fileutils" with homebrew?
"brew install fileutils" will not find anything.. and with the github repo (https://github.com/ruby/ruby/blob/trunk/lib/fileutils.rb) i have some troubles..


weird, but LGTM


> But that increased a video's ID# too much and kept changing it.

Why is that a concern?


Mir ist das im Prinzip egal, ich dachte nur, dass es so besser aussieht. Aber wenn wir das nicht mehr ändern, dann können wir auch den neuesten Namen verwenden.


Sure!


Done


This setter is really confusing: setting the personId to a principalName? The two of them are vaild things and it seems we're mixing them up...


datagramReadBufferSize?


Done.


Yes, fixed thanks.


this is fucking everything up, why the change?


Okay, good.


Did you add this to the Cartfile somewhere?


@bmr-cymru, I agree, I'll update and also fix the rt-kernel.py where I pulled that code from.


We're string frozen as of last week, so this patch may have to wait until v1.1 of Firefox iOS.


unneeded brackets around ok


You should check for 443 as well.


O que são essas linhas comentadas? Por que elas entraram no commit?


Your name or your team name may be here.


Good call, if move it to the external it might work, setTimeout it's a bad approach because might be executed after the rest of the code since it is queued in the event loop of javascript.


Oops.  Meant "Updating Readme.md"


Good call. :)


TeamCity NEventStore :: SQL :: Build [Build 13](http://build.prxm.it:8811/viewLog.html?buildId=3342&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:36


Agreed. Having a bit of trouble with how sails implements grunt. It seems to run the tasks asynchronously, which doesn't make a lot of sense for that use case. Maybe making a grunt task and adding it to the Gruntfile directly will fix it


It doesn't matter what the video ID# is. For me personally, while developing, I want to have the video ID always be the same for the same video for now. It's easier for me to check during my testing.


apologies - novice question here
@alexanderm10 I'm not sure how to deal with these two commits

Did you commit these to the repository or have you started a new branch?  Or maybe did you commit but not push?

I see the commit but the dot.R files have not updated on github and when I pull I get a "already up to date" message.


I think you might want to add a UDP and/or Unix datagram test, since they are now no longer handled by the TCP test code.


I tried this config for a long time in nearly every libretro emulator and it works fine for me. Like I said, pressing the Analog button does not work for me. The device ID is correct (according to lsusb) otherwise the config would not be picked up in the first place, I guess. Assuming that what you said is correct, the only thing i can think of is that the Analog button in my gamepad is screwed. Maybe thats it.
Feel free to revert the changes back, I will just use this config manually.


It's going to shit :P
SIGSEGV :(


With angular $window is recommended.


In this case, all text is red as especified, but instructions say that you should apply this style to all body tag like this
``` body{ color: red; } ```


LGTM


Nope. {{datagramReadBufferSize}} is the size of the read buffer as passed to the kernel in {{ListenUDP}}. This could contain several datagrams. This is the maximum size of one datagram, which is obviously 64k for UDP (but less obvious for unix domain datagram sockets). Two different settings.


Not that it matters much, but this is dupe, see line 4


Why is the console.log line here? If we get to this point, and the modules writes to the console, have we done something incorrectly, or should this line have been removed prior to the commit?


This is remarkable boost in native packages compiling performance. More meaningful for SM, but V8 also compiles faster.

index.js:
```js
console.log("ok");
```
Command:
```bash
$ jx package index.js -add -native
```

V8 gain:  1522 ms (old) vs 659 ms (new) -> 2.3x faster
SM gain:  21739 ms (old) vs 276 ms (new) -> **78.8x** faster

SM is now faster than V8 previously and even now!


@hazzik why did the release_notes requirement get deprecated?


Anything wrong with `rotate_map_coordinates`?


Re brackets, quite right (I'm new to go from C), but it's been merged now!


Essa coluna já não foi adicionada em uma migração anterior (https://github.com/gems-uff/sapos/blob/bugfixes/db/migrate/20150516180801_add_nationality_to_country.rb)? Não dará problema quando formos migrar o BD e a coluna já estiver lá?


@mikesaurio sólo las comillas "" para la traducción porfa !


Cool. Thanks for fixing this.


``static EventClient g_eventc`` <- this I really don't like. You're introducing global variables where we can go without them.


TeamCity NEventStore :: SQL :: Build [Build 14](http://build.prxm.it:8811/viewLog.html?buildId=3343&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:32


consider flushing your database...


Good use of tags to enclose the text content.


> weird, but LGTM

its on the post-rebase todo list to fix


그런데 교수님, 왜 `return MyObject.someProperty` 가 아니라 `return someProperty in MyObject` 를 쓰는 건가요?
혼자 생각해보기에는 프로퍼티 가 존재하긴 하나 값이 0인 경우(length 등) 때문인가 싶은데..


This is an old typo: should be `import com.twitter.finagle.Httpx`. We can either fix it here or in a separate commit, @ilya-murzinov.


Another old typo: "bellow" instead of "below".


#### Critical

In this case, all text is red as especified, but instructions say that you must apply this style to all body tag like this
```css
body{
    color: red;
}
````


Oops, sorry :)


Hello! I've got the error after this commit. The only string from debug.log:
```caught <type 'exceptions.TypeError'> in handle_user_input(): 'NoneType' object is not iterable```
Python 2.7.10


Cần sửa thành `file_A.cpp`


I think I meant to exclude `.psci_modules`.


Full Lesson 4


On 07/06/2015 07:23 PM, Alex Bligh wrote:
> Re brackets, quite right (I'm new to go from C), but it's been merged now!

Oh noos!

     Met vriendelijke groet,
         Pauline Middelink
--
GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA  BD3B 9A50 B416 E2D0 C3C2
For more details look at my website http://www.polyware.nl/~middelink


modification


@merces: before this commit, `peshash -a <any_algo>` printed checksums only for headers. It now prints for everything.


because magit 2.1.0


Is it with `flake8`? I got no error and `__path__` is a package special attribute, I think you can remove the `# noqa`.


@akbargumbira It may have been used in the user map perhaps (btw that would be another good candidate for replacement by you @akbargumbira - using the InaSAFE one you made would be a great step forward...). Anyway as far as I know PILLOW is a drop in replacement for PIL (which is now deprecated).


Please checkout version 0.1.3, the bug is fixed.


Ok cool, so the module documentation generation changes with `0.7`? I would say if the actual reference docs are no longer here, we should remove the first line and replace it with the repo name instead. Further I would put the module documentation link to the bottom of the README, so first you get a summery, then a short example and lastly the link to more docs. Finally, if we split this up, we should probably remove the duplicate example, i.e. craft the README by hand, and remove the inline code. What do you think?


Yes, so I was told. As usual I fail at testing...
Though if you look at the RFC I sent you'll see that I have a potential, work-in-progress proposal for that as well.


can this be part of the `PluginHandle.parse()` method as well or is it called at the wrong placed then?


nit: `except Exception:`

Context: https://docs.python.org/2/howto/doanddont.html#except


I am just about to push a massive invalidate tile refactor.


TeamCity NEventStore :: SQL :: Build [Build 15](http://build.prxm.it:8811/viewLog.html?buildId=3345&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:36


if you open LUCENE-2736 you'll remember, but maybe it's good it stays forgotten :)


Hmm what would you prefer? I think I would have to drop the namespace and use a singleton class instead in this case. It would be fine with me if you think it's better.


Hi there @mmmfang,
I see that you are committing your Ruby file into the main directory. We would like it to go into the 'ruby' folder of the repository.
Could you fix that up by dragging the ruby file into the 'ruby' folder locally, then add it, commit it, and push it. The changes will then join the others in this pull request.


I did that in the METADATA PR.


Ad already said: just wait a few days till i get the device and then il fix bugs


This must be called at most once, right? Will this kick off multiple threads otherwise?

Might be worth keeping track of whether this has been called and assert that it hasn't been called already, since that's almost never what we want.


Yes it is, with the sublime plugin. I have a F821. But I will remove it as requested!


Can you just do this?
```
(group.id, group.trans_implied_ids.ids)
```


Maybe: `You will need to include MDL's JavaScript alongside your customised CSS to get the full experience. This is included in our default Download from the Getting Started guide'?


## This is a markdown file


TeamCity NEventStore :: SQL :: Build [Build 16](http://build.prxm.it:8811/viewLog.html?buildId=3347&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:30


A SUPPRIMER POUR VOUS


And it might be worth some documentation and/or a more-clear name to be clear about what this function is actually doing now (not just updating from a filename once).


DB_SOCKET : A SUPPRIMER POUR VOUS !


972124-2NewDetailedIceStorage (RKStrand) - i386-Windows-7-VisualStudio-12: OK (1673 of 1676 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


I don't think there is a standard notation. What you suggested makes sense.


I'm fine moving things around however you prefer, this was just the result of running `pulp docs`.


TeamCity NEventStore :: SQL :: Build [Build 6.1.0-unstable.2+2](http://build.prxm.it:8811/viewLog.html?buildId=3348&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:01:52


This is something we should do.

LGTM


По идее он тебе уже не нужен. Тут нигде не используется.


Sorry. I don't understand. It's part of the parse method.
Do you mean the static list of plugins?


That makes sense.


а зачем эта штука нужна? с /path


Derped with oauth token. It's no longer viable, sorry! :d


Changing the return type from `public Integer getMaxAge()` to `public Long getMaxAge()` will mean some compilation breakage.


Agreed.


TeamCity NEventStore :: SQL :: Build [Build 6.0.0](http://build.prxm.it:8811/viewLog.html?buildId=3350&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **FAILURE**
Summary: Error running GitVersion Build time: 00:01:44


@agnogueira the class has been here for such a long time


Changing the type signature here will break compilation


shouldn't this be part of the fabfile.py so that we can shell into the remote machine and publish this ?


No that's good
But it will require some tests because the browser may convert it with http/https. So maybe a css selector will have to be updated


It is a bit too broad.  I think we can safely restrict to errors related to either missing or malformed config file.


`example/example.purs → test/Main.purs`

I would put my vote against this tbh, because the file does not contain tests. It's a runnable example, but apart from being compilable, it does not assert anything. I think we should reserve that space for mocha test suites or the like.


LGTM... should also update with output of `hack/update-swagger-spec.sh` to pick up changes in parameter descriptions


(fine to do as a follow-up)


As this is Android and not Java in general I am not sure your argument fully holds, at any time there was only ever one official IDE so far. Plus there already is project.properties for example which at least nowadays seems to be Eclipse-only and there's also the proguard stuff.
However as you can probably guess from the commit message I am not a particular fan of it either, but I am too new at this to figure out what might sense to include and what not, and made the questionable decision to trust the IDE...
I think the changes to build.gradle and  gradle/wrapper/gradle-wrapper.properties at least are reasonable. I am happy to slice and dice this patch so it contains only what you think suitable.
Mostly I care about having some kind of build system included (and preferably one that F-Droid can also use), and one that someone half-clueless about Android can get to work with reasonable effort.
The previous change on its own probably achieves that reasonably well though.


HBIRE_vector_take2 (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1168 of 1168 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Is this CSS file among the project dependencies? If not, we can remove that line as well.


is this member actually used anymore?


@noahdietz why double slash happened here? File a ticket for templates project if it's a bug


1712-AvailabilityManagers (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


PEP8 compliance is good. I'll ask it be followed in all RelEng python code reviews going forward.


g


Confirmed that the file is present in the Bower dependencies, so the question is: what is it being used for?


@noahdietz  Property names would be populated here based on request schema with your latest work, right?


.travis.yml fixed


I agree with your idea. Let's name the storage_type "customized" for cases where we want to customize. The other benefit of having something like this would be in those rare cases when a single machine would be connected to two different SANs.


Good call, yeah. At one point I showed it as a default but then realized this was a bad idea. Never changed the keys here to match so muy apreciado.


Nope, removed in commit 2, which adds the `toxics.Register()` thing.


this variable is unused


First let me say thank you for creating such a great tool, here is my site and it looks great thanks to you:
http://microsoft.github.io/maker.js/docs/api/

I only had to do a little modification to your example theme.

I am hosting my site on GitHub Pages, and the BOM puts an extra character at the beginning of the file.
The Jekyll engine is looking for a “---“ in the beginning of pages. So the BOM was interfering with that.

From: Sebastian Lenz [mailto:notifications@github.com]
Sent: Monday, July 6, 2015 12:54 AM
To: sebastian-lenz/typedoc
Cc: Dan Marshall
Subject: Re: [typedoc] Started adepting Rendrer (0ec4b4c)

I have to admit that I'm not sure why I've done this. But can the BOM create any problems?

—
Reply to this email directly or view it on GitHub<https://github.com/sebastian-lenz/typedoc/commit/0ec4b4ca3572913cc48846d881af75374820533b#commitcomment-12010452>.


Shouldn't `/{plan_id}` be something like `DATA GOES HERE` thing? It should be obvious that it's a missing piece.


#### Awesome :white_check_mark:
Using CSS classes to re-use style’s, awesome.


Good Lord! So glad this is happenning :+1:


Done


(I can help with testing)


Empty query string should not be rendered. Please file a ticket for templates tag if you agree.


An array might make more sense.


`JSON.parse` should've autogenerated


1712-AvailabilityManagers (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


All the code to this point is shared between `publish` and `unpublish` right? This could also be in a separate middleware function.


how so?


`apiError()` returns a json blob with the error in it. Since this endpoint normally returns `http.StatusNoContent`, the content type is set only if an error occured.
This could probably be cleaned up though.


It was removed in the following commits :metal:.


Alright, I just wanted a simple way to set up Travis CI to verify things ran correctly, but we can do that in other ways. Feel free to change this branch however you like and merge, I'm going to leave it alone now.


As pointed out by @alxndrsn, there is a stray `?` to start the file. Should be replaced with `<?xml version="1.0" encoding="UTF-8" standalone="yes"?>`


Rather than making you fork my code, I'd be happy to consider making es6-promise-pool itself not depend on es6-promise. It already supports any implementation compatible with Promises/A+.


A server is not accessible via SNI.

The point is that the client stands up a server that responds to connection attempts that use SNI, demonstrating a high degree of control over the server.


More concise. You wouldn't have to do `Array.prototype` because it would ACTUALLY be an array :P


just collecting bug reports for you.


I don't want to put this is middleware because it's not really middleware (not a precursor to publishing). And my next patch kinda leverages this too in the middle


Check indent


Why the extra blank line?


alright


Thank you, worked great for me!


Agree with you. I prefer as cleanest as possible but by the moment the seed has that library. My preference is to avoid using it but I'm not the whole stuff hehe!

@mravinale what do you think? Is really necessary to add this library in a seed project?


Isn't it /exactly/ a precursor to publishing?


this is a range of size 0 and base port 0, which results in a random allocator, which was the previous default behavior? if so, LGTM


I know this is nit-picky, but we really should refactor all of these if/else if/else blocks into switch statements. The Go style guide is pretty specific about that. Wouldn't worry about fixing it here, though.


Commenting the commit.


So, you stay on v2 ? Not v0 ?


Hahaha yeah :metal: thanks to you for noticing!


@dudekm Niepotrzebne nawiasy wokół `$request->getGet('id')`


follow up: https://github.com/plone/plone.app.layout/issues/46


Not really, rather, it is a part of the publishing process! But since publish.wm.org is not handling this (I think it should), we need to do it out here


It was deprecated because it was using deprecated APIs. If it is updated to not use deprecated APIs, Atom will load it.


@alfiehanssen Why isn't this in a PR?


TeamCity NEventStore :: SQL :: Build [Build 6.0.1-beta.1+2](http://build.prxm.it:8811/viewLog.html?buildId=3351&buildTypeId=NEventStore_Sql_Build&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:01:53


Hello, I am new to GitHub, not sure if I am doing this right.  I want to say thank you for starting MLB-scraper.  I have been working on it to scrape data for baseball.  The one issue that I have is that it dropped connection due to games postponed.

For example, on 6/27, the 4th game listed there did not occur.  It was postponed.  So, the dropped connections stops there.  However, as you may know, there are still games that needs to be scraped after the 4th game.

Me and my partner are working on solutions to get around the dropped connections.  Will advise if we figure it out.

Thanks.


is that the network fix?


we are doing a couple crud operations for roles and permissions and ng-table is helping us


@dudekm Jak klasa jest w tej samej przestrzeni to nie musisz walić pełnej ścieżki.

* jesteś w `\Dudekm\Blog\Controller\UserController`
* czyli przestrzeń dla aktualnego pliku to `\Dudekm\Blog\Controller`
* czyli wystarczy samo `Request` zamiast pełnego `\Dudekm\Blog\Controller\Request`


The code without this + lines should not generate warnings, AFAICT. Drop this patch, I'd say.