would this be too much?

````

                                                                                ...
                                                                                `@@@@@@@'
                                                                                .@@@@@@@@@@@
                                                                               @@@@@@@@@@@@@@
                                                                             #@@@@@@@@@@@@@@@@
                                                                            @@@@@@@@@@@@@@@@@@@
                                                                          ;@@@@@@@@@@@@@@@@@@@@.
                                                                         @@@@@@@@@@@@@@@@@@@@@@@
                                                                      .@@@@@@@@@@@@@@@@@@@@@@@@@@
                                                                    ;@@@@@@@@@@@@@@@@@@@@@@@@@@@@.
                                                                  #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
                                                                 ,@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#
                                                                  `@@@@@@@@@@,@@@@@@@@@@@@@@@@@@@@@
                                                                     ;@@@@+. @@@@@@@@@@@@@@@@@@@@@@#
                                                                             @#@@@@@@@@@@@@@@@@@@@@@
                           `.                                                + @@@@@@@@@@@@@@@@@@@@@'                                                      .
                          ;@@@                                                :@@@@@@@@@@@@@@@@@@@@@@                                                     @@@
                          @@@@                                                @@@@@@@@@@@@@@@@@@@@@@@:                                                   ;@@@'
                          @@@@                                                @@@@@@@@@@@@@@@@@@@@@@@@                                                   .@@@@
                          @@@@                                               .@@@@@@@@@@@@@@@@@@@@@@@@.                                                   @@@@
                         ,@@@@                                               @@@@@@@@@@@@@@@@@@@@@@@@@@                                                   @@@@
                         #@@@+                                               @@@@@@@@@@@@@@@@@@@@@@@@@@                                                   @@@@;
                         @@@@,                                              `@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                  @@@@@
                         @@@@                                               #@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                  #@@@@
                         @@@@                                               @@@@@@@@@@@@@@@@@@@@@@@@@@@@#                                                 ;@@@@
                         @@@@                                               @@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                  @@@@
                        ;@@@@                                              +@@@@@@@@@@@@@@@@@@@@@@@@@@@@@'                                                 @@@@
                        @@@@@                                              @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                 @@@@,
                        @@@@'                                              @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@.                                                @@@@+
                        @@@@`                                             '@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                @@@@@
                        @@@@                                              @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                '@@@@
                        @@@@                                              @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                               `@@@@
                        @@@@                                             '@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                                @@@@
                        @@@@                                             @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@'                                               @@@@
                        @@@@                                             @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                               @@@@
                        @@@@                                            ;@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@`                                             ,@@@@
                        @@@@,                                           @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                             @@@@@
                        @@@@@                                           @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                            `@@@@@
                        @@@@@@                                         ,@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@'                                           @@@@@@
                        @@@@@@#                                        @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                          @@@@@@@
                        @@@@@@@@                                       @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@`                                        @@@@@@@@
                        @@@@@@@@@                                     ,@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                      `@@@@@@@@@
                        @@@@@@@@@@'                                   @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                     #@@@@@@@@@@
                        @@@@ @@@@@@@,                                 @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@,                                  +@@@@@@@+@@@+
                        @@@@. @@@@@@@@'                              #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                                #@@@@@@@+ +@@@.
                        @@@@;  ;@@@@@@@@@:                           @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                            `#@@@@@@@@@`  @@@@
                        ;@@@+    @@@@@@@@@@@@;                      '@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@;                       .#@@@@@@@@@@@'    @@@@
                        `@@@@      @@@@@@@@@@@@@@@#.                @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@                  :@@@@@@@@@@@@@@@+     @@@@@
                         @@@@@'      ;@@@@@@@@@@@@@@@@'            #@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@              `@@@@@@@@@@@@@@@@@.      @@@@@@
                         @@@@@@@@       :@@@@@@@@@@@@@@@@`         @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@'           ;@@@@@@@@@@@@@@@@,      ;@@@@@@@@
                         @@@@@@@@@@,        ,@@@@@@@@@@@@@@        @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@         .@@@@@@@@@@@@@+.       `@@@@@@@@@@'
                         @@@@@@@@@@@@+           `'@@@@@@@@@;      @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@        @@@@@@@@@@:           '@@@@@@@@@@@@
                         ,@@@@@@@@@@@@@@             .@@@@@@@#     @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#      @@@@@@@@`            #@@@@@@@@@@@@@@
                          @@@@``+@@@@@@@@@              @@@@@@@    @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@     @@@@@@#             #@@@@@@@@@:`,@@@@
                          @@@@.```,@@@@@@@@@             :@@@@@@  '@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@    @@@@@@             #@@@@@@@@@````@@@@#
                          @@@@@``````@@@@@@@@@             @@@@@@`@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@  @@@@@#            ,@@@@@@@@+``````@@@@`
                          .@@@@````````@@@@@@@@#            @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@ @@@@@+            @@@@@@@@'````````@@@@
                           @@@@``````````@@@@@@@@.           @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#@@@@#           '@@@@@@@'`````````#@@@@
                           @@@@#```````````@@@@@@@#           @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@           @@@@@@@@```````````@@@@,
                           :@@@@````````````:@@@@@@@          .@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@          .@@@@@@@`````````````@@@@
                            @@@@.`````````````@@@@@@@.         @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@;         +@@@@@@;`````````````@@@@@
                            @@@@@``````````````,@@@@@@'        '@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@         @@@@@@@```````````````@@@@,
                            `@@@@````````````````@@@@@@+        @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@         @@@@@@+```````````````:@@@@
                             @@@@'````````````````#@@@@@#        @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@         @@@@@@.````````````````@@@@#
                             +@@@@`````````````````,@@@@@+         @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@#         @@@@@@`````````````````.@@@@
                              @@@@:`````````````````.@@@@@,          :@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@'          @@@@@@``````````````````@@@@@
                              @@@@@``````````````````@@@@@@              +@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@:              @@@@@@``````````````````@@@@`
                               @@@@,```````````````.@@@@@@@                   .;@@@@@@@@@@@@@@@@@@@@@@@@'`                   @@@@@@@````````````````@@@@@
                               @@@@@``````````````.@@@@@@@                                @@@@..                              @@@@@@@```````````````@@@@.
                                @@@@,````````````,@@@@@@'                      +@@        @@@@       `@@`                      @@@@@@@`````````````@@@@@
                                @@@@@```````````,@@@@@@`                      ;@@@#       @@@@       @@@@                       +@@@@@@```````````.@@@@.
                                 @@@@'`````````,@@@@@@                       `@@@@@       @@@@       @@@@@                       :@@@@@@``````````@@@@@
                                 #@@@@````````:@@@@@@                        @@@@@        @@@@       ,@@@@#                       .@@@@@@````````:@@@@`
                                  @@@@@``````:@@@@@@                        @@@@@.        @@@@        @@@@@.                       `@@@@@@```````@@@@@
                                  :@@@@.````'@@@@@@                        `@@@@+         @@@@         @@@@@                         @@@@@@`````#@@@@
                                   @@@@@```'@@@@@@                         @@@@@          @@@@         .@@@@#                         @@@@@@```.@@@@;
                                    @@@@#`#@@@@@@                         ,@@@@`          @@@@          @@@@@                          @@@@@@.`@@@@@
                                    +@@@@+@@@@@@                          @@@@@           @@@@           @@@@#                         `@@@@@@#@@@@
                                     @@@@@@@@@@                          `@@@@            @@@@           +@@@@                          .@@@@@@@@@+
                                      @@@@@@@@                           @@@@@            @@@@            @@@@;                          '@@@@@@@@
                                      +@@@@@@,                           @@@@`            @@@@            @@@@@                           #@@@@@@
                                       @@@@@#                            @@@@             @@@@            `@@@@                            @@@@@@
                                      `@@@@@                            ;@@@@             @@@@             @@@@                             @@@@@
                                      @@@@@                             @@@@;             @@@@             @@@@;                            `@@@@'
                                     +@@@@.                             @@@@              @@@@             #@@@+                             #@@@@
                                     @@@@@                              @@@@              @@@@             ;@@@+                              @@@@@
                                    @@@@@                               @@@@              @@@@             .@@@;                               @@@@`
                                   .@@@@,                               @@@@              @@@@             ;@@@:                               #@@@@
                                   @@@@@                                @@@@              @@@@             +@@@`                                @@@@;
                                  '@@@@                                 @@@@.             @@@@             @@@@                                 .@@@@
                                  @@@@#                                 ;@@@#             @@@@             @@@@                                  @@@@#
                                 #@@@@                                   @@@@             @@@@             @@@@                                   @@@@
                                 @@@@+                                   @@@@`            @@@@            @@@@'                                   @@@@#
                                #@@@@                                    #@@@@            @@@@            @@@@                                     @@@@
                                @@@@+                                     @@@@.           @@@@           @@@@@                                     @@@@#
                               +@@@@                                      @@@@@           @@@@          ,@@@@`                                      @@@@
                               @@@@#                                       @@@@@          @@@@          @@@@@                                       @@@@+
                              ,@@@@                                        ;@@@@:          @@          @@@@@                                        .@@@@
                              @@@@@                            `;+@@+;      @@@@+                      @@@@,      .;;;;.                             @@@@.
                              @@@@                         `@@@@@@@@@@@@@    @@@                       ;@@+   +@@@@@@@@@@@@@`                        #@@@@
                             +@@@@                       #@@@@@@@@@@@@@@@@@                                 .@@@@@@@@@@@@@@@@@+                       @@@@
                             @@@@:                     @@@@@@@@@@@@@@@@@@@@@                               '@@@@@@@@@@@@@@@@@@@@+                     @@@@'
                             @@@@                    ;@@@@@@@@@@@@@@@@@@@@@@@                             ,@@@@@@@@@@@@@@@@@@@@@@@                    '@@@@
                            +@@@@                   @@@@@@@@#``@@@@'   '@@@@@@                            @@@@@@    @@@@@`:@@@@@@@@,                   @@@@
                            @@@@.                  @@@@@@@,```,@@@@     @@@@@@,                          @@@@@@,     @@@@````'@@@@@@+                  @@@@;
                            @@@@                  @@@@@@;`````;@@@;     ;@@@@@@                         `@@@@@@      @@@@``````#@@@@@+                 #@@@@
                           .@@@@                 @@@@@@```````,@@@#     #@@@@@@.                        @@@@@@@      @@@@```````:@@@@@;                `@@@@
                           #@@@'                @@@@@@`````````@@@@     @@@@@@@@                        @@@@@@@@    '@@@@````````.@@@@@`                @@@@
                           @@@@                .@@@@@``````````@@@@@' '@@@@@@@@@                        @@@@@@@@@,`@@@@@#``````````@@@@@                @@@@'
                           @@@@                @@@@@```````````;@@@@@@@@@@@+@@@@                       ;@@@#@@@@@@@@@@@@```````````,@@@@#               #@@@@
                           @@@@               '@@@@.````````````@@@@@@@@@@+`@@@@.                      #@@@;`@@@@@@@@@@:````````````@@@@@               .@@@@
                           @@@@               @@@@#``````````````+@@@@@@@,``@@@@;                      @@@@```+@@@@@@@.``````````````@@@@#               @@@@
                          ;@@@'              .@@@@`````````````````'@@@:````;@@@;                      @@@@`````'@@@,````````````````:@@@@               @@@@
                          +@@@.              @@@@#``````````````````````````;@@@+                      @@@@```````````````````````````@@@@:              @@@@`
                          @@@@               @@@@```````````````````````````;@@@+                      @@@@```````````````````````````+@@@@              @@@@;
                          @@@@              `@@@@```````````````````````````'@@@;                      @@@@````````````````````````````@@@@              #@@@+
                          @@@@              +@@@+```````````````````````````#@@@:                      @@@@````````````````````````````@@@@              '@@@+
                          @@@@              @@@@.```````````````````````````@@@@.                      @@@@,```````````````````````````@@@@'             ;@@@@
                          @@@@              @@@@````````````````````````````@@@@                       @@@@'```````````````````````````;@@@@             .@@@@
                          @@@@              @@@@````````````````````````````@@@@                       '@@@@```````````````````````````.@@@@             .@@@@
                          @@@@              @@@@````````````````````````````@@@@                       `@@@@````````````````````````````@@@@             `@@@@
                          @@@@              @@@@```````````````````````````;@@@@                        @@@@````````````````````````````@@@@             .@@@#
                          @@@@             .@@@@```````````````````````````@@@@'                        @@@@:```````````````````````````@@@@             .@@@+
                          @@@@             ;@@@@```````````````````````````@@@@                         @@@@@```````````````````````````@@@@             ;@@@;
                          @@@@`            ;@@@@``````````````````````````:@@@@                         `@@@@```````````````````````````@@@@             +@@@.
                          @@@@;            ;@@@@``````````````````````````@@@@#                          @@@@'``````````````````````````@@@@             @@@@
                          #@@@+            ;@@@@`````````````````````````.@@@@                           +@@@@``````````````````````````@@@@             @@@@
                          ;@@@@            .@@@@`````````````````````````@@@@@                            @@@@+`````````````````````````@@@@             @@@@
                           @@@@            .@@@@````````````````````````:@@@@`           ....`            #@@@@`````````````````````````@@@@             @@@@
                           @@@@             @@@@````````````````````````@@@@@      .@@@@@@@@@@@@@@@;       @@@@@````````````````````````@@@@             @@@@
                           @@@@             @@@@```````````````````````@@@@@     +@@@@@@@@@@@@@@@@@@@@`    ;@@@@;``````````````````````.@@@@            ;@@@;
                           @@@@'            @@@@``````````````````````#@@@@+    +@@@@@@@@@@@@@@@@@@@@@@`    @@@@@``````````````````````;@@@+            @@@@
                           '@@@@            @@@@,`````````````````````@@@@@     @@@@@@@@@@@@@@@@@@@@@@@@     @@@@@`````````````````````@@@@,            @@@@
                            @@@@            @@@@+````````````````````@@@@@      @@@@@,            '@@@@@     .@@@@;````````````````````@@@@             @@@@
                            @@@@.           ;@@@@````````````````````@@@@.      @@@@@@#         `@@@@@@@      #@@@@````````````````````@@@@            #@@@;
                            @@@@@            @@@@```````````````````#@@@@       @@@@@@@@.      #@@@@@@@@       @@@@````````````````````@@@@            @@@@
                            .@@@@            @@@@```````````````````@@@@        '@@@@@@@@.    #@@@@@@@@        @@@@+``````````````````+@@@+           `@@@@
                             @@@@,           @@@@'``````````````````@@@@         `@@@@@@@@   ;@@@@@@@@         .@@@@``````````````````@@@@`           @@@@'
                             @@@@@           ;@@@@``````````````````@@@@             #@@@@@  @@@@@,             @@@@``````````````````@@@@            @@@@
                              @@@@            @@@@``````````````````@@@@              '@@@@+@@@@@               @@@@`````````````````;@@@@           #@@@@
                              @@@@@           @@@@'`````````````````@@@@               @@@@@@@@@.               @@@@`````````````````@@@@,           @@@@`
                              .@@@@           '@@@@`````````````````@@@@                @@@@@@@@               `@@@@`````````````````@@@@           +@@@@
                               @@@@@           @@@@`````````````````@@@@                `@@@@@@                #@@@@````````````````+@@@@           @@@@,
                               .@@@@`          @@@@@````````````````@@@@@                #@@@@                 @@@@,````````````````@@@@.          #@@@@
                                @@@@@          `@@@@````````````````.@@@@                @@@@@#               +@@@@````````````````:@@@@           @@@@,
                                `@@@@;          @@@@'````````````````@@@@@              @@@@@@@'             `@@@@+````````````````@@@@#          @@@@@
                                 @@@@@          '@@@@````````````````.@@@@@            @@@@@@@@@#           ,@@@@@````````````````.@@@@          '@@@@`
                                  @@@@@          @@@@;````````````````#@@@@@#        +@@@@@@@@@@@@,       `@@@@@@.````````````````@@@@@          @@@@@
                                  ,@@@@'         +@@@@`````````````````@@@@@@@@@@@@@@@@@@@@ .@@@@@@@@@@@@@@@@@@@:````````````````.@@@@`         @@@@@
                                   @@@@@`         @@@@;`````````````````@@@@@@@@@@@@@@@@@@   `@@@@@@@@@@@@@@@@@,`````````````````@@@@@         #@@@@:
                                    @@@@@         #@@@@``````````````````'@@@@@@@@@@@@@@,      #@@@@@@@@@@@@@@```````````````````@@@@,        :@@@@@
                                    `@@@@@         @@@@,``````````````````@@@@@@@@@@@@.          ;@@@@@@@@@@@:``````````````````@@@@@         @@@@@
                                     ;@@@@@        @@@@@``````````````````.@@@@ .                        @@@@```````````````````@@@@+        @@@@@`
                                      #@@@@+        @@@@```````````````````@@@@,                        @@@@@``````````````````'@@@@        @@@@@;
                                       @@@@@,       @@@@@``````````````````@@@@@                       '@@@@@``````````````````@@@@@       +@@@@#
                                        @@@@@`      ,@@@@`````````````````.@@@@@@                     '@@@@@@`````````````````.@@@@`      .@@@@@
                                         @@@@@       @@@@:````````````````#@@@@@@@;                  @@@@@@@@,````````````````@@@@@       @@@@@
                                         .@@@@@      @@@@@````````````````@@@@@@@@@@;              #@@@@@@@@@@````````````````@@@@#      @@@@@
                                          '@@@@+      @@@@```````````````.@@@@@@@@@@@@@@@+;;;;+@@@@@@@@@@@@@@@```````````````:@@@@      #@@@@`
                                           @@@@@.     @@@@;``````````````@@@@@ +@@@@@@@@@@@@@@@@@@@@@@@@.`@@@@+``````````````@@@@@     ,@@@@'
                                            @@@@@     #@@@@``````````````@@@@`   '@@@@@@@@@@@@@@@@@@@@.   @@@@@``````````````@@@@;     @@@@@
                                             @@@@@     @@@@`````````````@@@@@       #@@@@@@@@@@@@@@'       @@@@:````````````.@@@@     @@@@@
                                             .@@@@+    @@@@,````````````@@@@           .+@@@@@@;           #@@@@````````````@@@@@    #@@@@
                                              #@@@@`   @@@@#```````````@@@@@                                @@@@,```````````@@@@,   ,@@@@'
                                               @@@@@   .@@@@```````````@@@@                                 +@@@@```````````@@@@    @@@@@
                                                @@@@@   @@@@``````````@@@@@                                  @@@@,`````````:@@@@   @@@@@
                                                ;@@@@;  @@@@.`````````@@@@                                   ;@@@@`````````@@@@;  #@@@@.
                                                 @@@@@  @@@@+````````@@@@@                                    @@@@;````````@@@@  ,@@@@@
                                                  @@@@@ ,@@@@```````,@@@@                                     `@@@@````````@@@@  @@@@@
                                                  ;@@@@` @@@@```````@@@@#                                      @@@@#```````@@@@ @@@@@.
                                                   @@@@@ @@@@``````#@@@@                                        @@@@``````:@@@@ @@@@@
                                                   `@@@@'@@@@``````@@@@;                                        #@@@@`````+@@@;@@@@@
                                                    @@@@@@@@@.````@@@@@                                          @@@@+````@@@@@@@@@;
                                                     @@@@@@@@;```+@@@@`                                          '@@@@````@@@@@@@@@
                                                     @@@@@@@@+```@@@@#                                            @@@@@```@@@@@@@@,
                                                      @@@@@@@@``@@@@@                                             `@@@@@``@@@@@@@@
                                                      @@@@@@@@`@@@@@`                                              #@@@@,`@@@@@@@'
                                                      `@@@@@@@#@@@@'                                                @@@@@.@@@@@@@
                                                       @@@@@@@@@@@@                                                  @@@@@@@@@@@@
                                                       '@@@@@@@@@@                                                   ;@@@@@@@@@@
                                                        @@@@@@@@@`                                                    @@@@@@@@@@
                                                        @@@@@@@@;                                                      @@@@@@@@:
                                                        `@@@@@@@                                                        @@@@@@@
                                                         @@@@@@                                                         .@@@@@#

````


this commit doesn't increase the nesting limit for main /comments pages, does it? are there plans to do that soon?


@danielreuther is there any special reason for this reorder? Like semantic thing?


Now I'm looking at this again. I think they might do this way purposely. It shows the log twice but it says `Error: done() called multiple times` below.

the test on master branch makes sure if the `done` is called more than once it fails. For the log its really a mocha thing.


Doesn't changing everything to `$state.prototype.x` mean you have to do `new $state()`?


We don't need this if statement logger level should take care of stuff ?


Yep, doh.
On Tue, Jun 30, 2015 at 8:37 PM Nate Abele <notifications@github.com> wrote:

> Doesn't changing everything to $state.prototype.x mean you have to do new
> $state()?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angular-ui/ui-router/commit/7360b6ec67332774446815c7d8971795bbff486a#commitcomment-11944865>
> .
>


Well, yes! If you're stride is 960 then you should probably set it to 960,
no?

On Tue, Jun 30, 2015 at 9:00 PM, isaak654 <notifications@github.com> wrote:

> @hastalafiesta <https://github.com/hastalafiesta> I installed an app
> called Device Debug, and this is a log obtained from i9070_JB:
>
> http://hastebin.com/ecepotuhof.sm
>
> On Camera 1 you can clearly see that Record stride value for our device is
> 960, so I don't see the point to set an irregular value like 4096.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zzpianoman/android_frameworks_av/commit/4dd20cf8df10e3f71897b01b0b4849b93ad8d6c0#commitcomment-11944542>
> .
>


There must be a way to chain these three ```match``` statements together and only check for error once at the end.  This would make the code shorter and (I think) more readable.  I'm assuming the logic is correct as is.

These are two links that don't quite do what you want, but hopefully they'll lead you in the right direction.
http://stackoverflow.com/questions/20824766/idiomatic-scala-for-applying-functions-in-a-chain-if-options-are-defined
http://daily-scala.blogspot.com/2010/02/chaining-options-with-orelse.html


edit


配列はスペースを空ける


Yes, get fixed. Thanks Mike.


Google style guide for Java:

> Method names are typically verbs or verb phrases. For example, sendMessage or stop

http://google.github.io/styleguide/javaguide.html#s5.2.3-method-names

```requireLogin```?  ```processLogin```?


端折ってはいるけど、privateって書いてあるってことは、クラス内なので
$this->displayStatus
である必要がある


$hasは真偽値の印象が強いから避けた方が良いかも


Roll, -pitch, -yaw


r+


スペースを空ける


This is a good thing to document in ScalaDoc because it's not at all obvious from the class/method names what the algorithm is.


I'm sorry for this but I took @blackcoder's tests as enough for applying this patch. I took long hours of developing and troubleshooting to try to clean what everyone was not certain was right. So don't take me wrong on this but this was just to help and not to break anything, as you tend to say...


Trust abuse, ah? Typical Michael Reed.


sqlite_timeseries (mbadams5) - x86_64-MacOS-10.9-clang: OK (1705 of 1706 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


持ってる契約が全て返って来た上で、契約状態と有効期限を見ているから$hasは全体的におかしい気がする
持っているかではなくて、有効かの方が良い
有効だったらとりあえずvalidかな
[参考](http://g1g0.com/2013/08/1811/)


Improved test at i7-3517U:
TCP 48929 rps
IPC 36593 rps
ZMQ not tested


*while wearing blindfold, hits merge button on all of @fmoralesc's PRs*


And that is the path to my radium source :3
But I have 6.0 for kernel cloned locally as well anyway xD


なんか面倒な事やってない？


This test should actually be:
Start sql:

````sql
WITH cte1 as (SELECT a FROM b) SELECT C into D from cte1;
````
Translates to:

````sql
IF XACT_STATE() = 1 COMMIT; CREATE TABLE D WITH (DISTRIBUTION = REPLICATE)\nAS\NWITH cte1 as (select a FROM b) SELECT C  FROM CTE1;
````


Create a GitHub issue and reference the issue number in the comment.

In the meantime, print to standard error?


why are you importing the files directly?


reack


@craigkerstiens You broke my Heroku button. For shame! Is there a new button?


Also typical Michael Reed. *Carry on*.


@rwdaigle Oh good call, insta-fix then.


Anything else worth adding/changing? Looks pretty solid to me.


Are lines 210-211 supposed to be enclosed in braces?
Does that matter?


Any reason why this is here?


oops, that's what i get for copy and pasting without testing...


Do these all build? If so merging commit to UBERTC :+1:


Thank you for correcting this logging oversight.  I have made the corrections, and will release sometime tonight or tomorrow.


And here I was ranting about bad Apple QA on Twitter. Serves me right!


Define this magic number somewhere?


Define magic number somewhere?


use `===` instead of `==` to prevent issues with type casting


1. should I remove the old one?
2. ok, I'll remove "message"


global variable shared between all widgets?


Haii..
How can I upload images using these classes? I am completely unaware of this uploading images from mobile using api
Please help me in this


@perry haha, fair! I sort of feel like `overflow: hidden` is a similar property to `display: none` where it can be useful to comment the CSS as to why, for future devs looking at, (since it's usually done for quite specific reasons that aren't immediately obvious).


:santa:


probably smth like `extractItem` sounds better


是不是需要 @inkn 一下？


no need in tmp var?


hello world


咦 這邊為什麼拿掉? 好像因為這個 fail 了，還是說你要做成 Param class?


HELLO WORLD


THIS IS README.ME


debugging?


@dtaalbers I would really suggest scoping this to a namespace, so it doesn't pollute the window and global. Take for example a [look at this article](http://appendto.com/2010/10/how-good-c-habits-can-encourage-bad-javascript-habits-part-1/).


Антон, привіт.
Твій аккаунт дали викладачі з LITS.
Шукаю собі в команду перспективного початківця/середнячка для RoR + HTML, порадили тебе і ще декількох студентів.
Якщо цікавить участь в проєктах студії - дай мені знати на:
voronin.nick@gmail.com
або у фейсбуці: https://www.facebook.com/voronin.nick

Дякую.


*dances*


just note: You can also use jquery.toggleClass


@Agontuk I have the optimization of google play service on every boot and it takes about 5 mins (so it makes boot extremely longer than normal), any tips?


what is the difference between plot_sources and plot_raw_components ?

my feeling is that your plot_raw_components should be the replacement of the ica.plot_sources when passing a raw object.


Probably we had some misunderstanding. I asked you to create separate widget so that client is not forced to define validators and formatters during/after initialization but can use default ones. But that is also ok.

The main thought is that you found out how to use inheritance using jquery.widgets


It is confusing to create $choice_list elsewhere and manipulate it else where. Survey::getAndRenderChoices() shoud indeed return the rendered choice list not templates otherwise you will have to do that processing everywhere you call getAndRenderChoices.

Also the reason I avoided the class property was because you don't exactly know where that array $strings_to_parse will be emptied after the instance has been created.


needs minimum z-index of 501, cause #dropdown have a z-index of 500, and if the autocomplete function found a result, the z-index goes +1 from the target element (#dropdown)
```
<ul style="z-index: 501; display: block; width: 313px; top: 91.4833px; left: 1081px;" tabindex="0" id="ui-id-1" class="ui-autocomplete ui-menu ui-widget ui-widget-content ui-corner-all"><li role="presentation" class="user ui-menu-item"><a tabindex="-1" class="ui-corner-all ui-state-focus" id="ui-id-2">felix</a></li></ul>
```


there is no such module in the kie-tests, it is in performance-tests so the build of this project will fail.


@pandalion tell @henrahmagix to update the style guide :wink:


reset


can we use simple target as the reportDataLocation so it's generic and no someone's specific folder?


Can you explain why these two contexts are redundant? Is it because there's no value in tests that only uses `assert_current_node :oru_result`?


in js we use capital names only for constructors and constants


Yeah I understand why you did this, but with your method we incur opencpus
overhead twice at least (for choices and items). Thats not so good.
Cyril <notifications@github.com> schrieb am Mi., 1. Juli 2015 um 12:09:

> It is confusing to create $choice_list elsewhere and manipulate it else
> where. Survey::getAndRenderChoices() shoud indeed return the rendered
> choice list not templates otherwise you will have to do that processing
> everywhere you call getAndRenderChoices.
>
> Also the reason I avoided the class property was because you don't exactly
> know where that array $strings_to_parse will be emptied after the instance
> has been created.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rubenarslan/formr.org/commit/58d68a541266570e5b6cc2c2f8b82c04edf24146#commitcomment-11949929>
> .
>


Ge kunt mss wel nog zoiets toevoegen als validatie:

	repository=$1
	client=$2
	project=$3

	if [[ "$repository" == "" ]] || [[ "$client" == "" ]] || [[ "$project" == "" ]]
	then
		echo "usage: ./new-fork-project.sh <repository> <client> <project>"
	else
		<alle code>
	fi


voordelen:

* je hebt validatie
* je kan overal named variabelen gebruiken, dus $repository ipv $1 bvb
* als je mist krijg je een schone uitleg hoe het werkt.


Can you explain why the following test contexts are redundant?

* "answer Brazil, registered in north-korea"
* "Death in Poland, currently in Cameroon"
* "died in austria, user in north-korea"

Is it because there's no value in tests that only use `assert_current_node :oru_result`?


what about using `selectedProduct` instead of `selectedIndex`?


Eigenlijk is het best practice om commit message in de imperatief te schrijven, dus "Add" ipv "Added".


Regarding the class property: I understand that this is not guaranteed, but
its nice that it can have multiple consumers. Maybe a better way'd be to
put this in a singleton or so.
Ruben Arslan <rubenarslan@gmail.com> schrieb am Mi., 1. Juli 2015 um 12:12:

> Yeah I understand why you did this, but with your method we incur opencpus
> overhead twice at least (for choices and items). Thats not so good.
> Cyril <notifications@github.com> schrieb am Mi., 1. Juli 2015 um 12:09:
>
>> It is confusing to create $choice_list elsewhere and manipulate it else
>> where. Survey::getAndRenderChoices() shoud indeed return the rendered
>> choice list not templates otherwise you will have to do that processing
>> everywhere you call getAndRenderChoices.
>>
>> Also the reason I avoided the class property was because you don't
>> exactly know where that array $strings_to_parse will be emptied after the
>> instance has been created.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/rubenarslan/formr.org/commit/58d68a541266570e5b6cc2c2f8b82c04edf24146#commitcomment-11949929>
>> .
>>
>


it's better to create separate reference `this.selectedProduct = this.products[index]`


Could we please get a new build and a release of this? I consume dependencies via Bower and this is preventing me from using the latest version...


Can you change this error message to also include GroupId?


Fixes #16


One mutex for syncing access to commands queue, another one for messages queue. What exactly should be in a design doc?


I also don't remember what exactly was the issue, only that some custom Jazkarta microsite loading(?) code was preventing the microsite loading, either via microsites.json or server-vars (lms.env.json I think). When I disabled that, we were able to load the microsite normally.


Зачем возвращать __factors[:]__? Разве __return factors__ не значит то же самое?


@Gaelan Yes, absolutely, plus a few others like `:AckFile` for completeness :smile:

I'd recommend these as a bridge to anyone who may want to migrate (back?) from ag.vim to ack.vim, but it doesn't seem appropriate to actually include them in ack.vim. I guess I might entertain a pull request to define `Ag` commands as aliases `if g:ackprg =~# '^ag\s'` but that feels like bloat to me unless ag.vim maintainers wished to merge the projects again. This could have been part of an alternative to forking in the first place…


# 出力のマージ
極性分析を最終ファイルにマージする
# 日付の処理


https://github.com/mavlink/mavros/tree/test_package_for_0.13/test_mavros - here test for imu with apm sitl.
Based on that i returned to old math (it maybe wrong, but at least i see same imu evolutions as gcs).

Issue #321.


Pops and executes commands left in the queue when the class is destroyed in destructor and worker thread should exit. Take a look on two following lines of code.


@ncannasse: I have no idea what I'm doing here but I guess these are "should never happen" cases anyway.


Could be `self._request = RequestsHttpCaller(self.url)`?


nyampah commit


This is the application of PR #3445, the explanation is on that PR's description.


remains to be seen. otherwise i'll slap a sma+coax on it. but that is the only pin.


2 spaces in-between `#{@postcode}  -`


@snozawa
I added samplerobot_sequrence_player to test case. To make test failure, I used assert so if there are some bugs, samplerobot_sequrence_player.py stops at that point, whereas current implementation go through all test/demo program/function and display True or False. If you do not like this behavior, I'll change this.


add methods into prototype instead of adding this. Each time you create new instance of this controller you also create methods (use extra RAM space)


line


see https://github.com/contao-community-alliance/dc-general/commit/e6454be989132d1f5d257fbbdf0e9d7181ad6f59


See also https://github.com/MetaModels/attribute_tags/commit/ff12cc630975111818efd1d0aed82274ab18d111


:+1: Молодец!


why don't you use ngModel controller?


0x128 + 4 = 0x12c, create_time is at 0x130.. missing some padding? I see the source you referenced has the same mistake with missing the padding too.

https://github.com/exjam/xbox360-emu/blob/master/docs/kernel/structures.txt#L129-L131


could be $().removeClass("menu_0_cursor menu_1_cursor menu_2_cursor").addClass("something")

actually,what I am thinking is maybe using css pseudo class and css transition to do this is a better choice.


Thanks for noticing; removed it in db1773af5d0371e2905783e47a2d5ded92c4a8bb.


Hi Anton, have test the fuel indicators and it's working.
The only minor problem is, the fuel indicators is show in scale 0 - 800 not in percentage (0% - 100%). Is it possible to make it into percentage, as percentage will be easier to understand ?


LGTM


Sure, of course. All code refactoring will appreciated


Same here, missing 4 byte padding. You might want to check all of your structs closely for this, I only quickly skimmed over it to see if the structs I figured out were correct!


you created, a directive do you need this method also?


@DooMLoRD

Can you please take a look here?

http://forums.yuplaygod.com/threads/official-yuphoria-windows-drivers-pack-drivers-for-adb-fastboot.15025/page-2#post-180410


The import of `from .nidaq import NIDAQError` in `acq4/drivers/nidaq/SuperTask.py` does not seem to work on my system. Strange that it seems to work on yours?
Is there something else I am doing wrong?


Remember, the HD patch doesn't recognize "regional" folders.


I realised that broadcasting only works one way around for multiplication, so may as well stick with that here too.


The `DefId` here is the `DefId` of the impl from the `VtableImpl`. I really don't like storing these kinds of things.


why not just `item`? what is the purpose to pass each property separately?


css3 keyframe might be something more suitable in this case.


we don't write this way.


I'll try to make one. I think the original release didn't come with one.


I removed the 4D tests as I think they are now redundant: assuming the collapsed method and cube operations are working correctly, I can't see how the 3D tests would pass and the 4D ones fail.


Cool. You might also want to define a short hand for `Thread.current[:swagger_last_response]` as `Swagger.last_response` as it's easier to remember how to access it. (and it could also catch typo, as `Thread.current[:swaggger_last_response]` would not give you an error but nil, and `Swagger.last_ressponse` would give you an error.


Why is this initialized to -1?


see issue #315


I am really clueless now, because with certainty the right Google Play Services has been installed.


Geht diese Änderung bei dir? Bei mir nämlich nicht...
Mir scheint es, dass man Stilspezifische Optionen (nurinit) nicht an diese Stelle setzen kann, sondern dort funktionieren nur biblatex-eigene Optionen


Laughable


Don't you at least *compile* your PRs?


We have xsprintf() for this.


why's self bad here? self is independent from the class name and shorter. Plus one can easily transform the method from nonstatic to static without rechanging all usages.


Changed MEAN to SUM for consistency with `scipy.stats.mstats.pearsonr`.  It only makes a difference if the cubes' masks do not match.


Why this? Doesn't safe_atoi() handle this just fine?


I analyzed the app versions of the installed Core Apps and they seem right. Can you take another look too? BTW have you installed the fornexus package or another one?


As far as I remember you can use `$close` inside template, so I believe no need to create separate method


xsprintf()


ack


probably putting everything into one object would be better


@talex5 sorry I had to tweak the watch API again to fix that race ...


I am testing with 'stock' with a custom gapps-config. I also did look at the versions, and for my Galaxy S3 they are also correctly installed and chosen. I have literally no idea what is going on.
Do we know how Google Play Services/The Play Store determines which dpi the device is using?


https://github.com/ros-perception/imu_pipeline/blob/indigo-devel/imu_transformer/launch/ned_to_enu.launch

From REP 145. But i think that here Y-front X-right Z-down.


</body>


LGTM


Do you mean it shouldn't change from using the makefile?

My experience with the makefile build was that it didn't work. It seemed out of date. Using xbuild there were problems with case-insensitive resource filenames. That was easily fixed, to use xbuild.


Cool, I didn't know you can make it too :smile: Thanks


I don't see changes to your table styles. You need to add styles so that everything looks good


das geht bei dir?


I wonder what the plan is for  usb_midi_msg_type going forward. So far it is 0 to 8, this patch adds 9, and adding the other defined codes from the system and realtime block would take us to 18 (24 if the currently unassigned ones were also allocated in anticipation of future standardisation and to keep them in order).


Not after the last rebase I did, apparently.


`buf` is 4k, `rt` and `wt` is 256. Sure, it's kernel generated data and shouldn't overflow, but  "%ms" is preferred, imo.


This looks like useful functionality. I believe similar changes to the Teensy 2/++2 usbMIDI code should also be made, to keep them in sync.


Selva,

Looks ok to me.


can you remove unneeded stuff to keep this file clean?


ack


Error could be INUSED ?


probably we only want one commit to add the whole pylintrc :)


Maybe introduce a `method_trait_ref` method?


we don't have an 'org.jboss' version of this one?


The userAcceleration according to to doc is
The acceleration that the user is giving to the device. (read-only)
https://developer.apple.com/library/ios/documentation/CoreMotion/Reference/CMDeviceMotion_Class/#//apple_ref/occ/instp/CMDeviceMotion/userAcceleration


Question:
Is returning nothing(undefined) for sync mode intended?


fixes #1993 | https://github.com/syncthing/syncthing/issues/1993


ack, the or thing is nice.


hui, du magst recht haben. Ich guck mir das nachher an.


Checking comments.


"failed to initialize" ?


@flavour please review this...Is this good for merge? Should cap.js be compressed now or after some time period because there are places where cap.js should be changed?


Ah. Make sure to add anyone from SK who's reason contains "DDoS", "stealing files" or "ban me forever". These are dangerous.


Is explicit importing core-js necessary? It's a bloat if I'm using some other polyfill for `Map` support.


argh, that's not that easy. _ is our translation function, you override it with this for the scope below. This this is error phrone.


I will make a level check instead. GetActiveSpecGroup is useless for the purpose it was meant to be used as. GetSpecialization is the only part that gives correct information so that we can use it to show correct stats.


Oh shit :-). Zum Glück wird der Part in Production eh generiert ist also Wurst was da steht.


this chunk is ok


動かす


I pledge for rejection except for the chunk marked as ok :)


ack


見直す


bei geschichtsfrkl in der cbx gibt es aber ein so ähnliche Zeile, die geschichtsfrkl-eigene Optionen aktiviert. Ich habe es aber bei mir nicht zum Laufen gebracht.
Aber wenn "nurinit" ohnehin umgemodelt wird, ist es für diesen spezifischen Fall nicht mehr wichtig.


isn't this a constant?


Peter I don't understand the removal & comment here about hardware acceleration.

Attribute "hardwareAccelerated" is only used in API level 11 and higher (and ignored in lower levels).


what does writing here do?


好顶赞，我更新下翻译。


Yes I find it working :)


@esoergel when looking at something else I realized that https://github.com/dimagi/commcare-hq/pull/7253/ wouldn't work on cloudcare. this isn't the cleanest change but I think it's the best short term plan, and added comments why


I don't know; But really that's the "canonical" EE API artifact. There should be no problem with it.


the `if` was redundant since these are defined on `CouchUser`. The use of the new `user_session_data` function is the main change.


Thanks!

Can you just add a bit of error handling and tracing to the "Handling Provided jars" part where the jars are copied? like check if the paths are ok, etc.. throw if there is something wrong.


` Merge branch 'tmp--sstok--minor-changes' into tmp--rollerworks--master `

Hmm, thats not good :|


For the examples, perhaps a sketch to demonstrate active sensing would be useful. When activated, it calls sendRealTime(0xFE) every 250ms (the timeout is 300ms).


@vooon NED frame on PX4 has X pointing front (North). So right transform is what we have.
Rotation matrix to both position and attitude (euler angles) is `{[1,0,0],[0,-1,0],[0,0,-1]}`. which means that resulting position is `(x,-y-z)` (X points NORTH) and `(r,-p,-y)`. For quaternion transformation, same thing: rotation quaternion (in `(x,y,z,w)`) has the following form `{[1,0,0,0],[0,-1,0,0],[0,0,-1,0],[0,0,0,1]}`.


I thought we are going to have something like:
```
var gpio = require('iotjs').gpio
```

If we just provide 'gpio' as same level with other builtin, why does process have 'iotjs' property?


Just empty 'iotjs' object?


I would prefer to get rid of this (have this enum be `enum MethodOrigin { Inherent, Trait }`) and cache the offsets (using the `VtableObjectData`). I would prefer to fix #26339 while I'm at it, and do it in a separate commit, through.


> my feeling is that your plot_raw_components should be the replacement of the ica.plot_sources when passing a raw object.

Yes, that's probably true. I've been having this inner debate about the design of this. One way would be just converting the data to raw array and using raw.plot, but I'm not sure what kind of features we want to add to this. At least the exclusion would work a bit different, so I decided just to do some heavy refactoring and try to reuse as much code as possible.


嗯，想起来了


It is because AK driver uses uT, so it actually has proper scaling.


It is true, but look how they defined tf: pi/2 0 pi so as i understand pi/2 rotate x/y (y-front -> x-fromt), pi z


Ah, basically, yes.


@CzBiX
感觉还有好多要修的，可能不用急着更新steam那边，这个汉化的质量不得不说有点差。
我待会还要再提交点修改


Initial commit


lose IE e.keyCode


the implementation is a byproduct of the API design. If you agree that
people should look at sources from raw with plot_sources just make it work.

if it creates huge data duplication and a waste of memory you'll have to
look into it.


This is white-space broken, and really weird coding-style. Why not:

```
_cleanup_free_ char *c = NULL;
char *r = NULL;

c = strdup(name);
if (!c)
        return NULL;

r = endswith(c, ".sh");
if (r)
        *r = 0;

if (unit_name_mangle(....) < 0)
        return NULL;

return r;
```


sure, I will change it in the upcoming commit to /tmp/reportData


This should go on the same line as the closing brace.


good catch, I will fix it


Yeah, something is swapped, either gob id or loot itself, i think it is the second one, need to check sniffs


> It is true, but look how they defined tf: pi/2 0 pi so as i understand pi/2 rotate x/y (y-front -> x-fromt), pi z

That rotation is only true on conventional NED: X points WEST, Y points NORTH and Z points down. PX$ convention has X pointing NORTH and Y EAST.


I don't want to make someone angry, so I removed only myself from classes.


ALTER TABLE `creature_template`
    ADD COLUMN `questItem1` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `RacialLeader`,
    ADD COLUMN `questItem2` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem1`,
    ADD COLUMN `questItem3` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem2`,
    ADD COLUMN `questItem4` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem3`,
    ADD COLUMN `questItem5` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem4`,
    ADD COLUMN `questItem6` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem5`;

ALTER TABLE `gameobject_template`
    ADD COLUMN `questItem1` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `size`,
    ADD COLUMN `questItem2` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem1`,
    ADD COLUMN `questItem3` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem2`,
    ADD COLUMN `questItem4` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem3`,
	ADD COLUMN `questItem5` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem4`,
	ADD COLUMN `questItem6` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem5`;ALTER TABLE `creature_template`
    ADD COLUMN `questItem1` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `RacialLeader`,
    ADD COLUMN `questItem2` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem1`,
    ADD COLUMN `questItem3` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem2`,
    ADD COLUMN `questItem4` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem3`,
    ADD COLUMN `questItem5` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem4`,
    ADD COLUMN `questItem6` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem5`;

ALTER TABLE `gameobject_template`
    ADD COLUMN `questItem1` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `size`,
    ADD COLUMN `questItem2` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem1`,
    ADD COLUMN `questItem3` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem2`,
    ADD COLUMN `questItem4` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem3`,
    ADD COLUMN `questItem5` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem4`,
    ADD COLUMN `questItem6` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem5`;


Em algumas execuções, senão em todas, a ordem da lista de tradutores importa para um pequeno vício na distribuição dos _scores_. Mas isso é besteira! Pois esses _scores_ também não fazem uma comparação "humanamente perfeita". **Fiquemos com um fator de sorteio.** Uma pequena melhoria poderá ser: tornar randômica a ordem dos tradutores.


ALTER TABLE `creature_template`
    ADD COLUMN `questItem1` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `RacialLeader`,
    ADD COLUMN `questItem2` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem1`,
    ADD COLUMN `questItem3` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem2`,
    ADD COLUMN `questItem4` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem3`,
    ADD COLUMN `questItem5` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem4`,
	ADD COLUMN `questItem6` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem5`;

ALTER TABLE `gameobject_template`
    ADD COLUMN `questItem1` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `size`,
    ADD COLUMN `questItem2` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem1`,
    ADD COLUMN `questItem3` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem2`,
    ADD COLUMN `questItem4` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem3`,
	ADD COLUMN `questItem5` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem4`,
	ADD COLUMN `questItem6` int(11) UNSIGNED DEFAULT '0' NOT NULL AFTER `questItem5`;


Hey man,tnx you and arter97 for this commit
i just implemented your powersuspend& autosleep and adreno idler
its drop to min freq and sit there,doesn't seem to ramp up even with touch
is this in the way it is or something wrong with my implementation ?
btw good affect on batt life,tnx


Great comment, thanks again!
I've updated it, please have a look:
https://github.com/swagger-api/swagger-codegen/commit/846d282ba02c9cf3f0c14618d3655798f3160519


Please try with;
```
<style type="text/css">
   .ui-selectonemenu {
      padding-right: 2em !important;
   }
</style>
```
or
```
<p:selectOneMenu style="width: ...px;" />
```


In a world with the damage disabled I've got the next error:

    ERROR[main]: ...netest-dev/bin/../mods/food/food/init.lua:113: attempt to index global 'hunger' (a nil value)

because hbhunger don't declare any variable if damage are disabled and I don't have the hunger mod installed.

So, this part of code shouldn't be as below?

    -- Checks for hunger mods to register food on
    function food.item_eat(amt)
    	if minetest.get_modpath("diet") and diet and diet.item_eat then
    		return diet.item_eat(amt)
    	elseif minetest.get_modpath("hud") and hud and hud.item_eat then
    		return hud.item_eat(amt)
    	elseif minetest.get_modpath("hbhunger") and hbhunger and hbhunger.item_eat then
    		return hbhunger.item_eat(amt)
    	elseif minetest.get_modpath("hunger") and hunger and hunger.item_eat then
    		return hunger.item_eat(amt)
    	else
    		return minetest.item_eat(amt)
    	end
    end


But this requires that all pages has a suffix called ```html```
What if another suffix is used?


Atm, html is the only suffix accepted by the system:
https://github.com/arastta/arastta/blob/master/system/library/route.php#L307


This broke several of my app's unit tests, which were checking for `status >= HTTPClientError.code`, which is now *always* `True`, as `HTTPClientError.code is None` and `201 >= None` is true. I spent an annoying half hour figuring out what happened. I've changed my tests to check for `status >= HTTPBadRequest.code`, which is downwards compatible to older Pyramid versions.


sure we can use it, but product teams will have to switch it as they only want stuff which gets rebuilt from sources.
Just a slight preference, to keep our branches from diverging.


![image](https://cloud.githubusercontent.com/assets/3346407/8453004/1f28b378-202b-11e5-8f3d-45a9a83c71f2.png)

demo


Doing...


That's Copied out of another sample in the manual

Sent from my iPhone

> On Jul 1, 2015, at 2:45 AM, Vadi Kumar <notifications@github.com> wrote:
>
> @davydotcom - Did you intend to write .files(f -> f.dir("assets"))
>
> —
> Reply to this email directly or view it on GitHub.
>


Is `headers` an instance of `Headers`? In which case the JSDoc block probably needs updating.

Is the typeof check to cover such a case?

```javascript
var hdrs = headers().accept( function () { return 'file'; } );
```

I know it existed before your change but I haven't found a case where `headers` would contain a function. Do we still need this?


Переделай на:

```php
public function render($file, array $data = [])
```

вместо сеттеров / геттеров


Необходимо добавить проверку на `is_file` или `file_exists` и в случае отсутствия выбрасывать `Exception`, либо, в случае для `$debug = false` рендрить файл с ошибкой


no need in extra brackets


Используй автоформатирование кода, если ты используешь phpstorm / intelijidea


wouldn't it then not work on windows? I was thinking to use "target" folder from the maven build so it exists always when executing regardless of the platform. If I got it right


Thanks Vivek


Do you have updated to the .json icomoon?


Personally, I don't mind. The autorship is never exclusive and Git provides sufficient informace for that.


stuff with passing `selectedIndex` as option doesn't work because it's passed as copy and not as a reference


oops.


`field.val()`


Wow i must be popular if im on this list too, and it seems you got my id correct, then again what purpose does this list serve?


List of official FBI most wanted


ACE can be valued as 1 or 14. So the Rank ONE is redundant?


Would it make sense to move  `uploadHeaders()` (https://github.com/Mendeley/mendeley-javascript-sdk/blob/master/lib/utilities.js#L212) here as well or does that function serve a different purpose?


no need in extra brackets and you can merge your selector:
1. `span.error, span.init`
2. `span.error.init` (not sure if this case is what you want)


If it were me I'd have amended the commit while nobody was looking :P


fear me


ah - I did not know we could use static methods from `self`


what about `toggleValidity` name?


@chelmuth: above fixup eliminates a compiler warning on hw_x86_64


Yes, I agree!


I fixed all those issues now.


no need in _self


well it obviously works doesn't it? :P

2015-07-01 13:03 GMT+02:00 AbdealiJK <notifications@github.com>:

> ah - I did not know we could use static methods from self
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/2ecbce2c01814bc75ef733d967cf3fc1562ca68f#commitcomment-11950740>
> .
>


`extractProduct`


would you mind reverting this change, or comment it out so that we can easily enable it as needed?
It slows down the tests :)


`populateProduct` or smth similar


These also need backporting into ``src/main/html/index.html`` to ensure that ``gulp`` does not overwrite them...


'id name ..'.split(' ').forEach(function() {field.value = ''})


Use socket.emit('validated') instead.


@tchap I'm a bit confused by this. Why should the internal representation know about existing encoders (and moreover just these two, even though markdown also uses this)?


Imho this doesn't need to be in the library, only in the app.


The correct way is to move the startup message to Protocol.java start(), just before the check if the plugin can be started


Imho this doesn't have to be in the library, only in the app.


well, I expect that users will set the report data location themselves ... "target" may be accidentally deleted via mvn clean. In the future I can imagine that the location can be an URL instead of a folder.


I would mention only the new way.


It's missing documentation whether it should contain blocking code or apps should create AsyncTask.


Update of README.md is missing.


Not critical to do the compression pre-merge, but why not?
Simply create a file in static/scripts/tools like the rest & put into the build scri[pt...


In what way? The _lib/puppet/resource/type.rb_ already had hard dependencies on the Puppet::Parser::Resource. The messages will be affected (of course). Is that a problem?


From my understanding: The way pylint works is that any constants should be in global scope (outside classes and functions) and any variables will be inside. So, possible solutions:
1. Shift these variables out - this isnt nice - because it isnt required for anything else.
2. Remove these variables - because they are unnecessarily declared.


I have seen it, but should that not be a setting?
Could be added as feature request to the next release, maybe using the config_seo_suffix instead as checkbox a input or select field.
Customers can then define by themselve.


@amite please make this live


This still does nothing - it creates a message but doesn't assign it to anything (e.g. 'result')


& here


Jup, my bad!


indent


Fair enough!


@tchap What exactly does this buy us? Why can't we use `common.ReleaseNotes` directly here?


unfortunatelly, that's not the full story. I guess you could want to cherry-pick some commits form #693


Any specific reason to not use the modules instead?

> .addAsManifestResource( VersionTestHelper.moduleDependencyManifest(), "MANIFEST.MF" )

Unless we're specifically aiming to test capability to bundle jars, moving forward we'll be recommending the modules usage - when on wildFly.

It also cuts the test execution time by 50%, as shrinkwrap won't have to zip up all the dependencies.


reack


In my local tests, turning the vals into vars made the hole extraction work. Would it somehow be possible to do it here? -- in the meantime before we handle block extraction in a more principled way based on dependency graphs.


I'd prefer this list as 1 per row (easier to comment one out and fits style of rest of app)


reacj


This isn't just ugly - it's unefficient as well.

Can be replaced with: node?.Type

I complained about the mis use of ChildNodes before - try not to use that.


I see this is because of Tabs not Spaces - eek!
This is the very first line in the customisation chapter of the book!


ACE can be valued as 1 or 14. So the Rank ONE is redundant?


cache result once.
```js
var widget = $('#...');

widget.prodWidget();

widget...
widget..
```

Each time you write $(''...) jquery finds this element on the page


indent...there should be NO tabs in the code at all - only spaces...


joking eh?
If required = True then simply set the validator to not have the IS_EMPTY_OR!


@tchap never mind, I found out below that you use custom `story` type here. Makes sense.


plural?


I agree with @hrach. Licence doesn't explicitly entitle anyone to have his name in a file/class/method header. Autorship is retained in Git history and also in [GitHub Graph](https://github.com/nette/database/graphs/contributors).


indent


You're seraching for something like:

nodeContext.SemanticModel.GetConstantValue (arrayType.RankSpecifiers[0].Sizes[0]);


Чтобы возвращать не сам список, а его копию. Ниже пример, показывающий разницу
>>> def func(a):
...     return a
...
>>> a = [2, 3, 4]
>>> b = func(a)
>>> b
[2, 3, 4]
>>> b[1] = 0
>>> a
[2, 0, 4]
>>> def func(a):
...     return a[:]
...
>>> a = [2, 3, 4]
>>> b = func(a)
>>> b[1] = 0
>>> a
[2, 3, 4]
>>>


@tchap this is just a string comparison, right? Perhaps we might want to use some better ordering, like user stories and bugs first and then coding tasks, etc.


// I deactivated this for the moment since i have to take care of sig drop

OPEN  TICKETS TO TRACK TEMPORARILY THINGS !!!


Why remove the indenting?


hm, I'd pledge towards 2.


Try to find a different expression for that.


Processing the parsed strings directly after $choice_lists = $this->getAndRenderChoices(); won't reduce ocpu over head if that is your concern. To address your concern you need to send item labels and item choices at the same time to ocpu and this I assure you will get crazy especially with the show-ifs.


This assignment is redundant, just use callback as is.


lol


Yes indeed, it was supposed to be fix. Would you mind opening an issue please?


lib/hw/sensors.default.so → lib/hw/sensors.mt6582.so
This fix sensors.


You already call this.init in the parent class.


What happened to HasConflictingNames ?


Avoid such a usage - every roslyn node has properties which usually make such things obsolete.


This, and a few other pieces below, should not be deleted to implement the SetEnvIfNoCase feature.


see above.


let


good one bhavin


Before this becomes to complicated, perhaps extract the expression into a separate variable `$use_setenv_mod` and use that everywhere.


unrelated change.


@mosic since we do not have the correct auth type needed for the camera, we are depending on fallbacks. So I am trying basic auth first and if it fails, trying digest auth. However, for the cookie based auth, the resulting url will still give 200 response and so it may not work here. some hackish way to identify cookie based auth will be to check if the ends with certain extension, say 'cgi' or the resulting response contains 'Invalid credentials'. Do you have any suggestion on how we can identify if a given url ONLY supports cookie?

/cc @marcoherbst


@tmoreira2020 No technical reason at all. It just felt more natural to me to put the required attributes before the additional ones. Would you think the previous order made more sense?


It's an auto generated file - I thought it'd be useful when figuring out which configs can be changed because this stuff isn't well documented


Use different values for testing setenvif and setenvifnocase to be able to check whether the implementation did not mix up those two.


I began this structure with a Haskell style.

When I switched to the SML functor style, the mapValues and mapKeysMonotonic functions, giving as result a similar structure with different types for values/keys respectively, made me maintain the structure as a type function.

I would accept any working suggestions to do it simpler.


On line 54:
missing whitespace around arithmetic operator:
```
# It should be:
return (grovepi.analogRead(self.ANALOG_PINS[pin.location]) / 10.23)
```

On line 66:
missing whitespace around arithmetic operator:
```
# It should be:
grovepi.analogWrite(pin.location, int(value * 2.55))
```


// The size required to print %d is not 8 * sizeof(int), rather the size of the string representation of largest int


//snprintf should not be called when tmp_comment.s is not allocated


Hi,

Thank you for your addition to the carrierroute module. I still have to test the code, but beforehand I can tell you I spot some problems around this area:

tmp_comment.s=(char *)pkg_malloc( ... )
if (!tmp_comment.s)
		LM_ERR("No pkg memory left\n");
snprintf(tmp_comment.s, 8 * sizeof(int) + 255 + 3 + 1, "%d - %s", ...

Firstly, what you are allocating in pkg_malloc is number of characters in the string representation of a number plus another string. So, the string representation of an int should be conceptually something like strlen(string representation of MAX_INT) - that is to say strlen("2147483647").

Secondly, you shouldn't try to do the snprintf if the tmp_comment.s is NULL.

Thank you


I like it.  This conveys intent a lot better to me.


The `MultipleFailureException` instance thrown by test case is collected, instead of collect `getFailures()` only;
The case `ParentRunnerTest.parentRunnerTestMethods()` is modified to verify the behavior.

Thanks!


I think that was because `var x = _` reifies an statement where as `val x = _` does not. That's the reason.
Did you try to force `as` to reify a statement to see if it works or not?


global vars?
`angular.extend({}, this.items[idx])`


I think it's read from build.prop. I also analyzed my Nandroid backup I made before flashing the ZIP and it has not changed.


I didn't realize. Hmmm, I'll see what else can be done


I felt the overall penalty was too high., especially in the opposed case.
White b2 b3 a4, black b4 c5
b3 is scored as a backward (ok)
b2 is scored as a double (ok) and as a backward (!?)

If you remove c5, suddenly no backwards at all (but 2 "unsupported")


`_` is only a convention, it's still just an identifier


I did not know it was a supported value. The GTFS [specification](https://developers.google.com/transit/gtfs/reference#routestxt-)  says that route types go from 0 to 7, being 0 a
"0 - Tram, Streetcar, Light rail. Any light rail or street level system within a metropolitan area".

I'll revert the commit if you say it is right.


-> there is no real way to ignore variables


For these use cases I usually use `local` directory located at the same level as `target`, which should be gitignored (so it does not show up when looking at local changes), but it is not cleaned automatically by maven.

I agree with @mswiderski that having reasonable default with the possibility of overwriting it is the best solution.


Switching to Jessie together with Kodi 15.0 Isengard would be the right moment.


Yes, I figured. This is still a WIP so I'll update the PR once tests are green.


Yep, I know - but pylint wants that convention to be used due to some
convention guideline ...
I think double underscore __ may work ? Lets see ...

On Wed, Jul 1, 2015 at 4:56 PM, Lasse Schuirmann <notifications@github.com>
wrote:

> _ is only a convention, it's still just an identifier
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/b368ffe946ac289e4632f53eed465876542a55c7#commitcomment-11951064>
> .
>


When the 'result[0]' is success we can be ensured that result[1] has not been set. That is why it is not immediately returned and was written so to be consistent with the code above in the try block.
We could maybe update the code in both places to immediately return in case 'retVal' is true?


What the 'waitForTask' method essentially returns is the status of the vCenter task. And based on this status, we fail or pass the CCP operation.
So when we check the state of the vCenter task and find that it has failed with a fault we throw an exception which is the case here. In case of a failure we have an if/else only for better debug logs.

Cancelling the task is secondary as it


Can you, rather than fallback, hardcode for vendor-id = ubiquity

and , for digest, vendor-id=samsung?

m

On 1 July 2015 at 12:22, Shankar Dhanasekaran <notifications@github.com>
wrote:

> @mosic <https://github.com/mosic> since we do not have the correct auth
> type needed for the camera, we are depending on fallbacks. So I am trying
> basic auth first and if it fails, trying digest auth. However, for the
> cookie based auth, the resulting url will still give 200 response and so it
> may not work here. some hackish way to identify cookie based auth will be
> to check if the ends with certain extension, say 'cgi' or the resulting
> response contains 'Invalid credentials'. Do you have any suggestion on how
> we can identify if a given url ONLY supports cookie?
>
> /cc @marcoherbst <https://github.com/marcoherbst>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/shankardevy/evercam-media/commit/a9da540242e7e6ebcb73e487bb11f2328880b51f#commitcomment-11951001>
> .
>

--
Marco Herbst
*Evercam.io <http://www.evercam.io/>* - Cameras Unleashed
Mobile: +353 86 196 0451
Skype: marco.a.herbst


I would use Knockout also to deal with column visibility, it looks fine, but try to use a pure knockout approach next time in order to simplify the code.


This also present texture export fix #110.


Thanks a lot ! It solved my issue.


when smbd change form name in html you will have erros in controller. hidden dependency on view part


The result should be a 2D-array as in the other maximizers.


I think that it is also possible to use a pure Knockout approach for these three methods.


since we use maven to run this we do have control over if we want to remove the previous data or not (using mvn clean execute... or mvn execute...). Issue I see with other folders maven is now aware of is how you distinguish which data comes from which execution? By timestamp only?


On line 11:  'grovepi' imported but unused

This is kind of flake8 bug...  but i guess you should fix because it is not a good idea to have the same name for diferent things.

```
# It should be:
import grovepi as GPi
# And then replace all grovepi for GPi:
# On vim: %s /grovepi/GPi/gc
```


Don't see why there should be any need for anything else than html, and I can not recall seeing any SEO rewrite using anything else. Why would that be needed Michael, is it something worth spending time on?

If a choice is needed it should probably be only between the normals (html/php/aspx...), and not some weird custom ideas (text field)...


`angular.extend`


A -> An object


Login command has been deleted due command has security issue


So the way I tested this is by opening one of the test scenes in cmftStudio, then going to environment/edit (in the right column). In the panel that open when pressing edit, the radiance cubemap is a good example because it has several mipmap levels. No matter what format I try (.dds or .ktx) I can't get the right mipmaps in Cinder.

In Cinder I tried this in the cubemapping example where I just changed the loaded asset and the "texture" to "textureLod( ..., 5 )" in the shader.

I know .dds can be a pain to work with. I'll see if I can add some logs here and there in the code to see what's going.


Merhaba,

Lütfen bundan sonra github'ın kendi uygulamasını kullanını sync işlemi yaparken. Bu commitde de görüldüğü gibi benim yaptığım tüm değişiklikleri merge etmek zorunda kalmış ve bazı bölümleri çalışmaz hale getirmiş. Gerçi sonradan düzeltmişsiniz ama boş yere vakit harcamaya gerek yok. Eğer github'un sync tuşuna basarsanız o hiçbir sıkıntı olmadan eşitliyor zaten. Fark etmediğimiz bir yerde comment etmesin sonra sıkıntı olur.

İyi çalışmalar


I think it won't compile and generate the gcm_defaultSenderId string in values.xml. Which we are referencing in the code. @peterbartos  ?


It is a extended GTFS type: https://support.google.com/transitpartners/answer/3520902?hl=en


Nice!


On pingo/rpi/__init__.py

no newline at end of file


I have an error:

ERROR	'Handler Poweradminurt42Plugin could not handle event map changed: ValueError:  is not a boolean value [(\'/home/ptitbigorneau/b3-1.10/b3/parser.py\', 1411, \'handleEvents\', \'hfunc.parseEvent(event)\'), (\'/home/ptitbigorneau/b3-1.10/b3/plugin.py\', 344, \'parseEvent\', \'"""\'), (\'/home/ptitbigorneau/b3-1.10/b3/plugins/poweradminurt/iourt41.py\', 1041, \'onGameMapChange\', \'self._matchmode = matchmode.getBoolean()\'), (\'/home/ptitbigorneau/b3-1.10/b3/cvar.py\', 107, \'getBoolean\', "raise ValueError(\'%s is not a boolean value\' % self.value)")]'

my solution to solve this error:

matchmode = self.console.getCvar('g_matchmode')['value']
if matchmode:
    self._matchmode = bool(int(matchmode))


I knew I forgot something.


It didn't work without it - the gcm_defaultSenderId string is generated with this plugin and the string is referenced in GcmHelper:176. We could maybe create an empty string there and the plugin would then override the string? In that case, it would not be needed.


:+1: for configurable `default_variant` :rocket:


This commit is missing the MAd `ActiveWorker` `start()` call


[Here's two cubemaps](https://www.dropbox.com/s/cjvv3te3tj0hlgv/Archive.zip?dl=1) exported that way.


I would think it is ok to just translate stateString


Also reset on closing the appointment form.


Still looks like this is occuring, but not to the same extent, granted, still definitely occuring.
Before I recompiled the plugin, it seemed like random timers would just start going haywire, after complitation it seems it only repeats the timer a bunch of times in ONE second instead of totally locking up.

Log: '[01/07/2015 07:21:30] Random weather set to ID 2
[01/07/2015 07:21:30] Random weather set to ID 0'
Repeats about a thousand times over the course of only 01/07/2015 07:21:30(1 second).

Code:
task HourlyTimer[3600000]() //hour
{
	RandomWeather();
	timesync = 1;
}

stock RandomWeather()
{
	new fine_weather_ids[] = {0,1,2,3,5,6,10,11,13,14};
	new foggy_weather_ids[] = {4,7,9,12,15};
	new wet_weather_ids[] = {8,16};
	new next_weather_prob = random(100);
	new weatherid;
	if(next_weather_prob < 70)
	{
		weatherid = fine_weather_ids[random(sizeof(foggy_weather_ids))];
		SetWeather(weatherid);
	}
	else if(next_weather_prob < 95)
	{
		weatherid = foggy_weather_ids[random(sizeof(foggy_weather_ids))];
		SetWeather(weatherid);
	}
	else
	{
		weatherid = wet_weather_ids[random(sizeof(wet_weather_ids))];
		SetWeather(weatherid);
	}
	switch(weatherid)
	{
		case 4, 15:
		{
			SendClientMessageToAll(COLOR_TAN, "[WEATHER ADVISORY] --- Weather expected to be partly cloudy. Drive carefully!");
		}
		case 7, 9:
		{
			SendClientMessageToAll(COLOR_TAN, "[WEATHER ADVISORY] --- Weather expected to be cloudy with low visibility.");
		}
		case 8, 16:
		{
			SendClientMessageToAll(COLOR_TAN, "[WEATHER ADVISORY] --- Weather expected to be cloudy and rainy with low visibility.");
		}
	}
	printf("Random weather set to ID %i", weatherid);
	return 1;
}


The problem is that I couldn't get it compiled with API 10 - is that config necessary?


you could use a check if you are in your workspace or not for things like this so you don't forget to enable/dissable them


This solution is not very correct. The getBoolean value should already handle this situation. Can you post the value of `g_matchmode` cvar?


How about adding only this string into the library? With a comment that it will be overwritten by the gradle plugin in app.


Even weirder is, I switched back to the old package, have cleared my google play services and play store, but still my phone is considered to be 'incompatible' with those apps. Even though I can install them now succesfully via Titanium Backup :/
Weirdest shit ever...


It's in devel, so should be in the upcoming 2.0 release.


1: M100 needs more reviewers
1: M101 signature is missing


3: M190 line is too long (77 > 72)


1: M111 unrecognized component name: legacy


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2013


Hmm, we definitely could go this route, where we have one test for both key type registration checks. I was expecting a separate test for each key type though, e.g., `test_public_key_register_get_destroy` and `test_private_key_register_get_destroy`. This may cause a problem down below.


1: D100 Missing docstring in public module
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I100 Imports statements are in the wrong order. from invenio.modules.access.local_config should be before from invenio.utils
41:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.modules.access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio.modules.access.control should be before from invenio.modules.access.engine
43:1: I201 Missing newline before sections or imports.
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio_records.api
44:1: I201 Missing newline before sections or imports.
45:1: I101 Imported names are in the wrong order. Should be page, pagefooteronly, pageheaderonly, warning_page, write_warning
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
49:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webuser
51:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
52:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, create_navtrail_links, guess_primary_collection_of_a_record, record_exists
53:6: E126 continuation line over-indented for hanging indent
56:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio_records.access
56:1: I201 Missing newline before sections or imports.
59:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
61:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio.modules.collections.models
66:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
66:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
66:1: E402 module level import not at top of file
67:6: E126 continuation line over-indented for hanging indent
73: D101 Missing docstring in public class
75: D102 Missing docstring in public method
111:90: E203 whitespace before ':'
113:29: E127 continuation line over-indented for visual indent
113:94: E502 the backslash is redundant between brackets
113:75: E203 whitespace before ':'
113:91: E203 whitespace before ':'
117:56: E502 the backslash is redundant between brackets
118:45: E127 continuation line over-indented for visual indent
118:49: E251 unexpected spaces around keyword / parameter equals
118:51: E251 unexpected spaces around keyword / parameter equals
147:17: E266 too many leading '#' for block comment
148:17: E266 too many leading '#' for block comment
166:13: E266 too many leading '#' for block comment
190:37: E266 too many leading '#' for block comment
191:37: E266 too many leading '#' for block comment
194:45: E128 continuation line under-indented for visual indent
201:107: E203 whitespace before ':'
203:37: E122 continuation line missing indentation or outdented
203:102: E502 the backslash is redundant between brackets
203:83: E203 whitespace before ':'
203:99: E203 whitespace before ':'
204:41: E128 continuation line under-indented for visual indent
239:13: F841 local variable 'cc_id' is assigned to but never used
265:25: E128 continuation line under-indented for visual indent
265:79: E502 the backslash is redundant between brackets
266:41: E127 continuation line over-indented for visual indent
267:54: E502 the backslash is redundant between brackets
268:25: E128 continuation line under-indented for visual indent
270:25: E126 continuation line over-indented for hanging indent
277:25: E127 continuation line over-indented for visual indent
278:25: E127 continuation line over-indented for visual indent
279:25: E127 continuation line over-indented for visual indent
280:25: E127 continuation line over-indented for visual indent
283: D400 First line should end with a period (not 't')
283: D205 1 blank line required between summary line and description (found 0)
283: D208 Docstring is over-indented
295:1: E302 expected 2 blank lines, found 1
295: D210 No whitespaces allowed surrounding docstring text
295: D202 No blank lines allowed after function docstring (found 1)
295: D400 First line should end with a period (not 's')
304:13: E203 whitespace before ':'
311:13: E266 too many leading '#' for block comment
323:17: E266 too many leading '#' for block comment
338: D101 Missing docstring in public class
342: D400 First line should end with a period (not 'd')
342: D200 One-line docstring should fit on one line with quotes (found 3)
363:22: E126 continuation line over-indented for hanging indent
363:50: E203 whitespace before ':'
364:55: E203 whitespace before ':'
374:9: E122 continuation line missing indentation or outdented
427:96: E128 continuation line under-indented for visual indent
438:50: E502 the backslash is redundant between brackets
458:5: E128 continuation line under-indented for visual indent
466:26: E251 unexpected spaces around keyword / parameter equals
466:28: E251 unexpected spaces around keyword / parameter equals
469:111: E502 the backslash is redundant between brackets
469:34: E251 unexpected spaces around keyword / parameter equals
469:36: E251 unexpected spaces around keyword / parameter equals
470:37: E127 continuation line over-indented for visual indent
471:25: E251 unexpected spaces around keyword / parameter equals
471:27: E251 unexpected spaces around keyword / parameter equals
472:24: E251 unexpected spaces around keyword / parameter equals
472:26: E251 unexpected spaces around keyword / parameter equals
477: D202 No blank lines allowed after function docstring (found 1)
477: D400 First line should end with a period (not 'e')
477: D300 Use """triple double quotes""" (found '-quotes)
492:16: E127 continuation line over-indented for visual indent
496:35: E128 continuation line under-indented for visual indent
497:35: E128 continuation line under-indented for visual indent
507:13: B901 blind except: statement
513:13: B901 blind except: statement
518:17: E128 continuation line under-indented for visual indent
519:17: E128 continuation line under-indented for visual indent
520:17: E128 continuation line under-indented for visual indent