When we talk about measuring witch one is more real, online or offline reality, we get to an impasse, we are used to think that the existence of one fights with the other, and by ourselves create conflicts. We see these concepts as opposites, but if we try to have a bigger picture we can realize that one makes the other better, and that in fact they don´t necessarily try to have everything for itself. It is necessary to make a deeper analysis, taking into account that the idea of one replacing the other would lead to the lack of context for the contemporary history.


definitely a code smell. definitely going to break.


done


@andrewisplinghoff should be fixed with commit
https://github.com/shopware/shopware/commit/b9f75caac872c168b58f667f61484269177c37ca

Thanks for your help.


Thank you


This should be in trademark-policy.html


This should be in privacy-policy.html


Just a suggestion: Add new selectors to the bottom of each list, regardless if there's place for them. That way, the old styles accumulate on top of the lists and it's easier to purge old styles later :)


JOKer Under WOrlD


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.764.2f4bee61b582b5f77afb30722a59bb4c76554bfd](http://build.palaso.org/viewLog.html?buildId=59736&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 377, ignored: 3 Build time: 00:02:56


You should amend this commit to add the models/__init__.py file


For those curious about this change.  While i liked the attribute of Sets in which it maintains uniqueness of all objects added to it's internal list, the other characteristic of a Set is that it doesn't guarantee order.  So, that is why our custom items were showing up in random order in the inventory window in Creative Mode.  Moving to an ArrayList doesn't guarantee uniqueness, but it does guarantee order.


I think there's a small mixup with the descriptions there ;)


I think it's messy and I am wondering if there's a better way to do it!


Would it be unreasonable to have one selector per line? A tool like [CSScomb](http://csscomb.com/) could help with that.


TeamCity xBIM :: XbimExchange :: Build [Build 368](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2060&buildTypeId=XBIM_XbimExchange_Build) is now running


LOL I remember you suggested that before, my OCD hates big gaps... so that urge took over.

I might just go through the whole thing and reformat the lines to remove the gaps - without rearranging the selectors.


the hint seems very large and readability could be improved by a background. if I press the button while the hint is displayed, the hint loses its focus, disappears, and there is no mouseup event on the button, thus the form isn't being sent


Oh yeah! :+1:


Not much to say, just moving things around.


Type is a reserved word in python, it needs to be changed


Ack'd


@mbernat The only thing to discuss is the format of log messages. You don't needs to read the rest of this commit ;-)


Will also address this in the next commit.


These two could be compute fields.


@Gilbert09 these are all explicit changes


Should use single quotes rather than double!  I will be adding in a jshint to the code soon!


This commit was breaking the format due wrong indentation. I already fixed it.


Yes,  thanks Pablo! I tried a lot to fix it: rearrange immutable structure, components, read docs, etc.. But not submit button ) omg..


shouldn't this be:
*fp = SDS_TYPE_5 | ((oldlen+incr) << SDS_TYPE_BITS);
len = oldlen+incr;
(adding 'incr' not '+1' in both lines)


Merge all this into a [compute field](https://github.com/nbessi/odoo_new_api_guideline/blob/master/source/fields.rst#computed-fields)


Could you please use [`.on('click')`](http://api.jquery.com/on/) instead?


I like this idea, and I like the deflate option.  I would be happier, though, if there was a way of guaranteeing that the 'deflate' option and the 'netcdf_format' option were consistent with each other.  For example, what should the code do if the user specifies 'netcdf' format and 'deflate' of 3?


@agorrod, I meant to put this on a branch for review, and then pushed it into the wrong tree.

It's just a minor cleanup; Alex, would you please do a fast review and make sure it's OK?


TeamCity xBIM :: XbimExchange :: Build [Build 369](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2061&buildTypeId=XBIM_XbimExchange_Build) is now running


TeamCity xBIM :: XbimExchange :: Build [Build 368](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2060&buildTypeId=XBIM_XbimExchange_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:03:20


Cool, it is for sure messy in my opinion and for sure could probably be broken out into more discreet steps.  I'm just about to start my day so I need to dig into my own code problems but I'll try to allocate some time today to dig through it.


This is replaced by the package from salsaflow itself.


i took a stab, please review


Oh nice. I might have  a use case for this in a bit.

On Wed, Jul 15, 2015 at 11:20 AM, Ben Welsh <notifications@github.com>
wrote:

> It's still very rough, but take a look at django-postgres-copy
> <https://github.com/california-civic-data-coalition/django-postgres-copy>.
> My goal is to make the kind of thing we're doing here as easy as possible.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/california-civic-data-coalition/django-calaccess-raw-data/commit/8e6749932b711c8ce3921a00f27cf4d1fa82d4bc#commitcomment-12181728>
> .
>


Just a helper to instantiate GitHub API client.


I've been using node like that. However, the problem with this file in particular is that the blocking calls happen inside a for loop and there are many blocking calls inside the body of the loop. It might be possible with async or another similar library but all the libraries that I've looked at seem to be hacks that try to cover node's deficiencies.


Very thorough, very good :+1:


Faz a validação ou a importação?


You forgot a *)*


the indentation here is a bit hairy, in general we are using `two spaces` for javascript, css/less and html files


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


...See my comment on the previous commit (https://github.com/dchandan/PyReshaper/commit/d0de582315df8a4725505a30d62e498d1d98ab08)


this should be assigned to PLATFORM, then given default values in the setPlatformConfig call a few lines below.  You can just set the default to 'Search', which will default all platforms to Search.

The way it is now, the placeholder would be empty unless someone explicitly set it, thats why we need to implement it as described above.  See the other configurable items for an example.


use `const` over `let` - changes to style guide are forthcoming


Of course I did


because `main` requires `app` and `record_tools`, you can remove them from here. r.js will discover them automagically.


Missed to mention in the commit message:

Problem #1 is fixed in this change. i.e. 1. Myriad's code is changed to use the new NODE_RESOURCE_UPDATE_EVENT to update NM's capacity.


@pbeeler You linked a script from Gitlab.  I never said you left Github.  I
said "go back" to Gitlab (where you linked the script from) where you will
find all of your friends who marvel your penchant for nonsensical tirade.
On Jul 15, 2015 08:38, "Saber-Dev" <notifications@github.com> wrote:

> @drgroovestarr <https://github.com/drgroovestarr> I never left github in
> the first place. Where do you get your information from?
>
> @Cl3Kener <https://github.com/Cl3Kener> The only thing in AOSP is gcc
> configuration which is not exactly to the tee like yours or SaberMod's. And
> you came up with the renamed sysroot all by yourself right? GTFO.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/drgroovestarr/linaro-scripts/commit/0200814c2afa0b0b94bab51e93032b478f100eb2#commitcomment-12182245>
> .
>


TeamCity xBIM :: XbimExchange :: Build [Build 369](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2061&buildTypeId=XBIM_XbimExchange_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:03:10


Clicking on the date will launch update. Still no idea why date, 'html psychology' or not Jerry lol


probably. i'm going to leave it for later though.


But is this the kind of thing Code Review is meant for?


The placeholder will need to be added to the templateConfig in the filterBar service, otherwise this will be null :-( .


It is impossible to disable the 'force login' feature after having enabled it without removing the 'cas_force_login' row from the database as the value returned from the DB will never be false.


i suppose this makes sense, but it will break for many mod descriptions due to them using the current
 filename.. you could do with adding a fallback otherwise this is unlikly to get approved :)


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Thanks. It's already fixed in master.


I think one per line would result in something like 8k+ lines. Not a fan of scrolling, really :)


Ah you're right. I didn't realize that in PyReshaper the verbosity controls who prints to the stdout.


is there accessors instead of getting _elements ?
it's better to uses accessors instead of gettigns 'private' data directly


Do not define each file manually, its path will do it for you.
```javascript
define(function(require, exports, module) {
    var $ = require('jquery'),
        bootstrap = require('bootstrap'),
        modal_list = require('hgn!./templates/modal_list')

    // you should really export something, it's a library.
})
```


Unfortunately, the test with 16 Threads is doing bad. :-(
And I expected a positive effect especially with many cores ...


This is not true.  It just ensures their ACCRUED claim blocks are never less than the default.  If the code said "if TOTAL claim blocks are less than initial, set TOTAL to initial", then that would be wrong, because players can spend blocks to reduce their total.  But there's nothing a player can do to reduce his accrued blocks.


This falls into the conversation we've had before but not sure if we have arrived at a concrete consensus.  Would prefer to have `let returnValue = null` assignment.  Then Line 117 be `returnValue = 'text-right' and line 120 to be `return returnValue`.  "returnValue" could be named something else.


Works on iOS 8 + 9 ?


That's fair enough.  I like this change, and I agree the str.format syntax should be used.  I think this commit should be made to the code.


Lines 6 is valid ruby:
```ruby
self.per_page=(50)
```
though leaving the parentheses off would be more conventional for a setter `=` call:

```ruby
self.per_page = 50
```


done


Why adding bodyHandler here if you remove it from VertxNubes ? Can't see the point.


@fna this looks good to me.


This falls into the conversation we've had before but not sure if we have arrived at a concrete consensus.  Would prefer to have `let returnValue = null` assignment.  Then Line 76 be `'column-' + (
                    sortAscending ? 'ascending' : 'descending'
                );' and line 81 to be `return returnValue`.  "returnValue" could be named something else.


For backwards compatibility, could we leave it as a noop in this release with a warning, then disable in next release?


I guess it was experimental anyway wasn't it... probably doesn't matter...


e


Oke :3


@Ephemerality oh really? well them maybe TRUE-developerss would be so greatful to explain a bit to those poor non-devs?


@crazyR14
I am changing the description file name for texture packs, not for mods. This change would only effect texture packs. I have not heard of even a single texture pack that uses "info.txt", so there should be few texture packs if any at all effected.

I could add in a fallback to the old convention if people think it is worth it, but I don't really know if any texture packs use the old method at all.


Small comment. I would replace this with:

    For details on this calculation, see `here <...>`_.

Also: is there a line-break in the middle of that link? I don't think it would work, so please don't wrap this line to 80 chars.


better late than never I suppose ;)


+1 for reformatting the lines to wrap at a fixed char count like 80 or 100. Over time, there will be unavoidable gaps. Maybe there is a `grunt` module to handle reformatting like that :)


The apostrophes are not needed


I'd have expected this to be in a minor version bump, since the contract for this method changed.


This part must be unittested


merged


reack


Index should be unique


Can the index be unique with such constraint ?


done


merged 2


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17982/testReport/) for this commit**


Can index be unique with such constraint on mysql ?


commit message :P


The error.jade need to be a fragment of view to show in others screens. I think that it's better than have a page with the errors and the toolbar.


Wow that's a bit of dickish comment.


El footer debe de permanecer igual en todo el sitio. Esta sección es para patrocinadores y organizadores, en este caso INFOTEC no lo es.


Why you don't use the toolbar?


También, eliminar el logo de INFOTEC.


This change is notable, as the mFileList.update() must be called if the filesystem has changed, and should be in the finally block.


增加会员快到期提醒。


if im not mistaken that file was designed to be read by texture database's etc. so anything that relies on that file would fail to work


@callumacrae yep, thought as much. We needed something to test IE8 though, but didn't think an entire shim was necessary so just dropped this in.


just a spacing fix.


Yeah, that's how I originally designed it.  I'd be willing to consider
changing the default behavior, if backwards compatibility could be
maintained.

On Wed, Jul 15, 2015 at 9:59 AM, Deepak Chandan <notifications@github.com>
wrote:

> Ah you're right. I didn't realize that in PyReshaper the verbosity
> controls who prints to the stdout.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dchandan/ASAPPyTools/commit/3338f8f238e724a411fb7b9138c1e94cd9577a0f#commitcomment-12182797>
> .
>

--
____________________________________________________________
Kevin Paul
The National Center for Atmospheric Research
Computational and Information Systems Laboratory
(303) 497-2441


chrome --no-sandbox --gpu-launcher='xterm -title renderer -e gdb --eval-command=run --args' , thats the recommended way to debug gpu process.


i want import


Reconsider making this a computed property that observes `options`, as there is nothing watching the result returned from `highchartsOptions()` in order to react to any changes in the configuration data.  Part of the consideration may be to implement such reactions.


@trentm Comments addressed in https://github.com/joyent/sdc-docker/pull/44.


done


This was screwing up metrics, not being called because it wasn't correctly overridden


commit


1.list updated via firebase
2.problem while adding new list on already exist object(firebase).


<?php
echo 'Something';
?>


this package.json is mostly a throwaway _but_ it's worth pointing out that this *is* the batch endpoint. It's the same endpoint; the difference is just whether the query is batched or not (by separating multiple queries with semicolons). @yhahn and I talked a little about whether a separate batch endpoint is desirable, but for now the only difference is the query format.


eliminar


test


The use of `const` is preferred over `let` in scenarios where applicable.  Associated changed to the style guide is forthcoming.


generateJSON(false) means clear the object after generating JSON. Calling getWifiCount() and the like afterwards was dumbo.


not going to attempt to in this pull req.


Es Cumbre Global, no sé porqué están cambiando los textos a Cumbre Mundial. El nombre es Cumbre Global de la Alianza para el Gobierno Abierto


i think so. VisibleForTesting is essentially private


For paginating the scenarios left to right I added controls in the footer and removed the horizontal scrollbar.  To move the scenarios left to right we need to calculate the cell width based on screen size and then adjust the #compare-container left value.  There are four widths of table cells based on screen size: 48vw, 32.5vw, 24.5vw, and 19.5vw.  So based on screen size we will need to increment the #compare-container left attribute by a degree of 48vw, 32.5vw, 24.5vw, or 19.5vw to move the scenarios left to right.


explains why


Why did you decide to remove VES? Since its the only viewers for Android PCL.


The extra cables on the connected to the EV-side modem is simply to allow for connections to external EVSE's, and is not relevant to the setup you are trying to make. The extra cables on the power supply is simply because the two modems are connected in parallel to the power supply (and is not especially relevant either).

SLAC is used for EVCCs to recognize which SECC they're connected to, since powerline has a tendency to propagate to unwanted devices. It works simply by generating a number of "sound packets" that propagate to all nearby SECCs. The SECCs then measure the signal strength and translates this to an attenuation value, since it knows the original signal strength specified in the standard. The SECCs then repliy with the attenuation characteristic, and the EVCC chooses to associate with one which is below a dB threshold specified in the standard. The association process is basically an exchange of network keys from SECC to EVCC, after which the EVCC can set its network key appropriately. At this point the SLAC association is complete, and the EVCC and the SECC are in the same IP-based network.

After this the EVCC can start doing the SECC Discovery Protocol (SDP) to discover the IP address of the connected SECC.


i just wanted to file a feature request until i found this.


:shipit:


Arg, indeed, projects.kee can have 400 characters... It's too bad !
In the same time, we really need to have this unique key to prevent any futur issue. :(


nothing comes to mind right away. it's a 1 liner anyway


можно не ходить по всем расширениям toolwindow, а использовать toolWindowManager.getToolWindow(Id)


¿¿hapi?? XD


Nodemailer?? :/


* Can't click inside circle
* Better use different colors for circles as well


LGTM thanks


Doesn't this sentence miss a verb?


Do you know what databases and such would rely upon the file being "info.txt"? It would be great if "description.txt" could be used across the board for description files for mods and texture packs.

I wasn't even able to figure out what file was used for texture pack descriptions until I looked through the source to find while file is called, so it would be great at least if the file name could be inferred to be the same as the one used for mods.


@jdegoes I had to change the types here a little to make this work out (switching out `pr` for `pl` in `InstalledState`), when you get a minute can you review to see if this still fits your intention?


* Clean up front end code


Why do you print that?


Ага, видимо в этих местах и вылезает альфа. Но не понимаю, почему твоя схема выводит правильно.


:+1: makes sense


I made it as short as possible because the rest doesn't really matter and the shorter it is the better maintainable it is :)


What is `.string` providing that is needed to facilitate this test?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The use of `const` is preferred over `let` in scenarios where applicable.  Associated changed to the style guide is forthcoming.


Hi,

I haven't forgotten you, but I am very busy.
I just quickly read the code and I have a question:
why dpi should modify the zoom factor?

I think correct the font size with dpi factor in ConsoleView::CreateFont would be more accurate.

I choose a zoom factor of 200%. I move the window and see a different number in status bar. It's curious.


But you check for output or did I get it wrong?


Esta relación no es necesaria, porque el Evento tiene una colección de tags, no queremos manejar relaciones bi direccionales en los DTO para no generar tanta basura.


I agree with what Mat said, better to encourage consistent version usage than to hunt bugs due to an out of date compiler.

Mat: One thing you could do to further reduce friction of gcc-arm upgrading is linking to https://launchpad.net/gcc-arm-embedded and noting that the user download something equal to or newer to "expected_version". Also, from a "user should upgrade compiler" standpoint, one quirk I noticed is that the version number the binary spits out via `--version` is different from what you'd expect from the download filename, i.e. the compiler in 'https://launchpad.net/gcc-arm-embedded/4.9/4.9-2015-q2-update/+download/gcc-arm-none-eabi-4_9-2015q2-20150609-linux.tar.bz2' returns '4.9.3 20150529', even though it's download file name is '20150609'


Talking about unnecessary lines, here's another one :)


Igual esta relación no es tan necesaria para que el DTO lo muestre.


Would it be simple to add a registry key to suppress the popup window which normally appears when IE's status bar is disabled?

I think a name like "suppress_statusbar_enablement_notification" would be clear.


Esta relación es innecesaria.


Yes, I see that after spending a bit of time with a fork of the project.  It's a bit of mind bender to have worked on an app that generates an engine cart for testing and then to switch over to engine cart that creates an app to test itself.  I'm not sure whether I'm looking at the horse or the cart ;-)


Discuss this here:

https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/1w5wAbclL78


# Config files


ugh... for debugging purposes one might think ^^ well, actually thats a very thoughtful algorithm behind it that relies totally on this print happening!


Why you exclude integration test?


PyLintBear will throw an exception on PyPy which we test so this output must either be empty or the PyLintBear warning


@fernandog @abeloin This is scary to me, but it fixes non-scene numbering. Does it look like it can break anything?


Should we just store formulae directly in the format of `user/repo/bar`(without `homebrew-`)? It's clean and can avoid latter unnecessary string manipulation.


This is not fixing the docstring test on deprecated functions `generate_stc` and `generate_sparce_stc`.
Anyone for help?


look all im saying is your changing `local infofile = current_texture_path ..DIR_DELIM.."info.txt"` so all existing texture packs that have that as the file name, will have to change it or else the file above wont recoginise it and also any other mods/texture databases etc. i do agree that it should be the same as mods. but for a short period of time there should be a fallback to give texture creators time to update there texture pack info.txt filename. etc


Esta relación esta demas ya que el evento tiene una coleccion de estos maes.


Maybe we should make a base class for integration tests, so that other features can be tested in different files. The base class would contain your coala execution code and maybe some helpers.


Esta relación esta demas ya que el evento tiene una coleccion de estos comentarios.


nope, I exclude the files holding the main routine, test is executed


done


Energía y agua (agua sin mayúscula)


How is the sort order managed?


eliminar el logo


> Maybe we should make a base class for integration tests, so that other features can be tested in different files. The base class would contain your coala execution code and maybe some helpers.

What I use here is specific to CLI and I'd do all integration testing for CLI in this file so far.


eliminar


hmm... since this is a basic test it's okay


Tratando de entender


eliminar logo


@cyberious - @Iristyle mentioned this doesn't need to be here at https://github.com/puppetlabs/puppetlabs-registry/pull/88#discussion_r34683375


I reverted back to 4.9.2. I don't get why 4.9.3 fails so I'll stay with the old one that worked.

About msys2, I'm still not bought it's mature enough. Sure, the current msys is ancient, but it works, or at least it worked up until now.

So basically, https://github.com/mpc-hc/mpc-hc/compare/64939c2...XhmikosR:develop


TeamCity xBIM :: XbimScripting :: Build [Build 23](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2062&buildTypeId=XBIM_XbimScripting_Build) is now running


un comentario sobre cada línea?


for real?


LOL on the comment :)

Since you don't seem to be sure why it is called 2 times, let me remind you that all watched expressions are called at least twice per digest, once to get their value and at least once more to ensure their value has stabilized (i.e. it hasn't changed again as a result of another watched expression being evaluated).

(Aaand we're happy Angular 2 is well on its way :smile:)


Hola @JRedentor tan pronto revises estos cambios por favor infórmanos

saludos!


nope.


TeamCity xBIM :: XbimScripting :: Build [Build 24](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2063&buildTypeId=XBIM_XbimScripting_Build) is now running


TeamCity xBIM :: XbimScripting :: Build [Build 23](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2062&buildTypeId=XBIM_XbimScripting_Build) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:50


if you're commenting something please consider twice do you need to commit it?


done


sí, claro, comentarios de comentarios


cc'd @barbeau


this is looking awesome, es7 from the start :D


TeamCity xBIM :: XbimScripting :: Build [Build 24](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2063&buildTypeId=XBIM_XbimScripting_Build) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:25


u put it in the wrong channel


actually it is beter for this test to rely less on whats happening in the inside because thats already covered by other tests


I think this change is fine, too.  And I like the idea of filename validation.

However, there are a few ways to do this.  One way might be to take the `output_prefix` as it was originally defined and split it based on base filename and the output directory.  For example, something like this:

```python
output_directory, output_file_prefix = os.path.split(prefix)
```

...and then continue to check for validity in the `output_file_basename` and `output_directory`.  Personally, I believe that the advantage to doing it this way is that you reduce the number of input arguments, which always makes it easier to use.

Also, is your filename validation cross-platform?  Will it work on both windows and unix-like systems?


I was thinking:
    annotations = defaults;


It'd be great if the legend interactivity for this example worked like this -> https://plot.ly/~agvd/240


I think `encode` can be called on non-unicode strings too, maybe just always call it?


You're right :)))


@tagforce can you check this please?


I'm not sure it is a good idea to have the same notification time for treasury and research in queue. In the end, we might want to change one and not the other as they are not as important.


Revert this, por favor.


Patch looks fine to me, and it makes sense if you don't have the bandwidth. I started playing around with it myself but I have Pontoon stuff that's more important right now. :(


so if I understand correctly PyPy prints nothing, it just triggers an exception?
But anyway I think the message is wrong, it can be empty but doesn't have to be^^


Yeah, looks like a typo on my part, these types look correct.


@robertmesserle, not so fast, my friend :)

That test does _**not**_ actually check that the same `timeoutId` is returned every time.
Sorry :disappointed:


when method name starts with `Check` I expect checking result, `bool` for example,
but you method is adding message to modelState


Yeah i was unhappy about the code duplication too. My thinking was this: having argparse would allow for providing more interesting control possibilities in the script in the future, but while these are being added those using 2.6 would continue to be able to use the code. When in the future the project wishes to move away from supporting 2.6, that section of the code can simply be discarded. Does this make sense to you? Also how strongly do you guys wish to support 2.6?


this looks weird. You're creating a new list and passing it a list that's created with an array of 1.

this should be:
```
defaults = Arrays.asList( new SpelAnnotation(PreAuthorize.class.getName()) );


seems good


done


Ah ok, great. I thought I might have been missing something as they were flipped in both `installR` and `installL`.


oh yeah sorry the tests reside in a tests directory...
but why do you exclude those? only `*Test.py` is executed


law Demeter violation
https://en.wikipedia.org/wiki/Law_of_Demeter


@tdhock This should take care of the `ggthemes` dependency


nope, is shouldn't print anything. *EXCEPT* PyPy because the *PyLintBear* will throw an exception and that will triger the warning that is *catched* here


then nvm


2014... you sure?


this is the ignore list for coverage


This was fixed up in the latest commit, the beaker logic is now just

`gem 'beaker', *location_for(ENV['BEAKER_VERSION'] || '~> 2.2')`


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (652 of 652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.49%25-green.svg)


r+


why just PyPy raises such an exception? :O


I need to check can a performance issue appear here...


Hi, When will this be published in the plugin? Have to create this manually every time.


because PyLint doesn't support pypy


Should be 'iOS' shouldn't it?


ah okay :)


not worthwhile i think, it's just 2 places and the messages are different


when you create constructor that takes null as param, consider about create more concrete constructor, without nulls


whats the channel name? correct it


done


Thanks for the explanation!

However I think it is easier if the first switch should return false as default:
                t->driver = "STM32F09";
                block_size = 0x800;
                break;
+       default: return false;
        }
        if (t->driver) {


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17983/testReport/) for this commit**


let's keep this in mind but postpone ok?


Hm, this is not a good approach actually.
Since the output format is so simple (just a couple blocks of lines), you know precisely how to read it too:
`parse = { parseTitle(); parseInfo(); parseCommits(); parseBlockers(); parseUser(); }`
where each function consumes a few lines a returns the data contained therein. This is reflected in your states too, you always go directly from one to the next in a linear order.

Doing this via state machine only complicates everything and doesn't bring any value (i.e. you wouldn't be able to parse anything more complicated with this code anyway; for that you'd need an actual grammar-based parser).


First, this would be better expressed as a lambda.
Second, this assumes that the defaults are always added if not specified. I don't think this is the maven way. Instead, you should allow the user to either configure their own settings or use the default. This means that they'd have to repeat the config for the default annotations but I don't imagine having a lot of them since they are domain specific.


ack but we first merge mine if you ack it ;)


the loop


I stand by my meta-assertion that if you're operating that close to the
bleeding edge of the compiler, you're asking for trouble. Been there. Done
that. Regretted it.

Also expect the community to grumble about it also, so a FAQ entry _might_
save you some heat.

On Wed, Jul 15, 2015 at 11:19 AM, Joe Goggins <notifications@github.com>
wrote:

> I agree with what Mat said, better to encourage consistent version usage
> than to hunt bugs due to an out of date compiler.
>
> Mat: One thing you could do to further reduce friction of gcc-arm
> upgrading is linking to https://launchpad.net/gcc-arm-embedded and noting
> that the user download something equal to or newer to "expected_version".
> Also, from a "user should upgrade compiler" standpoint, one quirk I noticed
> is that the version number the binary spits out via --version is
> different from what you'd expect from the download filename, i.e. the
> compiler in '
> https://launchpad.net/gcc-arm-embedded/4.9/4.9-2015-q2-update/+download/gcc-arm-none-eabi-4_9-2015q2-20150609-linux.tar.bz2'
> returns '4.9.3 20150529', even though it's download file name is '20150609'
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/spark/firmware/commit/bcd4e51f74f7b2a59bc24b641895b602193d0921#commitcomment-12183297>
> .
>

--
Andy


`err.message` would be cleaner.


it's a "private" method


If we're notting what the function should do, we should not what the function actually does :stuck_out_tongue:


You could use:

 for (var i= 0;  i< gridheight - 2; i++)

then you wouldn't need the (i - 2) inside the loop


Basically this was forcing every show/episode to be processed and renamed to scene numbering, even if the user set the scene numbering to unchecked in the show.

But, what happens if a user does not have scene numbering checked in the show, but the releases are in scene numbering? Will they start getting the incorrect episodes?

I have noticed the occasional reverse situation, where a show is not scene and was PP incorrect, which this fixes.

As it is now, the scene numbering setting by the user is auto overwritten when adding a show if the show has scene numbering on xem, or when updating a show.

So probably this might be safe, but I'd like to be as close to sure as possible.


重新修改了代码仔细看下


现在是新版的了


I think this has some unintended effects... If I have the production screen open and the sitrep window is open in the background, I want to close it to see the map better. But when I click the X of the sitrep window, it closes the production window and leaves the sitrep open.


Maybe it would be good to identify the source of the error: `('strong-supervisor: lost connection to control channel: %s', err.message)`


@drgroovestarr yeah.l, I'll get right on that...


ack


Resolves #5


What we can do is make output directory an optional argument. If it is specified then the files are written to that folder, otherwise the prefix would be expected to have the full path and the basename prefix and then continue to check.

I think the validation is cross-platform. Some symbols such as ~ are legal for filenames, and others such as ":" are legal on Macs, but these are such fringe cases that i've included them all just to ensure that only reasonable looking filenames can be produced.


I was testing the changes I made to how the compounds are sorted in the Reaction.pm code, and the impact of this change is reflected in the reactions.master.tsv database file. The intention was to ensure that the sorting of the compounds, when printing names in an equation, was identical to that when printing just identifiers. It appears to have worked.


this should be the same hadoop version used by the rest of phoenix. The top level pom defines the `${hadoop.version}` property that you can use here.


shouldn't you throw if you get down here and there were errors reported?


Resolves #6


```off``` is used only for BUG_ON statement, so there is no sense to introduce ```data_off```, just use ```off```


Look's like you're missing one closing div here. :eyes:


so, we always get a call back with a valid id and then an invalid sequentially ? is gettting two call backs with valid ids back to back is an error ? I see that you have DCHECK which tests that selection offer is null before passing the new offer.


error instead of warn, unless that immediately halts execution


Instead of doing this can we just hide the Add Block menu item at the area level when this is the case? That's how we always did it before.


this code is
if (X1 && !Y) return false;
if (X2 && !Z) return false; <-- different X !
return true;


Yeah, that's the problem.  We actually have some supercomputing systems with admin teams refusing to install updated version of Python!  And the system default is 2.6 on those systems.  It's a little frustrating, frankly.

I think we might have to do a little research to find out the current status of our 2.6 customers.  I feel like 2.7 should be the standard everywhere, and if we can enforce a 2.7 requirement, then I think we should do that.  Until then, I guess I'd be fine with these changes, as long as they are temporary.  (Of course, I've thought that changes were "temporary" many times in the past, and never had the time to properly fix them.  I don't want that to happen here.)


'private' method


ここでDummyUserFormを表示することを期待しているが表示されない．おそらくDummyUserFormViewModel と view のDummyUserForm が 紐付いていない


@jcscottiii one very nitpicky thing to make this more idiomatic. Can you just return here the dbAdapter and remove the else statement?


 `Tool` and `ToolRunner` are shipped in the hadoop-common jar, as seen http://grepcode.com/file/repo1.maven.org/maven2/org.apache.hadoop/hadoop-common/2.6.0/org/apache/hadoop/util/Tool.java?av=f

This dependency should be `<groupId>org.apache.hadoop</groupId><artifactId>hadoop-common</artifactId>`.


add a todo here to see how we can restrict the search of the reflections api to configured packages. If the user configures a set of package names, then we should limit the search to those names.


let's postpone this


can we extract this func definition to a normal func declaration?


might want to drain the work queue  before stopping the thread pool? i.e.

```c
req_wq.drain();
m_tp.stop();
```


Is it right location?
In init.geehrc.rc there is 'service fm_dl /system/bin/sh /system/etc/init.gee.fm.sh'.


likewise, `commons-logging` is defined in the top-level pom, so this will inherit it's details. In this case, it means this `scope` line can be omitted -- it's sufficient to specify the groupId and artifactId.


Should the title be localized? I think that if you load the right title here, you can get rid of https://github.com/jpruden92/gaia/commit/4372c6f03e1b51e60fa3a1e548dd0c8df5886851#diff-8064e67350b1ac4c84187c9a52e045dbR69


this要らない気がする。


great! Once the `Tool` interface is established and the below code uses `getConf()`, users will be able to override the port this service listens on by specifying `-Dphoenix.traceserver.http.port=XXXX` at the command line or by providing the property in their hbase-site.xml file. This is what we want.


@gkalpak Ah, I thought you meant a general test for the method (which was still missing) - still tweaking, will add a test for that as well.


If you are retrieving the categories, why not use `this.site.categories`? They should be in there without having to call `list()` right? Or is there some extended information you need?


Great. Hoping to have it up on PyPI today.


Why did you downgrade the cabal-version requirement?


i'm not doing any changes to v1 in this PR, so I'd rather not. If the diff algorithm were smarter you'd see there aren't that many changes :(


I'm not sure we do need it. We were talking about how it would be preferable to be able to show as much data as possible before getting the whole manifest, so there is some progressive disclosure to the user as they wait. I think that's taken care of by the title, however.


I was using that!


`supress` should be `suppress`.


@hjwsm1989

- could you split this commit into two? one for the wq drain things, and the other for the bucket name.
- iiuc, this fixes the issue described in http://tracker.ceph.com/issues/3896 right? if yes, could you please label the one which drains the work queue with "Fixes: #3896"

thanks.


Have you check if the UI is working fine when the list of Contacts to match is a large one? Please try this scenario and confirm that the scroll is working as expected.


Don't use `System#property(String,String)` anymore. Because this class implements `Configurable`, you should use it's `Configuration` instance (http://hadoop.apache.org/docs/r2.6.0/api/org/apache/hadoop/conf/Configuration.html).

What you want here is something like

`final int port = getConf().getInt(TRACE_SERVER_HTTP_PORT_KEY, DEFAULT_HTTP_PORT);`


Is this spec no longer in last call?


Breh lol you pushed the "whaMainActivity"


make this an `int`, to work with `getConf().getInt(String, int)` below.


I know, right? There's just something about "plz" that really gets me going.
If you happen to have a mod installed, or the ability to write one, that supports moving your cells individually, this enables that functionality.


can we extract this func too?


v


commit comment is pretty good...
as a team member I would like to know what exactly was done in this commit and what task it's related to


Documentation links for the RegOpenKeyEx calls:

https://msdn.microsoft.com/en-us/library/windows/desktop/ms724897(v=vs.85).aspx

https://msdn.microsoft.com/en-us/library/windows/desktop/ms724878(v=vs.85).aspx

Just for reference.


Ha perfect! Thanks!


Exercise 1: I made a menu using ul and li, styling with css.

Exercise 2: I did a layout using ONLY div and span, styling with css.

Exercise 3: I did a form layout using ul and li, styling with css.


無くてもダメでした :sob:


Much of the template, as well as of the parser, is identical for story and commit review issues. Should be possible to refactor, right?
I think the only difference is in the header (commit/story info), the commit list, blockers and user content should be shared.


@bbharris mentioned that SPIFlashes need a bit of time to initialize after enabling.

I was also encountering some intermittent errors when I enabled + sent commands immediately after, and this seems to have resolved it (as much as you can say something 'resolves' intermittent issues).

I can experiment with the value and see if we can make it a bit shorter.


Like above, instead of a java System property, use a Hadoop Configuration property. You can add a new key similar to `TRACE_SERVER_HTTP_PORT_KEY` (maybe `TRACE_SERVER_HTTP_JETTY_HOME_KEY`? I'm not familiar with the Jetty API to know why you're specifying/exposing this). Then you can use `Configuration#get(String, String)` to retrieve the value.


reack


Do we know why it's (still?) needed? I'm fine keeping it if we want and/or need to sanitize the input, but understanding why we might get spaces would be useful (and have corresponding tests).


Para replicar en todos los ambientes, hay varios ambientes con varios niveles de acceso y operatividad, no todos los desarrolladores tienen acceso, sin estos valores de catálogo no puede funcionar el sistema, por lo que el programador debe garantizar que exista. No puede depender de un operador. Posteriormente en producción se harán los movimientos que sean necesarios por el operador que se designe, mientras tanto no se puede depender de un operador para catálogos necesarios para la puesta en punto del sistema.


Please make all function documentation follow the standard: "Load creates a new client from a settings file". We all need to do this religiously. ;-)

http://golang.org/doc/effective_go.html#commentary


部分表述还是要仔细考量，有些用词建议调整，这部分内容较多，还是要逐句仔细在校订。包括后续内容，太困了，加班太晚，先睡了。

-->

提供一个轻量级、通用的访问权限控制框架。当今计算环境变得越来越敌对，为内核添加增强的访问控制模型可以改善主机的安全性并帮助服务器在恶意攻击中得以幸存。安全性研究已经提供了针对不同环境有效的多种不同类型的增强型访问控制。LSM 框架允许访问控制模型实现为可加载的内核模块。.


Looks fine!


I know it's a developing part, but I'd prefer to keep code readable after each commit,
if comment doesn't deliver any addition information in code I wouldn't like to see it at all.


The normal Go convention would be for this to be called `New()`. Go vet and go lint will probably complain about this.


You should be able to poll the status register to determine readiness. Better than a fixed delay.


This method is copy-paste from the other service. It's a shame we don't have anyplace in the project for such code to live. Please add a `TODO: share code with query server Main`.


Do we need to call `super` to check for properties from `PaymentInfo`?


I may be missing something, but I don't see parsing of the review blockers (which are included in the format above). One more reason to make this code shared with commit review issues.


ScoredOfferModel never will sent from client to server with post action so we don't need any validation attribute.
we need it only as a representation of offer with scoring


![gyazo](http://gyazo.com/68280a9797ae6b0d3207eb4bdd2227cb)

型がおかしい？


Thanks :)


variable name should not be uppercase, right?


Nice!


Yeah, I guess I'm just being picky.  I really don't like adding user-input options unless they are absolutely necessary.  It can really lead to UI bloat, which I'd like to avoid.

That said, the optional argument approach is fine with me.

As for the cross-platform validation, you appear to be correct.  I think it's okay to a be a bit more restrictive than the filesystem will allow, but it might be better to do a try/except instead.  Something like:

```python
...[validate the output_dir variable]

try:
    dummy_filename = output_dir + output_prefix + '_' + output_suffix
    open(dummy_filename, 'w').close()
    os.remove(dummy_filename)
except OSError:
    err_msg = "Output file prefix and/or suffix appear invalid.  Cannot create test file."
    raise ValueError(err_msg)
```

The only problem with this approach is that it doesn't tell you what is invalid about the filename!


Looks to me like you could shorthand these several lines to: `return ioutil.WriteFile(locateSettingsFile(), settingsContents, 0775)`


We technically don't have a use-case (yet?) for Ruby plugins supporting Sepa/Elv.


Actually,  I dont know what I have done... Is it ok? :)


Also why do you need the variable? Why ```skb``` is bad?
Please be careful with stack variables - please see the commit https://github.com/natsys/tempesta/commit/47d82a18f9fd124616fb571175a45fd24127de3e#diff-0a919ed70e9a8fc9bdfce5b5ee1e1e99R75


this is quite good but DRY is violated
form other hand, we need to consider do wee need separate viewmodel for it


@pbeeler Wow,  really? That's fantastic! I can appreciate that you are
passionate about your project,  but it is clear that your beef is with
@cl3kener. I respect your status as a seasoned dev and if I felt like I had
done you wrong, I would be the first to make amends and correct the issue.
I just don't think you should be treating others the way you do,  for
having any association with Uber or @cl3kener.
On Jul 15, 2015 09:34, "Saber-Dev" <notifications@github.com> wrote:

> @drgroovestarr <https://github.com/drgroovestarr> yeah.l, I'll get right
> on that...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/drgroovestarr/linaro-scripts/commit/0200814c2afa0b0b94bab51e93032b478f100eb2#commitcomment-12183638>
> .
>


done


The `run` method is where you implement what was previously in `main` method. This class needs a `main` that contains a simple invocation of the `ToolRunner` API, as is done in the javadoc to `Tool` that I linked you to earlier. Something along the lines of `ToolRunner.run(HBaseConfiguration.create(), new Main(), args);` Actually, it'll be exactly like what we have in https://github.com/apache/phoenix/blob/master/phoenix-server/src/main/java/org/apache/phoenix/queryserver/server/Main.java#L225-L228


you must be 1000000% sure you will never divide by 0.


:+1:

Could you add tests (see `TestAdyenPaymentPluginApi`)?


commented code always looks very professional, but no one reads it.


Can you please specify github logins for EACH of developers?


Given that current_user is a 'helper_method' we can use it directly in the view so we can avoid creating the username and token variables and call directly in the view current_user.username and current_user.token


Okay, yep I understand. I did some searching and found a handful of texture packs that do use "info.txt". So I will add in backwards compatibility for that as well, whereby if there is no "description.txt" then "info.txt" is used if it exists.


> One could argue that '1901-00-00' is not a valid date anyways, but ok :)

Wikidata use this kind or representation to encode years.

> Why not use Boost if std::tm is not enough?

I don't find in Boost documentation a simple way to encode year only or year-month dates in Boost. But maybe I've missed something in the documentation.


We'll need to fold this in to make sure we're using the same jetty version throughout the project. This will require more maven gymnastics so let's put it off for now. Please add a `TODO` comment here as well, and we'll open a tick to get it fixed after your initial commit is ready.


that's ok :)


No way lol. Sabermod is still the best to me, but somehow my kernels compiled with it won't boot, so I was doing some experiments with other toolchains.
Besides I tried to compile sabermod with some krait optimizations but the DAMN Gitlab would never allow me to clone repos! ;(
Still I'm looking forward to getting back to SM though.


not going to be easier to read i think


I made `URL` uppercase to avoid masking the `url` package, but if you would rather I use another name I can.


Hmm, seems like a problem in the design: each received skb must be processed by upcalls from SS to HTTP, so why ever we see unprocessed skb in the list? Typically the peeked skb is already processed.


Is there no `constexpr` calculation you can do to evaluate this?

OR, is there some way I can personally validate `491940000`?


good question. fixed now


if you declare `pushes = make(chan map[string]bool)` you can check it in line 196 with `if shouldPush[id]` rather than `if _, push := shouldPush[id]; push`


changes in comment is awesome, but no one reads it


I like this. Elegant.


that makes sense, add a comment that the backwards compatibility should be removed once all known working texture packs have updated etc. :D


They didn't but I'm happy to rename it.


They could be, but it may be nice to be able to override the parser directly only for a specific node type...


or even better:
```
RequestCreator load(String url) {
  return Picasso.with(MainActivity.this).load(url).error(R.drawable.warning).resize(400,400).centerCrop();
}
...
load(world.getThumbnailUrl()).into(mImageViewWorld);
```


To generate restfull routes it is a good practice to use the **resources** method provided by rails.

resources :users, only: :index

With the only and except option we can limit the routes we want to generate for the resource


The imports should be ordered as specified in https://www.python.org/dev/peps/pep-0008/#imports


yeah, true.


We will do it later. Actually, I dont know all links :).


why is `imageIDs` an array? if we use a map of ids this could be constant time.


Without a return statement in a Python function, a function returns ``None``, not Empty.


I was running the sklearn version and having problems with the covariance calculation: in the _do_mstep method in GaussianHMM I had values as 0.01/(small number), and it diverged (the 0.01 came from the prior default value).  I can see the problematic line has been modified to                 self._covars_ = (covars_prior + cv_num) / np.maximum(cv_den, 1e-5) but don't think the maximum addition would have fixed it, so what has changed in the code to prevent the behavior I was experiencing before? Thanks


New() or NewApp()?


yeah I just didn't change anything in v1 code in this PR, there's more I will have to do but I need this first PR in. For this specific change I can do it if that's what's preventing the approval.


In Underscore `_.isFinite('1')` is `true`
`Number.isFinite('1')` is `false`


Yuck, I hate that this is a weakly typed integer.  Not your fault, now I read through the code, that's what you are getting.

AND you have so much repeated code below:

    enableDirRestartFix (rippleCalc_.view.info ().parentCloseTime)

Why not pass `rippledCalc_` to `enableDirRestartFix()`?  Then the client code below would look like:

    if (enableDirRestartFix(rippleCalc_))


Hahahaha! Nice commitmessage!


Ok, main concern is to check if the file exists (not necessarily if it's executable), we're now just checking if it was provided or not.


I am thinking that you want to make it a buffered channel so that the send does not block: `make(chan bool, 1)`


Ok. Just don't forget)


Leave a line note


Apropos:
http://community.particle.io/t/toolchain-mac-clean-builds-failing-on-arm-4-9-3-linker-cant-find--gettimeofday/13293

On Wed, Jul 15, 2015 at 11:32 AM, Andy Warner <andyw@pobox.com> wrote:

> I stand by my meta-assertion that if you're operating that close to the
> bleeding edge of the compiler, you're asking for trouble. Been there. Done
> that. Regretted it.
>
> Also expect the community to grumble about it also, so a FAQ entry _might_
> save you some heat.
>
> On Wed, Jul 15, 2015 at 11:19 AM, Joe Goggins <notifications@github.com>
> wrote:
>
>> I agree with what Mat said, better to encourage consistent version usage
>> than to hunt bugs due to an out of date compiler.
>>
>> Mat: One thing you could do to further reduce friction of gcc-arm
>> upgrading is linking to https://launchpad.net/gcc-arm-embedded and
>> noting that the user download something equal to or newer to
>> "expected_version". Also, from a "user should upgrade compiler" standpoint,
>> one quirk I noticed is that the version number the binary spits out via
>> --version is different from what you'd expect from the download
>> filename, i.e. the compiler in '
>> https://launchpad.net/gcc-arm-embedded/4.9/4.9-2015-q2-update/+download/gcc-arm-none-eabi-4_9-2015q2-20150609-linux.tar.bz2'
>> returns '4.9.3 20150529', even though it's download file name is '20150609'
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/spark/firmware/commit/bcd4e51f74f7b2a59bc24b641895b602193d0921#commitcomment-12183297>
>> .
>>
>
>
>
> --
> Andy
>

--
Andy


Shameless stole the code from https://github.com/mboersma/progress :smile:


If you use ``%s`` formatting, better put them at the end of the string, not in the middle. Example:
+ Not so good: ``"test %s %s" % (foo, bar) + " test"``
+ Good: ``"test %s %s test" % (foo, bar)``


Oops guess that should be udp :)


This works, but will be very inefficient. This will make a request to UAA for every GUID it needs to translate into an email address. The old implementation was able to make batch requests. We should fix this to make requests in a manner similar to the old implementation.


Same as above


I think buffering the quit channel makes this unnecessary. You should close quite, though.


Law of Demeter,

it's better to call offerSearchViewModel.HasOffers() or something


forgot to mention in the first review, but we should also include $(SOL_FBP_TO_DOT_BIN) as a cheat-sheet, dependency.

Besides that we're good enough.


This will overwrite the old "switch audio" command with the new "switch subtitle" command.
I think we should support both, so instead of changing the languageup/down keys, two new commands should be added (something like subtitleup/down).
This would need to be added to the web interface, too, perhabs with buttons "C+" and "C-" (fits the "CC" to toggle subtitles).


@gkalpak Added a test to check for timeoutId and also confirm that multiple calls receive the same timeout.


comments, comments


This space should be removed


Merge the code properly after taking update.


Hi Kyle,
Thanks a lot for the feedback
I added the changes you suggested
David


You want to pass more information to `enableDirRestartFix` than necessary? Why?


@psytronx DWMR. You can see in this commit that the only file changed is the storyboard. That file is managed 100% by Xcode - which means it will be updated automatically should any features come or go. If we implemented this view controller in code, we'd have to update it manually. That's a big reason, just by itself, to use storyboards. Press on!


Please keep consistancy across docstrings and follow the pep257 (used in pep8): https://www.python.org/dev/peps/pep-0257/#multi-line-docstrings


Any ideas where this constant should be defined?

```
root@41d075742cc1:/var/www# hhvm --version
HipHop VM 3.2.0 (rel)
Compiler: tags/HHVM-3.2.0-0-g01228273b8cf709aacbd3df1c51b1e690ecebac8
Repo schema: c52ba40f4a246d35a88f1dfc1daf959851ced8aa
root@41d075742cc1:/var/www# tail -n 1 /var/log/hhvm/error.log
\nFatal error: Uncaught exception 'Symfony\\Component\\Debug\\Exception\\ContextErrorException' with message 'Notice: Use of undefined constant PHP_OUTPUT_HANDLER_REMOVABLE - assumed 'PHP_OUTPUT_HANDLER_REMOVABLE'' in /var/www/app/bootstrap.php.cache:1802\nStack trace:\n#0 /var/www/app/bootstrap.php.cache(1802): Symfony\\Component\\Debug\\ErrorHandler->handleError()\n#1 /var/www/app/bootstrap.php.cache(1468): Symfony\\Component\\HttpFoundation\\Response::closeOutputBuffers()\n#2 /var/www/web/app_dev.php(35): Symfony\\Component\\HttpFoundation\\Response->send()\n#3 {main}
```


Ah, right.  I was debating adding a step to use a normal `$timeout(0)` to get the baseline number as a way to prove that this reduces that number of digests.


If `Assets.loadBitmapData` calls the callback instantly (if the bitmap is already cached or the load results in error), then `handler` could be called multiple times.


repository is holy place , we need to care about its cleanliness


Where are the commits related to RTL direction?


Same as above


*sigh* 8 spaces to a tab. I'll go back and fix them :(


Whitespace, per https://github.com/softlayer/ember-style-guide/blob/master/javascript.md#block-statements


To achieve the same functionality we can use the method **find_or_create_by(attributes)**

(i.e.) user = User.find_or_create_by(username:username, token: token)


You need
`expect(env.clock.now() < time_point(enableAfter)`
Now this won't compile (needs tweaking) but you need to make sure that the clock starts out *before* the switchover time


Please reinitialize any data structures by the new message only when all work with current message is finished. In this case you call caching when connection->msg is already reinitialized. Probably, this is not a bug in this case, but it's good to follow the rule.


Good idea :+1:


Things like this should probably be a Future[User]


Done.


I think we can remove this file.


re save_comps:

the user_* fields have no bearing on matching - they are strictly for passing values to/from the callback routine.

only the following foreach_args_t fields drive matching
name type id  owner_id owning_comp

so for example:

foreach_args_t args = { .type = HAL_PIN } will match all pins
foreach_args_t args = { .type = HAL_PIN, .owner_id = 123 } will match pins owned by comp with id 123, OR instance with id 123
foreach_args_t args = { .type = HAL_PIN, .owning_comp = 453 } will match pins owned by comp with id 123 either direcly or through an instance (whose ID does not matter)

foreach_args_t args = { .type = HAL_PIN, .name = "foo" } will match all pins whose name starts with 'foo'
foreach_args_t args = { .type = HAL_PIN, .id = 789 } will match exactly zero or one times depending if pin with id 789 exists or not
foreach_args_t args = { .type = HAL_PIN, .owning_comp = 453, .id = 789 } will match exactly zero or one times depending if pin with id 789 exists or not, but only if owned by comp with id 453 directly or indirectly

foreach_args_t args = { .name = "bar"  } will match all objects whose name begins with "bar"


Can we make it so `parentTemplateName` always succeeds, no matter what the View tree looks like, just to be safe?


You need `<date>` which hasn't been written yet. You can validate the number by adding it to the epoch (January 1, 2000 I believe) and converting to a date/time.


every time you commit commented code a kitten dies somewhere


Since you are using ``split()`` to retrieve two meaningful variables, better give them a name. For instance ``ip, port = details_dict['proxy'].split(':')``


NOOOOOOOOOOOO!


Comments should also be complete sentences, ending with a period.


done


The use of `const` over `let` is preferred, where appropriate, per a forthcoming change to the style guide.  This change should be made to all occurrences, not just this one (will save on the commenting and messages).


We don't forget. All members know about it, when they will have free time they will write. Actually, in new commit Alina wrote her links. It will be ready will for Friday. :)


Hi Phil(https://github.com/phi-lira),

On this context, the ptr for GVRMaterial(,long ptr) inside of the constructor GVRRenderPass() is never set.
Do you expect it can be used in the future when you add a more complex Multipass example?

        GVRMaterial material = new GVRMaterial(mGVRContext,
                GVRShaderType.Unlit.ID);
        material.setMainTexture(texture);

        GVRRenderPass pass = new GVRRenderPass(mGVRContext);
        pass.setMaterial(material);

From: Mihail [mailto:notifications@github.com]
Sent: Tuesday, July 14, 2015 12:38 PM
To: Samsung/GearVRf
Cc: Jason Kim
Subject: Re: [GearVRf] Merge pull request #143 from phi-lira/master (f806f17)

I guess if there is a special need for constructing a material in this manner, it will be less error-prone for it to be captured as a dedicated constructor.

—
Reply to this email directly or view it on GitHub<https://github.com/Samsung/GearVRf/commit/f806f17a9fcbdf707f64bf890e3501968bc21c18#commitcomment-12163936>.


NOOOOOOOOOOO!


I know I'm very tedious, but this code is useless.


Great. Thanks!


Okay, I added backwards compatibility, and the new commit is here a99441dc05aa00ba67ef255fdb444fa56719a7fb .


You can combine these on one line like this:

attr_accessor :title, :priority, :completed


I'd personally have this return `true` when in "standalone" mode, which will allow the unit tests to succeed without any tweaks here or in the JTX.


What is the purpose of this line?  Couldn't this value be set on line 275?


Hi.
This is complete?

Android.mk break build for me.


The standard is to not include parens if you have no arguments.


Good job!


Looks like the `net/http` code prefers nil to an empty byte slice. That said, probably doesn't make a practical difference.


Please, prefer more readable stuff that:
``copen = (copen if TARGET == 'lout' else '') + TAGS['tableTitleCellOpen']``


Why do we want to introduce a dependency on the `Config` global variable if we don't have to? And your suggestion does NOT allow the "unit tests to succeed", because the definition of success is "old behavior before the date, new behavior after the date." With your change, we have no way to test that we still get the old behavior before the cutoff date.


hey ciao,
ich han ebe i mim comment gmeint, dassmer wenns würkli notwendig isch das serversitig zspeichere, das inere tabelle language wür speichere. denn brüchtisch ebe ned so viel klasse.

das wör denn so usgseh, dass ide klass language es DE property und es EN property hesch und das objekt denn jewils anstatt emene string id entity schriebe wörsch. jetzt hesch ja eigetli singletons gmacht und defo mega viel..

sorry dassi ned scho vorher zruggschriebe han, be gad recht im stress..


Do not comment and commit any code added newly.Verify the changes before commiting.


NO! Wrong!
1. never ever comment in Polish language,
2. where this number must come from?
why don writing a stub
`var score = GetScoreForOffer(offer);

.....
GetScoreForOffer(offer){
const in myDummyScore = 1;
return myDummyScore;
}

`
I believe you will never forget about this variable


This would also be relevant for Arabic, Farsi, Urdu.


Looks good to me!


With this change, in the `webgl_materials_cubemap.html` example, `renderer.info.memory.textures = 2`. Should not it be 1 -- at least in theory?


Does this really work?
I think to define a new command like ```togglesubs```, it must also be included in ```command_send``` in ```omxplayerd.py```, or it won't be passed over to ```omx_send()``` to be converted to a keystroke and sent to the omxplayer process.


Yes because they have verbose decorator they show up as being under
"mne.utils". Just remove the "mne.simulation." before the name and you will
be good. The underlying test uses "in" not "==" to check, so you don't need
the whole name.


Acessando o índice do vetor retornado pela função get_messages()


This is temporary code anyways that will be removed as soon as we hit the cutoff switch.


aber ich versto immer nanig wieso das id DB ine muess. all andere textli hemmer ja immer im front-end gspeicheret? gaht denn öpper is tool ine und bearbeitet die textli in dütsch und englisch? macht das die frau vo de verwaltig? well susch würis eifach is language.json inetue und wenn notwendig de key füregä


Oops, I thought I was committing to a branch. Still getting used to the GitHub desktop app.


You are right :) Now it's not sure :(


nope - not required


Excellent! I think this is more intuitive too because it was the only Plone 4 object action that "disappeared from time to time". For the same reasons - but now on Plone Toolbar - I'd suggest not hiding the `Workflow` and `More options` menu icons when viewing the folder contents. After all we want it to be much more used now so let's not hide stuff there.


(There is assume hint about what the test thinks the name is in the error
message btw)


comments, comments, but please .... no.


Sorry for the mangled commit comment.


done. deleted KMerCounter


Nice! This is awesome. :+1:


@YixingChen This is not an OpenStudio bug. This object is purposefully not in OpenStudio. You must build out a Detailed refrigeration system.


done


chasch ja suschd die klass au TranslatedString nenne.. :)


sqlite_timeseries (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1755 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


None of the other component tests contain this specific test (that comes with the blueprint) so remove for conformity.


Согласно ГОСТ 2.105, на который ссылается ГОСТ 7.0.11 по части выполнения приложений:

«4.3.8 Приложения обозначают заглавными буквами русского алфавита, начиная с А, за исключением букв Ё, З, Й, О, Ч, Ь, Ы, Ъ. После слова "Приложение" следует буква, обозначающая его последовательность.

Допускается обозначение приложений буквами латинского алфавита, за исключением букв I и О.

В случае полного использования букв русского и латинского алфавитов допускается обозначать приложения арабскими цифрами.

Если в документе одно приложение, оно обозначается "Приложение А".»

Не придумал, как исключить отдельные буквы. То ли отдельные номера из последовательности как-то исключать. То ли как-то ещё.


I think it's good to show score at least for debug/test time


:+1: :smile:


What is the purpose of this line? Couldn't this value be set on line 303?


removed


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17987/testReport/) for this commit**


There is no `assert.expect()` call


what if name == ""  true?
do we want to search by "" ?


Yes. But the current approach was hacky. At some point we have to create `THREE.Image` and we'll be able to cache (and reuse) these.


No - the definition of success is: "funded offers aren't incorectly removed." If any tests fail that based on time, then the tests are wrong and need to be updated. Remember, the behavior prior to the cutoff being identical to what's on the network now is a temporary thing and it's going away soon.

As to the dependency to the `Config`, again it's only temporary, until this code is merged and the switch triggers; after that the entire function is removed along with the dependency.


ここはDataType="{x:Type ～}"があってる。このコミットで消したのが間違い


This shouldn't break your build. Error?


Ah yes, I'd forgotten about `pkgconfig-depends`.

The package I was trying to fix is hayland which calls `pkg-config` via TH during compilation.  I've updated hayland.cabal to use `pkgconfig-depends` and that is sufficient.

While `pkgconfig` is one of the build-tools Cabal is aware of according to [Builtin.hs](https://github.com/haskell/cabal/blob/master/Cabal/Distribution/Simple/Program/Builtin.hs), I doubt there are any properly-constructed packages in the wild that use the `build-tools` dependency without using `pkgconfig-depends` also.

This commit can be reverted upstream if you'd like.  Thanks for the feedback!


when you're defining variable always use `var` keyword,
one day  it will save you a couple of hours.


Technically speaking, that is correct.  It's under consideration of the XMPP Council, so still proposed, but the last call did end.

This is an administrative detail, but should not have any real impact on progressing.


Should have looked closer, the executable doesn't appear to have changed at all (same md5 checksum) by doing this.  No idea.


Because of this redundancy variable from "MainScreenBGM" on 26th line, I use it for "ImprovementMaterial" instead.


Much more subtle. Great commit.


Consider moving this assertion to the start date range test and remove this test


I think that the comma already was added


Точка после первой части была бы лучше запятой.
Нужна запятая после волос.


Consider moving this assertion to the endDate range test and remove this test


typo :P


close #82


запятая нинужен


This is where that `val, ok := args[key]` pattern comes in useful. Rather than search the hash twice for the same key, you can do:

```go
if val, ok := args[key]; ok {
   return string(val)
}
return ""
```

That said, I'm actually not sure if this works if you actually set foo[bar]=nil. It's likely that nil is a legit value in a map[string]interface{}.


That's not right. We need to make sure that Scott's changes don't introduce changes to transaction processing _before_ the cutoff date.


смотрю на совершенное произведение искусства


Though if the script fails, it's probably better to start from scratch!


> Yes. But the current approach was hacky.

Oh, I agree. I am not questioning the code change....

I expected cacheing was working now...  maybe only for 2D textures?


Pretty sure this should be "Geurol Leather" (mark with x?)


x


EvansHVACObjects (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


That's a fair point - it's obvious by inspection that they don't, but a test won't hurt. OK, I'm convinced.


Ниочень. Там всё вон возвышенное. Изящные глаза или какие-то такие. Глаза на мокром месте тут стилистически не.


Done.


sqlite_timeseries (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1755 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@robertmesserle - :8ball:


напоминающее курицу надо выделить запятыми


Тоже как-то не по-русски звучит(


Material necessary to meet a qualification for the Elemental Master's list.


I must have missed something... why are you dereferencing the pointer instead of having apps.Create take a *Client?


слишком большое усилие он приложил. Быстрота тут ни при чем.


Прежде, чем она успела бла бла бла


can we use recursion in this function to avoid those `goto`, it might be cleaner? There are also some dead code comments.


This game ID leads to a Non'Valve game.


This might be cleaner to initialize with just the resource, and then reference the model and associations from the resource.


EvansHVACObjects (evanweaver) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


What happens if the custodia process dies on its own before we get here ? Will the wait() stall forever ?


- Deleted math.pm and integrated functionality in performance.pm because the function is just needed for millisecond converting.

- Deleted all Unit and conversionfunction fields from JSON

- Added dynamical Unit printing for performance counters

- Deleted some uneeded Modules


yes, thanks for noticing I thought I had removed them.


You should do the same also for `LocalJobLauncher`.


Huge Minotaur fang obtained from Susanhan Marketplace (??) - I'm not sure if it's implying the Minotaur was in the marketplace, or that the fang was bought there.  I feel like the latter is most likely.


x


Refuzu Nail (?)


A Nail required as proof of your commitment to the Monk Master.


Haha se mando dos veces. Perdon.


Note that this part was changed in #219, so very likely you will have merge conflict.


Needs another space to keep things uniform.


this hardcoded path is a good candidate to be extracted for windows. Can we do it now so other people don't need to come behind reading our code again?


Maybe it's me but `ICSS` sounds like `ISIS` when spoken? Maybe add a pronunciation guide next to it like you would find in a dictionary.


it's also better to use `filepath.Join` for these kind of operations.


Cara, você conhece bem a cobra em! hahaha :new_moon_with_face:


yay


I would mention the "Multithreaded Processing" section where the documentation goes into more detail. Perhaps I would even keep this part brief. Maybe just:

"The consumer is not thread-safe, see the `Multithreaded Processing` section for more details."

As it is, users may think that external synchronization is the way forward.


yes!


returns `nil` if the regex doesn't match.  This is probably not what you want.  Generally better to define a dummy class and return that instead.  This is what I've done with `NoServer`, `Proxy::NoProxy`, etc.  Otherwise the nil can raise an exception in a completely unrelated method to where the issue came from.


would be nice to not have that status worker unless it's needed, it's another thread that is not necessary unless there are experiments that are not completed


`s/path/filepath/`


python < 3.x.x?


Resolves #4


@syserr0r have a look at the following ``if``block. You can pass an ``admin_login`` query parameter to override `cas_force_login` and log in as a local user with administration privileges


develop (axelstudios) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


agreed


I went through the first chunk and marked what seemed like a suitable edit / translation, as well as added some input for certain lines.  Definitely run through the rest, and don't forget to mark stuff as you go (only on the stuff that makes sense).


Hmm, it's a boundary use case but still. We could patch it. What would you recommend?


done


We can live with `const` for the foreseeable future.  `constexpr` here changes syntax only, and not semantics.


moved to testing


You also need to do this for line 640 of this file.


What happens when `server_details.nil?`


I think this broke something.
See: https://twitter.com/MaximeHuran/status/621339052311228416


Be sure to mark your lines with an x.


Hi Alexx,

sorry but I did not try making ak4pf jets. Could you please explain me
what you mean by that?
I just add the tau information so I would not expect it to affect the
jet. Is that the reason why
you commented the tau part?

Cheers,
Betty

Le 15/07/2015 17:22, Alexx Perloff a écrit :
>
> This all looks fine to me. Did you try making ak4pf jets, or something
> like that, to make sure the changes don't affect the other jet
> collections?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Calpas/JetMETAnalysis/commit/a0ba2b025829613fd6575a41d1b2c2dd6e42680b#commitcomment-12180239>.
>


Please use `{@link SourceState}` and similarly for other classes.


this looks very constant to me :wink:


there's a typo from here on (not corrected in the final *styles.css*)
**b**border-top: 1px solid #e0e0e0;


Am I leaving your wing?  Just got an email to find another mentor.

Justin

> On Jul 14, 2015, at 6:55 PM, Justin Grant <justin@accr.biz> wrote:
>
> I haven’t had a chance to work on it yet. I will let you know.
>
> Justin
>
>> On Jul 14, 2015, at 6:40 PM, Bobbilee <notifications@github.com <mailto:notifications@github.com>> wrote:
>>
>> with adding the show link and changing the stuff to the gist, did that formatting fix production?
>>
>> —
>> Reply to this email directly or view it on GitHub <https://github.com/jgrant29/bloccit/commit/78aada2944cbffd76bceb2612f87287dd5f2bc69#commitcomment-12168885>.
>>
>


looks like a copy-paste error here.


Wow, that was much easier than I was trying to do.


typo


3: L102 copyright year is outdated, expected 2015 but got 2014


The `return` here doesn't seem to do anything (there is no fall-through in Scala pattern matching). Maybe also remove the one in the line above.


1: D100 Missing docstring in public module
21:1: F401 'six' imported but unused
23:1: I100 Imports statements are in the wrong order. from invenio_records.api should be before import six
24:1: I201 Missing newline before sections or imports.
27: D400 First line should end with a period (not 't')
27: D200 One-line docstring should fit on one line with quotes (found 3)
52: D400 First line should end with a period (not 's')
52: D200 One-line docstring should fit on one line with quotes (found 3)
64: D200 One-line docstring should fit on one line with quotes (found 3)
83: D400 First line should end with a period (not 's')
83: D200 One-line docstring should fit on one line with quotes (found 3)


26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. import dateutil.parser should be before import dictdiffer
27:1: I201 Missing newline before sections or imports.
29:1: I100 Imports statements are in the wrong order. from tempfile should be before import dateutil.parser
30:1: I100 Imports statements are in the wrong order. from functools should be before from tempfile
31:1: I101 Imported names are in the wrong order. Should be abort, current_app, request
31:1: I201 Missing newline before sections or imports.
32:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from functools should be before from flask_login
33:1: I201 Missing newline before sections or imports.
36:1: I100 Imports statements are in the wrong order. from invenio.modules.editor.models should be before from invenio_records.api
36:1: I201 Missing newline before sections or imports.
37:1: I101 Imported names are in the wrong order. Should be Agent, Deposition, DepositionDraftCacheManager
37:1: I100 Imports statements are in the wrong order. from invenio.modules.deposit.models should be before from invenio.modules.editor.models
39:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.deposit.models
42:1: I101 Imported names are in the wrong order. Should be deposition_record, make_record, record_to_draft
42:1: I201 Missing newline before sections or imports.
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from .helpers
474: D103 Missing docstring in public function
481:19: E261 at least two spaces before inline comment
492:34: E261 at least two spaces before inline comment
498: D103 Missing docstring in public function
505:19: E261 at least two spaces before inline comment
505:20: E262 inline comment should start with '# '


1: D100 Missing docstring in public module
21:1: I100 Imports statements are in the wrong order. from flask should be before from flask_login
21:1: I201 Missing newline before sections or imports.
23:1: I101 Imported names are in the wrong order. Should be Deposition, DepositionType
25:1: I101 Imported names are in the wrong order. Should be create_recid, dump_record_sip, hold_for_approval, prefill_draft, prepare_sip, process_sip_metadata, render_form, store_record
25:1: I100 Imports statements are in the wrong order. from invenio.modules.deposit.tasks should be before from invenio.modules.formatter


done


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Yeah, that default is for get, not get getattr


What is it about stopwatch that requires abstract_clock, whereas NetClock doesn't?


Consider pinning to 0.12 to stay current with patch releases.


add clear_status to json_parser_reset


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


will fix


It would be nice if we added some docs on how to actually use Gulp, maybe in the README. Doesn't have to be a lot, just, like, what command do I run to build.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 145](https://teamcity.labkey.org/viewLog.html?buildId=261124&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 2 (1 new), passed: 12 Build time: 00:22:28
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


Ah... the close buttons for these panels are bound to Toggle[window]() rather than Hide[window]() in the MapWnd ctor.  I don't think there'd be any problems with binding it to the latter function, not sure why it's set up this way.


Now just to as 3.4

Because I don't think we have 2.7 is called on my laptop at the moment.


Yeah, I really worked hard to make changes in the integration subclasses easy!

Adding a `Requirements Check` for Git is equally as simple.  We may want to reconsider that some day.


Or, autocorrelation fail


Looks good to me.
Anyone else?


... I give up


Oh wait, I didn't see the `foreach` above. So this exists the `foreach` once the case matches. Is that intended?


done


Mano, cobra é vida! :new_moon_with_face:


@airtoxin not ST3 only?


We do not yet inject `NetClock` based objects into logic, while we do inject `Stopwatch`. At some point we will want to inject `NetClock`s for testing purposes and that's when we'll probably make this `NetClock` a detail class (e.g. `detail::NetClockImpl`) and then write
```
using NetClock = beast::abstract_clock<detail::NetClockImpl>
```


LGTM.


囧。。没主意。。谢谢更正。。


I could do it now if you prefer


@andystanton you are the master of all the CLion casks :laughing: Thanks again.

As with the other cask, you are a little to strict here and the cask only conflicts with `clion-eap`.

Otherwise :+1:


Ah, I didn't realize your question was suggestive :smile: The sentence is currently wrong. It should say:

- assigned to the list (manually or automatically)

AND

- the list is published in the Livingdocs TM

OR

- "filled up" from the list's elastic search query

I'll change this. I can probably even put the first two points into one sentence in order to make it clearer.
Thanks!


D'oh, ```togglesubs``` was already there but unused.  My bad!
Then of course it should work :-)


Looks good to me too


Done, sorry about that.


hm... what about:
return -strcmp(a,b);


@frapposelli nice, LGTM!


/me hangs head


@anton-johansson, reviewed my PR on `landing-pages`? :D::D:D:D:D. Largest PR ever.


Ouh tu aimes prendre de l'espace :D


Ton editeur utilise des tabulations, il faut le configurer pour utiliser 4 espaces à la place


A lo que me refiero es que a través del propio sistema debo agregar un nuevo rol, en este caso, el rol de 'Perito Valuador' como se haría con cualquier item que se agregue a un catálogo... Es decir, debe depender solo del Administrador de Sistema.


LGTM

I think it would've been better to do this as a separate PR and then merge.

Can you further explain "project.files() does not have a type amenable to performing pattern matching". I didn't quite understand this.


@pbeeler the only person that is lying here is you to yourself.  The uberroot configuration I use I got the idea from AOSP and Linaro since they both use it.  I put the two scripts through a plagiarism website and they are 91% different.  The logs actually have provided very good feedback and I've been able to solve over 20 different compile issues for people interested in building UBERTC (so yes that does actually help development).  Also my comment on your trolling is also true this history shows it all https://github.com/pbeeler?tab=activity.  If you look at my github I'm not hiding anything.  There is not a single commit from SaberMod and nothing was authored without proper commit history.  I give no credit to SaberMod because I took nothing from SaberMod. SaberMod overcompilcates things in every way.  Build scripts are longer, toolchains are larger, toolchains don't work properly without modding build folder and vendor, etc.  UBERTC is far simpler than SaberMod and will build a ROM without any modifications to the build folder which is why it is growing in popularity. You may find it hard to believe but most people don't have time to deal with over-complicated scripts & build folder mods. These same people also don't have time to troll everyone on github either.  I cater to these people because I respect their time. I realize that they have jobs, families, and a life.


Isn't that Replete's icon ?
I have no idea how can I get javascript core working on Droid.


@cagryInside I believe we should add the get/set predicted arrival/departure times methods to `TimepointPredictionBean` too.  This classes was added by Kurt in his initial commit for per stoptime predictions (https://github.com/kurtraschke/onebusaway-application-modules/commit/417deb7f46f2d53d49c758e3fe7468e8a8eb6e5d).  I believe this is needed to export the predictions via the [OBA GTFS-rt export API](http://developer.onebusaway.org/modules/onebusaway-application-modules/current-SNAPSHOT/api/gtfs-realtime.html).


Hi.
Why a fresh project need bootstrap-sass as default?
Thanks.


the issue here is that current version is for versions >= 3.4.6:

https://issues.apache.org/jira/browse/ZOOKEEPER-1810

Could we add a `version` field to the Notification class, save the version and then the rest of the code can decide to ignore or not this message depending on the version?

I, personally, don't work with <= 3.4.6 clusters but I am sure there are many of those clusters still around...  Thoughts?


I think I wouldn't use the word "legacy" in the name of the config property: useLegacyParentChildMechanism

Actually I'd propose: core.hierarchyMode = parentchild | reference and set it to "reference" by default.

Also I'd have created a SS that is more generic than just for the hierarchy mode. Note that we already have a CoreConfiguration class and we could have a CoreScriptService to expose some core configs that don't fit elsewhere for now.

Since this is becoming APIs we should probably discuss this on the list too.

Thanks for starting this!


just write See [installation guide](http://github.com/cppit/jucipp/blob/master/docs/install.md)


What happens if the file doesn't exist?


thank you :)


@lawinslow why is this going back a version?


Yes, there is some cacheing working for xhttp and image requests but it still needs more work.


double click on disabled option work, and give this error !
![capture d ecran 2015-07-15 a 19 47 28](https://cloud.githubusercontent.com/assets/56861/8705545/8fee3b78-2b2a-11e5-8d25-c54b0a80c24f.png)

just edit ra.remote-form.js line 22 to resolve this
dom_widget.on('dblclick', '.ra-multiselect option:not(:disabled)', function(e){


I should have left it, that's a good algorithm name.

`Last night I made pasta and had to do a bread first search in QFC.`

It kind of works.


EvansHVACObjects (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


hmm, not sure how this empty commit got in


This look interesting.


@mjuric I suppose we should also add `ln -s g++ c++`, unless you can think of a reason not to...


Lab exercise code for the course Machine Learning : https://www.coursera.org/learn/machine-learning/home/info


pakozh, yes, you are right!


...and nevermind.  I just read your commit message above.  Move along, nothing to see here....


I don't like the idea of adding wrapper with 'rank' argument. Can we somehow provide it implicitly? Like adding it to the envir or so? or simply passing to .fiface.eval?


Sorry, got to this too late. You don't need `string(...)` here or in any of the other tests, since you already have a string inside. It should just be

```
@fact bytestring(buffer) == " - 3 + 1 t + 𝒪(t¹⁶)" => true
```


This is wrong. You should set data-l10n-id instead of using mozL10n.get which is deprecated.


This is wrong. You should use mozL10n.setAttributes instead of mozL10n.get which is deprecated


Same here.


OK. Thank you for the clarification. : - )


Thanks, reproduced the bug. Turns out that this happens when need to split the page twice or more to insert a record. Will merge with a fix.

Minor comments:

* 2GB volatile pool for one testcase is quite large. I want to make sure at least testcase runs with small memory with a reasonable -j. Could you change it to reproduce the bug with 100~200MB pool at most?
* Need to enable cpplint in your environment (in my env it gives me 5 warnings). Will check it tomorrow.


EvansHVACObjects (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


This needs to be way upper, not after we setup other fields.


This is wrong. You should declare data-l10n-id instead of using mozl10n.get which is deprecated.


What I mean with my previous comment about `string` is that you can replace these two lines with just
```julia
@fact string(-xH) == " - 1 x₁"  => true
```
which is much more readable!


Why it worked before? What changed?


Oki thanks, they are putting the version info in the JSON with the ability to add it to mimetype later if needed.


No. We cannot do this on public interface.


I love you to, Mike.


You don't need and should not use mozL10n.get at all.


I think this isn't actually a problem after all, given https://github.com/AkihiroSuda/zktraffic/commit/f29921c9d1f8debe7d25cbf8c9f1b65ab18593f4.

If the cluster isn't patched with ZOOKEEPER-2098, notification messages aren't visible anyway.


I don't have a strong opinion for this, I just thought we could use the same basis for all recurring notifications. But if you prefer to keep them separate, I can revert this change and add a NO_RESEARCH_TIME_COUNT parameter.


develop (axelstudios) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


it rebooted after few minutes so I dropped it for now


I believe you'll need to change the return type here to `TimepointPredictionRecord`, so we can have access to both arrival and departure times that are needed below.


have you tried developing with brackets? it has a decent git plugin. Commandline is pretty easy too ;)


this should not store localized value, but l10nId and resolve it only when displayed - https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs


make sure, what you print correct result.


neig default was incorrect. For this case neig.default should be 1.

Then I fixed default, test failed)


This should not use mozL10n.get. It should set data-l10n-id on the element that is to be localized. See https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs


@ruchikamayekar please DRY up this code. why we need to log output as `puts....for #{post.id}` where `post_id` will remain same for that run in a loop ?
cc: @shivanibhanwal @swatijadhav


I believe this method should be changed to receive a `TimepointPredictionRecord` as input, so within `setPredictedTimesFromAbsoluteArrivalTimes()` you can set both the arrival and departure times based on the original GTFS-rt arrival/departure.  Currently we're just using the arrival time to set both arrival and departure times:

~~~
private void setPredictedTimesFromAbsoluteArrivalTimes(
      ArrivalAndDepartureInstance instance, long predictedArrivalTime,
      BlockLocation blockLocation, long targetTime) {

    setPredictedArrivalTimeForInstance(instance, predictedArrivalTime);
    setPredictedDepartureTimeForInstance(instance, predictedArrivalTime);  // <-- should be set using the original GTFS-rt departure time for this stop, if it exists

    TimeIntervalBean predictedDepartureTimeInterval = computePredictedDepartureTimeInterval(
        instance, blockLocation, targetTime);
    instance.setPredictedDepartureInterval(predictedDepartureTimeInterval);
  }
~~~


@Ephemerality that was pretty much all that I needed to know, thank you.


@ruchikamayekar
`alert` statements committed?


@slabounty I cannot tell yet, but I will investigate to find a long term solution :-)


doesn't this need:

```
__metaclass__ = ABCMeta
```

or to be derived from ABCMeta for the @abstractmethod decorator to work? See: https://docs.python.org/2/library/abc.html#abc.abstractmethod


But I need some "dummy" ssa-obj for using generics (like .traj.dim). And then I fix object class


Hack for the build tool which can't handle the dual change in package versions at once. It will go back


@ruchikamayekar We should instead output Blog post `Title` i.e. Subject and `ID` instead of logging ID for every line.


sqlite_timeseries (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1755 of 1755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


So next time this happens we are not throwing any exception and silently fail, am I correct?


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Thus, maybe just = NULL for default? =min(whatever) is not very good to in such point of view.


The communication defaults to regular shell, right?


Ah, I didn't catch that, thanks for the heads up, I'll fix that.


should return `tpr` here, and change the return type to `TimepointPredictionRecord`.


return statements ? why ?
@ruchikamayekar @swatijadhav @shivanibhanwal


@mitchellh @benh57 ^^


Thanks for noticing this issue and proposing a fix. I think a better place for the fix would be in ParseEnumValueList though. We should check for null in there.
Also, TryReadElementFromXml should only return false if it doesn't know the element name that it is asked to parse. In this case, it does know the element name (DayOfWeek) so it should return true.


Did you do this for because of https://github.com/mitchellh/packer/issues/2429 ? I submitted a pull request (https://github.com/mitchellh/packer/pull/2438) to fix the error a couple of days ago, it's sitting in the queue.


Why are you casting malloc? void* get implicitly casted in C.


It does


@ruchikamayekar its good practice to use `.for_each` with a batch size of 20 or 50 here instead of doing `.all.each`.
...imagine if we have 1K posts then this will load that much in memory.
cc: @shivanibhanwal


sqlite_timeseries (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


the NoSQL Lightning Talks session has multiple speakers. The design only accounts for speaker person session. How should we represent multiple speakers.
<img width="1201" alt="screen shot 2015-07-15 at 10 13 37" src="https://cloud.githubusercontent.com/assets/1772618/8705591/7838089c-2adf-11e5-86fa-7f0ff60933b3.png">


DRY up this code please....path and url have common path or strings, thus we can dry it up here
@ruchikamayekar
cc: @shivanibhanwal


What is dependency for HBaseConfiguration?


Os 2!


have a better task name here.


:birthday: Thanks!


@cassiopaia I think transparent background works better for labels - this way they less similar to buttons and create less visual clutter


Thanks for feedback, I will fix them.


TeamCity Gensokyo Lobby :: Lobster Server [Build 17](http://pixelated.design/build/viewLog.html?buildId=43&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **FAILURE**
Summary: Exit code 14 (new) Build time: 00:00:10


This space has been removed.


@bjoern-r

> for me video calls does not work. but i havn't investigaed the issue.

You do need to do the install again.


comment is not my favorite.  "would be" implies some other condition; is "are" the same meaning?  if so it's more assertive.  Also the scope is confusing...why would this be just for "across multiple versions of a distro" (i.e. what does that mean in some more detail, I guess?)


Awesome - if it ever switches to powershell, this call should be `where.exe` instead of just `where` to override the powershell alias.


This test has been removed.


move to the calling class


I personally think SPI is not a terrible place for this, because connectors who need this will need to import
com.facebook.presto.spi.DecodableColumnHandle;
instead of regular
com.facebook.presto.spi.ColumnHandle;
but with the move it utilities this becomes
com.facebook.presto.utils.decoder.DecodableColumnHandle;

but no strong feelings about this either.


This whitespace issue has been fixed.


Could you please rephrase this comment?


Rephrase.


Ukrainian my bad ><


@rathanbpoojary where is the combined css file?


I was leaving it as a placeholder for utilities that includes more than decoders.

If none are expected, the more accurate name would be
presto-connector-decoders
or
presto-decoders


No :)