This seems to be causing a problems in the backend. If I apply a non-credit card payment to an order this callback is called which creates a 0 value credit card payment (and latest `master` branch will make it the full order amount instead of 0). What is worse is that it cancels the payment I am trying to create due to yet other callback which [cancels old payments](https://github.com/spree/spree/blob/master/core/app/models/spree/payment.rb#L203) since my payment has not transitioned to complete yet.

Unsure if there is a solution to this (perhaps more conditionals on the if statement which seems messy). Or perhaps just remove the `from_credit_card` portion. So if there are any other payments on the order we don't try to auto-create a payment.


extract this reference to AppDelegate and pass the NSNumber var of userId


Oh, well I only tested the Linux version. I guess we know both work now!


You fixed the one from L208 but not this ;)


ah ok - I need to learn to spell :)


with latest commits it should work without any problem. tried it and some other user on note 4.


Stats 3.0 isn't stable yet and I'm stuck on the last working AR build 355!! & Stats 2.0. Wont update them. :/


@yardenr @gregra81 This actually changes the meaning of this quite a bit. You used to be able to not pass a redirect uri parameter. Now you always pass something. This breaks my existing code.


I would keep this and flag it as `not cool` maybe


this is the xml payload, right? I assume it's always the same. we could take a look at one to find out what encoding they use. Most likely its utf8.


It is not implemented yet, it might or might not be in the future, if it's staged then it will be released when it's done. If you are really anxious to have it, ACE3 is open-source, feel free to to take a cookie and develop it yourself. :cookie:


improved a bit


Thanks for the quick reply, could you send me a link, i'm not familier with Bower repository. I'm a self taught coder and just learning the ropes


You may want to consider ignoring this file, if it will persist to generate.


:+1:
we should also add a line about image credit, as I think it's important and we don't want to go chasing them later about this.


hook_update_N is the one special case where were don't need to put the "Implements hook..." type declaration. Simply just put a description of what the update hook does. The reason for this being that when the admin runs these updates, drupal will parse these comments and spit it on the update page as a description of what the update does.


Why **was** my feature request closed on **G**it**H**ub


@gregra81 @phbcanada's comments notwithstanding, this used to only pass @redirect_uri as a parameter when there was something to pass - now this url always has the parameter, although it may be blank. Probably harmless?


A great addition!
If you may, I would like to suggest a "usage" method for all new commands.,  since we have been starting to add the "h" help parameter and it would be nice if we got all on that track.

And I know that @buggii will want to have a write up how to use the new commands.
and @holiman will want the changelog.md to be updated..


broken**,** when


Never mind just realized you have :P https://github.com/EthanRiley/SKSEBot/commit/5d44fb8c700628448399868beeb8350f9799b6e4


did you mean current or coherent in the changeset description ?


Yup. I've confirmed that 1.4 works but none of the 1.5.x versions work.


Fun fact**,** it isn't


**ACE3** 3.1.1


Haha np! I would have made much worse mistakes with my "the Italian who went to Malta" like english ;)


Arma 3 (missing space)


please remove this constants before publishing


Spelled "canola" wrong!


Header redux is always nice to have, saves a bit of compile time...


Hi, not sure about the directive "pf-percentage-used", shouldn't it indicate what kind of chart will be rendered, ex: "pfBarChartPctUsed".
Also, you are also changing form/form-buttons, I realize it should be transparent to end-users, but I would've liked to see this in a different, separate, commit.  Being hidden in this commit will make it more difficult to track down when/where this form changed happened if there ever was an issue.


It is utf8. I'll update this.

```
 <?xml version="1.0" encoding="utf-8"?>
```


please remove reference to AppDelegate from method and pass just NSNumber vars


hpwh_residential (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1679 of 1686 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.58%25-yellow.svg)


Will this take care of a scenario of updating the counter as a user swipes through videos in landscape mode? Back when I was investigating the issue, I remember the main reason this was an issue was because the if condition in setFilmstripCounter was not returning as 'true' in landscape mode on an iPhone.


A longer explanation might be beneficial, basically what is being said all the time:
ACE3 isn't and can't be responsible for all (mod) conflicts, due it's size other (mod) authors are strongly encouraged to provide that from their side.


I like these keybindings for next/previous MUCH BETTER!


@elyngved @jusx Is there a reason we need a fork of this guide, when we've made no changes to it?


A longer explanation might be beneficial, basically what is being said all the time:
ACE3 isn't and can't be responsible for compatibility with every (mod), due it's size other (mod) authors are strongly encouraged to provide that from their side. Compatibility PBOs currently in ACE3 are there to kick-start and provide examples for (mod) authors.


oh, thank you so much. :) :8ball:


Yes, that is actually the specific scenario that the JIRA ticket was for that this bug was addressing. It won't update the counter if it's hidden, but will as the orientation changes and the counter is revealed.


972154-NewSimpleChilledCeiling (RKStrand) - x86_64-MacOS-10.9-clang: OK (1682 of 1694 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.29%25-yellow.svg)


`self`'s


My conclusion (again working with my firmware B and official A):
* if I mix bootloader from B and firmware from A (this is the result if I first flash B with dfu and then flash A in bootloader) the radio will not work, in fact when I press power button I get immediately into bootloader (without any trim keys pressed).

I verified contents of radio FLASH by reading it back with dfu-util. So hybird FLASH image (bootloader part from B and opentx from A) does not work.

But some of my compiled firmwares are ok and work when flashed from bootloader. Is it possible that opentx is linking some part of the bootloader code? Because my bootloader is different from the official (due to make flags and probably different toolchain).


@chpreheim @jusx Is this test still used as part of our interview process? should this publicly visible?


`<<` rather than push, maybe? I'm kinda indifferent.


What's the justification for this? Are "Their own TLS and crypto libraries" meant to mean SecureTransport?

This will almost certainly cause regressions for software that believes linking against openssl will not give it 0.9.8


@jusx Is this test still used as part of our interview process? should this publicly visible?


Sounds like a good idea. Want to send us a PR?


We don't promise it'll be there forever :-). Better to copy or publish as a separate NPM package.


@ransomr Updated.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Hey @kaycebasques and @jpmedley, please make sure you test building WF every time you make a commit. This commit broke the entire build due to a missing line right after "dgash:". See https://github.com/google/WebFundamentals/commit/99b6c448704c52d8d4d9fd360d5d78aea5b946b4


Ugh, sorry for that ugly commit. Fixed it.


Noted!


pure crap


No, currently nothing is public. When the cm11 is ready then I will release the rom and here also the source.


are we really wanting to have this HAVE_CONTIKI dep? I mean, we seem to want to get rid of it and let the user choose it, at least until we come up with a better solution for that, with that we can't always have contiki available.


we should open PRs for these just to make sure CI is happy


Good :D


1682_waterheater_stratified (mbadams5) - i386-Windows-7-VisualStudio-12: OK (2187 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.74%25-yellow.svg)


This was a lifesaver for me, thanks!


s/Soletta will do/Soletta aims to do its best/

or sort of....


yeah it's tough - I don't like being too judgmental. There are probably occasional cases (word = 'stub' + 'prefix') where it makes sense still.


here you should depend only on PLATFORM_CONTIKI since it already depends on HAVE_CONTIKI, it will scale the deps for you, don't need to declare it here.


I think this CSS is being used for the carousel notification if the shortcode doesn't work.
see #1277


I know the same thing happened for me on m8. The BF.1.1 rebase bootlooped if I just flashed the boot.IMG, but worked fine if built with the ROM.


This filter should be documented


84691154_AutomateBuildingOfDocs (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (652 of 652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.49%25-green.svg)


I'm not gonna open PRs for every small change :wink: We might as well just run the CI always (making sure deploys happen though)


Is there a special reason why some OCD-entries are excluded?
API-Breakage? Covered in other PRs/branches?
I'm asking mostly because of the `DataHolder` too generic entry


> What's the justification for this?

Clang & LD have fun ideas of what is a reasonable standard linking behaviour to adopt, and it was biting people. See #41613.

We're extremely aware this is going to bite people who have installed things from source over the last 4 days - We've rebottled everything that had OpenSSL links updated during that period and forced revisions. We will be reviewing the situation going forwards in regards to taking more drastic action.

> Are "Their own TLS and crypto libraries" meant to mean SecureTransport?

Yup, as well as the archaic OpenSSL they keep slightly supported.


This should be probably changed to
```C++
if ( GetAnimateOnReset() )
```


@erictune, I guess this is not intended?


Good point! How about:

> Please add a line with image credits and be sure to respect the privacy of others when uploading photos.


best one


@iceman1001 or @buggii  -- can you point me to an example of using the "h" option in the preferred manner?  I would like to add this although I am not sure what I know what you are looking for...


Right, thanks.


Recommend to check not old version with current, but with that in which the change occurred in fact. For instance, in your case it should be:
```if (oldVersion <= 4) {```


Pete told me. I am sorry.

On Mon, Jul 13, 2015 at 1:54 PM, Paul Bakaus <notifications@github.com>
wrote:

> Hey @kaycebasques <https://github.com/kaycebasques> and @jpmedley
> <https://github.com/jpmedley>, please make sure you test building WF
> every time you make a commit. This commit broke the entire build due to a
> missing line right after "dgash:". See 99b6c44
> <https://github.com/google/WebFundamentals/commit/99b6c448704c52d8d4d9fd360d5d78aea5b946b4>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/WebFundamentals/commit/604eabc47e6c8ddd997739129fb3ffad08436a87#commitcomment-12142693>
> .
>


why do we need this sol-missing-contiki.c? it's putting sort of all hardware support implementation together...


I bought your reason for not starting hackney before - why did you change your mind? Won't be needed in the default config.


It seems like this link should be:
```
<a class="navbar-brand" href="/viewer/index.html">Viewer</a>
```


Something has gone wrong with the creation of the Documentation page -- there's no revision, size, or checksum, and the URL is incomplete.


Something has also gone wrong with the creation of the Platform Tools page.  There's no revision #, sizes, checksums, or URLs for the different host-OS packages.


should this be hackney_pool since it is specific to hackney? Do you need to initialize the pool if not the default? Should at least add a comment describing the effect of this.


Neat, I didn't know setdefault


I don't agree with that.

In my mind then __pclass is just another BSON type.

We don't pass raw bson types to anything. We use them to create our corresponding types and assign them values.

For __pclass, the type is the classname is refers to, so we create our corresponding object.

No need to pass it unless we are ignoring its value and constructing different object, or array, in which case I can see the need for including the __pclass.
Similarly to how it works now, if the classname provided cannot be loaded we populate __pclass as any other Binary type.


@jbaxleyiii the endpoints are not being created and that is one of the several reasons why People are not being created on Apollos after giving.  Can we talk through this code sometime?


I tested this, it's ok but the overhead is too high I think. For example we turned our server down to 24000 and the overhead leaves it at a negative value.  I changed it to this and it basically works:

```
    var overhead = 2000;
    var minimum = Math.min(syncData.max_bandwidth, 12000);
    var bitrate = Math.max(syncData.max_bandwidth - overhead, minimum);
    this.setBitrate( bitrate );
```


change the date here to: Tue July 14 2015
(date you picked in the editorial calendar)


> This will almost certainly cause regressions for software that believes linking against openssl will not give it 0.9.8

Our usual advice to users wanting to link against this openssl applies: within Homebrew this openssl will automatically be picked up if specified as a dependency, and outside Homebrew we recommend setting CFLAGS and LDFLAGS (as documented in `brew info openssl` and the postinstall instructions).

Sorry for the inconvenience.


Never mind, just saw this post.

http://forum.xda-developers.com/showpost.php?p=61730916&postcount=16


You're right, I didn't realize they were strings.
Perhaps this makes more sense. We only want to blur if there is a value passed into.


Remove empty line


this is a great post, thank you so much! :sparkles:
before I can merge, could you:

- change post date (see previous comment)
- change the file title to `2015-07-14-Introducing-Team-Techylite.md` (the .md extension is important, as it shows that it's a Markdown file)
- add all the images you are using to the folder `img/blog/2015`, and link to them in the text. You can take a look at previous posts, to see how it's done. Please also add image credits accordingly :)

don't hesitate to comment here if you have any questions, need help, or are confused about anything.


push @afgane - how to add a volume so it will be accessible in the whole cluster?


Sounds good to me! :+1:


to all my kernel followers!
i have made rebuild of tree by deleting code from history and tree to reduce bugs from hacks.
to sync your tree with my do this!

git reset --hard c3fc555c2c2eaad7a865b7759ba60f8ea569543d
then sync with me tree again.

changes that done, i have reverted:
cpuidle, core, cpustats, msm cpufreq, arch kernel, mem maps, few other hacks.
i want to gain stable cpu code. even if it's add small delay... maybe... :)


@gabizou asked me not to touch the data related issues. You'll have to wait for the new Data API, but making changes now would essentially get replaced anyway.


I prefer the existing implementation.


Hello Invoca folks @nburwell @codyjca @melch @colin-allen! I've had a bit of time in between other stuff last couple of weekends and so I thought I'd take stab at upgrading to datatables 1.10. Check it out, it works! Pretty minor changes, but the way that reordering columns works now required some pretty surgical changes. Anyways, I'll let you guys decide on what you want to do with this.


Cool so this is where it will ignore marks received after fullyLoaded (since tests will use measures after that point)


Specify utf-8 charset


Sweet, thanks for fixing this @shirish-pampoorickal!


https://github.com/Proxmark/proxmark3/blob/master/client/cmdhfmfu.c#L1137

Its quite easy, just rip out all "help texts".... basically.


Yep! :+1:


@leiyangyou feel free to make a PR with this add-on if it's stable! At least one test case will be required.


Just a nit but you could use ```StandardCharsets.UTF_8```. I think its in the same package you imported.


Hmm, I don't like that the requirements for the Key type change all of sudden, and you'll get several tens of lines of unreadable template poop just by trying to call the function:

    Building module fail2ban...
    In file included from fail2ban.cpp:17:
    In file included from ./../include/znc/znc.h:21:
    In file included from ./../include/znc/Client.h:21:
    In file included from ./../include/znc/Socket.h:21:
    In file included from ./../include/znc/Csocket.h:43:
    In file included from ./../include/znc/defines.h:24:
    In file included from ./../include/znc/ZNCDebug.h:21:
    In file included from ./../include/znc/ZNCString.h:21:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/map:423:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__tree:15:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/iterator:332:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__functional_base:15:
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/type_traits:948:38: error: implicit instantiation of undefined template 'std::__1::hash<CString>'
        : public integral_constant<bool, __is_empty(_Tp)> {};
                                         ^
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:362:54: note: in instantiation of template class 'std::__1::is_empty<std::__1::hash<CString> >' requested here
    template <class _Key, class _Cp, class _Hash, bool = is_empty<_Hash>::value
                                                         ^
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:731:13: note: in instantiation of default argument for '__unordered_map_hasher<CString, std::__1::__hash_value_type<CString, unsigned int>, std::__1::hash<CString> >' required here
        typedef __unordered_map_hasher<key_type, __value_type, hasher> __hasher;
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    fail2ban.cpp:144:33: note: in instantiation of template class 'std::__1::unordered_map<CString, unsigned int, std::__1::hash<CString>, std::__1::equal_to<CString>, std::__1::allocator<std::__1::pair<const CString, unsigned int> > >' requested here
      for (const auto& it : m_Cache.GetItems()) {
                                    ^
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/memory:3065:29: note: template is declared here
    template <class _Tp> struct hash;
                                ^
    In file included from fail2ban.cpp:17:
    In file included from ./../include/znc/znc.h:21:
    In file included from ./../include/znc/Client.h:21:
    In file included from ./../include/znc/Socket.h:22:
    In file included from ./../include/znc/Threads.h:24:
    In file included from ./../include/znc/Utils.h:30:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:350:
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__hash_table:2016:21: error: called object type 'hasher' (aka 'int') is not a function or function pointer
        size_t __hash = hash_function()(__k);
                        ^~~~~~~~~~~~~~~
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:972:57: note: in instantiation of function template specialization 'std::__1::__hash_table<std::__1::__hash_value_type<CString, unsigned int>, int, std::__1::__unordered_map_equal<CString, std::__1::__hash_value_type<CString, unsigned int>, std::__1::equal_to<CString>, true>, std::__1::allocator<std::__1::__hash_value_type<CString, unsigned int> > >::find<CString>' requested here
        iterator find(const key_type& __k) {return __table_.find(__k);}
                                                            ^
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:1362:20: note: in instantiation of member function 'std::__1::unordered_map<CString, unsigned int, std::__1::hash<CString>, std::__1::equal_to<CString>, std::__1::allocator<std::__1::pair<const CString, unsigned int> > >::find' requested here
        iterator __i = find(__k);
                       ^
    ./../include/znc/Utils.h:345:4: note: in instantiation of member function 'std::__1::unordered_map<CString, unsigned int, std::__1::hash<CString>, std::__1::equal_to<CString>, std::__1::allocator<std::__1::pair<const CString, unsigned int> > >::operator[]' requested here
       mItems[it.first] = it.second.second;
       ^
    fail2ban.cpp:144:33: note: in instantiation of member function 'TCacheMap<CString, unsigned int>::GetItems' requested here
      for (const auto& it : m_Cache.GetItems()) {
                                    ^
    In file included from fail2ban.cpp:17:
    In file included from ./../include/znc/znc.h:21:
    In file included from ./../include/znc/Client.h:21:
    In file included from ./../include/znc/Socket.h:22:
    In file included from ./../include/znc/Threads.h:24:
    In file included from ./../include/znc/Utils.h:30:
    In file included from /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:350:
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/__hash_table:1595:21: error: called object type 'hasher' (aka 'int') is not a function or function pointer
        __nd->__hash_ = hash_function()(__nd->__value_);
                        ^~~~~~~~~~~~~~~
    /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/unordered_map:1366:41: note: in instantiation of member function 'std::__1::__hash_table<std::__1::__hash_value_type<CString, unsigned int>, int, std::__1::__unordered_map_equal<CString, std::__1::__hash_value_type<CString, unsigned int>, std::__1::equal_to<CString>, true>, std::__1::allocator<std::__1::__hash_value_type<CString, unsigned int> > >::__node_insert_unique' requested here
        pair<iterator, bool> __r = __table_.__node_insert_unique(__h.get());
                                            ^
    ./../include/znc/Utils.h:345:4: note: in instantiation of member function 'std::__1::unordered_map<CString, unsigned int, std::__1::hash<CString>, std::__1::equal_to<CString>, std::__1::allocator<std::__1::pair<const CString, unsigned int> > >::operator[]' requested here
       mItems[it.first] = it.second.second;
       ^
    fail2ban.cpp:144:33: note: in instantiation of member function 'TCacheMap<CString, unsigned int>::GetItems' requested here
      for (const auto& it : m_Cache.GetItems()) {
                                    ^
    3 errors generated.


Just a skippable nit, cool otherwise.


Thanks heaps for the clarification, and sorry if I came across bluntly. Justification probably wasn't the right language to use.


Fixes #1


yeah CI does run on deploy however it only deploys and does not run the tests, our test process assumes all changes that make it into master have been PR'd that is part of the git diff magic that we do to only run the tests over a subset of all the projects


foti has a good suggestion but also ambivalent.


Sorry, ja das war der Hinkel-Bilder Quickfix (der einfach nur die
Hinkel-Bilder abfragen im Frontend blockiert). Kann ja jetzt einfach
gelöscht werden, der hatte ja nur zusätzlich gefiltert. Kann ich sonst
morgen auch flott machen.

Am 13.07.2015 um 21:08 schrieb Daniel:
>
> Genau, das ist der berühmte Hinkel-Quickfix (oder ein Teil davon), von
> dem ich weiß. Der war so in der Zeit wo du weg warst. Also ich könnte
> mir vorstellen, dass der auch noch wieder ausgebaut werden kann / muss ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/codarchlab/arachnefrontend/commit/d3cd968b4181f5c68834e1974f3d39c78f4bdc72#commitcomment-12140587>.
>


Thanks! Fixed


Great. Waiting impatiently to test it ;)


Oops. sorry about this! :disappointed:


Looking at the, I don't see any way to access the params from within the script. Could you possibly give an example of you might do that?


> our test process assumes all changes that make it into master have been PR'd

Well, that sounds like a bug in the CI system. It would be strange to do every single change we make over PRs and we've not been doing that in the past eighter.


@taroth21  As you are saying, it has already been fixed. Thanks!


It would require a lot of modifying CPython files, probably not worth it.


maybe add that info into code comment for clarify


I think this line was supposed to be removed altogether.


Sure, I created a pull request (I think...)


TODO : Beaucoup de trucs sont pas propres dans le script. Commencer par débugguer la console quand le script est lancé depuis level_logic.blend.


Unfortunately, this didn't actually fix the notification issue.


Nice patch.  Hope it passes!  If you end up going with the current values you can of course simplify to
int score = level * 16 + sp->moveCount - sp->depth * 4;
without changing functionality.


nice. i've always implemented it on my own:

```php
$foo = in_array($var, array('true', 'yes', 1));
```


@SeismicData/owners You mind if I reset master to 059a892fa9ba9333a410a734cd9576e9182de1bc (before provenance code was added) or 42ba7b50e1bc40fc3c11ac4ea260af62ba20faf2 (can be easily fixed, I think)?


Koop server is long gone, this section definitely needs a rewrite


Yeah that's fine. I tried earlier but had some issue getting it to work.

On Jul 13, 2015 5:24 PM, Elliott Sales de Andrade <notifications@github.com> wrote:

@SeismicData/owners<https://github.com/orgs/SeismicData/teams/owners> You mind if I reset master to 059a892<https://github.com/SeismicData/asdf-library/commit/059a892fa9ba9333a410a734cd9576e9182de1bc> (before provenance code was added) or 42ba7b5<https://github.com/SeismicData/asdf-library/commit/42ba7b50e1bc40fc3c11ac4ea260af62ba20faf2> (can be easily fixed, I think)?

—
Reply to this email directly or view it on GitHub<https://github.com/SeismicData/asdf-library/commit/ac16a15bdd7129bdbf9ddcd65c5ffd235c62e6c0#commitcomment-12143256>.


@martinmr already commented earlier on on a similar comment you made. I don't know about the state of container, yet


not sure how to handle this. It slipped through before, but if we add a side that doesn't have any data (or y/xlims specified) how do we link this to the existing plot?

I removed this because I made a jump to `plot.window()` instead of the par sets because there is just way too much code to copy to reproduce what is done in there. Became especially hard w/ axis and changes to par()$usr.


new proposal: std::vector<K> TCacheMap::GetKeys()


Isn't part of this change that you can bypass the input filter and set the input paths directly at the file set level? Now that will work with PFS, but not with TPFS?


@mpuri instead of saying `userId` same something like `where the hash and range key have to be domain model specific attributes`


Whoops! Seems like you'll want to remove that log :-)


Damn.  How sloppy of me.  It's worth noting that this class isn't actually used anywhere yet, but this certainly worth fixing.
Additionally, the null check isn't necessary either, since instanceof already returns false if the object is null.


Nice!


I'm only doing what the webbook's saying me ¿?


Oh I'm sorry I could have totes done that :)


Why would it be strange? PRs allow for peer review as well as automated review, so I do not think it is a terrible idea.

As far as running CI on deploy, sure seems like a good idea, open to a pr implementing this. However this raises a good question, what if CI fails should it deploy?

Lets play out this thought experiment if we say... just commit to master and master then breaks, we then have to apply fixes directly onto master because we made a mistake, now in the rush to fix master we apply another broken commit, quickly our commit log begins to look like as I am sure we can all relate to in real world projects:

```log
* Fix Fix Fix gahhh
|
* Really Fix new feature
|
* Fix new feature
|
* Add new feature
```
In a sense this breaks the ideal approach of [atomic commits](https://en.wikipedia.org/wiki/Atomic_commit). which we currently strive for (source needed).

What harm does opening a PR do? In my mind it does many positive things, to name a few:

1. It forces peer review,
2. It slows things down, giving people time to think about an implementation and offer ways to improve it
3. It allows the author to reorder their commits and split code up into logical chunks


Otherwise, +1.


Any other ideas why this didn't converge? @xhqu1981


Please open PRs for now:

xref: https://github.com/tastejs/todomvc/commit/c5cb4dadada23a9de2d2db7c4db827b05e4ab3a0#commitcomment-12143363


set_target_properties( classad PROPERTIES VERSION ${PACKAGE_VERSION} SOVERSION 7 )


Can you give us instructions in howto reproduce this error?


...good call!


I know, this PR is 16 months old, lot's have changed since then. Anyway, I think the real feature to detect is wether the device is capable of showing a browser view on only part of the screen real estate. If it's always fullscreen, backstretch should use the device screen size instead of the viewport.


@blangel I've pushed the update.


Yeah, that's great, thanks for doing this required refactoring!


I reset `master` and added `old-provenance` branch which you can pull your original changes out of. I will try and fix `master` soon.


"Each task" (not plural)


Add this chunk upstream
https://review.openstack.org/#/c/201350/


# List of changes to input files:

## Renamed files:
* all_projects.tab -> project_info.tab
* existing_projects.tab -> proj_existing_builds.tab
* project_specific_costs.tab -> proj_build_costs.tab
```bash
mv all_projects.tab project_info.tab
mv existing_projects.tab proj_existing_builds.tab
mv project_specific_costs.tab proj_build_costs.tab
```

## Renamed columns:
In variable_capacity_factors.tab:
* prj_capacity_factor -> proj_max_capacity_factor
```bash
find . -name variable_capacity_factors.tab | while read p; do
    sed -e 's/prj_capacity_factor/proj_max_capacity_factor/' -i '' $p;
done
```
In load_zones.tab:
* cost_multipliers -> lz_cost_multipliers
* ccs_distance_km -> lz_ccs_distance_km
* dbid -> lz_dbid
```bash
find . -name load_zones.tab | while read p; do
    sed -e 's/cost_multipliers/lz_cost_multipliers/' \
        -e 's/ccs_distance_km/lz_ccs_distance_km/' \
        -e 's/dbid/lz_dbid/' \
        -i '' $p;
done
```

In loads.tab
* demand_mw -> lz_demand_mw
```bash
find . -name loads.tab | while read p; do
    sed -e 's/demand_mw/lz_demand_mw/' -i '' $p;
done
```

## Moved data from little files into bigger files:
Project stuff
* cap_limited_projects.tab -> project_info.tab
* proj_heat_rate.tab -> project_info.tab
* proj_variable_costs.tab -> project_info.tab

Generation Technologies
* generator_energy_sources.tab -> generator_info.tab
* ccs_info.tab -> generator_info.tab
* storage_info.tab -> generator_info.tab
* gen_unit_commit.tab -> generator_info.tab

Load zone stuff
* local_td_existing.tab -> load_zones.tab

When merging the small files into the larger files, remember to insert a dot . into any cell that does not have a value. For example, if you specify a heat rate for a solar project instead of using a dot, the model will report an error.

## Added optional new columns:
In project_info.tab
* proj_forced_outage_rate
* proj_scheduled_outage_rate

## Deleted unnecessary column:
In generator_info.tab
* g_is_dispatchable

To change, open file in text editor, copy contents to a spreadsheet, delete the column, copy contents back to the text editor and save it. Many spreadsheets will mess up line endings when they save tab delimited files.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17880/testReport/) for this commit**


Good catch. Now we would need your full name and the Signed-Off-By line, see above.


The blank line here quietly rescues us, but for correctness can you adjust line 39 to drop the final \


You should only be looking for enterprises.33049.1.1.1
By including the "1012", that's the SX1012 device.

On my SX1036, it shows up as the follows:

```
:~# snmpget -v2c -cIHME sx1036 sysObjectID.0
SNMPv2-MIB::sysObjectID.0 = OID: SNMPv2-SMI::enterprises.33049.1.1.1.1036
```


Nice! (╯°□°）╯︵ ┻━┻


yay!


I'll sort this tomorrow!


That might not be good either, depending on how apple and android handle their multitasking frames in their latest releases of their iOS.


Clever, but having the cost as a variable that then gets multiplied keeps the value in one place.

For example, if we use your solution:
``` return self.getsDiscount ? 18 : 24```
and then the value of vodka goes up to 27.50, you'd need to get your calculator out and see how much 75% of 27.50 is.

However, if we keep the declaration, we only need to change the full value, like so:
``` NSUInteger cost = 27.50;```
```return self.getsDiscount ? cost * 0.75 : cost```


Такие комментарии не нужно оставлять.

Чтобы они не добавлялись автоматически, можно настроить в phpStorm:
*File | Settings... | File And Code Templates | PHP Class*
В открывшемся шаблоне удалить строку `#parse("PHP File Header.php")`


PR if you want a review or for larger changes, but many changes are minor and can just be committed directly. The overhead would be extremely high if every change needed to be a PR.


Ok


Watch your indentation. This should be one tab to the left.


Again, watch your indentation.


You could also do a .hist() in stead and do without the sorting!


Great work on the police killings data!


Нужно поправить форматирование (убрать лишние пустые строки, лишние пробелы, добавить недостающие пустые строки и т. п.), добавить комментарии к классам, свойствам и методам.

Сеттеры должны возвращать `return $this`.


"...it *is* the most..."


hmm, guess I disagree then based on what I wrote above


map is fine; unordered_map is just nicer, that's it. Of course, to use unordered_map, need to define `std::hash<CString>` (just delegate it to `std::string`)
You can return MCString here.
Btw, probably MCString should be unordered_map instead of map.
A problem with std::vector TCacheMap::GetKeys() is that keys can get outdated between call to GetKeys(), and access to the key.


this is an abstract type, so it is not the right test. the interface for `Ref


I would just say "If using hackney, ensure that it is started". Actually now that I'm thinking about it, I would probably remove the dependency on hackney from rebar.config as well and let people add it themselves if they want it.


A very subjective thing, but try not to name your variables with a single letter. Try using, ```numberCounter```, for example. This makes it so that in more complex for loops, you know exactly what you're doing.


do we need Spree.ajax?


Indentation!


Правильнее было бы тут использовать `+` вместо `*`, а иначе в callback функцию будут попадать даже пустые строки.


This should read `majors['sample_unemployment_rate'] = 1 - majors['sample_employment_rate']`


All in all great work on this homework! You clearly have a great grasp on this material


@bryanbrazil please test latest master thoroughly. I had a big cleanup waiting in some other branch which I missed to pull in before. (that´s also why I "overwrote" your PR)
Same for @HitcherUK, would be nice if you could confirm that none of the calls you´re using is broken.


Will test tonight and report back, thanks!


Ah, yes, this is the bug where the server gratuitously writes a file into the file system when it starts.   It should just treat every directory as a container in the absence of any meta file.


Тут метод вернёт значение `$this->replace`, а должен вернуть ссылку на объект класса `$this`.
Должно быть так:
```php
public function setReplace($newReplace)
{
    $this->replace = $newReplace;
    return $this;
}
```


What the functions do is not clear from their name. `ui*` will always execute asynchronously. `do-ui*` will either execute right now if called from the UI thread, or delegate to `ui*` (and thus execute asynchronously).
In the first case, wrapping the result in an atom ensures the return type is the same (a ref that can be derefed) in both branches of the `if`.

Two remarks about these functions:
- using and dereffing the promise returned by `ui*` must be used with care, because if called from the wrong thread, we can introduce deadlocks (imagine if `ui*` is called from the UI thread itself, and we deref the result, waiting forever for the promise to be delivered).
- this is problematic, to the point that I think we should fix it. If the calling code wants to use a promise, it should create it itself. Thus `ui*` would not return a promise anymore. Of course, all codes currently using the return value of `ui*` when calling it will have to be fixed.
- I would like to see if `do-ui*` can be removed. It is unclear how to use it correctly.


pipebackend.cc: In member function 'virtual void PipeBackend::lookup(const QType&, const DNSName&, DNSPacket*, int)':
pipebackend.cc:116:43: error: 'const class DNSName' has no member named 'toStingNoDot'
       if(d_regex && !d_regex->match(qname.toStingNoDot())) {


I would mention that it comes in as an `array` object. Also mention the case of multiple arguments and the splat needs to be the last one. Also mentioning what happens if they put nothing in!


This test is there because there were some `WidgetDisposedException`. I don't see this test in the new code anymore, I guess we may get the problem again, then ...


no I think it's ok to just remove it


I actually changed this to user `iter_docs` in a later commit, but I didn't know about the difference between `<couchmodel>.view` and `<couchmodel>.get_db().view`, so thanks! Will be useful.


can we actually bump the version to 0.4.0 ?


What accounts for larger or minor changes I up in the air though. I'm just against having to do PRs for absolutely anything.


It might be better to use `success:` and `error:` callbacks, since this will miss statuses other than 200 and 400.


Indeed, so switched back to map. :P


Eilt nicht, sollte nur vor dem nächsten Release gemacht werden, oder?


You know about my context menu add-on, right? Ideally there shouldnt be any buttons added to context menu by the skin.


unsynchronized.


@chris-kuhr
Thank's for contributing your additions.
I just had a quick look at it and did some comments on the code.
In general, I am not really happy how you implemented the new feature(s), I would prefer to have clear config params for voltage, current, power and energy instead of reusing the socket numbers used for the PMS-LAN device. These params can be made optional.
What do you think ?
Best
Hans-Jörg


Yeah comment is wrong (obviously)


ctz?


There was a reason. But this whole `STExchange` thing needs to be rethought


True, ideally they would provide a way of reporting the maximum viewport and changes to it. A viewport that excludes stuff like a location bar that could slide up etc.


wait - why? beast, boost, ed25519, stdlib?


Bundle qualifier should be 1.8.0


next() is available for iterators in Python 3 too under a different name: __next__(). Did you try that?


would it be better here to do a subshell instead of piping to sh?

    $("zfs clone ${_zfsconfig} $fs@$uuid $cfs")


latest commit changed the search string to "var sockstates ="


84691154_AutomateBuildingOfDocs (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


Thanks, I'll check it out tomorrow.


Hmmm, how does the new method work? Like SIMPLE or line SIMPLE_LOOPS? I think we should not add it here, just use it instead of the old method, if the number of iterations is bigger than some limit.


please don't remove this trace logger.


Do you want Try/Catch and Ignore. here like in the directory case?


Don't force push after a day :)


I think the adjlist operations belong to adjlist.c


Yes, ideally, I'd like this to work for any abstract ref, but I'm not sure what the interface to the intrinsic should be, since it needs to know the type of the parameter. Thoughts?


I think you forgit to commit "actors/sfx/underwaterlight.txt"...


Absurd that basically nobody can get indentation actually right :p


should be itemType


Is this a copy paste error? Or do you actually need to check the size twice?


To make rspec successful on local machine,
1. I install brew install mysql because bundle install mysql2 in incorrect location.
2. rake jetty:start


972154-NewSimpleChilledCeiling (RKStrand) - Win64-Windows-7-VisualStudio-12: OK (1688 of 1700 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.29%25-yellow.svg)


there is no thermostat


This seems like the kind of thing you could move to a @Before method.


see above, there is no thermostat and no setpoint


I think the `cors` dependency is not used in the project, though added to `package.json`.


please change logger level to debug


Should this really be mutable?


Hi Helen,

Perfect thanks! I’ve just spent a while trying to understand this - and now I think I do, I’d better go to bed. 😊

But I will get back onto this later in the week. Thanks for uploading the real files for me. I see the problem was I missed out the “ marks.

I’ll check with you on images. I wasn’t certain about the Sladdin one but I’m glad that’s fine. It’s a very good one of you both.

See you tomorrow

Alice

From: Helen
Sent: Sunday, 12 July 2015 22:54
To: polorum/polorum.github.io
Cc: Ojedalicia

https://github.com/polorum/polorum.github.io/commit/19b51a2c2436cc64638024f5bfd1b994f48a1499

Check out the new commit, you should be able to pull it down to the Alice
Experiments branch, but will then probably have to stash these changes
(save them in a file somewhere that is outside of the polorum.github.io
folder) and then merge the master into Alice Experiments (overwriting your
changes) before putting the stashed files back and making a new pull request

Helen Williams
hlwilliams92@gmail.com

On Sun, Jul 12, 2015 at 10:37 PM, Helen Williams <hlwilliams92@gmail.com>
wrote:

> Ok, I'm just going to pull your branch and check it out. I'll take a look
> at it, and probably upload all the images to the site (I don't like the
> idea of using images that aren't hosted on our server)
>
> Also, we do have permission to use all the pictures that you've added to
> the website, but it is something that we need to be careful about, so just
> be aware of that. And if you're not sure if we have the rights to use a
> certain photo, I can probably answer that. :)
>
> Helen Williams
> hlwilliams92@gmail.com
>
> On Sun, Jul 12, 2015 at 10:28 PM, Ojedalicia <notifications@github.com>
> wrote:
>
>> Helen please review my changes. Ignore first three images added. I'm
>> trying out images on our website - but I don't know exactly how to store
>> images on our file and make them link (said 'broken link' when I tried).
>> Let me know what you think
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/polorum/polorum.github.io/commit/dd3312f4f3fb8fb8faec7504f6da73b9feef421b#commitcomment-12124298>
>> .
>>
>
>

—
Reply to this email directly or view it on GitHub.


Why the `ifdef` for Windows here? Doesn't the same apply to other systems as well? We shouldn't rely on zend_long and long being the same in cases where it matters.


Oh, I see. So this is orthogonal to the actual method. Hmmm. I think I would still like to do this automatically. And maybe add a separate argument for it later, if needed.


In my humble opinion, PRs are way too time consuming for both the reviewer and the comitter. Also when I see @arthurvr, @sindresorhus or any other comitter doing commits I don't see much errors getting caused. It would also be noisy just for watchers of the repo.

for your interest Sam you're the only one that doesn't commit to master often.


I don't see reasons to don't use duktape.[c|h] in our code since its the recommended way by duktape website and repository.
"This repository is intended for Duktape developers only, and contains Duktape internals: test cases, internal documentation, sources for the duktape.org web site, etc"

I'll list some of the problems we might have if we use a git submodule or anything like this.

1 - Its one more repo to be downloaded.
      duktape - 53.87MB
      duktape-releases 18.71MB
      instead of 2.75MB (lots of useless files as pointed out by duktape website, this will be a problem in some platforms that lack internet speed)
2 - Its one more thing to do in our build (could matter for some environments that lack processing power)
3 - The license can change at any moment and since we would be doing git clone etc we wouldn't even realize, this could raise legal problems to us.


Should this really be an enum? Seems like it'd make a better final class w/ private constructor (or some other static singleton pattern).


I don't really see the issue here, it's fairly easy to work around for anyone knowing git.


Mind changing:

Tracking server license: `Apache License 2.0`

to

`Apache License 2.0`

Then I'll merge the pull request.


Hmm, oops. Missed a file in the previous commit. Oh well.


Thanks, this works for me. I don't like that it works, but it works.


&& has higher prio, but is it what you mean here? Can you add parens?


You should just remove this function and you are good to go!


LGTM


Other portion of this commit was missed accidentally and is in fdaa4dc


@chris-kuhr
Thank's for contributing your additions to the binding.
I had a quick look at the code and left some inline comments.
I am not quite happy with your approach and would prefer to have clear config params for voltage, current, power and energy, instead of reusing the socket numbers of PMS-LAN devices. This params could be made optional.
What do you think ?
Best
Hans-Jörg


@cactus yeah, that's what I thought first too - but after bashing my head against the wall for an hour I gave up on that idea. For some obscure reason it fails in a subshell... but not when piped.


yes


Didn't look to closely at this test, I suppose it repros and the NPE and verifies that the fix indeed fixes it?


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


lgtm


I see these are putting the full namespace in now. Has there been a change to the included assemblies to require this?


LGTM :+1:


@jdewinne @bmoussaud: Something to consider for a separate commit, but we should probably call this task `Deploy`, and similarly call the others `InvokeControlTask`, `MigrateDeploymentPackage` and `GetLatestPackageVersion` or so?

We would then need an upgraded to rename the task in the repo, though. And, once 4.7.0 is out, also one to rename them in the archive..?


It's the encoding of the XML response - I don't think we know that encoding.

But I'd rather guess/assume utf8 than use the String constructor that uses the os-default encoding.


No, as it mean that if the file is physically reachable, them the line 106 will be true, so instead of leaving out any special parameter from the command line we would add *open* what is not good for this case. Anyway it could be more clear to move those conditions into line 106 with an inversion.


Hm ok. We're treating ed25519 as a separate hierarchy. Carry on.


just the encoding.


I'm going to need some error logs or something to go by because I've tested this twice now on different accounts and it's working. Are you sure you're running source tip from the CloudMan repo?


:cool:


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.14](http://pixelated.design/build/viewLog.html?buildId=37&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 87 Build time: 00:00:12


Yeah it should be abstract


Perhaps something like https://github.com/jpnurmi/znc/commit/01db01a6e6d51b42065062f2acab5df543bf5dd8, or should leave it out for now, until we know better what is needed?


It looks like everything has been merged successfully.
Querying categories for combo-box is commented because it uses SQL-dependent way, not MVC way. We should rewrite it.
Now when we can save categories, I will add saving transactions to database.
Also it doesn't look like we need Category and Transaction classes at all for now. But maybe we will need them later when implementing calendar view of transactions?


hmm. I wonder why it was failing. Clearly my example is wrong because it has quotes of course. I will poke around and see if I can figure out what may be different about the subshell.


I like that you guarded the file name output by verbose, but I would like the verbose mode to include the digest for debugging purposes.


I assume this is for code coverage purposes.  Should we enshrine the guideline somewhere?


Nice using `--stdin`, but let's use `-z` while we're at it.


I haven't worked with PRs that much, so do you do it (which is fine to me) or should I add another commit to my repo and then create the PR again?


I noticed it because of code coverage, but I removed it because we had code that was impossible to be hit (I verified all paths that lead to this).


It cannot be squashed with the first one, because it requires bash (the 2nd commit).

I could squash them all into one.

> Add a comment explaining why we use pipefail

Will do.


Можно в названии коммита писать `Closes #XXX` или `Fixes #XXX`, тогда гитхаб автоматом будет закрывать нужные issues.


No need for this


Я знаю. Каждый раз забываю, егда строчу в баше.
My bad.


This starts to address the problems raised in issue #2


Yeah, probably.  I'll change that.


Forgot to reference #3 in the commit message


Насчет important'ов - те, что я прочесал, были не нужны. Ну, фиг знает.


That's a good change


И надо бы ещё `:before` и `:after` писать с двумя двоеточиями `::before`, `::after`. Потому что это псевдоэлементы, а не селекторы выборки, вроде `:first-of-type`.


Was this ever merged into rvagg/node-libssh?


You bet. That's why I included !System.HasAddon(context.extendedinfo.dialog) as a visible condition.
I added the functions for people not aware of the add-on.


Одно двоеточие браузеры поддерживают для совместимости с древними IE.


:wink:


4973_heatpump_defrost_bug (nmerket) - x86_64-MacOS-10.9-clang: OK (1673 of 1677 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


Hey @payingattention , so sorry for the long wait with your tip! We discovered that the Github API only returns 30 comments per API call, and our bot didn't detect your comment because this was a particularly long comment thread. Tipping on this thread should work now - have a high five on me for your inconvenience. Cheers! @changetip


А некроопера?


Thanks, this looks like a good change. Will merge after the minor details are addressed.


@dpavlenkov Please let me know if the current code will work for you,if we are missing something we're happy to bring it back, it was my understanding that it may be duplication. Jared and I have recently been discussing attaching events to the OrderTicket object itself, which would also provide task support and the great deal of flexibility that follows :).

We've opened a new issue for this: https://github.com/QuantConnect/Lean/issues/140


Is this test just run manually?


It actually shouldn't make much of a difference but apparently there are versions of mime magic that do not correctly detect PHP files. I originally intended to ignore file extensions and go for the mime type. Due to the mentioned issues, it "evolved" to an optional paranoid check. Since I made that check optional, the feature got renamed to "trusting" mode. I for some reason didn't rename it in this class though and thus broke the logic.

So I'm not sure whether or not this qualifies as a debug thing.


There doesn't seem to be a `lazy-motion:search-forward`...?


This should be && not || I think


I think so...

C:\Users\Anton\PhpstormProjects\Symfony Training>composer -V
Composer version 1.0-dev (c36d2a2e501315934b6968efa3cea41dd27f2511) 2015-07-13 1
3:28:10

C:\Users\Anton\PhpstormProjects\Symfony Training>


No idea. Currently I'm making structure based on the Swagger docs as I go.


Да. Ещё с седьмой версии.


Does this need the same `if( ! empty( $this->start ) && ! empty( $this->end ) ) {` check as above?


1682_waterheater_stratified (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (2184 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.6%25-yellow.svg)


great


Is it possible for service code to use this api and override this?


The main difference actually is not in this class but on the calling side where ```$trusingMode == true``` is passed but it was interpreted as ```$paranoidMode == true``` on the receiving side.


(CMessage& Message, CClient& Client);
similar to existing OnSendToClient


Actually, does this even need a subshell at all? Just a bare expansion would work I think?

    zfs clone ${_zfsconfig} "$fs@$uuid" "$cfs"


Incomplete Javadoc.


LGTM other than the only comment.


Oh I get it.  lazy-motion:forward does different things depending on whether it's invoked in the text editor or the lazy motion box (I think).  Having multiple bindings to lazy-motion:forward in your keymap doesn't actually mean there's duplicate functionality.


Is that a MIPS device ? Actually I did some search, and I found that there aren't any Android MIPS devices yet, the first one is expected to release next year: http://www.pcworld.com/article/2601040/first-mobile-device-with-mips-64bit-processor-coming-in-2016.html


I'm not sure if I like this code. It is basically an experiment with LINQ statements. The code runs a little bit slower. More exploration is necessary.


That works!. Anyway I was totally misguided. `parser_is_flag` checks on `sub(1,1)` so override that is totally irrelevant.

https://github.com/albfan/clink-completions/commit/1f02095659b83a50f501e6ca219d96249d3a4323


@fieranmason You should fix the email associated with your git installation, it's incorrect! Check the creator of this commit and look at the "?" icon.


97902934_ZoneMixing (macumber) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


One comment above


You bet. That's why I included !System.HasAddon(context.extendedinfo.dialog) as a visible condition.
 I added the functions for people not aware of the add-on.

Date: Mon, 13 Jul 2015 14:53:25 -0700
From: notifications@github.com
To: Rapier@noreply.github.com
CC: christian_gade@hotmail.com
Subject: Re: [Rapier] Added Extended Info button to library context menu. (1ac9de4)

You know about my context menu add-on, right? Ideally there shouldnt be any buttons added to context menu by the skin.

—
Reply to this email directly or view it on GitHub.


@yobimarbella ready for review


Great! I was a little confused why is_flag() needed overriding because the forward slash is in the middle of what completion considers a word. I thought there was a subtle bug somewhere but it doesn't sound like I need to go looking for that now.


Hey, Heliomance? How can we add more flaws in the HeroForge? thanx in advance


don't use different type for factor and maxfactor - this may lead to nasty errors in future


97902934_ZoneMixing (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


getvisblerange kann man da dann auch ganz gerne usen :D


great


artview must be imported after this 3 lines (not before), otherwise it will fail if using in-place (not install). This lines are actually adding the folder to the import path


Any estimate on when this will be available via jCenter?

Thanks!


@pannon what @cactus suggests worked for me as well.


I was trying to come up with a generic hook whose purpose is to allow customizing the CMessage -> CString conversion. Any changes to the message object at this point would be lost, so I made it const. Perhaps something like "OnPrepareTagsToClient(const CMessage& Message, MCString& mssTags)" would be better then? Also, is the client argument necessary, because CMessage has GetClient() for client-related messages?


When using stuff like this, we will have to make sure to clean up abandoned assignments at the end of each day. Otherwise there could be dangling assignments taken but not submitted from previous days (and they might have 20 games).


This should be better,
1. export ARCH=arm && export CROSS_COMPILE=<toolchain> && make ariesve_defconfig (using your config)
2. then make menuconfig > save > exit
3. open .config and copy all of line, replace it in ariesve_defconfig
4. git add . && git commit --amend && git push -f <your repo> <brunch>


why `[mini]`?  just curious.


Ah. I'm glad you figured out. :)

Yeah, that Sladdin one was taken by Launch.ed for their media. They've said
that we can use it online, but need to check with the photographer if we
want to use it in print.

Helen Williams
hlwilliams92@gmail.com

On Mon, Jul 13, 2015 at 11:02 PM, Ojedalicia <notifications@github.com>
wrote:

> Hi Helen,
>
>
> Perfect thanks! I’ve just spent a while trying to understand this - and
> now I think I do, I’d better go to bed. 😊
>
>
> But I will get back onto this later in the week. Thanks for uploading the
> real files for me. I see the problem was I missed out the “ marks.
>
>
> I’ll check with you on images. I wasn’t certain about the Sladdin one but
> I’m glad that’s fine. It’s a very good one of you both.
>
>
> See you tomorrow
>
> Alice
>
>
>
>
>
>
>
>
> From: Helen
> Sent: Sunday, 12 July 2015 22:54
> To: polorum/polorum.github.io
> Cc: Ojedalicia
>
>
>
>
>
> https://github.com/polorum/polorum.github.io/commit/19b51a2c2436cc64638024f5bfd1b994f48a1499
>
> Check out the new commit, you should be able to pull it down to the Alice
> Experiments branch, but will then probably have to stash these changes
> (save them in a file somewhere that is outside of the polorum.github.io
> folder) and then merge the master into Alice Experiments (overwriting your
> changes) before putting the stashed files back and making a new pull
> request
>
> Helen Williams
> hlwilliams92@gmail.com
>
> On Sun, Jul 12, 2015 at 10:37 PM, Helen Williams <hlwilliams92@gmail.com>
> wrote:
>
> > Ok, I'm just going to pull your branch and check it out. I'll take a
> look
> > at it, and probably upload all the images to the site (I don't like the
> > idea of using images that aren't hosted on our server)
> >
> > Also, we do have permission to use all the pictures that you've added to
> > the website, but it is something that we need to be careful about, so
> just
> > be aware of that. And if you're not sure if we have the rights to use a
> > certain photo, I can probably answer that. :)
> >
> > Helen Williams
> > hlwilliams92@gmail.com
> >
> > On Sun, Jul 12, 2015 at 10:28 PM, Ojedalicia <notifications@github.com>
> > wrote:
> >
> >> Helen please review my changes. Ignore first three images added. I'm
> >> trying out images on our website - but I don't know exactly how to
> store
> >> images on our file and make them link (said 'broken link' when I
> tried).
> >> Let me know what you think
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/polorum/polorum.github.io/commit/dd3312f4f3fb8fb8faec7504f6da73b9feef421b#commitcomment-12124298>
>
> >> .
> >>
> >
> >
>
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/polorum/polorum.github.io/commit/dd3312f4f3fb8fb8faec7504f6da73b9feef421b#commitcomment-12143853>
> .
>


EvansHVACObjects (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


While you're at it: https://github.com/EdtechFoundry/loopback-testing/blob/master/test/test.js#L16


@skarekrow @cactus just submit the PR


Thanks. This code was copied from someone else and modified. Needs of course to be reviewed and reoptimized.


@pannon no need, I changed it. Testing one last time before I commit.


The extra quoting I did probably isn't necessary. Just habitual from dealing with portable shell stuff on systems at work that sometimes end up with spaces in the names of things (the horror! ;_; ).

```
diff --git a/lib/ioc-zfs b/lib/ioc-zfs
index aa9e894..5c10b02 100644
--- a/lib/ioc-zfs
+++ b/lib/ioc-zfs
@@ -80,20 +80,19 @@ __create_jail () {
         zfs snapshot -r $pool/iocage/releases/$release@$uuid
         for fs in $fs_list ; do
             cfs=$(echo $fs | sed s#/releases/$release#/jails/$uuid#g)
-            #echo "cloning $fs into $cfs"
-            echo "zfs clone ${_zfsconfig} $fs@$uuid $cfs" | sh
+            zfs clone ${_zfsconfig} "$fs@$uuid" "$cfs"
         done
         _configured="1"
     elif [ "${2}" = "-e" ] ; then
         _zfsconfig="$(__configure_jail generate)"
-        echo "zfs create -p ${_zfsconfig} $pool/iocage/jails/$uuid" | sh
+        zfs create -p ${_zfsconfig} "$pool/iocage/jails/$uuid"
         zfs create -p $pool/iocage/jails/$uuid/root
         _configured="1"
     elif [ "${2}" = "-b" ] ; then
        export type=basejail
        _zfsconfig="$(__configure_jail generate)"
        zfs snapshot -r $pool/iocage/base@$uuid
-       echo "zfs create -p ${_zfsconfig} $pool/iocage/jails/$uuid" | sh
+       zfs create -p ${_zfsconfig} "$pool/iocage/jails/$uuid"
        zfs create -o compression=lz4 -p $pool/iocage/jails/$uuid/root/usr

        for fs in $bfs_list ; do
@@ -181,7 +180,7 @@ __clone_jail () {
             if [ $(echo $cfs | grep data$ | wc -l) -eq 1 ] ; then
                 zfs clone -o mountpoint=none -o jailed=on $fs@$uuid $cfs
             else
-                echo "zfs clone ${_zfsconfig} $fs@$uuid $cfs" | sh
+                zfs clone ${_zfsconfig} "$fs@$uuid" "$cfs"
             fi
         done
     else
@@ -190,7 +189,7 @@ __clone_jail () {
             if [ $(echo $cfs | grep data$ | wc -l) -eq 1 ] ; then
                 zfs clone -o mountpoint=none -o jailed=on $fs@$snapshot $cfs
             else
-                echo "zfs clone ${_zfsconfig} $fs@$snapshot $cfs" | sh
+                zfs clone ${_zfsconfig} "$fs@$snapshot" "$cfs"
             fi
         done
     fi
```

Also I think these could be condensed to remove subshell invocation too.

```
diff --git a/lib/ioc-rc b/lib/ioc-rc
index caf291e..b429d1c 100644
--- a/lib/ioc-rc
+++ b/lib/ioc-rc
@@ -360,7 +360,7 @@ __stop_jail () {
     echo "* Stopping $fulluuid ($tag)"

     echo -n "  + Running pre-stop"
-    echo "$exec_prestop" | sh
+    $exec_prestop
     if [ $? -ne 1 ] ; then
         echo "         OK"
     else
@@ -402,7 +402,7 @@ __stop_jail () {
     fi

     echo -n "  + Running post-stop"
-    echo "$exec_poststop" | sh
+    $exec_poststop
     if [ $? -ne 1 ] ; then
         echo "        OK"
     else
```


EvansHVACObjects (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Actually it turns out that now this broke everything. I forgot to do a ```make install``` after I changed things since this machine had them installed before.


rcData should be updated on all iterations, even when factor is 0 (either special case it, of just use calculation below  with  factor == 0)

As implemented now, rcData won't be update only when new data did not arrive - this may happen very infrequently and cause hard to detect bugs


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (652 of 652 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-5.49%25-green.svg)


tested locally, r+


:+1: I like this feature.


@e2 Perhaps you could open an issue explaining those obscure issues and pointing to one of those plugins using guard-minitest that fail if you add the dependency. In case someone wants to take a stab at it. :)


Does processRx always overwrite rcData?


What are s & s1 here? perhaps workingSentence & nextString? just a matter of style :)
Why do we need to grab a Substring(1)? are you always removing a comma?
Have you tried this instead?

    var tooltip = hostNames.Aggregate((sentence, next) => sentence + "," + next);

The format of the call you are using is more for working with numbers e.g.

    var multipliers = new []{10,20,30,40};
    var multiplied = multipliers.Aggregate(5, (a,b) => a * b);
    Console.WriteLine(multiplied); //Output 1200000 ((((5*10)*20)*30)*40)


I would mark this as "final". pretty much all (most) variables should be final for a variety of reasons, including code readability, safety, caching, etc.


develop (axelstudios) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


note that if you add static import for SauceEnvironmentUtil.generateTunnelIdentifier , your tests become more readable


In the context of JSON files, "Type=" key seems wrong.


done with the review for this commit


@emmenko something is still broken in 1.4.1


What's the problem?


Well it is not updated. No point to do rcData = rcData.

When the factor is gone it goes through normal current failsafe mechanisms etc....


FUCK!!! locked mutex and not unlocked.... @#!S^&#$


If this test passes:
http://tests.stockfishchess.org/tests/view/55a429d10ebc590abbe1ba5a

I would suggest an extra `SPRT(-4,0)` at STC, using 16MB Hash, before to commit. Just to check for no regression with low hash pressure.


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


hmm. using sh -x to print commands I see this:

```
+ zfs clone -o 'org.freebsd.iocage:interfaces="vnet0:bridge0,vnet1:bridge1"' -o 'org.freebsd.iocage:vnet="off"' -o 'org.freebsd.iocage:host_hostname="8b3b32b5-29b0-11e5-964e-0cc47a31451a"' -o 'org.freebsd.iocage:hostname="8b3b32b5-29b0-11e5-964e-0cc47a31451a"' -o 'org.freebsd.iocage:ip4_addr="none"' -o 'org.freebsd.iocage:ip4_saddrsel="1"' -o 'org.freebsd.iocage:ip4="new"' -o 'org.freebsd.iocage:ip6_addr="none"' -o 'org.freebsd.iocage:ip6_saddrsel="1"' -o 'org.freebsd.iocage:ip6="new"' -o 'org.freebsd.iocage:defaultrouter="none"' -o 'org.freebsd.iocage:defaultrouter6="none"' -o 'org.freebsd.iocage:resolver="none"' -o 'org.freebsd.iocage:exec_fib="0"' -o 'org.freebsd.iocage:vnet0_mac="none"' -o 'org.freebsd.iocage:vnet1_mac="none"' -o 'org.freebsd.iocage:vnet2_mac="none"' -o 'org.freebsd.iocage:vnet3_mac="none"' -o 'org.freebsd.iocage:devfs_ruleset="4"' -o 'org.freebsd.iocage:mount_devfs="1"' -o 'org.freebsd.iocage:exec_start="/bin/sh' '/etc/rc"' -o 'org.freebsd.iocage:exec_stop="/bin/sh' '/etc/rc.shutdown"' -o 'org.freebsd.iocage:exec_prestart="/usr/bin/true"' -o 'org.freebsd.iocage:exec_prestop="/usr/bin/true"' -o 'org.freebsd.iocage:exec_poststop="/usr/bin/true"' -o 'org.freebsd.iocage:exec_poststart="/usr/bin/true"' -o 'org.freebsd.iocage:exec_clean="1"' -o 'org.freebsd.iocage:exec_timeout="60"' -o 'org.freebsd.iocage:stop_timeout="30"' -o 'org.freebsd.iocage:exec_jail_user="root"' -o 'org.freebsd.iocage:exec_system_jail_user="0"' -o 'org.freebsd.iocage:exec_system_user="root"' -o 'org.freebsd.iocage:mount_fdescfs="1"' -o 'org.freebsd.iocage:mount_procfs="0"' -o 'org.freebsd.iocage:enforce_statfs="2"' -o 'org.freebsd.iocage:children_max="0"' -o 'org.freebsd.iocage:login_flags="-f' 'root"' -o 'org.freebsd.iocage:securelevel="2"' -o 'org.freebsd.iocage:allow_set_hostname="0"' -o 'org.freebsd.iocage:allow_sysvipc="0"' -o 'org.freebsd.iocage:allow_raw_sockets="0"' -o 'org.freebsd.iocage:allow_chflags="0"' -o 'org.freebsd.iocage:allow_mount="0"' -o 'org.freebsd.iocage:allow_mount_devfs="0"' -o 'org.freebsd.iocage:allow_mount_nullfs="0"' -o 'org.freebsd.iocage:allow_mount_procfs="0"' -o 'org.freebsd.iocage:allow_mount_tmpfs="0"' -o 'org.freebsd.iocage:allow_mount_zfs="0"' -o 'org.freebsd.iocage:allow_quotas="0"' -o 'org.freebsd.iocage:allow_socket_af="0"' -o 'org.freebsd.iocage:host_hostuuid="8b3b32b5-29b0-11e5-964e-0cc47a31451a"' -o 'org.freebsd.iocage:memoryuse="8G:log"' -o 'org.freebsd.iocage:memorylocked="off"' -o 'org.freebsd.iocage:vmemoryuse="off"' -o 'org.freebsd.iocage:maxproc="off"' -o 'org.freebsd.iocage:cputime="off"' -o 'org.freebsd.iocage:pcpu="off"' -o 'org.freebsd.iocage:datasize="off"' -o 'org.freebsd.iocage:stacksize="off"' -o 'org.freebsd.iocage:coredumpsize="off"' -o 'org.freebsd.iocage:openfiles="off"' -o 'org.freebsd.iocage:pseudoterminals="off"' -o 'org.freebsd.iocage:swapuse="off"' -o 'org.freebsd.iocage:nthr="off"' -o 'org.freebsd.iocage:msgqqueued="off"' -o 'org.freebsd.iocage:msgqsize="off"' -o 'org.freebsd.iocage:nmsgq="off"' -o 'org.freebsd.iocage:nsemop="off"' -o 'org.freebsd.iocage:nshm="off"' -o 'org.freebsd.iocage:shmsize="off"' -o 'org.freebsd.iocage:wallclock="off"' -o 'org.freebsd.iocage:tag="hodor"' -o 'org.freebsd.iocage:template="no"' -o 'org.freebsd.iocage:rlimits="off"' -o 'org.freebsd.iocage:boot="off"' -o 'org.freebsd.iocage:notes="none"' -o 'org.freebsd.iocage:owner="root"' -o 'org.freebsd.iocage:priority="99"' -o 'org.freebsd.iocage:last_started="none"' -o 'org.freebsd.iocage:type="jail"' -o 'org.freebsd.iocage:hostid="00000000-0000-0000-0000-0cc47a31451a"' -o 'org.freebsd.iocage:cpuset="off"' -o 'org.freebsd.iocage:jail_zfs="off"' -o 'org.freebsd.iocage:jail_zfs_dataset="iocage/jails/8b3b32b5-29b0-11e5-964e-0cc47a31451a/root/data"' -o 'org.freebsd.iocage:release="10.1-RELEASE"' -o 'org.freebsd.iocage:hack88="1"' -o 'org.freebsd.iocage:sync_target="none"' -o 'org.freebsd.iocage:sync_tgt_zpool="none"' -o 'compression="off"' -o 'quota="none"' -o 'dedup="off"' -o 'reservation="none"' barrel/iocage/releases/10.1-RELEASE/root@8b3b32b5-29b0-11e5-964e-0cc47a31451a barrel/iocage/jails/8b3b32b5-29b0-11e5-964e-0cc47a31451a/root
too many arguments
```

Will fiddle around some more and open a PR if I figure anything out.


OK i do get it. So what should become new data when factor expired?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 137](https://teamcity.labkey.org/viewLog.html?buildId=260664&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabkeyTrunk :: build Build time: 00:00:00


Yeah that looks like it's trying to set on a snapshot and on a dataset. If you figure it out, please PR it.


Did you mean to commit this change to `ur`?


@jmunhoz looks good. Can you change 'Related' to 'Fixes' in the commit message? Thanks!


Authentication on retrieval causes complications for caching it on the frontend. They would need to be logged in BEFORE going to the survey URL.


OK.  I have no problem with that.


can you add the beta channel as well?


rcData is always being updated actually out of this code. Basically things stay the same if the factor expired till new data gets in.


yep, looks good to me!

Once the index is in it would be interesting to see if the .explain for this and the original query make sense.


thats a required parameter from the interface (RequestHandlerInterface)


Not sure if #228 applies here (not user-facing)


Can't wait to see the new possibilities.

PS : the Emoji button don't appear anymore, it's part of the plan too ?


I think you need to add another commit, and then create a new PR.


that is a bug we will get it fixed

On Tue, Jul 14, 2015 at 8:53 AM, iunctis <notifications@github.com> wrote:

> Can't wait to see the new possibilities.
>
> PS : the Emoji button don't appear anymore, it's part of the plan too ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/discourse/discourse/commit/20a338362fd144835ae333e185f47b975ce0cb88#commitcomment-12144557>
> .
>


Approved.


Yes, I'll be fixing it up soon.

On Mon, Jul 13, 2015 at 3:05 PM, Robin Gohmert <notifications@github.com>
wrote:

> It seems like you forgot to compile a new static tier1 library for Linux.
> Could you please add that as well? The current version will result in
> undefined symbol errors (g_pMemAlloc, V_atoi64, etc.)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alliedmodders/hl2sdk/commit/a6722dd0108da10c395ac5e094bad5ab1628b567#commitcomment-12140538>
> .
>


93469234-DemandResponse2 (vidanovic) - i386-Windows-7-VisualStudio-12: OK (1690 of 1693 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


I believe [API Studio](http://apistudio.io/) can do this (thanks @dibyom).


А то если асинхронное чтение конфига задержится, то скрипт может прочесть его джва раза с непонятным результатом.


I think the flow would be

1. Visit `/enumerate/<enumerator_only_survey_id>`.

2. The application redirects you to the login page with `?next=<previous_url>`.

3. You log in and get redirected to the enumerate URL.

Now, that may still interfere with caching. You would know better.


Oh, sure. Just thought including the date would make it a bit more specific.


Jerry, an idea on the icon when screenshot is disabled.
![](https://upload.wikimedia.org/wikipedia/commons/b/b6/Forbiden_picture_photo_interdite.PNG)
Or just a color overlay. Anyway I'm not very good with icons and it's late. See you on tox fellow :)


This should be done in the ResearchManager as it is the place where all this stuff is gathered. Moreover, if you feel like it could be used somewhere else, you can use a lambda like it is done for ResearchManager::listAllResearches.


nice catch


This hack can leak goroutines, https://github.com/mikespook/gearman-go/pull/60 that uses a proper channel just got merged upstream. Fyi.


good


Thanks for fixing my mistakes ^^


since this is c&p from BoldenGlyph you should factor out the constant since that is the only thing which differs.


What is this for?


I don't really get what it is supposed to do but I will try ^^


What is this about?


@mkortstiege, could you take a look at this commit? http://forum.kodi.tv/showthread.php?tid=231936


LGTM :+1:


The test kitchen way for doing this would be to generate a new key during the container creation. Safer too.


The recent changes in GetRho, partially broke test_FPCA.R; you 'warnings()' are generated regarding the "(unlist(yobs) - unlist(yhat))" step.


NIT: I think we have a coding guideline against using multiple attributes in one set of square brackets?


@Ayuto make sure that you're defining NO_MALLOC_OVERRIDE on POSIX platforms for version of the engine on the TF2 branch that has a linux client port (TF2, SDK 2013, CS:S, DoD:S, HL2:DM), as well as L4D and L4D2.

We had a shim in memalloc.h to avoid the need for that but the actual Valve headers do not have it and require the define (see the actual SDK 2013 copy). The shim got accidentally removed when porting code from 2013.


`devicesCallback` can now be in-lined here, its sole use.


Spelling - The instead of he


I changed the roof directory to MyProject.


This will work, but rcData would be set to new value in processRx and keep this value until `(int32_t)(currentTime - loopTime) >= 0` (may be several loop invocations). Then  filterRc() is called and rcData is rolled back almost to previous value.

Current code should not have problem with this, but it is very confusing. Don't worry about it now, its perfect for testing, but this problem should be considered before merging ...

Data flow is problematic in CF in general ..


OK i figured it out. so since python 2.7 doesn't have lzma support someone backported it from 3.3 as a module. https://github.com/peterjc/backports.lzma
(using Python 2.7.9)


no biggie :)


My hope is that we don't need to worry about any real schema or semantic "riders" -- the content of any data or message will contain any markers as needed as is done with microformats and the IndieWeb data flows.

Anything that must exist outside the content would hopefully only be required by the transport and that should be very minimal


Hrm.. this causes issues for any application that includes doorkeeper's specs, as per: https://github.com/doorkeeper-gem/doorkeeper/issues/55


Hmm... at this point, it won't actually work with legacy. :P


We really need a sandbox API...


As with Mike's stuff, I'd love to see the soup stuff get tucked inside the client. Since creating articles and categories will probably happen in a number of tests, I'd be inclined to make convenience methods that do all the donkey work. I'd also be tempted to have a standard tree that we can easily add, perhaps without need to do it all through HTTP requests. That can wait until we see duplicate effort in the tests, though.


I hope you know what you are doing ;-) filterRc() won't remove PPM glitches (and won't filter aux channels at all)

One possible solution is to use filtered path for sticks command and aux channels (delay is not that important here, except maybe for gimbal) and separate, fast path for PID input (some spike/outlier  filter may make sense here).


Ah okay, makes sense. Can we use the "cancel disconnected assignments" button in the console?


Add a U before the URL so that it gets created as link in doco.

E.g.

U(http://docs.aws.amazon.com/IAM/latest/UserGuide/Using_Identifiers.html#Identifiers_ARNs)


It would be great if you wrote an announcement to the Cukes google group on every major release.

Could you also update History.md please?

Cheers,
Aslak


Since the defaults are merged, there doesn't appear to be a way to override including the id or email in the projection. Could the default be just the `id`?


Hello,

This patch possibly work with Python2, but Python 3 requires to cancel this patch to work. otherwise it returns an error when a threaded function in c++ call a python function (like callback of the watchers):
`Fatal Python error: take_gil : NULL tstate ...`

(excuse my bad english, i'm french...)


testing


This looks Very interesting, and you've got some nice data sources.  Do you know what kind of model you will use?


Lead Backend Developer/Guy Who Knows About Fonts


My point was that we need not version our API(s).
They should work with old/new clients without having to update the clients.

cheers
James

James Mills / prologic

E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au

On Tue, Jul 14, 2015 at 9:07 AM, Mike Taylor <notifications@github.com>
wrote:

> My hope is that we don't need to worry about any real schema or semantic
> "riders" -- the content of any data or message will contain any markers as
> needed as is done with microformats and the IndieWeb data flows.
>
> Anything that must exist outside the content would hopefully only be
> required by the transport and that should be very minimal
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/prologic/knot/commit/bfc94541fadca6e85747f18d5ff13e3a74611455#commitcomment-12144692>
> .
>


Nice catch! I have fixed them.


> LGTM :+1:

I scrolled all the way down to the bottom of the page for _that_?


no matter development or build ,will meet error：

ERROR in ./lib/index.coffee
Module build failed: Error: Final loader didn't return a Buffer or String


Loving seeing activity on the pack again. Excellent work as always!


Useless


Before we had to have repoclosure. Now we don't. If we are never going to
install the sub packages then we don't need to include the extra epel
packages.

On Mon, Jul 13, 2015, 8:46 AM Peter Baldwin <notifications@github.com>
wrote:

> True, it makes tracking upstream easier, but at the cost of adding cruft
> RPMS from EPEL into the ClearOS tree. To name two (there are more)
> perl-ZMQ-LibZMQ3, zermoq3.
>
> If we want to change that policy, we can certainly discuss that for 7.2...
> no problemo. Right now, I'm just reverting to the behavior that we have had
> in the beta for the past few months.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/clearos/amavisd-new/commit/b64fd60321225782aedb72137e40431e1c014373#commitcomment-12135059>
> .
>


You're right - I've added a comment in the PR here: https://github.com/guard/guard-minitest/pull/131


Where did you find "official A"? If I am not mistaken we are still missing X9E builds on the compilation server, and the nightly builds don't include my fix!


lol, these are funny :joy:


`rcData[channel] = lastcommand[channel]`. Consistency is in my experience very important when writing robust code - don't create new code path (that needs to be tested) when you don't have to.


Yeah I know what can happen if faulty data comes in. I chose for ch 1-4,
but all channels might require filtering although I cant imagine it is a
high risk on aux channels even if someone would have arming on one of the
aux channels. Or the code should check conditionally weather more channels
need to be filtered.
To disarm there is also throttle low needed.

I see multiple adventages of this rcData filtering now.
1) Derivative kick
2) Blackbox could now log rcData to show real stick input instead of
calculated one through different functions.
3) This could replace or improve the current averaging system. More logic
can be added here to prevent unwanted scenarios.
 Op 14 jul. 2015 01:10 schreef "Petr Ledvina" <notifications@github.com>:

> I hope you know what you are doing ;-) filterRc() won't remove PPM
> glitches (and won't filter aux channels at all)
>
> One possible solution is to use filtered path for sticks command and aux
> channels (delay is not that important here, except maybe for gimbal) and
> separate, fast path for PID input (some spike/outlier filter may make sense
> here).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/cleanflight/commit/74f5854f257f8485947119e0fa0ac5cfb886dcd8#commitcomment-12144709>
> .
>


`Array.prototype.find` is not present in most browsers!


So glad this was added. It was difficult to find though.


don't know when it happened @wmvanvliet but we should confine this to EEG only, the other stuff takes too long.
Had that changed already ...


I wanted to point out that I had intentionally left the option to the user whether to use slick-migrations toString for the migration description or to add his/her own. There were two reasons for this

1) Flyway uses to compare migrations. If Slick-additions were to change its toString then Flyway will assume the migrations had been improperly implemented and throw an exception.

2) With large complex migrations the user may prefer to give his own short descriptions.

Feel free to add the option again or to leave it as is.


I'll put through a couple of doc updates.


s/sever/server


yeah I agree about the names should be formalized once this would become PR
candidate.
I will also let my brain do some thinking and rethinking all of the
scenarios.
Op 14 jul. 2015 01:23 schreef "Petr Ledvina" <notifications@github.com>:

> rcData[channel] = lastcommand[channel]. Consistency is in my experience
> very important when writing robust code - don't create new code path (that
> needs to be tested) when you don't have to.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/cleanflight/commit/74f5854f257f8485947119e0fa0ac5cfb886dcd8#commitcomment-12144831>
> .
>


I would really like to use swift forms in an upcoming project but can’t find the ‘framework’ to embed it. I am using 8.0 but would prefer not to use CocoaPods at this point. Is there somewhere i can get the framework? I tried just copying the swiftForms folder into my project but that did not work. Thanks.


972154-NewSimpleChilledCeiling (RKStrand) - i386-Windows-7-VisualStudio-12: OK (1688 of 1700 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.29%25-yellow.svg)


これ、本家に入れてもらった方がいいんじゃないでしょうか。


This looks really cool.  I'm very interested in seeing how well lat/long can predict crime types.  This will be a classification problem, so you could use KNN, Decision Trees, Random Forests or a number of other Classification algorithms.


What does this packet (for the client) ?


ohhh - see, I need to dial back my reaction to that trigger word "semantic" - I see it and think someone is about to go all RDFa on me

yes, +1 on the non-versioned API(s)


Not with disarm_kill_switch active ...

Also new filtering will only create ramp between values returned from RC - PPM_AND_PWM_SAMPLE_COUNT is filter applied at RC update rate ...


will be totally frustrating for people in the coming events :3


On aurait pu utiliser `bfg` mais ça implique de réécrire l'historique du repos bare, et github stock les issues/pr dans des refs :-/


This was not done


Je regarde du coté de `git-filter-branch`


Shipit.


I was trying to figure out how the specs didn't catch this, then I realized that I didn't run the specs. Thanks for catching this.


I was talking about updating rcData on each iteration - if it breaks something, it will break it immediately instead of waiting for one late RC frame ..


I think clocks should be singular here, right?  s/clocks/clock


Argh, didn't think about that one, I could submit a PR to polyfill.


@matthill Bug on line 417


@worldnamer This saved me fighting with display_* helpers on a collection, much nicer to do the styling in css also!


Was the intention to break running these bat files if you are not in the sbin\ folder?  Shouldn't these be:

```
call "%~dp0\rabbitmq-env.bat"
if exist "%cd%\rabbitmq-env.bat" (
  call "%cd%\rabbitmq-env.bat"
)
```


addressed via latest commit.

On Mon, Jul 13, 2015 at 5:48 PM, Joe Burgess <notifications@github.com>
wrote:

> I would mention that it comes in as an array object. Also mention the
> case of multiple arguments and the splat needs to be the last one. Also
> mentioning what happens if they put nothing in!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/learn-co-curriculum/splat-readme/commit/ccfb994dc8f88a8cfd67881a94b70632d8650eb6#commitcomment-12143626>
> .
>

--
Sophie DeBenedetto


develop (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1169 of 1169 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.81%25-green.svg)


@EricMSFT, do you recall why you removed this line?


The commit message for this does not appear to reflect the actual changes. The only change is a minor version bump, yet the commit message states that this changes an internal git commit that commits the package.json file.

Please be more cautious about your commit messages and the content they contain.


Thats what I meant with conditional things based on activated features.
Additional protection code could be added.

There is still 2 point averaging together with the filter of 1 or even 2
cycles. I don't expect more ramping than before?
Op 14 jul. 2015 01:29 schreef "Petr Ledvina" <notifications@github.com>:

> Not with disarm_kill_switch active ...
>
> Also new filtering will only create ramp between values returned from RC -
> PPM_AND_PWM_SAMPLE_COUNT is filter applied at RC update rate ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/cleanflight/commit/74f5854f257f8485947119e0fa0ac5cfb886dcd8#commitcomment-12144911>
> .
>


```bash
git filter-branch --force --index-filter 'git rm --cached --ignore-unmatch labriqueinternet.webm' --prune-empty --tag-name-filter cat -- --all
git push -f -a
```

Cf. https://help.github.com/articles/remove-sensitive-data/


Great!
Let's keep the rule of reciprocal accepting the PRs, so we avoid silly mistakes ;)


GetVisibleRange ? Wenn es blizzlike ist wird es so gemacht. Ich arbeite gerade vom iPad aus. Momentan nur wichtige fixxes.


Bitwise AND/OR has higher precedence than logical ones, but I agree it's good for clarity.


test


realized i've been working on outdated repo, so when I tried to push my commits I had to first pull all of the other changes to the fork. It's up to date now.


No I don't think it would. The server redirecting the request before loading the page should prevent caching.

Sounds like a plan


Looks good


Argh, I keep writing `loading` when I mean `interactive` :)


No, there is no number between 1000 and 9999 that raised to the square would be a palindrome.
I was thinking that if I begin from 9999 and go down until 1000, the first palindrome I encounter would be the largest.
It worked for 4 digits, but for 3 digits was a "no go".


I had an error but I solved it with:
BigInteger testlong = BigInteger.valueOf(Long.MAX_VALUE);


Comment nit: The order in which R is combined in an implementation detail, while the comment here should be about the API / what the user should expect. So you could change the comment to something like `Returns both the Q and R factor of a QR decomposiion of the input matrix. The returned values of Q and R are reproducible, i.e. they should be valid across multiple evaluations`


Looks good!


4973_heatpump_defrost_bug (nmerket) - i386-Windows-7-VisualStudio-12: OK (1679 of 1683 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.76%25-yellow.svg)


Yeah no I did not mean RDF(s) :P

Semantic Web != RFD :P

cheers
James

James Mills / prologic

E: prologic@shortcircuit.net.au
W: prologic.shortcircuit.net.au

On Tue, Jul 14, 2015 at 9:29 AM, Mike Taylor <notifications@github.com>
wrote:

> ohhh - see, I need to dial back my reaction to that trigger word
> "semantic" - I see it and think someone is about to go all RDFa on me
>
> yes, +1 on the non-versioned API(s)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/prologic/knot/commit/bfc94541fadca6e85747f18d5ff13e3a74611455#commitcomment-12144907>
> .
>


Nice


>> Reapplying update "2015_06_26_00_characters_335.sql" 'f8230a5' -> 'C2CC6E5' (it changed)...

Any idea what might be the problem here?

@Naios, @ShinDarth


What if we had `icon_ = "default_marker"` so that a marker gets drawn by default?


Возможно, стоит вместо попытки охватить всё сделать бранч под уже известные диссоветы.


Done.  Thanks!


Xero should be paying you.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/17888/testReport/) for this commit**


Hello @ZogStriP , I am wonding why did you remove `Discourse.getURLWithCDN(url)` in all user avatar? Because i have problem with user avatar image in profile and navigation menu are not using CDN, but user avatar in user's activity use CDN.

in meta.discourse.org, It always use CDN for user avatar, but on try.discourse.org also have same problem with mine.

Thanks


DONE


Now it looks nice! Thanks!


[style] spaces after the commas.


I had an error but I solved with:
BigInteger testlong = BigInteger.valueOf(Long.MAX_VALUE);


DONE

Thanks for this. Yes, this is definitely better :) The missing piece for me was the fact that the Done() channel will always return the same value once it fired i.e. we can use it at the top and the bottom.


88737258-EPW-Ruby-Access (jasondegraw) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


r+


wonder if explicitly installing `unittest2` will help in Py26 - https://pypi.python.org/pypi/unittest2


@wycats do you have other thoughts on this? Polyfill or just do it manually?


The specs compile again, and I can reproduce the out-of-order issue you've noticed. I'll get it fixed tonight and push out a new release.


Its a common typographical error.


its not working


93469234-DemandResponse2 (vidanovic) - Win64-Windows-7-VisualStudio-12: OK (1690 of 1693 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.82%25-yellow.svg)


saw approval from jedmccaleb
at https://github.com/stellar/stellar-core/commit/2d10b618c7b131b567f69a9e8387cc1322537a26


merging stellar/stellar-core/newbuild = 2d10b618 into auto


stellar/stellar-core/newbuild = 2d10b618 merged ok, testing candidate = 617880e0