TeamCity ReOpenLDAP :: devel-2.4 [Build 178](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=34&buildTypeId=ReOpenLDAP_Devel24&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:44:17


TeamCity ReOpenLDAP :: devel-2.4 [Build 179](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=42&buildTypeId=ReOpenLDAP_Devel24&guest=1) is now running


it is not necessary. Exceptions are already handled where saferepr() is called! This breaks SystemExit, KeyboardInterrupt and SyntaxError!


This migration could be squashed too.


I agree that this could go either way.  But seeing that the orphan still has a parent, and that a modified child is in fact still a child, I felt that it was cleaner to ensure that this signature did not leave a trace.  There is an additional signature to allow for more control.


This is now better


the task scheduler documentation should warn in detail about which variables can be passed to lambdas and how they should be passed.


Oh, no - I suppose not.


hey that thread is not mine .. i'l be bringing official support and wil create a new thread !


typo? what does prependtial mean? should it be prependtail ?


it's the normal way to derefence member function pointer.


d


minor observations, otherwise :shipit:


Then we want to catch anything that ``repr(0`` might raise here? Without this patch ``Debugger()`` can go crazy :)


Awesome! Have you considered sass? They're both great (I started with less too) but there are more developers using SASS ATM - compare:

http://stackoverflow.com/tags/sass
http://stackoverflow.com/tags/less

Twitter Bootstrap (one of the most popular less projects) also just moved to sass in version 4.


It's ok.
xcopy is being run from the apps root directory. So xcopy is copying the contents of the "Third-party Apps" directory to the apps root directory.  This is desired function.  You can test xcopy for yourself in a command window.  It helped me understand the function of this line.


That's a possibility, let's think on that.  If you feel the same way at the end of the review we can make the change.  I guess my original thought was ti make some calls that only deal with parent/child use cases more explicitly named.  But I can see your point.  Let's wait until we have the REST API figured out and then finalize the naming.


Ingo

I get a compilation error:
in ipdehaz.cc line 122
'mean' has invalid type for 'reduction'


should be better to have ```size <= 1```


Well, the correct version should be `\ifnum\the\luatexversion < 80`, but if using `79` eases the test process for TeXLive 2014 users, why not, I think it should only change the penalty of clef changes, so it doesn't matter much...


else what?


I'd prefer to use `GRand` - it's threadsafe.  Which doesn't matter here but might in other code.


`ib_modify_qp_is_ok()` allows for moving from SQD to RESET, ERR, and RTS. Any reason to prevent these transitions?


в данном случае мы можем создавать объект PDO, а параметры брать из глобальных констант.


Lines 210-214 could be replaced with one line:
```
return stub != null ? stub.isTopLevel() : getParent() instanceof JetFile;
```


This actually @henrygarner 's name :P It's a prepending partial  - "prepend-tial".


I know, I actually brought this issue up with Peter.  I'll forward you his response in e-mail.


The `LVHD` "object" looks similar to the `Auth` object we already have, which is not in-database. Any idea why that one is OK but `LVHD` isn't?


This can be `- %UserProfile%\.node-gyp`


This is fine as long as the Go Around does not REQUIRE restarting a landing.  What if I have more than one DO_LAND_START in a mission (we do)?


沒錯啊，我並沒有說 babel 會幫你做檢查喔。目前的確需要像 @chentsulin 說得，自己加上 `flow` server


I'm not sure about those sort methods. They match to Filterable module, but I can't move them standard. How about some dynamic-calling or is not worthy effort?


Good indent, bad alignment


Hmm, curious indeed. Some more investigation required!

On Mon, 24 Aug 2015 14:00 John Else <notifications@github.com> wrote:

> The LVHD "object" looks similar to the Auth object we already have, which
> is not in-database. Any idea why that one is OK but LVHD isn't?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/djs55/xen-api/commit/d5868fbe0d4e9dde6253488fa8b36d0604f08f14#commitcomment-12856689>
> .
>


bad alignment


Wasn't there a function defined to convert between the two mtu types (rxe and ib)? You should use that instead of casting, although it would be best just to avoid defining a device specific mtu enum.


this is better.  I have found one other file type to take into account.
Looks like this:
Read 1
>HWI-ST330:137:D057WACXX:7:1101:1222:2061 1:N:0:ACAGTG
Read 2
>HWI-ST330:137:D057WACXX:7:1101:1222:2061 2:N:0:ACAGTG


The scenario where this happens is that when that node died. So no point sending it an activated packet because it does not exist anymore.


This should be a method of the MetricDefinition struct as MetricData doesnt have an ID field.


Is the `:run_callbacks` to kick off the geocoding and push to elastic search?
Is it needed this in this test as the cascade will happen automatically with the call to `:destroy` ?


When I try to run your app, I get the following error: `ReferenceError: List is not defined`

Before you define your prototype, you need to define your List constructor (i.e., `var List = function( info ){ ... }`. Otherwise, line 7 won't work.


class for %c and for %t? Should second one be "type?"


Unfortunately this code not fits the concerns idea.
It should be service - as I wrote before.
Make `services` directory in `app/` path, and place it there as class, not module.


We should probably distinguish between the `[]` and `_:_:_` (0 vs more than 1 user)


Unfortunately the command line program currently depends on some internal functions that are not exposed in the library API. It won't be possible to link against the shared lib before that is fixed.


Pretty sure this the Id field should already be set, so maybe wrap in an `if def.Id == "" {}`  also, the Id should be set using def.SetId()


angular.js의 d3 directive도 있던데 확인해보면 좋겠다.
http://krispo.github.io/angular-nvd3


I see.


I believe that if IB_QP_ALT_PATH is set, you should also check alt_timeout, alt_port_num.


zOMG


Yeah, I did restart all the staging builds: http://hydra.nixos.org/eval/1216596

There is no heuristic for low RAM. I don't see a good way - once a build that consumes a lot of memory has terminated, the memory is returned, so we won't see the low RAM condition. Maybe the build could be run in a memory cgroup, then we can check the highwater mark in `memory.max_usage_in_bytes`.


The method `getDefaultProps()` returns an `Object`, but you supply a variable that is not set. This doesn't seem right. Isn't this supposed to be:

```javascript
getDefaultProps() {
  return {
    validatePassword: () => {},
    requiredMessage: 'Password is required',
    invalidMessage: 'Password must be at least 8 characters in length'
  }
}
```

I am not sure if this is completely correct ES6 javascript, but I don't think the defaultProps are correct here. I haven't tested it, but it's just what I've spotted.


just idea/thinking out loud - this could be in another interface that sprintf would check to see if it "supports" rdata printing.


Patch only shows 3 lines before first change.
The condition is just one line above patch start i.e. "if ( *pos ==  0 )"

So now code looks like this:
static void *c_start(struct seq_file *m, loff_t *pos)
{
        if (*pos == 0)  /* just in case, cpu 0 is not the first */
                *pos = cpumask_first(cpu_online_mask);
        else
                *pos = cpumask_next(*pos - 1, cpu_online_mask);

        return *pos < nr_cpu_ids ? cpu_to_ptr(*pos) : NULL;
}

static void *c_next(struct seq_file *m, void *v, loff_t *pos)
{
        *pos = cpumask_next(*pos, cpu_online_mask);

        /*
         * return cpu-id to iterator for show routine, NULL to stop.
         * However since NULL is also a valid cpu-id (0), we use a round-about
         * way to pass it w/o having to kmalloc/free a 2 byte string.
         * Encode cpu-id as 0xFFcccc, which is decoded by show routine.
         */
        return *pos < nr_cpu_ids ? cpu_to_ptr(*pos) : NULL;
}

In my case I checked system with 2 cpus: 0 and 16.
Seem that seq_read() uses c_start even with pos equal 17 (next one after my last CPU).

I tried to understand seq_read() but it is not fully comprehensive.
Given that, I just tend to mimic many other architectures.
Maybe you can better understand how one should implement seq_file operations.

Regards,
Noam

From: Vineet Gupta [mailto:notifications@github.com]
Sent: Monday, August 24, 2015 2:58 PM
To: EZchip/linux
Cc: Noam Camus
Subject: Re: [linux] ARC: Adjust cpuinfo to work on sparsed mask (a95f79a)

i dont understand ur patch above.
c_start unconditionally replaces *pos with 1st valid cpu - so you don't need the check.

But we need to understand what non NULL value it is getting - perhaps caller is already passing cpumask_first() to it ?

—
Reply to this email directly or view it on GitHub<https://github.com/EZchip/linux/commit/a95f79acf3d7457b0da6f304f5dd8775eeebf7a9#commitcomment-12855598>.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19569/testReport/) for this commit**


Forgot to delete `./pkgs/ShellCheck`?


I'm fine if we don't merge this. Thanks for the heads up.


Remove 2px border on quotes


Right, I'll get to that soon


Nope, I've never had issues. The first launch after installation or updates seems to take a few seconds for the Box Sync window to appear but it always seems to be able to "repair" itself and do whatever it needs to do inside the home directory.


How come there was no such check when the tasks where disabled?


How do you know he hasn't done anything? ( ͡° ͜ʖ ͡°)


Should this comment be here?


I wonder if you need to lowercase name and drop final dot here to make some kind of of "canonical" output....


Hello, I'm here


Fixed in https://github.com/bartvig/ting_oembed/commit/2c2c629325d2ab3fdf64823a488108433baf935e


What value does this actually provide? You can do this easily in your own code and then pass in the prepped session object. IMHO this is better solved by documentation, showing how to do it for typical use cases (e.g. the U-A header).

The above solution will always be restricted to what you provided as "magic" names there, and won't evolve with newer requests versions. Outside initialization has no such restrictions.


comment would not hurt to read this func later


I think this function is very similar to rxe_qp_drain() and you can easily factor out the common code.


Fixed in https://github.com/bartvig/ting_oembed/commit/daf9906aa29a079acd44772a48440bec8e7e2cbd


From my experience: when I just grabbed the example code snippets (both the nodes and the EvMenu init stuff) and dropped it into my app, I expected it to work immediately. Instead I was messing around trying to figure out if I'd imported something wrong, but it turned out to be a discrepancy between variable names from line 14 and this. (Where line 14 references 'start' and the code snippets have nodename1)

Heh, though looking at it again now, I think I changed the wrong line- the example at line 32 should match whatever is on line 18, which is clear enough for anyone reading it initially before C/Ping what starts on line 72.

If you're in agreement, I'll go fix that.


This is also fixed in https://github.com/bartvig/ting_oembed/commit/daf9906aa29a079acd44772a48440bec8e7e2cbd


Lol this is funny.


This now started a new ripple, try on IE or Safari with bootstrap validation. You will see blurring bouncing to one control to another if you place two consecutive masking controls.


Dependencies has been added to makefile here: https://github.com/bartvig/ting_oembed/commit/9ec68af2c59355a1ef9e5750ef0ba0a04f1b4c41


you probably would change around here for CNAMEs being first and other things going later...


Description has been added to this commit: https://github.com/bartvig/ting_oembed/commit/fc0c45b02967fd904f671f32d0c031e07bec0f14


Fix comment


Hello,

why you disabled
<field name="database_join_join_sql"
				type="fabrikeditor"
				mode="mysql"
				description="PLG_ELEMENT_DBJOIN_JOIN_STATEMENT_DESC"
				label="PLG_ELEMENT_DBJOIN_JOIN_STATEMENT_LABEL" />
in
plugins/fabrik_element/databasejoin/forms/fields.xml

? I had the problem that something is saved in this field and know it will be deleted after saving it again.

Thanks


The comments have been addressed in the following commits:
https://github.com/bartvig/ting_oembed/commit/2c2c629325d2ab3fdf64823a488108433baf935e
https://github.com/bartvig/ting_oembed/commit/daf9906aa29a079acd44772a48440bec8e7e2cbd
https://github.com/bartvig/ting_oembed/commit/9ec68af2c59355a1ef9e5750ef0ba0a04f1b4c41
https://github.com/bartvig/ting_oembed/commit/fc0c45b02967fd904f671f32d0c031e07bec0f14


close #593


Can u confirm if c_start is called only once - if so why do u need the if block there - and why do we care what it gets passed ! We reset the satte machine by setting 1st online cpu in *pos in c_start() and iterate in c_next()


I don't sure that it matters here (tests)


test


No, I'd have to debug it to see.


The Id field should already be present.  This should be removed.


Ok, agreed.


Just to descriptor How to make audioRecorder By lane


--single-branch would be good here too


@inooid according to the es6 spec [here](https://babeljs.io/docs/learn-es2015/#enhanced-object-literals), line 23 is a shorthand for `validatePasword: validatePasword`, which uses the function declared at line 4 as the default `validatePasword` props.


also you probably want short TTL records before long TTL ones so if you dedupped three A recs short TTLs survive and long ones are thrown away.


Probably property should be renamed to avoid misunderstandings


This way, if ```quant_ids``` is greater than 1, domain is overwritten at every cycle


BTW: while we're into micro-optimisation, since we already have the reference to `this.$element`, why not just write `this.$element.trigger('change').trigger('input')` ?


But it seems the regular expression could be written as `"/\\*[^*]+\\*/"`


Yes, I'll simplify it


Don't worry about it for now, since I'll reformat, but this was originally correct. `Classname *varname` is the correct format for instance variable declarations.


Thanks @KonajuGames. I just did an experiment to see how the WinForms `OnMouseWheel` event behaves and sure enough it returns 120 for one notch of the mouse wheel. I've to removed the division and the event behaves the same way as WinForms, I think that's the best way forward.

In future, if it seems like a reasonable thing to do, I might add it back in as an optional setting.

> The delta was set to 120 to allow Microsoft or other vendors to build finer-resolution wheels

I wonder how many mice have finer resolution wheels?


I read the processes get a SIGKILL, which seems pretty unusual normally. https://www.kernel.org/doc/gorman/html/understand/understand016.html That's all assuming this is the mechanism that gets fired and not e.g. just failing malloc or something – I don't know what exactly happens typically.


--single-branch will cause issues with upgrades because right now with git you can switch branches on upgrade, with --single-branch it will be painful due the fact I would need to keep track of this information and prevent switching between branches.

Given I push the usage of featured branches instead of patches with git, dropping the ability to switch between branches sounds wrong to me.

However I will add it for ports where switching between branches is less useful :)


Sorry, I thought this comment explained all, https://github.com/imagemin/jpegtran-bin/issues/9#issuecomment-23159526

I just verified it on my Linux Mint Rebecca (based on Ubuntu 14.04) that nasm is required to setup the starter kit.


@aniarya82 Thanks!

Can you send a PR?


@CrackerTeg Its all good sugartits... i still love you.


Is it safe to free the resources here? Couldn't another thread access them concurrently?

You would think ib_modify_qp_is_ok would prevent that, but you could overcome its check with IB_QP_CUR_STATE.


I reopened #65 to make sure.


看了你的分析，发现还是很多不足，确实单元测试做得不够充分，bug也挺多的，我一点一点改


Please check whether you can remove this rcu lock.


Doesn't the returned sgid_attr contain a netdev that you need to put?


Yeah, but it's typically some grandchild process that gets the SIGKILL, not the top-level builder process, so we don't get to see the SIGKILL.


About the first argument of `gulp.watch()`, `'app/js/**/*.js'`, normally this should be the same as the argument of `gulp.src()` in the gulp task we are watching.


we usually write this as "--message=" in the man pages rather than just "--message", if it takes an argument.


Same notes as for the primary path. You could factor out this code and use a single function to handle both primary and alternate address vectors.


Haggai: For your questions, Yes it's used to limit the number of the allocated ib_ucontexts.

Could you please tell how much we need to increase it.


@daniceexi I should've been more specific. I meant the change that introduced the error, instead of the change where we're having this conversation.


a


Fixed. I now let the possibility to specify a `Context` or use `Vertx.currentContext()`


Why are you filtering `groovy-*` dependencies?


@aniarya82 yeah, we changed it in the SQL structure. We also need to change it at the frontend here.


Congrats!
Suggestions:
1.  Maybe the 64 value should be multiply to the bonus.
2.  Line 57:  IMO, it will be more readable if you did:
if(abs(int(v))>512)
   table[pc][to]=VALUE_ZERO;


This really should stay, it's part of the API, and we always need a way to query the current setting!


what happens when I click on update Readme.txt and type this in?


If you can arrive to dump the JVM and read the memory, this means you could have the complete control o the server. You could still set the cache size = 0 to disable it


test case


Good use of semantic elements article, header and nav


oh, I see, these are just comments


Remove comment


Yes. In fact I think this line isn't needed in some of the other tests under the "destroy" context too. I'm tempted to fix all that as part of this PR, but also concerned that's rather off topic for this PR. I feel like I should keep this in for consistency in this PR. But raise a new PR that tidies this whole section up. wdyt?


Be careful with your naming conventions.  Web servers don't like names with spaces in them and it is best practice to name your landing page index.html.


A list of options here:
http://compass-style.org/help/documentation/configuration-reference/


So it seems like there are a few objections.

1. Relying on the BuildInfo plugin adds an extra dependency.
2. IntelliJ can't resolve the generated file, and therefore shows an error.
3. There are already many places that reference the version, so one more doesn't hurt.

I freely admit that there may actually be more reasons, and my solution may not be a good one. But I think the reasons above can be addressed.

1. We don't actually need to rely on the buildinfo plugin, we can generate it simply ourselves, which is probably for the best.
2. Have you tried deleting the .idea folder and reimporting? I am not experiencing that issue here.
3. The README only references the current stable version once, which could be automated if really needed, but the real point is that keeping two constants in different files in sync every time you want to test a different version is error prone. If this isn't the best solution, we should find what is.


Let's just widen for now and then install that and the other three commits on `master`, and then release `v2.2.1`.


a


shouldn't this be a PK action that is "implied" by the reboot/halt/poweroff actions? i.e. using the `org.freedesktop.policykit.imply` construct?


The css is only added, when we alter the facetbrowser form, so it's not necessary to add more specific css classes to the template.


Это не нужно.


This property is a flex-box layout property and only takes effect when the display property on the parent is set to flex.  It is beyond the scope of this course as it isn't widely supported by all browsers yet.


Should be <command> rather than <option> I figure. Also I think it should be saying "command" once too.


I don't know if we should be focusing much on a non-LTS version. Anyway, for the PostgreSQL stuff, I think we should be using postgresql from the [PGDG repo](http://apt.postgresql.org/pub/repos/apt/) instead of depending on the version provided by Ubuntu.

Check this out oguya/ansible-ckan#4


The configuration options here are quite similar to the ones available to `config.rb`, but there are still difference. For example, `line_comments` and `output_style` in `config.rb` are not available in `gulp-compass`.


hm, why not using just _motor_to_channel_map? Is there a particularity I'm missing here?


Better to use `Strings.isNullOrEmpty()` for clarity and idiomatic Java.


logical is likely to be so
```
this.opt = $.extend(true, {}, $.fn.raty.defaults, options, this.self.data());
```
, as we have already received the current object


This line is the culprit: https://github.com/usefulio/forms/blob/master/lib/forms.js#L228


* Here is to override the configuration in `config.rb`
* If these folders are not specified here, those in `config.rb` will be used


Where is this freed in the end?


In general you have done well.  We need to work on a more standard directory structure like putting your style in a css directory and images in an images or img directory to keep things separated.  It does look oddly like Wendy Bite though ;-)

I appreciate that you have gone ahead and put in real copy (text) about yourself, many students didn't do so and I've seen far too many Joe Johnsons to care for :-) so far.


Apart from idiom code review looks good.


Sorry, I don't know what a promise is. That's probably why I used a
callback. I assume you are referring to '.once()'.

On 8/24/2015 8:07 AM, SamGraber wrote:
>
> Out of curiosity, why did you opt for using a callback instead of a
> promise?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SonofNun15/set-manager-pro/commit/ad32eeb3cf100dcd751ff7af0fd330db0b262122#commitcomment-12855781>.Web
> Bug from
> https://github.com/notifications/beacon/AMlO7omsjsnQnbaYjKqSVHCSPLIBEeA3ks5oqwB6gaJpZM4Fw8eP.gif
>
> No virus found in this message.
> Checked by AVG - www.avg.com <http://www.avg.com>
> Version: 2015.0.6125 / Virus Database: 4409/10497 - Release Date: 08/23/15
>


This doesn't look right to me.

Remember the client is shared and can be used from many contexts so doesn't make a lot of sense to cache a context on the pool.

Instead the context should be got when the async operation is invoked, so the result can be delivered on the correct context.


Why is this test always at the top of the page


Lacks OOM check.

Also, this should just use `strjoina()` rather than `strjoin()`, meaning the memory is allocated from the stack rather than the heap. This allows us to not care for freeing it anymore, and we can keep the "const" on the string ptr.


Jacques, compiles fine on gcc 4.9.2. But I will push a fix now


title changed


Also check if already on the right context, if so runOnContext can be avoided (better performance).


Is missing OOM check. Also, what happens if the string is already initialized? we'll leak memory then.

Consider using `free_and_strdup()` for this.


The commit message of this commit has nothing to do with its content.


Replace by "!isempty(arg_wall)" check, which does the same, but is shorter!


But what happens if the async operation is not invoked from an event loop ?


I don't think we need a commit just for imports


For `Compass` plugins.

This is used to access `Compass` plugins without having a project configuration file (`config.rb`).


First we center all the text. Including the `i.fa`


Could you change this to "Failed to set wall message, ignoring: %s" here? i.e. let's not dump the function name on the user, he's unlikely to make sense of it. Also, clarify that we ignore this error, by saying so.


According to the spec, the timeout is `Ttr = 4.096 * 2 ^ attr->timeout [us]`, and the HCA should detect the timeout between `Ttr` and `4 * Ttr`.
The code will always round it down, so it looks like it will always set the timer to below the specs minimum.
You can fix it by using something like:

    (4096ULL << attr->timeout) / 1000


The following is not a problem, but just a convention. The `.rb` file extension can be optionally left out. If its not there, `require_relative` will try adding it. The `.rb` often isn't included.

I see the checkpoint docs sometimes include the `.rb` extension and sometimes don't. I've requested the docs be cleaned up and be consistent.


Oh okay, I see what you mean. The `startnode` keyword is set as an example of the call signature (it is "start" if you don't specify it), but no matching node is then given as an example. Sure, fix them to be consistent, I guess people copying&pasting from the docstring is to be expected.


There's a uniqueness constraint on ids, so more than one is impossible.


If you use vertx.getOrCreateContext() it will create a new context if not already on one.


Each "task to watch" should have a separate `gulp.watch()` statement.


I am not convinced this should get a short option. We try to be very conservative with them, and only grant them to the most commonly used options... I doubt this one qualifies...


Good refactoring :+1:


Then we float all Font awesome icons to the left. That way we don't need `.f-inner__title-space`


Again the `.rb` could be safely removed from this line.


Hi Vineet,

I am totally understand your logic, but somehow it is not how things works with read_seq.

I added to c_start and c_next beginning a printk and you can see below when it is called and what passed in *pos:

Noam

[EZdk]$ cat /proc/cpuinfo
c_start is called with pos :::::::::::::::::::::: 0
c_next is called with pos :::::::::::::::::::::: 0
c_next is called with pos :::::::::::::::::::::: 16

IDENTITY        : ARCVER [0x30] ARCNUM [0x0] CHIPID [0xffff]
processor [0]   : ARC 700 (ARCompact ISA) [Big-Endian]
CPU speed       : 83.33 Mhz
Timers          : Timer0 Timer1
ISA Extn        : mpy norm barrel-shift swap minmax swape
Bogo MIPS       : 165.27
MMU [v3]        : 8k PAGE, JTLB 256 (128x2), uDTLB 8, uITLB 4
I-Cache         : 16K, 2way/set, 32B Line, VIPT
D-Cache         : 32K, 4way/set, 32B Line, VIPT
Vector Table    : 0x80002000
Uncached Base   : 0xc0000000
DEBUG           : ActionPoint
OS ABI [v3]     : no-legacy-syscalls
Extn [EZNPS-SMP]        : On

IDENTITY        : ARCVER [0x30] ARCNUM [0x1] CHIPID [0xffff]
processor [16]  : ARC 700 (ARCompact ISA) [Big-Endian]
CPU speed       : 83.33 Mhz
Timers          : Timer0 Timer1
ISA Extn        : mpy norm barrel-shift swap minmax swape
Bogo MIPS       : 165.27
MMU [v3]        : 8k PAGE, JTLB 256 (128x2), uDTLB 8, uITLB 4
I-Cache         : 16K, 2way/set, 32B Line, VIPT
D-Cache         : 32K, 4way/set, 32B Line, VIPT
Vector Table    : 0x80002000
Uncached Base   : 0xc0000000
DEBUG           : ActionPoint
OS ABI [v3]     : no-legacy-syscalls
Extn [EZNPS-SMP]        : On

c_start is called with pos :::::::::::::::::::::: 17
c_start is called with pos :::::::::::::::::::::: 17

From: Vineet Gupta [mailto:notifications@github.com]
Sent: Monday, August 24, 2015 4:13 PM
To: EZchip/linux
Cc: Noam Camus
Subject: Re: [linux] ARC: Adjust cpuinfo to work on sparsed mask (a95f79a)

Can u confirm if c_start is called only once - if so why do u need the if block there - and why do we care what it gets passed ! We reset the satte machine by setting 1st online cpu in *pos in c_start() and iterate in c_next()

—
Reply to this email directly or view it on GitHub<https://github.com/EZchip/linux/commit/a95f79acf3d7457b0da6f304f5dd8775eeebf7a9#commitcomment-12856906>.


Why do you still use '$' from prototype here?


It's better to separate words with `-` for better readability


Typically, when we create a new task, there are 2 more things we need to consider doing:
* Add the task to `gulp.watch()`
* Add the task to the `default` task


Let's create a own class for the wrapping link. And we don't want text to have any decoration on hover.


`*arg_wall` is only the first item in the list. Please use `strv_join()` to turn this into a single space-separated string first...


(a new branch is being worked on right now that fixes the 'destroying' context)


My mistake. `.flexbox__card-link` should wrap `.f-inner` and not just `.f-inner__card-titles`


`strv_push()` will take the memory pointed to by optarg and make it part of the arg_wall strv. This will explode in case of strv_free() on the strv, since that assumes dynamic rather than the static memory of optarg... Hence, please use `strv_extend()` instead, which duplicates the passed string first.


PR are welcome: Do you mean to the supermarket...?

Agree it's important which is why Ceph asked us to take over because it was
behind where it needed to be. The push was just a simple doc update
directly to let new people passing by know of changes because no one
believed the it to be active. There is a move on to begin cleaning up the
overall ceph repo which came out of the Ceph Hackathon 2 weeks ago. The
goal is to eventually bring all automation into line and easy for people to
determine which one they would like to use.

Thanks

On Sun, Aug 23, 2015 at 6:21 PM, Guilhem Lettron <notifications@github.com>
wrote:

> I'm waiting for PR, but before that all I see is something against all
> rules for this cookbook:
>
>    - You are pushing directly to master
>    - You didn't ask all maintainers (and yes I keep to be a maintainer
>    with this cookbook in production).
>
> I also see that you just register on supermarket... sorry but I don't give
> a *so* important cookbook to someone who didn't manage any other
> community cookbook before.
>
> But as I said, your welcome to help on improving cookbook. PR are welcome
> and you don't need any write access for this.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ceph/ceph-cookbook/commit/1f3a84dcaa4c0fce3ea93123dbc494564193cb93#commitcomment-12848252>
> .
>

--
Best Regards,
Chris Jones

cjones@cloudm2.com
(p) 770.655.0770


Please change the error message as above. (Yupp, apparently the old msg wasn't pretty either, but let's improve over this...)


Looks good otherwise!


@samveen, the changes that @hu-weihua  made for this was done in pull request #81, but the syntax issue was missed in the review process and since the change was simple, we decided to have those types of fixes get directly pushed to the repository.

We are still getting used to this process and will try to improve.  your suggestions are welcome and appreciated!

The core xCAT dev team has write access to the repository, are you suggesting that we should implement a core review board that will allow pull requests to go into the  project? We are discussion the review process and trying to come up with a good way that will not put too heavy work load on a set of developers.


A "promise" is the general software term for a way of handling async code. You've used promises in .NET with the TAP libraries (Task<bool>.ContinueWith()). Tasks are promises.

Here is one (of many) articles on promises in JS: https://spring.io/understanding/javascript-promises

In ES6, promises will be built into the language.


@cromwellryan this has the correct tracking code


Saída pela esquerda.  Que tal:

> "... softwares open source em Python para, mas não limitado a, Ciências Exatas, Biológicas e da Terra."


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Oh. I guess it is because the SNAPSHOT RoboVM builds are published only to a snapshot repo and that is not included by default.


Aqui as disciplinas acima são repetidas.  Acho que pode cortar ou colocar apenas:
> "... é focada em aplicações científicas e afins..."


Looks ok.


they are the same thing... but as explained in other comments I'm actually removing _motor_to_channel_map


Doesn't this affect the behaviour of the switch statement below? Tho in the case the err msg has no spaces I guess the switch below will never set a message type anyway.


We chose not to make our own facet browser, so we can reuse the existing one and modify this instead.

This means that we remove the existing facets, because we don't want to use all of them (e.g. date is not used for e-courses as they are all relevant - old courses are removed from ekurser.nu). Facets are removed explicitly, but maybe this has to be changed. If a site has added more facets, these will be shown and not removed automatically. It's currently undefined how to deal with this situation.

Most of the code in this alter hook is to change the handling of facets. The intention of the existing facet browser is to make several AND filters. This is not what ekurser.nu handling is supposed to do. They want OR filters, i.e. when you have chosen one facet the facet browser should still show the "top" facets instead of filtering down. This might not be the cleanest way to do it, but instead of making a completely new facet browser we can reuse the existing and modify it.


@ismailakbudak :+1:  :clap:


Jacques, I pushed a fix.


What Sam is saying is that authenticate could have returned a promise (something that could be awaited) instead of taking a callback as a parameter.

Callbacks tend to lead to "Christmas tree code," where each successive call gets more and more deeply nested / indented, which becomes hard to read / understand. You can simplify by moving nested calls into named functions, but promises are another solution that is flexible and flattens the call sequence, making it appear linear.


This drops references on the QP, right? Doesn't this circular reference prevent this function from ever being called?


@timholy with FileIO, should this become something like:
```Julia
save(::File{format"NRRD"}, ::format"Imagine", h::Dict{ASCIIString, Any}) = ...
save(::File{format"NRRD"}, ::File{format"Imagine"}, h::Dict{ASCIIString, Any}) = ...
```
I can only find little information about the `imagine` file format. It seems similar to `NRRD`, so would it make sense to put it into the `NRRD.jl` package?


If there's an authorship problem, tell me. Ill force push the right commits

On Sun, Aug 23, 2015, 8:22 PM no1uknow <notifications@github.com> wrote:

> danielstuart14@918b38e
> <https://github.com/danielstuart14/android_device_lge_g2-common/commit/918b38eff364a0351e59d978bf35c1eadaa1e713>
>
> Thats why... The Origin
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CyanogenMod/android_device_lge_g2-common/commit/918b38eff364a0351e59d978bf35c1eadaa1e713#commitcomment-12848579>
> .
>
--

Thanks,
Rashed Abdel-Tawab


Sadly, here it goes when using react 0.14-beta1:

> The package react does not satisfy its siblings' peerDependencies requirements!
> Peer react-dropzone-component@0.5.1 wants react@>=0.13.0

(I'm using npm 2.11.3 for reference)


[Handling high resolution mouse wheel](https://msdn.microsoft.com/en-us/library/windows/hardware/dn613935(v=vs.85).aspx)

The main thing is, don't assume that each event will receive the mouse wheel input in lots of 120.  It might go as low as 30 and it is up to the application to accumulate the input and wait until it reaches +/-120 before acting on it as a single scroll event.  The application can do partial scrolling in the meantime.


What's the reasoning behind this?


I prefer to keep all the settings in once place. I switched to using reverse('sign_request') there.


@tom-dalton-fanduel Yes, you're right :) It's my mistake :) Good :)


I think something like 512 should be enough for everyone :)


Aren't these already defined above at line 63 and 64?


Merci chef !-)


Yeah. The 1.6.0 plugin has already been published to bintray if you have projects that depend on that. My thought was to have master track the *next* RoboVM release so that we can easily have same day support for it. Thoughts?


Please use a class instead of an ID - our usual rule is "IDs for JS, classes for CSS". In this case it's important because this form can be reused in multiple interstitials on the blog page, and it's not valid to use the same ID twice in the DOM.


should this be pushed back to v2.x?


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


These are already defined above starting at line 69...


@tom-dalton-fanduel I will work as default :) so it will handle as MSG_RSP_REDIS_ERROR, but it is not correct :)
You're right :)


Thank you！


Thanks for clearing this up ;)


Can we write a unit test to capture it next time


In this case, the 120 should be removed because higher resolution input devices will result in this sending a sequence of events with zero for the delta and then a final event with 1 or -1 delta.


yes, I will create a pr later this week with the sharedfp fileview fix, this CID fix and one more CID fix that I need to commit.


I don't think this needs an `!` because you are providing a default value in the initializer. (could be wrong, didn't test myself)


Checkmarx scan results 24 Aug 2015 16:53 UTC +03:00

High
Medium
Low
Info

New
2
2
21
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


EITHER in Red/System is not reliable when used inside an expression. So better put it out of it.


`timeRunning` doesn't have to be optional, it's either true or false and you're providing a value in the initializer. If the compiler complains it's probably better to make this line:
```
private var timerRunning: Bool = false
```


The reason for this is that we modify the facet browser and modify the behavior of filtering of facets. When you go to the search (when you haven't chosen any facet), a search will be performed which will - among search results - return facets. These facets are cached. When you choose a facet, instead of filtering the facets too, we show the cached facets so we are able to choose from the main set again.

The facets are cached permanently, and this will only be a problem if you go directly to a search for a specific facets and the top facets have changed. Every time you go to the main ekurser page, it will make a search as it normally would, so the cached facets will not be older than the last time ekurser was visited. If you go to a search with a specific facet and the cache is empty, it will redirect to the main ekurser page to make a new search to get the facets.

In practice this should only be a problem if either ekurser is almost never visited, or the facets change more frequently than ekurser is visited, and users tend to go directly to a facet term instead of the main ekurser search page.


I renamed MetricDefinition to MetricData to be more clear. (every struct is a definition)


Ugh, npm. Should work now.


> Given that I see legacy code being removed

What code has been removed?

But yes, `fastlane_core` should support both methods.


This can be a tuple :smiley:

```python
  if isinstance(val, basestring) and val.lower() in (
                    "no", "false", "off", "0"
                ):
```


This is done with SwiftyJSON, right? If so you can use:
```
let nextStep = tea["steps"][number + 1]["stepName"].stringValue
```
Instead of forcefully unwrapping. `stringValue` returns either the correct value or `""` if the value isn't found (`nil`)


OK, these are in master now.


See my other comment about forcefully unwrapping from the json object


never mind, i changed IndvMetric to MetricData and left MetricDefinition as-is it seems.


@slambert I'm confused about some of the changes made in ac6db0aad011b33edefcea3d7219004c8c28b614, mainly the Description tags and the use of  "rdf:#$hFzg+" attribute used on line 5 and 20

though these changes have worked for some time, maybe it's worth reverting back to the previous structure.


When only the name of an imported class changes, you can do this instead:

    from spock.vector import Vector3 as Vec3

so you don't have to replace the `Vec3` everywhere.


This method should return a '`Bool` instead of a `Bool?` since the answer to the question this function is binary it shouldn't be possible to get `nil` back (either the timer is running or it is not).


you may want to throw an exception or something so you can reverse any prework you did before sending the activated packet


Hi,
is the line

    $(".toggle-button").hide();

really necessary? Why is it relevant to hide the buttons after uncollapsing?


What is interesting to note is that if the table is 0, the highest depth it can accept is depth<=8.
If depth>=9 it will clear the table entry.
example:
9*9*64=576
576>=512
so:  table[pc][to]=VALUE_ZERO;


Excellent, thanks!


I mean `if (plusEnabled)`


That did the trick! thanks :bow:


Sss


yep you're right.


> Pag size

Typo.


I think a cleaner way would be to have an option not to get rid of the internals of theano.
In the tests, you would specify to use that option, and to keep all the user lines as well. That way, you will be sure that the whole stack traces correspond.


Любые поля, что нам приходят из sso нужно обновлять, а не только основные, условие как бы лишнее


Did this need to be `null`? If not in the config obj it would be undefined.


`string!` can be written as `stringValue` which is safer. Same applies to `int!` (`intValue`).


This will always be a path, so it will be better to use getPathInput(name, required, check)


You're absolutely right this needs to be addressed better. See if you like #21?


Do you not  think users should always have the choice to change the default selection? This could prove useful if one day one of the regexps stop working.


Since you just allowed this to be themed properly am I correct in assuming this fixes the custom color part? I went back to white commit instead of themed call because I could only set transparent, nothing else was respected


We've been trying to develop a secure site where the token is saved off in a cookie. Esri IdentityManager is supposed to append this cookie to all calls to the arcgis server, but it isn't working. This change is an attempt to get the proxy to append the token whenever IdentityManager fails to do so.


@UX-admin this commit breaks Boost detection on recent Fedora machines, which represents a much larger part of our user base. We also do not need this patch on our own Solaris builders, so we are going to revert it. If you want this fixed, please propose a correct and portable fix upstream at https://github.com/tsuna/boost.m4


Sounds reasonable!


You modified the script too right?


Why?
Since the index isn't random, you won't get much security with a pseudo random 8 bit value...


I'm a little reluctant to always open the stream; ImageMagick, for example, seems designed to take a filename (if I remember correctly, I thought their stream interface somehow seems tacked-on), and some (not very good) libraries may not even offer a stream interface.


Don't you forget to add the trailing '\0' on name_str here?


А где эти переменные определены?
AUTH_ENTRY_REGISTER


Furthermore, there is no locking, so multiple threads can get the same value.


Now, it's work fine !

But, but, for me this algoritm (Retinex) give artifacts...
Look at image "Madeira05.08;2005_10-21-33.dng"...at the right of image; there are big halos...and also
If I use wavelet, I obtain a better image...
I will look to improve algorithm !


resolve #18


This is impossible to add custom current steps such as 750 mA. The current is set here
https://github.com/ace2nutzer/Samsung_STE_Kernel/blob/956f2035d47287aab38e625fde5784fda39f96c7/drivers/power/abb_charger.c#L1537
If you look a bit deeper in sources you'll see that only 15 steps are allowed(100-1500 mA) and there's no way to add custom ones.


@flavorjones you might want to add `build: off` again since is used for MSBuild solution files instead and not the *build* itself.


test-unit was removed from Ruby in version 2.2 and moved into a gem, so the comparison should probably test for a RUBY_VERSION >= 2.2, but I can't think of an easy way to do that comparison.


this function should stay though IMHO.
there's a `EnsureIndex(m *schema.MetricData)` function that takes in metricdata and checks if the corresponding MetricDefinition is in ES, but for that it needs an id, which it gets based on the MetricData, i.e. using this function.

what may be a bit confusing is that i did end up removing an Id property for the MetricData struct (formerly known as IndvMetric), this was a property that was only in the schema on the raintank-metric side, but not in grafana.
but it didn't actually make much sense for it to be a property (because it's not part of the data and it was just used as a proxy and only generated once to query ES) so it was harmless to remove it, which i did. made the code a tiny bit simpler too.


Checkmarx scan results 24 Aug 2015 17:06 UTC +03:00

High
Medium
Low
Info

New
2
2
21
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


I setup a new branch with the older XML structure updated with new version info — 0e7ecdf86bd242f0ad3a79418a581a61411926a8

want to try submitting this?


Yep. I've already done it. I'm publishing the 0.2 release now.


@gautric I removed the compatibility matrix from the main page, as the Rhiot scope is wider than Camel itself. Is that OK with you?


delete


The GC scanning performance for this will be awful.

Couldn't we improve mono_g_hash_table to support weak values?


Fixes #338


Try to remove this max-wdith from 'android-wear-band-text' class in styles.css. IT will fix alignment issue


As far as I know, If you delete this line, the tool redirects on partner-tools to old site will not work, since they relying on these returning not implemented.


Looks good!


This I added for myself and forgot to remove. But it won't hurt to add vim modelines to the scripts actually...


If the test is failing in this commit, please mark it as so with `@unittest.expectedFailure`, and remove the expectedFailure annotation in the commit that fixes the bug. Otherwise, you don't have a bisectable history (IOW, each commit should pass the testsuite).


doc = Nokogiri::XML(xml)
doc.xpath('//string[preceding-sibling::key[position() = 1 and text() = "JVMHomePath"]]').each do |x|
	puts x.text
end


yeah i know i have a few of those in there just covering all my bases before cleaning up my code


good


--Untested---


Checkmarx scan results 24 Aug 2015 17:10 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
2
2
21
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Was hoping we could use subcommands a la trollop (would also like to use trollop since we own that gem now :smiley:)

So, the command line would be like:

```
$ ascii_binder new some_directory
$ ascii_binder build # or just make this the default as you did
$ ascii_binder watch
```


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


True! I'm fine with your proposition from #21.
Maybe the middle ground could be this:
```Julia
# in fileio
function load(f::File, args...; key_args...)
    open(f) do s
        skipmagic(s) # should this be here!?
        load(s, args...;key_args...
    end
end
# in e.g. imagemagick:
load(f::File{format"ImageMagick"}), args...; key_args...) = ... # overload load
```
This way one can save some writing in julian IO libraries that operate on streams, but we still can opt out!?


It was confirmed using the [Microsoft File Checksum Integrity Verifier Utility](https://support.microsoft.com/en-us/kb/841290).

```
C:\>fciv -md5 "C:\OpenNI-Win32-1.5.4-Dev.msi"
//
// File Checksum Integrity Verifier version 2.05.
//
996d48f447b41a5501b7d22af27ab251 c:\openni-win32-1.5.4-dev.msi

C:\>fciv -md5 "C:\Sensor-Win-OpenSource32-5.1.0.msi"
//
// File Checksum Integrity Verifier version 2.05.
//
55da1f7541d7c9c98772bddf801c7e1c c:\sensor-win-opensource32-5.1.0.msi
```


This caused a fatal error in my code. Because its already set in the interface.


Hi @theod -- I'm curious what has motivated the change of the gain knob range, as we spent a lot of deliberate time on this topic when we initially made it the way it is.  Perhaps we should open a discussion ( and include @lossius ) if a serious change like this needs to be made?


I'm game - I didn't have a good idea on which lib to use for it.

On Mon, Aug 24, 2015 at 10:12 AM, Jason Frey <notifications@github.com>
wrote:

> Was hoping we could use subcommands a la trollop (would also like to use
> trollop since we own that gem now [image: :smiley:])
>
> So, the command line would be like:
>
> $ ascii_binder new some_directory
> $ ascii_binder build # or just make this the default as you did
> $ ascii_binder watch
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nhr/ascii_binder/commit/09decd3bf222af10380a3049a7f131eaa62ea09d#commitcomment-12858150>
> .
>


25:1: I201 Missing newline before sections or imports.


Yeah, we ninja-patched this in Firebird's version of `scoutfile` but dropped the ball on contributing it back.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Is it useful for example for apps like Nightly and Aurora, which will never be available at another source?
I only say, there should be an option to set for apps where it is definitivly the case.


You should also check for the wraparound case. (`iova + length < iova`).


@zkirill This is what Apple recommends in their [documentation for managing strings files](https://developer.apple.com/library/ios/documentation/MacOSX/Conceptual/BPInternational/MaintaingYourOwnStringsFiles/MaintaingYourOwnStringsFiles.html). Look in the section titled: "Creating Strings Files for User-Facing Text in Your Code"


markers.sample_num should be more accurate and consistent than marker_block


:boom:


I was wondering if we needed to provide any other parameters to the getParameterXml override, but after looking at what PIR and Report Viewer need when fetching the xml, they only need to be able to getParameterValues, which you can get from the API. I figured the API would have all of the functions necessary for getParameterXml.

Good catch on the above check. I will add a return statement inside of the if statement.


This does not work, nor does "\${out}" or just "$out", how do I get the output directory?


Thank you!

There seems to be one problem though: MTA crashes in libcurl.dll when quitting. Unfortunately, I don't have the addresses anymore as the callstack always gets corrupted in my recent builds.


Whyy did you remove all the regions

Whyyy XD


What about other types?


@yehudasa we aren't modifying _to_index_valid_ at all, it's only a kind of alias with name reflecting the intention behind using it. I guess it's nice in such situation to explicitly tell reader about that through _const_.

I will make _from_index_ and _to_index_ const references.


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


hmmm, I had a hard time on this one - chrome optimization algorithm avoids repainting the core area thinking that the external container had the same color. I could reproduce this on [g1](http://g1.globo.com/index.html) page some time ago, not sure if it's related to bugged css in there. I would test it again before removing this code.


Ideally all RRs should support it. I becomes more interesting if a) this is needed/wanted at all and b) should we export it.


Isn't an 'at_least_version' field worth it?


I think this code would feel safer with a memset(0). On second thought, why don't you just make the pool zero out objects it allocates. Do you think it will hurt performance too much?


Effectivement j'ai corrigé merci


@jython234 Yeah


Kindly remove me from the repository .
I am no longer a member of the web team


Easier to read when going through the chain (personal pref) and seeing as `JDatabaseQueryLimitable`, I assume the `$limit` and `$offset` arguments in the `setQuery` function will no doubt become deprecated at some point in the future


Could you use ALIGN() here, or is RXE_BUF_PER_MAP not a power of two?


Hmmm, true. and this is true when using Pack() as well btw.


With these two scripts:
```bash
git checkout master
python list_structs.py > structs_orig.txt
git checkout struct_rework
python list_structs.py > structs_rework.txt
diff structs_orig.txt structs_rework.txt
```

`list_structs.py`:
```
import ctypes
import inspect
from epics import dbr

def _issubclass(cls, base):
    try:
        return issubclass(cls, base)
    except TypeError:
        pass

objs = [getattr(dbr, name) for name in sorted(dir(dbr))]
structs = [obj for obj in objs
           if _issubclass(obj, ctypes.Structure)]

for struct in structs:
    fields = []
    for cls in reversed(inspect.getmro(struct)):
        if hasattr(cls, '_fields_'):
            fields.extend(cls._fields_)

    print(struct.__name__, fields)
```

The result is:
```bash
$ sh compare_structs.sh
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
Switched to branch 'struct_rework'
Your branch is up-to-date with 'origin/struct_rework'.
1a2,5
> ('_ctrl_units', [('status', <class 'ctypes.c_short'>), ('severity', <class 'ctypes.c_short'>), ('precision', <class 'ctypes.c_short'>), ('RISC_pad', <class 'ctypes.c_short'>), ('units', <class 'epics.dbr.c_char_Array_8'>)])
> ('_stat_sev', [('status', <class 'ctypes.c_short'>), ('severity', <class 'ctypes.c_short'>)])
> ('_stat_sev_ts', [('status', <class 'ctypes.c_short'>), ('severity', <class 'ctypes.c_short'>), ('stamp', <class 'epics.dbr.TimeStamp'>)])
> ('_stat_sev_units', [('status', <class 'ctypes.c_short'>), ('severity', <class 'ctypes.c_short'>), ('units', <class 'epics.dbr.c_char_Array_8'>)])

```

The differences listed above show only the addition of the new base classes.
That is, the structures have remained the same between the versions. Tested with 2.7/3.4.


Fixed in Next Update.


yep, that's wrong. Thanks.


No, it has a very different header format. It's my own lab's format. I'll deal with splitting it out.


Can you write this as a short circuit operation instead? See https://github.com/mapbox/react-colorpickr/blob/26c78c924511edbef7eb300873246e59d219d96a/index.js#L406-L413 as example.


```
if not e:
    self.print_warning(...)
    continue
```


hash


unicode


Great!


I think this macro needs a uncrustify.schema entry.


I support that, although it will require constant checking for when something breaks.


I understand phys MRs are going to be removed from the kernel. If you send this code after they are, then you should remove this code as well.


the origin skydns dedup checks for CNAMEs as well. If it moves to be more generic I think we even need to check DNAME and friends...

Re: long TTLs, possbily unlikely, but true as well.


Picky, but can you add wrap this value in single quotes instead?


So, if we want to get the _submission_ context, we cannot retrieve the context when the execution context is created (as it will be shared), but when a task is submitted.

This results into:

```
@Override
  public void execute(Runnable runnable) {
    Context ctxt = Vertx.currentContext();
    if (ctxt == null) {
      ctxt = vertx.getOrCreateContext();
    }
    ctxt.runOnContext(v -> {
      try {
        runnable.run();
      } catch (Throwable e) {
        reportFailure(e);
      }
    });
  }
```


Naive question: could we use `6 * variable_name`?


Checkmarx scan results 24 Aug 2015 17:23 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
2
2
21
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


please respect the alphabetic order of the namespaces


add author information


`b.toString()` is a leftover and could be deleted


This commit is being reviewed as a part of review issue #56.


So the reason it was not picked up by the IntelliJ was, that I had for some reason excluded the target directory.

After some thought, I think we can keep it. Although I have made a slight change on how it's used (in branch autoplugin of my fork, more on that in #46)


maybe package protected?


missing final


@mbernat This is mostly pretty boring code. Just introduced `common.BlablablaFactory` to be able to use `LocalConfigTemplate()` for every module to get the string to be inserted into the template when running `repo bootstrap`.


I remember seeing that bind verb was not supported. If that's the case then there's no need to support memory windows.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1277 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi Tim, this relative to the feature asked by Trond on the dev list to get internal audio/gain parameter in dB, range -70 +6.
as this feature have consequence for j.ui widget I choose a easy solution by using the same range here too.
but it is possible to have a different unit and range for j.ui as it is a view separated from the model so we can stay in midi gain here if needed while the parameter is in dB.


This wouldn't be needed if we added a `require` option to `gulp-compass`.


Hmmm, yeah.  I guess I got split up the versions?

I just don't understand what Bundler doesn't provide this.  It's silly `:platform` thingy is super not future proof.  I suppose another option would be to move to a test framework not coupled to the platform…


I like the openness of how this is being done now, and I thought the same process as before would continue, where the developers were committing in. But it's great to see that almost everything is going through review, so that all puplic can view the code that is going in.

I am quite nosey, and always interested, as I like to see what's coming up, and what's being fixed; so that I am able to support my customers better


instead of `.aws` it should be `.rebilly` no?


I think you might have mixed minified and non-minified variable names.


Thanks. Because of changing many times the variables, I didn't see this.


This is never set from the constructor, is this how it should be?


@azturner Develop seems to be missing a migration:

public partial class wat : Rock.Migrations.RockMigration
    {
        /// <summary>
        /// Operations to be performed during the upgrade process.
        /// </summary>
        public override void Up()
        {
            CreateIndex("dbo.FinancialPaymentDetail", "BillingLocationId");
            AddForeignKey("dbo.FinancialPaymentDetail", "BillingLocationId", "dbo.DefinedValue", "Id");
        }

        /// <summary>
        /// Operations to be performed during the downgrade process.
        /// </summary>
        public override void Down()
        {
            DropForeignKey("dbo.FinancialPaymentDetail", "BillingLocationId", "dbo.DefinedValue");
            DropIndex("dbo.FinancialPaymentDetail", new[] { "BillingLocationId" });
        }
    }


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (752 of 752 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.91%25-green.svg)


Is this branch only for phys MRs?


The best I can think of is `if RUBY_VERSION.scan(/\d+/).map(&:to_i) <= [2, 2]`, but that's not super self explanatory.


I think you could use better names for these parameters than `m` and `n`.


That's the benefit of having more eyeballs on a piece of code!


I prefer things the way they were before. It reads as "git-town.com", and links to "http://www.git-town.com".


By default, if `$break-menu` is a number of pixel, e.g. `500px`, `media` `min-width` will apply.


Nit picky thing:  Why is "keyWords" camel case?  It's one word, not two.


As discussed, no comparison needed as is now a True/False value.


We normally put this `base` `partial` at the end as it has dependencies on other `partials`.


Looks great so far. I will keep a eye on your progress. Thanks.


EINVAL?


This line makes the following code in `config.rb` unnecessary:
```Ruby
require 'susy'
require 'breakpoint'
```


@kyleam Please have a lock at these entries and add new ones for the things you just changed. Then push to this branch (`relnotes`) using new wip commits. I will then create a proper commit and release.

Note that I try to use a style similar to what is used for git bug fix releases, so don't "fix" that.


nope, should be exaclty enomem since the problem is out of memory (refcount > UINT16_MAX)


I know, but I still think this is worth distinguishing between "No such user" and "This really shouldn't happen".


@nfebuary
Could be wrong and haven't try that patch, but looks like a typo: ">" in "ta>sk"


Sure, let's try that and see if it works. Good idea.


Do we need to bump struct api versions at this point?


Hi @katzer, quick question, we are working on a very privacy [sensitive application] (https://github.com/bitpay/copay), and users have complained about the new GET_ACCOUNTS permission.

Do you know if the plugin would work if we modify the plugin before bundling the app, removing the lines:
```
       <config-file target="AndroidManifest.xml" parent="/manifest">
            <uses-permission android:name="android.permission.GET_ACCOUNTS" />
        </config-file>
```
?
thanks


I think this could just be a volatile fileld, rather than an `AtomicBoolean`, could it not?

What is the benefit of this being an `AtomicBoolean`, cache line isolation? Because I don't see any reuse of the object.


Nice. :smile:


Checkmarx scan results 24 Aug 2015 17:37 UTC +03:00

High
Medium
Low
Info

New
2
2
21
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Extra spaces at the end, and remember the uncrustify schema.


DIACRITICS FOR THE DIACRITIC THRONE!


Strange, would have expected `*(instance._Function)()`


I only change range of settings :
* variance
* gain
* offset

I put a link I think a good compromize, using Dehaze and Wavelet for "Madeira...dng"
http://jacques.desmis.perso.neuf.fr/RT/Madeira05.08.2005_10-21-33.dehaz-wavedng.pp3


TeamCity ReOpenLDAP :: devel-2.4 [Build 179](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=42&buildTypeId=ReOpenLDAP_Devel24&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:45:30


TeamCity ReOpenLDAP :: devel-2.5 [Build 101](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=35&buildTypeId=ReOpenLDAP_Devel25&guest=1) is now running


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1277 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Maybe EINVAL?


Nit picking: scrip -> script


Why not treat png_save_uint_16 the same way?

   buf[1] = i % 256;
   i = i / 256;
   buf[0] = i % 256;

The change to png.c has already been done, but without any
typecast on "i" in the call to png_save_uint_32().


I suggest to change
```python
from monitorrent.utils import soup_factory
```
to
```python
from monitorrent.utils.soup_factory import get_soup
```


More generic to use logname here (which I guess you'll get when you rebase). :)


$ npm install browser-sync del gulp-autoprefixer gulp-compass gulp-plumber gulp-rename gulp-uglify --save-dev


Hi.
This doesn't actually fixing the issue for me. It still can't find the user with id > 1000 with api.get(User, email='user@domain.com'. There is similar problem with php backend: http://forums.kayako.com/threads/php-api-kyuser-getall-not-returning-all-users.29970/ and they recommend to do that in cycle by 1000 users per time. Would be great if such functionality will be in python module by default.


Why link phase is use instead of compile phase?


nitpick: extra empty line.


@lucascaton : Rails is still supporting Ruby 2.2.2 ; this commit just makes the CI server uses 2.2.3.


Nice! Keep going!


Do not merge this. Was trying to explain what the defineProperty function was doing to someone else. My bad


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Small improvement suggestion: Catch the return code so to not to proceed to the pip install on rc != 0 (then we may not have the dependencies setup).


nitpick: extra space after `req->pp`.


Esta alteraçao foi feita diretamente no repositorio do gif via web.


Can this really happen, or is it checked somewhere else in the responder flow?

If it can happen, I think you should somehow return a different error value so that the completion can report the length error.


输出世界你好


How did you do this? I mean, what is the git command?


Iterator -- это интерфейсЮ зачем он тут?))


Ugh, just forgot.  I am constantly amazed at how your eyes will just scan over something you've written and notice glaring mistakes like this.


What DCSS version are you targeting? Elliptic seems to write against trunk


proyecto re-remate


Done


Also there is a glaring syntax err on line 87

equal.(err)

whoopse, fixing now


А вот numGenerator как раз должен реализовывать этот интерфейс, т.е. иметь три метода:
- Name() string
- Count() int
- Next(step int) []*checker.Checker


@alpha0010 then ask the linux-mm folks about it. As it turns out the [thread](http://thread.gmane.org/gmane.linux.kernel.mm/65493) that my last interaction with the mm guys spurred discussed `FADV_NOREUSE`. In fact, an (unfortunately incorrect) implementation was even offered. It might be good to bring up the matter again; they would likely want to know if there is demand for a feature that is currently not implemented.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 400](https://teamcity.labkey.org/viewLog.html?buildId=267995&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:23
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


I really have no idea what changed in that last sentence.


this is not a problem, is ?
At least uncrustify does not complain with those spaces.


Seems okay to me


Yeah the same thing was done in #38


I was thinking about not keeping a reference to the `sol_fd` would cause problems. I did test (in simple cases) under valgrind, it couldn't find any problems.

(optional) But I think that this is depending too much on how `sol_fd` is implemented. I guess it would be clearer if you kept the reference and cleaned it up in the end.


I didn't know markdown supported em-dashes, interesting!  thanks


how to disable enable guid now ?


This does make it prettier


not sure, i'm using einval for invalid values/parameters, when is something that i do not know the problem, i prefer return -1. But i'm ok with change it if you guys prefer


Leave the `inlineDeferreds` stuff as a next step for people who are interested to look into on their own.


this `find` is not needed, you're looking for the item you already have


yep, we are changing this structure/api. This field is exaclty for this


08/24
遊戯王OCG事務局です。

いつも遊戯王オフィシャルカードゲームをお楽しみいただき誠にありがとうございます。
ゲームルールについてお問い合わせいただいた件、下記のとおりご案内申し上げます。

Q.1.
●自分フィールド上：
《ＤＮＡ改造手術》（魔法使い族を宣言）
「ヒュグロの魔導書」の効果が適用された「レッド・デーモンズ・ドラゴン／バスター」
銀河眼の光子竜
タキオン・トランスミグレイション
●相手フィールド上：
異次元の戦士
「レッド・デーモンズ・ドラゴン／バスター」攻撃のダメージ計算後

チェーン1：自分のレッド・デーモンズ・ドラゴン／バスター
チェーン2：相手の「異次元の戦士」
チェーン3：自分の「タキオン・トランスミグレイション」
チェーン処理が終了した後、「異次元の戦士」はデッキに戻ります？
この場合、「ヒュグロの魔導書」の『戦闘によって相手モンスターを破壊した場合、デッキから「魔導書」と名のついた魔法カード１枚を手札に加える事ができる』効果は発動しますか？
A.
戦闘での破壊が決まっている「異次元の戦士」も、「タキオン・トランスミグレイション」の効果によってデッキへ戻ります。
なお、この場合であっても、「ヒュグロの魔導書」の効果を受けた「レッド・デーモンズ・ドラゴン／バスター」が、戦闘で相手モンスターを破壊しているのであれば、デッキから「魔導書」と名のついた魔法カード1枚を手札に加える事ができます。

Q.2.
自分フィールド上：《ＤＮＡ改造手術》（魔法使い族を宣言）、「ヒュグロの魔導書」の効果が適用された「レッド・デーモンズ・ドラゴン／バスター」
相手フィールド上：異次元の戦士
「レッド・デーモンズ・ドラゴン／バスター」攻撃のダメージ計算後に「レッド・デーモンズ・ドラゴン／バスター」、「異次元の戦士」の効果を発動する場合、「ヒュグロの魔導書」の『戦闘によって相手モンスターを破壊した場合、デッキから「魔導書」と名のついた魔法カード１枚を手札に加える事ができる』効果は発動しますか？
A.
「ヒュグロの魔導書」の効果が適用された「レッド・デーモンズ・ドラゴン／バスター」が、「異次元の戦士」の効果によって除外された場合や、「レッド・デーモンズ・ドラゴン／バスター」の効果によって破壊した場合であっても、戦闘ダメージ計算を行った結果、「ヒュグロの魔導書」の効果を受けた「レッド・デーモンズ・ドラゴン／バスター」が相手モンスターを破壊したのであれば、デッキから「魔導書」と名のついた魔法カード1枚を手札に加える事ができます。

Q.3.
「異次元の狂獣」の発動のタイミング、詳しく教えて下さい。
A.
「異次元の狂獣」の効果は、ダメージ計算後にて発動します。
ダメージ計算後に発動し、戦闘で破壊が確定した相手モンスターをゲームから除外します。

Q.4.
相打ちで「異次元の狂獣」の効果除外できますか？
A.
「異次元の狂獣」と相手のモンスターがお互いに戦闘で破壊された場合であっても、「異次元の狂獣」の効果は発動し、相手モンスターを除外します。

Q.5.
戦闘破壊された「見習い魔術師」が「異次元の狂獣」の効果で除外された場合、「見習い魔術師」の効果を発動できますか？
A.
「異次元の狂獣」との戦闘で破壊された「見習い魔術師」が、「異次元の狂獣」の効果によって除外された場合であっても、ダメージステップ終了時にて、その「見習い魔術師」の効果を発動する事はできます。

Q.6.
戦闘破壊された「見習い魔術師」が「超念導体ビヒーマス」の効果で除外された場合、「見習い魔術師」の効果を発動できますか？
A.
「超念導体ビヒーマス」の効果によって、戦闘で破壊された「見習い魔術師」が除外された場合においても、ダメージステップ終了時にて「見習い魔術師」の効果を発動する事ができます。


use `Flame.Collection` and `createWithMixins()` instead of `.extend().create()`


this probably could be replaced with erl_anno:location/1


the indentation looks off here


You want to get the context when the _user_ submits the operation, not
when it is executed.

On 24/08/15 15:23, Clement Escoffier wrote:
>
> So, if we want to get the /submission/ context, we cannot retrieve the
> context when the execution context is created (as it will be shared),
> but when a task is submitted.
>
> This results into:
>
> |@Override
>    public void execute(Runnable runnable) {
>      Context ctxt = Vertx.currentContext();
>      if (ctxt == null) {
>        ctxt = vertx.getOrCreateContext();
>      }
>      ctxt.runOnContext(v -> {
>        try {
>          runnable.run();
>        } catch (Throwable e) {
>          reportFailure(e);
>        }
>      });
>    }
> |
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vert-x3/vertx-mysql-postgresql-client/commit/244ab07a0fe2572348389b9e35eb5e3a99df20c4#commitcomment-12858420>.
>


`return this.get('menu.value').contains(this.get('content.value'));`


i'll do, thanks for pointing it


ack


@masoodtalha, does this first commit include changes from the original? I see a new comment, but how would one be able to see the differences?


`char name_str[PATH_MAX] = {}` initialized the entire array to zero.


Included overlooked fixes for https://github.com/radssh/radssh/commit/728e88b64d096eedd3cad79e041f09ceda5db488 that weren't caught earlier. Python2 str.decode() does not take named parameters.


Do you need #to_a here?


morris.js css style file


Yes, png_save_uint_16 could be treated the same way.

All of these functions are a little odd to me.  I feel like they should be taking exact width integer types such as uint32_t or minimum-width integer types such as int_least32_t but I don’t want to change the APIs.  Right now both these functions take identical arguments.

Eliminating the type cast on “I” is probably a good idea.

Thanks,

rCs

From: Glenn Randers-Pehrson [mailto:notifications@github.com]
Sent: Monday, August 24, 2015 10:40 AM
To: rcseacord/libpng <libpng@noreply.github.com>
Cc: Robert C. Seacord <rcs@securecodinginstitute.com>
Subject: Re: [libpng] rewrote png_save_uint_32 function to be portable across difference sizes of int without undefined behavior (add2713)

Why not treat png_save_uint_16 the same way?

buf[1] = i % 256;
i = i / 256;
buf[0] = i % 256;

The change to png.c has already been done, but without any
typecast on "i" in the call to png_save_uint_32().

—
Reply to this email directly or view it on GitHub <https://github.com/rcseacord/libpng/commit/add2713701c33a353667ad0adae0ebb8f873073f#commitcomment-12858882> .  <https://github.com/notifications/beacon/AC5XlJV4logMuHN0D8vlXfI94FOzgG-0ks5oqyQmgaJpZM4FxCsT.gif>


While it's obviously fantastically unlikely, in theory these could be the same.  Change it to be `i = 1` and do `a[0] = random (); b[0] = a[0] + 1;` at the start?


Shouldn't it count down?


And there is no difference in calling get_all(User, 1, 1000) and get_all(User, 1, 10000), because Kayako API will return 1000 results max. So this change is no-op actually.


Right now I tried to keep only one instance of the execution context, to really get the context during the submission, it would mean creating multiple instances. I will work on a version with several instances.


Strange enough, it looks fine to me
![kk-snap](https://cloud.githubusercontent.com/assets/10297022/9443336/020bfc70-4a9a-11e5-835d-5674ee41d9de.PNG)


You are right, No need for this definition because we don't allow the mtu to be bigger than 4096 , i'll remove it and use ib_mtu.


@masoodtalha, does it work now? What does `toggleSortableClickHandler` do? What *should* it do?


Я бы наверное установку этого условия отдельным методом сделал, но можно и так, если это что-то очень важное. Но я даже не понял как это используется. Оно в каких-то других репозиториях?


Looks like you could use a `min` here.


It's enabled by default now. There isn't any reason to disable this anymore.


@harsh96 You have been removed. You should `Unfollow` this repo using the button at the right top corner of the repo page.


Yep, you will need a different instance for each invocation.


i thought i had already done this. I will do this, but i cannot found how this can become a problem, the lifecycle of this is controlled by libmicrohttpd


You are right, I'll fix it.


This could be simplified to
`else if (is1 == null || is2 == null)`

Sorry if this is unwelcome.


the item not stacked so its annoying in storage from event items. So, just remove the item flag of GUID and its settled isnt it ?


Same as above


Probably should be fixed, feel free to do it.


I'm still getting spurious 0-byte transfers with no error conditions. `bytes_transferred` is passed to the completion handler with value 0. I use the completion condition of: `transfer_exactly(1)`


YOU SAVED MY LIFE!


What happens on pause events? Does sound get paused?


sure, ok to push with this change?


This assertion seems to be that the chunks have the same length...which they should, right?  Unless I'm missing something.


I'm still getting spurious 0-byte transfers with no error conditions. bytes_transferred is passed to the completion handler with value 0. I use the completion condition of: transfer_exactly(1)


In that case, yes, you can remove/comment the GUID section from the item_flag.txt file.


This should be signing up procedure, not log in.


This change has broken my grep settings.. why is `.` not allowed?


allright thanks !


Seems fighting too much.


That is some beautiful code.


the tile resizing finds containers to the left/right/up/down using this function, so it can resize the adjacent containers too.
this would grab containers across outputs and mess things up. its fixed now though.


Please note that access must have at most single bit set.


k


Hopefully it shouldn't happen often. If it does, we might try to reduce ``--cores``.


Really anal of me but mainly to match the rest of the project, can you remove the blank line please.


Hi,

Here is an implementation for mail reply scenario to keep the encrypted attached files after re-opening them with mailvelope editor again. For instance, when we reply to an encrypted mail which has attachments and we would like to see them or add another to them.

The reply to can be activated through options by setting replyTo flag into true while we initialize the editorContainer.

Please let me know your thoughts.

Thank you.

Hadi


jj https://github.com/rohlikcz/nette-code-checker/pull/1


Ah thanks for the insight Tobias! \cc @phated.


While the 1.7.2 patch works on the 1.8 stable branch, it no longer works on the 1.9 mainline branch unfortunately.

this is the only failure however, so probably not too hard to fix

     patching file src/http/ngx_http_upstream_round_robin.h
     Hunk #1 FAILED at 36.


No it was previously [http://www.git-town.com](git-town.com). Check the source of my comment


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1277 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I guess not as this is by default returning an array :)


Just some comments (on the order of IMHO rather than "this is how it should be"). The code below uses a heuristic to find the center and radius of the circle that's used to inscribe the Zernikes and you may want to make the radius and x and y center into parameters which can take default values if not explicitly set. In CellProfiler, we find the minimum enclosing circle around each cell or nucleus measured and use the center of that circle as the Zernike center and the radius as the radius. Alternatively, you could use the center of mass and the distance to the point furthest from that. There may be images where it makes sense to calculate the Zernike over the whole image, but I think the most useful may be when calculating within a region of interest where the caller might want to alter the heuristic. For a labeling, you may want to have a table of centers and radii per label and have the Zernike calculated per label - that's the way it's done in CellProfiler.


For the current code, this is fine. The problem is when we have another "ifdef" feature that needs to shutdown the others, e.g., imagine there's another protocol client: we want to call `sol_network_shutdown` if one of them fail, but not twice. And if our protocol fails, we may want to call `sol_http_client_shutdown()`.

I think a better approach here is: (a) assume all those functions exist in the general init/shutdown code (b) create empty versions of them (those empty versions com be in sol-comms.c, ifndefed appropriatedly). That way initialization / shutdown code will contain no ifdef and no need to worry about combinations. Compiler will be able to get rid of the code with the empty functions.

Makes sense?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1277 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Minor: If we're adding tests that trip this assertion, can we move the assertion fix before the tests in the history to preserve bisectability?


Those are for cases when we have a race between `Updater` creation and rotation.
During construction of new `ConcurrentMapState` we will pass tracked changes as `this.hasTrackedChanges = prototype.hasTrackedChanges;`. That will prevent us from loosing updates that happened after state creation.


I wasn't sure about its meaning.  I managed to get to_offset != from_offset and it failed with some random data, but I spent a whole day trying to reproduce it without any luck (I really had to save the data I used :()

I will drop the commit from the series.


concat?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Just to clarify, can't we just instantiate a TTaskAbstract and  reuse it than creating 3 different ones for each priority change?


oh, next commit :D


@Snkz
Does this seem more or less reasonable to you?


I think it is best the way you've done it, Theo. Thanks!


Thanks I think it will be useful for many!


Can we just remove these?


Could we hide this config from the user, it seems we don't have a use for the shared infrastructure except when either `HTTP_CLIENT` or `HTTP_SERVER` is around. It could be automatically selected when either of those are selected.


Thanks to @faux123


Before you got a -1 and now only the type... Does it is wanted?


@ethantw t looks like row 108 should actually have 5 columns, instead of 6, and that makes it harder to read the source since github won't display beautifully on account of that.


before it was defined as
```
#define NO_ID				((uint32_t)-1)
```
Now we see that the minus one have disappeared...
Does it is wanted...
BTW, the T-1 is more elegant with numeric_limits<T>()-1
So does it should be:
```
#define NO_ID				DECLARE_NO_INDEX(std::numeric_limits<uint32_t>::max())
```


I found this bug :D


I think I've mentioned it before.
Installing Gapps totally ruins this. This doesn't make sense for community CyanogenMod builds.


:+1: this is good


Except for the infinite loop I created. Fix it later (after adding tests) ;)


the alias list was recently added to NetJSON NetworkGraph with the name of `local_addresses`, for more info see https://github.com/interop-dev/netjson/issues/15 or https://github.com/interop-dev/netjson/commit/db8fb24dae091c1a15b247a7e178aff97016a515
So dealing with aliases will be (hopefully) possible in a generalized wa :+1:


@posita the first commit was the original file and the second commit is refactored version. In the commit you can see the changes I have made. Basically to start with everything was attached to `window` variable which is wrong. There was absolutely no encapsulation implemented which is a very bad code practice.

Also in the function `areListsPresent?` variable `found` was used without being declared (unless it was declared in another file which I don't know about).

Frankly I have not tested the fix, I would be happy if you give me access to some git repo where I can push my changes and see if the fix works. There I'd be able to see other related files as well.

Thanks,
Talha


FYI I created a whitelist request for Travis to add this ppa:  https://github.com/travis-ci/apt-source-whitelist/issues/120

Judging by the number of open requests I'm guessing it may take a while to be added.


log ;)


Creo que es mejor poner aquí directamente la lista de admitidos, y así no tienes que dar permiso a todos los que quieran ver el listado.
Algo así como *Admitidos Grupos de estudio Primer Ciclo*


I think we should only bump this once we set on stone that our ABI is somewhat stable. My understanding is that we are not there yet.

Other way to think is: is there any code today (module or program that links with soletta) that depends on soletta HTTP and we may not recompile (and want to fail at runtime)? Once we have a release with some kind of compatibility promise, I don't see benefit in bumping versions.


Hlvc


Wouldn't putting the `if debugging` call inside `SU.debug` and returning right away if it's not enabled be a more elegant way to code this? Did you compare what kind of  performance difference that would give? I don't know  how Lua handles optimizing things like that, but it might be roughly the same as having to code the check before every call.


what


Pense que se podia ver! Pero es mucho mejor lo que dices, gracias!


fine


Please note: https://github.com/arangodb/arangodb-php/commit/c0d8041f67d964f4f971baf81f73c21a8456f089


We get both `window` and `document` by specifying `browser: true` under `env` so these aren't strictly necessary.


This change has actually caused issues for me. I think  it needs to be
```
angular.extend(scope.center,{
   lat: map.getCenter().lat,
   lng: map.getCenter().lng,
   zoom: map.getZoom(),
   autoDiscover: false
});
```

as stated in the issue. My center always seems to get reverted after extension. Therefore the map never moves and always moves back.


Could this be implemented in terms of `SOL_VECTOR_FOREACH_IDX`?


17526 - Use PostgreSQL with Ruby on Rails Application – CentOS.html

Why did you do this


Hmm, I think the renderAssocArray is used in a few places. :-|

My memory isn't recalling exactly where or why, but we should verify how and why it's used before removing it. It could have been added for use in the compiled output method.


You can just set expires_at in lets. before is redundant


I couldn't find any references to it, and it never showed up in code coverage.


We can if we do something like this in ```romanesco/__init__.py```:
```
+from executors.python import run as python_run
+from executors.workflow import run as workflow_run
 from . import executors, utils

@@ -43,8 +44,8 @@ def unregister_executor(name):

 # Register the core executors that are always enabled.
-register_executor('python', executors.python.run)
-register_executor('workflow', executors.workflow.run)
+register_executor('python', python_run)
+register_executor('workflow', workflow_run)
```


this appears to be missing a gcroot and wb (for assignment to t->result in finish_task)


Do we also want to enable `blockBindings`, e.g. `let` and `const`?


P>S> thanks a lot to @kikote300


Ah, then it should be the other way around:

```markdown
[git-town.com](http://www.git-town.com)
```


please commit into fluent-api branch


Hey Jack,

 Your method actually does more things than it should. It will get called even if you do not change the current page. The `didChangeCurrentpage` would be misleading.

Cheers!


get rid of this change


i believe this variable name has come from the old code, is it possible to update this variable name "varStr" with a more meaningful name, which will provide the reader the actual context of the data/ content in it.


Yay this one had been bothering me.


Shouldn't the Windows Open AL bindings be inside the block, like the Mac and Linux ones?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (752 of 752 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.91%25-green.svg)


GitHub has a capitalized H.


urls


Yup, and if you're going to link you need to include `http` or `https`.


@liewegas, sorry, i meant "we should remove TryLock() here".


I wondered about this before, but is there a race here? If discover returns a "hot" task, then what happens if a test is discovered before you subscribe?


I am a massive derp


It seems we don't need reference count for server objects at the moment. Are there cases we expect this to be necessary?

The only place that actually uses these functions, also keep an `init_count` of its own (to set `server = NULL`) that could be used to also `del` the server.


Perhaps there's a better analogy out there than Microsoft Office?


Thank you!


I'd like to add [`spread`](https://leanpub.com/understandinges6/read#leanpub-auto-the-spread-operator) too.


The H in Github is capitalized.


What do you think about configuring the server to use `http://git-town.com` (no www, GitHub does that for example). Seems cleaner to me, though there are arguments on both sides


I've tried that and it appeared that you cannot set a date in the future for some reason. It was ignoring the +2.hours in the it block for some reason. Any ideas why ?


The H in Github should be capitalized.


@philipobenito

This is the one I was wondering about - unless `AbstractDefinition` implements `DefinitionInterface`, there are no docs to inherit. Reverted the change here.


go go go


Ah I see the issue now. :+1: for your suggestion.


We might also want to add `WHICH` here...?


Perhaps 2 or 1 is the optimum value... And that could mean some more elo...


I set the assembly list up to have extended selection, which means you *could* have multiple assemblies selected when you do this?


> "You've heard about a server is before"

Perhaps you meant "You may have heard the word server before, but may not be sure what it actually is."?


This comment should probably go on `RebuildTraits` itself, since it applies everywhere you call it.


Maybe model sets it on create somehow. Accepting then :)


This should use `https`


make odd sides = 'x' and  even sides = 'y' so that sides > 4 can still be handled


yeh, i already had remove the quest id on my next commit
and did minor fix as well


That's what `SU.debug` already does. The reason this works is (a) it saves function calls, which are pretty slow; (b) Lua has to construct the parameters to pass to `SU.debug`, and usually that involves string concatenation (`" Deactivating r ("..self.r.type..")"`), even if `SU.debug` returns right away. String concatenation in Lua is very slow.


### 誒喲真難找啊。


this modification need to be reviewed by odoo china community.
jeff@osbzr.co
oldrev@gmail.comm
ccdos@intoerp.com
lvxin@gmail.com


Defaults are loaded later, on the loadsettings function (which i also think
calls save settings to flush valid cfg to the file). Is the errno extra
logic really worth the trouble? I mean even if we try to save so what?
Am 24.08.2015 14:10 schrieb "Jan Holthuis" <notifications@github.com>:

> This one won't add any values though. I'd propose:
>
>     cfgPath=GetPath("/emu.cfg");
>     int error_code = 0;
>     FILE* cfgfile = fopen(cfgPath.c_str(),"r");
>
>     if(!cfgfile) {
>             int error_code = errno;
>             printf("Warning: Unable to open the config file '%s' for reading (%s)\n", cfgPath.c_str(), strerror(error_code));
>     } else {
>         cfgdb.parse(cfgfile);
>         fclose(cfgfile);
>     }
>
>     if (error_code == -ENOENT)
>     {
>         // The config file does not exist, let's create it
>         savecfgf();
>     }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/reicast/reicast-emulator/commit/aa7aa18cabcbf19d0dd771f86931cf5b0ed405a1#commitcomment-12855850>
> .
>


TeamCity OsmSharp :: GitHub - OsmSharp [Build 1053](http://build.osmsharp.com:8080/viewLog.html?buildId=5177&buildTypeId=bt16) is now running


"dell'indicatore" - not right
"dell\'indicatore" - right


Note that Tasks can be top-level objects as well. Considering also that I don't think it makes much sense to put artificial restrictions on the objects we allow as top-level, and given that Contest is the only one that requires special treatment, you could use:
```
obj = self.objs[id_]
session.add(obj)
session.flush()
if isinstance(obj, Contest):
    contest_id += [contest.id]
    contest_files |= ...
```
Could you also take the chance to fix a bug I spotted in DumpEporter.py:125, using "is" to compare to None in a filter? (Python evaluates that to False before SQLAlchemy has the chance to insert its magic; alternatives are using "==" or ".is_(...)")


Can you fix the other two too?


Savvy.


Can you please make the ```ListGroupItem``` class implement the ```com.google.gwt.user.client.ui.HasHTML``` and ```com.google.gwt.user.client.ui.HasText``` interfaces ?

```
...
import com.google.gwt.user.client.ui.HasHTML;
import com.google.gwt.user.client.ui.HasText;

public class ListGroupItem extends ComplexWidget implements HasType<ListGroupItemType>, HasText, HasHTML {
...
```


Hmm... agree with the idea but the language needs to be clearer.


what is it supposed to do ?


thought: I'll try to include an iphone 4 layout today.  If you can't get the iphone 5 one to work you can cp it to the right spot with SSH out there, or load it up at home.  Once both phones have the layout served up they can store them locally (I've only loaded mine up once).


why do you reuse repoURL name ?


NVM disregard


Yes oversight


Known Issues
Lazy Loading of Images


We probably should have a `struct sol_http_request` passed here, that would contain `method`, `params` (which are the request params). This keeps low the cost of adding new information to the request, e.g. when we actually want to pass the data that was part of the request we may add a couple of fields to `sol_http_request` instead of changing this callback signature.


(unsigned)-1 == std::numeric_limits<unsigned>::max()


I don't have the rationals for this but it looks like a bad idea


This looks great. pacman.pot for transifex also updated?


I'm not seeing the test in question and it really should be there. The current implementation lets me pass a relative path as the container name which would cause reads outside of /var/lib/lxd and if pointing to a path matching the logname, then actually return it.


### Results:

#### < 78
 - LuaTeX beta-0.76.0 (TeXLive 2013)*: old test **fail**; new test *pass*
 - LuaTeX beta-0.79.1 (TeXLive 2014): old test *pass*; new test **fail**
 - LuaTeX beta-0.80.0 (TeXLive 2015): old test *pass*; new test **fail**

#### < 79
 - LuaTeX beta-0.76.0 (TeXLive 2013): old test **fail**; new test *pass*
 - LuaTeX beta-0.79.1 (TeXLive 2014): old test *pass*; new test **fail**
 - LuaTeX beta-0.80.0 (TeXLive 2015): old test *pass*; new test **fail**

#### < 80
 - LuaTeX beta-0.76.0 (TeXLive 2013)*: old test **fail**; new test *pass*
 - LuaTeX beta-0.79.1 (TeXLive 2014): old test **fail**; new test *pass*
 - LuaTeX beta-0.80.0 (TeXLive 2015): old test *pass*; new test **fail**

* It should be noted that this version has problems with loading the font for the LuaLaTeX tests.  The PlainTeX tests appear to work fine, so I'm including the results here.

### Conclusions
No version of the test can pass on all three of the most recent versions of LuaTeX.  Crossing the pretolerance setting boundry (where ever it is set) causes a flip in which version passes.  The best we can hope for, therefore, is something which passes on the two of the three.  Personally, I think it's better if it passes both 0.79.1 and 0.80.0 (the two most recent).

To that end, it would seem the old test is the better test, assuming the pretolerance setting boundry is at <79 or <78.

Of course, the most complicated option would be to have the test run conditionally, but I'm not sure there's a gain there.


Why ? So much fun! Wow! Amazing commit !


This link should be usefull with cache troubleshoot
http://symfony.com/doc/current/cookbook/deployment/tools.html


Ah, I conveniently overlooked those. Just pushed that as well, thanks.


Lets say I pass "../../../../../../../etc/lxc" as the name and "lxc.conf" as the file, I'll be returned the system wide LXC configuration file.


Should not be commited, it should be read from an ENV variable or a local file


Same comment as above, except this time I can actually remove the file.


this fixes the json output so that it validates correctly


I don't know if that's possible on windows, but on linux, you can do this:

```
$ echo "foo" > foo.txt
$ chmod -r foo.txt
$ ls -l
total 4
--w------- 1 jan jan 4 Aug 24 17:34 foo.txt

$ cat foo.txt
cat: foo.txt: Permission denied

$ echo "bar" > foo.txt
$ chmod +r foo.txt
$ cat foo.txt
bar
```

So if the file is writeable but not readable, we would truncate the user's config file, which is undesired IMHO.


TeamCity OsmSharp :: GitHub - OsmSharp [Build 4.4.0.1053](http://build.osmsharp.com:8080/viewLog.html?buildId=5177&buildTypeId=bt16) outcome was **SUCCESS**
Summary: Tests passed: 548 Build time: 0:0:0


You can't do that because of validLogFileName().


The new /logs API should also be documented in specs/rest-api.md


@kelemen :
> I'm excluding it because the Groovy plugin uses the groovy-all jar defined in the library manager (or at least, this is what it says). So, I do not want to conflict with the Groovy plugin.


Its a general issue of lambda captures and especially if you capture by reference.
If you capture a temporary iterator by reference which is destructed after leaving the scope
it will cause an invalid reference.


Ah, yep, seems I wrote the comment but forgot the code.


Why do these #ifdefs need to be moved around?


I've forget
use Acme\Snappy\SnappyServiceProvider;


I forgot to generate the js before pushing the coffee. Do we really need to commit/push the generated js?


IIRC this was quite a win.  We should work to re-enable some parallelism here ASAP.


Why do we need to change || to &&?


Hello @bbrodt, would it be possible to do proper cherry-picks, so that we can preserve the individual commits and their commit messages? I think it would make it easier for people to understand what are the changes about. The message "Merged 6.3.x changes" is too general one needs to actually closely look at the code to see what changed. Thanks!


On linux directories are application/x-not-regular-file.


`{{ page.url }}'?


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1277 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Created a repository to clone the Nordstrom repo to my github account.


Yes I can. lxc.conf is a valid name per validLogFileName, the path isn't checked so it'll happily let me read /etc/lxc/lxc.conf from the host.


Yes, Transifex is configured to auto update pamac.pot from this Github repo so wait until tomorrow to be sure and the new string to translate should be available in Transifex.
Then, update new translations from Transifex is the best way to go I think.
I will follow those steps to add French translations.


I think we should remove these, they have no use for us at the moment.


Typo in the block title fixed.


Note for collaborators:
From now until we fix all checkstyle errors, the build will always fail.


I guess my question is the same as Vinicius (but I don't see how the `sol_fd` implementation could save us from trouble here), where's the `sol_fd_del` for this `listen_fd`?


Should we just remove the layouts we don't use?


My opinion, then, is to gate the pretolerance setting at <79 (or <78) and restore the older test expectation.


The xunit command line allows specifiying a config file after the assembly name, so we *could* just use a single/small number of config files instead of duplicating it per assembly.

However, having done the work already I'm not sure if it's worth reverting to that model.


You use specific quantities in all of the other scenarios, so use them here. This will expose a few other scenarios for you, such as whether there are duplicate items (and how to handle that)


Thanks :)


Common sense of passing temporaries by reference applies...