1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I201 Missing newline before sections or imports.
23:1: I100 Imports statements are in the wrong order. from invenio_upgrader.api should be before from sqlalchemy.dialects
23:1: I201 Missing newline before sections or imports.
28: D103 Missing docstring in public function


23:1: I201 Missing newline before sections or imports.


53: D203 1 blank line required before class docstring (found 0)


nit: can be written
```
self.version = version
if not self.version:
    self.version = (addon.current_beta_version if is_beta
                    else addon.current_version)
```


Hoda, can you resolve the conflicts?  I would like to merge and then improve a bit upon it by in stread of an simple time leap, do an incremental leap to a time using ods_time_leap_over or ods_time_leap_to.
But lets merge first.


after several update the option appared in the Settings tab, i have update to 0.94 with plugin enabled maybe this corrupted the update


typo Recor[e]ds


remove this destructor, an create a function gather that take Rep like argument argument something like that:
void gather(Rep const& r){
     gather(r,v.rep())
}


:+1 less parameters are always good


it is not in yast2 but in ruby-bindings


This line is not related to the history adapter, we need to remember to move it somewhere else


so you create a store function in the class, partial specialize on the bool:
 - true you call your gather
 - false you call the old one


stray console.log statement from debugging


This comes from `gradle.properties` now, but if we ever start adding `description`s to subprojects in their `build.gradle`, it'll automatically pick them up.


I'd actually like to see this commit reverted... :) Do you still need the "1+" for unmuting to work? For me, just "toggle" suffices and works perfectly.


91977808_LBNL_NewVRFModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1799 of 1803 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


Does this function have a unit test?


Suggestion: Remove "Required fields are in red and marked with an ✻" and remove "comment" field.
Rationale: (1) Marking mandatory fields is not the essence of this example, and unnecessarily draws attention to it; (2) It is enough to have one error message to convey your point, so no need to have both "email" and "comment" fields being highlighted - it poses more cognitive load for little benefit; (3) the comment field is large in size so the red highlighting draws too much attention and distraction visually.


should fix the `path` to be as it was set in earlier versions that passed along the `load.metadata.pluginArgument`


does this function also automatically create a new place if no place for `url` exist yet?


I can't find a issue tracker on your repo so I will just post it here.

It seems that the `i3-wm` and `mutt` theme in the README.md does not exists.


why not always update `place.title` to `title`? Maybe the title of the place changed since the last visit.


Is this necessary?


Could you use EnvironmentVariable(s) instead of Variable(s)? We should use only one term (I don't mind if we even stop using "environment variable" eventually).


Can you open an issue? Thanks.


Might be the problem, that I accidentally added my custom.cfg to the branch, see last commit (https://github.com/OneGov/dev/commit/1c3f3fdd006ebd5f43e489d38a829bd4838d3491)


Would be nice to have a unit test for this as well, to confirm that visits get sorted in the right way (is it newest first?)


:+1: even if the problem comes from Odoo we need this fix...


This is a step forward but it doesn't help if you have a custom job status or if the job is interactive (because the question is not serialized). We'll have to address this later on.


Why `.concat()`? Is that a way to clone the Array?


Microsoft Azure Redis doesn't provide all the info data that the module is using. Because of that some of the $info array keys are undefined. A few isset() fixes the issue.


Nice catch! Could you sign this commit? And maybe extend the commit message to something like:

```
inno: fixed typo in description for setting the default console app
```


ใครวะ


See https://github.com/OneGov/onegov.town/commit/422a24c66f65ba9e73bc52a5458fe820685774bf


Dear jfarrell.
    I used to write a java server code.
-------------------
public void run() {
		try {
			TMultiplexedProcessor processor = new TMultiplexedProcessor();
			TServerTransport t = new TServerSocket(SERVER_PORT);
			TServer server = new TThreadPoolServer(new
			processor.registerProcessor(
				ShoppingCartService.class.getSimpleName(),
				new ShoppingCartService.Processor<ShoppingCartService.Iface>(
					(ShoppingCartService.Iface) new BizMonitor(this).wrapper(
						new ShoppingCartServiceImpl(ShoppingCartService.class.getSimpleName(),"1.0")
					)
				)
			);
			server.serve();
		}

		..................
}
-------------------
Then I use nodejs thrift to connection my server.  But it dosen't work,The error infomation:
Service name not found in message name: verifyFoilCardNum.  Did you forget to use a TMultiplexProtocol in your client?

It seems to tell me I should use TMultiplexProtocol to conneciton.

But Api of nodejs thrift about TMultiplexProtocol  show nothing to me. I don't know how to use TMultiplexProtocol to connection my server.
Can you show me a demo? Very grateful!
thankjava@foxmail.com.


Until what ever is causing users not being able to connect to the server due to duplicate names in ChestShops is fixed, I'm going to have to downgrade back to the official latest release, v3.8.12. Sorry! :(


TeamCity pull requests :: netty [Build 79](https://garage.netty.io/teamcity/viewLog.html?buildId=554&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4738, ignored: 21 Build time: 00:28:47


TeamCity pull requests :: netty [Build 80](https://garage.netty.io/teamcity/viewLog.html?buildId=555&buildTypeId=pulls_netty&guest=1) is now running


哎，我以为会有rc2呢，发布了，赶紧看看代码。嘿嘿


why not simple run `RETURN 42`?


Nice @tsg. Thank you!


Our team have got this issue, we tried with 2.4.4 and it did solve the problem. Is there a way we can produce this issue in 2.2.3? Just curious to reproduce it somehow. Cheers!


Further information:
https://make.wordpress.org/core/2015/07/31/headings-in-admin-screens-change-in-wordpress-4-3/


OMG, I forgot delete this line, I will fix it right now


Yes i already know that...
But i'm busy all the week so i won't be able to do something


Ok yes this looks better.


There is already the [jobRunner.js](https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-job/xwiki-platform-job-webjar/src/main/resources/jobRunner.js) (used by the [tree widget](https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-webjar/src/main/resources/tree.js#L132)) that can be reused / extended.


I have left this here as i think "allow" is a flag to the parse method rather than removduplicates - ie parse(duplicatestyle="allow") should not call removeduplicates at all - and removeduplicates(duplicatestyle="allow") would do nothing and is kinda meaningless


It might be better to put { , } here because GL_INS is a macro. It used to no compile.


This could be part of EnvironmentVariable not Deployment, e.g. environmentVariable.isResolved (won't work for option).
More important, env variable in this scope means exclusively variables defined in cluster scope and names need to be in format cluster.name (or even cluster.group.name) and using only strings that is not clear (check out ValueReference/TraitReference).
I find definitions a bit missliding/confusing.


Odd. Are you sure about the $DISTRO_VERSION_COMPAT value being 'precise'?
This is Fatdog64's /etc/DISTRO_SPECS, the comments say that DISTRO_VERSION_COMPAT is a three-digit number...
```
#DISTRO_FILE_PREFIX: prefix for Puppy files... exs: upup-500.sfs, upupsave.2fs
#DISTRO_VERSION: this is the version number of Puppy that you are building. must be 3 digits.
#       (technical note: see below it is defined without quotes, this is required by scripts)
#package list and urls are in file DISTRO-PKGS-SPECS-${DISTRO_BINARY_COMPAT}.

DISTRO_VERSION=700
DISTRO_BINARY_COMPAT="fatdog64"

DISTRO_NAME="Fatdog64"
DISTRO_FILE_PREFIX="fd64"
DISTRO_COMPAT_VERSION=$DISTRO_VERSION
```


:+1: on `Array.from`.


ОК.


Brilliant!
Can you open pull request?


:+1: on checking `childElementCount` here.


Is it better just isDeployed? Fact that breed may be a dependency to another breed it not used here and it's irrelevant.


Ну, CASCADE и SET NULL — они полезные. Но да, если делается что-то вроде CMS, то лучше средствами сервера это сделать. Получим лучшую переносимость кода на разные базы. Вот только делаем мы не универсальную CMS.


I think the way you merge the two sorted arrays `place.visits` and `visits`, by first concatenating them, then splicing out the duplicates in a double for-loop, and then sorting again, is probably not the most efficient algorithm. How about this alternative:
````js
for  (var i=0; i<visits.length; i++) {
  if (place.visits.indexOf(visits[i]) === -1) {
    place.visits.push(visits[i]);
  }
}
place.visits.sort(function(a, b) {
  return b - a;
});
````
Seems simpler and possibly faster?


Sorry but I don't understand those comments.


Didn't realise eclipse had made things worse. Fixed and pushed.


Okay. Please give me some time.


You need to create a requirements.txt file and add these there. docs_requirements aren't installed when you do a setup.py


It has lower cyclomatic complexity than array spread :)


ODL VTN (release/lithium)  source


Done here c5dfe8f


We can have also only one method isDeployed(breeds: Breed*)


Indeed: see commit de2253b


I feel we need at least one unit test for the history adapter. Maybe just add it under https://github.com/weilonge/gaia/tree/master/apps/settings/test/unit for now, and then we can move it along with the code once we have the Synchronizer app to land this in.


Thanks, I just added an issue tracker.

i3 styles are here:

* https://github.com/xHN35RQ/base16-builder/tree/master/templates/i3
* https://github.com/xHN35RQ/base16-builder/tree/master/templates/i3-style
* https://github.com/xHN35RQ/base16-builder/tree/master/templates/i3status

And mutt is here:

* https://github.com/xHN35RQ/base16-builder/tree/master/templates/mutt

I have not built them into their own repos (such as base16-mutt or base16-i3) but they are ready to build by cloning down base16-builder and running `./base16` and look in ouput for the generated templates. (ruby required)


Not nedded anymore because we are not building.


ok


98812296-SkyTemperatureShiftsSchedules-4866 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


why???????????????????


Model->find("list") có thể thay thế toàn bộ nội dung của hàm này?


Yes, If you would like to convert for example JSON->AVRO then we would need here access to JsonSchemaRepo. But right now we don't need this (and I don't know if we will), so I would like to not prepare solution which might not be used.


Xoá các đoạn comment không dùng đến do template sinh ra


Comment is likely wrong. I think b, a is 8 -15.

It might worth to add a quick comment for upl32 and upl16. Otherwise it is hard to read.


TeamCity pull requests :: netty [Build 78](https://garage.netty.io/teamcity/viewLog.html?buildId=553&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4745, ignored: 21 Build time: 00:52:08


TeamCity pull requests :: netty [Build 81](https://garage.netty.io/teamcity/viewLog.html?buildId=556&buildTypeId=pulls_netty&guest=1) is now running


Loại ra cho rồi, Phú ghẻ


How would the script check for login status and perform the login when the internet is off? I think it was correct before.


Hi Jon. Thanks for this commit. Helpful.
As small hint, we use ', if is possible and often faster. Yes, I know, it is not always here in the source. As hint a link to our codex - https://github.com/inpsyde/Codex


c'est juste que du coup la coloration syntaxique était pas bonne


This adapter 'syncs down' visits to places that exist on the Sync server but not in the places DataStore. But that's only step 1, we also need to 'sync up', so iterate over the places their visits and check if they all exist in kintoCollection. If there is a place that's missing from the kintoCollection, use `kintoCollection.add()`. If there is a place which is missing some visits in the kintoCollection, add the missing visits using http://kintojs.readthedocs.org/en/latest/api/#updating-a-record.

Since Kinto.js does not have auto-batching, and [batch operations are not supported yet](https://github.com/Kinto/kinto.js/issues/16), this is going to very slow when there are hundreds of records to update. It's important for performance to do all these `add` and `update` operations in a batch operation, so that they go into one IndexedDB transaction instead of hundreds of slow IndexedDB transactions. But for now, let's just not batch them, and add a code comment, referring to https://github.com/Kinto/kinto.js/issues/16, which mentions this important performance issue (we could do some measurements to confirm exactly how slow it is).


shall we remove line 21 or line 25? I would like to remove them both.


In fact I don't care so much about the resource values of the kubelet. They are not used anywhere other than in e2e tests. Moreover, the e2e tests (https://github.com/mesosphere/kubernetes-mesos/issues/437) expect that they are the only one getting their piece of the capacity, and that the resource consumption on a node is static, i.e. no other framework messes with resources.

In other words: the e2e test mentioned is incompatible with any dynamic environment where kubernetes is only one of the resource consumers.


Add Photo Stuff


Here is Shawn’s homework1


Rebase slip-up. An old branch had this code.


Không hard-code link thế này. Dùng array('controller' =>..., 'action' => ...)


back


1712-AvailabilityManagers (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2188 of 2230 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.12%25-yellow.svg)


jhjhjhjhj


khung


Please maintain authorship.
http://review.blissroms.com/#/c/679/


The "fixed" logic obviously has problems. I'm wondering if we should perhaps revert this change *and* the keystore change until we understand exactly how we should be doing this search.


here is shawn‘s homework1


Adding a comment:

% Check if data points intersect with the borders of the plot


here is Shawn's homework1
![2197f7669cf9f610](https://cloud.githubusercontent.com/assets/13847840/9378474/b61ac894-46ef-11e5-97af-55a57731f093.jpg)


Java能用Arrys.sort 真是比c好多了


Not trying to be a dick here but that change is easily doable with a least
bit of knowledge in Android Makefiles.

On Thu, Aug 20, 2015 at 4:57 PM, Devesh Negi <notifications@github.com>
wrote:

> Please maintain authorship.
> http://review.blissroms.com/#/c/679/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android_system_core/commit/91cecb7d12a89575d87d6b1e6858900e99f73020#commitcomment-12801677>
> .
>


saw approval from gordonguthrie
at https://github.com/basho/riak_ql/commit/53582b5d8d09932a881d921b3e6b76a82e03d5aa


merging basho/riak_ql/gg/timeseries = 53582b5d into borshop-integration-10-gg/timeseries


basho/riak_ql/gg/timeseries = 53582b5d merged ok, testing candidate = dafb20ae


或后面的 i>0 是多余的。因为这个判断如果前面的i==0不成立，肯定是i>0必然成立


TeamCity pull requests :: netty [Build 80](https://garage.netty.io/teamcity/viewLog.html?buildId=555&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4728, ignored: 20 Build time: 00:28:15


i'm agree that a single define is hard, one possible but dangerous solution is recording the relative address in define, then access the member by *(int*)(this + rel_pos).

but i'm still looking forward to simply the current interface.


Hi, do you mind letting us know why you decided to remove this dependency?
I think this dependency was causing issues for us because we where encrypting using Sun security provider, but other project that was using iOS notifications was trying to decrypt using BouncyCastleProvider and we were getting this exception intermittently:
javax.crypto.BadPaddingException: pad block corrupted
	at org.bouncycastle.jce.provider.JCEBlockCipher.engineDoFinal(Unknown Source)
	at javax.crypto.Cipher.doFinal(Cipher.java:2131)


commenyed


Looking at this now I doubt that we need to use classes here. We can use just functions `getArrayDiff`, etc. So we will not need this kind of assignments. What do you think?


develop (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2301 of 2333 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.63%25-yellow.svg)


是不是这样写比较好，
```java
for (int i = 0; i < nums.length - 2; i++)  {
  if (i > 0 && nums[i] == nums[i-1]) {
    continue;
  }

  // do something
}
```


This function seems to be duplicated in all etcd_tests.
How about moving it to etcdtest?


Just looked in the hammerhead code and figured out that we used simple var notation for this kind of objects. My fault. BTW, it should be `calculators` not `calculations`:

```js
var markerPositionCalculators = {
...
};
```


Yes, good idea!


http://i.imgur.com/4oxEwEO.png
@arter97


I think it should be just `err` instead of `originalErr` since we don't have `modifiedErr` or smthg like this.


\r- because of some minor style nits, but in general looks really good. Thank you.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 585](http://build.prxm.it:8811/viewLog.html?buildId=3823&buildTypeId=Jarvis_DocumentStore_CI) is now running


the last line is different in all files (NewREST).
But I agree we can extract the first few lines to a separate function (returning etcdStorage and fakeClient). Will do it.


Initial commit


lol.
I'll force-update the Git repo. Is that fine for everyone?


@temasek


No need because these additions won't produce an error when compiling with Qt < 5.5. And they should not increase the compilation time either since the same header cannot be included multiple times.
I generally try to avoid having too many preprocessor instructions since they tend to make the code more difficult to read.


@tomasbedrich, prý sis tu knížku nechal na Věnečku. Má ji u sebe Verča z PyLadies, domluvíte se nějak? Dáš mi na sebe třeba e-mail?


Ooh, interesting - thanks for that. Will probably leave this where it is, but it's good to know the reason :)


Think this works better because we could also set a default indicator if we wanted.


Oops, yeah, wrong way round. I'll fix the issues then get back to you.


Boxed Morvy is destroyer of worlds.


@nfeske: please try this commit


Just FYI, you can just do `Services.ContentTypeService.GetAllPropertyTypeAliases();` since `Services` is exposed as a property on these base class (on almost all base classes in umbraco)


thanks :+1:


Changed in 00c9ec0cd7f0db27a9a82c2e5b0293317b58b403.


Ah yes, that's why one should always pass drop=FALSE when reducing the size of a matrix instead of just using as.matrix. Should hopefully be fixed in maddin79/darch@a86e96c. Thanks!


But you're not using the checklist-model as a function in that example. Btw, are you fine with moving our conversation to the issue list? Just submit a new issue with the plunkr example.


Doesn't it need to link against fontconfig now for that to work?


Ah, merci. Même si tous les noms restent faux du coup :p

Y a des listes quelque part ? Et faut vraiment que je trouve un système pour récupérer les photos aussi.


这儿跟遍历i的逻辑是一样的，
干脆，用for
```java
for (j=i+1; j<nums.length-1; j++) {
  if (j > i+1 && nums[j] == nums[j-1]) {
    continue
  }

  // then find index k from (j+1 to nums.length - 1) to fit nums[i]+nums[j]+nums[k] == 0
  // =  find number (0-nums[i]-nums[j]]) in nums[j+1..nums.length-1] binary-search will be faster.
}
```


Is blisspop now trying to be the next police of commits?


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/56


I could not test them yet as I did not installed ruby.


In the commit message - failes -> fails.


yes, both! :)
and also the stray space on line 22, I guess.


Flame war for later.
I have to go out real soon.
Can I remove this commit?


Nope
But that asked me yesterday night,  thanks for the commit.
But then he should maintain authorship before pushing or give credits.


I tested this changes and it looks that this line have to be removed because when DoXferDone(hbm_acq); in line 980 will be called hbm_acq will be null. Should suffice GlobalFree(hbm_acq); in line 981;


sur le drive de l'AEDI, tu dois avoir la liste de tous les noms :)
Après pour le moment, on peut juste retirer les photos.


We are trying to be more be careful now with cp and authorship to eradicate any conflict


It should work on ElasticSearch 1.4.4. I will do some tests the next ES versions.

De : Barthe van Doorn [mailto:notifications@github.com]
Envoyé : dimanche 2 août 2015 17:39
À : djanssen/elasticsearch-view-plugin
Cc : Janssen, David (LNG-FNI)
Objet : Re: [elasticsearch-view-plugin] Added multi shards/nodes support (cb5d739)

does this work with elasticsearch 1.7 ? I installed but am getting error when I point to a view http://localhost:9200/_view/catalog/product/1 ... error is: java.lang.IncompatibleClassChangeError: Found class org.elasticsearch.indices.IndicesService, but interface was expected

—
Reply to this email directly or view it on GitHub<https://github.com/djanssen/elasticsearch-view-plugin/commit/cb5d739f471557ac5b8e73544fbe69b715e4b6ca#commitcomment-12483552>.


This should be:
```matlab
out(id_detA) = 0 < lambda1 & lambda1 < 1 & 0 < lambda2 & lambda2 < 1;
```

Our we could even write it out in two lines to deduplicate the logic a bit:
```matlab
isInRange01 = @(val) (0 < val & val < 1);
out(id_detA) = isInRange01(lambda1) & isInRange01(lambda2);
```


Ifdef  is not code theft


Why do you need this json import here?


98812296-SkyTemperatureShiftsSchedules-4866 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


careful there :)


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 585](http://build.prxm.it:8811/viewLog.html?buildId=3823&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 4 (3 new), passed: 289; compilation error: src\Jarvis.DocumentStore.Tests\Jarvis.DocumentStore.Tests.csproj (new) Build time: 00:13:23
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_html_to_pdf("v1").verify_html_plain_ToPdf_old: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_html_to_pdf("v2").verify_html_plain_ToPdf_old: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_multiple_password("v1").verify_tika_job_with_two_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.DocumentControllerIntegrationTests("v2").verify_de_duplication__not_delete_original_blob_before_15_days: <no details avaliable>

```


this is crap


oops. Typo (will update in the next commit)


True, i just replaced the all by &. However, it seems any/all is broadly mixed in the code so i am not sure, what is better. In any case i would prefer all([lambda1, lambda2] > 0.0, 2) & all([lambda1, lambda2] < 1.0, 2); over a separate function


Thanks! Buildout is working now


What about `SD['conf'] = {}`? :smile:


True, not needed anymore.


What are supposed to be the `'b` and `'b` here? Maybe worth making them more explicit?


Assignment Branch Condition size for set_users_in_gon is too high. [32/15]<br>Method has too many lines. [19/10]


Assignment Branch Condition size for find_missing_users is too high. [20.02/15]


Align the elements of an array literal if they span more than one line.


Align the operands of an expression in an assignment spanning multiple lines.


Use empty lines between defs.


Haha If @adamfortuna says I did it, than yup I probably did. Sorry about that :monkey_face:


I now see this fix is not flexible.
I'm gonna have to revert this anyways.
@temasek please check DM.


PSR style whitespace is 4 spaces ;)


борис, ты не прав!


:smile:


Fixed :)


@Shauren I just briefly watched ... ok ok :D


Yes, franco, engstk and fllar2 also reverted this commit, because they got many reports about false battery stats.


@arter97

Do what u think is necessary.


T'façon faut surtout trouver un vrai design. Je réfléchis. (au bureau)


Here i am unsure. To stay consitent i would have to make it
n = size(data, 1);
out = false(n.1, 1);

However, then I would have to replace n -> (n-1) in all the comments below.
Opinions?


De ce e nevoie de id pe button? Si de ce este un tag "i" cu atributul "value"?


98812296-SkyTemperatureShiftsSchedules-4866 (rglazer2) - i386-Windows-7-VisualStudio-12: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Either one is fine, it's just that one of the bounds was wrong.


J'espère que ça casse pas tout je l'ai fait direct depuis github


This commit fixes issue https://github.com/Flipboard/FLAnimatedImage/issues/84

Background in the Apple doc here: https://developer.apple.com/library/prerelease/ios/documentation/General/Conceptual/ExtensibilityPG/ExtensionScenarios.html


OK, great. But @sirex please be aware, that your *Makefile* has failed on other two modern operating systems. I think it would be best if next time you add notes about your *dev-env*, this would let me and perhaps others much easier disqualify the bugs, which are really not bugs in that one particular system, like in this case *Ubuntu 14.04*.


Yes, this worked for me. Thanks!


Aici mesajul commit-ului nu zice nimic de adaugarea suportului pentru formatul GIF. Ar fi trebuit sa fie 2 commit-uri separate aici, pentru ca s-au schimbat 2 lucruri diferite.


简直太给脸了 :dancers:


What will this return, nothing??


Yes, it is in the pdp data.


True - I've made the necessary amendments and in fact it works. Thanks!


facepalm,
that is the kind of bug, I would spend a whole day searching for. Thanks brain for autocorrect ;)


I know, most (php code) in the file is, but I haven't touched all the code... some is copied in without reformatting. Maybe we have to skim some of those again later. full PSR compliance will probably very hard to reach on the old code...


Asta ar fi meritat un commit separat, deoarece nu are nimic de a face cu mesajul actualului commit.


this needs to be "/raintank/raintank-probe".  As discussed in the slack channel, this is a common issue with working with  forks of Go projects.

I suggest your remove $GOPATH/src/github.com/raintank/raintank-probe  then
```
go get github.com/laher/gopin
gopin get -u -repo github.com/AriaEdo/raintank-probe github.com/raintank/raintank-probe
``

this will then checkout our fork of the code into  $GOPATH/src/github.com/raintank/raintank-probe and it will then compile properly


TeamCity pull requests :: netty [Build 81](https://garage.netty.io/teamcity/viewLog.html?buildId=556&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4729, ignored: 20 Build time: 00:42:33


`UNVERIFIED` should be [UNVERIFIED_ACCOUNT](https://github.com/mozilla/fxa-content-server/blob/0bcf3010ba6a205356e3a6a2dc71750f7d602959/app/scripts/lib/auth-errors.js#L53).


please remove empty line


Does this fix work for desktop browsers?


Aici commit-ul nu spune nimic despre ce anume ai refactorizat. Din ce vad, ai redenumit niste nume de clase. Acest "tip de refactorizare" poarta numele de "rename [ceva]", unde [ceva] poate fi: class, method, parameter, variable, etc. La tine [ceva] poate fi "css classes".


Happens to all of us :grinning: That's why I like having a function in place: it makes those things stand out a bit more. I think in the long run, we might write it as an actual function, since those conditionals are used at other places as well.


T'inquiète, j'ai un super workflow sécurisé. (je ne sais pas si ça veut dire quelque chose)


instead of `call_user_func` use `return $callable();` directly


Excellent work. But, for security concern please use getaddrinfo instead of gethostnyname. I will merge your patch after.

Regs,
Alexandre


Copy/paste error?


Ah, and I forgot, we also need a function `HistoryAdapter#handleConflict`, so we can do something like this:
````js
var conflict = {
  type: "incoming", // can also be "outgoing"
  local: {
    _status: "created",
    id: "233a018a-fd2b-4d39-ba85-8bf3e13d73ec",
    title: "local title",
  },
  remote: {
    id: "233a018a-fd2b-4d39-ba85-8bf3e13d73ec",
    title: "remote title",
  }
};
myHistoryAdapter.handleConflict(conflict);
````
The only type of conflict we need to worry about is if one URL was visited both on desktop and on the phone. So you can always just:
* merge the `visits` arrays
* use the `title` of the one which was visited lasted (title should never be different unless the visits are also different)

So something like:
````js
function handleConflict(conflict) {
  var merged = conflict.local;

  // Merge visits from remote into visits from local:
  for  (var i=0; i<conflict.remote.visits.length; i++) {
    if (merged.visits.indexOf(visits[i]) === -1) {
      merged.visits.push(visits[i]);
    }
  }
  merged.visits.sort(function(a, b) {
    return b - a;
  });

  // Use title from remote if more recent:
  if (conflict.remote.visited > conflict.local.visited) {
    merged.title = conflict.remote.title;
  }
}
````


develop (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.84%25-red.svg)


这个跟3sum差不多，还有一个可以优化的点是，把nums处理一下，让每个数字相同的可能性不大于3，比如给个输入是 1000 个 5， 其实可以处理成 3 个 5， 结果是一致的。


ping @jlipps, we need to lookout for this pattern, async methods cannot be use as interface with package like express, we need to make sure promise are resolved cleanly, otherwise the error get lost.


Instead of NoCache adapter it would be better to implement ArrayCache, then all fetched values will be stored inside memory and will be consistent for every calls in single process


@ropilz hey man tnx for the great effort for the community. have you uploaded this last version to adobe plugin repository? I mean can we just state the previous plugin name and build it to get the latest version ?


example of how to use it can be found in lib/utils.c:get_local_name()


```crosswalk``` should be ```xwalk```?


91977808_LBNL_NewVRFModel (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (1799 of 1803 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


iminor() returns 20 bits - why masking to 4 LSBs here?


>  My question is, can type (1) and (2) ever appear nested inside of (3)?

No, I don't think so.

>  If not, then the code to handle (1) and (2) should be pulled out of the recursive _compileQuery() method and just be run on the type level args.query object.

Is it to avoid useless passes on the two first if ? Then you think I should put it directly inside the constructor ?
Maybe another way could be to call _testTypeOfQuery in 'and' and 'or' instead of _compileQuery ?


```xwalkview``` --> ```XWalkView```.


Why did you returned them back?)


Wouldn´t it be nice, if the timeout is also written to the cookie itself? But I don´t know how to do it in a nice way, because the session is started even before the kirby class is loaded, so all the options are not available at that time. Additionally the class, which does the session handling has no access to the kirby object, which is ok, because the session class is part of the toolkit.

I don´t know if there is any special sense, that the session is started  that way, but it would be more complex to solve this. Probably when Bastian works on issue #249, which requires some more changes to the session handling, I think.
I was trying to get issue #291 right, but failed because of the reasons mentioned above.


CPU state in time shows 268 instead of 223 even though krait table for CPU voltage shows 223.


here is something unusual. I have been working on it.


> the From: and Reply-To: addresses are already available in the commit and displayed in the email (except in corner-cases where From: is the pusher and the pusher has an email different from the committer). We could add an option to remove emails from the messages

Ok, so that's not what I mean, and removing all email addresses from messages is not what I propose. Let's separate email content from email meta-information. Email content indeed contains email addresses, etc. - it is generated by git, so everybody who knows git know that commit address will be visible to anyone. But when email has "From: " header set to physical person, it should be that given physical person wrote that email. When it's not the case, *one way* to look at the situation is that it's "email forging" and "impersonation". Similarly with "Reply-To" - it means that person knowlingly may want to receive to reply to a message (e.g. by willingly subscribing to some mailing list which may set that header). With git-multimail, it's different - someone can grab it, install to millions repositories, and with its default settings, it will put persons' email into From: and Reply-To: without them endorsing or even knowing that.

> To me, the typical use-case of git-multimail is code review, and what I expect as default behavior is an easy way to tell the author "hey, this patch hunk is wrong, you should write this instead". Setting the From and/or Reply-To is an easy way to achieve this.

Yes, that's how it usually happens - if your tool becomes popular, you may find that people start to use it in ways you didn't expect or think of ;-). Again, I don't think that you should change anything in the default config right away (it's fair to say to folks like me: dude, do you homework on configuring git-multimail). But: a) if you or someone else will want to make email address handling even more "liberal", please do keep the perspective above in mind; b) if you receive dozen complaints about similar matters, maybe it's time to think about changing defaults ;-).

Thanks for the discussion!


it shows me an error:
 throw e
              ^
Error: The specified procedure could not be found.
d:\demo\node_modules\contextify\build\Release\contextify.node


Thanks!


I feel honored!


Would you mind reporting that issue upstream?

Curiously enough, I don't see that problem at all (running on `master`); `htop` works just fine.


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (755 of 755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.31%25-green.svg)


No y u do this


Could you explain what is the problem with protocol-less links?
Maybe I should quit using them in my projects.


Hi, this commit is weird.
When I compile the library, I have two errors :
mFocusedPoint = series.get(i); => "series" does not exist and if replaced by "mSeries", incompatible type
focusedPointOrder = i => "focusedPointOrder" does not exist and there is nothing similar apparenlty


yes, thanks.


1: M111 unrecognized component name: unapi


Sai rồi hehe


`app_root` cannot be blank because we identify it here https://github.com/padrino/padrino-framework/blob/master/padrino-core/lib/padrino-core/mounter.rb#L41


`app_obj` is already here, we don't need to request it again from the app_data


Thanks. It was actually reviewed by Gavin, a Tor developer, and I got some comments via private email too, but more is always welcome.

The Core/XT code base is a bit hard to unit test because so much state is in global variables and there's no easy way to reset things. But yeah testing the init path would be a good improvement too.


I think this should be autoload and not autoload-dev


Nice patch.
Could you alter the fuction name `realMain` in response to other auxiliary functions?
`mainAux` is good for its name. (please refer to compile.go, baselib.go etc...)


and is this path correct?


We should also have text chat in hipchat as an option here as well as calls. It works very well for simple updates on projects, as everyone gets to see it and it's asynchronous.

Also, can these things be put in an order of preference, or does it depend on the situation and the people involved? We don't want to end up with lots of persistent documentation that no-one then reads because there's too much - so many things can happen in non-persistent chat. Only significant stuff needs to be captured in a persistent way.


This line we don't need at all, `app_file` is there anyway, Sinatra determines it https://github.com/bmizerany/sinatra/blob/work/lib/sinatra/base.rb#L1506 and it cannot exist. It is very easy to confirm

```ruby
class SinatraApp < Sinatra::Base
  set :public_folder, File.dirname(__FILE__)
  get "/" do
    "hello sinatra app"
  end
end

puts SinatraApp.app_file.to_s
```


These days I don't think we need the hipchat transition room or to rely on just Alice. We could replace this with ask in the wundercafe, or ask someone in your local office - or check the hipchat help.


That was fast :)


`app_constant` looks for the constant each time you call it, it is better to request it once and keep the result in a local variable and reuse within the method.


trang tu tin


This line is too long.


Since we have  `init()` function I think it should be better to call this `ActiveWindowTracker` and make it class instead of set of functions (moreover it has internal state)


```a``` --> ```an```


this file has been has been added by Guangcheng by commit 32c053005bbee1d53e15e568c54f7d02341af532

What source file this file linked from?


Il est [conseillé](https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/parseInt) de toujours préciser le second argument de `parseInt`, qui indique dans quelle base doit s'effectuer la conversion en entier.


Lets check the existence of the public folder only once.


`app_object` cannot be nil, it is already here


I have tested `i3` and `i3status`, it seems that `i3` is a bit weird and it have weird status color.

`i3status` seems to have the wrong **good color** as it uses *yellow* instead of *green*.
![2015-08-20-165651_1600x900_scrot](https://cloud.githubusercontent.com/assets/4687791/9379516/7e75a9d2-475c-11e5-857a-7bc8137d43a7.png)


sure, I am also considering re-order it


unhappy indentation is unhappy.


-add IPMI Measure Points
-removed device import function
-fixed #22
-fixed #32


@seth do we want ema_pow to be 0?


Herehttp://forum.xda-developers.com/showthread.php?p=62411019

Bluetooth works on cm nightly. Not sure if they are compiling with acortex


very educative thanks alot


pls fix indentation.


why do sou use array() instead of []? downwarts compability?


@michaelneale I agree with the replacement but I'd replace also other occurrences in Javadoc.


If we set this to:

```php
public function sendAudio($chat_id, $audio, $duration = null, $reply_to_message_id = null, $reply_markup = null, $performer = null, $title = null)
```

ie Reorder the parameters, there would be no backwards compatibility problem....I think.


Yep, prefSet wasn't found, was in a hurry
Compiled fine :3
On Aug 20, 2015 2:00 PM, "Ateek Ujjawal" <notifications@github.com> wrote:

> What will this return, nothing??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Team-Radium/packages_apps_Settings/commit/c0b121e9c9774e1f44fc8f66253a87ac3327966f#commitcomment-12802253>
> .
>


develop (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.92%25-red.svg)


i just don't like the fact that generic turned into Avro everywhere


Thank you. I couldn't clone the repo due to GFW.


bb


You can get errors by removing line 2
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-build-moEcxG/Quamash/setup.py", line 2, in <module>
        import quamash
      File "quamash/__init__.py", line 1
    SyntaxError: Non-ASCII character '\xc2' in file quamash/__init__.py on line 1, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details

I suggest putting it back.


I agree, OK


"Replace all tokens in the same line AS the element pointed TO by $stackPtr"


Done.


I get the following error:
```
cannot convert from 'GDALD river *' to 'OGRSFDriver *' [c:\mb\windows-builds-64\packages\libosmium\build\examples\osmium_toogr.vcxproj]
```

I suppose you haven't upgraded to gdal 200 yet?

[MIGRATION GUIDE FROM GDAL 1.11 to GDAL 2.0](http://svn.osgeo.org/gdal/trunk/gdal/MIGRATION_GUIDE.TXT):
```
OGRSFDriverRegistrar and OGRSFDriver are now deprecated.
Use GDALDriverManager and GDALDriver instead.
```

Any plans to move to gdal 200 soon, or should I use an older gdal?


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1280 of 1280 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.53%25-green.svg)


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=112&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 02:54:28


Yes, please amend the commit message and force-push to update the PR. Good catch!


There is no problem with protocol-less links in general, but they were causing CSP checking to fail. This  means that brwosers that support CSP headers will not load the content.


Hardly a full game :P


That doesn't compile.


I have updated some info in the commend above, I hope you can also add template for newsbeuter. Look at https://github.com/chriskempson/base16-builder/issues/284#issue-94651002.


Perhaps the term `session.timeout` is a little bit misleading. It refers to the timeout once a user is logged in (to the panel, or to the site, if implemented) which is hardcoded to one week today. As far as I know this timeout is handled with the kirby cookie, not with the PHP session cookie. The timeout was not meant to be related to the PHP session.

I cannot say whether it would be useful to have this timeout value stored in the PHP session cookie, or whether the PHP session should timout as well.


Checking for existing project/Userlogin.ss

repeated


This is not needed. This policy is an Inline User Policy and doesn't have to be unique.


@gsouvik

Since the FT is already on the page "mobile/loc_list", why not just hidding the prompt window? Is that too difficult? A refresh of a page consumes a lot more server resources than using jQuery to hide a div.

Let me know.


Could you avoid these unnecessary merges from now on please? There is no reason for a 3-way merge here, commits are completely independent.
To do so, after you do some local commits, use git pull --rebase instead of git pull. This will move your commits after the existing ones. It simplifies the history and avoids this noise.
Thanks in advance.


Thanks! Adopted a fix based on this, but with a very slightly different style (feels *marginally* more robust).
Good work raising the issue & proposed fix.


No strong opinion on which one sounds better


Shouldn't myOverrideData be cleared here like myHighlightData and myNavigationData?


No problem 😉


`"Following are examples of schema renames."`?
@johnktims Or do you have a better idea?


fits. thx


asdas


Ok then I can close my Pull request. I will test this and open a new pull request if I can improve it. :+1:


@yofreke here you can get the directories:

```
console.log(buildResult.config.directories);
```


Does caching the length property to a variable makes an actual difference.


Ok.


Vím, děkuji. Spíš mi prosím dej mail na Verču, já se s ní domluvím.

Tomáš Bedřich
On Aug 20, 2015 10:08 AM, "Petr Viktorin" <notifications@github.com> wrote:

> @tomasbedrich <https://github.com/tomasbedrich>, prý sis tu knížku nechal
> na Věnečku. Má ji u sebe Verča z PyLadies, domluvíte se nějak? Dáš mi na
> sebe třeba e-mail?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pyvec/bookshelf/commit/c9aa2d78580a15a019e3763fec26556e85f655d6#commitcomment-12801883>
> .
>


仔细看了一下，上面这（j遍历，二分查找）效率有问题。

修正下
```java
int j = i+1;
int k = nums.length - 1;
int middle;
while (k > j + 1 && nums[i] + nums[j] + nums[k] != 0) {
   if (nums[i] + nums[j] + nums[k]  > 0) {
      k = binary_search_the_biggest_k_fit(nums[i] + nums[j] + nums[k] <= 0).in(j+1..k-1)
   }
   else {
      j = binary_search_the_smallest_j_fit(nums[i]+nums[j]+nums[k] >=0).in(j+1..k-1)
   }
}
```


@stof Thank you for looking into this. But 1.* version is old (Last updated in 2013) and while trying extraction of trans strings from the source code, found out it requires dev-master version of translation bundle.


"Under normal circumstances, this fallback isn't needed" - but under *abnormal* circumstances, it prevents the chooser from breaking completely when you switch git branches on your project. -1 for removing this.


Commit related to #209


Could you please state the Windows version where you see the truncated text, and sign off on your commit? Simply amend the commit and force push to update the PR.

Thanks!


Upload spawns later


Well now that you got the blobs, could you try just adding them ?

Add them manually if it works I will help you to add them to your project in your makefile if you don't know how to do it


upload spawns later


Removed the required fields.

Given this is a writing tip, I would prefer to follow the style guides (either AP or Chicago) approach to writing numbers. Also, I think that the approach with the form should follow the principle that a form is a conversation between the system and the user, and keep the language quite human. To this end I have used your second option with a slight tweak.

Note: You can use `<code>` examples in GitHub comments by using the \` character.


merge


Хм, это теперь можно будет включить режим зеркального отражения, как у гугла на 1 апреля?


Solves issue #274


This is not possible as the `PipelineFactory` does `broker.title()`.

   > 'PythonList'.title()
   'Pythonlist'


(1) raw_input always returns strings.
```
>>> x = raw_input("> ")
> 3
>>> type(x)
<type 'str'>
>>> if x == 3: print True
...
>>>
```


Should be 2.

Threshold should be 1000.

Delay should be 1.

On Thursday, August 20, 2015, Frank Laub <notifications@github.com> wrote:

> @seth <https://github.com/seth> do we want ema_pow to be 0?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hmflash/tikitank/commit/8c5892a880b08cca2cf167e7efc1be608303399a#commitcomment-12802673>
> .
>


Такой себе комит


The textbook way to implement BFS is to initialize your `distance` dictionary for each node to infinity.  In Python, that's `sys.maxsize`.  This way you don't need a `visited` dictionary, because you can tell whether or not you've visited a node based on the distance value.


"NONE" not "None"


Non, ça c'est pas ok.... En avant c'est devant, ou plus haut. Un highlight c'est mettre en évidence


98812296-SkyTemperatureShiftsSchedules-4866 (rglazer2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes but running as Administrator disables `git push` / `git pull` to the network because you are not the correct user. Also npm gives me errors if I mix installing as administrator and as user. This can be solved to run npm as Administrator on all projects . Even non Ember projects. Perhaps we don't want beginners to have these problems. Can't we make symlink work by setting some rights for the normal windows user? If I do this, this check should be "can you create symlinks". (Is this check not already in ember-cli ??)

So I always have mixed feelings when I read "Run as Administrator". It is the same advice as always run sudo. Perhaps we should reconsider adding this test.


Thanks for submitting this one Andrew - has also been discussed on mcstas-users and will be in an update release within the next month or so.


Aucune


There is anothwer current.T below so bring into scope (not yours, was there before)


Asked a few people and no one had any better ideas. We can always rename if it gets overloaded.


Ah there's been an update, will update to use UmbracoAuthorizedApiController in next release


bring s3db into scope...in fact bring the table into scope...


Assuming you initialize `distance` to infinity, this is where you set `distance[node.name]` to `0`.


Could you please start the field name with m? menuItems --> mMenuItems.
Makes reading easier, specially in Github,

(Same comment for the rest of the attributes of the class)


Почему автоинкремент?


coffeelint:

      ✗ app/client.cjsx
         ✗ #11: Line contains a trailing semicolon.
         ✗ #29: Line contains inconsistent indentation. Expected 2 got 1.
         ✗ #29: Line contains tab indentation.
         ⚡ #30: Used `this` in a function without a fat arrow.
         ✗ #30: Line contains tab indentation.
         ✗ #30: Line exceeds maximum allowed length. Length is 107, max is 100.
         ✗ #31: Line contains inconsistent indentation. Expected 2 got 4.
         ⚡ #33: Operators must be spaced properly. -.
         ✗ #38: Line contains tab indentation.
      ✗ app/component/itinerary/bottom-navigation.cjsx
         ✗ #17: Line exceeds maximum allowed length. Length is 147, max is 100.
      ✗ app/component/map/map.cjsx
         ✗ #19: Line exceeds maximum allowed length. Length is 200, max is 100.
         ✗ #86: Line exceeds maximum allowed length. Length is 132, max is 100.
         ⚡ #92: Operators must be spaced properly. +.
         ✗ #110: Line exceeds maximum allowed length. Length is 107, max is 100.
      ✗ app/component/map/route-marker-popup.cjsx
         ⚡ #26: Spaces are required after commas. ,.
         ✗ #36: Line exceeds maximum allowed length. Length is 102, max is 100.
         ✗ #37: Line exceeds maximum allowed length. Length is 116, max is 100.
         ✗ #39: Line exceeds maximum allowed length. Length is 108, max is 100.
         ✗ #42: Line exceeds maximum allowed length. Length is 101, max is 100.
         ✗ #45: Line exceeds maximum allowed length. Length is 131, max is 100.
         ✗ #46: Line exceeds maximum allowed length. Length is 116, max is 100.
      ✗ app/component/map/stop-marker-container.cjsx
         ⚡ #43-87: The cyclomatic complexity is too damn high. 11.
         ⚡ #46-85: The cyclomatic complexity is too damn high. 11.
         ⚡ #58: Colon assignment without proper spacing. Incorrect spacing around column 87.
    Expected left: 0, right: 1.
    Got left: 0, right: 0..
         ⚡ #58: Colon assignment without proper spacing. Incorrect spacing around column 103.
    Expected left: 0, right: 1.
    Got left: 0, right: 0..
         ⚡ #58: Colon assignment without proper spacing. Incorrect spacing around column 117.
    Expected left: 0, right: 1.
    Got left: 0, right: 0..
         ⚡ #58: Colon assignment without proper spacing. Incorrect spacing around column 132.
    Expected left: 0, right: 1.
    Got left: 0, right: 0..
         ✗ #58: Line exceeds maximum allowed length. Length is 156, max is 100.
         ✗ #76: Line exceeds maximum allowed length. Length is 130, max is 100.
         ⚡ #81: Spaces are required after commas. ,.
         ⚡ #81: Spaces are required after commas. ,.
         ✗ #81: Line exceeds maximum allowed length. Length is 223, max is 100.
         ✗ #88: Line exceeds maximum allowed length. Length is 105, max is 100.
      ✗ app/component/map/stop-marker-popup.cjsx
         ✗ #43: Line exceeds maximum allowed length. Length is 217, max is 100.
         ✗ #44: Line exceeds maximum allowed length. Length is 146, max is 100.
         ✗ #46: Line exceeds maximum allowed length. Length is 221, max is 100.
         ✗ #47: Line exceeds maximum allowed length. Length is 305, max is 100.
      ✗ app/component/navigation/back-button.cjsx
         ✗ #25: Line exceeds maximum allowed length. Length is 102, max is 100.
      ✗ app/component/navigation/index-navigation.cjsx
         ✗ #25: Line contains a trailing semicolon.
         ✗ #27: Line exceeds maximum allowed length. Length is 104, max is 100.
         ✗ #27: Line contains a trailing semicolon.
         ✗ #46: Line exceeds maximum allowed length. Length is 172, max is 100.
      ✗ app/component/navigation/summary-navigation.cjsx
         ✗ #24: Line exceeds maximum allowed length. Length is 141, max is 100.
      ✗ app/component/route/route-header.cjsx
         ⚡ #12: Spaces are required after commas. ,.
         ⚡ #12: Spaces are required after commas. ,.
         ✗ #12: Line exceeds maximum allowed length. Length is 178, max is 100.
         ✗ #14: Line exceeds maximum allowed length. Length is 103, max is 100.
         ✗ #15: Line exceeds maximum allowed length. Length is 127, max is 100.
         ✗ #31: Line exceeds maximum allowed length. Length is 120, max is 100.
         ✗ #32: Line exceeds maximum allowed length. Length is 137, max is 100.
      ✗ app/component/route/route-stop.cjsx
         ✗ #14: Line exceeds maximum allowed length. Length is 131, max is 100.
         ✗ #15: Line exceeds maximum allowed length. Length is 108, max is 100.
         ✗ #17: Line exceeds maximum allowed length. Length is 140, max is 100.
         ✗ #25: Line exceeds maximum allowed length. Length is 101, max is 100.
      ✗ app/component/search/from-to-search.cjsx
         ✗ #9: Line exceeds maximum allowed length. Length is 118, max is 100.
         ✗ #12: Line exceeds maximum allowed length. Length is 124, max is 100.
         ✗ #14: Line exceeds maximum allowed length. Length is 153, max is 100.
         ✗ #23: Line exceeds maximum allowed length. Length is 118, max is 100.
         ✗ #26: Line exceeds maximum allowed length. Length is 122, max is 100.
      ✗ app/component/search/search.cjsx
         ⚡ #31-68: The cyclomatic complexity is too damn high. 13.
         ⚡ #41: Spaces are required after commas. ,.
         ⚡ #42: Operators must be spaced properly. +.
         ⚡ #50: Spaces are required after commas. ,.
         ✗ #76: Line exceeds maximum allowed length. Length is 114, max is 100.
         ✗ #88: Line exceeds maximum allowed length. Length is 181, max is 100.
         ✗ #91: Line exceeds maximum allowed length. Length is 121, max is 100.
         ✗ #107: Line exceeds maximum allowed length. Length is 142, max is 100.
         ⚡ #108: Spaces are required after commas. ,.
         ✗ #143: Line exceeds maximum allowed length. Length is 114, max is 100.
         ✗ #161: Line exceeds maximum allowed length. Length is 111, max is 100.
         ✗ #190: Line exceeds maximum allowed length. Length is 123, max is 100.
         ✗ #191: Line exceeds maximum allowed length. Length is 124, max is 100.
         ✗ #192: Line exceeds maximum allowed length. Length is 124, max is 100.
         ⚡ #234: Don't use 'this', use '@' instead.
         ⚡ #260: Don't use 'this', use '@' instead.
         ✗ #281: Line exceeds maximum allowed length. Length is 114, max is 100.
         ✗ #296: Line exceeds maximum allowed length. Length is 112, max is 100.
      ✗ app/component/search/search-with-location.cjsx
         ✗ #11: Line exceeds maximum allowed length. Length is 118, max is 100.
      ✗ app/component/stop-cards/departure-list-container.cjsx
         ⚡ #23: Don't use 'this', use '@' instead.
         ✗ #33: Line exceeds maximum allowed length. Length is 159, max is 100.
         ⚡ #33: Operators must be spaced properly. -.
         ⚡ #33: Operators must be spaced properly. -.
         ⚡ #36-70: The cyclomatic complexity is too damn high. 12.
         ⚡ #44: Operators must be spaced properly. *.
         ✗ #46: Line exceeds maximum allowed length. Length is 164, max is 100.
         ✗ #50: Line exceeds maximum allowed length. Length is 193, max is 100.
         ⚡ #59: Comprehensions must have parentheses around them.
         ✗ #59: Line exceeds maximum allowed length. Length is 107, max is 100.
         ✗ #63: Line exceeds maximum allowed length. Length is 151, max is 100.
         ✗ #65: Line exceeds maximum allowed length. Length is 180, max is 100.
         ⚡ #67: Spaces are required after commas. ,.
         ⚡ #67: Operators must be spaced properly. -.
         ✗ #67: Line exceeds maximum allowed length. Length is 220, max is 100.
         ✗ #71: Line exceeds maximum allowed length. Length is 207, max is 100.
      ✗ app/component/stop-cards/route-list.cjsx
         ✗ #9: Line exceeds maximum allowed length. Length is 135, max is 100.
         ✗ #10: Line contains tab indentation.
         ✗ #11: Line contains tab indentation.
      ✗ app/component/stop-cards/stop-card.cjsx
         ✗ #13: Line exceeds maximum allowed length. Length is 174, max is 100.
      ✗ app/component/stop-cards/stop-card-header.cjsx
         ✗ #20: Line exceeds maximum allowed length. Length is 104, max is 100.
         ✗ #28: Line exceeds maximum allowed length. Length is 161, max is 100.
         ✗ #30: Line exceeds maximum allowed length. Length is 127, max is 100.
         ✗ #31: Line exceeds maximum allowed length. Length is 119, max is 100.
         ✗ #32: Line exceeds maximum allowed length. Length is 137, max is 100.
      ✗ app/component/stop-cards/stop-card-list.cjsx
         ✗ #21: Line exceeds maximum allowed length. Length is 109, max is 100.
         ✗ #22: Line exceeds maximum allowed length. Length is 102, max is 100.
      ✗ app/component/summary/summary-row.cjsx
         ⚡ #8-133: The cyclomatic complexity is too damn high. 16.
         ⚡ #17: Operators must be spaced properly. -.
         ⚡ #21: Operators must be spaced properly. /.
         ⚡ #21: Operators must be spaced properly. -.
         ⚡ #22: Operators must be spaced properly. -.
         ⚡ #22: Operators must be spaced properly. /.
         ⚡ #22: Operators must be spaced properly. -.
         ✗ #37: Line exceeds maximum allowed length. Length is 105, max is 100.
         ✗ #46: Line exceeds maximum allowed length. Length is 105, max is 100.
         ⚡ #71: Operators must be spaced properly. /.
         ⚡ #83: Operators must be spaced properly. +.
         ✗ #83: Line exceeds maximum allowed length. Length is 114, max is 100.
         ✗ #84: Line exceeds maximum allowed length. Length is 117, max is 100.
         ⚡ #84: Operators must be spaced properly. +.
         ⚡ #85: Operators must be spaced properly. +.
         ✗ #85: Line exceeds maximum allowed length. Length is 141, max is 100.
         ⚡ #92: Operators must be spaced properly. +.
         ⚡ #99: Operators must be spaced properly. +.
         ⚡ #105: Operators must be spaced properly. +.
         ⚡ #111: Operators must be spaced properly. +.
         ✗ #122: Line exceeds maximum allowed length. Length is 152, max is 100.
         ✗ #125: Line exceeds maximum allowed length. Length is 161, max is 100.
      ✗ app/page/index.cjsx
         ✗ #29: Line exceeds maximum allowed length. Length is 114, max is 100.
         ✗ #31: Line exceeds maximum allowed length. Length is 230, max is 100.
      ✗ app/page/map.cjsx
         ✗ #14: Line exceeds maximum allowed length. Length is 221, max is 100.
      ✗ app/page/route.cjsx
         ✗ #22: Line exceeds maximum allowed length. Length is 103, max is 100.
         ✗ #42: Line exceeds maximum allowed length. Length is 105, max is 100.
      ✗ app/page/stop.cjsx
         ⚡ #47: Operators must be spaced properly. +.
         ✗ #47: Line exceeds maximum allowed length. Length is 139, max is 100.
         ✗ #48: Line exceeds maximum allowed length. Length is 117, max is 100.
         ✗ #49: Line exceeds maximum allowed length. Length is 187, max is 100.
         ✗ #50: Line exceeds maximum allowed length. Length is 262, max is 100.
         ✗ #52: Line exceeds maximum allowed length. Length is 197, max is 100.
      ✗ app/routes.cjsx
         ✗ #23: Line exceeds maximum allowed length. Length is 104, max is 100.
         ✗ #26: Line exceeds maximum allowed length. Length is 101, max is 100.
         ✗ #27: Line exceeds maximum allowed length. Length is 114, max is 100.
         ✗ #28: Line exceeds maximum allowed length. Length is 110, max is 100.
         ✗ #30: Line exceeds maximum allowed length. Length is 103, max is 100.
         ✗ #32: Line exceeds maximum allowed length. Length is 108, max is 100.
         ✗ #33: Line exceeds maximum allowed length. Length is 118, max is 100.
         ✗ #34: Line exceeds maximum allowed length. Length is 125, max is 100.


Better to do
priority =
if prioirty:
     ...
However in this case what I had before worked fine - you obviously haven't tested either the before or after...the map popups are not represented already so what I had worked fine already...


Il faut enclancher, certaines partie de l'htaccess qui lui est toujours à la racine de FS


`queue.pop(0)` also works here, which means you don't have to use it again at the end of the `while` loop.


well make it:
priority = priority or T("Unknown")


since raw isn't used for anything else, why bring it into scope?


f3() added the !


This was deliberately left here as a reminder/easy to enable


I think the `'` in `don't` here needs to be a double (`''`) so it doesn't break the string.


you: "South Hall has only 76.9230769231\% the number of chars of Python Rocks!"

me: "'South Hall' has only 76.92% the number of chars of Python Rocks!"


I don't have much time today, so I have committed these half-finished changes. I did try to compile aegisub with these changes on Fatdog64, but the configure step errors out (see below).
I'm also sure that the `cp /usr/lib/libboost*` step will fail on Fatdog64, since libboost* is installed in /usr/lib64. Will get to that when I have more time.

**configure step fails**
```
sandbox# bash -ex ./aegisub_ffmpeg_project.sh aegisub

...
checking for AVRESAMPLE... no
checking for AVRESAMPLE... yes
checking whether -Wl,-Bsymbolic is needed... no
configure: error: in `/root/mpv/sources/ffms2':
configure: error: cannot build ffms2 as a shared library
See `config.log' for more details
+ exit 1
```
This is from `config.log`
```
configure:16689: gcc -o conftest -O3 -Wall -Wextra   -D__STDC_CONSTANT_MACROS  -shared  -fPIC -DPIC -Wl,-Bsymbolic conftest.c  -L/root/mpv/build/lib -L/usr/li
b64 -L/root/mpv/build/lib -L/usr/lib64 -L/root/mpv/build/lib -L/usr/lib64 -L/root/mpv/build/lib -L/usr/lib64 -L/root/mpv/build/lib -lavformat -ljack -lasound
-lSDL -lpthread -lSDL -lpthread -lm -ldl -lts -lpthread -lxvidcore -lx265 -lstdc++ -lm -lrt -ldl -lx264 -lpthread -lm -ldl -lwavpack -lvpx -lm -lpthread -lvpx
 -lm -lpthread -lvpx -lm -lpthread -lvpx -lm -lpthread -lvorbisenc -lvorbis -logg -ltheoraenc -ltheoradec -logg -lspeex -lm -lopus -lm -lopencore-amrwb -lopen
core-amrnb -lmp3lame -lfreetype -lbz2 -lz -lpng16 -lm -lz -lm -lharfbuzz -lfdk-aac -lm -lass -lm -lfontconfig -lexpat -lfreetype -lexpat -lenca -lm -lfribidi
-lglib-2.0 -pthread -lpcre -lfreetype -lbz2 -lz -lpng16 -lm -lz -lm -lharfbuzz -lm -llzma -lbz2 -lz -pthread -lavcodec -ljack -lasound -lSDL -lpthread -lSDL -
lpthread -lm -ldl -lts -lpthread -lxvidcore -lx265 -lstdc++ -lm -ldl -lx264 -lpthread -lm -ldl -lwavpack -lvpx -lm -lpthread -lvpx -lm -lpthread -lvpx -lm -lp
thread -lvpx -lm -lpthread -lvorbisenc -lvorbis -logg -ltheoraenc -ltheoradec -logg -lspeex -lm -lopus -lm -lopencore-amrwb -lopencore-amrnb -lmp3lame -lfreet
ype -lbz2 -lz -lpng16 -lm -lz -lm -lharfbuzz -lfdk-aac -lm -lass -lm -lfontconfig -lexpat -lfreetype -lexpat -lenca -lm -lfribidi -lglib-2.0 -pthread -lpcre -
lfreetype -lbz2 -lz -lpng16 -lm -lz -lm -lharfbuzz -lm -llzma -lbz2 -lz -pthread -lswresample -lm -lswscale -lm -lavutil -lm -lrt >&5
/usr/bin/ld: /root/mpv/build/lib/libexpat.a(xmlparse.o): relocation R_X86_64_32S against `.rodata' can not be used when making a shared object; recompile with
 -fPIC
/root/mpv/build/lib/libexpat.a: error adding symbols: Bad value
collect2: error: ld returned 1 exit status
configure:16689: $? = 1
configure: failed program was:
| /* confdefs.h */
| #define PACKAGE_NAME "ffms2"
| #define PACKAGE_TARNAME "ffms2"
| #define PACKAGE_VERSION "2.22.0"
| #define PACKAGE_STRING "ffms2 2.22.0"
| #define PACKAGE_BUGREPORT ""
| #define PACKAGE_URL ""
| #define PACKAGE "ffms2"
| #define VERSION "2.22.0"
| #define STDC_HEADERS 1
| #define HAVE_SYS_TYPES_H 1
| #define HAVE_SYS_STAT_H 1
| #define HAVE_STDLIB_H 1
| #define HAVE_STRING_H 1
| #define HAVE_MEMORY_H 1
| #define HAVE_STRINGS_H 1
| #define HAVE_INTTYPES_H 1
| #define HAVE_STDINT_H 1
| #define HAVE_UNISTD_H 1
| #define HAVE_DLFCN_H 1
| #define LT_OBJDIR ".libs/"
| #define FFMS_USE_FFMPEG_COMPAT 1
| #define WITH_SWRESAMPLE 1
| /* end confdefs.h.  */
|
|             #include <libavcodec/avcodec.h>
|             #include <libswscale/swscale.h>
|
| int
| main ()
| {
|
|                 avcodec_register_all();
|                 swscale_version();
|                 #ifdef FFMS_USE_FFMPEG_COMPAT
|                 int bogus = CODEC_ID_G2M;
|                 (void) bogus;
|                 #endif
|
|   ;
|   return 0;
| }
configure:16700: result: no
configure:16702: error: in `/root/mpv/sources/ffms2':
configure:16704: error: cannot build ffms2 as a shared library
See `config.log' for more details
```


uh oh, this toggle should not be turned on like on #640 ... right ? xD


This needs to stay here according to my suggestions


@sircharleswatson Oops :grin:. Done!


If you are updating the file, I believe you can use 2014-15 format


This request is still valid!


Funny classes - but try to check the diffs before submitting pull requests :)


No significant progress so far, see first comment in 0cc69b0.


From my understanding of this, the presets are always supplied by the parameter, and never by metadata. If that's the case, can this metadataChanged stuff be removed entirely?


### 膜膜膜
orz godQun


git bisect says this one broke our [tests](https://travis-ci.org/openSUSE/open-build-service/jobs/76300359).

@mlschroe Could you fix them?


ok, my fault that your change only for diskless


it's not part of 0.9.9 thus that should be good - 0.9.10 seems only in staging (not yet released as a gem)
what (other) key-store change you mean, related to default paths from #61 (part of 0.9.9) ?


You'll usually have bigger problems than your page chooser if you're database is in an *abnormal* state. IIRC, the page index and edit views will break anyway.


these are not listeners


abc


float() not ord()


Github maximum length line limit is 120. If you put longer lines we need to do scroll for reviewing the code in Github. It isn't a big problem but it isn't comfortable
Please, don't exceed this limit to make the review easier. ;)


Done, see commit https://github.com/owncloud/android/commit/8b55e8b35ca36ecb89f27853b3244401e03324a2


without obsoletes


This is not a listener either, EventManager takes care of that and then just calls methods that the views provide.


1: M111 unrecognized component name: unapi


without all


Fucking awesome.


these switches should be just `--installed`, etc.


Since we had probably the same idea. I prefer this "full-button-version" also. ;-)
In Full Screen, the buttons are very close to the outer edges.


This hasn't changed yet since the previous time?


use space instead,
if i % 3 == 0 and i % 5 == 0: is shorter


Please undo this, that makes no sense!
both of them work and since TYPO3 V8 includeJSlibs is deprecated


``for i in range(1,1000):``


print


empty catch it not a good code.


Also been fixed in commit https://github.com/owncloud/android/commit/8b55e8b35ca36ecb89f27853b3244401e03324a2 :)


npm install dies at

    npm ERR! Linux 3.16.0-4-amd64
npm ERR! argv "/usr/bin/node" "/usr/bin/npm" "install"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package leaflet does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer react-leaflet@0.6.2 wants leaflet@^0.7.0

npm ERR! Please include the following file with any support request:


sebenernya....

ini tetep aja menyayangkan gitu..

"Udah penuh"... "Ngapain kamu lagi"
dan semacamnya tapi secara halus.


The menu view does not need to be recreated when the items change, that's something that's taken care of by the CollectionView (the CollectionView will observe changes on its content array and update its child views accordingly).


@mmoelli  Why didn't the following test case fail before: https://github.com/sphereio/sphere-node-product-csv-sync/blob/master/src/spec/mapping.spec.coffee#L114


btw you're commenting on a commit again ;)


But your proposal is perfectly valid.


sorted by length


Seems fine to me.


It's weird, but http://docs.gl/gl3/glDrawBuffer doesn't mention COLOR_ATTACHMENT0 at all :O Are there any good docs on how this function should be used with FBOs?


По-моему, как-то странно, что функция отправки статистики отправляет только тип события, а не конкретную инфу. Полезнее было быотправлять, с каког видео на какое кто перешел. А тут отправится только то, что я перешел по предложенному видео и всё. Хотя, может еще добавят - вызова этой функции-то все равно в данном коммите нет.


Look up sets


Why was this reverted?


getResultDataは一覧画面表示の際に呼ばれる処理です。


getResultDataDetailは詳細画面表示の際に呼ばれる処理です。


Yeah, please use that instead (unless you can think of a use-case that doesn't want that). This trait is so specific that making its prerequisites generic is just misleading.


"Komentar Jahil"
"Tampilkan Perubahan EXP"


add `(RhBug:1199601)` and chnage msg to ~ "alternative to pkgnarrow"


You popped the old index. Things shifted.
```
['Littlest', 'Bear', 'Magic', 'To', 'Python', 'Truth', 'Reality']
['PYTHON!', ['Littlest', 'Bear', 'Python', 'Truth', 'Reality']]
```


Comment about the leaflet bug would be good, otherwise this looks odd.


recordにはTestResultDataがセットされ、
record.UrlでTestResultDataのgetUrlメソッドが呼ばれます。


if i_res == _3a_result.end(); may cause crash.


remove would work fine here


change the message


これで入力された値をそのまま返す感じになります。
自動リンクされなくなるので自前でaタグ入れるとかの必要がありますね。


This conditional would check if the child's distance is infinity.


Still missing some changes in docstring. Indeed model is now univariate. Reference to 'multivariate model' should be removed
Otherwise seems ok to be merged


Reverted in: https://github.com/torchbox/wagtail/commit/0bf12ca33343cd4d87a90ed431883a0cbeda3974


詳細画面ではresult.DetailでTestResultDataが呼ばれるようになっています。


I'm interested in seeing what you come up w/


if we can add version control, it looks better, because the member maxMem appears from lsf 9.1+.

#if VERSION >= 26

int
 ji_maxMem(self)
 	LSF_Batch_jobInfo *self
     CODE:
 	RETVAL = self->maxMem;
     OUTPUT:
 	RETVAL

#endif


A comment here too.


You'd also have to set the child's new distance in here.


Having this check probably doesn't hurt, but shouldnt we more higher up/earlier check for configs and set default? (Assuming that is not already the case)


Great, thanks!  What does the error message look like if you run without appropriate privilege?


@Legoless ah ok!  I was not aware of that - thanks :)


The `distance=0` parameter isn't needed anymore.  You could also refactor the code to use your `distance` dictionary and remove this method entirely.


I’ve done it, and I’m making a few more changes to uContactor.

I’ll branch and do a pull request again if that’s ok with you.


Does this mean the branch doesn't handle map state in the URL anymore? If yes, a TODO marker would be good to avoid surprising regressions later.


This line should be longer


`.only` left in


ok perfect


Thanks, reverted them all in fd38b5f.


А team_members_memberId_foreign норм работает? или тоже нужно к ловер кейсу привети?


```
php benchmarks/middleware.php                                                                                !55026
n=50000
Runing by-closure - . 35493.135190949/s
Runing by-iteration - . 50467.227196519/s

                  Rate   Mem by-iteration by-closure
by-iteration  50.47K/s    0B           --       -70%
  by-closure  35.49K/s    0B         142%         --

================================== Bar Chart ==================================

  by-iteration  50.47K/s | ████████████████████████████████████████████████████████████  |
    by-closure  35.49K/s | ██████████████████████████████████████████                    |

============================== System Information ==============================

PHP Version: 5.6.10
CPU Brand String: Intel(R) Core(TM) i5-4258U CPU @ 2.40GHz

With XDebug Extension.
```


QUIT messages don't have a target.


This is only valid for 2D arrays. As far as I know we only remove points when the data is 2D?!


      nothing provides rubygem(ruby:2.2.0:coveralls) = 0.7.0 needed by obs-api-testsuite-deps
      nothing provides rubygem(ruby:2.2.0:rest-client) = 1.7.3 needed by obs-api-testsuite-deps
      nothing provides rubygem(ruby:2.2.0:term-ansicolor) = 1.3.0 needed by obs-api-testsuite-deps
      nothing provides rubygem(ruby:2.2.0:tins) = 1.3.5 needed by obs-api-testsuite-deps


Can you give me a correct syntax for using this format function?
Thanks.


Hi,

Can you please make a PR of it on 1.6.1.x branch please ?

Thank you.

Regards


It's ok, will waiting for your pull request


I will add the text chat, too.
As of the preference/order: usually this depends on the order. What I have intended to emphasize is that everything, even if discussed by voice should be documented. This is also covered further down the page.

What would be your preferred order, @steveparks?


Leftmost const is 100% evil. I'll let this go though...


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 16](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=113&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Not sure if this is really a shortcut, since you're caching the object in an attribute. I'm also not sure if this documentation format is according to the default attribute documentation. Shouldn't it rather be something like:

    $log = $self->log;
    $self = $self->log(Mojo::Log->new);


:tada: :dancer:


From the first look I would assume that this wasn't working as it was not seeking for `categories.externalId` after your change to the implementation. But to be honest, I don't know. WDYT?


Còn tính tổng của các số thì tiếp theo thế nào ạ?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 16](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=113&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:01:20


98812296-SkyTemperatureShiftsSchedules-4866 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity Xbim :: Xbim Analysis :: XbimAnalysis [Build 9](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=114&buildTypeId=Xbim_XbimAnalysis_XbimAnalysis) is now running


Oh shit. Sorry! I just looked back over the documentation and saw that I'd implemented ExitThread with TerminateThread's parameters :(


TeamCity Xbim :: Xbim Analysis :: XbimAnalysis [Build 9](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=114&buildTypeId=Xbim_XbimAnalysis_XbimAnalysis) outcome was **SUCCESS**
Summary: Running Build time: 00:00:24


We might also just mention the communication channels, without any order. Guidance on the preference or dependency on the situation is provided by "communication-channels".


E ko hiểu đoạn này a comment vậy là sao?
Chỉ có mỗi
else:
 	numDate = 'ko xac dinh'
 print numDate

Hay tại e chưa biết xem đầy đủ?


updated OS=Linux....  ok


Not part of your checkin, but is there really something called donwcase?


I would change this to:

> The `ttl` key specifies the "time to live" of the value -- specifically, the maximum amount of time in seconds which a client should be expected to retain the value of the secret after accessing it.  If you expect the secret to change frequently, or if you need clients to react quickly to a change in the secret's value, specify a low TTL value.  When choosing this value, consider the tradeoff in load -- a low TTL may add significant additional load to the Vault server as clients access it more frequently.


>>    startNode may be -1 here
>
> No. At this point buildPath() has already checked that a pathgrid exists. If a pathgrid exists, getClosestPoint() must return a node. (Unless it has a bug, which we should fix.)

You're making an assumption that getClosestPoint() won't return -1 because you happened to know the implementation detail not because the interface contract guarantees it.

Having said that, I'm happy in general that you're updating this part of the codebase.  In a way I would like to see more aggressive re-factoring (I was too timid to rewrite aiwander's over-complicated implementation).


@gaearon same ¯\_(ツ)_/¯


发


方法


I Wants Advanced Hub Stuff LOL!!!


convert_new_coils_modelobjectlist (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Missed a console.log?


oops


Looks quite straightforward to me.  Let me pull this branch and play with it and I should be able to release as `0.4.2` very soon.


Removed and published `0.8.1`


I'm so sorry for the hideous mess I created in these commits


Is there a specific reason why this commit wasn't included in todays update?


@bcamper
You can refer the yaml spec for the same here: http://www.yaml.org/spec/1.2/spec.html#schema/failsafe/.


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1801 of 1801 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I've forked


I think this method isn't doing anything, and its why the sidebar won't show up. Uuugghhhhh I'm baffled


update carbon... i just paid for my server and then i just found out that i can't get carbon to work at all :(


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


These are not recursive -- setMemPoolParents and setMemPoolChildren are just the in-mempool direct parents/children of a transaction.

I've begun work on reimplementing these data structures to use iterators rather than uint256's, but it's trickier and a bigger change than I had hoped (the code had to be restructured because otherwise the compiler seems unhappy with the circular dependency between CTxMemPoolEntry and indexed_transaction_set).

I think if we are happy with the overall approach here, then it would be better to separately evaluate (perhaps in a future pull, or as an additional commit to this one) whether rewriting this to use iterators is actually a net win, looking at both the value of the reduced memory footprint and the readability of the resulting code.


Thanks! Trying this right now, with x=4.


This looks great! But, there are a couple of comments:

- it's great that you assigned all the copyrights to me, but feel free to assign them to yourself if you prefer.

- it looks like you do not obey the 'enabled' flag of your new SearchProvider object; this is a complex issue because (1) you need to handle ASINs (ie. search Amazon first even if Amazon is not first or is not enabled), (2) you need to prevent them disabling all providers, (3)  if they are searching by Author/Title, they can not search LibraryThing first because it does not support author/title searches.

- you probably need to update the comments; many seem to relate to the code which was cloned eg.
```
/**
+ * Activity to edit the list of styles and enable/disable their presence in the
+ * styles menu.
+ *
+ * @author Philip Warner
+ */
public class SearchOrdersActivity extends EditObjectList<SearchProvider> {
...
```

- you may want to consider making mMaxSearchBits static and final by using the expression:
```
    mMaxSearchBits = Math.floor(Math.log(SEARCH_ALL)/math.log(2)+0.00000000001)+1;
    /* adding 0.00000000001 is paranoia to avoid rounding/accuracy issues */
```

- the new strings can all be merged with 5.1.3, which has not been released.


## This is a markdown file


empd (nmerket) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-60.88%25-red.svg)


Just let me know this game is old
Gimme vedio fuck around


This doesn't work


In aviation local tangent plane coordinates are frequently used (known as NED coordinates), X-axis is north, Y - east, Z - down. Legacy MultiWii code modified this to NEU coordinates (North-East-Up), I inherited this approach. It also keeps trogonometry straightforward as heading angle is also reversed compared to cartesian coordinate system.


98318570_RemoveRadianceCheckbox (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.96%25-red.svg)


processing and plotting of seismic data


Should probably require spotlight without a variable as spotlight is needed for this test.


testes


here's a quick and dirty way: https://github.com/jpalmieri/zd_wrapper/commit/11b177d34a1d67c4daf5479e1e9963771ca78f85


Right, I know. I just thought I'd put it on to help test. This issue is just one of the things preventing me from keeping the build up.


No, it's a hint to clients of the maximum expected data validity period. If the lease is given to them as an hour, they should be checking for new data at least once an hour. Vault is simply passing this information along.


the one below it should be my.is_admin too right?
line 214


BTW, IMU in cleanflight also works with X being forward, Y being right.


Also:

- adding some comments to generatePreferredSearchOrder would be nice.

- it looks like this:
```
       int i = 0;
       int flag = 1;
       while (iSearch != mMaxSearchBits && i <= mMaxSearchBits) {
           if (!flagAssigned.contains(flag) && (flag & SEARCH_ALL) != 0) {
               listResult[iSearch] = flag;
               iSearch++;
           }
           flag <<= 1;
           i++;
       }
```
is adding all search providers not already in the list. Is that correct and what you intended?


what is `this` referring too?


Good catch - fixed!


This fixes SleepyTrousers/EnderIO#2724


@sowjanya143  here, https://github.com/johnny5550822/ezinstall


if (model == removedBuildings[i].r_Model || model == -1) is to ensure compatibility with how RemoveBuildingForPlayer() now operates in SA-MP 0.3.7
https://wiki.sa-mp.com/wiki/RemoveBuildingForPlayer


change elif to else


Very minor quibble:

- the name 'flag' is usually used for binary values; 'code', 'id' of something else might be more suitable for the provider number/id/code


Since this is a class, it should be outside of the server function IMO


Bad indentation.


1786_python_bindings_patch (elainethale) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2282 of 2341 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.48%25-yellow.svg)


why don't you say `this.players = [].slice.call(arguments)`?


Why do you need to pass options?  Shouldn't the default cover this?


Technically, should have: `".uuid="+ ConfigManager.main.Table_Players +".uuid GROUP BY "`


Not working on Android 4.4, 5.1
Working on 4.2.2


Fagmaster


I can pass null. There is no method that doesn't take an argument (since I removed it above).


1786_python_bindings_patch (elainethale) - Win64-Windows-7-VisualStudio-12: OK (2303 of 2341 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.38%25-yellow.svg)


Only two differences in the mentioned MCU's: flash and RAM size. Code should work on L151C8 without any modifications.
This USB example had been taken from the SPL library and its have one significant imperfection - with enabled code optimization (-O1, -O2, etc.) the MCU will stuck in the USB IRQ handler. If you compiled this code with optimization, try to disable it. If not - there is next question: what means "virtual com port doesn't shown up"? The USB device appears in system, but not recognized or system doesn't see device at all?
PS: code, ported from the CubeMX, works with optimizations enabled. But still lack any functionality except a simple loobpack.


Done


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1275 of 1275 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Wouldn't socketio rooms be more suited to this task?
http://socket.io/docs/rooms-and-namespaces/#rooms
we could create a room for each match and just emit to that room


We really shouldn't change the public API, can you overload the method and call the two argument version with a default NONE or null parameter as appropriate?


I'm aware of all that. I was hoping we could address my concern directly which is that it is bad practice.


What's up with using `site.baseurl` so much?


1786_python_bindings_patch (elainethale) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Update Language PT
correct error


Can you help me understand why it's bad practice to use a class abstraction provided by bootstrap?


hello


Extreme future proofing for v5 when v4 docs will be available at getbootstrap.com/4.0.0 but besides that most of Mark's links had it so I just updated the rest accordingly.


awesome! :+1: :+1: :+1:


awesome, thanks!


This is fine. Please submit a pull request.


Reverted these changes and updated the PR.


spelling: accidently


Spurious change?


Ok! Maybe I understood wrong, sorry. There is a patch file attached in Jira for you. I have created the account. Is it necessary to reply the comment or insert another comment?


I made a change to fix this in the next version. Thanks!


elsewhere; (replace comma with semi-colon)


Would make it easier to remove the other API call at a later point. Can remove it though. Done.


spelling: separate


spelling: guidelines


I forgot about that. I left it there in case the method I was using didn't work. My next step was to try resource_bundles for the pod. I would have needed this code for that. I could probably remove it now that we have a working solution.


reasoning or reasons


"Closes #xyz"


Yes on both lines


On second thought, I will leave it there. The cocoapods documentation recommends implementing resource_bundles, which I will do at some stage. Then I will just uncomment it.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 378](https://teamcity.labkey.org/viewLog.html?buildId=267670&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:07
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


what's the differentiation between getActivity() and getContext()?


資格って始まり年と終わり年いります？


This code:

```
       int i = 0;
       int flag = 1;
       while (iSearch != mMaxSearchBits && i <= mMaxSearchBits) {
           if (!flagAssigned.contains(flag) && (flag & SEARCH_ALL) != 0) {
               listResult[iSearch] = flag;
               iSearch++;
           }
           flag <<= 1;
           i++;
       }
```
adds searchProviders to the list in numeric order, assuming that they are all powers of 2 -- which is true, and likely to remain true -- but ISTM a better approach would be to add the missing ones in the 'default' search order, so I would do something like:

```
       int i = 0;
       int flag = 1;
       for(int providerId: mDefaultSearchOrder) {
           if (!flagAssigned.contains(providerId) ) {
               listResult[iSearch] = providerId;
               iSearch++;
           }
       }
```


@boucher Not at all. Please go ahead and submit them as PRs. Thanks.


@boucher sorry about the delay. I though I replied you in the afternoon, but the message somehow was not sent out.


BioCircos.js is an open source interactive Javascript library which provides an easy way to interactive display biological data on the web. It implements a raster-based SVG visualization using the open source Javascript framework D3.js. Circos.js is multiplatform and works in all major internet browsers (Internet Explorer, Mozilla Firefox, Google Chrome, Safari, Opera). Its speed is determined by the client’s hardware and internet browser. For smoothest user experience, we recommend Google Chrome.


> detail not because the interface contract guarantees it.

A valid point.  How would you set up an interface contract to guarantee it?


Eléggé :)


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-70.97%25-red.svg)


@csurf
Actually, after your comment I re-checked how IMU code works and found that I got Y-axis (East) reversed! Fixed and will test soon.


この辺、頑張って `std::copy` でバイナリデータを読み取っているが、もっとなんかいい方法はないものか？
D言語に変換してみたさもある


Thanks for submitting the pull request. This issue has been addressed by our internal repo and the function now actually returns ESIF_OK. When we update the github master branch next time you should see this fix.


@creesch any idea why I had to add the spaces before and after 'search' to make it look not shitty?


ここはこのままではデータが読めていなかった
`char*` で読みだしてるけど、途中にfloatのデータがあって、`0x00`が入ってるので無視されてた。


Generally speaking:

* It clutters the template (like inline styles); and
* Mixes content with presentation; and
* They can't be overridden (like inline styles. You _can_ override them with higher specificity, but it would be silly to have `text-center` on the template that has been overridden in CSS... which is almost as bad as having an inline style overridden with `!important`); and
* For our uncached HTML pages it is more data to send to the user on each page load (same with inline styles)

The above is basically just a summary of the top 5 answers from: http://stackoverflow.com/questions/2612483/whats-so-bad-about-in-line-css .

Specifically to OAE, for example, we do require copying of templates in order to implement re-usable components, so those text-center's get copied everywhere. If we ever wanted to restyle a component, we'd have to wade through them all and change each one -- these are problems having separate style-sheets solves.

It's also a pain to think that when I've written my template and I start styling, I have to jump to the template to apply a `text-center class instead of just putting it with the rest of the styles.


You wrote these functions ! ;)


To finish on a more positive note: FWIW, I am impressed that you integrated your changes so well into out existing app style.


I'm thinking about a potential corner case where if we land during a GPS glitch it can be switched into loiter and armed within the 5 second window. In practice the position and velocity innovations used by the glitch detector collapse to zero when the vehicle disarms, but If we have glitch event just prior to landing, they stay high for long enough to make the user wait a few seconds for the condition to clear which is a good thing to do.

I would recommend we AND gpsAccuracyGood with the other checks in the  !vehicleArmed condition, e.g.:

.... || (!vehicleArmed && usingInFlight && (imuSampleTime_ms - timeAtDisarm_ms) < 5000 && gpsAccuracyGood);


fixes the issue of final objs that can only be completed by vehicles getting proper scoring for the pilot.


what is this?


hmmm?


Fixes #xyz closes the issue automatically when the pull request is merged in.


Good


1), The context of makeToast should be {android.app.Application}  or {android.app.Activity} object.
http://developer.android.com/guide/topics/ui/notifiers/toasts.html
2),  In shared mode, I am not sure if the getContext is of type  {android.app.Application}/{android.app.Activity} or some Context we defined.

So to be sure, getActivity is the better choice here.


WTF.. What a Terrible Failure.


[Relevant issue](https://github.com/laumann/compiletest-rs/issues/25).

The tests *do* pass on my 64bit machine if I remove the 32bit part. But I'd be curious to see the test results on a 32bit machine.


PluginZoneInitialization2 (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.85%25-red.svg)


1774_add_misc_objects (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Not sure how we missed this.  :-/


圆头像旋转效果。


the struggle is awwdorable. thanks!


Should we keep the `if from_nbits != 0`? (rationale [here](https://github.com/Manishearth/rust-clippy/pull/208#discussion_r37590683))


o be 44 ze


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.97%25-red.svg)


Yea but technically, if you wanted to remove all buildings all you need to do is just not use the `CA_Init` function. Or perhaps if `-1` was used before `CA_Init` you could just terminate before loading the objects in `CA_Init`.


lol


This commit broke the build on windows. I pushed a probable fix.

http://104.154.46.123:8010/builders/win-64-trunk/builds/4/steps/Build%20Halide%20Debug/logs/stdio


I think we can safely assume no string literal (that's what this is about right?) will ever be 2^32 chars long, much less 2^64, right?


forgot to put this part in the else


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1275 of 1275 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


convert_new_coils_modelobjectlist (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


` ./git for-each-ref --format 'outside align %(align:60,left)foo %(refname:short) bar%(end)' --shell | head -n1
outside align 'foo allow-unknown-type bar                                  '`

Seems to be working for me


Will add that


Closes #81.


This works similar to a while loop except that when it's done looping it returns the Iterator where it left off.


I keep looking at this and thinking I ought to make the Eclipse command set this good.


yes


Here the iteration continues where the while() call() construct left off.


A bị điên nặng

2015-08-20 14:56 GMT+07:00 vanthinh91 <notifications@github.com>:

> khung
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/giang11t1/HGiang/commit/0df1b6bfc7ca6c5c23cc1a60748cfc8104629bf7#commitcomment-12801675>
> .
>


yazım hatasını düzeltim ahmetcim


adasdasd


This does not seem to include any new code. Oh well.


형 이게 min이 prime number 아닐 때도 index = index/min 해도 돼요?


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


hell yeah, thanks for this!


I'm merging this to the master branch.  We need to make sure that we get the file in too.


请问一下在使用卷积网络时 ，models/image_net_mean.bin如何得到，需要自己生成吗，格式如何


The lab notebook section is discipline specific (they aren't really a thing in the social sciences). Can you alter the language to make it a more generalizable point? So, use lab notebooks as an example of a process that might already be happening, but why that can still creates problems, as well as briefly describe what you mean by a lab notebook for those who aren't as familiar with the amout of detail they contain?


Looks good to me


LGTM.


also moved files to corresponding folders


@nick22891 as discussed, we could combine the parseDate function with the isActive function.


98318570_RemoveRadianceCheckbox (macumber) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-78.96%25-red.svg)


nice work! Although, it would have been nicer to separate removing concurrency kit in its own commit to make code reviewing easier.


stole all your stuff lol


Thanks @alaphoid, plainly, I failed to test for that case, my apologies. Will get onto it.


In most all of these cases, we will want the owner and group to be 'root'. This is consistent with what we are doing elsewhere. These shouldn't need to change.