dasdasdas


copying files in the source directories is probably not a good idea. i suggest only moving files around inside test/.
(and as mentioned above i would just define a new profile, and avoid constructing lua code synthetically)


I changed this to have a height of 6 text lines, which should be the maximum number of lines a debug info can have. (If not, it'll just increase the height of the widget temporarily like it does now, no big deal.)


I love `git blame`, it totally answered my question ("why are these 3 lines needed, what would happen if you removed them?") without me having to ask it. :)


This is already removed in latest code. Thank You.


What I really need from both Sergey and Robert is a proposal of how to provide the required functionality in a way that also provides a solid enough security posture - not providing template support is a non starter


I have added you on Skype. When you have time let me know and we can schedule a meeting. Thank you in advance.


Awesome. Fixed indeed! Thanks for the quick response.


isn't the word datum used for lat and lon coordinates as well as for altitude? would it be clearer to use 'altitude' or 'elevation'?


It all works here for me…

On Fri, Aug 21, 2015 at 3:31 PM, roblanf <notifications@github.com> wrote:

> updated test prot_hcluster3
> RAxML didn’t like one of the partitions. The results.bin may need to be
> updated here. @brettc can you check this?
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/brettc/partitionfinder/commit/1e980fbf4c90b1e80945778503f8cebd9f616624


Handy! :)


I had ```make quick-check``` working fine. Then I tried to update lme4 to version 10 and got this:
```
glmTMB> glmmTMB(Reaction ~ Days + (1|Subject), sleepstudy)
Error: evaluation nested too deeply: infinite recursion / options(expressions=)?
Execution halted
make: *** [ex-test] Error 1
```


Let's get rid of these cout statements - we don't want them to print in the test outputs.  If you want it to print something when they fail, googletest has a [way to do that](https://code.google.com/p/googletest/wiki/AdvancedGuide#Teaching_Google_Test_How_to_Print_Your_Values).


Would it be better to expect both to be true here?


#4858-VRF-IO-Ref-documentation-shows-incorrect-values-for-schedule-priority-control (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1800 of 1800 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


git/git
On 22 Aug 2015 01:28, "Lars Moelleken" <notifications@github.com> wrote:

> git init --template=[image: :heart:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/git/git/commit/e83c5163316f89bfbde7d9ab23ca2e25604af290#commitcomment-12833858>
> .
>


OK cool


Add comment second


Ok then :)


#4858-VRF-IO-Ref-documentation-shows-incorrect-values-for-schedule-priority-control (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@mcostalba , @joergoster I've lowered the priority of this one to -1 so that the other one is tested first.
Pls confirm if this is the patch which gives worse bench results.


Looks good!


can you try it something like this
```
$category_layout = $categoryParams->get('category_layout','');
if(!empty($category_layout)){
```


SO HARD :P


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1795 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


initial throughput looks like around ~150k-200k events/sec on a macbook air, running zookeeper & kafka locally


from where i can get this plugin?


For example - will leveraging Angular's whitelist based $sanitize service https://docs.angularjs.org/api/ngSanitize/service/$sanitize like this:

el.innerHTML = $sanitize(content.innerText);

suffice?


Suggest write this code as below format:
```C++
if (row < 1 || col > (this->MapSize - 1)) {
    return;
}
```


[
  {
    "level": 1,
    "tasks": [
      {
        "label": "SSN + ID Card",
        "description": "You have to have a valid social security card and ID card. You can verify with any staff. If you've submitted this at intake, this will be counted.",
      },
      {
        "label": "Typing Assessment",
        "description": "Complete a typing assessment at www.Typingtest.com in the computer lab. \n Once on the website, seleect English as the language and choose the 3-minute assessment. Choose any story option. Write the results below. Print results and place in Task List Drop Box (located behind Computer Lab Instructors desk).",
        "onApprovalRequest": {
          "inputs": [
            {
              "label": "First assessment WPM",
              "type": "text"
            }
          ]
        }
      },
      {
        "label": "Professional E-mail",
        "description": "Set up a professional e-mail account. If you already have an e-mail account, please follow the listed instructions for how to verify by sending an email. Ex: my prescious3298@yahoo.com is NOT professional. Print out a blank email you've sent to a Rubicon staff member with the subject Test Message."
      },
      {
        "label": "Current Schedule",
        "description": "Put together a weekly schedule. Use a blank “Current Schedule” document and fill in every time slot. Verify all time slots are filled in. Make a copy of the schedule for yourself and keep the original. Place copy in Task List Drop Box (located behind Computer Lab Instructors desk)."
      },
      {
        "label": "The Number",
        "description": "What’s your sufficiency number? How much do you have to earn to comfortably take care of you and your family? Complete this assessment at www.insightcced.org/calculator.html Please print 2 copies. Keep one for yourself and place the other in Task List Drop Box (located behind Computer Lab Instructors desk). "
      },
      {
        "label": "Complete Master Application",
        "description": "Complete a master application using the blank Master Schedule document. It must be filled out completely or you will not get credit. This is a valuable job search tool and your toughest assignment. Please make a copy and keep the original. Please place copy in Task List Drop Box (located behind Computer Lab Instructors desk)."
      },
    ]
  },
  {
    "level": 2,
    "tasks": [
    {
        "label": "Top 10 Goals",
        "description": "Complete Goals Worksheet. List at least 7 goals you want to accomplish in the next year. Make a copy of thee goals worksheet and you keep the original. Place copy in Task List Drop Box (located behind Computer Lab Instructors desk).",
      },
      {
        "label": "16 Personalities Assessment",
        "bonus": 75,
        "description": "Go to 16personalities.com and complete the free assessment. This is an extended version of the Brain Typing Questionnaire. Enter your 4 letters and send your results to your email. Write your results below and print a copy of your results and place this in the Task List Drop Box (located behind Computer Lab Instructors desk).",
        "onApprovalRequest": {
          "input": {
            "label": "Personality Type Letters",
            "type": "text"
          }
        }
      },
      {
        "label": "Barriers Assessment",
        "description": "Complete the Barriers Assessment. Instructions are located on the worksheet.List one barrier you can address right NOW. Then write out 2 action steps you can take today or this week. Keep the original and make a copy. Please place copy in Task List Drop Box (located behind Computer Lab Instructors desk).",
        "onApprovalRequest": {
          "inputs": [
            {
              "label": "Barrier",
              "type": "text"
            }
          ]
        }
      },
      {
        "label": "Increase Typing Speed by 25%",
        "description": "Complete a second typing assessment at www.Typingtest.com in the computer lab. \n Once on the website, seleect English as the language and choose the 3-minute assessment. Choose any story option. Print results and make sure you have improved by at least 25% from your first typing test in Level 1. Write your results below and place test results in Task List Drop Box (located behind Computer Lab Instructors desk).",
        "onApprovalRequest": {
         "inputs": [
            {
              "label": "First Typing Assessment WPM",
              "type": "text"
            },
            {
              "label": "Second Typing Assessment WPM",
              "type": "text"
            }
          ]
        }
      },
     {
        "label": "Email Practice Session 1",
        "description": "You must be able to “download” a file, “attach” a file to an e-mail, and send that e-mail to
        Rasheeda@rubiconprograms.org. Please see staff member if you need additional instructions. Please print a copy of the email sent
        and make sure you've  attached a file and sent it with an appropriate message."
      },
     {
        "label": "Complete Resume 1st Draft",
        "description": "Complete your first resume. Please ask Computer Lab Coordinator or Rubicon staff member for resume templates. It must be in digital format to get credit.
        Send the digitial copy of your resume to rasheedad@rubiconprograms.org. Please print a copy and place copy in Task List Drop Box (located behind Computer Lab Instructors desk)."
      },
      {
        "label": "Interview Prep Worksheet",
        "description": "Complete the Interview Prep Worksheet. Instructions are located on the worksheet. Please make a copy and keep the original. Please place copy in Task List Drop Box (located behind Computer Lab Instructors desk)."
      },
      {
        "label": "Future Career Research",
        "description": "Research a future career at www.onetonline.org. You must complete the Future Career Research worksheet.
          Please make a copy and keep the original. Please place copy in Task List Drop Box (located behind Computer Lab Instructors desk)."
      },
    ]
  },
  {
    "level": 3,
    "tasks": [
    {
        "label": "Rat Park",
        "bonus": 150,
        "description": "Read comic found on Stuart McMillen’s website. On the surface, it covers addiction, but there’s a deeper message. Use Google to find it. Complete Side Project worksheet. Make a copy of the Side Project Worksheet. Keep the original and place copy in Task List Drop Box (located behind Computer Lab Instructors desk).",
      },
    {
        "label": "Increase Typing Speed by 50%",
        "bonus": 500,
        "description": "Retake the typing test. List your Level 1 and 2 results first. Print results and place in Task List Drop Box (located behind Computer Lab Instructors desk).",
         "onApprovalRequest": {
         "inputs": [
            {
              "label": "First Typing Assessment WPM",
              "type": "text"
            },
            {
              "label": "Second Typing Assessment WPM",
              "type": "text"
            }
            {
              "label": "Third Typing Assessment WPM",
              "type": "text"
            }
          ]
        }
      },
   {
        "label": "Read The 5 Chimps Report",
        "bonus": 400,
        "description": "Google “5 chimps report pdf”, download the PDF, and read it in its entirety. You can read it in the computer lab or download to your phone. Ask a staff member for help if you need it. Complete Side Project worksheet. Make a copy of the Side Project Worksheet. Keep the original and place copy in Task List Drop Box (located behind Computer Lab Instructors desk).",
      },
   {
        "label": "The Cain Conversation with Gary Vaynerchuk",
        "bonus": 300,
        "description": "Google “gary cain conversation” – the video is just over 40 minutes long. Please complete the Side Project worksheet. Make a copy of the Side Project Worksheet. Keep the original and place copy in Task List Drop Box (located behind Computer Lab Instructors desk).",
      },
      {
        "label": "Credit Score",
        "bonus": 250,
        "description": "You can go to www.quizzle.com or wwww.annualcreditreport.com. Please see a staff member for assistance and verification. Make a copy of the online credit score. Keep the original and place copy in Task List Drop Box (located behind Computer Lab Instructors desk).",
      },
]


CoilHeatingDXMultiSpeed-adjustments (kbenne) - i386-Windows-7-VisualStudio-12: OK (2303 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.29%25-yellow.svg)


OK for now. It'd be great if we could move ``MAX_WORKERS`` to config/settings.


muh ctrl+H too stronk


ふーん


Fixes #44


I expected output from `python dev/change_version.py -p -s false . 0.12.0-incubating` to produce pom's without `-SNAPSHOT`, but the `-SNAPSHOT` remains. I believe it's a bug from this line (because the props file is not changed according to `is_snapshot` when `pom_only`.

Why do we have to read whether this is a snapshot version from the file? Can't we just append `-SNAPSHOT` if  `is_snapshot`?


Range initializer is not public.
Range.nsdict is a private property.


Indeed It is a mistake, probably when I tried some tests on operators


I think we should have some discussion on the level part.


:bomb: )


Uhm.... why creating the map on the heap?
why not just:
QMap<QString, QString> npc_values;


What's wrong?


`didReceiveMemoryWarning()` はとくになにもしてないので、overrideする必要はないかなあと思います:eyes:


Ok, thank you for your comments !


へー


added some breaks after the copy because when you scroll down it was crashing into the left sidebar. I don't think this the best solution, but for now it works and the type is not crashing.


修改错别字及其他


I added my code as a comment - but I'll try to see if I can learn how to "commit" vs. just leaving this as comments. Let me know if you see the updated version from my end that includes levels 1-3.

Thanks!


:sos:


Actually - i hardly think what I did even remotely classifies as code... so I added my json "stuff" as a comment above -


Micropostになるとnameじゃなくてcontentsとかtextとかなにかポストの内容のような名前にしたほうがわかりやすいなあという話をしたmemo


try making the `path: "/admin/plugins"`


Нужен поиск не каждого союзника подряд, а у другого союзника союзника, иначе миллион вариантов


91977808_LBNL_NewVRFModel (rongpengzhang) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-60.66%25-red.svg)


does it make sense to have two distinct icons for this?
what about having a single button with drop dow actions (list the select icon)?


Should this be in this commit or is it a leftover from the attempt to support `LIKE`?


Ping! Experimenting with a line comment...


ここも必要ないね！


Most of problem in this commit are still in the format:
- White-space between in binary operands:
```C++
i=1;
```
shall be
```C++
 i = 1
```

- Brace shall be used for a code block:
```C++
if (condition)
    return false;

for (loop)
{
    loop_elements();
}

int foo() {
    //TODO
}
```
shall be
```C++
if (condition) {
    return false;
}

for (loop) {
    loop_elements();
}

int foo()
{
    //TODO
}
```
- Indention uses 4 spaces in C/C++ programming:
```C++
int bar()
{
        //Here is 8 spaces or a tab
}
```
Shall be
```C++
int bar()
{
    //Here is a 4 spaces indent
}
```
- Naming issue, the member variable is usually given `m_` prefix, and `hhg` in test case does not make sense, use `game` to replace it.


これも必要ない〜！


@bmuschko well, the URL in itself doesn't have any content since the isn't any "raw content" for a directory, but if you append `jshint-rhino/jshint-rhino/jshint-rhino-2.1.11.js` according to the pattern (`[organization]/[module]/[module]-[revision](.[classifier]).[ext]`) you get https://raw.githubusercontent.com/bmuschko/gradle-in-action-source/master/chapter11/listing_11_06-07-todo-js-code-quality/ivy-repo/jshint-rhino/jshint-rhino/jshint-rhino-2.1.11.js, which is the URL to the JS file.

If you append the same string to the old URL you get https://github.com/bmuschko/gradle-in-action-source/blob/master/chapter11/listing_11_06-07-todo-js-code-quality/ivy-repo/jshint-rhino/jshint-rhino/jshint-rhino-2.1.11.js, which is the HTML file displaying the source code, which isn't much use for Gradle.


* when switching from standard add feature to curve tools, the rubber bands remains
![image](https://cloud.githubusercontent.com/assets/127259/9459814/0214f184-4b00-11e5-8251-013f6c793a9a.png)

* I would have a rubberband following the mouse even when first point of arc is not digitized otherwise we are not sure we are in the digitize mode. It's even more obvious when switching from standard add feature the arc tools.

* right click should cancel and not finishing the arc. It should cancel the arc so you could start again from last point.


`// MARK: - View Events`
とかいれてあげるとわかりやすいかも〜！


Den lades till då det tidigare inte fungerade med POST. Har ändrat lite i koden nu så den routen kan tas bort.


You shouldn't actually have to cast the `world` to `org.spongepowered.api.world.World` since it's going to be an instance of `World` at runtime anyways and `Cause` only checks instanceof.


@ladydanger do you need to add another `admin_route` above?


Something like this?
```
add_admin_route 'ad_plugin.title', 'ad-plugin'
add_admin_route 'ad_plugin.title', 'ad-plugin/dfp'

 Discourse::Application.routes.append do
  get '/admin/plugins/ad-plugin' => 'admin/plugins#index'
  get '/admin/plugins/ad-plugin/dfp' => '/admin/plugins/ad-plugin#dfp'
end
```


4590-VRF-defrost-power-calculation-problems (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1276 of 1276 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.97%25-green.svg)


Please do not replace the tabs by spaces.
I use notepad2-mod for editing
Could you redo this patch?


org.intellij.erlang.psi.ErlangType does not allow to do it more elegant. I am thinking about it, but now I have no idea how to do it clear and simple. It would be great if you will suggest something.


The GEO CODE for Upazilla is 2 digit code issued by Bangladesh Bureau of Statistics (BBS), but in this SQL Script it is 3 digit. Please clarify if it is the actual Geo-Code Information


i dont think this is tested, the last change now involves 2 times YouLess.
I will make the change here locally.
From the source i see you need address/port/password


I think this is already covered by `$?.exitstatus == 0`


Why you mess with priorities? FWIK it was supposed you just approve the
tests...or I miss something?

On Tue, Aug 25, 2015 at 7:44 AM, ajithcj <notifications@github.com> wrote:

> @mcostalba <https://github.com/mcostalba> , @joergoster
> <https://github.com/joergoster> I've lowered the priority of this one to
> -1 so that the other one is tested first.
> Pls confirm if this is the patch which gives worse bench results.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mcostalba/Stockfish/commit/0e21835dda2c70854fa1700dda69e667727cbfa5#commitcomment-12872526>
> .
>


As discussed in #122, please add a unit-test for that.

You can also mention this `none` in doc/gitolite.rst.

Thanks,


What's the 5.58 from? I'm guessing 5 + 7/12ths years of data?


The codes are wrong, according to The GEO CODE issued by Bangladesh Bureau of Statistics (BBS) for division are as follows,
10-Barisal Division
20-Chittagong Division
30-Dhaka Division
40-Khulna Division
50-Rajshahi Division
55-Rangpur Division
60-Sylhet Division
(source: http://www.bbs.gov.bd/PageWebMenuContent.aspx?MenuKey=151)


@ladydanger  Scratch that... take this for a spin..

```
Discourse::Application.routes.append do
  get '/admin/plugins/ad-plugin' => 'admin/plugins#index'
  get '/admin/plugins/ad-plugin/dfp' => '/admin/plugins/ad-plugin#index'
end
```

I was just reading @eviltrout's post https://meta.discourse.org/t/beginners-guide-to-creating-discourse-plugins-part-5-admin-interfaces/31761 it seems that we just need to point that url to the default plugin page.

In theory when the page actually loads (from a full page refresh) the ember router will read `/admin/plugins/ad-plugin/dfp` and map it correctly to your plugin's client side route.


sadasdasd
s
da
sd
as
das
das


I checked, and without added this in the hardware controller, all is working well.
Do not think we need this patch correct?


91977808_LBNL_NewVRFModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1801 of 1805 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


You mean you want both these tests to run simultaneously???
http://tests.stockfishchess.org/tests/view/55db7bc20ebc595da9433914
http://tests.stockfishchess.org/tests/view/55db7bb90ebc595da9433912


@ajithcj  Correct, this is the patch which gives worse results for me with 7 threads. Nevertheless, I'd recommend to let it running just like the other one. If the bad bench results also translate into worse elo performance, which may or may not be the case, it will fail rather quickly, I guess.


Sure


ss


@mcostalba, running three 7 thread tests simultaneously seems very inefficient.
You are free to modify to 0.


missing space between thereforecurrently


This looks great! I was thinking about cmdlets resetting fields to standard values but never got around to doing it. I think you should push it :)


true, but also to be considered sending the heap dump to third parties for analysis. it could expose passwords.


Whoops, that's embarrassing :D fixed in https://github.com/k9mail/k-9/commit/16bd8a53ed967a113c3d664a95597b6e20b995d5


I am running on Ubuntu linux 14.04. Back at version 8.04LTS Ubuntu [changed the default shell](https://wiki.ubuntu.com/DashAsBinSh) that /bin/sh links to to dash. The default user shell in Ubuntu remains bash.

It appears that in Mac OSX, Panther and  later, the default shell is bash but before that it was tcsh.

In the article [bash on Mac OS X](http://www.macdevcenter.com/pub/a/mac/2004/02/24/bash.html) they compare the size of the binaries and conclude that /bin/sh and /bin/bash are the same. See image below.
![image](https://cloud.githubusercontent.com/assets/864159/9459896/0209aaee-4b01-11e5-8389-6f2b5a17fb69.png)

I think that if this project is to be useable across multiple OSes then the switch to bash (if that is what you have been writing your shell scripts in on OSx) will avoid the problems of other OS pointing /bin/sh to some other shell, as this will force the scripts to be run with bash.

A search of the git repo shows the following:
````sh
[/tmp/aaa-tmp/drude] (master) $ find . -type f -print | xargs     grep "/bin/sh"
./install-drude.sh:#!/bin/sh
./install-dsh.sh:#!/bin/sh
./circle.yml:    - sudo ln -sf /bin/bash /bin/sh
./.git/hooks/commit-msg.sample:#!/bin/sh
./.git/hooks/prepare-commit-msg.sample:#!/bin/sh
./.git/hooks/pre-applypatch.sample:#!/bin/sh
./.git/hooks/pre-push.sample:#!/bin/sh
./.git/hooks/applypatch-msg.sample:#!/bin/sh
./.git/hooks/update.sample:#!/bin/sh
./.git/hooks/pre-rebase.sample:#!/bin/sh
./.git/hooks/pre-commit.sample:#!/bin/sh
./.git/hooks/post-update.sample:#!/bin/sh
./.docker/bin/dsh:#!/bin/sh
````
comxd has switched to [use #!/bin/bash](https://github.com/comxd/drude/commit/8ca28f5a7dbf17f05254a2b38d10329d8c7baaf1) for install-dsh.sh

Would it be possible to change the scripts (other than the .git/hooks/ scripts) over to use  /bin/bash so that this project will function properly on Ubuntu Linux and possibly others as well?


I have already modified to zero, but please don't touch priorities unless
there is a specific reason.

If you think scheduling algorithm should be improved then send a patch to
improve it. Priorities are not assumed to be knobs to tweak on a case by
case basis.

Approver should respect the submitted test and do not touch it.

On Tue, Aug 25, 2015 at 8:28 AM, ajithcj <notifications@github.com> wrote:

> @mcostalba <https://github.com/mcostalba>, running three 7 thread tests
> simultaneously seems very inefficient.
> You are free to modify to 0.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mcostalba/Stockfish/commit/0e21835dda2c70854fa1700dda69e667727cbfa5#commitcomment-12872928>
> .
>


 还是不想用静态库QAQ
都挤在exe里以后自动更新也不方便啊
至于Mac 0.0。。。动态无力


Made the changes here locally


This is just a repository for random thoughts.


Done.


Поиск - это форма с тегом input


File System run async, function return undefined.


You might have introduced a bug here -- aren't hooks still supposed to be in `$SRC/bin/hooks/`?


deleted


@Montellese I'm rebasing RetroPlayer on 15.1 and I'm backporting this PR, but `$<TARGET_FILE:${target}>` isn't getting processed correctly. Does this PR rely on another?


Yes, it's just so that I could say from 2009 onward....

On Tuesday, August 25, 2015, jmarshallnz <notifications@github.com> wrote:

> What's the 5.58 from? I'm guessing 5 + 7/12ths years of data?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dtsh2/measles/commit/2315567790174c1a7fff5e04a0b96115f3b3450d#commitcomment-12872862>
> .
>


i have a question. can some one give me a anwser?
can zfs compile and install in debain 7.8  i386?


Если middle-part - это центровщик, то используй уже имеющийся класс .container


I'd definitely move this preamble to a separate file and source it, instead of copying it over to every single file.


Fixed


@oliverguenther I resolved this conflict manually. Please check the resolution.


Computer Science and enginnering


添加文件


That's correct. The `to_time` was superfluous.


这个我们是不是不需要强调 30 秒间隔了，改成 1 秒对用户来说应该没有延迟了


Ping ;)


Thanks for fixing and your hint!


ห้ามแก้ครับ


Nit: s/at/_/


Nit: Invalid _


101286574_Issue937 (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.36%25-red.svg)


ah, that's unfortunate.


CoilHeatingDXMultiSpeed-adjustments (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2311 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.63%25-yellow.svg)


Perhaps instead of

```
inline bool compatible(SEXP x) {
            if( !Rf_inherits(x, "POSIXct" ) ) return false ;
            SEXP xtz = Rf_getAttrib(x, Rf_install("tzone") ) ;

            if( Rf_isNull(tz) ) {
                tz = xtz ;
                return true ;
            }

            if( Rf_isNull( xtz ) ) return false ;

            return STRING_ELT(tz, 0) == STRING_ELT(xtz, 0 ) ;
        }
```

we could just have :

```
inline bool compatible(SEXP x) {
            return Rf_inherits(x, "POSIXct" ) ;
        }
```

so that two `POSIXct` are compatible. And we have some other way to determine the `tzone` of the result, like what we do in joins.


.shop-descript можешь назначить для тега h2, идущего далее. А в этом div нет смысла. Ты блочный элемент вкладываешь в блочный.


asdasdas


s/are/is


.bottom-part - лишний элемент. Тег nav - является блочным элементом


Perhaps the message should have quotes around the regexp as well.


What version of cmake are you using? I already noticed that at least on Win32 there are several issues with different versions of CMek 2.8.x whereas CMake 3.x works fine. See my comment at https://github.com/xbmc/xbmc/pull/7570#issuecomment-129738126.


@mcostalba @ajithcj  Just one run for example

take 1
´´´
===========================
Total time (ms) : 79203
Nodes searched  : 633734714
Nodes/second    : 8001397
´´´

take 2
´´´
===========================
Total time (ms) : 90054
Nodes searched  : 637301960
Nodes/second    : 7076886
´´´

Of course, there are runs where both have similar ttd performance, but take 1 always has the better scaling, and very often also the better speedup. But unfortunately, that doesn't necessarily mean take 1 has the better elo performance ...


@RomanTsegelskyi, I though you have fixed this -- was it reverted in some of the past rebases?


no idea. fishtest bug.


no 'package' property makes an NPE


This comment shouldn't be here, it's not this code responsibility to know what labels are used. When you update `canStoryBeStaged` function in the future you'll certainly forget to reflect that change here.


You mean like this ?
````cpp
if ( parentScope && ( nullptr == varFrame ) )
````


В макете два слайда и два текста, каждый для своего слайда


I don't think output_armed_not_stabilizing() and output_armed_stabilizing() methods should have identical copied contents.  Surely it's better to have one calling the other.


Слайдер можешь пока оставить. На последующих вебинарах на примере слайдера для Nerds покажут как их верстать


嗯，这块关于间隔的我就去掉了，含糊一些


After this you will start to get multicast packets, right?

But the rxe_add_key() hasn't been called yet, so the group won't be found. Is that okay?


Any chance we could rename AP_MotorsHeli_Single to something that won't be confused with Single Copter?


Ahh, right. What about this ?
```
Powered by <a href=".*">Arastta
```


@mbernat Nope. The command used to build the executables is different now and it places everything into the same directory.


Maybe this should better be named "assertinvalid".


Please create a PR with this cleanup

karin & karin_windy need only
 # CONFIG_TOUCHSCREEN_CLEARPAD is not set
 CONFIG_TOUCHSCREEN_MAXIM_STI=y

those 2 lines should replace
 CONFIG_TOUCHSCREEN_CLEARPAD=y


Students/Ghiurau A. Alexandra Cristina/Assignment 3/src/javasmmr/zoowsome/controllers/Main.java

This is not a solution :))


Btw, can we rename the constructor to just `AssertEq`, for consistency?


Students/Ghiurau A. Alexandra Cristina/Assignment 3/src/javasmmr/zoowsome/models/animals/Bird.java

why comment this out?


What do these lines of code do?


Can you also adapt the README?


When the story is just tested, not reviewed (which is possible with PT), this function will return `Implemented`, which is actually not true. Are we sure this won't cause problems anywhere?

Of course, this just reflects the fact that PT doesn't follow JIRA review -> testing workflow (and I think we don't either, it was probably too restrictive). We probably don't want our general tracker-agnostic workflow be based on JIRA in the future.


I'm many years learning about core and db develop.. and searching for teacher's.  i have tried to follow mangos, tc and some other. and contribute there. but the colloquial language in the groups is terrible. and no one is helping other. and some years ago I found here a friendly atmosphere. in all groups are gone most of the "old" devs and many groups have died. here too. I certainly hope that someone maybe comes back. the hope dies last :-) :-)


@mbernat It's pretty hacky to source files relative to the script file. I also thought about sourcing a common file, but it's ugly. I can try, but I am not going to save much typing...


>>but please don't touch priorities unless there is a specific reason.
@mcostalba, well in this case there were a few reasons:
1. Three 7 threads in the framework would be inefficient
2. One of them has lower NPS reported earlier in the forum
3. There is another unapproved SMP test which is in the queue for 2 days


"[...] cast to a string it [...]" should be "[...] cast it to a string [...]".

Also, why `str` and not `toString`?


Got it. Thanks for the quick answer!


dsfnksdjfsd


101286574_Issue937 (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


死


cmake 3.3.1 worked. we should probably note this in a readme


I think setting the default to 1 would change the default behavior of the code and not be compatible with existing code anymore. Also a forever block wouldn't be possible anymore, unless select can already eat a None as interval in which case the if is not needed anyway.


Um, what?


@lasconic : this change is for MScoreText, but the dynamics use the mscore font. In fact, dynamics in scores are still unkerned...

I am working on moving the full kern table of the old version of mscore to the new version, so please don't bother.


This design indicates we would change regex converters for different objects. Why would we ever want that?


ROTOR_CONTROL_xxx should probably be an enum rather than a #define.  I know we've got both in the code but for new stuff at least using enums is safer because the compiler will do things like warn us if a switch statement is missing any members of the enum.


mind blown! Awesome work :)


Huh? Sourcing works without any problem in bash. Also, it's not about saving typing (that's just a pleasant side-effect), it's about keeping it maintainable. We're programmers, we don't have to copy&paste ;)


If the pulses were separated by enough time, there may be enough signal left to detect that.
148 What are the current demographic estimates for the Neanderthal/human populations?


If this is a user-facing message, and I think it is, we could write out "regex pattern" to "a regular expression pattern" here, for extra helpfulness.


This looks racy. Couldn't another thread call `rxe_mcast_drop_grp_element()` on the same `qp` and `grp`? Then you can call `list_del()` twice.


Ah, I see, you used to `cd` into that directory before.


hello


@kenichi ptal: https://github.com/igrigorik/http-2/pull/40


This looks like you did the modifications by hand/via regex.

We should run clang-tidy over the CMake code with the [ContainerSizeEmpty](https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/readability/ContainerSizeEmptyCheck.h) checker. Other checkers that the CMake code benefits from are: [ElseAfterReturn](https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/readability/ElseAfterReturnCheck.h), [RedundantStringCStr](https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/readability/RedundantStringCStrCheck.h), and [SimplifyBooleanExpr](https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/readability/SimplifyBooleanExprCheck.h).

We may need to wait for clang-tools-extra release 3.7.


What platform are you on? Theoretically these generators should work with CMake 2.8 (according to the documentation). If it's a platform-specific issue we should note it in a README otherwise we need to bump the
```
cmake_minimum_required(VERSION 2.8)
```
to a higher version (and bump the version of cmake we build with depends.


this one was ok ;)


@lacostej Agreed, there is a big room for improvements in that regard :+1:


I'm on windows 7


Thanks!

It's actually still got a few bugs to fix, but I'm pleased with it. If you have any feedback, let me know!


OK I'll have to give linux a try with a manual build sometime but on OSX AFAIK we use the cmake version (2.8.12) built with depends (see https://github.com/xbmc/xbmc/blob/master/tools/depends/native/cmake-native/Makefile) which seems to work fine which indicates that this is a win32 specific problem.


Is this an attempt to read the protocol part of the opcode? I think it would be better to use IB_OPCODE_RC/UD/... instead of magic numbers. That would require masking out the operation though.


Done. Please check.


By default the serializers can be easily overwritten. Docs: http://django-rest-auth.readthedocs.org/en/latest/configuration.html

My choices are partially based on specifications in http://jsonapi.org/ . The assumption is that you need to have a token by default (why login/register otherwise?). Combining two different objects in the same response is just confusing and against specs.

I hope this makes sense and the config can help you forward?


Warnings that occur due to outside packets should be ratelimited.


fdhusdgfuifsd


Hello,Excellent work.  I am learning PCA and Python by myself, and I think I got some trouble when I learning your code, I hope you can give me more help on how to use it. After I put my images into "like" and "dislike" file,run the visuals.py in the terminal just like what you said in the readme file. It turned out to

C:\Eigenstyle-master>python visuals.py
processing images...
(this takes a long time if you have a lot of images)
finding principal components...
Traceback (most recent call last):
  File "visuals.py", line 270, in <module>
    X = pca.fit_transform(data)
  File "C:\Python27\lib\site-packages\sklearn\decomposition\pca.py", line 653, i
n fit_transform
    X = self._fit(X)
  File "C:\Python27\lib\site-packages\sklearn\decomposition\pca.py", line 585, i
n _fit
    X = np.atleast_2d(as_float_array(X, copy=self.copy))
  File "C:\Python27\lib\site-packages\sklearn\utils\validation.py", line 95, in
as_float_array
    return X.astype(np.float32 if X.dtype == np.int32 else np.float64)
MemoryError

I am sorry, I was using 64 windows 8.1,and python 2.7. Is this the problem?
Thank you very much.


This commit is being reviewed as a part of review issue #55.


It's not that bad. I meant, you cannot simply use `source ./common`, because that won't work when you do `./circle_scripts/install.bash`, right? But anyway, implemented in 4af1833


OSX builds the add-on alright. System cmake version is 3.2.3, not sure which one the build is using


Leaving a comment.


Good stuff, for sure I'll let you know if I have any feedback. One of these days I'll study it. I liked the way you walked through the logic in the demo. Also btw, I found your retroactive data structures code -- I had previously thought of trying to implement those in the future since I hadn't seen any implementations, guess I'll be taking a look at your work instead.


This is bullshit. If it was programmed for speed the someone did a lousy job. There are plenty of things that could be made much faster. certainly if copying/filling halves the performance as you say.

coding for performance does not mean one cannot create readable code!


Will think about it ;-)


Have you tested it with Crashlytics? I've had problems with versions placeholders when using fabric.io plugin.


Class Icon needed Capitalization.


!blocker Maybe change `StoriesInDevelopment` to `ListReviewableStories`


CoilHeatingDXMultiSpeed-adjustments (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.23%25-red.svg)


You can just use `min`


You're meant to run the whole thing in GhcModT then It's just one level of either and you handle the outermost failure level separately.


Yes, I meant that we don't have a common content type. Instead mark all commands with 2 content types.


In stead of the copy-paste the 2nd and 3rd cases could be done like this:

case AP_MOTORS_HELI_RSC_MODE_SETPOINT:
case AP_MOTORS_HELI_RSC_MODE_THROTTLE_CURVE:
    // all the other stuff here


You should pretty print it with `gmeDoc` at least: http://hackage.haskell.org/package/ghc-mod/docs/Language-Haskell-GhcMod-Internal.html#v:gmeDoc


Also, you should have a helper function that increments the bad_pkey_cntr of a port (including the spinlock).


Ok, this killed my imac! Demand of storing all the results from call to lapply (ln 61) and with explanded parameter set used up all available memory!


コメントを書いておきます。

resucue しないと、id を指定した時にデータベースでユニーク制約に引っかかって例外が起こりました。（2回目以降のcreateで）


I did just this in #1342


Could there be a memory issue here? Usually ```keySlice := iterator.Key()``` and ```keySlice.Data()``` should be followed by ```keySlice.Free()```. This is not happening here. There's ```self.Key().Data()``` without any ```Free()```


dwqdqwdqw


It will move the keypoints mainly from coarse scale levels up to 3 pixels. This is still an experimental branch but that change corrected a bias in the conversion of the keypoints.


develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2301 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.21%25-yellow.svg)


Newest build (3.2.1-93~preciseppa1) seems to work for me.  Had to install the suitable UVM module (nvidia-331-updates-uvm in my case), which I did not have before.  Glad you resolved this and thanks for the hint.


@qnm I am sorry I thought it was for me. I asked for help and I was lead to this code...I run on windows 8.1 I do not code but, I do art/all things psychology. I want to do art for a job for awesome people/communities. I don't know what to do. I can't even check my email-I am actively being watched and hacked. I do not know what to do. I am so sorry. Do you know what I should do?


N[osdjgsjndvlksmcl;adk[csodvmlsk


Chmm, !blocker doesn't work for some reason...


There's a need to add python-dev to build pillow, or building throw an error as Python.h isn't on the system.


not use it any more


Just `$(dirname "$0")`...


Leaving another comment.


For this case to happen, qp_type(qp) needs to be IB_QPT_GSI, but the check above excludes it.


Sure, it's not as pretty as in normal languages. But if that's your argument, you shouldn't have used a different scripting language :P


!blocker Maybe change StoriesInDevelopment to ListReviewableStories


I don't really know how that works on OSX and Linux either. Maybe @wsnipex or @Memphiz can provide some insight into this.


CoilHeatingDXMultiSpeed-adjustments (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


We raise the exception caught.


// MAX7219, matrix driver
#include <LedControl.h>
#include <Button.h>

#define USE_DS1307_RTC
#define SET_TIME_BTN
#define ANI_MODE_KEY

#define PIN_MAX7219_DATA 5//16 //4
#define PIN_MAX7219_CLK  6//15 //3
#define PIN_MAX7219_LOAD 7//14 //2
LedControl lc = LedControl(PIN_MAX7219_DATA,
                           PIN_MAX7219_CLK,
                           PIN_MAX7219_LOAD,
                           1);

byte panel[8] = {0, };

// Fix shuffled row and column idx.
#define R0 4
#define R1 6
#define R2 2
#define R3 3
#define R4 7
#define C0 6
#define C1 1
#define C2 5
#define C3 0
#define C4 4
byte r_table[5] = {R0, R1, R2, R3, R4};
byte c_table[5] = {C0, C1, C2, C3, C4};

#define _P_ON(_R, _C) panel[_R] |= (1 << _C)
#define P_ON(_R, _C) _P_ON(R##_R, C##_C)
#define REFRESH_PANEL() \
  for (int i = 0; i < 8; i++) \
    lc.setRow(0, i, panel[i])

#define CLEAN_PANEL() \
  lc.clearDisplay(0); \
  memset(panel, 0x00, 8)

#ifdef USE_DS1307_RTC
// Date and time functions using a DS1307 RTC connected via I2C and Wire lib
#include <Wire.h>
#include "RTClib.h"
RTC_DS1307 RTC;
#else
void update_dummy_rtc(void);
#endif

unsigned long last_rtc_millis;

uint8_t curr_h, curr_m, curr_s;
void set_rtc(uint8_t, uint8_t, uint8_t);
void get_rtc(void);

unsigned long last_millis;
void show_time(int, int);
#define SHOW_CURR_TIME() show_time(curr_h, curr_m)

#define PIN_LED 13

int animation_mode = false;
int sp=0;
#define MAX_ROW  5
#define MAX_COL  5
#define MAX_BUFF_SIZE 40 //MAX_ROW*MAX_COL

int photo_no = 0;

void Animation(byte *buff, int index, int buff_sz)
{
  //byte *buff;
  int i, j;

  CLEAN_PANEL();
  for(i=0; i<MAX_ROW; i++){
      for(j=0; j<MAX_COL; j++) {
          if(buff[(i+index)%buff_sz] & (0x01 << j))
              _P_ON(r_table[i], c_table[(MAX_COL-1)-j]);
      }
  }
  REFRESH_PANEL();
}

void PictureMode()
{
  int i, j;

  CLEAN_PANEL();
  for(i=0; i<MAX_ROW; i++){
      for(j=0; j<MAX_COL; j++) {
        _P_ON(r_table[i], c_table[j]);
      }
  }
  REFRESH_PANEL();
}

#if 0
//=======================================================
// Func. Description
// Animate screen data to move horizontal direction
// Parameter :
//       - *buff : to display data buffer pointer
//       - index : buffer position to read
//       - buff_sz : size of buffer to read
//       - bit_pos : position of bit to display byte in horizontal mode.
//                   if animation mode is virtical direction, it must set to ZERO.
//                   valide range of value is 0 to MAX_COL-1
//
// Return value : RxBuff read position increament flag
//               true - increase read rx buff. position (sp++)
//               false - Hold sp
//=======================================================
boolean AnimationHorizon(byte *buff, int index, int buff_sz, int bit_pos)
{
  //byte *buff;
  int i, j, shift, next;

  CLEAN_PANEL();
  for(i=0; i<MAX_ROW; i++){
      for(j=0; j<MAX_COL; j++) {
          next = (j+bit_pos >= MAX_COL) ? 5 : 0;
          shift = (next==5) ? ((j+bit_pos)-MAX_COL) : j;
          if(buff[(i+index+next)%buff_sz] & (0x01 << (MAX_COL-1)-shift))
              _P_ON(r_table[i], c_table[j]);
      }
  }
  REFRESH_PANEL();
}
#endif

#define  ANI_CLEAR   0
#define  ANI_NORMAL  1 // Default Animation
#define  ANI_USER_V  2 // User Image Animation (vertical direction)
#define  ANI_USER_H  3 // User Image Animation (Horizontal direction)
#define  ANI_USER_F  4 // User Image Animation (Flash mode)
#define  ANI_INFO    5 // Weather Info Display
#define  ANI_DEMO    6 // Time Demo
#define  ANI_PICTURE 7 // Picture Mode

boolean picture_mode = false;

boolean AniModeSet(int mode)
{
    if(mode != ANI_PICTURE)
      picture_mode = false;
    animation_mode = mode;
    sp=0; // display position reset.
    Serial.print("AniMode = ");
    Serial.println(mode);
    return((mode==ANI_CLEAR) ? false:true);
}

#ifdef SET_TIME_BTN
#define PIN_BTN_UP 9
#define PIN_BTN_DN 8
#define LONGPRESS_CNT 20 //10

int btnUp_pressed_cnt = 0;
int btnDn_pressed_cnt = 0;

Button btnUp = Button(PIN_BTN_UP,PULLUP);
Button btnDn = Button(PIN_BTN_DN,PULLUP);

boolean flgReqSysTime = 0;

uint8_t Inc5Min(uint8_t time)
{
  if((time==2) || (time==3))
    return 3;
  else if((time==7) || (time==8))
    return 7;
  else
    return 5;
}

boolean button_chk(void)
{
  boolean change = false;

  // Button Up check
  if(btnUp.uniquePress()){
    btnUp_pressed_cnt = 0;

    if(animation_mode) {
      AniModeSet(ANI_CLEAR); // off animation_mode
      Serial.println("animode clear");
      return(true);
    }
    get_rtc();
    // Inc. Hour
    curr_h++;
    if(curr_h >= 24) curr_h = curr_h%24;
    change = true;
    //Serial.print("Change hour to ");
    //Serial.println(curr_h);
  }else if(btnUp.wasPressed()){  // Long Key check
    btnUp_pressed_cnt++;
    if(btnUp_pressed_cnt > LONGPRESS_CNT){
      btnUp_pressed_cnt = 0;
      // Request system time to PC
      //flgReqSysTime = 1;
      //Serial.println("Req. System Time Flag set");
      //req_sys_time();
    }
  }else if(btnUp.stateChanged()){
    //Serial.println("BtnUp State Change");
  }

  // Button down check
  if(btnDn.uniquePress()){
    //Serial.println("Button Down Click");
    btnDn_pressed_cnt = 0;

    get_rtc();
    // inc. Min.
    curr_m += Inc5Min(curr_m);
    if(curr_m >= 60) curr_m = curr_m%60;
    change = true;
    //Serial.print("Change Minutes to ");
    //Serial.println(curr_m);
  }else if(btnDn.wasPressed()){
    //Serial.println("BtnDn WAS pressed");
    btnDn_pressed_cnt++;
    if(btnDn_pressed_cnt > LONGPRESS_CNT){
      //Serial.println("BtnDn Long Key");
#ifdef ANI_MODE_KEY
      if(!animation_mode) {
        //Serial.println("Set Ani_Normal2");
        //AniModeSet(ANI_NORMAL);
        AniModeSet(ANI_PICTURE);
        photo_no = 0;
        btnDn_pressed_cnt = 0;
        //Serial.println("animode nomal");
        // off animation mode
        return(true);
      }else {
        AniModeSet(ANI_CLEAR); // if animation mode is set, will be exit animation_mode.
        //Serial.println("exit animation mode");
      }
#else
      curr_m++;
      if(curr_m >= 60) curr_m = curr_m%60;
      change = true;
      //Serial.print("Change Minutes to ");
      //Serial.println(curr_m);
#endif
    }
  }else if(btnDn.stateChanged()){
    //Serial.println("BtnDn State Change");
  }

  return(change);
}
#endif

void demo(void);
void splash(void);
void init_ips(void)
{
    Serial.println("Initing matrix driver...");
    lc.shutdown(0, false);
    lc.setIntensity(0, 15);
    lc.clearDisplay(0);

#ifdef USE_DS1307_RTC
    Serial.println("Initing RTC...");
#endif
}

#ifdef USE_DS1307_RTC
#define DS1307_I2C_ADDRESS 0x68

// Convert normal decimal numbers to binary coded decimal
byte decToBcd(byte val){
  return ( (val/10*16) + (val%10) );
}

// Convert binary coded decimal to normal decimal numbers
byte bcdToDec(byte val){
  return ( (val/16*10) + (val%16) );
}

// 1) Sets the date and time on the ds1307
// 2) Starts the clock
// 3) Sets hour mode to 24 hour clock

// Assumes you're passing in valid numbers

void setDateDs1307(byte second,        // 0-59
byte minute,        // 0-59
byte hour,          // 1-23
byte dayOfWeek,     // 1-7
byte dayOfMonth,    // 1-28/29/30/31
byte month,         // 1-12
byte year)          // 0-99
{
  Wire.beginTransmission(DS1307_I2C_ADDRESS);
  Wire.write(0);
  Wire.write(decToBcd(second));    // 0 to bit 7 starts the clock
  Wire.write(decToBcd(minute));
  Wire.write(decToBcd(hour));
  Wire.write(decToBcd(dayOfWeek));
  Wire.write(decToBcd(dayOfMonth));
  Wire.write(decToBcd(month));
  Wire.write(decToBcd(year));
  Wire.write(00010000); // sends 0x10 (hex) 00010000 (binary) to control register - turns on square wave
  Wire.endTransmission();
}

// Gets the date and time from the ds1307
void getDateDs1307(byte *second, byte *minute, byte *hour, byte *dayOfWeek, byte *dayOfMonth, byte *month, byte *year){
  // Reset the register pointer
  Wire.beginTransmission(DS1307_I2C_ADDRESS);
  Wire.write(0);
  Wire.endTransmission();

  Wire.requestFrom(DS1307_I2C_ADDRESS, 7);

  // A few of these need masks because certain bits are control bits
  *second     = bcdToDec(Wire.read() & 0x7f);
  *minute     = bcdToDec(Wire.read());
  *hour       = bcdToDec(Wire.read() & 0x3f);  // Need to change this if 12 hour am/pm
  *dayOfWeek  = bcdToDec(Wire.read());
  *dayOfMonth = bcdToDec(Wire.read());
  *month      = bcdToDec(Wire.read());
  *year       = bcdToDec(Wire.read());
}

#endif

void setup(void)
{
    pinMode(PIN_LED, OUTPUT);
    digitalWrite(PIN_LED, HIGH);

#ifdef USE_DS1307_RTC
    Serial.begin(57600);
    Wire.begin();
    RTC.begin();

  if (! RTC.isrunning()) {
    Serial.println("RTC is NOT running!");
    // following line sets the RTC to the date & time this sketch was compiled
    RTC.adjust(DateTime(__DATE__, __TIME__));
  }
#else
    Serial.begin(9600);
#endif
    init_ips();
    splash();
    last_millis = millis();
#ifndef USE_DS1307_RTC
    set_rtc(10, 32, 45);
#endif

    get_rtc();
    SHOW_CURR_TIME();

    digitalWrite(PIN_LED, LOW);
    Serial.println("HELLO");
    Serial.flush();

    // For Test
    //Serial.println(RAMEND);
    Serial.println(SERIAL_RX_BUFFER_SIZE);
}

void req_sys_time(void)
{
   // For test read time(HH:MM:SS) from PC
   Serial.println("#S|T|[]#");
}
void req_sys_date(void)
{
   // For test read date(YYYY-MM-DD) from PC
   Serial.println("#S|D|[]#");
}

#define SYS_TIME_LEN  8 /* 11 */
#define SYS_DATE_LEN  10

void set_sys_time()
{
    char Buff[30];
    char *receiveSerial;      // received data buffer pointer
    int i,foundPos;
    int receiveLeng;

    //delay(100);  // wait for rx data from PC
    receiveSerial = &Buff[0];
    receiveLeng = Serial.available();
    Serial.print("receiveLeng = ");
    Serial.println(receiveLeng);

    if (receiveLeng >= SYS_TIME_LEN) {

      Serial.readBytes(receiveSerial, receiveLeng);

      for(i=0; i < receiveLeng; i++) {
        //Serial.print(receiveSerial[i]);
        if(receiveSerial[i]==':') {
          foundPos = i;
          break;
        }
      }

      // set time
      if((receiveSerial[foundPos-2] != '1') && (receiveSerial[foundPos-2] != '2'))
        curr_h = receiveSerial[foundPos-1] - '0';
      else
        curr_h = (receiveSerial[foundPos-2] - '0')*10 + (receiveSerial[foundPos-1] - '0');

      curr_m = (receiveSerial[foundPos+1] - '0')*10 + (receiveSerial[foundPos+2] - '0');
      curr_s = (receiveSerial[foundPos+4] - '0')*10 + (receiveSerial[foundPos+5] - '0');
#if 0
      Serial.print(curr_h);
      Serial.print(":");
      Serial.print(curr_m);
      Serial.print(":");
      Serial.println(curr_s);
#endif

      set_rtc(curr_h, curr_m, curr_s);

      Serial.flush();
    }
}

/*
{ 0x06, 0x02, 0x0E, 0x0A, 0x0F, 0x00,  // a
  0x08, 0x08, 0x0E, 0x0A, 0x0E, 0x00,  // b
  0x00, 0x06, 0x08, 0x08, 0x06, 0x00,  // c
  0x02, 0x02, 0x0E, 0x0A, 0x0E, 0x00,  // d
  0x00, 0x0E, 0x0A, 0x0C, 0x0E, 0x00,  // e
  0x06, 0x08, 0x0C, 0x08, 0x08, 0x00,  // f
  0x0C, 0x0A, 0x0E, 0x02, 0x0C, 0x00,  // g
  0x08, 0x08, 0x0C, 0x0A, 0x0A, 0x00,  // h
  0x04, 0x00, 0x04, 0x04, 0x04, 0x00,  // i
  0x04, 0x00, 0x04, 0x04, 0x0C, 0x00,  // j
  0x08, 0x08, 0x0E, 0x0C, 0x0A, 0x00,  // k
  0x04, 0x04, 0x04, 0x04, 0x06, 0x00,  // l
  0x00, 0x0E, 0x0E, 0x0E, 0x0A, 0x00,  // m
  0x00, 0x0E, 0x0A, 0x0A, 0x0A, 0x00,  // n
  0x00, 0x04, 0x0A, 0x0A, 0x04, 0x00,  // o
  0x00, 0x0C, 0x0A, 0x0C, 0x08, 0x08,  // p
  0x00, 0x06, 0x0A, 0x06, 0x02, 0x02,  // q
  0x00, 0x0C, 0x0A, 0x0C, 0x0A, 0x00,  // r
  0x00, 0x0E, 0x0C, 0x02, 0x0E, 0x00,  // s
  0x00, 0x0E, 0x04, 0x04, 0x04, 0x00,  // t
  0x00, 0x0A, 0x0A, 0x0A, 0x06, 0x00,  // u
  0x00, 0x0A, 0x0A, 0x0E, 0x04, 0x00,  // v
  0x00, 0x0A, 0x0E, 0x0E, 0x0A, 0x00,  // w
  0x00, 0x0A, 0x0E, 0x04, 0x0A, 0x00,  // x
  0x00, 0x0A, 0x0A, 0x0E, 0x02, 0x0C,  // y
  0x00, 0x0E, 0x02, 0x0C, 0x0E, 0x00,  // z
}

{ 0x0E, 0x19, 0x1F, 0x19, 0x19, 0x00,  // A
  0x1E, 0x19, 0x1E, 0x19, 0x1E, 0x00,  // B
  0x0E, 0x19, 0x18, 0x19, 0x0E, 0x00,  // C
  0x1E, 0x19, 0x19, 0x19, 0x1E, 0x00,  // D
  0x1F, 0x18, 0x1F, 0x18, 0x1F, 0x00,  // E
  0x1F, 0x18, 0x1E, 0x18, 0x18, 0x00,  // F
  0x0E, 0x18, 0x1B, 0x19, 0x0E, 0x00,  // G
  0x19, 0x19, 0x1F, 0x19, 0x19, 0x00,  // H
  0x0E, 0x04, 0x00, 0x04, 0x0E, 0x00,  // I
  0x0E, 0x04, 0x00, 0x14, 0x0C, 0x00,  // J
  0x19, 0x1A, 0x1C, 0x1E, 0x1B, 0x00,  // K
  0x18, 0x18, 0x18, 0x18, 0x1F, 0x00,  // L
  0x11, 0x1B, 0x19, 0x19, 0x19, 0x00,  // M
  0x11, 0x19, 0x19, 0x1B, 0x19, 0x00,  // N
  0x0E, 0x19, 0x19, 0x19, 0x0E, 0x00,  // O
  0x1E, 0x19, 0x1E, 0x18, 0x18, 0x00,  // P
  0x0E, 0x19, 0x19, 0x1B, 0x0F, 0x00,  // Q
  0x1E, 0x19, 0x19, 0x1E, 0x1B, 0x00,  // R
  0x0F, 0x18, 0x1F, 0x01, 0x1E, 0x00,  // S
  0x1F, 0x04, 0x04, 0x04, 0x04, 0x00,  // T
  0x19, 0x19, 0x19, 0x19, 0x0E, 0x00,  // U
  0x11, 0x19, 0x19, 0x0A, 0x04, 0x00,  // V
  0x11, 0x11, 0x14, 0x1B, 0x0A, 0x00,  // W
  0x11, 0x0A, 0x04, 0x0A, 0x11, 0x00,  // X
  0x11, 0x19, 0x0C, 0x04, 0x04, 0x00,  // Y
  0x1F, 0x03, 0x10, 0x0C, 0x1F, 0x00,  // Z
}
*/
#if 0
const byte view_buff[] = { 0x0A, 0x15, 0x11, 0x0A, 0x04, // Heart
                     0x00, 0x1B, 0x1F, 0x0E, 0x04, // Heart
                     0x00, 0x08, 0x08, 0x0E, 0x00, // L
                     0x00, 0x04, 0x0A, 0x0A, 0x04, // o
                     0x00, 0x0A, 0x0A, 0x0E, 0x04, // v
                     0x00, 0x0E, 0x0A, 0x0C, 0x0E, // e
                     0x0A, 0x15, 0x11, 0x0A, 0x04, // Heart
                     0x00, 0x1B, 0x1F, 0x0E, 0x04, // Heart
                   };
#else
const byte view_buff[] = { 0x0A, 0x15, 0x11, 0x0A, 0x04, 0x00, // Heart
                     0x18, 0x18, 0x18, 0x18, 0x1F, 0x00, // L
                     0x0E, 0x19, 0x19, 0x19, 0x0E, 0x00, // O
                     0x11, 0x19, 0x1B, 0x0E, 0x04, 0x00, // V
                     0x1F, 0x18, 0x1E, 0x18, 0x1F, 0x00, // E
                     0x00, 0x1B, 0x1F, 0x0E, 0x04, 0x00, // Heart
                   };
#endif

const byte photo_buff[] = {
0x18,0x10,0x00,0x00,0x00,
0x1C,0x18,0x10,0x00,0x00,
0x1E,0x1C,0x18,0x10,0x00,
0x1F,0x1E,0x1C,0x18,0x10,
0x1F,0x1F,0x1E,0x1C,0x18,
0x1F,0x1F,0x1F,0x1E,0x1C,
0x1F,0x1F,0x1F,0x1F,0x1F,
0x1F,0x1F,0x1F,0x1F,0x1F,

};

const byte photo2_buff[] = {
0x00,0x00,0x04,0x00,0x00,
0x00,0x08,0x0C,0x00,0x00,
0x00,0x0E,0x0E,0x02,0x00,
0x10,0x1E,0x1E,0x1E,0x00,
0x1F,0x1F,0x1F,0x1F,0x01,
0x1F,0x1F,0x1F,0x1F,0x1F,
0x1F,0x1F,0x1F,0x1F,0x1F,
0x1F,0x1F,0x1F,0x1F,0x1F,
};

const byte rainy_day[] = {
0x08,0x08,0x0A,0x02,0x02,
0x01,0x08,0x08,0x0A,0x02,
0x11,0x01,0x08,0x08,0x0A,
0x11,0x11,0x01,0x08,0x08,
0x14,0x11,0x11,0x01,0x08,
0x04,0x14,0x11,0x11,0x01,
0x04,0x04,0x14,0x11,0x11,
0x00,0x04,0x04,0x14,0x11,
};

const byte haze_day[] = {
0x00,0x00,0x00,0x02,0x00,
0x00,0x08,0x02,0x08,0x00,
0x00,0x00,0x12,0x05,0x10,
0x10,0x02,0x14,0x01,0x14,
0x12,0x01,0x0A,0x00,0x15,
0x14,0x0A,0x11,0x08,0x15,
0x09,0x14,0x0A,0x00,0x15,
0x0A,0x15,0x0A,0x15,0x0A,
};

const byte normal_day[] = {
0x00,0x00,0x04,0x00,0x00,
0x00,0x0E,0x0A,0x0E,0x00,
0x1F,0x11,0x15,0x11,0x1F,
0x00,0x0E,0x0A,0x0E,0x00,
0x00,0x00,0x04,0x00,0x00,
0x00,0x0E,0x0A,0x0E,0x00,
0x1F,0x11,0x15,0x11,0x1F,
0x00,0x0E,0x0A,0x0E,0x00,
};

const byte cloudy_day[] = {
0x00,0x1B,0x1E,0x0C,0x00,
0x01,0x16,0x1C,0x18,0x00,
0x02,0x0C,0x18,0x10,0x01,
0x04,0x18,0x10,0x00,0x02,
0x08,0x11,0x01,0x01,0x04,
0x10,0x03,0x03,0x02,0x08,
0x00,0x06,0x07,0x05,0x10,
0x00,0x0D,0x0F,0x08,0x00,
};

const byte snowy_day[] = {
0x14,0x02,0x09,0x12,0x04,
0x09,0x14,0x02,0x09,0x12,
0x02,0x09,0x14,0x02,0x09,
0x11,0x02,0x08,0x14,0x02,
0x04,0x11,0x02,0x08,0x14,
0x12,0x04,0x11,0x02,0x08,
0x08,0x12,0x04,0x11,0x02,
0x04,0x08,0x12,0x04,0x11,
};

byte RxBuff[MAX_BUFF_SIZE+1];
int RxBuffSize = 0;

#define NORMAL     0
#define RAINY_DAY  1
#define HAZE_DAY   2
#define CLOUDY_DAY 3
#define SNOWY_DAY  4
#define MAX_WEATHER_DISP_CNT  2

int Weather = NORMAL;
int WeatherDispCount = 0;
bool tick_tock = LOW;
void loop(void)
{
    int i, j;
    unsigned long curr_millis = millis();
    byte *photo;

#ifndef USE_DS1307_RTC
    if ((curr_millis - last_rtc_millis) >= 1000) {
        update_dummy_rtc();
        last_rtc_millis = curr_millis;
        tick_tock = (tick_tock == HIGH ? LOW : HIGH);
        digitalWrite(PIN_LED, tick_tock);
    }
#endif

#ifdef SET_TIME_BTN
    // button check
    if(button_chk()) {
      //Serial.println("button_chk() return true!!");
      set_rtc(curr_h, curr_m, curr_s);
      get_rtc();
      SHOW_CURR_TIME();
      last_millis = millis();
    }
#endif

    // update panel in every 1 min
    if ((curr_millis - last_millis) >= 30 * 1000) {
        get_rtc();
        SHOW_CURR_TIME();
        last_millis = curr_millis;
    }

    // Set System Time from PC
    if(flgReqSysTime) {
      //Serial.println("Check Req. system time flag");
      delay(100); // wait for rx data from PC
      if (Serial.available() >= SYS_TIME_LEN) {
        flgReqSysTime = 0;
        Serial.println("Get system time");
        set_sys_time();
        get_rtc();
        SHOW_CURR_TIME();
        last_millis = millis();
      }
    }else if(animation_mode) {
        switch(animation_mode) {
            case ANI_INFO :
                //Serial.print("Weather is ");
                //Serial.println(Weather);
                if(Weather == RAINY_DAY){
                  Animation((byte *)&rainy_day[0], sp, MAX_BUFF_SIZE);
                }else if(Weather == HAZE_DAY) {
                  Animation((byte *)&haze_day[0], sp, MAX_BUFF_SIZE);
                }else if(Weather == CLOUDY_DAY){
                  Animation((byte *)&cloudy_day[0], sp, MAX_BUFF_SIZE);
                }else if(Weather == SNOWY_DAY){
                  Animation((byte *)&snowy_day[0], sp, MAX_BUFF_SIZE);
                }else{
                  Animation((byte *) &normal_day[0], sp, MAX_BUFF_SIZE);
                }
                if(sp < MAX_BUFF_SIZE) sp += 5;
                else {
                  sp = 0;
                  WeatherDispCount++;
                  if(WeatherDispCount > MAX_WEATHER_DISP_CNT) {
                    WeatherDispCount = 0;
                    //AniModeSet(ANI_CLEAR);
                  }
                }
                break;

            case ANI_USER_V :
            case ANI_USER_F :
                //Serial.println("ani. mode = ANI_USER");
                Animation(&RxBuff[0], sp, RxBuffSize);

                if(sp < RxBuffSize) {
                  if(animation_mode == ANI_USER_V)
                    sp++;
                  else if (animation_mode == ANI_USER_F)
                    sp += 5;
                }else sp = 0;
                break;

            case ANI_PICTURE :
                if(!picture_mode) {
                  picture_mode = true;
                  PictureMode();
                }else {
                  if(photo_no==0) Animation((byte *)&photo_buff[0], sp, MAX_BUFF_SIZE);
                  else if(photo_no==1) Animation((byte *)&photo2_buff[0], sp, MAX_BUFF_SIZE);
                  else if(photo_no==2) PictureMode();

                  if(sp < MAX_BUFF_SIZE) {
                    sp += 5;
                  }else {
                    sp = 0;
                    photo_no++;
                    if(photo_no > 5) photo_no = 5;
                  }
                }
                break;

            case ANI_USER_H :
                //break;

            case ANI_NORMAL :
                //Serial.println("ani. mode = ANI_NORMAL");

            default :
                Animation((byte *)&view_buff[0], sp, MAX_BUFF_SIZE);
                if(sp < MAX_BUFF_SIZE) sp++;
                else sp = 0;
                break;
        }
        delay(100);
    }

    // Serial commands
    // #D for Demo
    // #L<r><c> for turn on a LED in row r and column c
    // #S<hh><mm><ss> set time
    // #G get time
    // #V Veritical View Mode (animate received data from PC)
    // #H Horizontal View Mode (animate received data from PC)
    // #F Flash View Mode (animate received data from PC)
    // #A Animation Mode (animate default image)
    // #C Time Display Mode ( Exit animation mode )
    // #W Weather Display Mode
    // #P Photo Mode
    if (Serial.available() > 1 && '#' == Serial.read()) {
        char func = Serial.read();
        int hour = 0;
        int minute = 0;
        int sec = 0;
        byte temp;
        delay(10); // wait enough for following chars
        if (func == 'D') {          // Demo
            AniModeSet(ANI_DEMO);
            demo();
        } else if (func == 'G') {   // Get time
            get_rtc();
            Serial.print((int)(curr_h));
            Serial.print(":");
            Serial.print((int)(curr_m));
            Serial.print(":");
            Serial.print((int)(curr_s));
        } else if (func == 'S') {   // Set time
            hour = 10 * (Serial.read() - '0');
            hour += (Serial.read() - '0');
            minute = 10 * (Serial.read() - '0');
            minute += (Serial.read() - '0');
            sec = 10 * (Serial.read() - '0');
            sec += (Serial.read() - '0');
            set_rtc((uint8_t)hour, (uint8_t)minute, (uint8_t)sec);
            get_rtc();
            SHOW_CURR_TIME();
            last_millis = millis();
        } else if (func == 'L') {
            byte r = Serial.read() - '0';
            byte c = Serial.read() - '0';

            CLEAN_PANEL();
            _P_ON(r_table[r], c_table[c]);
            REFRESH_PANEL();
        } else if ((func == 'V') || (func == 'H') || (func == 'F')) {
          Serial.print("RxLen = ");
          Serial.println(Serial.available());
          for(i=0; Serial.available() > 0; ) {
            RxBuff[i] = Serial.read();
            if(RxBuff[i]!=',') { // Hex first char.
              temp = RxBuff[i] - '0';
              if(temp > 9) temp = (RxBuff[i] > 'F') ? (RxBuff[i] - 87) : (RxBuff[i] - 55);
              //Serial.print(temp);
              RxBuff[i] = Serial.read();
              if(RxBuff[i] != ','){ // Hex second number is exist.
                temp += (temp !=0 ) ? 15 : 0;
                if(RxBuff[i] > '9') {
                  temp += (RxBuff[i] > 'F') ? (RxBuff[i] - 87) : (RxBuff[i] - 55);
                }
                else temp += (RxBuff[i] - '0'); // this is Numeric.
                //Serial.println(temp);
              }
              RxBuff[i] = temp;
#if 0
              Serial.print("RxBuff[");
              Serial.print(i);
              Serial.print("]=");
              Serial.println(temp);
#endif
              i++;
            }
          }
          RxBuff[i] = 0xFE; // Added EOL..
          RxBuffSize = i;
          Serial.print("Received Length = ");
          Serial.println(i);
          //Serial.println(RxBuff[i]);
          if(func == 'V')
            AniModeSet(ANI_USER_V);
          else if (func == 'H')
            AniModeSet(ANI_USER_H);
          else if (func == 'F')
            AniModeSet(ANI_USER_F);
        }else if (func == 'A') {
          Serial.println("Set Ani_Normal");
          AniModeSet(ANI_NORMAL);
        }else if (func == 'C') {
          Serial.println("Exit Animation Mode");
          AniModeSet(ANI_CLEAR);
        }else if (func == 'W') {
          char WCode = Serial.read();
          if(WCode == 'R'){
            // It's Rainy day
            Weather = RAINY_DAY;
            Serial.println("It's Rainy");
          }else if (WCode == 'H') {
            // It's Haze
            Weather = HAZE_DAY;
            Serial.println("It's Haze");
          }else if(WCode == 'C') {
            // It's Cloudy Day
            Weather = CLOUDY_DAY;
            Serial.println("It's Cloudy");
          }else if(WCode == 'S') {
            // It's Cloudy Day
            Weather = SNOWY_DAY;
            Serial.println("It's Snowy");
          }else Weather = NORMAL;
          AniModeSet(ANI_INFO);
        }else if (func == 'P') {
          AniModeSet(ANI_PICTURE);
          photo_no = 0;
        }
        Serial.println(" OK");
    }
    delay(100); // sleep 100ms
}

int last_shown_h = -1;
int last_shown_m = -1;
void show_time(int h, int m)
{
#if 0
    Serial.print("show_time: ");
    Serial.print(h);
    Serial.print(":");
    Serial.println(m);
#endif

#if 0
    if (h == last_shown_h && m == last_shown_m)
        return;
#endif

    if(picture_mode) return;

    //if(animation_mode != ANI_CLEAR) return; // Must be check!!!

    // update current time from RTC in every hour
    if (h != last_shown_h)
        get_rtc();

    last_shown_h = h;
    last_shown_m = m;

    int m_10 = m / 10;
    int m_1 = m % 10;

    switch (m_1) {
    case 1 ... 3:
        m_1 = 0;
        break;
    case 4 ... 6:
        m_1 = 5;
        break;
    case 7 ... 9:
        m_1 = 0;
        m_10 += 1;
        break;
    }

    if (m_10 >= 6) {
        //Serial.print("m_10=");
        //Serial.println(m_10);
        m_10 = 0;
        h += 1;
    }

    CLEAN_PANEL();

    if ((h == 0 || h == 24) && (m_10 + m_1) == 0) {
        //Serial.println("JaJung...");
        P_ON(3, 0); P_ON(3, 1); // JaJung
        REFRESH_PANEL();
        return;
    }

    if (h == 12 && (m_10 + m_1) == 0) {
        //Serial.println("JungOh...");
        P_ON(3, 1); P_ON(4, 1); // JungOh
        REFRESH_PANEL();
        return;
    }

    if (h > 12) h -= 12;
    switch (h) {
    case 0:
    case 12:
        P_ON(0, 0); P_ON(1, 0); P_ON(2, 4);
        break;
    case 1:
        P_ON(0, 1); P_ON(2, 4);
        break;
    case 2:
        P_ON(1, 0); P_ON(2, 4);
        break;
    case 3:
        P_ON(0, 3); P_ON(2, 4);
        break;
    case 4:
        P_ON(0, 4); P_ON(2, 4);
        break;
    case 5:
        P_ON(0, 2); P_ON(1, 2); P_ON(2, 4);
        break;
    case 6:
        P_ON(1, 1); P_ON(1, 2); P_ON(2, 4);
        break;
    case 7:
        P_ON(1, 3); P_ON(1, 4); P_ON(2, 4);
        break;
    case 8:
        P_ON(2, 0); P_ON(2, 1); P_ON(2, 4);
        break;
    case 9:
        P_ON(2, 2); P_ON(2, 3); P_ON(2, 4);
        break;
    case 10:
        P_ON(0, 0); P_ON(2, 4);
        break;
    case 11:
        P_ON(0, 0); P_ON(0, 1); P_ON(2, 4);
        break;
    }

    if (m == 0) {
        REFRESH_PANEL();
        return;
    }

    switch (m_10) {
    case 1:
        P_ON(3, 4); P_ON(4, 4);
        break;
    case 2:
        P_ON(3, 2); P_ON(4, 2); P_ON(4, 4);
        break;
    case 3:
        P_ON(3, 3); P_ON(3, 4); P_ON(4, 4);
        break;
    case 4:
        P_ON(4, 0); P_ON(4, 2); P_ON(4, 4);
        break;
    case 5:
        P_ON(4, 1); P_ON(4, 2); P_ON(4, 4);
        break;
    }

    if (m_1 == 5) {
        P_ON(4, 3); P_ON(4, 4);
    }

    REFRESH_PANEL();
}

void splash(void)
{
    for (int r = 0; r < 5; r++) {
        for (int c = 0; c < 5; c++) {
            CLEAN_PANEL();
            _P_ON(r_table[r], c_table[c]);
            REFRESH_PANEL();
            delay(50);
        }
    }
    CLEAN_PANEL();
}

void demo(void)
{
    for (int h = 0; h < 24; h++) {
        for (int m = 0; m < 60; m += 5) {
            //if(animation_mode != ANI_DEMO) return;
            digitalWrite(PIN_LED, HIGH);
            show_time(h, m);
            digitalWrite(PIN_LED, LOW);
            delay(500); // 1sec
        }
    }
    CLEAN_PANEL();
}

#ifdef USE_DS1307_RTC
byte sec, min, hour, DoWeek, DoMonth, month, year;
void set_rtc(uint8_t h, uint8_t m, uint8_t s)
{
    getDateDs1307(&sec, &min, &hour, &DoWeek, &DoMonth, &month, &year); // 20150608 added by bclee.
#if 0
    Serial.print(year);
    Serial.print(".");
    Serial.print(month);
    Serial.print(".");
    Serial.print(DoMonth);
    Serial.print(". ");
#endif
    setDateDs1307(s, m, h, DoWeek, DoMonth, month, year);
    curr_h = h;
    curr_m = m;
    curr_s = s;
    last_rtc_millis = millis();
}

void get_rtc(void)
{
    DateTime now = RTC.now();

    curr_h = now.hour();
    curr_m = now.minute();
    curr_s = now.second();
}
#else
void set_rtc(uint8_t h, uint8_t m, uint8_t s)
{
    curr_h = h;
    curr_m = m;
    curr_s = s;
    last_rtc_millis = millis();
}

void get_rtc(void)
{

}

void update_dummy_rtc(void)
{
    curr_s += 1;
    if (curr_s >= 60) {
        curr_s = 0; curr_m += 1;
    }
    if (curr_m >= 60) {
        curr_m = 0; curr_h += 1;
    }
    if (curr_h >= 24) {
        curr_h = 0;
    }
}

#endif


Didn't you change it to `!mustfix`?


Btw this will return specs as being on team 2


I think I was wrong and there is no race here (but atomic operations should probably be used).


It was a permissions issue, the daemon had only read access, now it can write.


Initial Hangul Clock source


BTW could make sense to use !blocker, because email inbox is not the best thing for monitoring open issues or questions :-)


test Comment


Style nit: Space around `<-`


@garbear: See https://github.com/xbmc/xbmc/pull/7890.


Yeah, we'll need another uniform but that shouldn't be a big deal, it probably won't change a lot anyway.

The minz/maxz thing is interesting. There indeed seem to be potential to do something like that. I doubt there's additional clipping of values "outside" zscale, it's just a scale factor - any clipping would happen as a result of the coordinate after zscale being outside the minz/maxz clipping space... I think...


Yeah, this UX sucks. Emails are unusable. I use just GH interface for issues and notifications, which is also bad but somehow usable at least.


I picked the first thing that popped out at SO and I guess that I will keep it that way...


All right :)


Or I mean, is it a change request or just a note that I can use `$0`? :-)


把AdminLTE-2模板也加上吧，不然我又要改，麻烦。。


WTF is `NewError`? No wait, I don't really wanna know... :D


Yes its Good


cfg_dir is not defined in map.jinja and causes this state to fail.


I don't see where this was moved...? It's used by the other changes, and removed here. Where there two `InternalException` classes?


Thanks, please keep me updated, since if this change is valuable I would love to integrate it in the OpenMVG AKAZE port.


But `NewError` is being used like everywhere throughout SF, how come you are surprised? :-)


Why not just **parser**? :)


This warning isn't very helpful without information about the QP (such as the QPN).


Same here.


> if a generic Promises/A+ should be reused. Thoughts?
Thanks, I'm gonna reuse `Thenable<R>` on `promises-a-plus/promises-a-plus.d.ts`.
Because, chai-as-promised is compatible with Promises/A+ spec.

> Chai as Promised is compatible with all promises following the Promises/A+ specification.
> - https://www.npmjs.com/package/chai-as-promised#compatibility


用单引号


ActiveRecord::RecordNotFound: Couldn't find Product with 'id'=not_exist_id - and that exception should be catch in your controller or in ApplicationController with flash notification alia: 'Record not exists'. In your scenario you return empty array, and this behaviour is 'unclear' from user side because you didn't display anything, but server return you data. (empty array)


OSX should in theory work just like linux, meaning you can now build addons standalone and/or without unified depends. If that really works is up to test for someone that actually has OSX ;)


added h1 tag


Also adjusted the height of title for page such as Account Contact Us.


了解です〜！


forum dead too ? I see people there http://forums.arkania.net/


redundant `== false`. When checking a boolean variable `booleanVar` for example, you should simply write

`if(booleanVar)` <=> `if(booleanVar == true)`
`if(!booleanVar)` <=> `if(booleanVar == false)`


This solution doesn't scale at all. It would be better to pass a list of modules (i.e. `[issueTracker, codeReview, ...]`) and let each module append its stuff to the config in a loop. That way when you want to omit a module, you just don't add it to that list and you don't have to add zillions of `if` conditions everywhere like you do for Release Notes.


（口頭で話ましたがここにも簡単に書いておきます。）
デフォルトで`group_id`を生成せずに、`with_group`が指定された場合だけグループオブジェクトを生成して関連付ければ`id`を気にしなくて良くなるはずです。
`project`も同様です。


AV已经更新了code了，请不要再调用拼写错误的lib


bad variable naming


I would like to express my condolences. I can feel how painful it is to write Objective-C code :-).


I'm not saying we're going to have that many of kinds of modules, but the code is becoming horrible already now when there are only two mandatory and one optional :)


ブラウザでの挙動確認用なのですが、どのタイミングで消すのが適切でしょうか。


@shortdudey123 Did you mean:
```
       if peer == node['hostname'] || peer == node['fqdn']
```
not
```
       if peer == node['hostname'] || node == node['fqdn']
```
?


这些本地变量有用么，没用的话直接一行返回可以么
return new Auth(new Config(), new RemoteUserProvider());


Well done


div лишний можешь назначить этот класс для ul


Sure, I used Go as the scripting language in salsita-workflow/salsaflow-build ;-)


You can merge the two `if`s.


h3 и price-block - оберни в общий контейнер, чтобы ему задать внутренние отступы


Необходим ярлык new


Thanks!


Done: 0fafec2


全局侧滑


этот класс можешь назначить для ul


`dgid` isn't initialized in this function.
Also, where are the dgid/sgid checks for non multicast?


Всем картинкам добавь атрибуты width и height


@wsnipex: But only under the condition that all dependencies have already been built/installed system-wide?
But my question was how this works on e.g. jenkins. Does it use the CMake binary build from native depends or does it use a pre-installed CMake binary?


!blocker Refactor config template generation.


他の方にも指摘いただいて #18 で修正しました m_ _ m


I'm not sure what happens if you call `getAsJsonObject()` on a `JsonNull`, but I think the `elem.isJsonNull()` check should move up into this condition then we probably don't have to find out
`elem != null && !elem.isJsonNull()`


Можешь эту p и следующую обернуть в общий блок чтобы его ограничить по ширине. В данном макете он идет не на всю ширину.


Не ясно назначение пустого div


Ouch!!  I have not seen this.
But please  use  `traceback()`  in such a situation {which also gives a very long output...}
and report it a bit more.


I think if we can emulate a `doc: null` in a `View` result as well that would be good.


!blocker Remove unnecessary comment.


Why did you remove the headline?


Все input + label обернуть в общий блок обертку, которому мы повесим картинку в виде тени и ограничим label по ширине и дадим float: left


Maybe it's just me but this looks totally overengineered. Why do you need factories and instances and everything?
Isn't all you want a map from IDs to instances? Why do you need to have all this factory bullshit and `NewIssueTracker` (do you really create more than one issue tracker per app run? Why?) around?

It could be just me, but all those structs and functions seem to be totally unnecessary (and reminds me strongly of Java designs where million classes delegate functionality to each other and not one of them actually does anything useful...).


In test mode, we're adding a new bit of middleware to the stack. This will handle our request mocking. It's the same thing that MockJax was doing when we tried that, but simpler.


デバッグコードはコミットするべきではないですね。
挙動の確認はテストを書きましょう。


maybe https://github.com/OpenSCAP/openscap/pull/145 is related


helperに書くようにします :smiley:


I introduced that exception just to make each commit go green. at some point, I move [CypherExcpetion](https://github.com/systay/neo4j/blob/67f8b51220eceefcf5e7aacc44398e3a97d65e4a/community/cypher/frontend-2.3/src/main/scala/org/neo4j/cypher/internal/frontend/v2_3/CypherException.scala) and then I could remove this intermediate step


Лишние кавычки. Можешь слово Техномарт обернуть в span или strong с классом, а кавычки вообще не ставить. С помощью css добавим кавычки как псевдоэлементы (либо в html их можно добавить как служебные символы). Потому что твои кавычки не будут похожи на, те которые в макете.


@bolshoy STOP COMMITTING TO MASTER IN THIS REPO!!!!!


Yeah, this is basically the JIRA workflow. I don't see any issues in returning `Implemented` state. It's kinda annoying to capture the PT workflow, like you have basically 3 states - `reviewed`, `tested` and `reviewed&tested` or `verified` or something. Not really sure how useful it is to make this mess by not having states that linearly follow one after another.


So in this test we want requests to /package (I'm not checking the HTTP verb here, wasn't really necessary; might be later) to return a 413. Simple.


i'm removing this, it doesn't matter anyways since this package doesn't have any tests anyways


Это не является элементом списка


Use `list_for_each_entry`


どんな order が良いでしょうか :question:


Кнопка не является элементом списка


Traceback is:
```
14: lengths(x, use.names = use.names)
13: lengths(x, use.names = use.names)
12: lengths(cnms)
11: mkReTrms(findbars(RHSForm(formula)), fr)
10: getXReTrms(formula, mf, fr)
9: mkTMBStruc(formula, ziformula, dispformula, mf, fr, yobs, offset,
       weights, familyStr, link)
8: eval(expr, p)
7: eval.parent(mkTMBStruc(formula, ziformula, dispformula, mf, fr,
       yobs, offset, weights, familyStr, link))
6: glmmTMB(Reaction ~ Days + (1 | Subject), sleepstudy) at Rex2d677b9043dd#8
5: eval(expr, envir, enclos)
4: eval(ei, envir)
3: withVisible(eval(ei, envir))
2: source(tf, local, echo = echo, prompt.echo = paste0(prompt.prefix,
       getOption("prompt")), continue.echo = paste0(prompt.prefix,
       getOption("continue")), verbose = verbose, max.deparse.length = Inf,
       encoding = "UTF-8", skip.echo = skips, keep.source = TRUE)
1: example(glmmTMB)
```


So why do you have these bash scripts here then?


Ссылке необходим класс либо оберни ее в div. Чтобы сделать ее блочной и задать свойства, чтобы картинка не выпадала за размеры


We might not need this


Thanks a lot for your sharing. I'm referring your blog http://rndm.io/mqtt-go-and-the-ibm-internet-of-things/ to deploy goIoT on my board which is one ARMv7 platform.
When I execute "go get" command on my board, I got following errors, may I have your comments on that?

root@ls1021atwr:~/work/src/goIoT# go get
# goIoT
./main.go:52: undefined: mqtt.MqttClient
./main.go:97: mqtt.NewClientOptions().AddBroker(config.BrokerAddress).SetClientId undefined (type *mqtt.ClientOptions has no field or method SetClientId)
./main.go:110: cannot use client (type *mqtt.Client) as type mqtt.Client in argument to SendData

My ls1021atwr board is freescale's QorIQ Layerscape platform based on ARMv7,


Add new line between if for code beatification


Nah, I don't really care, just a suggestion so that you don't have to write that long unnecessary command. But I'm glad you source that file, so that you won't have to change it in 5 places in the future, so I consider this done.


Code style


Double space here right before second sentence.


开始使用git维护项目


Omit operations under if condition

It's bad practice


might only need the `required` option here. But I'll double check with server folks :)


辅导辅导费大幅度


This is the first time the skb has reached the driver, right? Does something zero-out the rxe_pkt_info part?


It's annoying, true. At the beginning `LocalConfigTemplate() string` was inside of `IssueTracker` or other modules, but then I discovered that it cannot be like that because instantiating the module actually often reads the local config, which might not exist. So I introduced another layer, which are the factories. If you have any ideas how to make this better, you can tell me.

So, how would you do it? You want a global variable holding module instances for each module type? It's that totally ugly?


p является блочным элементом, нет смысла блочный p закидывать в блочный div. Оставь p с классом copyright


code style. Brackets + new line


letが使われる場所を完全に追えてないのですが、普通のletだと落ちてしまいました :no_bell:

```
  1) 登録者のプロフィール プロフィールの編集 プロフィールが編集できる プロフィールが編集できる
     Failure/Error: select new_group, from: 'user_profile_group_id'
     Capybara::ElementNotFound:
       Unable to find option "BO2FRG4nJ7RAGGn"
     # ./spec/features/user_profiles_spec.rb:37:in `block (4 levels) in <top (required)>'
```


Or you mean that I should only call `NewIssueTracker` and stuff once and then pass the instance or what?


We don't want to leave our mocks hanging around for future tests, so we define a cucumber tag. Anything tagged `@rackmock` will have this called afterwards.


Social назначь для ul, а div убери


#### 观察者模式的实现


Reordering for readability - nothing important here.


Hi Simon,

I wanted to implememt Gait-Tracking-With-PNI IMU where the output data of the IMU is Acceleration in g 3-axis,Quaternion angular data.


We need to use our `@rackmock` cucumber tag, but we also want to use `@javascript` to make the whole test run in a proper javascript engine. Otherwise, it can't actually run the jquery to display the error as intended.


Внутри ссылок должен быть текст (например "Вконтакте", "Facebook" и так далее). Ссылки не должны быть пустыми


wishing there was a way to pass the validation error message to the `<Snack-bar/> element here :/
cant think of any..


getIdentity? update the comments


This is the main event. It's a bit of rack middleware that intercepts requests and takes over if it's been told to...


Для p необходимо назначить классы, чтобы потом их стилизовать


We're keeping a class variable to track the mocks, because there will be many instances of this. Easiest to use `@@` to keep the mocks in so we don't have to find the right object to add the mock to.


どんな order が良いでしょうか :question:


Historical reasons I guess, and also for copying and packing Bash is really much faster to use.


@brettevans this applies the simple regex we talked about earlier.
Let me know what you think.


#4858-VRF-IO-Ref-documentation-shows-incorrect-values-for-schedule-priority-control (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (752 of 752 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.91%25-green.svg)


pretty sure it uses cmake from unified depends


Why you don't use you stdlib free instead if your custom free

It will free memory or it'll be leaked?

Think about this


edit


I am really quite nervous about having a blanket exception catch here, it could hide real exceptions that have nothing to do with the server failing.


Excellent. Indeed, this is unnecessary and would waste 4 bytes per bitmap... which can add up.


Do we still need this?


What is the difference between DONE and EXIT? Could you add some comments explaining the different states?


Given this is a REST client, I still think 3 retry attempts is more than enough.  3 retry attempts ensures that at least 2 of the requests end up at a different data centre, and if the requests are not going to succeed after 2 attempts to two different data centres, it's not ever going to pass IMHO


Code


Genau so hab ich mir das gedacht mit der UI zum Löschen, klasse dass du das direkt gesehen hast.


den ganzen stacktrace würd ich da jetzt nicht reinpacken, das macht handle() schon beim loggen _eigentlich_


There's a missing period here.


We will hopefully soon opensource this plugin. I will update here when i get to put this to the planning.


Shouldn't the preferred host be inserted at position AFTER the hosts are recycled?  If I read this correctly, we will send requests to random hosts every time?


..toDebugString() fest aufrufen?


:+1: nice!


Of course, here we can go much faster by just casting mutableBitmap to ImmutableRoaringBitmap. E.g.,

        return new WrappedImmutableBitmap((ImmutableRoaringBitmap) mutableBitmap);

That would be much faster and just as safe!


AjaxUserList 클래스는 안보이네요.

컴파일 에러 났을거 같은데요?


Possibly introduced this bug https://github.com/pyinstaller/pyinstaller/issues/1436


As far as I know the dynamics do use the MScoreText font and not the mscore font. Please double check.

Here is the code: https://github.com/musescore/MuseScore/blob/master/libmscore/dynamic.cpp#L88

You can see the difference for ff and fff between
http://vtest.musescore.org/a23ef389/vtest.html#emmentaler-text-3
and
http://vtest.musescore.org/97324ae1/vtest.html#emmentaler-text-3

There is still a problem with the fz pair. I'm not sure why the others are working.


Ok... you only see this problem because your version of R is 3.1.x or earlier....  and so I or Ben don't see it.
All the same it is silly one-letter typo which I'll fix immediately.
Martin


fix is ok


I know I mentioned this in the previous commit, but I think we should really be thinking about which exceptions specifically we will catch that will warrant a retry, as opposed to excluding exceptions that we know should not result in a retry.  I expect the network library you are using has documented exception it will throw, and we know all the exceptions we can throw, so I believe that is possible.


Note that this part of the API is probably wasteful... serializing to an output stream directly would be faster and use less memory.


Better: http://sprunge.us/YFWC


What is the difference between the implicit ACK case above (returning COMPST_COMP_WQE) and the explicit ACK here (returning COMPST_COMP_ACK)?


@sirlantis

Do you want to do a merge request for this?


`replica_count` isn't used for striped so not sure if its worth warning the user


i


ù = problemi!


What does the -1 mean?


Each mock is a path and a status that should be returned. Header hash and body string are optional. The mock data is stored in the class variable for later. Note this is a class method so you don't need a real object to call it on to set up the mock.


I am not sure now if this is correct. However install.sh does not exist. There is also a /scripts/dsh-wrapper.sh but this looks to be not the installer but only the finder.


Clear out the mock hash when we want to reset.


@lpil thanks for the heads up earlier. I started updating my project that uses this and this module.concat really caught me by surprise.  I may not be the only one. I was expecting to set:

```elixir
config :dogma, :rule_set, Dogma.Rules.Sets.WhiteBreadCustom
# or
config :dogma, :rule_set, Foo.Bar.Whatever
```
This way you could go straight from looking at the config to looking at the rules used without having to remember/lookup what gets appended to the front.

What do you think?


呵呵


嗯


This is the business end. For each stored mock, run through the hash. If the path we're being asked for (`env["PATH_INFO"]`) matches the path key stored for the mock, return the stored mock response instead of passing through to the app. If none of those match, it will pass on the request up the stack at the end with `@app.call(env)`.


I see your point. Thanks!
Maybe I will try a fix which does not hide all buttons but instead allows to collapse certain graphs, though.


@blinkreaction, you will not want to merge this commit as links were switched to my fork repo. This was done so I could test with the fork repo.


Good job! :+1:


As far as I know there's no READ with invalidate in RoCE.


I see your point. Thanks!
Maybe I will try creating a fix which does not hide all buttons but instead allows to collapse certain graphs, though.


I'd prefer trailing commas for slightly tidier future diffs


Even with `stale=true` isn't there a chance that the index could finish rebuilding before this search returns anyway? At which point the result might not contain the `"llama"` doc at all. Currently that wouldn't fail the test and it probably shouldn't fail the test as it is valid behaviour, but it does mean that if the index rebuilds very quickly on test systems we might never actually get a `doc: null` returned to correctly test. Can we set up some kind of mock to just return hardcoded search result Json?


เนี่ย


a) you can use obj instead of self.objs[id_]
b) you can use isinstance instead of all this: it seems more idiomatic to me


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2280 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.31%25-yellow.svg)


This case is missing. With the next commit i will add it


So does the requestor task generate all the completions?


Please take care of that line (the way you prefer) and also add again the comment about using cascade to avoid inserting orphaned objects (with s/contests/root objects/). Then you can push.


I used this name because this structure is called "State vector" in the BINR exchange protocol


If you re-install `lme4` from github, it should work now.  I am rebuilding the `lme4_1.1-10.tar.gz` tar ball now and will replace the one in the glmmTMB (toplevel) directory in 15 minutes.


I'm not entirely sure I understand your need. If you don't specify a base URL then there's no URL to verify, and no sensitive environment to protect. This is the same as specifying a base URL of `None`.

If you implement your own `base_url` fixture, then the value returned will be checked against the `sensitive_url` value to protect sensitive environments. This can be disabled by overriding the `sensitive_url` fixture and returning `False` or by passing `None` (or any non-matching regular expression) as the sensitive URL value.

Correct me if I'm wrong, but the only use case I see that's not covered is overriding the `base_url` fixture but maintaining the verification?

How about a `--verify-base-url` command line option, which enables the additional checks. This means that by default we wouldn't verify the base URL, but it would be pretty simple to add this to `addopts` to enable it project/system wide. I could also add an environment variable to check. This keeps the syntax clear, and avoids added confusing negative command line options such as `--no-verify-base-url` or `--ignore-invalid-base-url`, etc.

It's worth noting that if the base URL is invalid then there's a good chance your tests will fail. The early verification is really to fail fast and prevent wasting time trying to test a site that's down.


とりあえずアルファベット順にしてみます :+1:


If prcopt->inittime set to 1, the time in the raw structure will not be initialized, and checking for the time difference in the message decoding function will not occur. This allows to proceed with the decoding even if the time in the message differs greatly from the actual time


remove blank line


What about changing this from info to debug...


I'll try to get to this in the next few days ... Sorry for the delay.  :-)


Sneaking this one in, let me know if you'd rather just add something to the README.

Sidenote: RxJava did some similar stuff recently in their unsafe package, and it makes proguarded apps using backpressure [blow up in fiery explosions.](https://github.com/ReactiveX/RxJava/issues/3097)


Why WARN_ON twice?
Also, please add some text to the kernel warning.


@ibek Would it be okay to change the parent to `performance-tests`?

Also, if the `performance-tests` module could be changed to `kie-performance-tests`, that would also be nice -- but that's just my personal preference.


Any change of getting a configurable *android:colorAccent* too? :D


And fixed a bug in Astar when no path is found


fixed it at next commit


Could you add a simple unittest for this so it doesn't get broken anymore.


Koen was having the same problem yesterday. He solved it by updating R. Glad you all tracked down the cause. Thanks!


@pollob666  - In this script 'id' is an auto increment field , please feel free to update this SQL with a new field that stores the bbs geo code , I think @nuhil  will agree :)

There is also a php class library that was retrieved from this repo, but improved where possible at  https://github.com/almaruf/bangladesh-administrative-areas/


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


good to see you supporting m4 ;)


Thanks for the hint, sure :)


did you check the commit referenced? It specifically moved that hunk to winrenderer:
https://github.com/wsnipex/xbmc/commit/80d44f908501dc1e44addcefece25c09050ef26d


Then you are perfectly right.


当不使用默认值的时候，需要调用一些设置方法，可能有用


コミットしないようにします　:pray:


We have updated this file with the required changes.


Well actually i think one could monitor both: Die `DisqueClient` and Disque itself. What metrics could the client expose? From what i know there's `getChannelCount()` and `getResourceCount()`


What about immediate data, src_qp, wc_flags?


Actually, on second thought, I think moving validation of date to date service would be nicer. Could you please have a look at 15fd0bb59f1


If the QP is in an error state, the completion should be with an error, but make_send_cqe() doesn't seem to have code that does that. Does something else updates the `wqe`'s status?


はい。

しばらく使うので後のコミットで消そうと思っていたデバッグコードですが。
他のコメントでも指摘を頂いたとおり、そもそもコミットに含めないようにします :+1:


hmmmm


@lasconic : I am confused; in the vtest I see the left-side image not kerned and the right-side image kerned; which is the current?

Also, I do not see any obvious difference between the "fz" pair and the others: in the left-side, it is not kerned as all the others and in the right-side image it is kerned as all the others.

I knew the code you point to, but I fail to see any hint that the MScoreText is referenced rather than mscore.

Lastly, I compiled with latest code and I get this (Linux Mint 17.1, Qt 5.3):
![dynamics](https://cloud.githubusercontent.com/assets/1420743/9461985/c613367e-4b12-11e5-9ad1-6ac172e57b15.png)
which to me looks not kerned.

Am I missing something?


SQL to update without running full oscommerce.sql

ALTER TABLE categories_description ADD categories_description TEXT NULL;


Does this mean the packet handled here must be a read or atomic response? It seems like this code can get called with any ack.


Спасибо. Я не знал механизм исключений, когда это писал :)


好的


This is weirdly formatted. I'd suggest using either `"%s" % start` or `"{path}"`.format(path=start).


replica_count does seem to be used according to the documentation here: http://gluster.readthedocs.org/en/latest/Administrator%20Guide/Setting%20Up%20Volumes/
However, it is now called a 'stripe count'.


ok


Why dumper need to read from STDIN? It's used to write file not read.

Maybe you mean to change reading file logic here: https://github.com/Homebrew/homebrew-bundle/blob/master/lib/bundle/utils.rb#L31-L41


tnx!


Maybe we can also leave this file, as e.g. logback_custom.xml, so that one can put particular level for particular packages and use this logback file when debugging.


right, however below you use `brick_count`


Yep what wsnipex said. Though you normally don't install any deps into the system on osx. (not even sure howto do so without building them via unified deps for example). There are some 3rd party package managers like brew or macports but they are nothing that is shipped with osx.


This commit is being reviewed as a part of review issue #49.


test


@houtanb Does this also check whether the integers are positive? I think this is a check that is performed for ```nobs```.


修正します m_ _ m


From what I understand, draining should be done until a message boundary. Won't this check pass for an ACK in the middle of a message?


yes


Don't include ScriptPCH.h directly but instead, include every header needed to compile your scripts.


`if(Cfg) {`

Возникают проблемы, если на борду заходишь *в первый раз*.


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2312 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.68%25-yellow.svg)


Connection details: Not only the count but which connections, the state of the connection, average latency/percentiles of 50, 90, 95, 99, 99.9 and in future releases perhaps even the cluster view etc.

I want that feature for lettuce, too, so some infrastructure there could be helpful. Metrics and JMX are two concerns and mixing these is usually not a good idea, because the next one wants to consume it differently. I had the idea of an internal publishing/event bus facility, similar to the Couchbase SDK. Take a look here: http://blog.couchbase.com/java-sdk-2.2.0-developer-preview-refresh

This approach is agnostic to how the metrics are consumed/exposed. So one could subscribe with JMX beans, the other one with a logger and so on. Does this make sense?


Escapowanie selected[i-1]


This looks good! I suppose this isn't going to work on my RPi model B because of the different pin assignment?


Why is this loop needed? Is there code waiting on the send queue when the QP is not valid?


I think we can make these checks more DRY, but let's try filing that upstream issue first.


this PR and https://github.com/lampepfl/dotty/pull/773/files used to be same branch in my local git repo.
After merging both indentation will be correct.


This (and the RESET state) looks repetitive. You can create helper functions to handle these cases.


I think it's `styleUtils` not `style`


hello,body


In this case disabling cache solves the problem. I could also put passwords non in clear as key, but with a HASH-256 + SALT + 1 iteration only. This would make things much harder.