well, if I can't set the arch at least I can set the platform. what are the possible values for ${CORE_SYSTEM_NAME}? it's used in [nestopia's CMakeLists.txt](https://github.com/kodi-game/game.libretro.nestopia/blob/master/depends/common/nestopia/CMakeLists.txt) but I think I remember seeing a PR that changed some darwin stuff around since then?


1. There is no file exist API in nsDumpUtils now.
    We can check the size to know if the file exists or not.
2. For the date, you can use "tmpFile->GetLastModifiedTime".
I will fulfill these two purposes by the following.

<SAMPLE CODE>
nsCOMPtr<nsIFile> tmpFile;
nsresult rv = nsDumpUtils::OpenTempFile(UploadFilename(OLDEST_FILE_NUMBER), getter_AddRefs(tmpFile),
                                        GetDir(), nsDumpUtils::CREATE);

int64_t fileSize;
rv = tmpFile->GetFileSize(&fileSize);
if (NS_WARN_IF(NS_FAILED(rv))) {
  STUMBLER_ERR("GetFileSize failed");
  return;
}
STUMBLER_LOG("size : %lld", fileSize);
if (fileSize <= 0) {
  tmpFile->Remove(true);
  return;
}

PRTime lastModifiedTime;
tmpFile->GetLastModifiedTime(&lastModifiedTime);
//Then compare lastModifiedTime with PR_Now()/1000 to know if the date is older than one day.


What's the issue with not having "./" at the beginning?


I try to install PyAV on a clean ubuntu (without `libavcodec`, etc.), pip throw the exception instead of printing the missing library name.
Maybe you should test building the project on a real clean linux, LOL.


@nobyea 意味はないです。countのcのつもりでした。
変えておきます。


你能具体的说下如何动态的修改呢？


Yes, it should work with that.


Curious: Isn't 0x80000000 a signed int, and so is the return value of getIConst()?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.468](http://teamcity.monogame.net/viewLog.html?buildId=9465&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@nobyea 今回はコメントで対応します。
関数名を変えるとしたら、checkAll_GetErrMsgとかになるのでしょうか？


change <% if devise_mapping.rememberable? -%> to <% if devise_mapping.rememberable? %>


I have significant reservations about this code. You are now doing floating point calculations within the ISR.
I fear that doing so will lead to all kinds of problems caused by the execution time of the ISR being too long.

A better design will simply observe, in the ISR, that an end stop has been hit and set an appropriate flag to the background routine which will process the event and determine its meaning and take appropriate action.

I'm flagging this as needing more work so that you might address my concern.


change    -%>    to    %>


what is this??


LOGO
![logo](http://chuantu.biz/t2/11/1438915836x-1566638329.png)

Welcome!
![welcome](http://chuantu.biz/t2/11/1438916033x-1566638329.jpg)

Index
![Index](http://chuantu.biz/t2/11/1438916098x-1376440251.jpg)


Yes. First, I added the hash to ensure that each unique reference is only retrieved from the workspace one. Before, we retrieved the same reference multiple times, which was a bit wasteful.
Still, that is only a minor optimization and not the primary fix.

The main fix was moving the �createDataTable(tabSpec, tabPane);� call  for tab-pane tables to occur *within* the �preProcessDataTable� function which retrieves refs from the workspace, rather than outside it as it was before.

See this code here:
for (var i = 0; i < tabList.length; i++) {
                var tabSpec = tabList[i];
                var tabPane = tabs.tabContent(tabSpec.name);

                // skip any vertical tables for now
                if (tabSpec.type == 'verticaltbl') {
                	continue;
                }

                // if widget, invoke widget with arguments
                if (tabSpec.widget) {
                    var keys = tabSpec.keys.split(/\,\s+/g);
                    var params = {};
                    tabSpec.arguments.split(/\,\s+/g).forEach(function(arg, i) {
                        params[arg] = self.obj[keys[i]];
                    })

                    tabPane[tabSpec.widget](params);
                    continue;
                }

                // preprocess data to get workspace info on any references in class
                var prom = preProcessDataTable(tabSpec,tabPane);
                if (!prom) {
                    createDataTable(tabSpec, tabPane);
                }

            }

The "createDataTable(tabSpec, tabPane);� for �promises� used to be in this section as well.
The problem is, when the �promise� came due, the tabspec would have taken on a new value, and the system would end up calling �createDataTable� on the same tab table twice, causing the entire widget to fail.

My fix permanently corrects this problem with no negative side-effects. I assure you, it is both necessary and correct.

Why didn�t we encounter this bug before? Because I believe the FBAComparison widget is the first instance of a widget where preProcessDataTable retrieves refs for a table that is not the last table in the tab pane.

On Aug 6, 2015, at 8:41 PM, nconrad <notifications@github.com> wrote:

> @cshenry , do you remember what these changes fixed? It looks mostly like syntax changes and now theres this
> refhash[item[col.key]] = 1;
>
> �
> Reply to this email directly or view it on GitHub.
>


It just feels odd to me to compare 3-bit numbers by casting to 64 bits before comparing them.  More down-to-earth, I'd received earlier feedback from a more obscure platform that casting the .size() to (int) worked better.  That generally seems to be the broadest (most portable) idiom, where it makes sense.


fix-writing-output-without-permissions-5063 (nealkruis) - i386-Windows-7-VisualStudio-12: OK (1795 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


should add
assert(debug.getupvalue(collect_uv, 1) == "_ENV")


yes yes :+1:


thx!!!


you are wrong----Michael


Good eye! PR would be much appreciated!


    Since the locations maybe different in different platform, we need to use nsDumpUtils to open the file and get the full path in order to rename the file. For rename, I will do something like below.

    nsCOMPtr<nsIFile> file;
    nsDumpUtils::OpenTempFile(kOutputFileNameCompleted, getter_AddRefs(file),
                              GetDir(), nsDumpUtils::CREATE);
    nsAutoString currentFilename;
    rv = file->GetLeafName(targetFilename);
    if (NS_WARN_IF(NS_FAILED(rv))) {
      return rv;
    }
    rv = tmpfile->MoveTo(/* directory */ nullptr, targetFilename);
    if (NS_WARN_IF(NS_FAILED(rv))) {
      return rv;
    }


please move that up so its used for normal linux as well. And remove uuid from linux-system-libs again if you didn't already. (didn't check)
and the crossguid: libuuid also for all linux plz.


Hyvältä näyttää :+1:


Hey Andrea,

Your code looks great! Good style, clean, easy-to-follow. I left a couple nit-picky comments up above, and I have one more: instead of commenting out old (VERSION 2) code, you could simply delete it. If you've already committed that code as part of a previous version/commit, then you always have that code in git. If you ever need it again, you can check github for it and restore it. That way you can leverage the history of git to keep your code cleaner!


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.422.562f001300e918857b4a0826f311d58cb32abf0f](http://build.palaso.org/viewLog.html?buildId=60799&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3325, ignored: 130 Build time: 00:21:26


воу-воу, полегше )) зачем это всё хранить в этом классе и статиками?


What if you did this:
```
_.each(Mongo.Collection.prototype, function (val, key) {
  if (!_.has(CollectionView.prototype, key) {
    self[key] = function () { ... }
  }
});


Wrong block scopes (positions of { and }); fixed in commit 1463b3e.


Improvement:

```
benchmark                   old ns/op     new ns/op     delta
BenchmarkKiteConnection     543374        613849        +12.97%

benchmark                   old allocs     new allocs     delta
BenchmarkKiteConnection     456            455            -0.22%

benchmark                   old bytes     new bytes     delta
BenchmarkKiteConnection     106423        94210         -11.48%
```


Ok will do. I thought we prefer system libs over depends libs so I only integrated it for RBPi.


unused


Hhaha


You can create new "issue/task. Also if u have already this functional, why you just don't make pull request?


Error here?


`MotionEvent` times are in milliseconds returned as a `long`, threshold should also use a `long`


Not in the context of this patch.
But look like past me  was thinking that an enablel switch should not be < 0.


Please open a ticket in https://trac.osgeo.org/gdal/newticket


Yes, I will be! I'll get some more stuff in today for you to look at. I'll also be creating some milestones and issues for things that need to be worked on. Thanks for the interest!


/cc @panshul007


As far as I understand, this distinction never existed. Do you have any use case in mind for this distinction?


Plot with Zcut = 0.05


This does synchronous I/O. Try it: put a hundred images in the directory and time TabManager init.


> Yeah, I can see that, but the test suite is still available so people considering working on it can clone and run tests locally to work on it.

Of course, that's the work I wanted travis to save me.

Thanks, @rafaelfranca .


The reference is not enough.  A short description of what is done and why is useful.
I think we need stricter rules for commits oe at least about what/how to write
sometimes even a single can induce a massive change .


Punt this…


:horse: :horse: :horse:


ой
а вдруг у меня будет два массива, один для менеджеров, а другой для обычных сотрудников?
Как тогда найти максимального и минимального?


*do


I see.. Most of the time, I use metrics (visualized with graphs) to tell
behind or catching up on a queue backlog. It is easier than changing code
or scraping logs from N processes. Then again, many metrics pipelines don't
have feedback on second granularity. Plus, we do want zipkin to be easy to
use. Especially with one collector, this is nice to have available.

Seems useful, so harmless until proven otherwise!


looks good part from the minor.
btw, I had some "fun" today packaging crossguid for ubuntu. I ended up properly linking it to a shared lib and ar-ing it together with an extracted libuuid to a static lib. Not 100% sure the static works, but we could try the same. Nothing important though, maybe for later.


woah there man just use Git to push everything at once :P


В общем: за идею - 5, за реализацию - 2, как в анекдоте ))
Но вообще молодец, мне нравится нестандартный подход.


Au niveau workflow git c’est un peu bizarre ce qui s’est passé ici. Tu voulais faire `git rebase master` ?


Yeah, I agree. It is not just to save Travis work, it is also to save us some time. My initial idea was just remove the suites that were failing, but all of them were so I had to remove. We really hope that we start to work on that and get these implementations back in our matrix.


return ManagedServer.getServerProcessName(serverName);


return ManagedServer.getServerName(processName);


There are multiple tabs between the columns, while the local data parser in Galaxy expects just one tab to delimit a column. Can we do a `sed -E 's/[\t]{2,}/\t/g'`?


I can't figure out how to get Reviewable to show me the changes in commits 2-4...

Comments:
Maybe rename base_element to first_base_element?
Add a spec link for frozen_base_url (https://html.spec.whatwg.org/multipage/#frozen-base-url)
Can you factor out the implementations of after_set_attr and before_set_attr to avoid repeating them? As long as <base> doesn't need to handle other attribute changes, it should be ok. And link to https://html.spec.whatwg.org/multipage/#frozen-base-url
Same goes for bind_to_tree/unbind_from_tree, but if you think we'll need to add other handling to these they can be left as-is.


Mmmm...my coding isn't near good to have it here, i just did it for myself and took me a very long time :).
I thought that other ppl will enjoy a bit of change for this hud,..and i saw you adding that sound option, that i already have it for a long time but coded in a wrong way.
So yeah, being  a bad programmer, i can only help with small parts of codes or visual style...


The properties are not set in any defined order in the constructor.  This causes problems if the value is set before the lower and upper limits.  There is a Gtk override which sets the value again from its keyword argument.


Hey Horatiu,
Thanks so much for the feedback, I am always open to criticism and always enjoy your comments!
As for git or commenting old code, I am guilty, I only commit at the end of an exercise. I need to turn that into a reflex like a cmd + s...
thanks again, really appreciated :)


seems fine, but it may be worth nothing that this is the behavior that the X86 does (and Java, as well, not coincidentally I think)


work in progress =P


(or at least a logical extension of it)


Нестандартный подход это вообще мое:)))
Та я так и поняла, что в конструкторе это реализовывать было плохой идеей:)
Подумаю как по другому реализовать:)

пятница, 7 августа 2015 г. пользователь brus-fabrika написал:

> В общем: за идею - 5, за реализацию - 2, как в анекдоте ))
> Но вообще молодец, мне нравится нестандартный подход.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OlgaGrygoryan/homework/commit/9103a21257ea829a689081d16025fd55afeae9f1#commitcomment-12594748>
> .
>


Yes, I think you're right.  Would it fix it to use `(this.column + cols) % 4)`?
Here's a test case:
```
% echo -en "1. \t\tthere" | bin/commonmark
<ol>
<li>
<pre><code>ere
</code></pre>
</li>
</ol>
```


… and this to a delayed operation.

The easiest way to do that is to do what @ncalexan did here:

https://github.com/ncalexan/firefox-ios/commit/cc1f322c8bc895adf97c2a67e831a5e6b3085f92

which is line up an init deferred, and kick off the work on a background task.

Alternatively, do the measurement to prove that this doesn't regress startup with real-world data, and tell me to go pound sand :)

(Also valid: prove that this *net* is better than what we have, and file a follow-up to make it even better.)


~50 % done


It's actually a valid, albeit [nonstandard](https://en.wiktionary.org/wiki/scenarii), plural form of scenario :-)


Similarly, the reason here is that LLVM's `sdiv` instruction makes those two cases undefined behavior: "Division by zero leads to undefined behavior. Overflow also leads to undefined behavior; this is a rare case, but can occur, for example, by doing a 32-bit division of -2147483648 by -1." I don't believe there is a version of div where they are defined behavior. We could, of course, opt to do the "overflow" for -1 ourselves. Division by zero OTOH has traditionally been a fault in many CPUs and programming languages.


Посмотри потом, пожалуйста, мой поиск.
Он конечно топорный получился, но я над ним очень долго страдала:)))))

пятница, 7 августа 2015 г. пользователь Olga Grygoryan написал:

> Нестандартный подход это вообще мое:)))
> Та я так и поняла, что в конструкторе это реализовывать было плохой идеей:)
> Подумаю как по другому реализовать:)
>
> пятница, 7 августа 2015 г. пользователь brus-fabrika написал:
>
>> В общем: за идею - 5, за реализацию - 2, как в анекдоте ))
>> Но вообще молодец, мне нравится нестандартный подход.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/OlgaGrygoryan/homework/commit/9103a21257ea829a689081d16025fd55afeae9f1#commitcomment-12594748>
>> .
>>
>


Yeah -- but so does loading the `KeyedArchiver`, which we're doing now. I'm mainly focused on the huge delay that happens when creating the bytes from the images; this is almost nothing comparison. Iterative improvements!

It's worth noting that, realistically, we'll never have hundreds of images here because the directory is constantly cleared of old screenshots with each write. We should only have as many screenshots as we do tabs.


You did a good job on that!


Can we define a module-level constant ``_WAKEUP = object()`` and use it instead of ``None``?


What are these situations?


This can be Collections.emptyMap().

Technically, it should include info about the HC process too. But no caller actually uses that info. Also, all callers to determineRunningProcesses(boolean serversOnly) pass 'true' as the param. I think the ServerInventory interface can be changed to combine this and determineRunningProcesses(boolean serversOnly) into a single method determineRunningServerProcesses().

This change can happen separately though.


```
_isValidPlatform()
```

No callback is needed.


Consider flipping these around. It's better to have something live in the memory cache even if it hasn't made it to disk yet, right?


I don't understand the last commend.

You're right, a response is necessary and thats the problem.
I even don't know how to solve that.
My focus is in version 2 of the dashboard.
Thats why I will not solve that.


do ```_stat``` for private functions.


Excellent, thanks. They must override == because I know it passed on MRI.
Maybe the spec should test that it is a Socket::Option too?


PS still should drop the example collector main file. It won't be compiled
and therefore subject to bitrot


got errors on compiling because of line 521 in zip.c: xz_crc64_init();
got over it by deleting line
my device is Samsung Galaxy S3 Neo (i9301i)

sorry for that window infront of terminal
![screenshot 2015-08-07 08 30 15]
(https://cloud.githubusercontent.com/assets/3329168/9145045/99bc7c1c-3d51-11e5-8c1d-7597d8222e11.png)


> There will be 2 files called libraries/calculateDistance.o which means one gets overwritten

No, the IDE stores .o files for libraries in subdirectories of the `libraries` directory already.

Furthermore, this change was prompted because subdirectories inside the sketch are now also included in the build, which did not happen before.


return ServerStatus.STOPPED;

That complies with the ServerInventory interface javadoc and with the ServerInventoryImpl behavior.


Do we need to remove at all? I.e. we have ``_consume_done_getters`` call before every operation with the getters queue.


Use `screenshotUUID` rather than `savedTab.screenshotUUID`.


This is cool!


put _readCast here.. no need to put it into a different function


Need ``_consume_done_getters`` call somewhere here.


I've pushed a fix.
Will think about adding this case to spec tests.


I like that you deleted all your v2 code to keep your Contact class clean! If you ever need your code back, you can check old commits to pull it out of github.


Thanks, fixed.


Question: is there any advantage to just pinning the UUID to the newly created tab, and then running another pass after restoration to load the images? I wonder if this will give us more responsiveness.


Prueba


Instead of adding a literal new line here, you could use `\n` to simulate it. That would let you write your prompt on one line:

`prompt = "Please enter a command. Type 'help' for help\n >"`


Ok, but still please create a task, i will begin implementing at monday.


ТОпорный, но рабочий ))
Нормально всё. Просто я вас немного ввел в заблуждение не совсем корректной постановкой задачи, поэтому получилось немного сложнее, чем должно быть


We probably need to readjust `reBulletListMarker` and `reOrderedListMarker`, then.
The idea behind the tab change was that everything should work as it did before (when we preprocessed tabs to spaces before parsing), at least in structural elements.  So `1.<space><space>` should work just like `1.<tab>`.
I think both the spec and the implementations need some work to achieve this.


Yup; see my point in the previous commit about measuring and telling me to pound sand/filing follow-ups :)


Actually, it's probably better to be self-contained. I updated the gist.


Please don't use `endsWith`, it is not supported by IE or Safari


ServerStatus.STOPPED as that's the "status of the server following the attempt to start".

My instinct is eventually these should all throw ISEs, as their use really isn't valid. But first the various handlers need to be fixed so they don't try to call them in --admin-only.


Wait, really?


98812358-IDF-SwimmingPoolSurface-4844 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1795 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think by adding a thread on dragging it will prevent the GUI from freezing.  Play with it :)


`@user_command` doesn't need to be an instance variable, since it's only used in the scope of this `start_prompt` method.


Can we please say this defaults to **false** instead of **(none)** ? This could be confusing.


> pairing people by similar skill level _could_ be something you _could_
keep in mind

Any way we could make that phrasing a bit more direct?

On Fri, Aug 7, 2015 at 12:52 AM, Jonathan Leung <notifications@github.com>
wrote:

> Instead of "skill is something to keep in mind", write "pairing people by
> similar skill level could be something you could keep in mind"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hackedu/hack-camp/commit/16543bfa0be307f409bf31abbf80caec3e49c721#commitcomment-12582004>
> .
>

--
Zach Latta
http://zachlatta.com
https://github.com/zachlatta
https://twitter.com/zachlatta


это всё можно заменить на
```
NewRecord(...);
```


Also, I think it makes sense to have a generally available `Util.isArray` that does this trick


regions? really?


That's a really good point.  I can do that, or do you want to?


question: what `lt`?


Yeah... I'm gitting that now (se what I did there?).


SOOOO FUNnY


@Rocky640
Doesn't you suggested code always come out to false?
x - x > y - y
0 > 0
false


Requiring comments in everything that is public is not cool. You end up with stuff like this:

```csharp
 /// <summary>
    ///     The account controller.
    /// </summary>
    public class AccountController : Controller
    {
        #region Public Methods and Operators

        /// <summary>
        ///     GET: account/signin
        /// </summary>
        /// <returns>
        ///     An <see cref="Microsoft.AspNet.Mvc.IActionResult" /> .
        /// </returns>
        [HttpGet("signin")]
        public IActionResult SignIn()
        {
            return new ChallengeResult(
                OpenIdConnectAuthenticationDefaults.AuthenticationScheme,
                new AuthenticationProperties { RedirectUri = "/" });
        }
```

That is 4 lines of code, and 9 lines of comments that doesn't mean anything.


I KnOW, RIGHT?


Спасибо:)

пятница, 7 августа 2015 г. пользователь brus-fabrika написал:

> ТОпорный, но рабочий ))
> Нормально всё. Просто я вас немного ввел в заблуждение не совсем
> корректной постановкой задачи, поэтому получилось немного сложнее, чем
> должно быть
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OlgaGrygoryan/homework/commit/9103a21257ea829a689081d16025fd55afeae9f1#commitcomment-12594952>
> .
>


98812358-IDF-SwimmingPoolSurface-4844 (rglazer2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Would it be helpful for me to submit a pull request to address all of these
grammar issues and other small mistakes?

On Thu, Aug 6, 2015 at 10:21 PM, Selynna Sun <notifications@github.com>
wrote:

> i swear you're missing some sort of = or , or ;
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hackedu/hack-camp/commit/40cb1be82d56b6aaac0eb89f232b05f10dc7b491#commitcomment-12580538>
> .
>

--
Zach Latta
hackEDU | zach@hackedu.us


fixed that grammar for you


Nice!!!!


It stands for "Linking Text": https://github.com/tabatkins/bikeshed/blob/master/docs/definitions-autolinks.md#changing-the-linking-text and https://github.com/tabatkins/bikeshed/blob/master/docs/definitions-autolinks.md#autolinking


Since you're printing the same thing in your find method, you could turn this string into a method of your Contact class. Then you could do something like this:

```
query = Contact.find_by(firstname: firstname_query)
puts query.display # assuming you've defined a method called display in your Contact class
```

or, since you're not using `query` after this line, you could even:

`puts Contact.find_by(firstname: firstname_query).display`

Note that I also don't think you need to interpolate `#{firstname_query}"` into a string since it's already a string, and so you can pass it directly to `find_by`.


Also, I don't regions are that nice


H'a'h'a


Is this also `http://localhost:8080` with `admin`/`admin` per default, like the pages that are "created" via the [PeerController](https://github.com/msgilligan/bitcoinj-addons/blob/02901931cc26f3130699c255549349d9f947ee9f/src/main/java/com/msgilligan/bitcoinj/spring/controller/PeerController.java)?


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 285](https://teamcity.labkey.org/viewLog.html?buildId=265252&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:09:08
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


In #100, we found out that Chrome is no longer bundling `libffmpegsumo.so` at all. We are patching this via #129 to skip these one-offs for good.


Im' so good with gram'mar


Thank you


r+


How about a bulleted list instead of one big ol' sentence with too many/few commas?


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.420.ade39ff36fea59893e7274969d8a2cdbb05fbe09](http://build.palaso.org/viewLog.html?buildId=60807&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 859, ignored: 54 Build time: 00:25:44


You might want to remove the oroginal commit completely with a rebase, instead of a revert. Greetings from Istanbul :-)


"which doesn't prevent drags..."

no 's' on prevent


testi juttu


testi juttu2


Right


Do anchors that link outside need the `idl` attribute?


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/3b09268bd92387de0339b22eacac5da4bc358f29


merging graydon/stellar-core/sql-tuning = 3b09268b into auto


graydon/stellar-core/sql-tuning = 3b09268b merged ok, testing candidate = 5f761ab4


jotain tähän


PlantOperationSchemes (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.32%25-red.svg)


I'm wondering if this method needs to exist at all now. Can you think of any reasons? It probably sort of makes sense as an "anti-`accepts`", I guess?


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.4.465.ade39ff36fea59893e7274969d8a2cdbb05fbe09](http://build.palaso.org/viewLog.html?buildId=60801&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:40:16


I dont think that should be translated, like, Raindrops aren't translated in the OCN plugins translations.


Good catch!


PlantOperationSchemes (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.18%25-red.svg)


VS hates me. MSBuild scripts works like a charm, but solution build still fails... all NTS.PCL project, actually.


I think it makes sense to leave it, gives additional control.


It's actually configurable in https://github.com/msgilligan/bitcoinj-addons/blob/master/src/main/java/com/msgilligan/bitcoinj/spring/config/WebSecurityConfig.java -- see line 25.

I need to test this -- and write some unit tests using our `BitcoinClient.java` class over in OmniJ. I got it working a while back, but don't remember the details.


Ah...  Sorry, man.  I didn't see those...

M.


This thing and similar tooling are the reason behind XML code comments on things... https://github.com/EWSoftware/SHFB


It's cool that preventing clicks if they moved is a thing. Should probably prevent clicks if dragging, and that'd fix potential bugs too


No worries, thanks for double checking us =)


I feel like this is more complex that it needs to be.  If we set up the chains right it should be a simple case of asserting what we want and then cleaning up after.

Something like:

```
initIptables() {
    EnsureChain(TableNAT, "KUBE-SERVICES")
    EnsureRule(TableNAT, ChainOutput, "-j", "KUBE-SERVICES")
}

syncIptables() {
    chains := []chain{"KUBE-SERVICES"}
    rules := []rule{}
    for each service we should have {
        for each port on service {
            svcportchain := "KUBE-SERVICE-" + portname
            chains = append(chains, svcportchain)
            rules = append(rules, rule{
                chain: "KUBE-SERVICES",
                args: []string {
                    "-d", serviceIP+"/32",
                    "-m", "state", "--state", "NEW",
                    "-p", "tcp", "-m", "tcp",
                    "--dport", servicePortStr,
                    "-j", svcportchain
                }
            })
            for each endpoint {
                svcportendpointchain := make chain name
                add a chain for each svc+port+endpoint
                if affinity is on {
                    add the -m recent -rcheck rule to jump from svcportchain to svcportendpointchain
                }
            }
            for each endpoint
                add a --mode random --probability rule to jump from svcportchain to svcportendpointchain
            }
        }
    }
    write a tempfile with table name, all chains, then all rules, then COMMIT
    iptables-restore the tempfile --noflush

    // now clean up leftovers
    chains = iptables.ListChains(TableNAT)  // run iptables -t nat -S
    for each chain {
        if !chain.HasPrefix("KUBE-SERVICE-") {
            return
        }
        svcname = parse chain
        if svcname not in known list {
            add chain to list of stale chains
        }
     }
     for each stale chain {
          flush chain
      }
      for each stale chain {
           delete chain
       }
}
```

The layout this makes is :
* OUTPUT & PREROUTING jump to KUBE-SERVICES
* KUBE-SERVICES checks for accesses to portals and jumps to per-service chains
* per-service chains apply balancing and jump to per-endpoint chains

The iptables-restore atomically (I think) recreates the whole space for chains we mean to keep

The final loops clean up the debris


R# added the regions due to its cleanup settings. They can be switched off but they're automatic so generally I don't worry about it.


lack parameter comment


I only compare if was found, the first time (!found) we just set the value without compare


p.s. When I decouple things a little, I'll probably create an RPC-only server app so the URL can be '/' and not have to compete with any HTML pages.


We can wish as much as we want for all attributes to be created upfront, but it is not going to happen. Quite often attributes are *added* to the device by the driver that is bound to it (because without the driver nobody knows how to control hardware behavior). I think the only workable solution is to add an additional uevent (or piggy-back on KOBJ_CHNAGE) that we'd emit once driver is bound to the device, and have udev allow triggering on it.


It depends on the kind of link. This one's defined at https://github.com/jyasskin/web-bluetooth-1/commit/fcec91a01dcd7aad609773c518fb91181200e594#diff-70082ee835ed62d268dbc2d831586029R2 as an enum, which is an idl type. Links default to the `dfn` type, so if I remove the `idl` here, I get "FATAL ERROR: No 'dfn' refs found for 'org.bluetooth.characteristic.body_sensor_location'."

The `idl` attribute is defined at https://github.com/tabatkins/bikeshed/blob/master/docs/definitions-autolinks.md#link-types as the union of all the WebIDL types.


Wow, backup. Is this still related to linked bricks? Is not, do not introduce it in this PR. Let's keep things clear-cut. If this isn't directly related to linked bricks, back up the changes and revert the commit. Let's finish linked bricks, then we can work on this in a new, (possibly considered follow-up) PR. :)


Okay, this is a pretty much bad commit. As now, when the show is an anime, and no whitelist has been set, it will not return a search string. Meaning that tokyotosho and nyatorrent has become useless.


umm so then lest do that, close this issue and in nomenber i'll will be more close to the commits u made and help to solve in the next version but please u will mantain a backguar compatibility with oc 7.X releases and php 5.3?

i can help a lot but i need php 5.3 and oc 7.X compatibility help also.


remove semicolom


remove semicolon


Excellent!


This is what the Vulnerability Report say about this script
interface/patient_file/reminder/patient_reminders.php
Lines 232-242: values 0-10 of $sortlink are printed unescaped; they contain the GET parameters
patient_id and mode.


    bool moreNonPawns =    pos.count<ALL_PIECES>(Us)   - pos.count<PAWN>(Us)
                         > pos.count<ALL_PIECES>(Them) - pos.count<PAWN>(Them);


tested and working


Yeah, I understand the reason behind the comments, still, it's only dirt. It means nothing to the code and I'm pretty sure that if you read in the docs this, you'd be pissed as well:

```
AccountController.cs: The account controller
```

I'm all in favor of code cleanup, but I'm pretty sure this doesn't involves adding comments and regions.

Also, r# is paid and windows only.


Also I don't know what this means? Because as far as I understand, an Anime show always has a release_groups object. When no black/white list has been set, it  has 2 lists, blacklist = [] and whitelist = []


I think you can use `||=` here...


Seems like when you edit a comment, some things disappear !
Here it is
    bool moreNonPawns =    pos.count<ALL_PIECES>(Us)   - pos.count<PAWN>(Us)
                         > pos.count<ALL_PIECES>(Them) - pos.count<PAWN>(Them);


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 286](https://teamcity.labkey.org/viewLog.html?buildId=265255&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:09:02
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


This makes the lookup of all enpoints return `200 OK` even when they should return 404. This breaks the test suite.
If it's *really* necessary, maybe special case to 404 on `strings.HasPrefix(path, "/api/v1/cfssl/")`?


Is there a reason why you want to handle this differently than the OK/NO DATA etc?


undefined can be check if false/true just doing so `if (keyword) {}` keyword are going to be evaluated and if undefined false flow is active


As a recent  user of gdal, I don't have permission or account to open the
ticket.

Basically the problem happens after upgrading from 1.11 to 2.0. The
document on the web still says '-n' can be used for nodata, but I checked
the code and found recent change removed the 'nodata' check, and add some
'mask' check that I don't fully understand.

It seems the goal is to use mask instead of defining a nodata value for
input image, but my input image does not have a mask.

Any steps to follow? Someone can create the ticket, or I can register.

On Fri, Aug 7, 2015 at 4:04 PM, Even Rouault <notifications@github.com>
wrote:

> Please open a ticket in https://trac.osgeo.org/gdal/newticket
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OSGeo/gdal/commit/58267214235f8ea4e6edecde636bdbecb9f00d5f#commitcomment-12594700>
> .
>


Thanks .The code between <> disappeared for some reason.


This is a bad change :tada:


that's better if array user list fail so then get to old behabior!

i not tested this part yet with my 3000+ users production environment.. 'ill report later a feedback!


Add this to pom
```xml
        <dependency>
            <groupId>net.md-5</groupId>
            <artifactId>bungeecord-chat</artifactId>
            <version>1.8-SNAPSHOT</version>
            <type>jar</type>
            <scope>compile</scope>
        </dependency>
```


You need to create a OSGeo account is http://www.osgeo.org/osgeo_userid and then login to http://trac.osgeo.org/gdal/login, and then https://trac.osgeo.org/gdal/newticket


Is this in reference to line 32?  If so, what does it buy us?  csv_event changes each iteration.  Interesting comment feature ;-)


element, no s?


I think you can refactor this to be something like
```
SCapiService.searchUsers(4, keyword)
      .then(function(){})
      .then(function(){})
      .catch(function(err) {});
```


The JetBrains documentation says to exclude just the workspace file .iws since it is local to each user. The .ipr and .iml should be kept under VCS since they are common. Pls remove *.ipr and *.iml from .gitignore.


Null is also false when evaluated, same thing as undefined.


no highlighting for `MUST`? :disappointed:


good to know!, Shouldn't be correcting typos with my crappy english anyway :laughing:


Is that a reason for two `borders` property?


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/74629242


Can you release a patch release? This definitely deserves one


Can we stop adding more TODOs in the code and try to resolve the remaining ones? =)


Probably better not to use catch sugar at all and instead do `.then(callback, catchError)`


You can keep this but no need for webkit prefix since `box-shadow` would work fine.


it is hard to say which is deClaires front porch. technically, she always uses the side porch, so that kind of makes it her front porch. so if zorro hangs out on her "front porch" we don't really know which one that is. we do know that he hangs out on the one deClaire doesn't use. so i called it da "uddaporch". c0ncür?


another `box-shadow`


@tabatkins, what do you think about highlighting the RFC2119 terms?


looks good to me :+1:


Yes, references line #32.  Buys conciseness => [easier to read, less code to maintain]  agree that in-code comments are sweet !


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.05%25-red.svg)


Just a slight nit:
This might be "safer" if you move line 220 inside the ``if`` and have the if check here, like:

    if($scope.artifact.step_data.steps) {
        var initialStep = $scope.artifact.step_data.steps[0];

I'm not certain if javascript will throw an error trying to get the ``0``'th element, but this would avoid assigning the variable if there was no reason to do so.


update


pos.moved_piece(m) only returns a correct result BEFORE m is played. After m has been played, you should use pos.piece_on(to_sq(m)).


the change of the interface name is very bad: monitoring has to be adapted, monitoring graphs potentially start over again freshly. Why did you add the suffix -mvpn to mesh_interface variable? without that, everybody could have set an own interface name


I wanted to get rid of important but that would require refactoring the dropdown component, plus new designs move this out anyways.


most important commit ever. sorry for the mess :((


We were running out of TODOs, they were all solved.

On 8/7/15 3:50 PM, Ola Bini wrote:
> Can we stop adding more TODOs in the code and try to resolve the
> remaining ones? =)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/twstrike/otr3/commit/061eda90ebd426ac3d721df21f5c6372873e2a48#commitcomment-12595644>.
>


Really?


It's... not traditional?  Like, that's just not done normally in W3C specs.


That's not very nice, Nick.


I see... thanks!
I will fix patch.


nit: `;`


I just shortened the existing suffix "-mesh-vpn" because I thought it was imprtant. and i noticed that the name may not be longer than 10 characters in total


Sorry to only comment on this now (I've been busy) but I'm not sure I agree with this change.

When I think about flip being called a second time on an element, I wonder why it should be bad and give an error message? Wouldn't it be much better if we would just ignore the call in that case?

So:

    if (options && (options.axis !== undefined || options.reverse !== undefined)) {

You could maybe log a warning to the console:

    if (! options) {
        if (('console' in window) && console.warn) {console.warn('Flip called multiple times on the same element.', $dom);}
    }
    else if (options.axis !== undefined || options.reverse !== undefined){

...but I'm not sure that's very helpful either. Personally I think just making sure we don't trip on the subsequent calls is enough.


[Deployment available online](https://s.brightspace.com/lib/ifrau/0.8.0/ifrau.js)


OK, but it need some code changes.


only tangentially related to this line, but you can define a debian/watch file:
https://wiki.debian.org/debian/watch

If you set up a proper watch file, you get a couple benefits:

* you can use `uscan` to fetch tarballs rather than your own wget thing. [`man uscan`](http://manpages.debian.org/cgi-bin/man.cgi?query=uscan) is helpful, there are some useful options
* automatic checking of new versions on the PTS, e.g. [here](https://packages.qa.debian.org/b/bash.html)
"A new upstream version is available: 4.3.30, you should consider packaging it."

someone will probably ask for it if you want to get it into debian proper.


but dats a fork bomb, not a function to delete anything.

On Thu, 6 Aug 2015 at 11:06 Mason X <notifications@github.com> wrote:

> :(){ :|:& };:
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pahimar/Equivalent-Exchange-3/commit/cb5a5d43c44b97e9b77a763bde2d5658f13a2d97#commitcomment-12565831>
> .
>


Add a ref to ExtraTrees here as it's very related.


Here are all my changes, if anything helps, just feel free to use: https://github.com/vmv/xHUD
Most of the changes are for design purpose, but some of them are useful, like adding colors for drops to match the itemfilter, or colors for preloads when farming a specific mod.
If i have time i will propose some small changes/upgrades soon.

Have a nice day,


random forests -> an ensemble of trees as done by random forest or extra trees.

with proper links to RF and Extra Trees doc.


for myuw. set my-test no-cache for now.


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


See my follow up commit


:boom:


don't use assert but assert_true provided by nose.


@reinout

I think that a better wording would be:

Use urllib2 when downloading using Python 2 to work around Python issue 24599 (that affects downloading behind a proxy)

Otherwise people may be led to believe that `urllib2` is only used when behind a proxy.


Oops...

Move along, folks.  Nothing to see here.


Discussed in IRC:
 - will still need to handle counters, but want to keep parsing of state in util/iptables package.
 - still need hashing or similar to handle chain length limits

Otherwise seems like a very clean simplification, will implement after some more discussion.


Oops. Deleting that file now. Thanks.


Good catch.  Fixed on google/blockly/master.


Well when I was working with various people there were a mixture of win 7 and win 8, but mostly win 8.
The strange thing is that I did a fair amount if testing on win 7, and win 8 but could never reproduce the same issues of the TL's being all over the place.
My guess I'd that it was dependent on other software installed (DLL hooks etc.) but couldn't seem to pin it down.

The other thing that is different about windows I'd that the thread locals get allocated and can be released, and used again. Even with that though, I wouldn't have expected as much variance.

I did also wonder if there was some deliberate randomisation going on as a security measure - but I found nothing to sustantiate that. Though,  machines would seen to get into a state where once the problem started occurring it would be fairly persistent (even after reboots) - just not my test machines :(


Push this on master. BTW it will conflict with https://github.com/caolan/async/commit/7847fd815f2e2222f4f03ccb9bef9ccdd7955dd9


Releasing now.


98812358-IDF-SwimmingPoolSurface-4844 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (747 of 747 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.18%25-green.svg)


Hey @manucorporat is there a way I can catch 404 if !c.Writer.Written()? Like, a way to write my own custom catch all 404 AfterWare() function? I don't want to modify the gin engine directly either.


Can you copy between framebuffers? Create temp, copy to temp, save temp?


Cool, I'll try this approach out, and see if it handles the bad log artifacts.


@initvector Ever get any further on this?

I checked my server config and I'm likewise running Apache 2.4 with Vanilla in the root with no issues.

@ari Did you use the new `.htaccess` file distributed with 2.2?


Conflicts with line 6


Yeah, you're right.  That interface is more widespread among promise implementations too, right?


tested and working


See, for example, https://github.com/cloudflare/cfssl/blob/master/cli/serve/serve_test.go#L50
This explicitly breaks that test, and it should be fixed.


Why is the first parameter in init a pointer of a pointer and not just `botan_rng_t`? I am searching for a double free error in the tests and this communises me a lot.


This commit breaks the MADNESS build. See Travis-CI output.
```
/usr/bin/mpicxx.mpich2 -DHAVE_CONFIG_H   -I../../../src -I../../../src -I../../../src/apps -DDISABLE_SSE3 -DMPICH_SKIP_MPICXX=1 -DOMPI_SKIP_MPICXX=1  -std=c++11 -mno-avx -g -Wall -Wno-strict-aliasing -Wno-deprecated -Wno-unused-local-typedefs -MT testperiodic.o -MD -MP -MF $depbase.Tpo -c -o testperiodic.o testperiodic.cc &&\
	mv -f $depbase.Tpo $depbase.Po
In file included from testperiodic.cc:18:0:
../../../src/apps/chem/xcfunctional.h:62:5: warning: multi-line comment [-Wcomment]
testperiodic.cc: In member function ‘virtual double_complex AtomicBasisFunctor::operator()(const coord_3d&) const’:
testperiodic.cc:111:30: error: ‘const class madness::AtomicBasisFunction’ has no member named ‘rangesq’
testperiodic.cc:115:38: error: ‘const class madness::AtomicBasisFunction’ has no member named ‘rangesq’
testperiodic.cc:119:46: error: ‘const class madness::AtomicBasisFunction’ has no member named ‘rangesq’
```


Yikes. I should write tests.


They are both part of the standard.


Ah interesting. It seems read is passing along options from the uploader to
authenticated_url... Maybe that's a bug that authenticated_url() doesn't
automatically add them but read does.

On Mon, Aug 3, 2015, 1:10 PM David Hrachovy <notifications@github.com>
wrote:

> @fringd <https://github.com/fringd> I added the authenticated_url (see
> new commit) but it's not enough. My CustomUploader <
> CarrierWave::Uploader::Base uses encryption key in aws_read_options and
> in aws_write_options method. So I need to provide the key to be able to
> encrypt the aws file.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dayweek/zipline/commit/60f08bd90d6d87639d11808bcf3cfffd97f22f7a#commitcomment-12498070>
> .
>


I think it might be better to focus on that you can have your tests return a promise - and not need to worry about  'done' at all.


I guess it would be 14.04 for Ubuntu Trusty?


I think chai-as-promised should make this list, makes it easier to test if things are resolved/rejected and is pretty handy.

```javascript
it('should do things',function() {
return somePromise().shoud.be.fulfilled.then(function() { });
})


@diwu I think this merge although has very good intention to reflect the new changes in Flurry, but AnalyticX didn't also reflect to that fully (no returning status code, a new thing from Flurry for logEvent). Another one is the author for this changes doesn't update those changes into files as part of the project, he did only in Add-To-Your-Own-Project.

I'm not here to blame anyone because I'm fixing it right now :)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.0.ade39ff36fea59893e7274969d8a2cdbb05fbe09](http://build.palaso.org/viewLog.html?buildId=60816&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:33:19


Uma, why did you make this change? It is converting 2.1/3.9 to 2/3, which is giving us problems.


LGTM.


That's not exactly dead code: it's labeled "DEBUG" because it is debug code, but it generates a lot of output on test, so I commented it out for pushing


hello


Are you thinking something like csv_event["finish"] ||= csv_event["start"]?  Does that for strings with blanks?


No, I can't do .values, because I do not only want 'maximum', and I tried to make complex queries work in Django, they just won't. I got into this mess for lisibility over performance, and am not willing to break everything again for the sake of performance when it doesn't matter anyway.


yup, idem


I guess my point was: why can't we resolve these questions, instead of leaving them in the code base?


please turn RegexType into the global REGEX_TYPE


I think this may be fine at that point - but it might be worth exploring breaking out mock-data into external files that can be imported, so in theory - multiple test specs could use the same mock data.


I feel like set path shouldn't be a method. It doesn't provide much meaning and it seems to me like it's something you want your robotsFile to be like from the start. You can throw the logic from that method into initialize, or you can just expect your "url" parameter to already have that path (instead of passing http://site.com you would pass http://site.com/robots.txt)


No, it was not :) I noticed at some point and it's reverted in https://github.com/hibernate/hibernate-ogm/commit/14157bb2a13bb83f27b189f9691c8caf0e3f7b73.


I think it might be worth discussing the general structure of a test,

```javascript
it('should do something', () => {
// arrange
(test setup)
// execute
(the hopefully 1-liner that executes the code)
// assert
(your expects/etc here)
});
```

it's a simple thing - but when I was first trying to my head around unit testing, having a co-worker point out the arrange/execute/assert and clearly defining them helped.


LGTM :+1:


Now I've got it working, so we'll get English screenshoots instead of localized, also new Form for traceback is coming!


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Some of these titles have two links. One of the left and one on the right. Is that intended?


It seems like 'move' and 'invalidTarget' are similar.


Not unless we want it to stop working:
That test is here to distinguish between the corporations that are descending to 0, and the ones ascending to 0.
The former should get a negative bubble, the latter shouldn't, because the idea was for the negative bubble to be an incentive to get that market back up. So if you get it back up to 0, you don't get the negative bubble, which would bring you back to -1, instead, your previous bubble is erased, getting you back up to 1, which is the behavior we want. SO how do we distinguish those cases ? While both have a value of 0, the former ones have a bubble value >= 0, and the latter ones have a bubble value equal to -1, so < 0 (which is better, just in case negative bubbles change value)


Improved system info thingy


This fix is not complete since it does not take old versions of unrar source into consideration.
A proper patch has been applied to latest master in order to resolve issue #40.


should fix #304


So now We'll got saved eof comment along with single toolkit comment, only last version it's packed, no "history".


The right JIRA number is actually SPARK-9677 by the way!


Hey @marcellosachs This was probably done by mistake. These files are vendor CSS files, they aren't actually SASS at all, so that file extension is kind of misleading. They ought have a `.css` extension to reflect their original vendor files.


Done, here and in other `<pre>`s.


Why does this only need to be done in production?


Oops. I fixed this but didn't push the change. Sorry!


This http://stackoverflow.com/questions/849142/how-to-limit-the-maximum-value-of-a-numeric-field-in-a-django-model is all I could find on the subject, and it doesn't seem much more elegant to me.


might want to migrate to google's fab now it's public! http://android-developers.blogspot.co.uk/2015/05/android-design-support-library.html


Yeah, any title that's the definition for an IDL thing will have 2 links for now. I'll update to avoid that when @tabatkins fixes https://github.com/tabatkins/bikeshed/issues/438.


thx, i will look later.


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.05%25-red.svg)


5. Add new property "proband" in individual


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.96%25-red.svg)


please don't use arrays. Lists, hashsets, dictionaries are preferred.

I this case we need has HashSet (or Dictionary)


So I was using this ref to manually trigger ripples. Is there a reason for its removal?


Idem, no Array please


np :)


castPlayer can be null.  you probably want castManager.inCastMode or isCasting or whatever we renamed it to


oh wait, something something iOS is fine.  you're sure this is okay when video is not casitng?


Kindly remove the port number


please explain why this class is needed (in the XMLdocs)


I tested play-and-cast as well, and it was OK.


document this (xmldoc)


document this (xmldoc) - short


Why do we `startAKEFromWhitespaceTag` (and generate the DHCommit) even if we don't have `WHITESPACE_START_AKE`?
The problem is that it will wipe our keys but will never send the DH commit.

We have the assumption that you should not generate a message unless you really intent to send it.


Why the `tolist`?


Good comment :+1:


And based on this assumption, this method originally was a no-op if we don' t have `WHITESPACE_START_AKE`.


Why is the indentation so inconsistent?.. Please Fix that


possible bug? Please add a TODO comment


This is badly indented. Fix it!


Seems sensible to me


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.421.d81c979ca66c99bdfc1d5b98796fbfec1a42c981](http://build.palaso.org/viewLog.html?buildId=60824&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 859, ignored: 54 Build time: 00:28:04


Are we about to build house here?..Why the enormous space?..Please Fix that


It should be in there actually: https://github.com/travis-ci/apt-package-whitelist/blob/master/ubuntu-precise#L5838.

Hope that helps. :)


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Granted, the last time I had ran a benchmark on this was five years ago with PHP 5.2. But even with PHP 5.6 there is a measurable 2.5x difference. Using the following benchmark script (requires the stats PECL extension):
```php
class foobar
{
	public function noop($a, $b, $c, $d, $e, $f)
	{
	}
}

function getStats($array)
{
	$sampleSize = count($array);
	$mean = array_sum($array) / $sampleSize;
	$sd = stats_standard_deviation($array, true);
	$min = min($array);
	$max = max($array);

	echo sprintf("Min/Mean/Max/SD: %1.4f / %1.4f / %1.4f / %1.4f", $min, $mean, $max, $sd) . "\n";
}

/**
 * Get the benchmark baseline using straight object calls
 *
 * @return  array
 */
function bmBaseline()
{
	$results = array();
	$o = new  foobar();

	for ($i = 0; $i < 50; $i++)
	{
		echo ".";

		$start = microtime(true);

		for ($j = 0; $j < 100000; $j++)
		{
			$o->noop(1, 2, 3, 4, 5, 6);
		}

		$end = microtime(true);

		$results[] = $end - $start;
	}

	echo "\n";

	return $results;
}

function bmUserFuncArray()
{
	$results = array();
	$o = new  foobar();
	$arguments = array(1, 2, 3, 4, 5, 6);

	for ($i = 0; $i < 50; $i++)
	{
		echo ".";

		$start = microtime(true);

		for ($j = 0; $j < 100000; $j++)
		{
			call_user_func_array(array($o, 'noop'), $arguments);
		}

		$end = microtime(true);

		$results[] = $end - $start;
	}

	echo "\n";

	return $results;
}

echo "Baseline (straight calls)\n";
$baseline = bmBaseline();
getStats($baseline);
echo "\n";

echo "call_user_func_array\n";
$ufa = bmUserFuncArray();
getStats($ufa);
echo "\n";
```

I get the following results (I ran it ten times without statistically signifficant variance in my results) using PHP 5.6 on a fairly modern Intel Core i7 16Gb RAM Linux machine:
```
Baseline (straight calls)
..................................................
Min/Mean/Max/SD: 0.1069 / 0.1092 / 0.1638 / 0.0079

call_user_func_array
..................................................
Min/Mean/Max/SD: 0.2673 / 0.2717 / 0.3484 / 0.0112
```

(these are minimum, mean and maximum values of the sample, followed by the standard deviation)

You might argue that 100,000 iterations are too many but since we're talking about an Events-heavy architecture I think it's not unrealistic, especially in the first few months (years?) until developers migrate their plugins off the legacy plugin architecture. I would argue that adding 100+ msec on top of a 350 msec page load is a significant price to pay for not having the ugly switch statement. I'd even say that for 30 msec. I wouldn't make that argument for an effect less than 5 msec which is the standard deviation of my page loads on this machine I am testing. So I'd rather keep this arguably ugly switch statement and only remove it when the legacy plugin support goes the way of the dinosaurs in Joomla! 5 :)


Great, thanks! One comment — you're missing the `=` in `Bonus >= 0.01` in the log message.


Well - `blank?` returns true for nil or empty string.  `||=` only assigns
values if the target is nil.  So if csv_event["finish"] has an empty string
(""), `||=` will not work...

On Fri, Aug 7, 2015 at 2:15 PM, Craig Taylor <notifications@github.com>
wrote:

> Are you thinking something like csv_event["finish"] ||=
> csv_event["start"]? Does that for strings with blanks?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ctaylor451/BAMRU-Org/commit/cdb1021ec1c6e804cef8124b967cd7d20dbe2813#commitcomment-12596098>
> .
>

--
andy@r210.com
650-823-0836


hmm, I've got a 530x I've been wanting to read. I'll have to give this a shot, thanks!


Inconsistent Indentation. Please Fix!


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Weren't they removed from CyanogenMod?
https://github.com/CyanogenMod/android_frameworks_av/commit/b55b927a6ae2eb67676e26fae45c7d81f585d7ac


### :warning: Update Loop Performance Down

---

> The update loop should never have custom implementation that reach values out side of scope it's own scope. The update loop should only be for getting the currentTime value and COPY it to store the copied value in a class property whom lives outside of scope of the Update Loop. Then all the implementation should be based of the class property the holds the currentTime Value. The executeMasterButtonAction should not be called in the Update Loop...

> I'll create a branch to add the update and create a pull request. I've been very busy with school and work. But this month I got a bit of free time add some contributions to this project.

> Best regards,

:shipit:


Yay I think I had this issue when editing and was wondering what was happening.


Hier sollte eigentlich 11280 stehen (10000+MTU)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.1.d81c979ca66c99bdfc1d5b98796fbfec1a42c981](http://build.palaso.org/viewLog.html?buildId=60823&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:35:24


r+


Just moved here https://github.com/CyanogenMod/android_external_stagefright-plugins/blob/cm-12.1/data/media_codecs_ffmpeg.xml


Won't this typically be a `TypeError` or `RangeError` for bad arguments, and something else when the request went bad?


Agree with @ShevT . It gets NPE:
E/AndroidRuntime( 1914): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2428)
E/AndroidRuntime( 1914): 	at android.app.ActivityThread.access$900(ActivityThread.java:153)
E/AndroidRuntime( 1914): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1319)
E/AndroidRuntime( 1914): 	at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime( 1914): 	at android.os.Looper.loop(Looper.java:135)
E/AndroidRuntime( 1914): 	at android.app.ActivityThread.main(ActivityThread.java:5312)
E/AndroidRuntime( 1914): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime( 1914): 	at java.lang.reflect.Method.invoke(Method.java:372)
E/AndroidRuntime( 1914): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
E/AndroidRuntime( 1914): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:699)
E/AndroidRuntime( 1914): Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.StringBuffer.toString()' on a null object reference
E/AndroidRuntime( 1914): 	at com.android.settings.util.ChildProcess.getResult(ChildProcess.java:142)
E/AndroidRuntime( 1914): 	at com.android.settings.util.CMDProcessor.runSuCommand(CMDProcessor.java:57)
E/AndroidRuntime( 1914): 	at com.android.settings.kangdroid.KangDroidMiscSettings.onCreate(KangDroidMiscSettings.java:81)
E/AndroidRuntime( 1914): 	at android.app.Fragment.performCreate(Fragment.java:2031)
E/AndroidRuntime( 1914): 	at android.app.FragmentManagerImpl.moveToState(FragmentManager.java:863)
E/AndroidRuntime( 1914): 	at android.app.FragmentManagerImpl.moveToState(FragmentManager.java:1067)
E/AndroidRuntime( 1914): 	at android.app.BackStackRecord.run(BackStackRecord.java:834)
E/AndroidRuntime( 1914): 	at android.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1452)
E/AndroidRuntime( 1914): 	at android.app.FragmentManagerImpl.executePendingTransactions(FragmentManager.java:483)
E/AndroidRuntime( 1914): 	at com.android.settings.SettingsActivity.switchToFragment(SettingsActivity.java:1015)
E/AndroidRuntime( 1914): 	at com.android.settings.SettingsActivity.onCreate(SettingsActivity.java:618)
E/AndroidRuntime( 1914): 	at android.app.Activity.performCreate(Activity.java:6860)
E/AndroidRuntime( 1914): 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1106)
E/AndroidRuntime( 1914): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2319)
E/AndroidRuntime( 1914): 	... 10 more

Well, its my rom but, I just saw that RR also has this problem maybe? I thought based on  @ShevT's.
Thanks


thank you! I'll take a look at the link as soon as I get home!


shouldn't you rather replace it with the right reference instead? Also you're destroying the reference to this URL in line 47.


oh, ok
I saw them being removed on a bunch of devices. Do you know why?


ok


This patch don't works with this expression "height:calc(100% - (64px + 10px))" :(


the message could probably be improved, too tired to propose something good right here and now, maybe after GUADEC and some sleep. (Good recipe, isn't it?)


saw approval from graydon
at https://github.com/jedmccaleb/stellar-core/commit/e77fdcf64c3d612ba24c6be7164ffa6d752a3394


merging jedmccaleb/stellar-core/master = e77fdcf6 into auto


jedmccaleb/stellar-core/master = e77fdcf6 merged ok, testing candidate = f476a700


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.2.8ef9ae3c0a6b824ab74ed8e315de8f3cf4559d80](http://build.palaso.org/viewLog.html?buildId=60825&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:33:46


It is good when these errors go away :)


This is wrong, mob in this instance is the player. This is how PVP is handled, they other player handles the hurt entity.


I mean, you're just saying there's "some problem" while you actually know more about the problem, right?


@ngriffin7a,
I think this is the only thing that needs to be reverted in `3.0.x-legacy`.
- Kyle


The "declaration" has been moved here: https://github.com/CyanogenMod/android_vendor_cm/commit/597025012dacdd54251b5abfdcb30fc8a9b60d7e
It still exists but we have to include it here so various codecs can be called. Else it would be a "dead" file


i think may be there is better way to extract broadcast_data. `https://api.periscope.tv/api/v2/getAccessPublic?token= + token_id`


I was just thinking about adding this, actually.
On Aug 7, 2015 2:10 PM, "Jacob H. Haven" <notifications@github.com> wrote:

> See, for example,
> https://github.com/cloudflare/cfssl/blob/master/cli/serve/serve_test.go#L50
> This explicitly breaks that test, and it should be fixed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/terinjokes/cfssl/commit/15ebabe09f21dcae21828ac226f8d7ce09905944#commitcomment-12596002>
> .
>


Hey, first line of the commit message is too long and will get cut off by git. Take a look at http://coala.readthedocs.org/en/latest/Getting_Involved/Writing_Good_Commits/#how-to-write-good-commit-messages for common commit message standards. (\me is trying to get them applied to babel slowly...)


Yes it would, thanks. Fixing.


Please remove the comments.


why not simply `key not in self` instead of making a new variable for it?


typo in commit message bu -> by I guess


Yes, I think that is better. It means the source's window has to include the target's window to be considered a partial match. If it is narrower in either direction, it is not a match.


/tnt <on;off>


This comment is difficult to parse.


Line too long.


You should flip these. Providing output from a function before a function is defined does work, but it assumes that the reader understands that functions bubble up to the top (not everyone knows that). It also makes the example more difficult to follow along with if they're typing it in to a console.


Add a cross-link to the "limits" section


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.422.8ef9ae3c0a6b824ab74ed8e315de8f3cf4559d80](http://build.palaso.org/viewLog.html?buildId=60826&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 859, ignored: 54 Build time: 00:19:17


The source built one mostly worked here, but gave graphical glitches in certain scenarios when booting into it and rebooting out of it. The Motorola binary you took is probably better for now.


Please do not hard code. for this, please use %{_sbindir}, check for other hard coded values.


Not sure if that may cause issues on Windows or OSes that use a `\` instead of `/`. Not sure if you want to use `path.join()` or something.


It is pretty unorthodox to have `static` objects in a header.  Is the intent really that each source that includes this header get its own private copy of these objects?


@b4b4r07 普通にAAジェネレーターで作ったやつ貼りつけただけだよw
そんな便利なモノあるとは知らんかった


Good idea :)


Is that right? I believe we rename the network interface.


Nit: variable name alignment


Fixed in 621d6a9516e0f9cd8c45e12904f4d4b7615e7fb8.


request = UrlRequest.new(@url)
response = request.get
response.code == 200


And I assume it's not as easy as changing the POST request of `bitcoin-cli` client to use `/bitcoinrpc` instead of `/`?

I quickly tested it and the client returns `error: couldn't connect to server`. I'm testing blindly here, and it would probably be useful to be able to log any HTTP request.

When changing `@Bean(name="/bitcoinrpc")` to `@Bean(name="/")`, then requests result in an exception, because `POST` requests are not supported.


Thanks, we gotta change that


It looks like this should synchronize things. You can probably shorten the sleeping though.


See the existing `scan_one_metadata_object_c` -- it was already like this


I do not think we need that here, we already strip as part of the build system.


Yikes, this broke `Requests.jl`. I mean, shame on `Requests` for playing with `URI` internals, but still.


Remove comments.


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Computers do have smallest numbers based on how many bits are used and if they're signed or unsigned. http://www.mathworks.com/help/matlab/ref/realmin.html I'm not sure it's worth mentioning


wtf. You go all the way to TileTessellator::instance just to get a TileSource, when you have a Player* passed into the parameters? Seriously,
p->region->setTileAndData()
lol.


PlantOperationSchemes (kbenne) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.96%25-red.svg)


This definitely solves the symptom, and is probably a good change since we don't want to count anything that was completed day 0 on the first point (x=0). +1


This should be `isExhaustiveGuard (Just CatchAll) = True`, right?


Is it minified if there are 3 lines? (philosoraptor)


I thought of representing `n` guards for each alternative. But having a more abstract representation seems a better idea.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/74639678


Sorry, it should be `Opaque`, but `False` on the right. `Nothing` should be `True` too.


There are two problems with this:

1. Assume we have a single bone. Then we get:

> THREE.Math.nextPowerOfTwo(Math.sqrt(4))
< 2

But a single bone matrix requires 4 pixels (4 * 4 = 16) and cannot be split across multiple rows. Consequently, the minimum size must be 4. To fix this, we could add a line after this:

size = Math.max(size, 4);

2. There appears to be a bug with THREE.Math.nextPowerOfTwo() (https://github.com/mrdoob/three.js/issues/6970). Assume we have 5 bones. Then we get:

> Math.sqrt(5 * 4)
< 4.47213595499958
> THREE.Math.nextPowerOfTwo(4.47213595499958)
< 4

But a 4x4 texture cannot hold 5 matrices. Either THREE.Math.nextPowerOfTwo() needs to be fixed, or we could do the following:

size = THREE.Math.nextPowerOfTwo( Math.ceil( Math.sqrt( this.bones.length * 4 ) ) );


We should try using `std::function` in `JobQueue` since we've moved to VS2013.


Okay, your call on whether or not to clean up on your changes.


Thanks Anton,  I'm glad you could make reuse of some of my code. It's not the most polished working under Jeremy's deadline.  Now we have to see if we can make it work during build.  Jeremy wants to move (has already moved) it back to the build.  He wants to use include files in the overlays to pull in a common set of params.


The issue with that is that it doesn't generalize well to things like integer binders. We should have the user make the translation to some choice of theory that we offer.


Shouldn't all this go in `src/ripple/core/`?


ok. Thank you.


This change doesn't work. It should be.

```php
$searchpath[] = $drupal_root . '/../drush';
```

or

```php
$searchpath[] = dirname($drupal_root) . '/drush';
```


I have the source code if you want to build the firmware ? Or collect together the firmware, well, if you want


/ping @TatumCreative


OK
So to avoid problems when there is a subdirectory in the sketch folder called "arduino" or "libraries" the build path for the sketch files is {build.path}/sketch/.
I'm perfectly fine with that but as you stated:
> @ffissore, would it perhaps be an option to store the source and .o files inside sketch, but put the final linked .elf and .hex files directly in the build folder? This might fix most backward compatibility problems I believe, and it would still make sense (and not cause problems)?

Which I understand as my statement
> **What I'm trying to say is that what you are trying to achieve is a good thing, but it does not need a change in the platform.txt file.**

So I think we are on the same line here.


fast-forwarding master to auto = f476a700


Thanks for the feedback @lezama - changes are in.

Question: Should we output the jetpack_updates option on sites/$site/updates ?


Do we want to keep this DRY? both pieces of code look identical.


If well want to say, then write me a mail or call on Skype
sattarvoybek@gmail.com   login Skype  (djsattar1)


something like `onlyMeAndSubscribers(user, req, res)`?


Does `'rb'` need to be added everytime a file is opened? Why only here?


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.99%25-red.svg)


My thinking here is that these errors are not serious enough to be sent to console or wrapper.log and should be sent to freenets log.
They are serious for library but not for fred's operation


why does sdl needs boost O.o?


PlantOperationSchemes (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.32%25-red.svg)


You might need ``FirstOrDefault()`` here, othewise you will get an exception if there is no namespace block in file.


why?


This one is already being logged, i've just removed the system output.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.74%25-red.svg)


@MikeBland Would you review this when you have time?
@projectkk2glider I rememeber we had an issue on audio / 9XR-PRO with the 4.8 compiler, I will try again now with this fix ...


Tbh you should have left silly as the magenta color, since silly and protocol look the exact same.


Is this pylint disable required?


The dynamics of the simple car were change to incorporate the disturbances signals. In this case it is an unknown obstacle that appears in the environment at a specific time.


Nope, it's not anymore. Thanks.


I've been wrong about this line already, but I'm still puzzled by this. Why not just `!window.HTMLMediaElement.srcObject`? If it exists in any shape or form then we should leave it alone, no?

If there's some reason `hasOwnProperty` has to be used, why not `HTMLMediaElement.hasOwnProperty('srcObject')`?


Removing these lines causes the publish() method to only ever return false, no matter what happens. Is that correct behavior?


You might want to add an epsilon to avoid platform precision issues with this test, as you did with the other tests further below.


This is playing very well against Komodo 9.1
1m/100+1m/100+(0m+1s)  0

Komodo 9.1 64-bit 8T   - Stockfish 070815 64 POPCNTRvQ     64.5 - 122.5    +17/=95/-75    34.49%

It will probably give some of that back, but Komodo normally gets about 43%, so this is way ahead.  At the 95% certainty level, it is still up 76 Elo which is huge.

Who knows it could plummet to its death, but it is looking like it is handling Komodo quite well at present.  8 threads 4.4 GHz.


Well for reasons unclear to me there are "" fields in the csv


This could be changed to:
    `continuation([](){});`
And then `doNothingCallback` will be unused and we can get rid of it.


Yes, I wonder if this should be in PyArt as you suggested @gamaanderson and yes @pfhein it's not quite the same. Best solution I could think of and clean up the code a little. For now this is workable on our end, but in future....

Also check out PR #67 . I created a new Display class which is a simplification of RadarDisplay. It's meant to handle some basic plots. It also allows the SelectRegion histogram.


PTAL, going to bok right now


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


BOOOOOoooooooooooooooooooooooooooooooo


Good catch, this is also broken in wsgi_config.py. Fixed. BTW, I think you're accidentally commenting on the commit and not on the pull request -- these comments wont' show up in the PR's historical records. No big deal, though.


Should this really be private?


Didn’t know that the precision is depending on the platform. Will do.

> On 08 Aug 2015, at 00:28, RPCMoritz <notifications@github.com> wrote:
>
> You might want to add an epsilon to avoid platform precision issues with this test, as you did with the other tests further below.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/FRosner/spawncamping-dds/commit/00eba571244782d9c6ff54f92152c234c60fb104#commitcomment-12597150>.
>


Or this?


Yeah, I think you can remove the `View` model and the `devise_for :views` line from the routes, and add another migration that removes the `views` table from the database.


I'm ok with this one


It's correct.


#{ !!sitemaps }


develop (mbadams5) - x86_64-MacOS-10.9-clang: OK (1269 of 1269 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Merging.


Correct you are. That's garbage from a different idea I started and didn't go through with.


You're right about not needing the 0, but I think the case of 2 (or more) is handled by the else block. Will remove the 0 on next push as it's pointless.


Does a robots file HAVE a request? Or does is MAKE requests?

Attributes are like physical properties on a real life object. Methods are like actions. I wouldn't think a robots file HAS a request, I think it makes requests. It's probably better to define a new request object everytime you make a request. This is also healthier and makes UrlRequest more useful.


Why did you have to set the user here? I would think the Post would already have a user at this point. Did you mean to set the user of the Summary instead?


Nice work! I like it.


Interesting. I think this makes more sense than how I had it.


Few things about this line.
1. It's probably better to check the response code rather than class. Someone reading this might not know why that class was returned or how it relates to robots file existing. However anyone would know that 200 is a success and 404 is a not found.
2. Is the url really invalid? Or does the robots file not exist? What's a better error description? Maybe the solution is to match the url with /robots.txt/ and if it's false, then it's an invalid url. However if the url is valid but no robots file is returned, then tell them robots file doesn't exist. If i were using your app as it is now, I would think i typed the url wrong.


In fact, this should not be a part of controller. Right now all acl methods we keep in models, e.g. post.validateCanShow(userId) or user.validateCanSubscribe(timelineId)


predicate booooooooooo. Don't need this.


I think we'll actually want a comment with the explanation here so noone changes it back again later.

So according to https://docs.python.org/3/reference/datamodel.html?highlight=__contains__#object.__contains__ the `__contains__` implementation of this object would run `__iter__` on self and looking at that implementation below, I don't see how it should make any performance difference compared to just using the `list.__contains__` implementation which is probably heavily optimized.


I've added the documentation back to the library for a very specific reason.

Maintaining the `gh-pages` branch is a pain. I firmly believe it should just reflect the latest tagged release. It makes it much, much easier to deal with from a maintainer's perspective.


.compact?


1728_add_coils (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I think that this code is correct after chasing down `wxCFStringRef` and `wxCFRef` ctors definitions, but I think it would be better to just use the static `wxCFStringRef::AsString(osDesc)` directly in `Format()` below, what do you think?


Give me a few days and I'll make this stuff more accessible.

I'll provide some sample code, create a Spring Boot server that is just the bitcoin*j*-daemon, and maybe even a java-based CLI client for it. :)


We use `wxS()` instead of `wxT()` in the new code as the former is more correct in UTF-8 build (if anybody ever wants to build wxOSX in it...). But more importantly, I wonder if this string shouldn't be translated? Is it really called "Mac OS X" in all languages?


Nevermind. I see you beat me to it.


Aah OK - then ||= isn't going to work here.  Not the end of the world.

On Fri, Aug 7, 2015 at 3:29 PM, Craig Taylor <notifications@github.com>
wrote:

> Well for reasons unclear to me there are "" fields in the csv
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ctaylor451/BAMRU-Org/commit/cdb1021ec1c6e804cef8124b967cd7d20dbe2813#commitcomment-12597153>
> .
>

--
andy@r210.com
650-823-0836


@Mindbreaker1 : which opening book ?


`immediateContinuation` is used in only one place (Coroutine.cpp) as an implementation detail.  It does not need to viewable from different TU's.  I recommend that it either be moved from here to the unnamed namespace in Coroutine, or just used immediately in `runOnCoroutine` like so:  `suspend(Continuation{[](Callback const& callback) {callback();}});`


Cool


Sorry, why this class is here? It's copy of `RoundedBitmapDisplayer` as I see.


@jan-ivar see https://github.com/webrtc/adapter/pull/119#discussion_r36473388


The Finite element order is also fixed.


nit: I think I'd prefer a custom exception.


The logic in this method is a bit funny and not very clean.

return false unless sitemap_file_exists?
open_sitemap.header['content-length'] == 0


Looks like there are 3 indirectly related changes in this one commit that only describes the UART change. I see changes relating to the UART as described and there seems to be pinmux and LED related changes. This raise a few questions:
1) Is the pinmux and LED change needed for the UART change? If so, the commit description should at least mention that and briefly state why they are needed in the same commit. If not, please break it up as a seperate pull request or at least something that mentions it.

2) Can the pinmux and LED changes be brought in as a seperate commits such that the code still compiles after that commit? Goal here is to allow anyone debugging this to be able to isolate the problem to either a specific change. Seperate commits that are compileable by themselves would allow git bitsect to narrow it down. Small commit chunks reduces the amount of manual inspection needed after git bisect.


AFAICT, this doesn't return None on failure.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 287](https://teamcity.labkey.org/viewLog.html?buildId=265265&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 28 (20 new), passed: 2 Build time: 00:08:49
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

org.labkey.test.tests.CDSTest.testSummaryPageSingleAxisLinks: <no details avaliable>

##### there are 18 more failed tests, see build details
```


@byteandahalf Stop bitching and moaning then release PocketPower source and look how cool our command block screen is :)


saw approval from mrallen1
at https://github.com/basho/riak_core/commit/8ca135efe7f01de61a1ed53ca8d904afc34d9fea


merging basho/riak_core/bugfix/bch/cleanup_verify_membackend = 8ca135ef into borshop-integration-758-bugfix/bch/cleanup_verify_membackend


basho/riak_core/bugfix/bch/cleanup_verify_membackend = 8ca135ef merged ok, testing candidate = a6bdb0e0


Why is there a mix of CapWords and lower_with_under?


saw approval from mrallen1
at https://github.com/basho/riak_kv/commit/c428891f74645cb04f03054bc0098d97e88e2905


merging basho/riak_kv/bugfix/bch/cleanup_verify_membackend = c428891f into borshop-integration-1163-bugfix/bch/cleanup_verify_membackend


basho/riak_kv/bugfix/bch/cleanup_verify_membackend = c428891f merged ok, testing candidate = 83b2b7d3


I think you're right, this docstring or the code needs to be modified to adapt to wsgi_config.py idioms. I'll revise.


Isn't that deprecated?


Можно пример использования, fx-get-dist, у меня выходит с ним только ERROR: Couldn't parse URL.


@stiemannkj1 Thanks, I reverted that line just now -- please verify that I got it right: https://github.com/liferay/liferay-faces/commit/a7f3bf6547c8dca8552bb1e7e4fdbc38bea393df


the last param should be `&detector.pollset`, right?


`dontSuspend` should be declared extern here:
````
extern Suspend const dontSuspend;
````
And then defined in Yield.cpp, outside the unnamed namespace, inside namespace `RPC`, and prior to use:
````
Suspend const dontSuspend = [] (Continuation const& continuation)
{
    continuation([](){});
};
````


@douglogue Switched to the calendar icon, but let me know (or submit a pull request :wink:) if you want something else.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 288](https://teamcity.labkey.org/viewLog.html?buildId=265268&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 28, passed: 2 Build time: 00:08:40
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

##### there are 18 more failed tests, see build details
```


@DanHerePE That code is Java lol


Nope.


I'm not at all fond of custom exceptions, but I resolved this and the other issue here by removing the exception entirely; now it returns None as the docstring says.


looks good!


Can you pretty please make the new code follow the style guidelines here? TIA :) https://doc.pfsense.org/index.php/Developer_Style_Guide#PHP_Specific_Rules


Right. Copy error. Sorry.


@rsivasundaram refinements_test looks good


[...]

> Exactly. If we had some kind of UI for overriding these filetype-specific
> settings I'd probably be happy to have more natural per-language defaults.
>
> Although to my mind that is the point of per filetype settings.
>
> It is; but until it becomes clearly discoverable I think we should not
> override the global preference unless absolutely needed (as @kugel-
> <https://github.com/kugel-> mentioned, i.e. for Make).
>
> (maybe a UI could start by showing a warning that languages X and Y have
> specific settings next to the global setting, but it would be better to be
> able to edit those specific ones easily)
>

I thought that was what Menu->Tools->Configuration Files->Filetype
Configuration->etc etc was for?

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZoomRmc/geany/commit/03d1d63044ae58cdc49d312c896299be9ecdc725#commitcomment-12587031>
> .
>


@ilyakatz When I click the switch button, the avatar changes from blue to green and green to yellow. It's supposed to change from green to red, then red to yellow.


develop (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1272 of 1272 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


not sure what was up w/ the newline change on line 508. Just edited straight in GH. :/


After this commit when I create a manual activity (with or without laps, it doesn't matter) summary shows the correct data but all metric overrides in Metric Tab appear with value 0. If I revert this commit all goes back to normal, but I didn't found the bug yet.


any reason to loop over features and append? couldn't this be replaced with:
`scenes_md = geojson['features']`


/#test


Change this line to: `DEPLOY_OSAD="no" ${BASE_DIR}/scripts/deploy.sh`


should used the `public_storage` or `private_storage` methods.


do we need an if statement here? If the if statement returns false then what is the return value of this method? I think you should just drop the if statement. That should cause it to return nil if there's no sitemap url, which is a reasonable response to expect from this method.


ily


develop (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1272 of 1272 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


star was moved to this directory


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 289](https://teamcity.labkey.org/viewLog.html?buildId=265270&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 28 (20 new), passed: 2 Build time: 00:16:42
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

org.labkey.test.tests.CDSTest.testSummaryPageSingleAxisLinks: <no details avaliable>

##### there are 18 more failed tests, see build details
```


Should be apache (current official planet license), and it does look like there's a license file with apache.


For dumb testing reasons. that code will be changed


1728_add_coils (mbadams5) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.34%25-red.svg)


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_core/builds/1670


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2268


Meinte #9


I didnt know...


Already addressed in latest PR. Thanks!


Why is there an if x.script else x.script?
This either doesn't need the if/else or the else should be a string.


The problem with automatic reboot is that we can't simply close the controller descriptor. If cqueues in embedded then the controller descriptor might be installed with libevent, and there's currently no way to register cancellation callbacks from regular C. We could stash the descriptor, but then they just pile up.

So some work needs to be done to flesh that out.


Понял, спасибо.


There isn't a good reason for this line to get a pylint disable for the line length.


Looks much better compared to the previous versiion. Few more comments:
1. The need to clear the mag interrupts doesn't seem to belong in this commit. It is not documented. See the next points before addressing this.

2. Can we break off new features into seperate comments. I see the following candidates  (each one a seperate commit) for this:
(a) The mag clear interrupt change by itself. New feature/bug fix.
(b) Microlib support. This is a new feature/mode of compile.
(c) Reduced Heap size for optimal memory usage. Tuning.
(d) The task ready flag. This is a bug fix independant of CMSIS or not.
(e) Reduced number of system messages for optimal memory usage. Tuning.

All the reduce/adjustments is an optimization that should be seperated from a change to use the CMSIS stuff.


Hi @mrhanlon, could you please update your copy of the style.css (using this commit), which serves araport.org and araport-dev.tacc.utexas.edu? Once this is done, we can use the web interface to add corner ribbons. Thank you!
cc @msarmien


Is it possible to use the max of what the user provided and the number of stacks?

What's the intended goal of specifying a stack number?

More importantly, see this: http://click.pocoo.org/4/exceptions/#where-are-errors-handled

In this case (if you don't change the behavior), you'd want to probably use: http://click.pocoo.org/4/api/#click.BadParameter


hihihi


It's None if it's a static files handler. I can add that to the returns contract if need be.


oops


@leosayous21 I activated automatic timestamp correction. In case you're satisfied with the results you could remove duplicates from application code (for the simple RangingAnchor sketch I did it already). If you experience any troubles with it, please let me know and don't hesitate to deactivate. ;-)


The reason is that I want to keep the same general form as its analogue in wsgi_config.py, but because of the longer function names here the line is longer, and there's no good way to break up a ternary operation into multiple lines in Python. I tried to rework it but found that the result was substantially harder to read.


To get a PR
[ ] - flag to add versioned asset map.
[ ] - Default to not versioning the asset map.


lgtm


1728_add_coils (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I think I _just_ realized your point, which is that we're waking readers on POLLOUT events, and writers on POLLIN events.


The I2C part itself looks fine. However, I see a conflict with the other commits. Please break up the pinmux code into a seperate commit. This way, all the other merge requests can build off the same commit and avoid conflicts.


I was second guessing myself thinking this percentage error was because when these four corners are in their static positions they are all alined ina a row and was maybe thinking this total width when aligned was what was causing the issue. Turns out the initial % calculation was just calculated wrong. final revision is 1px /1024 container * 100 = .09765625%


What do you guys think about using a specific arrangement?  Wouldn't it help to ensure even value distribution?


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1791 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


This actually breaks storing decimal parquet files into older versions of Hive: https://issues.apache.org/jira/browse/SPARK-9757


On one hand I agree, but on the other, I don't want to add any more barriers, and only specifying corners and center is easy to remember. Maybe set a "tournament" arrangement?


Trying to change the layout of our theme as this one is not responsive and does not look unique for the organization.


Font is hard to read so Architects Daughter seems like a better choice for our website theme.


Please remove this line, too


Great job!


@guidomb please note that this formula has the incorrect tag. Carthage is tagged at `0.8` not `0.8.0` and if this goes live it will fail on installing via home-brew.


Cool, I can take a look at it sometime this weekend.


nooooooob


@iam-merlin I'm not sure I'm following here.

Are you just saying that you want to wrap line 46 in an IF/THEN condition, but are not sure what syntax to use to do so? If so, since this line only builds the coverage data, but doesn't actually POST it, I don't think you'd need a condition.

Or, are you saying that you want to wrap Line 47 in a condition? If so, I've seen other people do that before, for example: https://github.com/PSchwisow/phergie-irc-plugin-react-puppet/blob/master/.travis.yml#L27 Does that example help?

Not sure that I'm helping here. Let me know if I'm moving in the wrong direction.


Did this to allow for explicit testing on the non-redux-connected component.