hmm. Interesting issue, not sure what to do about that. All that is doing is passing the id of the item to get_permalink. Must be some santization somewhere.

Presuming that a ?p=<post-id> type link will work for your post type and it should, you can use `?p={pod_id}` as your redirect.


Продолжая комментарий выше, думаю, будет красиво использовать `Supplier<Boolean>` и тут вместо передачи кнопки. Это не сократит объем кода сейчас, но сделает его более гибким.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.21.57ad4e8627db317d0e2f2e80ce0a732378cfe2a2](http://build.palaso.org/viewLog.html?buildId=61385&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:36:34


Аналогично `Supplier<String>`.


Thanks!


return undefined


初学Python，你的很多文章对我都很有帮助，谢谢


I think you accidentally committed a merge conflict here that needs to be removed.


I can't find this change


Added these graphics and some details in the readme for #10.


I would recommend you doing this with GoLang. It's more awesome handling Redis.


Is there option to disable this location "feature" ??


Ok.. I thought you meant the other callbacks like CurlReceiveBodyCallback, CurlReceiveHeadersCallback etc.

The socket callback can happen synchronously so we use reentrant locks and avoid any blocking code. Note that earlier, the callback was again calling curl_multi_socket_action which is no longer the case.


Since `collect` and `map` do the same thing, I would pick one and use it for both.  Since `map` is what was originally used, I would probably go with that.

Also, instead of calling `flatten` you can use either (depending on whether you go with `collect`, or `map`) `collect_concat` or `flat_map` which will automatically flatten all return values 1 level deep.  It's equivalent to calling `value.collect(&block).flatten!(1)`.

So I would probably change L471 to
```ruby
or_filters = value.flat_map do |or_clause|
```
Then you can change L474 to
```ruby
filters << {or: or_filters}
```


Addition is spelled incorrectly.
(again)


Thanks @willcosgrove !


This test was superfluous,  as it is now checked that `ECPair` has a valid `Network` object,  therefore,  as we expect a valid `ECPair`,  by definition,  we are receiving a valid `Network` object.
A valid `Network` object must contain `BIP32` constants.


oh I see that as well
```@topic = @post.topic``` works
```@topic = @post.topic_id``` set to a number (the topic id) instead of something like ```#<Topic:0x0000000647a990>``` and fails at ```redirect_to [@topic, @post]```
We can discuss this during meeting


Technically a breaking change.


Not a breaking change.


Do we need to keep the commented out lines? If not, please remove.


I am ok with this, can we have some tests?


I will talk to @levb about it tomorrow. Haven't worked on the tests before. Will amend the PR tomorrow.


Sounds good. I think being tolerant of other new fields is good, just would like some tests, etc..


I could not get my own SocialAccountAdapter to run.  Allauth would only let the DefaultSocialAccountAdapter to be called.  These were in my settings.py

ADAPTER = "startup.views.MyAccountAdapter"
ACCOUNT_ADAPTER = "startup.views.MyAccountAdapter"
SOCIALACCOUNT_ADAPTER = 'startup.views.MySocialAccountAdapter'

After the above change, MySocialAccountAdapter was being called.

Note: I made the parallel change in account/app_settings.py That change did not seem to affect MyAccountAdapter either way.  When was set to ('ACCOUNT_' ) or it called MyAccountAdapter and when it was set to ('') it also called MyAccountAdapter.


Don't accept this, I've made new changes.


Can we please split this commit to separate the PEP8 from the functionality changes?


The disable strip tags support gives me an error now.. I go an error exception : undefined index strip_html_tags.disabled
Am I the only one ?


@Maxim-38RUS-Zabelin Это тестовый вызов. Не имеет значения где его делать.


Darwin means Apple's OS X.


@Maxim-38RUS-Zabelin Спасибо за внимание к опечаткам ) Буду рад пулл реквесту.


TeamCity ATK :: QA :: Integration Per Branch [Build 1877](https://ubit-teamcity-iag.intel.com/viewLog.html?buildId=545491&buildTypeId=Atk_IntegrationPerBranch) outcome was **SUCCESS**
Summary: Tests passed: 438, ignored: 15, muted: 9 Build time: 02:03:54


does this work, using Mixin with `create`


oh okay :/ I'll try resolve this, if I find the soluction I post here


Im not sure about pulling it up, but I would b very interested in seeing what the implementation that eliminates dupes looks like!


t1 的 commit 再附註一次


@Maxim-38RUS-Zabelin Да, я бы тоже так сделал. Создайте реквест.


The ```DFL_SZ()``` macro is gross.


This ought to be a list.


technically doesn't even need istype()


not needed


added to the todo: https://github.com/spring/uberserver/issues/179


This is not a typo. It means we want to save the plugin to the devDependency list.


@Maxim-38RUS-Zabelin Эта категория не используется в библиотеке как и некоторые другие методы.
Я буду благодарен если вы поможете с работой над основной логикой, но не будете заострять внимание на устаревших файлах и тестовых методах.


Most likely, although other null reference exceptions could be thrown too. Seems like we need to alert a friendly message to the buyer and then log the exception separately


@Maxim-38RUS-Zabelin Я пока не встречался с таким редким случаем. В такой реализации нужно поддерживать два вида ошибок: сети и апи. В этом нет ничего сложного, но нужно сделать.
Создайте реквест. Заранее спасибо.


Ok, which button is number 12?


Ah oops I copied those over and forgot to remove.


Why split this into a pair of transitions? I believe they should be equal.


yes


tbh this isn't code that I actually changed in this PR so modifying it further is kind of out of scope.


why not update_rate_throtlle_factor


@Maxim-38RUS-Zabelin Это ожидаемое поведение. Да, ваш вариант мне больше нравится.
Собственно, сейчас я использовал подобный метод. Этот класс устарел. Вы можете заметить что его методы сейчас не используются в проекте. Нужно удалить эти методы. Но сейчас другие приоритеты развития.


it is remaining stuff of supporting linux guest. it will be removed.


*Main> range1
[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20]


Okay.


*Main> range2
"abcdefghijklmnopqrstuvwxyz"
*Main> range3
"DEFGHIJ"


dasda


Just... wow.


it support linux kernel's smp stuff. but If you want, it can be removed.


Thanks your advice!


Just a suggestion. The cxl_afu_h handle should usually be the first argument a function.


Using calloc would be simpler compared to malloc.


Policy is only to commit what is officially released as stable, e.g. via the play store. So if this release will also be put in the play store, it can be committed.


nice commit name


I have about 6 different linux computers i login to as root (ssh key and non ssh-keys). This helps me and the users remember what operating system they use :smile:


r+


last time, I heard that the line has limit of 80 characters, it was changed?


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/e0acb86aa01ccd38f7b783a0367a521e3d8d4d1d


merging graydon/stellar-core/more-prepared-statements = e0acb86a into auto


graydon/stellar-core/more-prepared-statements = e0acb86a merged ok, testing candidate = 72b501fd


README.md


We can omit this emit since a socket is already assigned and there is no event handler for this emit.


Most of getter/setter code seems to be boilerplate code. Can we simplify this using a generic macro that will define the body of the getter/setter. For example look into macro PHB3_PCI_CFG_READ macro in  skiboot/hw/phb3.c.


This is my misunderstanding about socket event. Forget this comment.


I like ````channelsStartingWith```` better. What do you think?


ローカルのブランチがおかしくなってしまったので修正しています。


Okay.


This flag can be set in cxl_work_attach function just before we do an ioctl.


@gwenshap No, I don't think we want this.. This behavior is introduced in KAFKA-2249. To avoid this we need to create LogConfig in the same way before that patch. What do you think?


Signature should be 'struct cxl_ioctl_start_work *cxl_work_alloc(void)'


@dillaman ,  so all metadata items of rbd should be prefixed by 'conf_', if you want to set rbd cache metadata, you should run something below
rbd -p rbd image-meta set test conf_rbd_cache false
is my understanding right


As @voltagex has told you in the comments, please make this neutral enough and send users to the mailing list (where their messages can actually be archived as well).  I don't expect you to be around until the end of time :smile: , so it's much better if we don't put all the burden on you.


Will this handle comments other than trailing?

eg. Above

```
    public string Foo()
    {
        // Don't wanna lose this
        return _foo.Bar();
    }
```

or below

```
    public string Foo()
    {
        return _foo.Bar();
        // Don't wanna lose this
    }
```


I will check with Jeremy.


on the W3C mapping, it's UP D-PAD, and it needs to be remapped to 14 on FF


preg_s's 'C' means set , from Interrupt Set-Enable Registers.
preg_c's 'C' means clear, from Interrupt Clear-Enable Registers.
have to i change it?


@indualagarsamy I know this was a while back, but I wonder if we need to do anything here ?


Will,
You mean the JAR file?

On Monday, August 17, 2015, Will Chang <notifications@github.com> wrote:

> @buggtb <https://github.com/buggtb> Could you help tell me where I can
> find >4.3.0.1-SPARK? Thanks.
>
> pentaho
> mondrian
>
>    - 4.3.0.1-130
>    - 4.3.0.1-SPARK
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OSBI/saiku/commit/ddfa72aa68760978ea19cf39d554b4f99798c5e5#commitcomment-12751662>
> .
>


101242918_EvapCndPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1275 of 1275 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


These changes to add `if current_provider` seem prudent, since `get_from_pipeline` indicates it may return `None`... But I'm curious as to how that happens. Under what circumstances is `running_pipeline` non-false, but `current_provider` is `None` ?


To signal that this is composed of two blocking calls. This is the threadpool cleanup code, so perf doesn't really matter.


On the other hand I don't think it is that bad. Only the developer needs to be aware of this "feature". Previously in order to add a new configuration in LogManager, we need to add it in KafkaConfig, LogConfig and LogManager. Now we need to add it in copyKafkaConfigToLog as well -- just 1 more place on top of 3.

Importantly, users will not be aware of this inconvenience. And I don't think any developer will miss this part when adding a new configuration to LogManager.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/76049202


Is it 74 or 75?


I think you'll need 'stop mpdecision' to disable it.


Actually it is. To do that its --save-dev. It's an argument. Without it npm
looks for a package save-dev

On Mon, Aug 17, 2015, 9:46 PM Sam Verschueren <notifications@github.com>
wrote:

> This is not a typo. It means we want to save the plugin to the
> devDependency list.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/robertbaker/gulp-cordova-description/commit/ad3b18dc13b36a5ccac9f318e408361ce1fc4478#commitcomment-12752932>
> .
>


NO.  There is no help for you.

On Mon, Aug 17, 2015 at 10:10 PM, ashitanojoe <notifications@github.com>
wrote:

> I am having trouble using your source code. I pull and run it in the simulator, but it doesn't appear to do anything. Can you help me?
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nivlet/jiratest/commit/9baa33fde07ab02c6fa6028c2d7b8da0d8a256c9#commitcomment-12752170


Fine then. But you should know, there's a bug in your comment.


I wonder if this is a correct behavior. Shouldn't the `Host` header be `host[:port]`?


The only thing I would have done differently is reverse the order so here to get:
```
[11, 10, 7, 1]
```
**Instead of**:
```
[1, 7, 10, 11]
```

Otherwise this is semantically "path from root" in the current order. No big deal to me though, I appreciate it and I know how to ```list[::-1]``` or ```list.reverse()```.

Thanks.


O_O

On Tue, Aug 18, 2015 at 12:33 AM, Joe Waller <notifications@github.com>
wrote:

> Fine then. But you should know, there's a bug in your comment.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nivlet/jiratest/commit/9baa33fde07ab02c6fa6028c2d7b8da0d8a256c9#commitcomment-12753242


fast-forwarding master to auto = 72b501fd


Looks good! Thanks for the quick turn around.


Oh sorry, my bad! I thought you removed them! Thanks for pointing that out :). And sorry for closing it!


Do you remember what was reason for this?


I thought I had asked this before, but I can't seem to find if/where I asked...  What is the purpose of this `logout` call? As far as I can see, no other social auth providers do this, nor does `social.actions.do_auth`.

If this does something important, please add an explanatory comment directly to the code.


Not entirely sure what happened here - definitely wasn't one of my changes.


Unfortunately the test doesn't compile, was tester3 meant to be a struct instead of a class?


@rmasco "authorizatin" is typo.


Alright, thanks!


Smallest temperature code.


Can you use AppVersion inside the script?  1.8 appears here and also in line 20.


According to 'http://code.compartmental.net/minim/index.html', the supported file types are : WAV, AIFF, AU, SND, and MP3.


IMHO this is a lot more understandable.  Clear separation of secrets and information.


101242918_EvapCndPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 750 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.46%25-green.svg)


change this test


apparently MSVC doesn't like this - `builtins.c(996) : error C2059: syntax error : ':'`

what's the right kind of empty to send this function?


LGTM, thanks.


@captain-caveman2k The Visual Studio gitignores are hard to manage since there is one for each version. I think it would be better if we consolidated. Let me know what you think of doing something like https://github.com/jay/curl/commit/761d188


/tmp/$(APP_NAME) ??


I don't think this message is really clear.  Can you elaborate it, please?


So next time we add new provider, we need to add an entry here?


1.修复自定义加密key的获取之后没有设置值的bug。
2.修改ConfigTools 类，生成加密密码的main方法，之前无法指定privateKey，如果都按默认的，则加密意义不大。


gcc copies the condition into the first argument slot if not specified.


As we discussed, do we need locking here?


Decided against typedlua?


@pranavkm  Why are you doing this in the dev branch?


I don't really understand where you want to download the additional packages...or do you want to bundle them into the installer?


A half-liner!


I was afraid this would happen... What operating system are you using?
@apfelbox Did you manage the run my tests on your configuration?
Maybe we can handle this properly with a `.gitattributes` file, but I must admit I never used it before. I guess setting the `binary` type for all test files should prevent git from modifying them.


log the error


If I understand correctly, 'selection' is an index inside the pool and '_currentFile' is an index of '_musicDirContents' OR the current pool. I believe these indexes cannot be compared. Instead, it should be something like:

int indexIntoFilenameArray = _shuffleMode ? _shuffleOrder[_currentFile] : _currentFile;
int testedIndex = pool[selection];
while (i == 0 && testedIndex == indexIntoFilenameArray ...) {}


%s/Appp/App/g :-)


The constraint is actually that the currently playing song will not be added to the shuffle order, right?


Keyboard input isn't hooked up yet. is this something you need?


Sorry, I was mistaken with the RHEL/CentOS. This is issue on Fedora since openssl-1.0.1h-5.fc21, i.e. on every supported Fedora. Quoting my original report (https://bugs.ruby-lang.org/issues/10046):

> I believe, that I observer these failures since openssl-1.0.1h-5.fc21 was build. From the changelog of
> OpenSSL, it seems that there was disabled SSLv2 and SSLv3:
>
> * Mon Jun 30 2014 Tomáš Mráz <tmraz@redhat.com> 1.0.1h-5
> - disable SSLv2 and SSLv3 protocols by default (can be enabled
>  via appropriate SSL_CTX_clear_options() call)
>
> According to the OpenSSL maintainer, they are going to be disabled in upstream release of OpenSSL
> 1.0.3 as well, since they are not secure enough.

And there is similar issue with LibreSSL on OpenBSD: https://bugs.ruby-lang.org/issues/11366


shouldnt the lhs and rhs of each be a logical expression ?


LGTM


So I removed the "shared=1" option in parmetis.rb and then I get the libparmetis.a file.


I'm using Mac OS X 10.10.4. Maybe the test cases could work well on Windows? :)


You could add a line `let open Int in` here and avoid the repeated `Int.` prefixes.


テスト


There's technically devfs.rules/devfs.conf as well that could have been used, as well as devd.conf with appropriate PCI IDs..

Less hex editing required as they're just simple text files.


Wer soll das denn auf null setzen?


くうううううううううううううっっっっっっっっっっっっっっっっぎっっっっっっっっっっよよよよおよよ


く


この destroy_paramsはこのコントローラー内で使われてないようですが、何故定義されたのでしょうか


Minor style nit: indent same as `if` (early exit style ifs can are sometimes written that way to avoid too spurious indentation).


I figured I might as well put it in while I was figuring out how the input worked. Gamestream is designed to work pretty well with the controller, so it's not necessary.


Actually, rereading the quote, there is mentioned ```SSL_CTX_clear_options``` which was not issued previously ...


@jnjackins thanks :)


Valeu pelo feedback, @cristianossd dá uma olhada agora...


Well, I wrote then on Windows, so I'm quite sure they do. :) And I liked the idea of having tests containing CRLF line endings, because they are often forgotten in the languages definitions. They need to work on every platform, though.


I am personaly not a friend of this style, but prefer return statements. It helps to avoid unnecessary indentions in more complex functions, avoids unneeded extra variables and avoids the risk to execute something unwanted by jumping out early.


この辺は既に挿入済みですね。失礼しました。


![captura de tela de 2015-08-18 02 53 15](https://cloud.githubusercontent.com/assets/12115990/9323355/4c66a17e-4556-11e5-9311-ba8187b737ff.png)


TeamCity pull requests :: netty [Build 51](https://garage.netty.io/teamcity/viewLog.html?buildId=471&buildTypeId=pulls_netty&guest=1) is now running


fine


I think you left an apostrophe out after my name Austin


So it only works if compiling ON a Mac, not when cross-compiling FOR a Mac, or am I mistaken?


this will create empty attributes when a value is nil, no? (The hash key will always be there unlike before)


Sorry, you misunderstood; What button do you have to press on the controller to get "12" highlighted in http://luser.github.io/gamepadtest/


I would move this into the start.frag otherwise it will be hard to include the raw `lib/index.js` inside riot if it has require calls


lgtm

:+1:


Ah, this would be a longer discussion.
We use this on several modules (it's a general practice we have).
You could have this segfault under certain cases but recover, so you can still do something with it.
The discussion would be: is a recover desired if it segfaults, or not ?

I have no strong preference on adding here or not.


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1800 of 1801 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Hey Boris,

Join error is strictly related to troubles with joining MUC room and has different error message. It was making me easier to figure out what is wrong with the configuration while trying to setup XMPP authentication with anonymous domain enabled.


@pbauer you do not run any robot test at all here.


Did you mean to remove this line? It looks like this is the only place where you create the tags.


nice catch!


oops!


Fix the typo and I think you can merge this (but only after we merge in your changes in the python repo, since these depend on those)


wrap the long line.


did you mean to duplicate this expression twice? (see default.nix)


UP ! :P


also `pkgs.lib.inNixShell then drv.env else drv` suggests this file can replace default.nix


This won't work in my case, because `x"$DE" = x""` is not true for `gnome-fallback`. Moreover, we should include `gnome-fallback-compiz`, because some people are using it.


Remove indent.


Checkmarx scan results 18 Aug 2015 09:10 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

10eaec2ba0b9372b1dea6c796a9a178ea5d75806	@dudug

276248cf0dce5d9446c830daad389394726c70ea	@dudug

af7b1855948891bb9529bb3e35a2a4fca542631e	@dudug

9e206f456722c4287c4a6b82bcf4aecbe3b32250	@dudug


こちら、paramsから直接、変数引っ張って、destroyアクション実行してしまってますが、
セキュリティ観点から、destroy_aparams使った方がいいですよね。


so because it's more fun this way, FF returns different gamepad ids on Windows or OSX !
PS4 Controller :
- FF in Windows : `054c-05c4-Wireless Controller`
- FF in OSX : `54c-5c4-Wireless Controller`

notice the additional `0` on windows :P

so as an easy fix for now I just duplicated the entry, but i'm not sure we should do the same for the others (as the same is most certainely true) or do some regexp magic to normalize it


Checkmarx scan results 18 Aug 2015 09:12 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3313e2b14249afcd46ac55a41363eb331dba88ca	@dudug


Should it just check for `gnome*)`?


I think it should be moved before `foreach` to place when `$dateRange` created


Hey there,

I didn't have time to investigate what was going on. But a lot of fork/join
activity was occurring.  Again I was running a more than likely non real
world scenario, of a shed load of sets (
https://github.com/tootedom/herdcache/blob/master/src/performance-test/java/org/greencheek/caching/herdcache/perf/benchmarks/cache/LotsOfSets.java).
In this I  noticed via a jfr profile that fork/join seemed to be eating a
lot of CPU, and affecting the benchmark results. So I just reverted to
clhm, over doing a full investigation (being over cautious). (
https://github.com/tootedom/herdcache/blob/master/src/main/java/org/greencheek/caching/herdcache/memcached/BaseMemcachedCache.java#L107
)

If you want to have a look you can checkout and uncomment that line and
have a look. I need to isolate the test more selectively.  I can however
pass you on any jfr results you need/want.

I'm using caffeine in a couple of real world production apps at work (DNS
caching), and am not seeing any issues.  As a side note, if you are
interested jacacco (the code coverage tool) has issues with one of the
caffeine classes. Can't remember which off the top of my head, but can let
you know if you are interested.

How you doing BTW?  Am liking caffeine, really good stuff, as usual.

Cheers
/dom

Interesting about the thread issue. Can you provide more details?

The executor is customizable, so you can use a same-thread executor if
desired. I tried to be intelligent about fork-join threads, but more
real-world experience would help me tune that heuristic. The intent was to
defer the maintenance work to a background thread instead of adding latency
to a user-facing thread.

—
Reply to this email directly or view it on GitHub
<https://github.com/tootedom/herdcache/commit/3ae87bc1f5ca98e5512e2773b2ad3527207804c0#commitcomment-12751903>
.


I don't think we need an output example for phpunit


@malash: Could you checkout the repo (on `gh-pages` branch) again and retry? I added a `.gitattributes` file and committed special line endings again.


fine with me, just that I would have kept the indention of the LEFT JOIN lines on same level. It can become quite deep with more complex queries IMHO.


TeamCity pull requests :: netty [Build 52](https://garage.netty.io/teamcity/viewLog.html?buildId=472&buildTypeId=pulls_netty&guest=1) is now running


No period after the sentence since the Mumble client adds it automatically.


No period after the sentence since the client adds it automatically.


why do we need php5-fpm? All code runs in unit tests only


I don't think we need that


Let me take this offline to email =)


isn't this basically removing the test?


Add Information Retrieval section and book "An Introduction to Information Retrieval"


I'm not quite sure what you are trying to achieve here as no such API endpoint exists.

We (Xero) won't be able to engage much in individual repositories on GitHub, but you are welcome to ask general questions about the Xero APIs in the Xero developer community: https://community.xero.com/developer/


As I said in the above comment, the documentation is on my roadmap for this week.


You are reviewing an old piece of code, this has been changed in the latest update. :)


I think you can add this (and key) before first `apt-get update`.
It allows to call `apt-get update` once.


I think, you should check for `gnome-fallback` (works for Gnome (Metacity)) and `gnome-fallback-compiz` (works for Gnome (Compiz). What's more important, you should move it out of the `if [ x"$DE" = x"" ]; then` instruction. E.g. above  it. In my case `$DE` is not empty. It's equal to `Unity`, but I'm using Gnome Session Fallback, so the main condition is not fulfilled.


This would be a great benefit! However, this form is not reliable so I won't pull it. Unfortunately I am not aware of a simple reliable way of waiting for the body to become available. As soon as I learn one I will update Zenfonts.

Also, please note that it is better to inline zenfonts-min.js than to reference it. If you add `<script src="path/to/zenfonts.js"></script>` it's good for caching but it also adds a(nother) blocking request to the page which is unfortunate (unless you are using HTTP/2). Zenfonts is made so tiny in order to be easily inlined.


What about the rest of the platforms?


removed


It passed.


Hi, this is not about the OWTF running on the loopback interface. This is where I start the Crawljax web interface (the `start.sh` script runs Crawljax on a loopback interface ATM. As of right now, OWTF by default runs on the loopback interface. In the next commit, I'll give an option in the default.cfg to specify the interface and port.


added.


Sorry we have problem with the merge we did...obviously something is wrong...we are going to fix this....if you see something else 'not logical' please tell us :)


This is broken right now, it always seems to think that whatever is in keys_pressed is valid.


I don't see how this could do the exact same thing as the old code


idem


All the resizing stuff is somewhat broken in that it for some reason alters positions incorrectly.


加了网络请求


Honestly, I am still learning and coming to terms with Sphinx style documentation. Let me give it a another go.


Still learning the Sphinx documentation, will fix in the next iteration of commits.


e


This was line used for debugging. I'll change it.


I will remove this, it just a handler, so won't install anything, but yes shouldn't be there really


ok


I hope this fixes it https://github.com/darealshinji/screenFetch/commit/ddce9549088a749fbc64da70a7c70831afce7c01


名前、名前（フリガナ）欄も消す必要があります。


I was replying on my phone an thought it was an email :-)  Technology is confusing at times (I've a feeling I'm turning into my dad).


Merge from the main repository


TeamCity pull requests :: netty [Build 51](https://garage.netty.io/teamcity/viewLog.html?buildId=471&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5567, ignored: 21 Build time: 00:34:32


I think this correction makes sense!


upcast.cabal, shell.nix, default.nix are all generated (from package.yaml). I don't really care what's duplicated in them.


Autodesk_Performance (DeadParrot) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity pull requests :: netty [Build 53](https://garage.netty.io/teamcity/viewLog.html?buildId=473&buildTypeId=pulls_netty&guest=1) is now running


Could you show an example to make sure we're on the same page?


Hello, this line has been removed and the component is done different now.


with AngularJs I will be using ngRoute to separate the main header and footer from the main content look from this test site i made to experiment ,Angularjs with gh-pages [index page](https://github.com/MAKOSCAFEE/MAKOSCAFEE.github.io/blob/master/index.html)

I also thought of preserving the old wiki structure but the idea of combining the shorter pages to longer ones is  a nice one.


This doesn't actually fire the query and it's not run as a subquery below. 2c18196b1432dd534081b9292d12b1e639fc19c6 fixes this


Why `bin` and not `binary`?


Yes you are correct by removing it. It is actually the 1st part of the fix for [this issue](https://github.com/gnois/luajit-lang-toolkit/issues/3), and crept in due to my overlook.

The 2nd part of the fix is at [bde3227](https://github.com/gnois/luajit-lang-toolkit/commit/bde3227ca7e43209831f327a813c13b4c3f8cfa4), which you reverted in later comment.

They both should go together in one commit.


if you change `$GDMSESSION` to `$DESKTOP_SESSION` in this line, it should be OK.


```
$ env http_proxy="https://proxy.example.com/" http http://www.example.com/test
```
the proxy used will be `http://proxy.example.com/`


*sigh* And the flugel tiara was nice for building on tall ceilings...


test


// Если другой поток поменял значение, то OptimisticLock конечно же выскочит.
// Написав эту версию с ручной проверкой я добивался лишь эмулировать подобную проверку версионности)
// Изначально я хотел просто отловить и обработать OptimisticLock exception, но вместе с
// org.hibernate.StaleObjectStateException приходит Error, изучив stackoverflow я понял, что не смогу обработать
// эту ситуацию в такой реализации


nice catch!


да, NPE возможно, необходимо проверять на null перед вызовом метода get()


Sweet :)


Exciting!!!


Is `dasherize` required here?


And not check for $GDMSESSION at all?


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 751 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.87%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-16.57%25-green.svg)


:+1: Perhaps, such search should be case insensitive.


Based on the commit message it doesn't seem that the removal of _Database.Tasks.RemoveTask(taskId)_ call was intentional.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.505](http://teamcity.monogame.net/viewLog.html?buildId=9707&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Should alibuild/aliBuild for being copy&paste


Ah, very nice! OK, sounds good to me.

Is it worth fixing the stuff in this commit, or do you want me to merge it as-is (in case you'll have to rewrite it again later with Angular)? All the things I noticed are pretty minor.


I would use int(a, 0).


I understand that this is not for crawljax. The point is if user is running OWTF on a different interface to access it over a network, he will not be able to access crawljax interface like this. Yes, you should allow user to specify crawljax interface. Better put it in general profile


Could you change this code to compile with configuration instead of comments?


Fixed.


No library file is fixing to it can you give me any suggestion please


With XO 0.6.0 you can now use the `xo.getFormatter();` method. It defaults to `stylish`, so no need for an argument.


According to the code in main(), first you extract a list of courses, then you use it to extract a list of sections/subsections (selections), and then you extract units. So in fact it's not quite structured as a tree.


reg


Could you recheck the last digit in `8.549297e-6`? I get an `8` here. Otherwise, take one digit less `8.54930e-6`.
Constants used:
speedOfLight== 299792458
eps0==8.854187817*^-12
echarge==1.602176565*^-19
emass==9.10938215*^-31


true, thanks for the hint.


You can now use the `xo.getErrorResults()` method: https://github.com/sindresorhus/xo/blob/1901f6dd3741db46c2313752fae229317565cbe3/index.js#L122


`Based by` => `Based on`


If I understand this code correctly, `if [ x"$GDMSESSION" = x"" ]` condition checks if `$GDMSESSION` variable is empty. If it's empty, then checking if it contains something doesn't make sense. Moreover, for gnome fallback session `gnome-fallback` or `gnome-fallback-compiz` value is inside `$DESKTOP_SESSION` variable. It's **not** inside `$GDM_SESSION` variable.


@shadowmint owes you a beer for adding this.


how do you generate nix files? stock hpack doesn't seem to do it


Nigel I think you're wrong


@milancurcic My `f` initialization is wrong (but I do not see why), however also your is not correct. The parameter `R_P` is a kind for real, but you used for the integer `4`. Maybe we can simply set
```fortran
real(R_P), parameter :: f=0.0001_R_P
```


Yes, I think so.


Last login: Tue Aug 18 09:56:20 on console

zzzs-iMac:~ zzz$ cd Gigabyte-GA-Z77X-DSDT-Patch

zzzs-iMac:Gigabyte-GA-Z77X-DSDT-Patch zzz$ tools/bdmesg | grep "Z77X"

0:100  0:000  ... with board Z77X-D3H

zzzs-iMac:Gigabyte-GA-Z77X-DSDT-Patch zzz$

2015-08-18 4:09 GMT+03:00 Alex James <notifications@github.com>:

> Hmm, I probably ID'd the motherboard incorrectly in the script. Can you cd
> into the repo folder, and then run tools/bdmesg | grep "Z77X"?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/theracermaster/Gigabyte-GA-Z77X-DSDT-Patch/commit/788781a32f7840ae0a9330ab58e724a2cd2daf3f#commitcomment-12751093>
> .
>


Nope, it's my mistake. Anyway If you want to use split conditional statement into multiple lines, I recommend as below:
if (((offset >> 2) - GICD_ISENABLER) == 0
    || ((offset >> 2) - GICD_ICENABLER) == 0) {


Thoughts on linking `fetch` to https://fetch.spec.whatwg.org?


You forgot to register the fieldgetters and such.


Ah no, this

```
[[ -e package.yaml ]] && hpack
cabal2nix . > default.nix
cabal2nix --shell . > shell.nix
```

Do you want that in the readme?


I like the idea of having a tree. Thinking about that in my favorite "merge (edx + coursera)-dl" context, we could generate trees structured differently for different platforms, but have a single downloader module for all of them.


do we need to keep default.nix?


so cool


いらないのではないかと思いますが、必要だと主張するリファレンスなどありますでしょうか？

私は、ストロングパラメーターを設定する理由として
「パラメーターとしてデータを受信する際、悪意があるパラメーターを排除するため」
のような形で認識しているのですが、
:prototype_id, :comment_id
に関しては、ユーザーが入力し、任意の値を送る事の出来るパラメーターではないため、
必要ないのでは　と考えました。
例えば、current_user.idに対して、ストロングパラメーターは設定しても意味ないですよね。


(it seems you can `nix-build shell.nix` just fine)


I assumed it's only a problem on Ubuntu because no one reported it on
another platform.

On Tue, Aug 18, 2015 at 9:34 AM Omer Hamerman <notifications@github.com>
wrote:

> What about the rest of the platforms?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hasadna/anyway/commit/6f0d884e22c0d93f8112ec49e2a7592942820747#commitcomment-12753677>
> .
>


Isn't this covered by the `img.onload` on L283 ?

https://github.com/ashleydw/lightbox/blob/master/ekko-lightbox.coffee#L283


What are the meaning of (offset >> 2) - GICD_ISENABLER) and (offset >> 2) - GICD_ICENABLER)? and what is the meaning of comparison value '0'?
Using named constant or define statement is better than use '0'.
How do you think about?


what is password ?
cant accesses root openelec


How do you decide what to put in the pool cleanup in what to put in the regular cleanup functions (`ib_device.destroy_srq()`)?


According to node.js API `http.ClientRequest` should emit 'socket' event after socket is assigned to request.


tese


Yes, thanks. I haven't understood the bytecode generator enough to make any change.


> do we need to keep default.nix?

I don't need it, I just think it's kinda good practice to leave there. In fact, I'm even fine with ignoring both the Nix files. They can be generated when needed.


I'm not sure if this is considered good practice or not, but when making a Docker image that can be used on different machines (dev, prod, …) I don't set the nginx [server_name directive](http://nginx.org/en/docs/http/server_names.html), and nginx,  unlike Apache(?), doesn't make any attempt of filling it automatically.

But now I just learned from https://developer.mozilla.org/en-US/docs/Web/HTML/Element/base that IE doesn't support relative URLs in base href, so it *might* be a bad idea to introduce relative URLs there..


i'm fine with leaving them, but shell.nix is clearly a superset of default.nix, so i'm trying to convince you to remove at least one :)


If I understood this code correctly, condition: `if [ x"$GDMSESSION" = x"" ];` checks whether `$GDMSESSION` is empty. If it's true then checking if `$GDMSESSION` contains something doesn't make sense.

I think, we can check `$GDMSESSION` or `$DESKTOP_SESSION`, but outside of the following conditions:
- `if [ x"$DE" = x"" ];`
- `if [ x"$GDMSESSION" = x"" ];`

This conditions may not be fulfilled for gnome session fallback


Это ты ошибся видать. Не должно тут v110 быть на релизе.


И тут.


Sure, we cannot image the meaning of those variable by naming.


Confirmed after a clean build -  public/private key not being accepted, and "openelec" not being accepted as the password, so no ssh access with this package.


How about removing (and ignoring) all 3 of them then? They are all generated from package.yaml.


What else could it be? This answer http://stackoverflow.com/a/30686035/ cites the Standard definition:

    template<params, param, param>
    class basic_string {
        typedef typename allocator_traits<Allocator>::size_type size_type;
        static const size_type npos = -1;
        // other stuff
    };

So `npos == (size_type)-1` which is the largest possible value for `size_type` and adding one to that should overflow and yield zero.


A simple solution to this would be to refactor the struct in the old object oriented way: have all the common fields in rxe_mem, and create distinct structs for mr, fmr, and mw each containing the rxe_mem struct.


let's keep the cabal file at least? i wouldn't expect people have hpack installed


Why put the "rxe_" there in the first place?


Please consider to use this commit message: "Refine the construction of tunneling commands, from string to list"


You must add these lines in your config file /config/feeds.php

/*
	  |--------------------------------------------------------------------------
	  | Strip Html Tags Disabled
	  |--------------------------------------------------------------------------
	  |
	  |
	  |
	  */
	'strip_html_tags.disabled' => true,
	/*
	  |--------------------------------------------------------------------------
	  | striped html tags
	  |--------------------------------------------------------------------------
	  |
	  |
	  |
	  */
//	'base', 'blink', 'body', 'doctype', 'embed', 'font', 'form', 'frame', 'frameset', 'html', 'iframe', 'input', 'marquee', 'meta', 'noscript', 'object', 'param', 'script', 'style'
	'strip_html_tags.tags'     => [ 'base', 'blink', 'body', 'doctype', 'embed', 'font', 'form', 'frame', 'frameset', 'html', 'iframe', 'input', 'marquee', 'meta', 'noscript', 'object', 'param', 'script', 'style'],


How you createEntity method use arguments ($type, $name=null).


You should use the ALIGN() macro.


IDK. I would :)


Good point, thanks


It tested if the checkbox was checked. If that was the case, $keywords was set to $A, else $keywords was set to $B.
I see no difference with
```php
$keywords = $checkbox->isChecked() ? $A : $B;
```


I'm going to cherry-pick this fix. Thank you for improving docker-pocketmine-mp!


TODO:

Add YARD Documentation.


Autodesk_Performance (DeadParrot) - Win64-Windows-7-VisualStudio-12: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What you think about calling destory, if its defined? So its not hard-coded. Just an idea. So not every gutter must have implemented it if its not required.

```coffeescript
gutter.destroy() if typeof gutter.destroy === 'function'
```


All right I see, but why the "strip_html_tags.disabled" is set to false by default then ?


You can remove addAnd() and use like this:
$query->field()->equals();


It was. We already have a way to remove tasks form the database, after they have been completed.
We actually want it to stay there, so we can get status of that even after it is done


It is better :D but for unit tests we would prefer to have only the minimum required to understand what are the covered cases (compliant and noncompliant). We should not have to start really reading code to understand.
For example if a function is declared it must be on purpose, to test scopes or function parameters, etc.
Also the code should be annotate with "//NOK" and "//OK" comment.
You could keep in mind that the goal of those unit tests is not to describe the function side of the rule but to test the technical implementation :). You should about code coverage, i.e covering the different paths/possibilities in your code more than demonstrate the functional aspect of the rule; even if some cases will of course!
Hope it was clear.


Hmm, it's a little bit confusing for me, but it does seem to do the same thing.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.505](http://teamcity.monogame.net/viewLog.html?buildId=9707&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests passed: 538, ignored: 6; exit code 1 (new) Build time: 00:20:56


Checkmarx scan results 18 Aug 2015 10:16 UTC +03:00

High
Medium
Low
Info

New
2
1
103
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3b7156b3a7c92a8537121cda42302dfda9bc8ece	@BearSpace


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.506](http://teamcity.monogame.net/viewLog.html?buildId=9711&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:00


地方


peut-être également permettre aux utilisateurs d'indiquer une apikey dans le header http du job pour leur permettre d'utiliser leur apikey personnalisée ?


I'm curious, why do you need a spinlock here. Supposedly, the release gets called when the last pointer to the pool is being released. Who can still access the pool's state?


TeamCity pull requests :: netty [Build 53](https://garage.netty.io/teamcity/viewLog.html?buildId=473&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5567, ignored: 21 Build time: 00:34:17


EOL


Yes, these packages are bundled in the installer.


Checkmarx scan results 18 Aug 2015 10:20 UTC +03:00

High
Medium
Low
Info

New
2
1
103
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3b7156b3a7c92a8537121cda42302dfda9bc8ece	@BearSpace


ZAP is using version 1.4, those JavaDocs are for 2.5.
We can/should use NIO instead of Apache Commons IO, to read/write the lines.


Added a selection box to the search aside which allows a user to specify a service_area in which they would like to narrow their results.

Helps to work around limitations of location radius in large areas and returns state-wide resources that would otherwise be missing in a locations search.


closes #6


Hello @carlosfrodriguez. There was some code here allowing to show partitions more than once. I could see this behaviour on a fresh installed OpenSuSE 13 where the main partition was listed like 10 times, always with the same value, probably due to bind mounts. I changed this now to only list every partition once. Please let me know if you have any issues with that or if I missed something here.
Best regards, mg


See #4280


This looks racy. Are you sure num_elem cannot be incremented after the read? Also, why do you need both the kref and num_elem?


just a test


I recently tried to apply this update on my project and I keep seeing the error message:
`You're using an older version of Ember - please reinstall and use ember-cli-azure-deploy@1.2.5.`
although after looking at this commit, I don't see how this could be possible.  In the first case, if it was failing to determine the ember-cli version it fails optimistically and copies the deploy files anyways and it it could find the version it would surely not return the error since I can manually open up the `/node_modules/ember-cli/package.json` file and see that it's version is set to 1.13.8.

Even if I run the `azure-deploy init` command in a empty directory I still get that error which is strange. I would expect emberPackage to be null since the require statement would not find the package.json, then checkForOldEmber would return false, and it should copy the files into the empty directory.

Has anyone else successfuly re-ran the `azure-deploy init` on an existing ember project?


It's been a while. Does it work with your suggested modification?

If not, one idea could be that c() can concatenate many types of things. But passing in the ids Vector ensures I get a Vector type back as a return value.


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1275 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.11%25-green.svg)


On second thought your recursive solution seems to be good. Sorry for rejecting it first, @wtayyeb.

Let me just do the testing first in all browser versions, and then I am going to add it to the codebase.

Thank you very much!


My guess is that this should be `if (sendStop) twi_write_stop();`, but please verify if that works with your sensor.


Perhaps should send a stop here as well?


Because by default we need a clean feed without javascript or css or iframes etc.....
and if you need to pass any one you must do it by yourself to be sure what you really need to pass


Why not use
`(typename _this == typename true)`
that would eliminate all errors


Perhaps you can print a warning in this case.


if the length is smaller than 3, how can it contain message_var_user?

    public static final String EMAIL_MESSAGE_VAR_USER = "$USER";

Did you mean greater than 3? :)


Here too.


@kristjan You were one step ahead of me. :+1:
I'd recommend updating your fork with the latest and greatest.


I noticed the readme.md says 1.13.7 or below, which is correct wording since 1.3.0 works with 1.13.8 and 1.2.5 works with 1.13.7 and below, but the code here uses `semver.lt`.  *Should it be `semver.lte` so 1.13.7 is included?* I think if a person had project at 1.13.7 they would not see the error even though they should.


Checkout `complete.R` in the same directory :)


I just noticed that the code will actually retry 6 times... however, the loop still has a termination value. The while statement chunk for checking nRetry should be (--nRetry > 0) OR initialize nRetry to 4 (which is less readable).


look fine to me


init commit on github web


Ok, I got it, thanks for your help !


To be honest this was just a quick fix I made when I figured it didn't find gnome-fallback on SteamOS.
I'm not really sure what this double $GDMSESSION check is all about either.
I don't mind if you give it a try and submit your own pull request, then I'll close this one.


Quick note: if you don't use `goog.inherits` then `provider instanceof Cesium.ImageryProvider` will evaluate to `false` if `provider` is an `olcs.core.OLImageryProvider`.


Isn't the `might_sleep` call inside the memory allocation enough? If not, perhaps you can simply add your own `might_sleep_if` here.


If the API is an issue, check out [my patch](https://github.com/fat-tire/RedPhone/commit/df747771f842e16d6f6bc481aed15b5bb6606471) to bring the project up to 22...  23 was released today but I don't think it would take much to get it compatible (some permission checking basically)


title лучше в стоку placeholder-ом.


Устанавливая 3 я думал про виджет на главной - слайдер, в котором три элемента, больше туда не влезет :)


I just uploaded a new version of the image. Removed application-specific settings. Enjoy!


Again reading twice the shared memory is wrong...
Look to master in proxy_cluster_trans() the balancer_table is saved in the request notes that might be the way to go.


Autodesk_Performance (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Could you unify the get_index and get_key functions by saying that the index is a 4-byte opaque key?


Great news http://forum.xda-developers.com/showpost.php?p=62370082&postcount=94 :smile:


indexed or keyed
no need for an apostrophe.


why double event.which == 27?


Ok. I was about to create my own PR, but I noticed this one, so I checked if it's similar to my idea of fix. That's why I started reviewing this. I'll create PR later.


Oh so you were referring to a 'bundle' product not 'grouped'.


Error checking of dbus_connection_send()?


moda ? really ? it has been tested................


TeamCity pull requests :: netty [Build 52](https://garage.netty.io/teamcity/viewLog.html?buildId=472&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5567, ignored: 21 Build time: 01:09:14


Looks like the author info messed up on this commit.


Acked-by: David Herrmann <dh.herrmann@gmail.com>

I'm not fond of the idea of activating sessions unconditionally on startup... but I guess it'll take some more effort to get rid of that behavior. Otherwise, looks good to me.


the comment should say that the decision to run or schedule is based on the parameter `sched`.


dfs


### May expose internal representation by incorporating reference to mutable object

This code stores a reference to an externally mutable object into the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Storing a copy of the object is better approach in many situations.

**EI_EXPOSE_REP2**


### Write to static field from instance method

This instance method writes to a static field. This is tricky to get correct if multiple instances are being manipulated, and generally bad practice.

**ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD**


### Unread field

This field is never read.  Consider removing it from the class.

**URF_UNREAD_FIELD**


I think that will be more clear if in xml we will have same name of param.


yup and it works as intended =3


This is great


On Windows we could use `%APPDATA%`, on Linux maybe `/tmp` or `./scotdata`?


Only notice @chemix @dg (plus https://github.com/chemix/planette/commit/4e66fe7f3ffb430aa401cbaa822354126f85feff)


Event Type	Description
show.bs.modal	This event fires immediately when the show instance method is called. If caused by a click, the clicked element is available as the relatedTarget property of the event.
shown.bs.modal	This event is fired when the modal has been made visible to the user (will wait for CSS transitions to complete). If caused by a click, the clicked element is available as the relatedTarget property of the event.
hide.bs.modal	This event is fired immediately when the hide instance method has been called.
hidden.bs.modal	This event is fired when the modal has finished being hidden from the user (will wait for CSS transitions to complete).
loaded.bs.modal	This event is fired when the modal has loaded content using the remote option.


have you add these dependency files into copylist in suite.json?


I'm afraid so... dictionaries always seem cumbersome to use and less performant to me. (Yes, I'm aware under the hood class members are stored as dicts too)
Prejudices like that are what you get from too much C++ :)


Hm. But I would make it very explicit if a data file is downloaded. Setting a default to a location no user will ever go to is probably not a good idea, especially on Windows. I mean, `/tmp` is regularly purged, but I'm pretty sure putting something into `%APPDATA%` will never be erased.


Ну, смотреть проекты только на главной как-то не торт.


Мб для неё сделать спецвиджет?


Other than that +1


Great. I'll close this one.


What? Dictionaries are less performant? Than what? Of course it depends on what you are doing with the data, but e.g. searching can't get much faster than hashtables. You really need to switch your mindset away from C++ :-).


cute commit! (〃ω〃)彡


...of the role (same for the others below)


I think with @halfline we decided that sessions should activate themselves "when ready", since they're the only ones that know when they can be ready, and as such, gdm won't activate sessions anymore when trying to launch a Wayland session, since that could cause flickering.


Should we use `spell` to check all the codes and comments?


> Maybe update_cycles_interval is a better name - its not really a divider, is it?

I'd say it is. It divides the `controller_manager` update frequency, it's the *n* of a [frequency divider](https://en.wikipedia.org/wiki/Frequency_divider). Maybe the terms is not so descriptive as I thought.

> why not update_rate_throttle_factor

We are throttling the update frequency, that is true. What I'd like to reflect in the name is that the user is specifying a divider, the *n* in  *skip n cycles*. As a ROS user, when I read throttle I'm tempted of making an analogy with [`topic_tools/throttle`](http://wiki.ros.org/topic_tools/throttle), where throttling is specified in terms of frequency or bandwidth.

Practically speaking, if the `controller_manager` runs at 1000Hz, and you want a controller updating at 500Hz, the parameter name should make it clear that what you need to specify is 2, not 500.


but.. Python 3 :(


Send me pull request and I will merge it


Nah, this works in 2.7 as well. Only the default has changed in Python 3, which uses new-style classes by default (whereas 2.7 doesn't IIRC).


action must be on https too.


Hi Shawn, thanks for your contribution!


Please describe here HOW to choose a correct branch. It is not explained here. You should explain purpose of each branch and differences between branches. I know that it would be a long text, but it will be very helpful.


Cool, I knew you'd figure it out :-)

I don't consider this too hacky at all. Changing the namespace would be a pretty breaking change, so I don't see that happening ever, and at least not without bumping the major nuget version. I'm not sure if changing the assembly name would be a breaking change in the nuget, but I also don't see that happening without careful consideration. We should document these two concerns in the serialization section of the README for future reference, and also in the xmldoc of the converter class.


Oh, good point. I'll update it.


ruby?????


what does it mean ?


@m-kusaba テーブル名を区別しやすいように変えましょう


확인


Use please some better word than 'good' (maybe understandable, self-explaining,....)


Where do you fill the network_type field? I expected it to be here.

Also, how do you handle link-local ipv6 addresses? They require filling out the scope id field of sockaddr_in6.


I managed to have a sort of "dev mode" simply by mounting a volume containing the application sources (from the docker host), is it enough for your use case or do you need something more?


1: M111 unrecognized component name: base


What's the reason for those changes? Do we need to change it in the importer too?
https://github.com/discourse/discourse/blob/master/script/import_scripts/base/uploader.rb#L18

BTW: Are `image_type` and `content_type` important? Currently the importer doesn't set those values.


Sure, if anyone activates a session, then the session itself. But it should still be optional. That is, gdm should tell the session that it is supposed to activate itself when done. Otherwise, you cannot spawn the session in background (like your background compositor crashes and restarts).


+, but, probably, we don't need this line at all.


Is the LIB_SUFFIX here standard CMAKE variable?


Ohh. :)


does this work also without having akka-distributed-data.jar in classpath at runtime?


Sorry @standino just uploading it to the repo now, just rerun the build in 5 minutes.


remove?


files under /usr/lib/pymodules/python${PY_VER}/diamond/handler actullay links to /usr/share/pyshared/diamond/handler


I personally prefer if software does not spam my home folders with visible top level directories.

`/tmp` may not be a good location because we should try to minimize download traffic.


I agree that it's too board. Please give us a pull request if you would like to change the logic.


s/thh/the


I would move this remark about coding style to a new, longer paragraph, where I think we should write also about:
* do not break public API
* use oscap_alloc, oscap_strdup, oscap_buffer_* instead of standard C functions
* do not make changes that change only identation
* do not forget #include <config.h> in your new C files
* doxygen doc
* atd.


Is this file used in any test ? if no, remove it in copying"_


I think that branches should be explained in a different text. That could be task for you since you have more experiences with it :-)


I prefer `upstream` as a name of remote.


Oh yesterday, Webkit added more ES6 features in 188545 build, Reflect.get & lexical "this" binding in arrow function :-)


Shouldn't we use regular SAB-debug-logging here?


Consider  `git pull --rebase`


I wonder if this works. I think it should be `git push --force origin fix_#455`


C++ mindset: `data.fs` is fast, but `data["fs"]` is slow. It is hard to get used to the fact that in Python these are equivalent.


this and the next line can be removed, they are implied by KDECMakeSettings included further down.


Yes, that's what I meant.. we don't need it in P3 and it's ugly in P2. But, yes.. I agree it needs to be changed.


Unique metadata ID generated, errors fixed
Update calls to tracker table to append metadata objects to array fixed


Yes, me too, but I also don't like software putting large data files in invisible folder without me knowing :-). I mean, it's not really huge in our case, but maybe we'll feature GB-sized example data sometime.

So maybe the best option would be to not download automatically if the file is not found (e.g. via an argument `download=False`)?


You're right.


I guess that needs porting still


I agree. But for the sake of compatibility we need to include it.


What is the purpose of "unsigned" here?


I think that it is very easy to create a pull request on github, you can describe it here in two sentences.


Я би трохи змінив на `classpath*:applicationContext.xml`


you usually want to put the summay at the very end of the cmakelists.txt. otherwise if someone adds a find_package call in (for example) the docs directory it won't be covered in the summary


WutFace


The contributor should write in his commit message what issue he fixes. for example: 'trac#666: fix typos in manpage`


CMake supports multiarch for finding libraries at least. It would be sad if it does not have CMAKE_* variable for finding out the suffix. What I searched LIB_SUFFIX is Fedora convention(?) If there is no CMAKE native solution this is acceptable.


I think that the channel should not be Open before getIODevice() call.
Don't you break outgoing transfers here?


This should have been a separate comment. It DOING_AJAX, skips the cookie storage and assumes it will be done using JS instead.


all files in CMakeFiles/ directories are garbage and should not be there. I'd generally suggest to do out-of-source builds.

e.g.
mkdir build
cd build
cmake ..
make

this will create all the build artifacts (cmake metadata, temporary .o files etc.) in a build subdirectory rather than in the actual source. this allows you to not accidentally write fragile cmake code where you reference a file relatively where it should have been absolute etc.


We do accept various values as [boolean](https://github.com/jxcore/jxcore/blob/master/doc/api/jxcore-feature-packaging-code-protection.markdown#boolean-values): true/1/yes false/0/no. The check here `typeof ret === "boolean"` in not directly related with that.


this line can now go, replaced by regular add_library()


It looks exciting!


а чем так плохо?


@brettwooldridge Hi Brett, after bumping the hikaricp version to 2.4.0 in Play a couple of tests started to fail because the type of `isReadOnly` has changed (see PR https://github.com/playframework/playframework/pull/5003). This is easy to fix, but I'm wondering why the change.


I will try.


Default underlying type for enum class is **int** ( http://stackoverflow.com/a/1122109/3137053 )
We need to cast unsigned values from lua scripts to enum class values, that is why underlying type is changed to unsigned


How about removing them by `sed` when concatenating?

I don't stick it, but I prefer to keep them for readability, CommonJS or ES6. (I wish we could put `*.flag` away someday...)

```javascript
import observable from 'riot-observable'
...
export default router
```


I don't see a reason to redone devices manipulation in this way, but let it be.


Let's ask the MNE guys :)


could also put in this way:
```c++
BOOST_SCOPE_EXIT_ALL(&) {
  // do clean up
}
```

one more reason to love C++11 :smiley:


"Oh" again.


@Gerst20051 Thank you for your note! It's fixed now.


Oddity.go is ready.


App name should be "Digibill" not "Doosra". Or "Digibill Test" if on testnet.


@agramfort @dengemann @Eric89GXL what do you think?


http://ncac.org/take-action/ Reported.


The contributor must write a description in his pull request.


Push the remote commits to remote branch which your pull requests is based on.


What happens if the closure requires params?


Autodesk_Performance (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why do we need to override those methods?


thanks


// This is the main file for the game logic and function
//
//
#include "game.h"
#include "Framework\console.h"
#include <iostream>
#include <iomanip>

double elapsedTime;
double deltaTime;
bool keyPressed[K_COUNT];
COORD charLocation;
COORD consoleSize;

//HengSoon Code Start

	COORD enemy1Location;
	COORD enemy2Location;
	COORD enemy3Location;

	int direction = -1;  // -1 = going left, 1 = going right
	int direction2 = -1; // -1 = going up, 1 = going down
	int direction3 = -1; // -1 = going up or left, 1 = going down or right

	bool goingRight = false, goingLeft = true, goingUp = false, goingDown = false;

//HengSoon Code End

void init()
{
    // Set precision for floating point output
    std::cout << std::fixed << std::setprecision(3);

    SetConsoleTitle(L"RGB Maze");

    // Sets the console size, this is the biggest so far.
    setConsoleSize(80, 30);

    // Get console width and height
    CONSOLE_SCREEN_BUFFER_INFO csbi; /* to get buffer info */

    /* get the number of character cells in the current buffer */
    GetConsoleScreenBufferInfo( GetStdHandle( STD_OUTPUT_HANDLE ), &csbi );
    consoleSize.X = csbi.srWindow.Right + 1;
    consoleSize.Y = csbi.srWindow.Bottom + 1;

    // set the character to be in the center of the screen.
    charLocation.X = consoleSize.X / 2;
    charLocation.Y = consoleSize.Y / 2;

//HengSoon Code Start

	enemy1Location.X = 60;
	enemy1Location.Y = 1;

	enemy2Location.X = 45;
	enemy2Location.Y = 15;

	enemy3Location.X = 20;
	enemy3Location.Y = 20;

//HengSoon Code End

    elapsedTime = 0.0;
}

void shutdown()
{
    // Reset to white text on black background
	colour(FOREGROUND_BLUE | FOREGROUND_GREEN | FOREGROUND_RED);
}

void getInput()
{
    keyPressed[K_UP] = isKeyPressed(VK_UP);
    keyPressed[K_DOWN] = isKeyPressed(VK_DOWN);
    keyPressed[K_LEFT] = isKeyPressed(VK_LEFT);
    keyPressed[K_RIGHT] = isKeyPressed(VK_RIGHT);
    keyPressed[K_ESCAPE] = isKeyPressed(VK_ESCAPE);
}

void update(double dt)
{
	CONSOLE_SCREEN_BUFFER_INFO csbi;
	GetConsoleScreenBufferInfo( GetStdHandle( STD_OUTPUT_HANDLE ), &csbi );

    // get the delta time
    elapsedTime += dt;
    deltaTime = dt;

//HengSoon Code Start

	enemy1Location.X += direction;
	enemy2Location.Y += direction2;

	if(goingRight)
	{
		direction3 = 1;
		enemy3Location.X += direction3;
		if(enemy3Location.X == csbi.srWindow.Right)
		{
			enemy3Location.X = csbi.srWindow.Right;
			goingRight = false;
			goingDown = true;
		}
	}

	if(goingLeft)
	{
		direction3 = -1;
		enemy3Location.X += direction3;
		if(enemy3Location.X == csbi.srWindow.Left)
		{
			enemy3Location.X = csbi.srWindow.Left;
			goingLeft = false;
			goingUp = true;
		}
	}

	if(goingUp)
	{
		direction3 = -1;
		enemy3Location.Y += direction3;
		if(enemy3Location.Y < 1)
		{
			goingUp = false;
			goingRight = true;
		}
	}

	if(goingDown)
	{
		direction3 = 1;
		enemy3Location.Y += direction3;
		if(enemy3Location.Y > 10)
		{
			enemy3Location.Y += direction3;
			goingDown = false;
			goingLeft = true;
		}
	}

	if(enemy1Location.X < 0 || enemy1Location.X > csbi.srWindow.Right)
	{
		direction *= -1;
	}

	if(enemy2Location.Y < 1 || enemy2Location.Y == csbi.srWindow.Bottom)
	{
		direction2 *= -1;
	}

//HengSoon Code End

    // Updating the location of the character based on the key press
    if (keyPressed[K_UP] && charLocation.Y > 0)
    {
        Beep(1440, 30);
        charLocation.Y--;
    }
    if (keyPressed[K_LEFT] && charLocation.X > 0)
    {
        Beep(1440, 30);
        charLocation.X--;
    }
    if (keyPressed[K_DOWN] && charLocation.Y < consoleSize.Y - 1)
    {
        Beep(1440, 30);
        charLocation.Y++;
    }
    if (keyPressed[K_RIGHT] && charLocation.X < consoleSize.X - 1)
    {
        Beep(1440, 30);
        charLocation.X++;
    }

    // quits the game if player hits the escape key
    if (keyPressed[K_ESCAPE])
        g_quitGame = true;
}

void render()
{
    // clear previous screen
    colour(0x0F);
    cls();

    //render the game

    //render test screen code (not efficient at all)
    const WORD colors[] =   {
	                        0x1A, 0x2B, 0x3C, 0x4D, 0x5E, 0x6F,
	                        0xA1, 0xB2, 0xC3, 0xD4, 0xE5, 0xF6
	                        };

	for (int i = 0; i < 12; ++i)
	{
		gotoXY(3*i,i+1);
		colour(colors[i]);
		std::cout << "O";
	}

    // render time taken to calculate this frame
    gotoXY(70, 0);
    colour(0x1A);
    std::cout << 1.0 / deltaTime << "fps" << std::endl;

    gotoXY(0, 0);
    colour(0x59);
    std::cout << elapsedTime << "secs" << std::endl;

    // render character
    gotoXY(charLocation);
    colour(0x0C);
    std::cout << (char)1;

//HengSoon Code Start

	// render enemies
	gotoXY(enemy1Location);
	colour(0x2B);
	std::cout << (char)1;

	gotoXY(enemy2Location);
	colour(0x2B);
	std::cout << (char)1;

	gotoXY(enemy3Location);
	colour(0x2B);
	std::cout << (char)1;

//HengSoon Code End

}


Just out of curiosity, did you do this because it is faster or something?


Great commit Matthew, thanks!


Autodesk_Performance (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


It is because of LuaBridge inner magic. It doesn't allow exposing methods of parent classes to lua


Coming back to this. I spoke with @rbuckton while working on some output issues, and as @mihailik mentioned, I don't necessarily think this fixes the problem.

As part of a change I'm making, I'm planning on changing this to `process.stdout.write`. Hopefully this will have a positive (or at least non-negative) impact.


also fix the file name


excellent!


why are closures no longer bound to app?


Hi,

I add the '*open with SublimeText at line_number*' feature to sack. I just improve the `F` script.
I store the filename and the line number, then I highly inspired from you for the `if [[ "$editor" =~ 'subl' ]]`.

See https://github.com/garaud/sack/issues/7 and the related commit (from today).

I tried and it works! Sorry for the delay.

Cheers,
Damien


I wrote it as a test in hurry i think i have to write it again and fix styling and indention and i will send a pull request with a better version.


Die Frage war nicht wie viel Wörter du speichern möchtest, sondern was du alles speichern möchtest.
Wenn du LOB schreibst, muss es nicht nur Text sein.


any COPYING file for green-100x100.png?


Merged!


what does it mean ?


In such a case I would prefer to have a block (a):

````
if ( ... )
{
    // Some comment giving info about the assignment or so
    x = 0;
}
else
    x = 1;
````

Or the comment is in the same line like the assignment (b).

I will do the change, simply let me know which one you prefer (a or b)!


should change the file path for windows,


should change the file path for windows?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.507](http://teamcity.monogame.net/viewLog.html?buildId=9715&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I think it should be called `promisify`


Ich will einfach nur mehr Text als 255 Zeichen. Ich dachte dafür muss man mit @lob annotieren.


No copy/paste, please. It can be rewritten with the ES6 syntax and most of the boilerplate code (especially dealing with the arguments can be removed).


- Search field before the map (doesn't reaaly see it under the map)
- Better placeholder (actually, if you wanna edit the field, it empty it)


`#!`必须出现在脚本的第一行，否则是没有效果的


dumps of the cache were: all records then all 1s.
Maybe my correction is not the best one: I prevent crap from being copied to the new cache that
is the result of resizing.
Maybe the correct fix is to prevent crap from entering the cache, but I really don't know this code enough.
Also, it's scarce on comments and it's just code: I don't understand so much the algorithm.


`my ($infile, $outfile) = @ARGV;`


\r-


these should be gone in the new commits


Hi,

I'd like to add you to my professional network on LinkedIn.

- Nikita

Confirm that you know Nikita: https://www.linkedin.com/e/v2?e=-gkbjx8-idh39x1k-3b&t=ssuw&tracking=eml-guest-invite-cta&ek=invite_guest&sharedKey=R3pC9XKj&invitationId=6039321907231236096

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/e/v2?e=-gkbjx8-idh39x1k-3b&t=lun&midToken=AQFmrFVhGEd36Q&ek=invite_guest&loid=AQG0Ye9wLnSA_wAAAU8_7U74ad8X-EcU9l3syJ5gS86MZmow6xZ36tcvKgLrVcsmgkDJ7uSbBpY94qge2NwbRTQXpRc80x-DXAdQl63BzdMhQWjWKPmz55mmSksxUfC0b3kqSo72kzPx1LCRk0QjWqeYu95A_VCnsdZB5KWMe0xbDvpbYgeJ7zZHUPh6sSbm9VTA&eid=-gkbjx8-idh39x1k-3b Learn why we included this at the following link: https://www.linkedin.com/e/v2?e=-gkbjx8-idh39x1k-3b&a=customerServiceUrl&ek=invite_guest&articleId=4788
© 2015, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA


See above.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.507](http://teamcity.monogame.net/viewLog.html?buildId=9715&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:04:49


@pluma why even bother with a warning? For my private Foxx app, I'd rather use a date/time stamp as version. And to work around this validation, it now looks like `0.0.201507311051`. I understand the need for semver for public foxx apps, but perhaps this could just be a manual validation when adding something to https://github.com/arangodb/foxx-apps.


没必要用`/\-/`，直接`"-"`即可，下同


The `.size` method happens to be cached. While we were effectively downsizing the image, the `.size` only changed once in the loop. I think it's fine to leave it as-is for the importers.


removed


What about trac? We should say that you need to close manually ticket on trac


Jo, korrekt. Das habe ich mir jetzt auch gedacht ;-)
Ich machs mal...


a


@Keader Ok I understand but the spectator as I know cannot /wisp or other thing right? but we put the condition if they talk on skype?


Oh, of course, now I see it.


Is this warning message really telling truth? AFAIK code is only compiled on the server side. My concerns was that file may begin with `#!/bin/bash env python` and be executable and then if user could somehow access it from the browser it would be game over.
Of course I wouldn't be surprised if unsandboxed code->bytecode compilation had some holes as well... so I think that only the message should be altered.


Indentation is wrong, comment style should be /* */ (same below)


I yesterday merged some Thing Map data from ArchDemon's branch. If you should need them, FYI


Not needed?


@cmantill you can try s.th. like

Float_t minJPt(99999.);
for(int j=0; j<nj; j++) minJPt=TMath::Min(jpt[j],minJPt);
fTJPt=minJPt;


unfortunately I made the changes simultaneously.. bad idea..


@rmasco, @yuji: OIDC::Lite requires XS modules such as JSON::XS and XML::LibXML. It is better that users install OIDC::Lite themselves, or that MT do not use OIDC::Lite, I think.


actually this commit has just finished the caption 6


Good point. Given that you're handing over code to be executed, there's almost certainly a vector in there somewhere, but it's not as simple as "put os.removedirs('/') in the text box".


You could just use `it { is_expected ...` for each of this tests since their are self-explanatory. Instead of let(:mail) you need `subject { ` -> is_expected operates on subject as default. Also would be nice to use mailer matchers (email_spec gem) like for ex. `deliver_from, deliver_to, have_subject, have_body_text` for greater readability.


I prefer approach (a)

Thanks.


I think option 2 (Move to end) is probably the best idea. Developing Modules that have the Same Name als Standard Modules is not such a good idea Anyway.
Georg

Georg Viehöver (georg.viehoever@web.de)

> Am 18.08.2015 um 02:54 schrieb ywangd <notifications@github.com>:
>
> @GeorgViehoever I did notice this problem as well. However I am not sure what the best solution is. There are a few options. But none of them is perfect.
>
> Remove dot from sys.path
>
> This risks breaking other code if they do intend to import from the same directory when the scripts reside (e.g. https://forum.omz-software.com/topic/2089/160025-import-from-same-directory)
> Move dot to the end of sys.path
>
> This would lead to similar problem as above when the module in current directory is shadowed by scripts with the same in other directories.
> Rename copy.py to something else
>
> This would solve this particular import error. But it does not tackle the true cause of the issue.
> —
> Reply to this email directly or view it on GitHub.
>


I need help with this, @zufrieden @gido @Yago .

IE 9 only appends the `title` item... :rage:


You don't need `RSpec.` here. Also, you should check in this controller changes in ActionMailer::Base.deliveries, also you can check is any instance of specific mailer called specific method, to make sure that right mailer was used in controller.


How doesn't this break Bluetooth on bacon? Everything I compile gives me that there are Bluetooth missing files.

Explained better here :https://github.com/temasek/android_build/commit/a40957636960cd87de562e37fcbd811422c62242


@miltontony is this right ?


Why this?


Why it is empty? What that class is responsible for?


I would prefer making it even more like Content/ContentType, so removing this one and changing `createRole(RoleCreateStruct $roleCreateStruct)` to always create in draft state. And then the other changes as well that follow from that.

But I guess we don't want to break things like that, even if it is for 6.0?


what is this? no new line after include


well done


- JSON::XS cannot be enclosed in extlib, because it is XS module.
- Some modules which OIDC::Lite requires are not enclosed in extlib. (e.g. Try::Tiny)


I noticed a bug in this commit:

When repeatDelay > 0, then the timer is still not cancelled as this loop continues it's work also when parent.canceled == true :

            while(!canceled) {
                Thread.sleep(repeatDelay);
                lastExecution = System.currentTimeMillis();
                run();
            }


It turns out that pow() is perfectly optimized for the case of 2, but std::norm() is more explicit and makes code more readable.


nitpick, I propose to use the same comment style for struct members (just as the ones below)


I need to re new the $$hashKey of the chip. How can I do that?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.508](http://teamcity.monogame.net/viewLog.html?buildId=9719&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


we can make this a temporary solution, but on a long run we should find out why the deployHandler still runs for that context.


Are these tickets propagating back to the source repository at Xero? Is this a crossed-line, or am I missing something?


...with the given ~~name~~ **id** was...


I think that the heading should be only "How to contribute to OpenSCAP"


Comparison of results between SHADE,CoDe,SHADE(modified).


name -> identifier


whoooo!


Apart from the question above, this looks good to me (https://github.com/ezsystems/ezpublish-kernel/commit/927ada70e76cfd068f1510a1fa5e676009552c94 as well).


Проверку лучше убрать, потому что сверху ты это уже сделал через `switch`. И передевать лучше сразу `IProject delta`. Тоже и к методу ниже.


Another option would be to change model so that footprint is smaller, it could be just a narrow cylinder base. It would make more sense imo.


But this is only a jammer, not cloaker and is constantly moving, it wont stand still.


When somebody want to fix bug from tracker, he/she should assign the bug.


Assignment 1


Thanks. Here are some flowers for you: :bouquet:


gotcha should remove OIDC:Lite form extlib.
Then, should not allow to configure/settings on Web Services Prefs without OIDC::Lite.


```bash
# make install
```
should be better


where the size (14) comes from?


app.iml file's commit is unneeded.


I don't like how we detect if an event has been fired based on whether it's been stopped or not. You can't really hook into the process if you just stop the event somewhere. It's hacky in a bad way.


Ignore, forgot that name = identifier here :)


Won't we want to use hrm_group_controller() here?


Gofundme.com
Gets donations from all viewers who view gregsenterprises@Gmail.com's Campaign with
Gofundme.com


Thanks for fixing this :+1:


Please send donations


fun!


```java
// Set all elements of tree to checked state.
public final void SerializationConfigView::checkAll()
```

Зачем ? Не надо никаких комментариев. Вот совсем, даже для API. У нас нет цели разработывать и *поддерживать* документацию. Вот [тут](https://ru.wikipedia.org/wiki/%D0%94%D0%BE%D0%BA%D1%83%D0%BC%D0%B5%D0%BD%D1%82%D0%B0%D1%86%D0%B8%D1%8F_%D0%BD%D0%B0_%D0%BF%D1%80%D0%BE%D0%B3%D1%80%D0%B0%D0%BC%D0%BC%D0%BD%D0%BE%D0%B5_%D0%BE%D0%B1%D0%B5%D1%81%D0%BF%D0%B5%D1%87%D0%B5%D0%BD%D0%B8%D0%B5#.D0.A2.D0.B5.D1.85.D0.BD.D0.B8.D1.87.D0.B5.D1.81.D0.BA.D0.B0.D1.8F_.D0.B4.D0.BE.D0.BA.D1.83.D0.BC.D0.B5.D0.BD.D1.82.D0.B0.D1.86.D0.B8.D1.8F) всё написано красиво. Там же
>Это также упрощает поддержку документации в актуальном состоянии.

Проверь, что будет если переименовать параметр метода. В JavaDoc он тоже переименуется автоматически ?


*
```Returns all projects owned by ownerId```. I think the following will be clearer and match the rest
```Returns all projects owned by the specified user```.
The same apply to all types i.e. datasets, screens etc

* ```the session user in the  specified group``` Extra space before ```specified```


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.508](http://teamcity.monogame.net/viewLog.html?buildId=9719&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests passed: 538, ignored: 6; exit code 1 Build time: 00:15:18


Can you tell me what this is?


Working now. Thanks @buggtb


Could you put this code snippet into a function with bytes range's starting byte and end byte as parameters?

Because this part (https://github.com/wangmingshuai/distribution/blob/master/registry/storage/driver/s3/s3.go#L616) also needs to be changed. Ceph S3 also doesn't support multiple part uploads with x-amz-copy-source header.


Test


:+1: :)


Fixed


Yep :+1: :)


click doesn't support 3.2 (like MANY other libraries), and python3 doesn't have `unicode()`


Это просто превентивная защита от трудноотлавливаемых внутренних ошибок, чтобы в метод нельзя было передать что попало.

Насчет передачи не очень понял, класса `IProjectDelta` нет, есть только общий `IResourceDelta`, у которого в `getResource()` могут лежать разные виды ресурсов, в том числе `IProject`.


Sorry @judgej, I might have been abusing github for getting in touch with @ronanq (he works at Xero!)

Ronan, using LineItems was actually a terrible example.  It's more a case of defining the object you might get back from the API, like addresses and phone numbers in the 'Types' section.  The only indication of what you get back currently is the XML showing an example request.


This document provides a comprehensive architectural overview of the solution for the CTP Project ‘Securities Recording & Viewing’, using a number of different architectural views to depict different aspects of the system.
The project’s Requirements Definition Report (RDR) captures the functional and non-functional requirements that must be delivered by the project, affecting both application and infrastructure aspects of any solution.
The Outline Solution Design (OSD) provides an overarching view of how the project will deliver the solution.
This document expands on the OSD, providing additional detail around both the application and infrastructure components that must be developed.  It describes at a high level how the proposed solution will be delivered on the target architecture.
Within the Commercial Transformation Programme, responsibility for delivery of all IT infrastructure components resides with the CTP Infrastructure project.  Because of this, no Provisioning Plan will be produced by this project.
Mid-Level Platform Designs will be produced for each affected Platform, using either project resource or Platform team resource, as appropriate.
This document will be reviewed against both the Outline Solution Design and the Requirements Definition Report to ensure that the proposed design will meet both the target architecture and the agreed requirements.  The lower-level deliverables will be reviewed against this document as part of their review process.

1.2	Scope
The scope of this document includes:
•	Overall architectural topology including logical, implementation and infrastructure views.
•	Overview of the proposed solution
•	High level architectural decisions
It does not cover:
•	Detailed functional and technical analysis of the low level problem domains
The scope of this project, the stakeholder group and the existing processes are defined in the Recording and Viewing Securities Terms of Reference.
The focus of this project is the replacement of the legacy Branch Information Technology Lending Information Securities Information system, “BIT LI SI”.  It will include the provision of a summary of security based on a requested list of customers – i.e. either a single customer or a group of related customers.
This project will NOT look to replace the securities perfection process currently managed by the Securities Centre using Visual Files.  Nor will it change the processes regarding the capture of securities information (whether manually or automatically in other applications).
1.2.1	Project Inter-dependencies with Lending Information
•	The Lending Groups application currently allows the Securities situation for a Lending Group to be displayed read-only (the ‘Group Summary of Securities’), and further, allows navigation for a particular Security item to a detailed view and/or maintenance function for that item.  A similar interface will be required between the new applications.
•	The Balances & Liabilities function requires a service currently exposed by the Securities system to obtain ‘guarantee of liability’ for liabilities.  This will need to be provided by the new Securities system.
•	Securities need to know which product to apply as a limitation.  “Internal” products will be provided by OCIS as normal; “external” Balances & Liabilities products will also be held in OCIS with an “external system id” of ‘B/L’.
The two solutions must be delivered side-by-side.  Failure to do so would introduce horrible issues such as:
•	An early delivery of Lending Groups would otherwise require some complex way of interfacing with the legacy BIT Securities application for Group Summary of Securities.
•	An early delivery of Securities would otherwise require some complex retro fitment of the new Securities interface to the legacy BIT Lending Groups application.
•	Increased complexity with separate migrations.


Looks like a duplicate line introduced by copy-paste.


Shaun, have you got a sample code with JSON for submitting or receiving ? I think I saw one before , not quite sure was in your rep.


We have arrow functions for this purposes


See: https://babeljs.io/docs/learn-es2015/#default-rest-spread


Hi @Jermolene
I do like the 'fold/unfold all' - available in the prerelease - very much but was wondering why not combine both buttons in one button that toggles the state and icons (like the sidebar button)?


![Uploading lineView.gif…]()
用法很简单 见 demo


Fixed in https://github.com/sinelaw/buildsome/commit/e3c20f0956bd1a664606d253ab039a11053c16c8


Can be extracted to variable for better semantics


Fixed in https://github.com/sinelaw/buildsome/commit/f2a0867c23f620ea3e3d8dd1bbf013ada8277923


I'm not very sure. But if I don't start it I don't need to stop it.


Fixes #19


We don't use this code style for conditions


![Uploading lineView.gif…]()


\r-


#33
#4
#6


```
communities: community logo feature addition

* NEW Enables possibility to add community logo.
  (addresses zenodo/zenodo#112)

Signed-off-by: Adrian Pawel Baran <adrian.pawel.baran@cern.ch>
```


Да, с методом печально. Надо или оставить как есть или передавать сюда два параметра
```handleProjectChanges(IProject project, typeof(delta.getKind()) как operation)```

А вот проверкой ты что проверяешь - Эклипс или свой код ? Если Эклипс, то не надо.


how about:
``` C
case AF_INET:
case AF_INET6:
s->domain = domain;
            s->type = type;
            if ((s->protocol = _choose_ipproto(type, protocol)) < 0) {
                res = -1;
            }
break;
```


I really like this example.