the "id of thread" extra words end of threadId param also exist in this class.


My whinging will not be impeded.


```
@defgroup datasets_track Tracking
```
goes before of
```
### VOT 2015 Database
```


Corrected.


i think while default config is doing those assumptions it's good to go here + https://github.com/actionless/awesome/commit/3f2ee46a10cee0633e509bfd272e61011b5d744e#commitcomment-12829322


Ah, no I think you're right - so the choice is between duplicating the /my and /reports/body template (so that these cobrands can include the filters there and share a filters template), duplicating the filters template as it was before, or adding a conditional to only include it on certain cobrand pages. Which would you prefer?


isn't this covered by the next line?


Right. OK, I will try to reproduce those as in `utils.preprocessing.tests.test_data`:

```python
def test_standard_scaler_numerical_stability():
    """Test numerical stability of scaling"""
    # np.log(1e-5) is taken because of its floating point representation
    # was empirically found to cause numerical problems with np.mean & np.std.

    x = np.zeros(8, dtype=np.float64) + np.log(1e-5, dtype=np.float64)
    if
    Version(np.__version__) >= LooseVersion('1.9'):
        # This does not raise a warning as the number of samples is too low
        # to trigger the problem in recent numpy
        x_scaled = assert_no_warnings(scale, x)
        assert_array_almost_equal(scale(x), np.zeros(8))
    else:
        w = "standard deviation of the data is probably very close to 0"
        x_scaled = assert_warns_message(UserWarning, w, scale, x)
        assert_array_almost_equal(x_scaled, np.zeros(8))
```


Nit on inconsistent indentation/whitespace


> So maybe the better thing to do is to just remove mkmailspool.

Agreed.


tests don't pass with this commit.


i am thinking of `awful.hotkey_popup`


I didn't want to create another SQL query. It retrieves all the users that are attached to the same template and same permission so there's an important filter already. I'll make up my mind about it.


why is this using `/srv/www` if it's running in vagrant?


1. I don't like the name `custom.css`. If there are many apps and many use `custom.css`, there will be confusion (the one that already existed, `base.css`, has the same problem). `enhydris.css` would be better.
2. Why these 20px margins and paddings? I don't see any difference if I don't use them.


@aerosol Nice! I'll try that. Thanks!


why?


Double spaces (with__key and for__key)


I think it's picking out non-quoted characters, and double-quoted strings (accepting escaped characters).

I don't get the `,` in `[^\s,"]` though -- is it treating a comma as special in some way?


why all these `|| true`?


Note that at the moment this is not an equivalent change (thought quite a step in progressive direction), since the oldways `upsdrvctl start/stop` iterated the current `ups.conf` and took care of defined drivers, while with this PR there should also be a script (likely a service and maybe a timer to tickle it regularly) to walk the configuration and (un-)define the service instances and so trigger their start/stop.


The path is built in the php version, e.g. the default config path. To have it correct in the container we use the same directory here.


1774_add_misc_objects (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


explained in https://github.com/justcarakas/forkcms/commit/0ea461840f7856bfb861dfb820564429dbbaaa4d#commitcomment-12754125


Update: si fue el bueno.


see above


The title 'Translating content' ... could be a bit more precise because text translated in templates, etc. is also content; here it's about content stored in model fields. Maybe something like 'Translating Model Fields'.


that magic button must be great :D, thanks


maybe a but much `cd`ing here?


take a minute to consider exposing a single bean (which can have either a groupId or a groupName, and not both, by contract) in PermissionRequest, instead of exposing a groupId and a groupName. I bet it will make things clearer and simpler


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19486/testReport/) for this commit**


101682488_EvapCoolPrimaryAirSizing (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1793 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.67%25-yellow.svg)


Cool! I like your implementation a lot better!


To enable multiple builds in the same vagrant box php-memcached is cleaned up to avoid using wrong php-memcached linking.


This file already includes ES2015 arrow functions ;)


might be better to say ID of the transaction rather than ID of operation -- applies to all transactional methods


The Stackato manifest is here:
https://github.com/mozilla/bugherder/blob/master/stackato.yml

Our own ticket related to this, with more info is at https://bugzilla.mozilla.org/show_bug.cgi?id=1183368

> The most likely explanation for your error is that whoever uploaded the buildpack did not pull in the submodules before packaging and uploading.

I'm referencing the buildpack using `BUILDPACK_URL` (it's all the older version of Stackato supports, and the admins our Stackato instance are either unable or unwilling to upload the buildpack):
https://github.com/mozilla/bugherder/blob/master/stackato.yml#L37

That said, we're using the older v2.x Stackato release (which is out of date in multiple ways, but I have no control over the version used), so this may just be wontfix. We've also been encouraged to move from our hosted Stackato instance to Heroku, so I'm happy to leave this as is for now (otherwise I'd file an issue, per the suggestion above) :-)


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8166/testReport/) for this commit**


@173210 Yes and free from closed source NTR (from cell09) yep.


well, those actually will evolve over time, and definitely faster than the types of robots created by Aldebaran :) Plus some of those would be relevant to very few users (like NAO without legts and/or arms). I'd say there are like 10/15 of those (including all the Pepper and such). I'd rather keep it flexible for now.


TeamCity pull requests :: netty [Build 92](https://garage.netty.io/teamcity/viewLog.html?buildId=636&buildTypeId=pulls_netty&guest=1) is now running


timeout is in miliseconds, as there is no unit passed here. Applies to all similar methods with similar parameters as there are others.


ok


Disabling CURLOPT_SSL_VERIFYPEER should work now, can you try?


weblogic web service using ant jwsc task


I believe I fully understand what you are proposing @romul .

I have only one comment/question:

As you know (and for everyone else's benefit), in Spree the option types/values could be used to form skus/variants and properties are used at the product (not sku/variant) level (they were used to describe general properties about every sku in the product).

Example:

Imagine you are selling a microwave oven

# Options
* Available Colors

# Properties
* Manufacturer
* Wattage
* Warranty

Options can change with each sku for a product but properties do not (and that's why you have both product_id and sku_id in the product_property table)

My inclination is that there might still be a benefit to differentiating between the two (either by a column in the product property table e.g. is_option or by a separate table?).

For example, given the above options:

If you create a product in the admin application, you could specify that any skus for this product must be assigned a color (and possibly that it must be unique).

You can also enforce that some new employee doesn't try to use the admin app to create a sku using 'Color' and 'Wattage'.

If you have numerous options/properties and they were all represented as in your ERD, you'd have a very long list from which to create skus, vs a much smaller list of 'legal' options.

I do like the typing you've done.  My only question above is "does it still make sense to treat them as two different types of entities?".   How would you enforce "only use these properties to create skus, but not these other ones"?.

I'd really like to hear from others on this as well.

Thanks for the work on this!


I'll do the same for project if I find it clearer and simpler


please use english as the working language everywhere :-)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19488/testReport/) for this commit**


Yeah!


I see, are we sending any dashboard packet later on in this case?


why not just `export LC_ALL=...`?


And no it solved nothing... :disappointed:


Папку packages нужно ставить в игнор, все плагины добавляются автоматически


Ok - we can revert that if it's harmful. Didn't really seem back then. Apart from the CI build, the other area that is affected by having the repos in a profile is importing into an IDE: at least for Intellij, having the profile active by default allows importing the project without further instructions. Generally, it seemed like the default would be to have the profile activated. AFAICT the repositories don't make it in the generated POM anyway (which is a concern).


Looks do-able.  One change you may have to make in addition is that the setup.py script looks for the presence of the 'tox.ini' file and uses that to determine if it is running "in tree" rather than from a pypi source distribution (there would be no tox.ini file in the latter case).

You should run this patch past Flavio - I remember asking him if it made sense to move all the generated stuff into the build dir, and he had a reason not to do so.  I forget his point.  His github account is  https://github.com/flaper87

The error you are seeing -
ImportError: dynamic module does not define init function (PyInit__cproton)

I seem to recall seeing this when a py3 interpreter tries to load a .so that has been built for py2.
That seems to be the problem here, as the traceback references an installed proton:

File "/usr/local/lib64/proton/bindings/python/cproton.py", line 28, in <module>

That path should be pointing to proton/bindings/python/.tox/.......

There's a JIRA opened against this (which IIRC you had originally opened)


Nice!  :-)


`.report-list` is never used with `.full-width`. And `.full-width` is meant to be a "mixin" type class, it shouldn't need to be overridden back, hmm, as you say it has got a bit confused. Why is the margin-left set to 0 in this file just above?

This change makes the Oxfordshire /my page unbalanced, I'm afraid, whereas it's okay at present (as the current placement applies to both reports and updates, and pulls both sides). Oxfordshire's problem is partly because its `.content` has been set to box-sizing:border-box which is messing up the padding/widths around there.


`let` will be better


Looking in the `ceylon.time.timezone:TimeZone.ceylon`, this is the definition of ZoneDateTime:
```ceylon
shared interface ZoneDateTime
       satisfies ReadableDateTime
               & DateTimeBehavior<ZoneDateTime, Date, Time>
               & Comparable<ZoneDateTime>
               & Ordinal<ZoneDateTime> & Enumerable<ZoneDateTime> {
...
}
```

So, it is an interface.

However, I agree, there should probably be a separate `ReadableZoneDateTime` interface somewhere, although the only additional field it adds to `ReadableDateTime` would be `timeZone`. Is it worth it?

I don't know...


does that also affect the runtime? or is just the compilation broken?


Is this empty line added on purpose?


好热闹。祝好！


one ldconfig is enough


should be "was sent by a machine"


The glyphicon-search looks like a button, but it does not work like a button.


if opts->data_dir == null then r will be 0 and sml_load will fail. is this the expected?


is this a copy or modification of the existing boot.sh?


With local Eureka running I didn't the routings, so removed them. I'll put it back for testing without Eureka running.


TeamCity pull requests :: netty [Build 92](https://garage.netty.io/teamcity/viewLog.html?buildId=636&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4701, ignored: 16 Build time: 00:09:49
### Failed tests
```
io.netty.handler.codec.http2.Http2ConnectionRoundtripTest.noMoreStreamIdsShouldSendGoAway: <no details avaliable>

```


> by a column in the product property table e.g. is_option
yeah, it's a `variable` column.. It supposed, that it means that property value could be variable among SKUs and override default value assigned to a product. So, when you're editing SKU, you definitely see only variable properties.


it means 坑比 233...

floating-cat <notifications@github.com>于2015年8月21日周五 21:51写道：

> What does KB means in this context, kill bugs?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/drakeet/Meizhi/commit/956ae0e73fc1fe61fe183a064673e4fc8d77c7a2#commitcomment-12829331>
> .
>


unclear comment


should be "their" configuration


Hmm, but this is weird, don't you think?


GitAttributes (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-19.99%25-red.svg)


Can I return localhost:9007 in case of exception or no Eureka?


I think smallest thing to do would be to have it as it was (in terms of blank base, INCLUDE in body.html and my.html), but to have one file and the other two be symlinks to that file, to make it clear that they're identical (and you don't have to remember to at present update three any time you make a change).


Thanks for your contribution.
Btw you should push commit to our gerrit code review, it will be better :)


there are many obvious bugs in 23.0.0..

许晓锋 <drakeet.me@gmail.com>于2015年8月21日周五 22:10写道：

> it means 坑比 233...
>
> floating-cat <notifications@github.com>于2015年8月21日周五 21:51写道：
>
>> What does KB means in this context, kill bugs?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/drakeet/Meizhi/commit/956ae0e73fc1fe61fe183a064673e4fc8d77c7a2#commitcomment-12829331>
>> .
>>
>


@edmorley I don't know exactly what version of cf-release is the ancestor of your version of Stackato, but I can tell you that submodule support in Buildpack repos dates back to this commit in May 2013:

> https://github.com/cloudfoundry/dea_ng/commit/8742cf5

In other words, Cloud Foundries derived from an earlier version are no longer supported by the current generation of Buildpacks.

You can likely work around this (if you're really desperate) by forking the buildpack, and putting the submodule code into your fork; then the lack of submodule support won't be an issue.

However, given the age of your installation, it's likely that you're also running an unsupported (and likely insecure) rootfs, and so we're likely to head down a deep rabbit hole of "what other assumptions are broken?".


If you have a 64 bit machine, wouldn't both of these lines be executed? Thus setting the package_source to just '-#{version}.msi' ?


typo "eis"


I was up late last night trying to figure out the correct way for us to script resigning apps.  I found your project.  I was looking through the commit log and just happened to see this.  I was looking for instructions earlier on how you wanted PRs done (similar to https://github.com/mitchellh/vagrant/blob/master/CONTRIBUTING.md).


I just pushed a fix and release.


Great commands, really useful! :+1:


I think you should schedule the worker here as we do in process and predict. If save_process is called but there is no process running we need to save it anyway instead of waiting for next process/predict process.


I think this sounds a bit vague, maybe more like "it is a marker error indicating the operation should be retried. "


should be "operation is about to be sent"


add && !save_needed
if save is scheduled at the end of last process or predict this method will be called with save_needed == true, process_needed == false, predict_needed == false, and we still need to save it


> I am still confused on what to put into the "received" method in games.coffee. I know what the data is -> @game.number_of_players_needed, but how do I get the program to display the data within the DOM? I did a little bit of DOM manipulation when I was at the Academy, but I have forgotten how to do it (I know I can relearn).

I'm guessing that since your work at RoleModel didn't include much work with jQuery, and that DOM manipulation was probably somewhat of a chore (because it really isn't simple with plain javascript). With jQuery, however, DOM manipulation is simply a breeze. jQuery is very powerful in terms of what you can achieve in small amounts of code, so it would be hard to give an overview here. I would recommend [checking this out](http://learn.jquery.com) to learn more about the basics of what you can do with jQuery.

> Also, in the prior actioncable-example, they were using data.comment, I do not think I need some kind of method call on the data since it is a number, correct?

You actually do need to call a method on that data, since the data comes through as a hash (or just a javascript Object, which happen to be the same :-). In the `GamesPlayer` class, when you post the notification, you pass the channel name, and then some data: `{update: @game.number_of_players_needed}`. I suppose you could skip passing in a hash and just pass the value of `@game.number_of_players_needed`, just to see if it works. If you could just pass in the value alone, without putting it in a hash, then you wouldn't need to call `data.update` in the `received` function.

> One of your last statement, "You'll need to put the number of players [...] in number of players." Where does this code go, I guess in games.coffee? If so, where?

That would go in the `received` function, since that is where you get the updated value when a new player joins the game.

> I guess I should replace "userIsCurrentUser: (comment) ->" with something like "playerIsCurrentPlayer: (data) ->"? But what is the data?

That code was specific to that particular example, and I don't think you'll need something like that in yours. The example used that because they didn't want to update the UI for the user that made the comment, but that situation doesn't apply here, so you can safely leave that out.


should be "Indicates operation is sent to a machine that isn't a member of the cluster"


typo "syste"


Personnal web developper account for amateur purpose


> We should just use #define LINUX_STORAGE_USE_FRAM 0
> Do you agree with me?

yes.


@gkiar you broke this.  why'd you take this out, you were supposed to add content.
please put this back in and add content.


There was no lorem ipsum.....?

--
Greg Kiar <gkiar07@gmail.com>

On Fri, Aug 21, 2015 at 10:18 AM, joshua vogelstein <
notifications@github.com> wrote:

> @gkiar <https://github.com/gkiar> you broke this. why'd you take this
> out, you were supposed to add content.
> please put this back in and add content.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openconnectome/ocp.me/commit/57abc861d5880ca6c19f88069eb4069a4b03453a#commitcomment-12829912>
> .
>


I’m not sure how necessary that will be once we convert our ICD-9 DX’s.  At that point we can get the previous GAF from the previous layer in the ICD-10 Record.

We are planning our conversion for first thing on Monday AM.


Nice


Yea, it looks good, working on a new PR.
Thanks for your help!


you can see the edits I made in the pull request, I literally changed 4
links 2 titles and a description.

--
Greg Kiar <gkiar07@gmail.com>

On Fri, Aug 21, 2015 at 10:18 AM, Greg Kiar <gkiar07@gmail.com> wrote:

> There was no lorem ipsum.....?
>
> --
> Greg Kiar <gkiar07@gmail.com>
>
> On Fri, Aug 21, 2015 at 10:18 AM, joshua vogelstein <
> notifications@github.com> wrote:
>
>> @gkiar <https://github.com/gkiar> you broke this. why'd you take this
>> out, you were supposed to add content.
>> please put this back in and add content.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/openconnectome/ocp.me/commit/57abc861d5880ca6c19f88069eb4069a4b03453a#commitcomment-12829912>
>> .
>>
>
>


lgtm


lgtm % comments


also note, this is a commit by @j6k4m8 .....


So these files can be deleted?


The reason for what I agree is a rather ugly solution is that the version of the lineprogram is embedded in the header of that lineprogram (a rather interesting design decision). You have to read the first few bytes of the header to discover the version of the header and only then can you know the format of the rest of the header.

Unfortunately when create_lineprog_header is called you don't know the version of the lineprogram as it hasn't yet been read and it doesn't have to be the same dwarf version as the compile unit that references it. An if statement unfortunately therefore wouldn't work.

As for the _ that is because the ctx at that point refers to the Struct containing the MetaField, not the lineprogram header. The _ refers to the parent context of the struct and therefore allows us to read the version of the header in order to determine whether or not to read maximum_operations_per_instruction or not.


**Good work documenting i18n.**  For a **CMS**, I would expect not to have to do so much work in order to have a multilingual Website. Checked out Django-CMS which has multilanguage support  'out of the box' which was great! But I much prefer Wagtail, especially now that I use wagtail-modeltranslation.

My only concern about your well written document on some of the techniques one can use to make Wagtail CMS multilingual is that it seems to me like Wagtail isn't going to include some of those functions in its code base, like Django-CMS did, but I could be wrong.

Just my 2 cents ...  Amazing work you're doing ...


Remove everything below this


Cool.


Don't we need , at the end of the line?


make ```int nestedModulesCount```, not ```int?```


Sorry, didn't mean to commit this. I had to roll back to 2.2.2 locally because of my Boxen setup.


Also update tests that depend on this.


Thanks for the quick reply.

In next hour you get a proposal for a revision of the actions_sendmails.inc.php. This is also fine for me.
Our new module "dolimail" is to send mails directly for example to partners, users, bills project. For this we get the mails from IMAP postbox directly to Dolibarr database. If you would like more information for dolimail I give it to you gladly.

When sending/writing a new mail, the mail is stored on the IMAP server and in next step the system import it to partner-tab.
In addition, it is possible in our dolimail version when you forward emails with attachments to delete all attachments at once from mail.


nice


For that kind of soundness proof, wouldn't we have to incorporate the semantics of ML itself which already entails bounds checking in the `.{i}`?


Fix private method naming and signature


Where do you find this parts? Thanks!


fix signature


+1, but s/sml_data_packe/sml_data_packet/ in comment.


this is a datasciencecoursera repo


remove commented out code


try to change something


ops. I forgot that. Thank you.
+1


So isn't this better than the old buffer which used 7.32421875 clusters?


Refactor to be less confusing


Co myślisz o tym żeby to trochę skompresować:
```coffeescript
(@currentChamber.ancestor || @currentChamber).radius * @genotype.growthFactor
```


make internal, not public


In fact, I believe you should simply get back the Sale order line description, if possible.

If not possible, then you should apply what I say in my comment above.


rename to ```dependencies```


rename to ```dependencyList```


I'd say we should add http://api.jquery.com/not/ to FlowQuery to make this intuitive ;)


Wouldn't it be better to use switch here?


remove default value for ```dependencies```


Since you're properly handling the wrong packet type (sending an error packet) why are you returning an error value? Shouldn't you return 0 here?


remove this comment


Yes it is


Don't know any more, removed


removed


add comment about this queue


- strike comma in second sentence
- make the last link into an actual link


sort usings


try to use
```perl
my $cmp = NCM::Component::fstab->new('fstab', log => CAF::Object->new());
```


add space between ) and {


Provide a very simple example of `LMM#initialize` here to illustrate this paragraph.


implement thread safety here


Looks like we now link html_single, is there a reason for that? The html/index.html should be still available.


Add a filter for *.js files


Thanks for looking into it. Sounds like we should just stick with what we have for now then. Ah well.


- indicate -> explore


Haha, you think? Not sure what happened there. Fixed in c99f11951967012649ef836f7bb6cc439fad248c.


@christ66 A https://github.com/jenkinsci/envinject-plugin/pull/65 have been sent.


Something similar for tsuru: https://github.com/alphagov/tsuru-terraform/blob/more-makefile-functions/Makefile


better naming


move private members to top


lgtm


I could be mistaken, but I think when your code is part of a paragraph, you don't want the extra line breaks between the triple-backticks and the rest of the sentence. Have you tested it by doing a `rake generate`?


nah problems


yeah - that's why I just commented it out. I figured we could revisit if we run into a problem with it.

somewhat off topic - in testing I ran into so issues with the layer order when I ran the conversion then added records on top. The manual layers ended up below the conversion layer. Not sure if it was some weird fluke, but I'm thinking of running the conversion on the weekend to be extra safe.


Both these are datatables callbacks that allow it to call user code when it has finished doing something. In this case we use that to show the results div and hide the Pace loading widget.


should we throw this?


Looks like your indentation has gone awry here and in a few other places below.


sort usings


Bonjour
Désolé, je ne suis pas l'auteur du programme DSD je suis l'auteur du
programme de DMRDecode.

Cordialement

Ian

On 21 August 2015 at 10:49, gaspar1987 <notifications@github.com> wrote:

> bonjour je veux un fichier dsd README .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IanWraith/DMRDecode/commit/5e6934feea00149ab959c4741f2ea1004f40ed01#commitcomment-12825395>
> .
>


I don't see `PHP_VERSION` being exported in the parent script (?)


verify we don't need to implement this.


Change 22435 x 8 to `22435×8` => 22435×8


else?


First `cd ..`: I wanted to complete all blocks with ending in the same directory as it was started (`/tmp`)

Second, I wanted to move to the parent dir of `${PHP_DIR}`, better ways?


Shouln't `incomplete_count` be a string?


to easily administrator? typo


move declaration near instantiation


Unfortunately I can't redistribute the executable that I used for testing but I will see if I can cook up something tonight.


I like the SSH ones. As we don't have SSH aliases, maybe we can do something similar


This revision is clean.


* here -> in this IRuby notebook
* Turn the whole sentence into a link.


Check arguments.


If I can get everything to work, yeah.


Check arguments


* Often, the experimental design...


Look up which issue this fixes


* with 100 rows, of the form:


满怀敬意的说声感谢。


Check for null allele? (depending on what is the expected behavior of indexOfAllele as it might well already fail appropriately.


Proyecto para streaming


Done


Same as above.


Nitpicking: Significant figures here? Probably just write 9.99e-4 or 0.000999. Easier for most people to parse.


@aniarya82

2015 spons images are not there in this repo. Please add and send a PR.

***

cc @students-alumni-cell-iitkgp/web-team-members


Hi @nicck I've found that http://ujifgc.tumblr.com/post/12362076917/reverse-pagination but I wanted to see your solution.


dash should be `—` instead


@snoyberg This change does basically the same thing as [your GHC patch](https://phabricator.haskell.org/D1153), but I've it doesn't handle smart quotes especially nicely.  They get transliterated to `?` instead of just regular quotes.  It's better than garbage on terminals that don't support UTF-8, but not ideal.


@gkiar ah, sorry.  nonetheless, please put these blocks in and add some content.  thanks


Check index with Utils.validIndex


Корекция на README.md файл


lgtm % comments


clarify comments in this file


Check arguments.


There should be a space between Export and the parentheses, and the parentheses should only display if exportCount is not zero.


настрой табуляцию в редакторе
У тебя где-то пробелы - где-то символы табуляции
P.S.
Везде должны быть пробелы


Great work overall. One of the best blog posts I've seen from a GSOC student. =)


101682488_EvapCoolPrimaryAirSizing (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (751 of 751 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.47%25-green.svg)


`setAncestor` i `setChild` muszą zawsze być wykonywane razem, bo inaczej dane przestają mieć sens. Zostawiłbym tylko jedną z nich, np.:
```coffee
class Chamber
  setAncestor: (ancestor) ->
    @ancestor = ancestor
    if ancestor
      @origin = ancestor.aperture
      ancestor.child = @
```
Swoją drogą, zaraz zobaczę czy ma to sens żeby zakładać że do `setAncestor` może być przekazany `null`/`undefined`


Concerned about some of the spacing here. Have you done a `rake generate` to make sure it's all formatted correctly?


I'm almost sure you can't have a carriage return inside a link.


Can you please either use https://github.com/mozilla/treeherder/blob/master/treeherder/etl/mixins.py#L15 or a similar logic?


Make this a section header: "Usage"


Is this still necessary, seeing as we won't provide `application.yml` in the modules? - this should belong there anyway, I think.


This revision is clean.


instead of forcing the developer to choose between the two.


Same as the comments above about this..


`--show-error`


Shouldn't this be `#case/due_date <= today()`


@graemerocher What say ye?


This commit is being reviewed as a part of review issue #88.


Same .... I don't like getSample as samples are not properties but members of this collection.


已fork，以后再来慢慢学习一下，感谢


Ya está subido al server donde se aloja la app.


something


Good work. Maybe add a sentence or two at the end describing your thoughts on open source software and whether you plan to stay involved with SciRuby, work on a different project, etc. (We won't hold it against you if you don't stay with us. The overall goal of GSoC is to get students to stay involved with OSS in general, but not necessarily with specific projects.)


Same.


Maybe a way around this would be to use hGetEncoding to get the encoding for stderr, and then use the `text-icu` package to perform the transliteration.  But that means building stack would require the [ICU library](http://www.icu-project.org/) to be installed which I'd rather avoid.  Ultimately this should be fixed by your GHC patches so I don't know that it's worth putting a lot of effort into a work-around in stack.


TeamCity DNN JavaScript Libraries :: CI [Build 69](http://teamcity.engagesoftware.com/viewLog.html?buildId=337&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


I'm not surprised by that, especially since I just looked at that code in
GHC. My recommendation:

* Long term: fix GHC so that it supports GHC_CHARENC
* Short term: add a hack to convert the smart quotes as necessary

I'm on my phone right now and can't write up details. If that idea is too
vague please open up am issue and I'll elaborate next week

On Fri, Aug 21, 2015, 5:39 PM Emanuel Borsboom <notifications@github.com>
wrote:

> @snoyberg <https://github.com/snoyberg> This change does basically the
> same thing as your GHC patch <https://phabricator.haskell.org/D1153>, but
> I've it doesn't handle smart quotes especially nicely. They get
> transliterated to ? instead of just regular quotes. It's better than
> garbage on terminals that don't support UTF-8, but not ideal.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/commercialhaskell/stack/commit/af5b05675e5fa8b441dbcf319f2b2a67630f7d16#commitcomment-12830388>
> .
>


TeamCity DNN JavaScript Libraries :: CI [Build 69](http://teamcity.engagesoftware.com/viewLog.html?buildId=337&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:9


Don't you also need to change default proxy_pass to something like `[{'path' => '/api/pdb', 'url' => 'http://localhost:8080/pdb'}, {'path': '/api/metrics', 'url' => 'http://localhost:8080/metrics'}]`?


I would like to summarise my work as a participant in Google Summer of Code


@dmurphy22 Haha, I've made plenty of these kinds of commits over the past few months...


This url should be in a settings file treeherder/settings/base.conf.


* Capitalize Ruby
* no comma after and
* Strike second sentence


it looks we'll need some staging area in the server, right? maybe mmap them to disk?


test


I guess you mean to say that the result cannot be modified...


search.js was also "prettified" so it might be tricky to find exact changes. If only there was a way to not track simple line changes or indentation changes?


I think this is what the try! macro does.


@stof Which services class don't you want to be parameterized ? Gedmo listeners or StofDoctrineExtension listeners ?


Насчёт вычисления r один раз отличное решение, возьму на заметку в следующий раз


Версия - 9.4.4. Нет, не на винде.
Ошибка следующая:
  >[Illuminate\Database\QueryException]
  >SQLSTATE[2BP01]: Dependent objects still exist: 7 ОШИБКА:  удалить объект таблица leagues нельзя, так как от него зависят другие объекты
  >DETAIL:  ограничение teams_leagueid_foreign в отношении таблица teams зависит от объекта таблица leagues
  >HINT:  Для удаления зависимых объектов используйте DROP ... CASCADE. (SQL: drop table "leagues")


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19496/testReport/) for this commit**


Should this be e.g. `'-internal-model'`?


* Capitalize C
* I am still confused about the details, some of which are explored in greater detail in my personal blog. (linkify explored in greater detail in my personal blog)
* "It" is ambiguous in the last sentence.


This commit is being reviewed as a part of review issue #54.


Doh.


Actually, https://github.com/grails/grails-core/commit/2e3cbbff6c88811ec106145686289718a6f67e0a might make more sense.


исправить отступы


@GrahamCampbell I know :)  The point was to say thank you


Yes, but wouldn't it be better if that value was in a config file, not hard coded in the Java?


Hey Abinash. I've been looking over this and I'd like you to rewrite it with a different focus. Instead of going through what you did and didn't achieve, like a self-evaluation, could you please provide an overview of what the software you wrote does? It should be written for a person who isn't familiar with SymEngine, and has some familiarity with Ruby. If you'd like some ideas, please have a look at some of the other students' blog entries.

cc @certik


Looks like spaces were used instead of tabs.  This seems to throw off the alignment when looking at the markdown-rendered README on the repo's main page.


Ok, I like that idea.  Not sure what you mean by 'variable column'.  Is 'variable' what you are proposing we call it?


fix #200


If you ask me, this should belong to boot itself (now too late). And they'll say I'm a crazy old man.

We don't want to get bit by funky replacements again in s-c-s either (remember we did with the docker image)


Don't use magic numbers. Define a constant for this. It's hard to tell what this number actually represents here


check the `helper.pm` in ncm-lib-blockdevices tests
```perl
use NCM::Blockdevices;
$NCM::Blockdevices::this_app = $cmp;
```
makes it work


If there is no "_requiredBy" property, we should add the package anyways so as to maintain backwards compatibility with npm v2


mixed use of `/app` and `/srv/www`


* Capitalize Ruby
* Do you want to capitalize Daru? It seems like it's a proper noun, but I'll leave it up to you.


`Vector` and `DataFrame`


A cursory inspection of this looks like this is not optional al the JQL is being ignored.Am I missing something?


Same.


This paragraph is good use of both active and passive voices. Well done.


Hey, thanks for the hint, you are correct, that return is missing. Probably nobody realized this yet, since most are not touching the version.
Can you do me a favour and add some simple unit-tests for set/get and their return values to [MessageTest::testVersion()](https://github.com/Gummibeer/gelf-php/blob/6e8dadbe90eaa907edc7f8f14bbcb89af94d8fbb/tests/Gelf/Test/MessageTest.php#L46-L49)?

Thanks a lot!


Make argument final.


Корекция на README.md


"this" without an object is ambiguous. Can you rephrase? You have in two places in this paragraph.


this will cause profile.d to be sourced twice in many cases which could lead to problems if it has side effects


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8167/testReport/) for this commit**


`-n`


* Capitalize Ruby, Statsample
* involved a significant amount of work on both Statsample and daru — Statsample because many constructs...
 * Note: this is `—`, not a dash.


yes - you're right. I will change this.


Add unit test for GetDepth (npm v2, npm v3)


Add Oxford comma. =)


Ruby


I cannot fault this logic :+1:


it could be, that likely helps readability.

Will accept a PR.


Yeah that would be nice.
Actually I've learned a lot from FlowQuery how jQuery actually works, and even from TypoScript about JavaScript :)


Do we have an excellent example with both text and video?  Would give the header better context.


Why GATKException instead of IAE (using Utils.nonNull)? I rather stick to the latter unless there is a reason for this.


`DateTimeIndex`, `DateTime`


@samreid Yes, I think I understand the "rendered blackbox" and the Shadow DOM as two separate, but connected things.


>А за идентичность (memberId и id) будет отвечать не автоинкремент, а разработчик который будет писать логику добавления токена.

Это понятно, но иначе mysql не сможет создать foreign key. А не проще создать поле id auto_increment и memberId? Таблица от полей особо не распухнет, и работать на двух базах будет.


We might be able to shave off some of the perf penalty by checking if new bindings have been set and only nuking the engine if they have. This should allow us to keep JIT-ed code and avoid having to create a new engine when evaluating code that doesn't bind new globals.


* Ruby
* to the nearest day, or any day of the week, or the end or beginning of the month, etc.
* stand-alone


"an introductory"


Tim:

what did the effective dates look like?  Did the manual layer have an earlier effective date for some reason?

Rob

On Aug 21, 2015, at 9:34 AM, tim <notifications@github.com<mailto:notifications@github.com>> wrote:

yeah - that's why I just commented it out. I figured we could revisit if we run into a problem with it.

somewhat off topic - in testing I ran into so issues with the layer order when I ran the conversion then added records on top. The manual layers ended up below the conversion layer. Not sure if it was some weird fluke, but I'm thinking of running the conversion on the weekend to be extra safe.

—
Reply to this email directly or view it on GitHub<https://github.com/txace/icd10-sql/commit/5f130044832abffec4a51e684e0fb05b0c2ffb66#commitcomment-12830257>.

This email, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information from StarCare Specialty Health System. Any unauthorized review, use, disclosure, or distribution is strictly prohibited. If you are not the intended recipient, please notify the sender immediately by reply email and destroy all copies of the transmission. Although this e-mail and any attachments are believed to be free of any virus or other defects that might affect any computer system into which it is received and/or opened, it is the responsibility of the recipient to ensure that it is virus free and no responsibility is accepted by StarCare Specialty Health System for any loss or damage arising in any way from its use.


It's probably more readable if you create the search arguments first and then use only one filter (or a list comprehension) to select the buildernames.


* Active voice here, definitely
* Useful is misspelled
* Clean up this paragraph a bit; it looks rushed.


Exe profile created. Tested win 7 x64. Shaders must not be set to ultra to enable dx9 rendering


Well it is.
However I will change the code to only load if opts->data_dir is not NULL


I'm thinking about just special casing the only two characters that matter:
the open and close smart quote.

On Fri, Aug 21, 2015, 5:44 PM Emanuel Borsboom <notifications@github.com>
wrote:

> Maybe a way around this would be to use hGetEncoding to get the encoding
> for stderr, and then use the text-icu package to perform the
> transliteration. But that means building stack would require the ICU
> library <http://www.icu-project.org/> to be installed which I'd rather
> avoid. Ultimately this should be fixed by your GHC patches so I don't know
> that it's worth putting a lot of effort into a work-around in stack.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/commercialhaskell/stack/commit/af5b05675e5fa8b441dbcf319f2b2a67630f7d16#commitcomment-12830507>
> .
>


Perhaps talk a bit about your plans for the future. Strike your current conclusion sentence. Confidence. =)


Overall, great work.


Version bump got committed :imp:

Also, commit message is wrong.

I'd suggest rebasing to amend this one to be just about the dependency updates


...or semver failed for some other reason. the case that nothing is specified could also be handled before making the request at all


@rudolphpienaar it seems the ENV_CHRIS_TMP_DIR is missing here


I don't understand this instruction.  Do you mean an example solution at the end, an example solution to the milestone, a repo I can clone and start from, inline code, or something else?


Note that this also fixed the forwarded ports.


Instead of adding `[self expandPopupView];` to every call. I would create a local block variable and set that variable as the completion block for all methods. It'd make things a bit neater.

`void (^completion)(void) = ^void(void) { [self expandPopupView]; };`


Sorry, I think I sent the wrong link somewhere and you are reviewing the pre-second commit version of this PR. In the second commit I added ETL support using a mixin: https://github.com/mozilla/treeherder/pull/892/files#diff-bb295a75074f6e2c9d641f7bb48bd09fR9.


Instead of linking to the example project in text, can we wrap the image in a hyperlink and just make that clickable?


why?


保重，FUCK GFW


To się przydaje chyba tylko przy budowie pierwszej komory, ponieważ potrzebna jest informacja o wszystkich poprzednich komorach żeby poprawnie znaleźć aperture kolejnych komór.

Uważam też jednak, że to jest lepsze miejsce na algorytm znajdowania ujścia - w Chamber, nie w Foram. Zauważ, że Chamber również ma dostęp do informacji o poprzednich komorach - przez `.ancestor.ancestor.ancestor ...`. Myślę że dałoby się stamtąd wywalić logikę znajdowania ujścia i wszystko robić tutaj. Co myślisz?


Whoa, cool. I didn't know you could do that.


This tutorial is aimed at absolute beginners -- people who've never don't know any programming, and who've never used a command-line.  I'm guessing hardly any of them will be using BSD?  (but maybe there's something I don't know).

The kind of person that I imagine uses BSD, I also imagine already knows how to install python -- that doesn't mean they can't get something out of the tutorial, just that I'm guessing they're probably going to skip the beginning sections about installation, what is a command-line, how the internet works, etc.

Maybe I'm wrong?


If you know the size in advance why use liked-list? (even without knowing the size array-list often perform better unless they are grossly oversized).


It called so at ERP diagram :-)
I've tried to name this column to get clear that value of this property could be changed in SKU.
But maybe it sounds strange for native speaker )))
Maybe we should name it as overridable_in_sku ?


saw approval from JeetKunDoug
at https://github.com/basho/riak_kv/commit/5fc26998370e136c3031b234af6b91392693b6c6


merging basho/riak_kv/bugfix/fwd-merge-lww-dvv-validation = 5fc26998 into borshop-integration-1174-bugfix/fwd-merge-lww-dvv-validation


basho/riak_kv/bugfix/fwd-merge-lww-dvv-validation = 5fc26998 merged ok, testing candidate = 99827295


> $(echo $name | cut -d '-' -f 2-)

repeated three times here


Please add this file to gitignore and remove from repo


Use @method


I would trigger this task directly from the view, since that's all this function is doing and it doesn't have much to do with the database.


Thank you!


@hildevestol It is because `expose_token_expiry_time` calls `current_token`, which we don't have in some cases. For instance the first time a user visits the app.

That is why we use `require_valid_token`(in timeregistrering) like this:
```ruby
require_valid_token except: [:init, :deploy_date]
```

As you can see, `*args` will be passed along to `before_action :require_valid_token`, meaning that `except: [:init, :deploy_date]` will apply to this before_action.

We also want it to apply to the after_action, so we don't get errors for not having a token, which is why i am passing `*args` along to the after_action as well.


Please use windows 1251 enecoding for project and LF as a line separator


fixing indentation.


I'm not concerned about proving anything, let alone formally. It's actually more about finding bugs by testing. Also, in this particular case, I like to think of the memory module as an abstraction independent from the language/evaluator/checker (it only knows about values, nothing else).


return idea too.


effective dates were the same.

I was testing lib_DX10:getUnbatchedCltDx() which is supposed to return the _earliest unbatched_ (read: bottom unbatched layer).

I ran the conversion which adds the records with effdate = $today. I removed the care date from the record I was testing. Then I added a new record with DX10.

I was expecting the Conversion Record, but kept getting the Manual record. When I reviewed the register it was because the conversion record was layered on top of the manual record.

That was on Monday or Tuesday. I haven't tried to recreate since then.


Yeah! will do.


Please use UTF-8 enecoding
And translate it to English


@moy awesome, thanks for the review.


return new as idea object.


![image](https://cloud.githubusercontent.com/assets/13874876/9411523/97ca71ba-47e3-11e5-8d5c-b993767c66cc.png)

Also if we go further till line number 10 it automatically adjust the content properly.


better comment


Also you may want to use streams here.


@rudolphpienaar


Add Options routing for vote requests.


As per the comment above, this task is probably triggering too many actions with different parameters. We will take care of it in [bug 1197197](https://bugzilla.mozilla.org/show_bug.cgi?id=1197197)


Please don't commit commented lines


Same as above, why GATKException rather than IAE (if no good reason the switch to IAE and use Utils.nonNull.


Utils.nonNull(filter).


Please remove commented code


> just about the dependency updates

ah, fair enough. wasn't sure what you meant at first. I have some deadline driven stuff today. I'll try to do it asap, but if you want to before me that would be awesome too


This is failed for Aws v1 because of
https://github.com/thoughtbot/paperclip/blob/b8221c6b9f9e4c616973b859a8ad0b05f7511372/features/step_definitions/s3_steps.rb#L4


`cd ${PHP_DIR}/..`


Regarding to uniqueness, it's hard validation in any case, b/c when you have many options you should check uniqueness in combinatory way.. I'm not sure that it's really needed, but it also possible w/o introducing separate entity. For example, we could add boolean `unique` column to Property and then check that ProductProperty has unique value among all SKUs of the product.


Please remove all console.log, which you use in current development process


Hi John, Thanks for taking the time to read it and suggesting corrections. I have started writing on what the gem is and what it does, considering it will be read by a person not familiar with SymEngine. I am editing the post and and will commit it as soon as I can.

Thanks again for the review.


I noticed you changed the test a bit here. Instead of counting the total number of bytes you are doing value comparisons to make sure that it's within the bounds of the type. While equivalent for the purposes of this test, I wonder why the change in methods.


We can probably remove these entries. (also the commented ones)


not this time, because I'm such a nice reviewer


Can you move this import to the top of the page?


Заюзал прям так, потому что вроде ничего криминального, да и не ясно как сделать через callback так, чтоб значение не менялось после проверки. self.original_text = clean(original_text) перед выполнением - меняет введенное пользователем. Идея в том, что карточка может состоять и из нескольких слов, я отлавливаю слова без пробелов, соответственно нет смысла писать в базу "розовыйслон" вместо "Розовый слон", я просто говорю пользователю, что не верно - исправь. можно конечно искать пробелы больше 1 и заменять их на 1 пробел и делать trim пробелов по краям, а также увеличивать первую букву, тогда в теории слова будут нормализованы в карточке и возможности ввести в карту "Розовый     слон в     бахилах" уже не будет. Надо оно?


Use Objects.equals() like so:

```
if (Objects.equals(targetReadGroupId, p.getReadGroup()))  {
        return true;
}
```


is there a case where we want to do set but not unset first? Why not clean the ref on the set, if it's not null?


GitAttributes (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Any reason for this?


Thanks @alexbikfalvi !


Explain in the javadoc the behavior if targetReadGroupId is null. Paraphrase with ```<p>...</p>```


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2300


I found it to be more intuitive to do a direct bounds check, instead of bothering to figure out the number of bytes required to represent a given value. No conversions needed and it's much more readable.


I bet that calling code would look better if instead of returned a null we return the empty ReadPileup. They can always do the isEmpty test if the behavior is completely different for a empty pileup.


Good point, yes, I was also wondering why the comma should be any special. I've removed it.


Tidy!


This is indeed broken (and confusing). I'll have to think a bit howto make it obvious and idiomatic. I'm not sure question form helps, since we have four different outcomes:

1 - read resolv.conf
2 - read proc/net/pnp
3 - don't read anything (and it's ok)
4 - don't read anything (there was an error)

I guess returning an enum with positive values for OK and -error for error cases is ok? then we can switch/case in manager_read_resolv_conf() and code should be more clear.


This assert is unnecessary, we haven't even run any of our code yet


Высосано из пальца, просто хотел попробовать callback


I'll read the CODING_STYLE doc and fix the style accordingly. I'll remove the stat also.


Check header is not null with Utils.nonNull.


Same as above. If you leave it as it is, the java doc must comment of the possible null return and what it means.


@gkiar now that i pushed, make sure it propagates to the web?


< cfbolz> ok, go ahead


This is far too specific -- 500 is general "oops, service screwed up" -- and in general, could be a retryable error. It should return 409 (conflict) in this case, so we should handle it by message, put in an issue to have the service handle this more gracefully, and then handle it properly when that time comes.


And here too.


k


oh!  ok, i see now...sorry :-)

I'm not too worried about enforcing uniqueness on the skus at the point where we are now.  I feel like our data model is starting to come together nicely and we'll be able to solve that problem a bit farther down the road?


In the case where header has multiple values  (i.e. X-Forwarded-Proto or X-Forwarded-For)

i.e.
X-Forwarded-Proto: https, http
X-Forwarded-For: 10.0.0.1, 10.0.0.2

We would want the access log elements to be double quoted so parsing of log elements is predictable.

For example: instead of looking like

```
. . .   x_forwarded_proto:https, http x_forwarded_for:10.0.0.1, 10.0.0.2
```

it should look like

```
. . .   x_forwarded_proto:"https, http" x_forwarded_for:"10.0.0.1, 10.0.0.2"
```

Cheers


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 381](https://teamcity.labkey.org/viewLog.html?buildId=267724&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:40
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


I don't have access to the docker/app server. We need someone on the web
server to simply git pull and it'll update. @j6k4m8, @alexbaden?

--
Greg Kiar <gkiar07@gmail.com>

On Fri, Aug 21, 2015 at 11:18 AM, joshua vogelstein <
notifications@github.com> wrote:

> @gkiar <https://github.com/gkiar> now that i pushed, make sure it
> propagates to the web?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gkiar/ocp.me/commit/e4286ce78d90f31a2225f36a80150199a9a79fac#commitcomment-12831290>
> .
>


I would try to narrow the type of exception we are expecting here. Or let it go with a 500.  You should also check that we have a resultset with id == pk and if that's not the case raise a rest_framework.exceptions.NotFound or something similar.


Yes, this is a copy of the boot.sh with unsetting the PHP_INI_SCAN_DIR


Great. Thank you.


Thank you @kdavis-mozilla . I discussed with the group last night and is better that we provide data to test accuracy with some performance tools, and then add the weights instead do randomly on items that we just think is bad. I am preparing an app to capture these database from testers.


oh right.
@alexbaden - can you give @gkiar an account on brainapps?


That's what I thought too but when i replace
```
let rm_str = rm.to_str();
let rendered_markdown = match rm_str {
...
```
with
```
let rm_str = try!(rm.to_str());
let rendered_markdown = String::from(rm_str);
```
it gives me a weird compiler error and I wrote this in like 20 minutes so I
didn't look into the real cause of that.

On Fri, Aug 21, 2015 at 9:46 AM, Arnav Sastry <notifications@github.com>
wrote:

> I think this is what the try! macro does.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ryanr1230/bolts/commit/9cf0d54da6ecade639336f73734e9f96c112c7ae#commitcomment-12830551>
> .
>


Already removed


what even is UFPLS!?


I agree.


this cause the update to execute infinitely.


101682488_EvapCoolPrimaryAirSizing (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1275 of 1276 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.91%25-green.svg)


Why does Github only sometimes show me what was actually changed in dark green? =(


Don't use the diamond operator, yet. We need to backport this to version 0.9.1, which is still Java 6.


Root is currently disabled on our images.  I'll revisit keeping it around
for at least long enough to run this.

On Thu, Aug 20, 2015 at 8:49 PM, Blake Blackshear <notifications@github.com>
wrote:

> since this a default variable, I think root still makes sense here
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nextgxdx/cis-rhel-ansible/commit/b1b588071e71c809801371590fbbb2a050a9c1c5#commitcomment-12820717>
> .
>


This paragraph has already been changed dramatically on master.


Thanks @rderoldan1 I will change it soon


Ok, but for testing, won't Array1.{i} report out-of-bounds in exactly the same set of cases?


I actually removed that other section, but I like this wording better.  Fixed in latest commit.


This whole chunk was removed on master


Seems like the right fix, it's working okay. Any reaction from the creator of the lib?


That's what I thought too but when i replace

```rust
let rm_str = rm.to_str();
let rendered_markdown = match rm_str {
...
```

with

```rust
let rm_str = try!(rm.to_str());
let rendered_markdown = String::from(rm_str);
```

it gives me a weird compiler error and I wrote this in like 20 minutes so I
didn't look into the real cause of that.


Thanks for your support and review.


I love it.  Fixed


already fixed on master


This method is only used in testing.... please move to a private method there unless there is a good reason to keep it in production.

I would add somewhere a method that extract the laneID from a read using the cited convention and then use that method here; so that that convention is "set in stone" somewhere.


Sorry about bring quotes up again :-)

Why don't we have to worry about single quotes here?


I just realized how much I depend on tests :'(


love it, fixed


of course. :(


Хотел написать, но нашел подходящий метод в рельсах :)


LOL at my original wording. fixed


already fixed in master


This whole para got dramatically re-worded in master already


missing `format_path` here
```
response = @session.do_post "/save_url/auto#{format_path(path, true)}", params
```


yup, fixed


So no read-group means no lane? Please explain this in javadoc.

I would double check whether this is actually even needed, perhaps this method should simply ignore read that lack meta-data.


Derp, yup. fixed


As before, what about just return an empty pileup? I think the calling code probably will look better.


@mshabunin could you check http://pullrequest.opencv.org/buildbot/export/pr/5121/docs/d7/dfc/group__highgui.html#ga5afdf8410934fd099df85c75b2e0888b
i confused if i must delete that lines


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8168/testReport/) for this commit**


Yes, important clarification. Fixed


derp, redundancy. fixed


@rhatdan @mrunalp Terminate still not working but will get it soon :)


Should this have some more documentation about what it's for and how it should be used?


Seems odd to fix the `source` to that commit (bcb34b2d8a456aabbe844fb9a9a9402d6ae5d7d2)


why did appveyor build fail?  looks like all the files are included


Fixed with https://github.com/sindresorhus/repeating-cli


Yes, I meant to put scare quotes.  Already added the ending double-quote in master


What about the service config? Is that being ignored deliberately?


I added "simulated" thus making the "a" correct on master


How come the signature for `notAcceptable` is `MonadSnap m => m a`, while the signature for `unsupportedMediaType` is `Snap a`?

This is less a stylistic quibble and more a question about functionality. Did you make `notAcceptable` more generic just out of reflex? Or, because it's better practice to do that (and `unsupportedMediaType` is just behind the times)?


Check index with Utils.validIndex.


haha. fixed.


thanks


why not ```pileupElements.isEmpty();```?


already fixed on master


Can we really assume that object.material is always valid?

Also, it would be really nice if material.program would get assigned right after the program is created instead of during the next render.


I don't understand what you mean? Any configuration is still mixed into the service so is still available.


That's what this is now.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19501/testReport/) for this commit**


fixed


yep, there is no limitation on that.


Thanks!


yes, fixed


アイテムログのカテゴリボタン表示 #723


No need for this if as is base is "-" then simpleBaseToBaseIndex will return -1.


Why do you want to make endpoint_base an optional parameter?


What is `@idx` for?


Nice idea but awful textures. Need to be changed


This does not at all require `celluloid/lock_detection` ... it just sets `$CELLULOID_MANAGED` and includes files that were not previously added.. like `actor/manager` especially... This version of the file will not work, because it needs to set the global variable, include the missing code, then include `celluloid/current` itself


Do you have to modify this file to be able to use cocoapods with your forked repo?


You probably don't need this, it is being handled globally via an interceptor in uicommons module


What changed here to fix share-site thumbnail generation - can you explain it to me?  (And maybe add a short comment to the code.)


Well that's a bit for you guys to decide, it's your project, your design :)
But if people aren't using it then why does that type exist?


Do not require `Celluloid` ... just set the global variables required, and include the code involved.


Why ``Character``` rather than ```char```?
Also this method is used for testing only, I would move it out.


I think save, retired, unretire purge methods should be here, we didn't do this encounterTypes ut we should have


GitAttributes (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.8%25-red.svg)


minor: maybe ceph_objectstore_bench will be better


ok


Change to the following
``` javascript
      if (typeof data.count === 'function') {
        count = data.count();
      } else if (typeof data.size !== 'undefined') {
        count = data.size;
      } else {
        count = data.length;
      }
```
To handle the length of a `Map()`


its a brand new object so it won't have post yet.


Yeah. I was just trying to figure out how using a custom `pod spec` works. I probably will end up creating a new Tag, I guess.


Just out of interest, why 'ua'?


`Celluloid` will be required/started when the programmer using this wants to. Down the line that might change, but I think it'd be best to let `Celluloid` be started elsewhere. Definiltely not in `celluloid-lock-detection` ... possibly in `celluloid-manager` ... but for now, in neither.


This one can go.  No mx.


first commit


For me the important question is: "do you think the design of that `longFormatTime()` is correct or do you think it should be changed to use `ZoneDateTime`?" (according to what you guys think is "correct usage" of the Time API)


use common/strtol.cc::strict_sistrtoll to unify?


What is the qual of a deletion? please explain in javadoc.


I think you should add a requiredPrivilege here i think it is Manage Patient Identifier Types


No,  `homepage` is more of a marketing/documentation thing, I believe.


Oops, I accidentally deleted a line where it increments that counter.

Basically you can add multple `after_save` callbacks, and I need to make sure my generated method name is different for each one.


When using the babel `Map` polyfill, the `.toString()` returns 'Map'.

Change to
```
  if ((type === 'Object' || type === 'Map') && typeof obj[Symbol.iterator] === 'function') {
```


Actually not here but to the links extension


remove these sapces


Why did you move this up when it is not used by the above code? Keep it where it is used


Yes. Instead of the explicit check, you could also wrap the loop in a try and then translate the exception into Bounds, if you prefer. I just want to make sure that only dedicated Memory exceptions escape this module (for hygiene, and so that upper layers can report them properly).


Move this to a sass file


That is expected, this is a temporary fix so that the mod as a whole can continue working while we are finishing up world gen.

Though, did it just spawn two diamond blocks in the middle of space?


what how


Seems that lots of the code around here is for testing only.... What about creating a test utility and move all that code to there?


I think these methods should be in the service in the uicommons module and just call the service methods from here


I'm thinking of the use case where you add in a duplicate service with the same scope, but with different configuration. The code will currently log a message, but carry on anyway. Is that what we want to happen? When I considered the registry, I thought logging a more specific error might be better, as the app won't behave how it should if a configured service is rejected.


That's correct. I was the first person at our company to discover the `MonadSnap` typeclass, and I discovered it a while after all these other functions were written. They all need to be updated, but I haven't had the time yet. (Maybe today?)

The more precise reason about why I used `MonadSnap` here was because I'm actually using `notAcceptable` in what is essentially a `ReaderT Something Snap` monad, so using `MonadSnap` means that I don't have to explicitly `lift` the action into the `ReaderT`.


Why not a ArrayList?


these are indented a little  far to the right


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19504/testReport/) for this commit**


Should we extract the comparator into a (perhaps public) constant?


Is there a reason for this or can it be `client_trusted_domains`?


nit, please put `matchMobileMessageShim` on next line


same


Is it too early to say about a forecast of a chance of v1.10.8 possible?


This is an SSE4... move to within the check for `if (Common::GetCPUCaps().sse4_1) {`, and then implement an SSE2 fallback for the other codepath


> because I'm such a nice reviewer

+1


nit: space after "if"


the code was entirely indented


Dropping this commit would make #208 simpler to merge


@anthonylewis just an FYI. You want to make code changes in the `src/` dir and then build this file using `grunt`


Revert this lonely change.


Yes, just two diamond blocks.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 382](https://teamcity.labkey.org/viewLog.html?buildId=267728&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:27
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


I will have to remove that because it breaks cascades. Why do you need this?


it was not a typo. if you want 'fix' it then put capital c in line 273 too.


Minor git screwup (mine) had caused bogus branch divergence.  Fixed now.


is it normal? I still get the following snapshot:
 https://oss.sonatype.org/content/repositories/snapshots/com/underwaterapps/overlap2druntime/overlap2d-runtime-libgdx/0.1.1-SNAPSHOT/overlap2d-runtime-libgdx-0.1.1-20150818.090541-22.jar


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 383](https://teamcity.labkey.org/viewLog.html?buildId=267726&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 6, passed: 0 Build time: 00:10:40
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.ScrumtimeTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


:fire:ed


I thought about a setup part at the beginning that checks the opcodes but you're right it should stay close to the loop


nit: just wondering if you could rewrite this using promises so that `shimHostIframe.contentWindow.bootstrap(App.instanceId)` is specified only once


I'd like to use a consistent design pattern for all API calls. Either function based resembling this syle, or class based viewsets. So this might change in the future.


If you amde better textures, we will add it with pleasure


taille de la fenetre ?


your file should look more like this
```
class SummariesController < ApplicationController

  def new
    @summary = Summary.new
    @post = Post.find(params[:post_id])
  end

  def show
    @summary = Summary.find(params[:id])
    @post = Post.find(params[:post_id])
  end

  def edit
    @summary = Summary.find(params[:id])
    @post = Post.find(params[:post_id])
  end

  def create
    @summary = Summary.new(params.require(:summary).permit(:name, :description))
    @post = Post.find(params[:post_id])
    if @summary.save
      redirect_to @summary, notice: "Summary was saved successfully."
    else
      flash[:error] = "Error creating summary. Please try again."
      render :new
    end
  end

  def update
    @summary = Summary.find(params[:id])
    @post = Post.find(params[:post_id])
    if @summary.update_attributes(params.require(:summary).permit(:name, :description))
      redirect_to [@post,@summary]
    else
      flash[:error] = "There was an error saving the summary."
      render :edit
    end
  end
end
```


Well, firstly... do we actually have any services that do that? and in a way in which it would even make sense for duplicate subscriptions at the same pubSubScope to be doing things differently?

Secondly, it isn't compulsory to extend BaseService. If we were to have a service that behaved like that then it can implement it's own registry checking - or, at the point at which we do need that level of complexity in the registry we can go back and add it.

At the moment I'm not sure the use case demands that we need this capability. I could be mistaken and there might be an example service that you would want duplicated at the same scope. If not, then we can iterate on the BaseService and serviceRegistry as and when its required.


Typo in commit comment.


u dont have a post this is a new object


same here u dont have a post yet


this is wrong


even though I can see a new build from today in the index.. gradle issue?


This "if" should probably be removed - add_btn can not be None.


In this commit I also made changes to the comment parsing. The regex will now remove links so that the results are prettier. The link format it removes is "[Link Description](http:whatever)". It will leave us with just the Link Description


Ahh, I see, the goal is to get the `Bounds` exception.  Makes sense; I'll just keep the check.


You should be able to `npm install TTLabs/EvaporateJS` (Ref: https://github.com/TTLabs/EvaporateJS/issues/22).


Regression - good catch. Comment can be removed - otherwise suggests something that doesn't work.


Removed `require 'celluloid/lock_detection'` & `require 'celluloid'`
And added `$CELLULOID_MANAGED ||= true`
And also added missing `report_event.rb` file with `require 'celluloid/actor/report_event'`

Anything missing now??


Segment.io generated events has random version.
Version checking could be turned on after release, when real existing api versions will be specified.


added `println` to make result more readable


Can't understand what you said. What do you mean??


最好加个前缀


That is very interesting.


sure: https://github.com/ionrock/cachecontrol/issues/96


@notspiff, I've been porting your VFS add-ons work into Kodi main but I can't get paste this:

> 21:40:01 T:140198265174080   DEBUG: CGUIMediaWindow::GetDirectory (nfs://192.168.133.77/media/hdd/testfiles/)
21:40:01 T:140198265174080   DEBUG:   ParentPath = [sources://video/]
21:40:01 T:140198265174080   DEBUG: ADDON: Dll Initializing - NFS support
21:40:01 T:140198265174080   DEBUG: SECTION:LoadDLL(/home/hudo/dev/tmp/vfstestnfs/share/kodi/addons/vfs.nfs/vfs.nfs.so)
21:40:01 T:140198265174080   DEBUG: Loading: /home/hudo/dev/tmp/vfstestnfs/share/kodi/addons/vfs.nfs/vfs.nfs.so
21:40:01 T:140197169809152  NOTICE: Thread JobWorker start, auto delete: true
21:40:01 T:140197169809152   DEBUG: AddOnLog: NFS support: NFS: Context for 192.168.133.77/media/hdd not open - get a new context.
21:40:01 T:140197169809152   DEBUG: AddOnLog: NFS support: NFS: Connected to server 192.168.133.77 and export /media/hdd
21:40:01 T:140197169809152   DEBUG: AddOnLog: NFS support: NFS: chunks: r/w 131072/131072
21:40:02 T:140198265174080   ERROR: Unable to lookup host: 'nfs'

As far as I can see, the only new call to CDNSNameCache::Lookup is is from CAddonCallbacksAddon::DNSLookup added in https://github.com/hudokkow/xbmc/commit/4c03c27e58b7bb8295fe93131da4e83e95270e1b

VSF add-on used to test -> https://github.com/hudokkow/vfs.nfs
Any insight?


We are not. I was thinking that at least in the case in which the failure was in updating the retry_info dictionary, the crab_retry is still known and we can report to dashboard. For the cases of failure retrieving the retry_info dictionary  we could use the dag_retry to report to dashboard (and still exit with fatal error). And finally, we can think of making crab_retry obsolete and always use dag_retry (the crab_retry is there to account for post-jobs restarts).


this is a test file


最好在constructor绑定好


Removed `require 'celluloid'`

Added
```ruby```
$CELLULOID_LOCKDETECTOR ||= true
$CELLULOID_LOCKDETECTOR_CHECKING ||= 1
$CELLULOID_LOCKDETECTOR_INTERVAL ||= 4
```
`LockDetector` code is in `actor/lock_detection`.


reack


Proven tools! Merged it into my repo ;)


maybe that's just me, but I like using "exports" for things I export, and "window" for things I "import". But maybe it's best to use exports so that it can work in any environment (worker/window). So I don't mind.


@borshop merge


GitAttributes (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


这种应该不需要了


The `TODO:` line is talking about extracting from the `Celluloid` gem in the future into its own gem. That's what this is now.


getFileHash uses a chunked algorithm whereeas readFile and then fingerprintString must read the entire contents into memory and then hash it. So for memory usage `getFileHash` will be better.


This made no difference when I tried it.


Fixed the userdev issue. Thanks!


Can this be null?


In this case, it is `$CELLULOID_MANAGED = true` rather than `||=` because this is explicitly saying "use managed celluloid"


We should not be doing this as it breaks sarsa and makes the class incompatible with other agents


HI Feng
Sorry for delay
i run kernel 4.2-rc7 with new patch but after boot machine crash with this :

[   89.690838] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   89.810991] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   89.901988] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   90.112040] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   90.532280] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   91.372536] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   93.053199] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   96.424508] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   98.655374] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   98.780803] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   98.795290] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   98.902422] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   99.069407] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   99.291459] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[   99.708485] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL
[  100.540348] skbuff: IMQ: kfree_skb: skb->nf_queue_entry != NULL

And stop link to machine.

m.


Agreed, this rule seems a bit useless...

Only use I would see for it is if we had a flag to disable building the go binaries in the tests, and we had the individual test rule depend on the 'build' rule. That way we'd do a toplevel 'build' and then run the test that wouldn't build anything, probably saving execution time.

(come to think of it, we probably want that flag anyway for travis builds, sounds useless to re-build all binaries when running each integration test, but that's a different change from this?)


Only format comment: try this (with same blank lines!), it's more beautiful :)

Examples:

* http://api.navitia.io/v1/coverage/fr-idf/vehicle_journeys?headsign=RTP1330709:379072_dst_1
* http://api.navitia.io/v1/coverage/fr-idf/stop_areas?headsign=RTP1330709:379072_dst_1


Seems logic that lime-proto-bmx6 depends from bmx6, isn't?
Wouldn't be more logic to create lime-proto-bmx7? I can't understand...


Please do not comment on commits to request support.  Use either the Kali forums or IRC for support.


@t-oster do you have smoothie working reliably over USB?


I started with your first video. I made it to the bower install part and typed this: bower install

but I get this error:
bash: bower: command not found

![bower install](https://cloud.githubusercontent.com/assets/13573291/9412778/d78e018c-47fb-11e5-949f-71c19ba07e91.jpg)


I was struggling to debug the deletion issue
Without this all that is shown in Console is S3Log Error: None

It's not critical, but this did add something


I think we could use "classList`*`.js", "perfBar`*`.css", "perfbar`*`.js".
Maybe the author will add minified files in the future.
What do you think about it? 😀?


See https://travis-ci.org/flavour/eden


Then there would be `data.data`; I kindof liked "segment" since it's more than just raw data.  It's also weird, now that I look again, to have `modul'.data` and `segment.data`.  How about I rename `module'.data` to `module'.init` and also move `memory` into `init` (since it's logically part of the same "initialize memory" section)?


Yes forgot to remove that after testing...doing so many diff things hard to keep track of all


This was the probability of selecting an event. But I realized it's a bit confusing so I changed this to drop prob instead, so now probability would be modified by * (1 - P(drop))


@anandsuresh I think this needs to be published to npm still.


And the example are awful :-1:
* on RER A http://api.navitia.io/v1/coverage/fr-idf/physical_modes/physical_mode:RapidTransit/lines/
* 1st VJ name http://api.navitia.io/v1/coverage/fr-idf/physical_modes/physical_mode:RapidTransit/lines/line:TRN:DUA810801041/vehicle_journeys
* so filter becomes http://api.navitia.io/v1/coverage/fr-idf/vehicle_journeys?headsign=CANE

It's so exciting to comment your PR, I love that!


changed to DropEventRandomlyIfNeeded, not sure what is a better name yet


You can use [`String.dump`](http://erratique.ch/software/astring/doc/Astring.String.html#VALdump) for that, it will also escape bytes using hexadecimal which is preferable in many occasions.


hmm, it's just modifying the prob affected by a coin flip so yes there're probably many references


I'm not clear on the original purpose.
This overrides whatever was in output["buttons"] which seems wrong?
Perhaps it should be:
if output["buttons"]:
    output["buttons"].update(add_btn = )
else:
    output["buttons"]= dict(add_btn = )


as configs ficam em ```req.we.config```


你是不是傻逼，老子做个备份，你管得着吗。

Best regards,
Chunxiang Yan

On Fri, Aug 21, 2015 at 5:12 PM, 朱江 <notifications@github.com> wrote:

> 真的吗？fix some bug这种commit message有什么意义？
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Chaunceyan/StarWars/commit/ddf27a19cda05c99220646a550a6a284d715a20f#commitcomment-12824850>
> .
>


And yes, we'll have a dynamic adjustment scheme for Q, but it's still in discussion


用 file.index 是错的，不能唯一标志该文件，列表增加删除后出错


Hmm, node.js/v8 do not canonicalize NaN's, some something else might be failing here? Perhaps a bug in the polyfill? @sunfishcode


It might waste your time moving these though because then you have to return promises which can end complicating things a little, you can leave them here i guess for now


Used your suggestion for now. I tried Contracts but it doesn't throw any runtime nor compile errors?


不要再 before 上 rotate ，在上面吧


Sorry, I don't think I'm familiar with this concept:
"using `MonadSnap` means that I don't have to explicitly `lift` the action into the `ReaderT`"

Specifically: Why does using the typeclass here remove the need for an explicit `lift`?


Nie dziękuję, nie stać mnie.


I fixed the commit. It is now d230f41 (note you'll have to force update your local copy of the branch).

All set for merge & publish now


感谢！！


I think our code convention is to have the braces here :)


Why is this returning null ?  Is this method never used ?  can you add comments to clarify...


:yellow_heart: An undefined value in Javascript is falsy. This means there is no need to compare it to `undefined`. You can rewrite the condition as:

```javascript
if (!user.username || !user.email || !user.password) {
  // code statements
}
```


COOL! If we can add a cache algorithm, I think we can replace with ObjectCacher TOO!


I wasn't suggesting that the service should be successfully registered with an alternative config, but just that it might be useful to provide a better error message. A log level message is effectively a note for information only (it's safe to ignore), whereas the attempt to register a duplicate service with a different config is an error that needs fixing before the app performs as expected (it's not safe to ignore it).


Oops! Nice good catch on directory traversal vulnerability on line 94 :+1:


remove commented out code


There is a css class in adminui.css file you can use i would also move the css to the sass file


They are there to improve performance on the world gen as i understand it. At the moment, we simply do not have working world gen, so making things efficient at the cost of functionality is not helpful. Once it actually works, i will go back and find a better way to do this. There are many ways we could make it have less of an impact, since we dont need high accuracy and it is an integer. We could also move the sqrt into a different thread, which minecraft makes poor use of anyway.
At absolute worst, we could pre-compute the values, and this would still use an inconsequential amount of memory.

What do you mean by block tolerance?


Done that. But https://hackage.haskell.org/package/base-4.8.1.0/docs/src/GHC.Fingerprint.html#getFileHash states that it is since base 4.7, which is 7.10 IIRC, so we also have to use fallback. So should I use `getFileHash` or `readFile` for that?
Also, as said by you, I have squashed the two commits into one in PR.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8169/testReport/) for this commit**


There is a css class in adminui.css file you can use


grammar: "deflate, however, files" -> "deflate, but files"

"more portable" is probably the wrong phrase.  Blosc-compressed files are portable in the sense that you can move them from one machine to another.   I would say something like: `files with deflate compression are readable by other HDF5-using programs without installing a [Blosc plugin](https://github.com/Blosc/hdf5) on your system.`


yep, I had to configure gradle for that.. (resolutionStrategy -> cacheChangingModulesFor)


You can do:

```py
  for index,record in enumerate(table.FeatureList.FeatureRecord):
```


make page size configurable?


@stankevich need to release `1.9.7`


Only the action part right? Planning to standardize the Action class to send 0 to 10 which can be used as actions directly.
Also, finally we will need to convert action space to analog, mostly SARSA won't be compatible with it, so we can get a variable to set the action space to analog for newer agents.


I cannot find where this is needed. Was it added accidentally?


Perhaps make the code collect nameIDs reference from GSUB/GPOS.  And then also check that there are no unreferenced nameIDs in name table...


Hm, that makes me wonder if the mode of operation makes sense to be honest.

Right now we extract *all* code samples when a document is saved, while instead we could treat the whole thing as lazy (since we already accept the fact that we won't cover all code samples given the remote source ability of code sample macros). Instead we could just have the view trigger a Celery task with the specific code sample name and have the table be populate over lazily. That would ease the roll out of this feature as well lower the impact of saving a document since it wouldn't have to extract the code sample on save time but only asynchronously on request time. We would have to delete all code samples of a document when it's saved though. Hm, not sure.


this line looks unneeded


Changes made to source code


ah bah tu as déjà tout fait du coup ^^


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19512/testReport/) for this commit**


Creating these methods as static could have disadvantages in the future: we cannot add any state to the class.  Suppose we create a derived class, we cannot override the static method.  Such methods are prone to concurrency bugs.


Ok, makes sense. Can you take care of that. For the moment I included the
patch as it is, this should never happen so I am not that worried!

On Fri, Aug 21, 2015 at 5:53 PM, Andres Tanasijczuk <
notifications@github.com> wrote:

> We are not. I was thinking that at least in the case in which the failure
> was in updating the retry_info dictionary, the crab_retry is still known
> and we can report to dashboard. For the cases of failure retrieving the
> retry_info dictionary we could use the dag_retry to report to dashboard
> (and still exit with fatal error). And finally, we can think of making
> crab_retry obsolete and always use dag_retry (the crab_retry is there to
> account for post-jobs restarts).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AndresTanasijczuk/CRABServer/commit/6954ea698226b452d609ca8a644638725c567458#commitcomment-12832102>
> .
>


doesn't this leak the plaintext password as part of the key, in the JVM heap dump in case of a crash?


or you can just clear caches, somehow for me even resolutionStrategy -> cacheChangingModulesFor doesnot work. I go to user home .gradle, and delete cache


I tried

Indeed your patch make the routine match their name.
Start to get first cpu
Next to get next cpu.

However seq_read calls start with pos != 0.
I am not familiar with seq operations but your patch cause an infinite loop in seq_read.

My patch just mimic other architectures I.e. x86.

Of course I can check pos value in c_start but that what you wanted to avoid.

What do you recommend to do?

Noam

Sent by MailWise<http://www.mail-wise.com/installation/4> – Your emails, with style.:)

-------- Original Message --------
From: Vineet Gupta <notifications@github.com>
Sent: Thursday, August 20, 2015 08:12 AM
To: EZchip/linux <linux@noreply.github.com>
Subject: Re: [linux] ARC: Adjust cpuinfo to work on sparsed mask (a95f79a)
CC: Noam Camus <noamc@ezchip.com>

Untested patch .....

diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
index 1dc087bbd7bb..348aae867d3b 100644
--- a/arch/arc/kernel/setup.c
+++ b/arch/arc/kernel/setup.c
@@ -500,12 +500,19 @@ done:

static void *c_start(struct seq_file *m, loff_t *pos)
{

  *   if (pos == 0) / just in case, cpu 0 is not the first */
  *   *pos = cpumask_first(cpu_online_mask);
  *   else
  *   pos = cpumask_next(pos - 1, cpu_online_mask);
  *   /* EZChip could have a sparse cpu map, cpu 0 may not be the first */
  *   *pos = cpumask_first(cpu_online_mask); +
  *   /* There will always be atleast 1 cpu */
  *   return cpu_to_ptr(*pos); +} + +static void *c_next(struct seq_file *m, void *v, loff_t *pos) +{
  *   pos = cpumask_next(pos, cpu_online_mask); + /*
  *   * Callback returns cpu-id to iterator for show routine, NULL to stop.
  *   * return cpu-id to iterator for show routine, NULL to stop.
     *   However since NULL is also a valid cpu-id (0), we use a round-about
     *   way to pass it w/o having to kmalloc/free a 2 byte string.
     *   Encode cpu-id as 0xFFcccc, which is decoded by show routine. @@ -513,12 +520,6 @@ static void c_start(struct seq_file *m, loff_t *pos) return *pos < nr_cpu_ids ? cpu_to_ptr(pos) : NULL; }

-static void *c_next(struct seq_file *m, void *v, loff_t *pos)
-{

  *   ++*pos;
  *   return c_start(m, pos); -} - static void c_stop(struct seq_file *m, void *v) { }

—
Reply to this email directly or view it on GitHub<https://github.com/EZchip/linux/commit/a95f79acf3d7457b0da6f304f5dd8775eeebf7a9#commitcomment-12800043>.


I guess we can use a prealloced buffer instead of append here. Otherwise it will always malloc a new memory.


If you look at http://hackage.haskell.org/package/snap-core-0.9.8.0/docs/Snap-Core.html, you'll see that `MonadSnap` implementations are provided for `ReaderT` (specifically `MonadSnap m => MonadSnap (ReaderT r m)` -- so probably the implementation is `liftSnap = lift`). So because this is written in `MonadSnap`, the compiler can check that the context where I'm using it supports liftSnap (oh look, it does because it's a ReaderT something Snap), and invoke the correct implementation automatically.


Actually I just rebased it a little further to have never dropped browserify to begin with, eliminating that last travis fix commit.

This commit has now become bd5d9a8


TeamCity pull requests :: netty [Build 93](https://garage.netty.io/teamcity/viewLog.html?buildId=637&buildTypeId=pulls_netty&guest=1) is now running


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 384](https://teamcity.labkey.org/viewLog.html?buildId=267741&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:38
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Indentation is off.


TeamCity pull requests :: netty [Build 93](https://garage.netty.io/teamcity/viewLog.html?buildId=637&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:39


What problem(s) does this solve? Removing public API methods will likely existing code in wild. Use deprecating methods in favour of immediate removal so people can have time to change their code.


Same issue as ramlev, see https://github.com/cybertk/ramlev/issues/27


Kind of accidentially. I was building Flink with the Hadoop1 profile in IntelliJ and it complained because the
`ConfigDocsCompletenessChecker` is importing `org.apache.commons.io.FileUtils`.
So this dependency is needed, but only for the tests.


Shouldn't the S-expr format match the abstract syntax? We can massage them
to fit either direction, but having them diverge would seem unfortunate. I
can see making the `memory` field more structured, with explicit `size`
node and multiple `segment` nodes contained in it. That would match the
structure you suggest. On the other hand, the flattened structure seems
more convenient, and more consistent with what we do with the other
declarations.


indentation for the next line.


I guess if using a continuous memory area and divide into multi page, it may better for tlb hit


I had forgotten that the the tests were locally runnable, so this is reverted in a subsequent commit.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8170/testReport/) for this commit**


dont need the puts


So I should manually change my origin using:

  git remote set-uril --push origin https://github.com/dumbunny/vitess.git?


dont need the return


I deleted the cache several times before, that didn't work for me


Not sure how this is used, but we're sure we want the buffer size to be 500?


I assume you meat `sq=" ' "`.

Anyways `git for-each-ref --shell --format="refname is %(align:30,middle)${sq}%(refname:short)${sq}%(end)|"`
would display `refname is '           '\''master'\''           '|`
Does that make sense?


PluginZoneInitialization2 (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2283 of 2341 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.52%25-yellow.svg)


basically when its inside the method u dont need a puts, if outside the methods it needs a puts


> Also, it would be really nice if material.program would get assigned right after the program is created instead of during the next render.

Yeah, that's what I was hoping.


Compress & unCompress


This isn't specific to the modulestore, so I'd rather it go in common/test/utils.py (this is a new file that @peter-fogg is creating in https://github.com/edx/edx-platform/pull/9366/files#diff-bc5d5a000be2abbd7261587eccbf16c4.


I'm not sure if this would make a difference, but since this code already checks if `elementClassInfo instanceof PrimitiveClassinfo` here, it could set *arrayClassInfo* without another conditional. It'd just need to consult a map from *PrimitiveClassInfo* to *PrimitiveArrayClassInfo*.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


s/is access/access is/


This breaks tests for users of the addon as well, we also had to use `es5-shim` to get our tests working again. All acceptance tests failed.

Should this go in the docs or is this behavior not intended?


Why? Is this not more or less the same thing?


This kind of change makes reviews harder; there isn't a functional change here, but someone has to carefully compare lines to find out.  These kinds of changes should be batched up and put in a separate commit.


Hello octocat i'm jhoebuzz


What is the purpose of this change, and why did you comment out the old implementation instead of replacing it?


I don't actually necessarily agree with that... because we want to put developers into a situation where separate components (or even extensions to a full Aikau page) can happily declare all of the services that they rely on safe in the knowledge that it won't cause any problems (which would be actual errors). We can potentially bump this up to warn, but I think error might actually be misleading - that would indicate something is wrong, whereas filtering services is actually normal (and in many cases expected) behaviour.


@elimisteve no, if a child job has multiple parents, it will run after each parent job.


@chrisvire Thanks, yes, I want to have a guide similar to this one :+1:


Didn't see this while merging the pull request. Two things:

* You used NPM and not Bower, _front-end dependencies should be installed through Bower_.
* The dependency isn't declared in the __package.json__ file (although it should be declared in __bower.json__), thereby I get the following error while running Gulp.

> Error: Cannot find module '/Users/johann/Development/wp-boilerplate/node_modules/es5-shim/es5-shim.min.js' from '/Users/johann/Development/wp-boilerplate'

I fixed those issues in 3f028d3 commit.


@Dominator008 See above. Let's fix the Javadoc.

@supersteves I don't think there's much we can do about updating code that isn't in our codebase, unfortunately, so you may just have to update your test at the same time that you upgrade your dependency on the compiler.


I /could/ write a more conclusive error message to the log at this point, but that may be misleading - because 0 target rows is not necessarily an error: sometimes, another part of the same cascade does already remove some of the target records of this call, so that we indeed may have no rows left at this point. Circular references even do that by nature.

The design is therefore that low-level delete always reports *success* if the target record does no longer exist after the call (to indicate green light to the dependent cascade), regardless whether it has been deleted in /this/ call or in another part of the cascade.

The uppermost level should indicate 404 Record Not Found if you call delete for a non-existent record..


Ahh so that's what it was :). Thanks!


I know this is old code but it's worth pointing out that `fileName.Capacity * 2` is wrong as the function expects a number of characters, not a number of bytes. Luckily module base name and file name are unlikely to exceed 1024 characters :smile:

And this doesn't even need to use `StringBuilder`, a `char[]` would do.


When there's an option for that, we should use it: http://eslint.org/docs/rules/space-infix-ops