Should we try to drain the pipe of whatever data is currently in it, rather than reading a single byte?  Otherwise, in a case where lots of changes happened, we could end up filling the pipe to the point where writes become blocking, and we could end up turning our blocking polling into a spin loop, e.g. if 1000 changes come in at the same time, even if there's no activity on any other file descriptor, we'll end up looping over the polling function a thousand times, each time reading one item from the pipe.  I'm thinking something like this (pseudo-code):
```C#
private unsafe void ReadSpecialFd(PollFlags revents)
{
    const PollFlags BadEvents = PollFlags.POLLERR | PollFlags.POLLHUP | PollFlags.POLLNVAL;
    if ((revents & BadEvents) != 0)
        throw new InvalidOperationException(...);

    const int BufferLen = 1024;
    byte* ignoredBytes = stackalloc byte[BufferLen];
    int pipeReadFd = _specialFds[libc.ReadEndOfPipe];
    do
    {
        if (read(pipeReadFd, ignoredBytes, (size_t)BufferLen) <= 0)
            throw new InvalidOperationException(...);
    }
    while (poll(pipeReadFd) > 0);
}
```
or something like that.


except that the way the response is being generated by the test harness is making invalid HTML for some reason, which is spooking the test \*sigh\*


When you bind two properties with a transformation function, the result should go into `target`


@Dwar3xwar DWMR. You handled the completion of this! Press on.


I think this will always evaluate to true, since you cannot have an *on_time* submission that is newer than a *late* one.


Indent problem


why is it on a new line
https://www.youtube.com/watch?v=umDr0mPuyQc&spfreload=10


@progirep Thanks a lot for the quick reply! I got the preprint from Cat (I hope that's OK) and read it already. Very cool :smiley:


How common is this going to be?  If not very, this is fine.  If it's going to be common, it'd be better to do this blocking in a way that doesn't require allocating a Task and the underlying Timer for it.  The most ideal would be Thread.Sleep(10).  If for some reason we can't do that, you could have a static readonly ManualResetEventSlim that's never Set, and then Wait(10) on it.


Muszály volt széthasítani,hogy az openssh felfrissítés ne rántson magával fejléc csomagokat, többek közt a kernel-headers -t.

Baromi a névkavarodás, nem értem, hogy miért van ez így?
editline? libedit?


Fixes the audio timing in RE2's FMVs too


Resolves: #323


@fboers , jumeg.template doesn't exist in this branch.


does your comment start with a new line?


initial merge


tranform txt charator to pic
xihuan  :thining the charactor
wave : use the forth patch of dd as response map1,
cnn : choose actual text region over the response map1


@hbun DWMR. You are leaning into the work and getting it done. Good. Keep it up.


Right. It could serve a descriptive json message though. You should also be able to hook into the content negotiation process and maybe serve a 403 template that will render the message.


I made a comment in PollFds about lazily-allocating the ```List<T>```, but looking at this now, it'd be better if the list were allocated once in PollFunction before the while loop, and then that list can be passed in to PollFds to be filled by it.  That avoids allocating the list each time.  You'd just clear the list prior to calling PollFds, it'd put descriptors into it, and then on return you'd check whether the Count was still 0.


Mostly, we use the join() subroutine.


Hi Matthijs,

You shouldn't commit and push the h2 configuration to the repo since the develop and test environment use a postgres-postgis config. The teamcity builds will now create a war file with h2 enabled which results in geonetwork not working on the development server anymore.
You can change it locally for development, but don't commit....


Should these be the Summer15_50nsV4_DATA corrections instead? Or are they meant to be MC.


why not put the message in one line by one call of trace()?


With this implementation I think the string `"GeometricPrograms cannot contain Signomials"` should be defined as a constant in only one location -- otherwise this is fragile.


What does curl_multi_socket_action do?  Does it invoke callbacks synchronously?  If so, it'll be doing so while the lock on multiHandle is held.


Looks good! What's the use case? WillResignActive wasn't enough?


Are you explicitly doing the cancellation check before calling CheckForCompletedTransfers?  If that exact timing of the check doesn't matter, you could simplify things by changing the while loop from ```while(true)``` to ```while (!cancellationTokenSource.IsCancellationRequested)``` (or whatever bool you end up using instead), and then removing this if block.


Here the second condition is unnecessary it can be removed.


@n0mer I think it makes perfect sense and will make even more sense when there is a dashboard page for Applications. You're naming the token.

This will all make more sense when I get around to logging all API requests by the token, so you can see who changed what.


You are counting twice


@hbun DWMR. Continued good work. Thank you.


remove this useless line


No good reason. In fact, I believe `try conn.close() catch { case _:  java.sql.SQLException => }` is better.


nice message


We find last saveturnin from folders /late and /on_time. And check for latest (bigest). Only check files without any logic.


personally i would have made size-only checks the default, then had the option to do exhaustive checks


In all the files, sometimes you outpu message to display the verbose value, sometime it's commented off.. Could you make  them consistent?


I think we should rename this to `qa-vagrant` or something.


Please always use curly braces even when there's a single statement. By not including it it's easier to introduce bugs in the future if a second statement needs to be added.


I realize there's the TODO, but in the meantime, it'd be better to avoid the delegate and closure allocation by doing:
```C#
Task.Factory.StartNew(
    s => PollFunction(((CurlHandler)s)._multiHandle), this,
    CancellationToken.None, TaskCreationOptions.DenyChildAttach, TaskScheduler.Default);
```


Please always put a space after the `if` keyword.


Consider to add a documentation for this function is not clear what it does. Use this standard to write it https://github.com/angular/angular.js/wiki/Writing-AngularJS-Documentation.


If `on_time` or `late` directories do not exist, while everything else is OK, then we should probably create them.  Otherwise the class directory administrator will have to manually create these directories for every assignment.  Alternative approaches are also welcome.


`Force yes` s is **a dangerous option**
```
       --force-yes
           Force yes; this is a dangerous option that will cause apt to continue without prompting if it is doing something potentially harmful. It should not be used except in very special situations. Using force-yes can potentially destroy your system! Configuration Item: APT::Get::force-yes.
```

`-y` (or `--assume-yes`) is enough.


use the operator `===` is safer than the `==`. Add a space between and after the operator it is more clear.


This assignment seems redundant.


This is a good delete


fast-forwarding 2.0 to borshop-integration-767-bugfix/jdm/vnode-proxy-stuck-in-overload-v2 = 806e8575


See the previous comment.


sorry it took a while, but done!


Please avoid one liners.


Why do you print this?


What happens in the following situation:
1. We remove the last FD and signal cancellation.
2. But the PollFunction loop is passed the cancellation check and is about to check for descriptors to be processed.
3. A new FD arrives and we spin up another PollFunction.

We now have two PollFunction loops running and potentially attempting to process the same set of descriptors.  Is that a problem?  If it is, you'll probably need to coordinate the tasks that get launched to run PollFunction.  That would likely mean storing the Task you launched to run PollFunction.  Then when you go to create another task to run PollFunction again, you do so in a way that'll only start the new processing once the old has finished, e.g. by using ContinueWith off of the previous Task rather than using StartNew.


Except the inline comments, please fix hte following common problems:
1. fix the indent  of all your change
2. use join() if you want to get the node list from noderange
3. combine the message if possible to reduce the time to call trace()


Also the `destinationID` has to be a string to be valid.


1: M110 missing component name
1: M190 line is too long (61 > 50)


i see.

it  was not clear that `name` is for 3-rd party application name

now it makes sense


I believe a zero penalty should be acceptable.  Not that important anyway.


now it's clear about the end frame size. it should be greater for leds count > 64. i've implemented again the size. see my code here: https://github.com/tvdzwan/hyperion/issues/361#issuecomment-129460108 (sorry for bad C++ code: i'm a C programmer). still dont understand watch the latch value does, but i left so.


You're only seeing the beginning of a new feature here :wink:


Hmm. I guess let's see what happens with store and what is easy to get
working.

I have tons more store info when you are ready.

D
Le Thu, Aug 13, 2015 à 15:08, divmazie <notifications@github.com> a écrit :

> Yeah, I guess it depends a bit on the store implementation. I'm happy to
> let old attachments sit for a while.
>
> Though also, my deleteOldAttachments method is the only thing in this code
> that is not working right now.
>
> On Thu, Aug 13, 2015 at 3:00 PM, Drew Westphal <notifications@github.com>
> wrote:
>
> > Do we want to delete old attachments all the time? Aren't we still going
> > to be selling old files, potentially? Then again we will have uploaded
> the
> > assets to the remote provider...
> >
> > IDK. What do you think?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/divmazie/jonathancoulton-theme/commit/922bfa9deaa109feb6f89cd1a00a4fda6f6eb73d#commitcomment-12696844
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/divmazie/jonathancoulton-theme/commit/922bfa9deaa109feb6f89cd1a00a4fda6f6eb73d#commitcomment-12697005>
> .
>


@jgarboza813 DWMR (done with my review). Good. Press on!


What is the purpose of the `div` in `div.CodeMirror-selected`, do you think we actually need it?


Smart Business from Home
is a change world bussiness MLM ONLINE or network marketing in support system by Faiz Woo
penetrate the boundaries of the world
Now still a lot of people who still do not understand the business system via online
Well, this time I will share infornasi about online business that is easy to understand it, easy to learn, easy duplication, is dedicated easy on, easy on the run by anyone in the world
You have to be open to what is learned in the world of online MLM business, because of its success in the world of MLM Online is thinking Intelligence openness to what has been you know about MLM or network marketing business.

Please visit me
www.rumahwootekh.com
www.tokowscbiolo.com

Thank you.

Best Regards,
for You

Young greetings, CEO 001
Faiz Woo

penetrate the boundaries of the world

http://rumahwootekh.com


Looks good


@drjova that was a bit too fast buddy.


I suppose the ably service always returns times in UTC


Is the Ably service returning time as in Unix time in milliseconds?


please add .idea/* to the .gitignore for the project so your phpstorm files aren't added.  Please also double check your commit files before pushing. :)


@AlbertoSONIC Qt Creator has a lot of options like that, and probably it's lighter than VS.


saw approval from jonmeredith
at https://github.com/basho/riak_core/commit/cac899ea3a4e7514217e4fde8222655528d19db1


merging basho/riak_core/basho/merge-forward-2.0-g806e857-to-2.1 = cac899ea into borshop-integration-770-basho/merge-forward-2.0-g806e857-to-2.1


basho/riak_core/basho/merge-forward-2.0-g806e857-to-2.1 = cac899ea merged ok, testing candidate = e1ceb12a


I think you meant `'\0'` instead of `0`.


    if (isFlush && isStraight) true
    else false

Remember, `if (expr) true else false` can be simplied.


Maybe we could make it more clear that the style sheet wins in the end?


Any chance to get the PR into master ?


s/know/known


1: M110 missing component name
1: M190 line is too long (61 > 50)


s/from the disk/from disk/ I would say


@greut true thanks!


lgtm


This isn't a valid node type.


This makes it impossible to add extra components to the Packagemanager, for the settings modal.
```
window.PackageManager = require('../components/package-manager.js');

jQuery(function () {

    (new Vue(window.PackageManager)).$mount('#extensions');

});
```
would restore that possibility.


This update semantically changes the topic request. The `true` meant it was looking for an unscoped `ALF_DISPLAY_NOTIFICATION`. It will now find any instance of that, and error with the supplied string if that's not the case.
`TestCommon.getLastPublish(topicName)` takes any number of arguments after the topic. If it finds a boolean, it will assign it to the `isGlobal` flag. If it's a number, it'll use it as the timeout for the query. Anything else will be used as the error message on failure.
To retain existing behaviour but add the message, change it to this:
```
.getLastPublish("ALF_DISPLAY_NOTIFICATION", true, "Did no publish correct topic when clicked")
```


Changed color scheme


XML to XSLT


Actually `JavaConverters` is the recommended way to handle these conversions (`JavaConversions` was introduced earlier and it's a bit too magical).


This will not work the way you intend. It will append the whole object to the `members` array of the house. What you want is this:

```javascript
...
$push: {
    members : {
        $each : ['Ned', 'Arya', 'Sansa']
    }
}
...
```

See this [doc](http://docs.mongodb.org/v2.6/reference/operator/update/push/#example-push-each) for more info.


You want `members` to be an array ([]).


Why don't you use something like `"{on_time,late}/%s-%d{,-*}.tgz"` as a pattern along with the `GLOB_BRACE` flag?


Includes fixes from https://github.com/Financial-Times/o-squishy-list/pull/12


commit


Nice! Fixed a lot for me


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1709


Pourquoi il n'y a pas de paramètre ?


`getfilelog` is not descriptive enough and I am still a big fun of comments, please consider adding a short description for each newly added function that its name is not self explanatory.


Attention, ne respecte pas la signature imposée !


If we send the error packet, I wonder if we could live without the warning. Error packets that are not handled end up becoming warnings, and if they are handled, we can still track them if we want by inspector or other means.

@bdilly thoughts?


Shouldn't this vary depending on the value of `penalty`?


I agree with Ederson.


``` diff
--- torbrowser-31.8.0_p453.ebuild	2015-08-14 16:11:56.024077670 +0200
+++ torbrowser-38.2.0_p500.ebuild	2015-08-14 16:26:00.032457541 +0200
@@ -1,6 +1,6 @@
 # Copyright 1999-2015 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: $
+# $Id$

 EAPI="5"
 WANT_AUTOCONF="2.1"
@@ -12,18 +12,17 @@ if [[ ${MOZ_ESR} == 1 ]]; then
 	MOZ_PV="${PV/_p*}esr"
 fi

-# see https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian/versions?h=maint-4.5
-TOR_PV="4.5.3"
-EGIT_COMMIT="tor-browser-${MOZ_PV}-4.5-1-build1"
+# see https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian/versions?h=maint-5.0
+TOR_PV="5.0"
+EGIT_COMMIT="tor-browser-${MOZ_PV}-5.0-1-build2"

 # Patch version
-PATCH="${MY_PN}-31.0-patches-0.3"
-PATCHFF="${PATCH}"
+PATCH="${MY_PN}-38.0-patches-0.3"

 MOZCONFIG_OPTIONAL_WIFI=1
 MOZCONFIG_OPTIONAL_JIT="enabled"

-inherit git-r3 check-reqs flag-o-matic toolchain-funcs eutils gnome2-utils mozconfig-v5.31 multilib pax-utils autotools
+inherit git-r3 check-reqs flag-o-matic toolchain-funcs eutils gnome2-utils mozconfig-v6.38 multilib pax-utils autotools

 DESCRIPTION="The Tor Browser"
 HOMEPAGE="https://www.torproject.org/projects/torbrowser.html
@@ -34,14 +33,15 @@ SLOT="0"
 # BSD license applies to torproject-related code like the patches
 # icons are under CCPL-Attribution-3.0
 LICENSE="BSD CC-BY-3.0 MPL-2.0 GPL-2 LGPL-2.1"
-IUSE="hardened test"
+IUSE="egl hardened test"

 EGIT_REPO_URI="https://git.torproject.org/tor-browser.git"
 EGIT_CLONE_TYPE="shallow"
 BASE_SRC_URI="https://dist.torproject.org/${PN}/${TOR_PV}"
 ARCHIVE_SRC_URI="https://archive.torproject.org/tor-package-archive/${PN}/${TOR_PV}"
 SRC_URI="http://dev.gentoo.org/~anarchy/mozilla/patchsets/${PATCH}.tar.xz
-	http://dev.gentoo.org/~axs/distfiles/${PATCH}.tar.xz
+	http://dev.gentoo.org/~axs/mozilla/patchsets/${PATCH}.tar.xz
+	http://dev.gentoo.org/~polynomial-c/mozilla/patchsets/${PATCH}.tar.xz
 	x86? (
 		${BASE_SRC_URI}/tor-browser-linux32-${TOR_PV}_en-US.tar.xz
 		${ARCHIVE_SRC_URI}/tor-browser-linux32-${TOR_PV}_en-US.tar.xz
@@ -53,15 +53,17 @@ SRC_URI="http://dev.gentoo.org/~anarchy/

 ASM_DEPEND=">=dev-lang/yasm-1.1"

-CDEPEND=">=dev-libs/nss-3.19.2
-	>=dev-libs/nspr-4.10.6"
+RDEPEND=">=dev-libs/nss-3.19.2
+	>=dev-libs/nspr-4.10.8"

-DEPEND="${CDEPEND}
+DEPEND="${RDEPEND}
 	${ASM_DEPEND}
 	virtual/opengl"

 QA_PRESTRIPPED="usr/$(get_libdir)/${PN}/${MY_PN}/firefox"

+BUILD_OBJ_DIR="${S}/ff"
+
 pkg_setup() {
 	moz_pkgsetup

@@ -82,13 +84,6 @@ pkg_pretend() {
 		CHECKREQS_DISK_BUILD="4G"
 	fi
 	check-reqs_pkg_setup
-
-	if use jit && [[ -n ${PROFILE_IS_HARDENED} ]]; then
-		ewarn "You are emerging this package on a hardened profile with USE=jit enabled."
-		ewarn "This is horribly insecure as it disables all PAGEEXEC restrictions."
-		ewarn "Please ensure you know what you are doing.  If you don't, please consider"
-		ewarn "emerging the package with USE=-jit"
-	fi
 }

 src_unpack() {
@@ -103,14 +98,11 @@ src_prepare() {
 	epatch "${WORKDIR}/firefox"

 	# Revert "Change the default Firefox profile directory to be TBB-relative"
-	epatch -R "${FILESDIR}/4.5-Change_the_default_Firefox_profile_directory_to_be_TBB-relative.patch"
-
-	# FIXME: https://bugzilla.mozilla.org/show_bug.cgi?id=1143411
-	epatch "${FILESDIR}/firefox-36.0.1-buildfix-ft-master.patch"
+	epatch "${FILESDIR}/5.0-Change_the_default_Firefox_profile_directory_to_be_TBB-relative.patch"

 	# FIXME: https://trac.torproject.org/projects/tor/ticket/10925
 	# Except lightspark-plugin and freshplayer-plugin from blocklist
-	epatch "${FILESDIR}/${PN}-31.7.0-allow-lightspark-and-freshplayerplugin.patch"
+	epatch "${FILESDIR}/${PN}-38.2.0-allow-lightspark-and-freshplayerplugin.patch"

 	# Allow user to apply any additional patches without modifing ebuild
 	epatch_user
@@ -147,10 +139,14 @@ src_prepare() {
 	# Must run autoconf in js/src
 	cd "${S}"/js/src || die
 	eautoconf
+
+	# Need to update jemalloc's configure
+	cd "${S}"/memory/jemalloc/src || die
+	WANT_AUTOCONF= eautoconf
 }

 src_configure() {
-	MOZILLA_FIVE_HOME="${EPREFIX}"/usr/$(get_libdir)/${PN}/${MY_PN}
+	MOZILLA_FIVE_HOME="/usr/$(get_libdir)/${PN}/${PN}"
 	MEXTENSIONS="default"

 	####################################
@@ -165,6 +161,8 @@ src_configure() {
 	# Add full relro support for hardened
 	use hardened && append-ldflags "-Wl,-z,relro,-z,now"

+	use egl && mozconfig_annotate 'Enable EGL as GL provider' --with-gl-provider=EGL
+
 	mozconfig_annotate '' --enable-extensions="${MEXTENSIONS}"
 	mozconfig_annotate '' --disable-mailnews

@@ -172,55 +170,57 @@ src_configure() {
 	mozconfig_annotate '' --with-default-mozilla-five-home=${MOZILLA_FIVE_HOME}

 	# Rename the install directory and the executable
-	mozconfig_annotate 'torbrowser' --libdir="${EPREFIX}"/usr/$(get_libdir)/${PN}
+	mozconfig_annotate 'torbrowser' --libdir=/usr/$(get_libdir)/${PN}
 	mozconfig_annotate 'torbrowser' --with-app-name=torbrowser
 	mozconfig_annotate 'torbrowser' --with-app-basename=torbrowser
-	# see https://gitweb.torproject.org/tor-browser.git/tree/configure.in?h=tor-browser-31.6.0esr-4.5-1#n6395
+	# see https://gitweb.torproject.org/tor-browser.git/tree/configure.in?h=tor-browser-38.2.0esr-5.0-1#n6500
 	mozconfig_annotate 'torbrowser' --disable-tor-browser-update
 	mozconfig_annotate 'torbrowser' --with-tor-browser-version=${TOR_PV}

+	# FIXME: use bundled libraries to work around build failure
+	mozconfig_annotate 'torbrowser' --without-system-nspr
+	mozconfig_annotate 'torbrowser' --without-system-nss
+
+	echo "mk_add_options MOZ_OBJDIR=${BUILD_OBJ_DIR}" >> "${S}"/.mozconfig
+
 	# Finalize and report settings
 	mozconfig_final

 	if [[ $(gcc-major-version) -lt 4 ]]; then
 		append-cxxflags -fno-stack-protector
-	elif [[ $(gcc-major-version) -gt 4 || $(gcc-minor-version) -gt 3 ]]; then
-		if use amd64 || use x86; then
-			append-flags -mno-avx
-		fi
 	fi
+
+	# workaround for funky/broken upstream configure...
+	emake -f client.mk configure
 }

 src_compile() {
 	CC="$(tc-getCC)" CXX="$(tc-getCXX)" LD="$(tc-getLD)" \
 	MOZ_MAKE_FLAGS="${MAKEOPTS}" SHELL="${SHELL}" \
-	emake -f client.mk
+	emake -f client.mk realbuild
 }

 src_install() {
-	MOZILLA_FIVE_HOME="${EPREFIX}/usr/$(get_libdir)/${PN}/${MY_PN}"
+	MOZILLA_FIVE_HOME="/usr/$(get_libdir)/${PN}/${PN}"
 	DICTPATH="\"${EPREFIX}/usr/share/myspell\""

-	# MOZ_BUILD_ROOT, and hence OBJ_DIR change depending on arch, compiler etc.
-	local obj_dir="$(echo */config.log)"
-	obj_dir="${obj_dir%/*}"
-	cd "${S}/${obj_dir}" || die
+	cd "${BUILD_OBJ_DIR}" || die

 	# Pax mark xpcshell for hardened support, only used for startupcache creation.
-	pax-mark m "${S}/${obj_dir}"/dist/bin/xpcshell
+	pax-mark m "${BUILD_OBJ_DIR}"/dist/bin/xpcshell

 	# Add an emty default prefs for mozconfig-3.eclass
-	touch "${S}/${obj_dir}/dist/bin/browser/defaults/preferences/all-gentoo.js" \
+	touch "${BUILD_OBJ_DIR}/dist/bin/browser/defaults/preferences/all-gentoo.js" \
 		|| die

 	# Set default path to search for dictionaries.
 	echo "pref(\"spellchecker.dictionary_path\", ${DICTPATH});" \
-		>> "${S}/${obj_dir}/dist/bin/browser/defaults/preferences/all-gentoo.js" \
+		>> "${BUILD_OBJ_DIR}/dist/bin/browser/defaults/preferences/all-gentoo.js" \
 		|| die

-	# see: https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian/descriptors/linux/gitian-bundle.yml#n150
+	# see:https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/gitian/descriptors/linux/gitian-bundle.yml#n166
 	echo "pref(\"general.useragent.locale\", \"en-US\");" \
-		>> "${S}/${obj_dir}/dist/bin/browser/defaults/preferences/000-tor-browser.js" \
+		>> "${BUILD_OBJ_DIR}/dist/bin/browser/defaults/preferences/000-tor-browser.js" \
 		|| die

 	MOZ_MAKE_FLAGS="${MAKEOPTS}" \
@@ -245,9 +245,11 @@ src_install() {
 	fi

 	# Required in order to use plugins and even run torbrowser on hardened.
-	pax-mark m "${ED}"${MOZILLA_FIVE_HOME}/plugin-container
-	# Required in order for jit to work on hardened, as of torbroser-31
-	use jit && pax-mark pm "${ED}"${MOZILLA_FIVE_HOME}/{torbrowser,torbrowser-bin}
+	if use jit; then
+		pax-mark m "${ED}"${MOZILLA_FIVE_HOME}/{torbrowser,torbrowser-bin,plugin-container}
+	else
+		pax-mark m "${ED}"${MOZILLA_FIVE_HOME}/plugin-container
+	fi

 	# We dont want development files
 	rm -r "${ED}"/usr/include "${ED}${MOZILLA_FIVE_HOME}"/{idl,include,lib,sdk} \
@@ -295,7 +297,7 @@ pkg_postinst() {
 	elog "for further information."
 	echo

-	if [[ "${REPLACING_VERSIONS}" ]] && [[ "${REPLACING_VERSIONS}" < "31.6.0_p450" ]]; then
+	if [[ "${REPLACING_VERSIONS}" ]] && [[ "${REPLACING_VERSIONS}" < "38.2.0_p500" ]]; then
 		ewarn ""
 		ewarn "Since this is a major upgrade, you need to start with a fresh profile."
 		ewarn "Either move or remove your profile in \"~/.mozilla/torbrowser/\""
```


not so sure


<div.row>


What's the difference between `this.createNotifcation()` and `$notification.create()`.

There are several other calls in the UI source to `this.createNotifcation()`.  I'm guessing this was part of the change when John refactored a bunch of code back in Jan/Feb.  Should we audit the current source to see if there are calls that need to be changed.


Oui, je pouvais rajouter longueurChemin, mais c'était une info inutile, donc je l'ai laissé de côté


+1 for sending and not WRN()-ing.


oups :P
Sinon, c'est plus ou moins correct le code ?


![I like it](http://38.media.tumblr.com/cde42c0bba57aa184b0de79b401aaebf/tumblr_n9bz9cSb6L1st18yzo1_500.gif)


Feels like we are repeating ourselves, should this be it's on function?


101242918_EvapCndPump (Nigusse) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can we add some tests as well?


why ?


Removed the warnings.


sorry my mistake though it's only the description


because


I'd like to see this heavily tested.
It's a pure function so that should be simple.


is said so


kadulmus


Unfortunatelly there is nothing on line 325. Could you please copy the exact warning and paste it here or prefereably at https://foliovision.com/support ?


Even if you are late for 5 minutes you should get a full day penalty.


Also, this should only be done when source and destination are the same (so a shorthand was used).


I'm partying this commit so hard you have no idea :D :dancers:


we don't have a strict line size or new line rule, but new line before the first parameter should be avoided. my 2 cent


Typo?


Okay


nhokay


fast-forwarding 2.1 to borshop-integration-770-basho/merge-forward-2.0-g806e857-to-2.1 = e1ceb12a


So far, so good.


I knew there was a way to bind to the events of the view, just couldn't find it. Will squirrel this away.


Ah, good man, thanks @kimble, am less familiar with the gradle so good to know! :)
Cheers, Andrew


Applying the multiplier to timeout reduces the time between successive attempts. A group of Scalpels will fire a salvo at a Gnat every 3 or so seconds. Applying the multiplier to health would make the salvos larger but with the same spacing and would also cause there to be no change against targets with low health compared to the damage of the weapon.

My reasoning for increasing the refire rate instead of the salvo size is as follows; Whether a unit is hit by a projectile in this situation depends much more on the unit than on the source of the projectile. If a Raven flies overhead then Scalpels are not going to hit it unless it dives. These windows of opportunity will be small so I would rather have the Scalpels firing more evenly.

Another example is a radar dot Glaive against Racketeers. Say, for example, the health modifier solution has two Racketeers fire at the Glaive every 8 seconds. If the Glaive remains outside LOS both will miss, if it enters LOS during the missile flight then they will both hit. But this could give the Glaive a window to run in and deal damage. Alternately, with the timeout multiplier, one Racketeer would shoot every 4 seconds. This means that if the Glaive enters LOS there will probably be a missile in flight which will quickly hit and disarm it.

Your extra assumptions and requirements for the timeout number was one of my big worries for overkill prevention changes. The change here fits the timeout system that I envisaged. I'm not sure that timeout is reliable enough to do what you want to do with it. It was never supposed to be an accurate estimation of impact time, it is simply a sanity check to say "well, I'm sure that damage isn't going to occur anymore".


Yeah, that makes sense.


Missing `{` to begin the object being assigned to `update.$push`. Also a missing `}` to close off `update` (the second argument to `db.collection.insert`). 4/5 credit.


> Is the Ably service returning time as in Unix time in milliseconds?

yes


LGTM


More specifically, https://github.com/cloudfoundry/cloud_controller_ng/commit/26b6cdc812800f62c8166444ca4feff79cc38316 removed the errant `p`.


Il y a un problème sur la condition : si tu n'as pas de fils gauche mais un fils droit ou inversément, il me semble qu'il passe à l'affichage


Very good.


Je pense que longueurChemin done la longueur maximum du chemin à explorer ?


Great.


Sometimes dialyzer doesn't complain about a library function until it is used. It also helps to catch mistakes in the tests and examples.

We can make a separate target (dialyze-all?) that includes the tests/examples. When epcap moves to rebar3, the default will be to check src only anyway.


Pareil pour la condition


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


101280704_LowTempRad (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


val ? D'où vient cette variable ?


Maybe: http://editorconfig.org/ (+ VS plugin) so all contributors will use same settings ?


Pour répondre au commentaire, si la fonction renvoie True, c'est que la somme es ttrouvée. Donc tu dois regarder aux retours de fonction si ledit retour est True


We don't all use VS, gregory is a linux coder :P


$lang_global['logininfo'] = 'All tools on this site will be available when you're logged in';


> I suppose the ably service always returns times in UTC

Not UTC but Unix time: https://en.wikipedia.org/wiki/Unix_time, which is only related to UTC in that it was 0 at 00:00:00 UTC on 1 January 1970.


This closes #2


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.490](http://teamcity.monogame.net/viewLog.html?buildId=9627&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:02


'an external'


Delayed::Worker.logger ||= Logger.new(File.join(Rails.root, 'log', 'delayed_job.log'))... when this line comes logger is defined either `Rails.logger` or user specified logger. So when the user didn't specify any logger delayed job not creating the default logger, instead it uses `Rails.logger` which could be the production log, finally the delayed job logs are mixed with production log.


Va falloir m'expliquer l'utilité de la fonction :-°


and i am not sure if "Transfer_Enco**n**ding" is expected.

@zqkkqz how did you test your fix?


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


-$jum_total = mysqli_result(mysqli_query($sql_total),0);


The commit broke posting variables with /.
ADDONURL='http://dist.suse.de/install/SLP/SLE-12-SP1-HA-Beta1/x86_64/DVD1/' becomes ADDONURL='http:%2F%2Fdist.suse.de%2Finstall%2FSLP%2FSLE-12-SP1-HA-Beta1%2Fx86_64%2FDVD1%2F'


$lang_global['adminlogininfo']  = 'Please use a valid username and password to login to the Control Panel';


תודה.....הסתדרתי והבנתי זאת שהמשכתי לעבור על השיעור


[Deployment available online](https://s.brightspace.com/lib/ifrau/0.10.1/ifrau.js)


@jnfoster @arjunguha @mcanini: Fixed the bug simply by replacing add_exn with add. It's actually possible (and not a problem) that a key is already present in the untbl. In fact, this is a good thing and means that we just avoided creating a duplicate state. (Take a look add add_to_t: it creates a new state only if there is not already an equivalent state present).


maybe make setNextRow synchronized.


:sunny:


there is probably a race condition because this happens after send


Somehow I get an error on saving a File with FileStorageTable now. Seems like $entity is a boolean:
```
Warning (4096): Argument 2 passed to Burzum\FileStorage\Storage\Listener\LocalListener::afterSave() must implement interface Cake\Datasource\EntityInterface, boolean given [ROOT/vendor/burzum/file-storage/src/Storage/Listener/LocalListener.php, line 108]
```


Hi Nico,
I got the following exception while trying to use nolearn. this problem didn't show up with previous version of nolearn.

  File "/usr/local/lib/python2.7/dist-packages/nolearn-0.6adev-py2.7.egg/nolearn/lasagne/base.py", line 3, in <mod
    from .._compat import basestring
ImportError: cannot import name basestring


good catch


check if that is correct, maybe it's not


You broke the `main()` asserts.


generates a job, creates a fake distributed result action, which blocks, so the queue is filled and pause is called


so the thing here is that there are three classes involved in the hashCode(). AggregatorFactory is the base class and implements hashCode() and then defines doHashCode for sub-classes to implement. ValuesSourceFactory extends AggregatorFactory and implements doHashCode but then defines this innerHashCode() for subclasses to implement. So doHashCode (and doEquals) are defined but we need multiple levels. Do you have anything similar to that in the query refactor?


Cảm ơn bạn. Tôi sẽ cập nhật trong nay mai.


Some of these can also be constants. If they are never reused in a different test, you can at least create local variable to use for the test asserts.


Very nice


LGTM


When imapUidList is > 1, cached.uidNext will not get a correct value.


No, I didn't explain myself correctly here.

I didn't mean to create a new `it` block. I was just saying that in the test titled "take AutoYaST cio_ignore setting if it is enabled" nothing guarantees that the `false` value in `expect(...).to eq(false)` is actually coming from `AutoinstConfig`. But if you use a weird value instead of `false`, then you can be sure it's not coming from anywhere else, so you can really assure the predicate "take AutoYaST cio_ignore setting".

Not sure if I explained better now or even worst. :wink:


Oh, I suppose it depends on your implementation generally. I thought we had agreed that because typically in .net a method should respond quickly or provide an evented / callback interface. I'll let you recommend what is best for .net


comment doesn't match


That is a good point.  It is DNSSEC vs HTTPS.


а зачем тут inspect? ты, наверно, хотел поле какое-нибудь вытянуть


please tell me about some problems,r you ready?


@ikenohate09 @syjkim35 this is a typo right…


I spent some time last night reviewing the "custom_delay_ms()" and found some issues when I wrote the DelayProof program to test it out (see below).

I included three different delay functions in the code and tested each one.  The issue with the first two seems to be that the overhead of calculations and calls creates additional delay time (which is probably not desired).

The final routine is within 4-12Usecs over delays of 40+ microseconds. Delays of 5-40 microseconds just have too much parasitic delays in the process to be accurate in this environment.

If you adjust the comments in the code below to reveal any of the delayUsecs(), then you can compile, upload and run the program to see the differences.  At some values, the divergence is quite large.

I included a sim_micros() to test the overflow processing. It is not very elegant, but I think it demonstrates that the code will work as intended.  Uncomment this section to test with the simulator.

The third routine makes use of the "real time" aspect of micros() and takes care of the overflow issue when micros() hits the top value of an "unsigned long" and goes back to Zero.  Since it is waiting for time to pass, and not just "running code to take up estimated time" (like the internal delay functions do), it is about as accurate as possible (IMHO).

Please consider using my function (the one in use below) to replace your custom_delay_ms().

Thanks and keep up the great work making this Library better.
``` c++
//
//    FILE: DelayProof.ino
//  AUTHOR: Paul Coughlin
//    DATE: 2015-08-14
//
// PURPOSE: test microsecond resolution delays for accuracy.
//
unsigned long t = 0, m = 0, n = 0, e = 0;
unsigned long times[20];

/* remove this comment to test with simulator
// "unsigned long" ranges from 0 to 4,294,967,295 (2^32 - 1).
// needed to test overflow event
// did not want to wait over an hour between natural occurrence
// Serial.print output is interesting when simulator is running
unsigned long sim_times[] = {
  4294956195,4294957195,4294958195,4294959195,4294960195,
  4294961195,4294962195,4294963195,4294964195,4294965195,
  4294966195,4294966295,4294966395,4294966495,4294966595,
  4294966695,4294966795,4294966895,4294966995,4294967095,
  4294967195,4294967205,4294967215,4294967225,4294967235,
  4294967245,4294967255,4294967265,4294967275,4294967285,
  4294967295,
  0,
  10, 20, 30, 40, 50, 60, 80, 100,
  100,200,300,400,500,600,700,800,900,
  1000,2000,3000,4000,5000,6000,7000,8000,9000,
  10000,11000,12000,13000,14000,15000,16000,17000,18000,
  19000,20000,21000
};
int sim_size = (sizeof(sim_times)/sizeof(unsigned long));
int sim_index = 0;

#define micros sim_micros
unsigned long sim_micros() {
  if (sim_index >= sim_size) {
    sim_index = 0;
  } else {
    sim_index++;
  }
  return sim_times[sim_index];
}
// */
#include <stdarg.h>
void p(char *fmt, ... ) {
  char buf[128]; // resulting string limited to 128 chars
  va_list args;
  va_start (args, fmt );
  vsnprintf(buf, 128, fmt, args);
  va_end (args);
  Serial.print(buf);
}

//void delayUsecs(unsigned long time) {
//	if (time) {
//		if (time > 16000) {
//			delayMicroseconds(time % 1000);
//			delay((int)(time / 1000));
//		}
//		else delayMicroseconds(time);
//	}
//}

//void delayUsecs(unsigned long time) {
//	if (time) {
//		while (time > 16000) {
//			delayMicroseconds(16000);
//			time -= 16000;
//		}
//		delayMicroseconds(time);
//	}
//}

void delayUsecs(unsigned long uSecs) {
  if (uSecs > 4) {
    unsigned long start = micros();
    unsigned long endMicros = start + uSecs - 4;
    if (endMicros < start) { // Check if overflow
      while ( micros() > start ) {} // wait until overflow
    }
    while ( micros() < endMicros ) {} // normal wait
  } else {
    __asm__("nop\n\t"); // must have or compiler optimizes out
  }
}

void print_after() {
  e = micros();
  t = (e - m);
  p("%lu =%lu-%lu \n", t, e, m);
}

void setup()
{
  // test to see when setup actually starts.
  times[0] = micros(); // Actual value= 4
  times[1] = micros();
  times[2] = micros();
  times[3] = micros();
  times[4] = micros();
  times[5] = micros(); // Call to micros() is actually about 3.1us
  times[6] = micros(); // so sometimes it catches same 4us window.
  times[7] = micros();
  times[8] = micros();
  times[9] = micros();
  times[10] = micros();
  times[11] = micros();
  times[12] = micros();
  times[13] = micros();
  times[14] = micros();
  times[15] = micros();
  times[16] = micros();
  times[17] = micros();
  times[18] = micros();
  times[19] = micros(); // Actual Value=68

  Serial.begin(9600);
  Serial.println("start...");
  p("%10lu\n", times[0]);
  for (int x = 1; x < 20; x++) {
    p("%10lu %lu\n", times[x], times[x] - times[x - 1]);
  }

  Serial.print("xCalc: "); // how long does micros() take?
  m = micros();
  for (int i = 0; i < 1000; i++) {
    micros();
  }
  print_after();

  // ------------------------------------- 0 to 40
  for (n = 0; n <= 40; n++) {
    p("%2lu: ", n);
    m = micros();
    delayUsecs(n);
    print_after();
  }
  Serial.println("---------------------");
  for (n = 1; n <= 9; n++) {
    unsigned long x = n * 10;
    p("%2lu: ", x);
    m = micros();
    delayUsecs(x);
    print_after();
  }
  Serial.println("---------------------");
  for (n = 1; n <= 9; n++) {
    unsigned long x = n * 100;
    p("%2lu: ", x);
    m = micros();
    delayUsecs(x);
    print_after();
  }
  Serial.println("---------------------");
  for (n = 1; n <= 9; n++) {
    unsigned long x = n * 1000;
    p("%2lu: ", x);
    m = micros();
    delayUsecs(x);
    print_after();
  }
  Serial.println("---------------------");
  for (n = 1; n <= 9; n++) {
    unsigned long x = n * 10000;
    p("%2lu: ", x);
    m = micros();
    delayUsecs(x);
    print_after();
  }
  Serial.println("---------------------");
  for (n = 1; n <= 9; n++) {
    unsigned long x = n * 100000;
    p("%2lu: ", x);
    m = micros();
    delayUsecs(x);
    print_after();
  }

  Serial.println("---------------------");
  Serial.print("       200: ");
  m = micros();
  delayUsecs(200);
  print_after();

  Serial.print("     2,000: ");
  m = micros();
  delayUsecs(2000);
  print_after();

  Serial.print("    20,000: ");
  m = micros();
  delayUsecs(20000);
  print_after();

  Serial.print("   200,000: ");
  m = micros();
  delayUsecs(200000);
  print_after();

  Serial.print(" 2,000,000: ");
  m = micros();
  delayUsecs(2000000);
  print_after();

  Serial.print("20,000,000: ");
  m = micros();
  delayUsecs(20000000);
  print_after();
}

void loop() {
}

```


thx


нужно проверить наличие категории, так как у тебя в миграции null: false


for development fixate number of shards


In Java, `time()` isn't implemented in `Realtime` at all, but it is inherited from the `Rest.time()` method, which is blocking and synchronous in the same way as for all the rest methods.


Adding Sarah's changes.


IMO the appropriate place to implement this logic is on the server side schema endpoint, which is intended to deliver the desired columns in the desired order to the client, which should accept them without modifying them. I will implement that, and then this client-side code should be unnecessary.


Can we remove the c++11 dep? I don't want users to have to upgrade their gcc.


Используй rails method
```ruby
truncate
```


No, it's inside a function, even though it's on a single line (maybe it would have been clearer if I hadn't put it on a single line however)


you're seeing early feedback )


My feeling is that generally in the realtime interface, the call now and respond later is the better paradigm. If that is counterintuitive to the language being implemented then fine, but mixing both callbacks/events and synchronous calls in the same class just seems odd, to me at least


Currently it does not support the GA-Z77X-D3H motherboard. I am currently rewriting the script quite a bit, and once I complete it I'll readd support for the GA-Z77X-D3H as well as the GA-Z77X-UD3H.


Any plans to make a new packaged release? This bug seems like a blocker.


Will cherry-pick; thanks for the feedback.


@tremainebuchanan- after the update try reloading the page so it disappears from the opening transaction listing.


I think this is a "can" because we don't want a normative keyword in two places.


Why do you recreate the keg object here? Why not just use `oldkeg` direclty.


I believe the consensus was that SHOULD use Alt-Used when using the alt-service. Thus the mitigation isn't not to send Alt-Used, but not to go to the alt service in the first place.


kangDroid install SU and works :) Settings need authorization on boot.


also add testParallelKillFetchContenxt() test


oh wait, this is even more confusing than it looked initially. You can generate your own certificates for your xmpp server, you do not need to deploy dnssec (which is the whole point) but you need to deploy your https server with certificates obtained from a CA. How about:
```
... an operator can generate its own certificates for the XMPP server but needs
to have HTTPS deployed with certificates obtained from a certification authority.
DNS security is not required.
```


@xenigmax Is it ```:dox:`BamIndex#jumpToRegion```` or  ```:dox:`BamFileIn#jumpToRegion````? This seems to break our manual...


Looks like there have been some changes, please update the commit message.


Correction: BASIC also apparently works fine - it will display a prompt after receiving a LF on serial line


Fix #20 保存最近方案


You are right. The main function was intended for debugging purposes only and I simply forgot to delete it before committing. In short: there is no harm in removing it.


Seems great!


Fixed in #1117.


Also, are you using `PATCH` or `PUT` as the update method?


Thank you for adding these comments to show which methods are called from the templates! :+1:


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/221fc240832f5cfe86459e7f6f3040a516a040e2/index.html)


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/e753a1188168f5d0e3b09ab7f4ad11f451d30193/index.html)


no in query-refactoring it's much simpler, only two levels, so I guess this is fine as-is. Thanks for the explanation.


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/0.4.0/index.html)


Nit: Could we move this method out of this scope and make it private? Just makes the actual logic this function performs more readable below


Noted @matjames007 . Those enhancements I was gonna focus on when I sit with @paradoxxjm today and walk through the feature so that if there are more, I can do them all one time.


Can you move the `)` down? I dunno why it's this way in the first place.


it is good job to separate the dev host and prod host.


Can we only use PixbufAnimation for .gifs and Pixbuf for other images? I'm worried it will allocate more memory


Как понятно из коммента к коммиту "intermediate comit for start page" это просто промеждуточны был соммит, чтобы seed.rb попал в гит, понятно, что исправлю


Thank you very much! I intend to thank/attribute all people who provided
support and awesome kit in the readme, I"m just getting started.

Are you participating in js13k this year?

On Friday, August 14, 2015, Florent Cailhol <notifications@github.com>
wrote:

> Hi, I'm the author of this module.
> FYI I've written a shorter version for the random function:
>
> function random() {
>     var x = Math.sin(.8765111159592828 + seed++) * 1e4
>     return x - Math.floor(x)
>   }
>
> I though you'll like it!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Rybar/js13k_2015/commit/a635effba2e7b13fdecd615a49de31cf88f61f97#commitcomment-12707152>
> .
>


We should update https://github.com/google/google-api-python-client/blob/master/googleapiclient/model.py#L319 too.


Hey Fleexy! Have you considered using github.io for easier previewing online?


Nit: This reads a bit weird - can we flip it so it's self.tabs.insert()... > 0


Was meintest du mit Expandierung des Asterisks?


Oops. That was a mistake.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.491](http://teamcity.monogame.net/viewLog.html?buildId=9631&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Ah oui, je dois mettre un 'or' du coup à la place


This should have been part of the next commit.


Funny, I just copied the example directly from the drupal docs. But searching again those docs have disappeared and I can't find an updated reference of how to accomplish this in D8.
If this is a blocker for D8 integration development/testing just delete this function from `CRM/Utils/System/Drupal8.php` and it will fall-back to the base class generic method.


totally reasonable -- i'd say file an issue on that repo. (or send a PR! :wink:)


Hum bah tu vois... euhhhh j'étais emballé et je voulais me faire une fonction printPath et puis je ne me suis même pas rendu compte qu'elle ne faisait qu'une ligne xD


I feel like this should default to the gradle build dir instead
```groovy
model.classpath.conventionMapping.defaultOutputDir = project.buildDir
```
it seem non-intuitive that gradle would configure the 2 build paths to be separate. If I'm working on the command line, I would expect my build to go to the same location as when I'm working in the IDE.


It would be good to explain what is being prepared here! Also the other public methods in this PR should have JavaDoc as well to explain the purpose of the method. That makes it a lot easier to understand the flow of the code, because the JavaDocs can explain which methods depend on each other and the sequence they are called.


I love seeing all of this hard coded HTML being deleted!


I'd like to see a McGinnis-based round of questioning at the next event please.


This should also solve fix issue #21, as setting maxLogItems to one would clear the previous messages.

```javascript
alertify.set({ maxLogItems: 1 });
```


petits canvis


Would there be anything wrong with replacing zero by one instead of filtering out zero? We have one, but is one guaranteed to be positive?

Otherwise, LGTM!


@btovar this would be a good one to backport to the 5.1 line I think.


Du coup je dois faire:
```python
if AfficheChemins(tree.LeftChild, path):
    return True
if AfficheChemins(tree.RightChild, path):
    return True
```
mais dans le cas où c'est False, je vois pas du coup où le mettre.. à la fin, mais c'est quand la fin xD ?


@horton1 @mbougie updated split_datacases.py for polygon averaging over a site


Please use @Override when possible.


Have you verified that data throughput is handled correctly? Just wondering...


YAY :+1:


I'm using POST, since the data is sent over using jquery-ajax, which only supports get and post.


@nicday Can you add the Godeps' workspace to `.gitignore`?


I really like this! Good work


Here's an archived version of the docs I was copying from (probably those will disappear soon also as the deprecated function seems to have now been removed from D8):
http://api.drupalecommerce.org/api/drupal/drupal!core!includes!bootstrap.inc/function/drupal_add_http_header/8.x


![Trebek you, man](http://media.giphy.com/media/cLmFVhmeMLJew/giphy.gif)


This looks pretty good already! Could you please:

- re-wrap at 76 columns/line, and
- add your [sign-off](https://github.com/git/git/blob/v2.4.6/Documentation/SubmittingPatches#L234-L286)

Once that is done, I will gladly merge it!


Sequence numbers are inverted lock times.


Actually, this imposes the restriction that both minor and patch versions are present.
The expansion ought to be optional for both minor and patch.


Do we want to test whether `vendor/cache` exists?


This is the most recent D8 reference for this I can find, but I don't see how it's saying anything different:
https://www.drupal.org/node/2181523


:tada:


This discussion isn't sufficiently visible from issue #756, maybe this comment adds to that?


Indentation?


I do think that 5 KB might be a bit small for batch size; however, I do not think that increasing the setting by a factor of 10 simply to eliminate the warnings is a good idea.


I guess the argument would be how do we differentiate at the call site if it was inserted or not. Do we rely on the returned row ID else where? Might be dangerous to assume all dependent code properly handles the 0 case.


CAAAAAAAARRRRRDDDDDDDSSSSSSSSS!!!!!!!!!


no need to use var here, just use `bundleItems := []*hsproto...{}`


@shrikeh

Nice!


Ha, what about this?


Indentation looks a little weird in this whole file?


:cry:


Yeah - this is always a bit of a disaster with scalacheck. Specifically, the minute you use something in a List (eg `Gen.listOf`), then your probability of success goes from `p` to `p^n`, so even when you have a small chance of failure, you can easily get scalacheck to bail. The other problem is that scalacheck generates 0s a LOT more than pretty much any other number, so even just filtering out the zero could still cause issues. I think @rklaehn idea may be nice too (0 -> 1), since we have a `Ring` afterall...


Indentation in this file looks funny too!


Also - the update may actually be creating more objects in the DB (movements and attachments) which will have a URLs decided by the DB. So doesn't that make the POST method somewhat more appropriate?

The creation/updating is not restfull in the sense that if I POST a new piece, it will create any associated objects based on that one request... It doesn't send a cascade of new POST requests to /movements/ and /attachments/.


Now matches all of:

* 4
* 4.1
* 4.10
* 4.10.0
* 4.10.0.9

And so on.


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


nit. Unnecessary new line


Il me semble surtout que tu dois mettre la condition sur le fils gauche et puis faire afficheChemin sur le fils gauche, puis faire la condition sur le fils droit et faire afficheChemin sur le fils droit.


I think jQuery supports PATCH:

http://stackoverflow.com/a/13656568


Overall, this looks really good @rmacor! It could use a little more JavaDoc to explain the integration with Freemarker, but this is a huge step forward for RadarGun reporting. Thanks!


<img src="http://i.giphy.com/TsD8LGhM5jgs0.gif"/>


not 100% sure, but think you can just do `result := hsproto.PegasusUtil_PurchaseWithGoldResponse_PR_SUCCESS`


Also, could we still do the `filter` after the map? Specifically, `Int.MinValue` will be generated here, which is no good.


`::` is meant for pseudo elements (`::before`, `::after`), not pseudo classes (`:hover`, `:active`).


To be consistent with the errors above lets drop the period in the message string. You'll have to update your unit test too.


par exemple. :)

Sinon effectivement, dans sommeChemin, tu fais appel à afficheChemin... Ça sent le vilain copier-coller des familles ça !


POSTing a new piece is fine; I was thinking specifically about the `/update` bit...


```
design:
  bg_color: "#3071BE"
  image: https://cdn.auth0.com/blog/mfa/logo_ga.svg
  image_size: "70%"
  image_bg: "#3071BE"
```


Thanks a lot for this work!. When I try to run the exec binary produced, I get the following error. Note this is on OS X (I want to make it run on OS X).

Do you have any idea what is going on? Thanks a lot in advance.

If it helps, nm e34908c1bf4e1be2c3bc98537430b5dd.so |grep _PyCObject_Type
gives U _PyCObject_Type
------------------------

dyld: Symbol not found: _PyCObject_Type

  Referenced from: /Users/ajain/.theano/compiledir_Darwin-15.0.0-x86_64-i386-64bit-i386-2.7.10-64/tmpTNtZV3/e34908c1bf4e1be2c3bc98537430b5dd.so

  Expected in: flat namespace

 in /Users/ajain/.theano/compiledir_Darwin-15.0.0-x86_64-i386-64bit-i386-2.7.10-64/tmpTNtZV3/e34908c1bf4e1be2c3bc98537430b5dd.so

Trace/BPT trap: 5

------------------------


Struggled, but finally switching to full AngularJS to handle the MVC. From now on, jQuery should only be used for animations.


Thanks. I'll cherry pick your fix when I get home from work.

- Jm


HURRA!!


Nit: Missing doc string.


in general, don't use empty lines after opening a block


I'll just wrap it once at 80 then. There's at least 4 different wrapping styles used in this file so it hardly matters..


also no empty lines before closing the block


same thing here with the empty lines


this should be unchanged


It will be better to listen to the item ready instead of waiting for a "random" number : oat-sa/extension-tao-itemqti#366 will help providing a proper way to listen to mathjax typesetting readiness


Hmm nice. I'll try this later today.


do put an empty line before the return here to stay consistent


no empty line here to stay consistent with the rest of the `return EncodeUtilResponse(...)` instances


FusionGraph auto-fitting after any signal change was introduced here. What about it?


Swap order of LICENSE and COPYRIGHT and put them below HOMEPAGE.


Get rid of the if/fi block and put `!x86_gcc2` in `ARCHITECTURES`, this isn't needed anymore.


Should also have $portVersion and possibly `compat` if symlinks are made.


Get rid of this blank line.


And this one.


Why have you made these variables non-constant?


This belongs right under `CHECKSUM_SHA256`.


Ah - that's how to enable it.

The fact that a request from `/update/` could be creating new objects or deleting existing objects doesn't make a POST more appropriate?


These go between `PROVIDES/REQUIRES` and `BUILD_REQUIRES/BUILDPREREQUIRES`.


This comment belongs right above the `cmake .` line.


@clowwindy PLEASE DON'T using c# 6.0 feature! only VS2015 support it! VS2013 user can't build it.


Useless comment.


s/这个页面/本文/


这个链接不存在，直接删除掉？


Just to validate development ... I'll remove it.


@clowwindy  like [timer?.Dispose();]


:tada:


TeamCity pull requests :: netty [Build 33](https://garage.netty.io/teamcity/viewLog.html?buildId=343&buildTypeId=pulls_netty&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.491](http://teamcity.monogame.net/viewLog.html?buildId=9631&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:24:24


simpler? `sys.version_info[:2] == (2, 6)`


:beers:


There is nothing with a name of "Stark" in your `houses` collection! 9/10 credit.


@rafalp I think that loader-large should be changed to misago-loader-large. Can you verify this?


![It has begun](http://i.imgur.com/urWFucK.png)


这是一种机制，它通过可调度的线程来执行某些中断的下半部分。这样就可以跟其他线程或进程一样，在同一个调度类里头来做优先级调度。


After Morchok defeating all Twilight Siege Captain(isAlive), all Ancient Water Lord(isAlive) and all Earthen Destroyer and Soldier(isAlive) should movement on defeat point(need coord). Teleport point It depends on which side of the npc spawn. If Morchok left - to the left, if the right - the right.
Creature_linking - this is hack. My script - temporary hack. If i can search teleport movement and teleport simple spell and position for left and right side npc, i deleted hack and implemented for guid npc sorting script.
Remember: Cata - not Wotlk.
On future: Please read full SDComment.


最近（2004 年 7 月），两个补丁被提交到  Linux 内核，用于支持软中断线程。


Again, you're being lazy. :)   String.replace() is a rather pricey thing to do.  Why not just use the same loop of code that is in the CSVRenderer (or, see my comments below about simply modifying the CSV renderer instead)?


Yuck.  Each call to str.contains() is going to completely iterate over the string.  Don't be lazy :)  Use a single loop, grab a character, and check it.   This sounds nit picky, but when you are dumping out 30 million rows, this sort of stuff is actually measurable.


Fantastic!

Crazy idea: what about if we could do `parser.labels['foo'] = 'bar'`?


You don't want to use an alias for configuration.  Aliases are strictly for creating an alias for a command in jsqsh.   For example:

    \alias run='\go'

will allow you to use "run" instead of the go command.  I think what you want instead would be to use variables.   Use SqshContext.getVariableManager() to fetch the manager.


Thanks Ryan!  A few comments and suggestions:

* Can you check your information in AUTHORS to see if you want to update it?
* Since really this is just the CSV renderer but with more configuration, why not just add your changes into the CSV renderer itself?  You could even register the renderer twice under different names (e.g. "csv" and "delim"), but it would save some code duplication.


Line 79 should be moved up to line 77. It got disassociated with its conditional in a previous commit.


I'll admit I'm unsure what debugging scenarios happen where you run into the repr of a middleware class. Also adding things that aren't part of the class (settings) seems questionable.


In the next revision of FCS, you should replace this line by FSharpTokenTag.Identifier.  The "Parser" and "Lexer" modules will be made internal to FSharp.Compiler.Service.dll (they are both much too low level to be exposed as part of the long term FCS API - and alternatives exist using the proper API).


First commit


但是其中 PPC 特定的部分无法打上。

注：后面一部分应该是说这个补丁可以在 2.6.8-mm1 上用，但是补丁中 PPC 特定的部分打不上去。。。


TeamCity pull requests :: netty [Build 34](https://garage.netty.io/teamcity/viewLog.html?buildId=344&buildTypeId=pulls_netty&guest=1) is now running


上面的链接无效，建议删除链接。


这里有一系列将来可以为该功能做的事情。


The sequence order of cached.list will be incorrect when imapUidList > 1. The sequence number is used in updates of type 'expunge' and 'fetch'.


Introduction -> 简介？


样例结果

--> 下面也异同改掉吧。


@gkalpak I don't think so. These examples are demonstrating how to react to both a success and error response.


Å oppdatere denne filen har ingen effekt (vi har den bare innsjekket "til informasjon" når du har en diff lokalt er det for å fortelle deg at det sannsynligvis er en diff mellom det du kjører med og det vi har i containerne som er sjekket inn).

Det som bestemmer hvilke versjoner vi kjører er det som ligger i Docker-containerne - og det oppdateres ved å oppdatere REFRESHED_AT i Dockerfile.


Review Done.


UploadId.


This description is misleading/confusing. Perhaps it should be something like:

    quote - The character used to wrap values containing a delimiter, newline, leading or trailing spaces, or the escape character.  The default is a double quote (")


Unfortunately I didn't write note over this commit. I've put the note on the next commit though, don't worry about that.


Yea SUPER lazy, the replace functionality was because you MIGHT want to
replace the renderer with just more than a Character.  Admittedly that
still could be better but not exactly copy & paste.

On Fri, Aug 14, 2015 at 11:46 AM, Scott Gray <notifications@github.com>
wrote:

> Again, you're being lazy. :) String.replace() is a rather pricey thing to
> do. Why not just use the same loop of code that is in the CSVRenderer (or,
> see my comments below about simply modifying the CSV renderer instead)?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/a0b27e8064e73b849a3a93a36746ea85d5ac5bf2#commitcomment-12713336>
> .
>


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.492](http://teamcity.monogame.net/viewLog.html?buildId=9635&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


From this description, does this mean that newline *has* to be replaced with a literal back-slash n, or is there still the option to leave a newline intact in the data?  Also, I thought I saw code dealing with \r too? Does that need to be mentioned?  Maybe instead this should be a boolean of "escape_newline" or something like that?


Can I do that here? Or should I redirect the route in config/routes.rb ?


Yup.


That doesn't parse anymore.


Why this change?


How do I update and is it important

On 14 August 2015, at 15:19, mziorusso <notifications@github.com> wrote:

XML to XSLT

—
Reply to this email directly or view it on GitHub.￼


You *could* factor out the update processing into JavaScript, where any creation results in a `POST` to the appropriate object endpoint, as you suggest. That would be one way to do it, and would probably result in removing some code from your `piece` update method.

It could get tricky since you would need to wait for the `PATCH` to the piece to complete before `POST`ing to the endpoints since you would need the object itself.


이건 무엇때문에 필요한건가요?


chnaged by me on saturday


Commit isn't signed-off.


:D


Sent a PR.

On Fri, 14 Aug 2015 11:18 am Craig Citro <notifications@github.com> wrote:

> totally reasonable -- i'd say file an issue on that repo. (or send a PR! [image:
> :wink:])
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/protorpc/commit/eb03145a6a7c72ae6cc43867d9635a5b8d8c4545#commitcomment-12712762>
> .
>


Oh, my! I used to delete items from container I have being iterating! So stupid!


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 323](https://teamcity.labkey.org/viewLog.html?buildId=266361&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0 Build time: 00:02:21
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


* SURE!
* Didn't want to modify something that was working and correct.  I like the
idea that csv represented a standard while there was another feature out
there that did something else.

On Fri, Aug 14, 2015 at 11:46 AM, Scott Gray <notifications@github.com>
wrote:

> Thanks Ryan! A few comments and suggestions:
>
>    - Can you check your information in AUTHORS to see if you want to
>    update it?
>    - Since really this is just the CSV renderer but with more
>    configuration, why not just add your changes into the CSV renderer itself?
>    You could even register the renderer twice under different names (e.g.
>    "csv" and "delim"), but it would save some code duplication.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/a0b27e8064e73b849a3a93a36746ea85d5ac5bf2#commitcomment-12713346>
> .
>


No newline at EOF


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 324](https://teamcity.labkey.org/viewLog.html?buildId=266364&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0 Build time: 00:02:21
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


guys this link will help you to make diagram more precisely...
http://www.visual-paradigm.com/VPGallery/diagrams/Sequence.html


TeamCity pull requests :: netty [Build 33](https://garage.netty.io/teamcity/viewLog.html?buildId=343&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 1204, ignored: 10 Build time: 00:16:58
### Failed tests
```
io.netty.handler.codec.http2.DefaultHttp2FrameIOTest.binaryHeadersWithoutPriorityShouldRoundtrip: <no details avaliable>

```


Context.cpp 는 빈 파일인가요? 그리고 main에 관련된 메시지도 수정해야할 것 같네요.


RemoveMoreBadCharacters (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nice.. & Fruity ;]
https://github.com/ZdrowyGosciu/kernel_d802/commit/62d49c62268b431a0eb073e6b34c738fb2ade601


Sorry @domesticmouse , I can't see the difference between the text you suggest and the text in the file


the request from my guy was that it was both configurable on the fly and
sticky, it seemed to be the only way to make that happen.   I did notice
you had SessionObjects which might work but I didn't see them used
anywhere.    I will look again.

On Fri, Aug 14, 2015 at 11:46 AM, Scott Gray <notifications@github.com>
wrote:

> You don't want to use an alias for configuration. Aliases are strictly for
> creating an alias for a command in jsqsh. For example:
>
> \alias run='\go'
>
> will allow you to use "run" instead of the go command. I think what you
> want instead would be to use variables. Use
> SqshContext.getVariableManager() to fetch the manager.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/a0b27e8064e73b849a3a93a36746ea85d5ac5bf2#commitcomment-12713341>
> .
>


the continue bugs the proc, if we remove a fleshy jumpsuit from ourselves then the potential new fleshy jumpsuit will not be added.


Gracias.


Merge this test with `test_warsong_commander`, so you don't use a worgen anymore.


Wrong usage.


It depends on a few things in the environment, so it seems simpler as a closure. But I'll see if I can improve the readability.


better yet it is completely wrong.  I feel quote is overused and should be
"marker"

quote - The character used to wrap values containing a delimiter,
newline, leading or trailing spaces, or the escape character.  The
default is a double quote (")

should be

marker - The character used to wrap values containing a delimiter,
newline, leading or trailing spaces, or the escape character.  The
default is a double quote (")

On Fri, Aug 14, 2015 at 11:51 AM, Scott Gray <notifications@github.com>
wrote:

> This description is misleading/confusing. Perhaps it should be something
> like:
>
> quote - The character used to wrap values containing a delimiter, newline, leading or trailing spaces, or the escape character.  The default is a double quote (")
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/2fafa37e8db2b068a3ba228c90f2e66fcfff348b#commitcomment-12713447>
> .
>


A few comments:

* these APIs should require API v14, see https://github.com/rundeck/rundeck/blob/development/rundeckapp/grails-app/controllers/rundeck/controllers/ScheduledExecutionController.groovy#L2914

* The response for the API endpoints should support JSON.  I see you are returning the Job xml/yaml.. instead maybe a simple success/failure.

* `apiService.renderErrorFormat` should be used to handle XML or JSON error response

* `scheduledExecutionService._doupdate` is not really necessary, since you are only toggling the boolean value.  The action should simple switch the boolean value, then interact with the scheduler as necessary I think


I like the ability prefex instead of feature. But it's more appropriate to use feature since here, in Enova a feature is the
"ability" by which a user, an app can function.


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1799 of 1803 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


:+1:  !!


ItemStacks are mutable. The issue stems from a conversation with @bloodmc about forcing an update on the client's inventory. Reasoning: When you modify an `ItemStack`, you'd expect the changes to be "updated" to the client without you having to do anything. The problem is within that chain of events:
```java
final ItemStack myStack = player.getItemInHand();
myStack.offer(Keys.DISPLAY_NAME, Texts.of("foo"));
```
At which point the `ItemStack` is NOT updated on the client until the client either performs one of the following: 1) right clicks with the `ItemStack`, 2) Another source of inventory changes occurs, 3) the client logs out and logs back in.

With Bukkit, there was a nasty deprecated `player.updateInventory()` method that would resolve this, such that after you've made multiple changes, you would update the inventory on the client.

What  we ended up deciding on was to start requiring a similar technique of Data API to help alleviate the issue: return copies on getters, force the use of "offering" or "setting" back. The advantage now here is that multiple people can't obtain the same instance of an `ItemStack`, and we achieve forceful synchronization at minimal cost.

I'm sure we'll have more of a discussion when @Mumfrey and some of the other developers have a sit down and chat about it.


@mosra You may want to look at this WIP commit, is this more to your liking? Tests currently all fail. I'm getting random data, probably did something wrong in `ImageData*D` construction, I'll figure it out ;)


Nice! Thanks!


password = ""


Still horrible, but slightly more readable.


oh! the requiredFile should not use wildcard!


Har fikset i f65cd8835325960eebe5ad9f6a36a90dff8e1076 (for nå fikk jeg diff i min Gemfile.lock).


@Myoldmopar Could also use cAlphaFieldNames(7) instead of the literal string.


Context.cpp 파일 맨 끝에 줄바꿈이 빠졌네요:)


Why do not just call list::clear() ???


Some of that code is already there... When the user clicks submit, JavaScript scans through the page and pushes changes to arrays `changes['modify'], changes['add'], changes['delete']`.

What happens after is it tacks `changes` onto a `FormData('#create-piece-form'). The advantage of this was that I could re-use the form-validation for creating pieces, the file uploading code, the code for handling lists of objects to be found/created.

So - the reason updating got added in 4 days, and the reason I'm hesitant to change the request type, is because the updating feature is using a *ton* of code from the uploading feature - which was all done in a POST request.


And refactor ;P


Understood. And I would definitely do what the current practice is. That said, I would try to gently start getting people to look at the distinction between ability and feature. It really does matter and it's a large reason why tools like Gherkin were modified to accept not just "Ability" but also "Business Need" as the top level keyword. This is also a case where developers tend to think differently than business analysts and testers. And Gherkin and Cucumber were written by developers. :)


Could you post a link to the code?


RemoveItem calls ItemDeleted()


o json não utiliza o prefixo ?

Exemplo `/contas.json` ?
http://book.cakephp.org/2.0/en/views/json-and-xml-views.html#enabling-data-views-in-your-application

Por que é necessário o uso do compact ?


Which code?


Looks like getEstimates is old and not being used


That makes sense. Sweet!


Yea, but Clear calls Cleared()


The `FormData` bit. And maybe the piece upload server bit too.


I was wondering about this...


this is what fedora makes crash... atm its a test if it works on fedora


Maybe this should be `"CatchClause"`?


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


how on earth did this pass the unit tests?


Oh, ok. Atm it is still crashing for me...


Very well


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 325](https://teamcity.labkey.org/viewLog.html?buildId=266390&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0 Build time: 00:02:16
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


stacktrace?


wwdqweqw


no me sale nada!!1


asdasd


`step()` is not tested


css文件待优化


This one I have no excuse for myself, I can argue the other decisions I
made but I was just being lazy.  Actually I was thinking a regex pattern
might be more feature rich (and certainly quicker than the replaces)  Ill
have to do a little test this weekend and see how much faster.

On Fri, Aug 14, 2015 at 11:46 AM, Scott Gray <notifications@github.com>
wrote:

> Yuck. Each call to str.contains() is going to completely iterate over the
> string. Don't be lazy :) Use a single loop, grab a character, and check it.
> This sounds nit picky, but when you are dumping out 30 million rows, this
> sort of stuff is actually measurable.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/a0b27e8064e73b849a3a93a36746ea85d5ac5bf2#commitcomment-12713337>
> .
>


Oh I see. thanks


We could return -1 here instead.

The thing I was going for is: this function returns an integer, and it's currently a row ID. That's kinda dodgy in and of itself (particularly around transactions), but so it goes.

But there are two failure cases that callers care about: an error occurred or no row was inserted. That might be -1 and 0, or we might make them both -1, or we might declare that callers don't get to know.


Yes of course! I was quite busy last year and hadn't enough time to finish
my composition... I hope this year I will be able to present a game! You
don't need to credit myself for the code since it is published under MIT
license.

--
Florent Cailhol


The same as I posted before - crash in UpdateMinimap()


Oh, yeah, I think so.  Looking at example-cpp I don't see anything C++11-specific.  Sorry, not sure why I ever added that in the first place.  :(


There are only four places that care:
```
ReadingList/ReadingListSQLStorage.swift
86:        let (id, statement) = items.insert(ItemColumns.ClientLastModified <- ReadingListNow(), ItemColumns.Url <- url, ItemColumns.Title <- title, ItemColumns.AddedBy <- addedBy)

Storage/SQL/FaviconsTable.swift
82:        let id = self.insert(db, item: obj, err: &err)

Storage/SQL/SQLiteRemoteClientsAndTabs.swift
130:                    let inserted = self.clients.insert(connection, item: client, err: &err)

Storage/SQL/SQLiteRemoteClientsAndTabs.swift
315:                    var commandID = self.commands.insert(connection, item: command.withClientGUID(client.guid), err: &err)
```


Nice job @gaearon and @acdlite !


ticket number please...


addresses #48 and #47


Nitpicky stuff, but couple little css things I noticed during the demo.


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (755 of 755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.3%25-green.svg)


this block is only executed if !chosen_prof.exists_list[slot], so there wouldnt be a new fleshy jumpsuit there anyway.

if there is a fleshy jumpsuit in the new profile and we're currently wearing one, there's no need to delete the original one as we can just set its variables to look like the new one.


missed a newline


same


ItemStack itself is an absolute mess and NEVER should have been mutable. We should be offering data back and should be dealing with copies. In doing so, we never have worries about developers knowing to "call some update method" to fix this.

If we do immutable stacks from the get go, we fix a hell of a lot of future issues.


Not sure why we need a copy, except for function handling.
For that, we can just change the value of the passed data.


In the future, we may want to make a catch-all method that adds content to a section for /any/ type of content - ex. the Formatter::Base class could implement an ``add_content(section, content, type)`` function where ``type`` would specify the type of content being added (ex. ``"html"``, ``"text"``, ``"irc"``).


Fix #9


EOL fix is needed


How's this?  (git push --force ftw!  ;))


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.493](http://teamcity.monogame.net/viewLog.html?buildId=9639&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.492](http://teamcity.monogame.net/viewLog.html?buildId=9635&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:24:47


nit : form.hidden = true; (I used display: none for some reason, even though it wasn't needed)


EOL Fix is needed


Can you please look into why this doesn’t produce an error message on Ruby 1.8?


Sorry, it was by mistake. It's added again.


Sure.

The JS for update page is here.
https://github.com/ELVIS-Project/elvis-database/blob/master/elvis/static/js/template-scripts/piece-update.js
`findChanges()` on 490 scans all the inputs and fills the `changes` object.
The ` $("#new-piece-form").submit` listener on 193 is where `changes` is appended to the `FormData` (203).

The uploading is pretty arduous - I'll try to sum up.
https://github.com/ELVIS-Project/elvis-database/blob/master/elvis/views/views.py
`handle_dynamic_file_table` on 199 finds all the new movements that were put into a movement table. It gets new movement info from request.POST, and loops through all the movements to be created. On each loop, it also finds any files in the file table to attach to the movement, and sends those to `handle_attachments`.
`handle_attachments()` on 154 creates the attachment object, links it to it's parent, and calls `upload_files()` on 73.

Because I wrote the updating JS to name the inputs for existing files/movements differently than new ones, I can just call `handle_dynamic_file_table` after the update request is sent in, and it will create all the new movements/attachments and upload, rename, and hash the files.


the indentation treatment isn't needed for JSFiddle, as we're not including `body` or `html` in the submitted code


Yes, the problem was this method was computing the status but the caller was updating the status tables.


Como ser haker


Why is the double negation needed ?


Would be nice, yes. I know there's  `__setitem__(self, key, value)` to usually implement this, but I have no idea if it can be somehow combined with the property.setter. Have you ?


I think our major problem would be running lots of separate browser
processes. It would be really great to use multiple sandboxed browser
profiles running under the same browser process instead, but that's
something the test runner would have to understand.
Thanks for the pointer!

On Fri, Aug 14, 2015 at 1:01 AM Dieter Adriaenssens <
notifications@github.com> wrote:

> Maybe an idea to reduce your build time : Stripe runs three hours of Ruby
> tests in under three minutes by splitting the tests over multiple workers :
> https://stripe.com/blog/distributed-ruby-testing
>
> 2015-08-12 9:56 GMT+02:00 Dieter Adriaenssens <
> dieter.adriaenssens@gmail.com
> >:
>
> > Hi Alex,
> >
> > What I did to get to builds 7129 :
> >
> > - set timeframe to month (button on top left corner of dashboard)
> > - set some filters in the build job duration chart (chart on the right on
> > the second row) :
> > - build matrix : dart, stable
> > - result : passed
> > - build_trigger : push
> > - On the chart you will see jump in the buildtimes, if you hover over the
> > columns, you can see the corresponding buildnumber
> > - With the travis api query (see above), I found the corresponding build
> > id on the travis website
> >
> > For builds 7112 and 7145 :
> >
> > - the same procedure as above, but with filter on build_trigger =
> > pull_request (all other filters are the same)
> >
> >
> >
>
>
> --
> Kind regards,
>
> Dieter Adriaenssens
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angular/angular/commit/30bd2a3fc72f8f1cdb0ffc4b9d11b4ca42e9ece7#commitcomment-12705576>
> .
>


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2192 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.16%25-yellow.svg)


Are multi-files gists supported ? Or will this submit a gist per file ?


This comment can be removed.


Not sure if "Public" is still relevant here.
Maybe Github Gist ? or simply Gist ?


I'm getting different test output for this and I can't make out why. I'm assuming you generated this with ICU and the latest glyph measuring so I would have expected the same results. My output is at f4f79ec if you want to have a look.


@krand7, is this section intentionally being hidden?


This sentence can be confusing since the user may think the addon automatically exports gists, also, this setting isn't specific to the prototype.
For the formulation, maybe "Make exported Gists public"


hi @hadley

Would it be a good idea to rename all those `p` to `l`, for layers? To me `p` sounds like the whole plot rather than a single layer so I'm constantly translating to `l` when I read this code.


:ghost:


can't wait to read this


Just want to give a big thank you for this commit. Saved me from building this logic into my app. :+1:


Try it now; as of 8d916e2 it should work for you.


Yes, that's better.


I think you can remove this link for IDatabase


The only way I can imagine it would work (pygit2 does something similar with remotes I think) is that the `labels` getter returns an object that can behave like a dict but with `__setitem__()` doing the modification.

However, it would mean that this would actually modify the label:
```
labels = parser.labels
labels['foo'] = 'bar'
```

so it depends whether we want that.


TeamCity pull requests :: netty [Build 34](https://garage.netty.io/teamcity/viewLog.html?buildId=344&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 3517, ignored: 6 Build time: 00:45:33


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


The result does go into target, and it also goes into `this.title`.
What exactly is the problem with this?


Please keep the open parenthesis at the end of the first line - otherwise it is not obvious that this is actually a function call.

Same below and for Connext.


Do you mean just using `offsets[row + 1]` for the right endpoint? Then we still need a separate codepath for the last row, which is why I extracted `len` above. Alternatively we could keep two arrays of start and end offsets, just like the protobuf message impl does, but I wanted to avoid that overhead since the arrays would be identical except for the first start offset and the last end offset.


Loader large is fine, it was ".loader" that clashed with DjDt's css.


did the removed asserts fail?


Not really.
It returns false to disable the timer.
On open() it doesn't matter.


```patch
         run_in_thread(self.ioctx.librados.rados_omap_get_next,
                       (self.ctx, pointer(self.key), pointer(self.value),
                        pointer(self.lens)))
-        if isinstance(self.value.value, str):
-            self.value.value = self.value.value[0:self.lens.value]
-        else:
+        if self.key.value is None and self.value.value is None:
             raise StopIteration()
+        if self.lens.value:
+            self.value.value = self.value.value[0:self.lens.value]
         return OmapItem(self.key.value, self.value.value, self.lens.value)
```

- there is chance we are only getting the keys here. so should not raise `StopIteration` when `self.value.value is None`.
- to check `self.lens.value`  is simpler, imho.


Thanks for throwing these in! It hadn't occurred to me to add these while I was in the code.


No, but in release ContainsItem check will not happen


@dunn Many thanks for this package!  Awesome thing 😍


Nope.
I'm already scheduling it again with a re-calculated timeout.
If I return true I would end up with multiple timers.


thats the purpose of asserts...


```patch
         iter, ret = self.ioctx.get_omap_vals_by_keys(read_op,("1",))
         self.ioctx.operate_read_op(read_op,"hw")
-        pair = iter.next()
-        eq(pair.key, None)
-        eq(pair.value, None)
+        assert_raises(StopIteration, iter.next)
         self.ioctx.release_read_op(read_op)
```

@chenji-kael would be ideal if you could run the test locally.


Imo that check must present all the time


Will do.
I will release 5.2 next Monday morning.


Sure


I think)) But you are right, assert is usefull too. I will back them


Thanks for mentioning. Will add. Cheers!


Done in #347


DeprecateRunScriptOnLinux (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


imo adding the same item to the list is a logical error, the same for removing the same item twice... silently handling this here allows broken code.


Also - I just broke something on the live website while re-factoring the `date_of_composition` and `date_of_composition2` field you were talking about the other day... So, don't try to look at any of this in action.


The transformation function should not have side effects. It converts the page number to the appropriate title. The title property is set by gobject's internal code.

If we had used something like
```Vala
notebook.notify["page"].connect(() => {
    // set the title
});
```
you would be right, but we are binding 2 properties and they are set automatically.


fsfd


I agree.


when keeping this, at least a wxLogWarning should be added


Somehow the egrep conflicts here and the command is not working...
Need to refactor this


The attempt to comment out polyfills in the README.md is not actually hiding it in the github readme output.


Yeah, but I'd rather not mess with the protobuf definitions until I get this whole zero-copy story straightened out.


@promactkaran are you getting errors running this sample code, or something that you are writing on your own?
If you are running the sample, [BridgingHeader.h](https://github.com/googlesamples/google-services/blob/master/ios/gcm/GcmExampleSwift/BridgingHeader.h) contains all the import you need, and I cannot reproduce your issue.


oh wow


why not less redundant:

```cmake
if(APPLE)
	set(link_flag "-undefined,error")
else()
	set(link_flag "--no-undefined")
endif()
set_target_properties("${target_name}" PROPERTIES LINK_FLAGS "-Wl,${link_flag}")
```


I made `insert` return an optional.


initCommit


I'm going to review this by annotating the commit. But in the future would be much easier on a PR :)


This is a complete nit pick, but I would prefer to see refactoring  in a separate commit, where possible (when not directly related to the commits changes). I've begun to adopt what I think is your approach to PR review, namely, to review each commit separately (as opposed to diving into them all at once, which I used to do) and seeing functionally distinct commits makes review easier. I'm referring here of course to the refactoring of `Parameters` to `Configuration`, use of generics therein, as well as static `doLookup()`. Again, I realize this is a nit, but I think you subscribe to this notion as well.


The problem here is that we have to change two places in this file to change the version of the package that we distributed.

All you need to do is put the RPM file names before the download location variables and use them in the URLs, like at the end of your snippet there.


I'm not sure MD5 is a good example. Maybe better something that does some IO, e.g. writes a file to disk or reads/writes to a socket?


Nope, my Y spacing is still tighter than yours. That commit brought yours down a little but not to the level mine is coming up with.


It's missing a tab to align to the line below


Initial git setup for linux version of mu Multi API APK Kitchen...


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.493](http://teamcity.monogame.net/viewLog.html?buildId=9639&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:28:32


1. Regular user url is of the format http://gympp.com/people/username1, for trainers we need urls like  http://gympp.com/trainer/username2. So lets use the original method user() for regular user and using routes.php use method trainer() for trainers. We may still want to make the check for proper user type.

2. Use class User for checking user_type instead of making another class.
3. Make class constants for association/education/certifications and use them instead of strings.
4. According to current logic trainer can have either certification or association but according to our requirement trainer can have both of them at a time.
5. use getTrainerEducation() only once and do array manipulations in controller to get the details.
6. Format the code with 4 spaces, '{' on new line, space after comma in method arguments and 1 space after if/else.

Rest looks good to me for now.


`apt-get` is not what's getting updated. `apt-get` is updating its local database. On a related note, you probably don't have to be that verbose with messages anyway.


This is not necessarily true, and is a common misconception about async APIs (in fact there has been a thread today on vertx googlegroup where a user confuses threads and async). Async APIs do not require extra threads. Vert.x is almost entirely async, and (unless you're using workers) everything is done on a single thread (the event loop).


this code is bad


wut commit title


Hm, yeah, that looks right.  I guess I presumptiously based my findings on the fact this error occurred in the 4.x kernels and not the 3.x ones.  Thanks for setting me straight.


Again, there's no requirement for a new thread or executor service. Async and threading are orthogonal concepts.


Nice work! This patch works for me!


Yes, definitely. I don't know what I was thinking when I wrote this code because I also find the variable names incredibly confusing.  (Also this commit is broken so I reverted it, but I'll be working on it again next week)


Again, I don't think it's helpful to use threads here.


This is not true. worker threads are only used for executing blocking actions, in normal use, no worker threads are used for invoking callbacks. only the event loop is used.


Thanks, I had something similar in mind, but that no longer looks as elegant as your original suggestion, so it's IMHO not worth implementing.


Setting the `android:textColor` in the `AppTheme` will correctly propagate to all of your `TextView`s.

But as the assignment says:
> Create a brand new style for your Hello, world! TextView and apply it in XML.

This was more about defining a separate style for the `TextView` and apply it in code with `style=@styles/MyTextViewStyle`


That was a failed attempt at rebasign


Why RefTimeSeries is not a proxy model?


Actually, thinking about this now, I don't think we need this. While the docs can be improved in general, the encoding param is optional and correctly documented.


Fair enough.

I think it needs to compare the new set of labels with the set being replaced, and raise `NotImplementedException` if the new set has a different entries to the replaced set -- i.e. we don't support adding or removing labels.

It would also be good if could only modify labels that have actually changed. That way we won't inadvertently modify the quoting style of unrelated labels.


and `dlapply()` could be renamed into a ronronnant `by_layer()` ;)


:+1: this really is great news for servers with no fixed worldborder! (I hope I can increase our server's render distance a bit now)


No es por eso, me volvió a pasar :(


What do you think of this as a solution? https://github.com/bigfont/BigFont/blob/master/BigFont.MVC/Classes/NuHtmlHelper.cs


@chenji-kael lens is the way we describe the length of "value". so i guess we can dispense with it? or we can use a tuple directly instead of creating a new type `OmapItem`?


could use mktemp for this files, so we don't rely on a fixed/hardcoded file path.


101242918_EvapCndPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@bqpd Can I go through and change this everywhere or is it already in a PR somewhere?


Oops, that wasn’t supposed to go in this commit… oh well, good riddance. Should never have been committed in the first place.


(I went to update it in the docs but realized it hasn't actually been implemented yet)


make sure to check if git-hub is installed before calling it and nicely failing...


RemoveMoreBadCharacters (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


dejemos esto sin acentos, prefiero no poner caracteres especiales en css y nombres de variables =)


aqui lo mismo, sin caracteres especiales =)


idem


besides the two comments the patch LGTM.


As long as all data was ASCII, the bug wouldn't have manifested. I didn't find it from buggy behavior, the code just caught my eye.


I'm nitpicking here but I feel it would be better if this was extracted to a private method.

And maybe inject the builder as dependency?  but that's just throwing ideas around, may be inadequate in this case.


metavar='MODE'


En estos condicionales.... creo que falta que uno sea `>=` o `<=` ... porque sino, que pasa cuando numbers[i] es == a P ? tal vez ahi se atora todo


do we really need to add `key`,`value`,`lens` as member variables?


I took 50 because it is the default (and effective value in embedded c*) for `batch_size_fail_threshold_in_kb`. I somehow miss the reason why need two distinct values for warnings and errors.

Anyway, 20 KB would be enough too to eliminate the warnings. Does that sound better?


101242918_EvapCndPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


IMO the main issue with this article is it mixes and confuses two different things:

1. async APIs. Async APIs don't require extra threads and aren't about executing blocking operations. In normal use a vert.x verticle will use just one thread and nothing blocks.
2. executing blocking operations.


`/etc/iptables/*.v6` wird bei der Ausführung nicht zu `/etc/iptables/rules.v6` umgewandelt.


[OT] would be ideal if we can have context manager for `*_op`. it's tedious to release it manually after done with it.


Remet `JNIEXPORT` à la place de `__attribute__((visibility("default")))`


I think it has?


Voilà l'appel de seek :-)


With Rust 1.2 it compiles without this extra inference hint. Did you add this line because the inference becomes less powerful in this context with the next Rust version?


You can use `models.CollectionPermission.DoesNotExist`


@Zidane We could always make `ItemStack` extend `ImmutableDataHolder` instead, but I do see the point that this would have a huge amount of backlash.


Very cool. Thanks @nzakas


There was a branch where it had been, no idea what happened to it