 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|suite_setup|1|0|0|0
local_ps_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_ps_virtual_router_test|__account/test_vm_ops_by_normal_account__|0|1|0|0
local_ps_virtual_router_test|__account/test_multi_accounts_vm_ops__|0|1|0|0
local_ps_virtual_router_test|__novlan/test_create_vm__|0|1|0|0
local_ps_virtual_router_test|__novlan/test_reboot_vm__|0|1|0|0
local_ps_virtual_router_test|__novlan/test_ping_vms__|0|1|0|0
local_ps_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_create_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_reboot_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_snat_create__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_dnat_reboot__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_ping_vms__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_create_3vms__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_start_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_3l3s_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_remove_dhcp__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_2l3_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vms_with_limited_ips__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.0__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.1__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_start_vms_simultaneously__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_static_ip_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vm_with_hostname__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_attach_nic__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_attach_nic_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_attach_nic_reboot_vm__|0|1|0|0
local_ps_virtual_router_test|__volume/test_add_volume__|0|1|0|0
local_ps_virtual_router_test|__volume/test_add_m_vols__|0|1|0|0
local_ps_virtual_router_test|__volume/test_add_volume_vr__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_volume__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_2_volumes__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_24_volumes__|0|1|0|0
local_ps_virtual_router_test|__volume/test_volume_ops_on_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_from_dvt__|0|1|0|0
local_ps_virtual_router_test|__template_image/test_crt_temp_image__|0|1|0|0
local_ps_virtual_router_test|__template_image/test_del_temp_image__|0|1|0|0
local_ps_virtual_router_test|__sg/test_ingress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_egress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_icmp__|0|1|0|0
local_ps_virtual_router_test|__sg/test_udp__|0|1|0|0
local_ps_virtual_router_test|__sg/test_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__sg/test_vm_ops__|0|1|0|0
local_ps_virtual_router_test|__sg/test_2vm_egress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_2vm_ingress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_4vm_complx__|0|1|0|0
local_ps_virtual_router_test|__sg/test_detach_l3__|0|1|0|0
local_ps_virtual_router_test|__pf/test_2l3s_pfs__|0|1|0|0
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|__pf/test_delete_pf_after_destroy_vm__|0|1|0|0
local_ps_virtual_router_test|pf/test_del_vip_before_add_pf_to_vm|1|0|0|0
local_ps_virtual_router_test|__pf/test_multi_pfs_sg_tcp__|0|1|0|0
local_ps_virtual_router_test|__pf/test_multi_rules__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pf_after_destroy_vm__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pf_sg_tcp__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pfs_tcp_udp_same_vip_ports__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pfs_tcp_with_same_vip__|0|1|0|0
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|__eip/test_2_eips__|0|1|0|0
local_ps_virtual_router_test|__eip/test_2l3s_eip_pf__|0|1|0|0
local_ps_virtual_router_test|__eip/test_2l3s_eips__|0|1|0|0
local_ps_virtual_router_test|__eip/test_attach_eip__|0|1|0|0
local_ps_virtual_router_test|__eip/test_create_eip_vm__|0|1|0|0
local_ps_virtual_router_test|__eip/test_del_vip_before_add_eip_to_vm__|0|1|0|0
local_ps_virtual_router_test|__eip/test_eip_sg_tcp__|0|1|0|0
local_ps_virtual_router_test|__eip/test_pf_eip_attach__|0|1|0|0
local_ps_virtual_router_test|__eip/test_vm_ops__|0|1|0|0
local_ps_virtual_router_test|eip/test_vm_ops2|1|0|0|0
local_ps_virtual_router_test|__snapshot/test_create_snapshot__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_create_sp_after_delete__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_create_image_by_snapshot__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_for_both_root_...__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm2__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm3__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_delete_snapshot_on_ru...__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_live_vm__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_from_vol_crt_f...__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_change_max_sp_depth__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_change_max_sp_depth_l...__|0|1|0|0
local_ps_virtual_router_test|__regression/delete_sg_with_2_attache...__|0|1|0|0
local_ps_virtual_router_test|__regression/rm_nic_sg_on_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__regression/test_data_volume_with_vm...__|0|1|0|0
local_ps_virtual_router_test|__vr/test_ping_vms_reboot_vr__|0|1|0|0
local_ps_virtual_router_test|__vr/test_reconnect_vr__|0|1|0|0
local_ps_virtual_router_test|__vr/test_start_vrs_simultaneously__|0|1|0|0
local_ps_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_ps_virtual_router_test|suite_teardown|1|0|0|0
local_nfs_virtual_router_test|suite_setup|1|0|0|0
local_nfs_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_nfs_virtual_router_test|__account/test_vm_ops_by_normal_account__|0|1|0|0
local_nfs_virtual_router_test|__account/test_multi_accounts_vm_ops__|0|1|0|0
local_nfs_virtual_router_test|__novlan/test_create_vm__|0|1|0|0
local_nfs_virtual_router_test|__novlan/test_reboot_vm__|0|1|0|0
local_nfs_virtual_router_test|__novlan/test_ping_vms__|0|1|0|0
local_nfs_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_create_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_reboot_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_snat_create__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_dnat_reboot__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_ping_vms__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_create_3vms__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_start_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_3l3s_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_remove_dhcp__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_2l3_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vms_with_limited_ips__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.0__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.1__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_start_vms_simultaneously__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_static_ip_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vm_with_hostname__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_attach_nic__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_attach_nic_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_attach_nic_reboot_vm__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_add_volume__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_add_m_vols__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_add_volume_vr__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_volume__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_2_volumes__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_24_volumes__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_volume_ops_on_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_from_dvt__|0|1|0|0
local_nfs_virtual_router_test|__template_image/test_crt_temp_image__|0|1|0|0
local_nfs_virtual_router_test|__template_image/test_del_temp_image__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_ingress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_egress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_icmp__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_udp__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_vm_ops__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_2vm_egress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_2vm_ingress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_4vm_complx__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_detach_l3__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_2l3s_pfs__|0|1|0|0
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|__pf/test_delete_pf_after_destroy_vm__|0|1|0|0
local_nfs_virtual_router_test|pf/test_del_vip_before_add_pf_to_vm|1|0|0|0
local_nfs_virtual_router_test|__pf/test_multi_pfs_sg_tcp__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_multi_rules__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pf_after_destroy_vm__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pf_sg_tcp__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pfs_tcp_udp_same_vip_ports__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pfs_tcp_with_same_vip__|0|1|0|0
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|__eip/test_2_eips__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_2l3s_eip_pf__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_2l3s_eips__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_attach_eip__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_create_eip_vm__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_del_vip_before_add_eip_to_vm__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_eip_sg_tcp__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_pf_eip_attach__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_vm_ops__|0|1|0|0
local_nfs_virtual_router_test|eip/test_vm_ops2|1|0|0|0
local_nfs_virtual_router_test|__snapshot/test_create_snapshot__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_create_sp_after_delete__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_create_image_by_snapshot__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_for_both_root_...__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm2__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm3__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_delete_snapshot_on_ru...__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_live_vm__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_from_vol_crt_f...__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_change_max_sp_depth__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_change_max_sp_depth_l...__|0|1|0|0
local_nfs_virtual_router_test|__regression/delete_sg_with_2_attache...__|0|1|0|0
local_nfs_virtual_router_test|__regression/rm_nic_sg_on_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__regression/test_data_volume_with_vm...__|0|1|0|0
local_nfs_virtual_router_test|__vr/test_ping_vms_reboot_vr__|0|1|0|0
local_nfs_virtual_router_test|__vr/test_reconnect_vr__|0|1|0|0
local_nfs_virtual_router_test|__vr/test_start_vrs_simultaneously__|0|1|0|0
local_nfs_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_nfs_virtual_router_test|suite_teardown|1|0|0|0
Total|289|8|166|0|115


oh, it's in #331


MD5 is not great but I wanted an example that is not related to vert.x,
than be easily split in 2 actions, that does require only one line of code.
That how I came up with this. I should mention that this is just an
illustration example.

Something more complex would loose the reader focus.

On 14 août 2015, at 18:45, Tim Fox <notifications@github.com> wrote:

I'm not sure MD5 is a good example. Maybe better something that does some
IO, e.g. writes a file to disk or reads/writes to a socket?

—
Reply to this email directly or view it on GitHub
<https://github.com/vert-x3/vertx-web-site/commit/cbb8a48b00868cecb69de9a52de053807832c794#commitcomment-12714440>
.


could use `list()` to convert `iter` to a list. like
```python
eq(list(iter), [("2", "bbb")])
```
note: i am using a tuple to present the `OmapItem`.


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1280 of 1280 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.51%25-green.svg)


@satya8123 could you please contact support@appfolio.com if you have a support question? Thanks.


Is there supposed to be a /plumgrid in the end? Please confirm


98318570_RemoveRadianceCheckbox (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


if you are using `iter` in the way of `iterator`, this test would be much more elegant and concise.


This tree is outdated mate, I actually never really used it (only for first build) all other things are in Hulk V2


Placeholder mixin won't work as expected in Chrome.

```scss
@mixin input-placeholder-color($color) {
  &::-webkit-input-placeholder,
  &::-moz-placeholder, /* Firefox 19+ */
  &:-moz-placeholder, /* Firefox 18- */
  &:-ms-input-placeholder {
	color: $color;
  }
}
```

This is because Chrome (at this point in time) fails to parse its part. These have to be separated out like so:

```scss
@mixin input-placeholder-color($color) {
  &::-webkit-input-placeholder { color: $color; }
  &::-moz-placeholder { color: $color; } /* Firefox 19+ */
  &:-moz-placeholder { color: $color; } /* Firefox 18- */
  &:-ms-input-placeholder { color: $color; }
}
```

BTW, found this out the hard way.


Why do you commit the `.gradle/` files?


Just checking :)

On Fri, Aug 14, 2015 at 12:10 PM, Luca Grifo <notifications@github.com>
wrote:

> This tree is outdated mate, I actually never really used it (only for
> first build) all other things are in Hulk V2
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Tkkg1994/Hulk-Kernel/commit/41118f1ca6b704fb16f4fedeeeb1c3742fbd989f#commitcomment-12714861>
> .
>


This has to be prefixed as `files.Path` since there's already a `Path` type in `pathway.io`.


(which I am code reviewing now and will likely be merged soon)


Thanks for the quick feedback!  I've created https://github.com/plobbes/mail-imapclient/commit/cf8ba920e2dd86927c7262bd83ca929247501a91 which will be in a 3.37 release coming shortly.


awesome


develop (axelstudios) - i386-Windows-7-VisualStudio-12: OK (2214 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.15%25-yellow.svg)


So that it can be easily used alongside the modular bootstrap architecture we discussed.


Awesome, I'm happy to see this change.


Closes #27.


It's one way to implement it (not the only way). I should add a note about
that.

Using a job queue or an event loop should be mentioned but are concepts not
usually understood by every developer (something they may not have seen
before).

On 14 août 2015, at 18:47, Tim Fox <notifications@github.com> wrote:

This is not necessarily true, and is a common misconception about async
APIs (in fact there has been a thread today on vertx googlegroup where a
user confuses threads and async). Async APIs do not require extra threads.
Vert.x is almost entirely async, and (unless you're using workers)
everything is done on a single thread (the event loop).

—
Reply to this email directly or view it on GitHub
<https://github.com/vert-x3/vertx-web-site/commit/cbb8a48b00868cecb69de9a52de053807832c794#commitcomment-12714473>
.


Yeah, I do subscribe to that notion, generally. I guess I don't feel quite so strictly. But this commit is a little large, and I agree it'd be better broken up. I'll break this up.


RemoveMoreBadCharacters (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Caused https://github.com/TrinityCore/TrinityCore/issues/15278


this seems awkward.  Does register really define the variable even if the "Create" play doesn't run?


Quite excited to see how this experiment will turn (for the better we hope !)
After 100M you have three parameters that seems quite stable, and the other 3 more or less equal.


I'll check it tonight...


Thanks for testing. You have probably seen the next 2 commits. No complaints from openATV users so far.


End of Friday, Code Sprint Week. code compiles, sets up sv wind and plasma structure using domains.

where_in_wind and where_in_grid are probably not working, or something similar, as lots of these errors:

```
trans_phot: Trying to scatter a photon which is not in a cell in the plasma structure
trans_phot: grid   0 x -2.16e+09 -1.73e+09 -1.49e+08
trans_phot: This photon is effectively lost!
```

we also need to do something about part in wind cells.


RemoveMoreBadCharacters (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Maybe a timer or some non blocking IO. I think these would be better as they can explain the concept of async APIs, but without having to introduce the concept of executing some operation on another thread (which is not really relevant).


After op-build pull request #229 was merged master-next fails to build.  Looks like some skiboot patches need to be removed and/or modified.  skiboot-0002-libflash-Provide-an-internal-parity-implementation-t.patch specifically does not apply anymore.  Could you please take a look into it?

Applying skiboot-0002-libflash-Provide-an-internal-parity-implementation-t.patch using patch:
patching file Makefile.main
Reversed (or previously applied) patch detected!  Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file Makefile.main.rej
patching file libflash/ecc.c
Reversed (or previously applied) patch detected!  Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file libflash/ecc.c.rej
Patch failed!  Please fix skiboot-0002-libflash-Provide-an-internal-parity-implementation-t.patch!
make: *** [/esw/san2/jmazurin/opbuild_update/op-build/output/build/skiboot-skiboot-5.1.0-beta2/.stamp_patched] Error 1
make: Leaving directory `/esw/san2/jmazurin/opbuild_update/op-build/buildroot'


I don't think there's an issue, as each platform has distinct shared object storage, the key is that you can save/restore data on each platform. I'm not sure if the storage format is entirely important otherwise :smile:


Do you want everything as a single commit?


this PR/commit seems by the creation of a tiny function "render-workspace-details" and relocation/moving of "WorkspaceDetails" to another file. :+1: Looks good to me!


Perfect, thanks!


Yes!


which breaks k&r because it shouldn't have newlines after else and class keywords, k&r is no different than allman at this point...


One reason I mention this - there was a thread today about threading and async on the google group (title "vert.x 3 threads in verticle") in which the user really struggles to understand why asynchronous doesn't require extra threads. That's why I think it's important in an article explaining async APIs not to use examples that spawn extra threads (or use workers) as it just re-inforces the misconception that async requires multi-threading) :)


Why put this intermediate empty object in the prototype chain?
Given that it is there, it should be frozen as well.


Hi Rocky,

actually I think that it is only the "cooling down" of SPSA which make them look like there are converged. The only problem: next two weeks I will be in holiday :-) so, we must wait to see how good the final values perform (I expect them for Monday or Tuesday).

Btw: I set the throughput so low that even if the final values cannot pass SPRT, no harm will be done, since the tuning session was running only if framework was almost empty.


RadianceRefactor (rpg777) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I like this approach a lot.


101242918_EvapCndPump (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


If it was me writing this, I think I would probably start out with a first post which discusses the concept of async apis, and the pure reactor model (i.e. just a single event loop that never blocks) and makes no reference to calling blocking apis or doing long lived calculations.
And then follow up with a second article that discusses stuff like "but in the real world we sometimes need to call legacy blocking apis too", and then introduces the concept of workers and execute blocking. At that point it would be appropriate to introduce the MD5 example.


try not to. The gitignore has .gradle in it

Just delete them. They're not supposed to be getting picked up


Why is `build_settings.sh` needed at all? The environment is inherited.


Provavel que seja por isso que não ta funcionando o popover


The widget still doesn't seem to take up the available vertical space in IE9.


Does this lookup succeed as a result of the definition herein : https://github.com/CruGlobal/ecs_config/blob/master/ecs/base-image-wildfly/cas.cli#L5 ?


Lol, epic fail xD


Aqui também


@joaomdmoura +1 for the questions.
Not sure there are other places where `Serializer.root_name` used right now.


please format correctly


good catch! It is unused.


Thanks for catching this.


gente.. esse div ta fechando fora do ul???


I don't think you need `get_string ()`


Hmmm I thought the environment was cleared when doing a conda build.
Maybe I got it wrong, I will recheck that.


Deletes unnecessary div? mas nem deletou nada... mas sem prob


nice


Maybe rename it to Head?
the doc needs updating.


@jranke was wondering, what prompted the change ?

I several functions as a dependency in: https://github.com/sahilseth/readthedocs


It should be `$t\string<0$` here, because of `<` is an active token in environment `function`.


Could we remove  `cache.Algorithm` ?


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2179 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.37%25-yellow.svg)


cuidado com linhas demais, tenho toc


Not sure I understand what you mean.


Not bad...


About NIL and T vs nil and t:

http://www.gnu.org/software/emacs/manual/html_node/elisp/Documentation-Tips.html

> When a documentation string refers to a Lisp symbol, write it as it would be printed (which usually means in lower case), with single-quotes around it. For example: ‘lambda’. There are two exceptions: write t and nil without single-quotes.

Other Emacs documentation says t and nil.


obviously the hack to fix is...
if (strtolower($this->getSetting('style')) == 'allman') {
                $this->oBeaut->addNewLineIndent();
            }


close, it's actually this line:
https://github.com/CruGlobal/ecs_config/blob/master/ecs/base-image-wildfly/cas.cli#L12

And this line, too, actually:
https://github.com/CruGlobal/budget-tool/blob/dockerize/src/main/webapp/WEB-INF/web.xml#L34


r+


Please update T to t and NIL to nil, as this stands out a bit too much. Otherwise nice work.


lol


I guess something like `this` or just bold, in case nothing fancy is available.


This solved our issue here at Weever Apps inc. Thank you!


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/5dd21812f7a16113f0714efb9ee33e9b34477839


merging graydon/stellar-core/avg-not-95 = 5dd21812 into auto


graydon/stellar-core/avg-not-95 = 5dd21812 merged ok, testing candidate = 030e48a3


Currently getting the same request(n-th request) which is equal (same path) to an already started but not finished one(first request) will not be started but will reuse the result form the 'first request'. This is disregarding whether the response is cacheable or not.


By using `{}` in this position, you create an empty object that inherits from `Object.prototype`. Your new object inherits from this empty object.

To omit this empty object from the prototype chain, say `Object.prototype` here instead of `{}`


socorr, style no html


Thanks :)!


ACK


I just put up D2346840 internally to remove some more of this.


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


@jasondegraw The fix is good. I would like to make a better message:

						ShowContinueError( "An adjacent zone = " + Zone( Surface( n ).Zone ).Name + " is not described in AIRFLOWNETWORK:MULTIZONE:ZONE" );


é do popover .. vou criar uma classe


merge


You can't. We don't build React with sourcemaps and don't have an option set up to do so.

This commit was about adding a source maps option to the `react-tools` project, which has since been discontinued.


Can we add a gulp test task that runs both of these?


@gracjan, this is possible. `T` and `NIL` are Common Lisp conventions. I'll amend that commit with fixed `T` and `NIL` soon.


Thanks.


found it... oops...
@pelegkaz


guigs! nao é mais assim! vai ser alterado nos commits mais a frente


Thank you Vincent!


You should avoid using partials because the partial relies on a certain context that may not always be available. Instead, you could use another component altogether with its own template.


:snake:!


I'll get on that now.  Should it be in addition to or instead of using the `npm test` script?


You should start following [ES6 syntax](https://github.com/airbnb/javascript). Don't use `var` anymore. You want to use `const` or `let`:

```javascript
const model = this.get('model');
const status = this.get('status');
```


spring-cloud-stream-modules-common-configuration -> should these (Mixin replacements, etc.) really go into spring-cloud-stream?
I don't think we need a separate test-support library here either.
S-I DSL seems like the easiest way to implement non trivial flows, but a bit clunkier without lambdas.
Some refactoring, renaming of Mixins...
What's the easiest way to inject module properties. Maybe create instance of the ConfigurationProperties classes and call the setters directly, but hard to do when composing properties like this.  Also, some boot supported conversions are not obvious, so better to initialize with a Properties object as the module property   values would look to the DSL.


Perfect! And huge thanks for reporting the issue!


VERY good point. Quite the micro-perf difference as well: http://jsperf.com/object-create-vs-object-create-object-prototype. I release a patch.


npm test should proxy out to gulp. ie. `./node_modules/.bin/gulp test`. We should probably switch the npm start script to use the local gulp copy as well (`./node_modules/.bin/gulp`) so devs don't need to have gulp installed globally


Looks good, but `find_executable` should not be in `File`. I suggest the `howl.sys` module as a suitable location.


A little, yeah :(. There's a good number of issues wired up to "0" for the reason that they're unlikely to ever be stabilized. We can go through and try to add issues for *why* I think they'll never be stabilized, but it seemed like somewhat overkill this first time around.


Fila a bug report about it. The problem as far as I can understand it is that you cannot know if the response will be cachable or not. Once a request starts to wait it is committed on using the response from the currently-in-flight one. There is no way to know if the response will be reusable or not beforehand.


You're right... it's been 15 years since I've been relying on garbage
collectors to do the job. :-)

Haven't changed anything else to minimize impact, but doesn't this look
like a leak too?
SelectResults * selectResults = new SelectResults(selectResultsPtr);

On Thu, Aug 13, 2015 at 4:14 PM, Grant Hutchins <notifications@github.com>
wrote:

> I think this is a memory leak. Where does this get deleted?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SorinTO/node-gemfire/commit/4ea77e56c0dc91d7bfa490f601678cb2b31161c4#commitcomment-12698257>
> .
>


The security is this patch is rather low.

Can you please at least:
  - open the pidfile,
  - *then*, using the opened handle, and before parsing the file, check that the owner of the file is the same as the owner of the process,
  - then only after that check read the file and fill the process.

I do not want that anybody on the machine can kill any process I own by writing something in `/tmp/test_cgal.pid`.


hola


101242918_EvapCndPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 750 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.46%25-green.svg)


Hmm, that is odd as I definitely see pks getting defined over in the map. @PredatorVI can you take a look at this when you get a chance to see if you can duplicate?


Hi @davidpersson ,

I have a question / doubt regarding the composer constraint. If we don't put this `1.0.0-rc1` in all the libraries, instead keep `~1.0`, doesn't it can take the appropriate release when the minimum-stability flag is set to `rc` ?

This may help not to keep / change the composer.json for each release.

Thank you.


@PredatorVI Actually looks like this was modified via another PR here: https://github.com/saltstack-formulas/rabbitmq-formula/pull/28


Fixes #220


> Anyway, 20 KB would be enough too to eliminate the warnings. Does that sound better?

Whether it 20, 30, 40, or 50 KB isn't the question. The question I have is whether or not we should be ignoring the warning in the first place.


Yes, it is basically a `HEAD` request. But it would be better to do it outside this pull request.


adding the axis1-3 arrays to the `getclientdx` functions seems redundant to me. We already have the `sortDxByV4Axis()` function for that.

the usage design is
```
getclientdx(...)
sortDxByV4Axis(...)
```

if we don't want to have to manage 2 library function calls for this then I propose we define a new function `getClientAxialDx(clientid, asofdate, axis1[], axis2[], axis3[])`

implementation would look like the design above
```
getClientAxialDx(clientid, asofdate, stripdots, axis1[], axis2[], axis3[]) is null
clientid is x
asofdate is d
stripdots is x
axis1[] is x
axis2[] is x
axis3[] is x

dx_rank[] is x
dx_axis[] is x
dx9_code[] is x

getclientdx(clientid, asofdate, , , , , , , dx_rank[], dx_axis[], dx9_code[])
sortDxByV4Axis(dx9_code[], dx_rank[], dx_axis[], stripdots, axis1[], axis2[], axis3[])
$allowupdate(axis1[], axis2[], axis3[])
end getClientAxialDx
```


Stray closing symbols. No points deducted.


Rename to "compdecompressproc".


Check indent.


Nice, but we gotta get out of the habit of messing with the .dme file like this. Go into your compiler for DreamMaker, click the Build tab, Preferences, and uncheck the "Automatic FILE_DIR" part. Then recompile.


Hi Sindre, thanks for the heads up! I’ll get back to this in a week when I‘m back at work.


Did you do this manually or with a tool? If a tool, what did you use?


PVC is overloaded with `PersistentVolumeClaim` -- maybe 'PV controller' would be a better way to refer to this in this doc.


How about just `proxy.conf` or `global.conf` since these apply to everything? `_settings` seems a little redundant and verbose to me.


Looks good, just spelling of "re-wroked".


You lost a space right there!


This will cause an endless loop, as ```this.buffer.slice(0, length - 1)``` does not modify the actual object.


So here, I'm guessing your intent is to add several documents at once to `members`, an array. Instead, you get an array, `members`, containing one object with three properties.

[This mongo doc](http://docs.mongodb.org/v2.6/reference/operator/update/push/#example-push-each) will explain how to push several values to an array in one update.

You'll also have trouble working with this even if they were separate documents, since they don't have standardized field names. If Ned's `ned` contains "Ned", and Arya's `arya` contains "Arya", you're going to have to get clever to simply extract the name from an unknown Stark's document. Instead, it'll be much easier on you to put this collection to use if their name fields were called "name", and the contained value was a string representation of their name, like so:

```javascript
...
{
    name : "Ned"
}
...
```

3/4 credit


@atheurer, were you able to run the unit tests to see if this affects anything?


Why are these changes made?  Why are you removing the functions `lookupReports()` and `createReport()`.  Please detail why these changes are done to `demand-ctrl.js`.  The commit is supposed to be about the farmer's supply card.  None of the changes done in `demand-ctrl.js` are related to the supply card.  @nick22891 please explain.


Should this go after the default ones in the template so that if they don't add all the existing ones, the proxy is not broken?  Although, I'm not sure if nginx allows you to override previously set options using laters ones off-hand though.


LGTM


pense que no usabas palabras en español como variables.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/75641055


@nick22891 Please explain the changes done here.


@devTristan IMO the default should be 0 dropped allowed


Perhaps move this closer to the long running collection at line 128?


@nick22891 This is part of core functionality.  Why undo them?!


Perhaps we should log this instead?


Man idk and I really trying sorry but my mind some where else to fixed try contact Google lost the #


Alias's are no more sticky than variables.  The only way to make them "sticky" is to define them in your ~/.jsqsh/sqshrc file.  Variables have the added benefit that they can be set on the command line as well:

    -vdelimiter=,


You should have left the configs in a default state because when you enabled pear by default people using K&R had all their styles change, this probably created more issues in the long run


I think I want this branch deleted.  These are changes that have been made previously.... @nick22891


https://github.com/fritsch/xbmc/commit/46bc5aa240eec672b98a6c2894bd976471b2ebef <- kodi patch

@btbn also started with this ffmpeg as base - let's make HEVC-VAAPI come true :-)


101280704_LowTempRad (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


depende a quien va dirigido el codigo; pero 90% de las veces todo en ingles para mantenerlo universal ;D


Could we make this a log message instead?


ARM11 Patch Support? Would this mean we could integrate NTR 3.0?


I'm lost and can't do this right now sorry


fast-forwarding master to auto = 030e48a3


I thinks this works, but an extra `./`.


101280704_LowTempRad (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@rpg777 this should allow you to run in pat on mac, measure still is not working on windows


I won't tell anything now ;)


 It faster to remove the sortdxbyv4axis function and simply return a set of
dx10_axis and dx9_axis arrays from the GetClientDX function.

On Fri, Aug 14, 2015 at 12:53 PM, tim <notifications@github.com> wrote:

> adding the axis1-3 arrays to the getclientdx functions seems redundant to
> me. We already have the sortDxByV4Axis() function for that.
>
> the usage design is
>
> getclientdx(...)
> sortDxByV4Axis(...)
>
> if we don't want to have to manage 2 library function calls for this then
> I propose we define a new function getClientAxialDx(clientid, asofdate,
> axis1[], axis2[], axis3[])
>
> implementation would look like the design above
>
> getClientAxialDx(clientid, asofdate, stripdots, axis1[], axis2[], axis3[]) is null
> clientid is x
> asofdate is d
> stripdots is x
> axis1[] is x
> axis2[] is x
> axis3[] is x
>
> dx_rank[] is x
> dx_axis[] is x
> dx9_code[] is x
>
> getclientdx(clientid, asofdate, , , , , , , dx_rank[], dx_axis[], dx9_code[])
> sortDxByV4Axis(dx9_code[], dx_rank[], dx_axis[], stripdots, axis1[], axis2[], axis3[])
> $allowupdate(axis1[], axis2[], axis3[])
> end getClientAxialDx
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/txace/icd10-sql/commit/da40a75197eaa8f40664cd39a34f04cc9cdd1700#commitcomment-12715659>
> .
>


succes**s**fully


Update the NEWS file also


You definitely should.

But in your context, how would you differntiate ability from feature?


Should print "/home/XXX/.ethereum" on linux machines


I'm gonna get hard if it's what I think it is xP

This is exciting :D


I find it is useful to have both a safe option on a more advanced rank and an option on a lower rank.  Having the retreat to a lower rank is more important though.


@bobsummerwill it doesn't to keep that name, it was mostly for testing purposes. Also, while I may kickstart things on develop at first, I'll switch to using proper branching once we'll have a bigger codebase!


Huh, "It's faster"

On Fri, Aug 14, 2015 at 1:07 PM, Chris Love <k6panzer@gmail.com> wrote:

>  It faster to remove the sortdxbyv4axis function and simply return a set
> of dx10_axis and dx9_axis arrays from the GetClientDX function.
>
> On Fri, Aug 14, 2015 at 12:53 PM, tim <notifications@github.com> wrote:
>
>> adding the axis1-3 arrays to the getclientdx functions seems redundant
>> to me. We already have the sortDxByV4Axis() function for that.
>>
>> the usage design is
>>
>> getclientdx(...)
>> sortDxByV4Axis(...)
>>
>> if we don't want to have to manage 2 library function calls for this then
>> I propose we define a new function getClientAxialDx(clientid, asofdate,
>> axis1[], axis2[], axis3[])
>>
>> implementation would look like the design above
>>
>> getClientAxialDx(clientid, asofdate, stripdots, axis1[], axis2[], axis3[]) is null
>> clientid is x
>> asofdate is d
>> stripdots is x
>> axis1[] is x
>> axis2[] is x
>> axis3[] is x
>>
>> dx_rank[] is x
>> dx_axis[] is x
>> dx9_code[] is x
>>
>> getclientdx(clientid, asofdate, , , , , , , dx_rank[], dx_axis[], dx9_code[])
>> sortDxByV4Axis(dx9_code[], dx_rank[], dx_axis[], stripdots, axis1[], axis2[], axis3[])
>> $allowupdate(axis1[], axis2[], axis3[])
>> end getClientAxialDx
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/txace/icd10-sql/commit/da40a75197eaa8f40664cd39a34f04cc9cdd1700#commitcomment-12715659>
>> .
>>
>
>


Are you using this script anywhere else in the demos? If you aren't, I would suggest deleting it from the repo, especially since it was written by other authors.


Remove unused commented code.


Excellent.
I expected the impact to be larger.
Since chpl_check_local() is a runtime check, we are only testing the assertion on true multilocale runs.  I assume you ran a representative sample of the multilocale tests.  If so, then OK to commit.


In this test, a safe option is a pawn protected square.
Maybe I can make this more general.

And having 2 options should not harm ;)

My first idea was to find a new bonus to help pieces get outside the pawn chain,
especially Bishop, but could have other purpose as well...


SL shuts down properly, but need more testing.


@vlj aftermerge of d3d12 branch with dx12 selected I get `Exception thrown at 0x0000000200865F92 in rpcs3.exe: 0xC0000005: Access violation writing location 0x00000001404DEBFC.` in STW. Only in d3d12. Could you look into this? (And I remember it was fine before when I tested your branch so it's probably introduced by recent changes)


Good!


It's not a good idea. PHPUnit is failing because of empty testcase :)


Yes I know, was a typo :+1:


> whether or not we should be ignoring the warning

I will gladly make it disappear in embedded cassandra (that is not recommended for production) because it is `batch_size_fail_threshold_in_kb` rather than `batch_size_warn_threshold_in_kb` that matters and it works(TM). I'd prefer not to see these warnings in the log when I solve other problems fully unrelated to cassandra. I admit that my perspective is selfish ;) I cannot serve with any authoritative statement whether there is something really dangerous behind these warnings.

Feel free to veto this commit. Is the rest of the PR OK?


:+1: "position: relative" was a masterful touch. Well done.


Is there anywhere I can find more information about why the extension code was removed?  And/or if it was moved somewhere else?


Looking good. Will mention this in the next tutorial video!


$languages_id is confused in status query so it would be better $orders_language_id instead


In business analysis terms, anyway, it comes down to what is provided as business value and then the specifics of how that is carried out. So the traditional idea is "log in." That's an ability. The user has the ability to log in to the application. The feature this works within, however, is authentication or security. So you are saying that "our application features authentication". The latter is what you are selling. No one is strictly paying for "being able to log in". They are paying for a secure service. One ability that allows that is logging in via a form. Another ability might be logging in via some third-party account, like Facebook or Google or LinkedIn.

Another example is reporting. People often incorrectly say "export to PDF" or "export to CSV" are features. They are not. Those are abilities. So what's the feature? Likely, something like "sharing information." So selling the business value is saying "our application lets you share reports and information with customers and colleagues". That's what customers want to pay for and that's a feature. Specific abilities provided to do that are exporting to various formats -- but also providing, for example, dashboards.

Or taking a game example: grouping in MMOs. The ability to play MMO games as a group is a feature. The abilities to support this are usually phased instances, group finders, "add to group" options, round robin loot systems, and so on.

A key thing to note here is that in all cases you could change, add to, or remove some abilities but still say that you provide the overall feature. Further, you can lump those abilities under the feature that they most speak to from a business perspective.

Hopefully this at least made sense rather than making me seem even crazier than I probably already do.


hi!
this is harsh from india..


You're right. My bad :/


@mikejolley ;)


I considered it, but since that would change behavior in any existing applications I'm saving that for a 2.0.0


tá errado


yes you are right, I was playing and seeing how to works rviz and moveit , Tried to use my message into rviz plugin of a ps2 teleoperation. I will remove it , I haven't clean the code yet


Remove it from the binary repos when we have it in our sync folder ...


I've uploaded new versions of the patches, fixing this. I think every patch until the *** WIP are fine to integrate.


:+1:  Great idea.


I like the idea, but no the filename


@Killyana : thanks for your efforts and releases, good job. :+1:

@D4R4 : issues from 2013 should be "quite old" issues (from when I joined github.com). Issues from 2012
are **very** old. "Ancient issue" should be any of the issues from 2011, ported from googlecode to github.com ;-)


This is not grammatically correct. Change to "Folder Contents"


This is causing errors in usage like
`rpiLogo.draw(-rpiLogo.width/2.0f,-rpiLogo.height/2.0f);`
intended?

`error: ‘int ofImage_<unsigned char>::height’ is protected`


I'd leave this argument empty without a default, so it requires users to input a valid Bluetooth address.


Same comment about Bluetooth addresses.


Not grammatically correct. Should be "driver to the Mindwave" or "driver for the Mindwave". Files of the node also doesn't make sense.


Can just be "ROS messages for Mindwave driver"


Never mind, found the reasons at https://github.com/SeleniumHQ/selenium/blob/master/rb/CHANGES


Please a comment explaining what this class does.


Can you add step-by-step instructions to the README for how to run specific programs, such as rosrun or roslaunch commands?


they are more then needed.


thx for fixing


Please remove the boilerplate comments and only leave the sections relevant to this project.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2194 of 2235 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.17%25-yellow.svg)


Primera Version Culqi.php


There is also a subtle aspect that might have to be considered: Often when one defends a piece with a piece when it is capable of making the same kind of move, doing so often takes one of the options from the piece being defended as that defending piece is now standing on the retreat.  It may therefore make sense to add a little more bonus to defending.  But it is unclear.  Difficult to know.  Sometimes you want to be able to take back with a piece that does the same thing, other times it does not mater.  If it does not mater, it probably would be better to have it a different kind of piece, so that a retreat is not compromised.  It is hard to get general here as calculation takes precedence over most considerations.


Sounds familiar...

https://twitter.com/StephenSFinney/status/631859725618028544


ESFormatter via Sublime plugin, using the jQuery preset

> On Aug 14, 2015, at 1:56 PM, Jörn Zaefferer <notifications@github.com> wrote:
>
> Did you do this manually or with a tool? If a tool, what did you use?
>
> —
> Reply to this email directly or view it on GitHub.
>


Fair enough :) I think the PR is fine otherwise.


In my opinion, one should treat Haskell's `do` keyword just as one treats curly brackets in C-like languages — one uses them even when they're not strictly necessary, because one day they might *become* necessary, and you'll pay *very* dearly to find that out.


Ill change it to vars but I want to go over the feature I was trying to
accomplish, as to not make me sound completely insane...

Lets say I like pipe separated values (I don't actually but let's go with
it).  For 90% of the stuff I write I want output by |.

So first off I will need to set a default some place. (you can argue that
why don't you just alias the command the drawback, you will end up having a
alias for each type, which isn't horrible but I will continue).

I run my queries and capture my output and all is great.

Well now the finance person wants something where the delimiter is a tab.
So I quickly modify my alias and viola for the next 10 queries all tabs.

Now back to my regular delimiter | and I am working again.  I turn my
computer off and that is that.

I think the same feature set you can just create a bunch of your own
aliases to satisfy each scenario.

\pipe=\go -m delim --separator="|"
\finance=\go -m delim --separator="\t"

On Fri, Aug 14, 2015 at 2:01 PM, Scott Gray <notifications@github.com>
wrote:

> Alias's are no more sticky than variables. The only way to make them
> "sticky" is to define them in your ~/.jsqsh/sqshrc file. Variables have the
> added benefit that they can be set on the command line as well:
>
> -vdelimiter=,
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/a0b27e8064e73b849a3a93a36746ea85d5ac5bf2#commitcomment-12715822>
> .
>


No, "Create" won't register ``teuthology_user_created`` unless the play runs.  That's why I had to ``teuthology_user_created is defined`` because if "Create" isn't ran the playbook will fail trying to use ``teuthology_user_created``.

The ``teuthology_user_changed|changed`` is there for when "Create" runs but does not create the user.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I don't know that this is the best way to handle this, but models that are deps of other models pose a problem during a shuffle if you're trying not to re-fire a computation that is going out of scope. Does anyone have any tips on a Better Way<sup>:tm:</sup>?

I still haven't figured out why making the `get` relative worked. I think it should have failed to resolve at that point. Am I off or is another test in order?


it should be fixed in the examples using it, can you send a PR?


Please also update the same in:

* [Documentation/building/custom-dnx-instructions.md](https://github.com/dotnet/coreclr/blob/46bb3fa7c4469c70d07b3a7b43370fe630d4fb69/Documentation/building/custom-dnx-instructions.md)
* [Documentation/install/get-dotnetcore-dnx-linux.md](https://github.com/dotnet/coreclr/blob/46bb3fa7c4469c70d07b3a7b43370fe630d4fb69/Documentation/install/get-dotnetcore-dnx-linux.md)
* [Documentation/install/get-dotnetcore-dnx-osx.md](https://github.com/dotnet/coreclr/blob/46bb3fa7c4469c70d07b3a7b43370fe630d4fb69/Documentation/install/get-dotnetcore-dnx-osx.md)


THX = {Thank You}


See 6285b343f366f2212b076f6efcb7d4bf4d9be099 for how I incorporated it.


howdy!


:beers:


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.78%25-red.svg)


sup


Should this now be changed to:

```yml
os: Visual Studio 2015
```


Daniel, is there a better way to do this problem without importing defaultdict?


closes issue #429


nit: missing EOF linefeed (required by git).


next commit fixes the "certificate authority" --> "certification authority"


98318570_RemoveRadianceCheckbox (macumber) - i386-Windows-7-VisualStudio-12: OK (2186 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.69%25-yellow.svg)


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2214 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.15%25-yellow.svg)


Please add an RSS to your line.
http://blog.cloudera.com/blog/category/data-science/feed/


Yes, I agree that aliases are the way to go to define a new *command* that sets your defaults, but they are not the right thing to use for conveying configuration information to the display format.

I do like the idea of adding some arguments to "\go" to allow you to easily set the variables, but if you do it, they should set the variables only for the duration of the "go" and then restore them to their previous settings.


I'm not personally a big fan of this one.  My personal style preference is to just use double quotes everywhere, regardless of interpolation.  There is no real speed penalty for doing so.  If anything I'd change this from `error` to `warn` but I'd say remove it completely.

Curious to have @begizi weigh in tho.


Очень-очень неплохо. Действительно.
Единственный момент, который смущает - это как теперь пользоваться оценками по экзаменам?
Например, я хочу взять и посчитать средний бал за вторую сессию. Как это сделать?


101242918_EvapCndPump (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1275 of 1275 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


woops, extra period


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1271 of 1271 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It is not necessary to provide the value of the field you want to unset, but, according to [this](http://docs.mongodb.org/v2.6/reference/operator/update/unset/), it will not affect the operation to provide an arbitrary value.


+1 -- if they obtain them from a CA they might not need posh but that gets very complicated to explain


@evs-chris I'm coming at this totally blind since I (still) haven't had a chance to get caught up on this new branch, but in #1740 one of the things I added was to not notify model child members of arrays on shuffle, with the exception of `@index`.

> I still haven't figured out why making the get relative worked. I think it should have failed to resolve at that point. Am I off or is another test in order?

From that template and data, it shouldn't work with `.get` because the options array members don't have a `.get` method! my .02


@talos, wondering what's the motivation behind dropping pgloader...
FYI, there's talk considering using it for CKAN https://github.com/ckan/ideas-and-roadmap/issues/150


We might want to change "does not need to deploy DNS security" to "is not required to deploy DNS security". I'm also thinking that some words after these bullet points might be useful, to the effect that "of course DNSSEC is a good thing and we're not trying to discourage you from deploying it, but from the perspective of DNA, DNSSEC is not necessary for the PKIX and POSH prooftypes"...


@begizi npm resolves the packages in the scripts to `./node_modules/.bin` by default, no need to explicitly include it here.


зачем здесь continue?


Teste 2


и здесь?


Temporarily removed other super units for easier testing.


There are diminishing returns on the number of the sum of retreats but probably not with trade options.

A slightly related idea that I am not sure if Stockfish has is that when you are in their territory you want to be the one with the capture choices while any capture choices they have of your piece should ideally be somewhat costly.  It is generally an investment of several moves or patient waiting for opportunity to get in there, you don't want it to be that easy to get rid of the piece.  Though with rooks it can be very fast and is often the point.

Hmm, that may already be being investigated by the "Capture Tuning".  Maybe that is more strait forward than my suggestion.  Though, that could be broken apart by piece.  Knights and queens in particular you like to keep in there behind enemy lines.  Bishops are there either to restrict a king or to pin or threaten to take something often as an in-between move as an active defense.


DeprecateRunScriptOnLinux (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


very nice :+1:


@Jaiglissechef-i9100
(First of all: sorry for spamming in here)
What do you meant by installing su? I am using APPOPS-Based SU, which was implemented from CyanogenMod. I already give permission via Appops when I switch to enforcing, but after that, it doesn't work.
You mean, at boot, Settings have(or su) to grant permission to OnBoot.java you meant?(Sorry I don't understand what you are exactly talking about.)


101280704_LowTempRad (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (749 of 749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.21%25-green.svg)


Very nicely idiomatic.  I was going to do this soon, happy you beat me to it.


хлопушки-воробушки...
зачем это всё?


Ah, I did not know that. Fixed


Cool results.

(24+1)s looks suspiciously like 249% * 10s.  And the same relationship holds for single-threading.  I'd bet it's accurate.  I haven't heard any kernel bugs here :).

Since you're using hyper-threading, you shouldn't expect 4x speedup.  You should aim for a 2x speed-up, and then a little bit extra _if_ the cpu likes you :).

[1] I think if you see 400% cpu use, that would mean you were always providing work for the 4 hardware threads.  It wouldn't tell you whether the hardware threads were actually able to take advantage of that or not.  The OS cpu scheduler doesn't know that, it just assigns tasks to the hardware threads.  (`perf` command might know, using cpu performance monitoring).

One hyperthreaded core isn't equivalent to two normal cores.  If you provide 2 runnable threads for that hyperthreaded core, you achieve 200% cpu usage, but you don't get 200% performance.  So your total cpu time will go up, compared to if you gave it the same work as a single thread.  But you can (sometimes) get the work done in fewer real seconds.

[2] We'd still ideally like 400% cpu usage given four hardware threads.  And hyper-threading doesn't explain why cpu time nearly doubled, because we only used 25% of the hyper-threading capability.  The likely answer is that we're spending time moving data between cpu cores.  This shows up as "cache misses" (on per-core caches).  `perf stat` command might be able to show them with some digging.  (By default it probably only shows front-end stalls.  These are a very rough approximation but hopefully you could see them go up v.s. the single-threaded case).


Well, is there any interest in allowing Renderer's to have the ability to
supply their on command arguments?  Or a double dash to indicate to stop
parsing and pass the other commands on to the Renderer, kinda like the mail
command?  (actually that last one sounds awful)

On Fri, Aug 14, 2015 at 2:44 PM, Scott Gray <notifications@github.com>
wrote:

> Yes, I agree that aliases are the way to go to define a new *command*
> that sets your defaults, but they are not the right thing to use for
> conveying configuration information to the display format.
>
> I do like the idea of adding some arguments to "\go" to allow you to
> easily set the variables, but if you do it, they should set the variables
> only for the duration of the "go" and then restore them to their previous
> settings.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rstouffer/jsqsh/commit/a0b27e8064e73b849a3a93a36746ea85d5ac5bf2#commitcomment-12716633>
> .
>


@Mazda--  any reason to have used runSuCommand for getenforce?
runShellCommand would work fine too, getenforce dosen't need root
Seems to be the cause for these random Settings crashes in the case of SuperSU not installed


that is arguably better, but for a line that will hopefully not stay with us for too long, I can't be bothered to change it (and kick off another multi hour CI run)


remove close paren


I like the idea of the linter enforcing a quoting style. We can just have it enforce double quotes instead so the code isn't littered with back and forth styles


:boom:


А в общем - здорово ))


4 пробела для отступов


Awesome work Shauren :)


@rlorenzo Does this look ok?


key stokes of lightening! :+1:


little typo


My thought here is that one or the other should be enforced for the reason @begizi mentioned above.  I am fine with either one, just as long as we're consistent.


You should come see us at ICFP once it's accepted :wink:


This is an example of Maple code which is nice, and less elegant in other languages.  If only Maple had a nicer syntax for the 'matching' being done using if/elif here, it really would be rather nice.


Not sure about the name. Seems like it should be `Observable` since this interface provided is mostly relevant to invoking registered callbacks. The `dispatch` method should, in my opinion, be

```
dispatch(arg: A): void {
  for let cb of this.callbacks) {
    cb(arg)
```

I might even rename `dispatch` to `call`.


Фигурная скобка на одной строке с селектором


@NicholasBuse Thanks! LOL I was off by a few seconds on the 3 Plus versions earlier so I had to get back!


98318570_RemoveRadianceCheckbox (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I get an error when compile this :

c:/rxTools/rxtools/source/features/nandtools.c: In function '
restoreCoolFiles':
c:/rxTools/rxtools/source/features/nandtools.c:193:12: error:
 'wsrc' undeclared (first use in this function)
   mbstowcs(wsrc, tmpstr, sizeof(wsrc));
            ^
c:/rxTools/rxtools/source/features/nandtools.c:193:12: note:
each undeclared identifier is reported only once for each function it appears in

make[2]: *** [nandtools.o] Error 1
make[1]: *** [build] Error 2
make: *** [rxtools/rxtools.bin] Error 2


@anthonyjruffa Switch to double quotes and we'll try that out for a while. I also vote to keep it at error. Better to force devs to stop and fix the issue rather than ignoring it and it slipping into master.


are --> is (or team members)


Why is the argument type `any`? Seems like it should be `A`.


sentence


Hmm, lemme check.


SQS will open happen if the `ENV['SQS_QUEUE_URL']` is set. This is documented in `eny.yml.template`


The commit message has a typo, the last sentence should read: These options work separately and will not draw meters outside their defined bounds.

Forgot the 'not'.


I agree, I will go ahead with that unless @cpjolicoeur has any objections to it.


updated text


does it work outside of VS ?
Check that Win32 Exceptions > Access violation is unchecked in Exceptions settings.


BTW, thanks for the VBox tips, i'm up and running!  Trying JuiceSSH from my phone to make package updates on the move :wink:


You're right. It wasn't showing up in code completion before I added it. Just removed it and now I let FD chug a bit, and it does indeed appear.


nice :smile: !


@sahrosa :point_up: motivo para usar o select2


minor, spell check


I am a bit concerned about the performance of this.

For example, for plugins with no vulnerabilities, you will iterate over the whole list for nothing (as their won't appear in the json var)

Furthermore, I think it would be better to change the structure of the json a bit, instead of having a key 'name' (for plugins/themes) and 'version' for the WP versions, it would be more suitable to have the slug (for plugins/themes)  and version number (for WP versions) as the key. That way we won't have to iterate over the whole list until we find the correct item, we will just do ```asset = json[identifier]```

e.g:
```json
[
   {
      "plugin-slug": {
        "vulnerabilities": [
         {
           //vulns
         }
       ]
    }
  }
]
```

```json
[
   {
      "3.8.1": {
        "vulnerabilities": [
         {
           //vulns
         }
       ]
    }
  }
]
```


Yep! I fancied a change from Ruby.


Haha! :+1: I missed these. So insightful!


This really shouldn't have passed the tests on Jenkins, that was weird.


I was thinking about the idea of having arguments specific to a style.  I'm
not opposed to the idea at all, it is just a lot of work because it doesn't
fit into how jsqsh handles command line arguments today -- you'd have to
search out the --style option, switch the style, get the rendered, hand it
the options, have it grab the ones it understands, then hand back the
remaining options for normal processing.

All super cool and useful, but a lot of work :)  If you are bored though...

Another option is to blow it out into a new command: \delim.  This command
could derive from \go and \go's arguments, but add just the options that
make sense for it.

On Fri, Aug 14, 2015 at 2:55 PM Ryan Stouffer <notifications@github.com>
wrote:

> Well, is there any interest in allowing Renderer's to have the ability to
> supply their on command arguments? Or a double dash to indicate to stop
> parsing and pass the other commands on to the Renderer, kinda like the mail
> command? (actually that last one sounds awful)
>
>
>


@sahrosa mais um caso onde o select2 teria ajudado


@dturanski

regarding the composition of properties using boot's `@ConfigurationProperites`: Can we do the composition of properties at the getter methods of `@ConfigurationProperties` ?

For the Mixins, I like having the mixins at S-C-S-Modules instead of S-C-S so that there is nothing module specific in there.


Because proxy models cannot define new fields, because they share the table with the base model. RefTimeSeries adds two new fields, so it must be a concrete sub model.


Haha. I like your response.

But the one thing I always had trouble relaying is the difference between ability and feature. I am terrible at explaining things, I just know what I know because I do. There, that should make you seem less crazy.

But unfortunately, this feature vs ability will be hard to adapt here especially with an older and established test suite. But I am sure you can change their minds.

Right now, with my team, I was fortunate enough to build the test framework from ground up hence my implementation of page object pattern and the use of watir-webdriver rather than the traditional capybara + poltergeist approach everyone uses here.

For me, features are abilities grouped while an ability on it's own is not the entirety of a feature.

You could say that, my app has an authentication feature that gives the user the ability to log in. But it would read terrible if you said my app has an ability to authenticate that features the user's login.

Well, good luck on the rest of the training. I look forward to seeing your implementatin of writing features into actual code that I can read through as well.


I'm just looking for ways to keep me engaged with SAFE while I wait for the launch.


wow, a lot in here.  can't wait to check it out.


чёт я не понял )))
зачем тебе интерфейс, если у тебя есть класс вотершип?
почему вотершип - это конкретный класс, а каргошип - абстрактный? зачем он тогда нужен (и тот, и другой)?
А почему Танкер наследуется от вотершипа, а не от КаргоШипа?


t


Объявление шрифта - правило font-family: <название шрифта>, <стандартный шрифт>, <семейство шрифтов>
Пример:
font-family: "Myriad_Pro", "Arial", sans-serif;


Размер в px


Modified the second part of the comment above.

Feel free to ignore it as it won't work as I was expected and we will have to do like before (i.e iterate over the list until we find the item we are looking for). However, I think it's a bit more good looking to have the slugs/version numbers as key rather than 'name' & 'version'. But it's just my view :D


Looks good to me, although could you do like you did for VirtualMachineList and make a function "VirtualAppListRecursive" and leave the VirtualAppList function prototype alone, so as not to break existing users?


@vlj yeah, it does. Sorry I forgot about that.


You forgot to check the malloc return here.


Достаточно /images/sprite.png
Путь рассматривается относительно корня проекта


Completely ignore the second part, it would add another nested node, which is not really that good.


hashed password was being rehashed before it was inserted


Perfect for me, it seems to go in the right direction. Next step will be to test this once you are done with your refactoring.


Nice, I was going to use the same concept to split questions ( ͡° ͜ʖ ͡°)


@ropilz
You need to include those params in your config.xml file like so...
```
<gap:plugin name="com.medlei.pushplugin" version="0.1.0" >
        <param name="APP_ID" value="Y0uRApP1D" />
        <param name="CLIENT_KEY" value="Y0uRCl13NtK3y" />
</gap:plugin>
```

However, I am encountering a java RuntimeException when the app is closed (http://pastebin.com/3twUbR9g).
"Unable to start receiver com.parse.ParseBroadcastReceiver: java.lang.RuntimeException: applicationContext is null. You must call Parse.initialize(Context) before using the Parse library."


I like this new idea of managing installation, upgrade and uninstallation in the OSF Installer. I would encourage to continue down that path for the other pieces as well.


Oops, sorry, missed one more below. made a PR already.


References should be array there :)

```json
"url": ["Ref 1" , "Ref 2"],
```


hihi :)

for the first part, do you have any suggestions?


This is done


DeprecateRunScriptOnLinux (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


git commit
Ctrl + v
esc

^[

[5myour commit message here,
Ctrl + v
esc

[0m

^[[5m#yolo^[[0m

git log


What does your Instant Answer do?
It will produce a cheatsheet for perl based vulnerability scanner that scans webserver for thousands of vulnerabilities and other known issues. It is advanced and more accurate and people would like the concept.

What is the data source for your Instant Answer? (Provide a link if possible)
r00tsec
http://www.r00tsec.com/2014/06/cheatsheet-nikto-cheat-sheet.html
Offical site of nikto: cirt
https://cirt.net/nikto2-docs/options.html#id2741238

Why did you choose this data source?
Both source are ingredient for good cheatsheet recipe, include some basic and advanced options with installation on different platform.

Are there any other alternative (better) data sources?
Cheatography provide same stuff as r00tsec do

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
Sys admin and Security

Is this Instant Answer connected to a DuckDuckHack Instant Answer idea?
Yes, It is cheatsheet

Are you having any problems? Do you need our help with anything?
No, till now i am not having any issue in creating cheatsheet.

Where did you hear about DuckDuckHack? (For first time contributors)
2nd contribution

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)

![image](https://cloud.githubusercontent.com/assets/10861554/9282077/7c50400a-42e7-11e5-8a41-f043d45dd78f.png)
![ss](https://cloud.githubusercontent.com/assets/10861554/9282090/95ed2b4a-42e7-11e5-8a09-250bdd0d5b08.JPG)


This should close #636.


This task should use the official gulp tasks: https://www.npmjs.com/package/gulp-coffeelint, and https://www.npmjs.com/package/gulp-stylint


remove the select, that way when the item is found, the loop will be stopped with the break statement


Nikto Cheat sheet, Perl based Vulnerability security tools


Legal.


I'ld rather put some more load onto the cores than "risk" any of them getting idle.
yes, the hyperthreaded cores not being as performant as real core might explain the additional cpu time.

btw,  if you like to help: the RemoteArchiverTestCase tests are still failing and I do not yet have an idea why.


оценки за первый курс сесия по инглишу укр биологии и тд,


@workshur @ukstv создал [пулл-реквест] (https://github.com/vaihtovirta/bicycle_orm/pull/1), буду правки вносить в него. Есть вопросы: если убрать все CRUD методы из sqlite адаптера, то что там оставить? Что-то типа select where и прочего такого?
Возможно ли заменить метод миссинг на подобное:
```
class User < BicycleOrm::Model
  attributes :first_name, :last_name
end
```
А в модели использовать define_method. Насколько будет правильным такое решение?


это класс отвечающий за оценки по зачётам студента на первом курсе


Analise de atividade


Analise de ativadade


display: inline-block;


Did you tested those ones ?

Doing [identifier] is a bit weird (maybe it works, no idea), as the asset['version/name'] is a string according to https://github.com/wpscanteam/wpscan/commit/8727935cb2106db663289aab18c0b8de5a6240ec

Or did I missed something ?


That's correct. But AFAIK Mojo then converts it back to / once it pass through http. Otherwise request URL contains / which Mojo interpreted as path delimiter and HMAC didn't pass and autentification failed.


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2175 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.19%25-yellow.svg)


@dukesrg Which PR?


AH! You spoke some magic words. Watir+Webdriver. I am a HUGE supporter. I even wrote a wrapper front-end (https://github.com/jnyman/symbiont) and I too adhere to the page object and activity object pattern.

As far as your statement, I would agree with it: features are abilities grouped together under a specific business value that is being provided. Going back to log in, nobody actually _wants_ log in if you think about it. It's just one more pain to remember how to log in. It's a nuisance. But people do want security. And authentication provides that. And thus people tolerate the ability to log in because they know it gives them the feature (security) that they really want.

Anyway, you've been kind to indulge me in discussion here. At some point, I would definitely like to compare notes with you and talk further about these ideas. I really appreciate you engaging on this as you did!


@nastys oops forgot to push the button :( #197


Yeah, you're right, it's a common project we all have in our workspaces, so there is no reason for not including it as a dependency.
I think GitHub will delete all the pull request comments if I delete the branch and push it again with cleaned commits, so I'm going to commit the change in a new one and I'll clean all them before merging the branch onto master.


seems good


Lovely! Just lovely, nice trick to make this validation work!


And I think that's why I suggested to use the slug/version number as a key above, to avoid the struggle of having to deal with two different things at the same time


heroku app deployment logging.


Try not to inset unneeded empty line at the end of the file


@crookedneighbor: This works better than the Jade `each` implementation, in that we don't get string errors. But I'm stumped as to how to get `achievementText` to take the `cards` value needed to display the stack number. We thus end up with this:

![image](https://cloud.githubusercontent.com/assets/4501321/9282263/bbab0750-4290-11e5-93cf-c7f725e5b315.png)


Sweet! You got this to display a message after 500 characters.


This will be the next thing I do if I have time to go back again and touch this project up.  Thanks!


This commit actually fixes the issue of being able to consume 2 http://wotlk.openwow.com/item=43523 in a row without waiting for the 1 second cooldown.
https://github.com/TrinityCore/TrinityCore/issues/15278 is caused by how the cooldowns are handled


For now, going to close this. The Stability index needs to be revisited but this is not going to land here. If necessary, a new PR can be opened against http://github.com/nodejs/node


@lordkada nice one! I might borrow a couple of methods from your gulpfile.js for my own version of this project, https://github.com/benjaminjt/ng-app


We most definitely can. And no worries, I was happy to go over someone's shopping cart that is more advanced.

And glad that someone else knows what WATIR webdriver is.
Yeah. In my project we use watir webdriver and page object gem to aide with my page object pattern.

You can CC (crapchat) me if you want to talk to me directly.

Good luck!


Oh yeah sorry thanks  to both aswell  :)


Great job overall. Nicely done!


I think the below would work better
```
asset = item['version'] if item['version']
asset = item['name'] if item['name']

next unless asset == identifier
```

Which could be refactored as
```
asset = item['version'] || item['name']

next unless asset == identifier
```

However, with such a json structure, we must ensure that versions will never have a 'name' key, and plugins/themes a 'version' key :o, otherwise, things will be quite funky ;D


It would be nice to also enable postgres server side expression compiler (settings -> datasources) which will speed up rendering at small scales.


This merge wasn't resolved.


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


ggg


Yea, it seems to work fine

We could change ```name``` for plugins/themes and ```version``` in wordpresses to ```slug```.

Problem is wordpresses already has a ```slug``` (which is not used in wpscan but is used in wpvulndb) but I don't think it is needed in wpscan.


LOTS OF LINEZ OF CODE.


I would separate this patch in two. But, being honest, we have a few commits that go against this rule. So I leave it to your discretion.


Why is the dist/ folder being ignored? Don't we still want to generate files in this folder and committing them to the git repo?


Nice!


this is pure js so probably `h5=env.t(card + 'CardAchievementTitle')` will work


Looks all good!


@gravyboat, the change of the jinja import moved to the bottom was requested by @puneetk and was not something I tested initially.  I probably should have pushed back before committing.  The initial pull request had the preliminary changes made with the help of @vr-jack.  I have been testing with @vr-jack's "Permanent fix" pull and all is well.


"lose access to the data"


Looks OK.


@Nehon
By the way, this is the change that broke TangentBinormalGenerator and made it fail on a simple box. Just letting you know.


RemoveMoreBadCharacters (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


is the command really `mkfs.something` or `mkfs something`?  Notice the `.` vs space.


I'm really sorry I pushed previous commit by mistake instead of just one branch...


@pcoughlin Thanks, I guess I should have done some in depth testing before pushing my commit :smile:
Thank you for the code, I will take some time to go through it and then replace my function with it.


Those pesky docs don't complain when they refer to non-existent options


Just a general comment on catch....

What a fine job you have done, this is easily the most useful and quickest to implement unit test libraries I have ever used.

Boss...seriously....catch is the business!!!!


gbkh


More doc to remove


Looks sane.


Woops!


RemoveMoreBadCharacters (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Okay guys thanks for your participation now all we have to do is make sure everything is in line get to it so we can start getting into revenue.


In the future, please use Q_FOREACH instead. Otherwise the whole commit looks good.


Don't we all wish to run our papers as code...


This causes issues when importing other contents of the directory which are not in openupgradelib


No tests?


easier to merge and rebase if your make things like this a separate PR :)


:p


Done there https://github.com/m-labs/artiq/commit/8669f1d61db7cacc676db464ffbcd54b76e3e8e0


Yep that makes sense.


Ok. Now I see what you meant (mostly thanks to your IRC comment). It failed to notice this in the previous **BIG** commit you wanted me to review.


This what i could achieve sir.


Its mkfs.type
Alternatively we could call mkfs -t type which just looks for mkfs.type in common binary locations and runs that. I figured we could skip the middle-man


I know :) Just wanted some initial feedback before cleaning up for the PR. Email and comment did just that :) Now I know the extra work wouldn't be a total waste at least!


There isn't a generic way to do async in .net. Currently there are 3 patterns, each used in different .net versions. Tasks go from .net 3.5 SP1 and are the preferred way. As we discussed before, we want to support all .net versions, so Tasks won't do. What do you think about an event then? Something like:

realtimeClient.TimeAsync();
realtimeClient.TimeCompleted += (time) => ....;


> I'm surprised to see --decrypt here when I expected --verify.

Weirdly, `gpg` overloads `--decrypt` to mean "verify this non-detached signature and then output its content". I guess in general they think of `--decrypt` as meaning "extract data, whether it's encrypted or merely signed".

> GPG exits with success if it sees ANY valid GPG signature, rather than a signature that covers the entire document.

Surely that is something that applies only to detached signatures and `--verify`? How exactly would you construct a non-detached signature that contains extra data that isn't signed? It seems like clearly a security problem in gpg itself if it accepts such things.


You forgot to commit the header files for BtConstModuleList and BtModuleList.


Function return type should also be int64_t


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - x86_64-MacOS-10.9-clang: OK (1786 of 1790 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


if we go that way, the slugged value must be from the same function, and I don't think it's currently the case especially regarding the versions: slug('3.8.1') = '381', slug('plugin name') = 'plugin-name'

Also, the slug methods would have to be in sync between the DB and WPScan


oh right!


Did you accidentally remove the Perf_trace ifdef? It's in the main branch.


This looks like a chunk from some other commit.


FWIW I can drop the .jshintrc, but I saw a (pre-existing) global that I missed in my last pr, as well as an unused `require('async')` so I figured it'd be useful.


По сути лишне, плок сам по себе не имеет заливки


@NicholasBuse No problem!


Концептуальная весч
Блок е должен отвечать за своё позиционирование, он знает обо всём что твориться у него внутри.
О внешних отступах должен позаботиться его родитель, по сути то место куда этот блок вставляется.
P.S. В разных местах он может позиционироваться по разному, где то по центру, а где то нет


См выше


And I only see `BtConstModuleList` being used, but not `BtModuleList`.


Thank you for this


Sounds good, thanks for following up!


The underlying problem is that your build system is something other than
Xubuntu 14.04.  Please remedy this. And see #91. -Joe

On Tue, Aug 11, 2015 at 3:18 PM, Yann Sionneau <notifications@github.com>
wrote:

> It's not a need, it's just that my linux-64 build machine happens to have
> a recent GLIBCXX (Debian Jessie).
> So when using the package on Ubuntu LTS it does not work, unless you add
> the ppa repository as I did.
> Is that an issue?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/m-labs/artiq/commit/075bf331ac440dcab49ee73a522acfe2230a0104#commitcomment-12651235>
> .
>


:hankey:


thanks, fixed!


Лишняя пустая строка


Опять 25


И тут не нужно


{ на одной строчке


4 пробела


и тут тоже


лишняя


@zhiyuli - It seems to me the two models fields that you have for the RefTimeSeries class are not used anywhere. If you can make sure these fields are not needed (I think the metadata model class ReferenceURL is being used in place of those 2 fields), then this class can be a proxy class like other resource type classes as part of the resource class refactoring that @ironfroggy is doing.


смотри выше


А вот между правилами можно и впихнуть пустую строку, дабы отделить


Prototypeに関してはimageをprototypesテーブルが持つのではなく、他にcaptured_imagesのようなテーブを作りアソシエーションを定義しましょう。加えて、prototypeはタイトルとイメージだけは寂しいので本番のProtospaceを見て、もう少しカラムが追加できないかを考えてみましょう。
Userに関しても、同じでプロフィールに関してのカラムを幾つか追加してもいいかもしれません。
今回のProtospaceは投稿されたプロトタイプに対して評価をするものではないので、モデル名はReviewではなく、Commentの方がいいかもしれません。

DB設計のところに曖昧な部分を残してしまうと後々の実装で苦労することになるので、きちんと定めてから実装に入るようにしましょう！


@steeef can you please make this change available in `master` branch of your fork?


You probably want to add .ToLower() here, so the name comparison below both have the same case.


I'm sorry but I don't understand what are you talking about.
TR_* are just used as a value for `return`. Why are they related to CHECK_PART?


After the `CACHE_TIMEOUT`, new tabs opening will send a `PING` to the master, and then write out the appropriate settings to `localStorage` again.

Currently the way it works is if `localStorage` says it's supported (`util.keys.SUPPORTED_KEY` returns `true`), it means that a new secondary tab at some point successfully connected to another tab's master, meaning that the browser environment is capable of communicating over `localStorage`. If it's set to `false` then a new secondary tab was unable to successfully communicate over `localStorage` (or it timed out).

I picked 10 minutes because it seemed like a decent general session period. The penalty for having it lower (like say, 0 seconds) is that new tabs will need to do their `PING` RTT each time a new tabs opens. This is generally like 50ms, but it's 50ms that doesn't need to be spent. Similarly, I didn't want it more than a session (like the current indefinite time period), because if it incorrectly failed to setup correctly crosstab would never work for that user on that domain (unless `localStorage` was cleared).


delete


Five blank lines?


close it soon and  I will support it  after i'm free


the message say 150 but you are subtracting 100, your method looked like wrong ;)


Great


You know I've got a g4 repo right? http://github.com/lg-devs/android_device_lge_g4-common


Adding login_required doesn't work. It gives the following error. I did
add a check that it is indeed an ajax call.

Traceback (most recent call last):
   File
"/home/alain/projects/irrigator_pro/irrigator_pro/VirtualEnvs/irrigator_pro/lib/python2.7/site-packages/django/core/handlers/base.py",
line 111, in get_response
     response = wrapped_callback(request, *callback_args, **callback_kwargs)
   File
"/home/alain/projects/irrigator_pro/irrigator_pro/VirtualEnvs/irrigator_pro/lib/python2.7/site-packages/django/utils/decorators.py",
line 29, in _wrapper
     return bound_func(*args, **kwargs)
TypeError: _wrapped_view() takes at least 1 argument (0 given)

On 08/13/2015 09:51 PM, Gregory R. Warnes wrote:
>
> get_fields_list() and get_users_list() in notifications_setup_view.py
> should have the @login_required decorator so they can't be without
> authentication.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/warnes/irrigator_pro/commit/b50381cf4cb466bcb61a4f34efa789495c8cae89#commitcomment-12703158>.
>


TeamCity pull requests :: netty [Build 31](https://garage.netty.io/teamcity/viewLog.html?buildId=324&buildTypeId=pulls_netty&guest=1) is now running


emplace_back isn't present in gcc 4.4


ss


TeamCity pull requests :: netty [Build 31](https://garage.netty.io/teamcity/viewLog.html?buildId=324&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 3481, ignored: 6; exit code 1 Build time: 00:04:12


TeamCity pull requests :: netty [Build 32](https://garage.netty.io/teamcity/viewLog.html?buildId=325&buildTypeId=pulls_netty&guest=1) is now running


Actually, while walking through the code, this made sense. But now, just reading the test, I have no idea why this would pass.


93653360-ResetVarsAtEndOfWarmup (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 750 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.24%25-green.svg)


`return result` ?


I don't understand this comment or why you are doing this... Can you make this more explanatory?


closes #64


TurnOffWarmupReportForRevDD (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


zdhsdh


missing a bunch of + signs? `/^([a-z_-]+)\\.([a-z_-]+)\\.([a-z_-]+)$/i`

A - at the start or end of a character class is handled differently.
[a-z]+ matches "abcd...xyz"
[a\\-z]+ matches "aaaazz---"
[a-z\\-]+ matches "abcdef...xyz\-"
[a-z-]+ matches "abcdef...xyz-"

I personally prefer message.split('.').


dsfggdfg


do you know when the new version with this new autoDownloadService and the
ability to use show files and play from duckie tv will be released.

Tried my hand at building a standalone from github but didnt get anything
functional.

With those 2 features I will be one happy camper!

On Thu, Aug 6, 2015 at 6:42 PM, garfield69 <notifications@github.com> wrote:

> re: #476 <https://github.com/SchizoDuckie/DuckieTV/issues/476> @shadycady
> <https://github.com/shadycady> re: your question about how often the new
> episodes are checked for available download: the answer was every 2 hours.
> But this change just implemented changes that to every 15 minutes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SchizoDuckie/DuckieTV/commit/e736fdab50568ee0517cb163daf072850ddd3b3a#commitcomment-12579133>
> .
>

--
Travis Cady
Carpe Diem, Quam minimum credula postero


I don't understand why you would want to use `that` instead of `this`?


TeamCity pull requests :: netty [Build 32](https://garage.netty.io/teamcity/viewLog.html?buildId=325&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 3142, ignored: 6; exit code 1 Build time: 00:03:50


First iteration towards fixing #5


PseudoAttacks[ROOK][blockSq] represents the 14 squares that would be attacked by a Rook on blocksq on an empty board.

Old line 615 should give you some ideas on how to do this correctly.


This comment heading style feels out of place


Should 300 be defined as a constant?


awesome job!


Tests added towards resolving #1


I want to merge this branch into 2.8.x stable version, is that ok?


I think this does not need to be `isRequired`? We are anyways setting it in `getDefaultProps `!


This is the change that I made base on the disucssion with Victor in #14


fix-window-frame-calcs-5095 (nealkruis) - i386-Windows-7-VisualStudio-12: OK (1795 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


从未见过如此厚颜无耻之人


@nastys  Clumsy, haha. The code is still okay though, right? This isn't gonna break anything, correct?


lgtm


*vectors


`Iterator[(VertexId, Map[VertexId, Long])]` makes more sense?


Wow, this is quite a complicated and difficult to parse conditional.


Is there any reason to have the hex representation of the result code here?


Hi Xiao Peng. Take a look at pull request #15. I made similar changes too. Not sure what that does with the merge if there will now be conflicts because of this commit 😃


Consider using Scala Option[T] rather than special values like NaN and minValue - much more Scala-like.


@lavanoid It just made one meaningless history. It's OK if he will be careful from now on.


why are you creating an android app for ion when [one already exists](https://github.com/el1t/Iolite)?