```
function T.SkinNextPrevButton(btn)
	local normal, pushed, disabled
	local isPrevButton = btn:GetName() and (string.find(btn:GetName(), "Left") or string.find(btn:GetName(), "Prev") or string.find(btn:GetName(), "Decrement") or string.find(btn:GetName(), "Back"))
	local isScrollUpButton = btn:GetName() and string.find(btn:GetName(), "ScrollUp")
	local isScrollDownButton = btn:GetName() and string.find(btn:GetName(), "ScrollDown")

	if btn:GetNormalTexture() then
		normal = btn:GetNormalTexture():GetTexture()
	end

	if btn:GetPushedTexture() then
		pushed = btn:GetPushedTexture():GetTexture()
	end

	if btn:GetDisabledTexture() then
		disabled = btn:GetDisabledTexture():GetTexture()
	end

	btn:StripTextures()

	if not normal then
		if isPrevButton then
			normal = "Interface\\Buttons\\UI-SpellbookIcon-PrevPage-Up"
		elseif isScrollUpButton then
			normal = "Interface\\ChatFrame\\UI-ChatIcon-ScrollUp-Up"
		elseif isScrollDownButton then
			normal = "Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Up"
		else
			normal = "Interface\\Buttons\\UI-SpellbookIcon-NextPage-Up"
		end
	end

	if not pushed then
		if isPrevButton then
			pushed = "Interface\\Buttons\\UI-SpellbookIcon-PrevPage-Down"
		elseif isScrollUpButton then
			pushed = "Interface\\ChatFrame\\UI-ChatIcon-ScrollUp-Down"
		elseif isScrollDownButton then
			pushed = "Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Down"
		else
			pushed = "Interface\\Buttons\\UI-SpellbookIcon-NextPage-Down"
		end
	end

	if not disabled then
		if isPrevButton then
			disabled = "Interface\\Buttons\\UI-SpellbookIcon-PrevPage-Disabled"
		elseif isScrollUpButton then
			disabled = "Interface\\ChatFrame\\UI-ChatIcon-ScrollUp-Disabled"
		elseif isScrollDownButton then
			disabled = "Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Disabled"
		else
			disabled = "Interface\\Buttons\\UI-SpellbookIcon-NextPage-Disabled"
		end
	end

	btn:SetNormalTexture(normal)
	btn:SetPushedTexture(pushed)
	btn:SetDisabledTexture(disabled)

	btn:SetTemplate("Overlay")
	btn:SetSize(btn:GetWidth() - 7, btn:GetHeight() - 7)

	if normal and pushed and disabled then
		btn:GetNormalTexture():SetTexCoord(0.3, 0.29, 0.3, 0.81, 0.65, 0.29, 0.65, 0.81)
		if btn:GetPushedTexture() then
			btn:GetPushedTexture():SetTexCoord(0.3, 0.35, 0.3, 0.81, 0.65, 0.35, 0.65, 0.81)
		end
		if btn:GetDisabledTexture() then
			btn:GetDisabledTexture():SetTexCoord(0.3, 0.29, 0.3, 0.75, 0.65, 0.29, 0.65, 0.75)
		end

		btn:GetNormalTexture():ClearAllPoints()
		btn:GetNormalTexture():SetPoint("TOPLEFT", 2, -2)
		btn:GetNormalTexture():SetPoint("BOTTOMRIGHT", -2, 2)
		if btn:GetDisabledTexture() then
			btn:GetDisabledTexture():SetAllPoints(btn:GetNormalTexture())
		end
		if btn:GetPushedTexture() then
			btn:GetPushedTexture():SetAllPoints(btn:GetNormalTexture())
		end
		btn:GetHighlightTexture():SetTexture(1, 1, 1, 0.3)
		btn:GetHighlightTexture():SetAllPoints(btn:GetNormalTexture())
	end
end
```


Better to cache the state in RB_BindFrameBufferObject


why?


Did the above unchecking code cause errors? Just for curious.


make sure to search within context


Fair enough.


Can we group these objects? There is a lot of redundancy, which could be eliminated by providing a function to instantiate a  ``DataTypeCreator``.


do like we talked about and make these on their own lines since the chain is so long


how would we get `HAVE_ICU` on RIOT? Leaking pkg-config?


True. Just seems like a random change to introduce.


Because `DataType` is a case class (so it would not be proper to extend it) and I'm eventually planning on adding support to `DataType1 to have `ScalaType` and `SQLType` as generic types, but that would have made this PR much more complicated.


Why do prefer this approach instead of resources/resource?


how would you `HAVE_GTK` on RIOT?


What does it change?


```
answer = SurveyAnswer(question=question, data=...)
submission.answers.append(answer)


how would you `HAVE_UDEV` on RIOT?


`f` is a quick functional instantiation to avoid having to implement the trait.


"Apple Developer" spelling mistake corrected


We should not ignore the ``DataType`` here.


this is optional in either case since you link it with an already-added object (submission, question), but if you go for the thing i just suggested i'd remove it since it's absolutely clear that you are adding a new object even without that call


That's a good point, this could be simplified.


Ok, sounds good :) Feel free to move ahead with this PR, though it feels like we're missing something here.


i don't like that title very much. What about title=Survey, subtitle=survey.title?


Please consider to use following commit message: "Fix the typo of mininet.cluster module import".


@SharkHunter Still I am waiting for implementing PR from 28 Apr 2013 :+1:
Nevermind, now with new commits from Nadahar I have to rewrite CSFD plugin again as recently CSFD.CZ page changed so some info is not retrieved.
Hopefully when I will do new PR (hopefully this week), it will be merged.
Btw. I found another fix I made and missed to create PR to your codebase so will try make new one also for it (replacement of deprecated code, timeouts due to nonexistent www.newzleech.com,...)


I'm not sure what was the intention of this change, but it breaks the behavoir of the env lookup.

The output of `lookup('env','HOME')` seems to be an array with 4 empty elements (`,,,`), instead of the locaton of the home folder.


just "Surveys" sounds better in my opinion


Can we get rid of the casts?


Though I agree, I was having a hard time logically determining equality.


I meant only a single column with `colspan="4"`


Commit is named "Create index action and view" but there are also seeds, ability, some side bar modifications. It's not good.


one space too much after `and`


Look at the commit code (https://github.com/navnorth/LRphpLib/commit/0af8c7654613663d04ed29bbc27817419498d0ec). I bet you got an email and didn't get the context


Can we have a comment here explaining why `1.4`?


No objection at all, looks good.


nope c'est pour faire un build sur travis et voir si coveralls fonctionne (https://travis-ci.org/SchawnnDev/LdCt-Cosmetiques)


any reason why the `was_survey_submitted` check is not part of `can_submit`?


I liked the previous syntax better. It also created less objects.


Unfortunately not. Getting an object from a `ResultSet` comes back as `AnyRef`.  Good old Java.


The network refresh works now. However, clicking the profile tool:

Traceback (most recent call last):
  File "/home/web/.qgis2/python/plugins/qgepplugin/tools/qgepmaptools.py", line 121, in canvasReleaseEvent
    self.leftClicked(event)
  File "/home/web/.qgis2/python/plugins/qgepplugin/tools/qgepmaptools.py", line 339, in leftClicked
    QgsPoint(snapped_point.snappedVertex))
TypeError: append() takes exactly one argument (2 given)


It builds fine, but:
> Start testing of Freeciv-web using CasperJS:
> Freeciv-web CasperJS tests failed!

Any logs where one could see what fails there? That commit makes the difference to the freeciv server that compiled-in metaserver is "http://localhost:8080/meta/metaserver.php"


dafault?


Ref #851 .


thanks for pointing out! - I will amend


This is a test and I can't imagine any scenario where you'd use this in normal operation. This technically creates one additional light-weight object.


develop (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Aqui acho que é "File listing options"

Aliás o nome da classe está errado, deveria ser `FileListingOptions` =/


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


the stack trace should be optional via a flag... the buffer can be huge and seeing an enormous stack trace isn't helpful when you can't even find the start of the message.


resources :orders ?


das muss weg


Hi m,

I just commit the 4.2 patch. It could work well with my host. So could you test it with heavy work please?

BTW, you could file another issue if there were some issue. It is better to trace than using this case.


das ist super!


Tell me if the changes are ok for you and that it follow the vision you had for that function.
I also tested the function a little, doesn't seems buggy from my little testing.


Thanks :)


Fiquei em dúvida aqui. Pois a conta não é do workspace, mas o workspace pertence a uma conta.

Talvez pudéssemos mudar pra "VTEX account name" ou algo assim que seja desvinculado do workspace.


Do you mean exception trace or error message backtrace?


This is also compatible/tested with Windows XP


@tfoote, @dirk-thomas , how did that typo get in without catkin saying anything ?


For backwards compatibility, can you change the default to `True`?


try to keep sql-generating construction in model layer. in scopes or methods


Although overflow is possible, it has no security consequence. The same size value is used for allocation and for the loop that operates on memory.


I implemented your suggestion, then immediately realized a problem.

It's fine to say close() should be called during normal operation.  But it gets more complex once you consider exception-safety.  The problem case is when you just want to raise an exception and die.  (If users catch an exception at some point and then do something else, I could understand keeping `close()` compulsory in that case).  daemon threads look purposely designed for this problem.

Standard python _looks_ like it works fine in this case if you implement `__del__()`.  Now users don't have to call close explicitly, maybe you don't need `close()` methods at all!  My friend at uni thought this, whereas I a) didn't expect python to be special here b) read all the [highlighted warnings about destructors](https://docs.python.org/2/reference/datamodel.html#basic-customization).


This breaks a lot of reports.


Please consider to use following commit message: "Make bridge names are accordance with node names, rather than static ones".


This probably breaks a lot of reports.


眼花不小心看到《规范》示例3.6节那个示例了


This is not necessary.


On localhost  dont found http://prntscr.com/83ss9x
Same error, where i have to put the passwords.txt ?


Ok, and what about the remaining main.py file ? Seems well reviewed.


Yes, the dependency resolver checks for all pkg-config stuff regardless of OS. I have plans to fix that, if @dorileo didn't get to it already, but I wanted things working soon rather than keep delaying it on a cascade of unforseen things.


What visual differences?


inside member fun too?


it's no error, just a warning that logging won't work correctly. To resolve this add to src/main/resources this file: https://github.com/jirkapinkas/java-blog-aggregator/blob/latest/src/main/resources/log4j.properties


ok


Does this work across browsers and ATs?


Please provide tests.


here you get request duplication. ```#update``` and then ```#save```
You can prevent it


Yeah, some kind of exception might be in order here.
On Aug 11, 2015 11:46 PM, "Arnaud Barisain-Monrose" <
notifications@github.com> wrote:

> Just like the commit right after this one, I think it's better for the
> functions to check their input and fail gracefully if their input is null
> or invalid, rather than having to think about checking the arguments before
> using the function :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/abarisain/dmix/commit/fea3b9e2d2564e57aca97a0218c10b508b237f2d#commitcomment-12657413>
> .
>


OK。虽然我也喜欢汉字编号，但是规范前面很明确的写了用阿拉伯编号。这规范真TM不规范。


LGTM.


It is not necessary to commit the .idea folder and binary files *.class and *.jar


it looks like hardcode. create methods like ```#confirm```
Also you should check this gem https://github.com/aasm/aasm . It could be very useful when you have states


I added general prefix by looking at following code. General prefix is added if property does not have any predefined section.
https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/controller/maintenance/SettingsProperty.java#L31


Neither bspwm nor sxhkd load global configuration files by default, only user specific. The defaults are $XDG_CONFIG_HOME/sxhkd/sxhkdrc and $XDG_CONFIG_HOME/bspwm/bspwmrc. Therefore installing files to /etc/skel is closest thing to automatic available. If I knew how I'd like to make the PKGBUILD print a line upon installation, which would tell where the default config files are found.

I can install them to /usr/share instead, but I think /etc/skel is better. The best would be to install them to /usr/share and then copy them to users home folder if the files do not exist. But I don't know how to do that (because packages are installed as root) nor do I know if it is considered good policy.

So maybe install them to /usr/share AND have notification?


`.format()`


Ruby


Can automatically identify the direction of arrow.


copy/paste spotted


You can do better than that. Max line length 100.


May I ask why this is now >= 5.6.0 instead of the previous >=5.5.0? I know it's recommended to use 5.6, but are there any technical requirements certain 5.6 features that are being used?


I did this change as a test and I am doing this comment as a test.


depending on the code structure, it sometimes is possible to solve this with a context manager ("with" block) or try/finally.


Does this fix it for you? I still have the same compilation errors?


Here's a line comment.


//It need a logic placed on arma 3 editor named "CENTER"


typo: "given"


Teria uma forma de descrever esse parâmetro como uma mensagem indicando que efeito essa alteração traz?

Pois *Description of the changes* deixa aberto a ser uma coisa de muito baixo nível, tipo *Altera valor da propriedade foo para "bar"*. E o que a gente quer é que essas mensagens sejam descritivas para quando o operador da loja precisar ler os **ChangeSets**, algo como *Configura o componente banner*.

Acho que posteriormente devemos ter na nossa documentação externa dicas de como essa mensagem deve ser, mas aqui podemos ter uma descrição mais clara do que deve ser passado para parâmetro.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.452.ce2e9089674008f6718ab47c68e297e3f7d0cef5](http://build.palaso.org/viewLog.html?buildId=61015&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3306, ignored: 132 Build time: 00:06:19


Yes it is!

"the form name" just before it is also ambiguous.

Like all Yii documentation, it's purpose is to educate the user on *use of* the method, not to be the method's formal functional specification. The Yii way is to encourage the user to read The Source to discover exact behavior.

This was the best compromise I could find at the time.

How about: "If there is no form name then load() ..." ?


Did you intend to check this change in?


Nit: IIRC, sometimes `auto` works better than 100% for width because it avoids issues with borders making things wider than 100%.


@rrati question.  Should i know about this struct as an end user?  Not sure how i should set some of the fields when requesting to make a first lock... (like AcquiredTime, RenewTime)  .


Why don't you just reuse that class?

On Wed, Aug 12, 2015 at 6:04 PM, Namrata Nehete <notifications@github.com>
wrote:

> I added general prefix by looking at following code. General prefix is
> added if property does not have any predefined section.
>
> https://github.com/openmrs/openmrs-core/blob/master/web/src/main/java/org/openmrs/web/controller/maintenance/SettingsProperty.java#L31
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/namratanehete/openmrs-module-webservices.rest/commit/4f1174a75817b03df95cbeec64872c1a39c9e5dc#commitcomment-12666738>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


You can have a specific method to select the account lookup


A function ``T => T`` is commonly called the identity function. I prefer to group types for better readability and IDE support (i.e. tab completion).


This is where I threw in a tiny change to the top link for taxing without a V11 and failed to improve the content supplied ... result was a simple and understood option became difficult for people to grasp and caused many problems.


Acho "Set of file changes" mais curto e claro (mantendo o "See FileChange for more information")


//This script randomly creates 10 markers with 10 triggers on towns.
//It requires a logic named "CENTER"
if ( !isDedicated && hasInterface ) then {

					for "_i" from 0 to 10 step 1 do {_gamelogic = CENTER;
					_towns = nearestLocations [getPosATL _gamelogic, ["NameVillage","NameCity","NameCityCapital"], 25000];
					_RandomTownPosition = position (_towns select (floor (random (count _towns))));
					_m = createMarker [format ["mrk%1",random 100000],_RandomTownPosition];
					_m setMarkerShape "ELLIPSE";
					_m setMarkerSize [300,300];
					_m setMarkerBrush "Solid";
					_m setMarkerAlpha 0.5;
					_m setMarkerColor "ColorGreen";

					_tr = createTrigger["EmptyDetector", _RandomTownPosition];
					_tr setTriggerArea[300,300,0,false];
					_tr setTriggerActivation["ANY","PRESENT",true];
					_tr setTriggerStatements["this", "isPlayerExposed = false;", "isPlayerExposed = true;"];

					};

};
waitUntil { time > 0 };

//Server
if (!isServer) exitWith {};


Looks like he's forgotten about this. I was going to make a PR, but you beat me to it!


@prawnsalad What's a *slideout*? I don't know how could I translate `Show the autocomplete slideout` in poeditor.com...


You'll want to change that to:

log.info("Timed out when %s", timeout_msg)

That's what the jenkins test is complaining about.


Maybe add a comment stating why this is hard-coded to 15? Do we need to do something else here?


Pls notice, that if you remove one port from veth pair, the second port will be removed automatically — that's the kernel behaviour. So the attempt to remove the second port will raise an exception.

And if you open a netlink socket with `IPRoute()`, it would be cool to close it thereafter — `ipr.close()`, to avoid FD leaks.


this is not Null-able correct?


Ah, ok, we need a way of getting `Services.prefs.getIntPref("browser.newtabpage.rows")` and friends from parent process.


When should we use `pkgshare` instead of `share`?


I think a slightly better regex here would be `/(\r?\n)+/`.


You can set them to whatever you want since they are managed internally. :)  Best to leave them blank.

I would like not to have those exposed at all, but if I don't expose them in the api then kubectl can't display the information I don't think.


Well, ``SQLType`` (or ``DBType``) has exactly the same signature as ``f``.

Why is ``f`` taking a parameter called ``f``? This could be named better.


Yes I will reuse this class. Thank you.


I'm talking about the object that gets printed when an exception is thrown. for example:

```[vagrant@me vagrant]$ php tests/vendor/bin/phpunit
PHPUnit 4.8.3 by Sebastian Bergmann and contributors.
Warning:	Deprecated configuration setting "strict" used

<pre>Mage_Eav_Exception Object
(
    [_messages:protected] => Array
        (
        )

    [message:protected] => Wrong attribute set ID
    [string:Exception:private] =>
    [code:protected] => 0
    [file:protected] => /vagrant/app/Mage.php
    [line:protected] => 588
    [trace:Exception:private] => Array
        (
            [0] => Array
                (
                    [file] => /vagrant/app/code/core/Mage/Eav/Model/Entity/Setup.php
                    [line] => 318
                    [function] => exception
                    [class] => Mage
                    [type] => ::
                    [args] => Array
                        (
                            [0] => Mage_Eav
                            [1] => Wrong attribute set ID
                        )

                )

            [1] => Array.......
```

It doesn't happen all the time, sometimes it's just a basic stack trace


This seems to break getCurrentFileName in windows causing it to return null - i think the easiest way to see an example of this is just to do ```echo %(editor.name)```


Main device tree files are gotten from balika011. Thanks to him!


//This script randomly creates 10 markers with 10 triggers everytime it executes.
//Use alogic named "CENTER" for it to work
if ( !isDedicated && hasInterface ) then {

					for "_i" from 0 to 10 step 1 do {_gamelogic = CENTER;
					_towns = nearestLocations [getPosATL _gamelogic, ["NameVillage","NameCity","NameCityCapital"], 25000];
					_RandomTownPosition = position (_towns select (floor (random (count _towns))));
					_m = createMarker [format ["mrk%1",random 100000],_RandomTownPosition];
					_m setMarkerShape "ELLIPSE";
					_m setMarkerSize [300,300];
					_m setMarkerBrush "Solid";
					_m setMarkerAlpha 0.5;
					_m setMarkerColor "ColorGreen";

					_tr = createTrigger["EmptyDetector", _RandomTownPosition];
					_tr setTriggerArea[300,300,0,false];
					_tr setTriggerActivation["ANY","PRESENT",true];
					_tr setTriggerStatements["this", "isPlayerExposed = false;", "isPlayerExposed = true;"];

					};

};
waitUntil { time > 0 };

//Server
if (!isServer) exitWith {};


Não precisamos documentar campos privados.


Idem.


@vrabaud `catkin_pkg` does not check the XML against a schema. It only checks the tags. Therefore this text block beside the tags is not noticed.

@tfoote please fix it anyway


I never had any issues with that (only in connection with macros). I would still prefer inner classes over to cluttering the namespace.


unit tests indicate end users only set 2 out of 4 fields... so maybe a comment that AcquiredTime and RenewedTime don't need to be set?


Thanks to balika011.


You can rename imports, e.g. ``import java.sql.{SQLType => JDBCType}``


Examples are the big case.

We discovered the potential for accidental conflict on formula that install examples into `share/examples` because those are then symlinked together into `HOMEBREW_PREFIX/share/examples`. Examples can be called some hilariously generic things like `example.c` and we were running the risk of introducing accidental conflict between formulae for the sake of examples. `pkgshare` ensures those examples can never run into each other.


For the record, the default list is: `['get', 'put', 'post', 'delete', 'head', 'options', 'patch']`.


Filed bug #5.


for the record, i'd prefer remove this always-timeout test. as it is pretty much a non-feature, so we can even break it without regret. (although not likely)


Be so awesome if we can kill XHTML use altogether :).


lp:epics-base/3.16 commit 12663


Yeah – the line was too long. This is one of those things where I don’t think we have much guidance in terms of Scala style. The style guide doesn’t say much, so I just fall back on Emacs’ behavior, which generally follows the official style guide well.


related to bug #5


This is awfully broad. Now everyone's Git is affected, not only the Git of people who want to build MSys2 packages...


remove abstract, use patern:
https://github.com/cloudband/jclouds-1/blob/1.8.x/apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/options/ListVolumeOptions.java#L75


To keep things in sync, any code outside this method interested in the calculation status should be only using pidfile's metadata (i.e. no get_cached_conc_sizes() calls).


Chỗ này anh nghĩ cần phải xóa đi luôn, không cần để lại nữa...


A few examples here please


Line comment here. :D


That's the list of autocomplete options that slides into view when pressing tab. Could be called a panel if that's better?


@victorlevasseur That's ok: it's indeed a bit more complicated but:

1) The interface of the class is no more complicated to use than before,
2) It avoids a lot of code repetition,

so it's better now :)


We need to test for much more to ensure that we are running inside an MSys2-based Git. `__MINGW32__` is defined for msysGit-based Git for Windows 1.x, for example, which wants to have the prefix `/`.


no @Nullable parameters for sure?


Nit: drop the false. Default to `false` regardless and no one knows what it does:)


Thanks :smile:


In the section `OWNER ENTITIES MULLIGAN ACTIONS`, you wrote this message down: `useAbility`. While this is useful information, it is a little confusing: this is a list of all *received* messages, and `useAbility` is a sent message. It is fine if you keep this here, but it should be made very clear which ones are being sent and which are being received, and when you are aiming to show what is sent and when you are aiming to show what is received.


Xóa phần này đi cũng được, nó chỉ là ocmment thôi


Please add a comment explaining what the regex does.


i like combining these on one line

  if found, ok := d.detailedStatNames[bucket]; ok {
    return found
  }


ok anh


Move the `let` to the while loop?


A vital part of my Kensai strategy was copious use of Shield Amulet, if you're asking about that.
Anyways, while I agree that widespread recharging is imbalanced, there are store recharging flags both in GemRB and ToBEx, thus some of balancing mods must have adressed that (although none that I use, strangely). Unpatched BG is cheesy in many other ways, too, but that's just how it is. I say it's more efficient to leave modding to modders.


Instead of ``f`` taking two parameters, I would create a trait with two separate functions.


Tilde Police checking in


lgtm


Thanks! It's a classic example of `IVar`s, except that trying to read an `IVar` that has not been written to will give an error instead. The question here is whether things can be arranged in such a way that it will be written as soon as you try to read it, but delayed otherwise. But I think I can think about this later.


Pode adicionar aqui:
```csharp
/// <exception cref="ArgumentNullException">Thrown if connector is null.</exception>
```

A classe base `GalleryClient` faz isso.


Thanks


What is the difference with 10th line?


97204612_MultiSpeedFan (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1277 of 1279 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.8%25-green.svg)


remove abstract see:
https://github.com/cloudband/jclouds-1/blob/1.8.x/apis/openstack-cinder/src/main/java/org/jclouds/openstack/cinder/v1/options/ListVolumeOptions.java#L75


Does this commit fix the camera force close? I've been following the dev for a while, but I can't make a build at the moment (computer is down for maintenance) otherwise I'd test for myself. Also thanks for all the hard work all of you have put in!


I love the idea.  Many other package management tools have this abstraction layer.  However,  this particular patch doesn't seem like it'll handle the use-cases where the package name differs across various distros.

The easiest example I can think if, would be apache.
redhat familiy,  the package name=httpd
debian family, the package name=apache2

If this actually has been accounted for, the documentation should reflect that.  If it hasn't, the community will probably need to determine a "best practice" to work around it until ansible fixes that use-case.


Absolutely. I believe in this case the "%sa" is the first half ("%sb" being the peer), so it shouldn't raise an exception (Yonghong please confirm).


`git blame` is your friend to learn why it was originally done. In this case, it revealed e5ca0bb6d2a67c30080f55f6adc7707635b4905b, which claims it was to gain access to the (then-new) `StaticSwingUtils.scrollToBottom` method.

I should have done it as a property though, instead of directly in the dependency declaration.

Anyway, it was intended to be temporary and should definitely now be removed.


File listing options


I looked around for a definition of *slideout*, but I couldn't find it (eg. http://www.oxforddictionaries.com/spellcheck/english/?q=slideout ). Thanks for explaining what that word means  :wink:


Well, two typed values are only the same if they have the same type and the same value. If you delete the ``equals()`` method, Scala will create it for you.


redundant spacing see:
https://github.com/cloudband/jclouds-1/blob/1.8.x/apis/openstack-heat/src/main/java/org/jclouds/openstack/heat/v1/domain/Stack.java


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.453.fdd7b29b073a02772fc4271b3f49f064b39f20ad](http://build.palaso.org/viewLog.html?buildId=61016&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3306, ignored: 133 Build time: 00:04:55


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2195 of 2232 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.34%25-yellow.svg)


It took me about ~15 minutes to create the file


not sure if you care much, but this behaves differently than the other one (which goes to the end of the payload)


bushihe


LGTM! Thanks, Trav :)


Ough, mea culpa — it was a reaction to the loop :)

Then it's ok.


Not sure whether *curves* is a clearer name. Any particular reason for the change?


Could you please make a next version with new traceur? NPM doesn't see your changes without it.


This will work fine as long as BES_VERSION is 9.2. Otherwise the major version needs to be considered for the path.


Right. We do a look up for "%sa" and remove it if it exists. We never try
to lookup/remove "%sb".

On Wed, Aug 12, 2015 at 8:24 AM, Brenden Blanco <notifications@github.com>
wrote:

> Absolutely. I believe in this case the "%sa" is the first half ("%sb"
> being the peer), so it shouldn't raise an exception (Yonghong please
> confirm).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/iovisor/bcc/commit/83f800f6508d273b8ed954f9b83efca10c7349f2#commitcomment-12667265>
> .
>


Hopefully not that long. The addition of the ugly link will, I hope, spur the correction of this issue.


rawSize := binary.BigEndian.Uint32(payload[s.pos:s.pos+4]


remove abstract


easiest method is to change the username and password you want in the UsersTableSeeder file, rollback your migration and refresh. You'll then be able to log in with the user you provided.

php artisan migrate:refresh


lgtm


It is induced by `fg/parkour`, wich requires some of the features from 5.6.
I hesitated to make this move but I thought it would be ok to start fresh for a new version.
Are you running a 5.5 environment ?


But your conversion is not even well-defined. We want to cast ``value`` to ``DataType``'s underlying JDBC type.


I miss quite a bit context in the commit message. I would like to believe that the documentation on commit messages [I wrote recently](https://github.com/git-for-windows/git/wiki/Good-commits#commit-messages) summarizes it nicely: you want to describe the *why* and the *what*.

For example, you *definitely* want to spell out the exact commands "to link /mingwXX/bin/git to /usr/bin/git".

And while I can guess from the context that you want to build MSys2 packages from `/usr/src/MSYS2-packages/*` and avoid having to install MSys2 Git (i.e. the `git` package) in addition to `mingw-w64-<arch>-git`). But I should not have to guess after reading the commit message, it should tell me.

I also wonder whether this is the correct approach to begin with. Would it not start to work magically if we appended `/mingw<bitness>/bin/` to the `PATH` variable? I.e. something like

```sh
PATH=$PATH:/mingw64/bin makepkg -s
```

should work, no?


No veo ningun cambio en el comportamiento.
En local sigue siendo http y en heroku se puede ver la contraseña en herramientas de red, POST params


Probably [NullPointerException](http://javadoc.imagej.net/Java/java/lang/NullPointerException.html) is the most appropriate thing to throw here.


Lol, at first I expected no one to download this, but it grew so I fixed it.


If you think I broke something, please explain what it is so it doesn't happen again. I changed comments only, as I just verified again. Best not to throw accusations in commit messages, which are a permanent record.


Why not include ppc64le into the existing list of arches on line 95?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.425.fdd7b29b073a02772fc4271b3f49f064b39f20ad](http://build.palaso.org/viewLog.html?buildId=61017&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3332, ignored: 132 Build time: 00:08:28


@WebSpider What is your hostname? I've only ever been testing on an IP.


rude


We cannot assume that ``dataType.converter`` is a ``SQLConversion.Identity``.


yep


What's wrong with Avatar?
![Avatar](http://www.quickmeme.com/img/5a/5a702109f0610c6af4fe63b3da83650c2fa908c069e054db4bbf39e44de070b7.jpg)


In fact, I think you can still use version 3.0 on PHP 5.5, as it doesn't use methods requiring PHP 5.6 from Parkour.


> Hi, Thank you. I have seen that, I changed the default password "admin" from the PhpMyAdmin interface, but I ddin't work. My problem that I can't find the Encrypting algorithm you use in your script. I several available possibilities as: MD5 and SHA1..., no one of them worked.

You can't change the password like that. You MUST do it from our web interface.


@yichengq Great question, I have not tested without the trailing `\`. It would be much cleaner without it. I thought it is required to write in Unit file, since lots of unit file examples have it. Could you confirm and update here?


That's because we don;t just straight up "hash" passwords as that would be totally insecure.


why nullable? doesnt it always has return value?


[SO #574240](http://stackoverflow.com/q/574240/1207769) will ease your mind regarding the synchronization.

But I'm curious why this change is necessary... Firstly, I always vastly prefer not to use `synchronized` if possible. And secondly: is it really bad to allow null frames here?


This won't be easily be propagated by the compiler, you could instead use `-1`


Is that file supposed to be empty?


I remove this one because it is already defined in the parent, thus you are overriding it here. Declaring one in the parent seems to allow to use a common version among all the modules (the dependency itself does not propagate, but if you add the dependency in a module, the version propagates).


Hi @djbuch,
Why did you add the 'classes' folder? In which case is it necessary.
We are facing errors in PDF translations because modules that have translations in their 'classes' folder are shown as PDF translations.

Thank you, kind regards.


![diff_supa_charter_from_ops_ad_wrap txt supa_charter_modified_with_milestone_wrap pdf](https://cloud.githubusercontent.com/assets/12652086/9228188/f4a39b64-4149-11e5-8770-6702de9d6c56.jpeg)


Did it happen with the new update?
Because the current fix actually related to this issue, as standart PHPUnit just print_r() the exception object, so you get this issue.


remove reduntant empy lines (are you sure you ran checkstyle?)


ok


@afronski cool thanks for the response!


I don't think anyone would complain if you just changed it to 12 (as long as we note it in the `NEWS`).


Not sure this sentence is well formed or if it's just me having a hard time understanding it.


Oh, yup.


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Minor: looks like this commit maybe dropped or merged with next.


Is this really obsolete...?


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-60.92%25-red.svg)


If so you have to move the loop up. Imo you should drop this commit.


Even if `/mingw64/bin` is in your PATH, git won't be able to find, for example, PREFIX/share/git-core/templates when doing a `git init` if it was invoked via a link `/usr/bin/git` -> `/mingw64/bin/git`.


I would have created a builder in order to be able to write `newBuilder(request).blablalblbal.build()` which I find closer to english


Spelling error for the first name - it reads "first nanme"


En heroku no hay manera para hacer funcionar el login, simplemente no ocurre nada, ni se logea ni da errores


canvis readme


`.format()`


add @Fallback(EmptyFluentIterableOnNotFoundOr404.class)


Why we should escape `File.pathSeparator` at next line?


redundant due to @FallBack


Well, obviously a Editor inside a null ScriptEditor would not make sense. Other than that, it never is null anyway.

Regarding the `synchronized`: I didn't actually try to find out why it is needed. I kept it for the sake of not changing the meaning of the code. I will have a look at it tomorrow.


I'm not sure that it *can* be typed as Class, since it is stored as a String, but I'll give it a try when I work on 2.3.


Is .net 4.0 support being dropped completely? Is there a specific reason for this change? Unfortunately this breaks any integration possibility for our product.


Do you attempt to delete the statusicon yourself?


@roystgnr is this equivalent?  I was using the "L" suffix to try and get more precision from the intermediate division before casting to `Real`, but I suppose that's no different than just doing `Real`-precision division in the first place?


be sure to add a trailing slash on these in the can project, these are (almost always) folders.

```js
import 'can/map/define/';
```


extraneous newline


I'll update the generator and do a new release.


My first web apps is deployed on IBM bluemix platform


Welp, sorry about the redundancy.  This *did* feel a bit familiar, but I did not completely remember discussing it before.  In any case, yes, I think a comment would help.  It looks very strange, at first glance, as is.


It's primarily because "animation" is reserved for the task also called "animation".

This collector gathers animation controls and is intended to output something like ATOM. I figured "curves" is better than "baked" or "points", but couldn't think of a really good fit. What do you think?


Shouldn't that be linkgit:git-rev-list[1]?


Лого, как правило, кликабельная ссылка (нужно использовать тэг <a>).


![diff_supa_charter_from_ops_ad_wrap txt supa_charter_modified_with_milestone_wrap pdf_2](https://cloud.githubusercontent.com/assets/12652086/9228502/5623ef5a-414b-11e5-8be8-baee2dd44e86.jpeg)


This time you remembered your alphabet!  :-P

:+1:


In that case, I would suggest removing the new synchronized blocks completely. As a rule of thumb: never changed synchronization of any code unless you are either A) 100% confident the existing code is incorrect; or more often B) you are trying to explicitly fix observed misbehavior. Overusing synchronized blocks is often worse than underusing them, because with overuse things can easily deadlock, whereas with underuse you will "only" suffer from occasional race conditions.


Oops, should be m.feasible(), which just returns a dict...


How about installing them to /usr/share and in the ISO-profile you can use symlinks in /etc/skel. That should work. Notification is possible, but then maybe not necessary...

Am 12. August 2015 17:04:52 MESZ, schrieb Chrysostomus <notifications@github.com>:
>Neither bspwm nor sxhkd load global configuration files by default,
>only user specific. The defaults are $XDG_CONFIG_HOME/sxhkd/sxhkdrc and
>$XDG_CONFIG_HOME/bspwm/bspwmrc. Therefore installing files to /etc/skel
>is closest thing to automatic available. If I knew how I'd like to make
>the PKGBUILD print a line upon installation, which would tell where the
>default config files are found.
>
>I can install them to /usr/share instead, but I think /etc/skel is
>better. The best would be to install them to /usr/share and then copy
>them to users home folder if the files do not exist. But I don't know
>how to do that (because packages are installed as root) nor do I know
>if it is considered good policy.
>
>So maybe install them to /usr/share AND have notification?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/Chrysostomus/packages-community/commit/d32343ab4801d275b407398b7d574a79208e5b3b#commitcomment-12666743


The script argument seems redundant here, since it will always be accessible via the node. Can we remove it?


hi loic, can u please release your new version on the grails repo. ty very much!


@kbenne I'm going to see if I can create some realistic controls without those AVMs...it would be dumb to add them just to support this one object.


![diff_supa_charter_from_ops_ad_wrap txt supa_charter_modified_with_milestone_wrap pdf_3](https://cloud.githubusercontent.com/assets/12652086/9228589/c47010a6-414b-11e5-883b-d557e043cf7b.jpeg)


I believe most of the code here is redundant since you dont need to parse this object from Json only to Json


Lower level includes come before higher level includes, so Gaffer includes should be before GafferImage.


Na verdade o `ResourceNotFoundException` é transformado em uma exceção mais específica antes do `throw`.

Aqui seriam:

```csharp
/// <exception cref="AccountNotFoundException">Thrown if account was not found.</exception>
/// <exception cref="WorkspaceNotFoundException">Thrown if workspace was not found.</exception>
/// <exception cref="ResourceNotFoundException">Thrown if server returns a 404 (Not Found) HTTP status code.</exception>
```


Yes, it was done in [Move EditorPane related preferences(-loading) into EditorPane](https://github.com/Squareys/imagej-ui-swing/commit/3568891f312319c2f68ae035633fe160fd0274ea) I guess I should note that in the commit message, shouldn't I.


what is the function of this class?


@Syxton Thanks for the comment. We'll look into it asap.


этот элемент должен быть кликабельной ссылкой


Can you use ` ProcessNames.INTERNET_EXPLORER.getWindowsImageName()` instead?


The change is specifically for compatibility reasons with Dynamics CRM. It is possible to convert to 4.0 however. The following post has information on why we made the change: https://github.com/Parature/ParatureSDK/issues/18


Ah, that will make significantly more sense.

Only other issue is mutating constraints; we should probably have more standard ways of mutating models (implement divide??), but this is fine for now


How about `feasibility`?


are these two chars counting as a single char?


c'est quoi travis ? x)


Shouldn't be `tr_a` instead of `tr1`?


This is kind-of an aside, but I thought it's as good a place to raise it as any:

Do these functions (`computedDisposeDependencyCallback ` and `computedBeginDependencyDetectionCallback `) need to be anonymous? i.e. can they be named functions e.g. `function computedDisposeDependencyCallback(...)` or `var computedDisposeDependencyCallback = function cddc(...)`, so that they don't show up as `anonymous` in the debugging stacks?

Same for `evaluateImmediate_CallReadThenEndDependencyDetection` below, and probably others in the code.  It'd probably be worthwhile, where there are potential internal branches where the decisions are otherwise opaque, to have named functions that reveal what's going on.

This is probably a whole other issue and beyond the scope of the performance concerns :smile: – but was just curious.


You'll just need to compile a version where the target framework is 4.0, feel free to fork.


Would getting the `sysname` from `uname()` be enough? This will be e.g. `MINGW64_NT-6.3` on mingw64 or `MSYS_NT-6.3` on MSYS2; not sure about what pre-msys2 MinGW/MSYS would return.


So now, `before.update` will no longer fire, but `before.upsert` will?


I like that name much better.


Add QUERY_BOUNDARY_LIST_END so as you can reuse in the next patch.


Hahahahhahah!! :D

I should feel embarrassed. The file was created and included as an earlier attempt to refactor I believe. Lets hope nothing was in it... since everything is working fine now. I added it and pushed as part of some frantic late-evening debugging when I found the stalker page to be broken.

In the end the root problem was the Rdio API proxy going down.  The missing file was a legit error but not the one I was trying to fix. Only time can fix the services you use being down... that, and angry Tweets.


Seguindo o caso acima, aqui seriam:

Na verdade o `ResourceNotFoundException` é transformado em uma exceção mais específica antes do `throw`.

Aqui seriam:

```csharp
/// <exception cref="AccountNotFoundException">Thrown if account was not found.</exception>
/// <exception cref="WorkspaceNotFoundException">Thrown if workspace was not found.</exception>
/// <exception cref="WorkspaceFileNotFoundException">Thrown if file was not found.</exception>
/// <exception cref="ResourceNotFoundException">Thrown if server returns a 404 (Not Found) HTTP status code.</exception>
```


any reason why is it not defined at `initialize` with a getter?


Yep, I saw that it was the new commit, and my composer file is running off of `dev-dev`. I ran composer update to grab the latest commit and it did update.


dude!


Which check?


Replace 3 with QUERY_BOUNDARY_LIST_END. This will make it obvious what it is for and will also ensure you never have an out-of-bound access when someone adds a new query boundary :)


This is a nice fix. Is there a related issue in YT? I believe @dalezhao just showed this to me yesterday at The Living.


This comment appears to have launched an invasion from another node. It's fine to leave leaf nodes like this uncommented as long as the node itself is documented reasonably in the relevant UI file. We only need comments in the C++ for stuff a programmer might not be able to glean first from the docs and from using the node in the UI.


Hello friend,
Thank you very much for your helpfull files.
Please let me know where is the 0.905+0.947 in log file of langvine method and also the dTemp = 0.783  in in.heat??
I should be thankfull if someone reply me back.
Regards

dQ = 8000 * 0.5*(===========> 0.905+0.947) / 100 / 18.82^2 / 2
  8000 atoms
  0.5*(0.905+0.947) = from log file =
    ave of total in/out energy for 2 regions normalized by # of atoms
  100 = 20,000 steps at 0.005 tau timestep = run time in tau
  xy box area = 18.82^2
  divide by 2 since energy flux goes in 2 directions due to periodic z
dTemp = 0.578 from log file for average Temp difference between 2 regions
dZ = 18.82

Kappa = 3.41

(2) in.heat

dQ = (100*100) / 100 / 18.82^2 / 2
  100*100 = 100 (time in tau) * 100 (energy delta specified in fix heat)
  100 = 20,000 steps at 0.005 tau timestep = run time in tau
  xy box area = 18.82^2
  divide by 2 since energy flux goes in 2 directions due to periodic z
dTemp ==============> 0.783 from log file for average Temp difference between 2 regions
dZ = 18.82


Ugh, I ran the tests against the wrong version :(


@Andrei-Pozolotin we restored the revision in the version and also we just plublished: **1.6.6-rev002**

https://oss.sonatype.org/#nexus-search;quick~sigar-loader


Yeah, we're escaping the `\` so that Ruby's interpreter sees it as a backslash surrounded by single quotes, rather than a single quote followed by an escaped single quote (and no termination to the string).


already did a new release to fix, np.


dude!!


actually it reports not only time, so maybe we should rename it and change description?


maybe the generator should have a test that generates a project and then does a sanity check that the hello world shows up.


```csharp
/// <exception cref="AccountNotFoundException">Thrown if account was not found.</exception>
/// <exception cref="WorkspaceNotFoundException">Thrown if workspace was not found.</exception>
/// <exception cref="ResourceNotFoundException">Thrown if server returns a 404 (Not Found) HTTP status code.</exception>
```


yep ... good spot I'll re open #13


why te2? I can't follow this test.


If use my method, there is no need to added the global function.


Alright, I will try if this would work without.


@drvink Sorry, I should have spelled out that the `PATH` modification was intended as an *alternative* to the link.

IOW you should be able to call

```sh
rm -f /usr/bin/git
PATH=$PATH:/mingw64/bin git init
```

and it should Just Work.


checkstyle had no problems here?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


test


That reject needs to be

#        reject

Why did this change ?


fits on the previous line?


It's cool. I mostly just commented to prove I stalk your GitHub.


Not really – in fact it was at one point as I was writing. It felt like the state methods were hinting towards a class refactor, though, so I kept it separate for the time being.


:sunglasses: !


;)
Appreciated.


No it didn't?  The reject was left over from some testing that got accidentally committed.


Why we allow many instrumenters but use only first?


This test seems to conflate two things. One is that shuffling actually makes the folds different than when not shuffling. The other is that shuffling doesn't break the "partition" property (`union(train, test) = all, intersect(train, test) = 0)`.

Am I missing anything, is the test testing anything else, or should it?


Oh, yes, that does of course work, though it seems unfortunate to require the user add a directory to their `PATH` (which is likely full of other programs too) just to make this work correctly.


This is where I would put my lambdas...if I could use any.


Wikipedia claims what I recall from my Numerical Analysis classes: "IEEE 754 requires correct rounding: that is, the rounded result is as if infinitely precise arithmetic was used to compute the value and then rounded", so for Real of long double or under this should be equivalent; for Real greater than long double this should be more accurate.


develop (evanweaver) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.35%25-red.svg)


Awesome job Steph, ya' crushed it! Super clean and easy to read code with meaningful output, love it. Only thing I would add is that you could clean up this if/else block a bit
```
if (winner === "player") {
    		playerWins += 1;
    	} else if (winner === "computer") {
    		computerWins += 1;
    	} else if (winner === "tie") {
    		computerWins +=0;
    		playerWins +=0;
    	}
```
Here the only meaningful values of winner are "player" and "computer" because with "tie", you do nothing. I understand the thought process, but the statement `computerWin += 0`, which is just shorthand for `computerWin = computerWin + 0;`, doesn't change the value of of computerWin at all so you can actually just get rid of it. With coding, less is more so if you can get away with completing the same objective with less then that's how it should be written (remember the phrase "refactoring" from Jaden's lecture - we're going to ask everyone to constantly try and refactor their code). So with that said, you could complete the same objective with getting rid of the last if statement like this:
```
if (winner === "player") {
    		playerWins += 1;
    	} else if (winner === "computer") {
    		computerWins += 1;
    	}
```
Seriously though, awesome job on the assignment it looks great considering accomplished all of that logic with only reading the fundamentals. Keep it up!


Acho que aqui seria "workspaces server".


Workspaces endpoint


"error:" prefix will be printed twice


workspaces server


![diff_supa_charter_from_ops_ad_wrap txt supa_charter_modified_with_milestone_wrap pdf](https://cloud.githubusercontent.com/assets/12652086/9228188/f4a39b64-4149-11e5-8770-6702de9d6c56.jpeg)
![diff_supa_charter_from_ops_ad_wrap txt supa_charter_modified_with_milestone_wrap pdf_2](https://cloud.githubusercontent.com/assets/12652086/9228502/5623ef5a-414b-11e5-8be8-baee2dd44e86.jpeg)
![diff_supa_charter_from_ops_ad_wrap txt supa_charter_modified_with_milestone_wrap pdf_3](https://cloud.githubusercontent.com/assets/12652086/9228589/c47010a6-414b-11e5-883b-d557e043cf7b.jpeg)


Sorry, I'm wrong on that one.  Carry on!


And while much of IEEE 754 only applies to icpc if you turn on "--disable-fast-but-broken-math" or whatever they're calling it now, the rounding requirement for primiive operations seems to be implemented at the CPU level.


Hello,
 I am building the test for the file simulation (which will run the code). In the function to assign strategies the __init__ . However when I build the test, when I tested just with random number, it appears as if the .strategies assigned to agents is False. So I printed the values of the strategies of the first 5 agents of each and they appear to be assigned randomly.
Is it right to place the assigning strategies function in the __init__?


En desarrollo localhost, la autenticación funciona correctamente, pero desplegado en heroku al tratar de ingresar con permisos de administrador la aplicación no hace nada, ni se autentica ni da errores.
Como implementé el manejo de sesiones con cookies incluyendo el timeout, quizás este problema solo sea mío.
Encontré este hilo donde explican que heroku verifica que la cookie generada por la aplicación sea "segura", así que añadiendo un parámetro al instanciar el mildware de esta forma:

```javascript
...
app.use(session({
    secret: 'Quiz 2015 Alejandro Ayala',
    proxy: true,//este parámetro hizo funcionar la autenticación en heroku
....
```

http://stackoverflow.com/questions/14463972/how-to-set-secure-cookie-using-heroku-node-js-express


Bra jobb Mr. Atom.


También se simplificó el archivo generado por el esquelo de **express-generator bin/www** por el que se encuentra en el branch master del curso.


97204612_MultiSpeedFan (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1804 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Применять для этого контейнера класс 'grid' не совсем корректно, т.к. содержимое этого контейнера не представляет собой колонки.


This is related to https://github.com/dropwizard/dropwizard/issues/868 and https://github.com/dropwizard/dropwizard/commit/7ab73cd1df6c1be914a3ae83e026ec5737a2ad7f

With additive=true (the default), a logger writes to its appender -and- any appenders hierarchically above it, including the root logger. For true redirection as described in issue 868, we need to be able to set additive=false so a logger writes to its appender only.


Do we really need print stack trace every times? I think it will be "hide" usage block.


Typo :(


Yes, there's a special diagnostic preventing references to member extensions until we figure out how they should be done


Remove dead code.


This `return` should be on a new line. We'll get to better formatting when we'll work in the IDE.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18983/testReport/) for this commit**


initial commit


I think print only when `options.time` is enough.


Since this plug is for the internal implementation, let's make the accessors for it private.


带有普通的边框:

First
Row

Second
Row

</talbe>

带有粗的边框：

First
Row

Second
Row

</talbe>

带有很粗的边框：

First
Row

Second
Row

</talbe>


Yes, I've tested different errors and often it's not at all clear what happened from the exception message, so I'm printing the stack trace as well


Maybe call this AreaSource to associate it even more strongly with areaSourcePlug()?


Seems like this might not be needed?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18984/testReport/) for this commit**


Seems like this one might be redundant also?


Easier way, not to have to iterate is just to use the `addAll()` method as in:

```java
pastries.addAll(ratedPastries);
```


Probably these changes should be moved to prev commit


@Dwar3xwar DWMR. Good good. Keep leaning into this work.


You may lose the notification if you don't lock the mutex for either changing the state or calling notify_one(), or both.


ok


Definitely an invasion....


Done. It was initially AreaType because it was going to be used for both the source and the affects. I then changed the affects to checkboxes, so now it's only applicable to the source.


@flavour Please review


Since the output of finding the stacks is a list of stacks, and poly-intersect, and others take in information for a single set of geojson, I though it made sense to only return a single stack (the deepest) unless otherwise specified.


Should `inPlug()->dataWindowPlug()` and `inPlug()->displayWindowPlug()` be in here too? They do affect the computation of cropwindow plug I think?


Should `inPlug()->formatPlug()` be in here too?


I think will be better to print `PropertyMetadata` instead of `PropertyMetadataImpl`


This commit removed the `SIMD.Float64x2` type altogether. Why is that?


Since we're adding something new to the App, we might need to update resetApp() in core/testUtils.js.


Nice, Is there a tool you use for this?


`<` is really ugly, any way to avoid these?


Oh. What is the blocking condition? Could you explain just a bit? Or provide a link?

David

> On Aug 11, 2015, at 11:18 PM, Markus Gesmann <notifications@github.com> wrote:
>
> This depends on RStudio, not me. You will have to lobby them.
> > On 11 Aug 2015, at 23:47, David Holstius <notifications@github.com> wrote:
> >
> > Hi, and thanks for your work on this package. Any near-term plans to (re-)add support for rendering in the RStudio viewer, removed in v0.5.0-1?
> >
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/mages/googleVis/commit/04ed20af7dfc1d51fb1854687be012eecc9b0f2f#commitcomment-12652910>.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


Not sure, will remove


> openWhenCompleted if `true`, the image will be opened as soon it is downloaded, `false` otherwise

I don't see where you use the `mOpenWhenCompleted` boolean :smile_cat:


done


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1658 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-92.37%25-yellow.svg)


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.454.4270f51fbabd6053cd3669f4b1a7ed6c96d6c64c](http://build.palaso.org/viewLog.html?buildId=61025&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3306, ignored: 133 Build time: 00:06:07


Thanks!


I don't sure that `PropertyMetadata` with same name should be equals. Where do you want to use it?

//cc @NataliaUkhorskaya @abreslav


I see that -- thanks :)


Can you please release a new version?


vim. yes, i admit that's slightly old school. :-)

http://vim.wikia.com/wiki/Remove_unwanted_spaces


hola


This might just be a pet peeve of mine, but when I see something being assigned into a non-const variable, I assume that a) it will be used in multiple spots and b) it will have its value modified. I'd probably just put the call inside the following conditional since neither of those is the case.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1271 of 1271 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.427.d2b5f5db92616f3dbf84a962a48754769b2e9315](http://build.palaso.org/viewLog.html?buildId=61021&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 859, ignored: 54 Build time: 00:23:48


This seems to be a race overall. You get a copy of the old value of `h.head`, `h.unselected` and `h.dbIndex` and then unlock the handle and you attemt `writeToStore`. What if some other go routine had a successful `pushReservation/writeToStore` during that time. By rolling back like this you are inadvertently overwriting that allocation.

Also the case of `release` you perform `pushReservation` and make that bit position available, But somebody could be trying to allocate that bit before your `writeToStore` succeeds/fails. This is also wrong.


Ahh, I see what you mean as it's now spread out in three different places.


Nice test. :-)


Very smart


Sometimes it's really worth doing the work to pass through a hash exactly as you're doing for the `inFormat == newFormat` case here - typically to avoid duplicating entries for large objects in the cache or to avoid an otherwise expensive computation. Since in this case the value is tiny, and we're having to do the whole computation to figure out if the hash can be shared, I think we may as well go for the simpler code instead.


Yes! You're totally right.


This should definitely be folded into the other commit (it's pretty annoying to have git history of the form "Add broken thing", "Fix broken thing", "Whoops I missed a spot" when you can use history rewrites to fix it at review time)


You don't need to pass `err.Error()`. It will be automatically invoked by `fmt.Errorf` if you just pass err


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Typo

    \cs{exp_args:NNoo} \meta{token_1} \meta{token_2} \Arg{tokens_1} \Arg{tokens_2}


Exceeds 80 chars


Same racy rollback problem here.


LGTM.


So I think we just want these two lines, plus a hashing in of `inPlug()->formatPlug()`.


As above.


OK.  And if I recall correctly, for "non-primitive" operations, `std::sqrt(14.L/15.L)` is the best we can do since we currently only rely on `sqrt` being implemented for long doubles and below?


@jakemulley Thanks for submitting this pull request.
Could you help me understand more about this issue?
How do you reproduce it?
I know that refreshview will create brand new objects so that the old events will be removed.
But the _onDataLoaded function is used to place the new events to the existing cell, in this case, if you call the refreshview method, I think it will wipe the new events?

I think the correct order is first call the refreshview method to generate cells for the new range, load the events for the new range, place the new events.
This is exactly how move function does. IMO, I don't think you need to call refreshview again.
What's your thought?


Same comments as above apply here too I think - let's go for the simpler implementation here since the optimisation isn't really worth it.


Do these elements need to be initialized with `nullptr`?


97204612_MultiSpeedFan (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1804 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is still kinda  an incomprehensible mess, but is definitely slightly less so than before (and definitely below-average on the "is completely incomprehensible" compared to the rest of the insane code we have here :P )
Some random comments:

- There's no explanation of what this block is doing, and you definitely can't call it "self-documenting"
- `(i * unitCount) + beginAttack + index - 1` is calculated repeatedly, and its significance not explained.
- Seriously, what the hell does this do? :P


Indentation seems to have gone a bit wild here?


Remember we talked about new lines at the end of files :smile:


will be fixed in #119


Dude, what's the PDF? lol


Would the global timer live in the Security component and it would be passed into each of the PriceAge components as a prop? Or is there a way to create a static global timer in the PriceAge component that all instances would use?


Woh baru tau bisa gitu xD


Grumble. I find Emacs' behavior pretty annoying. I would prefer we left lines like this long, and if it gets really bad think about whether a type alias or something else would help. However I know we have some signatures some places where it really gets out of hand and it seems there's no way around breaking a line. I would prefer not to use this automated line-breaking, though.


`opam install irmin-unix` should work.


This is great line.


Why don't we pass the `ordinal` all the way to `pushReservation` rather than converting `ordinal` to byte/bit position everywhere. All the byte/bit position can be self contained inside a small number of low level functions.


we will have an issue with that see my mail


You could extract this into a function since it's repeated twice in this file.


This is actually incorrect


Will we still need the XUL namespace here?


this will not work [] does not exist for v you must declare the load/store of the final wrapper


I'm making a comment on the entire diff


We should probably add bug stating what we want to do with here if it throws. Or maybe we should log and rethrow.


<<=>> Bootstrap Framework with PHP enabled Contact Form


@JDutil How do I effect this change to my app?


The early returns prevent the dummy avatar from being shown


We should consider using a Map or WeakMap here.


Since the files are generated only once and have a history of then being hand-edited, then this change is fine.


I guess this doesn't work yet.


Also I don't think we should never manipulate `dbIndex` outside the `store` callback functions such `Value` and `SetValue`


for this specialisation we need _mm256_i64gather_pd
 double -> _mm256_i64gather_pd
float -> _mm256_i32gather_pd


private file


The comments for trunk-fill and primary-fill are the same, but I'm guessing they shouldn't be?


sdasdas


It's necessary to call `ImageProcessor::hash( output, context, h )` here before appending to the hash, so I suggest pulling out the `else` clause below and just putting it at the top of the function.

Here's a bit of background on why this is. The hash is used as a key into Gaffer's in-memory cache of previously computed results, and must therefore uniquely identify the computation that created the result. So the hash needs to reflect the following :

1) The type of the node used to compute the result
2) Which plug it was computed for
3) The input plug  values the node uses to do the computation
4) The context values the node used to compute the result.

The call to the base class takes care of 1) and 2), and then the node itself takes care of 3) and 4).


It's sort of already wrapped in `updateUrl`, I feel it would be weird to further extract it.

Could we replace the first occurrence above with `updateUrl`? Would there be any harm in calling `router.navigate` at that stage?


Thanks to balika011!


@sharabash this commit isn't attributed to your user. Can you work through https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/ to make sure your commits are attributed to your user? Once you are done, you should be able to work through https://help.github.com/articles/changing-author-info/ to update this branch's history


hola


You don't need to declare this variable inside brackets since there is only one variable your are declaring.


I'm uploading this indegestible hack just so it doesn't get lost.


Hey,

Thanks for the PR. Sadly, changing the default for `img_url` isn't going to work as some people are already using it as it is. However, you can override that, perhaps, if someone sets the `img_size` instead.

Happy to add this but have to maintain backwards compat.


The formatting of this SASS looks a little off.

Same coding standards apply to SASS that apply to PHP code. Use two spaces for indenting.


@jonathanendersby if you set the referer header to imdb url it should get past the referer block, no?


it does indeed have several bugs which were not caught by CI... please comment on https://github.com/ros2/rclcpp/pull/82 for the latest changes to this class


v*dd,lolz


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.7.d2b5f5db92616f3dbf84a962a48754769b2e9315](http://build.palaso.org/viewLog.html?buildId=61020&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:36:34


47:1: I201 Missing newline before sections or imports.


24:1: I101 Imported names are in the wrong order. Should be ImportPathRegistry, RegistryError, RegistryProxy, SingletonRegistry
24:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.


26:1: I201 Missing newline before sections or imports.
27:1: I100 Imports statements are in the wrong order. import dateutil.parser should be before import dictdiffer
27:1: I201 Missing newline before sections or imports.
29:1: I100 Imports statements are in the wrong order. from tempfile should be before import dateutil.parser
30:1: I100 Imports statements are in the wrong order. from functools should be before from tempfile
31:1: I101 Imported names are in the wrong order. Should be abort, current_app, request
31:1: I201 Missing newline before sections or imports.
32:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from functools should be before from flask_login
33:1: I201 Missing newline before sections or imports.
36:1: I100 Imports statements are in the wrong order. from invenio.modules.editor.models should be before from invenio_records.api
36:1: I201 Missing newline before sections or imports.
37:1: I101 Imported names are in the wrong order. Should be Agent, Deposition, DepositionDraftCacheManager
37:1: I100 Imports statements are in the wrong order. from invenio.modules.deposit.models should be before from invenio.modules.editor.models
39:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.deposit.models
41:1: I201 Missing newline before sections or imports.
42:1: I101 Imported names are in the wrong order. Should be deposition_record, make_record, record_to_draft
42:1: I201 Missing newline before sections or imports.
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from .helpers
45:1: I201 Missing newline before sections or imports.
474: D103 Missing docstring in public function
481:19: E261 at least two spaces before inline comment
492:34: E261 at least two spaces before inline comment
498: D103 Missing docstring in public function
505:19: E261 at least two spaces before inline comment
505:20: E262 inline comment should start with '# '


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I201 Missing newline before sections or imports.
22:1: I100 Imports statements are in the wrong order. from flask should be before from invenio.testsuite
22:1: I201 Missing newline before sections or imports.
25: D203 1 blank line required before class docstring (found 0)
25: D204 1 blank line required after class docstring (found 0)
25: D200 One-line docstring should fit on one line with quotes (found 3)
29: D210 No whitespaces allowed surrounding docstring text
29: D400 First line should end with a period (not 'e')
38: D210 No whitespaces allowed surrounding docstring text
38: D400 First line should end with a period (not 'e')
47: D400 First line should end with a period (not 'e')
47: D200 One-line docstring should fit on one line with quotes (found 3)
91: D210 No whitespaces allowed surrounding docstring text
91: D202 No blank lines allowed after function docstring (found 1)
91: D400 First line should end with a period (not 'k')
105: D400 First line should end with a period (not 's')
105: D200 One-line docstring should fit on one line with quotes (found 3)
118: D400 First line should end with a period (not 'n')
118: D205 1 blank line required between summary line and description (found 0)
139: D210 No whitespaces allowed surrounding docstring text
139: D400 First line should end with a period (not 'd')


Import in order of lowest level to highest level, as we do for #include order.


save_pid_tracker() already returns an appropriate error code


Before doing the manual transformation, I tried the `UrlEncode` method, which did not work. I was not aware of `UrlPathEncode`. Thanks for the tip. The MSDN documentation says that UrlPathEncode is deprecated, so I am not going to use it either :(. I did not spend the time to investigate why UrlEncode failed. The images just did not render unless I used a manual transformation. The manual transformation came to my attention from running the W3C validator on the site. https://validator.w3.org/nu/?doc=http%3A%2F%2Fwww.ingridhauss.com%2F


Let's get some min/max limits on this, so we know we're only ever going to get value AreaSource values.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.426.fdd7b29b073a02772fc4271b3f49f064b39f20ad](http://build.palaso.org/viewLog.html?buildId=61022&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3332, ignored: 132 Build time: 00:14:49


We should really rename this file .js, as it's not JSON.


hola


Actual author is Jason Davies, lost context in the merge.


Old screen shot and not needed.


@bwoebi with this commit I got rid of unnecessary fcalls by eager pre-calculate all values required per token. This speeded up things in compared to the version before, but its not yet faster then the initial version.

before this change https://blackfire.io/profiles/12fd0bfe-8ff5-4d40-b0f8-66db575dda8a/graph
with this change https://blackfire.io/profiles/ad4c89dd-5b4e-4669-a4b6-5d7c8edf4bee/graph


I guess these URL is invalid.


Could you explain the rationale for these defaults? I think we both hold the opinion that the display window is the conceptual size of the image, and that the data window is mainly an optimisation whereby we only define a certain non-empty region of that (or perhaps provide overscan data). Given that, I think I'd expect a crop to work on the display window by default - to be cropping the image.


I guess these URL is also invalid.


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (747 of 747 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.17%25-green.svg)


GBATEK says X2 and Y2 should never be zero, but that messes up the TONC HBlank DMA demo. This leads me to believe that the windows are virtually disabled when the coordinates are equal.


`tr_{a|b|1|}` all are of same length :)


Yeah. If you search for <stripper PNG> the results are not safe for work :-). Lol. http://www.steelbytes.com/?mid=30 is the URL. It gets the job done simply and easily. There are probably other tools that are better. Do you know any?


May I suggest using [GitVersion](/GitTools/GitVersion) and [GitFlow](https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow/) (or [GitHubFlow](https://guides.github.com/introduction/flow/)) as a release and versioning strategy instead? Once understood and properly configured it really saves time and energy, plus it gets it right every time. :smiley:


{
"extends": "./node_modules/eslint-config-rambler/.eslintrc"
}
не работает в pycharm вообще

у меня в саблайм 3 работает
{
  "extends": "eslint-config-rambler"
}


Should this span be a child of the "newtab-intro-graphical-progress" div?


Might want to add `-n` to `ln` so that if the symlink already exists `ln` won't dereference it.


No, because the dummy icon is generated by the parent function


issue #2


My thinking that the default behaviour should be removing any data that previously existed outside of the Display Window. It would keep the active display the same, but crop off any extraneous data.


Does this mean that at z8, primary is wider than trunk or motorway? Is that intentional? (Maybe it works out because of the colors or something?)


Hey, can you resize their headshot to 240x240?


remove the "/>", you don't need it.


I prefer `.format` over `%` everywhere it's possible.


sure, will submit shortly.  I was noodling around with more extensive set of changes I can discuss later.  Just learning go by doing.


as above.


Well spotted: the earlier tests became redundant when I added the call to `is_tools_sr`.
However, I see that `is_tools_sr` does not check the content_type, so I shall make it do that.


Do you want to release it now ? or a beta ?


Could you give a little description on how to do local testing on mobile (your future self thanks you)


I think that this line should also be called in the other constructor AbstractForm(String...)


I'm missing a test for this commit; perhaps also one for when n.prop is null


I'm actually using the Nuget package (company rules). Currently the new .net 4.5 package is being distributed as .net 4.0 via nuget. I think the best solution is compile it for both and mark them explicitly as .net 4.0 or .net 4.5 as most Nuget packages do. You can include both dlls in the NuGet package and it will figure it out on install as long as they are marked explicitly. Otherwise you end up with people in my situation wherein a .net 4.0 nuget package does not work because the actual underlying DLL is .net 4.5.

Bare in mind that the vast majority of Dynamics CRM deployments currently are CRM 2013 or older (.net 4.0). Arbitrarily excluding them for want of *ONE* minor function is a bit extreme. So is changing the target framework for a minor update.


OK, so the defaults are for "throw away overscan"? I guess I was thinking the defaults would be "prepare to crop the image". Anyone else have an opinion on this? I think it's worth getting a consensus now, because defaults are one of the things we can't really change afterwards. @andrewkaufman, what do you think? Could you perhaps check with Lucien for his opinion too?


`plaug-in` -> `plug-in`


Fixes #6


I'm not a huge fan of renaming this.

All of these properties are **style** properties.  They don't need to have ``-style`` appended to them.


Injection should be done on application start and not in the presentation layer object

Once db engine injected application start to use it right away and never refer to it agin


Please change to `===`


Not needed.


two threads, much despair:
https://code.activestate.com/lists/python-dev/74225/
https://mail.python.org/pipermail/python-dev/2006-February/060689.html

It seems the solution is awful:
```diff
-    char * kwlist[] = {"filename", "stream_out", NULL};
+
+    static const char* const_kwlist[] = {"filename", "stream_out", NULL};
+    static char** kwlist = const_cast<char**>(const_kwlist);
```
This silences the warning, but ugh.


Sorry, I was mistaken. You are right, this is fine.


Also not needed.


@mperrin, these look great.


this should be tested.


The code to read data from all the boundaries should be unified and hidden behind a single function. This is already mostly the case but this function re-introduces booleans that make the entire thing moot.

If you had a function such as:

std::queue<ProfilerCall> getPerfData(QueryBoundary boundary);

You could then easily unify all your code and simplify it a great deal.


che cazz hai scritto?


Another option for the default would be to have it set areaSource to Custom, allow the post-create callback to set the area to the display window, and have both affectDataWindow and affectDisplayWindow set to True. That would effectively give the same result initially, but be in a better place to then be modified to crop the image.


I'm new to this, but wanted to double check that these are OK.

e.g. sp_background_rect_w_offset_mask.png

seems to be introducing some new artifacting. Is that normal?


type check or cast to number?


As above.


Re: 1, a local optimum feasibility? Wouldn't it be guaranteed to find a feasible point, just not necessarily the most feasible one?
Re: 2, how will the SP solve any of the GPs if it's fundamentally infeasible?


This should be squashed into previous commit


Nit: you don't need `function isEmpty()`
you can just write:
```JS
isEmpty() { ... },
```


We are using `maven-bundle-plugin` aren't we? Defaults are specified in parent pom(s), specifically in `oss-parent` (via `jackson-parent`), and we are always open to improvements where applicable.
It is possible that usage may be improved upon as well; many modules use bare defaults, whereas others try to list known imports explicitly.


Nit: isEmpty could get a getter.


Missing new line at end of file.


Same comment as before for the [3]


There is no need for this change. You don't have to force early npes in arbitrary cases like that. And if a test fails without this change, then the test is wrong.


Thanks for the comment!


Thanks! Merging


Yes, PushReservation() will be removed in a following commit along with the other non-atomic old functions GetFirstAvailable() and CheckIfAvailable().


Nope, just wanted to mark it as being version 4 :)
I still want to make sure everything is stable and do some cleaning in old extensions (marking them as deprecated) - I have a list of things to clean/remove in the code :)


It's inside initGUI, which is already called in both constructors (you can see its calls right under the I18nHandler creations).
If it should be included in initGUI or not is another topic, but I think it makes sense inside it as it's a GUI and not model related feature.


@dschafer @leebyron Wouldn't it make more sense to put the resolve function in starWarsData.js and reference it from here, just like `getFriends()`? It doesn't seem right to have starWarsData.js export `artoo` and `luke`. In fact, it seems to me that all resolve functions belong outside of the schema document. Then starWarsData.js wouldn't have to export `starWarsData` either.


nit: whitespace.


fwiw -- if you just let urlparse throw the exception you'll get a more informative error trace.  No problem though, maybe that's not important here.  But also if you want to look into it, the standard traceback package has traceback.print_exc() that will print out the exception that was caught.  Can be helpful for seeing in the stderr why it failed, but still letting you catch.


These appear to be coming from Pandoc. It'll be trivial to do a find-and-replace on helpdb.jl once this is merged.


I was confused about that column. Good catch.


whitespace


Can also simply do "while self.tocrawl:".  Python objects all act "truthy" and "falsey" intuitively when used in conditionals.


How would you like me to call this visitor then.


Wouldn't it be better to register this for each individual application, when the developer knows that the ResourceMap is actually available, instead of just catching the exception every time?


Please add `{` and `}`


LGTM


Se modifico para que mostrara la palabra Hola


I imagine that the timer would live in a separate module; something like

```
import BatchingTimer from '…';
BatchingTimer.batchExecutor = React.unstable_batchedUpdates;
BatchingTimer.setInterval(this.updatePriceAge, 1000);
```

And then in BatchingTimer:

```
var tasks = [];
function maybeStartTimer() {
  // Look at the `maybeInit` function of Chronos
  // https://github.com/fitzgen/chronos/blob/master/chronos.js
  // I'd rather see an implementation where the single timer had
  // a variable `INTERVAL` rather than a fixed one, where the
  // cycle was based on requestAnimationFrame and not setTimeout
  // and where the bookkeeping was based on absolute time
  // rather than time to `next` invocation (maybe with an option that
  // delivered guaranteed execution, or allowed the timer to drop
  // tasks if they've missed their window of opportunity.
}
function executeBatch() {
  // Find all of the `fn` that are overdue
  var overdueTasks = tasks.filter(/* ... */);
  if (BatchingTimer.batchExecutor) {
    BatchingTimer.batchExecutor(() =>
      overdueTasks.forEach(fn => fn())
    );
  } else {
    overdueTasks.forEach(fn => fn())
  }
}
export class BatchingTimer {
  static batchExecutor;
  static setInterval(fn, ms) {
    // Add `fn` to a list of tracked tasks that should be fired whenever `ms` milliseconds elapses
    maybeStartTimer();
    return intervalId;
  }
}
```

…but anyway. We digress from React :)


And wouldn't it be trivial to find-and-replace in `genstdlib.jl`? This really can't be merged until it's been combed over carefully.


`-measure`?


good point, will fix that


Okay.


cc @joscha

works. aber so würde der sass loader auch alle css files parsen... außerdem failed das im blob, weil er mit /***/ kommentaren wohl nicht klar kommt.


yes, sorry


Oh.. Thank you.


For feature requests, please feel free to email me.


It is so!


Nesse caso não deve ser `ApplicationException`, já que não é _application_, mas sim _library_.


SUBDIRS += script-console


It worked because previously when just $intnum was "passed" and shifted, the result in the caller was always non-zero regardless of what garbage was in %rdi.  In the new version, if %rdi happened to contain 0, zero was masked and therefore the interrupt was not processed.

Still not sure why the difference between qemu and kvm, but don't think it's important.


Hmm, Free energy :)


I don't think so.

The only reason that inPlug()->dataWindowPlug() is in there is because the data window intersects with the area, whereas the display window is completely overridden, ignoring what it was before.


What is "sudo" mode?


That's correct.  It looks like C++ support for __float128 is somewhat lacking.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.427.4270f51fbabd6053cd3669f4b1a7ed6c96d6c64c](http://build.palaso.org/viewLog.html?buildId=61023&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3332, ignored: 132 Build time: 00:23:11


@SachaG it looks like this only works for twitter cards if we set an image then... Maybe it would make sense to have an else statement and set the card to just summary if there is no image?


Reason why I enclosed in brackets was a simply a practical one: It helps me spot the definition when I look for it in the the code.


RoomAirflowNetwork (lgu1234) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-60.95%25-red.svg)


Did you mean for this to be spelled `Vagrantfile`?


Delete the dollar sign.


Keep data and code separate (declarations at the beginning of a scope).


By not doing this, though, the hash will definitely be changing, as I'll be hashing against the cropWindowPlug() rather than a format plug. Is that okay to do? It's not a heavy computation to figure out, but by simplifying the code here, we're basically saying that the format will definitely be computed again, even if it's going to be the same as the input format.


"through"


@dkubb oh, it's poor typo... I'll fix it, thanks!


Agree with @mossprescott, especially in this case where the line is below two others which are unbroken and even longer ;)


This is nice, so you dont have to adjust buffer size. Sweet!


Why adding camera to the scene?


Actually, I will go ahead and remove them when I take care of your other comments.


Actually, it would be better to leave the excludes there. It should not be the default that files do not have a license header and that only certain files need a license header. The license header should be in all files except those where it cannot be put. That is what is resembled by the "excudes". A long list of excludes should give rise to concern.


I think there is an error in the instructions for the assignment (it's the first time I'm reviewing this revised assignment). It says to *add `<div class="clearfix"> just below `<div class="selling-points">`, but that doesn't really make sense.

The point here is that the .selling-points div contains three floating elements, and as a wrapper, would benefit from having a .clearfix class because otherwise, its height does not reflect the full height of the three floating divs. You may use the Developer Tools on Chrome and inspect one selling point, then in the Elements tab that has opened, click or hover the .selling-points div: its height should be 0. When adding a .clearfix class, its height will be that of its floating children.

That would ensure any content added after the .selling-points div would actually be rendered *after* the selling-points, not below. You may add some content after that wrapping div (it's actually an article in your implementation) and check what happens with or without the .clearfix class.

``` html
<!-- with or without .clearfix -->
<article class="selling-points container [clearfix]">
  <section class="point column third">…</section>
  <section class="point column third">…</section>
  <section class="point column third">…</section>
</article>
<div>Hello, where am I?</div>
```


That's because GitHub is treating tabs as 8 spaces... When indenting like this, would you prefer I indent to the level of "return" and then use spaces beyond that?

This is what this chunk of code looks like at my end:

![gaffer_indentation](https://cloud.githubusercontent.com/assets/625512/9230572/d6d1f89e-411a-11e5-950e-bdad93984a47.png)


Why in this method? It supposed to be invoked multiple times, doesn't look as a good place to make changed in the scene.


Sorry, not sure I understand. Call a visitor?


LGTM


I'm sure I knew that - just a brain fart....


fixed


I guess this version will need a seek(0)


I wonder if we need to fix something in Sites.js to avoid accessing the `_link` private member?


It looks like the below only works because you're assuming that url is a domain name.  You'll probably end up adding full urls there as well, since we have some starting points which start at sub-paths.  This also assumes http, which may be fine but still is less flexible.

It would be more flexible if the code assumed url is a url, and used urlparse to get the parts.

Then, the real point -- there's a 4th case needed here I believe.  You cover starting with "/", but relative links can also start without a slash.  If you're viewing "http://x.com/x/y/abc.html" and you link just to "xyz.html", the browser goes to "http://x.com/x/y/xyz.html".  It doesn't look like that's covered below.


line length.


Where would you consider GafferTest to come relative to GafferImage? I'm thinking that all Test modules are a higher level than their implementations...


it would never have given you free energy.. it just would have just meant 2 adjacent nodes continuously tried to shove RF from one to the other, causing lag


I'm still not clear why url (c/f combined) & representation are separated within this lower level function?
Why can we not just give a URL here & have the representation (if-used) added at a higher level?


runs without checking for privileges


Я прошу прощения, я вчера неудачно смержился, похоже, зацепив ваши файлы.

Кстати, не надо ли добавить папку ./datacollector/datacollector_tablet/.idea в .gitignore ?
Кажется, это личные настройки студии, не нужные в репозитории.


Aqui vale um construtor com `setter` privado.


You're removing the anchor name here, but you have a case above where you accept named anchors ('#') and generate a url.  I may be wrong, but wouldn't you want to just ignore named anchors entirely?  They're just links to the same page you're already parsing.


Isn't this totally redundant with the `/* @ngInject */` annotation? The Vim snippets do not explicitly `$inject`


Well the list is already quite long, and it's painful because of the of of extra book-keeping involved. Currently only source code files have licenses set (and the main pom), so that why I switched it to includes. Will move it back.


I had this same problem on Contiki but for pkg-config I fixed calling Soletta make this way:
PKG_CONFIG=test make


Is this fool proof enough?

Consider this:
```
'characters:ben01_:controls_SET'
'characters:ben02_:controls_SET'
```

This would have two pointcache instances currently identified as `characters`.
Since we're in the collector stage we can't have it pass through Validators to ensure that doesn't happen.

And note that this could also happen with multiple namespaces; I think any namespace can conflict with another when not in the same level:
```
'foreground:ben01_:controls_SET'
'background:ben01_:controls_SET'
'background:ben02_:controls_SET'
```
*Namespaces are not only coming from references, they could also be added into a namespace in a scene for other reasons. So it's not only an issue with nested references, but could happen for more reasons.*

We could use the full namespace like this:
```
namespace, _ = pointcache.rsplit(":", 1)
name = namespace.replace(":", "_")
name = name.strip("_") + "_anim"
```
Even then it still could conflict where we have a `tree_tall:` namespace with `tree:tall:`.
Not fool proof again?


I would be tempted to remove this fn from core:
The channel_id part I would put into send_file_by_ftp
The rest I would put up a level into the caller


I was confused


Pra que uma interface aqui?


this is not an arbitrary case:
http://docs.oracle.com/javase/7/docs/api/java/util/TreeSet.html#add(E)

says:
```Throws:
NullPointerException - if the specified element is null and this set uses natural ordering, or its comparator does not permit null elements
```
and I'm checking the exact case


Mesma pergunta sobre a interface.


I've asked for feedback from the curriculum maintainers. I'll let you know about their answer.


Mesma questão sobre o construtor.


fixed


Même pour les itérateurs (cf. IndexMapper et String) ? =D. J'ai effectué le changement, j'espère que c'est le dernier ...

Sinon, j'ai un problème avec une texture qui s'affiche mal, une idée ?:
![comparison](https://cloud.githubusercontent.com/assets/5701967/9230467/ace3abf6-4122-11e5-8655-c2be85d3235c.png)

Et voici le code (les normales sont orientées vers le haut, la lumière est juste au dessus):
auto material = NzMaterial::New();
material->LoadFromFile("DebugTexture.png");
material->Apply();
Et puis, je fais juste:
renderQueue->AddMesh(m_material, meshData, AABB, transformMatrix);


No need to bring into scope as only gets used in error conditions & not at all in the (hopefully normal) success conditions


согласен


So I would have the url include the representation here
& I would do the get_data_from_url() call here too


:metal:


I wanted to keep the pushReservation() very focused on the core logic and avoid to conflate it with other tasks.
Also because the conversion is needed in another API: IsSet(), not only in the Set() Unset() paths.
I felt the IsSet() is a natural API to have, although is of no much use in a multi-thread use of bitseq.


I don't see this fn as being anything to do with Messaging per se...I think this lives more naturally inside s3xml or s3rest


Might want to use traceback.print_exc() here for info -- looks like this just silently fails.

Also to note -- a common pattern in Python is to let a function raise an exception to indicate error, and if it returns at all then it's a success.  If this function gave exception on all errors the caller could just wrap it in a try/except block and this function might be simpler.


Thanks!  :metal:


Falta essa classe ser somente leitura.


In fact, that function was even never called. My fail. Simply deleted.


What do $s & $r mean?
Some explanation in the docstring would be useful...


Most files without headers go into the test folders - those are covered by the wildcard patterns (although in principle it would be good if that was handled differently as well, but that's where I usually draw the line between book keeping and diligence).

In my experience I very rarely have to update the excludes and I use the excludes-based strategy in all of my projects. They typically look very similar to the list above.


incorrect indentation


What makes it multiple?
If the user subscribes via Email & SMS then presumably there are 2 subscription records? One for each method
So if the user wants multiple FTP representations then I think that would also be separate subscription records


Thnx, already gitignored.


LGTM


It's great to suggest changes to usability and find they've already been made. :white_flower:


saw approval from mrallen1
at https://github.com/basho/lager/commit/2f7f7b7dde7040e87b51744e31fc2df65338916a


merging basho/lager/bugfix/jrd/r15-compat = 2f7f7b7d into borshop-integration-284-bugfix/jrd/r15-compat


basho/lager/bugfix/jrd/r15-compat = 2f7f7b7d merged ok, testing candidate = e82bb13e


I have a patch defining this, but I had add it to sol-missing.h and the defining it as LONG_MAX as defined on my bit/posix1_lim.h


But if `areaSource == DisplayWindow` and the input DisplayWindow changes, then the output data window will change won't it? Actually, I realise this will be taken care of automatically as a secondary effect as long as the fix I mentioned above for having data window and format affect crop window is done. Does that make sense?


@GrahamCampbell already aware, just so you know, this branch is not in a review state yet. I will be creating a PR to master when it is.


Esse tipo de coisa deveria fazer parte do construtor.


Yes, data is vulnerable to changes between Unlock and writeToStore.
Also in the rollback code path, I am not locking h.

The fact is that pushReservation may return a new head under some circumstances. I need to refactor this a better way.
Thanks.


The way to DRY this would be to:
if type(resource_ids) is not list:
resource_ids = [resoruce_ids]

Then have no need to repeat a lot of code below...


I planned on doing that once it was given the OK.


Not convinced about the multiple here...doesn't seem consistent & I don't see a major usecase


In this file you have code at the top level.  That works, but most common in python is to have all global scope code wrapped in a __main__ check:
"""
if __name__ == "__main__":
    # All your non-function code goes here, i.e. stuff that's supposed to run on execution of the file.
    ...
"""

That will run that code if you just execute the file, but will not run it if you import the file.  This makes for safer code.  Otherwise, anyone who imports this file will have that code automatically run.  You might want to do this with the code above starting on line 13.  And it's usually at the end of the file.


well done


sure - just noticed this in my news feed