Oh, great! I put these in but then had more of a look around the project and got the feeling you wanted to not add too much bloat to the command set, so wasn't sure if these would be desirable. I'll push :)


Good call. I've changed it (in `plot.litfit` as well)


var target = UltTarget != null && UltTarget.Target.IsValidTarget(Q.Range)  :sake:


I just pushed version 0.5 to Cocoapods.


My bad, I was thinking empty container (```begin() == end()``` in that case) and there would simply be zero iterations of the loop...

Will add them back in...


sdfdfsdfd


Fixes for header_v5. Previous version is not supported from this moment/


Adding the comment here:

This change is not enough, the variable numHits must be equal to the main result size in order to iterate correctly thru the URL buckets.


Not sure if the forever could be installed more than twice, but if you want the last install path, then it might be better to do `rs[rs.length-1]` instead of `rs[1]` — it seems safe in any case anyways?


A usage of videojs, where everything else uses vjs.


Revert it please cause in RR i will use the 216 for both devices and I've got the GApps Package ready.
For CM 12.1 i will use the default one.


Initial commit


its is → it is


is it is → if it is


嗯，现在不在电脑旁，晚上回去弄。
我还不太会用github，又把修改的还原了。。
另外我想增加一个到期时间(到了这个时间就停用)，看了一下，似乎要修改ss的代码。想问下你有没有不修改ss代码就能实现的办法。如果没有的话就只能修改ss的代码了(修改起来好像也不难)。


@ccx-testerbot runtests master


Not sure if it is possible, but it seems like the checks for wait_psn are all over the place. Can they be in one state that all the packets eventually go through?


А здесь у нас имеется пачка последовательных чисел, верно? :)
Как насчёт индивидуального задания? :)
Попробуйте написать функцию, которая построит вам такой выпадающий список. В качестве аргументов она может принимать например 2 числа: **стартовый год** и **конечный год**.  (там элементарный цыкл. Подумайте как реализовать, какой цикл там лучше подходит).


Yep, that sound like a good approach. I'll take a look at the couchbase sdk then. Thanks for your feedback.


there are many following us.. some helping for testing etc.  but there are none helping as developer .


Also this you need to keep in order to make Ancora Parts work cause there is an option for the apps limit in the app and if you remove the entry the option will no longer work.


missing period.


Youhou


Thiet pha'


This commit is being reviewed as a part of review issue #57.


@inikulin  It is used as `Style` everywhere in the hammerhead code (other utils are used in the same way). Should we write in the other way (`StyleUtils`) or should we keep it for hammerhead refactoring?


This is the logic that was missing.


I moved all the generic cygwin and mxt support over to mxt-shell-zsh for now.  I'll cherrypick whatever's truly needed for oh-my-zsh over when it's completed.


Or..  I will just create a new branch for RR and this one will remain as it is now..


修正します！


直しそびれてました。クラスメソッドにします。


各コードの最終行には必ず空行を入れましょう！


残ってました


haha


In such case, I think we should emit warnings if extras in constraints are ignored.

From my point of view, it might make sense to allow extras in constraints, for example something like: `django[bcrypt]` => if you install django, always install it with bcrypt.

Either way (extras in constraints enforced or ignored), it should be documented :)


Такие списки тоже можно строить функциями, которые по ассоциативному массиву строят такие списки.
Массив вида
```php
array(
   'economic' => 'Экономический',
   'building' => 'Строительный',
   ...
)
```
Я расскажу на ближайшем занятии поподробнее (записал себе в блокнот), там несложно.


Надо бы дату исправить


I don't see any reason why we can't restyle **new code**. So it should be `styleUtil` (lowercased, since it's not class constructor).


Nikita Krivitski would like to connect on LinkedIn. How would you like to respond?

Accept: https://www.linkedin.com/blink?simpleRedirect=dzAMdzcOcjcOdP0Vcj8PejcMdzR4imVLqnhxt6BSrCACqAJoekdMcR8Zumlbp6lOomxP9DhUpnhvt71BoSdxfndQ9CZOpmwZrioPfmBI9z4MnT9Bp6VFrmlOnThPpnlDnThPsCBCfmJB9ClQqnpKimtBkClOs3Rx9zkJsCBzpnlNp6AJe7xGoCJDbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I6039321917989617665_500&markAsRead=

View Nikita Krivitski's profile: https://www.linkedin.com/blink?simpleRedirect=0NczkQe3gNd3gZh4BOpm9JpmQCt7xBt5ZBr6BCrT9MfndQ9CZOpmwZrioQfmBI9z4MnT9Bp6VFrmlOnThPpnlDnThPsCBCfmJB9DpMrzRQ9zkJsCBzpnlNp6AJe7xGoCJDbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I6039321917989617665_500&markAsRead=

You are receiving Reminder emails for pending invitations. Unsubscribe here: https://www.linkedin.com/blink?simpleRedirect=rmZzhj8BoDlEt6BDhj8BumNMpn8Md2kUp6oMoS8Mc6lzcPoNoj8Vd3AVp3xzcj4Nc30Mc30Mc6pzczANcC8SczkTejxzcm8MejBxoj8Nd34TcS9yojAMcP0Ne69ComlBem9zoSoOdCoUc312cylVr71BszRIqm5JpioMdz0MczRAqioSej0ScP8NcP8Tc3ANczcVcP0SfmhFpOoNc5ZOpmhKqmRBsBZQsSlRpRZQsT9FpzRHpipQu6lQnS9RsSVRbjkJoDlPrDkJcj1vsClArCBJpn9vt7dBtmtvt7dOqmoJr6RBfmtKqmJzon9Q9CZLpPRQ9zkJsCBzpnlNp6AJe7xGoCJDbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I6039321917989617665_500&markAsRead=

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/blink?simpleRedirect=3kJsCBzpnlNp6AJe7xGoCJDbjRAqmkCrkIVe4UTe4t3p5BoqAVEtTEUdmVcr6ERlzt5okUPjS5FtQRjlQ5VqTpfl6JqpQRocD9pt6JWmjdUsj13l4B6ilAMr6ZMq38NlB5CcCB4q50StltKhRBaqmRPpmMRqSURpPxIq4B8oAZ6gQV1okhnqTxPmBkMj3xxmntRsk9aqkMNimFbpkl1m7AQrk5bolBPp6wOun1KqCtEpSAOcA4Tc5FNrS4NlDxPumR7rjtGtQpHell1gk5hjkNapAFHd5tadQthgjRAqmZI9z4MnT9Bp6VFrmlOnThPpnlDnThPsCBCfmJB9B4ScSh5hSxmhD9JhB51fmVBqSZkp6BJ9CVRr3RQ9zkJsCBzpnlNp6AJe7xGoCJDbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I6039321917989617665_500&markAsRead=This email was intended for Nikitostalkerby/FPS. Learn why we included this at the following link: https://www.linkedin.com/blink?simpleRedirect=3wUdPgZp4BBr6dFt79x9z4MnT9Bp6VFrmlOnThPpnlDnThPsCBCfmJB9CNOlmlzqnpOpldOpmRLt7dRoPRx9zkJsCBzpnlNp6AJe7xGoCJDbjRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I6039321917989617665_500&markAsRead=
© 2015, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA


This broke all nixos tests because `hardware.firmware` is empty and `buildEnv` produces no output.


As usual, I really prefer my formatting....


How does the caller know if the serialization was successful or not? If someone accidentally passes a normal object here, there's no way for them to know if the call completed successfully.


same here


For testing puropose


I preferred the previous alignment, was easier to read.


Wenn man HAL ganz streng nimmt, müssen die link Relations (also die Keys) entweder registrierte Link Relations sein, oder aber URIs. (siehe https://tools.ietf.org/html/draft-kelly-json-hal-07#section-4.1.1)


Typo in commit message:  Should be Fixes #410 in r5_fixes


*Total* und *currency* würde ich eher einer verschachtelten Struktur zusammenfassen.


use getters and setter or see http://www.python-course.eu/python3_properties.php


ありがとうございます、調べてみます m_ _ m


"items" ist keine gültige Linkrelation, oder? Sofern es sich nicht um eine der wenigen offiziellen Begriffe handelt, sollte man eigene URIs verwenden - in unserem Fall könnte das sein "http://rels.innoq.com/project".


Just reading through the commits; is this how we want to implement it?
A device is usually taking care of the lowest layers, ipv6 would be run on top of it.

Is there such a close dependency between the device and the IP so that the init has to be implemented differently?

These are just questions, I don't have enough background knowledge.


Not sure what you mean. Reviews can be independent of QA. It's a limitation of our workflow that it only supports linear progress ;) In other words, PT labels actually make much more sense than JIRA states here.


I suppose we should update the comment to `in WebKit and MSEdge...` because of
```js
var needPreventScrolling = forMouseEvent && (Browser.isWebKit || Browser.isMSEdge);
```


Hm. I think the best would be to note this in the README and file a new issue to discuss what can we do about it.


You are right. Feel free to change the wording.


test this on an android emulator, it will show all stars for a second then back to normal when I click the component. After changing to ng-if, it displays normal.


Checking...


Agreed!

On Mon, Aug 24, 2015 at 4:18 PM, Sean Óg Crudden <notifications@github.com>
wrote:

> These really should be "hibernated".
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sheldonabrown/core/commit/08c4093b00efc8bbc206890de60a9e2510693846#commitcomment-12866036>
> .
>


Introduction

The Basic Process on how browsers work involves typing in a URL into your browser and pressing return. Your browser forms a connection to a Web server and requests a page .It receives it and the page pops up on your screen.
We will explore intrinsically what happens behind the scenes in your browser from when you type in the URL (uniform resource locator) in the address bar until you see the requested page on the browser screen.


Made the ```name``` and ```description``` attributes consistent for ```Individual```, ```Sample```, ```Experiment```, ```Analysis```.


name, grp = line.replace('\n', '').replace(' ', '').split(',')
return Person(name, group)


The `return new FileSequence( this->string() )` part of `isFileSequence()` will leak memory, because the new FileSequence will never be freed. Can we just use `IECore::FileSequence::fileNameValidator()` instead anyway, rather than create an object we don't want?


Well, I tried to understand `err`, `errs`, `Error`, ... a month ago and I gave up back then since it was impossible. And I don't even remember there being a `NewError` back then. So don't mind me, I'll simply ignore every line that contains an "err" substring (case insensitive) ;) :D


Git is not supposed to be used for large files, and GitHub is not supposed to be a file host either.


convention: for inputs that are **not** required we do not specify **empty** default values -- it should be:

```yaml
    - new_path:
        required: false
```

and later you can test if it is present with: `new_path if new_path else ''` -- if you use it only once, if you would use it many times you could define another input with this expression

please update all the inputs in this situation


For the love of God, **no [Yoda](https://en.wikipedia.org/wiki/Yoda_conditions)**!


Ông Thiệt lên đây sửa ngay lỗi, rồi tui mới merge zô


Line it up!


see comments inline


Ich frage mich (d.h. bin mir selbst nicht sicher), ob diese Relation nicht spezifischer sein sollte: Was kann der Client damit anfangen? Er müsste wissen, dass er sich gerade ein Projekt ansieht (das kann man voraussetzen) und daraus schließen, dass die "up"-Relation die Liste aller Projekte bedeutet - sofern das überhaupt korrekt ist.


для полей, которые целочисленные, вот например как *возраст* можно не пропускать через mysqli_real_escape_string, Там достаточно банального приведения к типу:
```php
...
age='" . (int)$age . "',
...
```
вот так напр.


type "that have an item"


Yup, I'm the one who specialized targetLanguage for each operator (super-/merged-/sliced-Language). It turns out to be a bad idea. Maybe we should revert to a generic targetLanguage?


Meines Wissens ist dies keine gültige Linkrelation; s.o.


I know you like the C++ style, but format the `*` according to local conditions — which here means like the other pointer `*` on the same line.


You've removed the ``-T TYPE`` argument below, so it should also be removed from the usage text.


Anderes Thema: Eine typische Diskussion die wir bei Kunden haben ist ob es gut ist manchmal ein Object und manchmal ein Array zu verwenden. Man könnte auf Array standarisieren und bei Link Relations mit einem Ziel eben ein einelementiges Array verwenden.
Das Argument dafür wäre, das es in manchen (statisch getypten) Sprachen nicht ganz einfach ist die JSON Bibliotheken zum polymorphen parsen zu überreden.


Oops, just - fixup pushed


+本书的各章相关工程以及资源文件可以在以下网址中找到：


I'm OK with grinning and bearing it given that its just GafferCortex using this functionality. Perhaps you could put a comment in alongside the metadata documentation, saying this is just for use in GafferCortex and should be avoided otherwise?


Möglicherweise sollte man diese beiden Attribute in einem gemeinsamen Kontext (Objekt) zusammenfassen:

```
"budget": {
    "total": 20000,
    "currency": "USD"
}
```

Falls später andere Zahlen hinzukommen (z.B. Stundensatz), ist ggf. nicht klar, worauf sich "currency" bezieht.


пролог


Thanks, fixed.


基于ZYBO板卡：http://pan.baidu.com/s/1bn1645h


基于ZedBoard板卡：http://pan.baidu.com/s/1i3zYvdV


```
styles: { large: "600x600>", medium: "300x300>", thumb: "100x100>" }
```


#4952-VRF-hard-crash-if-terminal-unit-list-error (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1800 of 1800 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


you can remove default navigation


Oops!


I think that many issue trackers only support linear workflow unless you decide, well, to use labels. Do you think that we should change the JIRA module to use labels for this as well? Not sure... In any case, I don't think that this is a decision we can make here. We need an abstract workflow that would be then implemented in the issue tracker modules. Right now it's linear because that is what is supported in all issue trackers. But if you think that we should drop this idea of state pipeline, we can discuss it let's say at Friday. I still think, though, that these two are not really separate and it doesn't make much sense to test when review is still not done. It can make sense, but sometimes it can lead to extra useless work, because as we know, you need to re-test when any review issue is fixed.


#4952-VRF-hard-crash-if-terminal-unit-list-error (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nice !


`<ul>` scheint mir angemessener, sofern es keine Sortierkriterien gibt.


Do we have a convention on putting default results in flows? Should they be there or should they be removed?
@oritstone @meirwah


Diese Relation kann man weglassen. Ich hab sie später von meiner HTML-Version übernommen, damit beide übereinstimmen. Braucht man aber eigentlich nur für die Navigation im Browser


errr....


Dies sollten jeweils eigene `<li>`-Elemente sein.


http://godoc.org/github.com/salsaflow/salsaflow/errs ;-)

Functions commonly used are basically `NewError`, `NewErroWithHint`, `Log` and `Fatal`.


"items" ist keine gültige Linkrelation; s.o.


If it makes anyone feel that much better to see a green Travis badge I'll figure out what's broken and add them back in, but it's a lot of headache for little added value at the moment in my opinion.


We only want to strip of the first part of the string we've checked it startswith, but I take your point - there was also a bug here too if the MEDIA_URL contained the hostname as well, so I'm changing this with:

```diff
diff --git a/pombola/info/migration_helpers.py b/pombola/info/migration_helpers.py
index 1a8dc7f..dd1c8c3 100644
--- a/pombola/info/migration_helpers.py
+++ b/pombola/info/migration_helpers.py
@@ -28,11 +28,11 @@ def get_first_image_file(file_archive_file_class, info_page):
     # If this is an image uploaded to the file_archive, we expect
     # the URL to begin with the MEDIA_URL followed by 'file_archive':
     image_path = urlsplit(first_image_url).path
-    expected_prefix = join(urlsplit(settings.MEDIA_URL).path, 'file_archive')
+    media_url_path = urlsplit(settings.MEDIA_URL).path
+    expected_prefix = join(media_url_path, 'file_archive')
     if not image_path.startswith(expected_prefix):
         return None
-    regex_to_replace = re.compile(r'^' + re.escape(settings.MEDIA_URL))
-    path_after_media_url = regex_to_replace.sub('', image_path)
+    path_after_media_url = image_path[len(media_url_path):]
     try:
         result = file_archive_file_class.objects.get(file=path_after_media_url)
     except file_archive_file_class.DoesNotExist:
```


Good point


Für derartige Aussagen zur aktuellen Ressource scheint mir `<link>` im `<head>` geeigneter.


okay


Oh, in that case it's not that terrible, but here are two points to think about:
1) `GetCodeReviewTool` and `GetIssueTrackerTool` functions are almost identical -> make it just one function taking the kind of module as an argument if at all possible. But maybe this will again hit Go's polymorphism limits.
2) Yes, if the instances don't keep state and/or are invoked with different contructor arguments every time (which they seem not to be), they should be singletons. I don't see any reason for creating dozen instances all the time when they are actually all the same (since they're mostly just namespaces for functions).


Ooops imported code without thinking about standards.


This should be `@compat UInt8(1)`


rowversion: my EF-Code First schema change


@joschiwald can you post the intended code ?


>>1. Здесь **$db** - это глобальная переменная. Подключение тут, я почти уверен, произошло.


Done


Ein <link> im <head> ist ungünstig, wenn man Ressourcen einbetten will. Da sollten alle refs zusammen liegen, oder?


BTW, this should be ``CIPHER_WRITE_WHITELIST``, but don't bother to fix it, because this code will change a little in my PR, and I'll take care of it.


Für Schlüssel-Wert-Paare wäre `<dl> <dt>$key</dt> <dd>$value</dd> ... </dl>` geeigener, da man damit auf standardisierte Semantik setzt. Allgemein sollten wir nicht-semantische Elemente wie `<span>` oder `<div>` vermeiden.


This is allowed but I will prefer if we change it as below:

```C
case PLK_CMD_CTRL_GET_FILE_BUFFER_SIZE:
         size_t*   fileBufferSize = (size_t*)pIrp_p->AssociatedIrp.SystemBuffer;
         fileBufferSize  = drv_getFileBufferSize();
          pIrp_p->IoStatus.Information = sizeof( size_t);
          status = STATUS_SUCCESS;
          break;
```


Yeah this was just a quick test - for speed & to avoid mistakes I generated the JSON from a reverse Marshal() call so there's stuff in there that's not required. I'll write something real later.


I think it's not a good idea to override the "normal" behaviour here. If you give as an argument a non existing port you should get a KeyError !


Copy!


rowversion: autogenerated code caused by my EF-Code First schema change


Will there be a 3.1.x (3.1.14) release and will this be included?


I will prefer if we use another variable instead of `bytesReturned` like below:

```C
BOOL      fIoctlRet;
ULONG    bytesReturned;
size_t       fileBufferSize;

fIoctlRet = DeviceIoControl(hFileHandle_l, PLK_CMD_CTRL_GET_FILE_BUFFER_SIZE,
                               0, 0, &fileBufferSize, sizeof(size_t), &bytesReturned, NULL);

if (!fIoctlRet || bytesReturned == 0)
{
       DEBUG_LVL_ERROR_TRACE("%s() Error in DeviceIoControl : %d\n", __func__, GetLastError());
       return 0;
}

return fileBufferSize;
```


Not a big deal, but if you can think of a good name, it might be good to extract `@presenter.finished? || !@presenter.started?` into a single method on the presenter.


It shows we should probably refine the function to make it more robust against mis-use. Maybe something like:
```c++
bool mastercore::get_Prices(uint32_t propertyId, md_PricesMap* ppricesMap)
{
    md_PropertiesMap::iterator it = metadex.find(propertyId);
    if (it == metadex.end()) {
        return false;
    }
    if (ppricesMap != NULL) {
        ppricesMap = &(it->second);
    }
    return true;
}
```


Im Vergleich zu JSON fehlt hier eine Typisierung: Der Konsument weiß nicht, dass es sich um eine Zahl handelt. Man könnte das durch spezielle Klassennamen ausdrücken ("t:int"), aber ich bin skeptisch, ob man `class` damit überladen sollte. Könntest du recherchieren, ob es anderswo (z.B. Microformats, Microdata, RDFa) bereits Lösungsansätze gibt, die man übernehmen könnte?


I'd prefer to keep "the old style" for the moment, to avoid rocking the boat.


Looks good. Thanks for your contribution.


I'd like a different function name here, all other functions are of the form check_group.


**1.** А вот, например, тут внимание вопрос:
Что такое **$db** здесь?
(ответ: это локальная переменная внутри метода. В неё не попало то, что было положено в глобальную переменную).


rowversion: probably not autogenerated


I think username and group can be made into const char* here, that should save the cast on line 445 of pam_yubico.c


I don't want to get into the workflow discussion here. Just (once again) pointing out, that it's not true that having labels is a mess, it can make sense for tasks which can run in parallel. Also, every issue tracker so far supported labels, didn't it? IMO it's more likely that some of them support just tags/labels and not states (and in PT you can't even configure them or change transitions, so labels are much more useful there). All in all, perhaps we should rethink our approach to workflow and use labels where it makes sense. IMO after trying JIRA for a bit, it's obvious that labels are actually very useful and flexible and certainly a better solution sometimes than a fixed workflow pipeline with preconfigured transitions like we had in JIRA.


That's a good thought. However, I'd generally prefer to execute operations locally where possible.
That is because the next step for this integration will be to do the communication via a local host channel, such as libvchan.


I'll update the commit note.


It might be worth extracting the diff & assertion logic into a custom assertion method.


Agreed, extras in constraints should issue a warning.

I'm torn on django[bcrypt] in constraints implying installation of it. Perhaps we should raise this to pypa-dev for wider discussion, before reworking? The issue is that its a slippery slope I guess: do we then have a thing to say 'and don't install other extras'? ...


You're right. I should add some logging here.


Ich bin mir nicht sicher, ob wir das "embed"-Konstrukt aus HAL übernehmen wollen: @tillsc und ich zumindest finden es eher abstoßend, weitere Ressourcen in diser Form innerhalb der Repräsentation einer anderen Ressource einzubetten.


rowversion: inserted manually to make use of rowversion


The scan failed.
Included commits

Commit ID	Owner

9872989bd39d3dd5979d62e853474ea3c26087cf	@BearSpace


The `<flow-name>/landing_page.txt` path feels a bit at odds with the existing paths, because it includes an underscore (although I suppose this makes it more likely to be unique). I wonder whether `<flow-name>.txt` would be better...?

@chrisroos: Do you have any thoughts?


Good point, I will update this using the last version.


@ccx-testerbot runtests


This is interesting


I appreciate your concerns, however at this project stage it seems the safest to me, to keep the blanket redirect.


Это типа добавили возможность указать слова, по которым комментарии на странице будут удаляться. Только вот у меня нет такой настройки в разделе редактирования группы.
`GroupsEdit.showObsceneWordsHint(document.body)` работает.


Es dient vor allem dazu, die Anzahl der Anfragen zu verkleinern, aber da wir uns vor zu vielen Anfragen wahrscheinlich nicht fürchten müssen, können wir es auch weglassen


const& (same after)


You didn't have to put that into the code :D
But yeah, it's a pity you have to reimplement map/filter/reduce ten times a day :)


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Code is a liability – it has to pay for existence/maintenance in function or convenience. The above code falls into the 2nd category, and IMHO falls short, because the code the caller has to write to prepare that dict parameter is about the same as to prepare the session object (once you know via docs that this is the way). Also quoting The Zen:

*There should be one-- and preferably only one --obvious way to do it.*

So if you ask me docs only is the way to go here, via concrete examples from real use-cases.


1) Yes, the point is that these functions return different interfaces, so you cannot really make them into one.

2) Isn't that just an implementation detail, though? You still need a function to get this singleton instance. Creating a new instance is almost free, so I am not sure why to keep an existing instance stored somewhere...


This isn't right, should not assume that opencog is installed under the home directory. You may use install `<OPENCOG_ROOT>` and explain that it stands for the path of the opencog repository.


It is not logging anything but I can repeatedly make it work with removing the @.
I’ve just discovered that I have v1.0.1 installed which was pushed to npm “a year ago” (see https://www.npmjs.com/package/hubot-darts). It actually was the 20th June, 2014 (https://github.com/hubot-scripts/hubot-darts/commit/52c77054847ac9f0bfb4016de14d10666e981807).

That is why I it does not contain this fix. Will there be a release anytime “soon”? :)

From: Devin Weaver <notifications@github.com>
Reply: hubot-scripts/hubot-darts <reply@reply.github.com>>
Date: 24 Aug 2015 at 17:54:51
To: hubot-scripts/hubot-darts <hubot-darts@noreply.github.com>>
Cc: Sören Gade <gade.soeren@googlemail.com>>
Subject:  Re: [hubot-darts] Minimal Viable Product for @mentions (185dd63)

@sgade do you have any logs? 'Cause I tested this with our slack adapter and it did work.

—
Reply to this email directly or view it on GitHub.


Das ist mir klar - aber in dem Fall sollte man m.E. zunächst sein Ressourcen-Design überdenken.


Please add it to the Friday agenda. It was your idea ;-)


So we're pretty sure that the problems with CMake 2.8 and generator expressions are Windows specific and don't have to bump the version of CMake we build with depends.


**Совет:**
Тут у нас используется паттерн типа "Active Record".
Он обычно использует глобальное подключение к базе - да. Тут проблематика следующая: ***Как "пропихнуть" ему этот объект глобального подключения?*** Чтобы в каждом методе не задавать ему параметром это подключение. Я посоветовал бы сделать так: сделать закрытое (private) поле класса User, например такой же $db.:
```php
...
public $firstName;
public $secondName;

private $db;
...
```
 И при создании объекта мы через конструктор можем задать ему это поле:
```php
...
public function __construct( $db )	{

		$this->firstName = $firstName;
		$this->secondName = $secondName;

                $this->db = $db;
...
```
 и дальше внутри этого класса мы уже работаем c $this->db а не с $db:
```php
...
	public function registr() {

		$sql = "INSERT INTO users SET `firstName` = '".$this->firstName."', `secondName` = '".$this->secondName."'";

		$this->db->query($sql);
...
```


Another suggestion is `index.txt` to indicate that it's the page shown when you visit `/<flow-name>/`. I think I might have a slight preference for either `<flow-name>.txt` or `index.txt` over `landing_page.txt` but really don't feel particularly strongly.


Sorry about my understanding on English, do u means I should just add new changes for feature, don't change any format in whitespace?

I have test my patches on the Git for windows 2.5.0, it work. and, I will port this pull request to git for windows 2.x


A different approach here would be to use getgrnam() (or preferably getgrnam_r()) on the group to get a list of members that would save the call to getgrouplist() which isn't strictly portable.
That way would require an extra call to getpwnam() (again getpwnam_r()) to get a possible group in the passwd file and compare that gid with the gid returned from getgrnam_r() but that should still be cheaper.


I just wanted to entertain us ;-)


Also please don't use malloc here, a static buffer should work fine since we know the size beforehand.


There was already a 'CONTENT' string,
![screen shot 2015-08-25 at 11 34 23](https://cloud.githubusercontent.com/assets/11783388/9463513/54e748e0-4b1d-11e5-9557-be2eefe20c00.png)

@rhukster going to revert NAME: and CONTENT:, where are they used to match your change? (cannot find them)


This line breaks the project deletion. I tried to list projects on OSE, picked one from the list (so it definitely exists) and tried to delete it. I got "the server could not find the requested resource".

You should apply similar approach that is in DefaultClient:
https://github.com/openshift/openshift-restclient-java/blob/master/src/main/java/com/openshift/internal/restclient/DefaultClient.java#L241


BTW: There's a gazillion hardcoded "enderio:" strings that could be replaced, too.


P.s. I'm adding new strings at the end of the list, and to all languages for now (we need a better/proper way to handle translations now)


Okay, I kind of get it (although I surely forget it again, there's just too many almost identically named concepts around), but that module is really terrible. Why do all those functions operate on `error` interface but then cast it to `Err` unsafely? Since you decided to use your own error interface for tasks (which is fine by me), there should be no more `error` anywhere but in the `Err` constructors. It should be just an implementation detail.

I'm not sure it's possible to change this at all, since it's all over the code now, but I'm honestly not feeling bad about not understanding this stuff, it's just way too overcomplicated...


modify also CMake file to remove pthread lib existence check


Yeah, baby steps :P


Even though this is a quite bad error (malloc failing) please don't use exit for errors here, return an error instead. This holds even more true for later errors.


Ah thanks! Forgot this.


I'm not sure if I understand the first sentence. Also, I used the description of "--force" as an inspiration, which doesn't mention command too.


That's strange. "Missing radix parameter" seems wrong, as the second parameter is indeed the radix value for decimals. Also, note that the parseInt should include the " * 0.8", as the height parameter is expected to be an integer.


I don't know what it does (and the polkit manual isn't crystal clear either), but I'll add it.


What's the foo for?


Nice job, thanks for making the (Naive)Cnf class injectable.


*arg_wall is deliberate. When --message= is used, it is read as one argument. I didn't want to introduce additional variable for that, therefore I reused arg_wall. In this case, it will only contain zero or one string (the message).


the rest of the module is using the D(()) macro for different kinds of diagnostic output, this is error messages but maybe it makes sense to use D(()) for it anyways.


@phalox I've asked myself the same question, but 6LoWPAN compression depends highly on the assumption that IPv6-addresses are derived from the Link Layer addresses, either the 64-bit EUI-64 of the IEEE802.15.4-capable device or the 16-bit short address of the radio (after an PAN-association event, up to the device-driver).
So in the current version of picoTCP there's only either Ethernet-framing or IP-framing but, IP-framing with a random Link-Local address.. Which is not preferred as I mentioned above.

I've also asked this question to @maximevince, if I am allowed to implement it like this, but I think this small addition to the pico_device structure is a bit insuperable in order to do 6LoWPAN-framing.

Maybe I see it wrong, if so, please feel free to enlighten my assumptions! :smile:


OK. Three random things:

1 - **I like the `--verify-base-url`** that you can call whether you override `base-url` or not - I agree it's often a nice convenience to fail fast, and I think having that available if you've overridden base-url is handy.

2 - One of my frustrations in the past with `verify-url` is that my selenium tests are usually mixed into a suite of other tests. Sometimes I'm running py.test -m 'not selenium' which doesn't call any of my selenium tests and as a result there's no need to spin up my test server. My experience (also with pytest-mozwebqa) is that verify-url happens seemingly at test collection and as a result is noisy when it shouldn't be. **Is there anyway to make `--verify-base-url` only happen when you're actually running a selenium test(s)?** (I have a feeling that the answer is no, but thought I'd ask)

3 - I think I've been misunderstanding `skip-sensitive` - I'm now understanding that sensitive_url is true or false once for the whole test run. The skip_sensitive is per function, because a function may be marked explicitly as nondestructive. (I previously thought that it was somehow checking the url that was being accessed for each different test - like there might be sensitive parts of a website or not.). I think I'm right in thinking that the use case for this is that you run the same test suite against different versions of the same website - `dev/local` | `staging` | `production` and you want to know what tests not to run against a production environment. And you're taking the cautious approach so all tests are dangerous by default. Assuming all of this is right, --sensitive-url=None seems good & clear. It might be worth adding a little more to the docs to explain these concepts more. e.g. "By default, all URLs are considered to be sensitive." I saw this in the context of "all urls within your test suite" but what you mean, I think, is "By default, any base url is considered to be sensitive."


I Updated the email content line be line and I also did a revert due to git add field base by mistake.


It's not really complicated. It just operates on `error` and internally does some additional stuff in case the `error` is actually an `errs.Err`. And it doesn't cast unsafely, where did you see that?

Not sure whether the whole concept of the package is good or not. I basically didn't want to case what kind of error object is returned. People usually return `error`, they never return custom error objects directly. In case you want or need to access a custom error object, you need to cast to it manually. That is how the Go stdlib works as well. But perhaps here I could have used something else since all the functions operate on the same custom error interface... Dunno... But it's true that the refactoring would be totally a PITA.


**2.** Кстати, тут тоже я вижу, что $firstName и $secondName локальные переменные, они не объявлены даже как аргументы в функции-конструкторе, потому они будут пустыми всегда...


The scan failed.
Included commits

Commit ID	Owner

9872989bd39d3dd5979d62e853474ea3c26087cf	@BearSpace


I agree. I guess this should be an exception on the level of things that `query` itself could throw... I could just make it an `error "..."` for now?


Fixed in https://github.com/wso2/carbon-business-process/pull/162.


@arun-khandavalli Looks good. Thanks!


@ctrurden
I would like to do that. Any clues what git magic to perform. Looking on the Internets it looks difficult and messy.... Is it actually easy?
Rebase then something else?


I think `receive` is now too long and complicated - we should break it out into submethods (for handling the instance-specific action, the general spam action and the receiving of the mail), particularly as I think there's a good case that we may want to reuse the logic for detecting whether an incoming mail is spam or not in order to e.g. not send bounce messages for that mail if the request is closed to new responses.


size() needs to be reactive too


Why are you removing the reactivity?


Nice job!


We've been trying to develop a secure site where the token is saved off in a cookie. Esri IdentityManager is supposed to append this cookie to all calls to the arcgis server, but it isn't working. This change is an attempt to get the proxy to append the token whenever IdentityManager fails to do so.


i used use mod_rewrite in .htaccess and works well now
but i see error

A PHP Error was encountered

Severity: Error

Message: Call to a member function clear() on a non-object

Filename: admin/Email.php

Line Number: 112

Backtrace:

in link http://www.clubshare.net/admin/email/send
when i try to send mass email


We do still want to automatically discard spam from the holding pen if `spam_action` is set to `discard`. For that reason, I think it would be better to move the holding pen check to [the 'holding_pen' clause of the `spam_action` case statement](https://github.com/mysociety/alaveteli/commit/8c2adc81d7633df6d759280c80b0ad91af8dc433#diff-5f7dfe1185cac97cbc9f9dc356abce7cR489):

```diff
when 'holding_pen'
-            reason = _("Incoming message has a spam score ({{spam_score}}) " \
-                       "above the configured threshold ({{spam_threshold}}).",
-                       :spam_score => spam_score,
-                       :spam_threshold => spam_threshold)
-            request = InfoRequest.holding_pen_request
-            request.receive(email, raw_email_data, false, reason)
-            return
+            unless self == InfoRequest.holding_pen_request
+              reason = _("Incoming message has a spam score ({{spam_score}}) " \
+                         "above the configured threshold ({{spam_threshold}}).",
+                         :spam_score => spam_score,
+                         :spam_threshold => spam_threshold)
+              request = InfoRequest.holding_pen_request
+              request.receive(email, raw_email_data, false, reason)
+          end
+          return
```


写出这个数 (20)


I think it's probably worth a comment here explaining why we need to do this.


minor point, this would probably fall under the "constants" umbrella, and thus should be ALL_CAPS:

https://www.python.org/dev/peps/pep-0008/#constants


Why do you want users to see this?


Misinterpreted your comment.

Yeah you're right that logic should be changed to use the Group instead of addr.


Note that this will likely be considerably simplified once we have down the format of the hexList.


@dthree are you developing on windows per chance?


Forgot about that `@gapi["id"]`! Thanks for reminding.


This alpha update is most of all for #58 and #128. I only updated this for now. #58 is only an enhancement and #128 only affects the Mac build. On the next major update I'll recompile the windows version as well, and at least it will be recompiled on the official opening of the alpha build.

And for now I've done enough. I'm going to take a break and some sleep. I'll see you again tomorrow.


OK, refresh! for now.


Good point, PR is welcome!


一朝回到解放前


Zone-VS-WSHP-system-sizing-draft (EnergyArchmage) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-89.06%25-red.svg)


Neat, didn't know about that!


I'm not crazy about wrapping `id` in square brackets. This seems orthogonal to representing the `id` value. Perhaps wrapping vs. not wrapping is better as a separate convenience method that would add the square brackets if needed? Something like `Table#query_id`?


Done


Hah, whoops.


@BoltzmannBrain You need to update the tag to point to this commit. The `0.2.1` tag/release still points to the previous verion


Hello @suddensleep cc: @laumontemayor @traymetis @jonhanke @julialintern
Good job on all 3 questions of command line!


101789044_gridviewFilters (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2284 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.48%25-yellow.svg)


But you wanted the convenience of a super short method when writing queries! And am I wrong, or do all generated project IDs contain dashes?


@BoltzmannBrain This `setup.py` is not installing the `fluent` package. Try using `find_packages()` function instead.


Gotcha, was just curious if there was anything I wasn't seeing
Op 25 aug. 2015 10:57 PM schreef "Andrew Smith" <notifications@github.com>:

> This is a replica of existing code, so couldn't give you a answer on this
> until I look through the code properly.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/silentworks/revolution/commit/90c823d36f4963b0b51f7d989e0a9f2f7919ef9c#commitcomment-12889859>
> .
>


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 418](https://teamcity.labkey.org/viewLog.html?buildId=268480&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:41
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


WHO REMEMBER


Yes, but we can also use the `Table#id` method outside of writing queries. If we wrap the value in square brackets we are coupling it to one use case. What if I want to use the id for something else and now I have to strip the square brackets off?


This is unnecessary, see my comments on the Border method.


Looks like this `@wip2` is a typo.


Still having trouble with borders and shading. I think my code might have to be redone to accommodate the shading and words that still need to be inserted.


Bench number is:  "split_low_depth"
It should be:  7620871


@emiltin `datum` here comes from the [lua binding](https://github.com/Project-OSRM/osrm-backend/blob/feature/raster_sources/extractor/scripting_environment.cpp#L147) (in order to handle out-of-bounds values, both `query` and `interpolate` return a small `RasterDatum` class that has `result.datum` and if out of bounds, is equal to `result.invalid_data()`). Since this is a source-agnostic feature the lua bindings can't name it altitude or elevation, but if you have other ideas for less confusing terms I would be open to them


no \n at EOF^^


There was only one aclService and it was the default bean despite being named named differently. I had to rename it so it went to the two seperate aclService beans. I'm not getting a compiling error, just server/sql stuff. I'm at IT tomorrow and at the gardens all day thursday.


in the second commit i allow this for unsigned manifests and disallow for signed, should have made it into this commit. In theory probably changing signed manifests should ALWAYS be disallowed but for now i just did it for changing ID and RunAsUser


Ok, sounds good. No brackets added by `Table#id`. Easy enough to add to query. I'll move the brackets to the example.


You dont translate strings any more?


removing this comment in a followup commit, added twice accidentally


:+1: :bow:


LGTM


ceiling operator^^


same here


I can put it back if you want.  r, I was thinking of maybe styling it some other way.  Maybe represent back to school somehow?


project name


_eigval should probably be a local variable


:heart:


this kind of check is awkward because it keeps the type system from catching things at compile time, but I didn't want `listener.go` to have to do the checking. Probably the best way to do it, this way some implementations of the policy interfaces don't need to require signed manifests.


@vspinu you're probably relieved that you won't have to merge all those pull requests anymore ;)


What I mean with making omit a set not only pass as default argument a set, but to make omit itself a set. This would enhance also setting omits:
```python
# with list:
fm.omit.append("yeah append...")
del fm.omit[3]
# with set:
fm.omit -= "yeah append..."
fm.omit |= "yeah now easily inserting with set!"
```
set just has more appropriate behaviour imo^^


and about documentation:
if a user wants to see the meaning behind `optional_params`, he will land on the property params. He doesn't want to read the complete class doc (like me) to just know what exactly the field means.
And declaring documentation as a heavy maintainance overhead... I don't know :O


It contains  multiple ads. We can name it @advertisements


yeah but anyway this doesn't make the `omit`-argument better :O
and changing this shouldn't be that hard


There is an extra space after "still"


# ALSO!!

## Improved the frequency grabbing function. Added optional extra outputs so can almost immediately feed into a plot.

## Began to add an extra section to AnalysisMain to reflect this next step.


How'd I miss that? lmao


Uma referência para a issue https://github.com/braziljs/eloquente-javascript/issues/108


Thought it might be confusing (or incorrect):


How about
if (params.contains("$where")) s"""$({params("$where")}) and  ($where)""" else where

?  This does not add parenthesis if you don't use and.


nice one.

:+1:


谢谢！


Thanks for these changes! Looks good :)


Yes...working well


version non finalisée


Do you expect to implement this in all deployment backends? Also, is the $form needed is you're providing the $sha param?


This will return stdClass - it needs the second param (true) to return an array.


@pimpmaneaton

Your settings https://github.com/TeamBliss-LP/android_packages_apps_Settings/commit/e9285fdf15368f22f5722f230146faaf221cf6c2

Change SecureSettings to SystemSettings in your res/xml/notification_drawer_settings.xml


out of sync*


It looks like the only change in this file is renaming this instance variable.  Is this necessary as part of this as it adds quite a bit of noise to the commit?


This is broken. By settings `this._settings` to another object it undermines the settings tree and that data will no longer be saved.


最後に改行をいれましょう。


Noice.

On Tue, Aug 25, 2015 at 3:06 PM, oneilljos <notifications@github.com> wrote:

> [image: 11903514_10152951176766529_1575673359_n]
> <https://cloud.githubusercontent.com/assets/5553582/9476445/a6ce9f60-4b21-11e5-85db-b05f5c592964.jpg>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/deanmarsinelli/City-Protectors/commit/d78e62dba2ab2e74ee1db54ad0d9dfc99cc31bce#commitcomment-12887503>
> .
>


DONE


DONE

I've added it as optional parameter. PTAL


@cgcgbcbc Brilliant.


Hmm, yes I thought we would update old backends as well to support this, even if they return an empty strategy.

TBH I just copypasted the deploy signature :-) deploy form has `getSelectedBuild`, so fine to drop SHA. I wonder if DNEnv and DNProj is also obtainable from that form?


In app/models/user.rb we should change farmer to platform_admin

In db/migrate/20150826002317_create_stores.rb we should update to make photo into photo_url


Yep. I haven't actually ran this code :)


이게 뭐여?? 프롬 모바일..


:tada: great work!


Just a heads up, you forgot to change a use of 'indirectMapsPrepped' on like 1478. Just needs to be changed to:

> If indirectMapsVersion < master_im_version

You also didn't seem to commit your additions of two global variables in 'ScopeDecl'. Once again, a small fix:
> Global GetDecl_Fail:Int
> Global GetDecl_Success:Int

Other than that, it's running really well. I'll be sure test it thoroughly. I don't have the time to look into it closer right this minute, but it's been working thus far.


thanks


Isn't requireAdministrator cannot startup?


历史将把你铭记！


然而主要是jjy的


looks good, but I think it'd be useful to add another line here on why this function exists (what's the expected use case?)


I would keep flaky-tests in the first line, and the second line unchanged. I wouldn't worry too much about long lines in this type of file. If it grows again, it can be split by wherever makes sense then. This kind of line changes can be a headache when doing merges or trying to understand history.


good


Ahh cool, thank you for the link. I searched and didn't find it.


We just need to invoke multirust override "$rustVersion" here to tell rust which version to use for the next compilation, and then we're all set.


やる気が微塵も感じられません


おねむなのね


I believe you should be grabbing a random IP from this list (but maybe it's already randomized for you).


Yeah, actually we were using it to avoid running other test that already had @wip, but forgot to change it back.


By design of ofCourse for course history this commit should be reverted. ofCourse detects the current term and loads that as the default participants page. But you can also select to do an 'all' option that will show everyone who has taken the course in the past.


@joshuafcole Can you elaborate? I don't follow 100%. I'm calling multirust override on line 87. Do I need to call it again?


Why did you put the region names on the endregion? They weren't broken.


Like I'm really not trying to shoot down everything you do but you don't need to put the name on the end directive


It would be good not to require the template. Ie if you have the model with
no template it generates a tile like dexterity generates a view. And the
themed can use diazo if they want to change it. This means we aren't
requiring intergrators learn zpt lowering the learning curve.

On Wed, 26 Aug 2015 02:30 Asko Soukka <notifications@github.com> wrote:

> @espenmn <https://github.com/espenmn> This adds support for supermodel
> XML based transient configuration for theme fragment tile. Just create a
> supermodel XML schema using Dexterity schema editor, export the XML and
> save it as foobar.xml next to foobar.pt. If the schema does not include
> any required fields, you may need to edit tile after adding to see the
> schema based fields. In template those field should be available as
> request/form/yourfieldname -variables.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/collective/collective.themefragments/commit/d073229e51778fdc0a25006a94ad76d0e070172c#commitcomment-12887977>
> .
>


Cheers :) sorry it was in such a state; copying by hand from another
version of the code with no chance to even compile it isn't a recipe for
success :)

On 26 Aug 2015 01:46, "Anthony Diamond" <notifications@github.com> wrote:
>
> Just a heads up, you forgot to change a use of 'indirectMapsPrepped' on
like 1478. Just needs to be changed to:
>>
>> If indirectMapsVersion < master_im_version
>
> You also didn't seem to commit your additions of two global variables in
'ScopeDecl'. Once again, a small fix:
>>
>> Global GetDecl_Fail:Int
>> Global GetDecl_Success:Int
>
> Other than that, it's running really well. I'll be sure test it
thoroughly. I don't have the time to look into it closer right this minute,
but it's been working thus far.
>
> —
> Reply to this email directly or view it on GitHub.


DONE


![NO SERVERS](http://www.leap.com.au/images/features/no-servers-no-worries.png)


How do I use this?
I enter in the ArrayPropertyEditor but I can't change the array size.


maybe do an ng-if here or filter on backend so they dont even show up?


I know how regions work. It is a good idea to do it for the times when you have, say a typo.


972124-2NewDetailedIceStorage (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1799 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


{# LOL #}


What do you mean by that?


Nothing, if you want it with no endmarkers with names then change it back. Either way it saves time in some cases.


@reckbo @pnlbwh @pradyu1993 @petersv2

This is the source location of the problem where fa values were not being properly updated.


Is that because a batch group can be part of both batchGroups and spilledBatchGroups list ?  Is that expected or does it point to a possible problem ?


I'm afraid IDs change often and this example may require some tweaking before it can work once the images are updated. Is there any way to specify image_name instead?


972124-2NewDetailedIceStorage (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Shouldn't this be inputStream = null; ?


101789044_gridviewFilters (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I think there's a config for disabling it make sure it still works.
If there is no config, please add it, some people (me included) don't like the music =P

Also, music discs? :D


Code is LGTM.
Does this new API need to be documented about how to delete a web page resources?


Major changes were made to the UART handling and tested.  We now have the ability to read characters from the UART0 input stream.


@rBatt Was this the right way to split these two types of files apart? As you pointed out, what we upload is somewhat different from what one downloads from the website. The complete_r_script.R only works on the latter, and I'm trying to make them a bit more distinct.


you should indent with spaces, not tabs


Here I'd say DreamCompute first and OpenStack after. What do you think of "This guide is for software developers who want to deploy applications to DreamCompute, which is based on OpenStack."?


谢谢你为互联网做出的贡献


@pradyu1993 This is the source commit that caused the computational errors in FA.

NOTE FA is no longer updated in most caeses because it is part of the if/else construct.


I think it is wrong to have null BatchGroup stored in the list.  I think we should modify the following line:
                  spilledBatchGroups.addFirst(mergeAndSpill(spilledBatchGroups));
to something like:
                 BatchGroup bg = mergeAndSplit(spilledBatchGroups);
                 if (bg != null)  {
                    spilledBatchGroups.addFirst(bg);
                 }


is this supposed to be .exclude().exclude()?


I think the wording "You must have a project..." is confusing. Since we are talking about DreamCompute customers, we may just say "We assume you have already an account to DreamCompute. If so, you have been assigned a 'project' (also known as a tenant in OpenStack lingo) and a maximum quota, depending on your subscription level." or something similar.


no, why?


Why not reuse `id` here instead of building the string again?

```ruby
def query_id
  return "[#{id}]" if id.include? "-"
  id
end
```


Remove "Fixes #3271" from the commit message


What do you mean?


you should be able to change the array size, could you describe in more
detail what you are doing?

On Tue, Aug 25, 2015 at 10:02 PM, Guilherme Felipe <notifications@github.com
> wrote:

> How do I use this?
> I enter in the ArrayPropertyEditor but I can't change the array size.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/okamstudio/godot/commit/04cb3c9eb13b3824f676bc29e037802bffc3bdac#commitcomment-12893277>
> .
>

--

*OkamStudio*


I think doing .exclude(cond1, cond2) is like exclude(cond1 && cond2) and i think you want .exclude.exclude which is exclude(condl1 || cond2)


fixes #49


since the easiest way to get these information is from the RC file, I'd say let's link it from up here and say something like:
"Download the DreamCompute RC file  from [link] and find there the following information:
* auth url
* ecc ecc
"


Shouldn't `View#refresh!` should be in an RDoc category as well?


we probably don't need to specify this here. Try to make the instructions shorter and straight to the point.


101789044_gridviewFilters (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Is this cached at all? It might be better to use `CourseAPIPresenterMixin. _get_structure()` since it is cached - though that's a private method and so would possibly need to be refactored.

Also should this be behind a switch? ([see here](https://github.com/edx/edx-analytics-dashboard/blob/89a83992ee1d4a91ee565a55fc368213bd302144/analytics_dashboard/courses/views/__init__.py#L55))


According to SimplePicker UX, when the left/right button is focused it reads <value> + <press ok button....>
and when value is changed it reads only <value>, but your code always read <value> + <press ok button ....>.
Also I think we don't need accessibilityLive for SimplePicker.


O modal.pack server para passar parâmetros a função de callback do modal. Então, a função de callback aqui é c_delete. E dentro do modal.pack eu passo o id, de forma que o a callback será chamada com:

```
c_delete(modal.pack)
```


see my comment above, check with libcloud if specifying the name instead of the id is possible. I think this will make the code more resilient and generate less friction.


Good point. Dictionaries are great!


It's looking good. I left some comments inline.


Not sure on why you need to add all the keys.
Would it remove every single key that you had (even in serverData, and previous operation sets) after revert is done?

In here, I guess what we should really remove from availableKeys is the keys that don't exist on `serverData` as well as don't exist on any `operationSetQueue` - meaning the keys that were added/removed only the last operationSet and that are unique to that operationSet.


i will try my best .


Ew.  Use the CLI.


That's the plan from now on. :P


Forgot to mention:  the straw going through the register_stair_and_slab call should eventually done directly in moreblocks since it's basically a default node.  For now, it belongs here in castles.


Thanks for the comments @lscheinkman, I moved this to #163.


This seems wrong; see https://github.com/w3c/web-platform-tests/pull/2107. This implies Servo is getting document cloning wrong (or I misunderstand the specs).


DId this work? Do you know what mistake you are doing? Read about has_many, belongs_to and has_one. Why and how we use it. What does it do?


EvapCoolerTwoSpeed-fixup (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I sure am glad you are figuring out the gnarly networking challenges, and not me.

Also, this

> You can now successfully navigate to an already-running simulation.

is awesome.


yes


Projeto Tavern


HPVariableSpeedEquationFit-fixup2 (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2309 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.55%25-yellow.svg)


`multirust override` serves two functions. In the case that the requested version is not installed, it installs it and switches the current rustc and cargo symlinks to that version. In the case that it is installed, it just switches the symlinks. This is necessary even when the current version is installed because it might not be the currently symlinked version.


Maybe a bug in portaudio version:

Make an LFO and set the rate to 100. Although this is a low frequency
oscillator, using 100 should still give an acceptable audio signal. Feed
the sine wave output to the output. In the original version I get the
expected low frequency buzz. In the port audio version I get a screech. You
can see the issue in the scope too.

On Tue, Aug 25, 2015 at 12:49 PM Dan Piponi <dpiponi@gmail.com> wrote:

> Here's a quick summary of what's available on a basic real oscilloscope:
>
> Horizontal scan rate and scale. On a real oscilloscope these are decoupled
> but the horizontal scale should exactly match the time to sweep across the
> window here.
> Vertical scale.
> Trigger rules. The simplest are trigger on rise and trigger on fall past
> an adjustable threshold.
> Dual trace, one for each of the left and right channels.
> X-Y mode. It'd be cool to use the left channel for one axis and the right
> channel for the other. Allows you to compare the phase of two signals.
> A superimposed grid :-)
>
> Also, if the oscilloscope can listen for OSC messages I could drive it
> from the UI or even from the physical patch panel.
>
> It's probably mildly painful to implement but the phosphor effect is
> actually useful as it allows you to see how something is evolving over time
> by comparing the current trace with the faint glow of what happened
> earlier. It probably needs double buffering between a pair of texture
> buffers you render into and a shader to copy from one texture to the other
> with a fade and a blur. I hate setting those things up in OpenGL as
> mistakes often give you black pixels with no explanation.
>
> On Tue, Aug 25, 2015 at 8:37 AM barnabyrobson <notifications@github.com>
> wrote:
>
>> Awesome ! Yeah I'm hoping to add the synchronization triggers soon. (btw
>> q. about the paralysis .. it doesn't change day to day; pretty consistent)
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/dpiponi/Moodler/commit/5974fb0265cb0d4a7ee46127e7c18d72ea7ee9ce#commitcomment-12883015>
>> .
>>
>


OH COOL I actually did what you told me to do without even reading your
full comment :D SCORE

On Tue, Aug 25, 2015 at 4:13 PM, Michael Marineau <notifications@github.com>
wrote:

> So is this actually working as-is? I would have thought that the
> close(loop); would trigger the autoclear and thus make mount not work. If
> so you'll need to change the function to pass out the value of loop and
> skip closing it until you have finished the mount.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ionave/seismograph/commit/396c5f01621eea5c3c54aecec799786edb6e9215#commitcomment-12892083>
> .
>

--
____

Sara Ezgi Akgul
ECE@Illinois, 2016 | www.ezgi.me


ㅇㅇㅇ


OR ELSE


Might be a false alarm...

On Tue, Aug 25, 2015 at 6:31 PM Dan Piponi <dpiponi@gmail.com> wrote:

> Maybe a bug in portaudio version:
>
> Make an LFO and set the rate to 100. Although this is a low frequency
> oscillator, using 100 should still give an acceptable audio signal. Feed
> the sine wave output to the output. In the original version I get the
> expected low frequency buzz. In the port audio version I get a screech. You
> can see the issue in the scope too.
>
> On Tue, Aug 25, 2015 at 12:49 PM Dan Piponi <dpiponi@gmail.com> wrote:
>
>> Here's a quick summary of what's available on a basic real oscilloscope:
>>
>> Horizontal scan rate and scale. On a real oscilloscope these are
>> decoupled but the horizontal scale should exactly match the time to sweep
>> across the window here.
>> Vertical scale.
>> Trigger rules. The simplest are trigger on rise and trigger on fall past
>> an adjustable threshold.
>> Dual trace, one for each of the left and right channels.
>> X-Y mode. It'd be cool to use the left channel for one axis and the right
>> channel for the other. Allows you to compare the phase of two signals.
>> A superimposed grid :-)
>>
>> Also, if the oscilloscope can listen for OSC messages I could drive it
>> from the UI or even from the physical patch panel.
>>
>> It's probably mildly painful to implement but the phosphor effect is
>> actually useful as it allows you to see how something is evolving over time
>> by comparing the current trace with the faint glow of what happened
>> earlier. It probably needs double buffering between a pair of texture
>> buffers you render into and a shader to copy from one texture to the other
>> with a fade and a blur. I hate setting those things up in OpenGL as
>> mistakes often give you black pixels with no explanation.
>>
>> On Tue, Aug 25, 2015 at 8:37 AM barnabyrobson <notifications@github.com>
>> wrote:
>>
>>> Awesome ! Yeah I'm hoping to add the synchronization triggers soon. (btw
>>> q. about the paralysis .. it doesn't change day to day; pretty consistent)
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/dpiponi/Moodler/commit/5974fb0265cb0d4a7ee46127e7c18d72ea7ee9ce#commitcomment-12883015>
>>> .
>>>
>>


FixupPlantTempSource (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Then tell me Erik, what else could we potentially use that could interact with the Atmospheric systems, wont cause LINDA to have a heart attack, and not to mention this is just the first commit.

Deprecated code is being brought up to date because that shit is from a 2012 build.


谢谢！


What'd I break? :)


972124-2NewDetailedIceStorage (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (749 of 749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.21%25-green.svg)


you guys want to work on the site please
because I'm kind of the only one who understands my JS... but feel free to ask questions :P because I don't understand it all myself either


Any feedback on this one?


@yankejustin, He means after the machine starts up the application won't run because it requires administrative permissions (If UAC is set to it's default value).  I'm not sure where to go from this, but Task Scheduler seems like it might be a good option.


No, not false alarm. It's consistent between the two versions. Very strange.

On Tue, Aug 25, 2015 at 6:32 PM Dan Piponi <dpiponi@gmail.com> wrote:

> Might be a false alarm...
>
> On Tue, Aug 25, 2015 at 6:31 PM Dan Piponi <dpiponi@gmail.com> wrote:
>
>> Maybe a bug in portaudio version:
>>
>> Make an LFO and set the rate to 100. Although this is a low frequency
>> oscillator, using 100 should still give an acceptable audio signal. Feed
>> the sine wave output to the output. In the original version I get the
>> expected low frequency buzz. In the port audio version I get a screech. You
>> can see the issue in the scope too.
>>
>> On Tue, Aug 25, 2015 at 12:49 PM Dan Piponi <dpiponi@gmail.com> wrote:
>>
>>> Here's a quick summary of what's available on a basic real oscilloscope:
>>>
>>> Horizontal scan rate and scale. On a real oscilloscope these are
>>> decoupled but the horizontal scale should exactly match the time to sweep
>>> across the window here.
>>> Vertical scale.
>>> Trigger rules. The simplest are trigger on rise and trigger on fall past
>>> an adjustable threshold.
>>> Dual trace, one for each of the left and right channels.
>>> X-Y mode. It'd be cool to use the left channel for one axis and the
>>> right channel for the other. Allows you to compare the phase of two signals.
>>> A superimposed grid :-)
>>>
>>> Also, if the oscilloscope can listen for OSC messages I could drive it
>>> from the UI or even from the physical patch panel.
>>>
>>> It's probably mildly painful to implement but the phosphor effect is
>>> actually useful as it allows you to see how something is evolving over time
>>> by comparing the current trace with the faint glow of what happened
>>> earlier. It probably needs double buffering between a pair of texture
>>> buffers you render into and a shader to copy from one texture to the other
>>> with a fade and a blur. I hate setting those things up in OpenGL as
>>> mistakes often give you black pixels with no explanation.
>>>
>>> On Tue, Aug 25, 2015 at 8:37 AM barnabyrobson <notifications@github.com>
>>> wrote:
>>>
>>>> Awesome ! Yeah I'm hoping to add the synchronization triggers soon.
>>>> (btw q. about the paralysis .. it doesn't change day to day; pretty
>>>> consistent)
>>>>
>>>> —
>>>> Reply to this email directly or view it on GitHub
>>>> <https://github.com/dpiponi/Moodler/commit/5974fb0265cb0d4a7ee46127e7c18d72ea7ee9ce#commitcomment-12883015>
>>>> .
>>>>
>>>


I mean the difference between the two versions is consistent. The port
audio version seems like it's getting the wrong samples. Or the LFO is
broken in your version - but that's implausible I think.

On Tue, Aug 25, 2015 at 6:35 PM Dan Piponi <dpiponi@gmail.com> wrote:

> No, not false alarm. It's consistent between the two versions. Very
> strange.
>
> On Tue, Aug 25, 2015 at 6:32 PM Dan Piponi <dpiponi@gmail.com> wrote:
>
>> Might be a false alarm...
>>
>> On Tue, Aug 25, 2015 at 6:31 PM Dan Piponi <dpiponi@gmail.com> wrote:
>>
>>> Maybe a bug in portaudio version:
>>>
>>> Make an LFO and set the rate to 100. Although this is a low frequency
>>> oscillator, using 100 should still give an acceptable audio signal. Feed
>>> the sine wave output to the output. In the original version I get the
>>> expected low frequency buzz. In the port audio version I get a screech. You
>>> can see the issue in the scope too.
>>>
>>> On Tue, Aug 25, 2015 at 12:49 PM Dan Piponi <dpiponi@gmail.com> wrote:
>>>
>>>> Here's a quick summary of what's available on a basic real oscilloscope:
>>>>
>>>> Horizontal scan rate and scale. On a real oscilloscope these are
>>>> decoupled but the horizontal scale should exactly match the time to sweep
>>>> across the window here.
>>>> Vertical scale.
>>>> Trigger rules. The simplest are trigger on rise and trigger on fall
>>>> past an adjustable threshold.
>>>> Dual trace, one for each of the left and right channels.
>>>> X-Y mode. It'd be cool to use the left channel for one axis and the
>>>> right channel for the other. Allows you to compare the phase of two signals.
>>>> A superimposed grid :-)
>>>>
>>>> Also, if the oscilloscope can listen for OSC messages I could drive it
>>>> from the UI or even from the physical patch panel.
>>>>
>>>> It's probably mildly painful to implement but the phosphor effect is
>>>> actually useful as it allows you to see how something is evolving over time
>>>> by comparing the current trace with the faint glow of what happened
>>>> earlier. It probably needs double buffering between a pair of texture
>>>> buffers you render into and a shader to copy from one texture to the other
>>>> with a fade and a blur. I hate setting those things up in OpenGL as
>>>> mistakes often give you black pixels with no explanation.
>>>>
>>>> On Tue, Aug 25, 2015 at 8:37 AM barnabyrobson <notifications@github.com>
>>>> wrote:
>>>>
>>>>> Awesome ! Yeah I'm hoping to add the synchronization triggers soon.
>>>>> (btw q. about the paralysis .. it doesn't change day to day; pretty
>>>>> consistent)
>>>>>
>>>>> —
>>>>> Reply to this email directly or view it on GitHub
>>>>> <https://github.com/dpiponi/Moodler/commit/5974fb0265cb0d4a7ee46127e7c18d72ea7ee9ce#commitcomment-12883015>
>>>>> .
>>>>>
>>>>


@d3agle Oh. So we're talking about how it is pretty annoying that we have to get the admin. privileges every single time? That is understandable. :)


@d3agle Go to gitter and contact MaxXor about getting back into the organization. Permissions were changed a bit.


Just build a new `/turf/` e.g. `/turf/snow/` and dont use `/turf/space` anywhere on the map, since there are a lot of things ingame that check if you are in space, which will act oddly in the snow (jetpacks, and other things)


Bad hardcode of rm/test location


HPVariableSpeedEquationFit-fixup2 (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


of course, I created a Node2d and I put this code to it:
``` GDScript
extends Node

export(StringArray) var test

func _ready():
	# Initialization here
	pass
```
then I click in the Node2D and I go on ArrayPropertyEditor and I tried to change.

This message appear in console:

ERROR: call: Invalid method 'size' for type 'Nil'.
   At: core/variant.cpp:2949.
ERROR: call: Invalid method 'resize' for type 'Nil'.
   At: core/variant.cpp:2949.
ERROR: call: Invalid method 'size' for type 'Nil'.
   At: core/variant.cpp:2949.
ERROR: call: Invalid method 'size' for type 'Nil'.
   At: core/variant.cpp:2949.


May help #46, not $46


ah that is interesting, I didn't think of that. The problem is that your
property is null, even if your type is a StringArray. I'll see what to do
about this. Try instead:

export var test=StringArray()

On Tue, Aug 25, 2015 at 10:41 PM, Guilherme Felipe <notifications@github.com
> wrote:

> of course, I created a Node2d and I put this code to it:
>
> extends Node
> export(StringArray) var test
> func _ready():
>     # Initialization here
>     pass
>
> then I click in the Node2D and I go on ArrayPropertyEditor and I tried to
> change.
>
> This message appear in console:
>
> ERROR: call: Invalid method 'size' for type 'Nil'.
> At: core/variant.cpp:2949.
> ERROR: call: Invalid method 'resize' for type 'Nil'.
> At: core/variant.cpp:2949.
> ERROR: call: Invalid method 'size' for type 'Nil'.
> At: core/variant.cpp:2949.
> ERROR: call: Invalid method 'size' for type 'Nil'.
> At: core/variant.cpp:2949.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/okamstudio/godot/commit/04cb3c9eb13b3824f676bc29e037802bffc3bdac#commitcomment-12893710>
> .
>


ありがとうございます！


Why it says I didn't finished my assignment on Coursera?


So good to do this but it should remain commented out. Can you fix and we'll take the pull.


Thanks!  Could you please submit on CMS, though?


Can you try the template from ac9c63ade827c66fe805c6d4bdffd3408c3ef002, which I re-saved using Word 2007? I still wasn't able to reproduce this; even with Word 2007 the old template worked. But hopefully this will fix things for you and others.

I'm not sure how to make the UI appear in Customize Ribbon setting of the preferences, but if you can figure out how, let me know.


actually i wrote code already to handle your situation so it must not be
working, will check

On Tue, Aug 25, 2015 at 10:44 PM, Juan Linietsky <reduzio@gmail.com> wrote:

> ah that is interesting, I didn't think of that. The problem is that your
> property is null, even if your type is a StringArray. I'll see what to do
> about this. Try instead:
>
> export var test=StringArray()
>
>
>
>
> On Tue, Aug 25, 2015 at 10:41 PM, Guilherme Felipe <
> notifications@github.com> wrote:
>
>> of course, I created a Node2d and I put this code to it:
>>
>> extends Node
>> export(StringArray) var test
>> func _ready():
>>     # Initialization here
>>     pass
>>
>> then I click in the Node2D and I go on ArrayPropertyEditor and I tried to
>> change.
>>
>> This message appear in console:
>>
>> ERROR: call: Invalid method 'size' for type 'Nil'.
>> At: core/variant.cpp:2949.
>> ERROR: call: Invalid method 'resize' for type 'Nil'.
>> At: core/variant.cpp:2949.
>> ERROR: call: Invalid method 'size' for type 'Nil'.
>> At: core/variant.cpp:2949.
>> ERROR: call: Invalid method 'size' for type 'Nil'.
>> At: core/variant.cpp:2949.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/okamstudio/godot/commit/04cb3c9eb13b3824f676bc29e037802bffc3bdac#commitcomment-12893710>
>> .
>>
>
>


@orangemocha yes, notification received. I have to agree with @Fishrock123 ...


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Ayaw ko nung tinype mo!


I realized this as well and now I tried this way and it works.


What constrains it to not doing this during mingw builds?  It seemed to build unless I screwed something up, but I don't understand how this works?


my bad.


This assertion will never fail.

If I change the function to
```
void
fast_handshake_state_free(fast_handshake_state_t *victim)
{
  return;
}
```

the test doesn't fail, and if I change it to:

```
 void
 fast_handshake_state_free(fast_handshake_state_t *victim)
 {
  memwipe(victim, 0, sizeof(fast_handshake_state_t));
  tor_free(victim);
 }
```

the test crashes (and the assertion will not fail).

That's one example of why is so hard to test any `_free` function. :umbrella:

(Don't worry, it's worth the learning)


Should have quotes around most variable evaluations here


Accidental paste?


It might be worth thinking of a better name or explanatory note for this - its non intuitive as to why two scenarios exist/are substantially the same.


I see that this is fixed in the recent commit (9a03d99b). Still I think mine is shorter and more elegant. :-)


@yankejustin, Right, the client won't run at all on startup, no prompt or anything.

Oh ok, I see you are able now to make changes as a Collaborator.  That's cool!


R.I.P


You can just do `!self.industry` here, `null` and `undefined` are both falsy values.


I cannot merge this commit, because it will break my version. You can use this method to avoid rewriting import paths. https://splice.com/blog/contributing-open-source-git-repositories-go/


remove test file here.


`if ((*txn)[sfAccount] != zero)`


What is `options` used for if you call `options_act` with the unchanged `old_options`?

Are you testing that `options_init ` provide default values that make `options_act` behave in a specific way?


In general, MySQL table names are case sensitive. We cannot force the names to lower case like that. There must be another solution to your problem. https://dev.mysql.com/doc/refman/5.0/en/identifier-case-sensitivity.html


The idea is that we should return the url only if it's configured to do so, with the previous version, the url was returned always even if we want Superdesk to act as a proxy to S3.
You are right about not returning the URL, will fix.


Like this as well


Each change should ideally be a commit (and a seaprate pull request):
* Added new time slider
* date format added to settings
* improvement of popover placements
* some css fixes, some smaller css fixes (please properly describe ;)

Ok? :) If in doubt, check the commit history of owncloud/core and how we do it there: https://github.com/owncloud/core/commits/master


The partial above (appointment_for_affidavit_norway) is used in two outcomes (outcome_os_affirmation and outcome_ss_affirmation) so I don't think it should be inlined. If a partial is only used in one place then I think it should probably be inlined (like the text for 'macao').


1) Replacing client.baseUrl with client.baseurl (lowercase) : https://github.com/stormpath/stormpath.js/blob/02be5c32fc2605c207c09e19527c9e9ab1aedb10/lib/client.js#L19

2) Adding the "sso/" part after the base url.

These changes have been tested (using a custom ID Site) using a Lite plan (api.stormpath.com) and with an Enterprise plan (enterprise.stormpath.io).


Did you need to introduce a partial here? Unless the partial is going to be used elsewhere I would've been inclined to put it straight into the outcome_os_affirmation.govspeak.erb template.


According to the yacc documentation, nonterminals can contain letters, dot "." underscore "_" and noninitial digits. So the regex we need is `^[a-zA-Z_.][a-zA-Z0-9_.]*`


Hi Varun,

For the scenario where new framebuffer is completely outside the old frame buffer all 3 if's are true and will overwrite the region outside the old framebuffer.

It should actually be:
             if (phys_base > vmem_end_old || video_mem_base > vmem_end_new) {
 		zeromem16((void *)video_mem_base, video_mem_size << 20);
             } else {
                         if (video_mem_base < phys_base)
                                     zeromem16((void *)video_mem_base, phys_base - video_mem_base);
                          if (vmem_end_old > vmem_end_new)
 		                  zeromem16((void *)vmem_end_new, vmem_end_old - vmem_end_new);
            }

Just check if i have missed any scenario.


@jasonlewis  Why not report the exception? Considering the API doesn't provide a stack trace the only way you can get the stack trace is by looking at the log.


@kdkocev

Съкратих с няколко реда view-то.

Използвам това, че в темплейтния език поучаваш цели обекти, от които можеш да викаш методи и пропъртита.

Махнах и една заявка защото я имаше два пъти.


Please add proper comments -- ApJ


Add Comments..


A couple of points in regards to your PR:
- 400 should be changed to one of the predefined constants used in the library (see top of the page).
- Don't hard code language strings in the library, use one the predefined language files instead.
- Whitespace is missing between the end bracket and curly braces, as well as the fat arrows.
- Doesn't conform to CI3's style guide e.g.  we use Alman styling for curly brackets.
- Doc comment is a mismatch with the rest of the library.

Then I have a question. Why is it restricted to POST only?

Honestly, this is just my opinion, but at present this is to specific and something a user could easily/should easily create themselves when they extend the REST server library.


Probably worth while. Will look into it. Stack trace is provided if you set `API_DEBUG` to `true`.


Is it definitely correct that the address of the British embassy in Seoul has been removed from these outcomes?


Not having used gmails storage before I think I've shared it with you - if
not let me know and I'll try again

On Tue, Aug 25, 2015 at 6:55 PM, BerndGabriel <notifications@github.com>
wrote:

> Unfortunately attachments are not passed to github comments. You might
> post it to the google code issue 411 before Aug 28 instead or upload it to
> a public file sharing host and post a link to it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BerndGabriel/HtmlViewer/commit/5ae61acf6811ad78b90085bd3a591606d1a3db88#commitcomment-12886071>
> .
>


Because I didn't want that position anymore?


Done


The link is dead. https://github.com/vimeo/vimeo.php/archive/v1.2.2.zip results in an error (Not found).


Ah I didn't know that :) but yeah is good for production then to know the stack trace.


> That's a very old version of gen_rst you are using.

Yes. I just wanted to point out the hack. One day, we'll have to take
time to include sphinx-gallery in the scipy lecture notes (which is where
this will be integrated).

> I'll make an issue to support seaborn in sphinx-gallery.

Thanks, and you can copy / paste this hack, which works fine.


So you agree that this is a possible runtime error and we should provide some alert? I was well aware of h2 and the SAS interface initialising that data structure...


You'd also need to actually call this from the dispatch method as you only call render at the minute.


Wouldn't using cc instead of gcc break compilation for "regular" unix? I thought "cc" is just an alias one can set for gcc or anything else, but is not set at default.


thanks man, good luck!


No, this is always correct, but potentially an optimisation. This will
never cause an error.

On 26 August 2015 at 20:05, Miquel Ramírez <notifications@github.com> wrote:

> So you agree that this is a possible runtime error and we should provide
> some alert? I was well aware of h2 and the SAS interface initialising that
> data structure...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tobyodavies/LAPKT-public/commit/4d705b2ca1c330454bcea35d2d18d60be2a1553d#commitcomment-12899374>
> .
>


Make sure this says `_send_unicast(iface, l2addr, l2addr_len, pkt);` and not `_send_unicast(iface, l2addr, l2addr_len, payload);`


Is it definitely correct that the address of the British embassy in Beijing has been removed from these outcomes?


How was this working before? :confused:


Sorry, I think there's been some confusion here (and it's totally our fault for not explaining how this works better in the README). The app is translated through the .po files in `/locale`, using gettext and the scripts in `/bin`. These extract strings from the templates in `/templates` and then can be used to generate the working, translated versions of the templates which get automatically placed in `/www/templates/en` or `www/templates/es`.

So, you shouldn't add and edit these files directly, instead you should add a new Spanish .po file in `/locale` and then use the scripts to generate Spanish versions of the templates.


it should be var_dump($token->body->access_token) as it is saved in the body (this is true for the other examples on this page as well).


Yes, that's because users can now use the online booking system for appointments. They used to contact the embassy directly to arrange an appointment.

FCO has been rolling out this change gradually.


Change back to `if (!gnrc_netapi_dispatch_send(pkt->type, GNRC_NETREG_DEMUX_CTX_ALL, pkt)) {`


This fixes the problem Configuration Center had with icons in /usr/share/pixmap but isn't a 150-px grid too large for 32-px icons? 100 px seems more natural to me.


I revert commits (without this old variable) yesterday because I notice collaboration import doesn't work on firefox after I push my code. I forget to delete it in the new commit. I just have removed it again in the new commit.


Yes, it's been replaced by links to the online booking system :)


I wonder if it would be worth encrypting the entire database in a production system.  Or even the file system too.

Yeah, we should work out the procedures for what data obfuscation guarantees we provide.

The inspiration for bcrypt came from [this HN thread](https://news.ycombinator.com/item?id=9277835).  Apparently Slack's security is something we could get inspiration from.  They were hacked, but no one was really concerned because they had best practices in place that, to my understanding, guaranteed as good security as you could get.


you can remove a sudo here too right?


rename the variable name


I think some rate limiting or otherwise limiting of such warnings is needed.


Got it. I'll update this commit, thanks :)


This test case does no longer test what the description says (Stopping an app sets instance count to 0). I'd either change the description to something meaningful, or remove the test. You could e.g. verify that there is actually no call to `repo.expunge`.


>= check


It looks as though these changes should have been in a different commit - they're unrelated to the full stop change.


系统消息部分。zcdl（注册登录）先别看。要修图


Okay

On Wed, 26 Aug 2015 20:06 Toby Davies <notifications@github.com> wrote:

> No, this is always correct, but potentially an optimisation. This will
> never cause an error.
>
> On 26 August 2015 at 20:05, Miquel Ramírez <notifications@github.com>
> wrote:
>
> > So you agree that this is a possible runtime error and we should provide
> > some alert? I was well aware of h2 and the SAS interface initialising
> that
> > data structure...
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/tobyodavies/LAPKT-public/commit/4d705b2ca1c330454bcea35d2d18d60be2a1553d#commitcomment-12899374
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tobyodavies/LAPKT-public/commit/4d705b2ca1c330454bcea35d2d18d60be2a1553d#commitcomment-12899388>
> .
>


Is there some check that makes sure ipv4 modules is loaded or built in?


We can't merge this in with your config in place, but that's our fault for having this file in git at all. What should really happen is that this file is ignored in the `.gitignore`, and we just keep [the example one](https://github.com/mysociety/fixmystreet-mobile/blob/phonegap-3/www/js/config.js-example) in the repo instead. Then everyone who uses the code can set up their config without having to check it in (You could keep secret API keys in it for example). Sorry for the confusion, can you remove this? A fixup for the earlier commit that added it (https://github.com/mysociety/fixmystreet-mobile/commit/ffe35e1c9ca5a89599b31aa1aa73da355f8792f7) would be much appreciated too.


add break statement


There's small typo here: extens should be extends


@jancborchardt: Normally I'm fully your opinion, that changes should be documented and small steps are much better.
But actually @libasys  is working hard and continuous on the project and personally I would like more, that he invests his time in coding and fixing and not in documenting and splitting pulls.
If he does it like now (fixing and pulling a paket and new "release" all 2-5 days and closing issues with reference on version) he has much more time for coding.
And you can test each closed issue for working or new issues.

If this actual "crunch mode" is over, it should be the way you described!


Maybe I am nitpicking, but the "DELETE FROM" line does not normally need 2 qualifiers unless there is more than 1 line containing the same value as one of the qualifiers. Using both qualifiers(column values) will only remove the line if it already exists in the form that you insert, which is correct (on its own) for inserting a new line when there is no line there before, but not if a line exists with a different value for one of the qualifiers.

Because there are only 2 columns in the `spell_script_names` table, you would only need to remove an existing line if it exists with a wrong value in 1 of the 2 columns or if you need to insert a non-existing line and also make the query repeatable (which is correct in itself). So the way I see it, you should remove any existing lines that also contain a wrong value in one of the 2 columns in addition to making the query repeatable. This will work for inserting a non-existing line and making the query repeatable, even if you use only 1 qualifier.
It is more likely that someone would have inserted a wrong spell script name than the spell id.

By the way, I just ran these 3 queries on the current world DB in TDB 335.59 (+ updates) :
```sql
SELECT * FROM `spell_script_names` WHERE `spell_id`=49575 AND `ScriptName`='spell_dk_death_grip_pull';
SELECT * FROM `spell_script_names` WHERE `spell_id`=49575;
SELECT * FROM `spell_script_names` WHERE `ScriptName`='spell_dk_death_grip_pull';
```
None of them returned a result, it only remains to make sure the qualifier logic is correct for DELETE FROM.


We'd rather not merge this with debug lines like this in place, could you remove them?


I think this function can return dst_entry as well, just like the ipv6 function. Perhaps this can open the way for more code sharing between the two protocols.


I've increased the grid because of the text -> many application (especialy in other language than english) names do not fit into the smaller grid (too long words). And of course one can use a bigger font => it would be better to compute size of the grid based on the longest word in application names to fit ...


Do we need defined sections in our classes? If not then this comment can be removed.


Is there any chance you could lift the curtain on how to find opcode IDs for new build?


array(); ?
I've already made this bundle wildly incompatible with php 5.3 anyway (see my last few commits)


Nag push na po kami kanina ng bagong update sir. Gumawa kami ng new branch
then dun po namin nilagay :)


Course sections/subsections should be tracked as well (without the "supported" argument).


@atd, thanks for feedback. From angular-swellrt v0.9.3, the syntax for this is: swellrt-avatar-options="{numberOfAvatars: 4}"

Also, the options available at [SwellRT avatars](https://github.com/P2Pvalue/swellrt/wiki/Extras#avatars) are available through that parameter (size, padding, numberOfAvatars, css, ...)


Yeah I'll look into implementing the logging. Shouldn't be very hard at all really.


Did you need to introduce a partial here? Unless the partial is going to be used elsewhere I would've been inclined to put it straight into the outcome_os_consular_cni.govspeak.erb template.


It looks like we might need to think of a way of keeping this config file separate from the git repository too, as it has app-specific information in it that we can't merge. The ideal would be to introduce a config.xml-example file, with the initial FixMyStreet config in it, and comments explaining what each setting does, similar to how we (should) deal with `www/js/config.js`


There is a discussion about the configuration center [here](https://github.com/lxde/lxqt/issues/501)


Is this initialization needed here? It should already have been initialized in `CourseBaseActivity`, I think.


@jorisberkhout @twilkinson573 I would prefer it to say:
`/rli/ser-scenario-2023`
`/rli/80-procent-co2-reductiescenario-2050`
`/rli/95-procent-co2-reductiescenario-2050`


Great discussion thread to review.

The consensus on tooling that I've found is that bcrypt is great vs. crypto but you sacrifice speed (perfect for creating a user account for example).

I think that certainly in the short term if we use a hardcoded (system config file) salt along potentially with a salt generated per user all run through bcrypt that should give us reasonable security for our use case. Hackers would have to have full access to the machines database and file system - realistically impossible to break them from an accidental open source leak.

(That being said looking at how opinionated people are on the matter this post might get be blacklisted from future employment!)


I actually mean you should create your own form type which is standard Symfony, see http://symfony.com/doc/current/cookbook/form/create_custom_field_type.html. Further you maybe should look into form types within Sonata, see: https://sonata-project.org/bundles/admin/2-3/doc/reference/form_types.html

If you understand these articles you should be able to create your own Form type, based on https://github.com/sonata-project/SonataCoreBundle/blob/master/Form/Type/BasePickerType.php and https://github.com/sonata-project/SonataCoreBundle/blob/master/Resources/views/Form/datepicker.html.twig


Can you explain why you needed to add this? As it is, it seems like something that might introduce security issues in a live app...


"Typically"


to be able to distinguish those from the other ActorIdentity that is used for identifying the receptionist, see

    case ActorIdentity(_, Some(receptionist))


`courseComponentId` needs to be updated, as the user navigates to next or previous course unit.


The method override can be removed now I guess, as it's not doing anything.


+ :+1: Good method name `prompt_delete`
+ :+1: Thoughtful handling of different ways of typing "yes"

What do you think about lines 60-65? Can you see an opportunity to reduce the amount of lines needed without changing the behaviour?


Hey @shs96c
I know this is one very old commit I've digged out, but the logic remains in the newest versions.
This piece of code makes it very hard to test sites that use hash based navigation, e.g. facebook.com/#!/profile/foo

Do you know of any easy way to force webdriver to expect a load event, even if the only change of the url is the hash part?


@gaearon, just published `0.0.2` on npm.


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


Thinking of it...
![München Bier Festival](http://www.francetvinfo.fr/image/74rf9h1if-0c32/1500/843/869619.jpg)


Similar to the previous comment, can you see an opportunity for reducing the amount of code on line 81-88 without changing the behaviour?


I fixed and submitted a new test...


Do you know why "test/data/marriage-abroad-responses-and-expected-results.yml" appears in this diff. It says there are 3,018 additions and 3,018 deletions but it doesn't show any changes.


This value has just been stored in line 82: just use `end_pwrlvl` in the call to `svc_suspend()`


We could even remove the `selectedUnit` variable now, since it can be fetched by id from each method. That's how it's done in `CourseBaseActivity`.


Overall good, feedback is for minor stuff, well done :+1:


Codacy Code Error Correction


Yes, I think it does. It would be nice if these comments were indented so that they align with the code, and a bit more descriptive if possible.


Great!!

2015-08-26 12:15 GMT+02:00 atfornes <notifications@github.com>:

> @atd <https://github.com/atd>, thanks for feedback. From angular-swellrt
> v0.9.3, the syntax for this is: swellrt-avatar-options="{numberOfAvatars:
> 4}"
>
> Also, the options available at SwellRT avatars
> <https://github.com/P2Pvalue/swellrt/wiki/Extras#avatars> are available
> through that parameter (size, padding, numberOfAvatars, css, ...)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/P2Pvalue/pear2pear/commit/8e7e1737855d3cde4ea218bece9a4d2734fc883e#commitcomment-12899542>
> .
>


ha! old habits die hard

this loose typing throughout in the code base is a real boat anchor


These method overrides aren't doing anything, so they can be removed as well I guess.


Unfortunately we don't have a serializer for the enclosing `Identify` / `ActorIdentity` messages anyway, but you are right in that I should not use `Some` (I thought that was part of the `Identify` signature).

This should be enough:

    val Heartbeat = "H"


Hmm, since you've had to change these, I think it would be a good idea to move them into the config file, rather than have them hardcoded. That way each app could use the tile servers it needed without having to change the code.


doesn't install via composer for cakephp3.0.12, even when [dev-master], @dev ... ...


Table search is broken.


Please remove the commented out line, as it doesn't serve any purpose. The `EXTRA_COURSE_UNIT` key can be removed now.


I think it would be more efficient to just handle frags in the resp/comp code. If you need some of the headers linearized perhaps you can use __pskb_pull_tail directly.


Some of these outcomes look a lot smaller than before (e.g. test/artefacts/marriage-abroad/cote-d-ivoire/uk/partner_other/opposite_sex.txt). Is that where they used to use the consular CNI outcome and are now using the marriage_via_local_authorities outcome?


I think this is only needed because of the confusion with the translations. If you supply a Spanish translation file, you can translate "FixMyStreet" in that, and then won't need to add this setting or change the templates to use it.


This is odd.
The outcome has been renamed and I can see that all outcome nodes for the Netherlands have been correctly updated to `outcome_marriage_via_local_authorities` in that file.


In that case this should be done from `setUnit()`.


I don't think that it a good way for other IDE users, checkstyle usually used everywhere and it doesn't enforce text to be enforced to width. cc @lanwen as he better knows this topic


Could you remove this debugging code?


I think this should fix all the cases. Thanks.


Similarly, could you remove this debugging code and the commented out sections?


Thank You and Be safe!


$ git clone https://github.com/google-homepage/google-homepage


I think the idea here was that when you set `CONFIG.FMS_URL` you add a trailing slash to it, so that these aren't needed.


The memset covers this just like it does for IPv6.


Yes. I have double-checked that with FCO and asked for an explanation, but I've only received a confirmation and no reason for the change unfortunately.