@julen

When this function is called synchronously there is no job.id - so the logging fails


shouldn't initial payload be loaded in client cache, so first request will get data without fetching?


We should protect against an NPE here as well in the event that the key doesn't exist in `elem`:
`keyElem != null && !keyElem.isJsonNull()`


the title might better have been put as "Allow handling of async jobs" - apologies


Hi Giso,

How exactly should I read this?

'Code written in packages created after September 2015'

Is this all created code (i.e. new classes and features) written in packages after September 2015, regardless of when the package itself was created, or all code written in packages that were created after September 2015 (i.e. the entire package didn't exist before that date)?

I'd prefer the first, because it would allow us to slowly (but steadily) move towards having everything namespaced where the latter will leave all legacy code untouched. However, existing packages not always have a clear namespace structure (for example Windmill) which might lead to inconsistent namespacing. Therefore I'd propose to split the rules:

- Major releases of packages after September 2015 MUST have namespace structure guidelines, these guidelines MAY be implemented in the entire package.
- Code written after September 2015 MUST use formal namespaces when namespace structure guidelines exists and when this does not break the working of this package.


Please mind commit messages — history is a very valuable part of the codebase.


This is a good smoke test, but would be nice to extract some information out. Groovy has some nice regex handling, maybe that could help if you couple it with some debug/test logs?

Regex example: https://github.com/JakeWharton/RxBinding/blob/master/buildSrc/src/main/groovy/com/jakewharton/rxbinding/project/KotlinGenTask.groovy#L169-L192


sterge cookie nu o seta la null `$.removeCookie('pickedWebsite')`


Namísto boolean používej bool alespoň v php.


:+1: for adding the extra tests, and working out how to mock `raw_input` :)


A tiny thing, but I think `s/Attempting to move/Moving/` here and below would be more confidence-inspiring :) (I don't think they can fail at this point.)


Why do you need a guid table? Isn't the GID table in IB core enough?


@magnars https://github.com/clojure-emacs/clj-refactor.el/commit/ed962d2ecbee170e24b51434a6724bd66ccb6f97


* Do you actually link against flowgraph.o? (check that on the linker command line)
* Try to put it in proper namespace declarations: `namespace inexor { namespace vscript { extern void node_render_test(); }}`


I'd still move this to `migrate_layout_settings` and instead yield `dmgr` itself here


missing period


Validation is an a type of application error that should be displayed for client.


Isn't this also called from the rxe_release call below?


    settings = {k, v for k, v in settings.iteritems() if v is not None}

Otherwise you'll actually set those values to `None` in the DB (and e.g. for bool options that makes no sense since we only expect True/False there)


(See my earlier comment about factoring out this "get from slug or ID" code.)


You should never call the kref's destructor function directly. Always use kref_put.


To clarify:
* Areatrigger is roughly at the middle of the bridge
* Master guard spawns at one side and runs toward the player position (which should be about the same than the AT)
* Slave guard spawns at the other side and follows the master guard
* On evade, both NPCs switch to random movement around a point in the middle of the bridge


Hello @mikeyc7m, @nyeholt and @tractorcow ,

I have to apologize. I'm sorry for this. I should have checked this better. I need a holiday :/ Sorry.

I provided a fix for this: https://github.com/silverstripe-australia/advancedworkflow/pull/223 Maybe someone wants to test this ?

Thanks for bearing with me,
Spek


The module_put is also called from rxe_release.


Saved the changes


can we skip themes we don't have anymore? (just use a list of allowed themes and set it to None if the theme is not in the list)?

that also reminds me that we wanted to remove the two themes from the dropdown which look exactly like the default


i don't like ``To do this``. you can reverse the sentence : you have to create a Gruntfile.js to configure grunt to manage the assets.


I thought that this should only be used for boss encounters of progression event (like doors or the like). But if you say I can use this instead, I will since I already have to add several more TYPE_* to handle the various Grim Guzzler events.


I don't understand this, the comment is saying there should be no exception, but the test is expecting a `ClassCastException`.
I didn't realise that an array of docs was a possibility here, what query did you use?


why not assign `e.stylesheet_metadata` directly?


 These changes make me confused...

Are we vendoring font-awesome or will bower fetch it?


I believe you can skip ALL non-conference events here

        it = self.zodb_root['conferences'].itervalues()
        if self.quiet:
            it = verbose_iterator(it, len(self.zodb_root['conferences']), attrgetter('id'), attrgetter('title'))
        wfr = self.zodb_root['webfactoryregistry']
        dmr = self.zodb_root['displayRegistery']
        for event in self.flushing_iterator(it):
            if wfr.get(event.id) is not None:  # meeting/lecture
                continue
            dmgr = dmr[event.id]
            # ...
            # yield ...


code style | add new line


magic numbers

Why 90??


This also seems to work on our HIPP Hudson machine: https://hudson.eclipse.org/californium/job/scandium/97/


Checkmarx scan results 26 Aug 2015 11:26 UTC +03:00

High
Medium
Low
Info

New
36
31
37
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3313e2b14249afcd46ac55a41363eb331dba88ca	@dudug


Caching implementation just landed, makes sense to try, however that would trigger some `shouldComponentUpdate`/event triggering that can be avoided by simply ignoring first routes update.


align this line with all code


magic


> Since I have to add a file mask to the FindFirstFile in Win32, I am doing this with *.pot, vs *

This contradicts the documentation for this feature, and make Windows behave differently than non-Windows. We will end up with "support issues".

> I know that you can have .pots with extension other than .pot (or no extension at all). But I am not going to load them. Loading 'random' files inside of code that expects a certain formatted file, is usually NOT a smart thing to do, but you own this code block ;)

Any problem with that would be a bug in some valid(). Also, it would be a user problem: As documented, the directory should only contain pot files but they don't need any extension.

We need to unify this behavior. I'm willing to change the non-Windows code if you can convince me it's more usable that way.


@suutari-ai: Bower fetches the LESS files for Font-Awesome, but the binaries are vendored. This could be improved at some future date (with, say, a build step that copies those files from the bower directory to where we need 'em.


Hm, no idea? What are the constructors good for? :)


Would there be a problem with just importing this from `pombola.core.tests.test_commands`? (Or maybe it would be more generally useful in commonlib, but nothing else is imported from there at the moment.)


Yes, RoCE v2 is not "other ethertypes". Why is the driver attached to a net_dev by the way? Why not to a UDP socket?


magic number, move it to define of use MAX_UINT from std libs


Relative to the .sublime-project file itself. The ST API has a trick for that if I remember correctly :-)


I am a nice comment


It's function only for internal use. Make it static


You should move to a hash table so that you aren't limited by an arbitrary ifindex.


Thanks!


heh, auto-generated from best.sh... this should be removed.


@vcunat thanks! I missed that :disappointed:


If, instead of subclassing `unittest.TestCase`, you subclass `TestCase` from `django.test` then each test will be run in a transaction, so you can leave out the `tearDown` method. https://docs.djangoproject.com/en/1.6/topics/testing/overview/#writing-tests


Why is this externally available? To use the sockets in the rxe_req file?
IIRC it currently uses its own per-QP socket. But it could use this I guess.


Anyway, to close this thread, what should I do? Do you want me to implement `Get<Module>` functions so that they only construct a single instance and keep it cached or what? I am getting lost here :-)


@ndisha


I'm on debian testing, maven 3.3.3 and Open JDK 1.7.0_79.
I will investigate this.


а зачем так сделал?  ruby style guide читал? )


> why which


Use addrconf_ifid_eui48. It is exported by the RoCE v2 patches.


Hey Boris,

Did you mean FEATURE_RTX here ?


What is this for? Since we're not doing `from h.api.groups import *` I didn't think we needed it. Also thought that `__all__` in a package was supposed to be a list of modules, not functions.


All rxe is in the same module, right? So there's no need for two references on the module for each device.


Yeah... I noticed this particular commit because the commit message was different from the automatic one: `Merge branch 'devel' of https://github.com/arangodb/arangodb into devel`


Why we need to update `babel-eslint` as well?


I didn't realise that an array of docs was a possibility here, what query did you use?


可能会更新的比较慢


Читал, конечно. Там это проходит как "Option B": https://github.com/bbatsov/ruby-style-guide#consistent-string-literals

Кроме того, свежая информация: https://viget.com/extend/just-use-double-quoted-ruby-strings


it's implicit


В целом, в этом проекте везде используются двойные кавычки, так что для единства стиля.


dma_device is only used for sysfs, as the DMA operations are replaced by the driver with null operations.
So why do you need the real_dev and not the vlan one?


why elasticsearch depends on it in the first place ?


PR #3207


This also escapes html stuff properly.


artifact versions belongs to parents


I'm also lost, I thought you started a philosophical debate already :)

AFAICS, these factories don't do anything useful, they just call `NewCodeRieviewTool` and similar, which in turn also don't do anything useful :) So just look at all that code that is invoked when you want to go from an ID to an actual instance and make it in just one step, instead of many steps like it is now. Makes sense? ;)


@johan, maybe a better model name would be ChangeLog so the trait could be ChangeLoggable?


noise


TeamCity pull requests :: netty [Build 109](https://garage.netty.io/teamcity/viewLog.html?buildId=724&buildTypeId=pulls_netty&guest=1) is now running


how is it related to ES ?


97204612_MultiSpeedFan (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1283 of 1283 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.99%25-green.svg)


not related to ES


#4942-VRF-with-water-cooled-condenser-does-not-pass-hard-flow-rates-to-plant-loop (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (752 of 752 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.91%25-green.svg)


Why is it the parent and not the netdev itself?


You Socker!


I see now that I already changed it after the pull request to this:

```html
<!--/* Bad */-->
<section class="teaser">
    <h3 data-sly-use.teaser="com.example.TeaserComponent">${teaser.title}</h3>
</section>

<!--/* Good */-->
<section class="teaser" data-sly-use.teaser="com.example.TeaserComponent">
    <h3>${teaser.title}</h3>
</section>
```

That's practically the same as your example, so I'll leave it as is.


Same comment as for the general ledger.


@ryandotclair, if this resolves https://github.com/EMCECS/ECS-CommunityEdition/issues/7 , please create a pull request against upstream.  Thanks!


谢谢！


This commit fix issue #1


babel-eslint v. 3.x is based on eslint v. 0.24. Because `ESLint is monkeypatched` by babel-eslint (see https://github.com/babel/babel-eslint/tree/v3.1.30#how-does-it-work), it can cause incompatibilities btw. different eslint versions. So I decided to upgrade babel-eslint to v.4.x that uses eslint v1.2.


Ah, that's a left-over from trying to debug differences in `cargo test`, before I realized that they're expected. Will fix.


@lieuwex you might want to be careful just unescaping stuff as you go. It might not be meant to be unescaped, especially looking at StudyGuide.coffee:135 above.


Did you get any feedback about using unix time as integer or strings for timestamps?


OK, good to know. Thanks @akx!


Why was this reintroduced? As far as I know none of the DBMSs we support require the index name to be unique..


TeamCity pull requests :: netty [Build 109](https://garage.netty.io/teamcity/viewLog.html?buildId=724&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4663, ignored: 16 Build time: 00:09:57
### Failed tests
```
io.netty.handler.codec.http2.InboundHttp2ToHttpAdapterTest.clientRequestStreamDependencyInHttpMessageFlow: <no details avaliable>

```


1st commit! :+1:


Huh? Doesn't this just mean that anyone can create annotations in any group? Even a group that doesn't exist


For Unix systems only.
Require GTK+ v.2.0 or greater to compile properly.

See the file README for more informations.


This is fixed in the same commit that renames the interface.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 40](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=122&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 02:54:51


Maybe later we should add simple authentication to this API requests, so this API can be used only by WRIO services, not outside world.


留名，感谢！


Its there to just clean up long specifiers and here in our context which is a file class I think I isn't really confusing to have all static File methods directly accessible


Yeah, but this let's say mess is only internal really. All the commands then call just `Get<Module>` and that's it. Like https://github.com/salsaflow/salsaflow/blob/develop/commands/review/post/command.go#L691 . I will think about it, but I don't think that it's that horrible...


@cgcgbcbc If GitHub can not be trusted, you can't trust this key even if the commits are signed with this key.


@HarshitJn the word *PCL*....Actually, you need not write X(PLC) since you have already declared X to be a PLC above and if you notice you have already used X without referring it to as PLC.


I don't think this can be changed -- it's standard angular practice to pass 'scope' into the link function of a directive.


We need this for getting the version from old files because some migrations are triggered by this. See `FileLinksUpgradeWarning.java`


the version will look like "py-2.7.6". The commit message has small typo


@czxcjx, is the order important?


I think you could take the network namespace from the net_dev. That way you could add namespace support more easily in the future.


Missing backtick


When are you planning on merging this?

Regarding marshalling and unmarshalling, do you have any method for unmarshalling a many payload?


this may be useful for some client-only init stage, like initial animations


No -- this is used as a suffix to "answer". So, it leads to "answer is ..."


What about the oif? You set it in the rxe_find_route6 function.


Importing wagtail here means that the pip installed version is loaded ahead of any settings/local.py where PATH_TO_WAGTAIL might be set. As a result the source pointed to by PATH_TO_WAGTAIL is not loaded.


I understand that.But the previous version doesn't work.I have thought to generate a random id to avoid this,but I am trying to find a better solution.


@HarshitJn IMO, the title can be simply "Theory"


Removed at https://github.com/openmrs/openmrs-module-uicommons/commit/fd64498f46fb0572a199d750fd6685033ed9a091


There are 3 lines of commented code. Is this meant as TODO?


Also, what about source and dest port?


@HarshitJn We can refer to it as *Shewchuk's theorem*


@nlzet can you tell me some hint about how to create my own data type in a straightforward way? thx


best.sh should use tab width 8. So should relbench, mailer and makechr in the run drectory.


@HarshitJn It can be titled as **Hang Si's theorem**


И это плохо


D'abord, l'installation.
Pour installer Git, il suffit d'une commande toute simple :
Pour une installation sur windows, il faut telecharger manuellement le setup à l'adresse suivante : http://git-scm.com/download/win
Ensuite les commandes usuelles.
mkdir ~/MonProjet
Ceci permet la creation de notre repertoire de projet. mkdir est la commande générale de navigation provenant du temps avant les interfaces graphiques. Le ** ~/ ** vous assure que nous construisons le dépôt tout en haut de la structure du fichier de notre ordinateur, au lieu d’un répertoire coincé dans quelque autre répertoire qui serait plus difficile à retrouver.
git init
Initialise un nouveau dépôt Git. Jusqu’à ce que vous exécutiez cette commande dans un dépôt ou répertoire, c’est simplement un répertoire normal. Seulement après avoir entré cette commande, il accepte les commandes Git qui suivent.
git config
raccourci de “configurer,” ceci est tout particulièrement utile quand vous paramétrez Git pour la première fois. git help : Oublié
git status
Vérifie le statut de votre repository. Voir quels fichiers sont à l’intérieur, quels sont les changements ayant besoin d’être gardés en mémoire, et sur quelle branche du repository vous êtes en train de travailler.
git add
Ceci n’ajoute pas de nouveaux fichiers dans votre dépôt. Au lieu de cela, cela porte de nouveaux fichiers à l’attention de Git. Après que vous ayez ajouté des fichiers, ils sont inclus dans les “instantanés” du dépôt Git.
git commit
la commande la plus importante de Git. Après avoir fait toute sorte de modification, vous saisissez ça afin de prendre un “instantané” du dépôt. Généralement cela s’écrit sous la forme : *git commit -m “Message ici“ *. Le -m indique que la section suivante de la commande devrait être lue comme un message.
git branch
Vous travaillez avec plusieurs collaborateurs et voulez produire des modifications de votre côté ? Cette commande vous permet de construire une nouvelle branche, ou une timeline de commits, de modifications et d’ajouts de fichiers qui sont complètement les vôtres. Votre titre va après la commande. Si vous vouliez créer une nouvelle branche appelée “chats”, vous saisiriez : *git branch chats *.
git checkout
Permet littéralement de rapatrier un dépôt dans lequel vous n’êtes pas. C’est une commande de navigation qui vous laisse migrer vers le répertoire que vous voulez rapatrier. Vous pouvez utiliser cette commande sous la forme : git checkout master pour rapatrier la branche master, ou git checkout chats pour rapatrier une autre branche.
git merge
Quand vous avez terminé de travailler sur une branche, vous pouvez fusionner vos modifications vers la branche master, qui est visible pour tous les collaborateurs. git merge cats prendrait toutes les modifications que vous avez faites sur la branche “cats” et les ajoutera à la la branche master.
git push
Si vous travaillez sur votre ordinateur local, et voulez que vos commits soient visibles aussi sur Github, vous “pushez” les modifications vers Github avec cette commande.
git pull
Si vous travaillez sur votre ordinateur local, et su vous voulez la version la plus à jour de votre repository pour travailler dessus, vous “pullez” (tirez) les modifications provenant de Github avec cette commande.
Enfin, la conclusion.
Au final, on se rend compte que GIT nous aidera sur la façon dont nous gérons le code source dans nos projets et nos équipes, nous devons tous essayer cet outil de versionning magnifique, qui selon moi, devrait permettre à nos dépôts de rester cohérents, de pouvoir gérer indépendamment les avancées fonctionnelles, les patchs et releases sans finir la journée avec un mal de tête !


Ok, great.


Are these additional fields that could be parsed? CIDR can be put into `[source|destination].network`. The others can go to `additional_information.`


@HarshitJn We can say that the implementation is based on **Hang Si's** theorem.


# A couple of pointers

If I was to pull down this project I would not be able to run it. This is because without looking at the index.html I would be unable to what the dependencies are. This is easily solved by using npm's package.json and bower's bower.json. Don't worry this is easy to do :).

## Npm's package.json

Here is the link about npm's package.json [link](https://docs.npmjs.com/files/package.json).

Essentially you run ```npm init```. Which gives you a wizard for creating a package.json.

Then after you that run ```npm install <package> --save``` to save to your dependencies.

Then after you that run ```npm install <package> --save-dev``` to save to your development dependencies.

> This is run in the root of your website.

## Bower's bower.json

Here is a link about bower's bower.json [link](http://bower.io/docs/creating-packages/).

Essentially you run ```bower init```. Which gives you a wizard for creating a bower.json.

Then after you that run ```bower install <package> --save``` to save to your dependencies.

Then after you that run ```bower install <package> --save-dev``` to save to your development dependencies.

> This is run in the root of your website.

@pavoni


101615016CoilCoolingDXMultiSpeed-requires-Waste-Heat-Function (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1801 of 1801 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Here are results for 20 threads. Not encouraging.

Score of SF-master vs SF-lone_split: 187 - 138 - 875  [0.520] 1200
ELO difference: 14
Finished match

./cutechess-cli -engine name=SF-master cmd=./stockfish dir=/home/louis/Documents/Chess/Stockfish/src -engine name=SF-lone_split cmd=./stockfish
dir=/home/louis/Documents/Chess/Testing/Stockfish-08ff/src/ -each tc=/15+0.05 option.Hash=128 option.Threads=20 proto=uci -concurrency 1
 -resign movecount=6 score=600 -rounds 1200 -pgnout match.pgn -event Engine_Match -openings file=/home/louis/Documents/Chess/Books/2moves_v1.pgn


The previous instruction is safer.


Thx. And sorry, my english is bad (


From Harmonization docs:
> comment - Free text commentary about the abuse event *inserted by an analyst*.

> additional_information - All anecdotal information, which cannot be parsed into the data harmonization elements.

I think the data should go to the latter.


Ok then. I just haven't update `babel-eslint` in testcafe-phoenix and it worked just fine. So, I was curious why we need this.


version = nil


replace both with hash rocket? different patch?


Removed at https://github.com/openmrs/openmrs-module-adminui/commit/c9edc05177c696fcd6e1bf27fef51a75df94e635


I had a closer look a and I don't think that actually works. I'm trying something else now.


Using strings use string.xml file rather than hard coding. I have mentioned this in your last pull request also.


revert to server change


101615016CoilCoolingDXMultiSpeed-requires-Waste-Heat-Function (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Nice!

ons. 26. aug. 2015 kl. 10.14 skrev Lars Andersen <notifications@github.com>:

> @magnars <https://github.com/magnars> ed962d2
> <https://github.com/clojure-emacs/clj-refactor.el/commit/ed962d2ecbee170e24b51434a6724bd66ccb6f97>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/clojure-emacs/clj-refactor.el/commit/50028631b14e7a6b907cbdb88afd0f564917185c#commitcomment-12897181>
> .
>


也是陪伴我最长的科学上网工具，谢谢！


I moved the following into handle uri.
```
fail ArgumentError, 'Missing uri' if uri.nil?
```
seperate commit?


I had nothing to do with WN009 - Inspiron N5110, that profile is from Mohamed Khairy 1de13c800b53a30d4366082122953e6d093e90f8 . So not sure why I'm being blamed on here :8ball:


My mistake, I have added the test case in css3test. https://github.com/yisibl/css3test/commit/517b98e96ebbb2efa450e56f3878dbb74baafac2#diff-ce4097fa41097a3b63603226458faf55R1093


@Bernardstanislas We need to debate on the onPopinClose


Why you became "lead developer"?


Shouldn't it be called after the close animation.
Maybe not.


Maybe `mask-border-source` should increase


I moved validate_auth_options after storing entity vars and I use them there.
separate commit?


`this.refs.popin-overlay`


Ну QML я не знаю. Темы сделаны под пак оформления, потому не вижу в этом ничего плохого. Да и если кому нужно подстроить под свое оформление, то легко можно подправить и заменить цвета в inkscape или kate.


ro.sec_ril.version=50 is wrong ril version, it is for lollipop ril
and ro.telephony.ril.config=newDialCode is not needed


A more expressive comment would be nice – maybe even explain why it is strange to already expunge the app


It's shorter to write `session[:shrinked_links] ||= []`


It's `updateList`.


Don't forget to add "widget": "monetary" to the options. Also use the monetary widget each time there's an amount.


Rails has routes, that lets you not deal with low-level URL building


Tycker det va en överflödig ändring. :-1:


dropped redundant
@headers ||= {}
from bearer_token() and remove method since its only one line now.
separate commit?


This step only works if the project exists on Phabricator before we run the step which is defying its purpose. If `$phabricatorProject` does not exist we shouldn't fail. This step is there to create the project if it doesn't exist.


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


This breaks for ARCv2 port as header is not included there.
Anyway I don't think we need the header - just open code #ifdef in entry.S
We have a patch in linux-next which makes that Branch a Jump anyways - so better to just do it here !


You can now get rid of the appRepository dependency :)


Typo


this was dropped in this patch. i'll rewrite it to access @common and add other hashes in a separate commit


Hmm. What I wanted to do server-side was just set the permissions as they need to be, according to whether the annotation has a group and whether it's private. So if it's a group annotation it gets `annotation['permissions']['read'] = ['group:<hashid>']`, for example.

This could then be extended so that the client doesn't even send the permissions on annotation create or update, they're just set server-side. If the client does send permissions we could either ignore them, or raise a validation error. (We'd have to add a new boolean field `private` to annotations to allow clients to create private annotations.)

Then we could remove the permissions from the annotations before sending them out to clients, as well. (I think we'd add new boolean permissions fields to the annotations on the way out, telling the client whether the user can update the annotation, delete the annotation, etc. The client can use these booleans to decide whether to show the edit and delete buttons, won't need `permissions.coffee` anymore).

So the permissions sub-dict would become an internal implementation detail, which would be the first step towards letting us move away from access control lists and from persisting permissions on the annotations.

But even without all those follow-on steps, I think I prefer to set sane permissions (and generally to do data validation) server-side rather than requiring each client (incl. third-party clients) to do it correctly?

It looks like what you're doing here is relying on the client to send the right permissions object for, for example, a shared annotation in a group (writable by its creator, readably by the group), or a private annotation in a group, etc. And just checking server-side that the request is authorized to use each principal that it tries to set?

Just looks to me like something that belongs server-side.


Commit messages are there to differentiate between different commits and uniquely identify each commit. You have made the last few commits using the same commit message. Avoid that in future scenarios.


By default you are correct, but if you've computed h2 or SAS+ mutexes however this can remove unreachable actions theoretically `edels - dels` is exactly the set of fluents that are mutex with any of the action preconditions.


I'd also prefer to only read *.pot files on non-Windows systems. I guess this meets user expectations.


This looks good


Yes. Is this the only place that "hashid" is exposed to clients?


Thank you.


Making HTTP requests in an ActiveRecord callback is bad design, also, it is slow


You removed the check that annotations can't be moved between groups? Allowing moving them raises all kinds of questions and is out of scope for the feature at the moment


Brian, thanks for the changes.
The path to the wehi_pains.csv is: `../../../Data/Pains/wehi_pains.csv`, not `../../../Data/PAINS/wehi_pains.csv` (line 18)
-Axel


Same comment re. the monetary widget


With ranges (`'a'..'z'`) it would be shorter and more expressive


> New two-factor recovery codes successfully generated.

Thank you **fxkr** for pointing that out.


Thank you so much for the direct link examples. They greatly improve my productivity! :)
One question though, i had understood you when you suggested that i replace the controller with Angular + REST.
But now when you say that i replace the page controller with the fragment controller, what advantage or difference does it make? :)


What would make it clear? I've already said that one is with JS and one is without JS - both are valid use cases and need testing. You can see from the test steps that the one with JS has an extra link to click on. Do you mean explanation of why both JS-on and JS-off matter, or why there's an extra step with JS, or that JS means JavaScript?


x


s


What about multiple catch blocks instead?


@moolitayer same commit: don't specify a default value (it must be passed here in the common code)


Huh? This should be `__world__` not `__none__` but I think it's still needed. This is for pre-groups annotations or annotations created by an API client other than our own client-side code, that have no group field, it's here so that our client-side code can always go ahead and assume every annotation has a group.

Unless I missed something else?


See
http://ruby-doc.org/core-2.2.0/Array.html#method-i-sample and
http://ruby-doc.org/core-2.2.0/Array.html#method-i-join


yes, separate patch


whitespace


A minimalist static blog based on Node.js and Express | 基于Node.js和Express的极简静态博客


This is here because parts of the UI break on newly-created annotations, without it


이거 마지막의 NUL 바이트가 복사되지 않을것 같은데요. 이건 어떨까요?

```
memcpy(yylval.str_val, yytext+1, yyleng-2);
yylval.str_val[yyleng-2] = '\0';
```


// To play videos, use ContentType.RECORDED and the video id


This base URL should be a constant.


No need for separate patch.


This can be removed for now.


// To play live streams, use ContentType.LIVE and the channel id


I like shared instead of public here, +1


Why Text::CSV and not Text::CSV_XS?
Text::CSV is lagging behind on mimicking the _XS variant, which is leading


Ok, any comment here @oschreib?


+ minors


KUMPULAN POKER ONLINE TERABARU DAN TERPERCAYA

POKER TERBAIK DAN TERPERCAYA 2015

NAMA POKER
MINIMAL DEPOSI
PENDAFTARAN

DEWAPOKER
25.000
Daftar

RATUPOKER88
25.000
Daftar

POKERQQ13
25.000
Daftar

POKERPELANGI
20.000
Daftar

POKER323
50.000
Daftar

NUSANTARAPOKER
20.000
Daftar

JOKIQQ
20.000
Daftar

IM2POKER
25.000
Daftar

POKERGG
20.000
Daftar

DRAGONPOKER88
15.000
Daftar

SAHABATQQ
20.000
Daftar

SCORE88POKER
10.000
Daftar

POKERDEWA88
10.000
Daftar

7DEWA
10.000
Daftar

DADUPOKER
20.000
Daftar

POKERMIMPI
20.000
Daftar


Idk which commit is that


I'm confused now. Where in the previously existing code got a phabricator project created?


Посмотрите на этот скрин
![papirus-dark3](https://cloud.githubusercontent.com/assets/4980269/9490043/f54dbf32-4bed-11e5-897d-3294835fec66.png)
Здесь у разных окон разные цвета, а с вашей темой это сделать невозможно


保重


sudo apt-get -y install gpaw
run tests.....gpaw-tests


when committing code make sure you go through the code again.  Please avoid committing this kind of changes.


Also, you can test this here: http://pay.webninjrdesign.com/sessions/login


`save` returns `false` in case of error, you ignore it. See `http://api.rubyonrails.org/classes/ActiveRecord/Persistence.html#method-i-save-21`
Also, no need to specify `self`


Why are you using a secondary capture group ?
`<mailto:([^\|]+)\|[^>]+?>` would just capture the email alone


animation and also feature animation. Pierre added http://openlayers.org/en/master/examples/feature-animation.html a while ago. And Tobias just published a blog showing how to animate flight routes: http://www.camptocamp.com/actualite/animating-maps-openlayers-3/.


Should we be using the MySQL PASSWORD for hashing or processing this in the controller logic? I'm not sure what methods MySQL uses by default but I think I've read that it is recommended for MySQL passwords only.

I think the question then is how complicated does this have to be to fit the context. This may be a perfectly adequate solution for now.

Two other options I can think of:
* Using the crypto library to SHA-X the password with a globally configured application salt
* Using the crypto library to SHA-X the password with a randomly generated per user salt

This is a great pull requested, really needed changes. Let me know if I've misunderstood the process!


Aha, magic!


`while !` == `until`


Are you planning to release 0.2.1.1 that includes this fix?


2,239 additions and 325 deletions – please @libasys make commits smaller, and always do it through pull requests. Otherwise it’s impossible to follow and join development.


By convention, variables start with lower case.


it's bad practice to use forever loops


2,239 additions and 325 deletions – please @libasys make commits smaller, and always do it through pull requests. Otherwise it’s impossible to follow and join development.

cc @sahne123 @DeepDiver1975 @georgehrke @raghunayyar


`<(?!!)([^\|]+)\|[^>]+>` would do just as well, if you are not using the label in the return


It would be cool to have a more proper commit message than just »important JS fix« ;) – what was actually fixed?


This is not quite right, if you tried just one random id and it's already taken, that doesn't mean there's no other values available. I would try 3 or 5 times.


Everything that has a beginning has an end, including GFW.


You always start with 1, that's not optimal


Looks like it. Will fix


where did you free your shared memory??


Seems confusing that the method has the same name as the private member.


ok


*Like*


Hi, I think the fix is a little redundancy，here is a patch for your reference.

    diff --git a/src/backend/optimizer/util/pgxcship.c b/src/backend/optimizer/util/pgxcship.c
    index 1ee40ae..1a737ff 100644
    --- a/src/backend/optimizer/util/pgxcship.c
    +++ b/src/backend/optimizer/util/pgxcship.c
    @@ -1468,14 +1468,17 @@ pgxc_find_dist_equijoin_qual(List *dist_vars1, List *dist_vars2, Node *quals)
                    if (list_length(op->args) != 2)
                            continue;

    +               lvar = (Var *)linitial(op->args);
    +               while (IsA(lvar, RelabelType))
    +                       lvar = (Var *)((RelabelType *)lvar)->arg;
    +
    +               rvar = (Var *)lsecond(op->args);
    +               while (IsA(rvar, RelabelType))
    +                       rvar = (Var *)((RelabelType *)rvar)->arg;
    +
                    /*
                     * Check if both operands are Vars, if not check next expression */
    -               if (IsA(linitial(op->args), Var) && IsA(lsecond(op->args), Var))
    -               {
    -                       lvar = (Var *)linitial(op->args);
    -                       rvar = (Var *)lsecond(op->args);
    -               }
    -               else
    +               if (!IsA(lvar, Var) || !IsA(rvar, Var))
                            continue;

                    /*


Typo: confortable=comfortable.


Good job


That's a very old version of gen_rst you are using.
But it brings again to my attention that examples are
indeed executed within sphinx-gallery and not out of it.
That's the way we set some matplotlib options to the gallery

I see resetting the defaults of matplotlib after each example
can be implemented. Although I thought when we run an example
all global configurations get saved in the example_globals
dictionary.

I'll make an issue to support seaborn in sphinx-gallery.


Why do you need to handle JS-requests?


monetary widget


感谢作者


Would be nice with a link to what to use instead :)


Wouldn't it be better to be able to specify a plain URL to download the nunit package, regardless of the version?

My rationale is that:
- if you want to download a nunit package from an arbitrary URL, you specify it here and it is taken regardless of the version
- if you just care about the versions, you don't specify the URL but specify the version instead


101615016CoilCoolingDXMultiSpeed-requires-Waste-Heat-Function (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (753 of 753 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.98%25-green.svg)


#4942-VRF-with-water-cooled-condenser-does-not-pass-hard-flow-rates-to-plant-loop (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1277 of 1277 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


[Here is the relevant MySQL documentation](https://dev.mysql.com/doc/refman/5.7/en/password-hashing.html) - the hashing algorithm depends on the version of MySQL you are using.

[Here is a SO answer about trying to "decrypt" the native PASSWORD() command](http://stackoverflow.com/a/20834766)

The motivation here is to prevent people from swiping passwords if we accidentally dump the data to the web (e.g via github) or leak it via dropbox.

If we would like to build in hash + salting as you suggest, it seems like `bcrypt` is the library we want.  However, at this point, those are just more configurations we will have to remember to reset/generate on install; a process we haven't well defined.


Я же объяснил, что Breeze и Oxygen написаны на QML, потому они и берут системные цвета. Я не программист вообще, потому мои познания в этом 0. Если кто-то создаст QML, то я буду не против.


thx!


Sure. Let me check your mouse issue before.


I think it would be better to replace `way.hasTag("area", "yes")` with `isTagTrue("area")` since in other places 'yes', 'true', and '1' are also considered true.


Use `before(:each)` and you won't have to do the clean up manually


no such method `destroyed`


Breeze написан на C++


Вот откройте /usr/share/kwin/aurorae/ и посмотрите.


Heh. You're right, it doesn't. It should though but I guess that should not be tackled here.


Thx you for sharing!.


I don't get it. Internal code is still your code and shouldn't be messy. Or do you want me to stop reviewing internal code? Just say so...
Anyway, not raising an issue, up to you to refactor it when you feel like it.


I don't know much about bash scripting. So this should become "${symbol_file:0:"${#symbol_file}"" ?


This is just a copy of another test


Нет, он написан на C++, как плагин к Qt. Например у меня есть библиотека /usr/lib/qt/plugins/org.kde.kdecoration2/breezedecoration.so которая за него отвечает.


В этой-же директории плагин для поддержки aurorae: kwin5_aurorae.so


Hi, I have nothing to do with this.

Cheers


We've added a proper fix for this (getting initial app state from native side and passing it through as a constant), but that didn't make it into this release.


Description says "it re-renders the 'new' template", but the test checks for redirect


слишком много скобок. фу.


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


if not the today div was matched ".fc-today" the function .position() caused an error and no more events loaded!


И декорации для aurorae не поддерживают все функции которые доступны breeze. Поэтому, мне кажется, бессмысленно делать тему aurorae.


No, I am going to think about it, but c'mon man, don't get offended all the time :-)


null check because null.method null pointer exception


handle remaining cases


Thanks a lot, May all is best.


this was a "small" commit, but i had to add 2 new 3rdparty scripts and 1 new css file for time slider!


Причем здесь Breeze вообще? Пак рассчитан также и для KDE 4, которым многие пользуются.


Let's call this FIREFOX_SYNC :)

Data sync is bigger than that, and in the end we are only adding Firefox Sync for now.


Ditto


This looks good to me, but I was wondering if we could slightly modify and abstract this behavior so it can be used by any app. What we are doing here is basically preprocessing the app's files to add/remove code based on some specific tags. This is something that we can benefit from in other apps.

Instead of having this code here, maybe we can add this logic to the general build process and execute it before the app's build.js script, probably even before https://mxr.mozilla.org/gaia/source/build/post-app.js#22 I am really not familiar enough with the build process, but I am thinking that we can have a file in the app's build folder where we specify a similar configuration that you are adding on the `fileList` var. So lets say that we call that file preprocess.json. It may contain only the list of files to be preprocessed. In your case it would be:

     elements/root.html
     elements/fxsync.html
     index.html
     js/fxsync.js

And then the algorithm could be something like:

      During the post-app process, get the apps preprocess.json file if it exists
      Iterate the list of files to be preprocessed. For each file look for the IFDEF_* and IFNDEF_* comments.
          When one of these comments is found
          If the comment is an IFDEF_* and * is defined
              remove the comment and its corresponding ENDIF_*
          If the comment is an IFDEF_* and * is *not* defined
              do nothing
          ( you can imagine how it follows with IFNDEF)

What do you think?


-1 for plurals -- but that's my personal preference.

The rest of the REST API (guvnor, kie-remote-services) are all singular based..


If you follow my suggestion above:
s/DATASYNC_BLOCK_START/IFDEF_FIREFOX_SYNC/g


If a ship has minwaterdepth = 5 will it be able to move back into the water when on land? In 100.0 ships can end momentarily be quite high (up sea cliffs) before finding their way back to water. If they get 0 speed at that point then they would become stuck on the cliff.


comments for class


print


Да, наверное вы правы, для KDE4 это необходимо. Но для Arch не имеет смысла собирать пакет,  т.к. здесь только KDE5.


why is this needed?


Вы можете использовать Breeze, вам же никто не  запрещает :)
Меня лично всем устраивает тема aurorae и удалять я ее не собираюсь.


Why Some("H")? Can't we use a custom object and define a serializer? I am not sure about the serialization stability of "Some" between scala versions.


Consider replacing the `let` with a `before` block to do the import from csv here.

`let` is mainly for declaring variables that need to be accessed in the `it` blocks.

`before` is suited for performing actions (calling methods).


related but not introduced by your change: `stopApp` will spawn an `AppStopActor` which will fetch all tasks from the `TaskTracker` and tell the `SchedulerDriver` to kill them. When that succeeds, `MarathonSchedulerActor.stopApp()` will also fetch all tasks from the `TaskTracker` and kill them – the usage of `AppStopActor` is more or less redundant. Anyways, I just wanted to write this down.


Thanks


test


Are you calling those methods manually?


add it to constants


@amagdas I don't understand why you added `if url is None: ...`.
You forgot to return `url` if it is not `None`.
And If you don't use S3, app.media doesn't have `url_for_media`. Then it should work.


Did you need to introduce a partial here? Unless the partial is going to be used elsewhere I would've been inclined to put it straight into the outcome_os_affirmation.govspeak.erb template.


Is this a work-in-progress change? With it the background doesnt change "2nd time". Backgrounds change when I scroll once but then stays intact. With previous version backgrounds change whenever applicable block is in view. Tested with `Adapt 2.0.1`.


"ALERT_CONTROLLER_TITLE" = "你按了所触按钮 %@. 你想要做点什么？";
"CANCEL" = "取消";
"CHOOSE_IMAGES" = "选择图片";
"CHOOSE_PHOTO" = "从现有的图片中选择";
"CONFIGURATION" = "配置";
"CONTACT_THE_DEVELOPERS" = "与开发者联系";
"DELETE_PHOTO" = "删除所选图片";
"DISMISS" = "撤销";
"ENABLE" = "启用";
"FACES_PRO" = "拼图";
"NO_IMAGE_CURRENTLY_SAVED" = "当前并没有图像以供保存";
"MAKERS" = "开发团队";
"OPACITY" = "不透明度";
"REMOVE_BACKGROUND_TINT" = "去除图片的背景色";
"REMOVE_CONTACT" = "删除联系人";
"RESPRING" = "注销生效";
"RESPRING_MESSAGE" = "每当你启用/禁用该插件或者调整了图片的不透明程度后，需要注销来使之生效.将来更新后可能就不再需要了";
"SELECT_NEW_CONTACT" = "重新选择联系人";
"SELECT_IMAGES_FOR_BUTTONS" = "点按此按钮以选择图片";
"SET_BACKGROUND_TINT" = "为图片选择一种背景色";
"SUPPORT" = "支持";
"TAKE_OR_CHOOSE" = "你想现拍一张照片或者从相册中选择？";
"TAKE_NEW_PHOTO" = "拍摄新的照片";
"TAKE_PHOTO" = "拍照";


This test (lines 151-156) has a problem.

Temporarily break the `AddressBook#iterative_search` method so that it always returns `nil`.

Which line in this test do you think will fail first? Run this spec with the broken `iterative_search` and let me know what you find out.


I was trying to keep it consistent with the line above, `<%= render partial: 'appointment_for_affidavit_norway.govspeak.erb' %>` is a very similar partial. Should I move them both inline?


size check


That's a useful analysis on MySQL PASSWORD.

If that is the primary motivation I think this should work for now. I would recommend a very simple utility to hash + salt before open sourcing to the extent of not having control over the install - I'm sure that would make organisations feel safer about their data. Not an upcoming issue though.

bcrypt looks like a solid choice.


@libasys cool – next time please directly use a meaningful commit message. :) Thanks!


Nvm, works flawlessly now after cleaning the project solution.


Start with var result = new List<IPackageAssemblyReference>();

You don't want to return null from an IEnumerable here, it will crash callers trying to loop on it without checking it first.


requiring a digit here instead of a string breaks external ids, which are strings, I believe. @slobak how should i best file this?


Why this addition?


Java style: ```new double[] {0.9``` (use of spaces)


There is no need to retrieve just a group of images from an article - there won't be many of them, and the data received is tiny being just image references. It adds too much unnecessary complexity to the frontend too, when it can just do a simple filter on the response to get the just the group it wants.


line length


This is me setting the physics back to normal after seeing if I should make everything stronger.


return statement is not required here


result = files.Select(file => new PackageAssemblyReference(file)).ToList();

You shouldn't need to cast this to an IPackageAssemblyReference


Yeah - all this stuff is specific to rippled though, or am I misreading?


FYI you can open a PR into his branch with the github interface almost as
easily as you can into mne-tools/master


101884090-Venting-Availability-Schedule-does-not-work-properly-in-the-AFN-model (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1280 of 1280 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.98%25-green.svg)


example should document things more -- what is 1234? squid bug? etc
Also, if purge is an object, it should be Purge


Note on the status of fixing this in main repo. `shownSurveyCollections` set is reset since
https://github.com/mixpanel/mixpanel-iphone/pull/295

`shownNotifications` wasn't fixed on the main repo, but as to me it should. See my comment here: https://github.com/mixpanel/mixpanel-iphone/issues/232

Hopefully we will be able to switch to main repo soon.


Thanks for the tip!

Did this with my last breath after 12 hours of coding… I’ll take a look tomorrow morning if it’s not solved by then.

> On Aug 26, 2015, at 9:02 PM, Eric Larson <notifications@github.com> wrote:
>
> FYI you can open a PR into his branch with the github interface almost as
> easily as you can into mne-tools/master
> —
> Reply to this email directly or view it on GitHub <https://github.com/dengemann/mne-python/commit/8221d0b1e94a3875903c9ab18f22d2300c4ef5a4#commitcomment-12915865>.
>


i suggest you chain thenables rather than nesting them - makes everything much more readable.  Here, change it to:
p.open()
.then(function() { return p.purge(...);
}).then(function() { console.log(...);
}).catch(...{
}).finally(...);


I think it might be convenient to return "self" here - this way when the function that gets called after the open() is done can use it without a closure:
p.open().then(function(p) { return p.somethingElse(); });  But this is just my preference


This should make it easier to fix #64


Fixed the problems and uploaded the code to the new repo, thank you for your review and help


Aha! I see the paragraph numbers are starting from paragraphs in the TEI header, which doesn't make much sense for us. I'll try setting a `@from` attribute on <xsl:number> where I'm noting paragraph numbers. Stay tuned for another batch transformation. . .!


101163166-AirLoopHVACNodeNameNotUnique-4407 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1797 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1792 of 1796 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


Seems like we should link to thoughtbot/guides instead of listing these bullets?


Because I had some issues with transaction. I was unable to make it be committed and then when trying to query I always got the message 'Unexpected call outside of transaction'. You can see it at [json-schema-entity](https://github.com/andrglo/json-schema-entity/commit/ff183104aedb5169f106ad362bc587ada8492b2a). I use ES6 Promises


I like that idea, this was taken off the templates repo: https://github.com/thoughtbot/templates/blob/master/CONTRIBUTING.md.template


We considered the Rx Observable interface and more recently the standardization attempt of reactive streans. We've been very careful with our interfaces in GRPC to make it easy to adapt a request or response stream onto an RX pipeline. See our StreamObserver class which is interface compatible with Rx's Observer.

The issues with the Observable interface that you note are the reasons why we did not think it practical to use directly and why our bindings require the caller to pass Observer. Aside from the buffering issue there is also the issue that you can have multiple Observers on a single Observable and then you have to choose whether this triggers multiple remote calls or just one. If it's multiple then you have to remember the request which may itself be a stream. We felt that the common pattern of 1 Observer per call was all that we needed to support in GRPC  and that if an application wanted more they could bolt on the RX lib to convert an Observer into a buffering/non-buffering Observable.

Thanks for the heads up on the proto3 support. Are you working with anyone here at Google on this? If not I can try to find a contact for you who would answer spec questions etc...


I am a beginner with Java, but I know a lot about bees.  This mod is super cool and a good place for me to find practice Java exercises outside of the book that my son and I are reading.   In the real world, the queen controls her subjects mostly with pheromones, because it is super noisy and very dark inside the hive.


I think this one's the right topic:
https://docs.python.org/3.4/library/gettext.html#deferred-translations
I read a bit...


Not sure if the spacing is correct, is the green bar a character added?


LGTM!!! :+1:


Weird that `gettext` modules doesn't provide some function like `mark_for_translation` whatsoever...
I think the proposal of using a dummy with name `N_` (which is as convenient as `_` and the **N** means something like "**n**o-translate" imo) is a good approach^^


Hi.  I'm one of the early adopters of the Keplur.  Kevin contacted me and told me that I have to use a FTDI cable to flash the Keplur and  have access to the new firmware.  How can I do that, could you upload documentation or send me instructions.  I really need to start using the Keplur with all its capabilities


I would strongly prefer to retain copyright and use a free-software license. However, to pursue the public domain option I would recommend using CC0 from Creative Commons.


Doesn't look correct :(  Did you use spaces or? Green blob looks like a tab to me..


![cadastro de aluno](https://cloud.githubusercontent.com/assets/13985817/9509658/abb4f7dc-4c38-11e5-983d-e2b48b6391b5.png)
![cadastro de disciplina](https://cloud.githubusercontent.com/assets/13985817/9509649/ab666b3a-4c38-11e5-9d8f-8b264fe5d0c1.png)
![cadastro de turma](https://cloud.githubusercontent.com/assets/13985817/9509650/ab67d682-4c38-11e5-9ee2-294b9561a0b6.png)
![consulta alunos por avaliacao](https://cloud.githubusercontent.com/assets/13985817/9509656/aba475d8-4c38-11e5-8dca-0dfcfd27370f.png)
![consulta por turma](https://cloud.githubusercontent.com/assets/13985817/9509652/ab6da2c4-4c38-11e5-8ec8-1d84255e1bf5.png)
![consulta todos os alunos e turma](https://cloud.githubusercontent.com/assets/13985817/9509651/ab6d20e2-4c38-11e5-8c2d-8827cc8d4782.png)
![disciplina](https://cloud.githubusercontent.com/assets/13985817/9509653/ab8730a4-4c38-11e5-8e81-dc32171ad814.png)
![editar aluno x](https://cloud.githubusercontent.com/assets/13985817/9509654/ab8a5748-4c38-11e5-9ebd-bfd492f05605.png)
![editar avaliacao x](https://cloud.githubusercontent.com/assets/13985817/9509655/ab8efcbc-4c38-11e5-9e18-709064470504.png)

![tela inicial](https://cloud.githubusercontent.com/assets/13985817/9509657/aba73ebc-4c38-11e5-95dd-62c514a4b6af.png)


So in fact you would then just do:
```
if hours == 1:
    return N_("An hour ago")
else:
    return N_("{hours} hours ago")
```


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Okay I see maybe overriding `_` is better then you don't need to change the message extraction program...


hey this isn't needed, u should just be calling .private? on any instance of wiki and it will return true or false, so get ride of this method.


Missing new line at the end of file


If "we" retain copyright, we have to figure out who "we" are.  Do you think the CONTRIBUTORS list is sufficient?


should probably be a dev dependency?


Hi Guoxiao-
ARCH_SUFFIX is also used in the java makefiles.
But perhaps it's better to change ARCH_SUFFIX to an empty string in Makefile.base for Darwin.
Thanks!


101884340-Crash-with-missing-AirflowNetworkMultiZoneZone-object-#5029 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1804 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sorry about that! Changed to the recommended/standard Matlab form, which you suggested as well. Hope it's not too much of a pain.


101884340-Crash-with-missing-AirflowNetworkMultiZoneZone-object-#5029 (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I get updates of Qt 5.5. I have try that code, but it still doesn't work with it.


develop (axelstudios) - Win64-Windows-7-VisualStudio-12: OK (2310 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.59%25-yellow.svg)


After this commit when I run 'jekyll serve' I don't get any styles :\


heh! :grinning:


why do you do the iteration twice here? Could just `find` and check for `nil`.


If all this function does is print to the console, why not just call `console.log` directly? :)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 427](https://teamcity.labkey.org/viewLog.html?buildId=268678&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:09:02
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


I was initially using that for test purposes and I forgot to delete it...my bad


Our project uses jQuery, so you can replace all `XMLHttpRequest`s with `jQuery.ajax` or `jQuery.get` or `jQuery.post`, it's a bit more readable and provides facilities to handle success/failure more easily (you can check out the jQuery docs)


After this commit I'm not getting the images c4l-log-pink.svg or cc.png


Merged this branch with main (overwriting it).  Continue on the main branch.


This comment doesn't have a space after the two forward slashes.

It should be:

```Go
// -----------------------------------------------------------------------------
```

All others look great.


This compiles OK; is it alright for the pointer assignment to happen before the switch?


Magic numbers aren't fun. Define this as a variable (something like `var MAX_REPO_SIZE = 10000;`) somewhere earlier in the file, at the highest level that it makes sense (so still within the confines of this functionality)

Also, what does the size represents? Kilobytes? Lines of code? If it's bytes, it should probably be 10,240 (because 1,024 kb = 1 mb) - make sure that's it's kb and not bytes! (because 10,240 bytes = 10 kb, which is very small)


Again, jQuery does all of this for you :)


好难过，突然不能翻墙了，感谢你们一直以来的贡献，一路走好！


@Jojo-Schmitz I'm trying to export mp3 and wav audio in my git build on my Arch Linux4.1.6 x86-64 machine, but I notice that the file is deleted at the moment the progress bar finishes.  I'm wondering if there could be a mistake in this code...maybe could you check on your machine?  I'm wondering if this file remove line for both exportaudio and exportmp3 should go before the progress.close() line.


Keeping backwards compatibility with TLS 1.2 clients by allowing the defaults seems perfectly valid to do, so long as it's only applied to TLS 1.2 and not 1.3+. Seeing as SHA1 is deprecated, dropping could make sense, though. The thing is, I expect server implementations to do this and stating it here seems better than having them violate a spec saying otherwise.


What does this ID mean? Also if it's a constant use CONSTANT_CASE (so `MAX_ID` here)


[This](https://www.opengl.org/wiki/Data_Type_(GLSL)) article in the OpenGL wiki says `Note: This document will mention double-precision types. These are only available on OpenGL 4.0 or ARB_gpu_shader_fp64.`


You could simply check wreckDef.resurrectable


Plugin did not have any code implemented to handle unloading and therefore would not unload the debug log object, causing HDT to crash if the plugin was subsequently reloaded.


Added a subroutine to stop recognition and close the debug logfile when the plugin is unloaded


FourPipeBeamAirTerminal (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1808 of 1808 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


My email : ljzyal@gmail.com
Tell me your email address and I will send the detail about dual sim audio problem.


If you were to show me the code that produced the error, I would have explained why that happens right away, because this is a very typical error that happens when you are making a call inside a transaction into object-context that sits outside of the transaction.


Thanks Lukas..


I am getting the same error again, even after running 'rake db:reset db:seed' and restarting my server.
Maybe the error is in db/seeds.rb, but I'm not sure.

NoMethodError in Posts#index
Showing /Users/laurenpease/bloc/bloccit/app/views/posts/index.html.erb where line #13 raised:

undefined method `name' for nil:NilClass


101789044_gridviewFilters (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2283 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.44%25-yellow.svg)


We discussed this on list a while back. I proposed SNI & ALPN as MTI; ALPN was rejected and SNI was agreed as MTI, but of not mandatory to send. There was no opposition that I remember on it as MTI, so long as it is of course restricted to areas where it is applicable.
https://www.ietf.org/mail-archive/web/tls/current/msg15513.html
https://www.ietf.org/mail-archive/web/tls/current/msg15515.html

SNI is also already considered mandatory in the TLS BCP:
https://tools.ietf.org/html/rfc7525#section-3.6

Requiring sigature_algorithms is issue #116.


Oh, I've been neglecting the effort of moving to Python3 with excuse that my essential libraries do not support (Django and skrf).  Well, I lost all my excuses by now ;-)
Personally I'd love to move to Python3 as I'm living in a multi-byte language country.

Saying that, I believe supporting Python2 is important for backward compatibility.
It looks Django uses a customized version of six.
https://docs.djangoproject.com/en/1.8/topics/python3/


Below is an example of a style override using the above code.  If I add the (untracked) file `/app/assets/stylesheets/branding/mybranding.css` with content `$search_input_bg_color: #ff0000;`, the main screen looks like the below:

![example_supermarket_overridden_style](https://cloud.githubusercontent.com/assets/1637133/9510003/26665bce-4c34-11e5-8f25-75bb3a7af6f8.png)


Don't log this every time


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 428](https://teamcity.labkey.org/viewLog.html?buildId=268684&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:43
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


TeamCity pull requests :: netty [Build 122](https://garage.netty.io/teamcity/viewLog.html?buildId=764&buildTypeId=pulls_netty&guest=1) is now running


Probably don't need publishChan because you aren't send incremental messages


data-mapper 함수를 호출하면 자동으로 context가 유지 되는 것으로 알고 있는데 context를 굳이 넘길 필요는 없지 않나요?


101884340-Crash-with-missing-AirflowNetworkMultiZoneZone-object-#5029 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (754 of 754 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-8.88%25-green.svg)


#This is the readme for hello world


It fits under the category of MTI extensions and is required by the TLS BCP. Not mentioning it leaves a hole in the security considerations of allowing backwards compatibility.


TeamCity pull requests :: netty [Build 123](https://garage.netty.io/teamcity/viewLog.html?buildId=765&buildTypeId=pulls_netty&guest=1) is now running


Octree (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/c9625b09b0e0b0ff89ef452dc103914f95f125fb/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/c9625b09b0e0b0ff89ef452dc103914f95f125fb/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/c9625b09b0e0b0ff89ef452dc103914f95f125fb/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/c9625b09b0e0b0ff89ef452dc103914f95f125fb/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/c9625b09b0e0b0ff89ef452dc103914f95f125fb/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


101789044_gridviewFilters (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2305 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.38%25-yellow.svg)


101789044_gridviewFilters (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


no place to trigger this function ?


Only for Final releases.  Not for branches.
On Aug 26, 2015 7:39 PM, "Marc Savy" <notifications@github.com> wrote:

> Do you reckon we should use cdn.rawgit for this? Just in case there's more
> traffic than we might anticipate.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apiman/apiman/commit/fc08d67dd696df1a9fdfd91b3daef3d70688ab11#commitcomment-12915571>
> .
>


Need to support Uploader


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/0adacc0b5e26c28c21688b6f1d78f0aa36d20225/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/0adacc0b5e26c28c21688b6f1d78f0aa36d20225/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/0adacc0b5e26c28c21688b6f1d78f0aa36d20225/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/0adacc0b5e26c28c21688b6f1d78f0aa36d20225/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/0adacc0b5e26c28c21688b6f1d78f0aa36d20225/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


q isssso bbaa


ConfigLookup should be need nil.  Make sure the project.NewProject(&context.Context) line doesn't set it to a default value.  We don't want FileConfigLookup because we don't want yaml files to be able to read files from server


ㅋㅋㅋㅋ


aaaahh delicia


TeamCity pull requests :: netty [Build 122](https://garage.netty.io/teamcity/viewLog.html?buildId=764&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4774, ignored: 16; resource leak detected (new) Build time: 00:10:11
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testQueryMx: <no details avaliable>

```


I'll also add tests for checking that "extends" doesn't work across multiple compose files.


Why not use Flags/Flag from twitter-commons for the environment properties?


101884340-Crash-with-missing-AirflowNetworkMultiZoneZone-object-#5029 (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (1804 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


meant to link this to #35, wonder if this comment will make the link.


You can't define a global in a header file like this. What will happen is that the global will be duplicated in every `.c` file that includes it, and each one will have a different value.

What you need to do is, in one `.c` file, write:

`bool is_py35;`

And then, in one `.h` file, write:

`extern bool is_py35;`


changed gedit settings but didnt work, used vi instead and still see green blobs, so will delete the whole bit before the text


I wouldn't list here, just use the environment id you already have.


this can be private class


NIT: `This`, and lack period.


I was Hoping to get some usable info from you about what changes might need to be made to add support for the SamsungGalaxyCorePrime SM-G360T and SM-G360T(1)?

![](http://cdn3.xda-developers.com/images/smilies/confused.gif) ![](http://cdn3.xda-developers.com/images/smilies/eek.gif)


This should be a `<head>` tag and the `<h1>` should be a `<title>`. Remember: the `<head>` is a tag that's used for non-visible elements of the page and the `<title>` tag controls what you see as the title in a tab in Chrome/Firefox, etc.

`<header>` is a valid HTML element, but we haven't learned about it yet.

Your best bet to catch mistakes like this is to run it all through an HTML validator like: https://validator.w3.org/


as we discussed these addEntry methods, should throw UnsupportedOperationException


Stylesheets should go at the top, in the `<head>` - great work using an external reference, though!


This is the most beautiful commit yet. Small change to one file, all easily understood because the service is so well contained. :heart:


Potatoes have so little food and so it would be better for 2 instead of 4 it had 1 then i made it four and now I thing it should be 2


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/2d2251c1daba2087ab433f714f1256a3cc943215/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/2d2251c1daba2087ab433f714f1256a3cc943215/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/2d2251c1daba2087ab433f714f1256a3cc943215/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/2d2251c1daba2087ab433f714f1256a3cc943215/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/2d2251c1daba2087ab433f714f1256a3cc943215/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Modifica el color del Placeholder


Oh, okay. Good thinking then.


@LouisZulli: thanks. So patch is strong with 7 threads, non functional with 3 or fewer, seems good with 20 threads too (even accounting for large error bar of a 600 games match).

What does that tell you about time to depth measures ? (hence about Crafty's alleged superiority in SMP)


the `<body>` tag should surround allll of the elements that you want to be visible on a page and there should only be one of them per page. There should also only be one `<html>` element per page.


The license could be `:oss`.


windowsAnimation must be private,

mWindowsTvOne, mWindowsTvTwo, mWindowsTvThree, please change name. ex: mTvUserName or mTvPassWord...


should be .msi


The download URL is unversioned so this should be used instead:
```ruby
version :latest
sha256 :no_check
```


sorry, but cannot identify tabs anymore in either editor, should I create the file from scratch?


ty!


nothing special application for this api, it just refresh visited url and when you reload the same url, the isReload will be set True. That is all.


Why not just Yeast? Then in recipe you could have something like:

`def yeast; @yeast ||= Yeast.random; end`


Maybe you wanted to put this `private` method under all `public` methods?


Photovoltaics (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.25%25-red.svg)


Thank you, Sang!


Yes, but not recommended, as also noted. I'm not used to ask questions to the developer, but next time I will. Thanks for your concern. For now my needs are fulfilled by pg but I'll be following pg-promise.


The `app 'Lantern.app'` should be after the `license` instead. The newline also needs to be added before:
```ruby
license :unknown

app 'Lantern.app'
```


Thanks - I was wondering why it failed at times!


TeamCity pull requests :: netty [Build 123](https://garage.netty.io/teamcity/viewLog.html?buildId=765&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4774, ignored: 16; resource leak detected Build time: 00:21:05
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testQueryMx: <no details avaliable>

```


Could be better to specify the iteration order, does it depend on specific eviction strategy, e.x. does `LRUEvictor#getIterator()` iterate over all caches in `LRU` order?


Could you make a Pull Request with only the changes that is the actual fix? Thanks in advance.


update


Missing `self.decrease_lives;`


I guess my point is, don't mess with Recipe, be a good yeast and just understand how to make a good random name.

This is a violation of the "law" of Demeter; which is that you shouldn't mess with other classes' state. Or more colorfully: "You can pick your friends, and you can pick your nose; but you can't pick your friend's nose." You can change your state, you can associate with others, but you shouldn't change their state (instance vars). Maybe if you had permission, or maybe if your friend was particularly into that kind of thing. :)


pkg_name different with line 404


@RemkoDuursma What's your recommendation for getting latex running on windows?


ok


Ps. LoD is also interview gold. It's also a principle which will get you in massive trouble if you take it too far. So again, strive, but fall short and you'll be in line with most programmers.


Is there an integration test where we try to delete the same post twice?


Have quick code walk-through:
- This is git repository, why do you name this file with suffix `.c` or `cpp`
- Please use 4 spaces to replace tab for indention
- the open brace `{` shall be aligned, for example:
```c++
while (1) {
    //loop
}
```
or
```c++
while (1)
{
    //loop
}
```


looks pretty good, just would prefer short names for types
`bool`, `str`, `int`, `list`, etc


lgtm


saw approval from shino
at https://github.com/GabrielNicolasAvellaneda/riak_cs/commit/efd23d5bb012b4dc7a2d8a0b5f3bd9f4c0770671


merging GabrielNicolasAvellaneda/riak_cs/typos = efd23d5b into borshop-integration-1226-typos


GabrielNicolasAvellaneda/riak_cs/typos = efd23d5b merged ok, testing candidate = 71598b9f


but production doesn't have permission to have skype and cord/remote desktop to their computer..
@pongstr

admin department has
production app + skype and rdc/cord


Octree (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1276 of 1276 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


great (y)


Photovoltaics (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


ES6 Promise not recommended only because it is feature-poor, and way slower than the alternatives. Other than that, it works just fine within pg-promise.

Good luck with your project!


maybe only translate the `m` in `15m`?  might want to add other/extra points


Thank you！历史会记住你的！祭奠曾经用过的goagent


Should this be `=`?


`queue.song_set.count()` is probably more efficient


Here is unneeded newline here.


Looks good


why doesn't `translate(prop.eventName).toUpperCase()` not work?


@lucasart: You're welcome. On 20 cores, this patch *reduced* time-to-depth (see opening post above) and gained Elo. This tells me that time-to-depth measures *might* serve as reasonable proxies for actual chess-playing performance.


Generally best to separate the property and value with a space. e.g.

```
   background-color: black;
```


@Ngrd sorry i thought someone said to add a new line at the beginning. fixing that now.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_cs/builds/1513


Nice commit, myself.


`thanks`


I think you can just delete all spaces and tabs in each line and substitute it with spaces. This way they will all be aligned the same


@leamerluck This may be a dumb question, but where is this `piece_params` function used?


:+1: This is much better.  Not sure I'm 100% sold on `Map` as the verbiage here though.  I wonder if `Type` would be better?


still need to check for deviant url without download link


자동으로는 못 해줍니다.
160번째 줄의 updateSequence는 인자를 하나만 넘기기 때문에 함수를 리턴하게 되어 있고요. 만약 db.transaction 안에서 호출하면 자동으로 context가 바인딩된 함수를 리턴해 주게끔 하기 때문에 따로 신경쓸 필요가 없지만
162번째 줄의 getSequence 같은 경우는 인자를 2개 이상 넘기기 때문에 함수를 리턴하지 않고 즉시 실행합니다. 그래서 db.transaction 내에서 유지되는 context 객체를 3번째 인자로 반드시 넣어주어야 합니다.


Octree (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1276 of 1276 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nope.  The PostWaitDeleteBuffer object automatically deletes it after wait() has been called on intermediate_req, and thanks to add_prior_request() that automatically happens when wait() is called on req.


Great work on your first assignment! A few minor things, but definitely looks like you're getting the hang of it!


This pull request introduced a double build bug.
See this issue: https://github.com/erikras/react-redux-universal-hot-example/issues/142#issuecomment-135045656


Similarly, should it just be `Warmer`?


Best to include links back to other pages.


Dammit, Bill. Let me do something! ;)


Missing `<head>`


This is great :+1:


Why is that?


@hackmastera maybe you are having the same problem I noticed?  See #23


Возможно, нам придётся вернуться в id'шкам в input+label для стилизации через css...


fast-forwarding develop to borshop-integration-1226-typos = 71598b9f


Does this fix a Kvirc crash on Theme uninstalation via theme manager?


Thanks, if you can amend your commit to also include the same mistake on line 318 that would save an unnecessary commit.


Forgot to put this in the description, but getting the type cleaned up would be my priority, and then beyond that, whatever you want. There is a good chance that I'll mess with the decorative design elements to a greater or lesser extent over time, so you are forewarned that those may change. Note that there are something like eight different shades of that neutral, to give the subtleties of depth, and the drop shadow might not be represented accurately in the SVG.


Why `public`?


@vcunat These perm flags seem to not work on OS X:

```
stripping (with flags -S) in /nix/store/kwr60d7n96zcdir5niqqic21jk3s61an-gnused-4.2.2/bin
patching script interpreter paths in /nix/store/kwr60d7n96zcdir5niqqic21jk3s61an-gnused-4.2.2
find: -perm: /0100: illegal mode string
builder for ‘/nix/store/bc3j08gc4i5v910cb4mrh2n1n7vasyhs-gnused-4.2.2.drv’ failed with exit code 1
```


Looks good to me!  Just a few nit picks, which I don't feel strongly about.  Initially, I wasn't sold on `HasADictionary` and `IsADictionary` naming, but their purpose becomes immediately evident...so :+1: from me.


TeamCity ReOpenLDAP :: devel-2.5 [Build 103](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=129&buildTypeId=ReOpenLDAP_Devel25&guest=1) is now running


前略，天国的GoAgent，感谢这么多年以来的帮助和陪伴，是你让我认识了世界真正的精彩，好人一生平安！


Redundant empty line.


FourPipeBeamAirTerminal (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1808 of 1808 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I see the comment looks reasonable.   I'd like to wait for scarbrofair's comment on it.   Will reopen the issue with a link to here.


I'm trying to follow http://json.org/ but "`boolean`" instead of "`true` or `false`" and with more specificity for numbers


101884340-Crash-with-missing-AirflowNetworkMultiZoneZone-object-#5029 (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1280 of 1280 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.98%25-green.svg)


The patch looks reasonable.   Would like to have Scarbrofair's comment on it.   Will reopen the issue #77 with a link to here.


今天core这了，回来看看代码，看不明白啊
为什么新的chunkserver就置成finish？
为了避免集群启动过程中的大量块复制？


rename to "Enable Zetes job"


Boooo!! What's buggy about that link.. I use it every day.


`/home/travis/build/HiSPARC/sapphire/sapphire/analysis/coincidences.py:docstring of sapphire.analysis.coincidences.CoincidencesESD.search_coincidences:9: WARNING: py:attr reference target not found: _src_c_index`


What was wrong with `toString()`?


Type and subtype are not valid per spec.


So this a static public get/set ... Is it supposed to be that way? Perhaps should this be a Single value resolver so it can only be set once on startup ?


When running in a sub folder it was showing links to folders above it (thinking they were test packages).

See if you can fix maybe?


I think I would rather have a pattern that covers most regexs than a pattern that covers none. Could you possibly make a patch for that as a stop-gap? Thanks!


Remove it if it's not needed.


<<<<<<< HEAD
Needs a cleanup


Remove if not needed.


While trying to fix this, I noticed that the entire handling of declaration specifiers is severely broken. Fixing this is apparently not easy - I seem to have opened a can of worms. It looks like Tokenizer::simplifyStdType() needs to be rewritten from scratch and Tokenizer::simplifyStaticConst() requires fixes (and more testing) and should be moved to simplifyTokenList1.


We explicitly do not want these files in our main code because it is 3rd party code which we do not maintain and having it separate makes potential future updates a lot easier. I'm no expert in our depends system or linux packaging and I've written this Makefile (and the configure stuff) with a lot of help from @wsnipex (actually he wrote most of it and I committed it).

It would be a lot easier if you would state what your exact problem is than simply calling people crazy.


Wanted to keep it simple and avoid a resolver, which would imply an interface, etc. And it's OK it's a public setter/getter as we want ppl to be able to set it. But you're right, it should be locked once the app has started (ie once resolution is frozen). Point taken. If that's OK?


Hmm.. I've not run wheels in a subfolder since that link was introduced.. I'll see what I can do.


@hoholee12 Okay, your fix is better. Reverting my fix...


Awesome. SGTM.


ok. will add comments


visibility of DeclarationDescriptorImpl.toString


npnp :rotating_light:  :key:  :point_up_2:  :o:


remove


Hmm, this works fine in my tests. Why doesn't it work for you ?


Inconsistent indentation again, run all files in this PR through clang-format (use git filter-branch if necessary).


Please write `while !cmddone` instead


indents


This removes a line break, does Windows provide it ?


The template is called in the keypad-slide.html file


Belfast Bikes has been moved to line #724


empty comment not needed


Well i'm not sure an interface is needed, can't we just make a single value resolver that accepts a `Func<HttpRequestBase, string>` ?


etc etc


Seems like Nextbikes has removed this network in the meantime


mm nah that'll change soon XD My bday is in 2 months


check flags according to spec, i think it's an `big_uint16_t` entity now.


Should one evaluate to abandon that kind of simplifications in favour of utility functions?


Sure, silly me. Though... feels weird and not really DI. Anyways. Do we really need it/want it? Your call.


Autodesk_Performance (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (755 of 755 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-8.89%25-green.svg)


Hey guys, we already use N_ in coala btw. Would be good to follow that
convention IMO.

2015-08-27 2:24 GMT+02:00 Makman2 <notifications@github.com>:

> Okay I see maybe overriding _ is better then you don't need to change the
> message extraction program...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala-gui/commit/e91eab20fc7e5265d552ed78fbf25bc1c14d8039#commitcomment-12916084>
> .
>


The only way I can see of avoiding the public OpenColorIO include is to use `void *` instead of `ConstTransformRcPtr &` in the `transform()` signature. We can't forward declare `ConstTransformRcPtr` because it's in a versioned namespace, and we can't figure out the version without including an OpenColorIO header. Unless we hit problems, let's consider including the header to be the lesser evil for now.

If we're including the header, can we not just return ConstTransformRcPtr instead of use the reference and the separate bool? I would expect `ConstTransformRcPtr()` to give you a null pointer. It looks like they're using `std::tr1::shared_ptr` rather than `boost::shared_ptr` - I think TR1 is sortof a preview of C++11.


-fix #14


edwedewdwed


is -> in?


if u(" :") in s:


You don't need to specify an error callback if you are not going to be doing anything in it.


what is the requirement for this timeout ?


I'm sure you'll eventually run into existing software which compiles C++ with gcc ;-)


commiting once again to hit build


Yeah we can clean this up a bit I think; I borrowed it from Twisted I think :)


i can't see propose repository tab


Best wishes.


dewdew
d
wed
ew
d
ew
dwed


Why? This is the least required version for phpunit.


The need to repeat the very same change done to `__str__()` in `base.TranslationStore` actually reflects the issue that `oofile` is not extending `base.TranslationStore`. It might be worth to investigate if making `oofile` to extend `base.TranslationStore` actually works.


Yes, I do know. AFAIK the travis containers run only these jobs, so it there are no other processes affected.


Why remove this? It makes it possible to download the latest version by specifying it by `1.0.*@dev` instead of using `dev-master` which is bad practice.


TKS


Valid point, too quick implemented. We will consolidate the delete reasons soon.


@threedaymonk Before it was overwriting the 'protect_from_forgery with: :exception' from 'ApplicationController' with only 'protect_from_forgery'. And due to this when you were changing the token on '/feedback' page you were getting 302 not 422 error.


Sorry, what I meant to say is you could calculate corepos = cpuid + (cluster_id * 4) which is what you have done for platform_my_core_pos().


Though, I guess such attempts will break for missing librumprun_unwind instead of breaking in subtle ways due to a different C++ standard being used during compilation and preprocessing.


From the logic of this function, it seems pwr_lvl will always be equal to PLAT_MAX_PWR_LVL. You would need to do something similar to what is done in get_sys_suspend_power_state(). This loop has to be :
```
for (int i = MPIDR_AFFLVL0; i < PLAT_MAX_PWR_LVL; i++)
	req_state->pwr_domain_state[i] = PLAT_MAX_OFF_STATE;

req_state->pwr_domain_state[PLAT_MAX_PWR_LVL] =
		PLAT_SYS_SUSPEND_STATE_ID;
```


As far as I can see, this is the sequence that can happen when 2 CPUs in the cluster are suspended.

When CPU1 is suspended through CPU_SUSPEND, the target_state[] would be {PLAT_MAX_OFF_STATE, RUN, RUN}.
When CPU0 is suspended through CPU_SUSPEND, the target_state[] would be {PLAT_MAX_OFF_STATE, PLAT_MAX_OFF_STATE, PLAT_SYS_SUSPEND_STATE_ID}.

If I see the previous implementation, this new implementation does not have the same behaviour. The `write_actlr_el1()` will write 2 different values for the 2 CPUs for CPU_SUSPEND. But in your case, probably this handler is invoked only by SYSTEM_SUSPEND API and hence you dont run into issues. But still it would make sense to check the target_state[] for each level and take appropriate actions. Please check fvp_pwr_domain_suspend() and css_power_down_common() implementation for reference. Also it would be helpful if some comments are written about the assumptions made about this handler and its invocation.


@Martinusbe thank u didn't notice that man :D


This looks pretty good! A lot cleaner then before, that's for sure :)


I would remove the variable $scope as it not used. I do not use $scope in a controller unless I have to. See https://github.com/johnpapa/angular-styleguide#controlleras-controller-syntax


感谢作者，我是看到代码被清才来探望的，哎，又一个壮举！


Similarly, here you would need to modify this loop as:
```
for (int i = MPIDR_AFFLVL0; i < pwr_lvl; i++)
    req_state->pwr_domain_state[i] = PLAT_MAX_OFF_STATE;

req_state->pwr_domain_state[pwr_lvl] = state_id & 0xFF;;
```


Consider alternative planets


Is it actually necessary to introduce this check? If it is Python 2 `serialize()` is called. If it is Python 3 `__bytes__()` is called instead (which also calls `serialize()`), isn't it?


I'd guess `toLocaleLowerCase()` should be used instead of `toLowerCase()` as we will
eventually support languages like Turkish where these methods may have different
behavior. For example, in Turkish "I" is converted to "ı" where as in English the same
uppercase letter "I" is converted to "i".


Please add appropriate assert() checks for other levels to ensure that the target_state[] is as expected.


Please add appropriate assert() checks for other levels to ensure that the target_state[] is as expected. Also for the below conditions.


I confirm: We still need to install gulp-crisper specifically. It seems we can't use the gulp-crisper that's a dependency of polybuild in the main gulpfile...


True, just thought of consistency is all.... but yeah, let's just leave it the way you have it, don't need to complicate this one.


@nfeske: platform contribution


would it be possible to use in both cases the same ```@Path("set")``` and just use  the ```@Consumes``` do the dispatch ?


@nfeske: kernel contribution


And I confirm this recipe still works with master :)


@richarddwalsh @brandonskane @erad888 @latsonml @RitvikM @tdunham02 @stefanocdn check this out! :+1:


If you have onkeyup event on an input element, I would do a proactive error checking by restricting the ability to type alphabetical characters totally.


just so that the message does not get removed too fast eg if you only bulk-something 2 or 3 docs.
looks better - cosmetic really - is it a problem?


typo ? "plaintText" ?


Since you're going to use this pattern a few times, I'd like to again advocate applying the helper function here:

    function extendMethod(context, methodName, extension) {
      var origMethod = context[methodName];
      context[methodName] = function() {
        var args = arguments.slice(0, origMethod.length);
        return extension.apply(context, args.concat(origMethod));
      }
    }

    extendMethod(this, 'create', function(json, parameters, oldCreate) {
      var self = oldCreate.call(this, json, parameters);
      /* do new create stuff with self */
    });

This way the 'extension' method should have N+1 arguments where N is the number of arguments of original method, and the original method is passed as the last argument of the extension.


Just noticed that str->bytes and unicode->str, so `__str__()` should check for this, but return a valid unicode string for Python 3.


Rather put Starting Id in a label tag, it makes reading the code much easier and it will help if you want to add specific css to all <label> elements


Please note this change. You might need similar cleanups in your analysis class.


Most of the code here comes (was backported) from NPoco, not sure if they have an issue open though.


¿Tiene que seguir este modelo?
http://escuelaposgrado.ugr.es/doctorado/tramites_administrativos_alumnos_doctorado/ficheros_tramites_administrativos_alumnos_doctorado/proyectotesisdoctoral


ah - here the is dispatch over ```@Produces``` - see my comment on the consumers


nope just curious


Better approach might be just returning $image. There can be more usages than only sending image (you can for example hash image and compare hashes in some project). Same goes for next lines.


So I just figured out how Github works. Have I seen that correctly, that you gave me access to the IAHM-COL/tu154b repository? Should I develop in this one or do I rather use a own one as a fork of yuriknsk/tu154b?


Ok the url need to be placed in implementation class right?


Nit: a block height is not a token amount. Please cast to `int`.


removegitattributes (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2306 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.42%25-yellow.svg)


I'd make it public then, it's sad to debug descriptors which are `org.jetbrains.kotlin.codegen.MutableClassDescriptor@ba261bf9`


@vwadekar,
Hi Varun,
   Some more comments from my side. Hopefully if all the newly suggested assert checks pass for all the use-cases, then the platform code should be in a good shape.


I think better approach is to require IStorage in constructor. Classes like this can not be tested well, if they force user to use FileStorage.


@Thecrazyskull u saw this commit somewhere else?


hjkdjaskldjaskld;asd


hmmm labai ilgai nieko Liudas neparase :)


The first argument to describe should be the class or module being tested.


@knapo You may want to use stub_const.
```ruby
before do
  stub_const("ENV", {
    'MYVAR' => 'value',
    'MYVAR2' => 'value2',
  })
end
```


Could you make this a separate target, say 'make coverage', instead?


I guess the initial check returns false if the `$modelValue.length` is `0` and your change does return `true` when the value is `0`. Do you still get the desired behaviour using this?

This looks like a nice addition to the component. Are you up to create a PR with your fix? Thanks!


If I'm not mistaken, then this generated 4 user faced messages:

1. PrintToLog
2. PrintToConsole
3. UI message box via AbortNode
4. LogPrintf via AbortNode


Nice one. But you need to delete `LICENCE` and `LICENSE`.


Puedes preguntarle a @deantares o a @rubenhek, que lo estaban rellenando, o lo han rellenado ya.


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1808 of 1808 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nit: the upper case variable name should probably be lower case


That makes sense. Perhaps the commit message could be something like this:

> Make CSRF protection consistent
>
> FeedbacksController overrode the protect_from_forgery settings inherited from ApplicationController. As a result, forged requests to FeedbackController returned 302 Found, but they returned 422 Unprocessable Entity everywhere else.


Remove testing code


No objection to this change for the moment, but if/when we decouple common/api out, this will fail again.


Shouldn't this read more like "map write-combined"?


That's right – thanks for pointing it out! I fixed the help text in commit cf8d7fb.


Fair enough. At this point it will be sensible to run javadoc with `failonwarning` per decoupled component.


make it a part of package


But the UNIX way is to be able to override :-) In the end your launcher should bind the environment variables but the binary should use flags :-)


Variable name control is very ambiguous. A bit more descriptive


Pues supongo, pero como lo quería hacer en LaTeX como @deantares, le
pregunté y me dijo que hizo un .tex normal con las secciones que pedían.

El jue., 27 de agosto de 2015 12:32, Pablo García Sánchez <
notifications@github.com> escribió:

> Puedes preguntarle a @deantares <https://github.com/deantares> o a
> @rubenhek, que lo estaban rellenando, o lo han rellenado ya.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/unintendedbear/Plan-de-investicaci-n-t-sis/commit/908bfdd83072279efb540b9161a429088b5d5d0b#commitcomment-12923210>
> .
>


lol


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


관리자 페이지의 환경설정에 있는 추가스크립트 삽입관련 부분이 빠진것 같습니다!
basic 테마에서 제가 작업중인 코드가 작동하지 않아서 알게 되었습니다 ! ㅋㅋ
if(!defined('G5_IS_ADMIN'))
    echo $config['cf_add_script'];


you mean the commit message or the variable name ? both we can change this, of course