Hmm, interesting. I have used libx264 since the inception of the project and it has always worked fine. I did a quick recording test with h264 and the output seemed normal. Also, thanks for making me look at some of that code, there's a small codec-codev typo there that should be fixed. I'll merge your changes and quickly fix that typo.


makes sense to also perform following check in these other test cases as well:

assertThat(value).isInstanceOf(LinearKPIValue.class);


5058-fix-readvars-cli (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (1733 of 1780 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.36%25-yellow.svg)


I mean something very personal. It's not an algo, it's a human summary.


@coreyfloyd in that case, we shouldn't call `cellForItemAtIndexPath:`, which is declared as `nonnull` in the docs


Why were the android emesis removed? I think it was something that set textsecure apart and I know several people that are disappointed by this. How about making it a choice?


This is fixed btw!


@Andrei-Stepanov, we need to work on the changelog. I need a commit message explaining which change you are adding, and why that change is necessary, together with a Signed-off-by: line, otherwise I can't take this. Thanks!


fix this with a locking version


Sounds good. Will fix.


I see what you mean. Interestingly it worked most of the time for me. Nevertheless I had already realized that the whole approach is rather fragile and doesn't work always - in addition to the issue with the wrong positioning.

I had already thought about moving some items (back) from the panel to the widget in order to avoid these `widget()` calls that tend to become circular. This would for example be `slotShowToolbar` and the session slots.


This change was in response to another committer telling me to remove the extra whitespace that was added erroneously.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 365](http://192.168.30.225:8111/viewLog.html?buildId=1888&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:11:07


Undoing, hopefully the if statement without braces never bites us :)


Rather than using plot continuously, this used a canvas which is updated at 10Hz


Could you provide a little bit more information?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.890.f09f18a2cd81a32f937971bbba2eaf5d4871d6ad](http://build.palaso.org/viewLog.html?buildId=60596&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:03:49


In tiny datasets there is not so much difference, i.e. using the data from the example amgut1.filt on my laptop:

One core use:
```
microbenchmark(est.clr.sc <-sparseiCov(data.clr, method='glasso', ncores = 1, nlambda = 50),  times=10L)

Unit: seconds
                                                                                expr      min       lq     mean
 est.clr.sc <- sparseiCov(data.clr, method = "glasso", ncores = 1,      nlambda = 50) 10.78753 10.80896 10.89008
  median       uq      max neval
 10.8472 10.99416 11.01935    10
```

4 cores used:
```
microbenchmark(est.clr.mc <-sparseiCov(data.clr, method='glasso', ncores = 1, nlambda = 50),  times=10L)

Unit: seconds
                                                                                expr      min       lq     mean
 est.clr.sc <- sparseiCov(data.clr, method = "glasso", ncores = 4,      nlambda = 50) 6.751323 6.822055 7.062001
   median       uq      max neval
 7.067801 7.136142 7.709561    10
```

But in the datasets we are dealing >4000 OTUs it reduces the time substantially as the nlamdas are executed in parallel. Will rerun some stuff and show some numbers


Hi Jeff,

We'll most likely update at XF.com when there are more significant changes and after periods of testing, etc.

However, you should be able to download directly from GitHub in the meantime:

https://github.com/Xon/XenForo-AddOnInstaller/archive/master.zip

Chris


É garantido que os livros vêm agrupados? Porque se vier livro 1 - autor 1, livro 2 - autor 1 e depois livro 1 - autor 2, quebrou sua query!


Agree with the change, but don't really see how it fixes #2 as it has the exact same behaviour.


I'm actually okay with all of this.


why are you recreating the API client's retry logic?


oops this should be a ticker.


Is this workaround only needed for Unknown Frames? ("_1")


I don't think `data === this.state.data` will ever be true. maybe use lodash `isEqual`


Is there a reason for these to use `const&` unlike all other functions?


This file still had some other old include standards so updated them all.


order in (orders | filter:orderFilter)


Looks like a code style mismatch.


Is this workaround only needed for these values? I see other similar patterns: ex: `stroke-dasharray="25,15"`


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/74124450


Prueba en github


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 261](https://teamcity.labkey.org/viewLog.html?buildId=264516&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:13:12
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Price: {{ album.price | currency }}


Ну, тогда стоит дописать "стр. 74-75". Хотя вообще формулировки там несколько другие и алгоритм из них надо еще додумывать. Зато разбирается все это довольно подробно, почему бы не оставить будущим разработчикам РДО референс для общего развития.


I've added this to the inits and core code.

Thank you for finding this.


404 instead?


hi @bryanmtl

what i have in place are similar to spree's api eg, https://github.com/spree/spree/blob/master/api/app/controllers/spree/api/v1/inventory_units_controller.rb#L28

all their controllers use the :read access.


Done fb0b91d


better call it framebufferGroup or even just have as a local variable


It seems like github should probably distinguish between signed and non-signed commits.


```COverlay::TYPE_GUITEXT``` ?


Aleluia!!! \o/


Those are two different initializers


fast-forwarding master to auto = b7d7489e


Is there a reason you switched to `Comment.create!(comment_params.merge(post: @post))` instead of `@comment = Post.comments.create(comment_params)`?


Maior stalker eu né? Vendo commit ahuahuhua


When uploading a zip file with 1000 tiny text files (via SWORD), updating my jhove.conf to this version reduced the time for the request to complete from 27.96 to 8.986 seconds.


@ahmadnassri it doesn't work because of CloudFlare not being able to detect the host when it's not being preserved (which is exactly the problem we are trying to fix). HttpBin on the other side has nothing sitting in front of their web server, which makes it work.


So this change broke all of the sensor connector dialogs, which were passing bare strings into setContent (via a Notifier class). I'll fix them, but it would be worth scanning the rest of the code to see if anyone else was using setContent the same way.


This is for the creepy animation hence the timeout


SetBindHost is fine, list of them (AddBindHost etc) is not.


Although it is [not required](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Default_parameters#Parameters_without_defaults_after_default_parameters), I think it's good practice to supply a default value for all arguments following optional ones.

What do you think @aldipower ?


@mickeyren Ok, sounds good.


It really doesn't help with our 10k message limit though

_________________________________________________
Carlos Henriquez
Massachusetts Institute of Technology | Class of 2017
Department of Electrical Engineering and Computer Science

On Tue, Aug 4, 2015 at 11:26 PM, Kate Yu <notifications@github.com> wrote:

> This is for the creepy animation hence the timeout
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/techx/hackmit-hackbot/commit/10532a3b81942d88817f80f71e3e469063876cc0#commitcomment-12526136>
> .
>


Hello World!


Lennysnake is a powerful thing, and should be used sparingly. Therefore the message limit is not a problem.


:( will double check my IDE configuration. Thanks.


@bgerstle good catch… will fix


```
# Old method:
# 0.5538689650602464

# New method:
# 0.09099616230584916

import timeit

ITERATIONS = 10000

print(timeit.Timer(
"""
entity = Entity(0)
entity.get_key_value_color('rendercolor')
""",
"""
from entities.entity import Entity
"""
).timeit(ITERATIONS))
```


How can we get a handle to the JsRuntimeReplFactoryBuilder from the application? The idea is that applications could bind custom classes/objects/functions.

At work we have provided our own custom version of runOnUIThread, startService, startActivity, etc.
What we where doing was initializing stetho with js and adding calling:
 * [importClass](https://github.com/facebook/stetho/tree/master/stetho-js-rhino#import-a-class)
 * [importPackage](https://github.com/facebook/stetho/tree/master/stetho-js-rhino#import-a-package)
 * [addVariable](https://github.com/facebook/stetho/tree/master/stetho-js-rhino#variable-binding)
 * [addFunction](https://github.com/facebook/stetho/tree/master/stetho-js-rhino#function-binding)

I'm planning on porting some (or all) of our changes to back to stetho (or at least to document them). Having access to builder to pass this binding back to the JS runtime can be useful.


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 366](http://192.168.30.225:8111/viewLog.html?buildId=1895&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


Yeah, sorry.

getMicrosoftTimeZoneName returns null when the id cannot be found. This causes the assert on line 62 to fire when checkGetMicrosoftTimeZoneName("africa/abidjan", "UTC"); is called because "africa/abidjan" cannot be found in the map.

Hopefully I explained that well enough.


saw approval from jedmccaleb
at https://github.com/stellar/stellar-core/commit/2bff7eedd60aced7d9e78bc31d0af6d62e722bc3


merging stellar/stellar-core/dm/update-sodium = 2bff7eed into auto


stellar/stellar-core/dm/update-sodium = 2bff7eed merged ok, testing candidate = d6df77db


This is awesome!


Ajout du url pour que le fil RSS (feed.xml) fonctionne.
Corrections mineures.


like


While here, can you fix the indentation for this line (tabs -> spaces)?


WindowComplexManager_Speedup (DeadParrot) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-86.63%25-red.svg)


It's because you can provide `exiftool` with multiple images.


> Those are two different initializers

```
func NewFramework(baseName string) *Framework {
    return NewCustomFramework(baseName, nsCreateFunc)
}
```
?


Personal preference but I think a link helper would make your code a lot more readable here!


That might make more sense in terms of how the urls are layed out.

For reference the api error codes were refactored in the second commit (https://github.com/Shopify/toxiproxy/commit/3c57f526a78319770ebb92e5bc89be1438252a45#diff-651a84f8ad6a38c1f7ccdf63f2692410R393)


Coursera Data Science Toolbox project.


@Geod24: Love these kinds of commits ;) (180 lines less)


My bad that "_1" actually means planning I believe - so the file pattern I am actually looking for is `Frames/*_1`


Missing `defaults`


Can you maybe clarify this comment? Not sure I understand.


`const` instead of `var`


We try to avoid that kind of heuristic if possible as if these heuristics fail then we fall back to the Bayesian classifier.


Not needed


`const`


This commit makes me sad. Especially the message. Can I pull request to 'harvard & quorum'?


Thought that might be the case, in that case carry on!


Now you can filter on build matrix setting in the build job duration chart.


I have no life. I am literally spending my time reading through friends commits.


:smile:


Btw, check this out: `/Applications/Xcode-beta.app/Contents/Developer/usr/share/xcs/xcsd/classes/issueClass.js` line `202` -> `commits: [], // TODO` :laughing: At least we know we won't be getting commits any time soon.


typo?


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 366](http://192.168.30.225:8111/viewLog.html?buildId=1895&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:09:57


`Divergence`


Why an optional? Below you use `??` anyway, so if I'm not missing something you could just turn it back to `NSDictionary`.


You are changing existing logic, which is not permitted.


`gulp` `lint` is complaining that this variable is not being used.


Yeah sure.


Hvad er det her?


Excelente! :+1:


Crying :P


how about searching for existing issues before you are asking a question for the 100th time? :tired_face:

fyi, this is not the place for discussions, github is for bugreports. Use the mailing list for discussions/questions...


:shit:


Hi @bloatware - can you give me a little info on what the exclude attribute does (or where it was discussed prior to this commit) so I can update the tag's documentation? Thanks!


@Buda1996 CRY MUAHAHAHAHHAHAHAHAHAHAHAHHA


Property "fill" already does something: when 1, it scales up to fill rectangle without cropping. You cannot change existing behavior. Your idea is good, but it needs to be triggered a different way. Perhaps when fill=2, or new property fill_crop, or crop_to_fill. And then, you cannot break fill=0 or fill=1 to fulfill this new behavior.


93651760-RowPerObjectReport (mjwitte) - x86_64-MacOS-10.9-clang: OK (1789 of 1789 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


BTW, this directory name change was just temporary while I was testing build system changes. I'm putting it back the way it was.


This error handling isn't needed. This script runs with `set -u` which will make the below assignment of "$1" fail if its unset.


Please declare this `local`.


@bgerstle  This navigation controller is a child view controller of the WMFArticleContainerViewController.

It is used for the ArticleVC and the webVC so that they have a different navigation stack (like we discussed last week). Needed this so I could separate out the different contexts for this transition and the forthcoming web transition.


Changing y is not a good idea, better change only the score.


This is obviously meant for discussion, it literally says comment on he commit. The bug tracker is there for bugs, don't use the comment section for that.


`url: VALIDATOR_REGISTRY_API+"/reports/"+validationPublicKey`


I see you copied this from the base class, but how about:

       try {
            super.write(b, off, len);
       } catch (IOException e) {
           // impossible
       }

Also, don't have to do this now, but often sub-classes of OutputStream override this method and do something more efficient.  In this case, the efficiency benefits would be the ability to use System.arraycopy instead of copying byte by byte.  It's worth a ticket.


I would change the score so you get full score on your lane, and half when you are not in your lane.


this is punishment for the sin of makind.


Så undgår man et mellemrum før kommaet.


Same here, we can avoid adding another configuration, and instead get half the score if not in lane.


r+


Use the `_MM_SHUFFLE` macro to create the param


Introduces a new dependency on xmltodict.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/74129289


I have an error here and  I don`t know how to get rid of it :"Unhandled exception type Exception".


Sweet. He even signs on them if you ask him nicely.

![](http://i.imgur.com/UR6o18p.png)


```
var promises = transaction.purchases.map(function (pur) {
  return AlbumFactory.getAlbum(pur.album);
})

return $q.all(promises);
```


See the following link for a visualization of current master vs new logarithmic model.
https://drive.google.com/open?id=0B5iFkyaZ-VOtdTJMMERGUFhXZFk


Looking good


Can't believe it


=)) scuze


Thanks!
Note that if the item is nullptr due to failing dynamic cast, the sound should also be played and break called.
Could you fix that?


I much prefer this style of listing all public entities near the top of the module


[ { state: 'admin', icon: 'glyphicon-dashboard', label: 'Dashboard' } ]


wat


FixLinksInDocs (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1784 of 1784 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fast-forwarding master to auto = d6df77db


Mm, this is the !slice case.


Looks like we need to add pattern "*_1c" here also


Is this Jiang and Shu WENO?


Thanks again. All this is reminding me that code part is not really good. But let's fix little by little.


What is this?


fuck me, *typo


quibble - there seem to be some extra spaces here.


I can't since currentResult is not effectively final. Or do I miss something?


Is this <= 80 columns?


If this is a test - name it accordingly:

Test_FinalPhotonSelection.py?


| date


nothing to say


{{ promoDate | date:'medium' }}


Good catch. Will fix locally before pushing.


> It would be worth some effort to ensure that references to objects related to animations are cleared when the animations are completed - for animations that only happen infrequently that is.

Well, normally, it is the case ;) I hope the debug tools I'm on will help. thanks a LOT for the massif output in any case. This just will help.


has been corrected in a later commit


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/99c1dae985e587be16c26b566eac37590f12d5fc


merging graydon/stellar-core/bug-669-fail-catchup-harder-so-files-get-deleted-refetched = 99c1dae9 into auto


graydon/stellar-core/bug-669-fail-catchup-harder-so-files-get-deleted-refetched = 99c1dae9 merged ok, testing candidate = 0284c24c


you can use a reduce instead, anyway, not really important


is that url at the end something we want/need?


Cool. I just miss samples/tests :)


lodash, _.without($scope.users, { _id: id })


wrong name?


@zhangns 我的pycharm一键reformat后就成这样了……


can you keep a symlink right now? I'm currently building things


Can you change

Test_GeometrySphereSurfaceProjectExternalSphere.py

With a relevant test to reflect these changes?


Makes jpm launch firefox with addon signatures disabled.


function (user) {
  return !(user._id === id);
}


`order` doesn't preserve a reference to the ctx, does it?  If not, why not just `order = get_order(group, bn_ctx())'`

Where's `get_order` defined now?  Didn't you delete it in this change?


should probably bump to at least 0.2.0 for such a breaking change...


I'm not familiar with why you would do this. I tried it in my browser and `a.href`looked exactly like currentUrl. ??


we should still make metadata available to the caller on success


why? COverlayText is a subclass of COverlay


This link makes it clear why there are potential issues with Click on Python 3, and why the unicode/bytes handling on file I/O and command line input is problematic, but it doesn't (appear to me?) make any case for why explicit literals by default in *the source code interacting with click* is preferable to unicode literals by default.

Would there be any sense in including some context on that page *specifically* about the unicode literals vs explicit literals, or am I just being dumb?


Maybe we should change the name since it is not upgrading. checkMappingsCompatibility?


Updated.


Oh, it's duplicated in the .cpp file?!  How did it ever work?


It's a thing of beauty :)


Alternative version, also in 8 instrs but without needing the mask:
```
MULPS(SRC1, R(SRC2));

MOVAPS(SRC2, R(SRC1));
SHUFPS(SRC2, R(SRC2), _MM_SHUFFLE(1,1,1,1));

MOVAPS(SRC3, R(SRC1));
SHUFPS(SRC3, R(SRC3), _MM_SHUFFLE(2,2,2,2));

SHUFPS(SRC1, R(SRC1), _MM_SHUFFLE(0,0,0,0));
ADDPS(SRC1, R(SRC2));
ADDPS(SRC1, R(SRC3));
```


first try


_.find(users, { _id: $stateParams.id })


hum, true but it's not ```pName```, but ```GetUnitById(nId):GetName()```


Just out of curiosity, I noticed you deleted the lines where all the variables (namely `title` and `id` were declared), and then later declared them inside the loop to generate each folder listing. Is that better practice?


lgtm


"Not interested in explaining further, been over this ground too many times before" is also an adequate response of course :smile: just figured I'd note that it's not clear to me how that document relates to this specific design decision.


How about `409 CONFLICT`?


or ```GetPlayerUnit():GetName()```


Thanks @myshkin. I haven't noticed an issue with quoted/expanded tweets
displaying multiple times yet, but I've only been running with this
tweak for a couple of days.

I'm going to see if I can figure out a less hacky way of doing this,
but might take me a while.


yup :P


Yeah, I put it back


Good catch!


This change seems to have uncovered a bug in `nixos/modules/profiles/minimal.nix`, which contains

```
i18n.supportedLocales = [ config.i18n.defaultLocale ];
```


Should we add a helper function for this check (i.e. is this something we'll have to do whenever we want to check if something is an array)?


En passant, tu peut juste modifier le fichier language.yml dans le dossier de Craftconomy pour le changer en FR ;)


If the (abstract?) factory pattern is properly followed, you will not need a `select type` block here. This requires `weno_interpolator`to have an `interpolate` method defined. If it does follow this convention, then the client code doesn’t need to have any access to the `type_weno_interpolator_upwind` module at all, and can *ONLY* interact with `weno_interpolator` objects through the abstract interfaces. (To the client code these objects exist only as contracts, cast as their abstract type.) In fact, I would leave the concrete implementations out of the `wenoof` module completely. The concrete factory/builder modules *DO* need to have access to the concrete `weno_interpolator` types/classes, and the client code *does* need to have access to the concrete factory/builder modules, but *not* the concrete implementations of `weno_interpolator`.

If you want to follow Rouson et al., the factory should *construct a `weno_interpolator_upwind` object*, and *return a `weno_interpolator` object*.


done


this approach causes a pottential problem. what if the result of an algorithm includes an error key? (e.g. a "margin of error" like {result: { confidence: "0.72", error: "0.02" }}).
Now if the caller does: if(result.error) { /* is this an API error? */ }

Previously this was solved by: `.success(cb).error(cb)`
I'm open to alternatives if they don't leave ambiguous situations.

Addtionally, some errors may include a stacktrace (per the API spec) that we should also expose back to the caller.


If I’m not mistaken, this is the only line requiring the select type construct, which could be eliminated adhering to the factory pattern as outline by Rouson et al.


Without forcing the value, HPC will cause a spurious coverage fail here, since you don't typically inspect the return value of an `IO ()` expression. Using `$!` makes sure that we get the right pointer to `()` in the value rather than a thunk, and ensures that HPC treats that expression as covered.


variable's scope should be as narrow as possible, it should be declared as close as possible to where it's used.
it's a good practice to follow to make code more readable.
additionally, in javascript, where variables are captured in closures, it can help avoid unneeded captures (i think).


Ok, I see. I'll rename it just after merging.

--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?


nice addition ;-)

I would have include the directory from a relaease instead (like  v0.2.4 ) not the whole source .... or better, a submodule ...just like for qtip ;-)


Just added it now, works a charm! I've credited you in the JS file header but I don't know how to credit you via Github... :s


@aldenml to build *jlibtorrent* now, it's as simple as?

```cd swig
./build-linux.sh```

```cd swig
./build-android.sh```

```cd swig
./build-linux.sh```
??

I think the build instructions probably need an update.


:boom:


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/74133382


user 내용은 변경될 수 있으므로 변경되지 않는 id만 비교하는게 좋을것 같습니다.


I may be a bit paranoid, but I really, really like to always include the `only: …` portion of the `use` statement. That way when you see undeclared variables, derived types, procedures, etc. in the current scoping unit, it is clear where they came from. This can be impractical for very large modules/libraries, but then the design of the module/library should probably be re-examined to require fewer items to be exported—at least for OO codes.


looks like a typo!


`{{ album.price | currency }}`


Is not that simple, because you need to iterate for each actual OS, but yes, it is just that command. The build instruction needs a super update.


GroundDomainUpdate (mmatts) - x86_64-MacOS-10.9-clang: OK (1785 of 1789 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


Thanks, I just noticed that on our big screen and was playing. I don't
understand why our dart stable build seems tri-modal (four if you count
fast failures).
Bigger problem is the graph doesn't go back far enough in history to show
me when the time increased.

On Tue, Aug 4, 2015 at 1:38 PM Dieter Adriaenssens <notifications@github.com>
wrote:

> Now you can filter on build matrix setting in the build job duration chart.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/angular/angular/commit/30bd2a3fc72f8f1cdb0ffc4b9d11b4ca42e9ece7#commitcomment-12526378>
> .
>


```
# get_key_value_int
    # Old method:
    # 0.3881156710576761

    # New method:
    # 0.07857079930483203

# get_key_value_float
    # Old method:
    # 0.37358543729399685

    # New method:
    # 0.07939316233715647

import timeit

ITERATIONS = 10000

print(timeit.Timer(
"""
entity = Entity(0)
entity.get_key_value_int('health')
""",
"""
from entities.entity import Entity
"""
).timeit(ITERATIONS))

print(timeit.Timer(
"""
entity = Entity(0)
entity.get_key_value_float('health')
""",
"""
from entities.entity import Entity
"""
).timeit(ITERATIONS))
```


This should become:
`"Authorization": "Simple " + key`


Every API will be a little different. Keep in mind that you can do things like sending headers and setting other parameters on the requests. The `$resource` and `$http` modules allow you a great deal of flexibility with how you handle this stuff.


Well, _technically_ it's wrong, but _we do_ fetch data from KOS which we _turn_ into events. Again, that's an implementation detail, from client's point of view it doesn't matter.


this should be exact_result = exact_result or (eregex.test option.html)

otherwise a non-exact result after finding an exactly result will set this variable to false


How would you deal with sending it to multiple players then? Only the first player can do it?
A timelimit is probably a good way to go. Or a combined one.


Is this just for safety, or are you bumping this up to fix specific games?


Hi Tom Preston-Werner,

This bit.ly hyperlink redirects to [http://blog.codestarter.org/how-we-turn-199-chromebooks-into-ubuntu-based-code/](http://blog.codestarter.org/how-we-turn-199-chromebooks-into-ubuntu-based-code/). However that website is now not working.

@mojombo, can you update the URL. I want to read the history on how Codestarter selected that piece of hardware.

I look forward to reading the history of this project. Lol, honestly, I just want a laptop I can rapidly image and put Linux on it. I don't have the time to fiddle with Ubuntu or ArchLinux, and fiddle with the wifi drivers. Just want to get the stuff working, so I can use a cheap/affordable laptop I can use on the go -- sometimes lugging around a macbook is too much, and frankly too expensive to lose.

Jonathan Lai


fast-forwarding master to auto = 0284c24c


gold, @warmwaffles


These would need to be sorted somehow first, our you could end up with a disjointed cluster.


I would actually *not* expose this module to client code (by including it here). See my comment below, about how to accomplish this. That way they won’t be tempted to use structure constructors, and will only instantiate objects the proper way, through the constructors provided by the factory pattern.


Is there any reason all these calculations are done in 64-bits instead of 32?


should they not be optional too?


This program was built using inheritance. It was made to manage the details of a university student.


@yehudasa ```arr[...] = { 0, }``` statement should zero whole array [according to quote from the standard](http://stackoverflow.com/questions/5636070/zero-an-array-in-c-code/5636111#5636111).

Let's verify that with some test code:
```
int main() {
    char arr[12345] = { 0, };
    return 0;
}
```

Assembler output from GCC obtained through ```g++ -S /tmp/test.cpp -o /tmp/test.S``` shows that compiler would decide to simply jump into ```memset``` in case of huge arrays:
```
main:
        // ...
        subq    $12352, %rsp
        leaq    -12352(%rbp), %rax
        movl    $12345, %edx
        movl    $0, %esi
        movq    %rax, %rdi
        call    memset
        // ...
```


Le *without affecting the original project* s'applique à l'ensemble du dépôt... après un *fork* on obtient bel et bien **deux dépôt complètement distincts**...

J'utilise Github au travail, on a qu'un seul dépôt que j'ai cloné sur lequel je n'ai pas les permissions pour merger les pull requests. J'ai ma copie locale, sur laquelle je fais tout mon caca, puis lorsque je suis content de mon boulot, je pousse sur le seul et unique dépôt (il y en a bel et bien qu'un seul, vu que l'on a jamais fait de *fork*). D'ailleurs, tu peux essayer de faire un *fork* d'un projet sur Github, tu obtiendras bien deux dépôts indépendants.

Par exemple, disons que tu es intéressé par une bibliothèque qui fait du café. Si tu veux contribuer pour l'améliorer, tu clones le dépôt, fait des modifs puis termine par une pull request. Si tu veux avoir ta propre version personnalisée de café, tu *forkes* le dépôt et tu obtiens ton propre dépôt à toi, **avec les fichiers du premier dépôt**, sur lequel tu peux faire *ce que tu veux*, vu que tu es tout seul dessus.

Si les contributeurs *forkent* puis font une pull request, leur pull request sera sur leur dépôt personnel... auquel personne n'aura accès. Ils doivent donc bel et bien cloner le projet, pour que tout le monde travaille sur le même dépôt Github.

En fait, techniquement, ils peuvent faire un *fork* du projet, mais ils auront quand même à cloner leur nouveau dépôt pour pouvoir éditer des trucs... Puis ils pousseront sur le dépôt original, et le *fork* ne servira à rien.


Cool! Much better, right?


FYI, call by name functions do NOT cache the result :(

```scala
>  def byName(foo: => Unit){ foo; foo}
>  byName(println("hello"))
hello
hello
```


Oh, @quintesse please use a fat arrow here instead of a block with a `return` statement!


No, this isn’t just a _technical detail_, it’s very important to understand that we don’t get _events_ directly from KOS.


if i dont have jquery... i get an error `Uncaught ReferenceError: jQuery is not defined`
Don't know if you are maintaining this project still or if you want new issues posted


WindowComplexManager_Speedup (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1738 of 1780 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.64%25-yellow.svg)


Oh yeah, I guess that makes sense.


I see some whitespace/indent changes....I see some relatively significant seeming table refactoring!  So far so good +1  ...  I am not merging because of tweaking in progress


what would happen if we subtracted the losses. I like that you are weighting the wins, and then counting the ties as basically one point. Are you a hockey fan?


stupid question: why does this need to be native? `1.0/0.0` should be positive infinity on the JVM too…


Will take care of it.


I agree that the changes make this correct. - Still think there should be modications to the test file


There were two overloads of `get_order`: I removed the unnecessary one, and we retain the necessary one.


WindowComplexManager_Speedup (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Here were several of the other similar patterns I found:

"22.1063,13.2638"
"23.3682,14.0209"
"23.4314,14.0588"
"23.5714,14.1429"
"24.1702,14.5021"
"24.5874,14.7524"
"24.267,14.5602"
"25.4169,15.2501"
"25.7843,15.4706"


if you're using jquery why not just use `$(document).ready()`?


Using a single builder pattern for the whole lib makes these awkward statements valid:
`algorithmia(myKey).algo(someAlgo).algo(someOtherAlgo).pipe(data)` (calls someOtherAlgo)
`algorithmia(mykey).then(cb1).pipe(data).algo(someAlgo).then(cb2).algo(someOtherAlgo)` (cb2 called with the output of someOtherAlgo)

This doesn't need changed right now, but at next refactor, it would be good to have `.algo(..)` return a different object. (this will be more important once we add support for the Data API)


Remove this file.


Thinking about it more, it might be that what you want to do is augment the arts with a set of effects (like hue shift, rotate, invert, etc).

If that's true, then I wonder if the simplest change is to abstract that into a separate modifier layer that gets called after each frame is rendered by the art? We could independently define the frequency at which the modifier layer gets switched out for the next?

Alex

> On Aug 3, 2015, at 10:31 PM, Alex King <alex_w_king@yahoo.com> wrote:
>
> Hey Rafe,
>
> thanks for solving the confusion, and glad you got in touch :)
>
> I'm excited that this code might play a role in a burning man project, and I'd love to work with you on figuring out what you need and how to make this stuff work.
>
> Can you tell me about what you want to accomplish?
>
> Alex
>
> p.s. I'll absolutely cherry pick life, the driver file, and things like gitignore. It looks like it might take a little unraveling though.
>
> From: Rafe Kaplan <notifications@github.com>
> To: slobberchops/rop <rop@noreply.github.com>
> Cc: ak15199 <alex_w_king@yahoo.com>
> Sent: Monday, August 3, 2015 12:43 PM
> Subject: Re: [rop] Added production blinky configuration for fade candy server. (926e645)
>
> You are writing to Slobberchops (aka Rafe)! Patrick is working with me on
> the forked source code project. I should explain...
>
> You definitely don't want to integrate all of our changes, we're working on
> a specific configuration for a burning man project. I was suggesting that
> you either cherry pick the changes that pertain to things you find
> interesting (specifically life.py) or just copy the files in without
> preserving the history.
>
> Those config files are indeed specific to the hardware we've been working
> on. It was done that way because I wanted to avoid writing my own
> equivalent of art.py at the time. I now understand more about what art.py
> does and am ready to either write my own harness, which would allow me to
> write stuff completely independently from the rop fork as we are doing now,
> or contribute improvements (if you like them) to the existing harness.
>
> Anyway, some changes to the original rop project would make it easier for
> someone to use that project independently while injecting their own config
> and art details rather than how I did it. If you would like some
> contribution to that effect, I'll be happy to do that separately.
>
> In the meantime, I could not figure out another way to communicate with you
> outside of issuing a pull request :)
>
>
> On Mon, Aug 3, 2015 at 9:58 AM, Patrick Ball <notifications@github.com>
> wrote:
>
> > oops sorry thought I was writing to slobberchops! maybe blinkymirror.json
> > should be git ignore'd?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/slobberchops/rop/commit/926e645aea800618d372ae870d413bbe2d2e73d6#commitcomment-12497841>
> > .
> >
>
>
>
> --
> - Rafe
> —
> Reply to this email directly or view it on GitHub.
>
>


it should be, "there is not an account ... "   or "no account  ..."  I think


Had to refactor this to allow for cases where endpoint is defined using identifiers, such as `candidate/P00003392/history`


No, it's longer, but I made a judgement call to go over. I'm reconsidering it now.


Rename this file appropriately
Something like:

Config_AstronomyFermiClusterAnalysisMaster.py


It's because they are being added to a pointer later, so they need to be 64-bit sign-extended.


It is something strange ... sCommand not used further


develop (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.54%25-red.svg)


Well, but you still imposed this issue on yourself by dropping the second sentence. ;)
Generally the structure doesn't make any sense now, since all exceptions do is _modify events' attributes_; but the way you put it is: _oh, also it modifies attributes_:

> Schedule exceptions describe differences to the “regular schedule” generated from KOS data, e.g. state holiday, dean’s holiday, temporary change of room, …, and modify events’ attributes fetched from KOS.


@lucaswerkmeister good question I wondered that myself.


Thanks for posting it!


Well, so suggest a new introduction, please. ;)


So how about:

> Schedule exceptions describe differences to the “regular schedule” generated from KOS data, e.g. state holiday, dean’s holiday, temporary change of room, etc. Applied exceptions modify attributes of events generated from KOS.


Hello world


This doesn’t make a sense for me. What’s “applied exceptions?” This is confusing.


Name this something more descriptive.
Perhaps:

Utility_AstronomyFermiEventsAndPointSourcesWithGalaxyGroupsLineSearch.py


Connect to Payroll Oracle Database using Eclipse


> please use a fat arrow here instead of a block with a return statement!

@gavinking that's exactly what we talked about last time, the specifier expression isn't in the scope of the attribute, so it doesn't know that it's meant for native code which means it can't be compiled correctly.


There is no file called

Library_updatedFeederDispersionFile.py

Name it:

Test_DataGetFermiInstrumentResponseEnergyDispersionFunction.py


Woops don't pull this... these are all debug changes... overwriting


Hi i'd like to let the use to choose which target name to use as server. allowing only name from dns would be a problem with server returning a different (virtual) host name. So I think the target name could be sent in the sasl_credential attribute of the connection object that is actually empty for kerberos authentication.

Can you check this solution in dev? You should pass a tuple in the sasl_credential with the target name as the only argument (remember the comma after it...):

c = Connection(.... sasl_credentials=(target ,)...

Let me know if this works for you.


991757360-DocIssues-4956-4997 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1769 of 1772 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


@garyb This commit adds retries to `Api.Query`. I think that these should have timeouts, but I wasn't sure what the proper timeout to set would be. Do you have any thoughts?


Add better description


@lucaswerkmeister perhaps it's not as efficient


@majloSka, na co je toto dobre?
napr.
body.no-touche sa vobec neprejavuje,...


tl;dr FUCK GITHUB


Looks like the Python library takes a "Simple": https://algorithmia.com/docs/clients/python/
How about I check if the API key has 'Simple', and add it if it doesn't exist?


La idea es portar la biblioteca de control al CIAA Firmware. La biblioteca necesita solo dos elementos del CIAA Firmware: la definicion de los tipos de datos (uint16_t, uint32_t, etc...) y una biblioteca de recursos matematicos para el manejo de matrices. El primero de los elementos lo consigue a través de la capa POSIX, por eso, está el include ciaaPOSIX_stdlib.h. El segundo elemento se conseguirá con un include a ciaaLibs_Matrix.h que aún no lo agregué.
Agrego tambien que la ciaaLibs_Matrix necesita una capa driver para interactuar, por lo que tambien falta agregar el include (aun no creados) en modules/bsp y los  .c de cada arq (aun no creados) en modules/platforms... estoy en los correcto?


Maybe forgot to rename usage of `transform` for bounds in DisplayObject?

```
/usr/lib/haxe/lib/openfl/git/openfl/display/DisplayObject.hx:1405: characters 14-30 : openfl.geom.Rectangle has no field transform (Suggestion: __transform)
/usr/lib/haxe/lib/openfl/git/openfl/display/DisplayObject.hx:1432: characters 17-46 : openfl.geom.Rectangle has no field transform (Suggestion: __transform)
```

6 days passed... :) Maybe I wrong, but how Travis CI passed that commit? Looks like html5 job is not scripted correctly. What do you think? Should we still need to create issues for these easy-to-figure-out compile-time errors?


As discussed, whilst we should support this, I would really prefer we add a `release` method as well please.


develop (DavidGoldwasser) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It's because Zelda: A Link Between Worlds produces a shader that is a bit bigger than 2MB, so I doubled it to be safe. Currently shaders are being generated much bigger than they need to be, but I'd prefer to those optimizations in later PRs. Specifically:
* If we do some upfront control/flow analysis, we don't need to compile the entire program block
* Inlining calls blows up the code a bit, but fixing this also requires ^


Should be a space in front of the comment (`// W...`).


Is it worth checking for overflow (`> 8EB` ?) Not sure.  I guess LVM will just error out trying to make a negatively-sized device.


This looks good - I must have forgotten to upload this.


It would be nice to see a `#get` definition as follows instead of passing in `None`:
```python
channel_same = self.ably.channels.get('new_channel')
```


> […] Exception applied to an event modifies event's attributes.


Comment space. Generally, you should try to use proper capitalisation and punctuation in comments --- basically, it's good Go style to make them complete sentences.


Seems crazy to have to catch the exception every time in Python 3, is there no better way to detect that it's Python 3 as opposed to catching an exception?


@majloSka, tuto classu zatial vymazem nech su vsetky stranky rovnake a neskor sa dohodneme ci to tam dat spat alebo nie.


Previous comments.


Extra spacing.


Why is the "Handlebars" parameter passed into the widget?  This gives me an error locally because the Handlebars parameter overwrites the global Handlebars JS and is left undefined when this widget is created.  If I just remove 'Handlebars' as a function parameter, it works as expected.

And sorry for not updating the require dependencies...  I'm still getting used to using require in widgets, and figured it just wouldn't work if they aren't correct.

I also now realize that we need to add the kbaseAuthenticatedWidget dependency in kbaseNarrativeAppCell.  I can do that in a separate PR.


@hvelarde porque o coverage não considera os teste robots?


@majloSka, takysto ako classu container2 aj cely div dam zatial prec.


It will be followed by TCP disconnect anyway. Unless you force close your client of course. Also this thing throws Netty decoder error, because you are not supposed to read from stream and not returning the message.


Great point! I will change it to check the status code instead. Will return an error for anything other than 200.


I have removed the default as suggested


contact_path updated


file removed


I'm trying to follow how we implemented it in other clients, that's why I didn't include meta data. How about I add an optional second parameter that will include the raw 'body' object? which includes the meta data.


Agree.


Why not just `return path.replace(base_dir, new_base_dir)`? Am I missing some corner case?
The current version looks way too complex...


@jbeezley we typically don't pass vertex data as style. Are you inclining towards passing all the data via styles now?


develop (DavidGoldwasser) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


this was your old file that i saved by calling it back up


Why this change? How is it related to API 3.0.0.? Have you discovered a certain bug with this? If yes, can you elaborate, please. I'm not quite sure but remember that this is so strange for a reason.


Delete this one, and only maintain the new one


@hbun DWMR (done with my review). This is good. Press on!


Please put spaces around the asterix here and above.


... and a space between the comment slashes and the actual text here and above.


@XhmikosR: Please check if you agree with the wording when you have time.


This change to using pipes seems to have disabled colorized output for the concurrent tasks.  Reverting to spawnOpts ['ignore', process.stdout, process.stderr] and removing the if re-enables colorized output for the concurrent tasks.

My environment is Red Hat Enterprise server 6.2 and I've used both putty and MobaXTerm to SSH to the machine and seen the same result.


Add - 184: "#define EXTRUDE_MINTEMP 5"


Import without 'as'


When I was running it without the inserted cache check, I would get
```
a1> <foo> Quoted tweet.
a0> <bar> Ha! https://twitter.com/foo/status/23405938456098435
a2> <foo> Quoted tweet.
```
Also, of course, issues where quoted tweets I'd already seen would show up again. Whether that's desirable behavior is up to user preference, I think.


Really? To be discussed.


holy shit you did it


@jessnev4life Here you can add a boolean that determines whether it is on or off


did you mean ../install here? the command is running inside the build dir


Add - 204: "#define ENDSTOPPULLUP_ZMIN  // Geoff 24_6_15"


use $PWD instead of "."? or was it intentional


I think that the https is preferred, at least read this document: https://help.github.com/articles/which-remote-url-should-i-use/
What do you think?
Also smart to use behind firewalls etc...
Regarding fnotify I think it is a good idea to try to support uart_devices feature. At least for mac and linux for now.


@Dwar3xwar DWMR. Weel done here. I'm looking forward to hearing about the progress on your app.


it is an exact copy of Test_finalphotonSelection.py
this can be deleted.
The library version of FinalPhotonSelection.py is now Library_PhotonsForGivenDMMass.py
which is more or less identical except one now reads in the DM mass


@kesla Much appreciated!


`callback(body.result, body.metadata)` seems reasonable to me


You can do more fun things: https://github.com/jomo/masquerade/commit/c616efffd1c1925090ffc6ef2da6969f9a07fec4

![screenshot](https://i.imgur.com/uP0PiDg.png)


ok will try


@Ninikitos DWMR (done with my review) Nice work here. Good. Press on!


93651760-RowPerObjectReport (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1769 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.55%25-yellow.svg)


>  the specifier expression isn't in the scope of the attribute

@quintesse nonononono this is a _lazy_ specifier!


that sounds like a fine compromise... I'll sync with Kenny on how we actually want to do this, b/c Java goes the other route:
https://github.com/algorithmiaio/algorithmia-java/blob/master/src/main/java/com/algorithmia/client/SimpleAuth.java


`'wsu_ip_map'  ` should be `'wsu_map' ` right?


@KodeKarnage accept if happy with this


Agreed i can add a better discription.


@wh1pch81n practice referencing


ooh, good catch :)


Hack is correct, this whole thing is pretty terrible.


Du hast gerade selbst ein gutes Beispiel gegeben, warum es bei Nutzung von static zu Problemen kommen kann.
Wie du das jetzt umgesetzt hast finde gut.
Wenn du noch den einen Namen anpasst hast du mein OK.


Does this fix any timeshifting issues? I remember that you touched this code last time to fix timeshifting?


fine


> Please note that all QM data is called via AJAX, so some constants are not accurate.
Can you clarify what you mean here? QM data isn't called via AJAX :)


also fine


Add 217 to 219:
+const bool X_ENDSTOPS_INVERTING = false; // Geoff 06_07_15 // set to true to invert the logic of the endstops.
+const bool Y_ENDSTOPS_INVERTING = false; // Geoff 06_07_15 // set to true to invert the logic of the endstops.
+const bool Z_ENDSTOPS_INVERTING = false; // Geoff 06_07_15 // set to true to invert the logic of the endstops.


/public is still being removed.  Should we take this out as well?  I kinda like /public not being there and looking directly for /lib


Not all of the targets start with `deis-`. When we do `deisctl ssh ordinary-panda`, it should be able to find the app container named `ordinary-panda`.


@Ninikitos Are you planning to redo the work you did over the weekend? Or are you confident tha tyou 'have it' understood?


TMI :100:


Is this needed anymore?  not sure exactly what it does.


93651760-RowPerObjectReport (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1680 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.59%25-yellow.svg)


WindowComplexManager_Speedup (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (746 of 746 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.15%25-green.svg)


Add 236: +#define INVERT_Z_DIR false     // for Mendel set to false, for Orca set to true


I forked the repo, probably will commit some issues.


I *think* this change has disabled auto-install on first run.  Haven't looked in detail, but I think install_myself is only called from within do_version_check, which is now only called if $self_update is set.


Should be "mkdir -p build/install". I resubmitted.

On Tue, Aug 4, 2015 at 2:58 PM, Brenden Blanco <notifications@github.com>
wrote:

> did you mean ../install here? the command is running inside the build dir
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/iovisor/bcc/commit/6ea7d0d7cfc354e8c855f3dec9e553bb4fd71102#commitcomment-12527959>
> .
>


- [ ] You'll need to fix these paths


_Style:
Rename any files used as libraries with more than 1 method in them as

Trash_...

Thus we have an appropriate flag for digging into future work.


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 262](https://teamcity.labkey.org/viewLog.html?buildId=264549&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:11:31
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Add 245: +#define Z_HOME_DIR 1


-Gotcha. Was using it as a placeholder till i fix the glyphicons not showing up issue w/ bower
- :D
- Done, committed.


Hm, not sure what a menist is, but you should remove the .gitignore file in this directory. In fact, you should nuke the entire directory using `git rm -r`.


- Done, committed.


- Sass compiled and added in, building on that now.


omg! @adletaw we have line ending demons again :crying_cat_face:


I'll fix these after the user-name-details taglib has been pushed in. It's still in Brian's queue waiting for review https://github.com/brianchandotcom/liferay-portal/pull/28786.


Add 250 to 255:
+#define X_MAX_POS 110
+#define X_MIN_POS -110
+#define Y_MAX_POS 113.5
+#define Y_MIN_POS -113.5
+#define Z_MAX_POS 75/2
+#define Z_MIN_POS -125/2


@Faded As @Zyres mentioned, those files are NOT contributed by the ArcEmu team. They're original works created by myself for AscEmu. I simply copied and pasted the headers without removing the ArcEmu related lines


_Style:
Rename any files used as libraries with more than 1 method in them as

Trash_...
Thus we have an appropriate flag for digging into future work


Add 272: +#define HOMING_FEEDRATE {30*60, 30*60, 20*60, 0}  // set the homing speeds (mm/min)


Changes Approved -
Print Statements Added


Edit


I don't see how this could work.  You removed the `this.notifyCurrentValue("dir")` call, so the code in `computeProperties()` won't run when the widget is created anymore.  But it needs to run.


Yeah, I wrote that pretty quickly without too much thought: wanted to just give a little note as to why some of the paths (like __FILE__) would show file inside the Query Monitor Extend plugin, and not whatever page you were on.... I'll clear that up once I get some free time.


_Style:

Import without 'as'


refs https://github.com/webpack/karma-webpack/issues/70


hi man swag


@pekohl DWMR (donewith my review). Looks good here. Talk to you tomorrow - looking froward to it.


LGTM


nice


The previous `StringBuilder::addObject` was a bit wrong sometimes on lime length limiting too.


Yep - I retested, good catch (the original version actually didn't work at all!)

```sh
bcook@AUS-MAC-1134:~$ cat test.sh
#!/bin/sh

if hash monkey; then
  echo "Ook ook"
fi

if [ ! hash squirrel ]; then
  echo "Golly"
fi

$ sh ./test.sh
./test.sh: line 3: hash: monkey: not found
./test.sh: line 7: [: hash: unary operator expected
```


@majloSka, dal som prec zatial.


I think we should add

self._access_key && self._secret_key


I thought six didn't have itervalues, but it does have it. I'll do `from six import itervalues`


93653360-ResetVarsAtEndOfWarmup (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1773 of 1778 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


should be lowercase `b` for `boolean` I think.


So we agree to delete this.


Never mind. I see what you meant. I'll fix it.


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


_Style:

Remove 'as' from import clause


Add 276 to 281:
+//#define DEFAULT_AXIS_STEPS_PER_UNIT   {78.7402,78.7402,200*8/3,760*1.1}  // default steps per unit for ultimaker
+//#define DEFAULT_AXIS_STEPS_PER_UNIT   {16*5.000*1.0101,16*5.0000*1.0154,16*200/2,760*1.0905}  // default steps per unit for ultimaker
+//#define DEFAULT_AXIS_STEPS_PER_UNIT   {62.37,62.37,1012,227}  // steps per unit for Mini CNC Mill
+#define DEFAULT_AXIS_STEPS_PER_UNIT   {63.5974*8,63.5974*8,63.5974*8,227}  // steps per unit for Mini CNC Mill
+#define DEFAULT_MAX_FEEDRATE          {33, 33, 33, 1}    // (mm/sec)
 #define DEFAULT_MAX_ACCELERATION      {9000,9000,100,10000}    // X, Y, Z, E maximum start speed for accelerated moves. E default values are good for skeinforge 40+, for older versions raise them a lot.


Ok. I will merge this but make it a bit more efficient.
I can make a case for decode_char (I saw that a fix for encode char is also needed) letting
it return false if a character can not be decoded.
Something similar for encode. Would be nice to have a flag that signal if the encoding is incomplete, or have gone wrong?


   Варианты появления Лизы:
1. Она приедет вместе с Сергеем.
2. Она будет в лагере до Сергея.
3. Странноватый. Через некоторое время после приезда Сергея, в лес рядом с "Совёнком" упадёт Союз с Лизай на борту. Скорее всего у неё будет амнезия.

    Набросок сцены в автобусе (вариант появления Лизы 2 или 3)
Сергей открывает глаза и не доумевает, что произошло. Ведь он только что заснул ( Зависит от принятого начала истории). Через некоторое время он понимает, что автобус ему кажеться знакомым. Встав и пройдясь немного по салону он замечает в окне ворота лагеря "Совёнок". Резко хватается за спинку кресла, чтобы не упасть от удивления. " Какого чёрта"- говорит Серёга не отрывая руки от кресла. Затем подходит к бардочку водителя и дастоёт от туда пачку сигарет с фразай "Кто знает, что может пригодиться в этом странном мире!?"  Потом он выходит из автобуса, обходит несколько раз вокруг него и направляется в сторону ворот.


Я СДЕЛАЛ ЭТО!!!!!!!!!!!!!!!!!!!!!


УРА!!!!!!!!!!!!!!!!!!


Встреча с лизой (день 2 )

Гг - Серёга, а не Семён.


Карты на развевание

Э- Эй, Сергей! Ты в карты играть умеешь?


This closes #2


Good


Как-то странно слились коммиты. Ну да ладно, главное чтобы ошибок не было.


Задание сценаристам (Ответ)

Надеюсь это имелось ввиду под заданием


Г - Годно


This closes #4


I suggest to implement **ContainerInterface**, see [here](https://github.com/container-interop/container-interop/blob/master/src/Interop/Container/ContainerInterface.php).


As we discussed over IM, please use int32_t on the native side with (FALSE = 0 and TRUE = 1) and then [return: MarshalAs(UnmanagedType.Bool)] on the managed side.


Add 283 to 284:
+#define DEFAULT_ACCELERATION          300    // X, Y, Z and E max acceleration in mm/s^2 for printing moves
+#define DEFAULT_RETRACT_ACCELERATION  300   // X, Y, Z and E max acceleration in mm/s^2 for r retracts


_Style:

Add a description for this file.

Currently is still blank, but this file returns a random variable which describes the Jfactor in a pile of clusters


Hmm, I guess this will work, but it's inefficient when the widget is created like a native custom element:

```js
var w = register.createElement("my-widget");
w.a = 1;
w.b = 2;
w.c = 3;
```

In this case `computeProperties()` and `refreshRendering()` are both getting called twice on widget creation, and in particular `refreshRendering()` will likely generate some DOM and then 0ms later overwrite it with something else... causing extra work for the browser.


The fork

https://github.com/SRI-CSL/whole-program-llvm

is 22 commits ahead of the travitch version.


Why would you remove the is trace enabled?


Add 308: +#define SDSUPPORT // Enable SD Card Support in Hardware Console


This is neat!


_Style:

Remove 'as' from import clause


How did you route this repository to esteebeck.com/3374, when your CNAME file designates courses.esteebeck.com?

Finally getting the hang of this—check out my "hello world" style band website: openpastures.org.


_Style:

Add descriptions for the library. (Source / Description / Args / Returns sections which are present in every library )


Ok, will do it


This is a commit from February, so this is a bit late. You can still use any released version of this cookbook, and there are still plenty of versions released that are compatible with chef 11.x (pin to < 2.0.0).


_Style:

Add new line characters between each named variable -

def Main(
   PSF = None
 ):


_Style:

remove 'as' from import


why End also have a messageFlagIgnoreUnreadable set?


_Style:

remove as from import


После перехода в MainActivity по кнопке "ввод" экранной клавиатуры, клавиатура не убирается.


oh, lol. I need to delete that CNAME file from this repository as it's really doing nothing for this site. BUT, the link you sent is looking good!


- [x] Include the new UsersAdminPortletKeys class here


_Style:

use pi in code as `numpy.pi`
Add descriptions for the library. (Source / Description / Args / Returns sections which are present in every library )
Add new line characters between each named variable -


_Content:

Remove the if name == main bit at the bottom.

Libraries are never invoked directly.


Nah, I think you should revert the revert. I think you got it right, even if for the wrong reason :)


If I use  try harder = 7 I get a constant red box in some part of the screen while playing horsez game ( see screenshot). Also after 9 lines of "GSdx: out-of-memory, purge old texture of the cache" there is one line of "GSdx: out-of-memory, texturing temporarily disabled"
![horsez](https://cloud.githubusercontent.com/assets/12788199/9074254/8af63f8e-3b25-11e5-82ad-008d05f914e1.jpg)

If I use try harder = 9 then the red box is mostly gone (only blinked once for a millisecond) and second line is more or less gone. So it will be better to use 9 I think.


Hello, dear colleagues!

Add bitcoin news website, please: http://www.coinfox.info (ENG), http://www.coinfox.ru (RU) and http://www.coinfox.es (ES) for https://bitcoin.org/ru/resources
This is news & popularization website.

Sincerely,

Igor Chepkasov
Cryptocurrency Foundation Russia, Founding chairman


No problem, I'll fix this


I wasn't suggesting anything, just a useless thing I pointed out.


I've been hacking the client side by redefining various functions from the inspector console.
This is what I get from the comments above when run against localhost which doesn't have a complete index. I'm only a few iterators away from symmetrically linking all items of a page.

![screen shot 2015-08-04 at 8 38 12 am](https://cloud.githubusercontent.com/assets/12127/9065020/4baed3a0-3a84-11e5-8745-ff645bef0ae5.png)


_Style:

Remove 'as' from import clause
Add descriptions for the library. (Source / Description / Args / Returns sections which are present in every library )
Add new line characters between each named variable


_Style:
Excellent Description Start :+1:

Remove 'as' from import clause
Add description sections for the library: (Source / Description / Args / Returns sections which are present in every library )
Add new line characters between each named variable


What are units?

Put in comment somewhere for this


Many thanks again @orhanf

You pad the training data, but not the validation data -- is this intended?


Hi!

pod --version
0.38.2

pod install
 [!] The platform of the target `Pods` (iOS 7.0) is not compatible with `MD5Digest (1.0.0)`, which does not support `ios`.

in pod file specific platform with version: platform :ios, '7.0'

With best regards,
Roman


woop - sorry my mass reorganization landed on top of you.


Yes, my local version of this code actually handles these other patterns and includes the *_1.svg frames as well.  Before I'd left for vacation I hadn't updated my private GitHub version with these changes, but I had run the code to produce the stylx for 1.1 that I submitted to the data repo.  Let me check my code in now.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.41%25-red.svg)


I remove the target directory, I mean MANIFEST.MF file, I did quick-fix, it remove some dependency


Just deleted it. Thanks a lot for the reminder, I mostly moved away from Android development nowadays, so I forgot this still existed!


_Content:

How is this any different from above:
   Library_MasterPointSourceselector.py


That bug was created in my original PR and I just stumbled across it today. So glad to see it's already been patched! Thank you Joseph!


_Style:

Rename as

Trash_....py    until this has been separated into 1 Main function per file.


typo in directory


_Content

Changes Approved


This wasn't removing code the was previously in Drill, this is a commit with all of the changes made in response to review comments. I haven't seen these checks used very frequently, and it seemed like unnecessary optimization given this only happens at drillbit startup. Maybe we should just always have guards whenever one of the parameters includes a method call, it just didn't seem necessary in this case.


Actually the fix could be inside the sign_v4() taking this in and fixing it.. properly.


Do you also need to update the associated html file?


_Style:

Remove 'as' from import clause
Add description sections for the library: (Source / Description / Args / Returns sections which are present in every library )
Add new line characters between each named variable


@sharnik
Does it look ok? It's the same as the rake task.
(In my file is not indented like this!)


I will redo everything. Just to improve my knowledge.

Sent from my iPhone

> On Aug 4, 2015, at 6:04 PM, dothework <notifications@github.com> wrote:
>
> @Ninikitos Are you planning to redo the work you did over the weekend? Or are you confident tha tyou 'have it' understood?
>
> —
> Reply to this email directly or view it on GitHub.
>


My main thought was that we already suffer from slow startup.  This looks like a non-trivial chunk of effort.  I'm guessing this call renders a giant JSON blog.  You right that it is only once (although in testing that is actually once per test).  I'm inclined to use this type of guarding if it is frequent or if it is non-trivial.


_Content:

Get rid of this name invocation


_Content:

Get rid of name invocation


Yup. Good call.  My oversight in the morning. Done now in 27584b8 .


_Style:
Remove 'as' from import clause
Add description sections for the library: (Source / Description / Args / Returns sections which are present in every library )


_Style:

Rename as

Trash_....py until functions are separable


closes #1


The reason we don't do it this way is that if a user wants to bind-mount the `/var/www/html` directory, it fails to initially copy the contents into that directory.


Thanks!


_Style: Approved


@REXDEVRU Sorry about that! Just pushed 1.0.1 with the fix!


hmm, shouldn't this use ``django.jQuery`` the same as https://github.com/stefanfoulis/django-filer/blob/develop/filer/static/filer/js/popup_handling.js#L29 does?


_Content:

Why are there no variables here?
Are they defined somewhere in a config or something?


_Content:

Remove Main invocation


@ace2nutzer, @mkaluza, this might be interesting for you. The main idea of this is resolving issue with messing screen up, when APE_25_OPP is enabled with screen ON(because now higher clocks are used). Will test this some time ..


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


_Content:

remove Main invocation    (we can then import tests in other tests for more easy use)


@keith Thank you very much!


Now webadmin can be fixed to use this.
It has:
```c++
while (!pNetwork->GetTrustedFingerprints().empty()) {
  pNetwork->DelTrustedFingerprint(*pNetwork->GetTrustedFingerprints().begin());
}
```


Print

"Test Sucess" / "Test Failure" on success or failure


_Content:

Print  "Test Sucess"  OR   "Test Failure" on success or failure


LGTM :+1:


_Content:

Remove main invocation


Looks like you could dedupe some things by setting DefaultLocale to the `en_US` value?


> As much as I would like to use stack, I can't figure out how to
  specify that the installed ghc should *always* be used instead
  of installing the ghc that matches the configured resolver.

I think that for reproducible builds this behavior is very good. I want that my various build environments are in perfect sync. So I do not accidentally have different system GHC versions on various machines. Hunting failures that are caused by this differency.

Maybe you should re-introduce stack with using the:

```
 --no-install-ghc         Disable downloading and installing GHC if necessary
                           (can be done manually with stack setup)
```

flag. That will fail the build in case the system does not provide the expected GHC?


_Content:

REmove main invocation


Invoke regardless in tests...

replace with:

main()


Gracias por el aporte, toda mejora es bienvenida ;)


I would argue you should print something on each retry. Allowing the user to spot the retry is intend, and not a misbehavior.


_Content: (Serious)

I have to read this carefully

Why can't we use 1, as the surface projection radius?


That's a reasonable point, I was just thinking about it from the other direction of avoiding the clutter where we didn't have demonstrated need for the optimization, but it really isn't that much clutter and it could make the unit tests a little faster. I can make a small PR to add it back. I actually forgot to add the "closes PR-#" to these commit messages when I added them to the merge branch, so there are a few dangling pull requests right now that I could clean up with another commit.


Where is this set on the `SearchForm` object?


Because I don't use the API client /o\


_Style: Approved


Same question for the other two templates.


_Style:

Remove 'as' from importing own libraries


Hi Brady, this is the report. it is requesting to fix lines 310 and 312. But there is nothig to fix in 312. Tested at:
Select Patient -> select encounter -> to billing view
interface/patient_file/history/encounters.php
Lines 310 and 312: $getStringForPage, which includes the GET parameters pagesize and pagestart, is
printed unescaped.


develop (DavidGoldwasser) - i386-Windows-7-VisualStudio-12: OK (2214 of 2232 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.19%25-yellow.svg)


(http://forum.zdoom.org/viewtopic.php?p=852060#p852060)

To draw a bar for a powerup, you need the `PowerupTime` keyword and the powerup giver, not the powerup class itself:
```
drawbar "HORZSPCF", " ", PowerupTime(SpaceSuit), horizontal, interpolate(10), 36, 160;
```


@youngit 유일한 객체임을 보장하는 엔티티인 경우 두개의 참조값이 동일하다고 생각하는데, 확신이 안서내요. 말씀하신대로 확실하게 user id를 사용하는 것으로 변경하겠습니다.


_Style:

Rename with capitol 'L'

'Library_FermiLineSearch.py'

While renaming :

Is this library restricted to searching for lines in stectrum, or is this capable of searching for arbitrary features?


_Content:

How does this differ from  :

Library_FermiEnergySpectrumFeatureSearch.py


ok will add


Seems that this commit messes something up?

![](https://slack-files.com/files-tmb/T074RB35J-F08KA603A-effbc06c19/westerntestsystem_2015-07-11_3_1024.png)


You can use github's api to identify out who pushed a commit:

Currently the event in question is on page 3 so you can use:
https://api.github.com/repos/amoffat/masquerade/events?page=3

It i will roll to further pages as new events come in.

```
{
    "id": "3030685599",
    "type": "PushEvent",
    "actor": {
      "id": 259113,
      "login": "amoffat",
      "gravatar_id": "",
      "url": "https://api.github.com/users/amoffat",
      "avatar_url": "https://avatars.githubusercontent.com/u/259113?"
    },
    "repo": {
      "id": 40194425,
      "name": "amoffat/masquerade",
      "url": "https://api.github.com/repos/amoffat/masquerade"
    },
    "payload": {
      "push_id": 747582733,
      "size": 1,
      "distinct_size": 1,
      "ref": "refs/heads/master",
      "head": "9b0562595cc479ac8696110cb0a2d33f8f2b7d29",
      "before": "2ff8c2e08b0be167a6794a1a03b7a41f0c459141",
      "commits": [
        {
          "sha": "9b0562595cc479ac8696110cb0a2d33f8f2b7d29",
          "author": {
            "email": "torvalds@linux-foundation.org",
            "name": "Linus Torvalds"
          },
          "message": "Enjoy!",
          "distinct": true,
          "url": "https://api.github.com/repos/amoffat/masquerade/commits/9b0562595cc479ac8696110cb0a2d33f8f2b7d29"
        }
      ]
    },
    "public": true,
    "created_at": "2015-08-04T18:44:26Z"
  },
```


@gniezen in the commit "Decreased size of USB report header" if you decrease the additional value, the driver can't fetch data records because it always returns the device header.


Any particular reason this block is readwrite?


Add "Zak":
STEAM_0:0:80172964 - "Zak/Zak The Exploiter, troll names, 5 vac bans, hack/troll groups, huge skid, stealing files"


lol


Nit: inconsistent spacing (two spaces after BOOL, no space after comma)


Nit: colons not aligned ¯\_(ツ)_/¯


_Content:

How is this any different from the other library:
Library_MasterSelectPointSources.py


hello


+ Add all members of "GmXploits", 3 more members.


class_copyPropertyList, like all of the objc runtime functions, is not recursive, which means that it doesn't include properties inherited from the superclass. Assuming you want to be able to observe inherited properties, you have to recurse up through the superclasses and call class_copyPropertyList on each of them.


And 'not' (like or and, xor...) are c++ keywords (even if not recognized as it by vs) for a very long time.
From our point of view, it is less error prone.

> On 04 Aug 2015, at 22:09, Don HO <notifications@github.com> wrote:
>
> @NN--- "!" might be more intuitive for C/C++ programmer but "not" is more visible, and since it's part of C++ now, I don't see why we don't use it. If our goal is to keep C++ programmer's old habit then no need to use C++ 11, therefore it's pointless to use VS 2015.
>
> Please Check the result as well: this commit makes Notepad++ start up gracefully! I can't believe people criticize only the code instead of seeing the benefice.
>
> ―
> Reply to this email directly or view it on GitHub.
>


not exactly, could be faster, but not always.


Hey @jonmak08,

I have rewritten the error messages to provide a more descriptive message based on our previous conversation.
Can you help me take a look to see if this format is okay?

Reference to previous conversation: 0bc8ce76dcb2ab04061515948d9f8a1d5f1a949e

Thanks!


Yes that's one approach.  However it can become complicated.  For example
one thing we would like to do is place overlays on top of arts.  This
overlay would be independent of whatever other art is running.  But in a
sense it is not really different from an art.  That's what the compound art
allows.

But I still think maybe compound art of but the right way to go.

Also a did write a shift.py art that is an interface to matrix shift.

On Tue, 4 Aug 2015 14:34 ak15199 <notifications@github.com> wrote:

>
> Thinking about it more, it might be that what you want to do is augment
> the arts with a set of effects (like hue shift, rotate, invert, etc).
>
> If that's true, then I wonder if the simplest change is to abstract that
> into a separate modifier layer that gets called after each frame is
> rendered by the art? We could independently define the frequency at which
> the modifier layer gets switched out for the next?
>
> Alex
>
>
> > On Aug 3, 2015, at 10:31 PM, Alex King <alex_w_king@yahoo.com> wrote:
> >
> > Hey Rafe,
> >
> > thanks for solving the confusion, and glad you got in touch :)
> >
> > I'm excited that this code might play a role in a burning man project,
> and I'd love to work with you on figuring out what you need and how to make
> this stuff work.
> >
> > Can you tell me about what you want to accomplish?
> >
> > Alex
> >
> > p.s. I'll absolutely cherry pick life, the driver file, and things like
> gitignore. It looks like it might take a little unraveling though.
> >
> > From: Rafe Kaplan <notifications@github.com>
> > To: slobberchops/rop <rop@noreply.github.com>
> > Cc: ak15199 <alex_w_king@yahoo.com>
> > Sent: Monday, August 3, 2015 12:43 PM
> > Subject: Re: [rop] Added production blinky configuration for fade candy
> server. (926e645)
> >
> > You are writing to Slobberchops (aka Rafe)! Patrick is working with me on
> > the forked source code project. I should explain...
> >
> > You definitely don't want to integrate all of our changes, we're working
> on
> > a specific configuration for a burning man project. I was suggesting that
> > you either cherry pick the changes that pertain to things you find
> > interesting (specifically life.py) or just copy the files in without
> > preserving the history.
> >
> > Those config files are indeed specific to the hardware we've been working
> > on. It was done that way because I wanted to avoid writing my own
> > equivalent of art.py at the time. I now understand more about what art.py
> > does and am ready to either write my own harness, which would allow me to
> > write stuff completely independently from the rop fork as we are doing
> now,
> > or contribute improvements (if you like them) to the existing harness.
> >
> > Anyway, some changes to the original rop project would make it easier for
> > someone to use that project independently while injecting their own
> config
> > and art details rather than how I did it. If you would like some
> > contribution to that effect, I'll be happy to do that separately.
> >
> > In the meantime, I could not figure out another way to communicate with
> you
> > outside of issuing a pull request :)
> >
> >
> > On Mon, Aug 3, 2015 at 9:58 AM, Patrick Ball <notifications@github.com>
> > wrote:
> >
> > > oops sorry thought I was writing to slobberchops! maybe
> blinkymirror.json
> > > should be git ignore'd?
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/slobberchops/rop/commit/926e645aea800618d372ae870d413bbe2d2e73d6#commitcomment-12497841
> >
> > > .
> > >
> >
> >
> >
> > --
> > - Rafe
> > —
> > Reply to this email directly or view it on GitHub.
> >
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/slobberchops/rop/commit/926e645aea800618d372ae870d413bbe2d2e73d6#commitcomment-12527498>
> .
>


All units are the same. the mass is in MeV


The standard naming convention would be initWithObservingObject: - init refers to the class (DPPWeakBlockObserver) not the action (observing).


WindowComplexManager_Speedup (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1264 of 1264 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.94%25-green.svg)


I would also add somewhere, that guess* and time* take into account the current available memory, so they could use a slower implementation when not enough memory is available.


MasterPointSourceselector.py is Redundant

This is the correct File.


It doesn't bother me so much, but most people would say that category methods exposed on standard framework classes should be prefixed with `dpp_` to prevent potential namespace collisions.


Made this change as per Brett's / Phil's suggestion.  I guess it worries me that it's a bit too simplistic.  It does mirror the node version, but perhaps we could update both to be better examples.  Thoughts?


All members of the group are already banned:

```
	["STEAM_0:0:80172964"] = "2S: Unknown hack,Member of hack/troll group: GmXploits",
	["STEAM_0:1:105180003"] = "Member of hack/troll group: GmXploits,Member of hack/troll group: GmXploits",
	["STEAM_0:0:29257121"] = "Shinycow, Hacks,Member of hack/troll group: GmXploits",
	["STEAM_0:0:83817006"] = "Member of hack/troll group: GmXploits,Member of hack/troll group: GmXploits",
	["STEAM_0:1:51997557"] = "Member of hack/troll group: GmXploits,Member of hack/troll group: GmXploits",
	["STEAM_0:1:27308779"] = "Dismay (stealing files), Overwatch Eusion, ban me,Member of hack/troll group: GmXploits",
```

STEAM_0:0:80172964 is already in there for a 2S ban. I've updated his reason :)


nit: multiline ifs without enclosing  { } are considered poor form.

Remember "goto fail"?


@gavinking I tried them out, both of them, lazy and eager and none of them have the (toplevel) attribute as their scope but the package. So in both cases there's no way to get at the native annotation specified on the attribute.


This is supposed to be The test of Library_FinalPhotonSelection.py


not in this instance since it is a test


FixLinksInDocs (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1784 of 1784 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It looks like this API assumes that observeValueForKeyPath: will be called from the main thread, and I'm guessing it's not thread safe? Maybe NSAssert([NSThread isMainThread]) just to make that clear.


@merk FYI, you don't need to do such change. The value of the ``dev-master`` branch alias only matters in the master branch itself. Composer will not read its value in other branches


Ah, but actually, there can be a valid selection which isn't a GlobalItem. It's because GlobalItem derives from GlobalObject. There are items selected which are GlobalObjects but not GlobalItems, but IsUsableInField() is a specialization of a GlobalItem. If the object selected is a GlobalWeapon or perhaps GlobalArmor, the cast fails - however, these are always "usable in the field" because this is one of the ways the item can be equipped.

The only cases where it might be worth considering to play a sound on failure even when the cast fails are if you happen to have a GlobalSpirit object (which doesn't seem to be used) or if you have a GlobalObject in the list which is not one of the other types. However, all the items I have found are all GlobalItems, no bare GlobalObject things around, and so all the ones that you would expect to hear the sound on, I do in fact hear.


Aye, you are correct. I have updated INSTALL.md accordingly.


I don't really understand the point of this method. Why are you checking that propertyNames are strings? When would they ever not be? And if they were, it would be a programming error, right? So it should throw an exception, not fail silently.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1266 of 1266 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


As of Xcode 6.4 (or is it 7 beta?) you can use generics to specify that this is an `NSArray<NSString>` which might be a better way to ensure people don't override it and return random objects instead of strings :-)


Should we go ahead and also add the production version?


The formulation “exception applied” is just weird in this context.


Oh yeah, no problem. I made a todo list of things I want to change, in my "issues". It would be well worth refactoring this part to try to eliminate the sketchy _object field altogether, but for now this makes it work.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


We don't rely on this file anymore.

We replace this with the

Utility_AstronomyFermiEventsAndPointSourcesWithGalaxyGroupsLineSearch.py

below


_Content:

Need to go through this line by line


great work as always :-)

But to be honest for me i don't care so much about the APE/DDR States.. for me it messes in both single cases with screen ON.. no matter if only APE25 or only DDR25.. so i just use APE/DDR25 for screen OFF and APE/DDR50 for screen ON and everything is fine. The Difference in power consumption is max. 5% and the delay is just too big .. it's not fast like normal CPU freq. switching .... if i sort the speed of freq. switching from fastest to slowest:

1. LiveOPP
2. MaliAutoBoost (delay 0)
3. DDR_OPP
4. APE_OPP

the slowest is ape_opp because it changes too many freqs at the same time .. also it change the GPU freq from an very low state to an suddenly high state.. that all cost us worsening in response-time and laggs.

btw: speaking about delays.. why u guys are using such big delay for LiveOPP ?

https://github.com/ChronoMonochrome/Chrono_Kernel-1/blob/android-3.0/drivers/cpufreq/dbx500-cpufreq.c#L125

https://github.com/mkaluza/Samsung_STE_Kernel/blob/master/drivers/cpufreq/dbx500-cpufreq.c#L125

LiveOPP is now quite stable.. (of course with right voltages) so that we can use lower latency:

https://github.com/ace2nutzer/Samsung_STE_Kernel/blob/3.0.101/drivers/cpufreq/dbx500-cpufreq.c#L125

That makes the Phone much more faster in response and reduces laggs a lot .. in other words, u can't "feel" it anymore when the CPU freq is switching .... just a Tip ;-)


TeamCity xBIM :: Xbim Essentials :: Release [Build 66](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2191&buildTypeId=XBIM_XbimEssentials_Release) is now running


Start und Stop scripts für den TeamSpeak3 MusicBot von ts3musicbot.net


TeamCity xBIM :: Xbim Essentials :: Release [Build 66](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2191&buildTypeId=XBIM_XbimEssentials_Release) outcome was **SUCCESS**
Summary: Running Build time: 00:01:08


[HINT HINT HINT](https://gitlab.com/)


I'd change this to ```scope :ordered_by_reverse_created_at, ->{ reorder('created_at ASC') }```.


Can we set `is_channel_backed` for all `@level.channel_backed?` levels?  It would be good to only have one place to update the list of levels that need a channel.


@maxxtepper looks good to merge.


Reviewed by Tyler and Daniel


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1272 of 1272 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think this was a great commit!


You need to just add contact. Not change all routes to herokuapp


I don't think that `LockWindowUpdate` does what you *intend* it to - `SendMessage(handle, WM_SETREDRAW, FALSE, 0)` probability is closer to it.

Raymond Chen has a series of four articles on `LockWindowUpdate`, which are great reading on the matter:

- [What does LockWindowUpdate do?](http://blogs.msdn.com/b/oldnewthing/archive/2007/02/19/1716211.aspx)
- [How is LockWindowUpdate meant to be used?](http://blogs.msdn.com/b/oldnewthing/archive/2007/02/20/1726880.aspx)
- [With what operations is LockWindowUpdate not meant to be used?](http://blogs.msdn.com/b/oldnewthing/archive/2007/02/22/1742084.aspx)
- [Final remarks on LockWindowUpdate](http://blogs.msdn.com/b/oldnewthing/archive/2007/02/23/1747713.aspx)

...and a fourth, which helped me diagnose some annoying performance issues in the past:

- [Speeding up adding items to a combobox or listbox](http://blogs.msdn.com/b/oldnewthing/archive/2004/06/10/152612.aspx)


> this commit makes Notepad++ start up gracefully
This change is excellent!
Who wondered and coded it?
Any plans on making this improvement also for shutdown process? (slow tab-closing effect looks the same as was happening on startup)

Imo, using 'not' looks easier to read when it is followed by empty(): `not cmdLineParams->_easterEggName.empty()` (not empty).
Although, imo, in PHP it is even easier: `!empty(notEmptyThing)` (except I think it can't use "not").


Thanks to thehacker911 for Graphite Flags ;-)


I think it should be TRUE === empty($templatePathAndFilename)


Thanks! I'm glad I can help.


По ідєї треба використовувати const замість #define. #define - це ще від C, бо там не було const взагалі. По суті #define працює через препроцесор і просто підставляє текст перед компіляцією.


nice.


Actual disabling xtrace got lost here...


`if c != "#" ` you mean?


Does this work? I think you need the `+`s at the end of the lines


It is on my list to improve this addon, I'm just working through a bunch of other addons first.


Do you know you can put `closes #4` in the commit message?


I recommend changing the AddOutputFilterByType line to:
AddOutputFilterByType DEFLATE text/html text/plain text/xml text/css text/javascript text/x-js application/x-javascript application/javascript

This compresses merged js files in Magento.


@kriskowal @Raynos  ok, so I was mistaking this for some sort of 'sub-service' routing key ( which, yes, I do want and Hyperbahn should support ). I think @mranney is working on some proposal for this kind of routing?

What this really is is you adding custom headers to the protocol to make the implementation of ringpop easier ( and theoretically more performant if the shard key is in the protocol instead of in the body of the message ).

Why is this documented in the protocol? Why can't these just be TChannel headers that RingPop knows about but we don't make 'official' headers.


This could just be:
```ruby
work_days.push({
  :name => person,
  :date => get_date(date, hours)
})


The else should be on its own line.


I understand that this patch uses these functions to expose properties of the underlying data to the planning context, and in the best cast will not actually evaluate the function on the values coming out of hbase, but this is not the most efficient way to implement these functions. The eval method will be run for each value of a table that this function is called on, which means this byte[] will be re-allocated on heap once for each value processed. If you need to put the data on-heap, this is okay, but this byte[] should added as a class level member of the function with an @Workspace annotation. This way it only needs to be allocated once in the setup method and can be re-used in the eval method without re-allocation.


Credits: glewarne!!


This is a place holder for all Oracle Scripts.


Let's put the same version as we have everywhere.


Angular is barely being used here. Let's remove it if we're going to be rendering whole pages from PHP.


or make it a turnery operator:
```ruby
date = (i < biweek[1] ? week_1[j] : week_2[j])
```


let's put all of our database generation in one php file


This kinda crap is why github is not an appropriate place for real-world projects, Security, enforcement and OPSEC at an all-time low across the board.


this file could go in create_db.php


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1272 of 1272 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ooops. Let's get rid of this.


Let's get rid of this, too.


@halindrome see https://github.com/opencreds/website/blob/master/specs/source/common/common.js#L75-L120 for how I updated the code for Credentials use. There might be a better way to do it, but this seems to work.

Note that definitions which reference other definitions remain, even if they're not used elsewhere; small price to pay.


Minor nit, is it any different from declaring i and len inline to the for loop?  Or is there some style guide which disallows that?


Nice use of regex!


similarly here, is there a reason we're assigning a variable to this instead of passing it directly into setupSubscription?


You don't actually need to assign and return this. Just say:
```ruby
Time.new(year, month, day, hours)
```
Since the last thing that is evaluated is the return value of a function.


LGTM


好像恢复了吧


These CI "failures" don't make sense to me -- maybe something wrong in the CI system?


Erste Release Version


Hi. Thanks for the pull request. As a rule of thumb I try to avoid adding redundant attributes.

Currently the [standard way](https://python-chess.readthedocs.org/en/latest/core.html#colors) to invert colors is `color ^ 1`.

I am not 100% happy with that, though. I've been considering to switch to a boolean value `white`. Then `black` is just `not white`, as expected. No crazy XORing required. Thoughts on this?


We should have an opt out if they don't want something with an on/off like we do already in RxJS with Rx.config.useNativeEvents


since the point of this change is to encapsulate grpc_channel, consider leaving the original forward declaration, and writing below:

- (instancetype)initWithChannel:(struct grpc_channel *)unmanagedChannel
   hostName:(NSString *)hostName NS_DESIGNATED_INITIALIZER;

below. Save the #include <grpc/grpc.h> for the headers that need it.


Better, but still has an issue; `LoadIcon` can fail, and the `NULL` handle is then passed to `trayIconControler` (misspelled, by the way). Later, when [someone else calls `_pTrayIco->doTrayIcon`](https://github.com/notepad-plus-plus/notepad-plus-plus/blob/11a51aa05e794f59bba85dfed0b69008010da946/PowerEditor/src/WinControls/TrayIcon/trayIconControler.cpp#L50), they'll invoke undefined behavior, and [it'll be at a distance](https://en.wikipedia.org/wiki/Action_at_a_distance_(computer_programming)).


Could there be a perf gain to creating a new Subscription for each type with addEventListener, on/off, etc instead of the closure scope capture of the removeEventListener?


Interesting question. Because in fact the notifies would not work if the file is not present, you would want to do both. Perhaps it would be more useful if we set `action :nothing` here and used a `ruby_block` to notice the `/var/run/reboot-required` file...?


Nice - since this is used/referenced everywhere, this should improve codegen! (measurably?)


That can just be squashed into the other commit.


Same comment as before with handling arguments with `fromEventPattern`


I'm not that familar with node, but after a short review some points:

- why not twig: https://github.com/justjohn/twig.js/
- you use node at the server side, so why no typescript? The tsc compiler creates clean (and working ;)) javascript code and typescript provides all necessary OO features. Javascript has a lot of design fails, but you wont have such problems with typescript
- https://github.com/benbieler/SocialDocs/blob/master/app.js#L21-L42 this is duplicated code. You define a route and render sth into the response and do some actions. I'm not familar with ExpressJS, but there should be ways to abstract that
- https://github.com/benbieler/SocialDocs/blob/master/modules/operations.js Abstract this in a class which is responsible for the login and another one which is responsible for the registration. -> https://en.wikipedia.org/wiki/God_object
- https://github.com/benbieler/SocialDocs/blob/master/modules/operations.js#L14-L19 why creating connections in the login? You could do this in a factory and inject a working connection (or a model manager) into the operations object.
- https://github.com/benbieler/SocialDocs/blob/master/modules/operations.js#L21 the business layer should not fetch stuff from the http request (a controller is actually responsible for that or a symfony-like param converter: http://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html)
- https://github.com/benbieler/SocialDocs/blob/master/modules/operations.js#L22-L25 why do you fetch the user two times? It should be enough to fetch the user one time and compare the credentials after that (this will cause a performance leak)
- https://github.com/benbieler/SocialDocs/blob/master/modules/operations.js#L56 redirecting should not happen in the business layer.


does this mean the backtrace includes all of the logging? I was the one who moved this into the top level function registered as register_error_handler in the old code. ;)

Is it possible that the trace for non-exception errors is set by monolog, or could be done at a lower level?


Did you mean
`FALSE === empty($templatePathAndFilename)`?

The conditional statement must not be executed if there is no template.


i find TFCond_BlastJumping more reliable to use.


It should be a little bit squishier than that since we don't know what the selector will be getting if it gets the full args...


Um, don't know why it's saying I changed a bunch of lines I obviously didn't touch. The only thing of note is on line 96. Also apparently "!!" gets replaced with "git status" in the commit message


Call it `Unit` - singular. That way you can declare a variable as: `Unit my_unit_;`


yes, my mistake.


These are here to divide event handlers from methods, and member variables. They shouldn't be removed - or if you think they should be remove, we should talk about removing them completely from all of PulseView in a separate commit.


This should be `Unit unit_;`


Much more readable! :)

Maybe:

```
SyncInfo() = default;
~SyncInfo() = default;
SyncInfo( const SyncInfo& ) = default;
SyncInfo& operator=( const SyncInfo& ) = default;
```
...would be a good idea? Otherwise, `= delete`ing the copy constructor/assignment operator might be?


Good catch.


Needs a comment that this initializer will take ownership of the channel, grpc_channel_destroy() the channel when this object is dealloc'ed

(What happens if the same grpc_channel is passed in the initWithChannel: to two different GRPCChannel instances? is it legal to grpc_channel_destroy() it twice? is the channel still valid after the first destroy? Is it a programmer error to pass the same grpc_channel to multiple GRPCChannels?


Tests?


GitHub (can) nuke indentation. Have you checked the raw source file?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (746 of 746 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.14%25-green.svg)


Nah, just habit.


again, habit


r+


...could `checkFileState` be `const`ified?


We should just use the sample-rate value in the `Segment` object. If the value is zero, then the sample-rate is unknown.

Also, it doesn't make sense to have this flag in Session, because in future we may support multiple captures coming from multiple devices in which case it would be a mixture of known and unknown. A better way would be to look at all the Segment objects on screen, and if any of them are missing a sample-rate, then show the time in samples.


You can use the `?:` operator here. Also some extra white-space hanging around.


Ebenfalls #18 Weiterspielen bei zurück button innerhalb Suchergebnis gefixt


I want to keep capnproto-rust building on the stable channel. I think that means we need to wait approximately six more weeks before we can switch over to the new `join()` function. :/