Because neither me nor zikula seem to care to support old PHP versions.

If you run an unsupported version for a system that you don't touch, keep running the same version of Doctrine 1 that you have been running previously. Like a frozen time bubble.

If you are still working on the application, and adding new features, then I recommend make it support PHP 5.4.

Finally, if you are still working on your legacy application and are not willing to migrate it to PHP 5.4, you are welcome to maintain a fork of Doctrine library and keep it supported for old PHP versions. If you do it consistently, I am not against including those patches in this version.


sad


Shouldn't this be in the previous commit?


Congrats. :clap:


Sort imports


minor: I would put the public method first


:fireworks: :cake: Thanks, and congratulations! :cake: :fireworks:


authorship?


Authorship?


Agregado


Very nice. Excellent work.


Why use an interface and implementation class ?


Sorry to be pedantic but push it to the previous commit.


Because Rudolf (from GPS test) told me it was unreliable on Galaxy S4 with KitKat.


again authorship?


thanks for kanging my commit :D


@fesor should this be `InlineContainer` instead of `AbstractBlock`?


I suppose you could continue to responsibly run those versions on CentOS 5
or 6, presumably among other distros that are maintaining them for security
until future dates.

On Fri, Aug 28, 2015 at 12:02 PM, Denis Sokolov <notifications@github.com>
wrote:

> Because neither me nor zikula seem to care to support old PHP versions.
>
> If you run an unsupported version for a system that you don't touch, keep
> running the same version of Doctrine 1 that you have been running
> previously. Like a frozen time bubble.
>
> If you are still working on the application, and adding new features, then
> I recommend make it support PHP 5.4.
>
> Finally, if you are still working on your legacy application and are not
> willing to migrate it to PHP 5.4, you are welcome to maintain a fork of
> Doctrine library and keep it supported for old PHP versions. If you do it
> consistently, I am not against including those patches in this version.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zikula/doctrine1/commit/45dc6208408b2e049712000a3a8f54c242e57de2#commitcomment-12951065>
> .
>

--

*THOMAS BOUTELL, *DEV & OPS
P'UNK AVENUE | (215) 755-1330  |  punkave.com


Easier to understand, so +2! ;)


weeeeeeee


@rimey: I still see types being used in a few places. See results from grep below:

cluster-insight/collector$ grep -n types *py

collector_error.py:31:import types
collector_error.py:38:    assert isinstance(message, types.StringTypes)

collector_test.py:24:import types
collector_test.py:68:    assert isinstance(ret_value, types.StringTypes)
collector_test.py:69:    assert isinstance(fname, types.StringTypes)
collector_test.py:135:    assert isinstance(type_name, types.StringTypes)
collector_test.py:155:    assert isinstance(type_name, types.StringTypes)
collector_test.py:359:    self.assertTrue(isinstance(health, types.StringTypes))

context.py:44:import types
context.py:259:    assert isinstance(output_format, types.StringTypes)

simple_cache.py:69:import types
simple_cache.py:144:    assert isinstance(label, types.StringTypes)
simple_cache.py:189:    assert isinstance(label, types.StringTypes)
simple_cache_test.py:24:import types
simple_cache_test.py:143:    assert isinstance(name, types.StringTypes)

utilities.py:23:import types
utilities.py:61:  return isinstance(x, types.StringTypes) and x
utilities.py:338:    assert isinstance(name, types.StringTypes)


I just want it to be permissive all the time


:tada: Nice work!


wow, this whole source is kanged...  I highly suggest you fix this because it is unacceptable!


Если ты будешь делать «резиновую» версию, то одной картинкой этот блок сделать не получится, т.к. фоновая картинка должна быть отдельно от надписи: при сужении экрана фон обрезается, а надпись не масштабируется. То есть нужно сделать две картинки.

Второй момент: картинку с гоарми можно в общем-то сделать фоном. Картинку с надписью можно сделать либо фоном и в блок поместить текст «Welcome … sucks!», либо кратинкой `img` и этот текст прописать в alt.


@todivasudha This file is redundant in this context. Also if you need this, you can add this in CMakelists.txt. Don't need to add here.


seems like we have an sql injection here, no?


历史会铭记这一时刻


@yehudasa My current understanding, user was S3 key, subuser was swift key. In original code when not specified key type the default value was s3(in key checkop). So the subuser operate must have --key-type=swift otherwise may failed e.g. rm subuser with --purge-keys. I think may improve this. more over, when create user and subuser at the same time by one command, need to create a s3 key for user and a swift key for subuser, so i modify the key type by context.


It would be better to leave the user with an option to set it permissive (e.g SelinuxMode changer), but its your kernel thus your decision ;)


should be removed.


Wow! I can't believe I overlooked that. I stared at it for like an hour! The first move might be buggy because of the precomputing it does on mouse down.


GetTypeInfo() was the key here.


@michaelcahill, staring at this error path in `__wt_row_modify`: https://github.com/wiredtiger/wiredtiger/blob/e7a76d1ca2df2e9aeec691eed3c37ed0b2b5df33/src/btree/row_modify.c#L163

The `cbt->ins = NULL;` was added a couple of years ago, as part of e7a76d1, and it doesn't appear in the column-store version of the code. Any chance you remember why it went in?


Эти картинка и другие в features — декоратвные. Их нужно сделать фоном, а контейнерам дать уточняющий класс типа features-item-food или что-то в таком духе, чтобы затем присвоить фон в CSS.


I think you could omit the version


just to quickly get me able to build...


No, good old SPSA tuner by Joona ... but with a custom book and a slightly modified SF. This is after ca. 42k of 100k iterations to see, if my setup is working. Coincidentally, I'm almost tuning the same values as Lucas did.


Yay!


just had to add this using statement


потому что `imperavi redactor` сохраняет размеры с помощью инлайн стилей, а после синка html кода редактора, `sir-trevor` санитайзит контент и удаляет теги `style`


I tried some other trick but didn't work. So this is the only way around. Btw u got it right, it's my kernel xD


![screenshot0118](https://cloud.githubusercontent.com/assets/12555146/9551204/dcb1748a-4dd9-11e5-8035-a88657a42672.jpg)
error. I can not add friends with bot.


Все равно спасибо за то что смотрите мой код )


Can we get this patch into the upstream project?


fixed with https://github.com/thelastpickle/zipkin/commit/efbed5b6684dc54d37197432789401aa55cc714d


This version breaks OpenVPN asking passphrases via systemd. Previous behaviour:
```
# start openvpn-lb
Enter Private Key Password: ***
```

New behaviour:
````
# start openvpn-lb
Job for openvpn-lb.service failed. See "systemctl status openvpn-lb.service" and "journalctl -xe" for details.
```
and the journal shows:
```
Aug 28 18:02:05 mandark openvpn[11259]: Fri Aug 28 18:02:05 2015 OpenVPN 2.3.8 x86_64-unknown-linux-gnu [SSL (OpenSSL)] [LZO] [EPOLL] [MH] [IPv6] built on Jan 01 1970
Aug 28 18:02:05 mandark openvpn[11259]: Fri Aug 28 18:02:05 2015 library versions: OpenSSL 1.0.1p 9 Jul 2015, LZO 2.09
Aug 28 18:02:05 mandark openvpn[11259]: Fri Aug 28 18:02:05 2015 WARNING: No server certificate verification method has been enabled.  See http://openvpn.net/howto.html#mitm for more info.
Aug 28 18:02:05 mandark openvpn[11259]: Fri Aug 28 18:02:05 2015 NOTE: the current --script-security setting may allow this configuration to call user-defined scripts
Aug 28 18:02:05 mandark openvpn[11259]: Fri Aug 28 18:02:05 2015 neither stdin nor stderr are a tty device, can't ask for Private Key password.  If you used --daemon, you need to use --askpa
Aug 28 18:02:05 mandark openvpn[11259]: Fri Aug 28 18:02:05 2015 Exiting due to fatal error
Aug 28 18:02:05 mandark systemd[1]: openvpn-lb.service: main process exited, code=exited, status=1/FAILURE
```

Unless we can fix this we should revert to 2.3.6 or maybe 2.3.7 (the release notes for 2.3.8 suggest that's where the problem was introduced).


The naming does not necessarily come from the input file syntax, it comes from how objects are named in Factory::create. The moose convention is to use the System/name (e.g., "Postprocessors/my_pp").

Of course, when using actions the name passed into the create method can be something completely custom, so there is not any way of dealing with that. However, when I updated constructors I followed the above convention as much as possible.

In the future I think we will need to change the convention slightly. Now, in MOOSE we are trusting that the convention be followed, for example in a custom action the following must be done:

```C++
_factory.create("MyCustomPostprocessor", "Postprocessor/my_pp", object_params);
```

However, trusting the user to follow the convention is a bad idea. We need to do something as follows:

```C++
_factory.create("MyCustomPostprocessor", "my_pp", object_params);
```
Then inside Factory::create the name would be prefixed with the base name (the name in InputParameters::registerBase). So, then the object name the users would be "Postprocessor/my_pp".


fittedSpline_and_3rdDerivative, is one of the maion files.
It has the smoothing of the spline, Reccurence of the knots ,
The reccurence of the Knots , gives straight edges . which was not there.
It also contains the plot after optimisation.
As the lamda value increases the smoothening increases.
If the number of knots are increased the smoothening as we seen clearly.


are there other characters ?


Yay! Great work!


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1253


101064176-AddCO2DemandControlledVentilation (lgu1234) - x86_64-MacOS-10.9-clang: OK (1792 of 1793 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


after compile this the version is always "1.0.0"


Чтобы не создавать каскад в CSS для стилизации этих `reason-item`-ов, им нужно дать дополнительный класс, который скажет, что они выглядят по-другому нежели первые две причины. Типа `reason-item-flat` или `reason-item-additional`.


efficiency wise they're currently more or less the same (timing both functions (and just those) + startup of python ~0,03 - 0,04 sec). Array seeking the "python way" isn't slower und could gain the upper if there will be more elif added
And the above was just a method. To reduce the string manipulation and follow your initial, it would look like that:
```py
def serverURL(domain):
    tld = ["de", "pl", "fr", "nl", "it", "ru", "ca"]
    tld_co = ["uk", "in", "jp", "kr"]
    if domain in tld:
        return "www.google."+domain
    elif domain in tld_co:
        return "www.google.co."+domain
    return "www.google.com"
```

homebrew? None at all


Thanks Soby. Will wait for more comments from Dan or Achin before pushing a
new PR.

On Fri, Aug 28, 2015, 9:22 PM soby-mathew <notifications@github.com> wrote:

> @vwadekar <https://github.com/vwadekar>
> The code looks good to me. Probably Achin might take a look in the
> following week.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vwadekar/arm-trusted-firmware/commit/d6e77ed3f710930f579a8fccb27707c8017063f1#commitcomment-12950845>
> .
>


@kylog x86_64 isn't a supported arch for solaris packages. we get to choose from sparc, i386 and ppc when building solaris 10. `uname -p` returns i386 on the pooler template, but it has 64-bit support built in.


В принципе `reason-row` тут может и не пригодиться, но пока пусть останется ))


LGTM


FYI this seems to be reverting some changes presently on master...


Ещё один момент: первый две причины у тебя `section`-ы, а эти три — дивы. лучше делать единообразно по-моему.


4695_hpwh_equip_seq_num (nmerket) - i386-Windows-7-VisualStudio-12: OK (1813 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'd rather pin this to a version we *know* it works with. If we want to update it to the latest, that's fine, but I'd rather be at least a little explicit. ~3.0.1 for example?


17971 - Compare Rack Web Servers for Ruby applications - ALL DISTROS.html

Just use the singular "Rack"


The log suggests it might be solved by some `--askpa...` parameter.


@aVadim483 это вылезает, например, на странице `/profile/test/created/photos/` в аякс-запросе `/ajax/image-manager-load-images/`, соответственно, мешая нормальной работе js.


`trim` should not remove nodes with empty TextNode (which it currently does). If a node consists of whitespace only, the string should be trimmed but the node alone should be preserved IMO.


Should just use "Rack" here.


I'm not talking about way of contributing. I mean that we should be cautious for dramatic changes. As you know, vim-dev doesn't experiences for PR based contributing. So we still not have rules, license agreements or something others. Ofcourse, by any chance, If we need to move repository into another one (i.e. not github), commit-message will be broken. github is too younger to compared with history of vim. Ofcourse, I love github and PRs.


Using types.StringTypes is current best practice.


I would increase greatly the number of uuids (1000, 10000 ?) created and make the assertions in a second loop


Get git


Related to https://github.com/Loreinator/Shuffle-Move/issues/45


oh just the typo, right?


Just collapse these few lines into ```error = mlt_properties_get_int()```.
Also, change the property name to "melt_error."


Вот это вот «Поиск гостиницы в Седоне» — это кнопка (см. ТЗ), т.е. ещё лучше сделать активным элементом (ссылкой), который в случае отключенных скриптов будет вести на другую страницу.


@RyanRiffle It took me a while too. I had to open the debugger and set a breakpoint to inspect the stack :)


4695_hpwh_equip_seq_num (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (759 of 759 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.36%25-green.svg)


Часть формы с полями ввода нужно обернуть будет в отдельный контейнер. Эта часть по ТЗ выезжает по клику на кнопку «Поиск гостиницы».


Actually, if it's minimum length, "?" stands for 0 or 1 characters no?
http://www.regular-expressions.info/optional.html

The "+" character is "at least one".

http://www.regular-expressions.info/repeat.html

My tests all still pass with the question mark removed:

>
Running Benchmark using agents in top-1000-last-7days.txt
Benchmarking browscap-php ...	126.13676secs 	90.25MB
Benchmarking crossjoin-browscap ...	13.581031secs 	4.5MB
>
Running Benchmark using agents in top-200-last-24.txt
Benchmarking browscap-php ...	24.658653secs 	35.25MB
Benchmarking crossjoin-browscap ...	2.6613709secs 	1.75MB
>
Running Benchmark using agents in ua-list-all.txt
Benchmarking browscap-php ...	71.190841secs 	35.25MB
Benchmarking crossjoin-browscap ...	4.0831820secs 	2.5MB
>
Running Benchmark using agents in ua-list-100-sample01.txt
Benchmarking browscap-php ...	14.776180secs 	35.25MB
Benchmarking crossjoin-browscap ...	0.8073611secs 	1.25MB
>
Running Benchmark using agents in problem.txt
Benchmarking browscap-php ...	0.1346449secs 	35MB
Benchmarking crossjoin-browscap ...	0.0212399secs 	0.5MB
>

And only diffs between browscap-php and crossjoin were the two I've mentioned before.


oh, yes. But I got error when keeping "/*! */".


The full name shouldn't come from the name passed in like that at all.

Look at how I did it in `Restartable`: https://github.com/idaholab/moose/blob/devel/framework/src/restart/Restartable.C#L29

There is a `system_name` that is passed in from the constructor of the base class for each system (for instance from `Kernel`: https://github.com/idaholab/moose/blob/devel/framework/src/kernels/KernelBase.C#L58

Then the "full name" (ie `Kernels/my_kernel` is built from the `system_name + short_name`).  This ensures that each object's full name is unique and properly built.


I tried, adding `askpass` to the configuration file didn't work.


great! thanks for the info Reman


You can see where the full_name gets constructed here: https://github.com/idaholab/moose/blob/devel/framework/include/restart/Restartable.h#L231


@indutny why is this needed ? Switching threads is very slow on iOS


Эту карту тоже лучше сделать фоном в дальнейшем, т.к. мы её будет делать интерактивной и отдельный элемент будет мешаться в контейнере.


too bad you forked it this way, now it's quite hard to merge with Songkick ever again :(


Please add a more descriptive commit message explaining the assumption and the potential side effects of this change.


Oh wow, I don't know how I missed this in my pull request :( Good catch!


Unrelated to this pull: Having said all of that, I'm not sure what gcc defaults to building on solaris 10. It may be 32-bit. If so, we could try out adding -m64 to cflags/cxxflags.


@greezybacon For some reason `setstatus` will not use `closed` and must be `3` (the id of closed)


develop (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This is what I plan on changing it to, but just use the base name set in
the base class InputParameters. This way the user doesn't need to specify
anything other than the custom name they provide.

On Fri, Aug 28, 2015 at 10:21 AM, Derek Gaston <notifications@github.com>
wrote:

> The full name shouldn't come from the name passed in like that at all.
>
> Look at how I did it in Restartable:
> https://github.com/idaholab/moose/blob/devel/framework/src/restart/Restartable.C#L29
>
> There is a system_name that is passed in from the constructor of the base
> class for each system (for instance from Kernel:
> https://github.com/idaholab/moose/blob/devel/framework/src/kernels/KernelBase.C#L58
>
> Then the "full name" (ie Kernels/my_kernel is built from the system_name
> + short_name). This ensures that each object's full name is unique and
> properly built.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/idaholab/moose/commit/eac557adc4a0fd8f702dff60126544396c6ed173#commitcomment-12951470>
> .
>


I am on lunch break right now, so im working on it some. Like I said I think the moving might be a bit buggy because of the precomputing it does in the onMovingWindow.


@chmod666org done :)


Lol ok someone revert this idk how


Эту ссылку можно включить внутрь параграфа.


@pierre but here we use `mysql` command, and it's only for mysql. If we already support PostgreSQL now, I can make it support PostgreSQL.


So if the user wants to customize their VCR instance, they would do that here rather than as methods in their TestCase class, right?  Maybe by instantiating VCR ahead of the TestCase for clarity.

What about customizing the cassette name? I guess there could be args to `test_case()` that would be passed on...


I edited the wrong bit :/


it does not matter how many uuids are generated, this test does not ensure anything
so, let's rather minor CPU and build time consumption


`re` is a Python std lib package, `lxml` is not. Sort them accordingly please.


Use the same type of triple quotes everywhere (`"""`).


typo in `Patch`


Wow, what a weird way to handle an edit button!
It should either open a new page: simple A _href
or the form should be embedded within this page (form = self.update()) & the button unhides this with JavaScript


@miigotu
strange as obj is always None but the filename has the indexer id:

```
2015-08-28 03:53:22 WARNING  SHOWQUEUE-REFRESH :: Unable to retrieve image to (obj is None) to save in /home/osmc/SickRage/cache/images/thumbnails/289108.banner.jpg, skipping
2015-08-28 03:53:18 WARNING  SHOWQUEUE-REFRESH :: Unable to retrieve image to (obj is None) to save in /home/osmc/SickRage/cache/images/289108.banner.jpg, skipping
2015-08-27 03:53:22 WARNING  SHOWQUEUE-REFRESH :: Unable to retrieve image to (obj is None) to save in /home/osmc/SickRage/cache/images/thumbnails/289108.banner.jpg, skipping
2015-08-27 03:53:21 WARNING  SHOWQUEUE-REFRESH :: Unable to retrieve image to (obj is None) to save in /home/osmc/SickRage/cache/images/289108.banner.jpg, skipping
```


What is your time control ?
And in your var file, what value(s) for the 5th and 6th parameter ?
Thanks !


Parameter `defaultA` and `defaultB` don't exist and so this comment seems out of place.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 42](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=126&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:40:27


`):` should be on a separate line to distinguish each condition.


Correct variable name


blah


Again, parameters `defaultA` and `defaultB` don't exist and so this comment seems out of place.


https://github.com/machinekit/machinekit-docs/pull/30
https://github.com/machinekit/machinekit-docs/pull/31

Not merged them, but put them alongside with an explanation which might get a bit of broader attention


The real control logic is going to need to be able to get more than just _t and a point.  I am trying to understand how that will work and change things from this basic version.


You don't have to check if `namespaces` is True, the `in` condition will take care of that.


@mrbannon There is an issue with undefined attributes of the model.
![image](https://cloud.githubusercontent.com/assets/11790432/9551608/3384eaee-4d80-11e5-99c8-8d0b3a2380c3.png)


C# source files seems to be using a mix of tabs and spaces. Would be great if you could switch to just spaces like the rest of the project. Makes it also easier to review online (code has indentation inconsistencies as it appears now).


Shouldn't this be `cache.put('nest', data, DEFAULT_CACHE_MSEC);`?


You might want to remove this commit to reduce the total number of files by roughly 140 :)


I've been waiting almost 2 years for my pull requests on Songkick to be addressed. I forked in this manner to avoid using their name everywhere.

Were they to start actively maintaining the gem again I would happily abandon this fork in favor of the original.


Fix documentation of params. It should be formatted as:

    :param str path: <description here>

Same goes for other params.


Funny or maybe sad that I was deploying my code to our production server after testing the 0.0.5 on dev just during the time you bumped the version to 0.0.8. That lead pip update to fail while the server was stopped waiting the requirements to be updated.


it's a time sensitive generator, so yes there's a good reason to increase the number of execution


4695_hpwh_equip_seq_num (nmerket) - Win64-Windows-7-VisualStudio-12: OK (1813 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


(This will be easier to understand with [the schema](https://wiki.musicbrainz.org/-/images/5/52/ngs.png) open :) )

> >What do you mean by:

> "artist_credit_names is more like a measure of how common it is for an artist to be credited with not his name"

`artist_credit_name` has (in this case) 4 important columns: `artist_credit`, `position`, `artist`, `name`. What they mean is: in the artist credit `artist_credit`, the artist `artist` is credited as `name` in position `position` (on [this release](https://beta.musicbrainz.org/release/0b7ab2b9-8d7e-433a-bc4b-13c2f35e10c5) for example the artist_credit_name entries look like

```
musicbrainz=> select * from artist_credit_name where artist_credit = 1206141;
┌───────────────┬──────────┬────────┬─────────────────────────┬─────────────┐
│ artist_credit │ position │ artist │          name           │ join_phrase │
├───────────────┼──────────┼────────┼─────────────────────────┼─────────────┤
│       1206141 │        0 │  20877 │ Edvard Grieg            │ ;           │
│       1206141 │        1 │  64981 │ Berliner Philharmoniker │ ,           │
│       1206141 │        2 │  10239 │ Herbert von Karajan     │             │
└───────────────┴──────────┴────────┴─────────────────────────┴─────────────┘

```

However, if an artist never has any featured artists and is always credited under his regular name, there'll be only one entry in artist_credit_name (position 0, artist $id, name the regular name and an empty join phrase). There'll be an entry in artist_credit corresponding to that single artist_credit_name. However, this artist_credit can be reused across lots of releases because the artist always just uses his regular name.

> So this is why it seems to work:
> > "it's somewhat more likely that an artist with hundreds or thousands of releases will have more artist_credit_name entries than one with only 10"

Of course I have no evidence for this, but yes, the more releases an artist has, the more likely it is that one of them will feature another artist or that he'll maybe try some name variation.

> So would this do the trick:

> >   releases = relationship("ArtistCredit",
> >                            primaryjoin="Artist.id == ArtistCredit.id",
> >                            foreign_keys=[Artist.id])

I don't think so - Artist.id is not related to ArtistCredit.id (ArtistCreditName.artist_credit_id is the foreign key to ArtistCredit.id). You can just add a relationship to artist_credit_names with `artist_credit_names = relationship("ArtistCreditName", innerjoin=True)` and then access the ref_count with `artist_credit_names.artist_credit.ref_count`. I'm not sure what ref_count is, though, but I think it really is the number of things (release groups, releases, recordings) that use an artist_credit.


Sorry about that. 0.0.5 had incorrect .tar.gz and then my attemps to *quickly* fix it produced more errors. Classic case of cutting shortcuts costing way more time....


You can import `Testcase` from `numpy.testing`, which is what all the other test modules do.


This seems to have caused a log warning in the debugger, and when I ran the app, it was just a black window. I'm not sure they are connected.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 35](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1189676&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


I can't get even one Fix, but accuracy is good.. Is it normal? :smiley:
http://i59.tinypic.com/t7mp8n.png


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 35](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1189676&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:02


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 36](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1189679&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 36](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1189679&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:02


penkqc


This is how Windows are in the DOM btw:

![Screnshot](http://i.imgur.com/3ZF9SJN.png)

I also just made a commit that fixes some of the pixel-perfection required to make your stuff work 100%.

So rebase your branch  and run `grunt themes:styles` :)


i cant


ok


Google also has domains like google.com.hk (Ref: https://en.wikipedia.org/wiki/List_of_Google_domains). I will wait for a while for some user requests on this.
No problem (on homebrew)! There is a request to add google-cli to homebrew so I was checking out :).


Il 28/08/15 18:02, Denis Sokolov ha scritto:
>
> Because neither me nor zikula seem to care to support old PHP versions.
>
I agree with you, I moved all my base requirement to php 5.6 time ago.
>
> If you run an unsupported version for a system that you don't touch,
> keep running the same version of Doctrine 1 that you have been running
> previously. Like a frozen time bubble.
>
a version tag on commit f063a6178856c6c1eccc5433fd03f60eb32aa2f9 (or
better commit ac7ad1ca8a6fe995f68f7bf9b39d41941ee1bbfc, the last of
"Drak era") would be great for this purpose.
>
> If you are still working on the application, and adding new features,
> then I recommend make it support PHP 5.4.
>
Application that I'm working on actively have been migrated to Doctrine2
or other ORM, application that I maintain for security can't be upgraded
so easily because of missing budget of client that aren't willing to
invest more (like the ones on ubuntu 12.04 LTS)
>
> Finally, if you are still working on your legacy application and are
> not willing to migrate it to PHP 5.4, you are welcome to maintain a
> fork of Doctrine library and keep it supported for old PHP versions.
> If you do it consistently, I am not against including those patches in
> this version.
>
If I will find myself in this situation be sure that I'm going to make a
PR, like in the past.

BTW, thanks for your work on this fork, keep it on!


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 37](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1189683&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 37](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1189683&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:02


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.31.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62172&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:36:09


A monotonic counts time going forwards, no matter NTP or other services changing the clock. Py3 has time.monotonic() for this. Py2 can use a similar code from the py3 implementation.


This can be inlined in `xpath()` function. The difference is just one line with `self._xml`.


@eparis just filled #132 that trims stock output. that would work i guess for most use cases without the need of further costumizations... Have a great weekend!


Note: My calculations may not have been correct, because the commit I made fixes something that has gone unnoticed for a while :P


and image/figure along with the extra "vcr.py"


Could you elaborate the reason not to modify index?


its very good algorithm


Do not make assertions against time/profiling in unittests. This, for example, failed during Travis CI cycle. Remove everything regarding `time` and the test itself will be much nicer.


Unrelated; I believe that there were fixes related environment variable passing to the route and ifconfig scripts in 2.3.7 which seemed important. Anyway do revert this if there is a problem with the update. I'm afk now.


thank u how to execute this code


first, this will create a time and CPU consuming test
second, it's unstable by design as it won't catch an issue for sure, but might some day which will fail a build out of nowhere

test is no good in this form but there should be a test ensuring no illegal character are generated

the implementation should be changed to delegate a some part to an object which can be tested independantly and then trusted

probably neither obvious nor easy to do though


This one should not have been un-repr'ed
```
17:36:10     from salt.template import check_render_pipe_str
17:36:10   File "/srv/virtualenvs/raas-pr/lib/python3.4/site-packages/salt/template.py", line 15, in <module>
17:36:10     import salt.utils
17:36:10   File "/srv/virtualenvs/raas-pr/lib/python3.4/site-packages/salt/utils/__init__.py", line 121, in <module>
17:36:10     import salt.version
17:36:10   File "/srv/virtualenvs/raas-pr/lib/python3.4/site-packages/salt/version.py", line 517, in <module>
17:36:10     __saltstack_version__ = __get_version(__saltstack_version__)
17:36:10   File "/srv/virtualenvs/raas-pr/lib/python3.4/site-packages/salt/version.py", line 510, in __get_version
17:36:10     from salt._version import __saltstack_version__  # pylint: disable=E0611,F0401
17:36:10   File "/srv/virtualenvs/raas-pr/lib/python3.4/site-packages/salt/_version.py", line 5
17:36:10     __saltstack_version__ = SaltStackVersion'(2015, 8, 0, 0, 3, 2064, 'g2db2451')'
17:36:10                                                                       ^
17:36:10 SyntaxError: invalid syntax
17:36:10 ERROR: could not load /var/lib/jenkins/workspace/raas/pr/368/tests/tests/conftest.py
```


You can name them differently. For example `xpath_node` and `xpath_evaluator_node` which makes their origin clearer.


`cab` -> `can`


The environment is _huge_ (run `npm run env` to get a sense of scale), and including it for every lifecycle or package script invocation would make the logging output nigh unusable.

I still think `silly` is still the appropriate level of debugging for that. Again, you can get that level of detail with `-ddd` or `--loglevel=silly`, and I think if you're that deep in the weeds already, you're going to want to see absolutely everything npm's doing anyway.


Add another assertion, for a more strict regexp (for example) that would show different results.


Well, that's embarrassing, the y indices should obviously depend on the number of columns in the network output. Didn't test this on any but the iris example, committed prematurely. Fixed in 8f1c40b. Thanks!


in which version of spacecmd is this patch included?


I remember when I implemented the stealth rocks check. I really had intended for the limit to be 2, but I can see why people would want it to be 1.

I see we're also doing team weather checks now. It's probably better this way compared to the overly complicated solution I had submitted a few months ago


Done: https://github.com/cpojer/relay-starter-kit/commit/91454381f0a4ba2ca5b8d732a33151810552ba24

Thank you!


we should unit test that


@chalkie666 Sorry, they go in the javadoc of the class. So e.g.:
```java
/**
 * A whizbang to jumble quarks.
 *
 * @author Curtis Rueden
 */
public class WhizbangQuarkJumbler {
  ...
}
```


and if its time sensitive, don't use `System` directly, control the input so you can actually assert the output in the test


Suggestion:

```

Window.prototype._getDOMRect = function() {
  var dim = this._dimension;
  var pos = this._position;
  var topMargin = 0;
  var borderSize = 0;

  var theme = OSjs.Core.getWindowManager().getStyleTheme(true);
  if ( theme ) {
     topMargin = theme.style.window.margin;
     borderSize = theme.style.window.border;
  }

  return {
    left : pos.x - borderSize,
    right : pos.x + dim.w + borderSize,
    top : pos.y - borderSize - topMargin,
    bottom : pos.y + dim.h + borderSize
  };

};

```


looks good


@jbrowning only the source changes are enough. Otherwise there might be conflicts with other PR's.
Seems like a good idea to add a test for this. If you don't have time for this I can add a test as well.

Thanks! :cake:


Or simply `_getRect()` is probably nicer


Or with more helpers:

```
  var rect = {
    left : pos.x - borderSize,
    right : pos.x + dim.w + borderSize,
    top : pos.y - borderSize - topMargin,
    bottom : pos.y + dim.h + borderSize
  };
  rect.width = rect.right - rect.left;
  rect.height = rect.bottom - rect.top;
  return rect;
```


yk


TeamCity pull requests :: netty [Build 141](https://garage.netty.io/teamcity/viewLog.html?buildId=912&buildTypeId=pulls_netty&guest=1) is now running


Remove line.


https://rubygems.org/gems/solidus_gateway/versions/0.9.0, https://github.com/solidusio/solidus_gateway/tree/v0.9


5 millón seconds? ^^


yep....that would match my experience with newest master I wrote in some issue. Having problems now on my S4 with Lollipop (!)


@tcompiegne Is this LoginResource required in case of OAuth authentication ?


Yes good point!


So... why does this method have a `type1` parameter if it is not used in the computation at all?


```
    client.waitFor(function() {
      return rocketbar.backdrop.displayed();
    });

```
with the `marionette/lib/rocketbar.js` to maximize the integration-ness of the test


The intent is to remove each of the module's files like:

.fixtures.yml
.gitignore
.project
.puppet-lint.rc
.sync.yml
.travis.yml
.gitreview
.nodeset.yml
.prefabs.yml
.gemspec
.rspec

Not every module has all of these.  But the puppet modules in general have a ton of testing files that dont' need to be packaged.  In reality most of them don't hurt anything.  I want to make sure that the .git* stuff is gone so the deb linter is happy, but the other stuff isn't too important.

It's another carry over from other packaging I've seen of of similar repos.


And similarly, why declare the `type2` parameter when it is not relevant to the return value?


So that the humans get' me.


Alright ill do that. So you say maybe add a _getRect to window?


Oh I see, it's implementing the abstract method, of course. So it should be tagged with `@Override` then, for clarity.


Yeah, just like the code above. It would help separate some of the logic to appropriate places.


101064176-AddCO2DemandControlledVentilation (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


That's so incredible awesome I remember upgrading to rails 2.0, ho ho, Elixir/Phoenix is just so clean, fast and beatifuullll. I got the goose bumbs


updatesAvailable = OS updates available!***


Today is friday, so  another "official" relase is going to take place. Would really like to get this in there :D


If you're just using Node, there's not much point in having `language: ruby`. And if you use `language: node_js`, the default test script is `npm test` anyway. So really all you need is `language: node_js`. And maybe a version specifier if you want to lock down the Node version to use (or test with multiple versions). See http://docs.travis-ci.com/user/languages/javascript-with-nodejs/


ie 没有 uid 把


Yeah, I fixed that in the next commit. Not sure if we *should* have travis run our tests in both LibSass and Ruby Sass — but we'll go with node for WIP.


(I just went ahead and fixed that.)


I was thinking that as well at one point. I want to move most of the generating needed data out of the mousemove handler to keep it running clean


Nice catch @paulbruneau :+1:

I just pushed PR #251 to address it.

Cheers!


This is just one type of Control that would come with MOOSE, just like we have Postprocessors, etc. that come with MOOSE for common functions.

The idea behind this is that developers create there own custom controls by inheriting from Control, you can do whatever you want inside an object you create, couple in variables, pps, etc.  We will then create a script based method around the Control object that calls a user defined script to make modifications.


101064176-AddCO2DemandControlledVentilation (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Ah, sorry about that. The README.md is updated via the vignette, so I'll make the change there.


This sounds about right. I'll make this change.


4695_hpwh_equip_seq_num (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1287 of 1287 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.02%25-green.svg)


I guess we could add a method to our LUT node to retrieve them, and then bind that?


It's good that the code now checks for both HTTP and HTTPS.  However, before we had
```go
    gravatarSource = "http:" + gravatarSource
```
and now we have
```go
    gravatarSource = "http://" + gravatarSource
```
so the syntax for specifying `gravatarSource` has changed.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.452.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62175&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:25:34


You need to remove one tab from adapter. It is indented too far.


Just saying, xposed is still a necessary addition for getting some things working, eg. cloaking the built-in superuser packages from root-protected apps from developers who have the backwards view that people having root means that they're dangerous and shouldn't be using their apps.

Sure, it's safe if you don't have to use xposed for anything, but for those of us who do it means we either need to make our own builds for xposed compatibility or stay on Build 15, which isn't optimal.

Considering the performance improvement is only to the initial boot which isn't a particularly necessary point to have good performance (I don't know anyone who really cares that much about how long the initial boot takes, since it's one off) and the fact that it breaks xposed, I don't really think it's worth it.

Feel free to make your own judgement though, you'll just end up with a bit of fragmentation in your users for no real reason.


Sorry, my mistake there. Each Terraform resource is instantiated with a type, followed by a name. In this case, "aws_db_security_group" is the type and "default" is the name. Later, you could refer to this resource by the name.

TL;DR: Yes. You're right.


@brasseld no, only for basic authentication, OAuth authentication has it's own Login page/resource.

> Le 28 août 2015 à 18:50, Brassely David <notifications@github.com> a écrit :
>
> @tcompiegne Is this LoginResource required in case of OAuth authentication ?
>
> —
> Reply to this email directly or view it on GitHub.
>


:cry:


Please tell me that was the :koala: and not one of us…


Your German is impresive


thank you for spotting this!


Are you using the commit that I have up on the CM gerrit?

On Fri, Aug 28, 2015 at 12:34 PM Zdrowy Gosciu <notifications@github.com>
wrote:

> I can't get even one Fix, but accuracy is good.. Is it normal? [image:
> :smiley:]
> http://i59.tinypic.com/t7mp8n.png
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lg-devs/proprietary_vendor_lge/commit/0b5cd7428a5380ddf28d81bcd57ca9776394810e#commitcomment-12951723>
> .
>
--

Thanks,
Rashed Abdel-Tawab


yeah perhaps there should be some type of call to merged_config here with arbitrary kwargs, so that it could be layered or something?


Just wondering: Did you use a particular tool to fix the formatting?


@FFMee dieser Host hat keinen A oder AAAA DNS Eintrag

```
~  dig @8.8.8.8 meerane.freifunk.net

; <<>> DiG 9.8.3-P1 <<>> @8.8.8.8 meerane.freifunk.net
; (1 server found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 481
;; flags: qr rd ra; QUERY: 1, ANSWER: 0, AUTHORITY: 1, ADDITIONAL: 0

;; QUESTION SECTION:
;meerane.freifunk.net.		IN	A
```


101064176-AddCO2DemandControlledVentilation (lgu1234) - i386-Windows-7-VisualStudio-12: OK (1798 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


No space before ":" in English.


`this.$('#_attachments') ` and `this.$('#_rev').val('');` (# missing)


調整了論壇和專業知識版面欄寬配置使both電腦and手機畫面變整齊些（為了簡化版面所以隱藏了論壇排序功能 手機版隱藏看板跳轉和發文功能 這樣看起來比較簡潔ＸＤ 如果大家要改回來再跟我說


Since the successful return value is an integer never less than 1, returning -1 for failure facilitates comparison.


Maybe setWSAddressingSupportEnabled(bool)? Not that anyone will turn it off again, I suspect, but it makes it clearer that this is a bool setter. This is just like QStandardPaths::setTestModeEnabled(true), nobody calls it with false.


Missing \since 1.5


Performance improvement is not only on first boot, as it still benefits /data partition by keeping odexed pre-optimized classes in /system partition, and many other things I have no time neither willings to list.

Xposed is one giant unsupported, unoptimized hack, which never worked properly for LP, even rovo doesn't support it officially for LP 5.1, and even if it can be useful, it can also cause a total chaos, is giant security hole in terms of injecting into framework methods, and rovo, or any xposed maintainer can fix it to work with dex-preoptimization just by adding support for gzipped odexed classes probably.

It's xposed which is broken, and not the ROM. I won't degrade system performance, neither security just to make people being able to flash a giant hack which is called xposed on top of that.

If you want to use xposed, you have 2 options. Either kindly ask xposed developer to fix his hack to make it work with gzipped odexed preoptimized classes, or go find another ROM.


なにこれ？


The crossgen for main.exe needs to see different test.dll than what we will actually end up using at runtime. I think that this should be:

```
COPY /Y testv1\test.dll test.dll
crossgen mainv2.exe

COPY /Y testv2\test.dll test.dll
crossgen test.dll
```


remove


it's pronounced "sh", but the spelling is still relation rather than relashion ;)


I have a MIDI keyboard on my other machine and I merged in all your changes and played with test_supersaw . I disconnected the left and right from the output and it all worked fine for me ... It's a cool synth BTW ! ... Anyway .. not sure why you are having problems with my branch ... hopefully in the light of day it now 'just works'


Signed-off-by: Paul Reioux <reioux@gmail.com>

did you see?

i modified it to suit with my kernel changes, so that the people that gonna use this know this is not pure faux commits


To be honest I'm glad it can no longer be used in my projects, as 95% of all bug reports have came from xposed users, so now at least I can focus on really broken parts of the ROM and not wasting time repeating every now and then that xposed is not stable and causes issues. If there was a simple way of protecting all binaries and shared .so libraries from modifying, I'd apply it without a single doubt.


Yep - you're right. In this case, it should be...

name = "${var..."

That's my own sloppiness there. Apologies.

Should thankfully be quick to rinse and repeat with a regex in this file.

And it reminds me to ask the mailing list what they do for syntax and lint testing.


MEP?


you probably want to allocate d here, or it will crash ;)


Nice catch!  But I think putting this in vdev_queue_init() is slightly more appropriate.


ок)


Yup. And even better would be this to be not a vector of vertices but a vector of functions etc. Anyway this and a more functorial approach (presheaves on a category of "shapes") are useful to reason about code, even if the type system is lacking.


TeamCity pull requests :: netty [Build 142](https://garage.netty.io/teamcity/viewLog.html?buildId=913&buildTypeId=pulls_netty&guest=1) is now running


this should be a ````const gchar *```` you probably get a warning otherwise.


Returning "const QString" is useless.

On the other hand you meant to mark the method as const -> put the const at the end.


Ну да. Просто проверяю, что бы формат в который декодируют, не был UNKNOWN и или тем, который мы получаем после декомпресси. Если после декомпрессии у нас будет YUY2 а декодировать пользователь захочет тоже в YUY2 - то IMFTransform конвертор на полном серьезе будет декодировать из YUY2 в YUY2. Ошибки не будет, более того он умеет декодировать так =) Только как он внутри устроен, и не начнет ли он на полном серьезе декодировать, я не знаю.


move const to the end


тут, я думаю, должно быть `a.logo`, не?)


move const to ... you guessed it


@tcompiegne That's what I was thinking about... So this **LoginResource** must only be visible when *security.implementation* is set to basic, right ?
Also, I think that *security.implementation* is not really easily understandable. Why not defining *security.profile* or, better, *security.type* as it is already done like this for repository ?


отлично!


Returning a const ref is bad practice, it makes it impossible to one day add
if (cond) { return KDSoapValue(); }


use switch() instead of 4 if()s


If we can get it working on the base class so the derived classes don't do it directly, then I think we can modify the ColorProcessor base class at some point so we can do away with it entirely.


remove "= QLatin1String", i.e. just pass params to the ctor directly


writ -> write


Лол.. =)) это да..... надо поправить


Can appInstance be null?


это декоративное изображение или контентное?)


Yeah.  I guess the standard way of doing this would be to have a Makefile with build and dist targets that 1) install just what needs to be installed into a $DESTDIR directory, and 2) create the source tarball; probably both of those would be selective.  Since you don't really have a build process, it makes sense that it's done in the packaging, I suppose.  But keep an eye out; the idea that a package build involves a make as well as a 'packaging' run is pretty engrained; there may be other mismatches.  But that explains why it seemed odd to me.


Fair point about me asking not to drop it from ColorSpace - if you want to just add a todo instead for now that's fine...


`img`?


Congrats :+1:  :heart_eyes:


D'OH! Fixed.


yes i think that could be a good thing to be able to have a color picker, even if we usually get that from the client


Then it's not arbitrary at all, it's the namespace for these XML elements. Remove that comment.

Also, move that namespace to KDSoapNamespaceManager.h/cpp to avoid duplicating it multiple times in this file.


space after if


okay)


:ok_hand: :ok_hand: :ok_hand:


After checking whether dim_ == 0, it would be more appropriate to just assert that dst != NULL.  The user needs to provide valid inputs, else it's an error.


this looks unfinished, at least add a TODO...


lol, very useful ;)


Remember to add class docu with \since 1.5


Perhaps I should add that I do not have any issues with the openvpn server I deployed the update to.


Did you mean olive oil or canola oil?


From ERR_GET_LIB(3): "Each sub-library of OpenSSL has a unique library number; function and reason codes are unique within each sub-library.  Note that different libraries may use the same value to signal different functions and reasons."


Please remove the extensive comment here.


Can we move the `partitionIndex` up in the hierarchy? Since we need this index to construct the remoteBindingName when binding the consumer, can we infer the partitionIndex when setting the `s.c.s.bindings.*` at the `data-admin`'s ModuleDeployer level?  I also believe this would also help in the case of dynamic scaling of module instances that is driven from the `data-admin` (via ModuleDeployer) by giving us control on specifying the partitioning index for the consumer modules and to dynamically `re-bind` the producer module at the same time.


forgot a `git add` ?


Нам эту переменную надо иметь тут (эта переменная декодер, который умеет конвертировать фреймы). Я переместил инициализацию pDecoder к общей инициализации. Не знаю как правильнее поступить. В принципе мы можем ее инициализировать в конструкторе MediaFoundation_Callback


@bgerstle is this "viewsToSendTouches" stuff needed any more?


Call KDSoapNamespaceManager::soapMessageAddressing() instead of duplicating the value here.


It isn't needed, since our device is set to don't search WiFi when on sleep

What's the differences between 4339 and 4335?


These are confusing comments.


`hou` is a python module for Houdini which defines the **HOM**, Houdini Object Model.


the .Line.Remove caused an error (IIRC the "Line" property didn't exist) so it always returned the string "", which always failed.

If you look at VMs serial out, they'll always retry twice even when their output contains "Licensed" both times. Also, if you run it manually, you can see error output each time it hits the old line 471 - it doesn't show up on serial out.


@belison I think what you have is good.


Writte -> Write   - you don't like this word, do you? ;)


Да. Можно и назад перевод сделать, обратный videoFormatToCaptureFormat вот такому вот. Если лучше сделать обратный перевод - то могу переделать. Это не долго


Good catch, we are unlocking it sometimes below so we we were doing unprotected operations sometimes.


this one could be static


Not sure why it is saying Line doesn't exist, but LGTM.


:+1: Great work!


I have the feeling this message is going to be very hard to understand...

Shouldn't we mention the various causes of problems and one of them being that the user doesn't have the Scripting Right?


А ну да, впринцыпе да. Я отлаживал, и получилось бы слишком много проверок. И забыл добавить после отладки.


@brasseld you're absolutely right, agree to change security.implementation for security.type.

Envoyé de mon iPad

> Le 28 août 2015 à 19:16, Brassely David <notifications@github.com> a écrit :
>
> @tcompiegne That's what I was thinking about... So this LoginResource must only be visible when security.implementation is set to basic, right ?
> Also, I think that security.implementation is not really easily understandable. Why not defining security.profile or, better, security.type as it is already done like this for repository ?
>
> —
> Reply to this email directly or view it on GitHub.
>


It sounds like you're going to write out nonsense. It will still comply to the spec, i.e. not invent its own element names... ;)

What you want to say is that there is no validation of the parameters. And that is also true in the setters, so I would actually document that in the class docu rather than here. "This class does not provide any kind of validation on the data being passed to it".
Then reduce this method docu to "Write the properties to the soap header".


adjust this when making the method static, obviously.


I assume that this would then prompt you to pick a new name for the repo?


I can't decode this comment.  Are you saying that I'm returning the wrong value in some case?  If so, what is that case?

(Note that expected return values are tested, to some extent, in cert_test.cc.)


missing empty line between methods


Short answer: This is ok, but not the most commonly used and there is no single accepted PET estimate, though there is an official reference ET one from the FAO for agricultural applications.

Ultiamtely, I guess it depends on what you are using PET for (i.e., for gap filling or for flagging bad AET values or for calculating AET/PET ratios). Thronthwaite is the oldest model out there, and it's useful in that it needs very few inputs, but it's not super accurate, probably ok for daily PET. Most of the time PET is computed using Penman-Montieth, Priestly-Taylor, or Shuttleworth(Penman), but they require more inputs (like net or solar radiation and wind speed). Here is the official FAO formula for reference ET from solar radiation, U, and T: http://www.fao.org/docrep/x0490e/x0490e06.htm (see eq. 6)

Also reference and potential ET are slightly different: http://edis.ifas.ufl.edu/pdffiles/AE/AE25600.pdf
Also useful: http://edis.ifas.ufl.edu/pdffiles/ae/ae45900.pdf
Online calculator of PET from P-M: http://ponce.sdsu.edu/onlinepenmanmonteith.php
8 PET models are compared here: http://www.tandfonline.com/doi/pdf/10.4296/cwrj1301009 and show differences mostly in dry,windy cases.
Another intercomparison: http://adv-geosci.net/18/15/2008/adgeo-18-15-2008.pdf
A 3rd intercomparison: http://naldc.nal.usda.gov/download/7287/PDF
Recommendations on which one to use: http://www.hydrol-earth-syst-sci.net/17/1331/2013/hess-17-1331-2013.pdf

So it's not easy as it's not an assumption-free quantity or one that has a direct physical link. IT's really a rule of thumb for what to expect for a typical well-watered, shaded agricultural crop in the height of growing season. If you have to pick one, use the FAO reference method.


No swear words in your code please, that's not professional.


(y)


How about a try-except instead of testing django versions?


No const in the ret val, that's useless.


comment?


@fernandog obj is never passed, and is only used at that spot. The image name/path is passed separate.


This method doesn't seem useful, given that the setter of properties already sets the bool?


Did you see crash on the assertion? Typically it should always be true. Just ">=" should be replaced by ">".


Ups, sorry I didn't check properly. Thanks.


You might as well replace the unicode Kelvin char too :)

I don't see the weather in Kelvin. But if I were to set to that, the Kelvin K will look odd one out compared to the rest.


Yes but it is not imported. Why does this work? Some kind of context that you drop Python files into and they magically have access to global objects?


This cannot be passed from ModuleDeployer (except in the local impl) since in a cloud environment env vars are common to all instances. We need each module instance to determine is "instanceIndex" itself from an env var provided by the actual runtime (CF_INSTANCE_INDEX on Cloud Foundry, INSTANCE_INDEX in Lattice). This also means its the responsibility of the binder *within* a module instance to determine its partitioning index, not a responsibility of the module deployer. ModuleDeployer impls will only know producer-side properties like partitionKey, and shared properties like the number of total instances requested. cc @mbogoevici

However, I would like to move it up the hierarchy, perhaps "spring.cloud.stream.instanceIndex" (and I'd like to change the module's 'count' property to 'instances' for consistency). It may be used for other functionality besides partitioning.


Prefer `ArrayList` to `LinkedList` unless you have a good reason.


Could you change the products on this to be `506 517 533 GeoLite2-Country GeoLite2-City GeoLite-Legacy-IPv6-Country GeoLite-Legacy-IPv6-City`? These are our free databases.


Nightly: https://scala-webapps.epfl.ch/jenkins/view/Scala.js/job/scalajs-nightly/507/
Weekly: https://scala-webapps.epfl.ch/jenkins/view/Scala.js/job/scalajs-weekly/58/


I think I did it like this because I didn't want to put implementation details of the I2C frame into the result accumulator (and because the whole I2C stuff looked very unfinished to me).

It was some time ago but I discussed this with @LorenzMeier a bit:
* Lorenz suggested to drop support for the i2c_frame because it is
a) not used by the current PX4 code anymore (I don't know for how long, need to check) and
b) is not very useful because invalid datasets need to be extrapolated (as there is no integration time field)
We could fill it with qual = 0, if we want to gracefully break support for PX4s with old code.

* In addition we concluded that it would be nice to somehow start to send a version number along with the data. If I remember correctly Lorenz suggested that we add it at the end of the current frame. Current implementations of the flow driver will ignore the version number and future implementations could check it by reading more data from the I2C bus. After that it is possible to add new fields like exposure info.

BTW: in my opinion the same thing as for the i2c_frame goes for the optical_flow mavlink message. That message however has at least some usefulness for testing because we can plot the flow directly without needing to divide by integration time. (which from my knowledge is not possible in QGC, there are no math columns for plotting).


@peterborkuti ,is this a backport of a specific ticket? Or just some extra changes to make this compatible with the deprecated branch?


stack overflow suggests a bunch more formats, maybe not all things that you would care about though - http://stackoverflow.com/questions/2936467/parse-youtube-video-id-using-preg-match


depends on how @coreyfloyd's new popup stuff works


101064176-AddCO2DemandControlledVentilation (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (751 of 751 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.61%25-green.svg)


This does more than validate the proposed partitions -- it also actually creates the `HomRefBlocks` for the partitions.


101064176-AddCO2DemandControlledVentilation (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (1798 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Confirmed, it installs cleanly now.


Hello,
It's done.


Test


This method does not return a String


I have added a new preference in Settings/System which lets you force the use of the orientation sensor (when both are available) so that you can experiment.


It looks to me like Artist.id is related to artist_credit.id:
```
musicbrainz_db=# SELECT * FROM musicbrainz.artist_credit WHERE artist_credit.id = 64981;
  id   |          name           | artist_count | ref_count |            created
-------+-------------------------+--------------+-----------+-------------------------------
 64981 | Berliner Philharmoniker |            1 |        64 | 2011-05-16 12:32:11.963929-04
(1 row)
```
```
musicbrainz_db=# select * from musicbrainz.artist where artist.id = 64981;
  id   |                 gid                  |          name           |        sort_name        | begin_date_year | begin_date_month | begin_date_day | end_date_year | end_date_month | end_date_day | type | area | gender | comment | edits_pending |         last_updated          | ended | begin_area | end_area
-------+--------------------------------------+-------------------------+-------------------------+-----------------+------------------+----------------+---------------+----------------+--------------+------+------+--------+---------+---------------+-------------------------------+-------+------------+----------
 64981 | dea28aa9-1086-4ffa-8739-0ccc759de1ce | Berliner Philharmoniker | Berliner Philharmoniker |            1882 |                  |                |               |                |              |    5 |   81 |        |         |             0 | 2015-02-13 06:01:30.415928-05 | f     |        326 |
(1 row)
```

The results using ref_count are pretty great.  If it really is all the release groups, releases, recordings...it probably isn't a bad metric for how popular/prolific the artist is.  Maybe I should just change the variable name in sir and roll with it?

I haven't set up nginx yet, but shouldn't be that hard to figure out right?  Hopefully you'll be able to test it soon!


extent


's/is assured be to a/is assured to be a'


Note: I forgot I also need to do the permitting here using those `permitted_params`.


Whoops, nope... Fixed.


Something like an invalid encoding, perhaps.

I can make this change, but, are you sure?  The previous code does not log in the case when OpenSSL returns 0, which suggests to me that maybe that case is expected to be frequent or spammy.

BoringSSL has a 2-state return value (0 or 1) as opposed to OpenSSL's 3-state (-1, 0, or 1).  So, in effect, this case attempts to distinguish between the two perhaps imperfectly defined cases that cannot be distinguished by return code.


Document the requirements for this `List<Integer>` to be considered as representing well-formed partitions.


Why not. I'll pull it in


Start variable names with a lowercase letter -> `gqPartitions`


You mean http://review.cyanogenmod.org/#/c/107672/?
I didn't picked it yet :smiley:


It appears that the requests for the sha1 were mainly due to Gradle doing cache checks. Not happening under current implementation.


This commit is useless, I had reverted it before , why you have again pushed it ??


Assert that these are empty! Same for explicit templates!


@miigotu

But I passed the obj here:

https://github.com/SiCKRAGETV/SickRage/commit/2447776983a8bd3414d6aae8a168c4f7932e8e75


right but it means somebody can set a source, not set any aggregations, and things will be weird. I think it's better to check that at least one aggregation is always provided, since that is the real use case


There's a code dealing with random - and trying to be portable on flow/random. Maybe reuse core code there here (and on other platform and make there use new shared).


Then you should note the changes you made in the commit description and not change the author.. since @faux123 wrote the base of this commit thus there is no reason to get rid of the author.


Also please keep a decent indentation format, any indentation format


Great work, thanks!
Could you please split yout commits with git rebase (I can help if needed) and send me a pull-request without disabling the extension in Firefox by default?
Moreover, maybe you can do the button in the way Adblock uses, e. g. button is on -> scripts are loaded in any page, button is off - they are not?


Admit it, you named the lib like this just to be able to make this pun. ;)


tc 0.7"+0.03"
eKingOnOne,58,0,200,8,0.002,0


Awesome!


I didn't mean to infer the environment properties via ModuleDeployer. Instead getting that info via REST calls (I think this is needed only for pre-existing deployments) and in other cases, the ModuleDeployer would specify which partition index to use based on the instance `count`. Isn't the benefit of having the binder determining the partitioning index (though we know beforehand at ModuleDeployer based on the instance count) to allow scaling outside the context of module deployer?


@fernandog that line only gets called when `if not image_data:` so you only see the log line when it is failing. Here you know now that it is failing with objects that are `None`


wrong: just `parseEvent`


See https://github.com/stretcher/stretcher/pull/83 for reason for this commit.


Take a look at https://github.com/infolab-csail/elasticstart/blob/master/scripts/index_abstracts.py (`get_header` and `get_abstract`).

If all you care about is the title, infoboxes, and first sentence, you don't really have to parse XML. lxml might be very fast, but it chokes on malformed input. Because the XML structure is so simple, it's easier if you do text search / regex matching.

Btw, I modified `WikiExtractor.py` to differentiate section headings and regular text (headings start with `## `).

You shouldn't need to import elasticstart as a dependency -- just copy over the functions you need.


Thoughts on ee3f5db  ?


Actually this is wrong because the IllegalArgumentException is launched by unbindService() below.


@fernandog `SickRage/sickbeard/image_cache.py:L262`


Has @ldgauthier given her blessing to this rewritten version of `genotypeQualityFromPLs()`? (looks ok to me)


That's all I wanted to know :)


Where is the sorting being performed? Are you assuming that `minPLs` is already sorted?


убрать точку


0.7 really ?
I would not trust the eg values in that case...but...I may be wrong.


Seriously, then you should go to faux repo and go asking authorship, because there is some others commit that he do same as i do..  :) btw this gonna be last reply. Thanks for the comment.


Also does extra steps to set up ubuntu desktop
 * virtualbox guest additions
 * automatic login
 * cut & paste enabled
 * auto resize works


https://www.safaribooksonline.com/library/view/flex-bison/9780596805418/ch01.html

sample compilation process.

$ flex hw.l
$ cc lex.yy.c -lfl
$ ./a.out
The boy stood


ok! thank you!


@cmungall -- you have the wrong repo, tag with geneontology/amigo#226


For rows to be written to the database, you have to call `session.commit()`. It looks like you're calling `commit` only once, after adding all articles in `get_all`.

This means you're buffering all articles to memory, and then flushing all at once.

What you probably want to do instead is commit in batches, say of 1000 articles. You might need to experiment with the batch size.


I’m open to whatever you want to do with it.  The problem is it doesn’t throw any exceptions with 1.8.  The options works fine the old way, but Django 1.8 ignores it.

--
Conan C. Albrecht, Ph.D.
Information Systems Department
Brigham Young University
ca@byu.edu
KG7USZ
http://goalbrecht.com/

> On Aug 28, 2015, at 11:28, jordiecometrica <notifications@github.com> wrote:
>
> How about a try-except instead of testing django versions?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/doconix/django-vinaigrette/commit/480b29a20f29104947a76392e1a561023deafda9#commitcomment-12952623>.
>


P.S. thanks for the project.  You saved me a lot of time.

--
Conan C. Albrecht, Ph.D.
Information Systems Department
Brigham Young University
ca@byu.edu
KG7USZ
http://goalbrecht.com/

> On Aug 28, 2015, at 11:28, jordiecometrica <notifications@github.com> wrote:
>
> How about a try-except instead of testing django versions?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/doconix/django-vinaigrette/commit/480b29a20f29104947a76392e1a561023deafda9#commitcomment-12952623>.
>


Your on ready handler refers to "Document" when it should refer to "document" -- the capital "D" makes all the difference!


отлично!


remove again


`ucwords` has already capitalized the first word so we can get rid of this `ucfirst`


This took me quite some time to find out why it's now all broken on Comet.
This is a breaking change. I would advise to revert and make a major change instead of a minor.


> I had to manually delete `<br>` tags and replace all `&` with `&`, as you can see in the merge_extracted.py script)

Per my comment above, is this still necessary?


It may be possible that in the going back and forth between the two
branches I failed to rebuild something at some point so I was using
incompatible binaries (or I needed to touch a file to make make rebuild
properly). I'll test again on the bus home.

I just got the latest update to Logic Pro X which has this awesome plugin
synth called Alchemy. I could sit around all day just playing one note with
various settings. Anyway, I noticed each oscillator unit can sum a (large)
variable number of detuned oscillators so I implemented it in Moodler.

On Fri, Aug 28, 2015 at 10:13 AM barnabyrobson <notifications@github.com>
wrote:

> I have a MIDI keyboard on my other machine and I merged in all your
> changes and played with test_supersaw . I disconnected the left and right
> from the output and it all worked fine for me ... It's a cool synth BTW !
> ... Anyway .. not sure why you are having problems with my branch ...
> hopefully in the light of day it now 'just works'
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dpiponi/Moodler/commit/5974fb0265cb0d4a7ee46127e7c18d72ea7ee9ce#commitcomment-12952320>
> .
>


Thanks so much :thumbsup:


(If this turns out to be a bug, we should understand why the existing tests didn't catch it, and make this method protected so we can test it directly)


Sorry. Im lost. So that PR I did is wrong? I only wanted to display the name of the show that didnt have the images so I cam manually add them in SR


And stop hit the indexer for that image


Alright, will push later. Thanks!


I'm going to remove this since we added the other conditional in the if statement.


@fernandog you didnt pass the object here: SickRage/sickbeard/image_cache.py Line 262


This is _so_ much clearer with the boost optional!


Круто!)


Speaking of bulk inserts, this might be useful if you notice that performance is slow: http://docs.sqlalchemy.org/en/rel_1_0/orm/persistence_techniques.html#bulk-operations

```python
s = Session()
objects = [
    User(name="u1"),
    User(name="u2"),
    User(name="u3")
]
s.bulk_save_objects(objects)
```


I will test them as soon as I am back from holidays, which is the next days.


Thanks for bringing this up! I did feel like I was simplifying saying "is more appropriate".

Also yeah - I had the same idea re: top-level parameters to pass down to control these things, I was just trying to get a working Linux function for simple strings first, and then have the OS X function match.

1. I saw the `eos = NULL` parameter but couldn't see anything so chose to ignore it
 - I'll add those settings to the function, not a problem
 - Maybe of relevance: [Windows clipboard R question, spotted last night on S.O](http://stackoverflow.com/questions/17140424/placing-a-string-on-the-clipboard-without-a-newline#comment24807657_17140615)

2. A customisable `sep` would be neat. The default could be handled in each O.S.'s respective function - `\n` on Mac & Linux, `\r\n` for Windows, and in all cases setting the top-level `write_clip()` call with `sep=...` would override it.
 - I'm happy to add that if you agree?
 - When might anyone want to separate with anything other than a newline do you think?


It's so much clearer to have a read-only parameter and a return parameter than that weird "read-write" parameter of before.


weird indentation/next line might fit into this one as one!


This seems much less readable than the original, straightforward for loop.


@21373colido and please do not forget to make a pull request to MarlinDev/master for every change you make, that would be interesting for the community. thanks.


quibble:  capitalize "Contains".


not needed in code, set that on the command line or in QtCreator


don't be messing with my loops, bro


@bgerstle Updating the same list is probably the thing to do - as long as the method is only used on the main thread.

Also, we should probably just make it formal that lists must be manipulated on the main thread… this makes sense… all lists currently are only modified by user interaction (with the possible exception of data migration… but thats a well contained edge case)

I don't know pushing knowledge of views into the model layer is the best pattern to go with - that doesn't jive well with MVC. If you need to import UIKit into a model class, that is usually a code smell.

A more appropriate place for the method you suggest would be in the view controller layer (a view controllers job is to mediate between models and views - even in MVVM, the view controller should still be setting up the binding).


don't forget \since 1.5 in the docu when you add it


Делаем форму


`input[type=submit]`


Ok, I will use "path.Join".
About the "if flag.Narg() < 2 { ...}". which line is this?
Should I wait until Andrey answers or can I start with other command (e.g.
"ed")?

2015-08-27 21:29 GMT-07:00 ron minnich <notifications@github.com>:

> This is very close but you need to use path.Join for things like that file
> name above, not the string + operator. path.Join will save you lots of
> trouble with weird names.
>
> Also the switch for the # args is slick but I think it's clear to just say
> if flag.Narg() < 2 { ...}
>
> let's see what andrey thinks.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rhiguita/u-root/commit/b417b098c60ac7c76d6f7d49df1e472ec8c991d0#commitcomment-12940627>
> .
>


s/contains/Contains/

The signature of these is so similar - is there no way to extract out a common struct to wrap most of these parameters, and preventing all the duplication of code and comments?


@dadouf checkout 5005a98928d7830d168662423f9bfb09bff23af3


seems so


this appears to cause an issue when chain loading to a microsoft WDS server.  We experienced this issue as well as this forum post user:  http://forum.ipxe.org/showthread.php?tid=7765   .  Backing out the patch also allowed WDS to boot successfully when redirected from iPXE.


Please change that variable name `convert_all_`, it agrees neither with Ripple's general style nor the style of this file!


I decided it would be best not to break things if people didn't have the latest version of Datashape installed. So we ignore the `NameError` we get if `Decimal` is not present.

If you'd rather enforce the dependency, I can take out this commit.


This would be clearer if `log_data` was a dict, then it would be `log_data.get('buiidid')` and not matter the exact order of the items. Then below you can use the keys in the format.


Diese Änderung gehört hier eigentlich nicht hin- du solltets die jar in den lib ordner packen und den Classpath unberührt.


Is this a new error case?  How did we detect/report a deformed amount before?


:+1: :smile_cat:


auch dieses file sollte iegntlich in ruhe gelassen werden.


das garnicht committen. man könnte das mal noch in die .gitignore aufnehmen


Another regression has been reported: http://trac.cppcheck.net/ticket/6956


**npm-debug.log** should be added on .gitignore file


`jvDestCur.append(systemCurrencyCode());` (from SystemParameters.h which is included almost everywhere...)


Usercredentials NIE auf der Konsole ausgeben! Höchsetsn zum Debuggen, aber nicht zum committen.


can you also check the other gui inset properties in the event connection?


Is there a possibility of revisiting this decision? I was about to make a pull request to re-instutite the headline per channel concept, as we need different headlines for the channels web, mobile and social to match the current functionality of WaPo.com.


are the docs available on the web?


This also seems to be a new error case...?


Das hatte ich eigentlich einen commit vorher hinzugefügt. Warum hast du das wieder weg gemacht?


101064176-AddCO2DemandControlledVentilation (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1276 of 1276 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


There must be a lot more patches before Ntop will build on Windows :cry:.


можно переделать на спаны или псевдоэлементы (::before, ::after)


I still don't understand what you mean when you say "ModuleDeployer would specify which partition index to use". The ModuleDeployer cannot specify anything for a particular instance, only shared properties.

In terms of dynamic properties in general, I think cloud-config would be the enabler.


Thanks for the update. Just a nitpick, but please put spaces around the `&&`.


1. NO hardcoded strings!  How did this get in here?!  It needs to go into JsonFields!

Also - this line is confusing.  What about
`jvStatus["destination_tag"] = bool(sleDest->getFlags () & lsfRequireDestTag);`

which indicates your intention (perform `&`, make it a boolean) better.


since `absolutize_url` seem's to be a variable name, could we choose a non-verb name? for example:
`absolute_url` or `absolutized_url`


quibble:  `status = valid ? doUpdate (cache, true) : jvStatus;`


"Declaration 'extends' clause", then?  (I assume you inadvertently omitted a "not" from the last sentence.)


1. Yes, please go ahead and add `eos = NULL` for `writeChar()`. As for Windows, that's a useful bookmark to follow up on. I have a colleague who can test on a windows machine, so I'll try to figure out what kind of behavior we need for that.
2. Agreed on a customizable `sep` the way that you describe it, and I'd be glad for your help implementing! Though I might suggest starting a separate pull request from this one. I'd like to merge in the typo-fixes and linux changes for this PR right away.
    - as for separation, I can foresee wanting to have it manually add double line breaks for display in something like markdown, or `;` for certain types of scripts. In any case, I think offering the system-appropriate line break as default, maybe `NULL` as no linebreak at all, and then allowing a custom override should cover those use cases...?


Thank you!


TeamCity pull requests :: netty [Build 142](https://garage.netty.io/teamcity/viewLog.html?buildId=913&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5186, ignored: 21 Build time: 00:53:42


TeamCity pull requests :: netty [Build 143](https://garage.netty.io/teamcity/viewLog.html?buildId=914&buildTypeId=pulls_netty&guest=1) is now running


Typo


While I don't object to this, it sure would be nice if you could say "ignore debian/* except for these select files"; stuff under debian/ tends to reproduce without bound


`input[type=radio]`


It's easy to get them. Just use a website which converts name to uuid.


canola mis spelled.


Nice description.  Thank you.  I will never remember it otherwise.


:stuck_out_tongue: lol


Noticed this on the other commit, but figured that you had probably caught it.


I'm in the process of merging all the various branches into master. I think elm-compiler/master and elm-make/next are the ones that work together right now. elm-compiler/next is probably going to die / become master soon.


Sorry for the disorganization on this!


I'm not clear on the relationship to `str:connect` here. Can you explain?


Well, I'd encourage you (and everyone) to use Error Prone for building Immutables: http://errorprone.info/docs/installation (along with `-Werror`)

It also flags errors with the use of `@GuardedBy` when using `@Value.Lazy` BTW; while the code looks safe, maybe this is misusing the `@GuardedBy` annotation (can't really tell, JCIP discourages double-checked locking, so who knows what the intent really was, but the way it's used in Immutables sure makes it hard for a static analyzer to validate that all accesses to the annotated fields are guarded by a lock; indeed the first check in the double-checked lock is not, and neither the `return`). See http://errorprone.info/bugpattern/GuardedByChecker
Note that in my case, I could easily replaced `@Value.Lazy` with `@Value.Derived`.


@NyKaren Acho que sua brach n estava atualizada, o fluxo normal é uma branch sair da master e voltar pra ela, essa branch contato é praticamente bisneta da master :astonished:,  isso n pode acontecer


`background-image`


wow


OK, thank you. If I'll not forget about that I'll use monotonic time next time I'll be working on some benchmark.


Not yet, but it's in the repo, already compiled. You can access it locally.

2015-08-28 20:03 GMT+02:00 Michaël Zasso <notifications@github.com>:

> are the docs available on the web?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NPellet/jsGraph/commit/765f9fdfa9b04ad78a4906c5936e617aa764ae31#commitcomment-12953253>
> .
>


OK, that’s cool… I’ve been making modernization passes myself (before a couple months ago it wasn’t even using ARC), but still have a lot to do, so I may pull some of your modernization changes.

However, it looks like you’ve been using Xcode 7, and I would prefer to keep the project in Xcode 6 format until Xcode 7 is officially released and I’ve verified that builds using the iOS 7 SDKs are stable.

By the way, the “.png” extension in the filenames were there because you still needed it in IOS 3; removing them now is a good idea.  But why did you move the refresh icons (and only those) into xcassets? Your comment mentioned making them “safe”…?

Craig

> On Aug 27, 2015, at 6:19 PM, MaddTheSane <notifications@github.com> wrote:
>
> I'll admit to picking up a project and trying to port different parts of it to Swift, or just modernize it in general. It's mainly a learning experience for me.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/MaddTheSane/iosfrotz/commit/c57e97a88f784d7af2e95ffbb9ba2337a3b48005#commitcomment-12938096>.
>


отлично!


Also, we might want to make this a `GATKException`


Thanks for the PR, this idea to use project's version as the label feels good.

Couple of comments, though:

`System.currentTimeMillis()` would be equal to `new Date().getTime()` and arguably a little clearer.

However, perhaps it would be better to use formatted time-stamp as previously: if you have to debug some problems, it's nicer to see `20150828T180244` than `1440784964`. Maven does similar thing with snapshot timestamps (although, I believe it uses `.` as separator instead of `T`, perhaps we could do the same.) Also, perhaps it would be a good thing to replace the `-SNAPSHOT`-suffix with timestamp. So to follow Maven, `1.2.3-SNAPSHOT` would turn into `1.2.3-20150828.180244`.

Sounds good? If you'll make these changes and upgrade the PR, I'll merge. (At the same time, perhaps the title of the PR could be updated, since the main thing is not the AWS version upgrade, but this change.)


I don't understand this change. The pickers have the SELECTED_ALPHA too in Material. Can it be reverted? (I can create the PR if it's needed)


Üblicherweise wird das PW beim register 2 mal gefordert, da man sich ja vertippt haben könnte.


@ctrueden  should  the
@override
go here?


Of course the commit message is a mistake, I meant `__find_jail_all`.


Wow. This is a really sweet implementation of this. Nice job!


I believe that's only a result of the migration to NGS (which happened in May 2011). There are about 10 times as many rows in artist_credit as there are in artist itself, so there can't be a 1:1 mapping.


@ctrueden  should  a second
@override
go here, also for this constructor of the method?


So war das eigentlich nicht gedacht - ja, das kann man so machen, aber schöner wäre es doch, das in einem seperaten Formobjekt zu haben.


I had looked at doing this, But was trying to keep the changeset smaller for merging to master.


s.o.


fix #13


`utils.variant` might be a better home for these classes


I agree this is questionable. However, the reference is initialized with the distance stored in the problem. The rationale is that if the distance is changed in the problem, it is automatically changed in the roadmap. As long as the problem exists, this reference makes sense.


Looks good to me.
```
$ zsh -c 'LSST_HOME=`dirname "$0:A"`; echo $LSST_HOME'
/home/jhoblitt/tmp
```


Nanoquibble: comma after equal!


master doesn't look all that different.


this line is pure awesomeness!


Thanks! I'll update our rules.


Oh I thought you meant `str::connect` when you said "previous deprecation", where you referring to something else?


Sweet! Congrats and thanks for all the hard work @chrismccord


What's our policy on line wrapping in docstrings?


>  The ModuleDeployer cannot specify anything for a particular instance, only shared properties.

ok, I get it now. I am wrong as I thought we have a control on specifying the instance specific properties.


Thanks. It was fun to get a chance to dig in and see how providers work in angular a bit.


If `minGQ` is inclusive and `maxGQ` is exclusive, do we have a problem if `minGQ == maxGQ`?


Should probably fix this line to also say StaSetEncryptionResp instead of wfaStaGetBSSIDResp


eigentlich müsste genau hier ein `return false;` hin


@mosra Is this going in the right direction?


TeamCity pull requests :: netty [Build 141](https://garage.netty.io/teamcity/viewLog.html?buildId=912&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 1 (1 new), passed: 3608, ignored: 12 Build time: 01:30:28
### Failed tests
```
io.netty.channel.local.LocalTransportThreadModelTest2.testSocketReuse: <no details avaliable>

```


Also its -> it's


@chalkie666 Lean on Eclipse. It will issue a warning everywhere an `@Override` would be appropriate, but is not declared.


follow-up #5


Initially, I had hard line breaks, but they were partly removed by whatever thing that processed them so when asking for help in the REPL it looked ugly.


ok, I fixed it on my local branch, it will be part of the open PR after I
force push

On 28 August 2015 at 18:45, Curtis Rueden <notifications@github.com> wrote:

> @chalkie666 <https://github.com/chalkie666> Sorry, they go in the javadoc
> of the class. So e.g.:
>
> /** * A whizbang to jumble quarks. * * @author Curtis Rueden */public class WhizbangQuarkJumbler {
>   ...
> }
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chalkie666/Colocalisation_Analysis/commit/8c31f7fe52b711bd75db63fcddc766cefbc3c29a#commitcomment-12951886>
> .
>


Edited and sending to Ready for editing


cool, I will watch for that.

On 28 August 2015 at 20:20, Curtis Rueden <notifications@github.com> wrote:

> @chalkie666 <https://github.com/chalkie666> Lean on Eclipse. It will
> issue a warning everywhere an @Override would be appropriate, but is not
> declared.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chalkie666/Colocalisation_Analysis/commit/7a42ae5e02ed7666dad3dd4affa195106a89ac63#commitcomment-12953591>
> .
>


TeamCity pull requests :: netty [Build 144](https://garage.netty.io/teamcity/viewLog.html?buildId=916&buildTypeId=pulls_netty&guest=1) is now running


Octree (DeadParrot) - x86_64-MacOS-10.9-clang: OK (1807 of 1807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks for the comments.

I have to say that even though I understand each step, I still find the overall idea opaque... you could be pulling all sorts of shenanigans here.  ;-)


Explain (in a comment) why we initialize `end` to -1 (and to `getStart() - 1` in the other constructor)


I mean, not "you" but this area of code...


So funktionieren prepared statements nicht. GANZ GEFÄHRLICH HIER! Machs wie oben, das hat einen Grund! (ich kann hier einen user z.B. `'); DROP TABLE users;` nennen.. Was dann passiert kannste dir ja ausdenken..)


1. Okie doke. Re: Windows, I have a Win8 partition on my laptop and will switch over to take it for a spin later on
2. :+1:
 - Gotcha :-)


worker setup and teardown should happen only once per execution of the program, rather than once per invocation of ProcessFile()


fix bug 1207874


I don't think we put the extra spaces between braces for uniform initialization.


it's copy paste, remove it if you want


`GATKException`?


> On Aug 28, 2015, at 12:10 PM, ifrotz <notifications@github.com> wrote:
>
> OK, that’s cool… I’ve been making modernization passes myself (before a couple months ago it wasn’t even using ARC), but still have a lot to do, so I may pull some of your modernization changes.
>
> However, it looks like you’ve been using Xcode 7, and I would prefer to keep the project in Xcode 6 format until Xcode 7 is officially released and I’ve verified that builds using the iOS 7 SDKs are stable.
>
> By the way, the “.png” extension in the filenames were there because you still needed it in IOS 3; removing them now is a good idea. But why did you move the refresh icons (and only those) into xcassets? Your comment mentioned making them “safe”…?
>
Simply put, with the .png extensions, the files weren’t showing up in the Interface Builder since I migrated the images to xcassets. I have yet to actually run the app in a simulator (since I don’t have a paid developer account and access to iOS 9).
> Craig
>
>
>
> > On Aug 27, 2015, at 6:19 PM, MaddTheSane <notifications@github.com> wrote:
> >
> > I'll admit to picking up a project and trying to port different parts of it to Swift, or just modernize it in general. It's mainly a learning experience for me.
> >
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/MaddTheSane/iosfrotz/commit/c57e97a88f784d7af2e95ffbb9ba2337a3b48005#commitcomment-12938096>.
> >
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/MaddTheSane/iosfrotz/commit/c57e97a88f784d7af2e95ffbb9ba2337a3b48005#commitcomment-12953413>.
>


делай абсолютные ссылки


@NyKaren @pedro-guimaraes ainda falta os campos `createAt` e `UpdateAt` em algumas tabelas.
Vocês entenderam a finalidade destes campos?

Assim como o `updateBy`, armazenará o Id da ultima pessoa que editou, esses dois campos armazenarão informações importantes como a data de criado e quando foi a última atualização. Por isso todas as tabelas, exceto `user`, precisarão destes campos.

Fazendo isso já podem abrir um `pull request`


Broke streams. Investigating...


@mikejolley: Should this be `stristr()` for case insensitive matching?


File a jira with the details of what is desired here for later.


зачем здесь этот аргумент? ведь контроллеры и так получают папку заблонов через конструктор.


Also, scaling up with partitioned streams is a little complex - since both the producer and consumer side need to become aware of the change (except for Kafka, where the partitioning strategy is based on the target topic's partition count, not the consumer count).


nproc is a linux specific command.  You should move this into the per host type setup section above (see where ${host} is assigned)


I didn't mean to do this, I was just searching for the bug and forgot to revert it back sorry.


You can find them all as follows:
* Open the Problems view (Window > Show View > Problems)
* Click the little downward white triangle on the upper right of that pane
* Choose Show > "Errors/warnings on selection"
* Click the white triangle again
* Click "Configure contents..."
* On the right side, under Description, select Text contains and write "Override" in the text field
* In Package Exploerer, select the top level of the Colocalization_Analysis project tree
* Now your project view shows all `@Override` opportunities!
* Select them all in the Problems view
* Right click, choose Quick Fix
* You should see "Add missing @Override annotation" as the selected fix
* Click Finish to do it
* Now all your @Overrides have been added
* Click the white triangle again in Problems view
* _Remove the "Override" text from the Text description filter!!!_ Very important to avoid accidentally hiding other errors/warnings later.


What does this mean? So we'd just benchmark and profile the 'nothing has changed' case?


I feel I do this in the next few lines.  I added another entry: "You write a combination of CSS and SassScript, which compiles to proper CSS."  Is that sufficient?


I remember this code pattern, I've read this before, but I still find this opaque.  Sigh.

But a question here.  How do you know that `raSrcAccount` isn't empty, now it's optional?


Based on other discussions, we should focus this on the 'jvm-component' plugin.


Consider bringing the ternary out as a separate local variable for readability!!


> On Aug 28, 2015, at 1:24 PM, MaddTheSane <notifications@github.com> wrote:
>
> Simply put, with the .png extensions, the files weren’t showing up in the Interface Builder since I migrated the images to xcassets. I have yet to actually run the app in a simulator (since I don’t have a paid developer account and access to iOS 9).

I thought you only needed a paid developer account to deploy to actual devices, not the simulator.
So you can at least run the simulator for iOS 8.x, right?

My question was, why did you migrate just those two images to xcassets, but no others?  Was it just a start, or were those two im particular causing problems?

Craig


So if I create this relationship: `artist_credit_names = relationship("ArtistCreditName", innerjoin=True)`
...would I want to use `artist_credit_names.artist_credit.ref_count`?  That would still give me the same value  as my previous attempt, right?  ...or do I need to use a `transformfunc=sum` to add up the ref_counts from each tuple (if there is more than one)?

Does the '.' in `artist_credit_names.artist_credit` create a join? (I'm still not entirely sure how the paths work in `sir/sir/schema/__init__.py`)


Great idea. I'll do that for the next exercises - like you did with railless-sass.  I felt that was more complex, but I have been a bit frustrated doing a lot of edits in CodePen.


TeamCity pull requests :: netty [Build 143](https://garage.netty.io/teamcity/viewLog.html?buildId=914&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4725, ignored: 16; resource leak detected (new) Build time: 00:21:29
### Failed tests
```
io.netty.handler.codec.http2.InboundHttp2ToHttpAdapterTest.serverResponseHeaderInformational: <no details avaliable>

```


Document that the median is rounded


(probably not your code but...) `transHuman`?  When did this appear?  It's like an attempt to be distracting - what's wrong with `to_string`??


TeamCity pull requests :: netty [Build 144](https://garage.netty.io/teamcity/viewLog.html?buildId=916&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4725, ignored: 16; resource leak detected Build time: 00:08:49
### Failed tests
```
io.netty.handler.codec.http2.InboundHttp2ToHttpAdapterTest.serverResponseHeaderInformational: <no details avaliable>

```


Maybe consider moving this warning into the paragraph describing nested widgets?


There is a way to do that with .gitignore: the `!` prefix means "*don't* ignore this file/directory"


I may actually remove it. It's not used anywhere, and the API does not provide kelvin option too. In fact I do not really know why I have included it...


extract out the subexpression pls. with a documentary name...


yes


updated


FIXME!


This is not the canonical way to write golang unit tests.  Generally, TestMain() is unnecessary, you should make a set of TestFoo(t *testing.T) {} functions and t.Fatalf() if a test fails and you want to abort the testcase, or t.Errorf() if a test fails and you want to continue.  The infrastructure does the rest.  Good examples available around.


Even with the check I sometimes got three Stealth Rock setters, probably because no moves left? So, this is for the better.

Yeah, I got a Snow Cloak Articuno in a battle when Pressure would have been very useful.


This change can create unnecessary objects if an Encoder doesn't register any data or signal dependencies. The early exit (L79) was added for this case, and made a noticeable difference to the job voyager performance to me. Did you not notice any difference?


Awaiting them


Protective copy?


Not sharing too much.


Is there any reason why the rootmenu * wasn't added to and externed from logic_bridge.cpp/h like the other global classes from logic, instead changing all of the rootmenu-> to logicore.rootmenu-> ?


thanks :)


Are you thinking making a pull request?


yes.  Do you want me to make the change now, or later?


What if the constructor that sets `startingVC` to null was used, and then `isContiguous()` is called?


You have this code fragment `STAmount(mDstAmount.issue(), STAmount::cMaxValue, STAmount::cMaxOffset)`

Extracting it as a little method would document what it was doing... :-)


WOW :)


Here too -- what if `startingVC` is null?


The comment doesn't tell you anything new!


Or this one!