 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_snapshot/test_backup_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_100_snapshots_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_backup_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_100_snapshots_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_backup_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_100_snapshots_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|295|0|4|0|291


ok then, my bad


I experimented. But now I don't show it. I return to the original code.


That random button is an awesome idea!


Very cool, look forward to seeing the final draft :)


I just realized which column that is. Are we changing contact types too now? That changes a lot more than this unit test if so.

For your purposes, you could just map `contact_type` to `Communication Type`.

Relevant lines: https://github.com/DirectEmployers/MyJobs/blob/quality-control/myreports/views.py#L314-L316


What is a copy of an attribute?


Why are you always tagging such a weird name if you mean me, @Silox? Also, just use python 3 everywhere.


nullable comment? I guess its not possible yet?


What needs to be done here? basically pyart most provide this functionality. I'm on that.


Yes, that is the least common denominator so they can be linked from all
supported VS versions.
On Aug 4, 2015 6:52 AM, "John Barbero Unenge" <notifications@github.com>
wrote:

> These binaries has a dependency on VC90CRT, is this intentional?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pocoproject/poco/commit/6ef38bff0ba5c111f246d1eb997fc61e26e972ff#commitcomment-12514168>
> .
>


`def dotDotDollarName = ...`


Hi Sebastian,

Could you let me know the cluster and directory where you’re running, and if possible a command that demonstrates the problem?

> On Aug 4, 2015, at 9:07 AM, SebastianKhan-LIGO <notifications@github.com> wrote:
>
> I've noticed that when trying to run a sngl detector analysis then one of the errors I get is the following
>
> File "/home/spx8sk/git/lal_branches/master/install/lib/python2.6/site-packages/PyCBC-c25007-py2.6.egg/pycbc/events/threshold_cpu.py", line 102, in init
> self.outv = numpy.zeros(self.outlen, numpy.complex64)
> ValueError: negative dimensions are not allowed
>
> I think it has something to do with the code around here....
>
> —
> Reply to this email directly or view it on GitHub.
>


One of the screenshots in the ticket says "Contact Type" should say "Communication Type"

https://directemployersfoundation.atlassian.net/browse/PD-1523


@jdegoes !!!

Need to test it now, but the types work out at least - I'd made a mistake in `QueryF` - that's where my required `p` was going missing.


It's better to use `set_target_properties` instead of setting `CMAKE_CXX_FLAGS`. Also the clang check can be added to the condition above:

```
if (FMT_PEDANTIC AND
   (CMAKE_COMPILER_IS_GNUCXX OR (CMAKE_CXX_COMPILER_ID MATCHES "Clang")))
  set_target_properties(cppformat PROPERTIES COMPILE_FLAGS
    "-Wall -Wextra -Wshadow -pedantic")
endif ()
```
or something like that.


ist cool


should we `_update_infolabel` just in a strong change and not none radar?


tt


Changed.


I suggest moving this a method to https://github.com/xeno-by/scalameta/blob/master/scalameta/src/main/scala/scala/meta/internal/parsers/Parsers.scala#L528, because you're going to need it on line 918 as well, to make sure that `T with ..$tpes` works as well :)


x


Would also need to change the helpers as well: https://github.com/DirectEmployers/MyJobs/blob/quality-control/myreports/helpers.py#L111


static?


The `fileContent` variable is useless now, and can be removed.


Send text in the email as a text file


can this be a function or something besides a #define?


Hi Larne,

I am running this on the arcca cluster at cardiff.

The running directory is

/home/spx8sk/runs/test1/1102089616-1102100616/

Here is the command line output from
running

pegasus-analyzer --indent 1  -d
/home/spx8sk/runs/test1/1102089616-1102100616/pycbc-tmp.fbLjx28zDM/work/main_ID0000001.000
--top-dir
/home/spx8sk/runs/test1/1102089616-1102100616/pycbc-tmp.fbLjx28zDM/work

it's quite long sorry!

Thanks!

[spx8sk@raven14 er7_uberbank_phenomD]$ pegasus-analyzer --indent 1  -d
/home/spx8sk/runs/test1/1102089616-1102100616/pycbc-tmp.fbLjx28zDM/work/main_ID0000001.000
--top-dir
/home/spx8sk/runs/test1/1102089616-1102100616/pycbc-tmp.fbLjx28zDM/work

************************************Summary*************************************

Submit Directory   :
/home/spx8sk/runs/test1/1102089616-1102100616/pycbc-tmp.fbLjx28zDM/work/main_ID0000001.000
Total jobs         :    100 (100.00%)
# jobs succeeded   :     13 (13.00%)
# jobs failed      :     10 (10.00%)
# jobs unsubmitted :     77 (77.00%)

******************************Failed jobs'
details******************************

===========================inspiral-H1_ID3_ID0000015============================

last state: POST_SCRIPT_FAILED
      site: local
submit file: inspiral-H1_ID3_ID0000015.sub
output file: inspiral-H1_ID3_ID0000015.out.015
error file: inspiral-H1_ID3_ID0000015.err.015

-------------------------------Task #1 -
Summary--------------------------------

site        : local
hostname    : raven320.bullx
executable  :
/home/spx8sk/git/lal_branches/master/install/bin/pycbc_inspiral
arguments   :   --segment-end-pad   16   --cluster-method   template
--low-frequency-cutoff   30   --pad-data   8   --sample-rate   4096
--chisq-threshold   10.0   --segment-start-pad   112   --psd-segment-stride
  128   --filter-inj-only   --psd-inverse-length   16
--psd-segment-length   256   --processing-scheme   cpu   --snr-threshold
6.0   --segment-length   512   --chisq-delta   0.2   --approximant
SPAtmplt   --psd-estimation   median   --maximization-interval   30
--strain-high-pass   30   --order   7   --chisq-bins   16   --channel-name
  H1:GDS-FAKE_STRAIN   --gps-start-time   1102089624   --gps-end-time
1102095512   --trig-start-time   1102089736   --trig-end-time   1102095164
  --output   110208/H1-INSPIRAL_JOB2-1102089736-5428.xml.gz   --frame-files
  110208/H-H1_ER_C00_AGG-1102089472-256.gwf
110208/H-H1_ER_C00_AGG-1102089984-256.gwf
110209/H-H1_ER_C00_AGG-1102090496-256.gwf
110209/H-H1_ER_C00_AGG-1102090752-256.gwf
110209/H-H1_ER_C00_AGG-1102091008-256.gwf
110209/H-H1_ER_C00_AGG-1102091264-256.gwf
110209/H-H1_ER_C00_AGG-1102091520-256.gwf
110209/H-H1_ER_C00_AGG-1102091776-256.gwf
110209/H-H1_ER_C00_AGG-1102092032-256.gwf
110209/H-H1_ER_C00_AGG-1102092288-256.gwf
110209/H-H1_ER_C00_AGG-1102092800-256.gwf
110209/H-H1_ER_C00_AGG-1102093056-256.gwf
110208/H-H1_ER_C00_AGG-1102089728-256.gwf
110209/H-H1_ER_C00_AGG-1102093568-256.gwf
110209/H-H1_ER_C00_AGG-1102093824-256.gwf
110209/H-H1_ER_C00_AGG-1102094080-256.gwf
110209/H-H1_ER_C00_AGG-1102094336-256.gwf
110209/H-H1_ER_C00_AGG-1102094592-256.gwf
110209/H-H1_ER_C00_AGG-1102094848-256.gwf
110209/H-H1_ER_C00_AGG-1102095104-256.gwf
110209/H-H1_ER_C00_AGG-1102093312-256.gwf
110209/H-H1_ER_C00_AGG-1102090240-256.gwf
110209/H-H1_ER_C00_AGG-1102095360-256.gwf
110209/H-H1_ER_C00_AGG-1102092544-256.gwf   --bank-file
H1-TMPLTBANK_SPLITTABLE_BANK2-1102091411-2048.xml.gz   --user-tag   JOB2
exitcode    : 1
working dir :
/home/spx8sk/runs/test1/1102089616-1102100616/work/main_ID0000001

------------Task #1 - inspiral-H1_ID3 - ID0000015 - Kickstart
stderr------------

/software/tools/pyenv/versions/2.6.6-ligo-pycbc/lib/python2.6/site-packages/numpy/lib/utils.py:134:
DeprecationWarning: `scipy.weave` is deprecated, use `weave` instead!
  warnings.warn(depdoc, DeprecationWarning)
Traceback (most recent call last):
  File "/home/spx8sk/git/lal_branches/master/install/bin/pycbc_inspiral",
line 4, in <module>
    __import__('pkg_resources').run_script('PyCBC===c25007',
'pycbc_inspiral')
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 735,
in run_script
  File "build/bdist.linux-x86_64/egg/pkg_resources/__init__.py", line 1652,
in run_script
  File
"/home/spx8sk/git/lal_branches/master/install/lib/python2.6/site-packages/PyCBC-c25007-py2.6.egg/EGG-INFO/scripts/pycbc_inspiral",
line 241, in <module>
    gpu_callback_method=opt.gpu_callback_method)
  File
"/home/spx8sk/git/lal_branches/master/install/lib/python2.6/site-packages/PyCBC-c25007-py2.6.egg/pycbc/filter/matchedfilter.py",
line 155, in __init__
    window))
  File
"/home/spx8sk/git/lal_branches/master/install/lib/python2.6/site-packages/PyCBC-c25007-py2.6.egg/pycbc/events/events.py",
line 64, in __new__
    return real_cls(*args, **kwargs)
  File
"/home/spx8sk/git/lal_branches/master/install/lib/python2.6/site-packages/PyCBC-c25007-py2.6.egg/pycbc/events/threshold_cpu.py",
line 102, in __init__
    self.outv = numpy.zeros(self.outlen, numpy.complex64)
ValueError: negative dimensions are not allowed

On 4 August 2015 at 14:50, Larne Pekowsky <notifications@github.com> wrote:

> Hi Sebastian,
>
> Could you let me know the cluster and directory where you’re running, and
> if possible a command that demonstrates the problem?
>
> > On Aug 4, 2015, at 9:07 AM, SebastianKhan-LIGO <notifications@github.com>
> wrote:
> >
> > I've noticed that when trying to run a sngl detector analysis then one
> of the errors I get is the following
> >
> > File
> "/home/spx8sk/git/lal_branches/master/install/lib/python2.6/site-packages/PyCBC-c25007-py2.6.egg/pycbc/events/threshold_cpu.py",
> line 102, in init
> > self.outv = numpy.zeros(self.outlen, numpy.complex64)
> > ValueError: negative dimensions are not allowed
> >
> > I think it has something to do with the code around here....
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ligo-cbc/pycbc/commit/1363f6725d94c09920bab20985414a4f9e70fd35#commitcomment-12517027>
> .
>

--
Sebastian Khan
Postgraduate Student
Gravitational Physics Group

School of Physics & Astronomy
Queens Buildings, The Parade
Cardiff, CF24 3AA

Email: sebastian.khan@astro.cf.ac.uk
Phone: (+44) 29 208 75120


What I mean is that using SHARED root is not necessary for what we are trying to achieve. Same can be achieved by doing simple chroot() and not using namespace at all. So why not enable that shortest path atleast for the case of SHARED.

Exporting Privatefs so that user can set it to false should be good enough for the case of SLAVE root.


The message is a great idea


5058-fix-readvars-cli (mbadams5) - x86_64-MacOS-10.9-clang: OK (1774 of 1774 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I did a bit more digging to add more information about why we were using the `packageDocumentUrl`.

The `packageDocumentUrl` is used to load the package document in order to pass it to functions in the in the readium-cfi-js. The raw package document is then used with jQuery selectors to build various CFI parts inside readium-cfi-js.

The quick solution is to give access to the raw document that was parsed by Readium, but there is a longer term question with respect to the readium-cfi-js and how to deal with the disconnect. If the package document was already parsed, loaded, and validated should `readium-cfi-js` be working with the raw document at all?


For some reason presto guys use parseTypeSignature here. Probably to be able to easily change implementation of type without changing many code places.


FYI: this is the roi (radius of influence) option of `pyart.map`, not artview roi


@uronce-cc Do you think it's better to create a new `package.info`  in `tachyon.worker.block.evictor`or use the existing `package.info` in `tachyon.worker` ?


Ahh… nice


According to the issue description at https://forge.typo3.org/issues/67595 this worked at least in 7.2.

Agreed with the dependency: let's set 7.3.1 as a minimum for installing ext:beautyofcode in 7.x.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.453](http://teamcity.monogame.net/viewLog.html?buildId=9355&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Why is this code only commented out?


Why not use iterator instead of looping twice?


To cover all cases, we can have separate `try` `finally` blocks for the input and output streams, immediately after each's initializations. That way, both of them are guaranteed to be closed in all situations.


Looks good


In the latest version of cstimer, the number of sessions is:
N = JSON.parse(localStorage.getItem('properties')).sessionN
and all of the sessions are: session1, session2, ..., sessionN


you mean below. right?


Schaut gut aus. Das sind die Änderungen, die wir vorgenommen haben. Aber sind das alle Änderungen? Wir haben die englische und deutsche Seite bearbeitet. Na, mal sehen wie es live aussieht.


It used to be `topic.category_names || [@props.category]`.
Now it doesn't look for `@props.category` and I wonder if it won't break anything.


Eu comentei para usar futuramente. Mas por enquanto ele está configurado no arquivo parameters.yml


Changes in: https://github.com/dmsurti/mayavi/commit/b5e59f7f359c4eb9a8160d2ee69f251d6d8e15c1


Foi uns testes para passar informações de conexão do banco via docker.


Not really a fan of the new name


Новым переменным лучше бы задать исходное значение во избежание конфликтов)


```diff
diff --git a/myreports/helpers.py b/myreports/helpers.py
index ede0b95..1f5baaa 100644
--- a/myreports/helpers.py
+++ b/myreports/helpers.py
@@ -80,7 +80,11 @@ def serialize(fmt, data, values=None, order_by=None):

     # helper function to deal with different value types in a dict
     def convert(record, value):
-        val = record[value]
+        if value == 'communication_type':
+            val = record['contact_type']
+        else:
+            val = record[value]
+
         # strip html from strings
         if isinstance(val, basestring) and val.strip():
             val = html.fromstring(val).text_content()
diff --git a/myreports/views.py b/myreports/views.py
index bbe08a2..0228398 100644
--- a/myreports/views.py
+++ b/myreports/views.py
@@ -274,7 +274,12 @@ def downloads(request):
                          if field not in blacklist[report.model]])

         values = json.loads(report.values) or fields
+        if 'contact_type' in values:
+            values[values.index('contact_type')] = 'communication_type'
+
         fields = values + [field for field in fields if field not in values]
+        if 'contact_type' in fields:
+            fields[fields.index('contact_type')] = 'communication_type'

         column_choice = ''
         sort_order = ''
```

Not suitable for direct application as it's based on my other work ,but should give you an idea.


вот тут


Why the type checking?
` opts = opts || {};`

if you want to do proper type checking for object, you could do:
`Object.prototype.toString.call(opts) == '[Object object]`

Array, Function and Object primitives are all objects in JS.


@tritao I guess it works on both C# and C++/CLI. Will write tests for C++/CLI too and submit a PR.


shouldn't that be https://waffle.io/blendervr/source ?


nearby, I am not sure what is the convention

2015-08-04 15:58 GMT+02:00 Łukasz Osipiuk <notifications@github.com>:

> you mean below. right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TeradataCenterForHadoop/presto/commit/52aad7402fcb85886d8ac6e5354eb6e06c31b493#commitcomment-12517248>
> .
>


This is a cmake bug that @godbyk knows about and submitted a patch for (?)


Не совсем понятен смысл переменной StoneRogue: Boolean, которой потом присвоено значение False, все крутится с if StoneRogue = False then StoneRogue := False


This condition will still never be met


The packet names here are different too, but if it works it works.

On Tuesday, August 4, 2015, RandomAltThing <notifications@github.com> wrote:

> @DefinitlyEvil <https://github.com/DefinitlyEvil> It should be similar -
> dont the packet ids need to be the same for this software to correctly
> work? And apprently you convert pc packets to pe ive heard so thats harder
> for me to port packets -_-
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DragonetMC/Dragonet/commit/2cbacb59399cb34959dc9f48f402d5dc04173b0c#commitcomment-12515415>
> .
>

--


Awesome stuff. :+1:   I was expecting some bugs to stay but looks like all problems are gone. I was trying to get it fixed for months and finally @gabest11 is my saviour. I wonder how hard it will be to port this  to HW mode?


We need to support date filter and pagination. See https://github.com/transmart/transmartApp/blob/b1f9eb5e348b4e475deba4015c3bcd3ca64ee964/grails-app/controllers/AccessLogController.groovy#L52


Typically when looking to encapsulate cell configuration logic from a view controller, it is done by subclassing the cell and placing the logic there.

Why not take that approach here?

I was a little confused when I looked at this class at first, and it took me a second to understand how it fit in.
It just starts to look a little weird here when you have something called a "controller" but doesn't own or even keep references to the objects it controls.


@bgoodmon Does MIRA still upload videos correctly if you make this change?


Are they broken?


this should probably be under the `train-42` branch (`train-42` should get the changes) and not `train-42.1`, we never hard `.1` branches before
cc @jrgm @shane-tomlinson


@jython234 Are you whatching dragonet or something?


> One more PR, color the bars red/green based on outcome, so the faster red
> builds are distinguished from the longer green builds.

Good idea!

> > In the first chart, I think your time agrees with the rollup time in
> > Travis, but both are wrong :) They show the sum of the times of the
> builds,
> > which is the right number if you want to know how many worker-hours were
> > spent, but not interesting to the developer. And I could lower that
> number
> > without improving developer's life (like removing all but the slowest
> > build) and I could improve developer's life without affecting that number
> > (like moving work from the longest build to the shortest).
> >
> > I would rather see the elapsed time from the first build starting to the
> > last build completing. I wish Travis would change that too. Maybe a good
> > bug report to send them?
>

I agree that the total build time (sum of all build jobs) isn't the key
metric you'd want to focus on. As you mention, this is heavily influenced
by the number of build jobs (build matrix),if they pass or not, or how the
build jobs are configured to behave (fe. in your project less tests are run
on PR).

But the same applies to the elapsed time (start of first until end of
last). This metric is influenced by the number of workers that are assigned
to a build. I can imagine that on busy moments, the elapsed time will be
larger than on more quite moments when more workers can be assigned. So it
could be a nice metric to see if Travis is under load... ;)
But as a developer you don't have much influence over this metric.

The total build time (whether accumulated time of all build jobs, or
ellapsed time between start and finish) is just a metric that can indicate
something is wrong in a buildprocess (fe. a build job failing, or some
timeout), and can be a starting point to start investigating what happened,
but it is influenced by many parameters, some of which are not in control
of the developer.

More useful metrics are total duration of a build job and the duration of
the substages, at least if you compare similar build jobs, fe. those with
the same build matrix settings, ...
I guess, that as a developer this is what you are interested in most.

In that regard, a chart that shows build job duration grouped by fe. build
matrix settings can be useful. That way you can easily see if a certain
build job takes more or less time than usual, or if there is an increasing
or decreasing trend in build job duration.

In the future I hope to add some checks that compare the build job duration
to similar build jobs in the past, and see if it behaves as expected, and
trigger an alert if a build deviates from the expected trend.

As for the Travis timing, feel free to send them a feature request to show
elapsed time. :)


@bgoodmon What are you trying to do here?


83785560WtoAirHP_ExampleFiles (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1266 of 1266 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.98%25-green.svg)


youps :)

just modified it, thx

> Le 4 août 2015 à 16:02, Dalai Felinto <notifications@github.com> a écrit :
>
> shouldn't that be https://waffle.io/blendervr/source <https://waffle.io/blendervr/source> ?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/BlenderVR/manual/commit/8daea49c751d98c40ed8c4832797f911436daf4e#commitcomment-12517335>.
>


The same kind of weasel-wording as "implements the same interface". I don't really feel like fixing this in a better way until IDL has a bunch improvements and we settle on how to define objects, their internal slots, their associated algorithms, etc.


Could also use `core.GenesisBlockForTesting` here.


Always do a list:flatten? Why not just insert say a '?' for unknown characters, now they just disappear?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.883.90bf7bad72d17bd0916ca41bfd688264f880c58f](http://build.palaso.org/viewLog.html?buildId=60574&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:03:42


The point is for library users to *know* they are using GLib/GObject stuff. With the `#include` in my headers, most of GLib is magically available and when people copy&paste to create a new file while removing `#include <insert a non-GLib library name, e.g. libeventd-event>.h` they wonder why `g_strdup` is not available any more!

If there was a way to shut `g-ir-scanner` warning in another way, I would use it, but I am not sure they support that use case so, let’s keep the `#include` there.


Great, sorry to see this just now, great work crabman :D


Review complete


C'mon, this isn't blocked on IDL in any way. Create a new attribute; set its local name to X; set its namespace to Y; ...


made a comment about a similar line of code:
Can we make this a NSString or function or something else besides a #define?


They seem to be on Travis. See https://github.com/mirage/ocaml-git/issues/116


I guess we'd need an anchor with random in the name?


1: M111 unrecognized component name: jsonref


Here is an error, actually reference on an automatic object. You need to store on stack Color instance returned from vtk color.


Can we go with WMFStyle to match other style classes?


He revisado la mayor parte de las traducciones del lenguaje Español España y estoy de acuerdo que un 80% de las traducciones coinciden con las traducciones latinoamericanas manejadas en el país de México. Creo que lo más adecuado sería que se incluyeran las traducciones es_ES junto con las de es_MX y yo periódicamente puedo dar revisión a los archivos para asegurar que se encuentran traducidos correctamente. Gracias. (Sugiero estos cambios ya que hasta ahora la única forma de tener Pixelmon en español es cambiando el idioma de Minecraft a España, mientras, que si se cambia a México las traducciones no se encuentran en su totalidad y Minecraft no maneja las mismas traducciones para España y México)


Would it be better to use Color::white() and Color::black() presets as in all other places of Viz?


для 3.4. просто этот файл удалять?)


Thanks to @andrewjcole


Hello


I don't see `user_id` in the main data of SubmissionModelBase.


`getScalars()`


Not sure exactly what this does - can't really tell from the name of the method. Does it get all children of a paragraph? what is a child?

I assume by sector you mean an xpath query? Is that normal path terminology?


Remove comments and commented code


Look reasonable. Did you ever get garbage characters here?
Thanks


I would keep this rule inside the fossball directory (same apply for other samples that are large enough to have subdirs).


hum, that was unintentional addition


Looks like this line is no longer needed? TGNoCameraAccessView is now part of the TGScannerView, and the outlet is unset here.


NSString?


Almost perfect, just one thing left, see inline.


`@return Tracker_SubmissionDao submission DAO`


Thanks


Why `Eventd-0` and not `EventdEvent-0`? IMO, it should match the `.pc` file, the `.so` file and so on.


Yep


Thanks for the commit. This was on my TO-DO list, as I wanted to catch Harpy up to the Swift equivalent lib, Siren. While your approach seems to solve the problem, I think I may try to make it similar to the way it was implemented in Swift:

https://github.com/ArtSabintsev/Siren/blob/master/Siren/Siren.swift#L491-L509


It has always been portable, apart from the few packingslips that Mr. Shipper generated.


sorry guys git is stupid


`@param string $uuid UUID`


use [.eslintignore](http://eslint.org/docs/user-guide/configuring.html#ignoring-files-and-directories) file for this puproses


Remove commented out code


Add newline


This is probably a stupid question, but what stops me removing this check in my pull request?


Use `NSStringFromClass([self class])` instead of hard-coding `@"TGNoCameraAccessView"`


The reason being is that I want to allow for both the A.B and A.B.C.D scenarios, but not any other ones, at least not yet. I'm a big proponent of Semantic Versioning, and would like Harpy and Siren to stick to that system.


eslintrc configs should extend root config: https://github.com/superroma/testcafe-phoenix/blob/master/test/server/.eslintrc#L2


@metaodi , thanks for your quick, sharp eyes, fixed in https://github.com/ckan/ckanext-pages/commit/7b25847c6b15023a37b0c0465a85bcf4ac0d2ba6


C is an incredibly odd choice for that, but as long as C++ header files are
available it should be extremely easy to get SWIG set up to export it.
Using that with a thin layer of target platform code (Java, C#, etc) would
let you have basically a language-native level of control over the API
without having to manually code the JNI bindings. I feel like that would be
the ideal case for Android, as you could pretty easily make a Java-only
'plugin' for the server to pass data to Cardboard, without ever having to
make JNI bindings for Cardboard (which it currently doesn't have).

I've messed with SWIG before, so I could fiddle around with it later. I'd
probably be a bit lost for the moment, since I haven't managed to get the
server up and running with my DK2 (and therefore haven't gotten to play
with any test/application code) but using SWIG for JNI would save a lot of
work in the long run, especially because you then get access to a few dozen
languages as end-targets.

On Mon, Aug 3, 2015 at 5:15 PM, Ryan Pavlik <notifications@github.com>
wrote:

> No, most of the config messages you see at CMake-time are from the nested
> build of VRPN. In this case, VRPN itself has some SWIG-based bindings that
> it's digging for. Those messages keep causing questions - will have to see
> if there's an easy way to hide them by default when we're building VRPN as
> a subproject (pretty sure the answer is yes)
>
> The main "public" APIs (pluginkit and clientkit) are both C APIs (with
> header-only C++ wrappers for those using them directly) for easy FFI -
> unsure whether the overhead of the various Java FFI systems is substantial
> enough to require a JNI binding (or if a JNI binding would let us provide a
> better mapping to the API model we essentially have to squeeze through C
> but is actually reasonably object-oriented)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OSVR/OSVR-Android-Build/commit/7407c1015389e2af8cac0c27dc7b417a6cd505df#commitcomment-12502737>
> .
>


eslint has an qunit env: http://eslint.org/docs/user-guide/configuring.html#specifying-environments


It means you will not receive any message from eventd.
The primary usage it to remove the need for a GLib event loop.
See [weechat-eventc](https://github.com/sardemff7/weechat-eventc) for an example usage.


Insert ` * void setUuid(string $uuid)`


What are you trying to release here? Just wondering if it is doing what we think.

Normally something like this would go inside of a loop that is allocating a bunch of memory. Is this method called in a loop?

Or are you trying to clean up what is created in the map function below? If so, it would probably be better to be inside of the loop so it cleans up along the way.


Just to provide a smoother user experience (whilst preserving a functional non-JS version)


Moved, see line 313.

But since moved back.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.453](http://teamcity.monogame.net/viewLog.html?buildId=9355&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:22:48


You win this time.


Да. Похоже в районе ветки 3.3-3.4 сменилась логика переопределения шаблона сообщений. Мне начали писать ошибки о сломанной верстке, в частности в модальных окнах.
Разбираться с последней версией J! особо нет времени, поэтому для безопасности пока что грохнул файл :) #хитрыйПлан


I guess you still need to fix this :P


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18684/testReport/) for this commit**


有些文件应该加入忽略列表中


`cp` instead of `mv`, or this will fail if the source is read-only. Also, probably target the specific files you care about. Something like this:
```
cp -v /opt/openshift/certs/{server.key,server.crt,ca-bundle.crt} /etc/openldap/certs/
```


`uuid.`


This method is obsolete and will be removed cleanup to follow.

Still I'll address the point of making sure output is clear in current messages.


Hi the check on pull request is to verify if the mkdocs site is built properly, however since it is a pull request we dont want to deploy the site yet.


`submission.`


This Library now has one component- ZoomableScrollView.
It extends from ScrollView and has possibility to zoom in and out using two methods:
-pinch zoom
-twice tap zoom


This value is directly passed to the underlying `GSocketClient`.
See [`g_socket_client_set_enable_proxy()`](https://developer.gnome.org/gio/stable/GSocketClient.html#g-socket-client-set-enable-proxy).
I think saying this is enough to document that function.
It was needed for [weechat-eventc](https://github.com/sardemff7/weechat-eventc) too (because weechat is not GLib main loop-based).


Use ``Maps``:

```java
Map<String, RaptorColumnHandle> columnHandleMap = uniqueIndex(columnHandles.build(), RaptorColumnHandle::getName);


@rvanburen-r7 be nice to have some unit tests added around this?

Also curious as to why we'd still need the 'default' argument


How about `properties`


Allways redirect after form success submit


I think "Place all the NuGet packages together:" should be delete too.


Me parece te felicito


Looks reasonable


Static import


The plugin context is `EventdPluginContext` and the actual definition (`struct _EventdPluginContext`) is left to the plugin itself.
The `EventdPluginCoreContext` is created in eventd and only a pointer is passed to plugin for the `eventd_plugin_core_*` functions.


This can just be a null check. An empty name won't match anything.


Yes. Thanks, Pawel!


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1263 of 1263 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why prefer git before https? Is git url better?
dthread is really just a a build dependency.
fnotify is used from the experimental uart_devices, I guess you are using it?
I can fix it, just wanted you to react before I merge.


So, it looks like this code was ripped out from the `animateViewsForState` method. Is there a reason we can't just call that method with our current state in viewDidAppear? It gets a little messy to start pulling code like this out into the `viewDid` methods.


ドキュメントがないので、確認してから。


Unnecessary local, or could be used throughout? Think I may have had to do this because SocketConnector was in another package and so didn't have access to package-protected route fields. Ditto for proxy.

You may find that by deleting SocketConnector that API methods I exposed in PR #1388 can be made private again. i.e. Address.getCertificatePinner() for similar reasons. See PR comments for what I modified.


roslib is needed: https://github.com/ipa320/cob_driver/blob/e1a5700d4d3775135580fb70fe463aaa3b2c9000/cob_mimic/src/mimic_node.py#L127!
 please test the drivers  before merge a node change, mimic doesn't work!


It might do. Weird thing the test passed. Lets explore this in the
afternoon. :)

On Tue, Aug 4, 2015 at 8:02 AM, Rodrigo B. de Oliveira <
notifications@github.com> wrote:

> Hm. I thought id stood for a message id here.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sneerteam/sneer/commit/88d27151bd613278b8656d576a77c445c5260304#commitcomment-12513324>
> .
>


Something here seems to break styling.


Nit: could be on one line.


Can't we just check isViewLoaded when the notification comes in and only reload if loaded? That is probably better than conditional observing - keeps the observation logic simpler.

Or can this be below this if statement so it always occurs when the data source is set?


When I used `EventdEvent`, the `EventdEvent` class didn't appear. My guess is that it takes the prefix, finds `""` and ignores it (without a warning).


@weierophinney I expect HTTP methods here, "GET", "POST", etc. I think we can change it to be more clear.


i did a rebase onto a public branch. #fail


@jenswi-linaro @jbech-linaro

Hi Both,

We have made some minor changes to the OPTEED as a part of implementing a new platform porting interface and reworking the PSCI implementation. APIs which accessed information using an `mpidr` passed as a parameter have been replaced with APIs that read the `mpidr` of the calling CPU internally. The assumption being that the old APIs were only ever used to access information specific to the current CPU.

Could you please have a look and ack the patch if it makes sense to you. We intend to merge the pull request early next week.

Thanks,
Achin


@aniarya82

Don't push merge commits that are not required here. This commit does not fix any conflicts. I don't understand **why the misleading commit message** was added.

Always rebase and push. I am going to take this commit **off this branch, anyway.** Update your branches, and then start working.


Is `setIntegrityCheck(false)` needed?


nice


Ditto above for route.getAddress().


TEst


eweqweqwe


Might want to consider moving fixture recording to NSURLProtocol so it can be separated from application logic. Not something necessary now, just might be a better encapsulation.


I'll make that change!


Hey @stevebluck, I'm writing a blogpost that references this PR, do you mind if I reference you in it? https://medium.com/@kentcdodds/78281ea47455


@michaelcahill, here's the commit we talked about last night. It feels kind of clunky to me, I ended up passing down `session->dhandle` and `S2BT(session)->id` as arguments to underlying functions in order to avoid doing explicit save/restore operations in those functions. Most of the ugliness is in and around `__las_page_instantiate`, please let me know if you can think of something cleaner.


Add a new error `INVALID_TABLE_PROPERTY` to `StandardErrorCode` and use that here.


OK. Thanks :smile:


Looks great, thanks!


address.uriHost + address.uriPort too.


I think this would be better as a simple else.  While `<-` is very common in R projects, many projects prefer to use strictly `=` for assignment and won't contain any `<-`.  But it is common enough it is probably fine as-is.


Or perhaps this should be `NOT_FOUND`?


Why are the ?: still here if SERVER_URL already defaults to localhost? (same thing in registerPrinter.html)

p.s. After about 20-30 years of experience in C and C++ the practice of putting multiple variable declarations on a single statement had practically disappeared. I'm not sure why it's trying to make a comeback in Javascript now.


Ok, what about `_get_name_of_expect_caller` ? Or, suggestions?


Need to lowercase here


Can you move that into sbt-auto-build please, we want that support regardless of whether or not sbt-distributables is used


sholud probably have a sensible default -- 'right'?


You Welcome!

El martes, 4 de agosto de 2015, Andrew Krawchyk <notifications@github.com>
escribió:

> Looks great, thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/diegomaximiliano/awesome-vim/commit/6e9e1d77cc37e34f494fb0494dfe5ec1f73accf4#commitcomment-12518076>
> .
>


Yes I am.

On Tuesday, August 4, 2015, RandomAltThing <notifications@github.com> wrote:

> @jython234 <https://github.com/jython234> Are you whatching dragonet or
> something?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DragonetMC/Dragonet/commit/2cbacb59399cb34959dc9f48f402d5dc04173b0c#commitcomment-12517421>
> .
>

--


I think `performance` should still be defined globally in web workers, even though `window` isn't ([in Chrome 33 and Firefox 34](https://developer.mozilla.org/en-US/docs/Web/API/Performance/now))


Start the error message with uppercase.


Same comment as above. Include the column name in the error message.


I'm glad to see the deep directory structure going away. Was never really sure why it was that way.


Yes, it is not a trivial fix. I initially attempted to properly fix this but things were not matching together (one layer needs info which is only available on a different layer, etc). This might be due to a lack of experience writing device drivers on my side, tho. But I'm certainly interested in sending a proper fix upstream.

I've just made and tested the changes proposed by @dsd and I'm updating this PR now.


1: M111 unrecognized component name: admin


1: M111 unrecognized component name: oauth2server


1: D400 First line should end with a period (not 'o')
1: D205 1 blank line required between summary line and description (found 0)
87: D102 Missing docstring in public method
91: D102 Missing docstring in public method


23:1: I201 Missing newline before sections or imports.
24:1: I100 Imports statements are in the wrong order. import warnings should be before import six
24:1: I201 Missing newline before sections or imports.
24:1: F401 'warnings' imported but unused
27:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
31:1: I201 Missing newline before sections or imports.
32:1: I100 Imports statements are in the wrong order. from flask_registry should be before from flask_restful
32:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from functools should be before from flask_registry
33:1: I201 Missing newline before sections or imports.
34:1: I201 Missing newline before sections or imports.
115:29: W503 line break before binary operator


23:1: I201 Missing newline before sections or imports.
24:1: I100 Imports statements are in the wrong order. from flask should be before import six
24:1: I201 Missing newline before sections or imports.
25:1: I201 Missing newline before sections or imports.


25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
28:1: I201 Missing newline before sections or imports.
30:1: I101 Imported names are in the wrong order. Should be error_codes, require_api_auth, require_header, require_oauth_scopes
30:1: I100 Imports statements are in the wrong order. from invenio.ext.restful should be before from werkzeug.utils
32:1: F401 'acc_authorize_action' imported but unused
33:1: I101 Imported names are in the wrong order. Should be Deposition, DepositionDoesNotExists, DepositionError, DepositionFile, DepositionNotDeletable, DraftDoesNotExists, FileDoesNotExists, FilenameAlreadyExists, ForbiddenAction, FormDoesNotExists, InvalidApiAction, InvalidDepositionType
273: D102 Missing docstring in public method
276: D102 Missing docstring in public method
279: D102 Missing docstring in public method
282: D102 Missing docstring in public method
285: D102 Missing docstring in public method
299: D102 Missing docstring in public method
319: D102 Missing docstring in public method
322: D102 Missing docstring in public method
325: D102 Missing docstring in public method
340: D102 Missing docstring in public method
343: D102 Missing docstring in public method
346: D102 Missing docstring in public method
349: D102 Missing docstring in public method
352: D102 Missing docstring in public method
355: D102 Missing docstring in public method
371: D102 Missing docstring in public method
383: D102 Missing docstring in public method
386: D102 Missing docstring in public method
389: D102 Missing docstring in public method
392: D102 Missing docstring in public method
405: D102 Missing docstring in public method
414: D102 Missing docstring in public method
417: D102 Missing docstring in public method
420: D102 Missing docstring in public method
423: D102 Missing docstring in public method
426: D102 Missing docstring in public method
508: D102 Missing docstring in public method
511: D102 Missing docstring in public method
514: D102 Missing docstring in public method
517: D102 Missing docstring in public method
548: D102 Missing docstring in public method
590: D102 Missing docstring in public method
593: D102 Missing docstring in public method
596: D102 Missing docstring in public method
603: D103 Missing docstring in public function


@ipa-nhg: I think this is a special case in which we really need roslib because we're explicitly calling roslib.packages.get_pkg_dir(). Please add it again and send a PR.

In all other cases it was OK to remove roslib as roslib.load_manifest() is not needed any more


1: D100 Missing docstring in public module
25:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
27:1: I201 Missing newline before sections or imports.
29:1: I101 Imported names are in the wrong order. Should be InvalidPayload, Receiver, ReceiverDoesNotExists, WebhookError
29:1: I201 Missing newline before sections or imports.
72: D102 Missing docstring in public method
77: D102 Missing docstring in public method
82: D102 Missing docstring in public method
85: D102 Missing docstring in public method
88: D102 Missing docstring in public method
91: D102 Missing docstring in public method
94: D102 Missing docstring in public method
101: D103 Missing docstring in public function


I tested what I mean here: https://github.com/kunaaljain/test-centos-docs/pull/21 It looks like Travis doesn't make the secret available for pull requests so it wont work anyway. You can see that based on the output here:

https://travis-ci.org/kunaaljain/test-centos-docs/builds/74073050

    $ bitballoon deploy site --access-token=$BB_ACCESS_TOKEN --site-id=$BB_SITE_ID || true
    Please enter your BitBalloon API Credentials (if you don't have any, you can create your credentials at https://www.bitballoon.com/applications)
    Client ID:


Commit de Julio Dieguez,


Probably not best reason ;-)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.454](http://teamcity.monogame.net/viewLog.html?buildId=9359&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Yes they are
https://github.com/MotorolaMobilityLLC/kernel-msm/blob/lollipop-5.1.1-release-surnia/arch/arm/boot/dts/qcom/msm8916-osprey-p0.dts


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18685/testReport/) for this commit**


Mind the `<script type="text/javascript" charset="utf-8" src="config.js"></script>` above. It may (or may not) have the SERVER_URL


@jython234 Well I'm in it so beat that :P


Don't know yet, it is even happening when the GS vertices have normalized texture coordinates (0-1) and the shaders also use that form. I can't just change the texture size because they would not scaled with it. Maybe if I interpolated the width/height pre-multiplied values and just before the texture lookup normalized them again with the new texture size, then I could avoid going full integer texture lookup. One extra *1/size step, but rcp isn't very precise.


can you put the/home/p0f - logs/above the socket on the socket open source? Thank you


sorry about the wrong Jira numbers is heading. Its WL-3997 patching KNL-1306


What do you mean?

On Tuesday, August 4, 2015, RandomAltThing <notifications@github.com> wrote:

> @jython234 <https://github.com/jython234> Well I'm in it so beat that :P
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DragonetMC/Dragonet/commit/2cbacb59399cb34959dc9f48f402d5dc04173b0c#commitcomment-12518193>
> .
>

--


You don't need to add the binary camera HAL here, it's the same as the camera.vendor.msm8960.so that CM uses, you can just rename it there, and remove the binary HAL in the tree


It looks like in this commit all the image.xcassets were deleted.  So if I pull this down I can't run it.

If you delete a file(s) by accident, you can see the delete updates when you check 'git status' before adding any changes. Also you'll see all the deletes when you run git add and git commit.  If you see any deletes you didn't do on purpose this should be a red flag.

If you're unable to restore the files from trash, you can always undo the changes in git if you make frequent commits as you add each feature.  Depending on when you catch the mistake determines how you 'undo' it with git.  It's different steps to undo depending on whether you've run 'git add', or 'git commit' for example.


@matthew-andrews I think we'd like some help figuring out why webpack build doesn't work in production, but does everywhere else. Any ideas...?


Ok, seems to equally work with:

CurrentTime = Duration;
ffx_process_frame(ActorHandle, FrameState, 0.F);   //That one call with 0.F is needed, else nothing updates. Asked you that before some weeks ago i think
ffx_process_frame(ActorHandle, FrameState, CurrentTime):

if(IsAudioStarted())
{
	OutAudioStart = 0.F;  //only valid if audio always starts at exactly 0.F during facefx anim playback
	OutAudioStarted = true;
}


Hi,
when yocto tries to checkout this commit, the following error appears (meta-atmel/recipes-bsp/u-boot):

| DEBUG: Python function base_do_unpack finished
| DEBUG: Python function do_unpack finished
| ERROR: Function failed: Fetcher failure: Fetch command failed with exit code 128, output:
| fatal: reference is not a tree: 91a9fa73b44dd15645e3f70644ecfdd386c7e2d1
|
ERROR: Task 103 (XXXXXXX/poky/meta-atmel/recipes-bsp/u-boot/u-boot-at91_2015.01.bb, do_unpack) failed with exit code '1'

Going back to commit 8ecda1615fe67756544c6ff2f71db050057ab536 resolves the error.
Do you know where it could come from?
Regards


gulp-msbuild, nice find! It's much cleaner.


wrong jira number in commit message Its WL-3997 patching KNL-1306


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18686/testReport/) for this commit**


请教一下，第一个参数是频率吧？第二和第三个参数是什么？


Oh, I missed them, thanks! But I still can't understand why this change in surnia's device tree


close https://github.com/CartoDB/docs/issues/286


I thought I `grep`'ed for all usages of `roslib`, as roslib is also needed in C++ if you have something like `ros::package` which was less obvious...sorry about that...must have slipped through...


@jython234 I'm in the Dragonet organisation.


No, I guess not. The problem is that we need the view to load before we show the spinner animation. My initial solution was having the if (self.viewState == TGMainViewStateLookingForRouters) { ... }. But after playing around with it, we just need to configure in viewDidAppear and don't even need that if statement anywhere.


You're talking about users that call one of the legacy methods?  If so, then yes, that's correct.


Entonces, ¿te parece bien que el nuevo contenido que se vaya subiendo lo incluya en ambos archivos y los errores y mejoras le demos soporte cada uno en sus respectivos archivos?


What about the Ant task which calls another method defined just below?


What hosts/IPs should the cert be signed for?


Good :+1:


I think there is still a problem with this section of code.  If "text" is not a basestring (in line 266) can it possibly be a str (in line 270-269) ?  I think lines 271-270 to 274 are unreachable.


Can you customize the SWIG mappings? One example where we might want this is for button and blink interfaces, where we marshal the byte value (0 or 1) to a boolean in .Net with ```[MarshalAs(UnmanagedType.I8)]```.


Oh nice.

On Tuesday, August 4, 2015, RandomAltThing <notifications@github.com> wrote:

> @jython234 <https://github.com/jython234> I'm in the Dragonet
> organisation.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DragonetMC/Dragonet/commit/2cbacb59399cb34959dc9f48f402d5dc04173b0c#commitcomment-12518304>
> .
>

--


somehow my menist is giving me error, I am not is sure is it due to delete this .gitignore,


Merge master


Bad, very bad. It's negative globs should be after positive.


I don't like having a second method for the same operation. Is it possible to use `Integer` here?


hmm... this doesn't build on osx for me


...Though the next installer will aim at fixing everyone's initial installatiom issues, and introduce installing into a separate folder. I'll probably also make a simple patcher that just pulls the latest from yhe build bot... at least until we go online enough to have "release builds".


Fixed in commit https://github.com/owncloud/android/commit/10c5498879f3475acab421134b4496c70645e73a


DIdn't everything moved in arch/arm/boot/dts/qcom ?


I -believe- so, but it might take some trickery. Is that not already a
boolean, in the C++ interface though?

Most types wrap with SWIG to be the closest thing available in the target
language.

On Tue, Aug 4, 2015 at 10:41 AM, Jeremy <notifications@github.com> wrote:

> Can you customize the SWIG mappings? One example where we might want this
> is for button and blink interfaces, where we marshal the byte value (0 or
> 1) to a boolean in .Net with [MarshalAs(UnmanagedType.I8)].
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OSVR/OSVR-Android-Build/commit/7407c1015389e2af8cac0c27dc7b417a6cd505df#commitcomment-12518375>
> .
>


I don't think you need `.json` here - my preference is to not add it.


unnecessary console.log


I now added a quick check to add_sourceapp.sh that should prevent issues like this in the future:
https://github.com/opengapps/opengapps/commit/094c4c0bb3abe9437130ec9a113c4b32dc79542b


@jython234 If you have any spare time you're welcome to make some [**Pull Requests**](https://github.com/dragonetmc/dragonet/pulls) and with enough commits (only a few needed) I will add you to the organisation if you like.


??  But on line 250 above ?


lgtm


ivode->invoke


5058-fix-readvars-cli (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1616 of 1780 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-90.79%25-yellow.svg)


For now i used two different colors (AAAAAA and EEEEEE) just to have the differentiation between the to, so we can set whatever color codes @jancborchardt decides on :)


Copyright


Slightly shorter:

```java
if (table.getTemporalColumnHandle().filter(handle -> handle.equals(column).isPresent()) {


saw approval from macintux
at https://github.com/trevorriles/cuttlefish/commit/9ff58304e3496dfc9644089cfa13f7c255614d9c


merging trevorriles/cuttlefish/fix/erlang18 = 9ff58304 into borshop-integration-197-fix/erlang18


trevorriles/cuttlefish/fix/erlang18 = 9ff58304 merged ok, testing candidate = 98a57a52


Is the "return;" necessary?


yes, I did,


It is a really interesting talk. It echoes a lot of what I believe about how the main websites we visit are becoming bloated and commercialized. My favorite part: "Let's reclaim the web from technologists who tell us that the future they've imagined is inevitable, and that our role in it is as consumers"


Please do all changes as pull requests, not direct commits to `master`. (Though I would :bee: this one.)


with though of "withParameters" and "withReturnType"


I'm more a fan of having a slightly more complex if statement and a simple `suports_colors` you can override instead of having `_suports_colors` that is wrapped by `suports_colors`. Imo it is just overhead.


These method arguments seem backwards. The table should be first since that is what it is operating on (and matches all the other methods). Can you add a commit before this which flips it?


It would be better if you check if Google WebView is installed, before modifying result. Check CM code to get context etc. They handle it well.


shall I implement alphabetic ordering?


Ahh interesting! I wanna see what they put together!


fail if methodNames contain a name which does not exist in class.


ok its your code. Do it how youlike it best ;)

2015-08-04 16:50 GMT+02:00 Makman2 <notifications@github.com>:

> I'm more a fan of having a slightly more complex if statement and a simple
> suports_colors you can override instead of having _suports_colors that is
> wrapped by suports_colors. Imo it is just overhead.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/73ed6eddd79f508917290c3ab7adf0029a605253#commitcomment-12518619>
> .
>


Rename style names


add info that methods() must be called in exception desc.


I actually don't care how it's ordered but it has to be ordered the same on
every invokation because they might be used for comparision in tests. Also
this makes your test expression simpler.

2015-08-04 16:51 GMT+02:00 Makman2 <notifications@github.com>:

> shall I implement alphabetic ordering?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/65ee67911807938ed9bc500ff1eb616af8c1ed45#commitcomment-12518636>
> .
>


Not sure, but I'd guess that missing break here will cause exception thrown when extension is `gif`


thats a yes ;)

2015-08-04 16:52 GMT+02:00 Lasse Schuirmann <lasse.schuirmann@gmail.com>:

> I actually don't care how it's ordered but it has to be ordered the same
> on every invokation because they might be used for comparision in tests.
> Also this makes your test expression simpler.
>
> 2015-08-04 16:51 GMT+02:00 Makman2 <notifications@github.com>:
>
>> shall I implement alphabetic ordering?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/coala-analyzer/coala/commit/65ee67911807938ed9bc500ff1eb616af8c1ed45#commitcomment-12518636>
>> .
>>
>
>


ya no funciona ni uno.saludos.


I try to import it as svg.path and Pycharm won't recognize it.  Perhaps I'm doing it wrong but I couldn't figure it out


Your ellipsis (`...`) won't have any effect. If you don't use something like `vsprintf` or `vsnprintf` it will just be discarded (like variadic templates if you don't expand the template argument pack).


lgtm


can we get rid of this console.log in a future release? thanks!


oh - here are the methods. This is probably better.


Shit. I'll send another PR.


".log after " + 1     should be
".log after " + i


a * aRescale might not fit, use Math.multiplyExact and catch exception


misspelling of canola


If CM has done it well, then this module has finished its initial purpose.

Sent using CloudMagic [https://cloudmagic.com/k/d/mailapp?ct=pa&cv=7.0.42&pv=5.1.1] On Tue, Aug 04, 2015 at 10:51 PM, pyler < notifications@github.com [notifications@github.com] > wrote:
It would be better if you check if Google WebView is installed, before modifying
result. Check CM code to get context etc. They handle it well.

—
Reply to this email directly or view it on GitHub
[https://github.com/PeterCxy/WebViewGoogle/commit/2e83cfeeed398b76f806f6e25af2deddce3e2ec1#commitcomment-12518633] .[https://github.com/notifications/beacon/AEUoxxWnuzmgejvXqJybtmByhr-ixO9_ks5okMjugaJpZM4FlX1y.gif]


You can tell I never actually hit that error during the refactor...


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1266 of 1266 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I was using two space indentation on the tags.
Also, I've been making sure that the opening and closing dom tags have equal number of spaces in front of them.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.454](http://teamcity.monogame.net/viewLog.html?buildId=9359&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:23:37


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.455](http://teamcity.monogame.net/viewLog.html?buildId=9363&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18687/testReport/) for this commit**


Ok, makes sense. HTML v4 to v5.


- 「極々」削りたい
- @omegamega


That's a possibility, but didn't want to go overly generic at first. Much simpler to store MobileView requests by the site & page for now.


Complete


@samdark seems there has been more code added than you wanted.


After thinking a little bit more about it, I think that keeping a `const char *` is not a great idea, and here is why:

Since you do not allocate anything, you have to make sure that the lifetime of the pointed-to string will outlive the lifetime of the struct itself. Imagine something like:

```
    int extraData = 10;
     std::string reason = "Bid does not contain extra data: " + to_string(extraData);
     result.setInvalidBid(reason.c_str());
```

Things will go boom boom because the `std::string` is local to the function and the underlying `char *` pointer will be deleted when it goes out of scope, thus you will end up with a dangling pointer, which is bad.

This is why I would recommend keeping a `std::string` rather than a `const char *` as it would fix both issue (lifetime and the `...` ellipsis above). It will cost one extra allocation but I don't think we care.


I'm not sure that's valid. Like I mentioned in the mail I sent, the audio started flag will *always* be set on the first tick after that 0 frame. So if you are jumping to say time 8 seconds, then you will tick at 0 (your first line), then you will tick to 8 seconds and the audio start bit will be set, because that's the first tick where time is >= 0. That does not mean the audio started at time 8 seconds. If you need to know when the audio started (I thought you were subtracting from current time to get an audio time delta to seek the audio to), you will need a different method.

I must not be too sure what it is you're trying to do in this code re: audio...


isIpAvailable?


Would probably be good to create a new namespace to put most of the websocket-specific stuff into.  Probably everything except `websocket-handler`?


Awesome!!!!


So, this info isn't available from the `UpgradeRequest`?


Instead of going away from ASCII, why not simply using the `±` entity for ±?


all tests pass:
success: http://buildbot.bos1/builders/test-cuttlefish/builds/163


freeIpAddresses


Perhaps use

            ss = gmapQi 0 (fromJust . cast) a

instead of the unsafeCoerce


I think at this point, the plugin interfaces are small enough that we're going for an "idiomatic" binding in each target language, rather than a generated one (and we also have performance to worry about there, particularly on the plugin side because client apps have no control over that). I'd rather not involve SWIG on ClientKit and PluginKit, at least not at first - it doesn't really map to the API model well. And, in terms of the Server library (for writing a GUI), that's a very small API but also internal and thus bendable. If you think SWIG on that API can get you going faster and get a Cardboard "sensor" up sooner, then go for it, but personally I will admit to being not fond of SWIG.  (I'd think rather than making JNI bindings for cardboard, you'd effectively do the reverse, using JNI to access PluginKit)


Unfortunately, it's all or nothing. Didn't to get into that can of worms just yet (or ever, depending on timing).


李新言


I think you can use a `defprotocol` here, and that'd be a little more Clojure-y.


Fixed in commit https://github.com/owncloud/android/commit/a329d49ddff262077711ac1dd55a8834b5a07ed0


I DEMAND TO KNOW WHY


Select an IP


I made it a define so you can easily "join" it w/ other string literals to form other constants, see [below](https://github.com/wikimedia/wikipedia-ios/commit/8829af6e217aa0f65d7ac02b9bde56c4dc1a0967#diff-85cd11c82e568bed63c95fe9280508fbR19)


I didn't get the suggestion with regards to System.getProperty("os.arch") - how would you suggest doing this? I thought I handle the (very unlikely) event that this is not set here, rather than checking for getNativeArch() returning NULL where I call this?


Thanks!


After all MSL is kept ASCII in order to avoid encoding issues.


argh, this should probably be getNativeArch().equals("arm")


Django lets you overwrite settings on a per-test basis: https://docs.djangoproject.com/en/1.4/topics/testing/#overriding-settings
We could overwrite the avatar directory to a temporary directory (with `tmpfile.mkdtmp` - https://docs.python.org/2/library/tempfile.html#tempfile.mkdtemp) and then delete it at the end of the test.


OFF WITH HIS HEAD!

![Like in that one movie with Johnny Depp, it was like totaly awesome, and they even wrote like a book about it, but it wasn't as good as the movie, so like whatever](http://media.giphy.com/media/5qTamQs4OhanK/giphy.gif)


5058-fix-readvars-cli (mbadams5) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.28%25-red.svg)


added by error?


> The signal is emitted in this case if the instruction is NONE but in the only ultimately connected slot to this signal

Remember that there are other applications using libowncloudsync. Are you saying they'd still get the same behaviour?


thanks. fixed typo


disclaimer: This codes are meant for help for beginners to seek some idea if he/she got stuck in the problem.


Is the issue #3162 fixed with this change?


Whoops, duplicated content here!


this sets the fill of the points in the color legend white, same as ggplot2:

![malaria-viz-chroms](https://cloud.githubusercontent.com/assets/932850/9064065/c811ad32-3a98-11e5-8002-17914612e203.png)

now I get only 2 failures in test-malaria.R

```
> tests_run(filter="malaria")
1. Failure (at test-malaria.R#206): one line is rendered for each region -------
length(region.lines) not equal to nrow(malaria$regions)
14 - 12 == 2

2. Failure (at test-malaria.R#251): none legend entry opacity 0.5 after clicking
none.after not equal to 0.5
0.5 - 1 == -0.5

testthat results ================================================================
OK: 11 SKIPPED: 0 FAILED: 2
1. Failure (at test-malaria.R#206): one line is rendered for each region
2. Failure (at test-malaria.R#251): none legend entry opacity 0.5 after clicking

Error: testthat unit tests failed
```


Copyright.


Why do we need to keep both loginWithProvider methods? aren't they internal for our use only?


Please, unify license comments.


Fixed in commit https://github.com/owncloud/android/commit/f7f468b5783add4a4e67d2b3d4d8ede3766ba156


For exceptions in `mock` you should use `side_effect`: http://www.voidspace.org.uk/python/mock/examples.html#raising-exceptions-on-attribute-access


Yeah, I wasn't very keen on the naming here, and I'm not sure how best to encapsulate the logic of setting up some kind of `DTAttributedTextContentView`-based UI in a "minimal" fashion.  I'm more or less forced to wrap it in an object (as opposed to subclass or category) since the customization is done through delegation.

It's not in use currently, but this class has an `articleNavigationDelegate` which is intended to provide an abstract interface for responding to content interactions.  The goal is to have that interface be common whether content is native or web.

Given that the goal is both to configure the content presentation (minimal) and handle adapting interface interaction events, I think `Controller` is a suitable term.  Not "owning" the attributed text content view is a caveat that the content view can be embedded or subclassed in a variety of different scenarios, so I'm trying my best to handle them all by allowing the `Controller` to configure whatever kind of `DTAttributedTextContentView`-derivative you throw at it.


This is not required. `core.GenesisBlockForTesting` requires a database to be setup.


@zidarsk8 I hope you don't mind this inline lodash, but I think this is the prettiest I can do.


yeah sure, but i liked palette :art:


Looking great! Will include it on the streama-page (which is currently being built) with instructions


That's the idea. The issue is, currently how I'd do it would be to make an
Android app which launches the osvr_server, which in turn would interface
with a plugin that would talk through JNI -back- up to the Cardboard
interface. If we wrapped the server and made the topmost layer (the server
essentially) run in JNI-wrapped Java, then adding a Cardboard plugin would
be incredibly easy to do.

SWIG wrapping has been very high performing whenever I've used it, the only
issue being when I want a class to be able to use callbacks (requires the
'director' feature, some tweaks, and a deriving class to override whatever
functions you want used, which is somewhat of a pain). My main thought
process for SWIG was simply because it would save time in the long run, but
it's not the only option.

On Tue, Aug 4, 2015 at 11:00 AM, Ryan Pavlik <notifications@github.com>
wrote:

> I think at this point, the plugin interfaces are small enough that we're
> going for an "idiomatic" binding in each target language, rather than a
> generated one (and we also have performance to worry about there,
> particularly on the plugin side because client apps have no control over
> that). I'd rather not involve SWIG on ClientKit and PluginKit, at least not
> at first - it doesn't really map to the API model well. And, in terms of
> the Server library (for writing a GUI), that's a very small API but also
> internal and thus bendable. If you think SWIG on that API can get you going
> faster and get a Cardboard "sensor" up sooner, then go for it, but
> personally I will admit to being not fond of SWIG. (I'd think rather than
> making JNI bindings for cardboard, you'd effectively do the reverse, using
> JNI to access PluginKit)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OSVR/OSVR-Android-Build/commit/7407c1015389e2af8cac0c27dc7b417a6cd505df#commitcomment-12518896>
> .
>


the indentation looks broken here


:metal: :metal:


TeamCity DNN JavaScript Libraries :: CI [Build 62](http://teamcity.engagesoftware.com/viewLog.html?buildId=330&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 62](http://teamcity.engagesoftware.com/viewLog.html?buildId=330&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


See http://developer.android.com/training/improving-layouts/reusing-layouts.html#Merge - basically to use it as a substitite for a layout container since you know the laout will be used via an include. Else you might end up with several cascading container layouts which are basically the same (e.g. a vertical linear layout in a vertical linear layout)


Is it expected to both send a `smpMessageAbort{}` back to the sender and also return an error? The `smpMessageAbort` is not going to be sent if there is an error. I could not find a test describing this behavior. :cry:


should this also be  `\array_keys`?


The nomenclature varies from XPath "expression" to "selector" depending on the context. Selector is also used for CSS, especially for APIs that support both XPath & CSS.

As far as what it does, i can add some doc-comments, but would prefer to keep the name short, as it's essentially a getter for a static property.  I'll consider a more specific name though, since it's intended for cases where presentation is "minimal."


Trailing ```,```


ST is common but d for delta isn't really established anywhere.
Up until now I expected dr to be destination rectangle :p


The scan failed.
Included commits

Commit ID	Owner

c75b6b34ee9f0a300bbaa42772c321dc0a04bf61	@dudug

4b8e99454950a090e8e3566e2a06f25a1a0b04f2	@dudug

a8029081cbc48195bd77ec9223b2afb0b04cce1a	@dudug

0e2771c3fd1595617742b392a035c4211fa3161d	@dudug


s/activate/activated


6,7번 항목에서 필요한 부분에 해당 커밋에서 추가시키면 되는 것 아닌가요? 만약 어떤 이유에서든 힘들다면 차라리 6,7번 항목을 첫번째 커밋으로 만들어서 기본 make 환경에서 parser 코드를 C++ 에서 사용할 수 있도록 만든 다음에 CMake로 변경하는 것을 추천하고 싶군요. 그리고 정민씨가 추가한 테스트 코드도 빌드 & 실행할 수 있도록 지원해 주세요!


@krainboltgreene you are the prime example of a retard that gets offended by the word retard.

By the way, your profile picture is offensive. It looks like you want to punch me - this does not create a safe space, which it should to comply with the latest code of conduct. Please remove this photo, I will be reporting you. Also, please remove the link to your website. I not only felt violated after seeing the design, the posts have left a permanent traumatic effect on me. Please leave GitHub immediately, we don't need people like you here. Shoo.


Who knows, it's public method.


I'm fine with just "the A.B and A.B.C.D". Actually no one need the A or A.B.C.D.E. But just like always I want to make more flexible for all situation then less people need to fork his own branch to solve the problem like me. And I don't think `oldVersion.count == newVersion.count` is good enough. Maybe someone just like to remove the zero at the end the the version may like `2.1->2.1.1`. It's not a good example but sometime just have a history package to doing this.
Anyway I have a great time for working on this. :+1:


这是给你的评价


Can we get this document taken down? It's kind of a disservice to the scala on android community since it's so far out of date, yet still ranks highly on google search.

Thanks (no way to email directly or open an issue on this repo.)


I added builder for Signature itself. I think it is more usefule as independent tool. Otherwise a lot of signature specific builder stuff would land here


Vectors (at least at this point) are described by just their name and their data type (int, string, etc.) as encoded by the ObsDescriptor.FieldType enum. We could promote FieldType to a top-level enum and give it a more generic name that might make it a good fit here; then the Vector's description would only need to be its data type.


It seems that the "R" character is missing here - should be RHASH_IFNONE


I think `package-info.java` in `tachyon.worker.block.evictor` is more appropriate for evictor related info.


Usually good to wrap cursor usage in a try/finally block to ensure that the cursor is closed even when an exception is raised:
```
Cursor ef = c.getContentResolver().query(...);
try {
    while (ef.moveToNext()) {
        ... // maybe this code throws an exception
    }
} finally {
    if (ef != null) {
        // We need to check if ef is null because of [1]
        // ef will now always be closed even when exceptions are raised above
        ef.close();
    }
}
```
[1]: https://stackoverflow.com/questions/13080540/what-causes-androids-contentresolver-query-to-return-null/16108435#16108435


The scan failed.
Included commits

Commit ID	Owner

0467f9dc03aa49abf3742cdea0e547b1c9cf8179	@dortal


Thank you, @danielspaniel. I upgraded and everything works great.


reack


You forgot on pure AOSP roms/other custom ROMs.


Still missing an ending `\r`

i.e:

```
➜  scaleway-cli git:(f84eda8) ./scw -V run alpine
INFO[0000] Server creation ...
INFO[0001] Server created: d526b2ff-22dd-448e-84c4-e190e67710ba
INFO[0001] Server start requested ...
INFO[0002] Server is starting, this may take up to a minute ...
/INFO[0003] Server changed state to 'starting'
/
```


Oh, thanks!


add `meanFunc` as a default value? This saves your from changing all uses of `eval_graphite_data`… not sure if it's cleaner though


From one to the other. Add links to redirect snippets in other doc.


Hmm, I think this may result in some copmlication, esp as we consider foremen.

Wouldn't it be simpler to treat resource exhausted tasks as "completed" tasks that are returned by available_results, with a status of WORK_QUEUE_RESULT_RESOURCE_EXHAUSTED?

(This also simplifies foremen and multi-slot workers, which may need to return a mix of tasks at the same time, some exhausted, and some not.)


Done and pushed, thanks


@dg-ratiodata Yep - It's caused a broken test which I can't reproduce locally though.


oh nevermind, you're setting the default one level up. Carry on…


java


It would have been nice to have this code as a script --- since we have bazillions of threads in our prod db, you never know how much memory or time running this would take and whether you won't have to edit things live.

See https://github.com/nylas/sync-engine/blob/master/bin/refresh_imapuid_labels for example.


sorry, I misunderstood


ack


Thanks for that :)


Hello @stevenovakov,

- Can you send me a Minimal (non-)Working Example, so I can run the example on my computer.
- Can you create a issue in the LTPV project for this problem, it will be simplier to discuss.


I think maybe _element_ would be more accurate here, since a _web element_ is just the JSON Object representation with the UUID.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1266 of 1266 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fast-forwarding develop to borshop-integration-197-fix/erlang18 = 98a57a52


I think it's always a good idea to think of this as `response`, because that's what it is. The *games* are what you access with `response.data`.


yeah, this was sort of a hack to try to stop it from crashing—which on closer inspection is a bit weird. we need to have more comprehensive integration tests with our data sources and a real collection view to make sure CRUD operations are functional.

i say that this is weird since, if it fixes the issue, something strange is going on. KVO callbacks _shouldn't_ be firing in the space between when we set the new data source and the collection view is reloaded.

i suggest we [revisit this later](https://phabricator.wikimedia.org/T107887) with tests.


@coolsquid, pls. You gave a whole bunch of fields/methods names that start with `L`

Also, USE DESCRIPTIVE COMMIT MESSAGES!


이 부분은 중복되는 부분이 많아서 다시 한번 수정이 필요합니다.
시큐리티에 대한 경험이 없어서 코드가 이쁘게 안나오내요...


It's a #define for similar reasons as the others, makes it easier to reuse (see below)


@AbdealiJK hey, take a look at what I did with the build matrix: https://github.com/coala-analyzer/PyPrint/pull/3 makes linux builds faster by far!


It’s unnecessary to reference **match a request** here.  I think the whole line can be removed, then you just do the check against the parameter `<var>name</var>`.


Nice!


Does this also update the "When about X players have joined..." in the lobby?


You mean `<a>element</a>` here.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.455](http://teamcity.monogame.net/viewLog.html?buildId=9363&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:28:56


Yes, that would be ideal. The problem is that we do not know which task is exhausting resources (in particular, disk), so we do not which single task to stop.

The current code reflects that a single task may make the worker unstable, so we want to kill everything there as soon as possible, and also tell the master immediately, before the worker may die for good.


refs. #29


Hi @rgm3 I would like to get in touch with you, but there is no email that I can message too. :-/
Could you send me an email to contact@openhybrid.org?

See you later,
Valentin


Yeah, I should probably remove it until we know we need it... I just thought that doing the XPath query, mapping, etc. **for each item in a list** would create a surge of autoreleased objects and potentially result in scrolling performance degradation.  Will remove for now and consider it when we do performance auditing of the new lists... which I just filed [a ticket](https://phabricator.wikimedia.org/T107888) for.


refs. #28


We can get away with just using `<var>name</var>` here I think.


This fix works excelent but when i download the npm package it is not yet. It's necessary to copy manually.


SCM?


Yeah the more you describe the more it sounds like a cell with controls. I would really look in that direction. it is very common to have cells with controls that send actions/messages to the view controller needs to handle - either by assigning actions or by conforming to a delegate of the cell. I've both seen and used this pattern pretty regularly.

Also of note: the messages you are sending in the delegate protocol are UI interaction messages (did tap this, etc…), which in general are propagated from view classes (Like UITableView). Additionally, Its also common for cells to take on these "controller-like" activities such as configuration that you describe.

And while I see the logic in:
>It's not in use currently, but this class has an articleNavigationDelegate which is intended to provide an abstract interface for responding to content interactions. The goal is to have that interface be common whether content is native or web.…
> …Not "owning" the attributed text content view is a caveat that the content view can be embedded or subclassed in a variety of different scenarios,

Thats a bit of pre-optimization/YAGNI - and seems like most of the impetus for this odd duck of a class. We really don't know what the other needs of web and other native views are going to look like. In this case it complicates the implementation here for potential shared interfaces at a later date. Its much more pragmatic to extract the commonalities after the 2nd implementation is written rather than before.


You are linking a controller in your state AND using ng-controller, which can cause tons of a problems (and is a problem in itself).


`<dl class=switch>`


@edolstra thanks, I missed that!


What is the point of this line?


Of course not! Thank you for the mention :)


I see.  In that case, wouldn't it still be conservatively correct for the worker to stop all running tasks and return them in the ordinary way, with the resource exhaustion flag set?

(I get more picky about the things that affect our protocol...)


Line break this line to make it more readable.


“Return” here seems appropriate since it’s not a function, but you’re assigning the result of the match group to a variable.

I would just cut “Return” and say “The first matching statement…”


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.456](http://teamcity.monogame.net/viewLog.html?buildId=9377&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


text


First I wanted it to return a boolean value, but then I decided that I want to return string


Good idea to instantiate all of the properties you will set on your `$scope`, for example, `search`, `sortMethod` -- this is for clarity and readability.


@LorenzMeier something went wrong with this merge. This bug has appeared again from an earlier change: https://github.com/PX4/Firmware/blob/master/src/modules/fw_att_control/fw_att_control_main.cpp#L948
which I believe was in this change: https://github.com/PX4/Firmware/commit/1ca05aaa64c96600f9034c097e1a7b48069e3d2d


The `Exception as e` syntax is future compatible:
http://stackoverflow.com/questions/2535760/python-try-except-comma-vs-as-in-except


Build fails. SCM?


I don't understand what you're trying to do with this property.


Then maybe use `EventdEvent-0` and add `EventdEvent_0_gir_NAMESPACE = Eventd`.


Consider using isolate scope in the future.


Nice usage of filters.


@nathaliew817 ?


Yeah, honestly I'm not sure if that's the right behavior. The aborting stuff is a bit messy.


Maybe could check if(event_notify) here for reduce the spare lock, unlock and remove operation ?
I would think if event_notify is false, the m_xlist_item.remove_myself() is not needed.


Yes, that sounds good. Trying to send the messages right away had limited application anyway.


Weird random capital D.


Thanks !!!!


Start using resolve -- simplifies your controllers.


I'll get back to you on this. FYI: the EPUB3 Multiple Rendtions implementation (feature branch) makes use of package / spine in order to compute / compare CFI references (cross-rendition navigation). So I can see the kind of issue you are referring to.