Looks like this needs a tweak:

```diff
- @display_user = User.find_by_url_name_and_email_confirmed(url_name, true)
+ @display_user = User.find_by_url_name_and_email_confirmed(params[:url_name], true)
```


`###` 后加空格...


See my comment above on creating: display_balance(account_name, balance)


Line length – would be better like:

```ruby
unless @display_user
  raise #…
end
```


treste


I thought we agreed not to do the quick fix? Also, the preconditions, I believe, have a new due date of tomorrow.


Would be nice to use capitals for SQL keywords


See https://github.com/mdarefin/Convert-For-Each-Loop-to-Lambda-Expression-Eclipse-Plugin/milestones.


nit: move `def.is_fundamental` to the next line


这是不同于其它一些项目 --> 这个与许多其他项目不多，它们使用的默认用词。。。


See the issue queue ;)

This will be a monolithic file of about 50 lines that connects the CLI to the core.


Oh, thanks @lethalman you are right. I will correct this later, if no one does it in between.


Fixed in 249395291da6346149ea3986cd03fa94e94cf508


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2203 of 2232 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.7%25-yellow.svg)


added error handling


For some reason, I'm having trouble connecting to MySQL on Malta. There is a database named `py_wikipedia` with the `page` and `redirect` tables already loaded from the enwiki dump that I want to connect to to set up these additional tables (defined in this file). Here's the error:
```
Traceback (most recent call last):
  File "./models.py", line 73, in <module>
    Base.metadata.create_all(engine)
  File "build/bdist.linux-x86_64/egg/sqlalchemy/sql/schema.py", line 3687, in create_all
  File "build/bdist.linux-x86_64/egg/sqlalchemy/engine/base.py", line 1856, in _run_visitor
  File "build/bdist.linux-x86_64/egg/sqlalchemy/engine/base.py", line 1481, in _run_visitor
  File "build/bdist.linux-x86_64/egg/sqlalchemy/sql/visitors.py", line 121, in traverse_single
  File "build/bdist.linux-x86_64/egg/sqlalchemy/sql/ddl.py", line 709, in visit_metadata
  File "build/bdist.linux-x86_64/egg/sqlalchemy/sql/ddl.py", line 1058, in sort_tables_and_constraints
  File "build/bdist.linux-x86_64/egg/sqlalchemy/sql/schema.py", line 2810, in referred_table
  File "build/bdist.linux-x86_64/egg/sqlalchemy/util/langhelpers.py", line 747, in __get__
  File "build/bdist.linux-x86_64/egg/sqlalchemy/sql/schema.py", line 1784, in column
sqlalchemy.exc.NoReferencedTableError: Foreign key associated with column 'article_classes.a_id' could not find table 'page' with which to generate a foreign key to target column 'page_id'
```


Squash this in to previous commit


I'll add a regression test to specifically watch the GROUP_EDGE_ROLES tuple since it is so important.


A download URL in the code... this seems a bit hacky.


@Marty-D , does that mean that Revenge will double its power against a foe that switched position (e.g. with Ally Switch) with a mon that hit the Revenge user (e.g. with Extreme Speed)?


is this required for non-embedded as well?


Will it be better to add support of darray for xtest?


Did you have problems with the pg's default connection pool? I never saw any problems with the pool used in node-postgres, it has always worked fine for me.

Also, the following lines are not necessary together:

```javascript
pg = require('pg'),
pgpLib = require('pg-promise'),
```

pg-promise exposes the instance of the node-postgres it uses via property `pg`, i.e. in your case you can access it as `pgpLib.pg`. This is to avoid including more than one version of the node-poctres library, which may bring some undesirable results.


Trying to figure out how this works.


The #abs() call on the non-negative case is superfluous.


That's not what those mean.  But k,v could definitely be made more clear.


2006 年 9 月，当 GPL V3 起草时，一群内核开发者签署了一个立场声明，表明他们反对 GPL V3。这更加表明了内核不可能改用 GPL V3 协议。


1: M101 signature is missing
1: M111 unrecognized component name: personal_collection


In general, these flags could use comments, but definitely `is_dtorck` and `is_dtorck_valid`


`### 署名行（Signed-off-by）和原始开发者证书（DCO）`


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/74428158


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: personal_collection


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


1: D100 Missing docstring in public module


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
21:1: I201 Missing newline before sections or imports.
21:1: F401 'sa' imported but unused
22:1: F401 'mysql' imported but unused
25:1: I100 Imports statements are in the wrong order. from invenio.modules.upgrader.api should be before from sqlalchemy.dialects


41:1: I101 Imported names are in the wrong order. Should be RECORD_KEY_ALIASES, RECORD_PROCESSORS
41:1: I201 Missing newline before sections or imports.
45:1: I100 Imports statements are in the wrong order. from collections should be before from invenio_records.config
149:4: E131 continuation line unaligned for hanging indent
176:54: E261 at least two spaces before inline comment
176:55: E262 inline comment should start with '# '


23:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.modules.records.api should be before from six


27: D102 Missing docstring in public method
32: D102 Missing docstring in public method


23:1: I100 Imports statements are in the wrong order. import sys should be before import six
23:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
30:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.ext.mutable


28:1: I201 Missing newline before sections or imports.
29:1: I101 Imported names are in the wrong order. Should be Resource, abort
29:1: I201 Missing newline before sections or imports.


It seems to me that we shouldn't try to override functionality that is by design. See https://github.com/npm/npm/issues/3059.

I'd be more interested in getting the generated js out of the lib folder, but you said that wasn't possible.


Es el nombre del sistema cliente-servidor.


Add comments for each function


ok


Ah, maybe `should_prepare_once_when_enabled` is more appropriate.


I'm a month away from going to grad school for design+tech! Hopefully doing AR/VR, I've been desperately trying to figure out how to get my hands on a hololens.

i am suuper excited to see what you make lemme know if you ever need assets or testers


`should_prepare_everywhere_when_disabled`


I don't really know the significance of rescuing from the xapian searches, but maybe we just want to move the begin so that we have:

```ruby
# existing code …
begin
  @xapian_requests = perform_search([InfoRequestEvent], requests_query, 'newest', 'request_collapse')
  @xapian_comments = perform_search([InfoRequestEvent], comments_query, 'newest', nil)
rescue # some error class
  @xapian_requests = nil
  @xapian_comments = nil
end
```

See also #2704


@jedmao yeap, I hate npm/npm#3059 logic. It has no sense.

I try to make some solution like [in-publish](https://github.com/iarna/in-publish) but for local install.


BUILD_REQUIRES is not the right place for test prerequisites.


This should not be required to run tests. Pod tests should only be run for the author, not for normal end-user installations.


These next two tests look the same as the previous two aren't they the same?


Didn't know this could be done!


This is clearly not the right location for the shipped distribution :)


`should_prepare_everywhere_when_not_configured`


The expiring-membership version of my_groups.  I'll document both.


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: personal_collection


Normally one does not add oneself to the author list for patches.


@pkoppstein wrote:
> At this point, I think stability and clarity are far more important than answers to these somewhat delphic questions.   (In the case of STRING*0, both "" and null are defensible, not least because both these values are additive zeros for strings.)

I'm asking whether we want to document things that weren't.  When we do, we end up committing to them.  Will we be able to change this to "" later if it turns out to have been a better idea?  Should we say that it outputs null or ""?  I think so, yeah.


1: L101 copyright is missing


3: L102 copyright year is outdated, expected 2015 but got 2014


Please add more detailed design in the spec, especially equations:

(1) What is the permutation/shuffle method used in varImp.R?
(2) What is the evaluation metric for classification models?
(3) What is the evaluation metric for regression models?
(4) How to compute the variable importance from evaluated metric for classification and regression?


We don't really need this since it doesn't matter which query is prepared, better to just use the same query every time since you are clearing the primes each test anyways.


I was toying with an idea for sheerlike, that let you sort of "mount" sheer sites at a particular template path, and I was going to use [fslib](https://pypi.python.org/pypi/fslib/) to power that.

Result being, that you could refer to the template for the owning a home home page as 'owning-a-home/index.html', regardless of where it was actually stored.


当开发者为内核贡献代码时，他们必须提供一个署名行（Signed-off-by），表明他们承认那份开源协议并声明他们所做工作（他们所掌握知识的最好部分）为原创或者是兼容 GPL V2 许可的某些内容的衍生品。


fast-forwarding master to auto = 49345b34


Small style suggestion (I think this is the same)

```haskell
modHeadRule (DepM dep) f = DepM $ do
  dep
  get >>= \case
     x:xs -> put $ f x : xs
     r    -> put r
```

Also, can you add the bug as test case?


I see, I think you intended to not have `setPrepareStatementsOnce` here and test the default case?  Also I don't think we need separate test cases for preparing one vs. preparing all, the logic is the same.


@angi2 I've received an invitation to join https://github.com/Beildentollth from you. Have you mistaken me for somebody?


In fact, I just abused github to fix this on master.


@SiR-DanieL report an issue ~~report~~ if you spot a bug


These kind of conditional statements are always tricky...

Firstly, a reminder that the while loop will continue until the condition evaluates to false.

Secondly, when using the AND operator (&&) Ruby uses short circuit evaluations: http://blog.revathskumar.com/2013/05/short-circuit-evaluation-in-ruby.html

With this in mind, the key is to change the order that the conditions are checked, first check 'answer' then 'check another_service?'.

We want this loop to continue while answer is not equal to "exit" AND another_service? is equal to true.

In code this is:
while(answer != "exit" && another_service?)

If answer is equal to "exit", then the short circuit evaluation applies and  another_service? is not run.

Note: I have not actually tested this, but I think it will work... Let me know how it turns out.


查看[原创开发者证书][1]


原始开发者证书 --> 原创开发者证书


This breaks the `pom.xml`... Typo?


develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2210 of 2232 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.01%25-yellow.svg)


23:1: I100 Imports statements are in the wrong order. import sys should be before import six
23:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
30:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.ext.mutable
31:1: I201 Missing newline before sections or imports.


自由软件法律中心针对 GPL 有一份合规指南，很有用：


how about just checking window, window.htmlvideoelement and not srcObject? And getting rid of logging


I think you are probably right as to what LSST will prefer, at any rate, so I'll change to that. (I'm not sure if I have an opinion myself...)


Visual Studio is complaining that there is no `.hasOwnProperty` check. Would you consider the following syntax?
```js
Object.keys(opts).forEach(opt => {
    this[opt] = opts[opt];
});
```


`### 针对内核 USB API 的 EXPORT_SYMBOL_GPL`


commit Pichón style


EXPORT_SYMBOL_GPL 前加空格并使用 `EXPORT_SYMBOL_GPL`


Looks like ugly :). This is why I prefer confugarable linters like ESLint.


Fixed in master


You did not test it with 'n'

2.0.0-p645 :003 > "n" == ("n"&&"no")

 => false

2.0.0-p645 :004 > "no" == ("n"&&"no")

On 6 August 2015 at 16:44, meraymond2 <notifications@github.com> wrote:

> Hmm, that's a bit strange. It looks like it works for && though:
>
> 2.2.2 :008 > "no" == ("no" && "NO".downcase)
> => true
> 2.2.2 :009 > "no" == ("NO".downcase && "no")
> => true
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/meraymond2/week-01-coursework/commit/71790d99bf2e6ba2840dfe58b508d6ff37c66fbd#commitcomment-12568644>
> .
>


I've moved the counter out into `bootCurl`, let me know if you think this is better being done as a new PR. The following components rely on the `alreadyVisited` value but are now read only

- This new `membership-message-usa.js`
- `static/src/javascripts/projects/common/modules/experiments/tests/membership-message.js`
-`static/src/javascripts/projects/common/modules/commercial/build-page-targeting.js`
- `static/src/javascripts/projects/common/modules/commercial/donot-use-adblock.js`


Just leaving this here for now before I check it out tomorrow.


2.0.0-p645 :003 > "n" == ("n"&&"no")

 => false

2.0.0-p645 :004 > "no" == ("n"&&"no")

 => true

On 6 August 2015 at 17:09, Daryn Holmes <darynholmes@gmail.com> wrote:

> You did not test it with 'n'
>
> 2.0.0-p645 :003 > "n" == ("n"&&"no")
>
>  => false
>
> 2.0.0-p645 :004 > "no" == ("n"&&"no")
>
> On 6 August 2015 at 16:44, meraymond2 <notifications@github.com> wrote:
>
>> Hmm, that's a bit strange. It looks like it works for && though:
>>
>> 2.2.2 :008 > "no" == ("no" && "NO".downcase)
>> => true
>> 2.2.2 :009 > "no" == ("NO".downcase && "no")
>> => true
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/meraymond2/week-01-coursework/commit/71790d99bf2e6ba2840dfe58b508d6ff37c66fbd#commitcomment-12568644>
>> .
>>
>
>


NAVER - http://www.naver.com/
--------------------------------------------

heralder@naver.com 님께 보내신 메일 <Re: [frontend] Move alreadyVisited counter into bootCurl (5779907)> 이 다음과 같은 이유로 전송 실패했습니다.

--------------------------------------------

받는 사람이 회원님의 메일을 수신차단 하였습니다.

--------------------------------------------


Yep, you'r right, install ;)
Le 6 août 2015 4:37 PM, Simeon Bobylev <notifications@github.com> a écrit :I think you mean composer install instead of update ;-)
It works now, thx

—Reply to this email directly or view it on GitHub.


下面有一篇文章，包含了一些有趣的信息：


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 272](https://teamcity.labkey.org/viewLog.html?buildId=264936&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:07
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Commit comment is wrong. Removed extra quotes around file paths.


non condivido molto questo commit poiché queste sono segnalazioni che l'utente deve sapere, ma approverò la pull request lo stesso


The BLED112 doesn't require modification to the characteristic handles it discovers when you want to tell the dongle to write to them, so I think this only a gatttool thing


Need updates for the post "np-owner" world here and elsewhere.  I'll use set membership instead.


版权软件 --> 版权和软件


xD


`## 用户空间中内核头文件的使用`


See my comment on short circuit evaluation for this to make sense:

2.0.0-p645 :005 > "n"&&"no"

 => "no"

2.0.0-p645 :006 > "no"&&"n"

 => "n"

2.0.0-p645 :007 > "no"||"n"

 => "no"

2.0.0-p645 :008 > "n"||"no"

 => "n"

Ref:
http://blog.revathskumar.com/2013/05/short-circuit-evaluation-in-ruby.html

On 6 August 2015 at 17:10, Daryn Holmes <darynholmes@gmail.com> wrote:

> 2.0.0-p645 :003 > "n" == ("n"&&"no")
>
>  => false
>
> 2.0.0-p645 :004 > "no" == ("n"&&"no")
>
>  => true
>
> On 6 August 2015 at 17:09, Daryn Holmes <darynholmes@gmail.com> wrote:
>
>> You did not test it with 'n'
>>
>> 2.0.0-p645 :003 > "n" == ("n"&&"no")
>>
>>  => false
>>
>> 2.0.0-p645 :004 > "no" == ("n"&&"no")
>>
>> On 6 August 2015 at 16:44, meraymond2 <notifications@github.com> wrote:
>>
>>> Hmm, that's a bit strange. It looks like it works for && though:
>>>
>>> 2.2.2 :008 > "no" == ("no" && "NO".downcase)
>>> => true
>>> 2.2.2 :009 > "no" == ("NO".downcase && "no")
>>> => true
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/meraymond2/week-01-coursework/commit/71790d99bf2e6ba2840dfe58b508d6ff37c66fbd#commitcomment-12568644>
>>> .
>>>
>>
>>
>


Summary of review.   This definitely validates the functionality but I think we can reduce the number of tests and achieve the same coverage.  In total I think we only need three tests:

* `should_prepare_once_when_enabled` (Currently named `prepareOnceWhenQueryConfigured`)
* `should_prepare_everywhere_when_disabled` (Currently named `prepareOneQueryEverywhereWhenConfigured`)
* `should_prepare_everywhere_when_not_configured` (Currently named `prepareOneQueryEverywhereWhenNotConfigured`)

Additionally, a lot of the tests share some common logic that is:

1. They prepare a statement
2. They check whether or not the statement was prepared on each node and validate based on whether or not they expect only one node to be chosen.

Therefore you could come up with a common method, let's call it `validatePrepared(boolean expectOnce)` that executes a query and validate where it was prepared based on expectOnce.  For example:

```java
public void should_prepare_once_when_enabled() {
    queryOptions.setPrepareStatementsOnce(true);
    validatePrepared(true)
}
```

Let me know if you have any questions, thanks!


Oh baller; that's a simple fix. :+1:


Good catch. I'll get it in the next PR.


Nit: I think Rust's precedent is to treat acronyms like other words. I'm sure we're inconsistent here and there, but `Arc` etc suggest so. Hence this should be `AdtDef`.

Less nit: Writing `&'tcx AdtDef<'tcx>` is tiresome and error-prone. We should at minimum follow the `Ty` precedent and make `type AdtDef<'tcx> = &'tcx AdfDefData<'tcx>`. I'd also personally be fine with a newtype (for both this and `Ty`).


1: M101 signature is missing
1: M111 unrecognized component name: personal_collection


(a new type feels right to me because this constraint is more naturally enforced as part of the newtype, which signals "an interned AdtDefData")


Tested and it works like a champ, too. :metal:


You also need to apply the settings layout. Sorry, I forgot to write.

```
var group:LayoutGroup = new LayoutGroup();
			Starling.current.stage.addChild(group);

			var groupTop:LayoutGroup = new LayoutGroup();
			groupTop.backgroundSkin = new Quad(300, 150, Color.RED);
			group.addChild(groupTop);

			var buttonGroup:ButtonGroup = new ButtonGroup();
			buttonGroup.gap = 10;
			buttonGroup.verticalAlign = ButtonGroup.VERTICAL_ALIGN_MIDDLE;
			buttonGroup.horizontalAlign = ButtonGroup.HORIZONTAL_ALIGN_CENTER;
			buttonGroup.direction = ButtonGroup.DIRECTION_HORIZONTAL;
			buttonGroup.distributeButtonSizes = false;
			buttonGroup.dataProvider = new ListCollection([{label: "One"}]);
			group.addChild(buttonGroup);

			group.layout = new AnchorLayout();

			var layoutData:AnchorLayoutData = new AnchorLayoutData();
			layoutData.top = 0;
			layoutData.left = 0;
			groupTop.layoutData = layoutData;

			layoutData = new AnchorLayoutData();
			layoutData.top = 10;
			layoutData.topAnchorDisplayObject = groupTop;
			layoutData.horizontalCenter = 0;
			layoutData.horizontalCenterAnchorDisplayObject = groupTop;
			buttonGroup.layoutData = layoutData;
```


```go
package main

import (
	"time"

	"github.com/paultag/go-fancytext"
)

func main() {
	done := fancytext.Spinner()
	defer done()
	time.Sleep(3 * time.Second)
	done()
	time.Sleep(3 * time.Second)
	done()
}
```


Yep, install... I wrote my message too fast.


"bainary"


(this pattern makes it easier to avoid the chance of that goroutine not getting cleaned up once our reference to the function that can close the channel is gone)


这个被许可并且不会导致用户空间成为内核的衍生品并受限于 GPL 协议。


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.467](http://teamcity.monogame.net/viewLog.html?buildId=9461&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:23:00


Why not call Scintilla for the rescue?


I'd call it getXWikiCfgMock() instead


Yeah, i just saw you edited your comment xD that's better, fixing in master


I'd call it getVersioningStoreMock()


I've updated crates.io to 0.0.6.


I'd call this method registerEntityReferenceMocks() instead to be consistent with other methods like getXWikiCfgMock(), etc.


As an experiment you try and change this to use a case statement instead of the if, elsif, else

http://www.skorks.com/2009/08/how-a-ruby-case-statement-works-and-what-you-can-do-with-it/


Offset isn't defined anywhere. Just removing the offset variable (as if it were 0) seems to make everything work perfectly.


My apologies, I think you are right. `get_timer_value()` should indeed return the timer ticks. I was confused by this comment in `delay_timer.h`: `The ratio of the multiplier and the divider is the clock frequency in MHz.`. I think this needs correcting to `The ratio of the multiplier and the divider is the tick period in microseconds.`. Also, it looks like our FVP implementation is wrong but the behaviour we see is not as expected.

We're just going to spend a bit more time looking into our FVP port and then we will merge this.


I search for registerComponentIfDontExist() and couldn't find it. Is that something new?


That's the thing, it does not register mocks.


bah c'est assez pratique pour éviter d'avoir à corriger le style de toutes les div une par une :) le reste je le laisse à JQuery :)


yes, I have, but I put them in comment as they fail now, we have to complete the issue #8 then we could check with that testCase.


ah indeed :) Then I'd prefer registerEntityReferenceComponents()


Took me a bit to figure out why this wouldn't trigger in the case where a table changed and we get a keyspace change event as well (or if we updateKeyspaces on control conneciton reconnect).  I think it is because we only compare keyspaces when we rebuildSchema is called without table = null, is that right?  I can't seem to produce a case where we get a keyspace changed event where we shouldn't so it looks like this does work :)


Yes using `${KODI_LIB_DIR}` will only work on linux and will not work on all other platforms where `${CMAKE_INSTALL_PREFIX}` is the proper thing to use. That's why I suggested that we should provide a helper method for that.

Concerning the platform/arch tests you can test platforms using `${CORE_SYSTEM_NAME}` but there's nothing for different arches per platform yet. Using `APPLE` etc. won't work because they describe the host and not the target system.
Why do you need it in this particular case?


McBaaaaaain.

![AAAAAAIN](http://vignette3.wikia.nocookie.net/simpsons/images/4/40/McBain1.gif/revision/latest?cb=20101204224139)


I think these magic constants should be in criurpc.proto


it's on commons side.


You code is very tidy, I like it!

Only comment I have, you don't need the 'amount_to_trasfer'.

Again, your code is very clear and tidy...


no it is not required at all. my mistake. i delete this line in the next commit.


This doesn't do the same thing (though I assume it might in a future commit):

```ruby
@display_user.info_requests.pluck(:described_state).uniq
# => ["waiting_response", "successful"]

assign_request_states(@display_user)
# => [#<struct  value="waiting_response", text="Awaiting response.">,
#     #<struct  value="successful", text="Successful.">]


:+1:

It's a shame this local storage key doesn't confirm to our convention `gu.<keyname>`. Is it too late to update?


Could use a bang method here to raise an `ActiveRecord::RecordNotFound` if no record is found (though we'd lose the custom message)


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: personal_collection


1: M111 unrecognized component name: dojson


1: L101 copyright is missing


1: D100 Missing docstring in public module


How about this?
{ case x: Double => Some(SoQLDouble(x))
   case _: Any => None
 }


一般情况下，头文件的使用不会产生衍生品，尽管也会有例外。过去对于头文件中包含了多少代码量（例如代码行数）有投入很多的关注，但是现如今大家都不太关心这个问题了，并且几乎从来不是一个问题。理查德．斯托曼曾表示，针对数据结构，常量还有枚举类型(甚至小内联)的头文件的使用都不会产生衍生品。请看：


testing line note.


i don't think we will be adding this to the UIKit.  We have internal git projects that better serve containers for images.


検索した時に常に画面が中央にくるようにする


这种链接保留吧，可以这样写：

`<http://lkml.indiana.edu/hypermail/linux/kernel/0301.1/0362.html>`


Not sure losing the string matters (e.g. https://www.whatdotheyknow.com/user/ajwhebcuawecvuawbc3232937y23).


@pSub the fact is I cannot reproduce the error... are you able to on current master?


Be careful & knowledgable about methods that end with a !.

See this: http://stackoverflow.com/a/612196/259477


Не очень хороший способ строить запросы с in (select....). Гораздо лучше использовать join


Because `Cell` requires `T: Copy` and I am too lazy to implement `Cell` it myself.


Juhuuuuuu!
(⌒▽⌒)


It wasn't reverted yet, we are talking b/c the config does not necessarily enforce show_diff false and for security reasons we should not show those diff's as they could contain sensitive data


Drukkolok!


Nice!!!


Hm. Turns out, this change actually makes it more ugly, because then one
needs to check that there is `src` and there is `src.meta`, and only
then `src.meta.homepage`. Reverted.


Now that you are looking at this code... It would be nice to have an enum here, so we avoid bugs on what 1, 2 or 3 mean.


ok I missed your commit on commons, just pulled and seen it. Thanks


See https://imgur.com/TAj37vY for promising, yet incomplete local testing.


help....I'm trying to restore my backed up messages and can't find the app.


At least this explains why linking with -latomic was never needed before. My crosscompiler now complains about a missing library, while my gcc on Ubuntu does not care. If the dependency is only needed for RPM build, it would be nice to only supply it for that. I don't know if I'm capable to find another solution, we may have to ask more experienced people, maybe @smurfix . Perhaps there are variables which only apply to the RPM part? Or the configure check is only done when RPM build is selected? Or the library is added directly to the specific link command in the affected makefile?


Мне кажется, менять права каждого пользователя - не лучшее решение. Гораздо лучше давать права группам, а при выводе суммировать права от группы и права от пользователя.


Hello,
I have a problem after intalling pymobility. I can't do this test:
>>> from pymobility.models.mobility import random_waypoint
This is error message that it display:
ImportError                               Traceback (most recent call last)
<ipython-input-1-ad14d53a4ba8> in <module>()
----> 1 from pymobility.models.mobility import random_waypoint

/home/user/anaconda3/envs/py34/lib/python3.4/site-packages/pymobility-0.1.0-py3.4.egg/pymobility/models/__init__.py in <module>()
----> 1 from mobility import *

ImportError: No module named 'mobility'
Please help my,
Thanks


This could be changed to `unless` too?


It would be really great to have a link to back this up. Somebody is going to ask how this happened and for proof.


it is not like there are any non-interned `AdtDef`-s anywhere.


Alon Waisman: come in the morning but didn't attend any classes. Spent the day searching for doctors and going to the ER do deal with a broken thumb.


the mainline kernel developers added an option to the kernel build system to specifically create "sanitized" headers that are deemed safe for use by user-space programs, without incurring licensing issues.

--> 主线内核开发者给内核构建系统增加了一个选项，专门提供了一个“经过消毒处理的”头文件，这些头文件被认为可以安全用于用户空间程序，不会产生许可问题。


Не стоит использовать union


fix #20


Nobody wants them anyway :+1:


可以同样当作命令引用起来，类似这样：

\`make headers_check\`

效果：

`make headers_check`

两个都加一下。


Arduino linked to here, so I made my comment here.
When I noticed I made the same comment on the arduino github.
Thanks for answering :-)


the phenomenon is:

first my ENVIRONMENT_TYPE is 'test', everything is fine, all Solr_Configure, Solr_Reindex and search function are going well, and then I changed it to 'live' then doing the procedure, Solr_Configure is fine, the 'config' folder is created, everything is copied over to the core, then Solr_Reindex, it doesn't only doing the reindex, but also blows away all the indexed data, there is 0 file under solr_store_path/data/index. So my search function return Solr errors, thus broke my site. However, this is only happened in a Docker / Vagrant case, we test it in a linux / ubuntu host, even with 'live' mode, it is still working.
So really don't know what is source of that, and need more time to investigate, will report my result of investigation here. Our temporary solution is to roll back from 1.1.0 to 1.0.6 (thanks for Docker Composer feature, that makes the rolling-back a minute job). It also due to our customised SearchIndex class, the time being, I couldn't tell. :)


Alon Waisman: came in the morning but didn't attend any classes. Spent the day searching for doctors and going to the ER do deal with a broken thumb.


Yes, but it's apple, and company code-style


@frenkield thanks for this! Looking good, will merge for the next release the coming week!


excellent


Using `Tag.objects` here seems to cause an issue where other `TagBase` child classes can't find existing slugs in their own tag tables?


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-87.96%25-red.svg)


It seems you forgot updating gulpfile.js #2397


Could this just be:

```ruby
- User.find_by_url_name_and_email_confirmed(params[:url_name], true)
+ User.find_by_url_name_and_email_confirmed!(params[:url_name], true)
```


I’ve stopped DOI production for now. Since we’ve been running successfully for a while now, a few other things have piled up, too. I’ll take care of it and resume production once I have time to deal with it unhurriedly.

On August 6, 2015 at 7:49:27 AM, Shyue Ping Ong (notifications@github.com) wrote:

I have been seeing a lot of these commits. Does this really need to be in MPWorks or can it be in a database? The long list of these commits make it extremely difficult to find any old commit in MPWorks.

—
Reply to this email directly or view it on GitHub.


$group->id == 2 это что такое вообще?


一般使用下，使用这些被净化过的头文件是合法安全的（也就是说，头文件被特别地去除了大内联宏或者任何用户空间不需要的内容）。


If you find the PR where this was discussed you could add this discussion to the wiki (or here) so people know the "why"


Don't use `unless` with `else` https://github.com/bbatsov/ruby-style-guide#no-else-with-unless


This throws an error

     error: call of overloaded ‘Configure(const string&)’ is ambiguous

 when something like this is called

     "forceSensor->Configure(FORCE_CONFIG_FILE)"


Хардкод?


这篇文章解释了如何用内核构建系统来创建净化过的内核头文件。


It doesn't matter because `dup` is still a reference to the same object. I kept it with the code above it because I want to remove all the current allocation tracking machinery.


Use `&&`


The constructor is private, so you can't create them. It may be better to make the un-primed `ADTDef` (next commit) and friends newtypes.


Looks like a reasonable workaround.

I'm going to try and write a standalone libmesh example that tries to allgather a `vector<pair<Real,Point>>` just to confirm it doesn't work.  BTW, the build machines are using mpich-3.1.2 while rod uses openmpi-1.6.5.


Fair enough, we should look to see if we can improve that though. I know that the customer class assumes `0` if no user.

https://github.com/easydigitaldownloads/Easy-Digital-Downloads/blob/master/includes/class-edd-db-customers.php#L70


@avagin Should these constants stay in criu_opts.go, as criurpc.proto is imported from criu?


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1272 of 1272 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would actually prefer to have them fail until #8 is complete. It would sort of serve as a reminder to fix #8 :).


we have a field

'recompute_pack_op': fields.boolean('Recompute pack operation?', help='True if reserved quants changed, which mean we might need to recompute the package operations', copy=False),

and so many logic write picking and pass this field as true, but never been checked in any logic

why not check 'recompute_pack_op' in vals then unlink all operations ?


So, to answer your question:

> I did this three step, I also comment in the code like Step 1, can you take a look above code and lets me if its proper approach, and the following

If the tests are failing, probably it is not a proper approach.


需要注意的是，Android 操作系统开发者使用一种不同的过程来为他们的系统净化 bionic 头文件。他们的过程过程与主线头文件净化特性差不多同时开始。


Not weird, the delimiter in yaml is ":" so not allowed in text.

Put the text between quotes "my : text"


Can we use a general secret here? This would make a heavily used plugin obsolete: https://github.com/wbbaddons/Signer


991757360-DocIssues-4956-4997 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1765 of 1778 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.27%25-yellow.svg)


加了点注释


You're right - that's a mistake in the global change to redirect fossil subcommands. I've pushed a fix to this branch.


test-s3-fixes (lefticus) - x86_64-MacOS-10.9-clang: OK (1788 of 1789 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Lines 58 & 59: `@post` isn't available inside the `Post` instance - try to find an alternative way of accessing this post.


When reverse-variance goes away this should be split into an `lookup_adt_def_mut` (for collect, which needs this kind of access) and `lookup_adt_def` (for everyone else), hand-variancing.


I don't think xunit allows static test methods, does it?


- 自由软件法律重心为开源项目提供法律代表并发布围绕开源相关的法律问题信息


Security 1&1 says this is insecure. RFC 2104 exists for a reason. `hash_hmac` resides in the Hash extension which currently is not required. A polyfill is easy to write, though: https://github.com/wbbaddons/Signer/blob/master/file/lib/util/Signer.class.php#L122-L148


typo here ` @track_things = @track_things = `


I believe you can leave the required for version.   The required indicates that it is required to launch the service... which in this case it is.   It doesn't mean that that it must be provided.   A property that is NOT required would be something like auth... providing auth creds is an optional property.   For version,  the crate service can NOT run without it so it is deemed required.

Please add this back.


- Linux 基金会的开放合规性计划


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


This case should currently pass, correct?


This is insecure as well. Do not trust external input!


This has nothing to do with your change.  But this is weird.  Type any really needs to be byte array.  But it is hidden within.


This was awesome thank you


This is insecure. Timing attacks are possible. Use `PasswortUtil::secureCompare().`


Interesting idea. I'll give the `discriminator` a shot. Would this be overloading the intended use of `discriminator`? From what I understand, `discriminator` is intended to denote polymorphism, but does not not necessarily indicate that the model marked `discriminator` should be abstract.


Nice, but this text deserves a revamp including content from the deleted part, no?


testing line note in-line.


991757360-DocIssues-4956-4997 (rglazer2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


So, this doesn't actually work, and I'm not sure why. If the method is defined in account.rb, it tells me the method is undefined for that kind of object. If however, I define the method in main.rb (which is there, but commented out), it does work. I'm struggling to understand the difference.


@huikang Yes, I think these should be in criu_opts.go too
Ruslan sent a patch with these constants http://lists.openvz.org/pipermail/criu/2015-August/021633.html


underlying(idx)


一个针对二进制进行分析的工具，用于调查 GPL 合规性

注：这类翻译可以点进去链接看一下具体意思：

The Binary Analysis Tool (BAT) makes it easier and cheaper to look inside binary code, find compliance issues, and reduce uncertainty when deploying Free and Open Source Software.


Consider doing a redirect here. This allows the httpd to pump out the data and frees up an PHP worker earlier (should be considered for the Gravatars as well).


Oh, it's definitely configurable in both VS as well as ESLint; however, I had to ask before making any assumptions, especially since you hadn't included the [guard-for-in](http://eslint.org/docs/rules/guard-for-in) ESLint rule in your configuration.


I could be mistaken, but it doesn't seem that this change is related to #8. For the sake of organization and the ability to easily rollback changes, please be specific about the commits you make. For example, if your commit is intended to progress on #8, then each change in that commit should serve that purpose. It also makes it much easier for someone else to read the commit so that only the relevant parts of the proposed solution are visible.


yes


LWN.net 上一篇关于二进制分析工具的文章（发表于 2010/05/06）


Great, can hardly wait for the next release!


Please throw in a `TODO: Make this part of the iptables interface`, your comment about this is right - it should be.


下述链接可以全部用 \`<http://gpl-violations.org/>\`  这种写法来保留链接，下面所有都需要修改下：

效果如下：

<http://gpl-violations.org/>


This function may not be efficient if it is used in a loop to process every single row.


i need to dig through the notes, but I think this follows the model quite closely for implementation with discriminators.


最后的信息也请保留和翻译：

[分类](http://eLinux.org/Special:Categories "Special:Categories"):
-   [开放源码许可](http://eLinux.org/Category:OpenSource_Licensing "Category:OpenSource Licensing")


This changes the public api. The call to get_declared_fields that was removed (old line 66) included base.base_fields, not base_declared_fields. The behavior of the following is now different:

```
class ABaseForm(ModelForm):
    class Meta:
        model = AModel
        fields = ('some', 'fields')

class AChildForm(ABaseForm):
    pass
```

Previously AChildForm.declared_fields would include the fields given in the Meta of ABaseForm, now it does not.


This comment is a little confusing.  The whole part about "except not including..." is not needed.  iptables-restore will handle it fine.


up to aac930c


`WCF_UUID` is generated in [PackageInstallationDispatcher](https://github.com/WoltLab/WCF/blob/e09c7044b7be1c01c5addf2aed8f2b8e4106b148/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php#L188-L196). We should decide on one location for both.


`if @track_thing` would be better?


There also `_.assign(this, opts)` if you really want to keep the syntax short. See [lodash#assign](https://lodash.com/docs#assign).


s/if/If


`if @xapian_requests`


yes, this test cases are passing.


wait, why is this in here?


poke @Tobschinski about these errors.


The problem is that your second configure method (the one with 3 parameters), provides defaults for the second two parameters; thus, if you call Configure with just one parameter, X, the compiler does not know whether to call Configure(X) or Configure(X, 10.0*cmn_ms, 0).  You can fix this by removing one or both of the default parameters.  But, why can't "timeout" and "customPortNumber" be provided in the config file?


I'd prefer `rawurlencode` for consistency reasons.


98318570_RemoveRadianceCheckbox (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Are you sure you need to `urldecode` here? Usually the Web server does this for you.


Need to look this over for possible PureDarwin 10 build.


Might want `if @xapian_requests.present?` here so that this isn't show in the case of `@xapian_requests` being `[]`.


I would recommend doing the steps in their aforementioned order:

> 1. This type **is** `java.util.Collection` (which you have already started to do here, or
2. This type **implements** `java.util.Collection` (in the case that the type is a class), or
3. This type **extends** `java.util.Collection` (in the case that the type is an interface).
...
The code for (1) seems to be all the way at the bottom of the method. Furthermore, I don't see the code for (2). Please let me know if I am mistaken. Then, I would do (3).


哈哈，你要去掉别人的if和括号间的空格，你自己却整个空格；果然任性


[`pathinfo(..., PATHINFO_EXTENSION)`](http://php.net/manual/en/function.pathinfo.php)


`if @xapian_requests` – results check is next line


Ideally I'd like to only define how algorithm is spelt in one place to avoid the risk of typos. But not a priority just now


Am I missing something here, or could this change leads to people accidentally checking in there secret key?


yes this tests are failing except the Collection that we had.


Nice! Now we just need a better name for "dummy" :P


这里也翻译一些：

```
[分类](http://eLinux.org/Special:Categories "Special:Categories"):
-   [Linux 跟踪系统](http://eLinux.org/Category:Linux_tracing "Category:Linux tracing")
```

效果如下：

[分类](http://eLinux.org/Special:Categories "Special:Categories"):
-   [Linux 跟踪系统](http://eLinux.org/Category:Linux_tracing "Category:Linux tracing")


Not sure about all these:

```diff
-    <% if !@xapian_comments.nil? %>
+    <% if @xapian_comments.present? %>
```

Most of them look like they can just check `if @instance_var`?


Great! Would you please update it on PyPi, so we can update the FreeBSD port. Thanks.


Cool. How about a test case where a class directly implements `java.util.Collection`? I would recommend writing the test case in a Java project before copying it to the `resources` directory.


thank you


You could also use [description](link) here. So much easier :)


s/没尚未/尚未/g


maybe some day we'll have `u1` support.

For now I'd use either `u32` (since that is the recommended type w.r.t. speed) or `u8` (since that is as close as you can come to `u1` in a numeric type right now).


I did the check for srcObject to prevent the prototype function from being overwritten in case it's natively supported - would that not be a problem?


do we need those empty rows?


In the pluginstore @TimWolla said, that I should validate the host, whether it is "localhost" for security reasons.

For example: https://github.com/wbbaddons/Image-Proxy/blob/master/files/lib/system/event/listener/ProxyListener.class.php#L33-L60


Changes made. It looks like moving all of this over to `iptables` should just require making use of the runner and locking the runner mutex and adding the methods to the interface.
I can go ahead and do that if you'd prefer.


test-s3-fixes (lefticus) - Win64-Windows-7-VisualStudio-12: OK (1795 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


一种提案，目标是在内核中实现一种通用的统计工具


TeamCity DNN JavaScript Libraries :: CI [Build 63](http://teamcity.engagesoftware.com/viewLog.html?buildId=331&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


Actually, this case is not being exercised. The code for the test is commented.


TeamCity DNN JavaScript Libraries :: CI [Build 63](http://teamcity.engagesoftware.com/viewLog.html?buildId=331&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:17


hh


一种针对 CPU  的硬件性能监控特性的接口


it would probably be more idiomatic to write this code via an iterator that seeks the right-most non-zero index, and then use that for the borrow.

(At the very least, I think writing it in that style would avoid the implicit bounds check that this incurs. But what do I know, maybe LLVM manages to optimize away the bounds checks in code like this.)


outputLiteralTypeArguments


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


:+1: It's 2 fewer lines and it's no longer clouded by `$model instanceof InsightsQuerypageModel` logic.

Can `wgEnableInsightsInfoboxes` be moved into `updateInsightsCache`?


inputLiteralTypeArguments


Зачем так сложно. Ты же знаешь, кого ремувишь. Поэтому достаточно вернуть `bool`.


有能力跟踪系统调用的进入和退出，也能够用于跟踪信号如何传递到进程（也用于调试进程）


Needed to squashed this change into the commit when the file was added (2fd7998fc4f9667f5c20d3c15926a0afb0606a44)!


API design: up to you.

A series of bool flags makes call sites hard to comprehend and easy to get wrong.  Consider something like:

```
type RestoreCountersFlag bool
const RestoreCounters RestoreCountersFlag = true
const NoRestoreCounters RestoreCountersFlag = false

type FlushFlag bool
const FlushTables FlushFlag = true
const NoFlushTables FlushFlag = false

func Restore(table Table, data []byte, flush FlushFlag, counters RestoreCountersFlag) error {
```

then the call-site becomes

```
iptables.Restore(iptables.TableNAT, data, iptables.NoFlushTables, iptables.RestoreCounters)
```


extractCalculationInputs is poor name. Pick something which explains what it does.
E.g. extractBingingForLiteralTypeParameters


Сложно выглядит, ну ok.


use long form `--counters`


可以用 \`man ptrace\` 和 \`man strace\` 替代，效果 `man ptrace` 和 `man strace`


Padawan, then, it is and shall be.


wing = with


If we're going down the `assign` route then why not just use https://github.com/sindresorhus/object-assign which contains the one method (and uses the built-in `Object.assign` if available)


why do we want a name in case when alias is not set?


lodash is too big ;). Especially when somebody will use PostCSS with React Style on client.

I do not see any problem with `for-in` in this case. Problem is only in linter, not in the code.


false


I comment because it will give the build error in travis, I am running them in local machine.


Это же метод мапы, причем тут я?


This is illegal.


inline


991757360-DocIssues-4956-4997 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (744 of 744 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.14%25-green.svg)


The sorting of calls was an issue and is resolved in 7ec55ff.


Thanks for researching this


The configuration file is the one that ATI provides. The reason for customPortNumber is to read simulated force/torque values sent over that port(when user wants to simulate FT when no physical sensor is connected.) User doesn't have to provide this number unless he wants to read values over a udp port.

I think if we don't wan't to pass the parameters in the function then we can pass the configuration file as a json, which will include the xml file provided by ATI and any other input parameters.
(OR)
Overload the base class 'Configure' as Configure(X, 10.0*cmn_ms, 0) and remove Configure(X) (As it was before)

@marcinbalicki Any particular reason this was changed ?


am I crazy for wondering whether we'd be better off with a hard-coded table mapping `size_of::<$ty>` to the appropriate values for `small_e` and `small_power`?  (That is all that matters, the size of the type involved, right?)


Thanks :)


Maybe, I don't know. I'd be more inclined to improve the documentation in each of the other options.


Don't do this.  just use the `-T table` flag


add test for methods differing only on return type (this probably should go to your previous commit)


> Value assigned is not used in any execution path.

No reason to create a new syntax error here if you're just going to override it below.


I think you're going to need an issue number attached to this FIXME for it to pass `make tidy`.


iptables-save and iptables-restore should be const variables


It should be fixed now. Commit 1f5208b7777c10f70b0d8bd0231ba980abb1ef99.


also add tests for more trivial cases if they are missing.


Followed these [guidelines](http://stackoverflow.com/questions/359424/detach-subdirectory-into-separate-git-repository) for **detaching a subdirectory into separate Git repository**

```
hei2@tgax89:~/alice.thesis$ git filter-branch --prune-empty --subdirectory-filter Thesis/ master
hei2@tgax89:~/alice.thesis$ git push https://github.com/tungufoss/alice.thesis.git -f
```


I see. I did some more tests today. The problem occurs only when 'make
rpm' is performed
without a prior 'make all' or after a 'make clean'. I also noticed that
'rpmbuild' does its own
./configure - maybe one of it options.

I believe if I make RPM dependent on 'all' and 'dist' then the problem
should not occur.
I will change this (and remove libatomic). Please let me know if that
works for you (it seems
to work for me on Ubuntu).

On 08/06/2015 06:25 PM, Othmar Truniger wrote:
>
> At least this explains why linking with -latomic was never needed
> before. My crosscompiler now complains about a missing library, while
> my gcc on Ubuntu does not care. If the dependency is only needed for
> RPM build, it would be nice to only supply it for that. I don't know
> if I'm capable to find another solution, we may have to ask more
> experienced people, maybe @smurfix <https://github.com/smurfix> .
> Perhaps there are variables which only apply to the RPM part? Or the
> configure check is only done when RPM build is selected? Or the
> library is added directly to the specific link command in the affected
> makefile?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/knxd/knxd/commit/da5f57832d33628c232f3d1f2526748a02dbddd1#commitcomment-12569580>.
>


Indeed, but there might be a gap between theory and practice :wink:


I would just throw this as a `defer` after the call to `TempFile()`


Totally understand.  So when I started to debug why this was breaking multi text tracks,  first obvious one is that fragmented text was never detected in the getIsTextTrack thus never called append on text source buffer.  Obviously change is what @KarishmaBagga suggested but I agree that it is not a true mimeType... I did alter the getIsTextTrack temporarily to detect FT but still did not play....   I will debug this more today but I wanted to talk to you first to see what other PR are related to this.  I see #690 & #685.   I think I should pull these in and add to my branch before I fix.  Agree?


I am ambivalent on whether IANA should allows for this or not, but I think the section should be replaced with a short one which says "IANA doesn't allow removal of entries from this registry" or something like this.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1272 of 1272 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


hmm, does the `mul_pow5` method also panic on overflow in non-debug builds (i.e. builds without `-C debug-assertions`)?  I didn't see anything obvious in there to indicate that it would.


I think this line is unneeded, too


if multiple spaces are between calculation part and alias part all but one space will be present in calculation group. This probably does not matter as later on antlr parser will ignore those.


Because each characteristic has a handle and each of the characteristic's descriptors has a handle. In order to subscribe to a characteristic, one must write to the client characteristic configuration descriptor with a value that means the subscription is either for notifications or indications. To do that, a handle is needed so get_handle is called.


Will change that. Thanks for pointing out the criu patch.


why do you print it if it is null :)


commit is fine apart from idle questions above


Here this.errorHandler should be set. When the driver will be created it will get the value of the errorHandler member.


I like @ben-eb's suggestion. It's not "too big," addressing your concern there and there are a good number of times you would use it in this project, from what I've seen, so it seems high value and good readability.


And error message should read like.

"literal cannot be null"


Yes, switching to the cli flag now, that makes this line doubly inaccurate and unnecessary.


literal cannot be empty. And again do not print it. It is empty - you know it.


Ftrace Function Graph 是 Ftrace 是指 func_graph 跟踪器，所以这里不能翻译成功能图，可以不用翻译或者翻译成 Ftrace 的 func_graph 跟踪器，也就是函数调用（图）跟踪，就是跟踪函数的调用以及各个函数的调用关系，并把这些关系可以绘制出一个调用关系图出来。

----------------------

有 Tim Biard 准备的报告和补丁，这些补丁为 ARM 系统添加了 function graph 和 持续时间跟踪功能


LGTM this commit


El único detalle es que dice "libería" en vez de "librería", pero que genial muchachios!


Is there a test for that?


ha ha


commented


Nice!


I think IANA wants to point to our document and tell registrants "look, here it says that you MUST do something". Whatever is recommended will be agreeable to IANA stuff.


rather than "formatting and parsing", would "round-tripping" make sense here?

In particular, I am thinking back on your comments in the PR description about the potential for overflow on some decimal inputs, and therefore the real point being made here is that it can handle inputs of the same number of significant digits as is used for outputting an `f64`.  (Right?)


commit is fine apart from idle thought on rewording of comment


This is very similar to the function that is currently used in TileServer to process every row.

Is there a more efficient way to do it that you're aware of?

Also, if it helps, the map is generally quite small.


I would suggest your first option (JSON file that includes name of ATI XML file).  Overloading the base class, mtsTask, with a component-specific signature is a bad idea.


Très bien !


i tried to do that but i am not understand clearly what happens there:
```lua
stack traceback:
        [C]: in local 'element'
        /usr/share/lua/5.3/lgi/component.lua:302: in function </usr/share/lua/5.3/lgi/component.lua:287>
        (...tail calls...)
        [C]: in metamethod '__newindex'
        /usr/share/awesome/lib/gears/surface.lua:85: in function 'gears.surface.duplicate_surface'
        /usr/share/awesome/lib/gears/color.lua:292: in function 'gears.color.recolor_image'
        [string "nlog(gears.color.recolor_image('/home/lie/ima..."]:1: in local 'f'
        /usr/share/awesome/lib/awful/remote.lua:25: in function </usr/share/awesome/lib/awful/remote.lua:21>
error: /usr/share/lua/5.3/lgi/component.lua:302: bad argument #3 to 'element' (cairo.Pattern expected, got userdata)
```

so it's raising on line `cr.source = s`


Finally! looked at that like years ago :p

makes me want to go though the code even more to privatize members... just a ton of tedious work that i never seem to find time for :)


regarding the TODO: if you have idle hands, go for it.  I'm going to press onto other commits in this series :)


Note: This doesn't belong in this change, but I'm not actually sure what to do about it.


to be clear: I will circle back, of course.


Remove this loop, as you have decorated with `@api.one`


I use these when using pygatt and I want to get the serial port to which the dongle is connected. I think we should keep these around somewhere and this didn't seem like a horrible place to do it when everything was still named to be BLED112 specific


Remove this line instead of commenting it


Check out issue #85


The same


Something should be added making it very clear that the extension doesn't support multiplexing.


--> 这个报告有些好的介绍 Ftrace 的资料，以及其他资源的链接


Ok, I'm going to go for it and push that along with the other api and docs fixes.


Ok. I'll change it accordingly.


note to myself: set only if not set


用 FTrace 测量函数持续时间，英文周边加空格。。。


Really minor nit: My personal preference is to put tests in a commit *after* the commits that make them work.

That is, while I  approve 100% percent of test-driven development, the commit series need not reflect the order in which the code was written.  And in the case of tests, putting a failing test before the commit that fixes it will cause problems for people who use `git bisect`.


I'll update it to do the filtering out of the Geometry row first, which should improve performance more.

Currently this code is mostly a no-op since we aren't selecting columns other than the location column very often.


取样系统  --> 采样系统


Please squash this commit with the one adding windows support so we get a cleaner and more maintainable history uncluttered with "fixup" commits.


Same here


(Squash)


(having said that, if i understand correctly, this test is not turned on by default anyway, so it really doesn't matter -- i.e., `make check` will still run on this commit, even though it comes before the commits that fix the behavior here.)


LGTM this commit


:+1: Ship it


Link given


And if I am not mistaken, it would also help that the file is cached. At the moment the file is reloaded with each call by the browser.


minor, but please put this AFTER the Proxier struct


That does look clearer. I'll do this in the next changeset.


after the struct


TeamCity DNN JavaScript Libraries :: CI [Build 64](http://teamcity.engagesoftware.com/viewLog.html?buildId=332&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


I looked quickly through the developers list. My conclusion is that this change is probably related to arduino create.
They really like breaking their own windows at arduino. :-(


TeamCity DNN JavaScript Libraries :: CI [Build 64](http://teamcity.engagesoftware.com/viewLog.html?buildId=332&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:7


So a hack is to get the methods, rather than what I'm doing now:

methods + filter (for definition location)

So I should use `LightGraphs.__META__` to create the dict in the form I mentioned elsewhere (docstring -> [methods]). Is the problem if you have many modules in your package? I guess you could be explicit:
```
{{
  MyModule.reverse
}}
```

None of this helps with what's shown at the REPL, but I think it's a good solution.


為什麼不是安裝到 `~/Application` 呢？


取样 --> 采样


This looks like magic and I'll have to sit down with you to understand how it works when you're here :)


LGTM


Conflicts in commit message? Could be better phrased so people get what you mean here if they're git blaming for some ci issue.

Just for the record, this commit is a derivative from one of mine, I don't care but some people do so one would give credit in the commit message. As pointed out, I don't mind.


something in the output this is spitting out when I tried running `few-ones` looks pretty bad in my terminals.  I assume its control characters or something.  I'm not 100% sure what your intention is with the output, but I suspect it would be better if it were free of control characters.


Was it intentional that you did not add a test of depth to the test of shallow fetch later in the file?


@tremainebuchanan try not to combine multiple feature branches.... it gets real confusing when doing a pull request.


LTTng ->  [Linux 跟踪工具箱](../../../dbg_portal/kernel_trace_and_profile/Linux_Trace_Toolkit/Linux_Trace_Toolkit.md "Linux Trace Toolkit"), 下一代


@joshuaruesweg https://github.com/WoltLab/WCF/commit/e934d809061623f97eace064b7741b764fa03524#diff-78c8cd5818525e2894ef1cd7489a8b32R74 !?


@joshuaruesweg That one is checked in `ImageBBCode::getProxyLink()`. Otherwise saving to disk would be completely senseless.


Looks good.


lol


it was about time too :+1:


ah I see, I guess you are spitting out binary output since ... that is the most direct thing to read into your python script for validation?  Hmm.  I don't know, I still am not thrilled; is it so bad to print out the byte values numerically and parse them on the python side?  (It may be a bit slower, but I cannot imagine it is *that* much slower.)


Yeah, that seems better.


Thanks! BitHub has sent payment of  $47.90USD for this commit.


commit is almost worth a rubber-stamp, but I am tempted to ask you to consider revising the output format of the tests to use ASCII when printing to stdout.


Import order shouldn't make a difference that I can think of.  I assume that snapshots would always follow the head/snapdir if that even matters.


打开里头的链接看了下，这里翻译成这个可能会更好：

Linux 内核状态跟踪器


This should probably be  `/^.*/`, rather than a literal dot. We don't use the code coverage stuff.


Got it working :)


TeamCity LabkeyTrunk :: CDS postgres 9.4 [Build 273](https://teamcity.labkey.org/viewLog.html?buildId=264957&buildTypeId=LabkeyTrunk_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:09:51
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


特殊跟踪系统 --> 专用跟踪系统


IMHO: NoLearnPerceptron captures enough information about randomness to make good guesses overall (sometimes); however, not in a system where it has to compete with learning algorithms.  This is due to several factors, the principle factor being: A.) it has to become more fit to become chosen B.) It does this for a brief run when it's randomness is in sync C.) by the time it's selected the period is most likely passed

It is not worth investigating a non-competitive system with NoLearnPerceptron, as it doesn't adapt.


Thanks! BitHub has sent payment of  $46.95USD for this commit.


This can be:
```ruby
hours.map!(&:strip)
```
That is special syntax to say call this function. Also, strip will do what you want it to do.


For me, locally, it is necessary.


跟踪函数进而显示函数执行时间以及调用关系图


Should not need to make a new `Context`. Just put `@Parameter private FeatureOpService fops;` as a field; pass the `Context` to the constructor as an argument; and all `context.inject(this)` in the constructor body.


Any particular reason you use `System.getProperty` to get the separator character rather than `java.io.File.separator`?


Can this be done with a straight array, instead of a stretch List, since you already know the size you want (grid^2) ?


any reason this script is in python rather than rust?

(I can think of some, but they all make me sad.)


Let's hold off on making it deprecated until replacement functionality exists. Otherwise there is no migration path. I made this mistake with `ImgPlus` and I regret it every time I'm faced with dozens of unfixable deprecation warnings.


Why not use javadoc?


Sure thing!

For the quick version, what used to be this:

```scala
class Foo {
  @Call("jsonrpc.method.name")
  def myMethod(...) = { ... }
}

val foo = new Foo
val routes = JsonRpc.makeHandlers(foo)
```

is now this:

```scala
class Foo {
  def myMethod(...) = { ... }
}

val foo = new Foo
val routes = JsonRpc.routes("""CALL  jsonrpc.method.name  foo.myMethod""")
```

So the mapping between jsonrpc names and scala methods now happens in this string description of the routes, rather than using an annotation on the class. That way your classes don't need to know anything about jsonrpc, which is nice.  The magic that actually translates the jsonrpc messages and calls the corresponding scala method is the same as it was before.


这是一个 RT-preempt  工具，可用于测量中断和互斥锁的延迟时间


(clearly i need to learn Python, I don't know what the `//` operator is...)


Ooh, assignment in an `if` statement. I try to never do that. Can be quite confusing.


You already checked that line#557


<img width="572" alt="e81e4452-3aa0-11e5-8c23-eddc60c3e074" src="https://cloud.githubusercontent.com/assets/40650/9118335/b0228358-3c3d-11e5-9463-7beb460b0c92.png">


封装在 -> 内嵌在


<img width="564" alt="screen shot 2015-08-06 at 1 15 47 pm" src="https://cloud.githubusercontent.com/assets/40650/9118339/b632f05c-3c3d-11e5-906e-b93cebe4f37e.png">


(I'm not sure why jslint wants you to make this change, `/./` was a valid regex).


Broad question about performance in the glue between Dart and Skia:

I see that at least for Rect and RSXform, sky forces the glue code to copy over arrays, since Rect is { SkRect + bool } and RSXform is likewise. Is this mismatch required?


Instead of calling it "deprecated", maybe just say that this is intended as a stopgap solution until the `OpService` supports caching more generally.


Mouais. C'est un peu overkill, je trouve, mais bon. C'est ton projet, après tout ! Moi je fais ce que je veux sur l'autre site :D


允许精确地察看在给定的队列中的块层正在做什么操作 --> 允许精确地查看给定队列中的块层正在做什么操作


commit: rubber stamp


My mistake, I've assumed that the image is displayed each time with the Action and not with the real path…


Looks good.


For this section I would instead try to determine if the time is am or pm, tack it onto the time, and then use a parsing function like:
```ruby
require 'date'
DateTime.parse("11pm").strftime("%H:%M") #=> "23:00"
```


这项特性已经合入主分支的 2.6.17 版本 --> 这项特性已经合入主线的 2.6.17 版本


IntegrityError?

Also, can we use a Django choices for this? (open question, not sure it works with integers)


Oh I see, you are overridding the `OpService`. Hmm... what if instead of doing that, you use composition rather than inheritance? So the `FeatureOpService` _has_ an `OpService` parameter, which it leans on as needed. Would be less potential for bugs and confusion I think.


dead code?


idem?


Yeah I screwed this up. I had the vg file there but not in git, deleted it, realized I needed it for the test, and tried to make it again from the JSON, but I did -Jg instead of -Jv.

Not sure what needs to be done to not accept GFA as VG. Maybe VG needs a magic number?


Javadoc copy/paste error here.


d


an `elif` would be more appropriate


Conference proceedings and journal articles are in their own [repos](https://github.com/tungufoss?tab=repositories) by @tungufoss


Please use the same formatting as the other namespace ops blocks.


I'd call that `didLike` or `Liked`


lgtm


Can I ask what inspired this change? In practice, all the uses are calling the same gpr_now with MONOTONIC before invoking work.


Missing license header. But can be added later, of course.


Nice usage of the new breakTo functionality


yeay. i <3 μ


To be more consistent with other API Docs, the URI parameters (`accountAlias` and `serverId` in this case) should be in a separate section/table above Content Properties called URI Parameters to distinguish the difference between the parameters passed in through the URI vs. the properties of the JSON object in the body of the request.


@Dwar3xwar DWMR. :+1:  Keep leaning into this work.


You could do the close portion up when you are determining the am/pm, and then just make it be 5pm and parse it with the other with something like:
```ruby
hours.map!({ |hour| DateTime.parse(hour).strftime("%H:%M") })
```


Brightness is initialized to -1 within BaseMob.h meaning it gets run the same time as initGraphics. Thus the bug still occurs.


More than 1. You only get to orient a node when you remove its last incoming edge, so if you're following an edge and you reach a node and it has more than 1 incoming edge, you just add it as a seed instead of putting it in S.


je crois que tu peux faire .values('maximum') si tu veux ne récupérer qu'un seul champ, ça simplifie le SQL derrière


Do these parameters need to be `protected`? ImageJ style prefers `private` for [reasons of safety and encapsulation](http://imagej.net/Coding_style#Private_over_protected_fields_and_methods).


统计并收集系统中每个任务经历的延迟


Thanks.


also, i was thinking about filtergin again on .filter(value=maximum), is this something that can be done? would avoid the second query and simplfy the code


I'm not sure I quite understand why the `rpycheck_fail.append()` is necessary here.  Can you not simply do something like:
```python
rpycheck = [False * 3]
for [...]:
    rpycheck_one = TSR.rpy_within_bounds(rpy, Bw)
    if all(rpycheck_one):
        return rpycheck_one
    else:
        rpycheck |= rpycheck_one
    [...]
return rpycheck
```


*raise


Yeah...  I'm really not clear on how to clean this up.


~~ending~~ -> starting


idem?


This test would need to include warnings both above and below the priority threshold, and check that only those warning that should get emitted to get included in the report.


Wondering is never crazy. Up until right now, I couldn't think of an elegant way to implement this table. It would presumably be an array, but an array indexed by `size_of::<$ty>` would have many gaps (either filled with garbage values, or making the table entries `Option`s). The natural way to index such a table would be by `log2(size_of::<$ty>)`, and it only just occurred to me how this might easily and efficiently be implemented (`size.trailing_zeros()` with a sanity check via `assert_eq!(size, 1 << log2_size)`).


we don't want to do file I/O for every library in a request


What's the reason for not using the same property name as the Ant PMD task? What's the canonical name in PMD?


Alright, that's from the master branch.


Conceivably could still have problems if the `CoocPXMinusY` has an element equal to `-EPSILON`? Would it make more sense to special case zero somehow? I ask these questions naively, not knowing the algorithm.


We need to get in sync with how this data object's #view and #navigate methods should work. I definitely don't see a need for both a #view(tab) and a #view_tab(tab) method, for one.

Also, the navigate method should be a lambda object that gets stored in @navigate.  This is an essential aspect of this data object in particular, because it allows the lambda to be put into all the Award's child objects--making it possible for them to do their own navigation.  It's critical we get on the same page about this especially now that you're working on some of the most convoluted aspects of Coeus, in terms of keeping track of where we are.

We should probably have a meeting about this stuff, and perhaps do it over a lunch somewhere. I think that'll be easier than via a screenshare.


I'd love to see more idiomatic Scala error handling, for compatibility with the rest of Pathway. It would be great if `unpackNatives` returned a `Try` rather than throwing. Also, probably, the use of matching `Throwable` should be replaced with [`NonFatal`](http://www.scala-lang.org/files/archive/nightly/docs/library/index.html#scala.util.control.NonFatal$).


I guess this example is wrong. I'd just leave it out of the task docs.


@megastep thanks for bringing this up. This change certainly fixes the original bug; we'll have to figure out what's going on. Do you by chance have a CSD that exhibits the perf errors?


you're still using 2 MRUs?


ça ne devrait pas être nb.value <= plutôt que < ?


You could probably reuse the `activity` variable identifier here and use `activity.id` after that if you still need the id.


[如果在这里加一些 djprobe 的资料就更好了]


Hi


Replacing these `try` blocks in the file visitor might be tricky, since `FileVisitor`s method signatures obviously don't expect Scala's `Try`.


Should this check also consider the alternative pole specification for the provided RPY?


2.6.16 前后加空格


Ok, now this answers my question on the other commit. I assumed that the uses would change after the function itself changed so I didn't look here first.


print


I have the  same question about ArpSpoofer, I don't see where  the @sniff_thread is exited ?


Looks like it did. Not a big deal but feel free to PR a cleanup :)


Same comments about `EPSILON` as above.


We now need to check gpr_now() in completion_queue.c, so moving it to a parameter removes a double-invoke.

Yes it muddies all other callers, but I think that's actually a fairly small price for the efficiency gain.


It might be good to note in the comments that chip_size also has nothing really to do with the actual chip size (it's just a copy of the "flash_size" parameter encoded into the header of the currently flashed firmware, and may or may not actually match the size of the physical flash chip)

The SDK does actually use some of the other fields (at least during startup, not sure about other times), but their values are apparently just hardcoded into the SDK and are never loaded/calculated from anywhere.


this doesn't sound like the right place to mangle. i would do the mangling only where we actually log out the trace


Hi George


Do you have a link to the errors?


cc @nathandunn this was an important fix, non canon splice site searches weren't working without this


post-fetch only makes sense for the caching fetchers


采样系统


False correction, pay it no mind; "Permeate" is actually the right choice.


I guess you'd have to ask Simone.


This should be:
```C#
        private static void _set()
        {
            try { SysShortDateFormat = Registry.CurrentUser.OpenSubKey(@"Control Panel\International", false).GetValue("sShortDate").ToString(); }
            catch (Exception exp) { SysShortDateFormat = "d/M/yyyy"; } //ExceptionHelper.Log(exp);

			try { SysTimeFormat = Registry.CurrentUser.OpenSubKey(@"Control Panel\International", false).GetValue("sTimeFormat").ToString(); }
            catch (Exception exp) { SysTimeFormat = "h:mm:ss tt"; }	//ExceptionHelper.Log(exp);

			try { SysShortTimeFormat = Registry.CurrentUser.OpenSubKey(@"Control Panel\International", false).GetValue("sShortTime").ToString(); }
            catch (Exception exp) { SysShortTimeFormat = "h:mm tt"; } //ExceptionHelper.Log(exp);
			SysDateTimeFormat = SysShortDateFormat + " " + SysTimeFormat;
        }
```


Yes, I think in practice this may be picking the unvisited node with lowest ID, given the way maps sort. There may be better heuristics (low degree? high degree?).

Anything you pull out of unvisited is guaranteed to be in a new connected component that had no heads, but I think the way I'm doing it won't handle components with only tails all that well.


The suggestion to use NonFatal is probably correct, I like this.


@krainboltgreene

Fingers in your ears "lalalalala"


请注意，分析系统（或者“采样系统”）略有不同，在这里他们涉及到采样而不是时间跟踪。一些主要的 Linux 采样工具有：


Not for any *particular* reason, just for consistency I suppose, since all the rest of the calls are to System.getProperty


shouldn't this be `{model.full_name}`??


Ops naming is now lower camel case, not all low case. https://github.com/imagej/imagej-ops/wiki/Naming


Yeah, it would be nice to do this in a less ugly way. Maybe NodeSide and NodeTraversal need their own header? Or maybe there could just be a forward declaration of the class?


为正在运行的系统（包括进程）提供了一个动态实时的视图


@madhuracj
Good to see your fix! I will stick to the coding-style guidelines in the future contribution. Also, I will fix the remaining coding-style problems by tomorrow evening.


Yes, I missed fixing that line.


Let's delete this huge block of commented code please.


@phadej, even with that fix applied, Cabal 1.22.4.0 still doesn't manage a round-trip of http://hackage.haskell.org/package/pandoc-1.13.2/revision/2.cabal; the generated Cabal file is still broken.


I hemmed and hawed about whether to mangle it here, but I was afraid that if I didn't do so it would end up getting logged somewhere that I didn't know where it was and crash everything.


Yeah, this is a quick hack to print the operations *as they're happening* instead of all at once at the end.


原链接已经失效，可以用 http://www.ibm.com/developerworks/cn/linux/l-oprof/

好像所以 IBM developer works 的链接都失效了，可以直接 Google 链接中最后的那个 html 文件名来找到正确的链接，或者后面我们自动替换吧，几乎所有的相关链接都是失效的。


The assumption the channel is always a bound value, which I suppose doesn't have to be true.


pushed fix for these.


Review 完毕！


pushed.


Instead of doing `${{ demand.de_price }}`, angular allows us to say `{{ demand.de_price | currency }}` and also for numeric quantities `{{ demand.de_quantity | number }}`.

Checkout [angular docs](https://docs.angularjs.org/api/ng/filter)


I agree: the end goal for modern code is to never `import ij.<anything>` ever. Work with ImgLib2 and ImageJ2 data model classes, and let the ImageJ legacy layer take care of exposing them as ImageJ1 objects in cases where that is needed.

I realize that there are many reasons we cannot always achieve this ideal, but if your plugin is already working with ImgLib2 data structures, it may be more achievable than you think. E.g. as Christian says, use SCIFIO to open your image data rather than e.g. `IJ.openImage(String)`.


The dot output is something I thought of too. I had another commit to add differently-oriented ends to the edges, but although it tested fine on my machine, I got what I think was an intermittent failure in the seemingly unrelated `vg map` "unitig mapping position is as expected" test on Travis. So I pulled it and added debugging that to my TODO list.

`portPos` looks like a much better way to do that. I didn't know it was a thing.


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2166 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.79%25-yellow.svg)


private fields always using `_camelCase` ?


991757360-DocIssues-4956-4997 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1262 of 1262 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


One good advice.

See the results for each different workers in any tests ?
Each one has a different result, with a W - L ranging from -20 to +20 usually, after 1000 games.

So never get (too) excited with a +20 local test.
Because your -20 test might prove to be better !!!

And to see anything on fishbench, you should set your numgames to 25000 or 30000 games.
If the result is really really really bad, you can stop it before the end.
If the result is very good, you might be allowed to go directly to LTC.

Also, after 25000 games, the error is usually less than 2 ELO,
so at least you get a measure that you can compare,
if you test specific other BestMoveChanges  values later.

In the present case, it is hard to believe that a 0.01 might change anything,
but who knows ?

So...good luck with your tests !


We can definitely move away from this sort of ImageJ1-centric usage, as part of @etarena's efforts—I'll have ample opportunity to ~~brainwash~~pontificate about how best to use ImageJ2 libraries. :wink:


It will print out all diagnostics as a summary after `dnu restore` if you add your error message into `ErrorMessages` (see code below). Here is a sample output:
![capture](https://cloud.githubusercontent.com/assets/1383883/9118734/53358688-3c27-11e5-84d8-6a75adb3608c.PNG)


Yeah, but we are legacy, so we'll need it. :)
I guess the newer SoC's are implementing this in device trees (dt), so they don't need it, hence they removed that.


Argh, thanks for the heads-up.  I should have thought of this; it's likely related to the way VB's linker implements a /DELAYLOAD-like stub for normally declared API calls (http://www.microsoft.com/msj/1298/hood/hood1298.aspx).  TLB-defined functions must be handled using the original, non-delayed convention.

This is going to be particularly problematic for various Vista+ features I want to add, as they're primarily exposed as interfaces.  Time for more hideous VTable hacks, I guess!


This doesn't seem to be an int. Also I'm not sure what the exact format is that's allowed here. "yyyy-MM-dd" seems to be working. Not sure yet if I can filter out via time of day too. So this should be documented as well.


This is redundant code. The credit splits are all handled in the AwardKeyPersonObject.

If there's something not right with how that code is functioning, please talk to me about it.  The Award data object is not the correct place to be storing credit splits for key personnel.

This method should be removed.


Fixed!


oh man this makes me sad.


Done.


LGTM this commit


La saco de la carpeta, para dar un paso a theme de Wordpress


![image](https://cloud.githubusercontent.com/assets/12467136/9118797/cf672360-3c27-11e5-849b-1282f06a0a86.png)
lightbox/fancybox


@dietzc You mean the cast from `RandomAccessibleInterval` to `IterableInterval`? Yes, that is bad. Best to use `Views.iterable`:
```java
Cursor<BitType> mask = Converters.convert(Views.iterable(positiveCorrelationMaskImage),
                new Converter<UnsignedByteType, BitType>() {

                    @Override
                    public void convert(UnsignedByteType arg0, BitType arg1) {
                        arg1.set(arg0.get() > 0);
                    }
                }, new BitType()).cursor();
```
Right?


bindin -> binding


`#` 后后面建议加个空格。。。


Good idea, will do.

(I am pretty certain LLVM optimizes the bound checks away. See #27130)


Maybe is missing the dependency for ui.bootstrap  in your controller
like:
 ```
angular.module('sardegnaclima', ['ui.bootstrap']).controller('MioCtrl', function ($scope) {
...
```


Either that, or discontinue XP support with v7.0 ...

----- Original Message -----
From: "tannerhelland/PhotoDemon"
To:"tannerhelland/PhotoDemon"
Cc:"Kroc Camen"
Sent:Thu, 06 Aug 2015 10:39:32 -0700
Subject:Re: [PhotoDemon] pdOpenSaveDialog: new Unicode-compatible
system file/save wrapper (6e3977c)

	Argh, thanks for the heads-up. I should have thought of this; it's
likely related to the way VB's linker implements a /DELAYLOAD-like
stub for normally declared API calls
(http://www.microsoft.com/msj/1298/hood/hood1298.aspx [1]).
TLB-defined functions must be handled using the original, non-delayed
convention.

	This is going to be particularly problematic for various Vista+
features I want to add, as they're primarily exposed as interfaces.
Time for more hideous VTable hacks, I guess!

	—
Reply to this email directly or view it on GitHub [2].

Links:
------
[1] http://www.microsoft.com/msj/1298/hood/hood1298.aspx
[2]
https://github.com/tannerhelland/PhotoDemon/commit/6e3977c6f6f21bd69b978b32b309a12301dbb6f3#commitcomment-12571416


Reorganicé algunas cosas.


What is the purpose of this method?

If you need to "get the key people", why aren't you using the Data Object's @key_personnel collection to do this?


Ah no, I meant the cast causing the Problem. My cast was not too nice, too ;)


Might I suggest a test case for this?


fxd; fxd


Are you sure? It passed `make tidy` on Travis. I've also seen `FIXME`s without issue numbers elsewhere in the code.


"Opps" -> "Oops"


We should probably remove the config file too?


This is a good point.  We don't really want this to be able to be passed to other places.

What do you think about yet another tweak here:

* break Save() and Restore() into Save() and SaveAll() and Restore and RestoreAll()
* Save and Restore take a real Table, the All() forms do not.


Added to <returns> comment.


@zipper1956 你不要直接拉 Merge 哦， 大体流程如下：

你把 MM 这个文件复制出去先。。。备份起来。。。然后：

git remote add tinyclub https://github.com/tinyclub/elinux.git
git fetch --all

然后

git checkout -b develop tinyclub/develop

之后，把 MM 那个文件加入进去，然后再提交，再发 PR，记得在那些标题 `#`  后面加一个空格哈。


I would drop these comments - too much implementation detail


drop this comment


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


@taylorotwell could you increment Laravel minor version to include this change ?


fancybox is a lightbox alternative: http://fancyapps.com/fancybox/


const variable for command name


No.


5.2 will be released in november


This change as also reverted and moved to laravel/laravel.


Thanks for the answer,

So do you think it would be better to up the number of games from 10 000 to 25 000, or to continue local testing with the 3 different tweaked versions?


Compiler Error:
```[ 86%] Building CXX object libraries/wallet/CMakeFiles/graphene_wallet.dir/cache.cpp.o
/home/jcalfee/bitshares/graphene/libraries/egenesis/embed_genesis.cpp: In function ‘void load_genesis(const boost::program_options::variables_map&, egenesis_info&)’:
/home/jcalfee/bitshares/graphene/libraries/egenesis/embed_genesis.cpp:201:69: error: ‘read_file_contents’ was not declared in this scope
       read_file_contents( genesis_json_filename, *info.genesis_json );
```


I will check it.


@mkwork seems like bicycle, huh?


Well, there is no more casting, now that a `Converter` is being used, right? So all is well?


We think this line is unnecessary because there is a halo update immediately below. Say @Hallberg-NOAA and @adcroft


The digit-sized arithmetic does not overflow as written (or if it does, that's a bug). The bignum arithmetic is all left to `mul_small`, so it should panic on overflows iff that one does.


By the way: @awalter17 is _this_ close to filing the PR for `ops.convert().bit(myUint8Image)` and friends, which will make this sort of conversion much less painful!


don't forget to `Close()` the file!!


I think you meant `case NonFatal(x)`.


@calfzhou
> `exposures` hash table is removed and substituted with `root_exposures` array.

I'm working on UPGRADE document where I plan to cover this thing.
Also how you get this error? If it's grape-swagger then I work on a workaround for it.


@GrahamCampbell my bad, I mean patch version :smile:


lgtm


LGTM


const var the command name


Sounds good. We definitely don't want anyone else using TableAll.


I understand csrf refer to cross site request forgery. But, in my opinion, If we can consider renaming bean name from "CsrfBean" to something like "CryptoRandomGeneratorBean" that will be good.


? Is this left over from the other one?


we typically use fmt.Errorf()


Indeed.


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: personal_collection


23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.modules.search.api should be before from six


23:1: I100 Imports statements are in the wrong order. import sys should be before import six
23:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.
30:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy.ext.mutable
31:1: I201 Missing newline before sections or imports.


timezone -> time zones


Added to show all comments for the evaluation


javascript => JavaScript


As one postmortem note here -- the fundamental issue going on here was that the container and the host share `~/.stack`, which I was not aware of at the time of writing the locking patches.  This is a note to myself to tweak the relevant part of the Archictecture section on the wiki to describe this aspect of the system.


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1771 of 1778 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.61%25-yellow.svg)


Separate file.


I can't test it myself, though. https://github.com/Tobschinski/WotLK-ACID/commit/14846157d86e4b98570d2edd37dac0aa1cd35b8e


Separate file


You understand correctly, these tests will only cause problems for `git bisect` if the test run on each commit is specifically `python src/etc/...`. But I don't care either way, so I'll swap the two commits when I rebase.


So... will this stop working in 2020? Should we put a note/comment to that effect? Or am I misunderstanding the name of this library?


Why doesn't it implement MetadataReferenceResolver?


Should we link them to some sort of list of valid timezone values so they can play?


What's the change here?  Was this test failing because we were using the wrong args?


Thanks. Everything is fine!


We do not in fact want to expose the image type through the GUI.  The GUI is only for use on Ubuntu Personal, in which case only the LXC containers are supposed to be supported.


Some of your attributes have spaces, and some do not. Standardize.


What does GetDeclaredMethod return in case it finds multiple methods by the given name? Does it return the first one it finds? The documentation does not tell how the method behaves in this scenario. Should we assert in such a case?


@mccalluc what's the motivation in switching from using Ruby's double-colon convention for namespacing, to using a long class name?


Can this be a link? I don't know how to do that in GitHub, but it seems like it might be 1. possible 2. nice. Maybe it doesn't exist yet to be linked to.


PlantOperationSchemes (kbenne) - i386-Windows-7-VisualStudio-12: OK (2214 of 2234 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.1%25-yellow.svg)


LGTM


Fixed.


Done.


as I think I noted in an earlier commit, I *think* the codegen for an actual iterator over the contents of `number` may be better than this `while`-loop combined with mutating the `number` slice itself.

but really, its all probably minor micro-optimization that may not be worth investing time in.


solving the mean first passage time


In the timezone clock, you used a different sort of... style... to name what parts of the code were interesting. This, for example, might have read there:
The widget relies on a `.weather` div with a `data-zip` data attribute.

Perhaps it would be worth settling on a standard.


This fails


:+1: for pulling this out into a mixin... is there a plan to use it elsewhere soon? You may want to remove `XmlBacked#initialize` at some point. I think it's probably better for mixins not to dictate the constructor of the classes they are mixed into.


>   CreateNoWindow = false
This should be false by default.


Done.
```
const (
	cmdIptablesSave    string = "iptables-save"
	cmdIptablesRestore string = "iptables-restore"
)
```


I see that looking through iptables, fixed and removed import.


done.


also done.


fixed!


reword suggestion: You may have more than one weather displayed => You may display more than one weather block


@DDuarte e.g C11 standard ?


wigdet => widget


RoomAirflowNetwork (lgu1234) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-63.94%25-red.svg)


heh. I like how many ways you came up with to say "mono equirectangular". Perhaps someday we'll add more projection options, so far there really hasn't been any need almost all video seems to be stored in an equirectangular for mono and equirectangular top/bottom format for stereo


Whoa this was dangerous as heck!! circular includes...


Integrate on cloudino


This is another method that is not properly utilizing the Data Object design pattern. The deletion of an Award contact should be getting handled by the KeyPersonnelCollection object, as well as the Key person data object itself.

We should confer about this and many other things at lunch tomorrow. :)


can you explain what you mean by "fast forward" ?


per [PowerShell in Depth: An administrator's guide](http://www.amazon.com/PowerShell-Depth-administrators-Don-Jones/dp/1617290556/) I "create[d] a credential object rather than attempting to create the credential in the call to the cmdlet" or in a variable like it was before.


Думал твое. Жабу пусть сами переписывают.


@madongfly  LGTM


if you felt generous you could normalize all calls to "iptables" and "ip6tables" to use similar consts.  Or not, up to you.


yes I just now saw the reference to that bug in a later commit, thanks for the pointer.


Can't the SOL_VECTOR_FOREACH_IDX() macro be used instead?


I like how you abstracted $(this) into targetnode in the weather example. Maybe follow that example here?


This patch does not fix the crash. Runnin python3 on arch linux. Still getting the type mismatch where bytes are expected but a dbus.string is found.

`fail (/usr/lib/python3.4/site-packages/blueman/gui/manager/ManagerDeviceMenu.py:119)
fail (DBusException(dbus.String('Traceback (most recent call last):\n  File "/usr/lib/python3.4/site-packages/blueman/services/meta/SerialService.py", line 29, in connect\n    port_id = create_rfcomm_device(Adapter(props[\'Adapter\']).get_properties()[\'Address\'], props[\'Address\'], 1)\n  File "_blueman.pyx", line 212, in _blueman.create_rfcomm_device (_blueman.c:1949)\nTypeError: expected bytes, dbus.String found\n'),),) `


@acouch, I don't `--rebase` is a good option here.  What happens if you are working on a branch you've already pushed up and in the mean time there have been some up stream changes?  This will keep the history nice and neat, but at the cost of sometimes forcing the user to do a `git push --force`.


While having 2 spaces indentation is easier to read, it's destructive when using Notepad++, that indents with tabs by default. But it's really just a convention, nothing more.


We will need Object.assign polyfill. And what it will change. Did it fix some code issue?

The only problem is incorrect linter.


yeah you're right, never mind.


random extra newline.


LGTM this PR


Canola, not canols.


Use the standard buffer overflow detection stuff for `snprintf()`. This way, cookies will be silently truncated if larger than the buffer.


I don't understand why yet, but despite the improvement in logic, it does not behave as expected (mobs can swim in water about 8-16 px above the actual water).


Purpose of this script is to create a new /etc/network/interfaces document for connecting to new networks. Every time its executed it writes on /etc/network/interfaces and creates a document of visible SSID's around to where you are at that moment. This is just a prototype and for sure it can be and it will be improved.
I have written this since I couldn't find anything like this myself in the web, if you can, don't hesitate to share because there are people looking for this kind of ease.


"provider" wasn't actually being used by the Plan. I noticed when I was documenting the Plan arguments so I took it out.


ack, thanks. the internal impl has a decodeValue() function that implicitly handles nulls.
missed this


LGTM


Hi @narlas01 You can put ' 20 seconds' here, instead of '0.2 minutes'


Local testing will not tell you much, unless you have a very powerful machine,
except for a quick sanity check that your test is not broken.

You can also take a look at History
https://groups.google.com/forum/?fromgroups=#!forum/fishcooking_results
and search for BestMoveChanges, and see what was tried.

numgames test is the way to go to have definite answers,
or compare very similar things.

Based on the results you will get, you may try to increase or decrease,
and submit a few other tests.


IIRC, I did this because I was getting into weird loop and subsequent crash when I created unit file foo.service and had bar.service -> foo.service, but foo.service had Also=bar.service. So basically when you have such setup and you ask systemd to enable bar.service and then we figure out bar.service is actually foo.service we don't want to also change have_installed (at the time we detect symlink we already moved InstallContext from will to have) hashmap by accident, because we don't want to hit the loop if user is stupid and put Also=bar.service to unit file.


Hmm, the current `HEAD` doesn't have that problem any more. It looks more like the fix didn't make it into the Cabal release that ships with GHC 7.10.2. :-(


on how to use install and use => on how to install and use


Done.. sort of. Currently we use:
```
func (runner *runner) iptablesCommand() string {
	if runner.IsIpv6() {
		return "ip6tables"
	} else {
		return "iptables"
	}
}
```
So I just swapped those two strings out for `cmdIptables`, `cmdIp6tables` so that the const block has all of the command strings.
I suppose we could also inline this but it doesn't seem like a good idea.


This check would have to be done when the task is executed, not when applying the plugin. It's quite possible for another task to create the checkstyle configuration file.


is this sentence incomplete? it'd be nice to have some documentation of where it is important to have variance here


A message like "Remove parentheses" would be more accurate here


Hi @narlas01. Try not to comment out code. We use a version control system and we don't need to comment things out so we can go back to them at a later stage.


Possibly it already exists and I'm missing it..... is config.getopt("deploy_complete") set to "False" when a deploy has been uninstalled or removed? I only say this because after I remove a deploy my config.yaml still contains deploy_complete: "true". Could be pertinent for redeploys...


@peti Ah, bummer. Maybe the important bits can be cherry picked?


We should be loading the default checkstyle config from the resolved checkstyle jar file, not providing one in Gradle.


I wonder what other API's the node is calling... might mean adjusting the `system:node` role permissions


Thanks a lot! I am kind of a beginner here, long time lurker, and it's nice to see that the community is helping.


Notes:
http://shwetapurushe.blogspot.com/2015/08/weave-analyst-notes-1-purpose-of-these.html?view=flipcard