Should the above use _escape_value instead of _escape_tag? I am testing version 2.7.3 and the above line causes "AttributeError: 'int' object has no attribute 'replace'" whenever there are integer tag values. Kindly let me know if I should open an issue for this.


Use AuthZRequest


Use AuthZResponse


Works like a charm!


shouldn't this be just MSEC_TO_SCAN_DURATION_UNITS? is Gap:: needed? or is it even correct? how did this pass your compiler?


same as above.


okaaay


you are right :)


Whoop!


It should be places in the contrib folder. There is not issue in during this (I normally moves it by hand).


TeamCity YaccConstructor :: YC.Core General Build [Build 487](http://teamcity.codebetter.com/viewLog.html?buildId=196691&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 236 Build time: 00:16:41


Please create independent changes and make separate pull requests next time. It makes integration easier if one of the changes needs to be modified.


Nice removing so many Reacts :)


Повторяющиеся элементы


@mstanichenko We already have a branch there. If you want to micro-optimize it, please do it in a separate commit with actual performance numbers included. You almost certainly will not see an improvement there because the CPU's branch predictor will predict the non-error case.


Tridge also seems to think the C++11 version is better so I think it's ok to move towards it even if it's not consistent with many of our libs.


What do you mean by simulation?


The weekdays need to start from Monday (Luni) and not Sunday (Duminică).


I don't remember...


Var egentlig ikke planen å commit'e denne, men om noen er interessert i å forsøke å ha dev-ship med utviklingsmiljø inni så gi beskjed så kan jeg gi demo. Hvis ikke så kan jeg reverte denne.


我的项目里面就有一个CustomBadgeValueBackgroundImage 继承自UITabbarItem 你可以参考里面的代码 有什么问题可以联系我

------------------ 原始邮件 ------------------
发件人: "malaimoo";<notifications@github.com>;
发送时间: 2015年8月6日(星期四) 下午4:19
收件人: "bianzhifeng/customTabbarItemBadgeValuebackground"<customTabbarItemBadgeValuebackground@noreply.github.com>;
抄送: "＿祢还不懂＿"<1107733919@qq.com>;
主题: Re: [customTabbarItemBadgeValuebackground] Delete README.md (c4668b7)

Hello?代码呢？能不能贴上来参考一下？Thx

—
Reply to this email directly or view it on GitHub.


.Tab-itemLink ?
On faisait pas un reset sur li et mettait la classe sur li ou a ?


You should move this to a function. The same block is used before two times.


Checkmarx scan results 2015-08-06T10:38:24Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

698aad662fafddc9e1a3ef8a1bda8881c37591a2	@dortal


amplifyCell делает много лишнего, для каждого свитча его вызывать дорого. см. getVLANSwitchInfo и getObjectPortsAndLinks


![zoo](https://cloud.githubusercontent.com/assets/1905964/9109647/86f9a3ea-3c37-11e5-95ea-8f3e2f69abc9.png)

Hidden inputs are exposed in red.
`animals[0]` and `animals[1]` should not be present.


Do we really want to rely on ``toString`` in ``equals()``?


add_string is for findPropers "REPACK|PROPER"
Its working for me as is for usenet crawler.


@acidprime just used v3.0 for r10k itself and webhook (local/non mcollective mode) seems to work fine with puppet 4.2.0 :+1:


Hi,

I unfortunately do not have time to maintain this project anymore. I
developed this project as a PoC a long time ago and am pretty impressed by
the number of people still using it. Since the birth of this project Google
has updated their API as well as their Protobuf structure. The
GooglePlayDownloader project (
http://codingteam.net/project/googleplaydownloader) might be more up to
date.
You might want to reverse engineer the last version of Google Play app in
order to document the protobuf structures. This Androguard script (
https://github.com/bitpew/androguard-protobuf-nano-extractor/tree/master)
is based on mine, but is supposed to handle Google's new NanoProtobuf
implementation.

I'm afraid I won't find time to review and merge pull requests, so please
feel free to fork the project and publish a (much) better and newer version.

Cheers,
Emilien

Hi, is there any update about this project recently? I found the Google
APIs have updated for several times and I'm studying ur codes. It's so nice
of u to make this project and could u tell me if I can run it with the
latest Google APIs？

—
Reply to this email directly or view it on GitHub
<https://github.com/egirault/googleplay-api/commit/9cf515f28eec16575ab2f6204cbdd779d2b77613#commitcomment-12561510>
.


produceUplinkPorts лишний, список uplink уже видно в в $desired_config после apply8021QOrder  (['vst_role'] == 'uplink')


remote_object_id может быть NULL, если порт не слинкован


В conflicts всегде не больше одного элемента? Зачем тогда такой массив?


Ah, I see, this was Søren's trick for providing multiple outputs. @skaae, I hope you're fine with merging the PR without this hack and introducing a proper solution for multiple-output layers afterwards (https://github.com/Lasagne/Lasagne/issues/337)!


err


покажи как бы ты сделал, так как если инициализировать до условия - ничег оне произойдет


Looks good, but what are the benefits of this change?


Ah, you have already changed it in a follow-up commit.


Checkmarx scan results 06 Aug 2015 13:46  UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


@zackdreaver , thanks, I'll look into it.


Hi Andrea,

W dniu 06.08.2015 o 12:16, Andrea Ceccanti pisze:
> Hi Krzystztof,
> is it something I should worry about? How much the performance has
> degraded and why? Can you elaborate on this? Is there a way to avoid
> this performance degradation?

Hard to say, maybe? Previously, in case of openssl truststore, it was
possible to easily locate CRL file having the issuer of the cert. With
BC changes it is impossible to get issuer's name in CRL locator[1]. In
effect canl has to load all CRLs and check one by one which is matching
the selection criteria provided by BC.

Sounds very bad, but the most expensive operation - read from disk - is
performed only once, then we have CRLs cached and performance is only
minimally lower. Surely the very first checking of CRL is much slower.
For CLI programs running only 1-2 certificate checks during invocation
this can be noticeable...

If this is a problem the best would be to fill a ticket against BC and
wait for 1.53... Otherwise I'd have to copy a very large part of BC to
canl (probably even hundreds of classes - hard to asses).

Best,
Krzysztof

---
[1] BC 1.52, in some cases, wraps the actual CRL matcher (which most
often has the expected CRL issuer info) with additional anonymous class.
I don't understand the reasons for this wrapping but anyway the wrapper
is all I get with only one method checking if a given CRL is fine or not :/
On the pros side sometimes this wrapping is not done (and then canl
behaves as it used to) but I can't easily say when this happens - there
are 2 wrapping places in BC code which I found so far, and all if-else
paths going to those invocations are hard to remember.


а это вообще не понимаю как переделать


Speedhistory is not saved, only refresh_rate\*275 items are saved in an array.
Refresh_rate config variable is updated when you change it in Glitter.


Only minor comments. See above.


yes. One very easy solution is to use a GRU instead.


Upstream issue: https://github.com/jborg/attic/issues/335


Aah okay. Well, it's still not working for me, for some shows. For ex: Log Horizon s2e7/s2e2, Ushio and Tora s1e2 and 3. And some others. All because the ep and season paramaters arent' working properly. I'll just add the search strings to my own fork. I'm not going to bother you with this, because of one buggy provider.


这个有什么用？


Why is it called `PlayerPreLogin` when it has nothing to do with a player, but only a user?


hello humans


hi


```
php -r "echo (int)'08';"
8
```


Debugging macro :+1:  Another thing that I should have set up.


Hello Henning,

I haven't found this limit in the ELB documentation (http://docs.aws.amazon.com/ElasticLoadBalancing/latest/APIReference/API_Operations.html). Why do we have this limit here?


参考官方文档的解释和解决方法。我们在项目中使用的这个方法，之前文档中有，现在已经更新为新方法了。
http://wiki.nginx.org/HttpLuaModule#Lua_Variable_Scope


Hi @deajan  I tried this but without much luck, I'm still getting issues. Haven't debugged it yet, but the readlink wrapper functions I've been using *seem* to work: https://github.com/talesin/osync/blob/busybox/osync.sh#L761


For some reason, it won't recognize filled form fields. I have checked if redirection is good with Capybara's save_and_open_page feature, it gives what it should. Cucumber says that it cannot find text which is on that page.
![2015-08-06-125400_1366x768_scrot](https://cloud.githubusercontent.com/assets/12072588/9110036/97705356-3c3a-11e5-89c8-d552e5bf3935.png)


## Before ##

![screen shot 2015-08-06 at 12 47 58](https://cloud.githubusercontent.com/assets/198682/9110026/8bd98256-3c3a-11e5-8af4-5b6b65813c0c.png)

## After ##

![screen shot 2015-08-06 at 12 53 54](https://cloud.githubusercontent.com/assets/198682/9110031/9280a6b6-3c3a-11e5-9687-f0cb1e748601.png)

h/t <https://github.com/daveliepmann/tufte-css>


Pushed a fix 7dc9450ed.

Even our ISOs were misconfigured :-)


This is overlapping with #663. How come this wasn't discussed? I don't really like the name of the events either.


rgw:the arguments 'domain' should not be assigned when return false

    Hostnames: [B.A]
    Inputs: [X.BB.A]
    Return: [false]
    Output: [B.A] it is wrong.

Fixes: #12629
Signed-off-by: Ruifeng Yang <149233652@qq.com>


merge


What does "too many incoming edges" mean?


All you are doing is just a simple concatenation of your index files into single one.


Checkmarx scan results 2015-08-06T11:00:11Z

High
Medium
Low
Info

New
0
4
42
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

698aad662fafddc9e1a3ef8a1bda8881c37591a2	@dortal


Did you try `async`?

```
async do
    emit SERVER_UPDATE;
end
```

Here you end up with a recursive call in `C++` which is bad.


composer require friendsofsymfony/elastica-bundle


```
cd alice.papers/Thesis/papers
for file in *InRu.pdf; do
      # Process $file
     echo $file
     # Find bounding boxes
     pdfcrop --verbose $file tmp.pdf | grep "%%HiResBoundingBox:" > bbox;
     # First page has the largest bounding box
     largest=`echo $(head -n 1 bbox)| cut -d':' -f 2`
     # Crop $file
     pdfcrop $file tmp.pdf --bbox "$largest"
     mv tmp.pdf $file
  done
rm bbox
```


Checkmarx scan results 06 Aug 2015 14:03 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


sorry for my english ... is possible in Spanish ... that changes must be made ... thank you very much ... great job ...


child ~~repo~~ module


Where are the `delete` associated to of these `_new_*`?


I would have done it the other way round, OWNCLOUD_MAX_PARALLEL should be able to override your if()


@Gaurav I will fix the type locally before integration, so no need to provide another patch for this!


sehr nice


Fixed in 99828363. Also fixed the old endpoint's documentation.


Fixed in 99828363


`git commit --amend` ;)


I did it exactly as zoggy asked, and exactly how SB handles it. It should not make it to query strings on most occasions. This reduces the total requests by about 99% already.


As discussed, I first implement it according to the task described in JIRA in this phase.


Fixed in 99828363,


Not an issue:

```ruby
irb(main):004:0> User.pluck(:name).map { |n| n if n.start_with?(' ') }.compact
  SQL (239.0ms)  SELECT "users"."name" FROM "users"
=> []
irb(main):005:0> User.pluck(:name).map { |n| n if n.end_with?(' ') }.compact
  SQL (284.7ms)  SELECT "users"."name" FROM "users"
=> []
```


These C++ `Screen` objects are storaged in `ScreenManager`'s stack of `unique_ptr`. So, `delete` in `unique_ptr`.

All `GUI::Component`, `GUI::RectComponent` pointers go to `GUIManager`'s `vector`, all contents of which is `delete`d in `GUIManager`'s destructor.

For `Sprite`, `String`, `Color` and other objects which are created in world object's constructors - I believe I've added `finalize with _delete_obj(variable_name_here); end` for those.


Dear Brian,

( Just a general suggestion, )
it is better to set value for const member in initializer list associated with the constructor
rather than writing in the header file.

Thanks,

Best regards,
Yasu Okumura


Turns out we'll need anchor after all.


But that's not linked from github.  Also the pr-trigger job is currently serial which we'll need to parallelize at some point, and when we do, it won't be possible to follow the output in that job console.


I've applied fix in https://github.com/concord-consortium/lab/commit/fa57631d71989ff0490ec21cc982fbdd9d4bbe19, so we can pass strings again. It's probably easier than thinking whether something else got broken or not. :wink:


If you want to install something into the resource directory of the addon it's gonna get tricky due to differing behaviours between standalone linux and everything else. It might make sense to provide a helper macro/function for that.

BTW why do you need to build and install `library.kodi.game` and `library.xbmc.addon` as part of this addon? Shouldn't that be built and provided by Kodi? Furthermore we usually try to link every dependency statically so that the result is a single so/dll.


Hmm, the situation in 14.12 was somewhat more complicated 2efe8b6828.


* User = Use


What about '+' sign for example that can be added to email addresses


@RByers re line 360, should you s/identifier/target/?


Yeah I didn't have my crystal ball handy at the time ;-)


Thanks, @mswiderski !
I have to remember to modify OSGi stuff.. :/


清理代码没清理干净 orz


Thanks @mswiderski

I was sure I ran a full build before pushing. In any case, thank you for catching and fixing this.


Why volatile in a subscriber?


pomogite


Thanks :)


\o/


okay!


> Hmm, what's the precise rationale here?
>
> (looks ok generally...)

Tool iwyu runs analysis of a given compilation unit and reports how include statements at the top should look like based on actual use of function, variables, macros, etc. In this particular case we miss ```sys/stat.h``` and ```time-util.h```. Because those two files are pulled in indirectly by some other ```.h``` file compilation doesn't fail. However it is good practice only include what you use and nothing else.

If you don't want this commit to be included in PR I am happy to drop it and send separate PR. Your call.


Since 3.2.1-91~preciseppa1 my bumblebee setup does not work anymore after a hibernate.

The nvidia kernel module can not be unloaded:

 Aug  6 13:18:30 stromboli bumblebeed[14473]: /usr/sbin/bumblebeed 3.2.1 started
 Aug  6 13:18:33 stromboli bumblebeed[14473]: Unloading nvidia driver timed out.

Could that be related to this patch?


I don't like this file.


It's not the same message you were using - you were effectively taking `exc_type` (your original code was `sys.exc_info()[0])` which is just the exception class which is unhelpful.  `exc_val` is very definitely useful - trust me I tested it :)  The `sh` module gives a nicely formatted message which explains the command which was run plus the STDOUT and STDERR.

I don't understand your point about the filename - it already is `build.err`?


Checkmarx scan results 2015-08-06T11:22:12Z

High
Medium
Low
Info

New
0
4
42
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

698aad662fafddc9e1a3ef8a1bda8881c37591a2	@dortal


ok. Is the compiler complaining about these assignments?


I still don't understand why not collect() ? This subscriber just repeats that? You can have another sequence inside flatMap


The (styleguide)[https://github.com/alphagov/styleguides/blob/master/ruby.md] says:  "Add a trailing comma to multi-line array and hash definitions for clearer diffs with less line noise."

Should we remove this commit?


Yes, it's delayed forever - `emit` doesn't happen, so game is frozen like it's on pause.


I've updated the commit message locally to explain why I've gone with `next_node {}`.


Checkmarx scan results 2015-08-06T11:24:36Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


commit lgtm


Thanks @floehopper. I've fixed this in a fixup commit.


If MinGW doesn't support the full Win32 API that sounds like a bug in MinGW to me. It should be possible to dynamically load it from Shell32.dll with ```GetProcAddress()``` and if it is not found fall back to either ```SHGetFolderPath()``` or the environment variables. I think that's what I found somewhere as the suggested way to handle the directories in a version-independent manner.

MSVC needs the ```_WIN32_IE``` value to be at least ```0x0601``` (or, better, to ```_WIN32_IE_IE60SP1```) as apparently the ```SHGetFolderPath()``` function came together with some version of IE6.

This is because (in theory) you can still use the same API headers to write programs targeting pre-IE6 windows (i.e. early XP or Win2000, etc) which didn't have ```SHGetFolderPath()``` in its shell32.dll. I don't know about the MinGW Win32 header files (are they a copy from MS? or did they re-implement everything?) so I don't know which IE version that might need.


No need to require the file in itself :)


Yeah. Remove this commit.


No. I've removed `_PTR2REF` there because it is unnecessary (or may be compiler **was** complaining earlier, and that's why I added those in the first place).


@gzzhanghao
Could you please attend to the coding style violations in StructureController. Violation can be found at http://ci.phpmyadmin.net/job/phpMyAdmin-continuous/10476/checkstyleResult/file.447049598/
See https://wiki.phpmyadmin.net/pma/Developer_guidelines#Coding_style and https://wiki.phpmyadmin.net/pma/CodeSniffer as well.

I have fixed some of them in https://github.com/phpmyadmin/phpmyadmin/commit/bb1646dec757f40a4dabae2dec48bd1bcbb58260 and https://github.com/phpmyadmin/phpmyadmin/commit/a8a2986b567ddb2d800358fe8b7662003ff9e9c6


typo here?  shouldn't "the bit with weight `2^W`." instead be written "the bit with weight `2^i` ?


Legacy platforms (MSM7X01A, MSM7X25, MSM7X27, MSM7X30, QSD8X50, MSM8X60, SM8960, MSM8930, APQ8064, FSM9XXX, MSM9615, MSM8625, MSM9625, MSM7X27A) are not expected to use the mainline anymore. Remove unused code in idle-v7 and its related files.
See more: https://github.com/neobuddy89/hammerhead/commit/1d6ad0bbf43df0c975f99d7eacaf50131015b68b


>  i.e. I don't think the number of methods made available to the view changes does it?

No, you're quite right. I'll update the commit messages.


testing pull


Hi,

LONG RAW shall used using the Blong class :)

LONG => CLong
LONG RAW => BLong
RAW => Raw


Yeah!


Superseded by fish-shell/fish-shell@616d848faccb75e5301e105aabc86c8681814812 :smile_cat:


Is this how transactions are handled in oracledb as well?  I can't really figure out from the API docs if you can just run begin transaction commands or if you have to invoke a method on the connection


好棒！


yep, have created new pr


Issue #2 - Sequential Read functions added


Looking good so far - have you got a connection up and running, and at least some tests passing ;) ?


Why do you send a 'q' parameter with 'null' value instead of empty string?


Can we use the abstract one instead?


> why? are you the police? if somebody abuses someone, but makes good
security hole fix to your, would you not merge his fix?

I'll answer this one directly since I've had to do this a few times: No.
You are not the only developer in the entire world who can fix that
problem. There are enough not-assholes to ignore the "contributions" from
the assholes. This bullshit scenario also (unsurprisingly) ignores the
*cost* of having that asshole around, namely driving off good people.

On Thu, Aug 6, 2015 at 5:28 AM, Ackermann Yuriy <notifications@github.com>
wrote:

> @joepie91 <https://github.com/joepie91> I guess I just generally went out
> about the fact that people want other people to be gone and used
> @krainboltgreene <https://github.com/krainboltgreene> as example.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nixxquality/WebMConverter/commit/c1ac0baac06fa7175677a4a1bf65860a84708d67#commitcomment-12561667>
> .
>

--
Kurtis Rainbolt-Greene, Hacker
Software Developer
1631 8th St.
New Orleans, LA
70115


Ah, thanks!


`this->window()`?


nice :+1:


General comment: Just required `_ = require('lodash')` at the top of the file and use `_` directly instead. I know you just copied what was there already, but we are transitioning towards rmoving `Util.` :)


Why are those ignored?


> but "kick him out of maintainers because he writes on twitter something
homophobic/antitransgender" is sound exactly the same to as "Jews
execution(May theirs souls find their peace) during WW2" and "Stalin
political repressions".

Holy shit are you serious? Like, why would you ever write this in a public
place? No one should consider this a sane comparison. *No one*.

On Thu, Aug 6, 2015 at 6:30 AM, Kurtis Rainbolt-Greene <
me@kurtisrainboltgreene.name> wrote:

> > why? are you the police? if somebody abuses someone, but makes good
> security hole fix to your, would you not merge his fix?
>
> I'll answer this one directly since I've had to do this a few times: No.
> You are not the only developer in the entire world who can fix that
> problem. There are enough not-assholes to ignore the "contributions" from
> the assholes. This bullshit scenario also (unsurprisingly) ignores the
> *cost* of having that asshole around, namely driving off good people.
>
> On Thu, Aug 6, 2015 at 5:28 AM, Ackermann Yuriy <notifications@github.com>
> wrote:
>
>> @joepie91 <https://github.com/joepie91> I guess I just generally went
>> out about the fact that people want other people to be gone and used
>> @krainboltgreene <https://github.com/krainboltgreene> as example.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/nixxquality/WebMConverter/commit/c1ac0baac06fa7175677a4a1bf65860a84708d67#commitcomment-12561667>
>> .
>>
>
>
>
> --
> Kurtis Rainbolt-Greene, Hacker
> Software Developer
> 1631 8th St.
> New Orleans, LA
> 70115
>

--
Kurtis Rainbolt-Greene, Hacker
Software Developer
1631 8th St.
New Orleans, LA
70115


single `.DS_Store` is enough for all paths


Opmerkingen:

* ik zou van de `bmi_calc` gewoon een instance-method maken, en gewoon `bmi` noemen. Je wil gewoon de `bmi` van een `measurement` weten. Nu moet je een instance doorgeven. Optimalisatie: bewaar het berekend resultaat in een variabele, zodat je (om te vergelijken) niet twee keer moet berekenen.

Bv als volgt

    def bmi
      @bmi ||= calculate_bmi
    end

    def calculate_bmi
      # hier doe je dan je berekening
    end

* ik vond het eigenlijk mooier als de `current_user` niet in de `ApplicationController` staat, omdat je perfect weet hoe de `current_user` te berekenen, afhankelijk van de controller. M.i. simpeler.

Normaliter zetten we de `current_user` wel altijd in de `ApplicationController`, maar dat is omdat die methode normaal verwijst naar de ingelogde user, en dat we die ophalen uit de sessie. Ik zou ook geneigd zijn om de methode te hernoemen naar `current_person` omdat m.i. ook beter aansluit bij wat het wil zeggen (er is nog geen concept user in je app).

* de `current_measurement` zou ik hernoemen naar `last_measurement` en ik zou die definieren bij `Person`, dan kan je gewoon schrijven `current_user.last_measurement`, of liever `current_person.last_measurement` :smile: :smile:

Als je nog uitleg wil of vragen hebt, hoor ik dat graag :smile:

Oh, en volledig terzijde, ik snap dat je voor jezelf wilt bewaren wat je allemaal hebt gedaan, maar al die commentaar-regels met "oude code" maken het allemaal wat minder overzichtelijk.


But oracle does ;) - it seems it may be an option to the connection though, and not just a query?


Done.


I wouldn't leave it here


Checkmarx scan results 2015-08-06T11:32:48Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


In case your dialect is very similar to one of the existing, it is okay to inherit from that instead of the general one - whatever takes the least amount of custom code


Just try to create an ELB with a long name and you will see for yourself...


`*.gem`


使用this,确定当前实例，上面的代码也使用this，不是我本意，


这里是使用闭包处理的版本


the requests contain sensitive information in the security header


@krainboltgreene well. I guess it was not he most nice comparison. But it was equally bad reply as "oh he did not put jews in the oven, he only said he thinks we need to". From another view point it is conceptually the same. You trying to get rid of "morally incompatible people". It is physical in dictature, or verbally on github.


Thanks Dennis, let me try that


Correct, and now that I read it again, "i-th most significant" sounds wrong or at least easy to misunderstand. I'll make it

> Return the `i`-th bit where bit 0 is the least significant one, i.e., the bit with weight `2^i`.


@rmolodyko sandbox must be setted throught module configuration


@krainboltgreene but yea. It went a bit wrong.


The scan was canceled by the user   on 8/6/2015 2:25:21 PM
Included commits

Commit ID	Owner

020ee229556b2a129a140d78801de8fd2aaa7e7b	@amitchen22

91b93c8bc7000fb7e3d8b4e01f248b9169790b37	@amitchen22


What is this for? @rmolodyko


```ruby
case attr
when Array
  # ...
when Hash
  # ...
end
```


@rmolodyko if you want simple output then you should use ```s()->async(true);```


It should. It has no idea about unique pointers.
Anyway, I've just checked here and it does complain (probably a newer version than yours).


@mfonville

FYI, add_sources said it cleaned up the older API, but didn't, just noticed now, so I'll go squash it!

```
$ ./add_sourceapp.sh com.google.android.apps.docs.editors.slides-1.2.312.11.35-53121135-minAP
Importing Slides
Package com.google.android.apps.docs.editors.slides | VersionName 1.2.312.11.35 | VersionCode
Package supports DPIs: 480
Native code for architecture(s): armeabi-v7a
SUCCESS: Added /SANDBOX/git/opengapps/sources/arm/app/com.google.android.apps.docs.editors.sl
Cleaned up old API: /SANDBOX/git/opengapps/sources/arm/app/com.google.android.apps.docs.edito
```

sorry, the lines got truncated in my console...


Checkmarx scan results 2015-08-06T11:37:52Z

High
Medium
Low
Info

New
72
61
66
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d2c411e2e4d7536680d920b01c762c8592e975fe	@dudug


I've updated these commit messages to make them consistent with the other messages that were describing these changes.


Maybe consider moving instance variables to a hash if you need to change them dynamically?
`self.properties["#{attr}s"] = [yield(attrs)]`


Fixed in local commit.


You're doing it wrong. You have your PSI element captured here, thus you're storing both a smart pointer, and a psi element itself.


I guess this was the first file that you wrote?


Checkmarx scan results 2015-08-06T11:41:13Z

High
Medium
Low
Info

New
6
16
158
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

698aad662fafddc9e1a3ef8a1bda8881c37591a2	@dortal


This looks weird and confusing. At the very least, it requires comment what does it do there. Yet better is to rewrite it so it was close to exception point.


Sorry, I has never used the versions plugin and at first I thought it was telling me I HAD to use the latest version of everything, so I did. I realise it's just information though so will switch that back.


you might want to remove this file.


Hi, thanks for your commit. Do you have an application that depends on the F95 interface of PFFT? If possible, I suggest to use the Fortran2003 interface. It is automatically generated from the C interface and, therefore, also includes the most recent changes of the PFFT interface. In contrast the F95 interface will be updated only upon request.


Getting a compile failure on this set:
```
[INFO] Starting audit...
/home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:3:8: Unused import - org.jboss.metadata.ejb.jboss.IIOPMetaData.
/home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:4:8: Unused import - org.jboss.metadata.ejb.spec.EjbJarMetaData.
/home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:6:8: Unused import - org.junit.Assert.
/home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:13:15: Unused import - org.jboss.metadata.ejb.test.common.UnmarshallingHelper.unmarshalJboss.
Audit done.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Metadata Build Configuration ....................... SUCCESS [  1.533 s]
[INFO] JBoss Application Server: Metadata Aggregator ...... SUCCESS [  0.621 s]
[INFO] JBoss Metadata Test Helper ......................... SUCCESS [  0.955 s]
[INFO] JBoss Metadata Common .............................. SUCCESS [  3.413 s]
[INFO] JBoss Metadata EAR ................................. SUCCESS [  1.444 s]
[INFO] JBoss Metadata EJB ................................. FAILURE [  3.180 s]
```
That's a bit annoying.


this is okay.
but not good.


I think that probably would be clearer but I'm going to park that for later. I'll make a note to update the README that describes the order nodes are evaluated too.


OK, but this does stop my backup regime from exponentially growing in size and filling the storage.


Weird, I’ll have a look. Sorry, not sure why it would be doing this.
> On Aug 6, 2015, at 7:42 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> Getting a compile failure on this set:
>
> [INFO] Starting audit...
> /home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:3:8: Unused import - org.jboss.metadata.ejb.jboss.IIOPMetaData.
> /home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:4:8: Unused import - org.jboss.metadata.ejb.spec.EjbJarMetaData.
> /home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:6:8: Unused import - org.junit.Assert.
> /home/carlo/work/jboss/metadata/ejb/src/test/java/org/jboss/metadata/ejb/test/bz901186/IIOPMetaDataTestCase.java:13:15: Unused import - org.jboss.metadata.ejb.test.common.UnmarshallingHelper.unmarshalJboss.
> Audit done.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Metadata Build Configuration ....................... SUCCESS [  1.533 s]
> [INFO] JBoss Application Server: Metadata Aggregator ...... SUCCESS [  0.621 s]
> [INFO] JBoss Metadata Test Helper ......................... SUCCESS [  0.955 s]
> [INFO] JBoss Metadata Common .............................. SUCCESS [  3.413 s]
> [INFO] JBoss Metadata EAR ................................. SUCCESS [  1.444 s]
> [INFO] JBoss Metadata EJB ................................. FAILURE [  3.180 s]
> That's a bit annoying.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562831>.
>


Understood. However when we ran it, it literally showed the \n as part of the key.

So in groups_bars/all it showed up as
'\ngroup_id: xxxxx'


@ krainboltgreene
> not the only developer in the entire world who can fix that problem

yeah but the fix is there, and you opt to punish your software users for the sins of the contributer. this is retarded.


Oh sure!
You have to emit the special `CEU_IN__ASYNC` input from `C++`, somewhere in the event loop:
<https://github.com/fsantanna/ceu-sdl/blob/master/main.c#L458>


I'm not sure why would it complain (we're assigning reference's initial value). Plus, all these `_new_*` are declared as `@pure`.

On that exact line we're in `spawn`, and `finalize` is forbidden in it anyway. I think that might be the reason why I've added `_PTR2REF`.


btw that should work for both cases:
`[attrs].flatten.map{ |a| yield(a) }`


Do we need exometer here?


@nathanvda Sorry, sorry, sorry, misverstand. Dit was een tussenstap omdat ik een bende had gemaakt in mijn lokale repo. Ik ga nu per onderwerp pull requests aanmaken for review!


Yup, I've changed this in a fixup commit.


It's the same as for the tTimerHdl. eventArgAddr is never used and is not intended to be used. Am I right?
So I would also name it padding like for tTimerHdl.


Compressed some layers in the docker image to in this commit.


The `unmarshalJboss` method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66


should this be extracted?


@makc WAT?


hash syntax


Looks like the same thing happened to @mc1100 commits for slides (note: API change from 14 to 16...)


Would
```
loop i in 4 do
    async do emit UPDATE; end
end
```
work then? Or it would require 4 different `CEU_IN__ASYNC`?


Checkmarx scan results 2015-08-06T11:35:48Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
26
17
30
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

afc3113dce70f0a536509bd8d71f5bdf06c87daf	@amitchen22

020ee229556b2a129a140d78801de8fd2aaa7e7b	@amitchen22


You can declare those in the initializer and get rid of getter methods as you already have `attr_accessor` for them


I agree that it's not ideal but I think I have a _slight_ preference for the dynamically built tests over duplicating them. The dynamically built tests should make it harder to accidentally change validation in one question without considering its counterpart.


I guess you understood what Zip is.


Ow ok, sorry :smile:


`[errors].flatten.map{ |error| RoyalMailApi::Error.new(error) }`
This should work for both cases


@discordier If you don't like to butcher your phpDoc comment, you can add an inline comment after the regular comment:

```php
/**
 * Initialize the controller
 */
/** @noinspection PhpMissingParentConstructorInspection */
```

Not too nice either, tough.


After the first run set "setenforce 1" even if default.prop indicated ro.selinux = permissive.
This is not correct behavior.
Properly get "getenforce" value and set it as the default.
Please fix it.


> It should be possible to dynamically load it from Shell32.dll with ```GetProcAddress()``` and if it is not found fall back to either ```SHGetFolderPath()``` or the environment variables.

Sounds a bit messy, but if that works, might be the best way, yes.

Since I can't really test it fully, can you do that, and do a pull request? I can then see if it'll still compile with my MinGW. Thanks.

> I don't know about the MinGW Win32 header files (are they a copy from MS? or did they re-implement everything?)

They're not straight copies, they re-implementations, mostly. For copyright reasons, I assume?

Looking at a few versions of shlobj.h, it seems like any value >= 0x0501 would work. Some versions have ```SHGetFolderPath``` wrapped around >= 0x0400, some have a check at the top that the value needs to be at least 0x0500 (at least when winresrc.h isn't included first). winresrc.h itself sets it to 0x0501 when it's not already defined.

I.e. setting it to _WIN32_IE_IE60SP1 (which does exist in MinGW's sdkddkver.h, and is defined to 0x0601) *should* work.


But could Not understand why I said to use it.


It should complain exactly because they are not `@pure` functions: they are allocating memory.
You can't `finalize` inside a `spawn` because the `finalize` would run immediately and that's not what you want.
The correct way would be to call `_new_*` in the beginning of the class body you are spawning and `finalize` there, because now you'd have a long lasting scope (i.e., the whole organism lifetime).


I've made a note to address the naming of this magic number (`16`) separately.


@herrniemand read few posts above. in that somewhat imaginary scenario users are punished by having to run the software with security hole unpatched for some extra time because maintainer dislikes the contributor.


I’m not sure what your referring to, could you be more specific? I’ve never looked at or used the ExtensionTestCase your referencing. Are you saying any XSD and parser pair needs to be put in there to get the correct behavior based on a urn? example:

urn:iiop->IIOPMetaDataParser

Something like that?

> On Aug 6, 2015, at 7:45 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> The unmarshalJboss method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66 <https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562896>.
>


This is a bit too strict for AS


I agree that CPU's branch predictor will predict non-error case. I agree with a previous point as well. No chance to prove myself without showing actual numbers.

Could you please say how is it going with github? If I push an updated version on top of the current branch (fix_session_sent_return_value), will we lose comments that we already made here?


Currently we pass the string length to OCI_BindString()
OCI_BindString() implementation already adds one 1 character when it performs the OCI host buffer variable

The following code works as expected:

```C++

        con.Open(dbs, usr, pwd, Environment::SessionDefault);

        ostring in = L"a";
        ostring out;

        Statement st(con);
        st.Prepare(otext("begin :2 := :1; end;"));
        st.Bind(otext(":1"), in, 0, BindInfo::In);
        st.Bind(otext(":2"), out, 10, BindInfo::Out);
        st.ExecutePrepared();

        cout << out << endl;
```

Thus I don't where is the issue.


why "pratilipi-user-login" ?


確定 `$_SERVER['HTTP_HOST']` 在 UriHelper 前面的測試沒有被蓋掉嗎?


@makc oh. Sorry. Misunderstanding. Yes. That what I was talking about.


Another thing about this method: The return type of `u64` is pretty arbitrary, and clashes with every guideline for choosing integer sizes that I've seen. I originally made it `u64` because that avoids a cast in one of three locations where the method is used. Would `u32` or `bool` be more appropriate? I'm partial to `bool`, IMHO it makes the condition "is this bit one or zero?" slightly less readable. `u32` is just as arbitrary, just supported by a vague unofficial guideline ("use 32 bit when you have no reason to go bigger or smaller"), and `u8` feels like half-assing it.


Please use `forEach` here. Map is for when you want to collect the results.


you mean the .iml file? Yup agreed. I've just started using intelliJ so still working out what is needed. It should be included in the .gitignore next commit.


The scan was canceled by the user   on 8/6/2015 2:40:33 PM
Included commits

Commit ID	Owner

a2fd3bb87547c065e2c9d5895c64f381941c9bdc	@amitchen22

afc3113dce70f0a536509bd8d71f5bdf06c87daf	@amitchen22


Because ransack is passing the the param in this form from ember. So, the param value for filtering disabled is `"q"=>"null"


Yes but Not here with this fork,

Android build need more patch (  patch again nl_lists/base stuff with undef _C , the n64 with undef si_status , update libco armeabi with the current libretro-common , and samcoupe with undef PAGE_MASK, then in genie script we have to disable midi , define SDL_ARM=1 ...)

something like http://pastebin.com/4ptNhCHA
for compilation i use this syntax

```
make OSD="retro" verbose=1 RETRO=1 NOWERROR=1  ANDROID_NDK_ARM="/opt/ndk/toolchains/arm-linux-androideabi-4.8/prebuilt/linux-x86_64" NOASM="1" ANDROID_NDK_ROOT="/opt/ndk"  gcc="android-arm" OS="linux" TARGETOS="android-arm"  USE_BGFX=0 NO_USE_MIDI="1" -j4
```


It would work.
You have to put the `CEU_IN__ASYNC` emission in `C++` somewhere you are sure that gets called frequently, I mean, as fast as possible, just like you call `UPDATE`, `DRAW`, etc, once per frame.
You have to be sure that `UPDATE`, `DRAW`, and `ASYNC` are called every frame, possibly in sequence in the same block of code (that's what I mean by the event loop).
The file that I linked does exactly that (`SDL_DT`, `SDL_REDRAW`, ..., `ASYNC`, then loop).


why not require `active_support/core_ext/hash/keys` ?


I've fixed this and the other incorrectly named commit ("DRY up validation of pay frequency questions") locally.


Should this not come _after_ the `#ifdef RBX_ALLOC_TRACKING` below, or does that not matter?


`returns` not needed


I’m not seeing a compile error, did you do a clean first? I checked out the branch brand new and compiled with no issues.

-W
> On Aug 6, 2015, at 7:45 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> The unmarshalJboss method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66 <https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562896>.
>


Ok, now I see.

![screen shot 2015-08-06 at 13 54 08](https://cloud.githubusercontent.com/assets/13552306/9110979/c0271dae-3c42-11e5-9d1a-47ae36705e25.png)


I just pull last changes and I get the following error :

ParameterNotFoundException in ParameterBag.php line 106:
You have requested a non-existent parameter "locale". Did you mean this: "app_locales"?


``` python
>>> bitsAndPins = zip([1,0,1,0],[5,6,7,8])
>>> print bitsAndPins
[(1,5),(0,6),(1,7),(0,8)]
# [(what_to_display,where_to_display),....]


This will modify the class until script or server stops running. I suggest using hashes and `method_missing` for example


If not necessary, why use static variables?


We should try to get rid of singletons, and certainly not add new ones.


They are allocating memory, yet they are declared as `@pure` because it doesn't work the other way.

I guess your solution won't work because these C++ constructors require some arguments which are passed with event. Adding a special field in organisms would be strange as these fields are not used anywhere but in constructor (or beginning of the class body as well).

If these arguments are not pointers but some kind of temporary objects, that would require allocating them in heap with copy constructor, passing a pointer and deleting them inside of the spawned organism. I think there are only pointer-like arguments, though.


Logic can be greatly simplified to not produce deep case statements, for example:

```elixir
  defp translate_custom_type(mod, mapping, key, normalized_conf, parsed_value, result, app_name, setting_path) do
    mod_loaded? = Code.ensure_loaded(mod) == {:module, mod}
    transition2_exported? = function_exported?(mod, :transition, 2)
    transition3_exported? = function_exported?(mod, :transition, 3)
    case {transition2_exported?, transition3_exported?} do
      {true, _} ->
        mod.transition(mapping, custom_parsed_value(mod, key, normalized_conf, parsed_value))
      {_, true} ->
        mod.transition(mapping, custom_parsed_value(mod, key, normalized_conf, parsed_value),
                       get_in(result, [app_name|setting_path]))
      _ ->
        # if a module/function not loaded/exported it means that
        # it is internal type, but without transition. Just return
        # default parsed value.
        parsed_value
    end
  end
```


You are still re-instantiating ShortenUrl here. You don't need to do that because you have injected the instance already via the Controller constructor. Please fix that!


@circuitfive I checked other pages, and the only one with a minor change was `/developer` (the text was `15px` to left in the right margin), but I fixed in commit 1cae45d.

I.e., we're good!


@akva2 thanks for clarifying this. instead of hardcoding the paths, I added the install commands in a patch file: eb31076

the patching works on OSX, but on windows it fails:

```
[ 66%] Performing patch step for 'protobuf'
patching file cmake/libprotobuf-lite.cmake
Hunk #1 FAILED at 28.
1 out of 1 hunk FAILED -- saving rejects to file cmake/libprotobuf-lite.cmake.rej
patching file cmake/libprotobuf.cmake
Hunk #1 FAILED at 58.
1 out of 1 hunk FAILED -- saving rejects to file cmake/libprotobuf.cmake.rej
patching file cmake/protoc.cmake
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file cmake/protoc.cmake.rej
```

however, I checked out the .rej file:

```
*************** set(protoc_files
*** 4,6 ****

  add_executable(protoc ${protoc_files})
  target_link_libraries(protoc libprotobuf libprotoc)
--- 4,8 ----

  add_executable(protoc ${protoc_files})
  target_link_libraries(protoc libprotobuf libprotoc)
+
+ install(TARGETS protoc DESTINATION ${CMAKE_INSTALL_PREFIX}/bin)
```

this doesn't make any sense? the .rej file is the same as the patch. any clues on why this works on OSX but fails on windows? maybe a bad patch format? the patch is in the commit linked above.

@Montellese

`library.kodi.game` and `library.xbmc.addon` are replacements for the helper libraries provided by Kodi. Netplay uses these to intercept callbacks being sent to Kodi.

When netplay is not in use, everything is normal:

game DLL -> `library.kodi.game (from kodi)` -> Kodi

When no clients are connected, Netplay sits between the game DLL and Kodi:

game DLL -> `library.kodi.game (from netplay)` -> Netplay -> `library.kodi.game (from kodi)` -> Kodi

When a client is connected, the netplay helpers send the callbacks to the remote Kodi:

game DLL -> `library.kodi.game (netplay)` -> Netplay -> remote Netplay -> `library.kodi.game (kodi)` -> remote Kodi

I think this is the best approach, because it lets Netplay participate with no obtrusions into existing code. A new macro is probably needed, because the `install(TARGETS ...` command works on linux, but results in this on OSX:

```
Install the project...
-- Install configuration: "Debug"
-- Installing: /Users/garrett/Documents/kodi/addons/.//game.netplay
-- Installing: /Users/garrett/Documents/kodi/addons/.//game.netplay/addon.xml
-- Installing: /Users/garrett/Documents/kodi/addons/game.netplay/game.netplay.1.0.0.dylib
-- Installing: /Users/garrett/Documents/kodi/addons/game.netplay/game.netplay.15.0.dylib
-- Installing: /Users/garrett/Documents/kodi/addons/game.netplay/game.netplay.dylib
-- Installing: /Users/garrett/Documents/kodi/tools/depends/target/binary-addons/macosx10.10_x86_64-target/build/depends/lib/kodi/addons/game.netplay/resources/libXBMC_addon-x86_64-linux.dylib
-- Installing: /Users/garrett/Documents/kodi/tools/depends/target/binary-addons/macosx10.10_x86_64-target/build/depends/lib/kodi/addons/game.netplay/resources/libKODI_game-x86_64-linux.dylib
[100%] Completed 'game.netplay'
[100%] Built target game.netplay
touch .installed-macosx10.10_x86_64-target

real	3m23.170s
user	2m41.690s
sys	0m21.130s
```


Checkmarx scan results 2015-08-06T11:57:36Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a48142215902a27cc8bad6dd654f39f5ef7a79fe	@dudug

d2c411e2e4d7536680d920b01c762c8592e975fe	@dudug


line endings.


Checkmarx scan results 2015-08-06T11:57:48Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1a7ee17de73f84eaa67cdb0d696d794a10c69d86	@dudug

a48142215902a27cc8bad6dd654f39f5ef7a79fe	@dudug


Checkmarx scan results 2015-08-06T11:58:13Z

High
Medium
Low
Info

New
0
4
25
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

698aad662fafddc9e1a3ef8a1bda8881c37591a2	@dortal


I think those could be edited out and placed in repo


This is temporary until I make it so CMainDialog somehow access CScreenPlayerSelect directly, see the TODO comment there


Logged issue https://github.com/influxdb/influxdb-python/issues/225.


@axtimwalde  @StephanPreibisch @tpietzsch @ctrueden
what am i doing wrong here?
eclipse says no warnings, it compiles, but on running this unit test:
mandersRealNoisyImagesTest()
 i get a
cant cast
error


Fix #3


I would put `pry` in a `Gemfile` as it's not something the code depends on.


![media visualizer library](https://cloud.githubusercontent.com/assets/13623770/9111055/bc599c48-3c4b-11e5-8998-207280611c1a.jpg)


THis is WIP - not ready for review yet (This push into master was a dirty workaround for an even dirtier local workflow mess.)


Checkmarx scan results 2015-08-06T12:00:21Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


I throught it was better to keep the last opened tab in CScreenSetup than in CMainDialog/CMainUserInterface, but feel free to change this if you wish.


Checkmarx scan results 2015-08-06T12:00:47Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

9b3e3cbb093d84dfcaf2107d4a18879b98d7ba91	@dudug

1a7ee17de73f84eaa67cdb0d696d794a10c69d86	@dudug


Checkmarx scan results 2015-08-06T12:01:07Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d5a07cb0b1744f15f637a4c7ffe8f2ac25f77bdd	@dudug


I can't see any `.env` or `.env.sample` files. Why is that needed if you're using VCR?


Checkmarx scan results 2015-08-06T12:01:10Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2d7f90a6cf7dafb50b0d7ecbca5e722630dab119	@dudug

9b3e3cbb093d84dfcaf2107d4a18879b98d7ba91	@dudug

1a7ee17de73f84eaa67cdb0d696d794a10c69d86	@dudug


Using code like the following:

@Test
public void testIIOPParser() throws Exception {
    IIOPMetaDataParser parser = new IIOPMetaDataParser();
    Map<String, AbstractMetaDataParser<?>> parsers = new HashMap<String, AbstractMetaDataParser<?>>();
    parsers.put("urn:iiop", parser);
    EjbJarMetaData metaData = unmarshalJboss(EjbJarMetaData.class, "/org/jboss/metadata/ejb/test/bz901186/jboss-ejb3.xml", parsers);
    System.out.println(metaData);

Sorry for the formatting, it’s IDEA, I’m assuming what *should* happen is the xml file is unmarshalled/parsed and the correct IIOP metadata constructed due to the inheritance chain in the parsers themselves: i.e....IIOP extends the AbstractEJB3 guy and things should get correctly constructed, is this the case?

> On Aug 6, 2015, at 7:45 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> The unmarshalJboss method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66 <https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562896>.
>


Checkmarx scan results 2015-08-06T12:01:33Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1a7ee17de73f84eaa67cdb0d696d794a10c69d86	@dudug

a48142215902a27cc8bad6dd654f39f5ef7a79fe	@dudug


That makes it less well analyzable with existing tools since using setup.py is a programmatic, not a declarative, method of doing anything (even pip has a dev requirements file). But if you feel comfortable with that, keep going.


Checkmarx scan results 2015-08-06T12:02:36Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2d7f90a6cf7dafb50b0d7ecbca5e722630dab119	@dudug

9b3e3cbb093d84dfcaf2107d4a18879b98d7ba91	@dudug


想定の上をいくコードｗ


![clone icon](https://cloud.githubusercontent.com/assets/13623770/9111094/1ddd6a3a-3c4c-11e5-8310-b5b48fc61cef.jpg)


```
.title {
  list-style-type: square;
}
```

でいけるはず。


Yeah, I'm going to screw this up...Can I get some help with squashing the deletes and commits?


There is a problem of conversion int -> uint8_t. Any correction idea ?


6 here is really a constant? I didn't get it.


![add media button](https://cloud.githubusercontent.com/assets/13623770/9111114/492cc992-3c4c-11e5-9dfc-1a2c0eedd727.jpg)


Well, the point is that CScreenSetup exists now all the time in one instance, so there isn't any reason to keep any static variables and functions, only pass the pointer to CScreenSetup where it is needed.


This shouldn't print to stderr, and even if it did the better place to ignore it would be in __fish_fossil_subsubcommand anyway, wouldn't it?


Please submit these changes as a PR to the upstream repo, and I'll then update to ember-1.13.7


line-heightは単位つけないほうがいいっすねー
ぐぐってみそ。


![create new](https://cloud.githubusercontent.com/assets/13623770/9111130/6ad68dc6-3c4c-11e5-819c-47f2fdc7cc96.jpg)


Keep in mind this might be intensive on the CPU. If it ends up being too much, we may want to
consider using a normal loop instead.

For more info:
http://jsperf.com/javascript-filter-vs-loop


I think external libraries should be required before your own.


my guess is that this is the wrong sqrt function. Cholesky is better if `alpha_s` is a square matrix.


> > Hmm, what's the precise rationale here?
> >
> > (looks ok generally...)
>
> Tool iwyu runs analysis of a given compilation unit and reports how include statements at the top should look like based on actual use of function, variables, macros, etc. In this particular case we miss ```sys/stat.h``` and ```time-util.h```. Because those two files are pulled in indirectly by some other ```.h``` file compilation doesn't fail. However it is good practice only include what you use and nothing else.
>
> If you don't want this commit to be included in PR I am happy to drop it and send separate PR. Your call.

I'd probably not do this for now, unless it's necessary to make things
build on some distro/glibc version...


请不要三天之内发布三个版本。


https://github.com/imglib/imglib2-ij/blob/master/src/main/java/net/imglib2/img/ImagePlusAdapter.java#L75 casts to `BitType` even if the underlying `ImagePlus` is `ByteType`.


I don't know ember and ransack but it seems to me strange. That's why I asked you :)


Shouldn't that be in UTC or something?


Seems, like the whole deep case statement can be simplified at least to something like it:

```elixir
  comments = if custom? and function_exported?(mod, :to_doc, 1) do
               doc = Keyword.get(info, :doc, "")
               if (doc == "") do
                 to_comment(mod.to_doc(args))
               else
                 to_comment("#{doc}\n#{mod.to_doc(args)}")
               end
             else
               to_comment(Keyword.get(info, :doc, ""))
             end
```


CScreenSetup is now only a base class for all CScreenSetup___ classes, so there are multiple instances of it


Sure thing I don't know a ton of stuff it's always good to have a discussion if you are not sure about  something


Oh yeah and added some test placeholders


@Gaurav Same as for the typo, changed the line as follows:
````diff
-        UINT64          eventArgAddr;           ///< Address of the event argument
+        UINT64          padding;                ///< 64 Bit placeholder
````


Why so picky... ;)


Really good!


![delete icon](https://cloud.githubusercontent.com/assets/13623770/9111160/c5a32b38-3c4c-11e5-81e7-921fa3efa250.jpg)


Nice, with the exception of the question I did above.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


that should be forward ported to indigo-devel right ? indigo-devel should be the default branch too right ?


![edit icon](https://cloud.githubusercontent.com/assets/13623770/9111177/f3062404-3c4c-11e5-9b57-08b301c9e11d.jpg)


Ah, you're right. I don't keep up with all these changes :P


I just updated the branch you will find the

IIOPMetaDataTestCase

that shows what I am doing to test the IIOP XSD and the new code. The testIIOPParser() test is the one I’m using currently. If what I’m doing is correct, then there is a bug in the parsing code, not in the IIOP stuff because I can’t see what else would be wrong with what i have written.

> On Aug 6, 2015, at 7:45 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> The unmarshalJboss method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66 <https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562896>.
>


Good spot! I've fixed this locally.


I inherited the modules from Pawel Pabian (bbkr in gitian), I must have changed this a long time ago which is beyond my memory horizon ;-)

 Sorry for not reacting on the issue back then, I am also a newbe on github and just now I noticed all those messages

Greetings
Marcel


The fishy way to do it would be

```
set -l editor
if set -q EDITOR
    set editor $EDITOR
else if set -q VISUAL
    set editor $VISUAL
else
    echo 'Please either set $EDITOR or $VISUAL'
    return 1
end
```

also that actually errors out early if no editor can be found.


It was convenient to have the default value in the @args section


I admit... I completely forgot to handle directories...
Good job!


sprockets -v
3.2.0

bundle exec sprockets -v
2.12.4


![add new sheet](https://cloud.githubusercontent.com/assets/13623770/9111202/1cd4694e-3c4d-11e5-95a6-529763c3d2b0.jpg)


This should run specs


You are tricking the compiler just like `PTR2REF` does.

It is better to have a single trick to be able to easily track them.

Pointers in C/C++ are unsafe (being them unique, shared, standard, whatever).
The `finalize` mechanism makes them a little bit less unsafe.

Most `new_*` I saw don't pass any arguments.
For those who pass, why not pass them the organism constructor?
That's why constructors exist, just like in C++, what is the difference?

I'm just giving you an extra safer option, that's it. You can use `@pure new_*`, or use `PTR2REF`, or use constructors (from the un- safest to the safest).


THE magic line that speed up IT tests by of 10^26 ;)


Looks ok


I think it's because there's about to be a player, the object just hasn't been created yet.


It's better to alias `pyblish_integration.show` to `show`. At the moment, your function doesn't take any arguments, which means we can't pass on any arguments. You could pass `*args, **kwargs`, but then code completion would have a tougher time figuring out what the argument signature really is.

```python
show = pyblish_integration.show
```


You don't like comments do you?
I mean this is like a massive extinction...
R.I.P :skull:


Don't forget about linting, there should be two newlines here.


I don't think this (or `getUUID()`) is needed, as the event extends `UserEvent`.


ok, i changed line endings to windows format. on OSX it strips the CRs, but still works:

```
[ 65%] Performing patch step for 'protobuf'
(Stripping trailing CRs from patch.)
patching file cmake/libprotobuf-lite.cmake
(Stripping trailing CRs from patch.)
patching file cmake/libprotobuf.cmake
(Stripping trailing CRs from patch.)
patching file cmake/protoc.cmake
-- AUTOCONF: copying /Users/Shared/xbmc-depends/buildtools-native/share/automake-1.11/config.sub to /Users/garrett/Documents/kodi/tools/depends/target/binary-addons/macosx10.10_x86_64-target/build/protobuf/src/protobuf
-- AUTOCONF: copying /Users/Shared/xbmc-depends/buildtools-native/share/automake-1.11/config.guess to /Users/garrett/Documents/kodi/tools/depends/target/binary-addons/macosx10.10_x86_64-target/build/protobuf/src/protobuf

```

It looks like windows is also stripped the CRs, so it fails with the same error:

```
[ 66%] Performing patch step for 'protobuf'
(Stripping trailing CRs from patch.)
patching file cmake/libprotobuf-lite.cmake
Hunk #1 FAILED at 28.
1 out of 1 hunk FAILED -- saving rejects to file cmake/libprotobuf-lite.cmake.rej
(Stripping trailing CRs from patch.)
patching file cmake/libprotobuf.cmake
Hunk #1 FAILED at 58.
1 out of 1 hunk FAILED -- saving rejects to file cmake/libprotobuf.cmake.rej
(Stripping trailing CRs from patch.)
patching file cmake/protoc.cmake
Hunk #1 FAILED at 4.
1 out of 1 hunk FAILED -- saving rejects to file cmake/protoc.cmake.rej
```

how do other add-ons provide windows-compatible patches?


Goddamnit, i think I may have found it, give me a sec, I think something IS wrong in the parsing code...
> On Aug 6, 2015, at 7:45 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> The unmarshalJboss method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66 <https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562896>.
>


라인82~84 라인 대신에 다음과 같이 쓰세요.

if form.is_valid():
    form.save()
    return redirect('blog.views.detail', pk)


This isn't necessary anymore, see https://github.com/pyblish/pyblish/issues/213


Code style - braces everywhere, please!


![sheet table](https://cloud.githubusercontent.com/assets/13623770/9111260/c9b9a4ee-3c4d-11e5-9fae-1b98bc8eb827.jpg)


Mmmh, getFileNameFrom**File**Url was supposed to support http ones.


![file - publish to the web](https://cloud.githubusercontent.com/assets/13623770/9111266/d85afec6-3c4d-11e5-82fe-7ba47094b53d.jpg)


@MikePetullo, please review.


![start publishing](https://cloud.githubusercontent.com/assets/13623770/9111273/e7bdade6-3c4d-11e5-925c-aa557d59f85b.jpg)


lol


Wait, why do we need this?


We can remove this, other integrations should have it removed too.


Again, this is not needed.


Seriously, accepting contributions from bad, in your opinion, people is not the big deal. If you could use nazi rocket scientists to get to the moon, would you? If you could get blood transfusion from serial killer to save your own life, would you? Hell, you have no problem picking up the loot from your enemies in the video games. The examples are countless. But no, the software development is completely different business.


Why?


worg issue assign, some work on quick-fix


![comma-separated values](https://cloud.githubusercontent.com/assets/13623770/9111289/2263a1f8-3c4e-11e5-8aab-b4e6240b220d.jpg)


I  think we will outsource this two or three lines to a separate penalized WLS function, so it can be tested separately and be replaced by different versions.


![upload csv file from web](https://cloud.githubusercontent.com/assets/13623770/9111297/3c3f1eea-3c4e-11e5-8901-23991e9789b4.jpg)


Hey, no problems :-)  I submitted the PR in the hope that it helps.  Since the problem had resolved itself in the meantime, that's all good!


If you don't like it fix it in core until I have time to rewrite the whole damn syncing cron


nup


good job


Core works right and you doing redundant start.


The scan was canceled by the user admin admin on 06/08/2015 15:19:46
Included commits

Commit ID	Owner

f3f65c0932cdcdd1200eec89442b32b6ba5c4fff	@dortal


Pyblish QML isn't working?


This will sound old-school, but perhaps for errors to be intuitive to the player, we could use simple `window.alert()` dialogs?


Test tone sequence


It’s the ejb-name thing again, it’s infecting the other elements of the XSD, without it, varying errors occur and as a result, you have to keep adding it in weird places to get anything to work. This really needs to be fixed as per

https://bugzilla.redhat.com/show_bug.cgi?id=1192591

Once that is done, that kills off like 3 BZ’s for me all having to do with XML crap.

> On Aug 6, 2015, at 7:45 AM, Carlo de Wolf <notifications@github.com> wrote:
>
> The unmarshalJboss method is unaware of any extension parser. See also https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66 <https://github.com/wprice/metadata/blob/841f466fd60843a88b467bcbf8020fc4a4ad0339/ejb/src/test/java/org/jboss/metadata/ejb/test/extension/ExtensionTestCase.java#L66>
> —
> Reply to this email directly or view it on GitHub <https://github.com/wprice/metadata/commit/841f466fd60843a88b467bcbf8020fc4a4ad0339#commitcomment-12562896>.
>


isBuildable is overridden to always return false and I'm not removing it until I understand all the implications.


Because there aren't warnings here...


attributes should have more informative names. one letter names are not understandable without a manual or book


If I could pass arguments in constructor so they could be used in the beginning of the class body (before any parallel section), your solution would be reasonable. (Though I'm not sure how to do that.)

But having special organism fields for that is strange. For example, if I pass a reference to some constructor, I want it to use it only in constructor. I don't want it to save that reference somewhere inside. May be I'll `free`/`delete` referenced object right after that constructor call. Having such fields clutters up interface and creates a possibility for mistakes: for example, using these constructor arguments across `emit`.

I'm just saying that
```
every arg in SPAWN_ORGANISM do
    spawn Organism with
        this.cpp_object = {new CppObject(arg);}:
    end;
end
```
is better than
```
every arg in SPAWN_ORGANISM do
    spawn Organism with
        this.cpp_object_constructor_arg = arg; //attribution to a pointer with a wider scope?
    end;
end

...

class Organism with
    var _Argument* cpp_object_constructor_arg;
do
    var _CppObject&? cpp_object = _new_CppObject(cpp_object_constructor_arg); //passing a pointer into function, unsafe - yet that function's not `@pure` as it allocates memory
```


Checkmarx scan results 2015-08-06T12:11:19Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
26
17
30
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

bd65574303fa33a6a7199f8af33d90d5bbec7359	@amitchen22

3eab67964935d710c400a0bbc4a8825845e2daa9	@amitchen22


> Hell, you have no problem picking up the loot from your enemies in the video games.

Nailed it.


no (i didn't know that so 100 was just an arbitrary large number)


Intellij IDEA complains about "Account account = null;"


@marcelmoosbrugger should this be hardcoded?


Can you check whether it really failed to remove those old APKs? Dit they not just failed to be part of the upload_sources.sh script's execution?
I will download the commits and squash them


I'll have to look into the patch issue. I know that `patch.exe` can be a bit picky but when I added it I tested it with several patch files I copied from existing patches in the Kodi repository and it worked so I thought it wasn't as picky as advertised but maybe I was just lucky.


A+ solution


N.B. the amended commit was in no way meant to sound like I was bagging on the handily fantastic [PyString C++ microlibrary](https://github.com/imageworks/pystring), which I happened to be vendoring in, during this commit – although it kind of totally does read that way. This is because, if you go by LOC, the commit is like 90% PyString, 10% me; when I wrote the bit that was harshing on string methods I was in fact specifically griping about writing the [same fucking NSString category as always like for the 10th fucking time and shit](https://github.com/fish2000/libimread/blob/master/include/libimread/objc-rt.hh#L23-L39).

![maxresdefault](https://cloud.githubusercontent.com/assets/378969/9111353/56cb65e6-3c14-11e5-8a99-43f5120f3592.jpg)

… Hopefully that’s clear now; PyString is awesome, whereas my string methods are not, because I am all about fucking image-processing and shit dogg for realsies. Yes.


this variable is never used.


Plus, if I want a reference in the interface, I won't be able to do that, as I have to init it in constructor where I can't use `finalize` so I won't be able to use unsafe allocating functions.


No problem @bruderstein, this was easy.

Small price to pay for all those tests! :grinning:


Before the fix, the columns ['int_', 'long_', 'byte_'] would be returned in the right order, but the dtypes still have the original (wrong) order, causing the dtypes of the columns to be resp. [np.int8, np.int16, np.int32]


ah thanks ... able to replicate the same on linux
\n works fine on mac and ubuntu
:+1:


通常`#!`后面不加空格。


var frameLength = frame.contents().find('#ExpModPlaceholder input').length;
if (frameLength > 0) {
    elemCA = frame.contents().find('#ExperienceModificationCustCA');
    elemCA[0].value = items.ExpMod;
    expModField = elemCA[0];
    if (1 > frameLength) {
        window.frames[1].toggleExpMod();
    }
}


Checkmarx scan results 2015-08-06T12:28:55Z

High
Medium
Low
Info

New
0
4
25
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

698aad662fafddc9e1a3ef8a1bda8881c37591a2	@dortal


"if they"


Yeah I had brain fade on this realised later :( the setdefault threw me with the ghost volume and just wanted to be sure I kept original compatibility while going forward.


what's your build environment and error? I can build it with mingw64, vs2008~2013 and cross build on linux


I think we need a reference for OIDs. But otherwise this paragraph is fine.


Nice test.


`grdimage`命令里使用`-B`就可以绘制边框，所以下面的`psbasemap`没有必要


We should make this generic as much as possible before the CLI becomes too customized.


Checkmarx scan results 2015-08-06T12:19:27Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
26
17
30
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

0979a6efb552da1022112002cd1beade138653fc	@amitchen22

22add65bfd587052228949bda81ea630f2408142	@amitchen22


In which controller do you have this error ? Maybe try a cache:clear. I just pushed two corrections on index and tourist controllers but I don't think they are related to yours


Fait
+ pushé

Antoine

2015-08-06 13:02 GMT+02:00 julien <notifications@github.com>:

> composer require friendsofsymfony/elastica-bundle
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/juju921/E-Lycee/commit/a856f07e16e87d20846c608f70554526667c6c8a#commitcomment-12562192>
> .
>


Checkmarx scan results 06 Aug 2015 15:30 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


Тут ты перемудрил :) запиши проще)


Do we need to mention the earlier RFC(s) that mention PENs?


Ouch. Using sync will increase wait times and general overhead.
This function is supposed to be light and stop the worker when it is not needed anymore at all.

When this is called, we don't care about the results of the worker and we don't want any further decision, until the governor is up and running again.
Stay without sync: we don't care if we leave the current worker in an inconsistent state.


don't you need to tell splice how many to remove?

```
this.components.splice(i, 1);
```

otherwise, i think it defaults to 0 and it won't remove anything.


I agree that it should be placed in `contrib` but compared with the latest build (2.3.0rc1) the nanosoap module is in the root modules directory.


You could remove the 'game_board' parameter and replace it with '@board'. Same goes for in 'check_grid?'.


字符串里如果有空格的话，可以用单引号或双引号包围起来，用反斜杠转义的话不够直观，也比较容易出错。


I disagree about not using RFC 2119 language. These are either strict requirements or they are pointless.


Comments addressed in 74bc4f2.


I'm not sure how to make pip install eve-elastic work with requirements file, any ideas?


hm, so the patch uses unix EOL, which is converted to windows EOL by git (I believe), but then patch.exe strips the CRs and still fails?


`-M`是GMT3的用法，GMT4中的标准用法是`-m`，虽然GMT4也可以识别`-M`


что именно не понятно?


test-s3-fixes (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (747 of 747 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.18%25-green.svg)


Checkmarx scan results 2015-08-06T12:22:34Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
26
17
30
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

02e17dc4a17d2639ed7e6af2606bf56563f129a5	@amitchen22

0979a6efb552da1022112002cd1beade138653fc	@amitchen22


Isn't this the place where you'd want to use the provided codec registry instead of the default?


ah yes, you're right.  Thank you.


Damn intellij XD Ok, sorry.


Do we want to give examples on how to use OID (the old text) or do we expect people just to know? From my discussion with Pearl, it looks like people don't always have enough clue.


Checkmarx scan results 06 Aug 2015 15:35 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2df19aa46451ad26f4dc72164d23cf438903565b	@cxehud


да как его написать этот код


You could simply this whole function down to:

    def game_over?(board)
      board.check_grid?
    end

See my later note about 'check_grid?'


Leave this unchanged for this reason:
We are in an SMP decider.
if (up) {
   reduce_frequency(last_cpu_or_global);
   wake_cpu(cpu)
} else
   unplug_cpu(cpu)

This means that this cleanup will be, sooner or later, reverted.... for this reason I feel no need to clean this.


This looks strange, is it correct?


> If I could pass arguments in constructor so they could be used in the beginning of the class body (before any parallel section), your solution would be reasonable. (Though I'm not sure how to do that.)

They will already.
The semantics is
`spawn -> beginning-of-class-body-until-awaits -> continuation-of-spawn`

> But having special organism fields for that is strange. For example, if I pass a reference to some constructor, I want it to use it only in constructor.

You are totally right here.
But this is not a fundamental flaw, it is just a pity that the syntax doesn't allow you to distinguish between fields and constructor arguments. This could be changed at any time and it is totally doable, right?
It is totally different from a fundamental flaw, such as allowing unsafe pointers (from the point of view of Céu and other "safe languages").

> Plus, if I want a reference in the interface, I won't be able to do that, as I have to init it in constructor where I can't use finalize so I won't be able to use unsafe allocating functions.

The point is that you are *not* passing a reference, you are passing a newly-allocated object that has no associated "parent".
When you pass by reference you can only pass someone that has an explicit scope that is at least as high as the organism you are creating.
You already do that a lot in the code and you don't need any kind of `PTR2REF`.
Unfortunately, usually they are Céu classes that are already ported.
If you ever reach to a point to eliminate `C++` there will be no pointers, only strong references.
But you can't do that at once, of course, so you need `finalize` or `PTR2REF`.


Remove the branch. At the end I discovered that this way in the if 0 is stupid :p


I think this document needs to say how characters are limited. At least Pearl asked for specific text on this. (If you agree, the above addition is fine, but we also need text elsewhere.


You've got some duplication here. Consider moving this loop into 'Board' as a method and passing in the move lists.


I think the upload_script.sh needs some logic to be implemented for a
situation like this. Currently the script creates the commit like this:

# upload_script.sh line 34
git rm -q -r --ignore-unmatch "$(dirname "$1")"
git add "$1"

so if the new apk goes to a new subdir (higher API level), the old one will
not be removed.

2015-08-06 14:23 GMT+02:00 mfonville <notifications@github.com>:

> Can you check whether it really failed to remove those old APKs? Dit they
> not just failed to be part of the upload_sources.sh script's execution?
> I will download the commits and squash them
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opengapps/arm/commit/12536929dab4661a39f9ba529631ce268a0d59a1#commitcomment-12563608>
> .
>


Yes and no... rqbalance_state name was pretty explainatory...


This commit has introduced `PHP Fatal Error: Call to a member function getFullURL() on null in /usr/wikia/slot1/6061/src/extensions/wikia/Email/Controller/WallMessageController.class.php on line 197` in `release-319`.


Why save OIFS if never restoring it?


Btw, FYI @NicholasBuse, how I solved the squashing:
First I removed your commit that deleted all three files with: git reset HEAD~1
I made three separate commits that deleted each old file.
Then I did run git rebase -i HEAD~9 and i re-ordered the list so that each deleting commit came after each commit that added the file, and changed 'pick' into 'squash'


Checkmarx scan results 2015-08-06T12:39:24Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

7f653e426ca0580ae96d0fec929b1d624e96a14c	@dudug


yep, thanks for reminding ;)


UGLY. UGLY, UGLY and... UGLY!!!!

NO IFDEFS!!!!!


The scan was canceled by the user   on 8/6/2015 3:29:13 PM
Included commits

Commit ID	Owner

724757c496bc2ab785d727b87513125660e00f23	@amitchen22

02e17dc4a17d2639ed7e6af2606bf56563f129a5	@amitchen22


@mc1100 You are right. Unfortunately I won't have time to implement those changes soon, because I will be on holiday (yay for me!). Maybe somebody else like @rapperskull can take a look at it?


ARGH!!!


Why /var/tmp:
repoquery(yum-utils) uses that folder by default anyhow. The only thing done as a part of this story was to create a temp folder inside this one to overcome multi-threading issues while polling. BTW there is a system property available to change the folder to something else.

Why not work dir:
First time download of repo metadata and other files does take a bit of time. Since /var/tmp is retained across server restarts, the cached folder will be reused during next MDU, and hence second time onwards the repoquery calls should be relatively faster. "work" dir on the other hand gets recreated everytime Go server is restarted, so if we were to use this folder, the first repoquery call for each repo would be slow after every restart. Don't see a point in that.


Completely right.
This looks stupid like that and it is error prone. Check the return values. Do it.


I think your parameters file isn't up to date. You have to make a composer update to add "locale: en" in this file.


I believe (untested) MathJax's default will kick in, which is `\(...\)` but not `$...$`.
(And both `\[...\]` and `$$...$$`  for display)

It does sound from the commit title like the author *wanted* to disable inline altogether, which is strange.


Just a complement...
Python has no "private fields", but they have a *convention* that says that fields starting with `_` are private and shouldn't be touched from outside.
You could use a similar convention, such as `pvt_*` or `*_`, etc.


Well, I wasn't sure what status to make it, as it is broken for sure on `x86_gcc2` but it isn't on other arches, it just needs a bootstrap package. But @hamishm was saying he thinks there might be a way to get around that; he'll look into it.


не подходит, при первом условии если if (frameLength > 0) нужно вызвать window.frames[1].toggleExpMod();


you mean ```if not os.name```?


Shouldn't this also check for user modules and attribute their traffic to the user instead of the network?
Put differently: Why the special case for global modules?


You should have used a `<thead>` element to wrap the headers. Here's how it works:

``` html
<table>
  <thead>
    <tr>
      <th>…</th>
      <th>…</th>
      <th>…</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <th>…</th>
      <th>…</th>
      <th>…</th>
    </tr>
    <tr>
      // …
    </tr>
  </tbody>
</table>
```
Basically, you just wrap the current content (`<tr>` tags) inside `<thead>` and `<tbody>` tags, that allow you to distinguish between a table's headers and main content.


initially it wasn't, but works now with this commit; https://github.com/tokejepsen/pyblish-hiero/commit/8af56e283310843f4dbf2f8d5113ee2fbf738426#diff-fdf9ba356700ef48b73653e7bdea40dfL94


That's fine, just remember that there is more than one call to `resize_`, so you'll probably need to update both to call `dragNode.show()` if you remove it from `resize_`.


Couldn't `error` be NULL here?


Hmmmm... While the idea may be somehow good, this is wrong. You are not respecting the update rate.


If I understand correctly, then this assumes that the value on the top of the stack has index 2 and was checked to be a function above. However, nothing stops me from passing more stuff in and then "bad stuff" will happen in the callback.


@mstanichenko AFAICT, if you push, you'll hide the comments on lines that you changed (dunno if they're still visible somehow). Github assumes you addressed the review comments.


counter cache?


No, because e.g. if you don't have network, go get fails. So if you try and do a `make` while on a plane, it'll never work :(


Ha, yes :)


@petecooper This is an obsolete string. Yes it's in RPC for backwards compatibility but it won't be needed in these v4.6+ Textpacks. There are also other RPC strings that don't exist in this repo, that is intended - ignore those too please. Reverting.


такое не подходит


I didn't mean that I'm *passing* anything as a reference. I meant I'm *having* a reference to an allocated object. I'm responsible for it's deleting, but I want it to be public, so other organisms could use that if they have access to such organism.

May be that could be implemented using private reference and a special getter method, but who needs this if I can just have a public reference?

Also, I didn't get that about `spawn -> beginning-of-class-body-until-awaits -> continuation-of-spawn`... Do you mean I can write something like that:
```
every arg in EVENT do
    spawn Organism;
end

class Organism with
do
    var _CppObject&? = _new_CppObject(arg);
```
?

That really looks strange. If you mean that I can do something like:

```
every arg in EVENT do
    spawn Organism with
        this.arg = arg;
    end;
end

class Organism with
    var _Argument* arg;
do
    var _CppObject&? = _new_CppObject(arg);
```
Then I don't see the difference between that and just having a field.

Having a prefix is fine, but that means I can use such private field across any emit anyway (if that's a reference, for example). But if that reference is constructor-only, that can cause problems.

Of course, we can have a convention that `c_` are constructor-only and should only be used during construction phase, but it still looks worse than use of these arguments directly from constructor.


I think having you people on github is punishing to users.

On Thu, Aug 6, 2015 at 6:50 AM, Ackermann Yuriy <notifications@github.com>
wrote:

> @makc <https://github.com/makc> oh. Sorry. Misunderstanding. Yes. That
> what I was talking about.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nixxquality/WebMConverter/commit/c1ac0baac06fa7175677a4a1bf65860a84708d67#commitcomment-12562972>
> .
>

--
Kurtis Rainbolt-Greene, Hacker
Software Developer
1631 8th St.
New Orleans, LA
70115


The scan was canceled by the user   on 8/6/2015 3:41:35 PM
Included commits

Commit ID	Owner

cdf10c1e48dcb7db476bc16925a34d399047f06b	@amitchen22

724757c496bc2ab785d727b87513125660e00f23	@amitchen22


To create a self-signed certificate

```bash
TML_KEY="/opt/boxen/data/nginx/ssl/nginx.key"
TML_CERT="/opt/boxen/data/nginx/ssl/nginx.crt"

openssl req -x509 -nodes -days 365 -newkey rsa:2048 -keyout $TML_KEY -out $TML_CERT
```


Is this the wrong way round?


Gotcha.


I think so... I use several text editors with different configurations.


why accepting a `Boolean`, implies a three states parameter, one of which is implicitly converted in one of the other two (`null` is converted to `false`), confusing imho


The scan was canceled by the user   on 8/6/2015 3:42:35 PM
Included commits

Commit ID	Owner

64595cf35d01382df451c2eb01f952776628ba37	@amitchen22

cdf10c1e48dcb7db476bc16925a34d399047f06b	@amitchen22


Indeed


delete “S".Its ”状态栏选项“ NOT ”S状态栏选项“


`@Immutable` would be nice here


Will do! I did this as a quick fix, and ended up forgetting to push it further up. Thanks for reminding me.


Dommage :-) Cela aurait permis d'économiser des formats d'images dans les modules et d'utiliser ceux d'Addons qui sont justement en 57px. Surtout que cela n'augmente pas la hauteur de ligne d'un module.


lgtm


Again, seems like this conditional might be the wrong way round?


give this class seems to be a fork of the CE's implementation, all comments from previous review apply

WDYT?


We should stick to the final concept:
private final String url


No that is when its coming back from the `MongoCollection<BsonDocument>`  and we give it to users as a Document rather than a BsonDocument.  We encode it on the way in `GridFSBucketImpl`.


fixed fireball-x/fireball#181


This commit introduced tabulator characters instead of space characters.


Removing this doesn't seem right to me?


an override of this method with a vararg parameter would be nice


Done


@romquin this one goes out to you ;)


It looks like using `patch.exe` with `--binary` (like it is used in our buildsystem) doesn't work with this patch independent ofLF or CR-LF. Without `--binary` it crashes with LF but works fine with CR-LF. I'll have to investigate further.


некрасиво передается введенный пользователем текст, видимо необходимо использовать rails form helper вместо simple_form, но пока так


What happened to this? Is the scrollbar still invisible unless user hovers the scrollable area?


shouldn't this be a `setIntegerChildrenMeasures`? calling twice override previous values for a specific metricKey


My idea was to return the FDs to lua immediately and not only when the child exits. Lua can then read from these until the other end closes them, instead of explicitly waiting for the child process to exit.
So basically:
```C
lua_pushinteger(L, pid);
lua_pushinteger(L, data->stdout_fd);
lua_pushinteger(L, data->stderr_fd);
return 3;
```
(And `G_SPAWN_DO_NOT_REAP_CHILD` has to be removed then, I guess)

An example on how to read from a unix FD (this uses `0, false` which means "stdin and don't ever close the fd", so this should likely be replaced with `true` for actual use; also, this starts a main loop, which is not necessary in awesome, because we are already running a main loop; also notice that the first read is blocking, which is not what we want.)

```lua
$ (echo first ; echo second ) | lua -e 'gio, glib = require("lgi").Gio, require("lgi").GLib ; local read = gio.DataInputStream.new(gio.UnixInputStream.new(0, false)) ; print("first line", read:read_line()) ; read:read_line_async(glib.PRIORITY_DEFAULT, nil, function(obj, res) local line, err = obj:read_line_finish(res) ; print("second line", line, err) end) ; glib.MainLoop.new(nil, false):run()'
```

And yes, this makes the lua side more complicated. No, I don't know right know how to check if the other end has closed the pipe.


It looks like the webgme version was downgraded here... This will need to be fixed


Do you mean to make this function (optionally) parallel here?


good point


The scan was canceled by the user admin admin on 06/08/2015 15:59:08
Included commits

Commit ID	Owner

7a9447794779807bc34cbc314aa95ad92a4e5304	@dortal


could be called `setValue`, argument type is enoug


but it is. link field is in reality "embed"


Excuse my ignorance Sir! What is the difference between both annotations: [HttpGet("error")] and [Route("/error")]?


Tabulator character instead of space characters.


Never mind, I get it now.


Ah, that makes sense, sorry didn't think of the overlapping commit.


test


This class can be used in the following fashion `MeasureImpl.setIntValue(12).setDoubleValue(13d)`, in which case it holds two values (which are not the same!).
`setXXXValue()` methods should better be static, called `createMeasure` (rather than `create`, to be more static import friendly) and return a new instance for each call which will be design be able to hold only one value


I wonder if the performance could be improved by a using a particular pattern of unvisited nodes. Unvisited will be ordered as at https://github.com/adamnovak/vg/commit/a30484a56fef3c20b399536123b14612d0c438e8?diff=split#diff-b9e665b46d6668bb432c95d4b2539524R4217 above.

Is the intuition that unvisited things will be tend to be possible seeds in unreachable portions of the graph? (Including other disjoint subgraphs without heads or tails, such as "plasmids"?)


True. Hmm...


I realize that as soon as I pushed the update. Sorry about that.

On Thursday, August 6, 2015, Brian Broll <notifications@github.com> wrote:

> It looks like the webgme version was downgraded here... This will need to
> be fixed
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/brollb/cnn_creator/commit/04907f0624c68eaf201416bb8260d0ab905abb4f#commitcomment-12564325>
> .
>


Checkmarx scan results 2015-08-06T13:05:39Z

High
Medium
Low
Info

New
8
9
13
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1ab923c6f49c5c8440b23da1ae1983ba580232e2	@amitchen22


Checkmarx scan results 2015-08-06T13:05:58Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8b6b97cfc6265939c0dc98ebd4b27aaaa7160133	@dudug

2d7f90a6cf7dafb50b0d7ecbca5e722630dab119	@dudug


Copying code is a captial crime. The getType() method is copied code.

Since you're using just the classname anyways you don't need the getType() method at all.


This commit appears to have made Saved Application State reliable, fwiw.

No lost Terminal.app state across reboots/logouts and no lost state in other apps, in other words.


I think you messed up this merge - you've ended up with two copies of the code in the file!


Checkmarx scan results 2015-08-06T13:06:59Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ee1d926f8c0b789c076fdf456e6ad959c187af24	@dudug

8b6b97cfc6265939c0dc98ebd4b27aaaa7160133	@dudug


Sadly this will not be enough since Authenticate does more things than StartAuthenticate. =/


Checkmarx scan results 2015-08-06T13:07:57Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ee1d926f8c0b789c076fdf456e6ad959c187af24	@dudug

8b6b97cfc6265939c0dc98ebd4b27aaaa7160133	@dudug

2d7f90a6cf7dafb50b0d7ecbca5e722630dab119	@dudug


:+1: great description


Checkmarx scan results 2015-08-06T13:08:40Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d5a07cb0b1744f15f637a4c7ffe8f2ac25f77bdd	@dudug


I'm wondering if we can revert this commit for now. I would prefer it if we got the core functionality working well before doing this.


是我发现的我会乱说？


Was left there by accident, thanks for removing it!


Checkmarx scan results 2015-08-06T13:09:29Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3071ef86da588a98d27011986cc6c4db68c8958d	@dudug

29ea96f1bf0a08be0bb18a90b7c05b5126055d0d	@dudug

ee1d926f8c0b789c076fdf456e6ad959c187af24	@dudug


天了噜竟然更新了！赞赞赞


The line commenting isn't very clear. I mean line 31, the `preload` option, it doesn't exist.


and by "you people" you mean "whoever @krainboltgreene does not like", right?


How is this different from withdraw?


Checkmarx scan results 2015-08-06T13:10:19Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a84eb07efc81b2b508b79aca5bfce286b84281c2	@dudug

3071ef86da588a98d27011986cc6c4db68c8958d	@dudug


I believe this update should have fixed the problem:
``` diff
diff --git a/src/Socket.cpp b/src/Socket.cpp
index f5ff117..0ac783c 100644
--- a/src/Socket.cpp
+++ b/src/Socket.cpp
@@ -416,10 +416,10 @@ CSocket::~CSocket() {
                m_pModule->UnlinkSocket(this);
        }

-       if (pNetwork && m_pModule && (m_pModule->GetType() != CModInfo::GlobalModule)) {
+       if (pNetwork && m_pModule && (m_pModule->GetType() == CModInfo::NetworkModule)) {
                pNetwork->AddBytesWritten(GetBytesWritten());
                pNetwork->AddBytesRead(GetBytesRead());
-       } else if (pUser && m_pModule && (m_pModule->GetType() != CModInfo::GlobalModule)) {
+       } else if (pUser && m_pModule && (m_pModule->GetType() == CModInfo::UserModule)) {
                pUser->AddBytesWritten(GetBytesWritten());
                pUser->AddBytesRead(GetBytesRead());
        } else {
```


In this repository I'll put my code


Please don't add new tables for every different request and response type. That does not scale and is not maintainable.

Instead add a getDebugData() method to the interfaces of Request and Response. getDebugData returns an associative array where the key is what needs to be written in the <th> and the value is a String or an Object with a __toString() method.


You don't need all the getXYZ methods in the requests (for now). See https://github.com/comsolit/ComsolitImasysMessageSenderBundle/commit/38710f893e462338c646cc920f0d1f847c45495d#commitcomment-12564536


Damn, I think I messed up something with PY charm, I didn't noticed; lame me. Close this request, I'll send a fixed one.


Thanks!


Checkmarx scan results 2015-08-06T13:11:23Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a84eb07efc81b2b508b79aca5bfce286b84281c2	@dudug

3071ef86da588a98d27011986cc6c4db68c8958d	@dudug

29ea96f1bf0a08be0bb18a90b7c05b5126055d0d	@dudug

ee1d926f8c0b789c076fdf456e6ad959c187af24	@dudug


I think you can drop the 2 from answer2, or call it - continue


OK


This does not actually display the current balance...


This is nice, I like it.


Thanks.


On win32 you can use GetModuleFileName with NULL as the first parameter to get the name of the executable with the whole path to it.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms683197(v=vs.85).aspx


@cjbj I have implemented support for RAW and ROWID. I'm going to submit a PR but I need to go through legal first.


These don't really need to be one line, but I am glad you have learned how to do that.


This ended up not actually being the problem anyway, so this commit (and branch) don't need to be merged into master, and I'll be deleting it shortly.


Ugh, Here, I fixed it: [@d413433f0](https://github.com/caiwan/python-dali/commit/d413433f0b43a549f33b26d9e036295422f4a7af)
my bad


49610 already has charges - 0 . This line can be removed


no worries!


`@CheckForNull` missing here?


Nope, should we get rid of jspm?


CreateProcess
https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx

or ShellExecute (from SHELL32)
https://msdn.microsoft.com/en-us/library/windows/desktop/bb762153(v=vs.85).aspx


You can probably move this check into the while loop condition


Jean-Denis,
Thank you for the suggestion. I added the thead and tbody wrappers, but it didn't make much difference that I could tell.
Ralph

      From: Jean-Denis Vauguet <notifications@github.com>
 To: rmcgarity/foundation <foundation@noreply.github.com>
Cc: Ralph McGarity <ralph_mcgarity@yahoo.com>
 Sent: Thursday, August 6, 2015 7:44 AM
 Subject: Re: [foundation] Album View Assignment Complete (bab11d5)

You should have used a
 element to wrap the headers. Here's how it works:

      …
      …
      …

      …
      …
      …

      // …

Basically, you just wrap the current content (
 tags) inside
 and
 tags, that allow you to distinguish between a table's headers and main content.—
Reply to this email directly or view it on GitHub.


I checked `libmodplug-0.8.7.tar.gz` and the EOLs are LF, of course. on my windows, git checks out windows-style and commits unix-style. maybe that's what's going on here? patch.exe is trying to apply the LF patch to protobuf, but git cloned protobuf using CRLF endings?


Testing blame.


Adding it here is not enough, the action object and store diff can still end up being white.


Regards https://github.com/OpenTreeOfLife/treemachine/issues/187, but relies upon https://github.com/OpenTreeOfLife/reference-taxonomy/issues/129.


Hmmm - this looks kind of funny - a mix of preprocessor symbol and typedef?


lol, guess we need another dot in the regex.


Pourquoi on passe sur Angular au fait ? C'est un changement super bourrin, surtout que c'est pas forcément une technologie adaptée à ce site en particulier.

>AngularJS is perfect for Single Page Applications.

Ben oui, mais nous c'est plutôt un truc statique, on veut juste que ce soit joli. Je me trompe ?


I made a mistake here, it's 4. This "4" refers to the stepness function that fann uses internally, however the user can't change them. Should we omit this information?


sdasd


I've updated the commit note to explain the overriding of `date=` and the call to `minimum_wage_data_for_date`.


I think that `#payment_date` is probably a better name, yeah. I'll make a note to change it later.


Maybe this should really be `b: ?number` instead of `b?: number`?