Awesome job Jacob! Love that you added the playToX function in there. Only thing I would add is a an `if` statement at the end of the playTo5 and playToX function that have a `console.log()` that tells us who the actual winner is (just a cool feature not a requirement). Keep up the good work!


`MondValue.UserData` throws an exception if the type is not an object. My use of `||` here was correct.


```
But .. ehm .. why? Do tertiary operators require special magic?
```

Not sure... I am actually wondering if it would still work if you skip the ```ref``` check and just always do ```&$spec($string)```. Shouldn't that also work for the function args?

Btw, another curious link to check out - it's undecidable to figure out the abstract syntax tree of a Perl program before runtime:
http://www.perlmonks.org/?node_id=663393


Good one!


ObjectDoesNotExist should work, but I don't see a case when instance.DoesNotExist won't work.

> if you want i cant make another PR.

What do you mean by that?


I added something like that and it fixed manual network search but it broke multi sim support i think:) but I'll check that settings


I really would like to integrate your improvements, could you create a pull-request to let me do that ?


can you add a comment here explaining why?
Just giving some context of what we have been through here


I don't think there is an `Author.author` field, so this will give you an error.


My main point is that your approach means that a module developer will have to do something like this

    ui.requirePrivileges(["Use App", "Use Feature"], "referenceapplication", "login")

But that means that our core modules be hardcoded against the referenceapplication module, which is wrong.


Won't this already happen in the bootstrap code that Webpack adds?


deneme


Could you completely drop function `hook(mod)' and just use attribute 'binaries'?


Either a line break or a new line would help clearing that sentence up a bit.
(So I'd add a newline before it, or let the previous line end in two spaces)

Rendered in markdown it's directly added to the previous sentence.


This commit breaks the module for me, because the version specifier `^21.0.0` does not match pre-release versions like `21.0.0-dev.1`.

```
$ npm install
(...)
npm ERR! notarget No compatible version found: strong-swagger-client@'>=21.0.0 <22.0.0'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["20.0.0","20.1.0","21.0.0-dev.1","21.0.0-dev.2"]
```


Want the what? ;)


Yes, in fact that's a left over from the previous version when I called 'author' the name of the author itself - I forgot to delete it, thanks for pointing it out.


git add 1


test


This breaks classes like `System.Action` which have zero or more generic parameters. I'm not sure what odd behavior the `TypeReference` prototype was causing here. Could you elaborate?


Pushed before I had sorted out my local commit history.  Sorted that out and forced pushed - I know, bad form, but figure the chances of anybody using this repo in the 2 minute interim were slim.  However Github reported I was one behind upstream afterwards.  Did an upstream merge just to tidy that up before I forgot.


Your approach was correct, but you did this after question 5, rendering the result different. Before question 5, `this` would have been `window`. No points taken off.


aajshajsahaasa


Please drop 'hook(mod)' function and just use 'binaries' attribute.


Oh well. This is what came to mind.


aaaaa


The correct answer would have used the `Function.call` method, i.e., `deathStar.fire.call(...)`, which lets you set the context for the function as the first argument.


Der Präfix kommt wohl von einem anderen Plugin ...


Good catch!


@cloos thanks! I've included your fix to RT too.


jk


Чтобы сократить объем кода в `Game5View` предлагаю следующее:
т.к. в классе очень много похожих листенеров, можно их все делать не анонимными, а заводить под них отдельные параметризованные классы, например под эти три радио баттона можно сделать такой класс:
```java
class ConfigRadioSelectionListener implements SelectionListener {
	ConfigRadioSelectionListener(String jsonKey, String value) {
		this.jsonKey = jsonKey;
		this.value = value;
	}

	@Override
	public void widgetSelected(SelectionEvent e) {
		object.put(jsonKey, value);
	}
	@Override
	public void widgetDefaultSelected(SelectionEvent e) {
	}

	private final String jsonKey;
	private final String value;
}
```

И все назначения листенеров будут в одну строчку:
```java
allSituations.addSelectionListener(new ConfigRadioSelectionListener("solvable", "all"));
```

Похожим образом можно сделать листенеров для всех комбобоксов и т.п., думаю, размер вьюхи сократится очень прилично.


I'm baffled as to why unused is needed here since `env` is actually used in this function.  I wonder if its an indicator of some other problem.  Do you understand what is going on here?


param description missing


there is a stand alonen lib, let me see why it was no checked in.

On Tue, Aug 11, 2015 at 1:26 PM, nimrood <notifications@github.com> wrote:

> I receive this dependency error now, and running mvn -U didn't seem to
> help:
>
> [WARNING] The POM for pentaho.weka:pdm-timeseriesforecasting-ce:jar:1.0 is
> missing, no dependency information available
>
> [ERROR] Failed to execute goal on project cointrader: Could not resolve
> dependencies for project
> org.cryptocoinpartners:cointrader:jar:0.3.0-SNAPSHOT: Failure to find
> pentaho.weka:pdm-timeseriesforecasting-ce:jar:1.0 in
> https://oss.sonatype.org/content/repositories/snapshots was cached in the
> local repository, resolution will not be reattempted until the update
> interval of sonatype-oss-snapshot has elapsed or updates are forced ->
> [Help 1]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/timolson/cointrader/commit/63c99e8351daf061b4a32b940930a77c483c9b04#commitcomment-12638853>
> .
>


Hi @yanivdror,

Congratulations on completing the course! Unfortunately you made a couple of small mistakes that you can easily fix:

1) The directory has to be the state and then the city, in your case you did the country (IL) and then the city (tel-aviv). You are missing the state/province where Tel Aviv is in. If the state/province has the same name (see this example of [New York City](https://github.com/fromzeroedu/restaurant-guide/tree/master/Restaurants/US/New_York/New_York)) then you repeat it.

2) The file name has to be "restaurants.md" -- you put "restraunts.md".

You can do those changes then commit and push and then do a new pull request.

Let me know if you have any questions!

-- Jorge (@fromzeroedu)


Or rather `os.platform() === 'win32'`
https://nodejs.org/api/os.html


Just as `fire` has access to local variables, so would another function declared in the same scope.


The atom is `(:closed? state)`, not `state` so I'm stuck with the current code.


Oh, almost nothing (just php-xml and php-xmlwriter - I don't know that last one). OK.


@tyndouf you don't need to install the components via bower because now the components is come with the core module.


checked in, should see them under repo/pentaho

On Tue, Aug 11, 2015 at 3:26 PM, Douggie melville-clarke <
douggie@melvilleclarke.com> wrote:

> there is a stand alonen lib, let me see why it was no checked in.
>
> On Tue, Aug 11, 2015 at 1:26 PM, nimrood <notifications@github.com> wrote:
>
>> I receive this dependency error now, and running mvn -U didn't seem to
>> help:
>>
>> [WARNING] The POM for pentaho.weka:pdm-timeseriesforecasting-ce:jar:1.0
>> is missing, no dependency information available
>>
>> [ERROR] Failed to execute goal on project cointrader: Could not resolve
>> dependencies for project
>> org.cryptocoinpartners:cointrader:jar:0.3.0-SNAPSHOT: Failure to find
>> pentaho.weka:pdm-timeseriesforecasting-ce:jar:1.0 in
>> https://oss.sonatype.org/content/repositories/snapshots was cached in
>> the local repository, resolution will not be reattempted until the update
>> interval of sonatype-oss-snapshot has elapsed or updates are forced ->
>> [Help 1]
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/timolson/cointrader/commit/63c99e8351daf061b4a32b940930a77c483c9b04#commitcomment-12638853>
>> .
>>
>
>


This should not be the case, because of default options added to the `sslcontext` from https://github.com/ph/logstash/commit/1d31ec2835833418e455b5379a00fcbafa6be133#diff-8721b51d2ff0bdb1a187afe20352def0R46

The original commit message originate from https://github.com/ph/logstash/commit/4825d4d44abd5a7cdbcab841295db8b78ee578c9 You will get more information. Maybe @jordansissels can give you more information about the tests he did?

This patch only revert the verification of the clients certificates from a server, the clients still need to explicitly set `VERIFY_PEER` when connection to the server to make sure they verify the authenticity of the server before transmitting anything.


out of curiosity, why did you change rowMeta.key to rowMeta?


No idea


I'm not sure about it - for me it looks like prefix + lambda body, and braces around lambda seem sufficient.


`alderaan` is also accessible from `fire`. Half credit.


Nice, this makes my todo list a bit lighter. Had plans on creating `zimme:email-helpers` package with `Accounts.addEmail`, `Accounts.removeEmail` and `Accounts.changeEmail`. :+1:


No.  This is the ID of the import file itself (so it does not vary based upon the component's primary model, for example).  Just an arbitrary string used to pass that import file ID between the initial upload page and the field mapping page.


nice :)


/ome/ so the link isn't forwarded?


can **be** read everything (**from**)


Why? This shouldn't need glib anymore.


correcting automerge


Don't these injectables shadow the bindings from `parentInjector` ?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Here's where I need your help. Not sure how to spy on `xhrBackend` and `jsonpBackend` `createConnection()`


How so? Isn't this a compiler specific feature that should have been checked by the dependency-resolver?


It does map back to the original column, yes.  When you have a validation error that originated because an import column was mapped to a field but has invalid input for that field, we highlight the specific row and cell in the spreadsheet with that invalid input.  The outer loop on line 30 gets you the row number and then the inner loop starting on line 35 is going over the data associated with that row, where $index is the column's index and $column is its content.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Your call to `fire` is fine before question 5, but does not belong in the post-Q5 object literal. No points taken off for this.

The value of `this` if you were to invoke `fire` within `deathStar` would be `window` in the browser or `global` in Node.


这里用回 spawnSync 的原因是什么 ?


Ah, you're quite right. I got confused seeing the (_) for Table, sorry about that.

For the remaining issues, would you prefer to revise the patch, or for me to merge what you've got and we fix it in followup?


Actually yes :-)
The function now looks nice and cozy:
```
sub colorizeString {
  my ($string, $alias) = @_;
  return $COLORIZED_LOGGING ? &{$color_scheme{$alias}}($string) : $string; }
```

This property is not specific to Perl, is it? It works for any language which allows ambiguous function signatures?


This question was looking for you to use `Function.call`, a method that lets you call a function with a specified value for `this`. E.g., `deathStar.fire.call(<context>, arguments);`.


Looks good to me


I still don't get why it can't just be `/auth/`?


Hey, does this mean I can make a level where pressing spin jump switched goombas to koopas or something?


also, your indents are totally messed up
also, remove the team part because there's about/teams now


yes


Yeah, my tab sizes totally messed up :/


@maxGimeno, please try to have a coherent indentation in the lines you modify.


done


I would add a comment that `replace_stdout` is implicitly tested.


这里执行顺序很重要，不能用each，我试着用eachSeries，里面东西不执行，问你你说没时间看


tested and working


I love the idea of having a _curryfied_ router: packet processing as computed operations is a very elegant solution, and provides a perfect level of abstraction...


不测试的话，最好别改别人代码


Thank you!!!


*and logs*


Is this the format we're requesting the reference in? Shouldn't it be `%d/%m/%Y`?


... because `enif_make_pid()` is actually [a macro](https://github.com/erlang/otp/blob/maint-18/erts/emulator/beam/erl_nif_api_funcs.h#L546) that doesn't use `env`.  I feel this should be fixed in Erlang instead of worked around in nifpp (if possible.)


Yes, it is not very nice, but i don't know any other solution.
enif_make_pid() is a c macro which does not use env. So after the preprocessor run, env is unused.


Oops -- I thought I checked master soz


In fact, `%d/%m/%Y` is used above, so I think this is a typo?


:clap: you rock, @meh, thanks for taking care of this!


`alderaan` and `laserSize` are both accessible within `fire`'s scope.


@askdurrant  Any reason </body> and </html> are now aligned?


Ok, let's leave it as is.


wrap into one line :P


You dont have to check this in but i will allow it for now.


At `GET` for `/tagsmanager`, redirect to page `tagsmanager`


This is why I opened #1406. But since the milestone for 3.0 is near, I'd postbone this. Okay?


good.
they run for me, but fail off course because the invoice is not there.
The last test has wrong syntax. I will have to look up the syntax for the order test, but for the purchase you can just delete that third test, or write a meaningful one.


@TeriPastorino DWMR (done with my review) `<section>Nice</section>`


`git add -p` ;-)


Fairy light branch


This looks like it might be problematic for 'just install everything all of the time'.

The challenge is that init system is a runtime option, rather than a build-time option.


I wonder if we should make this use `_calculate_prisoner_hash` from the model (and maybe make that PrisonerLocation.generate_hash(number, dob)`)?


eachSeries 如果不执行, 说明 err 被 throw 了, 然后没有 catch 这个 error 播报出来


This is still not a global variable, hence no `g_` prefix should be used.


Can we tell for sure that despite `translated_words` and `reviewed_words` are not `None` they are greater than `0`?


`laserQuantity` is a local variable in the scope our hypothetical function would be declared in. That means that, unless the function declares a local variable within itself, it will have access to `laserQuantity`.


It is Octopus 5.0.x.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (748 of 748 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.2%25-green.svg)


We cannot access `laserQuantity` from the global scope. Two-thirds credit, rounded up.


@hbun DWMR Well done here. It's a pleasure to review your work. :+1:


`sol_util_fill_buffer` returns the size returned by the last `read()` it calls. The total amount read is returned in the last parameter. It seems the rest of the code expects `n` to have the total amount.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18942/testReport/) for this commit**


Oh i always seem to forget to add the colon and not know it :P


I understand what you're trying to do here, but an sql database (static or otherwise) will make our job a hell lot convenient, and facilitate a lot more than the current functions.

Firstly, It can be made possible to edit the data through other means (eg. website/applications), and reload data in-game for real time changes/updates. This also prevents the need for a lower priority GM to have shell access to reload or update the database. As 4144 mentioned, it can make it possible to use the same db for more than just one map server, a feature that eA was made to support from way back I believe.

Secondly, Indexing? readability and ease of use? we can easily create update statements for users to keep updated, this is a lot more convenient in cases where your custom database edits conflict with the head revision specially considering the size of the item database.

Thirdly, .conf/txt files require some extra code specially to help parse the file as opposed to sql which uses straight forward functions.

I personally feel that we should use sql as a primary method to load and store the database, let alone removing it's support. Ultimately making hercules more user-friendly. Hercules or any other emulator should give priority to facilitate these features and options in my honest opinion, because at the end of the day, guess who's using the software.


Still badly formatted.


The wording of this question has misled more than one student. The variables are declared and assigned outside, and they are accessible within `fire`. "Defined" is a little bit of a fuzzy term here, potentially meaning either "assigned" or "accessible".


Looks good.


So i looked it up, in orders the line would be

      expect_any_instance_of(OfficeHelper).to receive(:best_euros)

And this is meant to check that the number is not just written, but uses the helper function best_euros. (which i redefine in another project to change the output style)

You can read about what the expect... does here: https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/any-instance


@christianalfoni No I am not, I will try that now, thank you! So running synchronously is good when it should update the view quickly?


aaaa


TIL this commit broke coveralls' coverage reports


ack


This change feels like if it belongs to another commit.


@arnova You understood exactly, but for the "if [ $found -eq 0..." line your reference, why use EXTERNAL_NET if manually defined but not if autodetected ?  Though if $found -eq 0 then chances are EXTERNAL_NET will not be autodetected.  It is probably OK because of the logic, just something that caught my eye.


The context will be whatever context `deathStar` was called from. Since we're calling it from the global scope in a browser, `this` inside `fire` will equal `window`.

To test this, I encourage you to run this code in your browser console:

    this === window; // true
    (function() {
        (function() {
            console.log("Context of inner function is `window`: ", this === window);
        })();
    })();


What does this name mean?


very nice.


I think this is fine. Though from a sanity perspective, I like the software verifying that these system tables are present. We'll hold out hope that they fix this JDBC driver bug before we need to release this :-)


The `socket_read` have this limit of attempts, but `sol_util_fill_buffer` doesn't.

If that's intended, please comment why the limit of attempts is not needed anymore on the commit message.


A lot of devices will not be detected after this change


WindowComplexManager_Speedup (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1790 of 1790 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good try; this shows that you understand how context is set on functions called as methods of an object.

This question was calling (ha, ha) for your to use `Function.call` to explicitly set a context for the function invocation. Solution: `deathStar.fire.call(alderaan);`


ne du hattest eine Variable für "all" oder ähnliches zur verfügung gestellt die habe ich durch Text ersetzt


@ceolin, do you remember why the attempt was used and if it is still necessary?


It might be an interesting idea to have this as a `@property` rather than a method.


s/compositing/composing/


@jedk1 Did you test AirSweep after adding this remove() call? By the looks of it, now if any stream hits a block then the entire ability is removed, which is not ideal, rather the streams should still be removed independently.


What is `Upload` referencing here? Or is that a factory/service that needs to be created still?


but what will @Felbourn think of us now


ack


Indent! It will make your life and others' easier.


lol


These lines are endless, can we please wordwrap?


This version of `enif_make_pid` in otp seems to fix the problem:
```
#  define enif_make_pid(ENV, PID) ((void)(ENV),(const ERL_NIF_TERM)((PID)->pid))
```
I'll merge your PR without the `unused` above and then start a PR for OTP to fix the `enif_make_pid` macro.

Thanks for the cleanups. :)


`alderaan`, a global variable, is also accessible inside `fire`. Global variables are accessible everywhere. That's their defining feature and what makes them unsafe.


Alright, it must be something with my maven settings, since the library is available here:
https://repository.jboss.org/nexus/content/groups/public-jboss/org/jboss/arquillian/arquillian-bom/


I hope he won't take it too personally.


Prompt users to setup 2-step verification:

* Allow a grace period to minimise friction – setting up should be rushed, which it would be if a user needed to complete an urgent task (eg publish something)
* Advise how long it will take
* Would be accompanied by an email suggesting users setup 2-step

![screen shot 2015-08-11 at 15 57 37](https://cloud.githubusercontent.com/assets/319055/9200832/b0402a22-4041-11e5-9de1-90bc6187c26f.png)


Implements #8


That's correct. That logged object is actually `window`, our global object in the browser.


Needs release note


It's provided by the ng-file-upload module that was added in the previous commit.


remove this once functions are put into `main`


Hi Roman
I think it basically makes sense. But since you completely circumvent the existing attitude controllers, you have no "control modes" during the transitions anymore. So you'd need to implement those in the VTOL transition controller.

Let me explain what I mean with the following example:
- flying the vtol in MC POSCTL
- transitioning
- flying the vtol in FW POSCTL

The goal during transition would be to hold altitude (at least, heading would also be needed eventually). Would you implement that in this transition logic? I guess my naive question would be if the attitude controllers can be made more configurable to support the transition and still retain some level of control (without adding any vtol dependencies)


In the end, I think leaving a simple `NSLog` statement in is certainly a mistake no matter what path is taken.  At an absolute minimum, it should be wrapped in `#if DEBUG` (http://stackoverflow.com/q/28620494/2792531).  But ultimately, lots of people use some sort of logging library, and this is an ugly default `NSLog` statement that we've stuck in here.  This even goes against what we'd advice using in our own projects (where we'd prefer seeing using whatever logging library we're using).


when gathering data from the ContourNextLink (no ContourNextUSB, no ContourNext) we have some particular cases when the thresholds are not present in the header, it seems to be a special "bug" in that device, we have no specific documentation for it, but the other ContourNext documentation specifies the default thresholds values as 20/600, we are added this change as a advancement for the ContourNextLink implementation because this device also uses the same driver structure.


`alderaan` does not have a `deathStar` property, so you will get an error from trying to access the `fire` property of `undefined`.

The correct answer was to use `Function.call` to set the context of the invocation: `deathStar.fire.call(alderaan);`


Good question. It isn't clear from the documentation, but FileChannel.map() has platform- specific code in it to duplicate the FileDescriptor and keep that around on Windows only. So this code should actually work on both platforms (despite my comment).

Sent from my iPhone

> On Aug 10, 2015, at 23:49, ARUNACHALAM THIRUPATHI <notifications@github.com> wrote:
>
> We have some open source folks, using Voldemort on Windows servers. Can this go inside the system specific block or wrap it around the system specific block if possible ?
>
> —
> Reply to this email directly or view it on GitHub.
>


I would like to propose for the addition of the citation style International Journal of Food Science and Technology


Good stuff Matt! Loved the use of the while loop and the clean coding. Your program works great and even gives good feedback in the console displaying which option each player chose.

As a styling pointer, the only thing I would possibly change is saving the values of the winner in the `getWinner` function to a variable called `winner` and then use a single
```
return winner
```
It does the same thing that your code does and doesn't actually increase efficiency at all, but it ends up making it more readable.

Great Job, keep at it!


When I grep'ed for KE_KEY in the kernel sources there were about 50% of occurrences supporting your version and another 50% supporting mine. But I'm taking your suggestion here anyway :-)


@dpsoft, Thanks. I used `added_spm_backend` branch to contribute PR. Fixed years here - https://github.com/sematext/Kamon/commit/a96ef05d26b7bf2e3b2e7a1fd370644f8fb6350f (updated in PR as well).


ack


I have a an other error message wxhen performing the "php artisan module:install --no-update" command line. Here the message error I got:

"Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists."

My Github Public key is working when I try to clone something else, but not when executing your command line.

Thanks for your support :+1:
Linda.


I'd certainly prefer the early return here.  If we take the early return out, we have to throw in a `break` anyway.

Ultimately, I don't really ever see a problem with early returns.  And the only time they're really problematic is generally when your method is doing too much and needs to be refactored anyway.


sequentially, not a times table (but nice, although it also isn't grided)


Smart =)


new parameters are not mentioned in the WS description


Yes, I've checked and there were no errors.
There was only one warning asking if I should updated the MAINTAINERS file since a new file was created (asus-wrc.c), but I think that's not the case here.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1270 of 1270 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


\o/


good


@AndreasAntener The attitude controllers are not circumvented at all! The only thing that is changed is the guy who created the attitude setpoint. E.g for tailsitters the transition is achieved by ramping down the pitch angle setpoint. But still the same mc attitude controller would be used to track that setpoint.
It's more about the position controllers which need to be deactivated.


I have reverted this commit in ded3322, newer strong-swagger-js tarballs seem to work well.


@AndreasAntener And by the way, Hi Andreas :-)


It seems more about what should be the **default** (mysql-like) database for packages to depend on (e.g. qt is rather deep in dependency graphs). Fedora gives [some reasons](https://fedoraproject.org/wiki/Features/ReplaceMySQLwithMariaDB#Detailed_Description). On the whole it seems distros have [switched to mariadb a lot](https://mariadb.com/kb/en/mariadb/distributions-which-include-mariadb/) – from the popular ones I see all except Debian-based and Gentoo.


you should check with @ganncamp the description of group name parameter, I'm not sure about "whatever the case"


Sorry, I meant to write "position" controllers, updated in my comment ;)


It's not merged into this branch yet, but the nullability annotation branch marks the image argument as non-nil.  New images would still be a problem though.


:D


almost:
```python
>>> print len("comprehensivenesses")
19
```


Ah, glad you like it!

One thing I'm not sure about is whether there is a need to use these functions on the server for other users besides the current user. Currently, they are only available on the client, and there it makes sense to restrict them (similar to `changePassword` for instance).

Also, `addEmail` sets verified to false, but there may be scenarios where you know an email is verified (if you get it from an external service for instance).

I'm also thinking of adding a `findUser` to expose the case insensitive find by username/email.


what happens if both groupId and projectId are provided in the request?


Perhaps I should change the code to check for the driver queue size being over a certain limit and only set busy in that case?

I also think that for portability I need to change the code to use `ERRNO_BLOCK` rather than `EAGAIN`, since some platforms will generate `EWOULDBLOCK` errors rather than `EAGAIN`.

As for non-blocking, I was wondering about that. If where this change currently handles `EAGAIN`, instead of calling `driver_async` we first undo the actions of the `set_blocking_data()` function and then enable `driver_select` for the fd, that should do it, right?


whats that


for the purpose of this exercise let's practice passing values w/in and b/n functions


This would fix #32


project_id and project_key are not described in the description of the WS


It might be worth while to take all of the methods that have been thrown into Thundercats for debugging/testing purposes and make a separate library for them.


@AndreasAntener Ok, no problem. Your point is a good one, we need to think about it.


This solution can be accepted. Since I have several commits in my work desktop, a conflict is occured. So, this commitment is a little weird..


what do you mean ? What should I add ?


Yea, I agree with that.


most methods of `PermissionWsCommons` take a `DbSession` as a parameter, you should be consistent and keep that behavior for all methods
in addition, I think opening and closing the session should not be the responsibility of `PermissionWsCommons` so you should keep the `DbSession` argument


(My Phython Project)


how they are supposed to be used, the fact they are optional and exclusive (if I got it right)


ok, I replace with (case insensitive)


anytime you introduce coredata into a library - you really need to ensure that you can recover from this state.   forcing an application to terminate because your cache couldn't initialize is pretty bad.    I think it's much better to delete your store and re-initialize the storeCoordintator


snapshot? like git_config_snapshot?


Maybe something like `\group_begin: \exp_args:NNNx \group_end:` (`\exp_args:NNNx` is undefined actually) or

    \group_begin:
    \use:x
      {
        \group_end:
        ...
      }

is necessary here to avoid making `\relax` by `exp_not:c`.


the project permission for the given group is removed


1: M111 unrecognized component name: legacy


1: D400 First line should end with a period (not 'I')
4: L102 copyright year is outdated, expected 2015 but got 2014
26:1: I100 Imports statements are in the wrong order. from tempfile should be before import pkg_resources
26:1: I201 Missing newline before sections or imports.
30:1: I100 Imports statements are in the wrong order. from invenio.legacy.webpage should be before from invenio.legacy.webuser
31:1: I101 Imported names are in the wrong order. Should be CFG_ETCDIR, CFG_TMPSHAREDDIR
31:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.webpage
31:1: F401 'CFG_ETCDIR' imported but unused
32:1: I101 Imported names are in the wrong order. Should be extract_references_from_file_xml, extract_references_from_string_xml, extract_references_from_url_xml
33:36: E126 continuation line over-indented for hanging indent
37:1: I100 Imports statements are in the wrong order. import invenio.legacy.template should be before from invenio_formatter.engine
41: D400 First line should end with a period (not 'n')
50: D400 First line should end with a period (not 'h')
53:12: E127 continuation line over-indented for visual indent
54:12: E127 continuation line over-indented for visual indent
57: D209 Multi-line docstring closing quotes should be on a separate line
57: D400 First line should end with a period (not 'g')
77: D400 First line should end with a period (not 'v')
86: D203 1 blank line required before class docstring (found 0)
86: D204 1 blank line required after class docstring (found 0)
86: D400 First line should end with a period (not 'I')
94: D400 First line should end with a period (not 'f')
103: D400 First line should end with a period (not 'l')
117: D400 First line should end with a period (not 't')
129: D203 1 blank line required before class docstring (found 0)
129: D204 1 blank line required after class docstring (found 0)
129: D400 First line should end with a period (not 'I')
132:9: E128 continuation line under-indented for visual indent
138: D400 First line should end with a period (not 's')
148: D401 First line should be in imperative mood ('Refrence', not 'Refrences')
148: D209 Multi-line docstring closing quotes should be on a separate line
148: D400 First line should end with a period (not 'e')
177:44: E128 continuation line under-indented for visual indent


1: D400 First line should end with a period (not 's')
22:1: E402 module level import not at top of file
23:1: I100 Imports statements are in the wrong order. import os should be before from six.moves
23:1: I201 Missing newline before sections or imports.
23:1: E402 module level import not at top of file
24:1: E402 module level import not at top of file
25:1: E402 module level import not at top of file
26:1: I100 Imports statements are in the wrong order. import tempfile should be before import time
26:1: E402 module level import not at top of file
27:1: I100 Imports statements are in the wrong order. import sys should be before import tempfile
27:1: E402 module level import not at top of file
28:1: I100 Imports statements are in the wrong order. import datetime should be before import sys
28:1: E402 module level import not at top of file
33:1: I101 Imported names are in the wrong order. Should be abort, url_for
33:1: E402 module level import not at top of file
34:1: I201 Missing newline before sections or imports.
34:1: E402 module level import not at top of file
35:1: I201 Missing newline before sections or imports.
35:1: E402 module level import not at top of file
36:1: I201 Missing newline before sections or imports.
36:1: E402 module level import not at top of file
38:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
38:1: E402 module level import not at top of file
39:6: E126 continuation line over-indented for hanging indent
64:1: I100 Imports statements are in the wrong order. from invenio.base.globals should be before from invenio.config
64:1: F401 'cfg' imported but unused
64:1: E402 module level import not at top of file
65:1: E402 module level import not at top of file
66:1: E402 module level import not at top of file
67:1: I101 Imported names are in the wrong order. Should be datetime_format, run_sql, wash_table_column_name
67:1: E402 module level import not at top of file
69:1: E402 module level import not at top of file
70:1: I101 Imported names are in the wrong order. Should be get_record, record_exists, search_unit_in_bibxxx
70:1: E402 module level import not at top of file
72:1: E402 module level import not at top of file
73:1: I100 Imports statements are in the wrong order. from invenio.modules.search.api should be before from invenio_formatter
73:1: I201 Missing newline before sections or imports.
73:1: E402 module level import not at top of file
74:1: E402 module level import not at top of file
75:1: I101 Imported names are in the wrong order. Should be EscapedXMLString, X
75:1: E402 module level import not at top of file
78:25: E203 whitespace before ':'
79:25: E203 whitespace before ':'
80:25: E203 whitespace before ':'
85:25: E203 whitespace before ':'
89:25: E203 whitespace before ':'
107: D205 1 blank line required between summary line and description (found 0)
119: D400 First line should end with a period (not 'r')
119: D200 One-line docstring should fit on one line with quotes (found 3)
135:9: E266 too many leading '#' for block comment
136:9: E266 too many leading '#' for block comment
147:1: E302 expected 2 blank lines, found 1
147: D202 No blank lines allowed after function docstring (found 1)
147: D400 First line should end with a period (not 'r')
147: D200 One-line docstring should fit on one line with quotes (found 3)
169:1: E302 expected 2 blank lines, found 1
169: D200 One-line docstring should fit on one line with quotes (found 3)
179:1: E302 expected 2 blank lines, found 1
179: D401 First line should be in imperative mood ('Get', not 'Gets')
179: D202 No blank lines allowed after function docstring (found 1)
179: D200 One-line docstring should fit on one line with quotes (found 3)
187:9: E221 multiple spaces before operator
192:1: E302 expected 2 blank lines, found 1
192: D401 First line should be in imperative mood ('Return', not 'Returns')
192: D205 1 blank line required between summary line and description (found 0)
202:1: E302 expected 2 blank lines, found 1
202: D400 First line should end with a period (not 'e')
202: D205 1 blank line required between summary line and description (found 0)
212:1: E302 expected 2 blank lines, found 1
212: D400 First line should end with a period (not 'e')
212: D205 1 blank line required between summary line and description (found 0)
222:1: E302 expected 2 blank lines, found 1
222: D209 Multi-line docstring closing quotes should be on a separate line
222: D202 No blank lines allowed after function docstring (found 1)
222: D400 First line should end with a period (not 'r')
222: D205 1 blank line required between summary line and description (found 0)
231:1: E302 expected 2 blank lines, found 1
231: D400 First line should end with a period (not 'e')
231: D205 1 blank line required between summary line and description (found 0)
247:1: E302 expected 2 blank lines, found 1
247: D400 First line should end with a period (not 't')
247: D205 1 blank line required between summary line and description (found 0)
279:85: E261 at least two spaces before inline comment
279:86: E262 inline comment should start with '# '
284:1: E302 expected 2 blank lines, found 1
284: D200 One-line docstring should fit on one line with quotes (found 3)
289:5: E266 too many leading '#' for block comment
290:5: E266 too many leading '#' for block comment
297:9: E116 unexpected indentation (comment)
298:13: E116 unexpected indentation (comment)
299:17: E116 unexpected indentation (comment)
300:13: E116 unexpected indentation (comment)
301:17: E116 unexpected indentation (comment)
302:13: E116 unexpected indentation (comment)
303:17: E116 unexpected indentation (comment)
304:13: E116 unexpected indentation (comment)
305:17: E116 unexpected indentation (comment)
306:13: E116 unexpected indentation (comment)
307:17: E116 unexpected indentation (comment)
309:9: E116 unexpected indentation (comment)
310:13: E116 unexpected indentation (comment)
311:17: E116 unexpected indentation (comment)
312:13: E116 unexpected indentation (comment)
313:17: E116 unexpected indentation (comment)
314:13: E116 unexpected indentation (comment)
315:17: E116 unexpected indentation (comment)
317:1: E302 expected 2 blank lines, found 1
317: D401 First line should be in imperative mood ('Print', not 'Prints')
317: D202 No blank lines allowed after function docstring (found 1)
334:37: E713 test for membership should be 'not in'
335:13: E266 too many leading '#' for block comment
336:13: E266 too many leading '#' for block comment
350:5: E266 too many leading '#' for block comment
397:1: E302 expected 2 blank lines, found 1
397: D401 First line should be in imperative mood ('Generate', not 'Generates')
397: D202 No blank lines allowed after function docstring (found 1)
416:1: E302 expected 2 blank lines, found 1
416: D401 First line should be in imperative mood ('Generate', not 'Generates')
416: D202 No blank lines allowed after function docstring (found 1)
441:30: E261 at least two spaces before inline comment
447:9: E266 too many leading '#' for block comment
448:9: E266 too many leading '#' for block comment
471:9: E266 too many leading '#' for block comment
476:1: E302 expected 2 blank lines, found 1
476: D401 First line should be in imperative mood ('List', not 'Lists')
476: D202 No blank lines allowed after function docstring (found 1)
476: D200 One-line docstring should fit on one line with quotes (found 3)
497: D401 First line should be in imperative mood ('Return', not 'Returns')
497: D202 No blank lines allowed after function docstring (found 1)
513:12: E127 continuation line over-indented for visual indent
522:1: E303 too many blank lines (3)
522: D401 First line should be in imperative mood ('Generate', not 'Generates')
522: D202 No blank lines allowed after function docstring (found 1)
522: D208 Docstring is over-indented
546:17: E128 continuation line under-indented for visual indent
547:17: E128 continuation line under-indented for visual indent
548:17: E128 continuation line under-indented for visual indent
549:17: E128 continuation line under-indented for visual indent
550:17: E128 continuation line under-indented for visual indent
566:1: E302 expected 2 blank lines, found 1
566: D200 One-line docstring should fit on one line with quotes (found 3)
572:1: E302 expected 2 blank lines, found 1
572: D200 One-line docstring should fit on one line with quotes (found 3)
580:1: E302 expected 2 blank lines, found 1
580: D401 First line should be in imperative mood ('Generate', not 'Generates')
585:1: E302 expected 2 blank lines, found 1
585: D401 First line should be in imperative mood ('Generate', not 'Generates')
589:1: E302 expected 2 blank lines, found 1
589: D401 First line should be in imperative mood ('Return', not 'Returns')
589: D209 Multi-line docstring closing quotes should be on a separate line
589: D400 First line should end with a period (not 'd')
589: D205 1 blank line required between summary line and description (found 0)
604: D401 First line should be in imperative mood ('Return', not 'Returns')
604: D400 First line should end with a period (not 'C')
604: D200 One-line docstring should fit on one line with quotes (found 3)
618: D210 No whitespaces allowed surrounding docstring text
632:29: E261 at least two spaces before inline comment
632:30: E262 inline comment should start with '# '
639:31: E261 at least two spaces before inline comment
639:32: E262 inline comment should start with '# '
650:1: E302 expected 2 blank lines, found 1
650: D401 First line should be in imperative mood ('Return', not 'Returns')
650: D200 One-line docstring should fit on one line with quotes (found 3)
671:1: E302 expected 2 blank lines, found 1
671: D401 First line should be in imperative mood ('Generate', not 'Generates')
677:1: E302 expected 2 blank lines, found 1
677: D400 First line should end with a period (not 'e')
677: D205 1 blank line required between summary line and description (found 0)
690:1: E302 expected 2 blank lines, found 1
690: D200 One-line docstring should fit on one line with quotes (found 3)
710: D200 One-line docstring should fit on one line with quotes (found 3)
725:31: F841 local variable 'e' is assigned to but never used
729:1: E302 expected 2 blank lines, found 1
729: D200 One-line docstring should fit on one line with quotes (found 3)
739:5: E266 too many leading '#' for block comment
744:5: E266 too many leading '#' for block comment
755:9: E266 too many leading '#' for block comment
759:9: E266 too many leading '#' for block comment
764:1: E302 expected 2 blank lines, found 1
764: D400 First line should end with a period (not 's')
764: D205 1 blank line required between summary line and description (found 0)
771:5: E266 too many leading '#' for block comment
776:39: E261 at least two spaces before inline comment
776:40: E262 inline comment should start with '# '
782:5: E266 too many leading '#' for block comment
786:5: E266 too many leading '#' for block comment
788:12: E713 test for membership should be 'not in'
789:16: E126 continuation line over-indented for hanging indent
792:18: E261 at least two spaces before inline comment
794:5: E266 too many leading '#' for block comment
796:12: E127 continuation line over-indented for visual indent
803:5: E266 too many leading '#' for block comment
805:12: E127 continuation line over-indented for visual indent
813:12: E127 continuation line over-indented for visual indent
826:12: E127 continuation line over-indented for visual indent
827:12: E127 continuation line over-indented for visual indent
831:5: E266 too many leading '#' for block comment
833:12: E127 continuation line over-indented for visual indent
834:36: E261 at least two spaces before inline comment
838:5: E266 too many leading '#' for block comment
840:12: E127 continuation line over-indented for visual indent
844:12: E127 continuation line over-indented for visual indent
847:5: E266 too many leading '#' for block comment
849:12: E127 continuation line over-indented for visual indent
852:5: E266 too many leading '#' for block comment
854:12: E127 continuation line over-indented for visual indent
859:1: E302 expected 2 blank lines, found 1
859: D401 First line should be in imperative mood ('Run', not 'Runs')
859: D400 First line should end with a period (not 'k')
859: D200 One-line docstring should fit on one line with quotes (found 3)
865:90: E203 whitespace before ':'
865:91: E231 missing whitespace after ':'


38:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
45:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 45
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 45
45:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 45
45:1: F999 redefinition of unused 'CFG_LOGDIR' from line 45
45:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 45
45:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
45:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
45:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
45:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
45:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
45:1: F401 'CFG_OAI_ID_FIELD' imported but unused
45:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
45:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
45:1: F401 'CFG_SITE_RECORD' imported but unused
45:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
45:1: F401 'CFG_INSPIRE_SITE' imported but unused
45:1: F401 'CFG_BASE_URL' imported but unused
45:1: F401 'CFG_LOGDIR' imported but unused
45:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
45:1: F401 'CFG_BIBSORT_ENABLED' imported but unused
45:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
45:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
45:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
45:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
45:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
45:1: E402 module level import not at top of file
46:6: E126 continuation line over-indented for hanging indent
80:1: E402 module level import not at top of file
81:1: F401 'get_most_popular_field_values' imported but unused
81:1: E402 module level import not at top of file
82:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
82:1: I100 Imports statements are in the wrong order. from invenio.modules.search.errors should be before from invenio.modules.search.utils
82:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
82:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
82:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
82:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
82:1: E402 module level import not at top of file
83:6: E126 continuation line over-indented for hanging indent
87:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.modules.search.errors
87:1: F401 'get_fieldvalues_alephseq_like' imported but unused
87:1: E402 module level import not at top of file
89:1: E402 module level import not at top of file
90:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
90:1: I201 Missing newline before sections or imports.
90:1: F401 'record_xml_output' imported but unused
90:1: F401 'create_record' imported but unused
90:1: E402 module level import not at top of file
91:1: F401 'DataCacher' imported but unused
91:1: E402 module level import not at top of file
92:1: E402 module level import not at top of file
93:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS, VIEWRESTRCOLL
93:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
93:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
93:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
93:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
93:1: E402 module level import not at top of file
99:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio.modules.access.local_config
99:1: F401 'intbitset' imported but unused
99:1: E402 module level import not at top of file
100:1: I201 Missing newline before sections or imports.
100:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
100:1: E402 module level import not at top of file
101:1: F401 'deserialize_via_marshal' imported but unused
101:1: E402 module level import not at top of file
102:1: I100 Imports statements are in the wrong order. from invenio.modules.access.engine should be before from invenio.utils.serializers
102:1: F401 'acc_authorize_action' imported but unused
102:1: E402 module level import not at top of file
103:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.modules.access.engine
103:1: F401 'register_exception' imported but unused
103:1: E402 module level import not at top of file
104:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
104:1: F401 'encode_for_xml' imported but unused
104:1: F401 'wash_for_utf8' imported but unused
104:1: F401 'strip_accents' imported but unused
104:1: E402 module level import not at top of file
105:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
105:1: F401 'bibrecord' imported but unused
105:1: E402 module level import not at top of file
107:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
107:1: F401 'wash_table_column_name' imported but unused
107:1: F401 'get_table_update_time' imported but unused
107:1: F401 'run_sql_with_limit' imported but unused
107:1: E402 module level import not at top of file
109:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
109:1: F401 'collect_user_info' imported but unused
109:1: E402 module level import not at top of file
110:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webuser
110:1: E402 module level import not at top of file
112:1: F401 'apache' imported but unused
112:1: E402 module level import not at top of file
114:1: F401 'DatabaseError' imported but unused
114:1: E402 module level import not at top of file
119:22: E203 whitespace before ':'
119:14: E225 missing whitespace around operator
120:24: E203 whitespace before ':'
121:24: E203 whitespace before ':'
122:28: E203 whitespace before ':'
123:30: E203 whitespace before ':'
124:24: E203 whitespace before ':'
125:23: E203 whitespace before ':'
126:29: E203 whitespace before ':'
127:26: E203 whitespace before ':'
128:33: E203 whitespace before ':'
129:30: E203 whitespace before ':'
130:30: E203 whitespace before ':'
131:30: E203 whitespace before ':'
132:30: E203 whitespace before ':'
133:30: E203 whitespace before ':'
134:30: E203 whitespace before ':'
135:41: E703 statement ends with a semicolon
137:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from sqlalchemy.exc
137:1: F401 'collection_restricted_p' imported but unused
137:1: E402 module level import not at top of file
138:1: F401 'restricted_collection_cache' imported but unused
138:1: E402 module level import not at top of file
139:1: F401 'get_permitted_restricted_collections' imported but unused
139:1: E402 module level import not at top of file
142:1: F401 'check_user_can_view_record' imported but unused
142:1: E402 module level import not at top of file
144:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio_records.access
144:1: F401 'get_coll_i18nname' imported but unused
144:1: E402 module level import not at top of file
145:1: F401 'get_field_i18nname' imported but unused
145:1: E402 module level import not at top of file
148: D401 First line should be in imperative mood ('Create', not 'Creates')
148: D400 First line should end with a period (not 'n')
148: D205 1 blank line required between summary line and description (found 0)
155:1: F403 'from invenio.modules.search.washers import *' used; unable to detect undefined names
155:1: E402 module level import not at top of file
158: D401 First line should be in imperative mood ('Return', not 'Returns')
158: D300 Use """triple double quotes""" (found '-quotes)
179:1: I100 Imports statements are in the wrong order. from invenio.modules.collections.cache should be before from invenio.modules.search.washers
179:1: F401 'get_collection_allchildren' imported but unused
179:1: E402 module level import not at top of file
182: D400 First line should end with a period (not 'o')
182: D205 1 blank line required between summary line and description (found 0)
182: D208 Docstring is over-indented
227:1: F403 'from invenio.modules.search.searchext.engines.native import *' used; unable to detect undefined names
227:1: E402 module level import not at top of file
230: D209 Multi-line docstring closing quotes should be on a separate line
230: D400 First line should end with a period (not 'y')
230: D205 1 blank line required between summary line and description (found 0)
230: D208 Docstring is over-indented
243:38: E203 whitespace before ','
274:1: E302 expected 2 blank lines, found 0
274: D209 Multi-line docstring closing quotes should be on a separate line
274: D400 First line should end with a period (not 'g')
274: D205 1 blank line required between summary line and description (found 0)
274: D208 Docstring is over-indented
303: D209 Multi-line docstring closing quotes should be on a separate line
303: D205 1 blank line required between summary line and description (found 0)
316:1: E303 too many blank lines (3)
316: D103 Missing docstring in public function
326: D401 First line should be in imperative mood ('calculate', not 'calculates')
326: D209 Multi-line docstring closing quotes should be on a separate line
326: D202 No blank lines allowed after function docstring (found 1)
326: D400 First line should end with a period (not 'e')
326: D205 1 blank line required between summary line and description (found 0)
337:20: E261 at least two spaces before inline comment
341:17: E261 at least two spaces before inline comment
368:1: E302 expected 2 blank lines, found 1
386: D210 No whitespaces allowed surrounding docstring text
386: D400 First line should end with a period (not 'n')
392:25: E261 at least two spaces before inline comment
393:13: E222 multiple spaces after operator
416:10: E261 at least two spaces before inline comment
433:1: E266 too many leading '#' for block comment
435: D103 Missing docstring in public function
436:25: E128 continuation line under-indented for visual indent
437:25: E128 continuation line under-indented for visual indent
438:25: E128 continuation line under-indented for visual indent
439:25: E128 continuation line under-indented for visual indent
456: D401 First line should be in imperative mood ('Set', not 'Sets')
456: D202 No blank lines allowed after function docstring (found 1)
456: D400 First line should end with a period (not 'l')
456: D200 One-line docstring should fit on one line with quotes (found 3)
457:23: E128 continuation line under-indented for visual indent
458:23: E128 continuation line under-indented for visual indent
459:23: E128 continuation line under-indented for visual indent
460:23: E128 continuation line under-indented for visual indent
461:23: E128 continuation line under-indented for visual indent
499:9: B901 blind except: statement