 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_snapshot/test_backup_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|suite_setup|1|0|0|0
local_ps_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_ps_virtual_router_test|__account/test_vm_ops_by_normal_account__|0|1|0|0
local_ps_virtual_router_test|__account/test_multi_accounts_vm_ops__|0|1|0|0
local_ps_virtual_router_test|__novlan/test_create_vm__|0|1|0|0
local_ps_virtual_router_test|__novlan/test_reboot_vm__|0|1|0|0
local_ps_virtual_router_test|__novlan/test_ping_vms__|0|1|0|0
local_ps_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_create_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_reboot_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_snat_create__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_dnat_reboot__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_ping_vms__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_create_3vms__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_start_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_3l3s_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_remove_dhcp__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_2l3_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vms_with_limited_ips__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.0__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.1__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_start_vms_simultaneously__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_static_ip_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_crt_vm_with_hostname__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_attach_nic__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_attach_nic_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__vlan/test_attach_nic_reboot_vm__|0|1|0|0
local_ps_virtual_router_test|__volume/test_add_volume__|0|1|0|0
local_ps_virtual_router_test|__volume/test_add_m_vols__|0|1|0|0
local_ps_virtual_router_test|__volume/test_add_volume_vr__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_volume__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_2_volumes__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_24_volumes__|0|1|0|0
local_ps_virtual_router_test|__volume/test_volume_ops_on_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__volume/test_crt_vm_from_dvt__|0|1|0|0
local_ps_virtual_router_test|__template_image/test_crt_temp_image__|0|1|0|0
local_ps_virtual_router_test|__template_image/test_del_temp_image__|0|1|0|0
local_ps_virtual_router_test|__sg/test_ingress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_egress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_icmp__|0|1|0|0
local_ps_virtual_router_test|__sg/test_udp__|0|1|0|0
local_ps_virtual_router_test|__sg/test_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__sg/test_vm_ops__|0|1|0|0
local_ps_virtual_router_test|__sg/test_2vm_egress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_2vm_ingress__|0|1|0|0
local_ps_virtual_router_test|__sg/test_4vm_complx__|0|1|0|0
local_ps_virtual_router_test|__sg/test_detach_l3__|0|1|0|0
local_ps_virtual_router_test|__pf/test_2l3s_pfs__|0|1|0|0
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|__pf/test_delete_pf_after_destroy_vm__|0|1|0|0
local_ps_virtual_router_test|pf/test_del_vip_before_add_pf_to_vm|1|0|0|0
local_ps_virtual_router_test|__pf/test_multi_pfs_sg_tcp__|0|1|0|0
local_ps_virtual_router_test|__pf/test_multi_rules__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pf_after_destroy_vm__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pf_sg_tcp__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pfs_tcp_udp_same_vip_ports__|0|1|0|0
local_ps_virtual_router_test|__pf/test_pfs_tcp_with_same_vip__|0|1|0|0
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|__eip/test_2_eips__|0|1|0|0
local_ps_virtual_router_test|__eip/test_2l3s_eip_pf__|0|1|0|0
local_ps_virtual_router_test|__eip/test_2l3s_eips__|0|1|0|0
local_ps_virtual_router_test|__eip/test_attach_eip__|0|1|0|0
local_ps_virtual_router_test|__eip/test_create_eip_vm__|0|1|0|0
local_ps_virtual_router_test|__eip/test_del_vip_before_add_eip_to_vm__|0|1|0|0
local_ps_virtual_router_test|__eip/test_eip_sg_tcp__|0|1|0|0
local_ps_virtual_router_test|__eip/test_pf_eip_attach__|0|1|0|0
local_ps_virtual_router_test|__eip/test_vm_ops__|0|1|0|0
local_ps_virtual_router_test|eip/test_vm_ops2|1|0|0|0
local_ps_virtual_router_test|__snapshot/test_backup_snapshot__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_create_snapshot__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_create_sp_after_delete__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_create_image_by_snapshot__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_for_both_root_...__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm2__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm3__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_delete_snapshot_on_ru...__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_in_live_vm__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_crt_sp_from_vol_crt_f...__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_change_max_sp_depth__|0|1|0|0
local_ps_virtual_router_test|__snapshot/test_change_max_sp_depth_l...__|0|1|0|0
local_ps_virtual_router_test|__regression/delete_sg_with_2_attache...__|0|1|0|0
local_ps_virtual_router_test|__regression/rm_nic_sg_on_stopped_vm__|0|1|0|0
local_ps_virtual_router_test|__regression/test_data_volume_with_vm...__|0|1|0|0
local_ps_virtual_router_test|__vr/test_ping_vms_reboot_vr__|0|1|0|0
local_ps_virtual_router_test|__vr/test_reconnect_vr__|0|1|0|0
local_ps_virtual_router_test|__vr/test_start_vrs_simultaneously__|0|1|0|0
local_ps_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_ps_virtual_router_test|suite_teardown|1|0|0|0
local_nfs_virtual_router_test|suite_setup|1|0|0|0
local_nfs_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_nfs_virtual_router_test|__account/test_vm_ops_by_normal_account__|0|1|0|0
local_nfs_virtual_router_test|__account/test_multi_accounts_vm_ops__|0|1|0|0
local_nfs_virtual_router_test|__novlan/test_create_vm__|0|1|0|0
local_nfs_virtual_router_test|__novlan/test_reboot_vm__|0|1|0|0
local_nfs_virtual_router_test|__novlan/test_ping_vms__|0|1|0|0
local_nfs_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_create_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_reboot_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_snat_create__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_dnat_reboot__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_ping_vms__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_create_3vms__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_start_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_3l3s_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_remove_dhcp__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_2l3_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vms_with_limited_ips__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.0__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vms_with_limited_ips2.1__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_start_vms_simultaneously__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_static_ip_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_crt_vm_with_hostname__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_attach_nic__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_attach_nic_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__vlan/test_attach_nic_reboot_vm__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_add_volume__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_add_m_vols__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_add_volume_vr__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_volume__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_2_volumes__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_24_volumes__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_volume_ops_on_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__volume/test_crt_vm_from_dvt__|0|1|0|0
local_nfs_virtual_router_test|__template_image/test_crt_temp_image__|0|1|0|0
local_nfs_virtual_router_test|__template_image/test_del_temp_image__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_ingress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_egress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_icmp__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_udp__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_vm_ops__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_2vm_egress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_2vm_ingress__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_4vm_complx__|0|1|0|0
local_nfs_virtual_router_test|__sg/test_detach_l3__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_2l3s_pfs__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_attach_pf__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_delete_pf_after_destroy_vm__|0|1|0|0
local_nfs_virtual_router_test|pf/test_del_vip_before_add_pf_to_vm|1|0|0|0
local_nfs_virtual_router_test|__pf/test_multi_pfs_sg_tcp__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_multi_rules__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pf_after_destroy_vm__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pf_sg_tcp__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pfs_tcp_udp_same_vip_ports__|0|1|0|0
local_nfs_virtual_router_test|__pf/test_pfs_tcp_with_same_vip__|0|1|0|0
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|__eip/test_2_eips__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_2l3s_eip_pf__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_2l3s_eips__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_attach_eip__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_create_eip_vm__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_del_vip_before_add_eip_to_vm__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_eip_sg_tcp__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_pf_eip_attach__|0|1|0|0
local_nfs_virtual_router_test|__eip/test_vm_ops__|0|1|0|0
local_nfs_virtual_router_test|eip/test_vm_ops2|1|0|0|0
local_nfs_virtual_router_test|__snapshot/test_backup_snapshot__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_create_snapshot__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_create_sp_after_delete__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_create_image_by_snapshot__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_for_both_root_...__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm2__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm3__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_delete_snapshot_on_ru...__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_in_live_vm__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_crt_sp_from_vol_crt_f...__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_change_max_sp_depth__|0|1|0|0
local_nfs_virtual_router_test|__snapshot/test_change_max_sp_depth_l...__|0|1|0|0
local_nfs_virtual_router_test|__regression/delete_sg_with_2_attache...__|0|1|0|0
local_nfs_virtual_router_test|__regression/rm_nic_sg_on_stopped_vm__|0|1|0|0
local_nfs_virtual_router_test|__regression/test_data_volume_with_vm...__|0|1|0|0
local_nfs_virtual_router_test|__vr/test_ping_vms_reboot_vr__|0|1|0|0
local_nfs_virtual_router_test|__vr/test_reconnect_vr__|0|1|0|0
local_nfs_virtual_router_test|__vr/test_start_vrs_simultaneously__|0|1|0|0
local_nfs_virtual_router_test|__host/test_reconnect_host__|0|1|0|0
local_nfs_virtual_router_test|suite_teardown|1|0|0|0
Total|292|8|169|0|115


do not print anything extraneous


name of the function is cumulative_sum() but it runs just fine


TeamCity Subsonic :: Debug [Build 49](http://109.103.226.38:8512/viewLog.html?buildId=35026&buildTypeId=Subsonic_Debug) is now running


until this point it already gets OOM


.upper() will make all letters uppercase, rather than just the first letter of the word. Use .capitalize() instead (or .title()) for only the first letter.


Works!


@xhaggi - many thanks :grinning: - I'm on it.


Would it make sense to use espresso tests for stuff like this?


the instructions were to return a nested list with all strings capitalized. I understood that as all characters in the string but I could be totally wrong! Your function does what your understanding was spendidly though! :)


Yes, try to think of more ignore entries to add.


Great. Would be nice to rewrite the commit message saying such.


TeamCity Subsonic :: Debug [Build 49](http://109.103.226.38:8512/viewLog.html?buildId=35026&buildTypeId=Subsonic_Debug) outcome was **SUCCESS**
Summary: Running Build time: 00:01:23


saw approval from cmeiklejohn
at https://github.com/basho/riak_core/commit/c322af350d40189685c56c3625fbc6d52aaa3f20


merging basho/riak_core/bugfix/jdm/vnode-proxy-stuck-in-overload-v2 = c322af35 into borshop-integration-767-bugfix/jdm/vnode-proxy-stuck-in-overload-v2


basho/riak_core/bugfix/jdm/vnode-proxy-stuck-in-overload-v2 = c322af35 merged ok, testing candidate = 481c5dd7


Shouldn't `mempty` return a closed channel?

Take into account that `(mappend (mempty) ch)` must return a channel with the same values that are put into `ch`. Because of the implementation of `mappend`, it will drain all chained channels one at time, returning a channel with all the values. Since the channel returned by `mempty` isn't closed, `(mappend (mempty) ch)` will return a channel where no values will ever be put.

I haven't tested this so I might be wrong.


I am not sure if this code is still up to date, but as in the spotted bug in `dev`, do *not* remove the total offset! (pls just fix it https://github.com/ComputationalRadiationPhysics/picongpu/pull/1039)

somehow I got a notification that did lead me here.


Perfect!


![vmdbdatabasesettings display prior to fix](https://cloud.githubusercontent.com/assets/552686/9255501/af63f5bc-419e-11e5-96cb-03015f6ae0f1.png)

UI display of only 1 (first) setting from VmdbDatabaseSetting (out of 224)


nice use of list comprehension!


this method just tries to proxy all call to "raw" methods, so results are calculated once and get returned on a second lookup:

```php
$tstring = $token->tstring; // 1.st property lookup should be proxies thru to private $token->tstring() method
$string2 = $token->string; // should not invoke __get() and immediately return the value which was calculated in the 1st invocation


Looks good, though it would be nice to add in some comments that explain what you're doing and the fact that you have two methods for accomplishing the same thing. As you don't have the prompt at the top, it would be helpful to have some further context.


@chenji-kael could you add a new line here?


I'm not sure why I ended that line with a question mark. Yeah, that was just a reminder to anyone (me?) who checks this out and is confused when it doesn't work


Great!. all tests passed!


Are you just initializing t as this list? and then changing it through the function?


Hi @miloszszymczak

Thank you for the tip! I committed your fix in: https://github.com/piwik/piwik/commit/59bce9e787c45b28f48e413672e23cae541ed797

can you check if this works  well for you?

I guess this also fixes https://github.com/piwik/piwik/issues/7948


extraneous print statement


Here it gives an error, while calling nested_sum(item, total). The nested_sum that you have written accepts just 1 argument and while calling it you are passing 2.


trailing space.


The buttons were only drawn for the tiny size, not the big size. (George requested these from RetroStyle a long time ago, so I put them in as part of my artwork archaeology.) They won't look good big.


Was this no longer working?


not sure how necessary the newNestedList = capitalize_nested(item) part is. I think it could be cleaner if you write newList.append(capitalize_nested(listOfLists))


Awesome! works!!


Fix issue #8


This looks to me as being not very useful. Agree?
(If not, I will  neatly give it it own's example: one test per example.)


function name should be capitalize_nested


Hmm. I think maybe it should really be `Try[(Result, Self)]` since I'm not sure if the environment is still valid if the script throws an exception?


Shouldn't that be in the appengine base image?


Nice!. works for all the tests!


But the way, our REST API works in such a way that updates can ONLY happen if the url the uuid as seen [here](https://github.com/openmrs/openmrs-module-webservices.rest/blob/master/omod-common/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/controller/MainResourceController.java#L98). Having the uuid in the JSON pay load won't force it to be interpreted as an update, it will be treated as insert, and it will fail


How and where did u get these flag values? :)
I had it like that:
trun.sample_flags[0] = sample.is_rap ? (2 << 4) : 0;

Then I verified bitstream and I got what I expected to get. Maybe my expectations were wrong?..
"create problems in Firefox and Chrome" - what kind of problems?..


Good...this works too for all the tests! great work..


This has to have broken the CHECK_PART() macro.


missing white space after `iter,`


@promactkaran what do you mean when you say "is not getting detected"? Could you please open an issue describing your problem, including any error messages you are getting?


TeamCity pull requests :: netty [Build 24](https://garage.netty.io/teamcity/viewLog.html?buildId=295&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 5075, ignored: 20 Build time: 00:25:12
### Failed tests
```
io.netty.osgitests.OsgiBundleTest.testResolvedBundles: <no details avaliable>

```


seems like it's missing npm install, setting $PORT, etc


I'm not entirely sure what the implications of removing usedevelop=True are.


I guess it specifically broke `STRLEN()`, right?  This could also be fixed using `const char []` instead of `const char *`.
But macros were fine IMO, even if not `undef`ed later, nobody cares


saw approval from cmeiklejohn
at https://github.com/basho/riak_core/commit/c322af350d40189685c56c3625fbc6d52aaa3f20


merging basho/riak_core/bugfix/jdm/vnode-proxy-stuck-in-overload-v2 = c322af35 into borshop-integration-767-bugfix/jdm/vnode-proxy-stuck-in-overload-v2


basho/riak_core/bugfix/jdm/vnode-proxy-stuck-in-overload-v2 = c322af35 merged ok, testing candidate = 3b55b617


ok I thought it would be nice to get a warning when an assert fails.. but I will remove this


@GrahamCampbell I'm sorry but I didn't get what you mean.. do you mind elaborating?


Lol c'est un peu facile ça


> I guess it specifically broke `STRLEN()`, right?

Yes.


`$this->app->files->put(`


Python asks that you do not have lines over 80 columns in length. This one is 105 :(


These all look good to me, we should close this PR


Using this patch solved the issue for me on Windows 10.


End of Thursday -- slowly converting to domain use. Have switched to domains in SV wind setup. Up to about line 173 in sv.c in terms of code logic. Should go into ddd and check that the grid is setup right.

Things to think about / Questions that have come up:
* dummy cells - need a dummy between wind and disk.
* interpolation between cell properties
* wind_x arrays
* offset of wind above disk
* where_in_wind and where_in_grid routines


no.. this was only a quick update. more functions should be added.


or, `use Illuminate\Support\Facades\File`, then drop the slash


I'm afraid that external sort cannot read the temporary file. Need test.


Same length comment as above


Hey, Adam! I probably can't code today. But, fortunately, I have almost the whole day tomorrow! See you!


Oh okay already fixed here:
https://github.com/jadjoubran/laravel5-angular-material-starter/commit/d4c0305ebcb1bf1d5c2c6ba3909f3b2890063a5b
I just imported the `File` facade.. Looks good?


My guess is he cares a lot about ram usage on embedded devices.


I think we used to have this. But it was dropped because it is causing some race condition because of write-failure-retry loops.


It seems to me easier and more logical to pass a string as `$verb` and call `getVerb()` method within `inflect()` (or at least support both cases).


There a lot of possible template engines so I just use string concatenation. Would it be better to show the html markup of a table?


Don't really know why need to log a health station


I was thinking the same, or a channel holding nil, which I think is practically the same, though unnecessarily inefficient. If you take from a closed channel, it returns nil, right?


Yeah, IDK. All this event stuff is basically just a sketch on how we could theoretically use `CompiledScript` to JIT events and cache the compiled code, which I think is worth doing even if it means we have to provide an `Event` class.


First bug found! :D


That was fixed as well yesterday. I hope there were no further hidden bugs introduced with the cleanup.


TeamCity Subsonic :: Debug [Build 50](http://109.103.226.38:8512/viewLog.html?buildId=35029&buildTypeId=Subsonic_Debug) is now running


I would go even simpler than this, have a pair of options, one for DEBUG and other for RELEASE. If the user needs more fine grained options, simple use the CONFIG_CFLAGS / CONFIG_LDFLAGS.

I don't think we need config option for each -O1 -O2 -O3 -O4.


OMG. The code is really complicated to read now. Why is "map" required? I don't get that part.

I think, returning fieldtext is the better solution. Maybe the side effect of the old method was to return the whole content of the DOI if it's an invalid DOI...


What I guess you meant was to use `$services.parentchild.getParentsBasedOnParentChildRelationship` since otherwise this macro would not be about parentChild, but about whatever is currently configured to be used as hierarchy mode.


97204612_MultiSpeedFan (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1279 of 1280 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.9%25-green.svg)


s/welcomed/welcome :)


This broke the maps with the error: No such file or directory: /home/kylekyle/.gem/gems/nyaplot-0.1.5/lib/mapnya/datasets/geo-boundaries-world-110m/countries.geojson


Same note as below, just that here it should be `$services.parentchild.getParentsBasedOnReference` (which should also be public).


TeamCity Subsonic :: Debug [Build 50](http://109.103.226.38:8512/viewLog.html?buildId=35029&buildTypeId=Subsonic_Debug) outcome was **SUCCESS**
Summary: Running Build time: 00:01:33


What do you mean by highlight?


I have the same question as glima (and I think it can be handled in another patch since existing CONFIG_CFLAGS is already useful). Maybe with CONFIG_CFLAGS instead of CFLAGS.


Can you link the commit you did that in?


Nice!


@aleffert: OK. It will add a bit more complexity to the test.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1702


PORT is set in the base image, and npm install happens in the child Dockerfiles so we don't have to use ONBUILD.


Let's all land this stuff land first and then worry about that as a little follow up.


:+1: gorgeous


This stuff is only useful for a few runtimes, so it goes in each one that needs it.


93653360-ResetVarsAtEndOfWarmup (mbadams5) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


PERFECT!

http://i.imgur.com/pPDDkLl.gif


@mbougie @horton1  pull with run_xval


@horton1 @mbougie pull with analyze preds


I have to add that desyncing doesn't happen all that often. I don't have numbers. It should be assessed somehow by logging or counting it.

My opinion is that when detecting and resynchronizing is very reliable it is acceptable to loose 2 frames once in a while. (Like 10min) frames are discarded more often due to normal operation, for example if the current ground does not have enough features.

Recovery is quick (5ms) and in my testing - I forced desyncing by inclunding a delay in the interrupt handler - detection is immediate. The desynced image doesen't even reach the processing pipeline.


You're changing files in the exodiff source code here, don't know if we want to mess with that.


Yes, let's have a look together how could split this.


Swapped works correctly, however to anyone, I like generating a new token on each form post.  So I'd have this as a starting point, but consider changing the $max_time to a very short time, maybe just long enough to process the form, or 10 minutes.  I feel a day is too long, but that's just me.
Again sorry I mis-read the change at first.


Thank you Paul for collecting these settings into this PR. I applied this locally, along with switching to NFS and my VIPQS is now usable; actually fast!!!


This is my first attempt at a pull request, hopefully it goes well.


@devkbsc switched to `chokidar` and added some functionality to let processes know if they are the master of the cluster: https://github.com/foreverjs/forever-monitor/compare/v1.5.2...1.6.0


The naming `func_pointer` is not elegant since its type is already of `funcPtr`. Shorten it.


We could create a test package for testing navigation in Espresso, but obviously these tests will need to be run in an emulator as opposed to the JUnit tests (which was what we were trying to avoid by introducing Robolectric). Still in this case our hand seems to be forced by the limitations of the framework. I'll also see if there is any issue or feature request logged on the Robolectric repository, and what the status of it is.


Why `j <= i` here?


Thanks @elpaso
I slightly modified it. I wasn't sure about the :func:`with edit(layer)` code. Can we add a :code:`with edit(layer)` or similar?

The previous version was not accurate because edit is actually an object and not a function, but that will not help the reader to get the concept so I thought it's best to mention it as a complete statement.


I think PR #637 could be used here... that is simpler than this one, IMHO.
What do you think?


In line 43, if you call check_winner, it will never return nil.... Then, it wont stop if the game ended.


well, do you know javascript?  I have one bug pending in there for like nearly 6 months or so....  :-1:


TeamCity pull requests :: netty [Build 25](https://garage.netty.io/teamcity/viewLog.html?buildId=296&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 5113, ignored: 20 Build time: 00:45:10


[1064] You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '?Z?ў
', '2', '528', '48', '48', '1519', '13', '272', '384', '0', '1549', '-12'' at line 1
Error while parsing SQL. Core fix required.


crash)


can you pull this out?


I mean, if we can make it easy for most tests to run without an emulator, but we require some UI tests to do so, I don't think it's a big deal? On iOS you run all the tests in the simulator and it's not a big problem.


The issue is that if we ever want to add Scalaz and mix in its `Monad` typeclass (for the free ops and stuff) we have to make sure this return type conforms to the typeclass contract.


Merging PR 5


this assignment can just be in the `if` body


Please fix that, @Lohit13, documentation is very important ;)


Resetting the collection updates the times also.  I thought that may be easier instead of updating the collection and manually updating the times for each entry.


Do you mean JsDoc on functions? If so the current implementation of the intellisense doesn't take the underlying code in mind, so there shouldn't be any differences.


Does this work?


This test needs to be restricted to run in serial if it uses `-pc_type lu`


Do these tests run reasonably fast for you?  @smharper is trying to speed up modules tests overall and you are adding two tests with 1250 elements each...


we have testfixtures in the gradle code base for testing proxy support. I suggest to shamelessly copy that stuff.


isn't this a no-op?


Jestli to dobre chapu, chce pomoci s js??? Muzeme mu pomoci...

---------- Původní zpráva ----------

Od: Jan Paricka <notifications@github.com>

Komu: jparicka/cloudly <cloudly@noreply.github.com>

Datum: 13. 8. 2015 19:10:06

Předmět: Re: [cloudly] Update README.md (1367382)

"

well, do you know javascript? I have one bug pending in there for like
nearly 6 months or so.... :-1:

—

Reply to this email directly or view it on GitHub
(https://github.com/jparicka/cloudly/commit/13673825d0ab1d86c7c1e75793558a9515c8aa54#commitcomment-12694361)
.

"=


Same serial preconditioner issue here.


oh, it removes the last element.


My guess is that it's for debug purposes. Will update it.


có thể xóa đi code trong banner và thay bằng 1 hình ảnh
và thuộc tính như


I'm not 100% sure this is necessary to change the proxy settings. would require a test first. if the proxy settings changed and it turns out the daemon process cannot reconfigured accordingly, I would start a new daemon with a proper console about why this was necessary.


s/inbetween/in-between/


Yes, but I have found the problem and easily fixed.


As mentioned in #49, I have a hard time understanding this number. Citing from that PR, I see it as:

> “The fastest time was x times faster than this one (except, you should subtract 1x)”

As for *better* wording, I don’t know. Sorry.


lgtm


I think it's correct. Fee free to add comment or reorg the logic. It should not attempt to trace a message that has already been marked as "not sampled".


As per our discussion, the Registrant E-mail Address might be added back as per Pearl request.


@brainstorm I'll get started on it right away!


ok, thanks. Those header files were included in the fs_lustre_file_open.c, but you are right that they should be in the same location.  I will file an improved patch this afternoon. Thanks!


Aha.  Nice comment!


how do we deal with proxy settings provided in the gradle.properties file?
- Do we use these settings when proxy setup is not explicitly configured in eclipse?
- Do these settings generally win over the eclipse settings or the other way around (eclipse proxy settings win over gradle.properties - my favourite)
- Can I mix the places for configurations? (setting general proxy host and port with information from gradle.properties & user name + password from eclipse setup)


Yep, I used `abs` with the approx equal check, should be the same here.


:speak_no_evil: Shibboleth… Let me see when I find enough anti-depressiva and a test setup :speak_no_evil:


Sure. It's not optimal, but it should work.


#self:getPlatforms() == 0


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


To avoid holes on struct, try to put bigger stuff on beginning, please.


@jasondegraw Warnings are gone. Do you know what causes above unhandled Fundamental failure?


I think i fixed the issue, there was an issue in the encounterTypeService in uicommons module, never mind!


FixSlabTransition (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This should also be a member of struct vsb_server_s, there can be multiple instances with different behavior.


if distance is None? or not None?


You implemented @lpereira idea, neat (I think it's his). Wondering if we could, some day, just send this array to a sol_i2c_setup.


Why we use promises from Babel runtime? We can just use promise lib which is used in server.


I mean, if we can make it easy for most tests to run without an emulator, but we require some UI tests to do so, I don't think it's a big deal? On iOS you run all the tests in the simulator and it's not a big problem.


what do you mean?


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Do you need this `&` for the callback? Just `setup_device` is not enough?


ep - I don't like abbreviations so much for variable names as its not as intuitive. I have no idea what 'ep' stands for.


zero might be a valid possible course value


h


title 屬性要放 <%= c.user.name %>


No problem, at a glance, it looked funny.


var errBlabla = errors.New("....")


so that there's only one instance.


maybe to save dict construction:    set(n for n, _ in nx.single_source...)


Looks fishy why the cursor dimension are so big?


uh? actually I implemented this way because it was much easier to do.


sorry - will hun pokahole to figure out the holes and arrange them if needed.


test


the & is necessary to get the address of the fucnction, no?


develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2196 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.34%25-yellow.svg)


Then what is the problem?


CELERYD_PREFETCH_MULTIPLIER was 10.  Did you mean to change it to 1?


Huh. I guess we should make header files at some point for common stuff like sockets, like `source ctypes.sh/sockets` or something...


Don't you have to track the `sol_i2c_pending` returned by this function? I think you could look at some node that @zehortigoza changed on this matter.


The desire seems not to call `computeProperties()`/`refershRendering()` twice even for widget property value assignment right after widget creation. The best way I see to address such requirement is delaying observer setup, which I did in https://github.com/asudoh/decor/commit/c2cb7eb7431bce2790061b7568f01fc0910d159a.

Note that the current codebase sets up observers before (some of) initial widget property values are ready, and handles those values with the 1st observer callbacks, which makes it ambiguous initial widget property values vs. changes after then. To make it intuitive for widget authors wrt how change in widget property values are handled, we need to remove such ambiguity.


coming up.


https://github.com/ftomassetti/libav/commit/33fac5d14041412d5b9946e1bc0637b2a616c974#diff-a0fa3374c8c48ddad30639f3c7537e75R283 seems to need the same treatment, you should probably put the coordinate validation in paint_rect and forward the return error.


The map converts a DOI to the string representation of the DOI.
Am 13.08.2015 6:57 nachm. schrieb "Oliver Kopp" <notifications@github.com>:

> OMG. The code is really complicated to read now. Why is "map" required? I
> don't get that part.
>
> I think, returning fieldtext is the better solution. Maybe the side effect
> of the old method was to return the whole content of the DOI if it's an
> invalid DOI...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JabRef/jabref/commit/50c96386dc789c3614e1e347e3224ee7b9a31a5d#commitcomment-12694112>
> .
>


No need for `reduce` here since we have a determined set of promised events. Moreover, it's better to rewrite this in following maner:
```js
function nextTick() {
    return new Promise(function(resolve) {
        setTimeout(resolve, 0);
    });
}

ElementEditingWatcher.watchElementEditing($input[0]);
$input[0].value = '123';
EventSimulator.blur($input[0]);

nextTick()
   .then(function() {
       ElementEditingWatcher.watchElementEditing($input[0]);
       $input[0].value = '423';
       eval(processScript('$input[0].value = 42'));
       EventSimulator.blur($input[0]);
   })
   .then(nextTick)
   .then(function() {
     ...
    });
```


I was wondering about this revert but didn't have time to investigate,
thanks.

On Thu, Aug 13, 2015, 04:34 Vladimír Čunát <notifications@github.com> wrote:

> Now I stumbled on Hydra example of that, many commits before texinfo bump:
> http://hydra.nixos.org/build/24413657.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/dc74a811291ea5e29e47f7dcc01bdac118f492fb#commitcomment-12687090>
> .
>


тут написано:
/* можно это всё сетами в екземпляр класса ExamTheFirstCours вбить
		 * st1E.setSurName("Laz");
		 * st1E.setSessionTheFirstCoursAnatomy(5);
		 *  но мне так лень это было делать :(
		 *  по этому у меня чуточку извращённая логика программы
		 *  а вобще можно ли как нибудь воспользоваться конструкторами класа Session(или Ladder) если                          создавал екземпляр класса Exam?
		 *  или можно как-то вот все эти екземпляты внести в 1 самый самый дочерний? уже после того как я их конструкторами создал?
		 */ :)


ah, sure. coming up.


(as also commented in https://github.com/WebAssembly/polyfill-prototype-1/issues/15 , this is just in the `wasm-polyfill-prototype` branch in emscripten so far, which has not yet been merged to incoming or master.)


Isn't a good idea to save this timeout handler, and set it to null once the timeout is called?


You don't set this `mdata->timer` when call `sol_timeout_add`.


Remember to make `mdata->timer = NULL` here.


Exactly, and this code will rotate to 0° in that case. I should mention that I also fixed a bug in the [existing heading code](https://github.com/mapbox/mapbox-gl-native/commit/303e81bb5eb87ede85129d0ff650226f0c9218aa#diff-f315cd6ead3270a0818a2dcfb84bd99bR2446) to account for the same thing.


please don't use .ps1 as they are not able to run cross platform. Please use gulp or some other task runner to execute the tasks you are running in the .ps1


This is awesome!


thanks, ideally this would support the full range of supervisord options, one more never hurts!


@andrewgaul can you sign off the commit?


I don't need the `totalGpuOffset` anymore because it was used get the cell index in the local domain.
I am already calculating this in my ionization kernel and then passing it to the RNG initialization.
This is now similar to how it's done in the RNG for the initial temperature.
All is safe, @ax3l !


Really, I thought I've read him writing this idea on a previous version of this PR. Anyway, it's a neat idea =D


This is great. Thanks. Please capitalize 'Rust' though.


How about using https://github.com/StackStorm/st2/blob/master/st2common/st2common/exceptions/db.py#L19


Maybe generate syslog message if the test fails?  This will help plugin authors with debugging.


All 8 tests runs in 13 sec for me. For some of the tests I have reduced no. of elements in later commits. Yes, I can change the -pc-type to make the tests run in parallel.


Just curious - why was this change made?
I don't see anything wrong with it, but at the same time, I don't see what the benefit is either :)


Same here. It's better make all this async funcs (`focus`, `assertFocusing`) return Promise and make simple chain, e.g.:

```js
focus(input)
   .then(function() {
        clearExecutedHandlersCounter();
        input1FocusedCount = input1BlurredCount = input2FocusedCount = input2BlurredCount = 0;

        return assertFocusing(input1);
   })
   .then(function() {
        return focus(input2);
    })
    ...
```


Sweet. Even though we don't yet have `cljs.test` working, I'm glad we at least have these integration tests. (And sometimes the integration tests are great for end-to-end things like `-m`).


Dan, I don't think the reconnect within a timeout is a good idea at all. I'd suggest going with something which has been working fine for CloudAPI for  a long time: https://github.com/joyent/sdc-cloudapi/blob/master/lib/app.js#L371-L382

The iddleTimeout, I'm all for it


Re: our chat in Slack; WP coding standards stuff

- [ ] Pull from master first, then branch, then make your edits (you're a bit behind as there was an update yesterday)
- [ ] Ensure there's a comma at the end of the array, i.e. `img_size` => '',
- [ ] `if ( ! empty( $attr['img_size]  )` (spacing, mainly)


mpfh. I used to use a timer, now I don't use it anymore, forgot to remove it from the mdata struct.


The fourth point of this explanation is actually ambiguous: is `x` used, `y`, or both?


yes, it is. :)


you are correct, i read that too quickly. thanks!


What are these *.js.html files? Do we need them?


if (text === "收藏活動") {

js 的 === 會順便檢查資料型別，== 只會檢查 value
假除 text = 5，那 text == "5" 會 return true，一般應該會使用三個等號

http://stackoverflow.com/questions/359494/does-it-matter-which-equals-operator-vs-i-use-in-javascript-comparisons


develop (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


TeamCity DNN JavaScript Libraries :: CI [Build 67](http://teamcity.engagesoftware.com/viewLog.html?buildId=335&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


don't think so. if it returned with null it means that something went wrong, returned with value meant that it worked. @zehortigoza - shall I keep a copy of this and delete it later?


TeamCity DNN JavaScript Libraries :: CI [Build 67](http://teamcity.engagesoftware.com/viewLog.html?buildId=335&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:16


@andrewgaul the problem with this one is that it requires that the server is synchronized (up to 20 seconds), which is not always the case. Not sure what is the best way to tackle this, but I'm not sure we want to add this constraint.


typo


`ini_set`? Seriously?

http://php.net/manual/en/function.session-set-cookie-params.php


Do we need the *.js.html files? What about the files under .sass-cache?


link?


This causes the ErrorEstimationTest in the RunManager tests to fail.


Is there any validation for these fields?


Any particular reason this one doesn't come from `dl.signalfx.com` ?


createdAt and createdBy should be handled by a behavior.


Piping to the output of `b.bundle()` was undefined behavior that went away several Browserify releases ago.


Why not use those variables in the download location URLs?


develop (macumber) - i386-Windows-7-VisualStudio-12: OK (2203 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.66%25-yellow.svg)


canols??? lol


That's not technically accurate


Required fields, validation, etc


Hi developers,

Isn't typo?
```
diff -Nur a/src/main_window.c b/src/main_window.c
--- a/src/main_window.c	2015-08-14 02:36:54.858217515 +0900
+++ b/src/main_window.c	2015-08-14 02:37:41.371218452 +0900
@@ -590,7 +590,7 @@
 		gint monitor;

 		screen = gtk_window_get_screen(GTK_WINDOW(wnd));
-		window = gtk_widget_get_window(GTK_WIDGET(wnd))
+		window = gtk_widget_get_window(GTK_WIDGET(wnd));
 		monitor = gdk_screen_get_monitor_at_window(screen, window);

 		gdk_screen_get_monitor_geom(screen, monitor, &monitor_geom);
```

Best Regards.


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 750 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.32%25-green.svg)


indent


> Couldn't the typed geometry conductors create (Buffer)Geometry and also save their creation parameters along with a flag indicating if the geometry was altered?

That would be ideal, but I don't know how to detect when the geometry has been altered.


Yes, I agree this is not optimal. The reason was lack of time plus the C++ macro `FTConvertToCDI.cxx` implementation which relies on the `restrictedMC` flag which is democratically applied to all files if switched on. We need to differentiate between MC-like files and WP-like files so that the `restrictedMC` flag, if switched on, is only applied to MC-like files.


Also, I'd use this since we already have it: https://github.com/nerdzeu/nerdz.eu/blob/master/class/system.class.php#L9


Why not make `get_needed_os` figure out the package name to install for this?


I think this will never be more than 2, so you can change it to uint8_t or better have a:

uint8_t refcount : 7 : success : 1;


You can remove this and use instead sol_i2c_bus_get()


You can remove it


Missing a sol_i2c_busy()


Well, any other point where we send a pointer to a function, like the `sol_timeout_add` below, doesn't need the `&`.


Missing a sol_i2c_busy(), other node could be using the same bus to talk with another chip.


As soon you return this function write_msg will become invalid and the sol_i2c_write() will write garbage onto bus, use device->buffer.


Is this require to be able to run the `add-apt-repository`? If no, then adding the repository should be done first so you only have to `apt-get update` once


yay!


Potenettial conflict with django app inits.


RemoveMoreBadCharacters (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:-1: Only losers have other things to do


Also, I don't think there's the need to add the dot at the beginning. Quoting http://php.net/setcookie:

> Setting the domain to 'www.example.com' will make the cookie available in the www subdomain and higher subdomains. Cookies available to a lower domain, such as 'example.com' will be available to higher subdomains, such as 'www.example.com'. Older browsers still implementing the deprecated » RFC 2109 may require a leading . to match all subdomains.

We ain't dealing with older browsers.


Indent


Should be called UserSessions and be inside its own package as it is not ip ban specific.


Why not extract this into a function too?


金融單位的資料用 `decimal ` 儲存會比較保險
integer 沒小數點，float 的話 10.25 可能在 database 會變成 10.24999999999，有機會讓錢莫名消失

http://stackoverflow.com/questions/1019939/ruby-on-rails-best-method-of-handling-currency-money


Units of time? Hours? Leave a comment.


thx


Please get rid of the `-r`, it's redundant and potentially dangerous if a bug resulted in `name` being empty.


I don't like these "raw" string option names at all. It's gonna be so easy to make a typo and there's absolutely no documentation about the supported option names and what they do.


Someday I'll find a workflow for temporarily changing the feed value :)


What’s the rationale for this? I was going to file an issue that me SeeAlso items were being stripped … but you’re doing it on purpose?


.new


watch this indentation


Accidental, I was on a machine that didn't have pull-rebase on by default.


saw approval from mrallen1
at https://github.com/basho/cuttlefish/commit/a1dd63bd53beebfc0da46cbe542af5cb6dac0b85


merging basho/cuttlefish/feature/jrd/validate-ip = a1dd63bd into borshop-integration-201-feature/jrd/validate-ip


basho/cuttlefish/feature/jrd/validate-ip = a1dd63bd merged ok, testing candidate = 68d54f6b


:+1: Let's get this merged


Oh, but wait … most of them are showing up. OK, something is funny on my end. Ignore the noise and I’ll file an issue if it’s not just me.


Nitpick: This way is better to read:

if (sol_i2c_busy(mdata->context)) {
mdata->timeout = sol_timeout_add(0, &do_processing, mdata);
return false;
}

mdata->i2c_pending = sol_i2c_read_register(mdata->context, REG_AUX_UVINDEX0, (uint8_t *)&mdata->read_data, 2, &read_callback, mdata);
if (!mdata->i2c_pending) {
sol_flow_send_error_packet(mdata->node, EIO, "Couldn't read from device, check your UV reader (si114x)");
SOL_WRN("Couldn't read from device, check your UV reader (si114x)");
}


There is an `external_url` controller with of the form

    http://api.opentreeoflife.org/phylesystem/external_url/STUDY_ID_GOES_HERE

For example: http://api.opentreeoflife.org/phylesystem/external_url/ot_308
We could easily add more fields to the JSON that is returned by that call.


Wouldn't it be easier to read using `CVariant::isMember()`? Yes it would be slower because you have to lookup the value twice (if it exists) but it would be much easier to read IMO.


I guess, then I'm a losers :+1:

:smiley_cat:


:o


You need keep the timeout and remove it also you need cancel a pending i2c transaction.


oops. sorry you mean from within the server... hold on...


Don't you want to create and update preferredHandlerClassname and handlerConfig?


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


This is a bit nit-picky, but wouldn't the right thing be to remove the reference to format from the return statement instead, since there is nothing in the body of the function that sets it?


use constant


@laughedelic you removed ammonite dep here but did you test the version? It seems to me that the bundle keeps on using ammonite, see here https://github.com/ohnosequences-bundles/samtools/blob/master/src/main/scala/samtools.scala#L8


Sure. Browse to https://www.spamgourmet.com/ and click their FAQ link.


okay


Okay, so this is the last thing I need to fix, but I don't see a way to reuse binary objects. AFAICT, all of the `Binary` subclasses are private, and the static functions used to generate the `Binary` objects all instantiate new ones. Can you point me in the right direction on this? Thanks


setup_device is already the address of the callback you don't need the '&'
Also you need keep track of the sol_i2c_pending, if the user of the node decide to close it when there is a running i2c transaction happening you need cancel also if good to you print error in case that there is no memory.


@foresto cool, thanks


Hm, I understand what you want to say, but maybe there is a better way to say it? Something like "Tasks are not the same thing as threads, and one Task may not run on one thread or on a new thread" or something similar.


Sorry this has been overlooked.  Can you give me some background on this issue?


:+1:   thanks


not sure if we should prefer inline over static methods as large inline function can increase code size, which might result in slower code and you can't use overloads. @Montellese any opinions?


I thought it is the web service that is supposed to do the saving instead of you directly calling saveGlobalProperty(). Not so?


It's basically the data serialization part that needs to be added. My bad on that.

I'm take a code snippet from azuqua.js and add it to rest.js serializing data into a query string. However, it'll still break designer if designer is expecting body data in a GET request. If designer does check the BODY on a get request (there could be other components that does the same), perhaps the path of least resistance is reverting one commit back on restjs and changing node-token-client to use request. Thoughts?

```javascript
var addGetParameter = function(_path, key, value){
  var delimiter = _path.indexOf("?") > -1 ? "&" : "?";
  return _path + delimiter + encodeURIComponent(key) + "=" + encodeURIComponent(value);
};
........
    if(options.method === "GET"){
      _.each(params, function(key, value){
        options.path = addGetParameter(options.path, key, value);
      });
    }
```


Actually nevermind - since I'm working on tests for this module anyways I'll add it.


ok that's great, just caring for you ;)

we can double-check it during the PR again.


It would be:

    phylesystem = api_utils.get_phylesystem(request)
    try:
        shard_name, path_frag = phylesystem.get_repo_and_path_fragment(study_id)
    except:
        _LOG.exception('check for shard name failed')

where `path_frag` would be the part of the path like `ot_08/ot_308/ot_308.json`


This should be `messageBody(pkg)` instead. You can remove line 47 etc.

Right now line 47 just generates the body, but doesn't do anything with it, while we pass the template function in as body here.


Twitter counts long urls as max 30 chars, so this is actually stopping us from sending out valid tweets. So we need to count the status before adding the url and assume the url is 30 characters (after all, `https://www.railsschool.org/l/` is already 30 characters :P).


Can we add some more tests for retrieving, editing, and deleting an existing setting?


The release api should be generated as part of vso-node-api - not checked into the plugin.  http://github.com/Microsoft/vso-node-api

Talk to Teddy Ward to get it generated


This is circular. We use `hides_under_flooring()` to determine the level to set, yet `hides_under_flooring()` itself uses level to decide what value to return.


Greatest commit I've seen in my entire life.


I'm not sure if you understand the point of the original trry/except. On earlier versions of python there is no unicode class so the check if instance(value,unicode) causes an exception. The workaround I had before checked for unicode being in __builtins__ but that failed in more recent versions of  python too. This new change will cause an exception on earlier pythons in the if instance(value,unicode) statement and not fall through to the raise TypeError() statement. It is possible to move the whole try/except block down but I'm not sure why that is necessary.


I added a comment on master:

        # If user's sitewide permission level is Volunteer,
        # they may only register for work parties with a role of Volunteer.
        # Otherwise we use the workPartyRole submitted as part of the form.


I checked as well, and this won't exclude anything in the original checkout. :)


All new async code should come in and be exposed as a Q Promise, not the async node callback mechanism.  We're rolling through the agent and converting existing code to Q and we don't want new code coming in that's not


@b1l1s @173210 Ok now I'm at home. What do I do?


Sorry about commenting on ongoing work, but I think the "Sfx" in `audio::SfxChannel` is redundant. Since it's the audio namespace, wouldn't the simpler `audio::Channel` be more succinct?


I submitted a [PR to fix this typo](https://github.com/joyent/node/pull/4249) (and the other comment identical to this one in this file) 3 years ago and it just got closed today so i'm not going to bother to do it again....but someone really should fix this.


I prefer to use talkative names even for types.


Just ran over this while generating the changelog. @lgalfaso is this okay without a test? It just looks a bit suspicuous


(Y)


Hi,

2nd one:
```
diff -Nur a/src/main_window.c b/src/main_window.c
--- a/src/main_window.c	2015-08-14 03:00:39.040246188 +0900
+++ b/src/main_window.c	2015-08-14 02:59:56.868245339 +0900
@@ -593,7 +593,7 @@
 		window = gtk_widget_get_window(GTK_WIDGET(wnd));
 		monitor = gdk_screen_get_monitor_at_window(screen, window);

-		gdk_screen_get_monitor_geom(screen, monitor, &monitor_geom);
+		gdk_screen_get_monitor_geometry(screen, monitor, &monitor_geom);

 		width = monitor_geom.width/2;
```

Best Regards.


blah 1


What is the meaning of this?


Comment on commit


Update the DI docs accordingly


gracias migue!

nada mas falto q en el modificar, si es envase y hay uno seleccionado, aparezca seleccionado al cargar la pagina. pero no pasa nada ya lo hice.

saludos


I still think this should go ins install://

```
<?php
/**
 * @file
 * Install file for DKAN base migration.
 */

/**
 * Implements hook_disable().
 */
function dkan_migrate_base_disable() {
  dkan_migrate_base_migrations_disable();
}

/**
 * Implements hook_install().
 */
function dkan_migrate_base_install() {
  dkan_migrate_base_update_7000();
}

/**
 * Adds column to migrate_map_dkan_harvest_data_json.
 */
function dkan_migrate_base_update_7000(&$sandbox) {
  $table = 'migrate_map_dkan_harvest_data_json';
  $field = 'modified';

  if (!db_field_exists($table, $field)) {
    $modified = array(
      'type' => 'varchar',
      'length' => 32,
      'not null' => TRUE,
      'default' => '',
      'description' => 'Field added by dkan_migrate_base',
    );
    db_add_field($table, $field, $modified);
  }
}
```


Are you sure in that the value for `value-pairs` is correct? (shouldn't be it set to 5?)


Sorry about that.
Thanks.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 314](https://teamcity.labkey.org/viewLog.html?buildId=266168&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0 Build time: 00:02:29
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


No, it's not the root certificate. Mine has something about "Entrust, Inc." in it. If you don't come right, we can have a look at it tomorrow.


I'd use a name instead of numbers as an argument for `create_object` (enum, static const int, whatever).


Sure. I will add


but,... there are no "available libraries" at all...


imo, any of the below assumption are not proven/confirmed with tests as for now. these are our expectations from NDN. if I was a reader, I would expect some confirmations of these later in the paper


You use motherboard then uses mainboard then mother again... you do this in several places on code. You need to uniform it.


haaaaaaaaaaa, cierto que me dijiste y lo olvide jeje. no lo tenia anotado anoche y por eso me olvide.
okas, de nada wachin!
nos vemos maniana, salutes!


Yep. I will revert it to the placeholder code and just work locally.
Once I have a fixed version I will integrate it

> On Aug 12, 2015, at 9:58 PM, mandyfoster <notifications@github.com> wrote:
>
> Hey Mike, I just updated my installment of the application and I am running into an error on the index page. Here's the error, let me know if you have questions/solutions
>
>
>
> —
> Reply to this email directly or view it on GitHub.
>


:sunglasses:

i love ryan florence's videos.


真好。。


What happened to the player prefab? Its gone!


ClusterRoleBindings are never in a namespace.  They have global effects.


Hvad hulen er det du laver?  Er du sikker på at du har Git-kørekort?


wts local PremadeNotifierSaved = PremadeNotifierSaved or {}


Just don't talk about attribute restrictions.


Yes. Can we remove this test from here and only have test in controller for saving?


Let me see if I can rework this and #48 to use only the last-modified header returned by the server.


@progirep Is the new plugin introduced in this commit related to this issue #5 in any way? Also, which paper does the commit message refer to? This one? https://scirate.com/arxiv/1503.01793 Thanks :smiley:


I will add them.


can reference any Role in the namespace or ClusterRole in the cluster.


@mattlevine add a semi colon at the end of this line.


The master namespace is no longe rspecial.


Trivial. Merging.


If distance is not None (use dijkstra), `path_length` returns a dict of dict hence `sp` is a dict of dict.

In else condition we unpack `sp` to `node` and `dist_dict` (distance dictionary)


Soll Spoiler wirklich so aussehen oder gehen wir nach dem offiziellen Markdown
`>! Spoiler text text`?


all tests pass:
success: http://buildbot.bos1/builders/test-cuttlefish/builds/168


PluginZoneInitialization (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


@yehudasa Done.


The main.min.js is not minified!


I usually only inline one- or two-liner methods.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-77.18%25-red.svg)


dale, hasta mañana!


This looks like an inconsistency between the name and behavior of the method: `> 1.8 != 1.92+`


miss this code!


I think Bran has moved it to _character

Sent from my Windows Phone
________________________________
From: TrevorJohnston<mailto:notifications@github.com>
Sent: 13/08/2015 19:08
To: lunagames/luna<mailto:luna@noreply.github.com>
Subject: Re: [luna] Merge remote-tracking branch 'origin/master' (2f6811c)

What happened to the player prefab? Its gone!

---
Reply to this email directly or view it on GitHub:
https://github.com/lunagames/luna/commit/2f6811c3bb6cb6379164f8a51a537bbe991c3be1#commitcomment-12695633


Yes, both are of ExternOption type.


Thank you


Der Eintrag muss 208.ntp.ffmz.org statt 200.ntp.ffmz.org heißen.


Is there should be "locale" instead of "local"?


Good catch, this works for me.


Yeah, Sfx prefix is somewhat redundant, though its intended to indicate that the channels are intended for sound effects only. If you feel a prefix is unnecessary we can certainly remove it.


honestly i don't remember why i'm casting to a char* here, looks a bit weird


This was fixed on the API side of things but wasn't fixed on the implementation side.


can probably remove this class later


@m-kuhn there is a :code: role for inline code but I don't know if it will be properly formatted, you can try and see what happens.


onDrawFrame() is called from native, just before onDrawEyeView() is called also from the same native place for each eye. So, it makes sense to be here, and also addressed my previous two concerns automatically. On running a sample app, I don’t see any anomaly.


@jasdel s/dynmamodbattributes/dynmamodbattribute


VoCCN paper doesn't say much about it's architecture other than that:
"In the content delivery architecture of CCN, Inter- ests and Data flow in lock-step, each Interest retrieving a single data packet. In a dispersed or high-latency net- work, the round-trip latency can easily be large enough to delay reception times of media packets to the point where they become unplayable. To solve this problem, we employ pipelining by sending Interests for multiple future media packets. The CCN media receiver main- tains some number of outstanding Interests in a media stream; when the stream is opened (or as network con- ditions change) it generates a number of Interests. Each time it receives content for that stream, it produces a new Interest, thereby maintaining the number of out- standing Interests in the pipeline."
technically, we do the same, but we have introduced "lambda" to control outstanding interests. There is no information on how many outstanding interests VoCCN has, is this number static or dynamic, etc. The description in the paper is very high-level, I think...


a good reference for this is https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Inline_Functions

As we don't know which helper we need in future we should use the safer approach and switch over to static methods IMO


Hello, I found this post via google, and this is what I want to do, change the copy and paste but to Ctrl+y to copy and Ctrl+v for paste. You have termite.1 but on the default repo there is no termite.1 ... I don't really know much about c, can you help me out on what do next? Where do I put this change, to the default repo and then compile it?


Would also be cool to include the output from Println in the example


simple output change


Not sure if there is a better way around this, we don't have the real name until we get the descriptor file but as far as I can see the temp name given here is only used in temp directories for download. Please correct me if I'm wrong about this.


May be we should add additional check in another test (or create a new one) for testing that by default this property is `true`?


Hi partner!


But on Linux, I don't need to use `docker-machine`, do I?  I might get this error just from not having Docker running.

So, maybe:

```
Make sure Docker is running, and if you are using docker-machine, make sure it is properly configured.
```


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Good. However, one thing about these ending slashes:

* When the OSF Installer read the install.ini file, then it takes care to *always* remove the ending slash using `rtrim`. Check in the constructor of the OSFConfigurator.php class.

Another thing to note: when you do change the installer.ini file, you also should take a look at the `saveConfigurations` method of the `OSFConfigurator` class.


1.9.2, 1.9.3, 2.0, 2.1, 2.2 all return true for `> 1.8`.  "192_plus" is a useful way to describe that set of rubies.


No, we don't need them. They're just coverage reports. Sorry I'll fix it.  :sweat_smile:


fast-forwarding develop to borshop-integration-201-feature/jrd/validate-ip = 68d54f6b


Hey lol I just left

Sent from my iPhone

> On Aug 13, 2015, at 2:21 PM, jdaniels17 <notifications@github.com> wrote:
>
> Hi partner!
>
> —
> Reply to this email directly or view it on GitHub.
>


I'm going underground now

Sent from my iPhone

> On Aug 13, 2015, at 2:21 PM, jdaniels17 <notifications@github.com> wrote:
>
> Hi partner!
>
> —
> Reply to this email directly or view it on GitHub.
>


.sass-cache we definitely don't need. I'll fix it.


ok, but please, assign some talkative names to those numbers


Typically, if you're developing on Linux you will have docker-machine installed.  It provides the CLI tooling for controlling remote containers.  It just so happens that it MUST to be used on Mac or Windows to provide support for your virtual machine


I can try to get a test in place, but cannot warrantee that it will be
pretty


Great set of new command line tool functions. This should clarify the overall code quite a bit.


huum, I see. You suggestion seems fair. I'll spend some time thinking about the proposed solutions, thanks.


develop (macumber) - Win64-Windows-7-VisualStudio-12: OK (2216 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.24%25-yellow.svg)


Hi, Oliver.

Are you planned to include Soft Delete feature in an upcoming release soon?

Thanks in advance


I think this reverted the setclientid fix but was intended to revert the
task.error fix?

On 8/12/15, 6:34 PM, "Rebecca Turner" <notifications@github.com> wrote:

>Revert "Fix bad var name, thanks @dcollinsf5"
>
>This reverts commit 8ae9ff04c98921ae24e9447d5e5b758da8589c17.
>
>Turns out I missed that worker.js#249 was already handling this.
>Danger of second guessing yourself a year later. =D
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/iarna/abraxas/commit/f22647a8ae885267be559ddf23c0500762
>d2c284


Should the whitespace eater have munched on the second newline after the comment as well? That is, should we remove blank lines as well as trailing whitespace on the same line (including perhaps a newline) as a comment?


I found that, but it has caused a conflict that I dont know hoe to resolve. I can open unity and run the game but there is no player in the game, just a missing prefab object and a message in the console that says "The file Assets/_Character/Player.prefab seems to have merge conflicts. Please open it in a text editor and fix the merge.

UnityEditor.HostView:OnHierarchyChange()"
What can I do?


I like that, this makes the overall code much readable


Did it conflict with something or just was in need of a name change?


https://github.com/Leaflet/Leaflet/blob/master/src/layer/LayerGroup.js#L96
В лифлете используются такие циклы без проверок, вроде брат жив)


### See reviewers comments inline.
**Reviewer:** Sravan


Commitador de linha  :p kkkkkkkkkkkkk


See https://github.com/Xfennec/progress/issues/8


Taking a look in the bot environment.


Hi,
I cherry picked your commit :)
Thanks


@vais - This is probably a documentation issue (https://github.com/opal/opal/issues/1027), but in 0.8.0rc1, you could convert a native object to a hash like this:

```Ruby
stuff = Hash[`{url: 'something'}`]
```

Now, that gives a no method '$respond_to?' error when that coerce_to is called. I'm not sure how I got in the habit of converting native objects to hashes this way but I suppose it accidentally worked.

Maybe the docs should emphasize that `Opal.hash()` is the only supported way to go from native object->Opal hash (or maybe it was just my bad habit) but I wanted to make sure this wasn't an unintended side effect.


**Category:** Awesome
Good job building and compiling with the latest SDK available!


**Category:** Awesome
Good job supporting users of the latest Android API while also extending support to older API users!


I would use https://www.npmjs.com/package/qs instead, more robust.


**Category:** Awesome
Great job using `Serializable`, though I'd recommend you to use `Parcelable`. Here's why - http://www.developerphil.com/parcelable-vs-serializable/


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


For the miniclient/OpenGL files...you definitely need those on Linux for the miniclient. So they should not be excluded overall.


@sublimator is this still a problem? if so, where is this error happening?


Sure


Maybe that's why I found Docker so hard to work with... :stuck_out_tongue_closed_eyes:


91977808_LBNL_NewVRFModel (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (1799 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


**Category:** Nitpick

I'd recommend you to use `SearchView` along with `SearchView.OnQueryTextListener` - https://developer.android.com/guide/topics/search/index.html and https://developer.android.com/reference/android/widget/SearchView.OnQueryTextListener.html

That way you wouldn't need to write your own `TextWatcher`, `Handler` and your code can be a lot simpler.


Mit der OID des Kindes werden hier doch die Kinder des Kindes glesen, oder? Mir ist das hier noch nicht ganz klar...


**Category:** Critical

`ActionBarActivity` is deprecated! Use `AppCompatActivity` instead!


Don't get why you need this?


@cmungall @kshefchek  we need `--force` for npm install so it can grab the most recent version of the phenogrid release_2015-08-06 branch. This explains why phenogrid hasn't been updated on beta server.


test


I told you: not lazy, but :scream:


Rebase your tree instead


I did this commit in the wrong branch. then fixed it in another: https://github.com/ohnosequences-bundles/samtools/commit/c5f86631a26063ba95548d8f75fb5168e240f7ce


Wenn es nur um ein Kind geht, dnn ist mir der Unterschied zur unteren Methode nicht ganz klar. Wenn es darum geht, alle Eltern / Kind beziehungen zu löschen, dann ist mir nicht klar, was da die OID des Kindes macht.


**Category:** Awesome

Good job having all your string messages in the `strings.xml` file. This is the right way to do it.


Bryan,
please do not review this branch. I created a remote branch just to make sure my changes are not lost.
I will raise a PR tomorrow, both for vso-node-api repo and vsoagent.
Got the client auto generated already, with Teddy's help. Need some time to validate.


Nice!  This is a really handy function!!!!!!!!
:dancers:


Bitte nicht delete nennen. release oder so ist besser. Wir löschen hier ja nichts.


**Category:** Nitpick

You seem to have an empty menu item that does not seem to serve any purpose. The end user might think your app is broken, or even worse, incomplete. We wouldn't want that would we!


It caused bootloops on starting the phone, only after putting the device on the freezer it booted


got it. promise help to keep code clear. Wil make changes and convert to promises.


In this case, the computation was failing because the adapted object returned by the ModelAdaptor doesn't have the Store prototype any more. To me that sounds reasonable, but I'm not sure if it's correct or breaking.


Please have a look at [how we did this](https://github.com/samuelgruetter/icfpcontest2015/blob/f6dd31eb1e1887dad21b7718b7433aacfd9ea75c/proj1/src/main/scala/JsonRead.scala) and get excited about how much boilerplate spray-json's `convertTo` can save you ;-)


Just tap under the chat button to open like evergone used to do.


Thanks Joe!

The Si5351 datasheet says that it has NVM for configuration, but it is one-time programmable (p17 of the datasheet) and I believe that capability is only available from Silicon Labs. So if you would like to have a different default set of outputs, you'd need to order a batch to your specification from Silicon Labs.

On a side note, the very first order of Si5351A that I received appeared to be a custom batch like this that accidentally slipped out into the wild. It even responded to a different I2C address than the normal 0x60! So it does appear the Silicon Labs can customize a wide variety of the Si5351 parameters for you. This is how many of their other clock generator ICs work (most of them are not user-programmable in the field).


93653360-ResetVarsAtEndOfWarmup (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Better to pass the `request` to the lookup method to avoid the thread local lookup which is more expensive


I'm not sure that this should be special-cased here or at the call, and I'm also not sure that just returning a new KeyModel is correct.


Thanks @hottwaj. One last bit. Could you make a test for this? It might seem silly for something so trivial, but it's primarily to catch py2/py3 differences. I've been amazed at what can crop up.

A new file like test_template_tags that checks a setting is correctly fetched, update it, fetch it again, is all that is needed. If you aren't comfortable making tests, I'll get around to it at somepoint.


Hey Peter, what is the relation between ScheduleApp folder and SchedulerApp? does one supercede the other, if so maybe we should delete the older one?


remove alert.


**Category:** Nitpick

It's recommended to have all your dimensions values in the `dimens.xml` file. That way you a single source to edit all your values at once if the need ever arises. You could refer to the values as:

```xml
android:layout_width="@dimen/<your_dimen_here>"
```


91977808_LBNL_NewVRFModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1799 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


you forgot to prepend `app-misc/carbon-c-relay: ` to the commit message summary


Mir ist nicht klar, wozu du die Schleifen brauchst. Mit der OID des Kindes sollte genau ein Treffer zurück kommen. Dafür kannst du die read Methode im Bürger verwenden (auch das Kind ist ein Bürger). Dann holst über die selbe Methode den Elternteil und löscht die Beziehung.


`get` is not scoped to `options`, so it doesn't participate directly in the shuffle. It lives at a higher (lower, closer to root?) branch in the tree. Here again, that seems reasonable to me, but it looks like a breaking change.


**Category:** Awesome

Maybe you could use that incomplete menu item to show a Settings screen where the user gets to pick a country of their choice! Be careful to anticipate situations where in Spotify isn't supported in certain countries!


r+


@wied03 it wasn't accidental.


remove alert


Nice!!! :+1:


Thanks!


Что это за калькулятор такой? :dancers:


Cool!!!


@btmar Das bitte nochmal überarbeiten - siehe Kommentare oben


**Category:** Nitpick

Although we're only displaying a small number of items in our `ListView`, it is always recommended to use the `ViewHolder` pattern for efficient memory usage. The official docs have all the info you need - http://developer.android.com/training/improving-layouts/smooth-scrolling.html#ViewHolder
Good job implementing the `ViewHolder` pattern. :)


use `[ -d "$1" ]`  instead of `[[ -d $1 ]]` . the double bracket is a bashism. always quote the $1 or u'll have a bad time


Should not fail silently. Remove that line and have it error. This kind of programming error is not to be permitted.


surprisingly pwd -P is found in osx too, not sure if in android too, can someone confirm?


By have it error I meant just letting the natural error occur. You could make it throw a special error when text is nil or not of the right type, but in this case that's really not necessary.


already defined at line 45, with a more adapted value.


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1275 of 1275 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.75%25-green.svg)


quoting inside quotes just unquotes the path which results in possible command injection


I guess the 6 key is a little close to the 5 key on my keyboard! Thanks for the catch! :+1:


this patch is done not on top of master, which results in bad merge


saw approval from jedmccaleb
at https://github.com/FredericHeem/stellar-core/commit/4bb83a146228300d94deb0f667f4df77e9ce9640


merging FredericHeem/stellar-core/assetCodeToStr = 4bb83a14 into auto


FredericHeem/stellar-core/assetCodeToStr = 4bb83a14 merged ok, testing candidate = b2762125


Can't you just pick the first value in the list as the max and then compare against that?


Errrou


Removed after. OK


Nvm, I'll do it


@terrafrost The ampersand is not being removed here, it is being added.


You know I only moved it to the top eh? It was there already. I will get rid of it.


Have you tried deleting your local copy of the Player prefab and then syncing again from your desktop?

Sent from my Windows Phone
________________________________
From: TrevorJohnston<mailto:notifications@github.com>
Sent: 13/08/2015 19:29
To: lunagames/luna<mailto:luna@noreply.github.com>
Cc: waynehelley<mailto:waynehelley@hotmail.co.uk>
Subject: Re: [luna] Merge remote-tracking branch 'origin/master' (2f6811c)

I found that, but it has caused a conflict that I dont know hoe to resolve. I can open unity and run the game but there is no player in the game, just a missing prefab object and a message in the console that says "The file Assets/_Character/Player.prefab seems to have merge conflicts. Please open it in a text editor and fix the merge.

UnityEditor.HostView:OnHierarchyChange()"
What can I do?

---
Reply to this email directly or view it on GitHub:
https://github.com/lunagames/luna/commit/2f6811c3bb6cb6379164f8a51a537bbe991c3be1#commitcomment-12696198


Please see the reviewer's comments inline in the previous commit:
https://github.com/ashapka/SpotifyStreamer/commit/aea31cc39bb02b62bc40ae0cfd38d04a1a365e3e

This commit covers most of it with minor extras.

Things left behind in this commit that will be covered later.

TODO:
1. Implement a ViewHolder pattern.
2. Add SearchView.OnQueryTextListener.


The way to do it without breaking backward-compatibility would be to use
object observers, which would break older browser compatibility. Our
architecture has observable models (always using getters and setters) which
works in all browsers.  For BufferGeometry, it's difficult to alter
geometry data directly. So, a clean API to change BufferGeometry internals
could also set this flag, solving the two problems at once.

On Thu, Aug 13, 2015 at 1:40 PM, Mr.doob <notifications@github.com> wrote:

> Couldn't the typed geometry conductors create (Buffer)Geometry and also
> save their creation parameters along with a flag indicating if the geometry
> was altered?
>
> That would be ideal, but I don't know how to detect when the geometry has
> been altered.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mrdoob/three.js/commit/4278ba2f195aa2bcb2569a787342527f8b06a196#commitcomment-12695044>
> .
>


Кстати, это мелочь, но все-таки пропиши Description вместе с лицензией и все дела


Merged already


Sorry. Should have used the word temporarily.

sent from my mobile device
On Aug 13, 2015 12:45, "meh." <notifications@github.com> wrote:

> @wied03 <https://github.com/wied03> it wasn't accidental.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opal/opal/commit/5a709511b4e81f8a571f84e3bca0e1aa7b341481#commitcomment-12696555>
> .
>


should these imports be used?


@lastquestion maybe do:
```coffee-script
spy = sinon.spy(@discoveryWatcher.request, 'abort')
expect(spy.called).to.not.be.true
```


OK - just peaking to hopefully direct before too far :)


I don't think it should. Right now we remove the trailing whitespace and a single newline. If we remove all blank lines there we will be restricting a way for users to intentionally add blank lines.


Can be better ;-)
std::cout << "[" << std::setw(3) << p << "%]\r" << std::flush;


AvSoundFile


I regret I did find this issue earlier. it seems that once upon a time the relation between response and response_map is 1-to-1. But not this relationship is 1-to-n. (On ResponseMap may have mayn Responses).

After this change, "response_map_object.response" will not return 1 Response object, but an array of Response objects. This change will break ~50 places in Expertiza code and I am fixing it.

Team, if you have error message related to response and response_map, please let me know.


I may be able to get rid of this altogether.  I am trying to find a scenario that doesn't work when I remove the `setRenderView(false)`.  I am not yet sure that it is needed.  @graemerocher Do you know why this might be needed?


Thanks Jason.

I remember you writing in your blog about the wacky configuration on the first set of chips you received.

Too bad about the NV configs...I thought I read those registers were one-time writable by the user.
I was hoping to make a little universal crystal replacement board for my own use, but I guess it’s not going to be so simple. Maybe I can find some small, cheap MCU and put it on the board to load up a startup config?

Regards
Joe

From: Jason Milldrum
Sent: Thursday, August 13, 2015 2:42 PM
To: etherkit/Si5351Arduino
Cc: joedarock
Subject: Re: [Si5351Arduino] Merge pull request #16 from etherkit/dev (c5e2e2a)

Thanks Joe!

The Si5351 datasheet says that it has NVM for configuration, but it is one-time programmable (p17 of the datasheet) and I believe that capability is only available from Silicon Labs. So if you would like to have a different default set of outputs, you'd need to order a batch to your specification from Silicon Labs.

On a side note, the very first order of Si5351A that I received appeared to be a custom batch like this that accidentally slipped out into the wild. It even responded to a different I2C address than the normal 0x60! So it does appear the Silicon Labs can customize a wide variety of the Si5351 parameters for you. This is how many of their other clock generator ICs work (most of them are not user-programmable in the field).

—
Reply to this email directly or view it on GitHub.


Thanks, man! My fault. :grin:


And if that fails, maybe try it with the while project

Sent from my Windows Phone
________________________________
From: TrevorJohnston<mailto:notifications@github.com>
Sent: 13/08/2015 19:29
To: lunagames/luna<mailto:luna@noreply.github.com>
Cc: waynehelley<mailto:waynehelley@hotmail.co.uk>
Subject: Re: [luna] Merge remote-tracking branch 'origin/master' (2f6811c)

I found that, but it has caused a conflict that I dont know hoe to resolve. I can open unity and run the game but there is no player in the game, just a missing prefab object and a message in the console that says "The file Assets/_Character/Player.prefab seems to have merge conflicts. Please open it in a text editor and fix the merge.

UnityEditor.HostView:OnHierarchyChange()"
What can I do?

---
Reply to this email directly or view it on GitHub:
https://github.com/lunagames/luna/commit/2f6811c3bb6cb6379164f8a51a537bbe991c3be1#commitcomment-12696198


since the send_email_message() method no longer actually sends an email, should we rename it something like add_email_message_to_queue() or create_email_message()?


*whole

Sent from my Windows Phone
________________________________
From: TrevorJohnston<mailto:notifications@github.com>
Sent: 13/08/2015 19:29
To: lunagames/luna<mailto:luna@noreply.github.com>
Cc: waynehelley<mailto:waynehelley@hotmail.co.uk>
Subject: Re: [luna] Merge remote-tracking branch 'origin/master' (2f6811c)

I found that, but it has caused a conflict that I dont know hoe to resolve. I can open unity and run the game but there is no player in the game, just a missing prefab object and a message in the console that says "The file Assets/_Character/Player.prefab seems to have merge conflicts. Please open it in a text editor and fix the merge.

UnityEditor.HostView:OnHierarchyChange()"
What can I do?

---
Reply to this email directly or view it on GitHub:
https://github.com/lunagames/luna/commit/2f6811c3bb6cb6379164f8a51a537bbe991c3be1#commitcomment-12696198


Nao foi ficou


TeamCity pull requests :: netty [Build 26](https://garage.netty.io/teamcity/viewLog.html?buildId=311&buildTypeId=pulls_netty&guest=1) is now running


@jbenet I just noticed this change. This is bad. If someone were to add a large file using the onlyhash option, it would be stored entirely in memory.


Do we want to delete old attachments all the time? Aren't we still going to be selling old files, potentially? Then again we will have uploaded the assets to the remote provider...

IDK. What do you think?


*whole


Yeah, that didnt work. guess I'm gonna have to delete everything and re-clone again.


This causes yet another staging mass-rebuild, preventing it from being merged into master, and thus preventing us from making a new release. Is upgrading texinfo really that important?


Apparently we can't reuse `args` in a loop. It is undefined after `vsnprintf` call. From man-page:

> The    functions   vprintf(),   vfprintf(),   vdprintf(),   vsprintf(),
> vsnprintf()  are  equivalent  to  the  functions  printf(),  fprintf(),
> dprintf(),  sprintf(),  snprintf(),  respectively, except that they are
> called with a va_list instead of a variable number of arguments.  These
> functions do not call the va_end macro.  Because they invoke the va_arg
> macro, the value of ap is undefined after the call.  See stdarg(3).

We have to make a copy for each iteration. Since we don't need more than two iterations, maybe is better / clearer just to unroll the two calls and get rid of the loop

    va_list args_copy
    va_copy(args_copy, args)
    total = vsnprintf(p, space, fmt, args_copy)
    if (total >= space) {
        ensure()
        ... = vsnprintf(..., args)
    }


![screenshot_5](https://cloud.githubusercontent.com/assets/10588116/9258922/d219a2c4-4206-11e5-9714-dd8669c492d2.png)

просто что бы потом меньше багов фиксить. я сразу исправил, когда заметил.

там кнопка вылазила.


As per the [Swagger REUSE practices](https://github.com/swagger-api/swagger-spec/blob/master/guidelines/REUSE.md#guidelines-for-referencing) there are two types of referencing - internal and external. I agree that all internal references should be present in `#/definitions` but i do not think we want all external references to be referred in `#/definitions` as well. We can take a third opinion on this as well to let things flowing.


@barbieri ^


The functions at the top look like they are borrowed from sbml.py. We can import them instead.


NB : There has been 3 unversioned versions of this project before I first pushed to GH


What if the first item is null?


it may requires to use Transcoder (from AvTrasncoder) like to not open 5 times the same file, and to read only one stream into each one.
It decrease performances...


we should try to harmonize this a little. I suggest right now `epitope_mask` is global, while the other functions are methods of `H3N2_process` which doesn't make a lot of sense. The fitness model class right now doesn't know about the frequencies etc. we should probably fitness model a subclass of the process.


FixSlabTransition (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


What I asked was you to create two separate projects one with IService.cs (Contract) and Service.cs (behavior). Then create another project where refer this project assembly and delete everything and just keep the .svc file and refer the previous project's contract and behavior from within. You will need to keep a config file also along with the .svcfile


Maybe we can add a Decoder, just to create similar fonctionnalities than Transcoder, without encoding part.


Previous discussion in 303e81bb5eb87ede85129d0ff650226f0c9218aa.


Duplicate rel attribute. Please fix.


Got it... thanks.


Seems the following two can be final.


why are you hard coding the path here, are you sure that this path will be there in all the instances?


data is first validated by `javax.validation.Valid` here:
https://github.com/osu-mist/sad-api/blob/29854b2c6e30086f64e28e8b50f24572d1fd9fe2/src/main/groovy/edu/oregonstate/mist/sadapi/resources/SadResource.groovy#L51
this enforces type and any constraints specified in the representation class, such as `@NotNull`. java types are also enforced when this method is called. sql types are enforced by registering input and output parameters as with `statement.setString()`, and database constraints are enforced by the stored procedure call.

most of the business validation is in the database. for example, `pidm`, `termCodeEntry`, `applNo`, and `seqNo` are bound by a primary key constraint. `apdcDate` is bound to an oracle date type whose value i believe may be arbitrary. the values of `apdcCode` and `maintInd` are restricted to values contained in validation tables (see CO-144).

the api will return failure when data fails validation at the application or the database layer. currently the error messages are not descriptive, but i plan to improve error handling in CO-169.


Okey doke. If that works then the conflict must have been between the repository and what is on your desktop.

I'm still getting my head around GitHib so I'm a bit unsure what to do to stop this happening again. Just make sure you sync before doing any changes and discard any thing you change which you don't want to commit


It might be worth noting in the README which version of DSE that is required for this (so DSE 4.7.2 or greater I believe is where Spark 1.2.2 is introduced).


Doubt its compatible now but #6377 creates indexed BufferedGeometry from Geometry and deals with updates to Geometry to updated the indexed BufferedGeometry


There values may be modified in `run()`.


Yeah, I guess it depends a bit on the store implementation. I'm happy to
let old attachments sit for a while.

Though also, my deleteOldAttachments method is the only thing in this code
that is not working right now.

On Thu, Aug 13, 2015 at 3:00 PM, Drew Westphal <notifications@github.com>
wrote:

> Do we want to delete old attachments all the time? Aren't we still going
> to be selling old files, potentially? Then again we will have uploaded the
> assets to the remote provider...
>
> IDK. What do you think?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/divmazie/jonathancoulton-theme/commit/922bfa9deaa109feb6f89cd1a00a4fda6f6eb73d#commitcomment-12696844>
> .
>


The convention is using an explanation in the present, like:

>// Fprint formats using the default formats for its operands and writes to w.
// Spaces are added between operands when neither is a string.
// It returns the number of bytes written and any write error encountered.

http://blog.golang.org/godoc-documenting-go-code


SBuxAppDBConnection