@buunguyen @mlzummo I'm currently working on the implementation of Theme serial strings. The ThemeEditor widget will be changed in the very near future (especially segments that deal with localStorage).


OK. How about this:

We test the entire set of filters each time, and compare that the results contain only the filters that are expected to pass. So there should be some tests that return the full set of filters, some that return none, and some that return a partial set.

I'll also rename and add better docs to the `check_filters` function.


See inline comments and also refactor as per discussion.


I think this is calling out for encapsulation and refactoring. Please create a new component (pair of files .h and .cpp) for your ExprTree class and encapsulate its data members and move expressionPruning() and rebuildCondition(). Essentially, you will create a component that given a conditional statement can be pruned or can rebuild condition.


@hbun DWMR. Well done here. Press on!


I am not sure if you are notified automatically about my comments.


This snippet is strange enough that it probably warrants a code comment.  For instance, why do we transfer the role from the user only if the role is 'Volunteer'?


Commit inicial.


This was great. Good job.


cool story


NewDesignDocWorkflow (nmerket) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


CVector4 is a very good idea!


Most of this code was originally part of the `FileRegexTest` implementation. I factored it out for two reasons:

1) It added more complexity to that class than I thought it needed.

2) I want us to handle message definitions like this consistently everywhere, which means that things like `dangerous` flags on API calls will all just report their messages via this function and have consistent behavior.

I added the `format_kw` arg here for the same reason (I think a lot of those messages would benefit from being able to include better context information). But now that you mention it, I agree that it should probably be a separate helper function.


Thanks for the reassurance, Howard.  That's good enough for me.


wooooo

On 08/12/2015 02:02 PM, Elias Mulhall wrote:
>
> Almost there.
>
> ________________________________
> From: Arjun Guha <notifications@github.com>
> Sent: Wednesday, August 12, 2015 12:53 PM
> To: frenetic-lang/frenetic
> Subject: Re: [frenetic] Attempt at an integration test. (825a818)
>
>
> does it all work?
>
> -
> Reply to this email directly or view it on
> GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_frenetic-2Dlang_frenetic_commit_825a818e7cde1848aafa32ee1070f68041371af3-23commitcomment-2D12671038&d=BQMCaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=9uJ1MTIb3OfjizUC8w0LFB5bkDjp8GEkesh-KK6ylg0&m=dfqAH2-pTbb06fEAUCHrGcrc3s8MlEwh7JHGlyi29cc&s=1uq6q-fkgcMpDVYIOklLxu8pw8u0tLkH1yIXtfgGWOA&e=>.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/frenetic-lang/frenetic/commit/825a818e7cde1848aafa32ee1070f68041371af3#commitcomment-12671349>.
>


@mlzummo I'm using Chrome. If you don't have this error, probably because you have `themeEditorSerials` in your local storage.

@jbrundage how about setting the default to an empty object (or whatever value that doesn't throw or make any program's behavior incorrect)? Like: `JSON.parse(localStorage.themeEditorThemes || '{}')`


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Duh, should have tested that...

I was thinking that the very-similar-looking stuff in BindNetworkArgs below was additional command-line options, but it's not.


Missing space after comma.


For now. This is used for JS string regex texts, at the moment, but my plan is for it to be used for the values in `dangerous`, `readonly`, and such flags.


STM32F407 is rated to 168MHz and STM32F427 is rated to 180MHz, so this is overclocking both parts.


@caco3 Can you please send pull requests in the future :) thx


It's technically well-formed, but I agree it's poorly written. I'll try again.


ping @jancborchardt


when it fails, it will be very confusing which line causes fail


I don't think they're extraneous. I found this really hard to parse without the newlines.


RadianceRefactor (rpg777) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.2%25-red.svg)


sry!
Github gave me the impression this is the way to go :(


@yuyichao, this has stopped strings with interpolation from being recognised as docstrings:

Before:

```
julia> """
       baremodule M
       "\$(1 + 1)"
       f(x) = x
       end
       """ |> parse
:(baremodule M # line 2:
    @doc "$(1 + 1)" f(x) = begin  # none, line 3:
                x
            end
    end)
```

after:

```
julia> """
       baremodule M
       "\$(1 + 1)"
       f(x) = x
       end
       """ |> parse
:(baremodule M # line 2:
    "$(1 + 1)" # line 3:
    f(x) = begin  # none, line 3:
            x
        end
    end)
```

Apologies for not checking that earlier.


@griffinmacias We might want to make a bool property to check if its been shown, it displays itself again when the wiki page dismisses


1. `QList<const CSwordModuleInfo*>` is actually a `QList` of pointers to constant `CSwordModuleInfo` objects. I think it were better that the name reflect this, although it will be a long name. The `C` prefix is actually deprecated, newer classes should instead use `Bt`. To keep the type name shorter I suggest to drop `Sword` and perhaps even `Info`, So I suggest the type be called `BtConstModuleList` instead.
2. It would simplify things to move this typedef into a separate header file, because then other files can include that header file instead. The contents of it may be something like
```C++
class CSwordModuleInfo;
typedef QList<CSwordModuleInfo *> BtModuleList;
typedef QList<CSwordModuleInfo const *> BtConstModuleList;
```

PS: In the future we should probably rename `CSwordModuleInfo` to `BtModule` or something like that.


If that becomes the case we can refactor. IDs stylistically convey that css changes will not affect other parts of the code, since there is only one.


run: bundle update spree_contact_us

Then restart your webserver


Gurr... I just can't spell canola ...


Sorry, not implemented what?


What's up with this? Gonna make a fix.


I think you can use <%- instead of <%= to handle the escaping for you.


The changes in this file should go to a separate commit, because these have nothing to do with `CSwordModuleInfoList`.


I think this is backwards!


How about this?

```
    <#if ext.defaultValueAssignment?? >
        <#-- if the assignee property is a primitive, defaulValueAssignment will not be set -->
        if ( ${sourceReference} != null ) {
            ${ext.targetBeanName}.${ext.targetWriteAccessorName}( <@_assignment/> );
        } else {
            ${ext.targetBeanName}.${ext.targetWriteAccessorName}( <@_defaultValueAssignment/> );
        }
    <#else>
        ${ext.targetBeanName}.${ext.targetWriteAccessorName}( <@_assignment/> );
    </#if>
```
Extract that whole thing into a <#macro ..> and re-use it below... (in the try { ... } block which is used in case the property mapping method declares any exceptions)


Builds fine, but...

     5>------ Rebuild All started: Project: shader, Configuration: Debug Win32 ------
     5>  Building Custom Rule C:/Users/Mario/GitHub/SFML/examples/shader/CMakeLists.txt
     5>  CMake does not need to re-run because C:\Users\Mario\GitHub\SFML\build\vs\examples\shader\CMakeFiles\generate.stamp is up-to-date.
     5>  Shader.cpp
     5>LINK : warning LNK4098: defaultlib 'LIBCMT' conflicts with use of other libs; use /NODEFAULTLIB:library
     5>  shader.vcxproj -> C:\Users\Mario\GitHub\SFML\build\vs\examples\shader\Debug\shader-d.exe

Same for all other builds using **sfml-graphics**. Haven't had a closer look, but I guess it's due to **jpeg.lib**.


Indeed good catch.
I have prepared a rather quick "solution" that at least can be used to clarify the issue in the future.

I have checked other places where npc_escortAI::MovementInform was called and i think they must be ok.
But of course we need to consider the glitch that in the past both sd2-escort movement as well as (any) point-movement would have been called POINT_MOTION_TYPE.
So glitches can still happen..

However there is still another issue with the quest - evidently on MoveTargetHome when reaching the last waypoint, MovementInform is not called, hence I need to think a little bit what is best here


This is the spot I mean in the comment above... :)


Again, backwards. `0xff` = `ÿ`


If you change the type of `mods` to be `QList<CSwordModuleInfo> const &` the rest of the changes in this file are not necessary.


@buunguyen Agreed, that would patch the problem


You corrected the wrong one, the 16BE one was fine, the UTF-16 one was backwards.


Volume->is_moounted can die if the system call to df returns no such file or directory. I can put the try/catch back in, and skip the volume if it is not mounted. How does that sound?


@brian-swango So their are benefits to hard-coding things that are used exclusively and not for things that are more...general? What would be the downside of adding complicated boss encounters to the DB?

So is their in-depth instructions on discovering accurate event/action lists, and implementing them?

Thanks for the info, it really clears up the cloud in my mind. :)


We would like to return a list of non-const modules to install them later...  Your point?


Oh, yikes. No, you hadn't mentioned this (to me, anyway, but I see a mention months ago in the gitter logs). I would say "well, we should fix that", since Windows does support Unix-style symlinks as of Vista, but there are two problems there:

* "as of Vista"
* by default, the SE_CREATE_SYMBOLIC_LINK_NAME privilege is required in order to create symlinks

It's starting to feel like this isn't going to be doable.

The thing that's ultimately driving this for me is that the fscache patch makes things *much* faster. If it were in mainline Git, I'd have no problem just using msys2 git, but I assume it's separate for a reason.


This is awesome! :+1:


use document.createElement('li');

document.createElement('input');


`p` --> `package` ?
`ppp` --> `packages` ?


aye. they were. been coding from medical facilities as I cart me mum around. #ty. looks like i fixed'em all.


Hrmpf, yeah I just used CMake instead of actually adjusting the parameters. Will have to rebuild jpeg again.


It seems this is only required when using the deadletter exchange. Would be better to only do this when it's required.


Sorry to hear about your mom!  (I just noticed this BOM problem following a Tweet about your code today)


Oh, this is quite old and I think actually not needed...A lot of things in GC changed. However yes, it could be in main repo, but well...in that times I was not quite experienced with this all :P


I'm not particularity opinionated about this. I find it nice when a normal text sentence ends with the period to signify this. Like in this example:

```scala
 /**
 * A wrapper for a default value for the injection and for its identifiers.
 *
 * It is here to make injection constraints look like natural language.
 *
 * @param default default value for injected instance. It would be used if biding is not found in the `Injector`.
 * @param initialIdentifiers identifiers
 * @tparam T type of the dependency being injected
  */
```

I find it nice that both sentences "A wrapper for a default value for the injection and for its identifiers." and "It is here to make injection constraints look like natural language." have period, since they are part of the bigger description text. From the other had i feel that it's fine to skip the period in parameter descriptions, since they are often short partial sentences.

But again, It' just a explanation of why I added them. I don't have a strong opinion about this :) What is more important, I think, is that when we generate the html scaladoc, the sentences do not follow each other on the same line without any separator (it was the case with some of them, since they had no period or empty line between them)


Should be: Declaring deadletter exchange


Oh, wait, the BindNetworkArgs code *does* do that, and command_test.go tests it. (I just confused myself before because "openshift start --portal-net=foo" gave an error, but that's because I forgot "master".)


Should be: Failed to declare deadletter exchange


Out of curiosity: why was this move required?


@kinsomicrote what branch are you on? I needs to be backported into `3-0-stable`


The homepage version supports bookmarkable URLs. I'd love to find a nicer way to implement this feature.


I will prefer that we reorganize the exiting `tIoctlDllCalAsync` structure as below instead of creating a redundant structure type. what is your opinion?

```C
typedef struct
{
    tDllCalQueue    queue;
    size_t          size
    void*           pData; // Placeholder since the frame could have any size
}  tIoctlDllCalAsync;
```


I'd say leave it in unless it was causing other problems.  That way, it can make as much progress as possible during each execution.


Enterada y recibido :)


Those were flamingo variables ;)

Following commit changed them to 'directory_name', which is the proper
naming.

FWIW, 'directory names' are 'build', 'distribution', 'etc', 'makers',
'materials', 'segments' and 'stylesheets'.

So the idea of a 'directory name' is somewhat more specific in our usage
than it would appear.

Only a few commits away from completely Wrangler removal!

On Wed, Aug 12, 2015 at 2:57 PM Josiah Wolf Oberholtzer <
notifications@github.com> wrote:

> p --> package ?
> ppp --> packages ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Abjad/ide/commit/20300abb184d5ea6dce42934ed05860e3998f191#commitcomment-12672533>
> .
>


argh. so i think i actually got them right now. i need more caffeine or need to stop for the day :-) #ty


Change to: Run Tests in Parallel and move it to after "Build Badges"


@jbrundage cool. I have some other issues with the latest (1.4.2), after I address them I can submit a PR.


Fine, but I'm still renaming it to sponsor-uber since it's more descriptive than "uber".


`canonic_directory_name` ?
`toplevel_directory_name` ?


WAAAOOOWWWW BYTE OP


GTM, tested, merging.


update the txt to: This guide explains how you can run builds in parallel on Shippable and run your tests faster than ever!


Can we represent it like forward type definition as we use forward declaration for CSwordModuleInfo. I do not like the idea to connect any header here, i'd better avoid CSwordModuleInfoList in similar places.


Fixed, used flags.


It's in `3-0-stable` now.


[Deployment available online](https://s.brightspace.com/lib/ifrau/0.9.0/ifrau.js)


If you
```C++
typedef QList<CSwordModuleInfo *> BtModuleList;
typedef QList<CSwordModuleInfo const *> BtConstModuleList;
```
in the other header as I commented above, these two functions could be templated:
```C++
template <typename T>
QList<T *> CSwordBackend::getPointerListPrivate(QStringList const & names) const {
    QList<CSwordModuleInfo *> list;
    Q_FOREACH (QString const & name, names)
        if (T * const mInfo = findModuleByName(name))
            list.append(mInfo);
    return list;
}

QList<CSwordModuleInfo *> CSwordBackend::getPointerList(QStringList const & names) const
{ return getPointerListPrivate<CSwordModuleInfo>(names); }

QList<CSwordModuleInfo const *> CSwordBackend::getPointerList(QStringList const & names) const
{ return getPointerListPrivate<CSwordModuleInfo const>(names); }
```


can you fix the formatting of the 1of3 2of3...across the board in the doc


added inline comments.


We have problems with the POPEN spawner, I would recommend not to do this.


[cellprofiler/utilities.zmqrequest.py:835-836](https://github.com/CellProfiler/CellProfiler/blob/master/cellprofiler/utilities/zmqrequest.py#L849) uses get_file_attributes and set_file_attributes from the get_proper_case_filename module to set the hidden attribute on a lock file for Windows. Meh - hiding it is not so important, so it's fine to just delete these two lines (and the "if" statement  above it). If you want to use the Windows SetFileAttributes function via ctypes, that's fine too.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.479](http://teamcity.monogame.net/viewLog.html?buildId=9539&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Well this is interesting!


s/```elif cmd == "TEST-SKIP-VALGRIND":```/```elif cmd == "TEST-SKIP-VALGRIND" and args.valgrind:``` ?


Looks good


Thanks! I will use some of it


@meh - This might fix https://github.com/opal/opal/issues/858


It looks like this is on purpose to me - it has the effect of setting session.flash to an empty object the first time it is accessed.

If you didn't have it, you'd lose the assignment of session.flash, as the failing tests would support.


You need to add some code here so the cores know which inducers are linked to them, and make them unlink on destruction of the cores/inducer in `Destroy()`


What happened to `MiqServer.my_server.get_config("vmdb").config.fetch_path(:server, :timezone)`?


97204612_MultiSpeedFan (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (752 of 752 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.93%25-green.svg)


Changing this line to use responseWrapper instead of response fixes https://github.com/dotCMS/core/issues/8072 -- was there a reason why this no longer uses the wrapper?


This should probably use `forceMove()`


Haha, I'm revisiting every part of the plugin :)


+2
I would just comment why you need to check for no-sanitize - I personally know about the -fno-sanitize flag availability but I think it's worth mentioning in the commit message. Minor comment, non blocking.


So now we have to install less, gulp, etc for every project that depends on them an manually compile them?


hmmm


Thank you @bbolker .    What do you (or other listeners) think about making this a user option at all?
One could also argue for hardwiring it, as then user will more often have to explicitly use `correlation=TRUE`  or  `... = FALSE`  explicitly... and options are flexibility, yes,  but also "against" strict functional() programming [results depend only on arguments].


`forceMove()`


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 305](https://teamcity.labkey.org/viewLog.html?buildId=266009&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0 Build time: 00:02:11
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


Unless I'm missing something, I thought we decided that folder refresh events would be fired from the facade over the global event bus. This completely removes the `presenter->eventbus->presenter` boomerang effect since it would be facade->eventbus->presenter.


Поддержка gamma уже есть в ядре. Это не надо удалять


This should be changed to `Destroy()`


Why was this reverted?


@caco3 we never commit to master – we always create pull requests which then need to be reviewed by at least one other person. :)


awesome :)


Пардон, уже вижу ;)


This method is only available in Java 8. Since IOGI needs to be Java 5 compliance, please, use `Method.getParameterTypes().length`.


while-sleep was always a signal of something wrong, but the main reason is that the stat is meaningless.


Sorry, it compiles now, though!


This is not a final product and will not work perfectly on each system it's installed on. Network and File System metrics are usually specific to each system and will most likely need to be changed from what is shown in this file


Should be `Destroy()`


```C++
#include "backend/BtModuleList.h"
```


@zidein07
Message:
    Split 'var' declarations into multiple statements.


Ah, good call!


Add some sanity here.

```DM
. = ..()
if(.)
    return
```


develop (nmerket) - x86_64-MacOS-10.9-clang: OK (1271 of 1271 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sanity, again


BTW, KF5 can be gotten pretty easily now in testing.
Just download the weekly jigdo image


Doesn't look like it, I only fixed splat calls, I'll look into that.


Good thinking! But this change should go to a separate commit.


Ok, I have access to the fronted side, but still have no access to the
Back-end side of the CMS, I used the default admin password "admin". I
don't know if this is the right one.
Can you confirm please?

Also, when I modify the admin email address to my personal and try to ask
to reset my password  by entering this new address it says: *That user does
not exist.*

2015-08-12 20:31 GMT+02:00 Graham Campbell <notifications@github.com>:

> You need to run the app:reset command.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BootstrapCMS/CMS/commit/2b867f5654ab2b60bd4eae13d0a9002c05d878b7#commitcomment-12672033>
> .
>


THIS is shitty code.


could you move that diagnostic push/pop to the new format as well? To not clog travis/clang with warnings.


This should be:
```DM
if(..())
    return
```


missed one @blackeaglejs


This is still initiated from the presenter. To complete the loop, it's more like toolbar.refreshButton->presenter->facade->eventbus->presenter. Before this change it was toolbar.refreshButton->presenter->eventbus->presenter. So conceptually I still see the same boomerang effect, even though the facade is inserted into the middle.


This too @blackeaglejs


LGTM


Why remove the `const`?


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 304](https://teamcity.labkey.org/viewLog.html?buildId=266007&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 29 (11 new), passed: 2 Build time: 00:16:47
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.ScrumtimeTest: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

##### there are 19 more failed tests, see build details
```


Good fix! But this should also go to a separate commit.


That's correct. I felt the line had to be drawn here because the user will typically invoke `Collection.upsert(...)`, so the hook should match up as best it can with that. The user shouldn't need to know the it's actually `update` getting called. The upsert implementation could just as easily have used `insert` instead of `update` combined with the `upsert:true` flag, so that reflects how it would be hard for a user to guess that `before.update` would have been called.


How about adding a version that takes an offset and a size? I can think of some uses for it.


I had a hard time when I created the issue understanding where to uncomment specs and where to fix it (, but I first encountered it w/ method calls. As a result, in stuff like opal-rspec, I often had to do the following:

```Ruby
# https://github.com/opal/opal/issues/858
  # The problem is not directly related to the Reporter class (it has more to do with Formatter's call in add using a splat in the args list and right now, Opal does not run a to_a on a splat before the callee method takes over)
def register_listener(listener, *notifications)
    # Without this, we won't flatten out each notification properly (e.g. example_started, finished, etc.)
    notifications = notifications[0].to_a unless notifications[0].is_a? Array
    notifications.each do |notification|
      @listeners[notification.to_sym] << listener
    end
    true
  end
```


I'm so happy for these additions


sure. you can close the issue.


I don't know how to make it any clearer.   Look at how you wrote `fetch()` and `fetchRange()`, and use the same pattern to define a method called `on()`.


But it's the facade which is firing the event, not the presenter, right?
The idea of the bad boomerang pattern was that the same actor/actor-type that fired the event, handles the event.


This is what I had initially but it wasn't executed very well. Still unsure whether this is the opposite of DRY (what is DRY again?) Or is there a prettier way to do this with `while`?


Good fix! But should go to a separate commit.


121eff369b4de925e8a86f50927dd1635ca33b4b also seems in the neighborhood


Put this into the same commit with the other fixes of this kind.


```C++
#include "backend/BtModuleList.h"
```


#!/bin/sh
#
# Wordpress Setup Script
#
# This script will install and configure Wordpress on
# an Ubuntu 14.04 droplet
export DEBIAN_FRONTEND=noninteractive;

# Generate root and wordpress mysql passwords
rootmysqlpass=`dd if=/dev/urandom bs=1 count=32 2>/dev/null | base64 -w 0 | rev | cut -b 2- | rev`
wpmysqlpass=`dd if=/dev/urandom bs=1 count=32 2>/dev/null | base64 -w 0 | rev | cut -b 2- | rev`
# Write passwords to file
echo "Root MySQL Password: $rootmysqlpass" > /root/passwords.txt;
echo "Wordpress MySQL Password: $wpmysqlpass" >> /root/passwords.txt;
# Update Ubuntu
apt-get update;
apt-get -y upgrade;
# Install Apache/MySQL
apt-get -y install apache2 php5 php5-mysql mysql-server mysql-client unzip;
# Download and uncompress Wordpress
wget https://wordpress.org/latest.zip -O /tmp/wordpress.zip;
cd /tmp/;
unzip /tmp/wordpress.zip;
# Set up database user
/usr/bin/mysqladmin -u root -h localhost create wordpress;
/usr/bin/mysqladmin -u root -h localhost password $rootmysqlpass;
/usr/bin/mysql -uroot -p$rootmysqlpass -e "CREATE USER wordpress@localhost IDENTIFIED BY '"$wpmysqlpass"'";
/usr/bin/mysql -uroot -p$rootmysqlpass -e "GRANT ALL PRIVILEGES ON wordpress.* TO wordpress@localhost";
# Configure Wordpress
cp /tmp/wordpress/wp-config-sample.php /tmp/wordpress/wp-config.php;
sed -i "s/'DB_NAME', 'database_name_here'/'DB_NAME', 'wordpress'/g" /tmp/wordpress/wp-config.php;
sed -i "s/'DB_USER', 'username_here'/'DB_USER', 'wordpress'/g" /tmp/wordpress/wp-config.php;
sed -i "s/'DB_PASSWORD', 'password_here'/'DB_PASSWORD', '$wpmysqlpass'/g" /tmp/wordpress/wp-config.php;
cp -Rf /tmp/wordpress/* /var/www/html/.;
rm -f /var/www/html/index.html;
chown -Rf www-data:www-data /var/www/html;
a2enmod rewrite;
service apache2 restart;


RoomAirflowNetwork (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (1793 of 1796 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


[DRY] (http://lmgtfy.com/?q=DRY+acronym&l=1) is don't repeat yourself. The idea is that you shouldn't repeat code when you can e.g. loop or use a function instead.


Well done!
Check out [this question](http://summerjava.boards.net/thread/12/assignment-zoowsome) and my answer to see a slightly different approach on constructor "design".


Ok no problem i just ask.


I have applied the following diff to this patch:
```
diff --git a/src/bin/lttng-sessiond/save.c b/src/bin/lttng-sessiond/save.c
index 5123912..c76abba 100644
--- a/src/bin/lttng-sessiond/save.c
+++ b/src/bin/lttng-sessiond/save.c
@@ -1192,7 +1192,8 @@ end:
 }

 static
-int save_pid_tracker(struct config_writer *writer, struct ltt_session *sess, int domain)
+int save_pid_tracker(struct config_writer *writer,
+	struct ltt_session *sess, int domain)
 {
 	int ret = 0;
 	ssize_t nr_pids = 0, i;
@@ -1227,20 +1228,23 @@ int save_pid_tracker(struct config_writer *writer, struct ltt_session *sess, int

 	/* Only create a pid_tracker if enabled or untrack all */
 	if (nr_pids != 1 || (nr_pids == 1 && pids[0] != -1)) {
-		ret = config_writer_open_element(writer, config_element_pid_tracker);
+		ret = config_writer_open_element(writer,
+				config_element_pid_tracker);
 		if (ret) {
 			ret = LTTNG_ERR_SAVE_IO_FAIL;
 			goto end;
 		}

-		ret = config_writer_open_element(writer, config_element_targets);
+		ret = config_writer_open_element(writer,
+				config_element_targets);
 		if (ret) {
 			ret = LTTNG_ERR_SAVE_IO_FAIL;
 			goto end;
 		}

 		for (i = 0; i < nr_pids; i++) {
-			ret = config_writer_open_element(writer,config_element_target_pid);
+			ret = config_writer_open_element(writer,
+					config_element_target_pid);
 			if (ret) {
 				ret = LTTNG_ERR_SAVE_IO_FAIL;
 				goto end;
@@ -1319,9 +1323,8 @@ int save_domains(struct config_writer *writer, struct ltt_session *session)
 			goto end;
 		}

-		ret = save_pid_tracker(writer,session,LTTNG_DOMAIN_KERNEL);
+		ret = save_pid_tracker(writer, session, LTTNG_DOMAIN_KERNEL);
 		if (ret) {
-			ret = LTTNG_ERR_SAVE_IO_FAIL;
 			goto end;
 		}

@@ -1361,9 +1364,8 @@ int save_domains(struct config_writer *writer, struct ltt_session *session)
 			goto end;
 		}

-		ret = save_pid_tracker(writer,session,LTTNG_DOMAIN_UST);
+		ret = save_pid_tracker(writer, session, LTTNG_DOMAIN_UST);
 		if (ret) {
-			ret = LTTNG_ERR_SAVE_IO_FAIL;
 			goto end;
 		}

diff --git a/src/common/config/config.c b/src/common/config/config.c
index 5294f9b..03601be 100644
--- a/src/common/config/config.c
+++ b/src/common/config/config.c
@@ -2093,9 +2093,10 @@ end:
 }

 static
-int process_pid_tracker_node(xmlNodePtr pid_tracker_node, struct lttng_handle *handle)
+int process_pid_tracker_node(xmlNodePtr pid_tracker_node,
+	struct lttng_handle *handle)
 {
-	int ret;
+	int ret, child;
 	xmlNodePtr targets_node = NULL;
 	xmlNodePtr node;

@@ -2104,7 +2105,8 @@ int process_pid_tracker_node(xmlNodePtr pid_tracker_node, struct lttng_handle *h
 	/* get the targets node */
 	for (node = xmlFirstElementChild(pid_tracker_node); node;
 		node = xmlNextElementSibling(node)) {
-		if (!strcmp((const char *) node->name, config_element_targets)) {
+		if (!strcmp((const char *) node->name,
+				config_element_targets)) {
 			targets_node = node;
 			break;
 		}
@@ -2115,9 +2117,10 @@ int process_pid_tracker_node(xmlNodePtr pid_tracker_node, struct lttng_handle *h
 		goto end;
 	}

-	/* Go trought all pid_target node */
-	int child = xmlChildElementCount(targets_node);
+	/* Go through all pid_target node */
+	child = xmlChildElementCount(targets_node);
 	if (child == 0) {
+		/* The session is explicitly set to target nothing. */
 		ret = lttng_untrack_pid(handle, -1);
 		if (ret) {
 			goto end;
@@ -2125,14 +2128,13 @@ int process_pid_tracker_node(xmlNodePtr pid_tracker_node, struct lttng_handle *h
 	}
 	for (node = xmlFirstElementChild(targets_node); node;
 			node = xmlNextElementSibling(node)) {
-
-		xmlNodePtr pid_target_node = NULL;
-		pid_target_node = node;
+		xmlNodePtr pid_target_node = node;

 		/* get pid node and track it */
 		for (node = xmlFirstElementChild(pid_target_node); node;
 			node = xmlNextElementSibling(node)) {
-			if (!strcmp((const char *) node->name, config_element_pid)) {
+			if (!strcmp((const char *) node->name,
+					config_element_pid)) {
 				int64_t pid;
 				xmlChar *content = NULL;

@@ -2149,7 +2151,7 @@ int process_pid_tracker_node(xmlNodePtr pid_tracker_node, struct lttng_handle *h
 					goto end;
 				}

-				ret = lttng_track_pid(handle, (int)pid);
+				ret = lttng_track_pid(handle, (int) pid);
 				if (ret) {
 					goto end;
 				}
@@ -2253,7 +2255,6 @@ int process_domain_node(xmlNodePtr domain_node, const char *session_name)
 		goto end;
 	}

-
 	for (node = xmlFirstElementChild(trackers_node); node;
 			node = xmlNextElementSibling(node)) {
 		if (!strcmp((const char *)node->name,config_element_pid_tracker)) {
```


is there now some sort of callback to know that we have more than 1 node?


In this case, what is the difference between those two blocks of code in the `if`? One kwarg, plus a `warnings` catcher (which can operate on both with no issues). So I'd do this:
```
            fmax = p.lp_cut if file_type == 'pca' else (raw.info['lowpass'] + 50)
            with warnings.catch_warnings(record=True):
                raw = Raw(fname, preload=True, allow_maxshield=True)
            raw.plot_psd(tmin=tmin, tmax=raw.times[-1], fmin=fmin,
                         fmax=fmax, n_fft=n_fft,
                         n_jobs=p.n_jobs, proj=False, ax=None, color=(0, 0, 1),
                         picks=None)
```


Agreed. I set my version aside, rebased that change away on the ticket branch, rebased to master compared the final result. I found one cleanup that was missing on master (one assertTrue that is more informative as an assertGreater) so I added that as a separate commit


Maybe it would be good to have the same method of "doing things" as in the AnimalRepository? use a `decodeFromXml(...)` method on the caretaker, etc. etc.


Done


Well done, again.


me wonders if this breaks the desktop's Connection Quality tooltip, I have there the number of DHT nodes to which we are connected to.


Thanks; I saw that pattern but couldn't figure out how to apply the params.


It's to the client how to interpret the num of nodes in the DHT buckets, the info can be retrieved by postDHTStats and receive the alert DHTStatsAlert.


would this be the replacement for the old `s.getDHTStats().totalNodes()`?


Why the symlink?


Doesn't look good. I think the return type of `CSwordModuleSearch::unindexedModules()` should still be `QList<CSwordModuleInfo *>` so we wouldn't need to add an ugly `const_cast` hack here. If needed, we can always add another `CSwordModuleSearch::unindexedConstModules()` method to return us a `QList<CSwordModuleInfo const *>` object.


@scottschurr @HowardHinnant `ReadView::succ` gets a workout in this unit test:
https://github.com/HowardHinnant/rippled/blob/dd12f48f21d7e873051fb193f4458159b74687d8/src/ripple/ledger/tests/View_test.cpp#L32
If Howard's implementation does not cause the `View_test` to fail, then I have high confidence it is correct.


Perfect.  Please continue and fill in the rest of the logic and reports Nathan.


We don't use this in desktop.


Consider instead:
            if (getApp().getHashRouter().checkValidity(
                *item.second).first != HashRouter::SigBad)
            {
                apply(accum, *item.second, tapNONE,
                    getConfig(), deprecatedLogs().
                        journal("LedgerConsensus"));
            }


This patch provides support for parsing and generating strings from/to signed integers, too.


c&p?  maybe s/!opts->from_string/!opts->to_string/ ? also for the line below in the free() call.


Doesn't the installer use master.yaml instead of master-config.yaml? If not I'll go back and update the systemd unit files instead.


OK, yes I see how ArrayToStoreAdapter is setting a property called `obs` and DstoreToStoreAdapter is setting a property called `track` (and then Store.js has the code `if (collection.track || collection.obs)`).

You should pick one name, and document it (like you documented `data` and `source`).


should use assertEquals


Can you check what's fixed and what isn't and provide small test cases? Or find if there's that stuff in RubySpec?

The compiler is the land of the eldritch gods so the less figuring out I have to do the better.

/cc @vais


seems straightforward so merging.


no no, the free() is ok.


This is only for one bucket, there are more than one. You get the alert with all of them. You can add them to get a number (that has nothing to do with DHT nodes).


The default password is "password" (without quotes) for all the users.  If you take a look at the UsersTableSeeder class (app/Seeds/UsersTablesSeeder.php) you should see all the current users information.

Do not edit the database directly and you shouldn't run into many issues.  This means log in as the user and change the email address and see if it works for you.


we


inference* ( ͡° ͜ʖ ͡°)


"Seamless posting is a method that puts the extension's posting form element directly over the form element of the host page. It is 'Seamless' because the user does not need to leave a web app in order to post encrypted content to it."


:+1: :rose:


Woudn't just `performs` be enough here ?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.479](http://teamcity.monogame.net/viewLog.html?buildId=9539&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:25:52


are we discarding all the mdata pointers after this point? if not setting mdata->orig_string and friends to NULL seems good to me and avoid future dereferencing invalid pointers in that case, also re seting max_replace


Instead of allowMultipleTeamMembership I'd rather see the option passed be the number of teams a user is allowed to be a member of. Though then we have to define something for infinite.... But my point is that a boolean still isn't very flexible. And I question if doing this now is a good idea, since there is code on the back end also enforcing the single membership.


Why are we removing this?  If the other two tasks that set ``replace_repos`` don't run then "Disable all rhsm repos" will fail because ``replace_repos`` is undefined.  Perhaps what we want is just to set ``replace_repos: False`` in ``common/defaults/main.yml``?


Oops


cc @vasiledirla

@cdeneux: which problem are you referring too? I'm reading multiple things in this commit here.


what happens if we fail to strdup(value) ?


Ansible works with master-config.yaml, do you mind updating the sysconfig files along with this change?


"In seamless-posting, we first create a new Privly link and place it in the host page's form element. While the user types content into the protected form element, the content associated with the link continually updates. If the user clicks the cancel button, the content associated with the Privly link will be destroyed."


How about if all parametric (predefined) geometries create a generic `BufferGeometry` and lose their `type`?

I know you are interested in serialization via type and parameters, but I am not sure that was a good design decision in the first place.


Name the table ENG8424 to make it clear which test needs it.


Ok I see, I didn't know it could work like that.


End of review for Xin's commit.


saw approval from jonmeredith
at https://github.com/basho/riak_core/commit/2f55206682f6470d1cbceaf0025440c87013cd58


merging basho/riak_core/merge-2.0-gdce213c-to-2.1 = 2f552066 into borshop-integration-769-merge-2.0-gdce213c-to-2.1


basho/riak_core/merge-2.0-gdce213c-to-2.1 = 2f552066 merged ok, testing candidate = 138fc508


@flavour Please review


I might be confused about the directive (I probably am) but shouldn't the condition be:
````
if((originalWorkWifiId != null) && (!originalWorkWifiId.isEmpty())) {
        ...
        pm.setComponentEnabledSetting(componentName,PackageManager.COMPONENT_ENABLED_STATE_ENABLED, PackageManager.DONT_KILL_APP);
}
````

Since the state in the manifest is set to off ````<receiver android:name=".receiver.LunchOutDetectionReceiver" android:enabled="false">```` I am assuming we do not want to enable the receiver until the wifi ssid gets set by the user.


can add a `sol_buffer_get_slice_at(const struct sol_buffer *buf, size_t pos)`


Do we want to apply the transaction even if the local checks fail?


Ok


I don't get it, you're checking opts->from_string twice, I'm guessing you wanted to check for mdata->from_string right?


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/fcd7d6fc3e6af19085ae81a52a32bc5f830d3de4/index.html)


I think the function `padextent` could be named better? Because we are getting the extent with padding, rather than padding the extent, it seems.

`findPaddedExtent` or similar? (Probably a better verb than find though)


Yea, I tried that but then the link actually rendered out the html snippet (anchor tag) rather than interpreting the tag. It seemed like we just wanted to prevent XSS and thus I'm just partially escaping the course name (to prevent < and > characters). I didn't do a fully urlEncode because spaces became displayed as %20.


Simplify the path


This could be an elsif, that way you reduce the nested if


Remove all the comments please


fix #4


Could check if the num is divisible by 15, instead of by 3 and 5?


nope. I can't test both at the same line because because down in the code I'll print a "Unrecognized command" warning in the case I don't run with valgrind. so first I need to check for "test-skip-valgrind" , and if that works then I check if valgrind is used.


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/150067871e6dac3f900736dbf68d356b44040e82/index.html)


You have a typo in "implememted".


Why is there no header or footer?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/dev/dac8c1a3e5aa46952f49e35858c86ec45e5f6a62/index.html)


c&p error, indeed. Thanks.


[Deployment available online](https://s.brightspace.com/apps/hello-world-fra-iframe/0.3.0/index.html)


wiki_id: @wiki, user_id: @user


Can we remove the `aria-hidden="true"` here? It's an invalid attribute that is causing a bunch of errors.


Is this going to pick up files that begin with the module name? For example, if app.js is the main module, will it also pick up appointment.js?


When I wrote this comment, I thought that `CSwordModuleInfoList` was a `QList<CSwordModuleInfo *>`, because I had not actually read that the actual typedef was for `QList<CSwordModuleInfo const *>`.


Fixed in latest push.


unit is 1..256


wiki = Wiki.find(params[:wiki_id])
user = User.find(params[:user_id])


There can't be any reference to them after this point -- the node is being destructed.


I think it is no problem if we just add a new header file like I detailed in a comment below.


Thanks, I'll check.


Do you think it would make more sense if we did converted `remoteObjectIDs` into a mutable set?


Instead of having two different finis, add a owns_data flag and check for it to decide whether or not deallocate the memory. If any sol_buffer() allocates memory, set this flag.

Also I wonder if we should go ahead and reset everything in fini after the potential deallocation: `*buf = {}`.


Right, thanks.


Should this be key of :key and value of type?


collaborator.save


Of course


Actually I don't think so - allKeys is, as far as I can see, the fastest Way to do it. And `NSDictionary` itself will assure that no key will be duplicated - so I think this is a win :-)


Could use a more generic example? Its awkward to do generic as must be fixed size type.


this closes #36


If hideWhenOnePage works, then we shouldn't need to explicitly suppress the header and footer (which I'd like to avoid).


should be passed by const ref to avoid a copy


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1699


can be converted to a for ranged loop instead of using iterators


Same issue. Weird that is says "53" instead of "5300", right?


`return GetSession()->UpdateAccountToys(itemId, isFavourite);`


size is non_neg_integer(), i.e. can be zero too.


I don't understand. Don't I already have the same method of "doing things" as in the AnimalRepository? I used the method on the caretaker.


`transLogin`


Yeah, I'd prefer that we leave out this allowMultipleTeamMembership flag. The front-end code is not going to be using it throughout (for instance, hiding header/footer, disallowing the "Join" button on the Team page), the server code assumes a single team, and I'm not at all convinced that a boolean is the right way to go (vs. max number of teams).


Seriously dude...this was kind of a bogus move.  Why would you need analytics in a Color picker application?  You took an app that should be simple, friendly, and require NO permissions whatsoever and made it some web-facing pigmonster.


doh - I should have removed performs


Since the start_key is an alias of startKey, could we deduplicate them above like.
```
var startKey = (typeof opts.start_key !== "undefined") ? opts.start_key : opts.startKey;
```

For the adapters question, I'll leave that to someone else. Hope this helped tho'


`NULL` to `nullptr` everywhere


Bummer. Just a one-time fix though, yes?


message could say it's from UseToy


const auto&


This is the code that made the network images on 8-12.


initialize to 0


If the itr isn't const it could be used to assign isFavourite, it would avoid another lookup (really minor performance gain)


This does not follow ruby indentation style guide, for the rest of this course, make 100% sure this is follow please :), it will help you a lot in case you aim to get a job in development.


That's a good question. My assumption was that either course teams don't mind if folks are in lots of teams, or they want to restrict them to a single team for focus. I don't know if supporting a maximum of 3 teams is something we'd need to handle.

The reason I put the logic into the client is that it made it easier to read rather than having to put comments everywhere explaining that the server is doing this. It seemed better to have the client support either option, and then have the server tell the client that is is in 'single membership mode'. Then when we want to support the feature we just have to update the server.

If you dislike this then I'll go back to having assumptions in the client about single team membership along with comments in each place that we have to do this.


97204612_MultiSpeedFan (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1278 of 1279 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.92%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.9%25-green.svg)


There is no need to call `@videos` you can access them by iterating over `@categories` and calling `#videos` on each category.


Nice! I wasn't aware that Hash had a store method: http://ruby-doc.org/core-2.2.0/Hash.html#method-i-store Cool.


Wrong indentation here.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.480](http://teamcity.monogame.net/viewLog.html?buildId=9543&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


this is weird


Wrong indentation in whole file.


Eurgh. Stupid mocking library.


There is no need to interpolate that `category.name`


BTW: many thanks to DTL for exposing such deeply internal function in RCurl!


There shouldn't be a space between `link_to` and `(`


thank you!!!!!!!!!!!!!!!!!


This is glorious too.


Is this what we want? Can't we somehow check that it hasn't been called to that URL, ignoring the body?


This file should be in gitignore. Never put sensitive information here. Not even username.


We don't need this here since we have it in the step definition, right?

I would prefer not to do operations in here which are only needed by some scenarios


Can we have this as real documentation rather than comments please?


I think it would make more sense to move this to application_steps.rb.


You've not defined `Action`


There should be way more seeds - Create at least 4-5 videos.


Line comment on squashed commit


The idea is that the "My Team" (singular) tab never shows a header or footer. Eventually we'll have a "My Teams" tab which will.


Why?


Yeah someone was being a bit optimistic.


I think it would make more sense to move this to host_steps.rb and rename something like addHost


You've not defined action?


Why do we have to do both attributes and `className` property? Seems like duplication of work and perf problem.


You mean "backend/drivers/btmodulelist.h" ?


`a`?


Shouldn't this say that int and con are swapped temporarily?


Haa, here is a A


Do we need this call here? Seems like it should be called from a step definition somewhere.


Thanks for spotting that. This feature isn't supported on the header yet, so we'd have to implement it there. I agree that it would be cleaner, so I'll see what that would take.


Salut Gab, Bon travail pour l'avancement des script de mouvement et pour les nodes. J'ai mis en commentaire la ligne 11 de la classe CharacterMovement.cs, car elle retournait une erreur qui empêchait unity de compiler. J'ai ajouté aussi le invalidOperationException pour les objects Queue.
Présenement on a fait un meeting et les tâches qui sont a faire se retrouvent sur trello : https://trello.com/b/iLaYAbdB/vz


Fixed. Substitued by search for a checked radio button within a view.


Are you planning on having a fallow up CL where you pull out all of the class login into a renderer which could be shared by other components?


Final project - Portfolio site/Suzanne Portfolio/index.html

We don't really need the h1 here. It is not the page title. H1 should contain text.


97903100_SolarCollectors (macumber) - i386-Windows-7-VisualStudio-12: OK (2210 of 2241 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.62%25-yellow.svg)


# correct
Bien en **accord**


ok test


can the page-divider element be replaced by css. you can put a top and bottom border on the nav element.


@anchi1216 這個 `28.md` 是不是改成 `2.8.md`


這邊也是需要修改


Fixed in 353ae1678f719eae6342fcc445121d76f9d78515, thanks!


Nina porque borraste los otros commits....


Pretty awesome!


TeamCity pull requests :: netty [Build 5](https://garage.netty.io/teamcity/viewLog.html?buildId=230&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 4048, ignored: 16; exit code 1 Build time: 00:07:12


to achieve the thumb boxes, please look into using a markup-structure similar to this:
-div
---- span (box 1) /span
---- img
---- h2.project-title
-/div


Eliminar este comentario, no sirve.


Eliminar comentario, no sirve.


Should change another variable name that is more proper?


You could also achieve the same thing with `<% if @bookmarks.any? %>`


Thanks Bobby, much appreciated. :)

On Tue, Aug 11, 2015 at 3:21 PM, gittheking <notifications@github.com>
wrote:

> Awesome job Toti! Nice clean and commented code is what I live for!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tfbkny/wdi-fundamentals-rps/commit/14b6c0b41b599128ff23678bc0b0b8f6474a65ec#commitcomment-12648710>
> .
>


Hi, I use Ubuntu 64, and this update is causing trouble to the linking of the libusb installed in the depends folder. When I compile Protonect with cmake, /usr/include/libusb-1.0 is linked instead of the corrected libusb.
When I revert the changes, everything works fine. Just to let you know!


I think I prefer the simplicity of "Sensitivities" for showing output to new users -- is there value in the longer name?


Why do this?


Some of the purpose of const is "conceptual" vs. being purely mechanical.  C isn't able to implement the concept fully, but in C++ when a pointer to an object is const...that is the "doorway" through which you are working with the object.  Even if the object has mutable access to its guts, as long as it is serving as the broker for those guts it doesn't hand out mutable access as long as the interface is const.

So what I mean is that if an operation modifies the state of something in a way that can be observed by others with the same const pointer, then it is not a "const" operation.

I gather what's going on here is that there is some structure that has cost to build, and as it has cost it is kept associated with the routine and reused on the calls vs. building each time.  But interface-wise, that should be transparent...e.g. you ask the routine for something and it "hands it back", while other observers with the same pointer would not have a way of knowing the routine went through a change.  So that is what I mean about not making an "out" pointer const.


use unsigned int for the index is not a problem, but we are usually using uint16_t  for that. Besides that, +1


t̬̭͖̙̗͉̻̟̥̜̥͕̻̣̀̆ͨ̀͊ͬͣ̀͐ͩ̉̓ͧͧ͊ͮ̌́͘͟͟͞͞ͅͅ


cool!


lgtm


For what?


test


Manually corrected since original repo is not available. Thanks!


cool


The extra newline added after the ls command seems wrong, since the ls command already contains a newline (unlike the shell, it is not stripped, and remains intact).  Each file now emits two new line chars:

$ imgls.pl 2> /dev/null ~/Desktop/testing | hexdump -C | grep 0a
00000070  69 67 5f 66 65 72 61 2e  6a 70 67 0a 0a 20 20 20  |ig_fera.jpg..   |


This line should be put in `else` block.


Please review this, @casey-collab


Updated manually since original remote no longer exist. Thanks!


switched to material design lite and fixed a compatibility issue with newer versions of gradle


確かに、週初に「あ号」を受けずにブラウザを落とす場合に保存されませんね。
もともと $weekly は「あ号」用の記録データだったので、保存タイミングが不足していました。
Bugfix Issue #44 を設けました。


I was actually using that for debugging. If you think it'll be useful it can stay for the final PR, but I don't think it should be necessary.


had to revert ng-class because of bug; all directives lit up for hover on one


@mrunalk Have you applied patches from here:https://github.com/01org/ozone-wayland/tree/master/patches


RoomAirflowNetwork (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.77%25-green.svg)


いいと思います


a note to myself while writing the code; meant to remove it, oops. Thanks, fixed


The automatic caveat
```
(let ((default-directory "/usr/local/share/emacs/site-lisp/"))
  (normal-top-level-add-subdirs-to-load-path))
```
does work as substitute for `add-to-list` but does not work for `autoload`.

So I need these lines to use trr.
```
  (let ((default-directory "/usr/local/share/emacs/site-lisp/"))
    (normal-top-level-add-subdirs-to-load-path))
  (autoload 'trr "/usr/local/share/emacs/site-lisp/trr/trr" nil t)
```

So need caveat about `(autoload 'trr ..)`


Very nice.


Also, should change test with
```
(let ((default-directory "/usr/local/share/emacs/site-lisp/"))
  (normal-top-level-add-subdirs-to-load-path))
```


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


There is a typo in here, ti should be:
AND COUNT(wmbs_workflow.name) = 0


this*


muscle*


all of*


お　いいね


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


destroy_connection() is freeing connection, you should remove connection from vector before call destroy_connection()


1. check callback is callable?
2. document what callback is supposed to return?
3. where is this supposed to be called from?


uint16_t fits better


check if this function failed


Como que tu escreve um código desse jeito???


Why are lines not wrapped?  The previous one is better.
```
OData-ValidationTool
Copyright (c) Microsoft Corporation
All rights reserved.
MIT License

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
```


@junchaowu this might constitute a breaking change


@Ulto @austinkelleher


Trouble running at all or just can't step through the code in debugger? If latter, I suspect PDB incompatibility. If you need that, you'll have to build it yourself with your compiler.


"responsivo por de colores"


Thanks, fixed!


The USB controls for Synapse were first implemented by me. It appears that yours has been extracted from one of my earlier Note Edge ramdisks (by whoever).............

Anyway, would be appreciated if credits were not removed.

First line of ....../actions/storage should read:

# By UpInTheAir for SkyHigh kernels

Thank you


Hi, ombs, thanks a lot for the pull request!

The Arduino's map function is:

long map(long x, long in_min, long in_max, long out_min, long out_max) {
  return (x - in_min) * (out_max - out_min) / (in_max - in_min) + out_min;
}

Do you think (tested) that it really overflows if the lastFrequencies[i] is bigger than the whiteBalanceFrequencies[i]?

It looks like the map function prevents such thing from happening.

I'm wrong?


This is only for parse5 adapter. It is needed since it doesn't correctly handle setting `className` property. See the add / remove class methods.


This should be outside the loop: only need to do this once...in fact the previous 3 lines as well


Instead of overloading this struct for both lease and network watches, I would prefer to have two separate ones: `LeaseWatchResult` and `NetworkWatchResult`. This way we're also not changing JSON dictionary key names and thus don't need to bump the protocol version.


Супер е :)


Kinda. If we go the keyword route for other methods, we'll need to do it all the time...


would you describe zipmap as a convenience utility?


Shouldn't this be a `Bookmark`, not a `Wiki`? :)


I guess we're expecting relatively low turnover so that most of the time we will loop once, so this is fine (if we expected many then bring get_data_from_url into scope outside the loop)


ditto


Have you seen Sinatra helpers yet? You may consider creating a helper method that returns your current user. Don has a great example in his lecture notes from yesterday: https://gist.github.com/donburks/223c818e7f9849dc2ead#file-actions-rb


I did it because it seemed easier to create the state update for the POPEN case. I will include the SHELL spawner also. I am not sure yet how to do it there. It will change eventually.


Yes, I think it makes sense to extract a utility class that could be used by other directives.


oh, wait, sorry, yes, but why are you parsing the name, id and salary separately?


instead of redirecting, just `render`. That way you don't travel so you can keep the data on the form and show it


I know why! it's because you don't have an empty constructor - bad practice! :smile:


> This is incorrect.  It should be "losing", not "loosing".

Right, I'll change it back.

--
Courtroom Quote #19:
Q:  Doctor, how many autopsies have you performed on dead people?
A:  All my autopsies have been performed on dead people.

 /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net   \\\
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\  an exciting new programming language -- http://www.Zimbu.org        ///
 \\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Yup, this looks good to me.


Does seek(0) return the rewound object?
I would have expected not, and hence the seek(0) is before the return of the rewound object
Looks like I am correct: http://www.tutorialspoint.com/python/file_seek.htm


972124-2NewDetailedIceStorage (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1793 of 1793 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I quite like the way I've written it because it's explicit and easier to read. However, I'll see what everyone else says and you may well be right :)


Sorry - that is fixed in the latest check in. Bookmarks weren't fully working at that point.


It actually does... just tested!! Thanks :)


I didn't want to have to force people to supply a region, but that's required for STS. So I've made it so it uses the original connection method if region=None (e.g., defined in the OS), otherwise it checks if account=None, and if not, uses STS.


Wonderful! it was as easy as that, lol.
I think, I understand now, the password is encrypted with combination of
the password and the user email address. Right?

Thank you very much:)

2015-08-12 21:31 GMT+02:00 Ryan Matthews <notifications@github.com>:

> The default password is "password" (without quotes) for all the users. If
> you take a look at the UsersTableSeeder class
> (app/Seeds/UsersTablesSeeder.php) you should see all the current users
> information.
>
> Do not edit the database directly and you shouldn't run into many issues.
> This means log in as the user and change the email address and see if it
> works for you.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BootstrapCMS/CMS/commit/2b867f5654ab2b60bd4eae13d0a9002c05d878b7#commitcomment-12673247>
> .
>


I think you should keep the ref in the property setter instead of here.


Consider wrapping the expiration code with this check as nothing can expire before elapsed second surpass hold time. I also recommend renaming 'now' to 'elapsed'.

if (now >= mHoldTime)
{
     int expireTime = now - mHoldTime;

     // See if any supressions need to be expired
     auto it = mSuppressionTimes.begin ();

     while ((it != mSuppressionTimes.end ()) && (it->first <= expireTime))
     {
         for(auto const& lit : it->second)
             mSuppressionMap.erase (lit);
         it = mSuppressionTimes.erase (it);
     }
}


from the `link_to` documentation:
```
Using a :back Symbol instead of an options hash will generate a link to the referrer
```

though I prefer to hardcode the link, maybe as a param to the partial? because this way of going back is controlled by javascript, not ruby, and might render strange results over time.


I don't understand the question.  It's a function that converts two sequences into a map.


Thanks for the update! Don't worry about it; I was just sniffing around the github forks and poking at things that looked useful but didn't exist in PR form.


It is definitely not needed. I've already made a similar commit in my fork :)


RadianceRefactor (rpg777) - Win64-Windows-7-VisualStudio-12: OK (2189 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.83%25-yellow.svg)


Ahh sorry about that. I'll try to fix it when I'm back to my computer


aha! why not? maybe it's because the default is hardcoded on the ruby code (the name)? Maybe we should come up with a better solution for defaults, like having a boolean field in the database and forcing it to just have one entry with it set to true? :)


hey, don't you like tests? :)


is the same functionality otherwise achievable with more text/characters/code that this "zipmap" achieves with fewer ?


Yes, sorry about that. The problem is in running the tests, not caused by your commit.


I don't see any more glaring style issues so I'll just merge it


Could you use spaces in front and after '>'?


Dito.


Right.  I want the dependencies to be generated from the build dependencies though.


@cahrens If you can spare some time, I need some assistance with getting this test written. A few things:

* Firstly, is this even the right file? It's the only one I'm finding that's remotely close to discussion views/threads.
* I'm not great with CoffeeScript (also, aren't we doing away with it?) so I'm not sure if the syntax is correct; I'm following the other examples in this file
* Much like the file that actually sends focus, is there a way to pass in the thread ID, so we can verify the correct `thread-wrapper` is getting focus?

A little nudge in the right direction would be appreciated. Thanks in advance.


I don't see how it's faster in block retrieval?


It is not technically monadic for this to return `Try[Self]` instead of just `Self`, but i am not sure if there is any other reasonable way to encapsulate the exceptional nature of running a script. Just making it throw everything and forcing the caller to wrap it in a `Try()` block seems Bad & Wrong...


Ah, two different QueryStats classes in presto...


Any reason not to move this to the very top of the function?


as


Yes, you are right..overlooked that before.
Changes for this PR LGTM


rax retry tests


Need to do some more work actually understanding Content Providers


LGTM


hey, what do you think about cancancan, do you like it? do you see when is it useful and when it's better to use pundit or go with your own solution?


Similarly to the other commit, it'd be best to keep the ref in the setter.


I wonder what @ArcticLight thinks about this...


Ditto


The zipmap is exactly as it was before.  I've removed the assoc/dissoc that renames methodStoreX to methodRepoX, as the config is being handled differently now.


Yes.


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1799 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


use http://localhost:8080/test-war/V1/resource/j to test


Should be freed also when the parsing fails


Possibly this should be moved to a method on `ScriptMonad`; `context.evalEvent(event)` seems more semantic than `event.evalEvent(context)`...


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 24](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=57&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


okay


Updated in 22c9140 .


updated


1. true, in that sense, good point. What I meant is that there might exist a feasible point for the original problem (i.e., `s` in the feasibility problem could be less than one), but the SP heuristic might only find a point with `s > 1`. There's nothing fundamentally wrong with that, other than some might consider it misleading. It's certainly less convincing/pleasing than GP, where we have hard guarantees on the feasibility reported out.

2. I agree that the feasibility SP won't be fundamentally infeasible (unless there are equality constraint issues).


Update to say "if user is a member of a team".

Seems like there should also be a test here about when the user is not a member of team (that you are on browse topics).


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.480](http://teamcity.monogame.net/viewLog.html?buildId=9543&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:23:06


Thanks :-)


Maybe "switch back to the My Teams tab"? I was confused because you were already there...


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Why click on my teams?


Best.Commit.Ever.


I thought my commit would become a pull request. I would not have expected that I have write access to the master! Is there a way to revert it, so I can make a proper pull request?


the last png in this commit is in the wrong directory and is causing build failure. move it to the right drawable folder.


Hi, we're using this extension in Android, calling the purchase method on Android directly from the "onClick" event of a button without issues. I don't think this is really needed, but not harmful also... (not sure 100% anyway).


could be, in that case `!owns_data` implies in `fixed_size` since we can't realloc. Then, should it be an enum instead of two booleans?


Updated to `__filter_substring` in 3a6570b .


Why is this now a member variable? It's strange to be setting a member variable with the loop's iterator index, and you're still just using it as a parameter passed into methods like `self.testing()`, so keep this as `trial`.


This looks broken:

        if ( masterValue.isCompound() && masterValue.isCompound() ) {

Should it perhaps read:

        if ( masterValue.isCompound() && testValue.isCompound() ) {

instead?


@beornborn Сам формат текста я не изменяла, пока думаю, как лучше поле about оформить. Может разбить его на части, и при заполнении сделать форму,  где будет запрашиваться конкретная информация в каждом поле: день рождения, город, скилы, образование, опыт, другое... А потом эти блоки как-то красиво расположить на странице, например личные данные объединить где-то справа сверху, со скилов сделать лейблы... Не знаю, будет ли красиво так.
И еще, может внедрить заполнение отчетов в наше приложение, пускай у каждого на странице будет возможность составить отчет за день в форме, а также инфо о проделанной работе за месяц/неделю, справа потраченное время...
А общую таблицу вынести где-то на отдельную страницу...


I moved the accepted range of weights (40 < kg < 150 ) out of the view form helper, and into a model validation. <= first testing induced improvement, yay.

I added the validation tests, because BMI measurements are most reliable within a certain range, so I think that is a valid argument to test it.

I am not sure about the usefulness of the other validation tests, but they are copied from my textbook. Any thoughts on the usefullness of testing validations are most welcome.

Please ignore the multiple person statement. It will be gone after the next chapter in my textbook.


(str)


LGTM


works right!


RoomAirflowNetwork (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I am out of the office until Tuesday, August 18.

Your message was received and I will read it when I return. Any future
messages from you between now and when I return will be read at that
time also, but you will not receive any more automatic replies to that
effect.

If you feel that this issue requires immediate assistance, please contact
Dan Farnsworth at 848-932-4594 or danfarns@rci.rutgers.edu.


It will either need to remain `if social_account.type` or we need to change the protobuf and recompile. That will throw an error if we leave it like that because `type` is in the protobuf.


The format here is difficult to read, and you should be consistent in formatting throughout; just two lines down theres a dict of params in completely different format.


use double quotes


This isn't done yet and won't compile?


line wrap at 80 characters


I think I messed this one up. It should be fine as .type it's the parameter that needs to be account_type not the property.


This comment is in the incorrect location, should be with getSafestWaterTerr and not here. Furthemore, comment is inflammatory and not to the point. This is distracting and waste of the readers time.

I'd just delete this, ideally adding a comment with getSafestWaterTerr of the example where a bad result is returned.


document the meaning of -1 here


"comma"


I agree this comment is in the incorrect location, some items have not been fixed and are being lost. perhaps creating issues out of the unresolved ones would keep them around, or putting this into a wiki page.


again, this spacing is really off... https://www.python.org/dev/peps/pep-0008/#indentation


I don't like the fact that half the callers of this do no use 'created'. I suppose you could return a std:pair instead with the second being a bool telling if created or not, just a thought.


Lgtm


That *is* a complexity. You should be able to scrape it from the card instances themselves. If you want to use the template, then read about how to place the right information into the template from the cards themselves. This sort of repetition is not acceptable to maintenance.


two blank lines between functions


Nice, thanks :)


@DanielJMaher its the simple things....


Manual network search


Why is it needed by the sessiond?


Document the fact that this "generic engine " currently only supports two diffable formats (bam and vcf).


Nearly there :)


Thanks. I think it's ready for merge. Unless you want me to open up kwargs (fmin, tmin, nfft) for users?


Is translations/johnny_fr.qm generated from translations/johnny_fr.ts?
If yes, then that binary file probably shouldn't be included in the git repo, but rather be rebuild during make whenever translations/johnny_fr.ts changes.


thanks,

Take a look at my most recent delta.  I believe it should fully cover this.   It also has updates to how I was shutting down the worker thread (or in some cases it was not).  Also I updated the code in the upper branch Phantom_Phoenix to hopefully be the same code.

I am also thinking about the other delta which is to use a symbolic name for the USB2AX.  I have thought of doing this as I don't like how it assumes it is ttyACM0.   But if I am going to make this change I may change it slightly more and if ttyUSB2AX is not found then try ttyACM0...


I was pretty proud of those; some of my best Python ;-)

Updated in 382395d.


Could you update the log then.? qq What is the log for ?


Maybe instead of do everything the other constructor is doing, you could call that one adding the extra param (1000000); does it sound reasonable?


I don't understand `hostname` here; it seems like it might also fall afoul of the Raw() nonsense.  In any event, we have cal_svr here, so I think you want cal_svr.shortname or words to that effect (I'll look more closely)


It was in sys/socket.h with the libc I used, but since it's really not standard, I will just redefine the structure here.


Example of low value comment. The "you can take this out" is just extra reading.
This comment should read:
```
// If the strength of the potential attackers is more than the strenth of our transports plus
// the sea units in the destination, then we could get suicide non-combat moves.
```
There's more that could be done to get rid of the need for the comment completely, but that is a longer and more detailed conversation.


Have you tested this? The api documentation for the zope interface does not include self in the arguments. I would worry about that fouling up.


It's a member variable because partitionIndices needs to know which trial it is.  If i just make it trial, then I would have to make a new runExperiment in htm_runner.  I could get rid of the parameter that is passed to self.testing() and self.training().


As far as I understood, the DWT's capabilities are vendor specific, since the Cortex-M debugging capabilities are partly optional to save silicon space.
So I intentionally moved it into the platform specific initialization code ;-)
For the Cortex-M0, the assembly delay function will be used, which isn't totally terrible. `xpcc::delayMilliseconds(uint32_t)` is only 0.1% too slow on the F3, so there is hope.

It might be, however, that all µCs with > Cortex-M0 have the DWT Cycle Counter, but the STM32F0 series do not (even though they have a DWT module).


This test fails here :-/


I like -- suggest this pull request be promoted


well, you need to infer virtual package names then...


Right


Wow! That's it? That's all that turns this into max-sum?


Keeping these comments around do not make sense to me. It looks like we had some code, it was possibly bad, somebody was confused by it, took it out by commenting it, and then added TODO commentary that they were confused by the code.

At this point nobody in the world is going to actually come back and figure out what is wrong with this code and revive it. So having the commented out code is just extra, and so are the TODO comments about understanding it. Even worse, these comments have spawned this conversation, and will confuse any reader who comes across this section of text.

Lots of commentary like this is best just deleted. Another bar that it fails to meet is that it does not help me understand any of the actual code that is uncommented.


Nevermind! :)


@Optimusprimeums thanks mate, I think given what @Nadahar said I'll retag later on. Sorry for the trouble, and thanks @Nadahar for pointing it out


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2200 of 2234 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.48%25-yellow.svg)


This was the bug. Last two conditions weren't iterated over but were unassigned values in the loop body.


Adding your name to comment is not good form. Shouldn't matter who the author is. If this is a discussion, it should be on a forum or thread, not in code or over SVN.


#1064 - You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '+--
+UPDATE `creature_template_addon` SET `auras`="" WHERE `entry` IN (32638, 3' at line 1


This is literally how we tell users to run ceph-deploy :/


The second of the two new unit tests added for fancoil units failed due to array allocated dynamically in the first unit test. Added array de-allocation and resolved the issue.  Did more cleanup, merge with develop and pushed to remote.


Cool!  A couple of reactions:

The circles are a bit big. The numbers in the circles are supposed to be the darker yellow color (#E3B052 i'm pretty sure)

but also, I saw this style applied in 'lesson-block', not 'info-block'. I'm not sure about the appropriate coloring for in an info-block. Maybe a question for @zachwise or @emilywithrow .

But good for you for getting in there and monkeying around.


This line is too long, but I don't understand what it's supposed to say well enough to try to rewrite.


Interesting note added to the question. Indeed, such small change minimizes the possibility of usage error by the program end-user.


mtm.nuggad.net appears to redirect to http. (Hadn't seen this one when I made #2388.)


Sure Win. Looks like null values are eventually removed from observations at line 112.


`PropertyMetadata` is only a wrapper over a name of the property. As is the case for all wrappers ever, we must provide sensible `equals`/`hashCode`/`toString` for it, otherwise it can't be used as a hash map key, which is illustrated in this test. Here I'm achieving this with the data class, which seemed the most reasonable thing for me to do.


Haven't thought of this, but yes, maybe it's not good to leak implementation details to `toString`


empd (nmerket) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This was kind of a **sample application**, in which I never wanted to integrate analytics. During development of the application, I came to know about Mixpanel Analytics, so I thought of integrating it, to see it in action.

Also I'm thinking of updating the application, and if I'm doing so, I'll surely remove analytics and all permissions which are used.


well I think I may consider that "generic direction" rather than "a specific recipe"; certainly if I read that I would be tempted to say <hostname> rather than using backticks....

I dunno.  it's a little weird in a teuthology task, but I guess it's not hateful.  If we keep it that way, I request a comment to alleviate the next-guy-like-me's surprise, though.


I would change this to `spider = NodeSpiderCrawl(self.protocol, node, nearest, self.ksize, self.alpha)`
then pass the constants into `__init__` when the server is created.


More comments that can be axed. More questions are raised by this one than it answers.

" // don't move transports which are next to a good spot" seems like a good comment, but there are two lines below it which it maybe belonged to. Simply that question alone makes it a bad comment since now it degrades value.

Assuming that maybe the commented out line wasn't what the comment was about, scanning the rest of this method, we see neighborList which is perhaps related - but it's not readily clear how "not moving transports that are next to a good spot" really applies. Why make the reader go through all these exercises and guess work to eventually not gain anything?


On Wed, 12 Aug 2015 13:37:16 -0700, Thomas Gazagnaire wrote:
>
> well, you need to infer virtual package names then...

How?


Omit the class name when calling another method in the same class.


Seems to work now... Hrmm...


I would avoid this change for now. ID is used allow over the place in the app, both in the original code and in the my code. It will almost certainly create unforseen bugs unless we find every single instance of ID.


PHP errors. It caused Miraheze to go down.

On Wed, Aug 12, 2015 at 12:14 PM -0700, "Reception123" <notifications@github.com> wrote:
Why was this reverted?

---
Reply to this email directly or view it on GitHub:
https://github.com/miraheze/mw-config/commit/35e689f26891a5e63eeaaeefc102e5377ad3710a#commitcomment-12672889


What do you mean that these tutorials are saved in the repo?


Please provide default values. You can use merge


Add to your .gitignore file:
.idea
coverage
dist/build


r+


Yes, enum makes sense.

Also, we have the words "size" (in the flag), "reserved" and "used". The flag means that the reserved amount is fixed, so I think they should use the same word. Some suggestions:

- `fixed_capacity`, `capacity`
- `fixed_size`, `size`
- `fixed_reserve`, `reserved`


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


this two line comment is redundant to the "if(maxShipsTerr != null)" below it.
The comment really should really read "// skip needless work if maxShipsTerr is null"
Even better, don't bother with the comment in this case, that is already implied by the fact we skip stuff when maxShipsTerr is null.


Seems like the injectorState here and the state in ManualApplicationLifecycleState can be combined, especially since the resolveState() logic also just does a combine.


@Fauz-Tangent why do you want to exclude submitted hours from the total calc? You should sum what ever rows are returned by the project or date filters.


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/6ca9195c4386a3703f8aaed8ad280a0d2e99f0fb


merging graydon/stellar-core/bug-690-cache-vs-transactions = 6ca9195c into auto


graydon/stellar-core/bug-690-cache-vs-transactions = 6ca9195c merged ok, testing candidate = c3d023c8


Lots of commented out code, now wrapped weirdly. Only potential and no actual reasons to keep this stuff around. In the meantime it's maintenance and extra stuff.


Probably don't need to check in this test


will rename `reserved` to `capacity` and call the flag `SOL_BUFFER_FLAGS_FIXED_CAPACITY`.

What about the other flag to state memory is not owned? I'm thinking about `SOL_BUFFER_FLAGS_NO_FREE` to make it clear.


Sure, I'll add a comment!


Size might be confusing with used in some cases, when it's not fixed capacity, we build a buffer and want to do some write of it to a file.


%s/healthy/unhealthy?


C .. F will not work.
need change in CreatureAI.cpp

void CreatureAI::SendAIEventAround(...) const
...
        // Allow sending custom AI events to all units in range
        if (eventType >= AI_EVENT_CUSTOM_EVENTAI_A && eventType <= AI_EVENT_CUSTOM_EVENTAI_F && eventType != AI_EVENT_GOT_CCED)


A unit for the timeout in the method sig would be nice


I don't recall why. Removing it doesn't appear to have any adverse affect in either ExpandableText or OverlaySample which are the only known uses of ClampedText at the moment.


The repository contains the entire Drupal contribution history and will be ignored.


Nice touch with the 'logging you in' text change :)


This fixes #86

I've included text to indicate what tool file(s) should be choosen by the user:
![image](https://cloud.githubusercontent.com/assets/1618378/9236304/5ef348ee-4144-11e5-8c73-f85d153539da.png)

I've also changed the filters of the dialog boxes: they now filter on the expected files:
![image](https://cloud.githubusercontent.com/assets/1618378/9236370/d1c886c2-4144-11e5-98b0-861f8e81b9ec.png)


pdftk can't do this

```bash
	pdftk A=$1 B=blank.pdf cat A1-end B1 output $1
```


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


`Handler` is an abstract base class, does it still need to be initialized?


Merci, pour l'exception, j'arrivais pas à l'ajouter et l'enum etait un test


I gave up trying to get this working for all devices: https://code.google.com/p/android/issues/detail?id=181956


if A4 paper use a4 instead of `letter`.


cc @jcrist


Wouldn't finance_generate_loan_hash be a better name.


Actually we're not working with addresses here, but rather segment sizes. Each segment has its memory-size given by the `p_memsz` value in its corresponding `phdr`. Every `phdr` also has a value for `p_align`, which tells us the "alignment" for the corresponding (and individually loaded) segment. On my machine, with huge page support on x86_64, this value is usually 0x2000000, or 4MiB. Therefore, in order to compute the total size occupied by the executable's loadable segments in RAM, I must round every value of `p_memsz` up to the nearest multiple of `p_align` before adding it to the total memory size. This is why, for instance, any executable with n loadable segments on my machine will have a memory footprint of at least 4*n MiB (more if any single segment has a base memsz greater than 4MiB).

This was why I initially performed this operation in one go as `memsz += (phdr->p_memsz + align - 1) & ~(align - 1);`, prior to merging this code into UST and using the `ALIGN` macro to perform the same thing. I was trying to convey the meaning that it's not the total memory-size that is aligned, but rather the size of separate segments, which each contribute towards the total.


We don't need to check if the dbIndex is equal to the old value because if the code is correct then it can never be not equal. But if you want to just do a sanity check please add a error log in case it is not equal which is unexpected.


I hope the latest commit fixes the tool again. If not, please let me know.

On 08/12/2015 04:52 PM, Tudor Bărăscu wrote:
>
> The network refresh works now. However, clicking the profile tool:
>
> Traceback (most recent call last):
> File
> "/home/web/.qgis2/python/plugins/qgepplugin/tools/qgepmaptools.py",
> line 121, in canvasReleaseEvent
> self.leftClicked(event)
> File
> "/home/web/.qgis2/python/plugins/qgepplugin/tools/qgepmaptools.py",
> line 339, in leftClicked
> QgsPoint(snapped_point.snappedVertex))
> TypeError: append() takes exactly one argument (2 given)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/QGEP/qgepplugin/commit/6bc1fa10351dc18e86bf4c4f266116b5043e0a40#commitcomment-12666427>.
>


Merge this with the AlwaysHealthy version? They do the same thing.


Can you please rearrange this code to remove this `Unlock` and move the `return` statement to end of the for loop and avoid more than necessary Lock/Unlocks?


In particular this lets us `Ctrl-C` escape out of a computation and not have the progressbar thread continue on the screen


I'd like to track these independently so setting the lifecycle state in ManualApplicationLifecycleState doesn't override the injector state.


Also before anyone points out the obvious, yes, this is terrible. It's also temporary while things are still being planned and standardised


You need to also update this function with the similar log as was done in `h.set`


Fixed


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (751 of 751 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-16.56%25-green.svg)


@kalyankondapally, aah I didn't. Thanks for pointing out. Were these patches introduced recently? I didn't have to apply these patches earlier.


comments


usar foreign key para a tabela da sala


Doesn't print the key.


Good catch. Thanks.


Do we still need the logging?


I think I picked up the `-1ULL` from the babeltrace source where it is a fairly common pattern. I changed it to 0/-1 with `memsz` as an output parameter to be more in-line with UST's conventions.


Looks like this should remain processors


Actually this results in the error given in previous comment.


Most likely. I would just like to make sure this is well defined. e.g. the actual request will only have a single error type/object that can be inspected and any other error will be from user error.


OK.


Added exclusion to fix #43 and also found the need to exclude SP1002 and SP1004 after trawling through all of the CTX pages for XS65...


It might be. Let's see what @IntelOrca says.


That would be better, yes. An alternate name for the function might be `emplace`


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 306](https://teamcity.labkey.org/viewLog.html?buildId=266031&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0 Build time: 00:02:13
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


TeamCity pull requests :: netty [Build 11](https://garage.netty.io/teamcity/viewLog.html?buildId=261&buildTypeId=pulls_netty&guest=1) is now running


Would we temporary add typedef CSwordModuleInfo BtModule; (and derivatives as well) to decrease pain of future renaming for BtMini?


@maraujop Is it safe to install this repo via pip? The 1.4 version is causing:
```
[myvirtualenv]/lib/python2.7/site-packages/crispy_forms/utils.py:25: RemovedInDjango19Warning: memoize wrapper is deprecated and will be removed in Django 1.9. Use django.utils.lru_cache instead.
  default_field_template = memoize(default_field_template, {}, 1)
```
Anyway, just asking (no rush). Kudos for the great package!


What's a "detail?"


Generaliza melhor isso, senão essa função fica muito específica. Dessa forma, você só garante que determinada coleção tenha um índice "line" em ordem crescente. Mas e se você quiser criar outro índice que não seja esse em alguma outra coleção? Vai criar outra função pra isso?


Uh...this smells, why are we putting strings in the table?


this previously errored if the address was not an IP (like a DNS name). now it silently returns nil below


@vais - I did put a simple test case in that issue. I came up with a more realistic example though and #858 seems to be fixed. Do you want to close or should I?


Not encrypted. Encryption is two way.


And i agree, separate class with inline constructor would be good, with const-convertion and in separate header.


Hmm, I only used seq because the script already uses it, and I tried to match my coding style to the rest of the script...

Using a hotplug script would be nicer, this is just a hotfix to make alfred start relyably again.


Look at http://php.net/manual/en/ref.password.php.


I have honestly never been a testing maven (it is tough to test OS X internals when you are reverse engineering). I know I should be doing more testing with my bloc work but I am putting way more hours into Newlio than what I expected when I signed up for bloc. It doesn’t impact anything that Redradix is doing but Newlio has a history of working on a dozen things at once (and not doing any of them particularly well). I’m trying to change that (which is why I wanted to bring you in). But, for the time being, I am trying to manage all of our disparate projects which leaves me very little time for bloc. It is Wednesday at 5pm and I’ve already put 43 hours into Newlio work this week.

I actually like the blocmarks project (I’ve been using it personally) as it currently stands. I would rather not add “Like/Dislike” buttons and the profile page. I’d rather just add URL Previews and readable URL support.

-Reed

> On Aug 12, 2015, at 4:10 PM, Alejandro Andrés <notifications@github.com> wrote:
>
> hey, don't you like tests? :)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/rmangino/blocmarks/commit/f5ce9b2f6409fe521fa0ffd35bbd80911cc1f7bd#commitcomment-12674119>.
>


This is not entirely true. Since you divide by `report.ips`, the result cannot be “versus the fastest one”.


LGTM


Docs!


Actual CSwordBackend::getPointerList is not used anywhere but we may maintain it anyway. Ok.


TeamCity pull requests :: netty [Build 12](https://garage.netty.io/teamcity/viewLog.html?buildId=262&buildTypeId=pulls_netty&guest=1) is now running


@MartijnKaijser ? What are you doing?


I'm not sure this completely solves the issue.
```js
options = [ { value: 'add-1', label: 'evil option' } ]
```
will still show the warning when the user types '1', as the keys for both the add option and the 'add-1' option will be the same.


Hay algunas imágenes rotas.


I've done a fresh install of calendar and updated the datetimepick js and for some reason cannot see the new date/time picker.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.481](http://teamcity.monogame.net/viewLog.html?buildId=9557&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


The main thing I like about CanCanCan is that the authorization rules aren’t spread all over the place (plus it is easy to understand). I’m not sure I know under what circumstances I’d be better off using a homegrown solution.

-Reed

> On Aug 12, 2015, at 4:14 PM, Alejandro Andrés <notifications@github.com> wrote:
>
> hey, what do you think about cancancan, do you like it? do you see when is it useful and when it's better to use pundit or go with your own solution?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/rmangino/blocmarks/commit/0a1dadaad12bf4373069b9e7383081e17e2de8bb#commitcomment-12674202>.
>


I found it disorienting to have a case where the tool succeeded but no output file was created.


superduperydoo


this particular one looks wrong to me... not sure why


style: the "{" should go into the next new line.


Thanks,

Looking forward to giving the updated code a try this evening then hopefully merging the basic autonomous navigation and Pixy code from my previous setup to work with everything running on the RPi2.

Please ignore the second git request if it comes through (which I have closed so hopefully doesn’t).  I was tidying up my local files and inadvertently tried to publish my changes to your repository rather than my working version – still learning how this github process works J

From: KurtE [mailto:notifications@github.com]
Sent: Thursday, 13 August 2015 8:32 a.m.
To: CreedyNZ/Raspberry_Pi
Cc: CreedyNZ
Subject: Re: [Raspberry_Pi] Switch BioloidEX_Usb2Ax to BioloidEX (dbdb6fa)

thanks,

Take a look at my most recent delta. I believe it should fully cover this. It also has updates to how I was shutting down the worker thread (or in some cases it was not). Also I updated the code in the upper branch Phantom_Phoenix to hopefully be the same code.

I am also thinking about the other delta which is to use a symbolic name for the USB2AX. I have thought of doing this as I don't like how it assumes it is ttyACM0. But if I am going to make this change I may change it slightly more and if ttyUSB2AX is not found then try ttyACM0...

—
Reply to this email directly or view it on GitHub <https://github.com/CreedyNZ/Raspberry_Pi/commit/dbdb6fadb663766cc984bd60dd7a1f97339de2e1#commitcomment-12674670> .  <https://github.com/notifications/beacon/AK4n6qzVcep2fgctek-WQh8lvR71Lj5yks5om6TIgaJpZM4Fqf-l.gif>


👍 Should be `define-clojure-indent`


Perhaps:
```
try:
    key, res, tb, worker_id = queue.get()
except KeyboardInterrupt as res:
    pass
...
```

Avoids repeating the cleanup code twice.


TeamCity pull requests :: netty [Build 11](https://garage.netty.io/teamcity/viewLog.html?buildId=261&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4638, ignored: 16 Build time: 00:08:48
### Failed tests
```
io.netty.handler.codec.http2.DefaultHttp2FrameIOTest.binaryHeadersWithoutPriorityShouldRoundtrip: <no details avaliable>

```


TeamCity pull requests :: netty [Build 13](https://garage.netty.io/teamcity/viewLog.html?buildId=263&buildTypeId=pulls_netty&guest=1) is now running


Can you include a little description about the `javascript-watch` and `less-watch` tasks.


Good commit.


The standard deviation comparison seems to work fine. Great!

Nitpick: You could reduce duplication by calling `$stdout.printf "%20s: %10.1f i/s", name, report.ips` before the `if` call.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/75338836


Hi @jvzammit — what version of Django are you running? How's your test coverage? Fancy testing against master and reporting issues?

We need to extend test coverage for recent versions of Django and make sure all is good. We'll then roll a release. This is top of the list, so if you're not able to test safely, and can live with the warning, you may want to wait.  But all input welcomed!


Me gusta lo de tam-letter2 etc, estás respetando el principio, ahora, no sé si pudiera quedar más descriptivo. Saludos


Thank you.