I'm sorry to bother you,  I'm a fan of China. Now I'm learning how to write I2C driver, see your PCA8574 driver.
I would like to know how that the upper class would like to call this driver, I need to write in the main function of the APM-copter, because it is two different projects, call the function if you need to write.
In addition: if I myself wrote this driver, whether to modify
Makefiles/config_px4fmu-v2_default.mk
Src/drivers/drv_io_expander.h
Src/drivers/pca8574/module.mk
Src/drivers/pca8574/pca8574.cpp
This makefiles/config_px4fmu-v2_test.mk weather it Is no need to change
(Sorry,my English is poor    ^v^  )

(很抱歉打扰你，我是一名来自中国的爱好者。现在我正在学习如何编写I2C驱动，看到你的PCA8574的驱动。
我想知道，上层想调用这个驱动，我需要在APM-copter的主函数中怎样编写，因为这是两个不同的工程，调用函数是否需要自己编写。
另外：如果我自己写这个驱动，是否修改
makefiles/config_px4fmu-v2_default.mk
src/drivers/drv_io_expander.h
src/drivers/pca8574/module.mk
src/drivers/pca8574/pca8574.cpp
就可以了
这个makefiles/config_px4fmu-v2_test.mk
是不是不需要改)


All but the size argument are prefixed with `0x`... make consistent


@173210 Okey doke :+1:


Yea, I tried using your repo first, but wouldn't boot past the LG Logo.
Thought it was a kernel issue, but my kernel booted fine using the hima
repo.
On Aug 13, 2015 10:12 PM, "Rashed Abdel-Tawab" <notifications@github.com>
wrote:

> You know I've got a g4 repo right?
> http://github.com/lg-devs/android_device_lge_g4-common
> <https://github.com/lg-devs/android_device_lge_g4-common>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/graig79/android_device_lge_g4-common/commit/181ae486d735e6c27300ed71206b4814f9aec08a#commitcomment-12703309>
> .
>


Consider providing implicit conversion support.


does need to deploy https?


@rohanp Ion is a complete rewrite of Iodine with a radically different api.


專業點好嗎 XDDD
![screenshot on 8 14 2015 at 10 47 08 am](https://cloud.githubusercontent.com/assets/88208/9266332/f9b4ddb0-4271-11e5-8d1e-f3f5e959c8ea.png)


Yep, I'm thinking supporting Scala-ish syntax support would be next step.


This is an official project created by the CSL and Systems Administrators. Iolite is an unofficial app written by another student.


@LorenzMeier Thank you


```
if ((permissions & (u32)MemoryPermission::ReadWrite) != permissions) {
    return ERR_INVALID_COMBINATION;
}
VMAPermission vma_permissions (VMAPermission)permissions; // Or just pass this in as type VMAPermission?
```


Streamlined config.xml


same above.


Unnecessary `break`


1945 is great!


Why not just do this earlier and always return `result` instead of checking if it's an error then dropping through to here?


Let's wait on minifying, as it sucks for debugging.


i think return options directly may be better.
'''
 p.options = jpush.options({
     'apns_production': False
})
# {"options":{"apns_production":false}}
'''
i use it first time like this.


MeasureTool.testLabel=test


q
На 14.08.2015 05:12 "Jjordison82" <notifications@github.com> написа:
>
> Great
>
> —
> Reply to this email directly or view it on GitHub.


第三篇 （Ccc第一篇）       2015-08-14            多云 大雨 转 晴 ：火星天气良好，嫦娥出来了                 author：Ccc

近成都天气良好有点骚热 ，群主突变姨妈来了（liao），群主嘛一个月总会有这几天，情绪低落 精神失常 波动性的心理混乱 内分泌失调，早日康复，多吃药，好得快。


Enum?


I will add this template soon. thanks


reporets?


The logic in this function should be implemented in `maketar()`.  We no longer need the archives under `~class/TURNIN/assignment` we only need the link to the latest archive, in `on_time` or `late` subdirectory, there.


Можно обойтись другими способами, без изьятия из потока


Лишняя


RemoveMoreBadCharacters (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (749 of 749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.21%25-green.svg)


Вот сюда её


Will only work on Chris' machine


После запятой - пробел


Any changes from an administrator's standpoint?


После : пробел


merging from upstream


Typo


OK, getting a few new issues; workflow looks like this now:


I agree that using MD5 as example is not good, because it requires CPU and needs a thread to compute it, whereas IO is blocking because it waits for a response coming from an InputStream.


{ либо на новой строчке - либо на одной строчке с модой и [


Не переносим - так }, { надо


Pabitra,

Are you talking about current develop branch?

Drew

On Fri, Aug 14, 2015 at 1:59 PM, Pabitra Dash <notifications@github.com>
wrote:

> @zhiyuli <https://github.com/zhiyuli> - It seems to me the two models
> fields that you have for the RefTimeSeries class are not used anywhere. If
> you can make sure these fields are not needed (I think the metadata model
> class ReferenceURL is being used in place of those 2 fields), then this
> class can be a proxy class like other resource type classes as part of the
> resource class refactoring that @ironfroggy
> <https://github.com/ironfroggy> is doing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hydroshare/hydroshare/commit/27c849bf5a1f850cf63e2b59ff5b361dfcbcde2c#commitcomment-12717967>
> .
>


why....? :'(


Ahh, the bump.sh did that. Guess we need to update that.


Maybe a warning would help detect faulty behaviors.  It is not a must though.


That is a cool solution.


В целом гуд
Возьми на заметку правила написания, писать сразу нужно хорошо и чисто
https://ru.bem.info/technology/bemjson/v2/bemjson/


Looks good.

Couple minor things:

1. Line up the string. (Add an extra space or remove space on the other lines.)
2. Add @author field.  :)


Note that this should still show up if the user's in the process of adding an interaction (i.e. they got here by clicking the big 'add interaction' button).


Would be good to note here the purpose.  Caller should attempt to available local work while waiting for more incoming data.  Example might be doing partial sorts while waiting for additional data.


To quote [Daniel P. Berrangé](https://www.berrange.com/posts/2012/06/27/thoughts-on-improving-openstack-git-commit-practicehistory/):
> The cardinal rule for creating good commits is to ensure there is only one “logical change” per commit.

It's difficult to understand exactly how many logical changes this commit contains. Perhaps 0.75. Personally I suggest to create 3 commits:
1. "Introduced BtModuleList and BtConstModuleList" in which you just add `btmodulelist.h`
2. "Use BtConstModuleList where applicable" which has the contents of this commit.
3. "Use BtModuleList where applicable" in which you substitute all `QList<CSwordModuleInfo *>` with `BtModuleList`.


98318570_RemoveRadianceCheckbox (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.35%25-red.svg)


101280704_LowTempRad (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.95%25-green.svg)


Факультативом
В комит попали маковские файлы .DS_Store
чего быть не должно
Для того чтобы подобный мусор не попадал внутрь, существует файл .gitignore
В него надо добавить правило
http://git-scm.com/book/ru/v1


since you are changing the variable name from R to RR, how about giving it a name which explains what RR holds? At the minimum some comments.


yes, we don't need to talk about the implementation details of the blocking operation what matters is how the API is used. talking of the implementation (using a thread for computing the MD5) only brings confusion.

Perhaps the article should be split in several parts perpectives:

1/ using an async API
2/ implementing an async API based on a blocking API (jdbc)
3/ implementing an async API based on a non blocking API (mongodb)
4/ advanced: implementing an async API based on blocking and non blocking API and how to compose blocking + non blocking with Vert.x


101235614-Fix-AFN-Error-Output (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1791 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This should be in the "allowed_to_build" function.


Looks good to me.

Thanks!


Необходимо добавить блокировку работы в ручном и автоматическом режиме. Выставлять дополнительный регистр при установке ручного режима через EN_CTRL для определения что разрешение на работу пришло именно по команде "Ручной режим"


The previous version only accepted some of the types. Now that it accept all message types ("categories") even things like warning suppressions (`#pylint: disable=...`) will appear as issues which makes the suppression useless.
Maybe the categories to be reported should be configurable?
Current existing categories seem to be "info", "convention", "refactor", "warning", "error" and "fatal" (from `pylint.utils.MSG_TYPES`).


Yes, I've just refactored the secure_token method.  It is now a private method in the Helper module.

I'll check later for the dependency injection.


@zhiyuli - Yes. If in develop branch you can determine that the RefTimeSeries class does not need the  2 fields ('reference_type' and 'url') then let @ironfroggy know that.


ship it..


The idea of git-init-submodules.py was nice because it was automatic, but at the end it is meant to be a hack to the braindead duktape's repository.

@anselmomelo suggested we do our own duktape repository (could be in solettaproject) and provide a clean version of it. It can be a fork of original repo or just a manual pick (ie: a script that pulls the other repo, updates files and commit them in a clean state). Something that we do not have manual intervention, just a clean way to deliver the integration with `git clone --recursive`


What about the option to write the JSON results out to a file? (outputting to console won't make it easy to create the json file as you output some text before the results)


Nope, I meant something like:
`int endPoint = data.size() or offsets[row + 1]
...
return data.substring(offsets[row], endPoint)`
Since what we need is just the end point not the length.


this is not correct. If we provide an absolute path such as /usr/share/duktape, then we will try to generate duktape.o at that system directory. We need to force it to be inside our `build`


Looks good to me.


2.0.0 nownownownownownownownownownonwononwonow


Shouldn't these be Log_debug ? Otherwise there will be a lot of periodic prints.


Cool thanks. The pragmatic solution :)


Yes, the plugin directory contains /plumgrid after /plugin, thats what I'm assuming will be present.

https://github.com/plumgrid/plumgrid-neutron-plugin/tree/stable/juno/plugin/plumgrid
https://github.com/plumgrid/puppet-neutron/tree/stable_4_1_2/files/plumgrid


Я что-то очень долго мучалась с этим всем:)
Нужно подумать:)))

пятница, 14 августа 2015 г. пользователь brus-fabrika написал:

> Очень-очень неплохо. Действительно.
> Единственный момент, который смущает - это как теперь пользоваться
> оценками по экзаменам?
> Например, я хочу взять и посчитать средний бал за вторую сессию. Как это
> сделать?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OlgaGrygoryan/homework/commit/178f9c79f3cfbbc3d5c1d4f42542f5094f2c132f#commitcomment-12716685>
> .
>


Remove commented out code since it's not used?


Seems fine to me, thanks!


try to avoid return statements in scala :)


Fix: There is no matrixhelper library now.


great comments here, thanks


Hi @SchlesserClaude,

I  which situation, please ?


r+


RemoveMoreBadCharacters (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sure, this is fine.


I guess it's ok here, since if it's wrong we're in bigger trouble, though small info about `assert` vs. `require`.

We usually avoid assert as it throws an `AssertionError`, which is not handled by the default supervision strategy in Akka, and it kills tn entire application (supervision bubbles up to the parent, and shuts down the system).


@jqnatividad pgloader is great, but it's unnecessary if the CSV being imported is of perfect quality.  In this case, I'm generating the CSV in Python and can ensure it's high quality, so I may as well use postgres's `COPY` directly.

If you're feeding in large CSVs from external sources, `pgloader` is great.  Here, it's an unnecessary dependency.


I'll add a note to the error why it threw (`assert(boolean, string)`)


@tupaje: Hey, I'm curious what the advantage is to moving the server.js and assets.js files into the src directory rather than leaving them in the server directory?


looks good


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/826f34aa50d4f212d9d2ea46844797ea2680e5a2


merging graydon/stellar-core/tighten-memory-use = 826f34aa into auto


graydon/stellar-core/tighten-memory-use = 826f34aa merged ok, testing candidate = 28231d6f


On Fri, Aug 14, 2015 at 12:59 PM, Peter Portante <notifications@github.com>
wrote:

> @atheurer <https://github.com/atheurer>, were you able to run the unit
> tests to see if this affects anything?
>

I have not run any unit tests.  I am almost certain it will fail since the
output has changed

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/atheurer/pbench/commit/f37a37449bddf808cba3e16b66646f64fb03e281#commitcomment-12715763>
> .
>


Moving to 1-based log looks good, thanks


Ok, seems like a valid optimisation


is that used?


necessary?


we probably don't need opened anymore (next line)?


We need to put <html>  to match with </html>


This causes a style test to fail:

http://ci.ros2.org/job/ros2_batch_ci_linux/190/testReport/junit/rosidl_cmake/lint_cmake/whitespace_extra__cmake_rosidl_generate_interfaces_cmake_136_/


Resolves #49


Commited them, also marked a few spots with `XXX GLOBAL` where you leaked one, might wanna check up on that


sounds like we don't need selectedElem and that select = selectValue


 - Splits taggedsent_to_conll and taggedsents_to_conll
 - Added param type and rtype for the functions


Of course you did. Did you forget to maybe add the Human and Player inherited events?


@vahidreza add the snippet @brunetgarcia wrote above to be able to build from phonegap build.

@brunetgarcia, push notifications for android needs a post build patch in order to work. This is because we need to set android:name="com.medlei.App" on Application tag, but phone gap build doesn't support this.

To accomplish this you can use [apktool](http://ibotpeaches.github.io/Apktool/) to pack & unpack the apk and jar signer (included on java SDK) to sign the application again. After installing this applications you can write this commands on terminal to patch the apk:

    apktool d <path to apk> -o <output folder>
    sed -i -e 's/<application/<application android:name="com.medlei.App"/g' <output folder>/AndroidManifest.xml
    apktool b <output path> -o <path to new apk>
    jarsigner -keystore <keystore path> <path to new apk> <key alias> -storepass <store pass>

This also works on windows if you set your PATH, only sed is missing and you can do the change manually using notepad++ or even wordpad.


I see the test removed, but not the actual method.


nice work! thx! ;)


@gabizou

I didn't do the potion events to begin with. Perhaps THAT guy should look into adding those.


Might as well move this inside the `if`.


We should emit the consequence as well, as in "…so the tooltip will be missing."


So the issue here is that instead of a hard-coded scaling factor (like 1.5), we should be adding a parameter to determine how the values are normalized. This is done for polygon normals, and the same process should be used here too:

https://github.com/tangrams/tangram/blob/master/src/styles/builders.js#L86
https://github.com/tangrams/tangram/blob/master/src/styles/builders.js#L138
https://github.com/tangrams/tangram/blob/master/src/styles/polygons/polygons.js#L155


no, actually we process that... I found an error in one case but what it subst the provided path with buildstate


I strongly agree with the approach.


the change to line 856 in this commit makes the CI date helper a requirement. that was the reason for the previous `function_exists('now')` check.


This would be one of the ones that isn't done yet, since it's still in terms of makers, right?


Maybe if config is provided programatically we should just replace `configData.config` instead of trying to merge?  That makes sense... I wonder why I did it this way in the first place...  :/


98318570_RemoveRadianceCheckbox (macumber) - i386-Windows-7-VisualStudio-12: OK (2193 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.01%25-yellow.svg)


let's change this to $HOME = tmpdir.join('HOME')
and ensure $XDG_RUNTIME_DIR is unset


А эти 4 if-а нельзя как-нибудь в один метод вынести?


I don't understand your rewrite; are you object to the exception handling I'm doing? Another possibility I considered was to invoke the callbacks asynchronously instead; that would be a very javascripty solution that would not require dealing with exceptions, something like:
```
window.setTimeout(() => cb(msg), 0);
```
I think the asynchronous semantics fit nicely with javascript and the error handling is good (an exception in one callback doesn't prevent the others from being invoked), but, as usual, it obscures the stack traces so I'm not sure what's best. Thoughts?


TeamCity WildFly Core :: Pull Request :: Pull request aggregator starter [Build 1](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64847&buildTypeId=WildFlyCore_PullRequest_PullRequestAggregatorStarter) is now running


I'd been using a tuple in the other plugins for space efficiency—not having to store the keys in ES—but this will work too.


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2177 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.28%25-yellow.svg)


I haven't yet gone through and renamed all the `makers` lists to `menus`.


Эти поля должны быть приватными


TeamCity WildFly Core :: Pull Request :: Pull request aggregator starter [Build 2](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64849&buildTypeId=WildFlyCore_PullRequest_PullRequestAggregatorStarter) is now running


Maybe just add them for the sake of adding them?


What is this for?


We have to put the cast somewhere, because the underlying rpc code receives untyped messages over the wire and must pick the observable to dispatch them to based on a string name. If dispatch required an `A`, then that external code would have to know how to cast to the correct type, which isn't possible. I think I can rework this though to handle the types a bit better.


Although, in this case, I'd not store a single-item dict all the time: just store the qualname string as the first item of the tuple.


Install and uninstall packages from within Atom, and your `.atom/packages.txt` file will be updated automatically. Sync your `.atom` directory however you like while excluding the `packages` subdirectory, and use `apm install --packages-file $HOME/.atom/packages.txt` to reinstall or update your packages on a new machine.


hey tom looman, idk why you are on our repository, we want to delete the files on here that are not ours. are u here?


looking fine. I will test it right away while I'm still working out that defaultbackground problem


Hi @juricast,

Are you saying the problem is fixed with newer kernels? Or is "mips malta" different from "mipsel"? (I don't know anything about MIPS.)

If the test still fails on some platforms I'd rather not remove the #if guard in master until we've figured out the problem.

Please let me know what you find.


Is this really faster in the long run?  `JSON.stringify` will execute at least once (mostly twice) for every digest cycle (read: when any scope property changes or method is called).


Для того, чтобы не было такого плохого кода, мы используем guice.


Add this to forbidden apis?


As mentioned, this should be added as a separate test case: test the result of encoding the 'ISO-8859-1' file name with 'US-ASCII' encoding: should be able to verify the (garbled) file names.


Используй guice: @Inject HypermarketHolder


98318570_RemoveRadianceCheckbox (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It's not a forbidden API issue, it's just not in JDK 7 (depending on IDE, should have the language level and SDK set to 7).


You are correct... I thought I had tested with local files, but now the results are as you say.
I'll make the change.


Regardless we should probably add the no-charset version to forbidden APIs to avoid weird charset issues for non-UTF locales


PluginZoneInitialization2 (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Ok


Это должен быть интерфейс HypermarketProvider. У него сейчас должна быть одна реализация - ResourcesHypermarketProvider.


chill bro


Truth.


RoomAirflowNetwork (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Will need to automate this


I'm working on running this code locally, so I'll be poking around asking questions about how different things work.

One such question: Where is `time(...)` coming from?


I like it, but this doesn't solve @lucasdemarchi's issue where the address of the i2c bus changing from 7 to 8 if the location of the bus changes due some BIOS configuration (like pci or platform in minnowboard's case).

Since sysfs names can't have space in them, we could allow the option to be a serie of address to be space-delimited (since we don't support options being array of strings). Then one could say: `create,i2c,pci0000:00/0000:00:18.6,0x69,l3g4200d create,i2c,platform/XXXX,0x69,l3g4200d i2c/7-0069 l3g4200d 0` to try them all in that order.


Would '0.0' rate-factor a natural marker for NONE. In this case we can use 'double' instead of 'Double' avoiding auto boxing and perhaps if ifs statements that use 'hasRateFactor()' if the maths hold.


Typo: alow -> allow


Did you manage to preserve the cases where the Jump To X items come at the top of the menu, even if they're inserted later? I found that difficult to maintain when I refactored this for the makers, but I tried.


5000-th commit, nice.


Че за жесть? Почему тут проглатываются эксепшены?


LGTM !


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 326](https://teamcity.labkey.org/viewLog.html?buildId=266523&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 29 (1 new), passed: 2 Build time: 00:17:14
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 19 more failed tests, see build details
```


@jcodec this one really helped speedup mp4 parsing/generating on android


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/75662435


Looking good! I was going to recommend that you inline the menus into the Ref classes, but I actually rather like how the data extraction is separated from the templating, just like in a decent web app. In addition to being faster, this is going to end up significantly more comprehensible than the original or even the maker version.


Closes https://github.com/TrinityCore/TrinityCore/issues/15280


//cc @moollaza  not sure there's consistency in this file so not sure how you'd like it to read.
in any case--will be linking here for the global quack &  hack


On it.


Aren't you saving the changes?


This is the BQ < 18 goes to 6 transformation... I guess you don't want to change that for now.


В тикете сказано, что нужно хранить картинки в файловой системе. Их можно выгружать из джарника в файловую систему при старте сервера - но это просто один из способов заполнения файловой системы картинками


RoomAirflowNetwork (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I actually looked for a coffeelint gulp tasks and couldn't find it, and I didn't want to only use the stylint official gulp task.

Either way, I just updated this.


fast-forwarding master to auto = 28231d6f


@Kitke superfluous empty line (should be only one, not two)


Убить такой конструктор. Этой логики тут не должно быть.


i wonder if this should be a string or a number. any reason to force it to be an string with the formatting, instead of getting an integer and converting it to string when required?


Issue reported at robolectric/robolectric#1990


asdasdsadas


considering this is a private method I would say this if check is redundant... perhaps the the calling code should not put this method inside an iff (that check this condition) and this method should just return if the stream is null.


should request size_t result_path_size... or take a sol_buffer.


Предыдущие название было лучше


adicionado desenho do esquema de prototipagem.


Even more unnecessary; this is a paranoia check.


@Kitke You're still hardcoding this – just in a different place :P

Can I use this app with my own settings? Nope. I should be given an option to:

a.) insert my own settings in a settings window
b.) pass the options as (console) app arguments
c.) create a config file


Move constants and field to the beginning of the class.


Makes sense. But isn't bios configuration changing stuff something that user should care about?


the pair of bool + int is not that good. Only do an int return and let's do our best to provide a meaningful error.

If above you say -EINVAL may be because the device already exist, could we check for that and "fix" the return code?


Right. It does clean up the environment. But AFAICT `PATH` will be inherited. `LD_LIBRARY_PATH` should probably be handled as http://conda.pydata.org/docs/building/environment-vars.html#inherited-env-vars instead of `build_settings.sh`.


Что-тут делают md5 хэши?? Они никак не связаны с гипермаркетами - они только про хранение абстрактных картинок.


added missing comma at the end.


Is this sensible? Couldn't think of another way to do it.


@gabizou

Perhaps you are THAT guy :p.


This initialization turns out to be totally wasteful (is always overwritten) and bogus (it seems that the developers idea was to have a 2D matrix coded into a 1D array.


Thanks, Dan!


I used string because it's hexa - I just avoided more conversions, storing as int, changing to hexa when searching on sysfs...


Ah, that's a good point. Do you think it suffices to change jump append calls into insert, 0?


Also LGTM.


@tijoinc Did you profile at all? As noted here, the one of the initial reason for array over dict was performance.

I think the path to dict is good for safety and increased flexibility, however I'd have a calmer mind if I knew it doesn't come at a big performance cost.

Maybe you profiled it and it's only minimal, that would be totally acceptable.


It might make sense to compare `log(prevcost)` and `log(cost)` instead of comparing the costs directly.


Опять же, HypermarketHolder не имеет отношения к способу хранения картинок. Он только про способ хранения гипермаркетов.


Redundant OR. just do

```if (crErrorModel == PCRErrorModel.NONE) {```


guessed it, but should we? you're thinking because of the flow that uses this api and gets a string. OTOH the pure-C user is going to have to convert to a string to give a number.


Тут должен быть просто урл картинки, а не сама картинка


@Kitke Why did you change `dataHandle` to `dataDataHandle`?


None of the ones you mentioned will work: cct is not used from packages - it is installed straight from git, so this script isn't going to be invoked on it. the others are not even tested by mkcloud yet (and also not handled in :Staging).


I like how it defers some cluttering NULL logic to the framework. Please see my only comment on performance.


TeamCity pull requests :: netty [Build 35](https://garage.netty.io/teamcity/viewLog.html?buildId=353&buildTypeId=pulls_netty&guest=1) is now running


Этот класс в текущей концепции не расширяемый - должен быть final


Ok so if rateFactor is == 0, this this a division by 0... even so I don't see the need to have a Double vs a double in PCRErrorMode.


Не компилится


return false


RemoveMoreBadCharacters (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The issue in this bug was that incorrect variable was assigned for checking of the condenser pump austosizing.  Assigned the correct variable and the defect file runs to completion without any problem.  Added unit test to demonstrate the same fact.  I will issue pull request for this fix.


Nice simplification


this will break quite a few things bc of the default parameter being true. I wonder if you can keep the old 2 method API around for a while with Deprecation warnings,  and internally call  setup or setupWithSocketReuse accordingly?


Shouldn't we replace this test with a test that correctly checks the condition?


I have changed or declared as deprecated this method thru my changes to make HC to go faster so I will comment on it... apart of saying that is messy.


I also tested what you're printing - but seeing that osc build failed doesn't really help on understanding why osc build failed imho.

My original idea was to save the output of osc build - what is currently stored as build.log in the webdir, under the name "build.log" when build succeeded and under the name "build.err" when it failed. This way you could do less */build.err in order to see all build failures and analyzing them, without having to wade through build logs that succeeded.

in your case I'd have to grep for directories that contain a build.err and then open build.log in that dir instead. yeah, its possible but I think not as convenient.


На все гипермаркеты должен быть ровно один инстанс ридера. Сейчас у тебя на каждый гипермаркет по ридеру.


This one stored and loaded from blob.


You should include inline documentation here to say what this function does.


If the graph-based approach is not ported, thus you should remove this enum value.


Returns http://api.mongodb.org/python/current/api/pymongo/results.html#pymongo.results.UpdateResult which you may want to use to verify that N entries were updated


Hmm! And threshold on their distance from each other?


InvalidIdentity


Whoops. Thanks, @keithgee. Will change this anyway, even if it's ignored, just for practice.


Is it better ```-Math.log10(2.0)``` than ```Math.log10(.5)```? I prefer the second as it is more clear that it is correct.


Can you instead accept any server, rather than just these three options?


Also change the constant name from LOG_ONE_HALF to LOG10_ONE_HALF.


oops it is for being removed.


The text "is not required to deploy DNS security" makes sense.

After that, I think that's making political statements (IMO), and I don't really want to go there in an RFC.


is the getter necessary?


Should this function get named to `setIsRtl` and just pass in `true` or `false`?


Мы тут читаем из ресурсов - они полностью под нашим контролем. Поэтому тут любые эксепшны - это баги, и их можно спокойно оборачивать в RuntimeException, чтобы сервер не смог стартануть.


@Kitke Can you inject windows+controller in the `Toolbar`'s constructor?


Shouldn't need to depend on it anyways :P


Maybe you could just add them in this branch for easier squashing?


Этот класс лучше перенести в util


ok


Худший вариант работы с исключениями)


I prefer that you rename this to update_output or output only.
It's very strange "is_output", because makes me think that machine_learning_sync_data struct refers to an output data, which does not.


put this on previous line?


@Kitke What's this annotation for? I don't see `editSettings()` being called anywhere, so I guess this is kind of framework's magic?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1271 of 1271 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


RoomAirflowNetwork (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 750 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.32%25-green.svg)


Instead, you could check the field type on the mapper itself? Then you don't have to depend on serialization.


PlantOperationSchemes (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.14%25-red.svg)


RemoveMoreBadCharacters (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.95%25-green.svg)


ByteArray стримы хранятся как байт-массивы в памяти, поэтому им flush и close не нужны


Just wanted to add a note here for future reference, when merging, you shouldn't ever have to do it manually as long as `development` is always up to date with master, you can do this instead.
```
git checkout master
git rebase development
```
That will bring over ALL commits from the development branch.  Alternatively, you can squash commits before rebasing, [more info on squashing commits here](https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#Squashing-Commits)


Is public so in needs a javadoc and check on arguments for nulls or bad values.


Precyzuję: mozorg/home/index.lang


> Yep! I fancied a change from Ruby.

Who wouldn't? 😃


Этот Т должны все методы возвращать. Иначе тут нет никакого смысла в параметризации.


I would remove this if, there's no problem setting the value to NAN.


The placement here makes sense for the alphabetization of the key, but in the user-facing menu it puts Dutch in an odd location.


А что, если в коллекции нет точек?


this seems a test too deep and just for an error return, do we really need it?


Ты эти файлики делаешь руками, поэтому в этом месте было бы удобнее использовать xml формат, а не json.


Yes, absolutely. We have already lost a lot of coverage against error conditions. Error conditions are important to test as well, since they can be the places where attackers can get a foothold.


I would create a mutex_unlock function to check if pthread_mutex_unlock() failed to unlock. Just like mutex_lock()


TeamCity pull requests :: netty [Build 35](https://garage.netty.io/teamcity/viewLog.html?buildId=353&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4639, ignored: 16 Build time: 00:19:20
### Failed tests
```
io.netty.handler.codec.http2.DefaultHttp2FrameIOTest.binaryHeadersWithoutPriorityShouldRoundtrip: <no details avaliable>

```


yes


Хотя тут не должно быть вообще никакой логики про гипермаркеты


PlantOperationSchemes (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Картинки бывают не только jpg. Нужно придумать, как быть с форматом.


Я здесь вижу просто продублированное описание. Это не пройдет


@anthonydb We should be (but aren't) sorting the list by user-facing value while composing the template. Can you create an issue for that?


@dolfelt when using immutable, the class properties are always private to protect against external modification.


This method allows customizing the JSON encoding options without overloading the `body` method.


Haven't added tests for this class.


Hi @snapjay

Did you push the `1.0.0` version to npm?

```
bower install ngcart#1.0.0 --save
bower not-cached    git://github.com/snapjay/ngCart.git#1.0.0
bower resolve       git://github.com/snapjay/ngCart.git#1.0.0
bower ENORESTARGET  No tag found that was able to satisfy 1.0.0

Additional error details:
Available versions: 0.0.3-rc.2, 0.0.3-rc.1, 0.0.2-rc.1.0, 0.0.2-rc.1, 0.0.1-rc.2, 0.0.1-rc.1
```


Teste de comentário em novas linhas adicionadas.
@vinihjunior cadê a endentação dessa
? rsrs


@Kitke :+1:


Looks good.


Sounds like it got merged even though it is only needed during development (flagname implicates that. gonna change that in next version)


This builds, but doesn't boot for me.


Not sure this is all ready yet.  Still testing some stuff out.


That makes sense. I was actually going to do that in another release.  I might make that change real quick, but after working on this again today, I started thinking about a big refactor.  I'd like to split out the CLI code into cli.js, and make another file that exports useful functions (and can be included via a `require('npm-dview')` statement.  That way library authors can use this functionality (and get json output based on passing in a package.json path to a function)...


:+1: I was tempted to implement this as a configurable option, but didn't want to get too out of scope / kitchen sink in this PR.  In the latest update to the PR, I do suppress `info` types.  I'd be happy to make it configurable in this PR though.


Зачем тут объекты картинок? Используй обычные байт-массивы - тебе же пофиг, что в них.


Hahaha poxa :'(
Em 14/08/2015 6:27 PM, "Paulo Pereira dos Anjos" <notifications@github.com>
escreveu:

> Teste de comentário em novas linhas adicionadas.
> @vinihjunior <https://github.com/vinihjunior> cadê a endentação dessa
>
>    ? rsrs
>
>    -
>       -
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/K3yboard/estudo/commit/6cb2a40daf5efff7eef5c925e121f16a7f8d312a#commitcomment-12719554>
> .
>


И где все тесты?


PluginZoneInitialization2 (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Here it is: https://github.com/documentcloud/documentcloud/issues/257


looks good


Please fix it (too many seds). I think the build passed.


With the suppression of info, it's at least on par with the previous behavior. I personally don't need more configurability.


I had to change this line in default_spec.rb:
```ChefSpec::SoloRunner.new(step_into: ['step_into_lwrp', 'provides_this'])```
to:
```ChefSpec::SoloRunner.new(step_into: ['step_into_lwrp','step_into_provides'])```
to the test to work. Does 'provides_this' definitely work for you?


According to https://github.com/GrahamDumpleton/mod_wsgi/issues/85, the correct (documented) Python3 behaviour should be to throw an IOError.  Until this is fixed, code should catch both IOError and AttributeError.  So, line 99:

    except (AttributeError, IOError):


Ugh. I meant sdmmc. It seems I'm tired.


What would you prefer for the file name?


I wasn't aware of this API, that is just 100 times better.


ok, will make it back


TeamCity WildFly Core :: Pull Request :: Pull request aggregator [Build 1820](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64848&buildTypeId=WFCorePRAggregator) outcome was **FAILURE**
Summary: Snapshot dependencies failed: 2 Build time: 00:00:07


@Kitke Where do you initialise `toolbar`?


This makes me very happy! I had a monkeypatch to achieve this very same thing, which I can now remove.

Was there any discussion about this change?


Hey, Sorry I drafted it, but didn't push it.  I wanted to make a tweak first but didn't get around to it.It can be a minor update.
Try again.  I just created the version
https://github.com/snapjay/ngCart/releases

Regards,
Dan

Date: Fri, 14 Aug 2015 14:27:04 -0700
From: notifications@github.com
To: ngCart@noreply.github.com
CC: dan@snapjay.com
Subject: Re: [ngCart] Update version (ef4133c)

Hi @snapjay

Did you push the 1.0.0 version to npm?

bower install ngcart#1.0.0 --save
bower not-cached    git://github.com/snapjay/ngCart.git#1.0.0
bower resolve       git://github.com/snapjay/ngCart.git#1.0.0
bower ENORESTARGET  No tag found that was able to satisfy 1.0.0

Additional error details:
Available versions: 0.0.3-rc.2, 0.0.3-rc.1, 0.0.2-rc.1.0, 0.0.2-rc.1, 0.0.1-rc.2, 0.0.1-rc.1

—
Reply to this email directly or view it on GitHub.


^ bis


Seems like i successfully forked, cloned and committed an R' File with nothing. Home work done. Dr. Beasley, i will create issue with the link, to the code like originally suggested.


Okay.


It could be. I'm not sure.


After this some tests are failing:

```
Failure → spec/plugins/basicauth/access_spec.lua @ 87
Authentication Plugin Basic Authentication should pass with GET and proxy-authorization
spec/plugins/basicauth/access_spec.lua:91: Expected objects to be equal.
Passed in:
(nil)
Expected:
(string) 'Basic dXNlcm5hbWU6cGFzc3dvcmQ='

Failure → spec/plugins/basicauth/access_spec.lua @ 101
Authentication Plugin Basic Authentication should pass with GET and valid authorization and wrong proxy-authorization
spec/plugins/basicauth/access_spec.lua:105: Expected objects to be equal.
Passed in:
(nil)
Expected:
(string) 'Basic dXNlcm5hbWU6cGFzc3dvcmQ='

Failure → spec/plugins/basicauth/access_spec.lua @ 108
Authentication Plugin Basic Authentication should pass with GET and invalid authorization and valid proxy-authorization
spec/plugins/basicauth/access_spec.lua:112: Expected objects to be equal.
Passed in:
(nil)
Expected:
(string) 'Basic dXNlcm5hbWU6cGFzc3dvcmQ='
```


A good image to test the (valid) 0.00s frame delay case is this: http://www.nullsleep.com/_/tumblr/10-100.gif (from the browser compatibility site referenced in code).


WTF ameerr??????????


@jjb check the PR #3661, and the associated issue :).


Почему ничего не логируется?


@jasonody: If you omit the ‘-m’ flag, it’ll open your default editor and you can easily enter multiline commits ;) The documentation for Backbone and Marionette is somewhere between ok and not great, but they both provide annotated source code, which is probably more helpful. I did a two-part talk about Backbone and Marionette for my company a few weeks ago (pt. 1: https://youtu.be/oASPO02VOrk?t=6m35s, pt. 2: https://youtu.be/FyZXDkFiPRk?t=5m24s) that might be helpful, but the talk has a companion code repo that I can’t share :(. Also, word of warning, those videos are really long (3 hours total). I’ll try and find a good existing tutorial, but it’s a little tricky because Backbone and Marionette are so un-opinionated, pretty much every tutorial has a different way of doing things.

—
Sent from Mailbox

On Thu, Aug 13, 2015 at 10:55 PM, Jason Ody <notifications@github.com>
wrote:

> @roughani Haha, are you trying to tell me that my commit message wasn't descriptive enough? Should we suggest using multiple -m flags when making commits like below?
> `git commit -m "Title..." -m "Description..."`
> @jesserosato Are they any intro to backbone and marionette resources that you can link to in the readme to help backbone first-timers like myself get up and running? I was planning to look over this [three part blog series](http://www.smashingmagazine.com/2013/02/introduction-backbone-marionette/) as it appears at the top of a Google search. The only thing that's holding me back somewhat is that the posts are over two years old.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/code4sac/bikecounter/commit/5fec63e01288a9cbc4a94fdbb1ab6b0ead7711cb#commitcomment-12704453


Mm, thinking better I'd move these headers to the .h too.


Appreciate it! Sorry I commented on the commit instead of filing an issue or something.


It's working now! Thanks a lot. I'm testing it and including this version on the book.


:+1: thanks @peter-murach!


Ok. For what that's worth, looks like I can indeed remove explicit import definitions from jackson-databind; and replace `osgi.export` with `com.fasterxml.jackson.databind.*;version=${project.version}`.
Defaults do not work only because group id != Java package name here (unlike with modules where they match).

And just to reduce likelihood of breakage (I did compare results and they seemed logically equivalent), I'll make the change for 2.7.0-SNAPSHOT


TeamCity WildFly Core :: Pull Request :: Pull request aggregator starter [Build 3](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64876&buildTypeId=WildFlyCore_PullRequest_PullRequestAggregatorStarter) is now running


> - About and Settings windows are now injected into toolbar
> - Mail and GitHub addresses are saved in and read from properites through settings obj
> - Minor refactorings to methods

@Kitke 3 changes => 3 commits => easier to review


new line??


Oh right. :facepalm:


TurnOffWarmupReportForRevDD (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


works!


Follows the original's style;)


Nice attention to detail! I took the liberty to make a minor consistency tweak: cc21ac7


this is a port of some code and i was being lazy


Have I managed to comment on this?


how is it possible for jslat (and others below) to be NaN here???  you just assigned it to be a string


Bug in wiki. It's /streams/ not /clients/ according to source code.


This looks strange. Maybe we should set a variable saying that we're in prediction mode and check it here.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2201 of 2235 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.48%25-yellow.svg)


TurnOffWarmupReportForRevDD (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Awesome! Sorry about that. The book is excellent btw;  very hard to find anything wrong with it!

Date: Fri, 14 Aug 2015 14:38:36 -0700
From: notifications@github.com
To: ngCart@noreply.github.com
CC: dan@snapjay.com
Subject: Re: [ngCart] Update version (ef4133c)

It's working now! Thanks a lot. I'm testing it and including this version on the book.

—
Reply to this email directly or view it on GitHub.


you can use:

```
for i, scenarioRow in enumerate(scenarios):
   ...
```
for having an index `i`


Why ? :)


First attempt at Tor workaround.


missing space


you shouldn't be escaping javascript variables:
```javascript
var lang = JSON.parse(<?php echo json_encode( $lang ) ?>)
```


Why do you call feedback ?
Is it not supposed to be called my the soletta thread infra?


I agree that this watchdog timer and general clock setup stuff shouldn't be in main.  However, since it's board specific it should go into the board specific hardware file.


If you use this URL, you're going to block *all* Tor Exit relays… regardless of whether they allow exiting to the IP:port that your BitcoinXT node is running on. This unfairly punishes people who run Tor Exit relays. (For example, if I ran an Exit relay on my server which only allowed client to exit to port 443, then — even though no Tor clients could access the normal bitcoind ports from my Exit relay — I also would be unable to do so from my server.

We have [a tool which will parse the current exit list for you](https://check.torproject.org/torbulkexitlist), and, given an IP (or IP:port) will generate a list of only the Tor Exit relays which allow clients to exit to that IP (or IP:port). The output format from that tool also happens to be much easier to parse: it's just one Tor Exit relay IP address per line (you just have to discard lines which begin with `#`). The easiest way to use it would be to replace `https://check.torproject.org/exit-addresses` above with `https://check.torproject.org/torbulkexitlist?ip=38.229.72.19&port=443` (filling in whatever is the actual ip[:port] of the Bitcoin node).


this should just init the rtc only not all the clocking on the chip


Ups.

Yes BtModuleList have to go in separate commit I don't want to make now. Ok.


Made changes suggested by @yihui. Credit should go to @zhongxiali for setting up the example I built the new capabilities into.


Why is the watchdog timer being used for the sensor timestamp RTC? @vermar do you have any insight on this?  @quocly do you?


It might be better to default runnable parameter to true


No CSS is best CSS :smile:


Make this a real markdown file. Things like `<h2>`, `<ul>` and `<li>` should be done in markdown and raw HTML should only be used if no equivalent markdown exists.


PlantOperationSchemes (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Hi,
readAllLines is defined to use UTF-8 charset, so its not unsafe - and because of that it is not on the official list of forbidden APIs: <http://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#readAllLines-java.nio.file.Path->
"Read all lines from a file. Bytes from the file are decoded into characters using the UTF-8 charset."


fair enough..


We will soon replace them all anyway. Qt has some mechanisms using which `foreach` and `forever` are not available. `Q_FOREACH` and `Q_FOREVER` should always be available.

PS: Regarding `forever` and `Q_FOREVER` - don't use these. Use `for (;;)` instead.
PPS: We should switch to C++11 anyway, so we could use the C++11 range-based `for`.


you should still fix forbidden APIs to allow APIs not in all JDKs :)


@uschindler still can't add it though, because of https://github.com/policeman-tools/forbidden-apis/issues/63


counter-intuitively, indexing a and b won't result in optimal code, try this:
```
x = bitsk(*a++);
y = bitsk(*b++);
```


I'm curious why this was changed.  It seems weird to have two different functions for opening a port.
prevents you from being able to do.

```
rx.setup(9000, bReusePort);
```
which seems cleaner than

```
if( bReusePort){
  rx.setupWithSocketReuse(9000);
}else{
rx.setup(9000;
}
```


Ok!


It seems kind of arbitrary that this method modifies some attributes of the class but takes great care not to modify others.


The CTaskManager instance is created just before a task is started and destroyed as soon as the task is finished, so I believe this is correct


Please extend test case to show that it works. Thanks!


Pretty sure the parenthesis here are unneeded?


don't comment out lines- just delete them.  That's what git diff is for


How did this pass? It starts with `less`.


This enables you to know the address of a client from a server.


This only reverted the chmod, mismatching the commit msg(?)


No I was testing and forgot to remove it.


Greg,
On my environment (Linux + Chromium), `new Uint8Array(message.buffer);` does not work. `new Uint8Array(message);` works.
I'm not a JS expert but it seems like Uint8Array constructor wants the ArrayBuffer variable directly.


Emails to active an account were send to the user instead of the admins ;)


keep `{` on the same line as the for loop


extra white space


This issue is won't fix, because its already possible: see forbidden issue for complete explanation!


don't need this.  or add a new pragma mark


On a captive portal this enables you to know if the client is requesting the portal or other site (and should be redirected).


make a better test name for this


Not necessary to make a `group` here. I think you can just do:

    generate_contigs_async_task = generate_contigs.si(...)
    generate_contigs_async_task.apply_async()


white space


This could produce a NullPointerException, if findFirst() has nothing found and you want to get() this. Ask isPresent() if yes then return get() otherwise null.


98318570_RemoveRadianceCheckbox (macumber) - Win64-Windows-7-VisualStudio-12: OK (2200 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.32%25-yellow.svg)


Hey the previous import statement you had worked fine, however the newer one doesn't work for me, I'm not sure why you changed it?


this breaks true hardware independence.  Should we have  a public SystemReset function in the board file?


I can't figure out why this test fails:
nosetests pandas/io/tests/test_excel.py:XlwtTests_NoMerge.test_excel_010_hemstring

If you put a print statement right before
https://github.com/flamingbear/pandas/blob/10564-allow-multiindex-excel-writing/pandas/core/format.py#L1694  It's getting called

But the tests are showing:
```
(pandas_dev)savoie@savoie-laptop ~/projects/pandas-savoie (10564-allow-multiindex-excel-writing=)$ nosetests pandas/io/tests/test_excel.py:XlwtTests_NoMerge.test_excel_010_hemstring
F
======================================================================
FAIL: test_excel_010_hemstring (pandas.io.tests.test_excel.XlwtTests_NoMerge)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/savoie/projects/pandas-savoie/pandas/io/tests/test_excel.py", line 1167, in test_excel_010_hemstring
    res = roundtrip(df, use_headers, index=False)
  File "/Users/savoie/projects/pandas-savoie/pandas/util/testing.py", line 1895, in __exit__
    raise AssertionError("{0} not raised.".format(name))
AssertionError: NotImplementedError not raised.

----------------------------------------------------------------------
```


You should return a session.copy() instead of a database.
If you really want a database object, you should do this :
GetSession().db(GetDb())
Where GetSession() returns a session.copy() or initialize a session for the first time.

It's also better to use a custom object to handle the mgo session (or redis connection). This custom object will be global (or not, it depends of your implementation) and will contain your mgo session and the database name.


remove commented code


TeamCity WildFly projects :: Elytron :: Master - Windows [Build 717](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64879&buildTypeId=WildFlyProject_Elytron_MasterWindows) is now running


TeamCity WildFly projects :: Elytron :: Master - Linux [Build 711](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64878&buildTypeId=WildFlyProject_Elytron_MasterLinux) is now running


@jaimedp this way the chart appears and the screenshot is generated correctly

in future will make prs for more exciting changes : )


add hello world


TeamCity WildFly projects :: Elytron :: Master - Linux [Build 711](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64878&buildTypeId=WildFlyProject_Elytron_MasterLinux) outcome was **SUCCESS**
Summary: Tests passed: 579, ignored: 3 Build time: 00:01:57


TeamCity WildFly projects :: Elytron :: Master - Windows [Build 717](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64879&buildTypeId=WildFlyProject_Elytron_MasterWindows) outcome was **SUCCESS**
Summary: Tests passed: 579, ignored: 3 Build time: 00:02:15


Nit: probably should have been a minor bump since a new function was added to the API


Noted. Thanks.


Can confirm, exceptions file is in the packages\urllib3 folder in my Python installation.


this commit is atomic :)


Remove the whitespace around parenthesis ()


This is intriguing to me as I often have mysterious "invalid authenticity token" errors which I can never figure out the cause of.

Was there discussion of this issue anywhere? What does "rememberable is triggered on GET requests" mean? Is this referring to the rememberable period being extended due to `extend_remember_period = true`?

What does "first access" mean? The first GET request after authentication?

Thanks for any info/context!


Done


looks good


Add spaces around operators, it's fine apart from the bitwise OR |


same here


* The thickness of rivers ivaries a bit more
* Fix lighting bug by calc lighting of every chunk


I think I have everything done now on the new commit


Do you even use your own tool? :P m_lastVirus is a boolean, so this is "implicit cast float -> bool"


This one is even more obvious ;) (see comment above)


-commits changes to wikipedia-


Maybe `newmask = (newmask & spacesmask) | (~spacesmask & wlc_mask)` and just combine the comments above.


kkkkk depois melhora

2015-08-14 15:23 GMT-03:00 iagosilvany <notifications@github.com>:

> tá errado
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Gabrielgqa/BlogYii/commit/3b54bf36e8074aebbf84f9502771b09b1653ab4f#commitcomment-12716236>
> .
>


Confirmed fixed.


Thanks. ;)


I only checked the rules I was fixing :P


s/orderedInstance/orderedInstances


Thanks for the heads up. Fixed in 505ba0096d89604ffdc89d7ecddb686c7da87ccf


this is the only occurrence of liquid_layout_id in the whole commit. the migration is missing!


Maybe clearer, "Take the spaces in range and bitrotate them while ignoring spaces outside of the range"


Good change, thanks.


This doesn't seem to me like the most opportune place for this.  Maybe this should happen in a static initializer for the class, or maybe in some initialization code path for Robolectric?


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 328](https://teamcity.labkey.org/viewLog.html?buildId=266544&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0 Build time: 00:02:34
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


l


"Bitmask for the spaces in range, toggled bits define the spaces to shift, untoggled bits are left alone"


Create should only be 1


> Please extend test case to show that it works. Thanks!

Added a test, thanks!

Separately, the tests don't pass for me on master, but I will open a
separate issue for that.


unmounts I would expect to be 2


sAllocationCount = 0;


typo?


Why so many god damn files?


As I wrote before "timeout" has different meaning than it used to have before. Precise timeout is more or less a cornerstone of whole system. Everything depends on that:
1. Moment in time projectile is expected to hit target
2. Moment in time shields' power is evaluated and adjusted (same game frame as in 1st)
3. Future Disarm frame value and whether or not unit should block current target for a disarm projectile
4. Conditional return of doomed and disarmed attributes in OverkillPrevention_Is{Doomed, DisarmExpected}

Arbitrary changes to "timeout" break whole logic I had behind this improvements and may cause unexpected behavior practically. To give a metaphor I see this change as finishing polished wooden plank with chopper.
I'm yet to check the use cases you have given, but I'll do my best to substitute that change with something else (because the change's intent itself is probably reasonable).


cause of npm install bruh


1 create


2 unmounts


Can you please add a .gitignore and keep node_modules from being pushed?


nevermind, I see the `-it` there now.


better to just make it https


I can comment on this from 2 angles. 1 - This is historical. The original sensorhub implementation used that as the time source and I carried that forward per the original instructions. 2 - I suspect (as in have not verified the numbers and architecture on this chip) this is a power management choice. It is likely the WDT is on a different power domain so it can continue to run while rest of the SoC is in deep sleep or uses much less power relative to other times (prehaps it can avoid PLLs among other reasons).


Move declaration of this variable to where it's first used. (Above the branch below)


True, I'll fix it


"culqi_src.php" debe cambiarse a "culqi.php"


@GrahamCampbell :D


No idea how that happened.

https://github.com/SumOfUs/Champaign/pull/106 should sort it out.


This asserts function argument (user input), instead of logic. Move it top of the function, so others immediately see what kind of arguments are invalid.


TurnOffWarmupReportForRevDD (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (749 of 749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.21%25-green.svg)


klhlikhlk


OK, I will, most likely tomorrow I have time to compile _and_ test some vids.


yeah, `././` is equiv to `./` :-)


RoomAirflowNetwork (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1275 of 1275 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.75%25-green.svg)


Because of a Mockbin bug: https://github.com/Mashape/mockbin/issues/36

It works with http://httpbin.org

Once @ahmadnassri fixes the bug, the test will work.


Warnings like 4456 show up in 64bit build. Looks like you've only tested the changes in 32bit.


Btw what do you think of the new artisan generators?


empd (nmerket) - x86_64-MacOS-10.9-clang: OK (1789 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


SAD


Looks pretty nice.


I still don't think I understand why orderedInstances.removeAt(orderedInstances.indexOfValue(wrapper)) doesn't work here but this logic does.  As long as the wrapper is created with the same real object, it should be equivalent, no?  Both this logic and indexOfValue should be invoking the equals() of StrictEqualityNodeWrapper.


Why would there be an unmount here?  There is still a container using the volume..


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 327](https://teamcity.labkey.org/viewLog.html?buildId=266540&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 29, passed: 2 Build time: 00:18:43
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudiesSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 19 more failed tests, see build details
```


^ added!


Sorry, I didn't notice the `-it` in the run command (btw, these would be better to run top inside and drop the `-it`)


PluginZoneInitialization2 (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2183 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.76%25-yellow.svg)


Ok.

Out of curiosity: if something is unlikely to ever be stabilized, should it be deprecated?


can you try to fix libresapi.pro ?


There should be 1 unmount here, though.
Unmount is called on container stop. We don't intend to gate this by the daemon counter.


Actually, I also see warnings in debug 32bit build as well.


Why did you hardcoded `https://api.robinhood.com/accounts/5PY93481/` as `account` value?


I would agree here.  I say 2, because it won't necessarily cause a problem to tell a storage platform to mount again if it's already mounted.  The converse, unmount when it's actually being used, is bad.  I built this logic into my volume driver endpoint a while back since it does currently do 2 for this test.


**WildFly pull requests** [Build 1821](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64877&buildTypeId=WFCorePRAggregator) outcome was **FAILURE** using a merge of d30acac5570e2e2c2e9e41782255f9d3d9a6e220
Summary: Snapshot dependencies failed: 3 Build time: 00:00:02


This is the implementation of indexOfValue, it's using == instead of equals
 for (int i = 0; i < mSize; i++)
            if (mValues[i] == value)
                return i;


Never mind -- I got this resolved without worrying about this.


Done


Moved to _constructor_ which is called in initialization path.


I would predict that these won't be stabilized soon and they'll continue to only be used by the compiler


PlantOperationSchemes (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2210 of 2235 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.88%25-yellow.svg)


Add check for java version and in case of jre 8 and newer set 'MaxMetaspaceSize' instead of 'MaxPermSize'


Maybe make this bold?


**WildFly pull requests** [Build 4](http://brontes.lab.eng.brq.redhat.com/viewLog.html?buildId=64891&buildTypeId=WildFlyCore_PullRequest_PullRequestAggregatorStarter) is now running using a merge of d30acac5570e2e2c2e9e41782255f9d3d9a6e220


Could they be used by the compiler but not exposed at all in `std` or other stable crates? That way `#[unstable]` attrs are not needed at all.


The newly created files don't have apache license file header.  Other wise, looks good.


Certainly! We'd just have to define them in libsyntax or something


So that seems to be the problem here.  If the operation is allowed to go through, the underlying platform will attempt an unmount which is a synchronous process and can lead the Docker daemon to hang waiting for the return.  That is a best case, otherwise it will yank it from the other container running without giving it a chance to clean up.

IMO, if not at the daemon level, then it would be done by tracking at the volume driver/adapter level (not the endpoint).  There can be accounting at the daemon level that accommodates the object model of volumes, and then the lower level would be tracked and maintained within the daemon.  Passing this responsibility onto the volume driver assumes there is a tight level of syncing of metadata about running containers etc, which doesn't seem necessary quite yet.


PluginZoneInitialization2 (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Yeah. Will clean it up in a separate PR.


There's the problem though. You are using `Unmount` to do the operation of `Remove`.
I think we can add a uuid for each mount/unmount call (not the container id) to help the driver handle this.


A few newlines at the end of the files are missing :)


That is absurd... O_o

This code can still be shortened by iterating over orderedInstances and using valueAt() to extract individual values without needing to resolve the key.


want to upper case it before json_encoding?  Just in case some of the magic escaping values done by json_encode might get messed up.   Doesn't feel right to manipulate a value returned by json_encode.


If your tar is GNU's - like Fatdog's - it should support option -a, which makes untaring easier, just `tar -xaf tarfile.ext` for any ext(ension). Then you could:
```
function download() {
	local url="$@"
	local file=${url##*/}
	if [ -f "${file}" -a -f "${file}.downloaded" ] ; then
		echo "--- $file already downloaded"
	else
		${wget} "$url" && tar -xaf "${file}"
		if [ $? -eq 0 ] ; then
			echo -n > ${file}.downloaded # and uncompressed
		else
			rm -f ${file}.downloaded
# TODO: rm -r the folder that untaring created ??
		fi
	fi
}
```


// hello world


Awesome


navigation design : is each pill when clicked shows options for choice of children. so parent >> child.
Children once retrieved cached, so navigation of weave root is not needed again.


SNAPSHOT? :-1:


Steve,
  I now have movement in the view!!  I am missing a lot of things like different square colors when a man or a cart occupies a cart target and I do not have a movement counter, a timer, a game restart, game pause, or a game over notification.  The Shoes toolkit is a lot harder to use than I originally thought, I really hacked together the view, desperately trying to get something to work, but it does!!
  I got massively stuck this morning for 2 to 3 hours trying to figure out why the application was pointing to an older version of my code.  Bruce fixed this in less than 10 minutes.  Basically, I had initialized my grid incorrectly, and then I fixed it by writing the appropriate tests and getting the next tests to pass.  This was all in the game model.  However, when I started running Shoes, it always seemed to be pointing to the back level version of my model.  I could not understand what was going wrong.  It turned out I needed to quit the Shoes application and restart it and then run my game.  Shoes was keeping the prior game version in memory.  I am not experienced enough to think about such things as of yet.  When Bruce explained it to me, it all made sense but I would not have figured it out on my own.
  I am going to check my changes into master and then start new branches were I incrementally refactor the game model.  I will commit after each refactoring, so I have a record of the entire refactoring process.  When we meet tomorrow, we can go over my refactoring and then clean up my view and add new features.  I decided to leave major revision of the view to our meeting time since you can show me so much about Shoes in such a short period of time.
  Of course we will start out with observing the master at work by looking at what you have!!

Eric


A full minute to fail to establish a connection?


Interesting; codecov is new to me.  Maybe we should add a link on the front page (or somewhere) so it's clear how to access the coverage reports.


@starrynte Looks great!


should `super.stop()` come at the beginning or at the end of the child implementation?


you should use resourceful routes here

```
resources :links, only: [:new, :create]
```

you can always call `rake routes` from the command line and see the literal route mapping (urls, path names, etc)


Unicorns!


!! put some screenshots on the README! :)


Why don't you make this `require('gitlog')`? It's very confusing to have to figure out the file structure of your example just to set this up..


Hmm.. not sure what you're referring to.  The tests are just reporting how the functionality is happening today?


Am I doing it right?


I always get the warning even though everything looks right; I write my route in the following manner:
Router.route('/items/:_id', function () {
    var item = Items.findOne({_id: this.params._id});
    this.render('item', {data: item});
  }
});


fix_intel_compile_linux (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1797 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good question. It was probably broken because circleci doesn't put your
project in the GOPATH. Now that it's in the gopath, lets see if they work!

On Fri, Aug 14, 2015 at 6:55 AM Dale-Kurt Murray <notifications@github.com>
wrote:

> Were you able to fix this issue with golint?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wellington/wellington/commit/1124930f5876aef7115b41369b2ec4707a6ad67f#commitcomment-12708774>
> .
>


just copied from them


super stop just sets isStarted=false


91958608DOASEffectOnZoneSizing (wfbuhl) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.79%25-red.svg)


yeah, until the teamcity build is cut :)


Good candidate for Ruby's `case` / `when` block?


Missing semicolon ; fails to compile.


@joshlory Good call. I'll update that soon.


fix_intel_compile_linux (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Done


Meant "logout icon", instead of "logout button".


There should be an example, but I don't really like yours. It logs in the user that you just logged in with the previous statement. Maybe change it to something like the following:

```
$I->amLoggedAs(['email' => 'johndoe@example.com', 'password' => 'password']);
```


This was old decode method stuff? Really unsure why this was even here


and Firefox for Android


Can be downloaded from Drop Box. https://www.dropbox.com/home/Ian?preview=CarpetSuperCentre.accdb


technically, SeaMonkey isn't _officially_ supported (see the "Other Applications" drop-down menu in the top-right corner)


Yea, this seems reasonable. If there are too many I think you probably just have to show the top N values like Trifacta does and maybe have a "load more" button. Basically you just don't want to see a histogram for things that are like unique or almost unique IDs but that's not a datatype we're set up to detect and handle specifically so I think unless we do that, this is the best we've got.


How do we know writing to `cache.chunks` in `pp.crypter()` is safe v.s. `archive.write_checkpoint()` -> `cache.commit()` from `pp.writer()`?

In general I find this patch very scary.  I think individual threads and the "must be threadsafe" parts need to be more strongly encapsulated.  E.g. this feels like a few methods that use a lock have been added to an otherwise unmodified class.


Oops.  Fixed, and fixed "forces" to "force"


Accidentally left in debug prints?


Se me olvidó mencionar:
Autores:
 - Franco Pino (@FrancoPinoC).
 - Feliper Rubilar (@ZeroXcess).


What's the point?


It's hard to tell why this method is here, because it never references `self`.


That's right.


 Ooops ignore me again

 CVector4 temp = CVector4( z.x,  z.y, z.x, w);

BTW Quaternion104(3D) and Mandelbox103 make billions of interesting
hybrids, especially with the hybrid formulas Iterations: and Weight:
parameters.  DE can be reasonably good.

On Fri, Aug 14, 2015 at 12:15 PM, carbuncle grim <mclarekin@gmail.com>
wrote:

> How do I rewrite this with CVector4?
>
> void Quaternion104Iteration(CVector3 &z, CVector3 &c, int &i, double &w,
> const cFractal *fractal)
> {
>
>     CVector3 temp = z;
>     CVector3 tempW = z * 0;
>     CVector3 vectW = z * 0;
>     vectW.x = w;
>     vectW.y = 0.0;
>     vectW.z = 0.0;
>
> Cheers
>
>
>
> On Thu, Aug 13, 2015 at 10:10 AM, carbuncle grim <mclarekin@gmail.com>
> wrote:
>
>> Thank you
>>
>> And educational, I learn best by looking at how others do things.
>>
>>
>>
>> On Thu, Aug 13, 2015 at 6:46 AM, Krzysztof Marczak <
>> notifications@github.com> wrote:
>>
>>> CVector4 is a very good idea!
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/buddhi1980/mandelbulber2/commit/0a61708f78260d45726e6610563cab76a11c594e#commitcomment-12672324>
>>> .
>>>
>>
>>
>


File must be viewed in Microsoft Access presently. But will configure for MySQL


This should just be {}, not a C++ map from int to int sets -- it is, indeed, supposed to be a map from strings to integer lists.


Another stray debug print?


I'll fix that and update the rest of the pr.
Will revert the added SendMsg overload as it'll cause overload issues and the helpers hide the ugliness.


a whole line for "the"?


use implicit continuation w/ parenthesis, not backslashes


Does Cython allow literal dict notation?

    X_L['col_ensure'] = {
        'dependent': col_ensure_dep,
        'independent': col_ensure_ind,
    }


Thinking about this more I guess it's true that this problem is not necessarily only when there are unique IDs, in which case the show-top-N-only solution is the only one that comes to mind.


This seems odd. We should remove condition (if not self.clock_lock) if there is no need to check for self.clock_lock


Please don't mix indentation changes with functional changes: it makes it hard for reviewers to see what the functional change is.


make this add_options


should be in alpha order


I would rename this something like MesosSchedulerDriverBuilder or SchedulerDriverBuilder. We already have a factory that calls this to build the object.


Agree.


Same as above.


That's right.


We still have some more work to do with the schematic in order to proceed
to the pcb stage to then create the appropriate  3d render. Just wait a few
more days :-)

El viernes, 14 de agosto de 2015, Damián Silvani <notifications@github.com>
escribió:

> !! put some screenshots on the README! :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/c64scene-ar/clone64/commit/a49502e3beae34c04fa0b026818aea8085d9bc42#commitcomment-12720772>
> .
>


plotly would be much better, but we can worry about this later


Good point.


With gcc on linux I to have move the '$!<' before $!Libs so main.o is before the libraries :
```
  bin.build('$Objects', '$Bin', '$c:cc $CFlags $!< $!Libs $(c:binout $@)')
```


Commit msg:
Include the option(s) being added as context to the change event so
that we can support the "Add option" feature in react-chosen (which
hooks into the change event)


Not sure, I just changed the name `col_ensure_dep` to `col_ensure_dep_json`.


Fair enough.  (Don't mix indentation change in, though.)


Btw are you ready for me to release a new version yet?


Thanks Gaston, I liked the way you broke this down into smaller components to solve the issue. One naming concern, but other than that, LGTM. Also, I would like to double check that failover between multiple Chronos instances was adequately tested. This is a big enough change that we need to test several failover scenarios before merging.


I'm open to suggestions, I documented them along with the message
https://github.com/Paxxi/xbmc/commit/83de0ce16bfdd9a46661d978e8641d11438e642b#diff-54e705ce58fa59531c34d19c1a53fc0cR116

Another options is to use a struct with cvariants as that will provide clear names but I'm wondering if it will be messy adding structs for every message.


here's some help:

https://scotch.io/bar-talk/expressjs-4-0-new-features-and-upgrading-from-3-0

http://expressjs.com/guide/migrating-4.html#other-changes


RadianceRefactor (rpg777) - i386-Windows-7-VisualStudio-12: OK (2198 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.23%25-yellow.svg)


Some of these charts look really cool this way and like them like this, like AIRPORT in the wildlife strike data. A few columns look weird, like BIRDS_STRUCK in the wildlife strike data. The rightmost dot seems to be outside the chart area. I think it might be that the ones with only a few categories look weird as log scale. Perhaps we shouldn't have log scale if the number of categories is less than the fisheye limit.

I'm also wondering if it makes sense to add a button to toggle between log and linear scale?


You're checking ```@a``` for errors, but the errors are on the ```Comment (@comment)``` created in ```comments#create```.


Ok, this conversation might continue until you read something about permgen and metaspace. In short, MaxPermSize was added because IDEA has a lot of permanent generation objects and permgen will be overflown very soon with default value and I don't want to make plugin-developers to add this options to each build.gradle file. Adding MaxMetaspaceSize is senseless for solving this problem. So please get used to the warning because I'm not going to complicate the plugin for no reason.


verwijder blabla ajb


nice work! :+1:


This is the message you're seeing in the view after a failed save on ```@comment``` due to a short body.


I don't know. I don't know what is being sought with this change. The other changes seem to be aiming for speed via micro-optimizations. Maybe this is supposed to be a micro-optimization as well but if so it is not immediately clear to me how this would help..


If you redirect, you'll lose context of ```@comment```. You should check out ```render```: http://guides.rubyonrails.org/layouts_and_rendering.html#using-render


PathHelper


You'll probably want to change this to something like ```<%= if @comment && @comment.errors.any? %>``` or just ```<%= if @comment.try(:errors) %>```.


THANKS!


```@comment``` should go here now.


Good ! :+1:
It is when you choose the bootloader, i await your confirmation before posting.

Thanks


no problemo my friendo correcto munedo.


Something like ```render: "posts/show"``` should work.


readme


See comments in https://github.com/joomla-projects/webservices/pull/21


Option Explicit

Sub magicsquare()
'May-2010 by Arnaldo Gunzi
'algorithms from: books of math, mathworld.wolfram.com

Dim i As Long, j As Long
Dim tamanho As Long
Dim square() As Long
Dim posX As Long, posY As Long
Dim posXtest As Long, posYtest As Long
Dim inp As Variant
Dim tam2 As Long

Dim m As Long
Dim aux() As String
Dim aux2() As Integer

inp = Plan1.Cells(2, 7)

Application.ScreenUpdating = False

If Not IsNumeric(inp) Then
    MsgBox "Favor inserir um número"
    Exit Sub
Else
    tamanho = inp
End If

If tamanho < 3 Then
    MsgBox "O quadrado mágico deve ter lado >= 3"
    Exit Sub
End If

ReDim square(1 To tamanho, 1 To tamanho)

Plan1.Range("d4:zz50000").Clear

If tamanho Mod 2 = 1 Then
    'Para os magic Squares de tamanho impar
    'método siames

    posX = (tamanho + 1) / 2
    posY = 1

    For i = 1 To tamanho ^ 2
        square(posY, posX) = i

            If posY = 1 Then
                posYtest = tamanho
            Else
                posYtest = posY - 1
            End If

            If posX = 1 Then
                posXtest = tamanho
            Else
                posXtest = posX - 1
            End If

        If square(posYtest, posXtest) = 0 Then
            posY = posYtest
            posX = posXtest
        Else
            posY = posY + 1
        End If
    Next i

ElseIf tamanho Mod 4 = 0 Then
    For i = 1 To tamanho
        For j = 1 To tamanho
            If i Mod 4 = 1 Or i Mod 4 = 0 Then
                If j Mod 4 = 0 Or j Mod 4 = 1 Then
                    square(i, j) = tamanho ^ 2 - (tamanho * (i - 1) + j) + 1
                Else
                    square(i, j) = tamanho * (i - 1) + j
                End If
            Else
                If j Mod 4 = 2 Or j Mod 4 = 3 Then
                    square(i, j) = tamanho ^ 2 - (tamanho * (i - 1) + j) + 1
                Else
                    square(i, j) = tamanho * (i - 1) + j
                End If
            End If
        Next j
    Next i
Else
    'lado 6
    'LUX method
     m = (tamanho - 2) / 4

     ReDim aux(1 To 2 * m + 1, 1 To 2 * m + 1)
     ReDim aux2(1 To 2 * m + 1, 1 To 2 * m + 1)

     For i = 1 To m + 1
        For j = 1 To 2 * m + 1
            aux(i, j) = "L"
        Next j
     Next i

    For j = 1 To 2 * m + 1
        aux(m + 2, j) = "U"
    Next j

     For i = m + 3 To 2 * m + 1
        For j = 1 To 2 * m + 1
            aux(i, j) = "X"
        Next j
     Next i

    aux(m + 1, m + 1) = "U"
    aux(m + 2, m + 1) = "L"

    tam2 = 2 * m + 1
    posX = (tam2 + 1) / 2
    posY = 1

    For i = 1 To tam2 ^ 2
        aux2(posY, posX) = i

        If aux(posY, posX) = "L" Then
            square(2 * (posY - 1) + 1, 2 * (posX - 1) + 2) = 4 * (i - 1) + 1
            square(2 * (posY - 1) + 2, 2 * (posX - 1) + 1) = 4 * (i - 1) + 2
            square(2 * (posY - 1) + 2, 2 * (posX - 1) + 2) = 4 * (i - 1) + 3
            square(2 * (posY - 1) + 1, 2 * (posX - 1) + 1) = 4 * (i - 1) + 4

        ElseIf aux(posY, posX) = "U" Then
            square(2 * (posY - 1) + 1, 2 * (posX - 1) + 1) = 4 * (i - 1) + 1
            square(2 * (posY - 1) + 2, 2 * (posX - 1) + 1) = 4 * (i - 1) + 2
            square(2 * (posY - 1) + 2, 2 * (posX - 1) + 2) = 4 * (i - 1) + 3
            square(2 * (posY - 1) + 1, 2 * (posX - 1) + 2) = 4 * (i - 1) + 4
        ElseIf aux(posY, posX) = "X" Then
            square(2 * (posY - 1) + 1, 2 * (posX - 1) + 1) = 4 * (i - 1) + 1
            square(2 * (posY - 1) + 2, 2 * (posX - 1) + 2) = 4 * (i - 1) + 2
            square(2 * (posY - 1) + 2, 2 * (posX - 1) + 1) = 4 * (i - 1) + 3
            square(2 * (posY - 1) + 1, 2 * (posX - 1) + 2) = 4 * (i - 1) + 4

        End If

            If posY = 1 Then
                posYtest = tam2
            Else
                posYtest = posY - 1
            End If

            If posX = tam2 Then
                posXtest = 1
            Else
                posXtest = posX + 1
            End If

        If aux2(posYtest, posXtest) = 0 Then
            posY = posYtest
            posX = posXtest
        Else
            posY = posY + 1
        End If
    Next i

End If

'Cola o quadrado
Plan1.Activate
Plan1.Range("d4").Resize(tamanho, tamanho) = square

'Faz as bordas
Plan1.Range("d4").Select

    Range(Selection, Selection.End(xlToRight)).Select
    Range(Selection, Selection.End(xlDown)).Select
    Selection.Borders(xlDiagonalDown).LineStyle = xlNone
    Selection.Borders(xlDiagonalUp).LineStyle = xlNone
    With Selection.Borders(xlEdgeLeft)
        .LineStyle = xlContinuous
        .ColorIndex = 0
        .TintAndShade = 0
        .Weight = xlThin
    End With
    With Selection.Borders(xlEdgeTop)
        .LineStyle = xlContinuous
        .ColorIndex = 0
        .TintAndShade = 0
        .Weight = xlThin
    End With
    With Selection.Borders(xlEdgeBottom)
        .LineStyle = xlContinuous
        .ColorIndex = 0
        .TintAndShade = 0
        .Weight = xlThin
    End With
    With Selection.Borders(xlEdgeRight)
        .LineStyle = xlContinuous
        .ColorIndex = 0
        .TintAndShade = 0
        .Weight = xlThin
    End With
    With Selection.Borders(xlInsideVertical)
        .LineStyle = xlContinuous
        .ColorIndex = 0
        .TintAndShade = 0
        .Weight = xlThin
    End With
    With Selection.Borders(xlInsideHorizontal)
        .LineStyle = xlContinuous
        .ColorIndex = 0
        .TintAndShade = 0
        .Weight = xlThin
    End With

        With Selection
        .HorizontalAlignment = xlGeneral
        .VerticalAlignment = xlCenter
        .WrapText = False
        .Orientation = 0
        .AddIndent = False
        .IndentLevel = 0
        .ShrinkToFit = False
        .ReadingOrder = xlContext
        .MergeCells = False
    End With
    With Selection
        .HorizontalAlignment = xlCenter
        .VerticalAlignment = xlCenter
        .WrapText = False
        .Orientation = 0
        .AddIndent = False
        .IndentLevel = 0
        .ShrinkToFit = False
        .ReadingOrder = xlContext
        .MergeCells = False
    End With

End Sub


Geração de quadrados mágicos no Excel


whats the difference between:

`[weak self]`
and
`weak var wself = self`

?


(apologies about the delay!)

Re, known-http2: right, of course, one of those facepalm moments! :)

Not sure if I'm looking at the latest and greatest.. Is https://github.com/kenichi/http-2/commits/upgrade the latest and greatest on your end?


It works.


automatic re-indent error :)


By convention we go by the "parentheses mean you meant that assignment" idiom and associated compiler warning, so to keep from tripping that you'd use `(data = rargs->args[n])`.  *(The build system is about to switch from generated-GNU-make to a dual choice of either generated-CMake or just a CALL-based Rebol-driven full build driver which needs no other make, so investment in the build configurations to get everyone the right warnings and switches has not been made yet...)*


With this signature I qualify it with `Base.` (even though it should not be nessecery because Base show is imported into the module) and eve use Array{CIGAR, 1} in the signature instead of the CIGARString type alias I define. So I'm not sure why this show method is not used.


Oh no,
I just typed this in manually, and forgot to include this._render(). With this._render() line, it fails with
Uncaught TypeError: Cannot read property 'offsetHeight' of null, line 869


This fixed #364


91958608DOASEffectOnZoneSizing (wfbuhl) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.84%25-red.svg)


When this is called, element has not been attached yet. Have no idea why that's happening. But, there is no scroller...


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.434.0cd6da7f3bcbf167169d3c9ffc6e86028310afce](http://build.palaso.org/viewLog.html?buildId=61262&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:25:31


On legacy branch if you don't have google search(Google) installed we get this error:

Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setVisibility(int)' on a null object reference 	at com.android.launcher3.DeviceProfile.layout(DeviceProfile.java:755)

And is there any chance you can add this project to gerrit?


If you want to test this, I can give you temporary access to my private repo.


I disagree with this opinion - the IDE and gradle should not share output directories.
This clear separation allows gradle to not have to consider impacts the IDE may cause on the output gradle creates or having gradle need to work with the output from the IDE, as there is never any promise from the IDE that it is going to build exactly like gradle does. Having any potential of "mismatching", or in more negative terms "contamination", is a large risk that is best to be avoided - there's no telling what sort of unexpected problems may arise out of having their outputs overlap/intermix.
File lock issues between the IDE and gradle, as well as version incompatibilities in generated code are some initial problematic issues that may arise, but that's just a scratch on the surface.


Well, my ROM wasn't booting anyways with my old art. I believe its because
of the r9 merge, I'll try with CM. Thanks for letting me know!
On Aug 14, 2015 5:28 PM, "Jake Weinstein" <notifications@github.com> wrote:

> This builds, but doesn't boot for me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RadonX-ROM/art/commit/73abbf637aa312db9ab9b51849b848be239a1cd8#commitcomment-12719583>
> .
>


> None of the ones you mentioned will work

I know - that's what I just said!

> the others are not even tested by mkcloud yet

I know that too.  That's why I said this commit is an important **step towards** allowing that.  I didn't say this commit allows that right now.  But again, what's the reason to exclude it?  We need to do this work, and I've already done *some* (not all) of it here.  What's the benefit of delaying that further?


> notifyCurrentValue() creates pending change records even though there is no actual change, adding unnecessary memory pressure.

Yes, the "memory pressure" is unfortunate.   This would have been efficient with my original implementation of Invalidating where it just kept a hash of the old values.

> BTW 1st computedProperties()/refreshRendering() call in my change does not effective have a notion of “old values”. They merely are “values when observation starts”. If such difference is not desirable, here are several possible solutions (ones but the 1st one will be breaking changes):

Isn't the obvious solution what I wrote in the previous comment?   Call `refreshRendering(this.constructor.prototype)` rather than `refreshRendering(this)`.


PluginZoneInitialization2 (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2189 of 2233 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.03%25-yellow.svg)


This fixes the issue for me too, thanks


Hi @jalyna,

I'm currently working on exercism as part of Rails Girls Summer of Code. I'm doing some work on lib/app/views/styleguide.erb. Would you have some time to walk me through what's going on here?

Thanks,
Mixolidia


Personally I would use new, modified, deleted and hunk. The "File" suffix is not really giving any information. It's a diff file format, so I would expect that everyone knows it's files we are comparing ;)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.15.0cd6da7f3bcbf167169d3c9ffc6e86028310afce](http://build.palaso.org/viewLog.html?buildId=61261&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:36:07


zero never goes into the cache


In case it's useful, the referenced commit is https://github.com/mrcslws/gorilla-repl/commit/c43e63e97fdf38c394a563da718fe5759cac9eab


PluginZoneInitialization2 (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Now I've gotten curious what the standard actually guarantees (if anything at all) about what you get from argv[] in terms of the parameter content.  There can be internal whitespace, but is a lack of leading or trailing whitespace "guaranteed"?  If you're looking to score a few points on StackOverflow it could make a good [language-lawyer](http://stackoverflow.com/search?tab=votes&q=%5bc%5d%20and%20%5blanguage-lawyer%5d) question...


TeamCity pull requests :: netty [Build 36](https://garage.netty.io/teamcity/viewLog.html?buildId=354&buildTypeId=pulls_netty&guest=1) is now running


:sparkles: :+1:


Do you have a link to where you heard about the modal component coming to RN?


Just checking.  I don't believe this check agrees with the commit's description: "This allows a TrustSet transaction to create a trust line if the _only_ _thing_ being changed is setting the tfSetfAuth flag.".  The way I read this check is that _at_ _least_ the tfSetAuth flag is being set.  Other things may be happening as well in addition to setting the tfSetfAuth flag.  Is that your intent?  Or am I misreading the condition?


> seeing that osc build failed doesn't really help on understanding why osc build failed imho.

That's exactly what it does, because it gives the STDOUT and STDERR from the command.  Like I already said, that's a nice feature of the `sh` module.

> in your case I'd have to grep for directories that contain a build.err and then open build.log in that dir instead.

I don't think so, because again, build.err will contain STDOUT and STDERR from the failed build command.


97204612_MultiSpeedFan (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1805 of 1805 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


nit: Looks like the style fixes for change didn't make it into this commit. Feel free to just drop this commit and keep the fixes you have in the big commit.


not used


Oh wow, I can't believe I let this blatant bug pass by my eye! Good find @smharper!


* It is unknown if or how the 3DS kernel checks against this.


So, if a device is running on Android 5.0.x, is there a way to let profile owner install non-market apk?


На 14.08.2015 05:53 "Valentin Lichev" <lichev78.vl@gmail.com> написа:

> q
> На 14.08.2015 05:12 "Jjordison82" <notifications@github.com> написа:
> >
> > Great
> >
> > —
> > Reply to this email directly or view it on GitHub.
>


trtrtr


Установка:
1. Скачать apk-файл на телефон, подтвердить установку.
или
2. Скачать весь проект, открыть в Android Studio, запустить Run.


You changed other variable names to be `linheap_`... Just be consistent, I guess


What is 0x1000? Define a constant..?


what can i do for using these code?


真好。。


Ruby 2.0 之后默认的源代码文件都是按 UTF-8 来解析的了，这种 Magic Comment 都可以干掉了吧？


Should `type` be an enumeration?


Why did you change these types to int?


g


fix-window-frame-calcs-5095 (nealkruis) - Win64-Windows-7-VisualStudio-12: OK (1795 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


develop (mmatts) - i386-Windows-7-VisualStudio-12: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks for the pull request, but I'm not going to make the starter bot more complicated. The purpose of this is to show the most basic bot to write.


`-msse4.2` should only be passed if we're indeed on x86/x86_64.


Finally got a chance to review this. Amazing work.


The emitter functions that the result of these are passed into take integer arguments. So it means much more casts in the JIT (otherwise), or warnings (as there was before).


Note to self... this can be -msse4.1 (I think) now that we removed Dolphin's hash functions