1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
29:1: I100 Imports statements are in the wrong order. import os should be before import sys
33:1: I101 Imported names are in the wrong order. Should be task_get_option, task_init, task_set_option, write_message
34:29: E126 continuation line over-indented for hanging indent
35:1: I101 Imported names are in the wrong order. Should be CFG_INSPIRE_SITE, CFG_REFEXTRACT_TICKET_QUEUE, CFG_SITE_SECURE_URL, CFG_TMPSHAREDDIR, CFG_VERSION
35:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.legacy.bibsched.bibtask
36:28: E126 continuation line over-indented for hanging indent
43:1: I101 Imported names are in the wrong order. Should be DESCRIPTION, HELP_MESSAGE
44:1: I101 Imported names are in the wrong order. Should be FullTextNotAvailable, check_record_for_refextract, extract_references_from_record
44:1: I100 Imports statements are in the wrong order. from .api should be before from .cli
47:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from .config
47:1: I201 Missing newline before sections or imports.
48:1: I101 Imported names are in the wrong order. Should be split_ids, task_run_core_wrapper
50:1: I100 Imports statements are in the wrong order. from invenio.legacy.docextract.record should be before from invenio.legacy.docextract.utils
52:1: I101 Imported names are in the wrong order. Should be field_get_subfield_values, record_get_field_instances
52:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio.legacy.search_engine
56: D210 No whitespaces allowed surrounding docstring text
56: D400 First line should end with a period (not 's')
56: D205 1 blank line required between summary line and description (found 0)
73: D210 No whitespaces allowed surrounding docstring text
73: D400 First line should end with a period (not 'k')
134: D103 Missing docstring in public function
196: D103 Missing docstring in public function
225: D103 Missing docstring in public function
240: D401 First line should be in imperative mood ('Construct', not 'Constructs')
245:9: E128 continuation line under-indented for visual indent
246:9: E128 continuation line under-indented for visual indent
247:9: E128 continuation line under-indented for visual indent
248:9: E128 continuation line under-indented for visual indent
271:9: E128 continuation line under-indented for visual indent
272:9: E128 continuation line under-indented for visual indent
273:29: E127 continuation line over-indented for visual indent
290:9: E128 continuation line under-indented for visual indent
291:9: E128 continuation line under-indented for visual indent
292:9: E128 continuation line under-indented for visual indent


but STACK_TOP is same as TASK_SIZE - so we don't need USER_KERNEL_GUTTER etc !
Better to move the stack top commit closer to this !


Why did this get added?


White space matters - this added line makes the diff harder to see


求节点的差值最大的那个，你为啥要出入char型


appfactory.utils depends on appfactory.core from the beginning. I didn't change any dependencies. appfactory.common is the independent component not utilities.


Yes, it was temporary, so didn't feel the need for extracting the code that is missing, putting that in a new script and base the new image on official mariadb....


Just fyi if you're going to use `col s12` you could leave out both the `row` and the `col` because `col s12` is just `width: 100%; display: block` which is the default behavior anyway.

However, I kind of like you're putting it in anyway, because it's a familiar structure, and it makes it easy to add mobile-responsiveness later.


Do we print `-h` here?


![screen shot 2015-08-19 at 13 37 18](https://cloud.githubusercontent.com/assets/319055/9356279/919fe468-4677-11e5-93a2-2200ad2b9c79.png)
![screen shot 2015-08-19 at 13 37 29](https://cloud.githubusercontent.com/assets/319055/9356280/91a194a2-4677-11e5-98d9-acee2cd60e3b.png)
![screen shot 2015-08-19 at 13 37 35](https://cloud.githubusercontent.com/assets/319055/9356278/9197ecae-4677-11e5-9b6f-38dda024b82c.png)
![screen shot 2015-08-19 at 13 38 06](https://cloud.githubusercontent.com/assets/319055/9356277/91805530-4677-11e5-8a38-47fa9c95af27.png)


Fixed in 47201371d2805391f4dec3528cdc05f083814165, thanks for spotting it!


Since this is a tutorial, it might have been a better idea to use bootstrap, which is more familiar to the average developer, and also less buggy.


Looked at dns_packet_read_name() and it's quite tied to a DnsPacket, also including DNS data. So in order not to do strange things copying memory from DHCPv6 to DNS, I'll extract the identical label parsing from dns_packet_read_name() into the DHCPv6 code. It looks much better than the thing I glued together in the above code.

Other comments are taken into account already.


This should be `((hot))` too?


sorry missed that, coming right up.


But, using materialize is cool, so... :+1:


excellent fix. thanks :)


Not very well only if the number is complete :-1:
On Aug 19, 2015 1:19 PM, "Max Muth" <notifications@github.com> wrote:

> Nice [image: :+1:] Is this working?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lolobosse/ContactsAutoCompleteTextView/commit/145878da6c0c743476768663ca689d0e492fe2b9#commitcomment-12782628>
> .
>


You've changed the file permissions here :P


OK, that's a big if but why not if you feel it's an issue.


This podspec is still creating conflicts with Pods that require FMDB 2.5 including SpatialDBKit. Could we bump up the FMDB version?


File Permissions?


zhishiceshieryui


##pull 해보기
+pull test입니다.


Inline if in an inline if


I suppose it depends on if you are going to need the todo sometime later.


`fof/Factory/Scaffolding/BaseErector.php` went from `100644 → 100755`


LGTM.


Yeah, but 95% of this fix some important label issues. So I think only 2 lines of this must be revert.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19313/testReport/) for this commit**


This should be `documentSubmit` which has several benefits:
1. Your intention is made clearer
2. This works regardless of how the form is submitted
3. The forms package will validate the form on submit (which is triggered after `click`)
4. The forms package will pass the document as an argument, so you can handle it like so:

```javascript
'documentSubmit': function (e, tmpl, doc) {
  // no need to validate, the document is valid
  Tasks.insert(doc);
  tmpl.form.doc(null);
}
```


why does this need to be tested with 3 threads ? can't you start with 1 threads, and only run SMP tests once you have something that works ? nothing SMP related here.


음 좋은 새로운 파일이네요 ㅠㅠ


i am but either with -l i get limited info in cmd or without i get spamed with a tond of stuff that would normaly be put in logs....i guess this is one of the times would be nice if loging worked. i mean nobodys really using this client now but could at least mark this maybe as a trouble spot because client is worse with it like this than before.


//LIS在O(nlogn)的情况下的解法
#include <iostream>
#include <vector>
using namespace std;

int LIS(vector<int>& num)
{
      int length = num.size();
      vector<int> f;
      vector<int>::iterator iv;
      f.reverse(length);
      for(int i=0;i<length;i++)
      {
             if(f.empty())
                  f.push_back(num[i]);
             else
            {
                  iv = find(f.begin().f.end(),num[i]);//折半查找;
                  if(iv!=f.end())
                        *iv = num[i];
                  else
                        f.push_back(num[i]);
            }
       }
       return f.size();
}

int main()
{
       vector<int>  num;
        int temp;
        while(cin>>temp)
        {
                  num.push_back(temp);
        }
        return LIS(num);
}


@prate3k / is not required in case of links, refer http://www.w3.org/TR/html5/links.html#link-type-stylesheet


I cherry-picked this patch into `master`. Very nice, thank you.


@joshuawatson but why? This way we will drop 1.8 support without any real benefit.


That's a good thought. The question, I guess, is on the cognitive load at this point - I want to keep emphasizing the "vectors" start from 0 until it's drilled in.

There's also my personal experience that makes me feel it *mostly* comes up when slicing, so to introduce it there. This may be very specific to my use cases, however.


This PUT should stay I think


You could(and should) add your environment configurations to .gitignore


Dear @renecannao please make a leap of faith and start deleting code instead of commenting it. When you need it, I will teach you how to find it via `git log` (all versions of the code are stored in the history). Do it for me! :)


Noted!


Ca marche!


The best and the easiest way to show all object's attributes is: "{0}".format(self.__dict__)


I would have written this like so:

```
// 1. use a descriptive name
var docToInsert;
// 2a. What I normally do
docToInsert = tmpl.form.doc();
// 2b. If you want to control which fields are saved to the db
docToInsert = _.pick(tmpl.form.doc(), 'task', 'comments');
// 3. Add date created
// really it would be better to do this in a before hook
docToInsert.createdAt = new Date();
// 4. Insert the doc
Tasks.insert(docToInsert)
```


Interested in this as well.


Scratch my prev comment !
Instead of hard coding 0x2000_0000, lets hard code 0x6000_0000 (i.e. TASK_SIZE), and derive USER_KERNEL_GUTTER from it (as it is used id pgalloc etc)


Yes, I got used to writing it this way during development because I find it easier to maintain :)


The `HackageGit.hs` module is supposed to move into the [hackage-db](http://hackage.haskell.org/package/hackage-db) library soon, and that library defines `Hackage = Map String (Map Version GenericPackageDescription)` already. I'm reluctant to use a different type here, because the various Hackage readers ought to be interchangeable, IMHO.


Great, I've enabled it in 24df856


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.517](http://teamcity.monogame.net/viewLog.html?buildId=9765&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@peti Unfortunately, that means that all GenericPackageDescriptions that are ever accessed are memoized by GHC :/ And GenericPackageDescriptions are not that cheap memory-wise, since they contain descriptions etc


I thought about it, but I figured since we use materialize ourselves, why not "promote" it through our tutorials? if that makes sense ...


You don't want to increase the server library debug level?


just to build it. It is new in pom deps. Now can be uncommented. But now I need some concurrent map...


warum sollen die 4 werte an die methode übergeben werden, wenn man sie eh erst in der methode abfragt?
und wenn man mit "Token eingeben:" anfängt, wäre es wohl sinnvoller, wenn man da zuerst x und y abfragt


strange, i never change file permissions... let me try a commit fixing it


@FernetMenta This break amlcodec because a new buffer is now only requested if a picture is produced, which doesn't happen after a seek.
Any specific reason for this change? Running without it and it looks fine...
Maybe putting the "if (GetTimeSize..." out of the "if" is what you had in mind?


This should be done using handlebars: `class="{{classForValidity 'task'}}"` with a custom helper:

```javascript
'classForValidity': function (name) {
  return Forms.instance().isValid(name);
}
```


well, yes just replace. Not done because I was focused on `RetainedStackManager`


As noted before, if you handle the `documentSubmit` event instead of the `click` event none of the above 3 lines of code are necessary.


I think the log message in this case should be different than the one below. If it's a precaution measure, it means that you're expecting it to be triggered by a bug.


:+1: Awesome!


minor formatting issue here, you need a space after message,


Not sure, I believe I've tried but passing {appversion} didn't gave the result I was hoping for, I think it parses {appversion} later on.


Can this be simplified to:

    $granularity = intval(get_pref('time_granularity', 60));

so the following conditional can be removed? Or does the additional check satisfy some edge cases that the default parameter misses?


Done via commit 884e7e5.  :)


locally not working (bog down at least on Win). Michal (you should remember him from Amsterdam) told me that it could be a problem with this during scala build. But you're right, will be uncommented.


That's what I get for not working on a branch. Fixed in 3d27913


Right, that make sense.


PR pending for fixing it :)


what was wrong with the sequence?
I pushed some changes to master, which includes the change in class.backend.php for autoincrement task_id.

If postgres have problems with it, we must change it back to old max(task_id)+1 ?

Did you deleted tasks outside of flyspray interface,
e.g. sql command,  so max(task_id)+1 != autoincrement value?


@prate3k this is a good idea, we can ask developer to put an html element in their page wherever messaging box is required, and they can use that as $("#elem").mobicomkit


There is probably a range transitive dependency on `angular`.  We should probably come up with a better way to handle the path or lock the dependency.


Hi, This is my first repo on github.


@wpopielarski Do you know how to resolve this one?


I've converted this to print_error_errno(). I'll restructure to add the filename in a bit, however I am inclined to leave debug info in there.


Simon,
sorry that i turned utf8 arrows to `<-` but it has an impact on "organize imports" and the way how packaging is displayed in popup scala docs (I mean scala#1234.collection#110...)


@oxij to be honest I don't fully understand what I did here. Are the `null`s the default values? Any suggestions for changes welcome.


In javascript you need to think about empty values very broadly. We don't want to just write `!val` because `0` might be a valid value, and in fact, quite a few things might be valid or invalid which match this rule, for example: `[]`. What you should probably do is check for exactly what's allowed:

```javascript
// fairly permissive validator, anything goes as long as it isn't a string which exceeds the length:
if (_.isString(val) && val.length > max) return "Too long"
// fairly restrictive validator, only strings, null and undefined are permitted, and only within the specified length
if (!_.isString(val) && !_.isNull(val) && !_.isUndefined(val)) return "Not a valid type, please enter a string";
else if (val && val.length > max) return "Too long";
```


In case someone was able to attack by creating many spam tasks, they could be deleted and then autoincrement value set to the latest legal task_id +1 by the db admin.


This is in a comment, not actual executed code


In the past, I've managed to reduce the memory requirements from `hackage2nix` greatly through appropriate RTS flags (https://github.com/NixOS/cabal2nix/issues/160). That led me to believe that memory consumption is not an urgent topic for `hackage2nix`. Did you have trouble with the amount of RAM it requires at the moment?


It could be triggered by a bug.
If a Session is closed , the backend detaches the connection and either returns it to the pool or destroy it based on condition like this:
```
if ((myds->myconn->reusable==true) && myds->myconn->IsActiveTransaction()==false) {
```
That is not always enough. async_state_machine should be checked all.
In the long term, a function should check all the conditions to determine is a connection is reusable or not


this should be empty at all :)


yes. thanks.


why is category coming up as NONE ? How do I fix this?


Oops. Wrong markup. Bad for SEO.


@hxgdzyuyi 为什么我觉得 state 会一直保持 true 不变, constructor 肯定是第一个执行, 没有别的地方将 state 设置为 false, componentWillReceiveProps 就不会被 invoke  啊.
不过你肯定运行正确了的, 只是我不理解.. 我先 merge 了拉下来看看好了.


Why you reverted this commit?


On 08/19/2015 03:02 PM, wpopielarski wrote:
>
> Simon,
> sorry that i turned utf8 arrows to |<-| but it has an impact on
> "organize imports" and the way how packaging is displayed in popup
> scala docs (I mean scala#1234.collection#110...)
>
Ok, that is indeed a problem. I didn't see any problems on my system and
therefore removed the formatting change in the new PR, but we can add
them back when it continues to be a problem.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wpopielarski/scala-ide/commit/833f94ee5b49db42fe9f4719eb5691eec6ed5889#commitcomment-12783435>.
>


Let me check, but I believe cabal2nix master was using close to 1.5G of memory.


@arielb1

> All operators need to have their rvalue arguments be actual rvalues to avoid stuff like #27054. Indexing isn't special.

By "all operators" I presume you mean "all primitive operators". I agree with you that we want to do this, because it produces the behavior I think user's would (quite reasonably) expect, but I think that in terms of not crashing or printing garbage, it's not necessary. In particular, I think that doing the borrow checking on MIR would fix #27054 in the sense that it would get an error:

```rust
    let x = Box::new(0);
    println!("{}", *x + { drop(x); let _ = Box::new(main); 0 });
```

would get translated to MIR like:

```
BB0:
    var_x = box 0 // what
    drop(var_x);
    tmp = *var_x + 0 // <-- borrow check error here, var_x is moved
```

Score one for checking the lowered representation.


Согласен. Не досмотрел


Should be `{{#with error 'task'}} <span class="error"> {{message}} </span> {{/with}}` that way we don't have an empty error span when there's no error.


Use Typelib.debug { }


@hxgdzyuyi 还有关于 bower 还是 npm 安装 co, 我这边试了用 bower, webpack 就认不到了, 可以编译通过, 但是运行会报错, 找不到 co 的函数.. 要不你试一下吧?


This throws an error for me, because you haven't defined a template named `TasksList`


:+1: for sorting  this on your first commit.


Can you please solve this commit and update the pull request. I'm facing issues with the signed driver in the apc...


Why?
Does this piece of code broke anything ?


@scalar77 @HmHmmHm :P


В самом начале это казалось более быстрым решением. Про find_by не подумал.
в голове сидели find_by_name find_by_title и т.д. А с генерацией методов думал дольше буду возиться


Definitely should go in the docs.


souring -> sourcing


Нет оправдания :)


Should use CONFIG_DIR constant


#cool


```
else if(playerCoords.x === speakerCoords.x) {
    if(playerCoords.x > speakerCoords.x) {
      rotation = 90;
    } else {
      rotation = 270;
    }
  }
```

This doesn't make sense.
**playerCoords.x** can't be bigger as **speakerCoords.x**, because they are equal (first if)


I thought that the eye transforms were computed based on the head position.  I guess I don't know what a viewer is.

It will be very good to have code to be able to test whether startup is complete for the display, because that will be a good time to recompute any transforms that don't change.

Even better would be a notification when any of the display parameters change, so we can redo calculations without having to go back and check.  If the display values are static once read, then it is okay to have isStartupComplete().  If they can change, maybe we need an epoch() call that is updated every time a write method is used on the structure.  Otherwise, we either need to cache all the values and check or else redo the calculations each frame.

Right now, I'm redoing the calculations each frame.  Lets see if that is too slow.  If not, then just having startup complete is good.

Lets do merge!


Думал, что возможно понадобиться в будущем, поэтому оставил.


ermmm, hack xD


Why passing ID and Algorithm every time, while they should already be available after class instantiation?


Cool! ES6 code already. Had to look up what that did.


Wait, we might be able to GC parts of the map as we go, since we don't do any lookups in the map. I'll try this.


После копипаста, так и осталось. Тут уже не думал, просто торопился.


asd


Angles are now off by 1? why


Should we log the path of the Object that doesn't exist?


Да так и нужно было сделать. Просто изначально зацепился за метод мисинг из-за скорости.


check current AI entity, that way you'll only need two calls instead of three


Could we call this just mainAttachmentSHA256 to be consistent with other setters?


versable..

Works for me on Win and Linux.

What platform has trouble?  Details?
Dave


Oops! This is leftover code. should be `Template.TasksForm.helpers` instead.


update grenade arrow


Traditionally you want to use `if (doc._id)` to test whether this document is a new task or not.


@arielb1

> It's more like that the binder in MethodCallee never binds anything than anything specific to overloaded deref.

pre-existing, but true. Also, I don't think "coverge" is a word.


You know what, nevermind. We solved that.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.517](http://teamcity.monogame.net/viewLog.html?buildId=9765&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3 (3 new), passed: 538, ignored: 6 Build time: 00:23:39
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.ContentPipeline.MeshBuilderTests.BasicMeshBuilderTest: <no details avaliable>

MonoGameTests.exe: MonoGame.Tests.ContentPipeline.MeshBuilderTests.ThrowsInvalidOperationExceptionMeshBuilderTest: <no details avaliable>

MonoGameTests.exe: MonoGame.Tests.ContentPipeline.MeshBuilderTests.TwoMaterialsMeshBuilderTest: <no details avaliable>

```


I'm wondering why this line is now in comment. I believe a scope.$apply() should happen, like it does on ng-click.


Thanks, I will fix it :)


Add assert()


There's no `include_empty` in the locust master. Maybe it got added earlier in our branch? Anyway, the previous default behavior when asking for test stats was to generate a ValueError - I favor this way.


Sounds like a generic getter like this. How about something like `getSummaryFor` ?


Thanks. This looks nice but when I compile it there is no glossaries at all :\


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.518](http://teamcity.monogame.net/viewLog.html?buildId=9769&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Good


Split split split split


@mathuin , you wanted this change reverted, right ?


die 4 Werte sind vorerst Standartwerte, ich habe die hier eingefügt, weil diese keine Eigenschaft von der Playerklasse ist, jedoch macht es wohl Sinn die in der Methode zu Initialisieren, statt in dem Methodenkopf,...


replace with Collections.emptyMap


Special chars need to be escaped in selectors (`.n-util-hide\@screen`)


ahem https://github.com/eris-ltd/eris-cli/commit/8b7fb25f218d15c7f79239455a1b36627b38d081


Also the corner code is gone.


Finally, a hip file syncing program I can recommend to all the young people I know! ;-)


Set to 16, this number seems too big.


Yep, they are. I suggest keeping both the `if` and the default `null`s.

That's assuming `dmenu` is not needed on darwin for some reason. Should
`passmenu` work on darwin (in theory)?


Дублирование HasPassword с AccountController.


@nhunzaker yes, they are available in rc2: d2ddcb3f2ac8846ba5f40b2bf2d25bb8e752f85a


new map


Add assert().


Ubuntu 14.04

    /usr/bin/c++   -DLINUX_CRASHRPT -DOCPN_HAVE_X11 -DTIXML_USE_STL -DUSE_GARMINHOST -DUSE_GLU_TESS -DUSE_S57 -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D__WXGTK__ -DocpnUSE_GL -pthread -O3 -DNDEBUG -isystem /usr/lib/x86_64-linux-gnu/wx/include/gtk2-unicode-3.0-unofficial -isystem /usr/include/wx-3.0-unofficial -I/home/versable/Documents/Misc/OpenCPN/include -I/home/versable/Documents/Misc/OpenCPN/src -I/home/versable/Documents/Misc/OpenCPN/src/nmea0183 -I/home/versable/Documents/Misc/OpenCPN/src/mygdal -I/home/versable/Documents/Misc/OpenCPN/src/garmin/jeeps -I/home/versable/Documents/Misc/OpenCPN/src/texcmp/lz4 -I/home/versable/Documents/Misc/OpenCPN/src/texcmp/squish    -Wall -Wno-unused -fexceptions -rdynamic  -g -fno-strict-aliasing  -DPREFIX=\"/usr/local\" -o CMakeFiles/opencpn.dir/src/OCPN_Sound.cpp.o -c /home/versable/Documents/Misc/OpenCPN/src/OCPN_Sound.cpp
    /home/versable/Documents/Misc/OpenCPN/src/OCPN_Sound.cpp: In constructor ‘OCPN_Sound::OCPN_Sound()’:
    /home/versable/Documents/Misc/OpenCPN/src/OCPN_Sound.cpp:383:22: error: cannot call constructor ‘OCPN_Sound::wxSound’ directly [-fpermissive]
        wxSound::wxSound();
                         ^
    /home/versable/Documents/Misc/OpenCPN/src/OCPN_Sound.cpp:383:22: error:   for a function-style cast, remove the redundant ‘::wxSound’ [-fpermissive]


It is because in OSX, if you have installed Latex via MacTex, the command makeglossaries is not available. The glossary must be generated via the TexShop GUI (I don't know if there is another way to do this without TexShop).


I think either we shouldn't be using `ul` or we should be using `li`


It should be noted that this problem doesn't occur in the original IfcOpenShell as it doesn't have the --use-names feature.


Agreed!


You could use:

```
tmpl.form.doc(this)
```


this variable is a globla variable, your method could works even with a local variable


Running hashkat without the exact same number of regions gives me an error due to line 281 in analyzer_main.cpp:

' DEBUG_CHECK(R.regions.size() == N_BIN_REGIONS, "Should match!");'


requesting a buffer should happen a few lines above.

````
  // keep hw buffered demux above 1 second
  if (GetTimeSize() < target_timesize && m_speed == DVD_PLAYSPEED_NORMAL)
    return VC_BUFFER;
````

> Maybe putting the "if (GetTimeSize..." out of the

yes, this sounds reasonable too


TeamCity pull requests :: netty [Build 61](https://garage.netty.io/teamcity/viewLog.html?buildId=523&buildTypeId=pulls_netty&guest=1) is now running


Hi, just saw your new test.

If you use +2, there is no need to retest at 15+0.05,
you could test at 60+0.05 directly.


done


@Zomis Are you referring to only the `from` property, or to both the `chatId` and the `from` properties?


This commit is being reviewed as a part of review issue #53.


@vangheem One more idea for static layout support. On top of your static-layout work, but as an alternative to making customized tiles persistent with special tile data managers (no changes to plone.tiles master would be required).

We'd like to use inline rich text editors, but Mosaic Editor very much assumpts that rich text tiles are stored within layout.

What if we'd let Mosaic Editor always save the layout into content after all, but would merge it into configured static layout in fly (either in layout behavior's adapter or in its view render). That would allow us to remain using tranient tiles (updated configuration would be saved into content; and also use rich text tiles).

What merge should do, it should read the static layout at first. Remove all "removable" and "movable" classes from there. Find all tiles from both static layout and content layout and then copy tile URLs with matching id from content layout to static layout (this would fix transient tiles; persistent tiles have been working alread). Rich text tiles don't have any ID yet, but for beginning the merge could just replace Rich text tile contents in order from content layout to static layout. This should be pretty safe, because no new rich text tiles can be inserted in static layout mode. Of course, when new text tiles are added into static layout, rich text tiles would position wrongly. But this could be fixed by generating some kind of id also for text tiles.

Maybe you have already thought about that. So far, I thought the merge always go other way around (merging static layout changes into content layout), and that why it was considered too messy.


OK, stand corrected


I'm not sure I understand what the significance of the 'original' fields that are being added in this commit is, nor the change of the on_delete triggers to CASCADE.. Should those changes be in a separate commit?


TeamCity pull requests :: netty [Build 61](https://garage.netty.io/teamcity/viewLog.html?buildId=523&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:19


Related commit: https://github.com/Ensembl/ensembl-webcode/commit/cdc35275eb99b53f0a80acd05c5f3c0f161edb22


i see 3 duplicates. this code can be extracted to new method


yes 10x, I've do this only to test if it works without storage.


PasswordFor! Иначе пароль показывается при вводе. Надо тестировать свои изменения! :)


It's a subtle point, but the cast to `void` has significance: it indicates that the return value of `swap` does not participate in equality preservation, only the operands do. We could theoretically *require* `swap`'s return type to be `void`, but there seems to be no benefit to doing so. If some user out there has written a `swap` overload that returns something useful they are free to use it with the standard library without incurring undefined behavior if that overload doesn't always return equal values when passed equal operands.


`0.4` should be written without a leading zero as `.4`


Merge rule `.primary-toggle + label` with rule on line 1


Merge rule `.primary-toggle + label:before` with rule on line 1


Merge rule `.primary-toggle + label:after` with rule on line 1


new map. do not modify OpenTsdbTagProcessor output


> Any specific reason for this change?

without this change it would request a buffer on every cycle and drain dvdplayer's msg queue.


Np, thanks for looking out

On Wed, Aug 19, 2015 at 9:28 AM, ludamad <notifications@github.com> wrote:

> OK, stand corrected
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hashkat/hashkat/commit/192d5b8abc39320f02ba71b6792c4e5c374aa728#commitcomment-12784063>
> .
>


Like in the backend, you must never retrieve all the resources if you don't need them.
First because it will overload the server and kill it :angel:, and also because there is pagination that limits the number of responses.
Then you should use the `getById()` method instead of `query()`. Or continue to use `query`, but with a parameter to filter the query.


That makes sense and it results in cleaner code :+1:


Seen this issue before. Created a ticket for it now at https://phabricator.wikimedia.org/T109581

Do note that the code in this class has related OCP violations, though indirectly: it assumes all entities have labels, descriptions, aliases and statements, and won't hold into account additional types of content from new entity types.

For this class at least, it makes sense to solve those two issues at the same time since they have the same root cause.


There was a little bug with corners which was why a fix was needed in the first place. For corners I had it fixed in my version after changing the above, I thought I pushed the changes, I'll commit them now.


I am referring to only the `from` property. The `chatId` is required (and chatId = 1 represents the main lobby).


这个好像之前已经翻译过？从 TPM 链接过来？要不直接删掉算了？


Why the hate for `var`?


@kyon0304 可以~


Yes that's true, I've added those requirements later on in the document under the ** Required files ** section. It's however a good idea to reference that part of the document in the basic steps to compile the setup.


@kyon0304 不是多次调用 ，是可以链式调用。 then 返回的也是一个 promise 吧


Add comments to remove confusion.


I really like to have it all in one complete document, ofcourse it can be removed if you like.


@mathuin , i don't see any difference after moving it back to the original place, so as you said, i'm moving it back :+1:


Will do.


Returning zero from Decode does nothing useful. You will just be called again (without message queue being serviced or any state changing) immediately after. It just causes busy spinning with nothing changing.


建议把这个翻译直接覆盖掉 Security Hardware Resources，我后面直接把 TPM 这个删除掉。


Why version was increased?


I agree it's not the most strict html, it's the way materialize suggest it: http://materializecss.com/collections.html


Aonde se ler **doque** o correto é **do que**


The latest version is 3.4. Stick to using it


Also move version to properties


move version to properties


# one
## two
### three
regular


How so?


It will be @nikosdion. It was favourite of his when he did the FOF 2 updates to J3 :)


seriously, what is this monkey-coded patch? do you understand anything about how alpha-beta works? are we supposed to validate this?


@svk31 I'm not departing from Flux, I think my refactoring is even more inline with React philosophy: TransactionConfirm is pure function now - it just renders the state of TransactionConfirmStore.
Why does it need to listen to changes in accountstore and settingstore? Are there anything that can change while during a time confirmation is shown?


本文主要包含基于硬件的安全增强方面的信息


Yuuuuupppppppppp... For "absolutely friggin' hate the guts of it" values of "favourite" :p


We don't use any loops, so IFS wouldn't be used here.


Ah. That's what I meant. The previous was to generate that error, which Is what I preserved. This change seems fine, though.


ScheduledReporter already has start method with given interval. Moving these settings (period, unit) to OpenTsdbReporter is misleading and setting default value to 5 seconds may lead to problems in future.


基本没有问题，除了建议直接用 TPM 覆盖掉链接过来的那个文件。。。


@popcornmix look into the code. it does wait for 25ms when returning zero and no pic is produced.


@eherot curious what the deal with this is; would be good for me to grok this as well, in case of future troubles.


Maybe we can use RGBParamDescriptor?


26:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. import warnings should be before import sqlalchemy
23:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.


24:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.utils.text should be before from invenio_upgrader.api
25:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. import warnings should be before import sqlalchemy
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
25:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from sqlalchemy.exc
26:1: I201 Missing newline before sections or imports.
31: D103 Missing docstring in public function


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
20:1: F403 'from sqlalchemy import *' used; unable to detect undefined names
21:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
21:1: I201 Missing newline before sections or imports.
22:1: I201 Missing newline before sections or imports.
27: D103 Missing docstring in public function
31: D103 Missing docstring in public function
42: D103 Missing docstring in public function


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
20:1: F403 'from sqlalchemy import *' used; unable to detect undefined names
21:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
21:1: I201 Missing newline before sections or imports.
22:1: I201 Missing newline before sections or imports.
27: D103 Missing docstring in public function
31: D103 Missing docstring in public function
39: D103 Missing docstring in public function


27:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
32:5: E266 too many leading '#' for block comment
87:5: E303 too many blank lines (2)


`forDiff` is used only once, and function is called only once with each of possible boolean value.
It seems as a fishy hack to me, that is adding more complexity to understand, what is going on.
I suggest to make `statement` a parameter instead of adding `forDiff`.
Thus `ifTrueThenStatement` can be removed to,
so `generateForExtensionField` calls would look like this:
```kotlin
fun Descriptors.FieldDescriptor.getStatement(): String =
                "result.add(${containingType.typeName().replace(".", "")}Kind.${toEnumName()})"

fields.forEach { field -> generateForField(field, p, field.getStatement()) }
extFields.forEach { field -> generateForExtensionField(field, p, field.getStatement()) }
// ------
val statement = "return false"
fields.forEach { field -> generateForField(field, p, statement) }
extFields.forEach { field -> generateForExtensionField(field, p, statement) }
```

Even better approach would be to make generation object-oriented way, because both of these
functions have a similar structure.

It would probably work with something like (not working code, just a draft of idea):
```kotlin
abstract class FieldGenerator(field: Descriptors.FieldDescriptor, p: Printer) {
   val statement = field.getStatement()

   abstract fun Field.getStatement(): String

   fun generate() {
       val name = // ...

       if (field.isRepeated) {
          generateForRepeated(name)
       }
       // other cases...
   }

   abstract fun generateForRepeated(name: String)
}

open class FieldGeneratorImpl(/* params */) : FieldGenerator(/* params */) {
   override fun getStatement(): String = "return false"
}

class FieldGeneratorForDiff() : FieldGeneratorImpl {
    override fun getStatement(): String =  "result.add(${containingType.typeName().replace(".", "")}Kind.${toEnumName()})"
}
```


Bad usage of Macros!


Does it work? I don't see test for OpenTsdbReporter with per metric tags


versable...
OK, got it.  Editor auto complete nailed me, or an extraneous ctrl-v....

Thanks
Dave


I think this is misleading, in that it is bolder than `button-tertiary`.

Since it's only for one item, just make it a specific case:

```scss
  .new-request__make-new-requests {
    @include button-base;
    background-color: $color_orange;
    // etc…
   }
```


This one slipped through: can you please change this to `add_dependencies(canopen_ros_chain ${catkin_EXPORTED_TARGETS})`


Hello
dist was deleted but `package.json` was not updated.

```js
"main": "dist/index.js",
```

It broken `fly`

```bash
module.js:338
    throw err;
          ^
Error: Cannot find module 'fly-util'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/home/user/.nvm/versions/node/v0.12.7/lib/node_modules/fly/dist/reporter/index.js:17:16)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
```


@AlexTNolan no worries, I'll delete the folder


哥哥，没有英文版？这个很难参考校订哈。

根据之前的约定，建议先搞定 en 版本的 Markdown，拷入 en/ 然后，复制到 zh/ 添加一个记录，之后再修改，这样会有参考比较好对照一些 ^_^


Fix merge conflict markers


TeamCity OSS :: Kubernetes Mesos :: 4 - E2E Tests (docker/mesos) [Build 122](https://teamcity.mesosphere.io/viewLog.html?buildId=37750&buildTypeId=Oss_KubernetesMesos_e2eTests&guest=1) is now running


oh. not as good then. maybe just go with `-`


\begin{pedantic}
There are two changes in this commit -- in addition the lazy loading, it also uses find\_packages instead of hard-coding 'zipline' as the only package. This should either be split into a separate commit or mentioned in the message for this commit.
\end{pedantic}


Nice :+1:


This one is even recommended by the official documentation:
http://docs.qgis.org/testing/en/docs/pyqgis_developer_cookbook/vector.html#writing-vector-layers


1966db8ddcc2634841a939d33c9de42d6763dbb5 makes this setting local to individual tests.


这个 Review 过了吗？


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.519](http://teamcity.monogame.net/viewLog.html?buildId=9773&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


OK, 3c1dfe011018490102ec49d5b429a2fde1579b35 adds granular testing of the callback method that is used to implement the custom back stack reordering.


"Updated web-incremental so failure is recoverable"


Remove this and make it an inline function.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.518](http://teamcity.monogame.net/viewLog.html?buildId=9769&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 538, ignored: 6 Build time: 00:23:42
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.ContentPipeline.MeshBuilderTests.BasicMeshBuilderTest: <no details avaliable>

MonoGameTests.exe: MonoGame.Tests.ContentPipeline.MeshBuilderTests.ThrowsInvalidOperationExceptionMeshBuilderTest: <no details avaliable>

MonoGameTests.exe: MonoGame.Tests.ContentPipeline.MeshBuilderTests.TwoMaterialsMeshBuilderTest: <no details avaliable>

```


That should be 302px


Okay, so the Decode function should only return 0 if it has slept?
Otherwise we get stuck in this loop with 100% cpu:
https://github.com/xbmc/xbmc/blob/master/xbmc/cores/dvdplayer/DVDPlayerVideo.cpp#L589


Thanks to @igor0511 for reporting


Removed extra key


Should be inside the remark tag


"result" must be a class constant or local value, passed explicitly.
Using string names globally by convention is error prone.

This reasoning can be applicable to other string values in this class as well.


Somehow I cannot understand what is the intention here but its either wrong or confusing ... setting domain to 'undefined' and then logging exactly what?


Yes, that's fine. But the ruleRegistry will only be created if a StorageService is added. This causes that the RuleRegistry can not live without a storageService. In my opinion it would be better to track the StorageService in the RuleRegistry itself or add setter/unsetter methods for it. Additionally in the setter there should be a synchronization of the inMemory data and the storage-provided Data.


accepted


Here is an idea that just occurred to me. Since the only constants that are handled in the fast path are atoms and integers, why not make sure that we don't pass other types of constants to the instructions:

is_ge Lbl S1=x S2=x => i_is_ge_spec Lbl S1 S2
is_ge Lbl S1=x S2=ia => i_is_ge_spec Lbl S1 S2
is_ge Lbl S1=ia S2=x => i_is_ge_spec Lbl S1 S2

Not sure that it is worthwhile, but other constants could be handled like this:

is_ge Lbl S1=x S2=c => i_is_ge_compound Lbl S1 S2
is_ge Lbl S1=c S2=x => i_is_ge_compound Lbl S1 S2

Just an idea. Not tested.


Thanks! Will fix ASAP.


I believe that unnamed boolean arguments are evil.


ah sorry


okay


remove comment


Was there nothing new?


Can you upload the data base for this application
thank you


Why not just use `return when`? Also body can be expression.


Does Ember-CLI have variables for these paths? Maybe on `this` in this context, or in the options?


alaveteli.org uses blue for links. I think we should here, too, as it's purple is a bit in your face IMO

![screen shot 2015-08-19 at 14 49 52](https://cloud.githubusercontent.com/assets/282788/9357986/c525449a-4681-11e5-832d-14f53d78fdf8.png)


that's the case here. if it has no new pic, it sleeps. in case it does not time out and has a new pic, it returns VC_PICTURE. it would only return zero if it times out and has slept for 25ms.

````
  if (m_old_pictcnt == m_cur_pictcnt)
    m_ready_event.WaitMSec(25);

  int rtn = 0;
  if (m_old_pictcnt != m_cur_pictcnt)
  {
    m_old_pictcnt++;
    rtn = VC_PICTURE;
````


And, after realizing that to match the style of ShapedRecipe I needed to finalize the ItemStack, I cleverly finalized the wrong one.


why the extra empty line?


I'll fix it.


TeamCity OSS :: Kubernetes Mesos :: 4 - E2E Tests (docker/mesos) [Build 122](https://teamcity.mesosphere.io/viewLog.html?buildId=37750&buildTypeId=Oss_KubernetesMesos_e2eTests&guest=1) outcome was **UNKNOWN**
Summary: Canceled (Exit code 137 (new)) Build time: 00:10:21


This should be exp!


:+1:  :+1:


Test cases should be independent. This test case depends on ${user} variable. So, 'Test case 2' depends on 'Test case 1', where ${user} is defined.


Yeah. I was going for minimum viable diff, but in retrospect I prefer going direct from cert_pem -> cert.


+1 for uniformity with alaveteli.org but this change makes the banner clash with the hero image IMO. I think the solution is to find a new hero.

![screen shot 2015-08-19 at 14 47 47](https://cloud.githubusercontent.com/assets/282788/9358039/0ec18d02-4682-11e5-8035-3b31408ad764.png)


Althought -> However,
less -> fewer


is -> was
far -> long
consist -> consists


which would allow to use its features in Ruby -> which would allow full use of its features in Ruby


snip edit


TeamCity pull requests :: netty [Build 62](https://garage.netty.io/teamcity/viewLog.html?buildId=524&buildTypeId=pulls_netty&guest=1) is now running


an easy-to-use interface
the most commonly used features


Does it really matter?


thank you!


as easily as possible in a Rubyesque way.


remove comment


First line of ./john output(sometimes it contains version word, sometimes it doesn't)
Core 1.8.0:
John the Ripper password cracker, version 1.8.0
Current jumbo git:
John the Ripper 1.8.0.6-jumbo-1-705-gef50440 OMP [linux-gnu 64-bit AVX2-ac]
Jumbo 1.8.0.6 latest release:
John the Ripper password cracker, version 1.8.0.6-jumbo-1-bleeding [linux-gnu 64-bit AVX2-autoconf]

Which logic would you want ?
1) append first line starting by John The Ripper
2) Find first occurence of digit that ends with space or end of line following John The Ripper word
3) Suggestion


TeamCity pull requests :: netty [Build 62](https://garage.netty.io/teamcity/viewLog.html?buildId=524&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:47


Let's be consistent and just call it GnuplotRB from now on, no parentheses (since this is what you did in the title).


This changes the low memory killer settings to:
3072,5119,8191,10240,12288,14335
Which is less than ideal for this phone (not aggressive enough). I think this line should be removed because it's for phones with < 512 MB RAM and Android 4.4. The tuna/gnex needs aggressive low memory settings because it's running 5.1.1 with only 1 GB RAM!


.Spot For me


@Zhinsheng правки нужно производить в ветке test а не в ветке master, т.к. они там все всеравно перетрутся....


Два раза
```ruby
if alert
```


怎么这么吝啬空格阿，所有 # 后面加一个额外的空格吧。。。

sed -i -e "s/\(^#*\)/\1 /g" *.md


bezkomentarza


ничего внутри не показывает


Use backticks around `GnuplotRB::Plot` (or put it in a `tt` block, either way).


StudenViewModel


I think this depends on the outcome of https://github.com/mysociety/alavetelitheme/commit/8c024fa3896e72f9879dee7f9db42bd57c032f1f#commitcomment-12784792 – we don't really make that much use of orange on alaveteli.org though?


cartezian -> Cartesian


commit accepted


Closes #858 .


These dashes should be emdashes, which I think is —


Is this path likely correct?


Does this work properly when there isn't any heading in the entire file, though? I think in that case we still call `(hide-subtree)' when not at a heading, and the bug might reappear.


are these keywords? If so, put them in backticks/tt.


从这里开始全部斜掉了。。。 `_init` 标记为命令吧。


to avoid adding to keywords different suffixes and prefixes, you can call keyword by resource file name:
e.g. UserUILib.robot contains keyword: 'Login' - to call this keyword in testcase you could type: UserUILib.Login


*cries*


much better!


Six starting vectors seem a lot, 2 should be enough for this particular problem. Also, this fixes a bug with 1 x 1 matrices.


@divineforest  Yes i understand but **1.8 no longer available** right? so that my suggestion.


remove comment


_connect 类似，其他地方类似。。。


Do u know how to enable this by default? Means any sys entry or something?


Good point. If there are cases where we only have an EntityDiff and not the entities from which the diff was created, and we want to make a summary based on the diff, then that could also be done via this code. And as long as it is structured sanely, we can trivially expose that functionality by making a method public.

Do we have such places though? I understand that there are ones that already have an EntityDiff object, though as addshore pointed out, you can make better summaries if you have the entities themselves. (Or at least one of them and the diff.)


Well if you comment them off they wont work... all they do is just overlap but that is not the best imo and the angles are off by one still.


the repository README
the examples folder


Closes #859 .


TeamCity pull requests :: netty [Build 63](https://garage.netty.io/teamcity/viewLog.html?buildId=525&buildTypeId=pulls_netty&guest=1) is now running


e.g., to a PNG file


Shader properties and pass properties?


Here is a multiplot example


assignment 2 of R programming


Remove maxlength


multiplot lowercase


this fixes https://github.com/FieldDB/FieldDB/issues/2039


a Fit module


it is better to separate mvc app repository


The first library was HealthWise.


JPEG/PNG/SVG


:yum:


ASCII
GIF
`Animation` (backticks)


Тип нужен text


没有明白你的意思。。。。


Typo in SciRuby


Backticks around Dataframe, Vector


Копипасть аккуратно
откуда взялася imageable?


`daru`, not 'daru', or just make it Daru


good refactory!heyman


индекс тоже нужно будет поправить


Thanks Achraf !


It's the path I've been told to use :)


the following forms


saw approval from gordonguthrie
at https://github.com/basho/riak_ql/commit/6efbe9f042d5bb51c23e11d9273febc15bd17492


merging basho/riak_ql/int_keyword = 6efbe9f0 into borshop-integration-9-int_keyword


basho/riak_ql/int_keyword = 6efbe9f0 merged ok, testing candidate = 7e5351e6


commas after e.g.. e.g., `sin(x)`


Redefine to account for the consumed seed.


`BUTTON_IRQ` 可以作为代码注释起来。


In the HTML you can still write `<div class="n-util-hide@screen">`


Trying to get this last thing working. Something is wrong with Category, I keep getting the error: TypeError: Incompatible collection type: None is not list-like
when I remove it from element it happens with create_assessment too. The traceback is here: https://github.com/amarie004/ndb/commit/1f1475b799737d49d3e1a497211e19056a1c130e <https://github.com/amarie004/ndb/commit/1f1475b799737d49d3e1a497211e19056a1c130e>

Meeting at noon :(

> On Aug 18, 2015, at 6:09 PM, brianthelion <notifications@github.com> wrote:
>
> Naming example: owner_id = Column(Integer, ForeignKey('users.id'))
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/amarie004/ndb/commit/1f1475b799737d49d3e1a497211e19056a1c130e#commitcomment-12771954>.
>


I think only one set of backticks here.


backticks around each of these


*Compiling SSDT-GA-Z77X-D3H.dsl*:

./GA-Z77X.sh: line 262: iasl: command not found

mv: rename /tmp/SSDT-GA-Z77X-D3H.aml to
/Users/zzz/Gigabyte-GA-Z77X-DSDT-Patch/EFI/CLOVER/ACPI/patched/SSDT.aml: No
such file or directory

*SSDT compilation complete.* Exiting...

zzzs-iMac:Gigabyte-GA-Z77X-DSDT-Patch zzz$

2015-08-19 4:36 GMT-07:00 Alex James <notifications@github.com>:

> Hi,
>
> Try these steps. Make sure that you clone the repo, don't just download
> the ZIP, it won't include the external repos properly I'm afraid.
>
> git clone https://github.com/theracermaster/Gigabyte-GA-Z77X-DSDT-Patch
> cd Gigabyte-GA-Z77X-DSDT-Patch
>
> Now you can run the script properly and it should work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/theracermaster/Gigabyte-GA-Z77X-DSDT-Patch/commit/788781a32f7840ae0a9330ab58e724a2cd2daf3f#commitcomment-12781957>
> .
>


(_init)   --->  `_init`


program assignment 2


@indigofeather You saved us! And I think we are back to business.


s/inpput/input/g


I think it's better you keep the unicode and double-escape the backslashes here.


This is extremely well done. Good work. I'm particularly impressed by the writing — really good job with the English.


Can you create PR for this?


Same here.


And here too.


Not really.
But for example, after all repo movement old links from my notification emails are leading to absolutely irrelevent issues =).


maybe create PR is a good idea?


I guess there's no need to do `module = name` here, you already did outside the `if`.


done!


@aarontam I believe this is wrong, yes. I had forgotten about it. It should definitely reference _karma. Good catch.


Yes! The port used to do SSH I will make it clearer :)


Поправил


hmmm, might get confusing if people search the source for `n-util-hide@screen` - I vote for consistency throughout


I think that clobbers this, though: https://github.com/react-bootstrap/react-bootstrap/blob/v0.25.0-alpha.1/webpack/base.config.js#L38, and I think we want to preserve the docs source maps for the prod docs.


input report_key() --> input_report_key()


(localdb)\v11.0 instead of .\SQLEXPRESS


How so? They should redirect properly unless they were pointing at the original `nodejs/node`...

The changelog still contains tons of `iojs/io.js` and `nodejs/io.js` links and those are the links in the PRs, so I don't see cause to change them.


Yes, that was an alternative I hesitated for. The drawback is that with double backslashes, the string looks different as in a real file (visually). It's a design decision to make.


Why do you think it's not the best to overlap the wall code?

Oh, I just realized, walls used to create a 45 degree angle, now they create a 180 angle. No point trying to make them off by one pixel. (I did that because there's a little glitch that I never bothered to fix with my angle merging code. In some cases, when two angles overlapped by 0 degree it didn't merge them.) I'll remove that.


this makes it so the templates can be overridden in the lexicon browser, or use the defaults for https://github.com/FieldDB/FieldDB/issues/2032


I would remove the `-color-pale` variables and do them inline. I don't think people will want to customise it _that_ much?

```scss
$notice-color: $color_green;

#notice {
  background-color: desaturate(lighten($notice-color, 30%),10%);
  border-color: $notice-color;
}
```


I've no strong preference :)


Нужно ли здесь назначение переменной, если все равно в конце возвращается эта функция. Можно сразу return


yes grepping is an issue, but it does look nice in the HTML.


Thanx. No time to test. Sleep deprivation kicking in... :sleeping: :zzz:


As far as I can see, newPyrArray() doesn't set its own size, so removing this line would leave array->size at 0 (if it indeed is initialized to 0?)


remove


同样地，所有代码用 \` \`  标记。


Поправлено


Translation bundle version updated to ```dev-master``` as fabric is using the same version.


The problem with this is that the strings will be functionally different objects in python2, so will behave differently.


IDE пишет что в соответствии с кодстайлом нужно закрывать назначения переменных точкой с запятой - ;


TeamCity OSS :: Kubernetes Mesos :: 4 - E2E Tests (docker/mesos) [Build 123](https://teamcity.mesosphere.io/viewLog.html?buildId=37764&buildTypeId=Oss_KubernetesMesos_e2eTests&guest=1) is now running


Not sure if this was actually required.


Set up for Selenium Webdriver demo session.


Лучше разделять конкатенацию пробелами между знаками + для большей читаемости


Version 0.16.1 brings an error [Issue#181](https://github.com/discourse/discourse_docker/issues/181). Changing back to 0.16.0 can solve the problem.


处理输出事件？


I honestly don't think that `ao` will ever register in full-text search. Don't think that's enough characters for the engine to pick it up.

Funny enough I can't get `Riddler` to match when I have `fuzzy_search` on `article.content`. It's strange because it's definitely not one of the common dictionary words that should be filtered out.


It should be Test Setup and Test Teardown.


Может лучше вешать на элемент стиль, и его описать в css ?


Deal with `sol_vector_append()` failing?


Обязательно в конце каждого файла должна быть пустая строка


It is precondition, so should be moved to Test Setup


fixes size report


assert(id > 0);


得 --> 的


I'm not totally sure, but I think you can use the [completing](https://github.com/clojure/clojure/blob/bdc752a7fefff5e63e0847836ae5e6d95f971c37/src/clj/clojure/core.clj#L6564) function here.


Thanks for the CMake cleanup. I'll give it a try asap :)


e**x**isting key?


With the unicode_literals import, the strings are always unicode, whether on Python 2 or 3.


Problem is that if the decoder is starved and do not produce pics anymore, we are in an endless loop...

I'll test with the "if (GetSize" out of the pic "if"


It will be redundant action for tests, that test any ather functionality than showing error messages


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 12](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=101&buildTypeId=XbimEssentials_XbimEssentials) is now running


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/50


Let's use uppercase name for the module: `Regression`


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 12](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=101&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:00:44


certo


I get the intent, but the error message was pretty unhelpful.  Do you mean "must include a path component" rather than "must include a url prefix" ?  Or better yet, show the before vs after rather than just the suggested STATIC_URL.  I apparently was misconfigured, and assumed all along I had the '/static/' path in my static_url, so I was going nuts trying to figure out what was wrong with my configuration.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.519](http://teamcity.monogame.net/viewLog.html?buildId=9773&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:30:58


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.520](http://teamcity.monogame.net/viewLog.html?buildId=9777&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Students/Huruiala V. Vasile Alexandru/eclipse/assignment4/assignment4.1/src/javasmmr/zoosome/models/animals/Siege.java

Hah! Fair enough :))


If you extract this anonymous function into a private one, (because it is the same as in `handle-events-and-apply-results-to-atom`, just that has the 1-arity built in) and reuse it then that would DRY up the implementation.


Easily:
>Proposing a security@ team:

>@rvagg
@bnoordhuis
@indutny
@jasnell
@cjihrig
@shigeki
@mhdawson
—
Reply to this email directly or [view it on GitHub](https://github.com/nodejs/node/issues/48#issuecomment-110674884).

Click the link =).￼


Resetting db-atom after each step is by design (we want to run all reactions after each event processed). Maybe the function name should better communicate that.

look here for alternative which is coallescing:
https://github.com/darwin/re-frame/blob/22e91e1dde7f176d8cedc9093605ebdbed02de15/src/re_frame/frame.cljs#L155


On my todo for today


> unless they were pointing at the original nodejs/node

Yes, they were. And back then you weren't sure that the repos would be moved like that.


Awesome :+1:


As far as I have understood, passing a function as input to another function is something we don't want to do in general. A loop using `@eval` should do the trick. What I suggest is more or less:
```javascript
for (normest, op, opc) in ([:norm1est,  :A_mul_B!, :Ac_mul_B!], [:norm1est,  :A_ldiv_B!, :Ac_mul_B!],)
    @eval begin
        function ($normest){T}(A::SparseMatrixCSC{T}, t::Integer = min(2,maximum(size(A))); F = copy(A))
            # things...
            ($op)(Y,F,X)
            # other things
            ($opc)(Y,F,X)
            # other things
        end
    end
end
```
Then you'll be able to use `normestinv(A,t,factorize(A))` in `cond` and `norm1est(A,t)` where you need it.


:dolls:


I don't have anything against this class. It's a nifty helper class.


Missed that, you're right.


I like this


I kinda think we should reserve the green for action items (e.g. buttons, success status, notices).

e.g. on this page its really clear what is an action:

![screen shot 2015-08-19 at 15 14 54](https://cloud.githubusercontent.com/assets/282788/9358651/10d98fec-4685-11e5-9944-95cb7023a62c.png)

But here we mix the green in to the general page so it detracts from the action buttons:

<img alt="the cost of boring - a freedom of information request to ministry of silly walks - alaveteli 20150819" src="https://cloud.githubusercontent.com/assets/282788/9358733/821adbf2-4685-11e5-9dfa-9e5e2a8e3498.png">


Major blunder. Set low = 0 after every iteration for each algorithm!


Swell job


简化 --> 用于


Nice! That should let me access all I need.


You are reviewing code which has been changed.

Let's talk about the latest version:
https://github.com/darwin/re-frame/blob/22e91e1dde7f176d8cedc9093605ebdbed02de15/src/re_frame/frame.cljs#L155


Why not return 'transaction' here directly?


wow


得 --> 的


Where did you get this file from? https://github.com/ryanherlihy/semantria-test/blob/0583863f5938064135a5ffaf6bb7c118aabe2f2f/node_modules/leveldown/node_modules/prebuild/node_modules/ghreleases/foo.js


@k-italy testing


Yeah, probably. They just came in when I regenerated the files for the new `bodies_missing` column, which means they should have been run before (with my previous timestamp changes, and the cascade from a long time ago whenever that happened).


Whoops, thanks.


bitfield --> 位域


:gem: tight


Uh, why? Doesn't really correspond with the name of this function.


Mark, this patch relies on mbstring being enabled as a PHP extension. Our install did not have mbstring enabled, so PHPExcel was bombing out when dealing with dates. Might want to update the composer file to indicate that mbstring is a required extension of PHPExcel now.  https://github.com/PHPOffice/PHPExcel/blob/1.8/composer.json


In training, we use library/mongo. Are the two identical?


Thanks for the quick response! My concern is not with the db-atom resets, I understand those are needed. I was just really apparent that the `reducing-fn`'s in this function and the one below share great similarity, and should be refactored out. You could add the one-arity version in that refactored function, or just define the two arity one, and use `completing` here instead.


和、等 --> 和


@kvz Would it be possible to even move this into a separate repo?


We should be binding `$this` rather than `$this->container`


Hello lucasart,

while implementing logic for branch "qsearch_bonus" I accidentially found the Phänomenon, that these two "lunatic" lines in the sources of August 3rd led to success like:

SF_qs_immer1_inv_c   : 3060  2431 (+652,=1639,-140), 60.5 %  <---- this ist this "lunatic" version
    SF-dev_15081513           : 1214 (+324,=816,- 74), 60.3 %    <---- this is the compile of unchanged Sources
    SF20150817_ori_pb         : 1217 (+328,=823,- 66), 60.8 %   <---- this ist the dev-Stockfish x64-modern

In this case (OK, the best 2000-games-test) a 60% superiority!
Also other test where rather succesfull (around 53% -55% at shorter times)!

I don't understand why this patch worked such good. Maybe a bug at another place?
These lines look, as if the must desturb. OK I agree!

I just started a discussion about it at CSS-Forum (http://forum.computerschach.de/cgi-bin/mwf/topic_show.pl?tid=8504), where you can find further results too.

And you can download that Executable & sources at:
http://quapsel.bplaced.net/extra/SF_MinGW/Stockfish_20150803-irrerPatch.zip
(basing on sources of Aug 3rd)

Yes, I think I know somewhat about alpha-beta (Ok, surely not too much)
and that is why I was irritated as you are now.
But I saw those results!
And each test, I made, showed me more of them.

Yes, I would like to see this test, just to learn whether there still is a phenomenon which must get understood. Or there is despite the test-results nothing.

Greetings
Quapsel
:-)


I'll fix it.


I think we should refactor this condition to var `isPrevWindowIsIFrame` for clarity


haha


add


I think
```
$(DESTDIR)/usr/share/xsessions/notion.desktop
```
should be
```
$(DESTDIR)$(PREFIX)/share/xsessions/notion.desktop
```
In case the user is installing with another PREFIX than /usr


This allocates the window buffer only once and then reuses it to get *slices* from original vector. It also uses the in-place median algorithm.


`AsHTTP` is for HTTP URL form, as in `https://` and `ssh://`. `AsSSH` is for `git@github.com:repo/owner`...


It is commited lol.


Hi Ryan,
I'll be busy these next few weeks and I won't be able to improve our work flow further.
The "line 38" error is most likely happening, because the active view is not a section/elevation view.

I got the "line 71" error too in one or two views in particular. I didn't manage find the root cause. I suspect it's because one of the MIPs fails to create a closed solid. I use the solids to calculate the tag's placement points, which is inefficient but necessary because material tags are very sensitive about their placement. I'll need to revise this whole section of the graph once I get a chance.

I'm sorry I could not be of more help right now : /


The status color still seems to be a bit different from the theme in vim-airline.
![2015-08-19-222535_1600x900_scrot](https://cloud.githubusercontent.com/assets/4687791/9358947/3da20fea-46c1-11e5-9a60-249ff9231407.png)


Going deeper I'm not sure I understand what's going on here. Can you describe why we need this event?


Why we need `get()` here?


Thanks :+1: Improved in commit ec0ea91b911de2cbca393706b37a242759022a97


根据 Review 修订好以后，直接用这个翻译去覆盖掉 zh/dev_portals/Security/Security_Hardware_Resources/Security_Hardware_Resources.md，TPM.md 这个不用翻译就可以，之后我来删掉。


Also possible, although usually you'll want to `make deploy` from the project you're working on?


\r-


TeamCity pull requests :: netty [Build 63](https://garage.netty.io/teamcity/viewLog.html?buildId=525&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4740, ignored: 21 Build time: 00:29:48


King of Nerd Mountain!


Я б оставил правило:
https://github.com/petkaantonov/bluebird/wiki/Optimization-killers


* Plot location markers on google map

* Handle the case when k is small which makes bar really big


I agree it would be minimally more comfortable but I would like to keep the public tusd source code separated from the master.tus.io instance deployment code.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 33](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=99&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 02:59:40


I don't get it `ssh://` is not HTTP (!!!) URL form in any meaningful way :D But whatever...


no worries @dimven.  Whenever you can get to it.  thx.


Good:
- User as object
- separate libs for UI and API
Bad:
- non-independent test cases


table_dist() and code after fork().


Will remove test code from the files and push the updated files later on today !


Спасибо!

Я еще не во всех методах интерфейса разобрался.

Карен

Отправлено из Yahoo Почты на Android

От:"brus-fabrika" <notifications@github.com>
Дата:вт, авг 18, 2015 в 21:21
Тема:Re: [homework] Ready for REVIEW (450958b)

да, здесь всё хорошо, молодец.
Просто к сведению:
можно было добавить все элементы в список через метод addAll, как-то так:

fabrika.addAll(Arrays.asList(f0, f1, f2, ..., f10));

—
Reply to this email directly or view it on GitHub.￼


Sure, will do!


Hm, that's true. I don't currently have access to a Windows machine, but when I do I'll try that out if you haven't yet.


Hi,

this PR #14 fix this issue.

Best regards.


Gah. I thought I published some crap file in 1.3.0 but it turned out to be in version 1.2.0 so this patch was completely unecessary. Sorry about that.


@blalger Good point, thanks: "prefix" is the internal terminology, "path component" is obviously the right phrase to use in the error message; I'll change that.

I'll think about the before vs after values in the error message, but my feeling is that if people are confused about how their own settings are configured then it's hard for an error message to convince them otherwise. And, generally speaking, the more text you put in the message the less clear people find it.


I don't know about ya'll but I don't have any doc source maps when I run the doc server. I can change this here, but why would we only have source maps when its minimized? looking at an unminified webpack bundle isn't really helpful no?


a simple redirect($url, $message) should do the trick :-)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 361](https://teamcity.labkey.org/viewLog.html?buildId=267330&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:25
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Could you also add a new appcast? It seems that it has changed location, but it's still available:
```ruby
appcast 'https://rink.hockeyapp.net/api/2/apps/0de2e5766e01cde1f6c0fd5b9862c730'
        :sha256 => 'b9cc1bd81957cb06bafa72d95393239817467cb5864349a14c5ed7bb934bb6e2'
```


<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

表头:

	姓名
	电话
	电话

	Bill Gates
	555 77 854
	555 77 855

垂直的表头:

	姓名
	Bill Gates

	电话
	555 77 854

	电话
	555 77 855


Unfortunaly you can not use the same way for getting the column definition like for mysql. Here is an result of `show create table` in cubdir 9.3

```
1'th query[ 0,14 second , count of total rows : 1 ]
--------------------------------------------------
SHOW CREATE TABLE animal;
--------------------------------------------------
animal	CREATE TABLE [animal] ([id] INTEGER AUTO_INCREMENT (1, 1) NOT NULL, [type] CHARACTER VARYING(255) NOT NULL,  CONSTRAINT [pk_animal_id] PRIMARY KEY  ([id])) COLLATE utf8_bin
```

You can find how i tried to implement this feature https://github.com/unclead/yii2/blob/8152-extend-migration-class/framework/db/cubrid/QueryBuilder.php#L64 but you can try to write more beautifull regex


lololl


Can be an extension property


now, for all module names (and tests names) we use lowercase name.
Change to uppercase name for all modules?


Here's an update on why Gratipay isn't working for you: https://medium.com/gratipay-blog/hard-at-work-135000d1c237


Wow, thanks :)


Torching = Tourcoing (damn autocorrect)


:+1: added in commit 1e52a738c2d32d15a4cf7e0b0d44407c2792ce11


i can't choose a game mode, firefox-greasemonkey.


Don't worry about it, I have a patch ready waiting for me to decide what to do documentation wise. Note however that the current implementation of `apply` is tightly coupled with `variant` (mostly for `constexpr` reasons), while it should have a generic implementation to support _variant-like types_ based on `variant_size`, `variant_element` and `get`. If and when that happens, you might need to add specializations for those (just the base cases for `variant_size` and `variant_element`, you'd get the rest for free). This is analogous to the requirements of [`std::experimental::apply`](http://en.cppreference.com/w/cpp/experimental/apply) for `std::tuple`.

I'd appreciate issues being reported, even without a proposed resolution, as that would give me a chance to consider the situation. This goes for warnings too which you seem to have a few, I recently did some work on that area but I might not have got to them all (specially for some buggy MSVC ones that I decided to not workaround).


Should be NULL, since NO is a boolean expression, here we want a null pointer. Xcode 6.4 warns about this:

> Initialization of pointer of type 'sqlite3_stmt *' (aka 'struct sqlite3_stmt *') to null from a constant boolean expression


I've seen both even in this PR. If lower case is consistent then let's use it. However there are some places there upper case is used


:+1: improved in commit ae1203fb21532682ce82563d39df40284680abe6


Used once, can be inlined


LGTM.


*Installing kexts to EFI partition*:

cp: /Users/zzz/Gigabyte-GA-Z77X-DSDT-Patch/kexts/FakeSMC.kext: No such file
or directory

- Atheros AR8161 [1969:1091] detected, installing
AtherosE2200Ethernet.kext...

cp: /Users/zzz/Gigabyte-GA-Z77X-DSDT-Patch/kexts/AtherosE2200Ethernet.kext: No
such file or directory

Marvell SATA controller detected, installing AHCI_3rdParty_SATA.kext...

cp: /Users/zzz/Gigabyte-GA-Z77X-DSDT-Patch/kexts/AHCI_3rdParty_SATA.kext: No
such file or directory

PS/2 hardware present, installing VoodooPS2Controller...

cp: /Users/zzz/Gigabyte-GA-Z77X-DSDT-Patch/kexts/VoodooPS2Controller.kext: No
such file or directory

cp: org.rehabman.voodoo.driver.Daemon.plist: No such file or directory

cp: VoodooPS2Controller: No such file or directory

repo no folder "kexts"

2015-08-19 7:02 GMT-07:00 Sreda Sreda <sreda201378@gmail.com>:

> *Compiling SSDT-GA-Z77X-D3H.dsl*:
>
> ./GA-Z77X.sh: line 262: iasl: command not found
>
> mv: rename /tmp/SSDT-GA-Z77X-D3H.aml to
> /Users/zzz/Gigabyte-GA-Z77X-DSDT-Patch/EFI/CLOVER/ACPI/patched/SSDT.aml: No
> such file or directory
>
>
> *SSDT compilation complete.* Exiting...
>
> zzzs-iMac:Gigabyte-GA-Z77X-DSDT-Patch zzz$
>
>
>
> 2015-08-19 4:36 GMT-07:00 Alex James <notifications@github.com>:
>
>> Hi,
>>
>> Try these steps. Make sure that you clone the repo, don't just download
>> the ZIP, it won't include the external repos properly I'm afraid.
>>
>> git clone https://github.com/theracermaster/Gigabyte-GA-Z77X-DSDT-Patch
>> cd Gigabyte-GA-Z77X-DSDT-Patch
>>
>> Now you can run the script properly and it should work.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/theracermaster/Gigabyte-GA-Z77X-DSDT-Patch/commit/788781a32f7840ae0a9330ab58e724a2cd2daf3f#commitcomment-12781957>
>> .
>>
>
>


This commit contains a number of changes from the rubocop rules in the styleguides repo:

* The `Blocks` Cop has been renamed to `BlockDelimiters`.
* The `EmptyLinesAroundBody` Cop has been renamed to `EmptyLines`.
* The `UnneededPercentX` Cop has been renamed to `CommandLiteral`.
* The "other-metrics.yml" has been added which disables four metric Cops not present in styleguides version.

Should these changes be backported to the styleguides repo?


Hm...didn't see this change before working on mine. I guess to just get the total number of matches a new option would be the best route. `--totalcount`, maybe?


Seems like property


Why ? This is a very bad idea. This forbids using stable version, is incompatible with minimum-stability stable (because of that) and means it is impossible to make releases of this bundle in a safe way, because unbound constraints are not safe: https://getcomposer.org/doc/faqs/why-are-unbound-version-constraints-a-bad-idea.md

Please revert this and fix fabric instead


@rboulton: Should this change be backported to the rubocop rules in the styleguides repo?


#firstcommit !!!!!


#läuft !!!!


Thanks @mattbk

Today was the first time I learned that I was no longer able to even get donations.  That seems like a major communications break down from gratipay.    It seemed quite counterproductive to advertise that I was getting $6.26 a week when in fact I have not been getting anything for quite some time.

Brad


@boffbowsh: Should this change be backported to the rubocop rules in the styleguides repo?


The grapple code looks almost identical to this: http://webcache.googleusercontent.com/search?q=cache:J6uxAf4BrWwJ:zzero.fatal.ru/files/sdk/barnaclegrapple.cpp+&cd=5&hl=en&ct=clnk&gl=us (created way back in 2003)

BTW: Working on this right now ;)


Wow! I can't believe they suggest that...

*Joshua Ohlman*
*Lead Developer*
*Useful IO*
*(361) 772-4201*
*joshua@useful.io* <joshua@useful.io>

On Wed, Aug 19, 2015 at 8:33 AM, Vlad Balan <notifications@github.com>
wrote:

> I agree it's not the most strict html, it's the way materialize suggest
> it: http://materializecss.com/collections.html
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/usefulio/forms-tutorial/commit/3eab0421fe82f48c8d1f7e2079f8b25c22400a96#commitcomment-12784215>
> .
>


Looks good


Thanks, John! Such a shame for me to make so many mistakes. I'll fix them
and rebase this pull request tomorrow (I'm in train now).

Regards,
Ivan

2015-08-19 17:03 GMT+03:00 John Woods <notifications@github.com>:

> This is extremely well done. Good work. I'm particularly impressed by the
> writing — really good job with the English.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dilcom/sciruby.com/commit/29931da7ee0fae8f57bf183fbfb334ae8d86d228#commitcomment-12785117>
> .
>


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.521](http://teamcity.monogame.net/viewLog.html?buildId=9781&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.520](http://teamcity.monogame.net/viewLog.html?buildId=9777&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:25:19


Why do you make function and extension, but use explicit "this"?
Explicit parameter "p" or implicit this would be shorter.


Not quite sure how I'd write a unit test for this, @mbadams5?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 34](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=102&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


I'd prefer to avoid maps as AST nodes -- kind of violate the spirit of an AST being an ordered representation of syntax. Isn't it sufficient ot construct the map in the instance object? How about `export list` with
```
type export = export' phrase
and export' = {name : string; func : var}
```


Done https://github.com/tus/infra-tusd


you have more indentation spaces pls remove it


this makes it so that templates are overridable if apps use the same structure as reccomended in the angular style guide

and fixes https://github.com/FieldDB/FieldDB/issues/2032


The renamed cops are because they have actually been updated in Rubocop, the names were out of date in the `styleguides` repo. The `other-metrics.yml` was added because the now-disabled cops are too opinionated, and that sort of coding style issue is better discussed between humans in a pull request.

I don't think these should be backported, I think the configs should be removed from `styleguides`, with a pointer here instead.


Nit: I've tried to consistently use `x` for variables.


I don't think this is correct; it should return `one(x)`


Thanks, that seems to work


Do you press ESC?


Bikeshedding time :) : So far, the syntax avoids tagless S-expr nodes. E.g., you have to say (param ...) explicitly. It might be more consistent with that to just have singleton (export "f" x), and allow multiple of those.

Also, you probably want to use `var` instead of `INT` here, so that it gets a precise source position (below you get that of the whole remaining export list).


I'll fix it.


Remove this functionality of sampling and storing the XIDs and instead go for measuring time for every lookup.


I believe, you can add printlnIfWithComparisonIndent overload:
```kotlin
fun Printer.printlnIfWithComparisonIndent(...) {
    pushIndent()
    printlnIfWithComparisonIndent()
    popIndent()
}
```


Nit: s/str/name/ ?


Thanks :heart:


Whatever, I will change the naming so that it makes sense. Dunno really why I named a regular URL as HTTP URL...


Add `O_TRUNC`, in case the file already exists?


Oh you already fixed it.


Seems like property `javaName`


Looks good so far. As a suggestion, you might want to try to use Entity Framework with SqlLite. This way you don't have to manually handle all the events.


I'm pretty sure this was causing the bug resolved in this commit


Is this correct? I think that `n=0` should return `one(x)`...


Yeah, this was the email that went out, which wasn't nearly detailed enough, and didn't have a subject line that made it seem important: https://github.com/gratipay/gratipay.com/pull/3510.


Not at all! This is far fewer mistakes than I highlight in posts that are submitted to sciruby.com. =)


I like changes like that. Great!


Referring to https://github.com/rackt/react-router/issues/1543.


You might also consider submitting this against @willroden's [_marathon-client_](https://github.com/willroden/marathon-client) fork.


Nice to see this function being reused :)


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Guy
When it send to the input, which delimiter it will use?


I like the idea of the test; yet, I think it is better to use non-integer number, precisely to check issues related with the precision.


Seems like property `enumName`


Sorry bro, thanks.


I'll fix it.


That looks great to me...


I had no idea git could keep track of that too


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 34](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=102&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:08:36


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 35](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=103&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Should be passing in the query here, right?

I just realized that the for() loop to mix in the properties is probably useless now.    Instead of accessing `this.source` and `this.processQueryResult`, can't you just access `args.source` and `args.processQueryResult`?


@manstis it looks like a `hack` in order to have popup screens with modal footer properly working. can you confirm @cristianonicolai?


Comma can be used in when:
```kotlin
field.options.getExtension(DebugExtOptionsProtoBuf.stringIdInTable),
field.options.getExtension(DebugExtOptionsProtoBuf.nameIdInTable),
field.options.getExtension(DebugExtOptionsProtoBuf.fqNameIdInTable) ->
```


94006714-MultipleTowers (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1795 of 1795 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm getting not found error when click any app or theme:

Not Found

The requested URL /admincp/apps/undefined&open=https://store.phpfox.us/product/841/pay-to-be-featured was not found on this server.


Glad I could help.


Comma can be used in when:
field.options.getExtension(DebugExtOptionsProtoBuf.stringIdInTable),
field.options.getExtension(DebugExtOptionsProtoBuf.nameIdInTable) ->


You don't need this change anymore, you can just say

```
this.data = args.processQueryResult(args.source.filter(this._isQueried, this));
```


Yes, thanks.


Yeah - it was screwing something up. Couldn't figure out what the problem was at the time.

I'll take another stab at it this week.


wouldn't this redefine `UNIVERSAL_ADDRESS_SIZE` if someone else, say `MODULE_NG_IPV6` defines it in advance?


Instead of the `realQuery` variable you can just pass in `query` all the time.


No parentheses needed after `typeof`.


What about adding a test of the form `b^@interval(0.3)`, to really check that everything is being rounded correctly?


No parentheses needed after `!`.


Missing newline at EOF.


Shouldn't this just say `return realQuery`?


This commit is being reviewed as a part of review issue #53.


ui


can't get username and password .  in client object, these property are  protected.


ZoneVentilationDesignFlowRate (kbenne) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Improved in 6880761


你把你的修改提交就好了


EU/NA
[2015-08-19T21:39:46.006+07] FileVersion: 1.1.1.3647
[2015-08-19T21:39:46.006+07] ProductVersion: 1.1.1.3647


This part needs to be changed, because it ends up that `isQueried()` calls `_compileQuery()` repeatedly.   The idea is to just call  `_compileQuery()` when the class is constructed.


Likewise here.


<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

	Some text
	Some text

	Some text

正如您看到的，其中一个单元没有边框。这是因为它是空的。在该单元中插入一个空格后，仍然没有边框。

我们的技巧是在单元中插入一个 no-breaking 空格。

no-breaking 空格是一个字符实体。如果您不清楚什么是字符实体，请阅读关于字符实体的章节。

no-breaking 空格由和号开始 ("&")，然后是字符"nbsp"，并以分号结尾(";")。


All these great comments describing what is happening, and here's the meat of the commit. :)


This commit is incomplete , Where is the content of cpufreq_alucard.c? Obviously I was not compiled by the kernel because the information is not governor.
![Empty file](https://cloud.githubusercontent.com/assets/10282263/9359861/e6e52a70-465c-11e5-805b-e737197e2f42.png)


Could be simplified to "Return an iterator...", but I won't be a stickler about it. =P


There is a typo in `:delate` key. Also, the user must be removed and the `~` must be used instead. If you still would like to add this, then you should use this line instead:
```ruby
zap :delete => '~/Library/Application Support/AhnLab'
```


I'll add it, thanks.


@nmerket You can't easily search the error file yet, but you can query the sqlite output for these string outputs. Look at [OutputProcessor.unit.cc](https://github.com/NREL/EnergyPlus/blob/b5d65e9c71fc9f1db7dda067c865b6fde819d5f9/tst/EnergyPlus/unit/OutputProcessor.unit.cc) for examples of this. I can try to give a more concrete example later.


Always nice to delete some redundant code


There were some feature requests if I remember right as fixing actor/director photos, working youtube trailers, autogathering info without browsing files manually etc...
I know there is manual scan from plugin gui but it never worked for me (using CSFD plugin, not IMDB, also not sure if I must use "movieinfo.movieDB=true" to make it working or not. I need to read discussion about it again :-))


I'll fix it.


Just testing on iPhone6, looks perfect! Will check on even smaller screens later, but I guess it will be fine there, too.


Looks like my old env_warpball code, I restored it on my local repo, it will be uploaded in next revision :)


Please write your comments in English, so we can all follow it.


hashcode -> hashCode


link?


Copy-pasting item_battery is good idea (Valve/Gearbox did it too) but there are few things that needs to be changed . I upload item_helmet and item_armorvest code in the next commit :)


Hey, FYI I am using https://github.com/feross/standard as the style guide for this repo. You can `npm install -g standard` and then `standard --format myFile.js` to auto format code, and it will even pick up things like `==` vs `===`. I went ahead and formatted this commit after merging.


I don't think this is what we actually want. This is un-hiding all popups every time we call this method. The only time all popups get hidden is in the `TGMainViewStateLookingForRouters` case. In every other case, are they still showing? Something looks off about hardcoding these setters here.


yeah i agree


Maybe we should ask rest of the @CartoDB/frontend too.


oops


i had to change the numbers because previous test was wrong.. license summary was taking first the session then the dual licenses parameter and then the suite and i had totally missed that before.. so now the numbers are truly for jessie.


<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

这个表格有一个标题，以及粗边框：

我的标题

100
200
300

400
500
600


This old version of Dr.Rosenberg code should be fine, I'll take a look at this later and clean up some stuff (I think Rosenberg don't need the whole Scientist AI code)


Nice comment :smile: :last_quarter_moon_with_face:


This was necessary to have an initial encoding settings.


Applied in the local repo.


Should this not be ```... && !XSSUtil.containsXSS(requestedLocale.trim())``` or alternatively trim() in the line above?


@jcspader see this example http://jsfiddle.net/silasrm/vxoeLnLf/6/


I'm not sure what this does and why we need this program


I'll fix it.


So what should we do with it? `node test/server.js`?


ZoneVentilationDesignFlowRate (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


@m-mcgowan,
If I called "wiced_network_up_cancel = 1;" will this stop the wifi.connecting ?

Thanks


Makes no sense this confirmation dialog here since overwriting/appending is set elsewhere.


Thanks, in 07da0bc6008bfd54dbfc71377e57febab5b76dff


기존의 부팅 방식을 변경
부팅시 -> normal 모드 진입에서 사용자 정의 모듈을 한번 거치도록 변경

변경된점
부팅 -> hello 모듈 로드 -> hello 모듈에서 네트워크 통신으로 메시지 전달 -> normal 모드로 진입


This line determined that the constant encoding value 'System' was saved over and over.


*doh*


Why did you delete

> Please log in here at the prompt as 'admin' and follow the instructions to change the defaults

?


This broke building on Linux.


Looks good, but we need to do some cleaning here. I need to check if Hazmat / Clean Suit scientists can heal player or not. Also it might be better to just use C++ polymorphism on them, instead of copy-pasting the whole scientist.cpp


hmm, the app makes the files in the `/Users/root` folder. i didn’t know why they need it. and i double checked. it was just bug. sorry.


nit C&P error?


ZoneVentilationDesignFlowRate (kbenne) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


:100:

Cool.


ZoneVentilationDesignFlowRate (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


+1. I'm glad this was not so hard to find.  Kudos on the latest updates, by the way @joeyyang


Looks good. I'll check that deeper and integrate it when some AI fixes for security guards are ready (and some new features like weapon reload) :)


I don't see how
````go
	if len(blkid) == 1 {
		return blkid, nil
````
is valid. The previous logic used > because of regex match (afaict).

Should it be something more like
````go
	if blkid == "xfs" {
		return blkid, nil
````


Here it should be `$sprintPHID` instead of `$phid`, I guess.


Geez, that's straight up backwards. Thanks for the catch!


add


If the file does not have any heading at all in the first place, how would outshine mode be useful? In that case, the error would be a genuine error and not a bug.

You can have outshine mode enabled in a file without headings but then of course all the cycling commands will be pointless.


supernit: backtick and fix spacing in accessKey,secretKey and rdsPassword


I think you want class.getName() here, otherwise you end up with "class org.jitsi.impl.neomedia.transform.dtls.DtlsControlImpl" instead of "org.jitsi.impl.neomedia.transform.dtls.DtlsControlImpl".


Impulse 101 command will be changed in Subs 4. There will be a few simple IF/ELSE to see what HL1 game we're currently playing and player will get only items for proper game (e.g. no helmet and no vest in hl1 and of)


Sounds good. I'm shocked the standard js format is no semicolons.


Applied on local repo.


Yeah, it is beyond me why Travis keeps failing with timeouts.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.521](http://teamcity.monogame.net/viewLog.html?buildId=9781&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:30:22


This is due to the addition of orientations?

I checked out a bit here on because I've been focusing on getting xg up to speed. I might axe this whole part of the indexing scheme, just to decrease maintenance costs. :fire: :see_no_evil:


Thank you! This commit fixed the build. It was broken since http://ci.cgeo.org/job/c-geo/3954/


Now it's good :)


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1801 of 1801 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


asas


@edwinvanrijkom Oops, was that change breaking something? I'm curious... thanks


I think it looks fine. As you said, it's a workaround for now. Later we need to find a way to move all this processing inside the models, as each can have different requirements. We'll see together if you want (I have some ideas). but for now I think we can merge. Ok with you?


Could remove the merge conflict from the commit please?:-)

and from here 6be3ff69f0e54975fa1


Yep, and `npm run build` at first


If you actually want to filter out all the units from FA, use the PRODUCTFA category (and so you can replace all this with one line)


Great work, I won´t test anything until you land 4/4 there.


Because we want this to be easy to use for users.
They shouldn't worry about additional config possibilities.
I´ll add the line again.


In general, you should probably just add a restriction for the PRODUCTFA to every vanilla-SC mission.


ZoneVentilationDesignFlowRate (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Maybe we should include it in `npm` scripts? Is it possible to adjust `app/server.js` for this?


Cool! I really like the idea of having a generic API for variant-like types... that was the direction I wanted to take with `match(...)` and just adopting yours would probably make things a lot easier. It would provide an upgrade path for old codebases relying on unions or... dare we say it... dynamic casts ;)

About warnings, you mean the fact that I include it in a `ABL_DISABLE_WARNINGS` block? We do this with all external deps at Ableton because we compile with -`Weverything -Werror`, and `-Weverything` contains stuff that is well... debatable. If you want I can take your library out of the block and open issues with the warnings, but some of them might be not so useful.

Once again, thanks for taking a look and your collaborative attitude. I will open issues in the future for the stuff that comes up when using the library.


Ood:
![ood](http://img1.wikia.nocookie.net/__cb20140208021652/tardis/images/0/03/Ood_Sigma_%26_Co.jpg)


The new header is just to reduce the amount of boilerplate required by codes using the API.


26:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. import warnings should be before import sqlalchemy
23:1: I201 Missing newline before sections or imports.
26:1: I201 Missing newline before sections or imports.


24:1: I201 Missing newline before sections or imports.
25:1: I100 Imports statements are in the wrong order. from invenio.utils.text should be before from invenio_upgrader.api
25:1: I201 Missing newline before sections or imports.


4: L102 copyright year is outdated, expected 2015 but got 2014
23:1: I100 Imports statements are in the wrong order. import warnings should be before import sqlalchemy
23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
25:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from invenio.legacy.dbquery should be before from sqlalchemy.exc
26:1: I201 Missing newline before sections or imports.
31: D103 Missing docstring in public function


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
20:1: F403 'from sqlalchemy import *' used; unable to detect undefined names
21:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
21:1: I201 Missing newline before sections or imports.
22:1: I201 Missing newline before sections or imports.
27: D103 Missing docstring in public function
31: D103 Missing docstring in public function
42: D103 Missing docstring in public function


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014
20:1: F403 'from sqlalchemy import *' used; unable to detect undefined names
21:1: I100 Imports statements are in the wrong order. from invenio.ext.sqlalchemy should be before from sqlalchemy
21:1: I201 Missing newline before sections or imports.
22:1: I201 Missing newline before sections or imports.
27: D103 Missing docstring in public function
31: D103 Missing docstring in public function
39: D103 Missing docstring in public function


27:1: I101 Imported names are in the wrong order. Should be InvenioTestCase, make_test_suite, run_test_suite
32:5: E266 too many leading '#' for block comment
87:5: E303 too many blank lines (2)


Arf yes I mixed that up with something else, not sure why but I was thinking number of lines instead of length...
Actually during testing this I had `if len(blkid) >= 1`.

I believe we are agnostic of which fs is used (unless we ask for a force create), so ` if blkid != ""` should suffice right?


I access the source in other functions so I have to save the source in any case...


Iam not the fastet english writer (and my english isnt very good), so that was why I answered in german. Sorry for that.

In short terms:
If the sdparm command wait until it has finished the stop command (I doenst think really) we can try:
```
pid="sdparm --command=stop /dev/sd?"
wait $pid
```

Otherwise we can try this one (it is only pseudo-code and not tested):
```
# timeout in seconds
timeout=10
# seconds (with . milliseconds)
sleepTime=.5
tries=0

# sdparm --command=ready /dev/sd?  =>  If the device is not ready then the exit status will be 2
while ["$timeout" -lit "$tries" -a ! -e sdparm --command=ready /dev/sd?]
do
    tries=$(( tries+sleepTime ))
    sleep $sleepTime
done
```

Interessting part is the "man sdparm" page that says: "if the device is not ready then the exit status will be 2"

epg.dat:
Is this file written in /tmp and if its finished just moved to /etc or is this file growing?
- if its moved, we can maybe check the epg.dat date - some seconds, so we known that the file was written
- if its grown, maybe we can check the filesize and if its doesnt changed for example in 500 milliseconds, we known that the epg.dat was written


@rboulton: Ignore my question. It's been answered in https://github.com/alphagov/govuk-lint/commit/2b7cc676ad6a3c4ef38ca226943921b53e6c4773#commitcomment-12786309.


"There are currently no surveys available"?