The warning is here: https://github.com/KarthikNayak/git/blob/ref_filter/ref-filter.c#L1138 and says

    warning("ignoring ref with broken name %s", refname);

so we do get the name in the warning. Git has been forbidding broken names for a while, so I think it's OK to just show the warning and let the user rename his broken refs in case he has some.


This (and the following 3 lines) is a spurious change (apparently a tab -> 8 spaces).


Groovy. :v:


A simple `git pull --rebase` would prevent merge bubbles like this; I'm not sure that it has anything to do with the version of Git you're using.

You can [configure Git](https://coderwall.com/p/tnoiug/rebase-by-default-when-doing-git-pull) to rebase rather than merging on pull by default.


Forgot to update that for you: test updated: https://github.com/amarie004/ndb/blob/master/test/test.py <https://github.com/amarie004/ndb/blob/master/test/test.py>

sa1 = api.create_element('gathering information', sa)
sa2 = api.create_element(‘understanding information', sa)
sa3 = api.create_element('projecting and anticipating future state', sa)

> On Aug 20, 2015, at 12:44 PM, brianthelion <notifications@github.com> wrote:
>
> Traceback (most recent call last):
>   File "/usr/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
>     self.test(*self.arg)
>   File "/Users/ack/code/venv/NotssDB/notssdb/test/test.py", line 39, in test1
>     sa1 = api.create_element('gathering information', sa)
> Lines 38-40 in test.py for this commit says:
>
>     sa1 = api.create_element('gathering information')
>     sa2 = api.create_element('understanding information')
>     sa3 = api.create_element('projecting and anticipating future state')
> The traceback isn't from this commit. Are you sure you're running the right thing?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/amarie004/ndb/commit/04755fb2f1eb84f5621e32fa4f946b5e0188c29d#commitcomment-12811880>.
>


What's the traceback now?


Can we give this type it's own file?  Seems sufficiently large enough for one.


To be honest, I don't remember what I was trying to accomplish with this commit. I was scrambling to get integration testing working again before getting on a plane. I added the line back in the next commit.


@nick22891 don't change what you were doing before.  The first element is the most recent membership information.  Keep it like that.


Not really too happy about this, but it has to be done early. I'll leave it up to you to decide on how you would like this; let me know.


I don't understand what this is doing.


@pmclanahan Sorry, I knew, but I merged 2 commits and the commit message changed to "# This is a combination of 2 commits."

It was supposed to be "[fix bug 1193839] Update favicon for /firefox/nightly/firstrun."


this:
```
ERROR: notssdb.test.test.test1
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/ack/code/venv/NotssDB/notssdb/test/test.py", line 39, in test1
    sa1 = api.create_element('gathering information', sa)
  File "/Users/ack/code/venv/NotssDB/notssdb/api/convenience.py", line 17, in create_element
    return super(ConvenienceAPI, self).create_element(element_text, category)
  File "/Users/ack/code/venv/NotssDB/notssdb/api/object.py", line 192, in create_element
    new_element = Element(element_text, category)
  File "<string>", line 4, in __init__
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/state.py", line 306, in _initialize_instance
    manager.dispatch.init_failure(self, args, kwargs)
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/state.py", line 303, in _initialize_instance
    return manager.original_init(*mixed[1:], **kwargs)
  File "/Users/ack/code/venv/NotssDB/notssdb/model/base.py", line 180, in __init__
    self.category = category
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 224, in __set__
    instance_dict(instance), value, None)
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 1022, in set
    lambda adapter, i: adapter.adapt_like_to_iterable(i))
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 1038, in _set_iterable
    new_values = list(adapter(new_collection, iterable))
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/attributes.py", line 1022, in <lambda>
    lambda adapter, i: adapter.adapt_like_to_iterable(i))
  File "/usr/local/lib/python2.7/site-packages/sqlalchemy/orm/collections.py", line 636, in adapt_like_to_iterable
    given, wanted))
TypeError: Incompatible collection type: None is not list-like
-------------------- >> begin captured stdout << ---------------------
--start NOTSSdb Session--
('dance', 'Jen', 'C')
('wizzard', 'Brian', 'R')
('big', 'jo', 'smalls')
(u'dance', u'Jen', u'C', 65)
(u'big', u'jo', u'smalls', 67)
(u'wizzard', u'Brian', u'R', 2)
The new username is now: baseball
Deleted: big, jo, smalls 67
Leadership
Decision-Making
Teamwork and Communication
Situation Awareness
(u'Leadership', 1)

--------------------- >> end captured stdout << ----------------------

----------------------------------------------------------------------
Ran 1 test in 0.084s

```


The idea is to make Hybrid Base *versionless* and not have releases.  How to best go about that is something I'm working out at the moment.

You really shouldn't be keeping up with Hybrid Base versioning.  Rather, you should be keeping up your own versions of your own themes.  For example, you'd never update from "version 1.0" to "version 2.0" of Hybrid Base.


doesn't `rebase` mess up the history for other people though?

Which is why I only use `rebase` before pushing remotely.


Add a /... to the end and it would. I think removing it causes build
problems for folks who don't have it, not?
On Thu, Aug 20, 2015 at 9:45 AM bmw <notifications@github.com> wrote:

> Because go get -d github.com/letsencrypt/boulder exits with a non-zero
> status and the error message: no buildable Go source files.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/letsencrypt/letsencrypt/commit/283ccbfc45a484b3db96055d6418481a4a094ab2#commitcomment-12811907>
> .
>


I never used `-n<num>` myself so I can't provide a real-life use-case, but I think it makes sense to use both together. For example, after applying this

```
diff --git a/builtin/tag.c b/builtin/tag.c
index 781d3e5..396a8ac 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -40,10 +40,12 @@ static int list_tags(struct ref_filter *filter, struct ref_sorting *sorting, con
        if (filter->lines == -1)
                filter->lines = 0;

-       if (filter->lines)
-               format = "%(align:16,left)%(refname:short)%(end)";
-       else if (!format)
-               format = "%(refname:short)";
+       if (!format) {
+               if (filter->lines)
+                       format = "%(align:16,left)%(refname:short)%(end)";
+               else
+                       format = "%(refname:short)";
+       }

        verify_ref_format(format);
        filter_refs(&array, filter, FILTER_REFS_TAGS);
@@ -401,8 +403,6 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
                        copts.padding = 2;
                        run_column_filter(colopts, &copts);
                }
-               if (format && (filter.lines != -1))
-                       die(_("--format and -n are incompatible"));
                filter.name_patterns = argv;
                ret = list_tags(&filter, sorting, format);
                if (column_active(colopts))
```

I could run

    git tag -l -n3 --format '%(color:blue)%(align:16,left)%(refname:short)%(end)'

and get the same output as the default, but with the refname painted in blue (which is actually much more readable than the default IMHO).


Уахахаха =)

![63766ad5125b6a49732c0f5a49ad8a8e](https://cloud.githubusercontent.com/assets/5984175/9389599/a4db05aa-4774-11e5-8569-3a4d40547409.jpg)


That's a nice trick


Really bad fix , but it prevent some crash while i'll investigate :/


AsTypeSymbolOnly?


Is the @docker0 strictly necessary?


死霊の巣
這張我不太理解為什麼要重新修改
目前暫時維持原狀


@mkonicek, I submitted this as a PR in #2339. Feel free to overwrite this change if that's easier.


That'd require making 'free_array_item()' public, but I guess, it's a fair tradeoff.
Will do as you suggested :+1:


Yea, Will do


Do we need to pass "linkExisting=false" as well, or is it unnecessary to make it explicit? If "data-link-existing" is false, and we don't need to append "linkExisting="false" then is it better to remove the "data-link-existing" attribute, or does jsQuery do that auto-magically?


@alphan102 I think this is where the bug is. The variant must not be set as a string, it needs to be set as a type that XHR treats as binary.


You should also remove the empty line on line 2. The rest is fine.


that'd have been much better :) No worries, just want to make sure we're communicating our standards before merging.


Thanks for the opportunity for me to learn more about path finding.  The changes look like they are obviously correct.  I'm glad Tom is the other reviewer, since he actually knows about path finding.

Just for context I spent some time looking at the path finding README (https://github.com/ripple/rippled/blob/develop/src/ripple/app/paths/README.md#high-level-of-a-payment).  I'm guessing this code deals with the part where '...rippled "continuously" return solutions...'.

It looks like the changes meet the requirements of the JIRA item (https://ripplelabs.atlassian.net/browse/RIPD-1013).  @sublimator, does this look good to you?


@levicole DWMR. This was a great soltuion. :+1:


až moc class method blbě se to pak přetěžuje


Won't this change the comparison of the underlying `TypeSymbol` in t1 and t2 from a reference check to a `Equals` check?  Is that expected and okay in this case?


It seems like data-link-existing="false" is not passed by autocomplete.js in which case it seems unnecessary here.


Looks like the group talked about this [here](https://github.com/w3c/presentation-api/issues/46#issuecomment-88057245) with the justification that the analogy with `RTCDataChannel` is better than that with `postMessage`.


送去墓地的卡应该没有等级12的限制
另外，同名卡的这个效果同一连锁只能使用一次


merge it


Should we add an `IsDefault` method to `TypeWithModifiers`?


That was quick :)


TeamCity pull requests :: netty [Build 83](https://garage.netty.io/teamcity/viewLog.html?buildId=576&buildTypeId=pulls_netty&guest=1) is now running


Well good example there, I'll change this.


Great stuff. Since we've found our Pastry's rating here, we can actually call break;

What break; does is that it tells our loop that we've found what we're looking for. In such a small example, it's hard to see why we would do this, but imagine we had tens of thousands of Pastries...


Cool.


Actually, this is a reference. So playing with the resource itself is enough.


think its the way i query in object.py ? all the issues are coming from the many-to-many relationships ( I presume)


So I added config option for recharging, like in your example. This commit is in addition to 46b4467.
Terribly sorry for indent mismatch in Interface.cpp, I only noticed it after the push... them tabs are tricky.


To add to that, comma token doesn't seem to cover these either, so this only covers your first type parameter.


This overrides the FactoryGirl `@user` and `@post` in the before block above it. We discussed this in our meeting.


@ropilz tnx man for the info. I have done everything you said but unfortunatelly I get this force closed exception with the plugin in android:

 FATAL EXCEPTION: pool-2-thread-2
 Process: ......
 java.lang.NoSuchMethodError: No virtual method setFollowRedirects(Z)V in class Lcom/squareup/okhttp/OkHttpClient; or its super classes (declaration of 'com.squareup.okhttp.OkHttpClient' appears in /data/app/com.appiLux.appiNet.appiDoc-1/base.apk)
 	at com.parse.ParseOkHttpClient.<init>(ParseOkHttpClient.java:44)
 	at com.parse.ParseHttpClient.createClient(ParseHttpClient.java:42)
 	at com.parse.ParsePlugins$Android.newHttpClient(ParsePlugins.java:171)
 	at com.parse.ParsePlugins.restClient(ParsePlugins.java:87)
 	at com.parse.Parse.initialize(Parse.java:194)
 	at com.medlei.ParsePlugin$2.run(ParsePlugin.java:117)
 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
 	at java.lang.Thread.run(Thread.java:818)


@Mottie it shouldn't. Nothing should mess with history unless you `-f`.

Also, checked my gitconfig, it's actually another option that avoids these merge commits for me:

`git config --global branch.autosetuprebase always`


Fixed.


Not if the commits you're rebasing haven't been published yet. I.e., if you've made commits to your local `master` branch, and new commits have been published to the remote's `master`, you can safely `git pull --rebase` to replay your local commits on top of the remote changes.

Basically, anything that doesn't require a force-push is safe.


comment is now inconsistent with value


Make sure you add the copy right headers and comments on all your Java and CF code please


continue here surely?


Нужно было добавить, что оно берет данные из оглавления в главно РИДМИ


I think it would be better to have `registerListenerForTypes` take a `const&` to `PacketTypeList`


Yea, this needs to be changed.


Perhaps I should have explained, I added this requirement because it's absence was causing an error.


instead of polling, and thus forcing a 30-sec delay between lease and data availability, what do you think of using https://godoc.org/golang.org/x/exp/inotify to know when the leases change?


Alright, I'll fix the changes shortly.

IMO a breaking change so I vote for a new major version. Better safe than
sorry 😀

On Thursday, August 20, 2015, robert mcguinness <notifications@github.com>
wrote:

> sounds reasonable to me. i wonder if this is considering a breaking change
> or a bug fix? [image: :smile:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/phillipj/metalsmith-prism/commit/6ecbd1dec591c84789bcf3acbeb1ed98f537b7bb#commitcomment-12808232>
> .
>


The problem is that you're passing in a Category object to convenience.py line 16. Line 16 appears to expect a string, not an object. The ```.retrieve_category(...)``` call is probably returning None instead of throwing an error. You're then passing the None down to the ORM, which is expecting something else.


@ilyakatz It is not disabled on the tablet :c


@silverwind yup, although in versions of Git >= 1.7.9, you can also use `git config --global pull.rebase [true | preserve]`, where `preserve` performs the equivalent of `git rebase --preserve-merges`.


Agree, the regexp gives some level of input validation.


I can't really grasp why 27 would be supported and not 28. Maybe it was caused by other bugs (#1692) and this can be reverted later.


Ok, I ended up adding both global settings LOL... and I'm now using Git v2.5.0.


s/make/makes/, s/enable enable/enable/


Done


Wait, dammit, how did I miss this. They're duplicating the writable stream interface :(


yes, sorry. resent: https://github.com/brianchandotcom/liferay-portal/pull/29467


I'll also setup @jawshooah's suggestion. From what I read, `autosetuprebase` only works on new branches.


I was using the previous version of the mutate plugin with the fix posted here:
https://github.com/skokhanovskiy/logstash-filter-mutate/commit/c8b9e63ae32e6dd173424aa1c71e5f4d77d13f93

This worked perfectly in all my use cases.  I just upgraded to logstash 1.5.3 in a test env and also upgraded to this fixed version of the mutate plugin.  The lower casing does work now, but I am seeing one odd issue.  If the data I am lower casing contains a number or an underscore the field simply goes away and is not in the output at all.


(Which isn't ready yet, mainly because we didn't have any specs driving it... augh!!)


Style-wise, I actually prefer putting the packetLIstenerLocker in it's own block and letting it unlock on destruction, ie:

```cpp
{
     QMutexLocker packetListenerLocker(&_packetListenerLock);
     std::remove_if(std::begin(_packetListenerMap), std::end(_packetListenerMap),
                    [&listener](const ObjectMethodPair& pair) {
         return pair.first == listener;
     });
}
```

What do you guys think? Reasoning: makes it obvious what lines the mutex is locking and protects against programmers thinking that new line is protected because they didn't see the `unlock`. In some cases this sort of partitioning isn't possible, of course.


That article recommends not setting both global settings... now to find the default for `branch.autosetuprebase`...


Since we have the 'isaligned' function in john already, would it make better usage of time to first check if a buffer IS aligned before doing the copy, and only copy if it is not properly aligned from the start?

I do not know 1 way or the other, I am simply asking a question.


Why is this [ampersand](https://github.com/pluginkollektiv/antispam-bee/commit/f0c63a21a6a239d4482142725754d63f9b8c9913#diff-43cbb9fbbb79b59bb46166987ef4ebf1R374) red? Noticed that before, don’t think it’s a problem, just asking out of interest.


s/tigger/trigger/


Sorry, added [llen] - can't seem to find a way to edit the commit message. :-1:


stringByTrimmingCharactersInSet is for strings - the goal here is to trim white space from an attributed string non destructively to its attributes.


TeamCity pull requests :: netty [Build 82](https://garage.netty.io/teamcity/viewLog.html?buildId=569&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5159, ignored: 21 Build time: 00:25:52


TeamCity pull requests :: netty [Build 84](https://garage.netty.io/teamcity/viewLog.html?buildId=583&buildTypeId=pulls_netty&guest=1) is now running


These slow down self-test, especially for OpenCL. We can `#ifdef DEBUG` most of them out after all bugs are squashed.


@Mottie just edit `.gitconfig` in your home folder.


LGTM


28*2 is 56  is that the reason?  I have not looked at code, so have no idea if that is right or not.


What do we gain by forcing an upgrade in the NuGet dependencies? I know many libraries have the bad habit of creating a hard dependency to Newtonsoft.Json and if they specify an older version are there possible conflicts? Maybe a package XXX has an issue with 7.0.1 and only works with 6.0.8 then the user has to remove XLabs Json.NET and use ServiceStack instead (not a bad option but that's besides the point). Of course it will be easy to create their own wrapper around 6.0.8 Json.NET so there are workarounds.


@boucher This should be replaced by a value from libnetwork bridge interface. I will update this. Thanks


Good point!


Should I pass an object instead or delete def create_element(…) altogether in convenience.py?

> On Aug 20, 2015, at 1:01 PM, brianthelion <notifications@github.com> wrote:
>
> The problem is that you're passing in a Category object to convenience.py line 16. Line 16 appears to expect a string, not an object. The .retrieve_category(...) call is probably returning None instead of throwing an error. You're then passing the None down to the ORM, which is expecting something else.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/amarie004/ndb/commit/04755fb2f1eb84f5621e32fa4f946b5e0188c29d#commitcomment-12812232>.
>


There are actually 4 cases, but I worked out a way to make it not explode into too much boilerplate code. Committing it soon.


Good idea, could you add it?


@moy as per your suggestion, I've made the test check the stderr for the broken ref, works :)


Ooh I like that!


Feh, I didn't see that Derek had reverted the port, so that my testing copy was different.


database koi


Major updates to Cosmology chapter to include results from draft paper on dithering led by Humna Awan


The calls to the initialization functions should not use tail-calls, because in Java there is no TCO so in theory this could cause a stack overflow.  A better structure is to have all the calls to the init functions in the static { ... }


haha, i to je zanimljivo rješenje :)

Ja nešto sumnjam da bi ovaj bug nestao ako bismo prepisali kôd tako da ne koristimo `static` metode. Tj. da u `main()` metodi napravimo instancu klase `ShopApplication` i na njoj onda pozovemo instance metode. **Mislim** da bi tada ovaj problem nestao i da bismo mogli staviti `if`-ove u normalan redoslijed ili čak koristiti `switch` naredbu.


@mbadams5 Right now when it hits this, it just stops like

```
[==========] Running 179 tests from 56 test cases.
[----------] Global test environment set-up.
[----------] 1 test from AdvancedAFNTest
[ RUN      ] AdvancedAFNTest.Test1
[       OK ] AdvancedAFNTest.Test1 (1 ms)
[----------] 1 test from AdvancedAFNTest (1 ms total)

[----------] 1 test from AirflowNetworkBalanceManagerTest
[ RUN      ] AirflowNetworkBalanceManagerTest.TestOtherSideCoefficients
[       OK ] AirflowNetworkBalanceManagerTest.TestOtherSideCoefficients (0 ms)
[----------] 1 test from AirflowNetworkBalanceManagerTest (0 ms total)

[----------] 1 test from AirflowNetworkSolverTest
[ RUN      ] AirflowNetworkSolverTest.HorizontalOpening
[       OK ] AirflowNetworkSolverTest.HorizontalOpening (0 ms)
[----------] 1 test from AirflowNetworkSolverTest (0 ms total)

[----------] 1 test from ChillerElectricEIR
[ RUN      ] ChillerElectricEIR.TestOutletNodeConditions
[       OK ] ChillerElectricEIR.TestOutletNodeConditions (1 ms)
[----------] 1 test from ChillerElectricEIR (1 ms total)

[----------] 1 test from ConvectionCoefficientsTest
[ RUN      ] ConvectionCoefficientsTest.ConvectionCofficients
[       OK ] ConvectionCoefficientsTest.ConvectionCofficients (0 ms)
[----------] 1 test from ConvectionCoefficientsTest (0 ms total)

[----------] 13 tests from HVACFixture
[ RUN      ] HVACFixture.DXCoils_Test1
[       OK ] HVACFixture.DXCoils_Test1 (63 ms)
[ RUN      ] HVACFixture.DXCoils_Test2
[       OK ] HVACFixture.DXCoils_Test2 (39 ms)
[ RUN      ] HVACFixture.TestMultiSpeedDefrostCOP
[       OK ] HVACFixture.TestMultiSpeedDefrostCOP (34 ms)
[ RUN      ] HVACFixture.TestSingleSpeedDefrostCOP
[       OK ] HVACFixture.TestSingleSpeedDefrostCOP (35 ms)
[ RUN      ] HVACFixture.DXCoilEvapCondPumpSizingTest
[       OK ] HVACFixture.DXCoilEvapCondPumpSizingTest (888 ms)
[ RUN      ] HVACFixture.DemandManagerGetInput
[       OK ] HVACFixture.DemandManagerGetInput (64 ms)
[ RUN      ] HVACFixture.Humidifiers_Sizing
[       OK ] HVACFixture.Humidifiers_Sizing (32 ms)
[ RUN      ] HVACFixture.Humidifiers_AutoSizing
[       OK ] HVACFixture.Humidifiers_AutoSizing (32 ms)
[ RUN      ] HVACFixture.Humidifiers_EnergyUse
[       OK ] HVACFixture.Humidifiers_EnergyUse (32 ms)
[ RUN      ] HVACFixture.Humidifiers_GetHumidifierInput
[       OK ] HVACFixture.Humidifiers_GetHumidifierInput (62 ms)
[ RUN      ] HVACFixture.Humidifiers_ThermalEfficiency
[       OK ] HVACFixture.Humidifiers_ThermalEfficiency (67 ms)
[ RUN      ] HVACFixture.MixedAir_ProcessOAControllerTest
[       OK ] HVACFixture.MixedAir_ProcessOAControllerTest (68 ms)
[ RUN      ] HVACFixture.HPWHWrappedDummyNodeConfig
```
After that, nothing.


Did this just not run alright?


The problem is that std::partition reorders the vector so it can't be const.
And I couldn't think of any reason you would need to keep that vector around.
So at least that way if you pass in an initializer list directly, which is what we do everywhere, you avoid the copy.
We only create the vector once, it's used and then discarded.

One thing I'd also thought about would've been to take a `&` because order usually doesn't matter so you don't really care if it gets reordered.


please use intellij idea


Guys thanks for that,

Just one comment, FTDB provider is not working for Season Packs.

They have a dedicated category for it but sickrage is not searching there.


attributedSubstringFromRange seems the only option, unless I missed something...


canvg saved my day. thanks. @ChangeTip, send 400 bits to @gabelerner


Is `-log_phi` really `-Hgrad`? What about the `norm` term? Doesn't it depend on `phi`?


Hi @gabelerner, @cherouvim sent you a Bitcoin tip worth 400 bits ($0.09), and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/886861)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


Yeah, was acting up.  Didn't look into it yet.


what's different between this page and the map page? it shows up fine on the map, right?


The current template for the sim at https://github.com/phetsims/chipper/blob/master/templates/sim.html, has a  proper head with a title and a charset. The prototype does not. Again, need to do some reading on the shadow DOM.


I got what you did, and its better indeed. I just wrote to let you know that you missed part of the logic that was there ;)

I fixed it without changing ConfigurationMenu: I just check if it's a newMobilization before rendering ConfigurationMenu. If it is I render a different top bar.


localPkg returns baseurl only if local path


I think you're right, I'll make the change.

But I think that in this case:
```
QMutexLocker directConnectSetLocker(&_directConnectSetMutex);
Qt::ConnectionType connectionType =
                 _directlyConnectedObjects.contains(listener.first) ? Qt::DirectConnection : Qt::AutoConnection;
 directConnectSetLocker.unlock();
```
We shouldn't do that:
```
Qt::ConnectionType connectionType;
{
    QMutexLocker directConnectSetLocker(&_directConnectSetMutex);
    connectionType = _directlyConnectedObjects.contains(listener.first) ? Qt::DirectConnection : Qt::AutoConnection;
}
```
Thought?


@pmclanahan Yeah, sorry about that. I changed the message when merging but, seems that is not what ends up in history. :-/


Heh yeah. I realized it was pretty ironic that I did this change while in the middle of implementing a change that you asked for. :)

Still, it seemed like a good idea to make sure there's a low-tech "out" when my stuff just isn't working out. Last thing I want is to be frustrating people because I took away a simple, easy way to get stuff done.

-- Marco N.


Here's an relevant email on RNG seeding from Chris from a while back, coincidentally 2 days from a year ago :). Sounds like manual seeding (g_tw_rng_seed) should just be disabled entirely and the corresponding argument in tw_define_lps be ignored.

> I think we stopped using that parameter since we did not want users picking
> their own seeds as some seeds are better than others and some are just bad.
>
> So, a little primer here on RNGs. RNGs in fact have only one (hopefully) very, very
> long stream of random numbers. CLCG4 uses 4, 32bit values or 128 bits.
> This generator has a period of 2^121 implying that ~2^7 values are missing
> from the generator.This is fine.
>
> So, you can image a circle with 2^121 tiny point going around the circumference
> where each point would represent a random value. Eventually, if you called
> the generator 2^121 times, you would have made it around the circle.
>
> A very nice property of CLCG4 is that you can jump (or virtually teleport) ahead
> in that single stream of random numbers. We call it "seed jumping". ROSS
> starts from the default seed and jumps 2^70 calls ahead in the stream for each
> LP. That is, each LP's starting point in the random stream circle is 2^72 calls
> apart.  So, in theory, we could support simulation with unto 2^49 LPs and each
> LP have it's on part of the random stream, uncorrelated from other parts.
>
> Now, to change seed sets, what you really want to do is change where each LP
> starts on the random stream circle.
>
> You can do this by increasing g_tw_nRNGs_per_lp. So, suppose you use 4.
> That will give each LP 4 distinct RNG seed sets that start again 2^72 calls
> apart.
>
> In your model code, you just change which seed set you wish to us -- 0, 1, 2, 3
> e.g., lp->rng[0] or lp->rng[1], lp->rng[2] or lp->rng[3].
>
> By default in ROSS, when you use lp->rng your really saying &(lp->rng[0]).
>
> The downside of this approach is you're potentially wasting some memory by
> have these 4 seed sets around and the cost to compute them but it's a very
> low cost all around unless you have a model with billions of LPs.
>
> If that is the case, you would have to directly jump or shift seeds an LP uses
> by directly invoking the seed jumping routine w/i the RNG with the LPs
> init event.
>
> e.g., call, tw_rand_initial_seed(&lp->rng[i], lp->gid + offset);
> where offset would be the number of 2^70 jumps you want to make beyond the
> LP's global id.


@guce just style comments: open curly brackets in the same line of the `if`, no need for the `!= 0` for a boolean check. Same apply to the second test. Otherwise looks good!


Differences between this approach and Baeldung's.
Send and email with a verification code, and verify that the user responds with it in order to enable the account.
http://www.baeldung.com/registration-verify-user-by-email
Then, if the user doesn't respond in time and wants a new verification token, send a new one.  Also, exception handlers are covered in the link below:
http://www.baeldung.com/spring-security-registration-verification-email
We're already doing encryption... with bCrypt, as they are doing.  But it might be interesting to check over their code.
* http://www.baeldung.com/spring-security-registration-password-encoding-bcrypt *
password token reset:
http://www.baeldung.com/spring-security-registration-i-forgot-my-password
we're already doing localization... but there may be something useful related to redirecting for success/error:
* http://www.baeldung.com/spring-security-login-error-handling-localization *
logout... uses an audit service.  not sure why?
http://www.baeldung.com/spring-security-logout
redirectStrategy... redirect after login, based on whether the user is admin or not.  A bug in this implementation, if the user is both an admin and a user, it will fail.  It uses a custom AuthenticationSuccessHandler and DefaultRedirectStrategy... Spring classes.
http://www.baeldung.com/spring_redirect_after_login
Secure persistent remember-me.  I don't think that this capability is in the spring-security-login-and-registration project.
http://www.baeldung.com/spring-security-persistent-remember-me
Roles and Privileges:  Overkill for this application, perhaps.  he gives read only privilege to users, and read/write to admins.  But I don't get how these roles & privileges are used in the business logic, perhaps there's some 'magic' behind the scenes that enforces these 'authorities'.


You might be able to shorten this to something like ->
def indentation_builder(indentation_count): return "  " * int(i_count)


I thought I did that...


This particular sentence is one that bothers me because it scopes out discrimination I would adjust it to state "or other differences" at the end because we leave open some forms.


From `man git-config`:
> branch.autosetuprebase
When a new branch is created with git branch or git checkout that tracks another branch, this variable tells Git to set up pull to rebase instead of merge (see "branch.<name>.rebase"). When never, rebase is never automatically set to true. When local, rebase is set to true for tracked branches of other local branches. When remote, rebase is set to true for tracked branches of remote-tracking branches. When always, rebase will be set to true for all tracking branches. See "branch.autoSetupMerge" for details on how to set up a branch to track another branch. **This option defaults to never**.


BOOM!


Sasha wanted to see an example of a recursive function counting down, so maybe include this one (or a better modified one?) in the diagnostic answers?


Can you give an example of what it doesn't cover?


Maybe you can simplify with:
if cfg.stop_on_error:
    raise
(as at the end of the block it is the end of the loop block).

But, maybe it would be better to have
if cfg.stop_on_error:
    return scoreboard.rc()
inside the if e.code == Nosuchkey code to have the correct return code in such a case ?


@dwj192 overall ok. The only thing that is missing is that for any usage change we also need to update the test template at src/test/cli/radosgw-admin/help.t


How about swapping the `if` condition and using early returns?


organizational nit-pick, not required: this should be a class-method category on `NSCharacterSet`


Say I'm a vegan, it doesn't mention that (I'm not, I'm a omnivore but still) I have people attacked on Twitter and the likes for being vegans or vegetarians, there are many more personal beliefs that can be attacked.  We should just sort of imply: "we don't care what your personal beliefs are, we are here to code and your personal beliefs don't play a part in us getting a long professionally."


Good idea


you did something with the link, now it is not visible. when you see on the screen is actually the link for the girl avatar

http://take.ms/muhTT


sounds good to me!


@montehurd can you add a test to verify that all-whitespace strings return an empty string? can be a unit test, not an snapshot test


@xueharry That's a good question. I think there are some good reasons for doing it this way, although some may just be my own bias :).

1.  The simplified logic/algorithm for extracting the desired annotations makes the code much more readable. Now the template filter is dead simple and anyone can see at a glance what's going on. Furthermore, I don't think template filters should be doing much processing anyway, so it's useful to push that responsibility up to the view so that the template can be as dumb as possible.
2. Whenever you can simplify your algorithms by modifying your data structure, even if that means creating another data structure, that's generally a good thing. As you pointed out, with small data sets (few annotations and/or replies), there's no benefit to creating the additional data structure. You could argue this is premature optimization, but I would disagree and say that this is less optimization, and more good design to avoid an obvious performance issue that will show up at even moderate scales. I'm not sure if you've come across [this quote by Linus Torvalds](http://programmers.stackexchange.com/questions/163185/torvalds-quote-about-good-programmer), but I sometimes have to remind myself of that because it's easy to find yourself going to great lengths to extract the data you want, when you could save yourself a lot of time by just changing the input data structure to begin with.
3. Don't forget that the redundancy and space cost is actually not as bad as you think. Remember, python passes objects by reference, so when you're creating the  ```annotation_dict```, what are the values? The values are *references* to the annotation dicts contained in ```annotations['rows']```. That's because you're just assigning the ```anno``` object to the dictionary, which just assigns a reference. You aren't creating a new dictionary and assigning that and you aren't explicitly copying the dictionary objects, so the end result is actually quite space efficient. Assuming you don't modify anything in these data structures, and they are strictly intended for "read-only" access, there's nothing wrong with that.

If you really want to know if it's faster than the previous implementation, you could try running some tests with python's performance tools (**timeit** module). I haven't used it much, but you could probably design a test that would compare the two approaches at different scales.

Anyway, even if it isn't significantly faster than your previous implementation, the readability and reusability that you've gained is worth the tradeoff imo.


what is "it"?


pfeffer is such a noob


@Ravnsara ready to push to server


@croaky Have you ever come across a 'load order' bug when using Zeus with a Rails 3.x project? Recently I was running tests in Zeus that threw an exception seemingly because `ActiveRecord` hadn't yet been loaded, so one of my model factories was expecting a method from the `ActiveRecord::Base` superclass but instead the `user.superclass` returned `Object`.


Could this be pushed to NPM please?


@huikang I took the liberty of breaking up the first two pieces of your commit:

https://github.com/docker/libnetwork/compare/master...boucher:huikang-patch
https://github.com/opencontainers/runc/compare/master...boucher:huikang-patch

Do you mind if I submit them as PRs? (I've retained your authorship of course)


You mean the recursive module thing or `Elim`?

With recursive modules, if you don't have any local definitions other than types then it suffices to just provide the signature and set the module equal to itself. Not sure where it's explained but it's a trick I learned awhile ago.

The whole spiny thing in general is based on some of Conor's old epigram tech and this was my (probably misguided) attempt to port the gnarly haskell to gnarly OCaml :) The `Elim` thing is used to help drive the evaluator to WHNF in `(//)`.

I haven't ported any of the typechecker stuff yet but I think it should go through…


This seems to already be there in: https://github.com/ssadedin/bpipe/blob/master/src/main/groovy/bpipe/executor/SgeCommandExecutor.groovy#L106


Also added some limited tooltip help text to alignments panel


Also, one thing I like about this approach that I'll probably adopt elsewhere even if the rest doesn't pan out is the trick with defining `Ctx` in terms of `Star(Ext)`. I was using difference types in several of my other developments lately to do something similar but this seems like a cleaner and more localized approach.


Thanks, will do!

On Aug 20, 2015, at 5:53 AM, Fernando Sproviero <notifications@github.com> wrote:

> Hi @gkibilov, because the original developer removed it:
>
> https://code.google.com/p/javapns/issues/detail?id=214
> https://code.google.com/p/javapns/source/detail?r=387
> https://code.google.com/p/javapns/source/detail?r=388
>
> Anyway, I've been testing it and did not have any issues so far. Let me know if you encounter any issues.
>
> —
> Reply to this email directly or view it on GitHub.
>


Just out of curiosity, can you make it a more generic RBAC?


Better to use a document id to delete


Cioè, che cosa si mette in configuration_overall ???
Ora è vuoto?


:+1: was initially torn on this since I expect users to have their token but I think this would be a good feature to add to the command line tool (e.g. `snitcher login` then it asks for username + password.).

Documentation is great. We've been using Tomdoc as a format, thanks for keeping with it.


ChangeTransitionIDDName (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I want to add a bird


This should probably raise the `Timeout::Error` since it's a different error case from authentication failure.


why not just use System.Media.SoundPlayer and convert the mp3 to .wav?


Yeah but we have 8 bytes of salt too, and we do many limbs anyway. I can't see why 27 (nor 28) would be a magic number. But I haven't really looked at the code.

The OpenCL code can do 28, or more. Limiting it is more about limiting precious private memory use.


Nice :+1:
Finally updated my fav assembly :cat:
Thank you!


5127_hpwh_dummynodes (nmerket) - x86_64-MacOS-10.9-clang: OK (1792 of 1793 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


@AxisWhistle 没有问题，最后会精简一些


This should be `use_ssl: uri.scheme == "https"`. It's likely we got this wrong originally. It works since most HTTPS is over 443 but it's not correct.


Zxink


Does this commit fix the need to run 'rake asset:precompile' after deployment?


ChangeTransitionIDDName (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2289 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.95%25-yellow.svg)


Do the ButtonGroups actually *need* to be wrapped in a ButtonBar? Just seems like an extra wrapper to me.


Why are we adding a method that is deprecated already?


Capitalize normally.


@rootfs can you be more explicit ?


This looks good, but given that this is called every time the fragment is resumed it would make sense to check whether the notification map is empty before creating the thread.


Will do.


I agree. That test is very quick, and the strcpy is potentially very slow. We do something like that in pseudo-intrinsics.c (NEON/Altivec):
```c
static INLINE vtype vloadu_emu(const void *addr)
{
	char JTR_ALIGN(MEM_ALIGN_SIMD) buf[MEM_ALIGN_SIMD];
	return is_aligned(addr, MEM_ALIGN_SIMD) ?
		vload(addr) : (memcpy(buf, addr, MEM_ALIGN_SIMD), vload(buf));
}
```


@billinghamj [`babylon`](https://www.npmjs.com/package/babylon) and [`babel-core`](https://www.npmjs.com/package/babel-core) have both been updated in NPM.


I do not understand how Add support for BigPictureStyle. To show a BigPicture, send 'bigPicture' along with extras an example please


@loganfsmyth so how do I use them? Will a dependency of ^5.8.21 automatically use that?


In www/Toast.js the `Toast.prototype.show` is missing the `addPixelsY` argument and the call to `.withAddPixelsY(addPixelsY)`.


Why not simply make sure `self.IntelDisables` is always initialized?


This used to be a builder of TypeSymbols prefilled with nulls, now it is a builder of structures not prefilled. Items have to be added to it, indexing is going to throw.


[ABAC](https://github.com/kubernetes/kubernetes/tree/master/pkg/auth/authorizer/abac) is implemented, yet role based access control (RBAC) is not. [Keystone is a RBAC](http://docs.openstack.org/admin-guide-cloud/content/identity-service-api-protection-with-role-based-access-control.html). So my gut feeling is you can abstract keystone to RBAC first.


I'd need to test this but overall looking good.


Or Maybe in a lib the constant lookup could prioritize LibC by default.

Or letting the user do somthing like
```crystal
lib MyLib
  include LibC

  fun foo(c: Char): Int
end
```

I would like to avoid all the LibC. lib is only used for C bindings after all.


@jfirebaugh this overwrites most of the Emerald assets.


No red lines on line 2 Open the non changes tab. It's on the top left of the code window


ABAC or RBAC will just be authorizers. I don't see any value abstracting that out again.


I generally agree with the sentiment but I think it does not apply in this case. There is already no guarantee than the server and BnP logs will match. Doing ```this.status.setStatus``` only sets the status of the AsyncOp so that if an external observer queries for status that's what they get. It does not actually "push" the status back to the observer. From BnP's side, it queries the status periodically, but there's no guarantee that it will see any given status. This whole status mechanism is a convoluted and there is something to be said about improving it, but I'd rather not touch that as part of this change...


Good call. No support in globalize, as far as I can see, which makes sense because that's really based at the model level - we're using a more generally applicable Rails method for editing translations from the admin interface - `accepts_nested_attributes_for`, which is independent of globalize.

I've made a little class, but I want to add it into `app/controller/concerns` as it really is only relevant for controllers. We have quite a lot of undifferentiated stuff in `lib` already, and have established a pattern of using concerns, so I think this makes sense.


That's my bad!  Sorry about that one.


Happy to take a PR, thanks for noticing!


TeamCity pull requests :: netty [Build 84](https://garage.netty.io/teamcity/viewLog.html?buildId=583&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5568, ignored: 21 Build time: 00:35:12


TeamCity pull requests :: netty [Build 85](https://garage.netty.io/teamcity/viewLog.html?buildId=584&buildTypeId=pulls_netty&guest=1) is now running


TypeSymbolAsTypeWithModifiers is not a method, it is a delegate cached in a static readonly field, therefore the delegate is not getting allocated for each call.


thenk's for this repo plz.. update this repo ok


If you've installed the `babel` package from npm then you are installing [`packages/babel-cli`](https://github.com/babel/babel/blob/master/packages/babel-cli/package.json#L11), which depends currently does `^5.8.21` so if you install it fresh it it will install `5.8.22`.


Will move TypeWithModifiers type it in a separate file.


@tvandergeer he's a genius :P ;)


clear**er**?


Which of the three conditionals inside `$scope.saveDeck` are you referring to?


I didn't know this even existed, oh well. It'd be annoying for choosing a custom sound anyway.


Sure.


No, you should just do an check to see whether you have a string, int, or object. If you have an object, then you don't have to do anything. If you have a string or an int, then you need to retrieve the object.


Minor note- the reasoning behind using a separate var there was to protect against ebuilds doing stupid shit like mangling ebuild_phase (since it's not marked read only).

The thinking there was to ensure that pkgcore still kept its states correct, even if the ebuild did things it shouldn't.  In that regard, might want to be wary for changes like this.

...Mind you, I realize that's extreme corner case, but keep in mind most of these protections came about from the bad ole days before EAPI even existed.  People have proven to do heinous things at times. :)


do i look like i have control over that


I m thinking this is because of the two if statements used


Done. A test case is added in f908b74fa38b2678e26aea128dbd934cd781a9b6.


Ah okay.  Nice!


Roger that.


Nice so then create an IF ELIF statement in convenience.py before passing super()

> On Aug 20, 2015, at 1:44 PM, brianthelion <notifications@github.com> wrote:
>
> No, you should just do an check to see whether you have a string, int, or object. If you have an object, then you don't have to do anything. If you have a string or an int, then you need to retrieve the object.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/amarie004/ndb/commit/04755fb2f1eb84f5621e32fa4f946b5e0188c29d#commitcomment-12813113>.
>


We intended a section to be synonymous with a class (although teachers may use them differently). For example, a teacher may have one class of 3rd graders doing Course 2 and one class of 4th graders doing Course 3. Each class would be in its own section. Theoretically, when they finish the course, the entire section would change to the next course. But I've seen some teachers who don't follow this model and have one class, each in a different section for different courses.

Each section has a teacher and is assigned a course.  However, even though students in a section are assigned a particular course, they can still do other courses. When a section is assigned a course, that just means 1) the default view of teachers viewing student progress is for that particular course and 2) when students sign in, they're directly led to the course.

A student can be in multiple sections, even across different teachers.


I ll get rid of the two ifs. I tried && to get find_by to take multiple queries and it didn't work. I ll try the hint.


Yes, this is fine, the code below effectively does value comparison anyway.


I believe I did this somewhere else in PacketReceiver, but I do agree it can be a problem, particularly with more complex types. I can get on board with using unlock() in these cases.


It is interesting that `element.getTextRange()` does not return a value that is within the range of the document. We should investigate further why this is the case to make sure that this is the best fix.


I actually started checkpoint33 and switched it to assignment32 to correct it, but I forgot to add and commit


I have seen "Shadow DOM" mentioned a few times in this context, and I wanted to clarify: we are not using the Shadow DOM for our accessibility features.  A good way to think about our situation: the simulation is rendered in a black box (which may be SVG, Canvas or WebGL) and we are creating a surrogate/parallel DOM tree to communicate with the accessibility tree.


and ID?


BTW @zzlei did you see any speedups from this on Altivec and/or Arm? Are you acquainted with the "relbench.pl" script? It goes like this:
```
$ ./john -test > test1
(make changes)
$ ./john -test > test2
$ ./relbench test1 test2
```


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I do not believe it is warranted. This code exists to satisfy existing unit-tests, compiler never passes default instances to this API.


All of them, preferably. See http://codereview.stackexchange.com/a/61981/31562 . This helps greatly with reducing indentation level and overall makes the code easier to read IMO


ChangeTransitionIDDName (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.99%25-red.svg)


Commit or send me the code snippet that didn't work so I can take a look
please

On Thu, Aug 20, 2015 at 1:47 PM jophinjohn <notifications@github.com> wrote:

> I actually started checkpoint33 and switched it to assignment32 to correct
> it, but I forgot to add and commit
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jophinjohn/bloccit/commit/d2a3c1f8505bf34fba84c0c674758ef0f2d96608#commitcomment-12813183>
> .
>


Should be: `UserDialogsImpl.ShowToastOnBottom = true;`

The `s` is missing.


ChangeTransitionIDDName (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1792 of 1792 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


* Update of some manuals
* Updating many avps for Alcatel 7750


And relbench -v test1 test2 to see Ratio of old vs. new test for every format, except that currently it can't handle if a format has Many/Only one salt in one test and Raw in another etc... (I intend to fix that (with a new relbench option when I find the time.)


Having default instances of TypeWithModifiers flowing in the compiler is abnormal and unexpected.


Offhand, this is going to bite us in the ass the moment we use multiple EBDs in a threaded fashion; signal handlers are basically process specific in python, the main thread ID gets all signals.   Pretty much, if two ebds are going w/ timeouts, the last to register is the one that owns the signal handler- the first will never get an alarm.

This is my understanding of things mind you, but https://docs.python.org/2/library/signal.html looks to confirm it still.

Like the intent, just think you'll need a registration mechanism for this- or a generalized alarm handling thingy-ma-bob.


Interesting addition... Is it the intention that PowerShell runs non-elevated via the shortcut? I am plagued by warnings from the chef-client when I do this (provisioning scenarios mostly).

```[2015-08-20T16:52:12+01:00] WARN: chef-client doesn't have administrator privileges on node stuart-laptop. This might cause unexpected resource failures.```


I'm quite sure this is useless for you.


Yeah I added -v at the same time you wrote it :-)

Nor sure if Solar agrees, but I think it should default to use raw ≈ one-salt if they differ.


Lmao this lang key


Ok, I understand now.

Explicit moving is somewhat worrying to me in that it opens up an avenue for bugs - I can imagine someone trying to use `types` later in the function without realizing it was moved from. I'm mostly thinking out loud here, weighing the costs of performance vs safety in different situations. In general I'd err on the side of safety unless the performance is a real concern. What do you think?


I've added tests in my latest commit


I'll just make two options, or an option with two possible values.
(But that gets complicated when I want to cover Long/Short as well...)


guaranteed that


@bgerstle good catch!


Buenos dias, tengo una pregunta, porque usamos static en los métodos de clase?


I'd love a release with this in :)


Thank you, that was the missing info!


It takes a value anyway so moving here is safe. It'll only optimize if you
pass an rvalue ref, otherwise, it'll copy.
On Thu, Aug 20, 2015 at 7:57 PM Ryan Huffman <notifications@github.com>
wrote:

> Ok, I understand now.
>
> Explicit moving is somewhat worrying to me in that it opens up an avenue
> for bugs - I can imagine someone trying to use types later in the
> function without realizing it was moved from. I'm mostly thinking out loud
> here, weighing the costs of performance vs safety in different situations.
> In general I'd err on the side of safety unless the performance is a real
> concern. What do you think?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/huffman/hifi/commit/62c76d0332baedf401eb88d75bb69f2d35c30eab#commitcomment-12813378>
> .
>


Tried using `EXPECT_EXIT` and it caused it to seg fault. Also, it doesn't exit when the bug is fixed, so it wouldn't work anyway. I think this is fine the way it is.


You can retrigger hooks in the hooks settings panel


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 370](https://teamcity.labkey.org/viewLog.html?buildId=267607&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:05
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Yes. For 6733, you can safely (if your experiment can survive that range) set min=-10 and max=10 (but i have seen funny things at +10V, suspecting signed integer effects) globally. For other cards this can be different.


@taion @cpojer Would love your thoughts on *this* hack :smile:


For now I'm doing, for example:

```crystal
lib MyLib
  alias Int = LibC::Int
  alias Char = LibC::Char

  fun foo(c: Char): Int
  # ...
end
```


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (2307 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.72%25-yellow.svg)


This is an "existing" TODO in this type, it has it everywhere where custom modifiers could be present (see AreArrayTypesEqual on line 626). I am going to open an issue to make sure all these TODOs are dealt with.


Rather than duplicating this in multiple packages I would suggest to add a `qmake` build style and pass `$LDFLAGS` to them instead.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 371](https://teamcity.labkey.org/viewLog.html?buildId=267610&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:22
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Hash rocket launches you into space!

Hash colon .. uhh.. it's two dots. It's not as cool or fun.

Hehe :)


Hello with which databases emulator is compatible please ? Is it possible to add it to the deposit to be able to provide somes fixes and scripts ?


I meant that within the scope of this function, that parameter is no longer after this line.


Testando, blablalba


:+1: yep, that could be enough for know. Eventually a `use_plain_c_types` macro could be used for that at least inside crystal.


This parameter should be named either `$passwordHash` or `$tokenAuthSecret` since the password hash is what is stored in the `user` table.


oops! I’ll get to fixing this as soon as I can (but maybe not this
week, I’m at a conference.) If you’d like to get it back faster, you
can open a PR against `terraform.py`.


Porque tantos espacios en blanco? @tavorazo


QUitar los comentarios que ya no apliquen @tavorazo


QUitar esto @tavorazo


Quitar esto @tavorazo


I think this was added because IANA is asked to also assigned OIDs under different prefixes, which IANA doesn't necessarily control.


this also leads to a passing pod spec validation


@tavorazo Probaste que se guarden bien las fechas del lado del servidor?


@bgerstle Fixed!


Makes more sense to call this `default_save_path` or `default_save_dir` perhaps?


Cool, very nice


@Pixel-Pirate databases added few minutes later


It seems like we are adding a method, but I am reverting back to how it was before DRILL-3319. So the method that existed is being deprecated. My comment is slightly misleading, I'll fix that.


I don't need an opcode number (I know most of them). I need to know where is blizz using that one... I didn't even find the way how to set that note to players in calendar


Will `saves_dir` be absolute here? If not, can I get it absolute?


I thought the comment field is still useful. We don't want to allow change of names, but we should allow annotating them in case of merger/etc.


Because compile-time constants are more performant than run-time constants. if VC++ is too stupid to accept them, you can revert them back.


Seems like I might have to extend it a bit, to make sure we render old children until the ready state changes on the terminal root container or something.


why not all images (rhel too)?

we should be able to get them from ci.dev.openshift.redhat.com.  and of course if we we're going to use this for the jenkins push job, the image will already be available locally.


TeamCity pull requests :: netty [Build 85](https://garage.netty.io/teamcity/viewLog.html?buildId=584&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4740, ignored: 21 Build time: 00:28:16


TeamCity pull requests :: netty [Build 86](https://garage.netty.io/teamcity/viewLog.html?buildId=585&buildTypeId=pulls_netty&guest=1) is now running


Thanks :)


Small issue, but do you think it might be better to convert `$user['superuser_access']` to `int` before comparing? Depending on `(bool)'0' === false` worries me (at least for all possible PHP implementations, ie HHVM).


just return eventsCreated instead instead of passing in a pointer to a value to update; e.g.,

`int createSingleDeviceEvent(...)`


Just looked at this again, actually the old implementation was correct imo: if the plugin can handle the action it should return `true`, even if there is an error inside that action. Check the source of `org.apache.cordova.PluginManager.exec()` where a status `INVALID_ACTION` is sent as pluginresult, but you really want to handle the result in the plugin itself (send back a status of `ERROR` with a relevant message).

Since the callback isn't kept in our `callback.error()` methods I think the `INVALID_ACTION` that PluginManager sends never arrives at the client and that's when you'll see `Attempted to send a second callback for ID: Calendar272609691`

I'll change this a bit.


thus,

```
events += createSingleDeviceEvents(L, state, -1, device, events, &eventsCreated);
```


https://github.com/sindresorhus/string-length

Though you might want https://github.com/sindresorhus/string-width since you're using it in the terminal as it correctly counts fullwidth characters.


I think test methods should use the new method naming convention?


Use of "Reserved" was as per Pearl's request. I think we should keep it.


and since function is potentially creating multiple events, rename to `createSingleDeviceEvents`
and rename `cudaEvent_t* event` to `cudaEvent_t* events` since it is now possibly multiple events


Możesz się upewnić, że `mvn clean install` buduje u Ciebie projekt? Gdy robię to u siebie, dostaję:
```
[ERROR] /C:/dev/tmp/vending-machine-kata/src/main/java/tdd/vendingMachine/VendingMachine.java:[3,31] package com.sun.istack.internal does not exist
```
Jak się domyślam, jest to powiązane z tym tematem ze Stack Overflow: [http://stackoverflow.com/questions/1834826/it-is-a-bad-practice-to-use-suns-proprietary-java-classes]()

Jeśli będziesz miał jakieś poprawki w tej kwestii, zakutalizuj, proszę, pull requesta :-)


TeamCity pull requests :: netty [Build 83](https://garage.netty.io/teamcity/viewLog.html?buildId=576&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5568, ignored: 21 Build time: 01:16:08


I am getting slightly worried about the constant use of subrequest. There has to be a performance impact.


Per pep 257, you still need to have a blank line between the first one and the rest of the docstring.


rename function and the parameters:

`void waitSingleDeviceEvents(..., cudaEvent_t* events, int numEvents)`


To be extra safe, I'd check `.location == 0`, since the URLString should start with `v1*`, right?


This isn't an actual change, it's more for better readability


Thanks, I'll take a look over the weekend. I guess this is a performance improvement patch and the behavior shouldn't change, am I right?


Do the queries get aggregated correctly when you do this? Naively I'd expect this to double-issue any queries from the outer-most child `RootContainer`.


nit: spacing between `(` and `{`

`for (int i = 0; i < events; i++) {`


Add 'use strict'; as the first line - forces extra checks


Możesz się upewnić, że `mvn clean install` buduje u Ciebie projekt? Gdy robię to u siebie, dostaję:
```
ROR] /C:/dev/tmp/vending-machine-kata/src/main/java/tdd/vendingMachine/VendingMachine.java:[4,19] package org.mockito does not exist
```
Wygląda na to, że u Ciebie na classpath kodu produkcyjnego było dostępne Mockito, mimo że w `pom.xml` zdefiniowane jest jako `<scope>test</scope>`.

Jeśli będziesz miał jakieś poprawki w tej kwestii, zakutalizuj, proszę, pull requesta :-)


Envio completo via Visual Studio


We should just delete this file; it doesn't do anything.


Can you make it configurable from the config file?

I think we might need a section in the config file, something like this:
"github": {
    "ignore closed": true
  }


rename since it is now possibly more than one:

`cudaEvent_t* events = ...`


Move this file into the ./lib dir - follows package standard


semicolon


↪ 2015-08-20 Thu 18:40, John MacFarlane <notifications@github.com>:
> If `hidelinks` doesn't take an argument, shouldn't this be
>
>     $if(hidelinks)$hidelinks,$endif$

`hidelinks=false` has the same result as `hidelinks=true` or just
`hidelinks`.

I've fixed the patch-1 branch, sorry for the lousy testing of the
first patch.


Hello, you may need to do more atomic commits.


looks good to me otherwise, just naming convention changes and similar nits.


will do :)


Cleaned up and published my `.gitconfig`, in case you're interested in more tweaks :wink:

https://github.com/silverwind/dotfiles/blob/master/.gitconfig


hahaha its fine we can just force push again :^)


don't use == -- i almost never see it in js, === is the way to go :)


```elixir
def truncate(string, len, opts \\ [])
```


shouldn't we unregister if ID3DPresent_SetPresentParameters fails .


se haran pruebas al sistema.


Acknowledged.


@Robinlovelace thoughts on this?  I aimed to make the example much smaller and simpler to follow.


valeu


Done!


How do you feel about this? (obviously cleaning up comments once it passes CI)


> We don't use rtmpdump in tests anyway

It's not true. Just search "rtmpdump" in Travis CI build logs (for example [this one](https://travis-ci.org/rg3/youtube-dl/jobs/76474173)). Unfortunately, rtmpdump is not listed in allowed APT packages of container-based infrastructures. I've opened an issue at travis-ci/apt-package-whitelist#922.


Resharper - you may want to ensure you allow for picking up the team settings (I've put most everything in there) - I may do a full export again to that file to ensure so. I did the same recently for choco


Super awesome!


Probably `Elixir.Integer`


bleh, the "i" var is declared in the scope of the userThread function. Might cause an error if you have another use of "i".  For these cases, I saw a good approach of _.map(_.range(6), worker);   (assuming var _=require('underscore');


It should probably be something like this:

- customContentLayout
- contentLayout
- siteLayout
- sectionSiteLayout

Or is it too painful to switch? Migrations, etc...


Axel, improvements are always welcome! Make a pull request, I'm curious how you've implemented this.


its an IDE so why not? :disappointed: https://www.jetbrains.com/idea/


looks good


But the "render old children" behavior is exactly what you already get from `RootContainer`, no?

Taking a step back, I think what we want is support for something like:

1. User navigates from `/a/b` to `/a/c`
2. While Relay fetches the new data, show a spinner on the portion of the page for the changed sub-route
3. When the new data is available, render `/a/c` as it stands

I feel like this is a case that's potentially best handled by something like Relay's `fragment.deferred()` support, along with whatever `AsyncProps` support react-router ends up shipping, assuming those two play together nicely.

I feel like working around it here adds a little too much idiosyncratic complexity that won't match the "correct" longer-term solution. For the stuff I'm working on, I'm happy enough with the current behavior where the route transition just doesn't take effect until the root container is done fetching all the new data.


Fails regardless :(

```elixir
** (ArgumentError) could not call defines? on module Integer because it was already compiled
```


Cleaned up this and a few other places where a property would be much simpler.


This doesn't compile, right?


I think you should pull out this logic into a function and then write some `SimpleTestCase`s for it.

e.g.
```python
def test_integers(self):
    self.assertEqual(calcTotal([1, 2, 3]), 6)

def test_mixed(self):
    self.assertEqual(calcTotal([1, 2, 'a']), '')  # or whatever
```


Autoupdate isn't needed on T5x??

Regards


"C-style escape sequences like \t"? An example would be useful here because the term might not be that familiar.


Ok, I'll see if I can come up with an appropriate `common/build-sytle/qmake.sh`.


Love this. I just had the need for such a thing.


we could also try inferring this from the datatype of the associated column, but maybe that's overkill


ChangeTransitionIDDName (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (750 of 750 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.46%25-green.svg)


I am using version 0.4.0, and I am experiencing this error only on Chrome. It works fine Safari (Mac). The fixes outlined above are already applied in version 0.4.0, and the problem still persists.


Close #652.


surprised to see this inferred from the columns. could be more intuitive to make it a first class property of the report (don't feel strongly though)


Don't do this, you don't need to do this if you name your module correctly.


I got it working and it is committed. find_by runs without &&. found that out the hard way lol.
Date: Thu, 20 Aug 2015 10:52:11 -0700
From: notifications@github.com
To: bloccit@noreply.github.com
CC: jophinjohn@hotmail.com
Subject: Re: [bloccit] Assignment 32 final (d2a3c1f)

Commit or send me the code snippet that didn't work so I can take a look

please

On Thu, Aug 20, 2015 at 1:47 PM jophinjohn <notifications@github.com> wrote:

> I actually started checkpoint33 and switched it to assignment32 to correct

> it, but I forgot to add and commit

>

> —

> Reply to this email directly or view it on GitHub

> <https://github.com/jophinjohn/bloccit/commit/d2a3c1f8505bf34fba84c0c674758ef0f2d96608#commitcomment-12813183>

> .

>

—
Reply to this email directly or view it on GitHub.


You shouldn't need this either, nv12-venus is for 4k typically...


Should we have some kind of timeout here to ensure we don't spin forever?  Also if we're going to do that, might be nice to stuff the for() loops into a gofunc and then select{} on a channel.  We currently can't handle failures here, but I think that would be a good thing to do anyway, so that stuff that calls NewOsdnRegistryInterface() can intelligently handle problems (even if just by bailing out with a log message).


Perhaps: "PatternFly is meant to be used as a replacement for Bootstrap so please don't include the Bootstrap CSS if you are including PatternFly CSS in your project."


picky but this is actually sort of `total_rows` (since it's either a list of 0 or 1 element)


5127_hpwh_dummynodes (nmerket) - x86_64-MacOS-10.9-clang: OK (1793 of 1793 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Suggested as the advert [here](http://meta.opensource.stackexchange.com/a/596/407) for open source community. I'm open to suggestions.


Should remove the 'error' return from this function since it no longer returns an error anywhere.


Same here, nothing returns an error from this function anymore.


Hah, so people were setting EBUILD_PHASE manually in ebuilds? I guess that makes sense to protect against that then and/or perhaps scan for such things in pkgcheck.

Thanks for the code reviews by the way. :)


Agreed, but we need some automated benchmarking before optimizing.

Then that resolveResource would be a nice point to optimize. E.g. I'd expect that all ++site/contentlayou++'s could be just traversed (or looked up using resoucedirectory API) instead of subrequests.

Generally, I'm open for all optimizations, which don't break ESI. (Currently even ESI tiles do one subrequest, but I have alternative ESI transform on roadmap. I will need ESI.)

Nathan Van Gheem kirjoitti to elokuuta 20 21:12:03 2015 GMT+0300:
> I am getting slightly worried about the constant use of subrequest. There has to be a performance impact.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/plone/plone.app.blocks/commit/7f33c6d08082a16bfdc75473fef091752ca4a0a2#commitcomment-1281369


ChangeTransitionIDDName (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1798 of 1798 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks, this is great. Much appreciated.


99.8% of users do not read this :)  No problem.  As an FYI, I do things like this when I can't hit at least 2 platforms.  Otherwise I get more defects filed (android snackbar won't budge from bottom to top).


develop (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2194 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-93.88%25-yellow.svg)


renew


'See http://c3js.org/reference.html for a full list of C3 chart options.'
This is a great idea, would you mind updating the donut directive ngdoc with this comment, since you have an open PR  -thanks


config.totalUnits, I changed this to just 'units' as it is used to denote amounts other than just the 'total'


does your clang support `namespace sss::framing {`?

should work with `-std=c++1z` clang option


should this be called 'yData' to match the 'xData' property?


You don't even need to store the header for empty frame. It's just a constant byte.


Does Mythos really send `ZoneChangeMessage` before `ZoneMessage`? I have not been able to reproduce that. I believe `ZoneMessage` should always be sent first, anything else might be a bug.


Don't put closing namespace braces on single line.


Can you explain why you need this if statement? it will fail if the token is not expired, and that strips the x-auth-token from the headers, when it is needed.


Ah, I just meant the trick with recursive modules...

The Elim stuff is cool too, though.


sorry, but this made me think of another case: whitespace on only the head/tail of the string. could you add another for that? sorry I didn't think of this earlier, but returning early might mean the leading/trailing won't be trimmed in those cases.  I'd suggest we:

- set new "head" index to the first whitespace char +1 (clamped to end of the string), or if not found, the beginning of the string
- set new "tail" index to the last whitespace char -1 (clamped to 0), or if not found, the end of the string


5127_hpwh_dummynodes (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1799 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


+1

I'm not aware anything besides Mosaic using ILayoutAware from p.a.blocks 2.x, but there are dev sites out there so migration would be nice. Should get all types with the behavior from portal_types and migrate those.

Nathan Van Gheem kirjoitti to elokuuta 20 21:19:37 2015 GMT+0300:
> It should probably be something like this:
>
> - customContentLayout
> - contentLayout
> - siteLayout
> - sectionSiteLayout
>
> Or is it too painful to switch? Migrations, etc...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/plone/plone.app.blocks/commit/991ea97db7411da9b1ae2f40b014db077821eec2#commitcomment-1281387


return values?


And with a change like this, we probably need to cut 3.x release.


I have seen this issue since I started using PsiViewer (which is awesome btw) and I was wondering why no one else seemed to notice it. I found this repo accidentally when searching for Colin Fleming and I thought while I'm at it, I could fix this issue (and the annoying 13x13 pixel icon issue which seems already fixed).

My guess was that the `PsiElement` you are highlighting might be cached and is not always up-to-date when I delete characters. Indeed, a quick check, by committing the document reveals, that it seems to work too. My understanding is that committing the document saves all changes and brings everything up-to-date. I might be wrong about that, but with this here, I cannot reproduce the issue either:

    final Project project = _editor.getProject();
    assert project != null;
    PsiDocumentManager.getInstance(project).commitDocument(_editor.getDocument());
    TextRange textRange = element.getTextRange();
    debug("Adding highlighting for " + textRange);
    _highlighter = _editor.getMarkupModel().addRangeHighlighter(textRange.getStartOffset(),
         textRange.getEndOffset(),
         PsiViewerConstants.PSIVIEWER_HIGHLIGHT_LAYER,
         _textAttributes,
         HighlighterTargetArea.EXACT_RANGE);


Please remove whitespace between module tags.


We probably don't want to keep stream refs here directly, access them through channel instead.


On 2015-08-20 13:53, ferringb wrote:
> Offhand, this is going to bite us in the ass the moment we use
> multiple EBDs in a threaded fashion; signal handlers are basically
> process specific in python, the main thread ID gets all signals.
> Pretty much, if two ebds are going w/ timeouts, the last to register
> is the one that owns the signal handler- the first will never get an
> alarm.

> This is my understanding of things mind you, but
> https://docs.python.org/2/library/signal.html looks to confirm it
> still.

> Like the intent, just think you'll need a registration mechanism for
> this- or a generalized alarm handling thingy-ma-bob.

Ah, makes sense. In theory I think the timeout stuff could be dropped
now too if necessary. Initially it was because shutdown_processor wasn't
properly checking if an ebd instance was running or not so it would hang
on SIGSTOP-ed ebd instances.

Now snakeoil.process.is_running() parses the related process status
entry in /proc to determine process state so a SIGSTOP-ed process won't
be considered running anymore.

The only case where the timeout will be necessary is if an ebd instance
is in a really bad/strange state where it's running or getting hammered
somehow and doesn't respond to an alive query within 10 seconds.

Tim


Could you please also bump the version number of this pod so that people have the option of using older versions of AFNetworking.


What is $templateCache?  Should I have done something like this for donut chart !?


Add clang-format to pre-commit hooks for cpp/h/hpp files.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 372](https://teamcity.labkey.org/viewLog.html?buildId=267615&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:31
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


One last empty line always (Sublime Text setting: `"ensure_newline_at_eof_on_save": true`)


Why not just pass `channel::ptr`?


Hi,
I'm seeing some sporadic crashes, and I think they might be related to this changeset.
GDB gives me the following callstack (using version cb5f6a1a4bc72f2bca43d71004401d458821d04b):

```
#0  0x00007f11430b3227 in raise () from /lib64/libc.so.6
#1  0x00007f11430b4778 in abort () from /lib64/libc.so.6
#2  0x00007f11430f2e7b in ?? () from /lib64/libc.so.6
#3  0x00007f11430f89d6 in ?? () from /lib64/libc.so.6
#4  0x00007f11430f9753 in ?? () from /lib64/libc.so.6
#5  0x000000000042a611 in pktbuf_ref_dec (pb=0x7f10e80225d0) at src/packet.c:168
#6  pktbuf_ref_dec (pb=0x7f10e80225d0) at src/packet.c:164
#7  0x000000000042a639 in pkt_destroy (pkt=0x7f10e8002220) at src/packet.c:35
#8  pkt_ref_dec (pkt=0x7f10e8002220) at src/packet.c:67
#9  0x000000000048403c in mk_mux_write_pkt (mkm=0x1d2e6c0, pkt=0x7f10d414dae0) at src/muxer/tvh/mkmux.c:1240
#10 0x0000000000481b74 in tvh_muxer_write_pkt (m=0x261df00, smt=<optimized out>, data=<optimized out>) at src/muxer/muxer_tvh.c:162
#11 0x0000000000472b47 in muxer_write_pkt (data=<optimized out>, smt=<optimized out>, m=<optimized out>)
    at /root/spksrc.new/spk/tvheadend-testing/work-cedarview-5.1/tvheadend-testing-gitcb5f6a1a4b/src/muxer.h:137
#12 dvr_thread (aux=<optimized out>) at src/dvr/dvr_rec.c:951
#13 0x00000000004158be in thread_wrapper (p=0x3347d30) at src/wrappers.c:149
#14 0x00007f1143937def in ?? () from /lib64/libpthread.so.0
#15 0x00007f114316678d in clone () from /lib64/libc.so.6
```

I'm not sure what the cause of this crash is, does this callstack mean anything to you @perexg?


Yeah, it doesn't work anymore, even on the original tano ;_;7
It use to work perfectly fine.


Can you please upload the actual .osm file to Dropbox (or somewhere else) and link to it here so they can download the file without having to export from OSM?  That way they have an exact snapshot to test with - otherwise, if we (or someone else) makes changes to OSM they could end up running on a slightly different version of OSM than the one you tested with.  You can keep the link to OSM as well, so they can see the area on the map in question.


5127_hpwh_dummynodes (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


`int` function without returning any value? `-Werror` complains


The `-fPIE` part is probably not needed, since you're building a library instead of an executable.


Rather `channel->find_stream(header_.lsid).detach()`


So why do we have this file here??


Retries on the status request is invalid. Minecraft uses a TCP socket requests are not lost and result in an invalid packet being sent.


Yes. Setuptools has paved the way to increment major version when required :)

Nathan Van Gheem kirjoitti to elokuuta 20 21:35:28 2015 GMT+0300:
> And with a change like this, we probably need to cut 3.x release.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/plone/plone.app.blocks/commit/991ea97db7411da9b1ae2f40b014db077821eec2#commitcomment-1281421


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.441.0651a3f5fadfb60b8f48ad3406b4b9a28afa7397](http://build.palaso.org/viewLog.html?buildId=61612&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:17:10


I would move this line to the top - it's the most recent to the actual problem.


Why do you even need it? Does virtually nothing.


Ugh.  Why?  This makes it difficult or worse to diff, blame, merge with same formatting, or submit upstream pull requests.


"Fix bug" is a pretty crappy commit message.

The message should describe what you are fixing and why it works.


It's better call this type `max_frame_count` or `max_frame_count_t`.


demo


It saved me the effort of having to do the testing for if I misplaced something.


it is a 3-strided list
number, number name, description. I correted it and added a few more. See my pull request #43


Why dispatch always has a different signature?


Does it currently work in linux as well? (fine if it doesn't)


Wouldn't be better to use `intptr_t` instead of `int32_t` and thus solve the pesky issue with `SafeHandle` only working with `IntPtr` (see the `SafeFileHandle.Open` comment)?


Yea, storing wheels in the same git repo as members isn't a good idea. The files are too big. Let's instead use https://github.com/Cadair/travis_wheels to build all the wheels and host them on a server somewhere instead.


Take a look at BaseAttributeTypeValidatorTest and VisitAttributeTypeValidatorTest for examples.


Following on to my previous comment… I really can't tell what is going on here - I'm not sure why throwing away the string and returning the new one would be valid.


when I use it it means "only intended to be used in THIS namespace". I think it's common...


Don't ever use () to call default constructor. This might look like a declaration of function `frame()` returning a close_frame to compiler. With VEERY interesting error messages.


TeamCity pull requests :: netty [Build 86](https://garage.netty.io/teamcity/viewLog.html?buildId=585&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5574, ignored: 21 Build time: 00:34:48


Also remove the `return` below.


101064176-AddCO2DemandControlledVentilation (lgu1234) - x86_64-MacOS-10.9-clang: OK (1792 of 1793 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


@rzarzynski sorry for the late comment on this one, but why const bool? also, probably better use const string reference for the previous two


This entire bunch of functions could be
```
template <typename T>
void framing_t::read_handler(asio::const_buffer input)
{
  T frame;
  frame.read(input);
  frame.dispatch(this);
}
```


I understand. Thanks a lot!


Ok. Done.


demo


Not clear here whether 0.13.0 itself is broken or working.  I'd use language like "the problem seems to occur in v0.13 and higher".  That way its clear that 0.13.0 has the problem, vs. being the last working version.


Sure. thank you. I will check and make changes


But that only verifies the build step.


abre uma issue -> abra uma issue


That's just horrible wrt readability...


Can you also test for these cases where you throw exceptions?


That's all I needed it for. :smile_cat:


needed to remove the include_recipe as the docker DSL distributed with Chef is find for this but does not expose a default recipe.


@unbug What is the reason for calling `cancelMove` here?


This is not a package.


@bgerstle I added tests for these.


The exception messages need to tell the caller what exactly went wrong or what they should do. In other words, you are the one who has made the web service call and you get an exception with the above message, would it be obvious to you regarding what went wrong, without looking at the API internals?


Umm, WTF


Sure.


did you mean setInterval instead of setTimeout?


It works as-is 'cause it's looking for an inverted whitespace set in both cases.


I've move these screenshots to the top as well.

Generally, in bug reports I like to follow this format:

* Short summary of bug
* What I am seeing
* Steps to replicate
* What I expect to see
* Any workarounds?

So, I would suggest you follow this outline:

*Problem*

Routing on pedestrian areas seems to be broken in v0.13.0 and up

*What I see*

When building the graph...the OTP graph does not seem to include any links related to the pedestrian area in OSM.

(Show the graph visualization and OTP trip plan screenshots for the broken version here)

*Steps to replicate*

(Include the exact steps to replicate, including links to OSM data and command line commands used, and links to OSM ways/areas involved)

*What I expect to see*

(Include screenshots of working version of pedestrian routing on areas graph visualization and OTP path)

*Workarounds*

None, other than downgrading to the last working version of OTP, which is vX.X.X.


@unbug What is the reason for calling cancelMove here?


kinda looks like old code I forgot to remove... will take a look again tomorrow.


Wow, thanks for all the informations!

Yes I think it's better to treat the same file pawns as behind the bishop.

Bitboard pretty is really usefull, I made another commit with your corrections, thanks again for taking the time to respond to my (newbie) submissions, it helps me a lot.


This is much cleaner than the subtract & compare length thing.


@coreyfloyd ah good point!


You need to also improve this exception message using the same guidelines as i have mentioned above.


My biggest problem with coding is being forgetful, that's why I make so many commits of fixing.


because it's a constant; i don't think I want to change something that's expected to be immutable...


demo


oh, yea. That's right.


that's a bug. should be GPLv3


@coreyfloyd instead of **Fixed bug with "wmf_trim" and all whitespace strings.** I should have said **"wmf_trim" doesn't trim all-whitespace strings. Fixed.**


@versatran01, please correct me if I'm wrong, but I think active development of the catkin version is in the feature/child-frame-id branch


I assume those 2 lines should have gone into a unit test? :-)


stops my vim automated python PEP8 checker from reporting a warning there that I imported something but didn't use it.


Yes, it does (at least for me). Read this here: http://pastebin.com/nez6VC5p. The first one appears at 156.


Sorry was rushing.


importMethodsFrom(..) for an S3 method is utterly wrong..   use S4 methods if you want to import them :-)


yea, those *.whl's are too big. I think we're going to to have to perform surgery on the repo to get rid of them...


Do you need to append `s.config.domain` to the split `service.Hostname`? What if the user does not launch their Docker container with an FQDN?


We don't have to, just easier for my workflow when it's all consistent


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.23.0651a3f5fadfb60b8f48ad3406b4b9a28afa7397](http://build.palaso.org/viewLog.html?buildId=61611&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:32:34


This is an interesting question, Python requires no spaces here: http://stackoverflow.com/questions/8853063/pep-8-why-no-spaces-around-in-keyword-argument-or-a-default-parameter-value


Sorry, meant fix/child-frame-id


@mchaver Thank you, James. I'm not having a lot of problems with trying to use GHC 7.10, at least not with mtl or transformers.


5127_hpwh_dummynodes (nmerket) - i386-Windows-7-VisualStudio-12: OK (1799 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I really think this token based approach is not good. Reasoning about token sequences given a syntactic context is the job of the parser. If the services layer cannot simply check for a type parameter node in this position, then the parser is not doing its job sufficiently for incomplete constructs.


I didn't as there were no unmanaged resources to dispose.
See Remarks here: https://msdn.microsoft.com/en-us/library/system.idisposable.aspx
Also Adding Disposable to an existing class is considered breaking change.


@coreyfloyd It works because we're looking, first in one direction, then the other, for any non whitespace character. If we don't find one, in either case, we have a whitespace only attributed string, which when trimmed the desired output is an empty attributed string.


what is this supposed to be?


Is it ok for this to happen while the copter is running?  (I think it currently can).


5127_hpwh_dummynodes (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (751 of 751 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.9%25-green.svg)


sweet, optimizations incoming!
(why did I get a notification for this commit? ^^ probably because it's in the mainline repo and you commented it :dancer: )


demo


why the rails app is in a sub directory ?? any particular reason?


We could bin the for loop:
    var productQueryString = "/product?names=" + this.productsArray.join("&names=") +
                                              "&include_fields=...";


This will return a boolean in $type, but the original code returned a string view|table.


The overloading of lastGpsMagPass_ms is a little confusing.  You could name it something like "magYawResetTimer_ms", and add a comment here about how it's used to track how long the two conditions have been true: bad innovations, good data.

I was confused by this and had to prove to myself that it was logically correct, which it is.


Ок, учту. Во многих проектах к изменениям документации не такие строгие правила. Я нашел в том документи еще немного помарок,  оформить как PullRequest?


empd (jdwoods21) - x86_64-MacOS-10.9-clang: OK (1787 of 1791 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


better have the unicode type for name, as we might have international partners soon :shipit:


Done; whl's have been removed from the repo; make sure to git pull; we'll sort out hosting the files tomorrow.


I agree it would be more intuitive if this was a report level configuration. But, if we only totaled columns where `calculate_total` was true then this would make more sense to me.


更新好快…


Looks fine. Good luck with your test.


I think AddPrinTokens function below is good. I wouldn't export prinTokens.


Oh. Thanks!

tors 20 aug 2015 20:00 Jonas Eckerström <notifications@github.com> skrev:

> You can retrigger hooks in the hooks settings panel
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Softhouse/bearded-sansa/commit/6488e6fb3697776de432784a414cc04bb8542e06#commitcomment-12813440>
> .
>


Looks good.


Stuff


还有两个功能不满意，分别是公告的着色插件是支持全屏编辑内容的，但是还没做好，另一个是DataTables分组显示也没做。。。


Ah, and I think it's fine to have some initial hardcoded values like tpm/key, since we already make use of them in the tao package


chang Chang


I would remove this line and related lines (see the comment above about keeping tpm/key prins as defaults), and add a separate test in, e.g., DatalogGuard, that adds new non-default names and tests them in a policy.


has this been released?

```
[ERROR] Plugin com.github.siom79.japicmp:japicmp-maven-plugin:0.5.3 or one of its dependencies could not be resolved: Failed to read artifact descriptor for com.github.siom79.japicmp:japicmp-maven-plugin:jar:0.5.3: Could not find artifact com.github.siom79.japicmp:japicmp-maven-plugin:pom:0.5.3 in central (http://repo.maven.apache.org/maven2) -> [Help 1]
```


@joshbetz This needs an exit too.


建议给修改公告单独弄一个页面，只是个人意见…


Chang chang


Tim, can we close this now this dep is not here or does it have more value?


About CRotationMatrix44 it's not so easy to define. I will try to figure
out math which is needed to create rotation matrix from given angles.

About addition constant, I will try to debug it during weekend.

About CVector4 and parameters. It's not enough to rename spinbox3 to
spinbox4. I have to write quite a lot functions to handle 4D parameters.
ParameterContainer class is not prepared for it, there are missing
functions in SynchronizeInterface, and also I need to prepare animations
work with 4D parameters. I'm planning to do this but in next release.

Cheers

2015-08-20 0:28 GMT+02:00 mclarekin <notifications@github.com>:

> Both are interesting, try them and see. But first you intelligent young men
> have to discover why I can not get an addition constant for z.w to work. It
> does work in OpenCL but either i am missing a typo or I do not know enough
> c++ to find the bug.
>
> BTW, Another thing I could not do, was change the parameters names to
> CVector4 for the UI, so that i could have spinbox4 and slider4.
>
> Cheers
>
> On Thu, Aug 20, 2015 at 8:49 AM, Sebastian Jennen <
> notifications@github.com>
> wrote:
>
> > we could make a rotation with alpha beta gamma delta angle
> > and a CRotationMatrix44
> > with rotation logic from
> > https://en.wikipedia.org/wiki/Rotations_in_4-dimensional_Euclidean_space
> ,
> > or we can use quaternion properties to realize a rotation:
> > https://en.wikipedia.org/wiki/Quaternions_and_spatial_rotation
> >
> > Any opinions?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/buddhi1980/mandelbulber2/commit/7ed64240c4e721f2b151305f0b3739428b553d48#commitcomment-12794466
> >
> > .
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/buddhi1980/mandelbulber2/commit/7ed64240c4e721f2b151305f0b3739428b553d48#commitcomment-12796294>
> .
>


Yeah, that's what I planned to do once the CI was green


@falseen 从一开始就是单独一个页来修改公告的。


Good work overall. Nice clean code.


Great, exactly the fix I was looking for, thanks!


Yes, I was actually going to open an issue on that. My thinking was to get everything over to the shims and then use intptr_t/IntPtr throughout.


Oops
Example is wrong.

It should be:
(ryu-cli) installex /Users/takeshi/SDN/SDN-Work/COSCUP2015Workshop/hub_app.py
Install successfully


develop (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Sorry for my delay here I've been a little busy :) This looks good to me.


Just to match our project during submodule use... but prudent anyway, right?


no, this is not necessary since ng-repeat works fine with undefinied


fixed


Can you explain again why you are assigning `xhr` after the options were passed to `this.sync`?
The next line is `return request` which does not seem connected at all to this line.


can read outside buffer: (y-1)


You need to preserve the controller state across calls to LiSend*ControllerEvent. Passing 0 button flags makes all buttons go up. Same thing with analog sticks zeroing after pressing a button when you pass 0 as the analog stick state.

Most implementations choose to keep a controller context object/struct (or an array of them for multi controller support), update values in there based on new events, then pass the all controller state values to LiSend*ControllerEvent.


because active directory blocks us from installing anything


hoot


I see you're using Javascript, so discard the question about capybara and selenium, please.


Fixes #1


Thank you for this one, was about to do a PR, but saw it was fixed when I forked :)


Note: This is to support activeCollab v4.2.17


Given that this is a trivial change, I would suggest setting this up as a separate pull request so I can pull it.


Haven't tested this, but think we could rewrite it as something like:

    data.forEach(function(prod) {
        var prodName = data[prod].name;
        BugData.assignees[prodName] = {};
        data[prod].components.forEach(function(component) {
           BugData.assignees[prodName][component.name] = component.default_assigned_to;
        });
      });


发现你会的好多啊，materialize和DataTables我之前都没听说过。这个项目让我涨了不少见识，目前在看materialize的文档，希望以后能帮上你的忙。


This check appears to fail with a client using Prototype 1.7


how did the comma sneak back in here? I'll fix it...


Nice use of sessionStorage. :+1:


其实这个东西一开始我也是不了解的，例如一开始我不知道表格怎么排序，然后搜索，就找到了DataTables。


Please don't use real employee or company data in unit tests. I stick with imaginary users and tend to create a "story" of my unit test. See some of the other Test classes (maybe `GitTest`) for examples.


`if (!(bugObj.product in this.assignees))` or maybe `if (this.assignees[bugObj.product] === undefined)`


So, `$('body')` didn't work in some browsers?  Anyway, using `document.body` is probably slightly faster than the call the the jQuery function.


There will be a small conflict with this for my PR, I changed apollo to be speedcoder for the mongodb connection


Typo on "challangeBatch.js"


LGTM


Looks good to me. Tested on Chrome. :+1: