Document that this constructor sets `startingVC = null`


Not really, they're pretty sparse. I was on the fence about adding it but I feel like if the user is doing weird/hacky things with the socket, it could have been emitted already. I'd be up for removing it.


This comment should be removed and put into the overall comment about the sort at the top.


In this case it's not a regular expression, it's a browscap pattern placeholder - and there "?" means one character.


The comment doesn't tell you anything the comment above doesn't.


so typically, syntattically this looks best: (always have a space before the expect blocks)
```
it "searches AddressBook for Sussie" do
+       book.import_from_csv("entries.csv")
+       entry = book.iterative_search("Sussie")

+       expect(entry).to be_a Entry
+       check_entry(entry, "Sussie", "555-555-2036", "sussie@blocmail.com")
+     end
```


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 442](https://teamcity.labkey.org/viewLog.html?buildId=268988&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:34
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


"when considering quality" - that needs more explanation.  `convert_all_` - does that mean "when considering quality"?


Wow, we can do this?  Gret!


`startingVC` may be null


Added a "real world" example, after this.


Another regression has been reported: http://trac.cppcheck.net/ticket/6957


You shouldn't change the order of the conditions.  In particular, the comparison to `srcIssuer` might be quite a bit cheaper.


Should be per server. Also should be optional.

`send_data "PASS #{@server.password}" if @server.password`


What happened here!!


resolves #24


or the average of the two median elements


Hmph, what sort of "set" has an indexing operator?  :-D

(Beyond the scope of this review, `STPathSet` has never been a "set".)


btw, this also requires java 8
which means everyone who wants to run tests have to have java 8


It's like writing

    for (int i = 0; i < 10; ++i) {
        i /= 2;
        printf("%d\n", i);
    }

Which will loop forever since you are changing the loop index within the loop.

This bug was added with the change to use CUDA_KERNEL_LOOP, however it didn't manifest itself in practice as shown here: https://github.com/BVLC/caffe/pull/427#issuecomment-44092031


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.935.2a021d4719cd36acc67e66aa9063b13e72b0e2b4](http://build.palaso.org/viewLog.html?buildId=62190&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:05:08


1579840-GroundTemps (mmatts) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.5%25-red.svg)


Re-collapse these imports


Seems you have been mispelled for 'repalce' insted of 'replace'


Thanks, you're right.


Why `saZero`?  Why not just... `zero` and `one`?

We've basically gotten over the hungarian notation stuff.  It lives on in old code, but no reason to keep doing it?


fix pulled from http://mail-archives.apache.org/mod_mbox/incubator-zeppelin-users/201506.mbox/%3CCAFX-kxKR+1R11WoG69sa-63nwTcfT1VYFocJBywh6m0q72WqBg@mail.gmail.com%3E


This is here so I can see what it's targeting. It seems to find the correct target...


`convertAll`.


Fixes #67


...but then this finds an [Object object], so I'm confused.


why not? for(int i: list)


Ah, I put my Mackenzie-Buck joke in the pull request description. Please see it there.


This spacing is off


Currently I'm adding error prone to compile test/generated classes, this indeed is revealing `DepAnn`, `GuardedByChecker`, thank you for recommendation.
My bad is probably that I've used `GuardedBy` and alike annotations more as documentation tool and not much as static verification tool. The solution is simple though – add `Deprecated` annotations and remove `GuardedBy`.
Just to mention: double checking works for volatile fields in the presence of java memory model defined (>= jre 1.5). This works by imposing memory barrier on volatile read of bitset and acquiring lock only when needed to initialize the field, which itself is not required to be volatile to be properly observable under these circumstances. CMIIAW


Type parameter T is unused here


cast to String. what for?


Any message from UpdateAssemblyInfo at compile time?


Double cool!!!!!
On 28 Aug 2015 20:26, "Curtis Rueden" <notifications@github.com> wrote:

> You can find them all as follows:
>
>    - Open the Problems view (Window > Show View > Problems)
>    - Click the little downward white triangle on the upper right of that
>    pane
>    - Choose Show > "Errors/warnings on selection"
>    - Click the white triangle again
>    - Click "Configure contents..."
>    - On the right side, under Description, select Text contains and write
>    "Override" in the text field
>    - In Package Exploerer, select the top level of the
>    Colocalization_Analysis project tree
>    - Now your project view shows all @Override opportunities!
>    - Select them all in the Problems view
>    - Right click, choose Quick Fix
>    - You should see "Add missing @Override <https://github.com/Override>
>    annotation" as the selected fix
>    - Click Finish to do it
>    - Now all your @Overrides have been added
>    - Click the white triangle again in Problems view
>    - *Remove the "Override" text from the Text description filter!!!*
>    Very important to avoid accidentally hiding other errors/warnings later.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chalkie666/Colocalisation_Analysis/commit/7a42ae5e02ed7666dad3dd4affa195106a89ac63#commitcomment-12953707>
> .
>


@Snkz


It's not just that we keep doing this operation, which I have to read carefully each time to see it's exactly the same - but that it's also a little expensive to construct these STAmounts just to compare something to -1, and to compare (in this case) `saDstAmount.issue()` to itself.


Please add a space before the !important


This new method appears to be unused. Either delete it or add full documentation and tests.


we have `== zero` and `!= zero` for this if you like...


Octree (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (1777 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.01%25-yellow.svg)


Note that this is always != NULL.


Does this work in VS?  We had some troubles with... something like this, I don't remember.


Should look like this if all goes well:
```
Updating version number... updating version number to 3.4.8.230 0b47a62fbfac9892ca25abe3256e0338f25bbec8
```


You need to remove credentials from the github.
I was able to access your database yesterday with the credentials that are public here.


Do we not have a line-height variable we can use here?


I was just planning to discuss each usage of lighten/darken while reviewing the code.  I didn't feel like they needed an exercise to cement it.


This is an attempt to rewrite the Elm Core Dict module using `(Ord {})` instead of `comparable`. This would allow us to use dictionaries having `(Ord a)` records as keys.

I haven't been able to compile this code. `elm make` freezes when I try to compile this.


foreach


I'll expand the explanation on line 201.


Ah, k, gotcha.


Hmm. Tutorials are a thing. I always forget about that.


Wrap these in `UnmodifiableMaps` at the end of static initialization?


If I understand this stuff correctly, Platform.LOGGER.debug will log immediately. Just above this is the WriteLogger thing, which ends up calling Platform.LOGGER.debug after the operation completes, which in this case is after the socket sends the SYN_STREAM frame. I'm not sure you want to mix these two mechanisms -- if the write takes a long time to complete, your logs will have a bunch of headers with no context. Can you join these two together?


Should this line be moved to between 84 and 85 since you're not using the klass variable except when ost.method_name is "scan_metadata" ?


Yeah, that's what made me to think of the control on the `data-admin` side (via ModuleDeployer). But at least now I understand it can't be of that way :-)


Thanks :)


About the kind name(Functions), you use plural form.
As far as reading other parsers, singular form is used.
Following code is taken from ccs.c.

```
static kindOption CssKinds [] = {
	{ TRUE, 'c', "class",		"classes" },
	{ TRUE, 's', "selector",	"selectors" },
	{ TRUE, 'i', "id",			"identities" }
};
```

Could you consider to use  singular form for names (not for descriptions) if you don't have strong opinion about the form.


Please update the indenting to use tabs (This may also require changing settings in your editor).


well, my reading of it is that doesn't


you better to learn something about log4j


Same indenting issues with this section.


The class mentioned here (`GATKVCFConstants`) does not exist in hellbender.


perhaps it would be better to figure out a "has serializer class" semantic


1784-HPWHRemove (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


+1 for comment above, my read-only fields with custom html are now broken


Same for this.


It's more readable to include a space between `none!important` like `none !important`. Thanks


Use javadoc-style links to the classes being mentioned.


Sorry for the confusion: I don't have the paid service, so I can't test it on an actual device. I can run it on a simulator. With iOS 9, you will be able to run your own apps on your own devices with the free account.

As for xcassets images: the only ones I haven't migrated are the parchment, the save button, the URL button, and the glulx and zcode icons. And the Frotz icons and launch images, as they are already in the xcassets folder in one form or another


It seems to me only the first check is necessary. Am I missing something?


return (count == 0) : "true" ? "false";


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 443](https://teamcity.labkey.org/viewLog.html?buildId=268991&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Snapshot dependency failed to start: LabkeyTrunk :: build Build time: 00:00:01


o yeh, i have not seen the & operator, sorry. Only the first check is necessary. I will remove the others two before commit


This rule should be in the input-header section of this file. There's already a rule to assign a `line-height: 1.25em;` in place. Is this more significant than that?


`Utils.dupChar()` instead of this `Strings` class from `joptsimple`?


Anything that you can do to provide a screenshot or view of what tool you used what it looks like, the shape of the REST call (headers, POST vs. GET?)


you better to use IDE autogenerating equals() and hashcode()


One more comment.

You use upper case in the initial characters of names and kinds.
The most of all parsers, lower case is used.
(I don't talk about camel case in multiple words. Just about the initial characters.)


Nice :) I like what I see :)


The "Deploy to Azure" button could be added to jim's repo at the top

[Deploy To Azure](https://azure.microsoft.com/en-us/blog/deploy-to-azure-button-for-azure-websites-2/)


this doesn't work if a different executable tries to construct a PendulumWithBotVis from a different working directory (which is what happens in python)


If this change is purely for design reasons, I actually think the old design had some advantages over new new one.

If we look at the things we expect to vary by project vs the things we expect to vary by service, the old design made a clear distinction between them.  `working_dir` and `filename` would always be consistent for a single project, where as `service_name`, and `service_dict` would change for each service. So we can use the `ServiceLoader` to hold the settings we expect to stay consistent between services, and only pass around one object instead of all the settings.

We may not have used it that way, but I think we could (maybe should) have.

Does the change to validate external configs break this idea?


I assume the ability to do this ("close without closing the underlying writer") is no longer needed?


@jozic ideed kamon is builded with java 8 with this [travis-config] configuration but when release it we use this settings in order to supports [java 6] and above.

[travis-config]: https://raw.githubusercontent.com/kamon-io/Kamon/master/.travis.yml
[java 6]: https://github.com/kamon-io/Kamon/blob/master/project/Settings.scala#L28


CLI tests pass on Linux


that's exactly the += for. It should be handle late while there are both employee role and consumer_role. I will wrap up another commit to implement the has_active_consumer_role? and has_active_employee_role? methods


An intro that "draws me in" and what do I get out of this case study if I continue reading/doing?


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.87%25-red.svg)


Don't be overconfident -- "we **should** explode here" :)


ARM has been around for some time (sept 2014 at least), it's ARM templates that are new, as are new Resource Providers. the ARM Template engine is another "application (1st party)" that can use templates to do magic - but in the end, it calls the ARM REST API, Template engine handles 'state' - dependency, etc. - another workflow engine.


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2286 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.57%25-yellow.svg)


Why move this to `initialize`?


develop (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Absolutely trivial, but could you delete the extra blank line here?


Fair point, I'll make a change.


Add a test case that can detect the sorting issue in `genotypeQualityFromPLs()`


Makes sense. I was trying to be clever and save a line.


should this maybe be done with some globbing pattern (`computeShader*`) to catch any future added examples?


TeamCity pull requests :: netty [Build 145](https://garage.netty.io/teamcity/viewLog.html?buildId=929&buildTypeId=pulls_netty&guest=1) is now running


You should rename the key instead IMO. Otherwise it's confusing if you're using a singular key and get an plural translation.


Could follow the jQuery route and do something like `one`? I prefer that, but was kind of trying to match the current event naming style.


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Same as above


Rename key


nit, capitalize Hive probably


Please give force a default value of false, and a more clear name like "shouldReconnect"


I think this is ready to go. Going to create a pull request monday.


Magic is correct. :sparkles: In all seriousness the code is placed within a Houdini object within the Houdini editor. We just copy pasted it for submission.


tank u


Can't this be done when initializing obj_end instead of doing it in the loop?

Does this fix apply to the serial collector?


"This Action Keyword has already been assigned to another plugin. Please chose a different one."


Use easy-to-read bit.ly urls or don't use bit.ly at all :)


The fact is that the second constructor is not even needed to display the bug. Even without it, the compiler will throw a `NullPointerException`.

Example:
```java
public class Testing2 {
    public Testing2() {
        this(Strings::new);
    }
}
```


:tada: :tada: :tada:


Capitalize "Action Keyword" for consistency with other translations.


Totally understand.  I think it needs to be here for this test to pass in it's current form.

There is a potentially larger question about how we should be handling paths to urdfs, etc.  Alll of our code right now (in matlab, too) requires that either an absolute path gets put into the code, or that it's in the current working directory.

Are you requesting that we put a global path to the urdf into this c++ code (by somehow extracting the project root from cmake in the cpp at compile time?)  or something else?


Since this was extracted from CocoaPods we should **also** retain the original copyright which includes Eloy and Fabio who predominantly wrote this feature.

https://github.com/CocoaPods/CocoaPods/blob/master/LICENSE#L1


upper case is for constants


Added some more information about this project, with details and highlights of how it works and it's features.


@cnaude Is there any way to optimize the OnPlayerQuit event any further with your fork?
![link](http://i.imgur.com/HpsxAQu.png)


I consider doing any work in the constructor a bad idea. I think this is actually more concrete than just a style preference. It makes testing the object a lot more difficult.

With this change you can no longer create this object without calling all the logic in `resolve_environment()`, which means you're required to provide the full environment up front. If your unit test doesn't care about the environment you now have to provide a bunch of extra boilerplate for no reason.

You also can't test `resolve_environment()` in isolation any more, you're forced to test it with all the other constructor initialization logic.

I would go so far as to say a constructor should never do anything beyond simple assignment, but I will admit that strong of a statement is crossing over into personal preference (and the existing code would have already violated that).

Instead of doing work in the constructor, I think factory methods are the way to go

```python

@classmethod
def create_service_dict(cls, ...):
    service_dict['environment'] = resolve_environment(service_dict, working_dir)

    cls(service_dict, ...)
```

This way:
* you still have a clear interface for doing all the work together
* you can test each piece of work in isolation (a true unit test)


cannot


Regarding en.xaml:

IMO this file needs a massive overhaul in punctuation to make it look more professional. Not entirely sure if that fits in this PR or should be done separately.


why don`t you use parse date with DateFormat.class or something like this?


That´s a good idea Andrey!


@PilzAdam I just tested this and it is completly wrong, as long as you tell the compiler to optimize a little it will even generate the exactly identical assembly code

http://irc.minetest.ru/minetest-dev/2015-08-28#i_4379979


bad names for params


What kind of error? See [here](https://dev.mysql.com/doc/refman/5.7/en/comments.html) for the MySQL reference.


I really like this guide and translated it to Turkish. Feel free to reference:
https://gurkan.in/belgeler/linuxda-masaustu-guvenligi/

Thanks for writing such a good guide!


Note that `test_pmi2_simple_model.py` fails now because it tries to call this function.


GitHub issues are good, because they're public which is nice. @noonhub is working on it.


teste


Yes, most of the `db-helper` functions are MySQL-only (:+1: if you want to add support for PostgreSQL). However, we use the [dump](https://github.com/killbill/killbill/blob/e9655b2f35b3152235770cc350269002261e8222/bin/db-helper#L51) option to generate the DDL that is then uploaded to our [docs](https://github.com/killbill/killbill-docs/blob/gh-pages/0.15/ddl.sql). That DDL should work across MySQL, H2 and PostgreSQL.


this refactoring code (CMD+ALT+L WebStorm)
tabs->space, etc...


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


develop (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2300 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.16%25-yellow.svg)


Need some sort of intro as to what I get from reading this case study. the Elevator pitch and what I'll learn, etc.


I don't like having a password involved, but apparently you can't export private keys into one of these .pfx certs unless you have either a password or some domain identity (e.g. redmond\roncain).  It is currently hard-coded to "test" until we find a way around this.


I just changed those. xD just forgot to mention, and now u revert them. lol


I guess we differ on design philosophy here. I would always opt for a module level function over a class method.

Module level functions are inherently more re-usable you don't need to instantiate a class (which has it's own set of dependencies) to use them. They're also easier to refactor because all their dependencies come from arguments instead of from attributes on self.

The only change I'd really make here would be to return env, instead of mutating service_dict. That way the function is immutable, and you can let the caller deal with env any way they want to.

I acknowledge this is mostly a philosophical argument, but considering the change was made based on only a philosphical argument, I think that's ok :)

We should probably discuss this some more, so we can try to find some common design ground.


BG


bg


How does this work :\
Does the AF not supported by the binary you're launch just silently fail?


I was pleased to see this work, but now turns out to be a pretty new feature. It's updated. Thanks for review!


wait.. ?
but the ports are normally always free, per :

             http_port=get_free_port(),
             admin_port=get_free_port(),
             meta_port=get_free_port(),
             udp_port=get_free_port() if udp_enabled else -1,

you got a case where one of such port wasn't free when the server is started ??


We mustn't rely too much on compiler optimizations. I propose keeping it as `++i`.


I am a nice comment


some kind of pic showing the basic what runs where view would help i think. there's really not that many moving parts but there are key flows that are happening and the platform services that are being used in a normal manner from what i gather. the simulator CLI tool - there are several sample telemetry generator tools i think in the EventHubs samples - is it based upon that or unique - if the latter, then is it something that could be generalized and schema/config driven to generate telemetry data?


> Hail to anyone ~~updating~~ **fixing** my beloved Naxxramas or Blackwing Lair raids!!

Fixed that for you!  :stuck_out_tongue:

We don't want to encourage people to do silly updates that break more than they fix, do we?


Very cool - always cool to see little people like ants roaming around on a map.


Does the daemon just silently fail on the AF it does not support? Cause you need to run a tac_plus and tac_plus6 right?


This is really nice touch.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.457.d18d57e8e962130a97fd33af1f88e47c264ae383](http://build.palaso.org/viewLog.html?buildId=62191&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3354, ignored: 134 Build time: 00:11:16


This is a very __`BAD`__ practice - you moved the __SECRET KEY__ from `settings.py` into `.travis.yml`, which means that it still is accessible in the code!!! If the secret key is to be kept, well, secret, it needs to be removed from code completely, and setup as env variables on all machines that run the project. Travis allows setting env variables for builds via the settings option.


Just a question about the -B usage ... I don't quite get how that works ...


It breaks make , can't find boolean com.android.internal.R.bool.config_proximityCheckOnWakeEnabledByDefault


helo


That seems like a strong assumption without a check.  Otherwise I think this is a fine approach.


Sounds to crazy to me;)
I would prefer to keep `Package´ and other abstract elements as clean and
simple as possible.

So I would go with comments, and in case of any need of polymorphysm I
would make ´extend´ manually.
28 sie 2015 14:09 "Konstantin" <notifications@github.com> napisał(a):

> It sounds crazy, but what if inherit Package from HTMLElement.prototype,
> so juicy-tile-list still will be able to inherit from Package.prototype
> or manually copy Package.prototype to JuicyTileList.prototype?
>
> Otherwise I could add comments in the source file and readme, that
> juicy-tile-list is no longer inherited from Package.prototype.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Juicy/juicy-tile-list/commit/503198c23ecf6f5dfcb7c82e57824816828b8a1b#commitcomment-12946449>
> .
>


CLI tests pass on Windows


This commit fixes two issues. The first is the back button on mobile. The second is the native handling of forward and back. It is now ignored and up to the developer to implement.


I tested it in clean environment. Now it looks ok.


Good point; I'm not sure what I would want. We could use a `#define` in the CMakeLists to stick the global path into the file at compile time, or we could write something like pods_get_base_path() to point to the drake root. Or maybe there's a better solution that I'm not thinking of?


Less readable?  Look how beautiful this is!


I'm sure I don't understand all of what is going on but I was surprised to still see VmOrTemplate in here several times.  Also surprised (or should I not be) that I can't find any reference to these methods (*_update_op) that still use VmOrTemplate.  I guess this code is still in use and I can't find how its called?


What's up with this indentation?


:trollface:   There is one!


you can safely substitute this code with:
```python
import os
os.environ.get('SECRET_KEY', None)
```
and django itself will complaint about missing SECRET_KEY if the env variable is not set.


A trollface, not a copy.


We are getting some failing here (both on mac and fedora):

options/validate__exclude_nodes: [forking]
  FAIL src/test/test_options.c:798: assert(mock_saved_log_at(0) OP_EQ "You have asked to exclude certain relays from all positions " "in your circuits. Expect hidden services and other Tor " "features to be broken in unpredictable ways.\n"): <Country code 'uk' is not reco
gnized.
> vs <You have asked to exclude certain relays from all positions in your circuits. Expect hidden services and other Tor features to be broken in unpredictable ways.
>
  [validate__exclude_nodes FAILED]


This should, ideally, be defined. This is not a widely understood term.


yes, should I say that?  It seems like that's the definition of median.


Could you post an not working example? Because the [clock-widget](https://github.com/sdorra/adf-widget-clock/blob/master/src/clock.js#L36) uses a default config and it works.


Oops, I meant to name the commit version number bump but failed somehow. My bad.


ref dmn11-123


oh, ack, that snuck in here from somewhere else.


This commit disable the content in the red boxes below:

![image](https://cloud.githubusercontent.com/assets/4420550/9555000/306c1720-4d98-11e5-800f-29fffcf5b0a8.png)

I commented out those features because currently the roles in teams are hard-coded and can only be "programmer", "manager", "tester" and "doc-writer". This may confuse students since not all the assignments are coding assignments in this semester.


@sfan5 debug builds hate you!


I removed the method that allows it.  It didn't seem like it was being used for anything other than this test.


> you got a case where one of such port wasn't free when the server is started ??

Yeah. All the time. It got to the point where one out of 4 builds would fail on Travis.


the code coverage tool and report generation should be run only when the build succeeds, never when the build fails. So the report generation should be moved to the `after_success` section


@coolharsh55 I tried setting up an environment variable, and it didn't work. Can you try?

But personally, I think, there is nothing wrong with this. I saw [cookiecutter-django](https://github.com/pydanny/cookiecutter-django) doing this and it makes sense because we are not using this in production.


Updating master with mods in gh-pages


typo!
```python
except RuntimeError, e
```


HTML runners pass on Windows
*except* that the fullOpt versions fail 1 test: "Emitted classes should have a meaningful `name` property". But that test should not be run in fullOpt. It's just that the appropriate flag is not set by the HTML runners. We can fix that later.


Aplicar margen desde la vista, no en la customizacion


OK, will take a closer look! In any case, I plan to do some more performance testing prior to merging this PR.


First comment.


No problem, I just saw the change and was like "Woah, thats gonna break stuff!"... lol


Reducir codigo:
border-width:
border-style:
border-color: top right bottom left


Good catch, that should be Guava `String.repeat()` but we can use dupChar instead.


heh


Yeah rookie mistake on my part


hmmm .. then that would mean that the travis environment is shared (for the network resources at least) with multiple builds but that strikes me :s

what if you add a little sleep before starting the server ? (so to be sure the ports taken with get_free_port() are well released at the OS level).


Hmm, I think I missed something here - I was almost certain that I'd verified that it bound to a tcp46 socket - but now I come to re-check, it doesn't. You're right.

Is there a reason not to use a dual stack socket vs. a single one?

In the context of it binding to single-stack sockets - you're right, this makes little sense. I'll need to refactor it. Apologies.


I also wouldn't put it in the gemspec since it's not required to run the tests... but hey you're not alone and there is hope! https://github.com/rails-api/active_model_serializers/pull/1017/files#r37602184


Looks good! Want to put this down at the very bottom of "Usage"?


:+1: Gooood call!

(If you want, you could always change the look / colors or whatever.)


fixes hang on start

2015/08/28 19:06:53 [notice] 9568#0: nginx-clojure/0.4.2
2015/08/28 19:06:53 [notice] 9575#0: using the "epoll" event method
2015/08/28 19:06:53 [notice] 9575#0: nginx-clojure/0.4.2
2015/08/28 19:06:53 [notice] 9575#0: nginx/1.9.4
2015/08/28 19:06:53 [notice] 9575#0: built by gcc 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)
2015/08/28 19:06:53 [notice] 9575#0: OS: Linux 2.6.32-504.16.2.el6.x86_64
2015/08/28 19:06:53 [notice] 9575#0: getrlimit(RLIMIT_NOFILE): 1048576:1048576
2015/08/28 19:06:53 [notice] 9576#0: start worker processes
2015/08/28 19:06:53 [notice] 9576#0: start worker process 9577
2015/08/28 19:06:53 [notice] 9577#0: ngx clojure: init pipe for jvm worker, fds: 7, 8
2015/08/28 19:06:53 [error] 9577#0: too low version jar of nginx-clojure, we need at least 0.4.2, but meet 0.4.1
2015/08/28 19:06:53 [error] 9577#0: can not initialize jvm memory util
2015/08/28 19:06:53 [error] 9577#0: jvm start times 1
2015/08/28 19:06:53 [notice] 9576#0: signal 17 (SIGCHLD) received
2015/08/28 19:06:53 [notice] 9576#0: worker process 9577 exited with code 2
2015/08/28 19:06:53 [alert] 9576#0: worker process 9577 exited with fatal code 2 and cannot be respawned
2015/08/28 19:09:00 [notice] 9576#0: signal 15 (SIGTERM) received, exiting
2015/08/28 19:09:00 [notice] 9576#0: exit


sync frameworks/base
On Aug 28, 2015 12:18 PM, "Batsilos" <notifications@github.com> wrote:

> It breaks make , can't find boolean
> com.android.internal.R.bool.config_proximityCheckOnWakeEnabledByDefault
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CyanogenMod/android_packages_apps_Settings/commit/c76590935162a5fcc490a0808ac207259e3dc386#commitcomment-12954755>
> .
>


No real policy on asserts. Usually, more asserts are good, but in this precise case, I fail to see the value of it.
I also don't see how the kwarg makes anything more convenient since it only allows you to call the function without argument, which is an error.


The URL won't download. Is this package "alive"?


> what if you add a little sleep before starting the server ?
https://github.com/influxdb/influxdb-python/blob/c315bf15a73f1fea0868bd66fa41c2d637cf9c2a/influxdb/tests/misc.py#L18


does the test pass if you simply replace agegroup by compute_agegroup?


I just made a note that optional readings are italicized for those not good
with the color red. I suspect they already figured that out on their own.

On Fri, Aug 28, 2015 at 12:27 PM, Michael Ball <notifications@github.com>
wrote:

> [image: :+1:] Gooood call!
>
> (If you want, you could always change the look / colors or whatever.)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cs10/fa15/commit/a27092f78f15178a62588ce83e8827ba4ed4056a#commitcomment-12954932>
> .
>


oh, np then ;-)


There are chances that we get the same random port two times... Maybe it would be worth testing.


TeamCity pull requests :: netty [Build 145](https://garage.netty.io/teamcity/viewLog.html?buildId=929&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4759, ignored: 21 Build time: 00:29:07


Haha, to be honest I actually don't remember why this name came up. :-)


I am a nice comment


damn.. yeah then I can only guess that the localhost network interface(s) in a build is shared with others builds that would some time to time re-use the open ports we discovered with get_free_port() ..  but that really strikes me :s
unless if you have another explanation..


Incluir estilos dentro del class **table**


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.81%25-red.svg)


Yes, I think so. It's only needed in that block of code, and that block of code is a hack - that should be removed someday. Keeping all the hack code in one block will make it obvious what needs to be removed.


Current views:

Smartphone:
![mobile phone aug28](https://cloud.githubusercontent.com/assets/3407469/9555256/e78b2d3c-4d99-11e5-9357-9bc04679c086.png)

Tablet:
![tablet view aug28](https://cloud.githubusercontent.com/assets/3407469/9555265/f05bcaf2-4d99-11e5-9d91-ee90182ca3eb.png)

Normal desktop screen:
![normal screen aug28](https://cloud.githubusercontent.com/assets/3407469/9555274/f908b502-4d99-11e5-9ccb-6ebcade60bc5.png)


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.477.d18d57e8e962130a97fd33af1f88e47c264ae383](http://build.palaso.org/viewLog.html?buildId=62193&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3317, ignored: 138 Build time: 00:25:34
### Failed tests
```
Palaso.Tests.dll: Palaso.Tests.Progress.ConsoleProgressTests.LongRunningMethodUsingConsoleHandler_ProducesLog: <no details avaliable>

```


Yes! thanks. I'll do this.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 444](https://teamcity.labkey.org/viewLog.html?buildId=268994&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:00
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


No.


s/scale/translate/


>  build is shared with others builds that would some time to time re-use the open ports we discovered with get_free_port()

I don't think so. Travis builds have individual containers. I can't be sure tho.


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (754 of 754 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-8.0%25-green.svg)


cool. how `JitFunction` works?


This was a copy&paste from the original stackoverflow question, but as long as the single letter does not change I expect that no backward incompatibilities will exist... right?


We could add a `SpecialTileType` that only includes `CAMERA` and `PICKER`. That could then be the annotation for the constructor


Fails on my Mac. Works on my Ubuntu VM.


hey, congratulations, had made that fix in the man page last night for the smxi.org change, but hadn't committed it yet.

However, note that your change is actually incomplete, because inxi.1 is the source of inxi.1.gz and inxi.1 and inxi.1.gz form a part of the inxi.tar.gz file.

And inxi.1.gz requires a specific compression to be debian acceptable: gzip -c -9 inxi.1 > inxi.1.gz

now you know.

But I'll do that part for you.


Hmm, it seems that it became impossible to set nil to an optional Observable, as it crashes inside value setter. That, and creating generic protocols are making me scratch my head today.


They are removed, see [this commit](https://github.com/BuZZ-dEE/language-svg/commit/5cd80aa58eda21319fa92b58cdb246e6043f3111) or required to rewrite the history?


Octree (DeadParrot) - Win64-Windows-7-VisualStudio-12: OK (1777 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.01%25-yellow.svg)


I believe we should mock `geoip_get_country` in this test.


@ldgauthier  The assumption of normalization or the assumption of sorting?


Eh, why remove the mention of NanoTrasen from the decription of traitor gamemode?
If we actually move away from NT, wouldn't the entire gamemode description be rewritten?
I kinda preferred "NanoTrasen" there to "The Company". Maybe replace it with [company_name]?


I also changed the description URL, see [this commit](https://github.com/BuZZ-dEE/language-svg/commit/5cd80aa58eda21319fa92b58cdb246e6043f3111).


Thanks @masatake


It's actually `rollbackAttributes` (plural) and we can remove the `isNew` check since `rollbackAttributes` will either rollback or delete depending on `isNew` state on its own.

http://emberjs.com/api/data/classes/DS.Model.html#method_rollbackAttributes


Max found that the wrong AMI was in use here, it's unrelated to the python changes


Mentions don't work in README.md :see_no_evil: per https://github.com/github/markup/issues/209
In any case, thanks @muchweb for HTML-Marquee!


What if we just merge it into the comparison? eg: `iter++ != m_buttons[i].ids.end()`, would that work (better)?

`The postfix increment ++ does not increase the value of its operand until after it has been evaluated.`

the only reason i could think of not to do it is that it could be confusing for people who don't know about it.


I get an invalid reference when I try to solve a problem after reading a roadmap from a file in hpp-gui. In the process of reading a roadmap, a new roadmap is created, and a reference to the distance is passed. I guess there is a copy of the shared pointer somewhere instead of a reference. I did not look in that direction.

The weird thing though is that I got this bug in hpp-gui and has not been able to reproduce it using only python scripting even though I'm doing the same calls...


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.453.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62196&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:16:01


Ya, this popped up as a conflict.  Why?  Sry, if it messed somtin up.


lgtm


This is a little opaque to me. What does it mean to set intArray to _?


The idea of JitFunction is rather simple: codegeneration+compilation+loading. The tricky part was doing this crossplatform #1528 . The way I do it now is by statically linking in clang and llvm into the plugin.


э.ээ


I removed it by [commit](https://github.com/BuZZ-dEE/language-svg/commit/25d349367260df8bd77cfa8dd3b60d607183a0c2).


yaptığın iş mi lan


efendi ol birleştir


@mpalmi


Updated project features and how it works


Yeah, but it's always good to do the little stuff.

ᐧ

--
Michael Ball | michaelballphoto.com

On Fri, Aug 28, 2015 at 12:29 PM, joshHug <notifications@github.com> wrote:

> I just made a note that optional readings are italicized for those not good
> with the color red. I suspect they already figured that out on their own.
>
> On Fri, Aug 28, 2015 at 12:27 PM, Michael Ball <notifications@github.com>
> wrote:
>
> > [image: :+1:] Gooood call!
> >
> > (If you want, you could always change the look / colors or whatever.)
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/cs10/fa15/commit/a27092f78f15178a62588ce83e8827ba4ed4056a#commitcomment-12954932
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cs10/fa15/commit/a27092f78f15178a62588ce83e8827ba4ed4056a#commitcomment-12954961>
> .
>


Indeed! In fact, the method reference doesn't even have to come from a class that exists!
```
public class Testing3 {
  public Testing3() {
    this(Foo::new);
  }
}
```


Looks good.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 445](https://teamcity.labkey.org/viewLog.html?buildId=269003&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:36
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


cartridge spawns as well if a player inserts a new game


Done: 556390d


why snapshot is the first one to be tested?


@bbatsov, is this line right? I'm getting an error here: Debugger entered--Lisp error: (void-variable client-conn)


Nice


this relies on a few other operations on backend, for example forcecommit.


this test flow is not that obvious. You have done quite a lot tricks in here. Can you please write a few comments?


Is anyone else having issues with the code in chapter 3? Specifically in "colorGenerator", I get an "Invalid Object" error


Can you change this and the other variables to be your information.


Please just use "Computer Information Systems", or "Computing" in your case. Leave off the "major", and put that in the message string.


@georgekola because both NSOutputStream and NSInputStream are not thread safe. They could only be used from the thread of their event-loop. We already had problems with write from other thread that became blocking during some circumstances, I think that the 10 second thing that we are experiencing might have similar reasons.


very cool.


why are all the diff tools doing so badly at diffing this file? It looks like a lot of code has stayed the same, but github, meld, and Kaleidascope can't seem to recognize that.


Wouldn't something like:
```C
const char *fmt = upcase ? "%hh2X" : "%hh2x";
sol_buffer_append_printf(&buf, fmt, uuid.bytes[i]);
```

be simpler, I wouldn't call this code performance sensitive enough for needing the hand rolled version.

Or am I missing something?


If you init `uuid_str` ( `= { }` for example), you wouldn't need this.


Your message format is correct according to the original Ex 1 Introduction statement in the PDF, but look at the assignment description here, which is in the correct format: https://github.com/unioncollege-webtech/introduction#description


i hope we can make this as clear as possible not try to minimize the lines of code. So I would like to see newBackend -> newBatchTx


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1813 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I do not even know what do you mean by cleaning up a BatchTx without reading through its implementation.


interesting, how does this fly as a `swig_storage`?


oh here, nvm, last comment.


Aha! Kaleidoscope --> Ignore Whitespace FTW!


Ship it!


> I don't think so. Travis builds have individual containers. I can't be
sure tho.

I was rather sure about that too.. but I don't see what could be
eating/using the free ports obtained the way it's done here.. if we are
really in a container (with own network namespace) then I really don't see
what could do that :s damn.

2015-08-28 15:33 GMT-04:00 Alexandre Viau <notifications@github.com>:

> build is shared with others builds that would some time to time re-use the
> open ports we discovered with get_free_port()
>
> I don't think so. Travis builds have individual containers. I can't be
> sure tho.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/influxdb/influxdb-python/commit/78e5adad441767361bcc1a85393140a984394f1a#commitcomment-12955013>
> .
>


well... we need to make sure this will not block...


me wonders what could be done with this and S3.


Awch, I hope that didn't bite you too hard!


This is uneeded


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 446](https://teamcity.labkey.org/viewLog.html?buildId=269014&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Snapshot dependency failed to start: LabkeyTrunk :: build Build time: 00:00:00


Please stop spamming commits get git


Copypasta from `gen_rrtype_to_str`? 4 should be 5 in this function, since "CLASS" is 5 characters, right?


If you want cleaner diffs for this file, you might look commit by commit. The last commit was a refactor for how we exported things to dashboard, the previous commit(s) are where we changed some of the clicking/minimizing naming/logic.


this is unclear. as i said, let create a backend.


Why is "placeholder" passed around everywhere?


i am not sure why do we ever need to copy file.


Exactly :)


of course loading a file should also be tested, but for testing the various aspects of the elevation behaviour it might be easier to be able to define raster maps as part of the scenario? something along the lines of:

```gherkin
Given the raster file
	| 0 | 0 | 0 | 0 | 0 |
	| 0 | 0 | 2 | 5 | 9 |
	| 0 | 7 | 2 | 5 | 9 |
	| 0 | 7 | 3 | 0 | 9 |
	| 0 | 7 | 7 | 0 | 0 |
```


We are working on writing a macro


Have you tested the "castandrole" part? Because the KODI document says that they must be separated with `|`. ([#ListItem-setInfo](http://mirrors.xbmc.org/docs/python-docs/15.x-isengard/xbmcgui.html#ListItem-setInfo))


Final commit to change the variable names is now in place.


forncendo

fornecendo


We will change this to allow { appdomain -untrusted_app_noexecute } self:process execmem; and see how that goes.


Hi Jakeii
I ma using your woocomerce pesapal plugin.Unfortunately I am getting this error whenever I try to head to the checkout,do you know what might be the problem?

Problem: parameter_rejected | Advice: invalid_value_amount_exceeds_limit> oauth_parameters_rejected | 1900

This is the website....http://www.tshirtrepublique.com

Looking forward to your humble assistance.

Kind Regards


Did you test this against TS 1.5? I'm getting "Index signature is missing in type '{ flex: string; backgroundImage: string; }'." due to this when running the react-addons-tests.d.ts (after adding the indexer to react-addons.d.ts, which was missed in this commit). In TS 1.6 get the same error unless I use `[propertyName: string]: any;`.


Just in case you don't know: you can instead write `{Name: record.data.Name}`. JS doesn't require quotes for key names that contain only alphanumeric and _. Can look a little cleaner, but it's all the same.


We'll get rid of the auditallow as it's not directly related to this commit


@HelenaSabel Here's an XSLT identity transformation done with a new, simple built-in rule with XSLT 3.0: check it out! :-)


We're working on eliminating the need for this python script.


@SauloSilva vou dar o merge, ai só essa palavra para consertar beleza?!


Thanks! This was what I've been looking for hours!


Related to my point above on removing the distinction of a "program file" and a "module file", removing the requirement of writing `package foo.bar` will make them indeed syntactically the same. Either way should be fine. But personally I prefer less boilerplate.


I don't know if anyone has tried Electron on Vista, but Vista shares the same kernel with Windows 7 (both uses NT 6.x), so it should be safe to assume Electron works on Vista.


We did think about this before embarking on the implementation. The thing is, we wanted to prototype a useable module system quick, and having a `main` entry point seems to involve more work. But this is definitively a worthy avenue for future hacking. If you feel needed, take it on :)


Already fixed. See dbe8977


, jbkjb,b mbkj


@srisurya95 isn't it arm64?


what kind of perf improvement ? IMHO we shouldn't bring this. Any further bug fixes etc. to others will be hard to manage on this.


按钮组合并


add landscape


真的可以用了，楼上厉害！


I don't think you can do this:

1) In the examples pom files: the version you removed just *happens* to be the same as the parent. It serves as an example for people building modules and (as with all our real modules), the module version is different from the parent pom's version

2) If you replace the explicit versions in the parent poms with ${project.version}, then people who build their own projects (say with version 1.0-SNAPSHOT) and use our parent pom (say 2.2.4.35) will get (non-existing) 1.0-SNAPSHOT artifacts pulled in.

I may be wrong, but I think that's how it works, no?


@jkeung (Jason):
Great job on these exercises!


确定


Validating the presence of the created_at and updated_at columns causes validation errors.


There seems to be two query method for `findOneWithEagerRelationships`, cant we just keep the one with `Optional` and remove the other?


We removed topic_id from the polls table.


@fx2323
Good job!  Emacs all the way!


@fx2323
Great job!  good commands & explanation of xargs.


93651760-RowPerObjectReport (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-44.56%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


@mrdoob

> BoundingBoxHelper is no longer needed?

You can merge the functionality if you want. However, I prefer the `BoundingBoxHelper` API.
1. It takes a hex color as an argument in the constructor.
2. It does not require an argument to its `update()` method.


you need to indent the call to m.find...
if ...
<indent>m.find...


@agatorano
Good job!
I also like for command line:
>  ls -Glp


It's an old style habit that was designed to avoid expensive copies of iterators.  It was designed especially for this situation.  These iterators are expensive to copy.  Not that it matters much in a test.


原文: With the addition of libraries like Scalaz and Cats, we forget that learning to program functionally is simpler than learning to use a purely functional library.
訳案: しかし、それらのコンビネータに Scalaz や Cats といった純粋関数型のライブラリが加わると、その使用方法に気が取られて、とたんに関数型プログラミングを学習することを難しく考えてしまう人が多い。


@agatorano
Ok with vim!


@agatorano
Ok, with both, that's what I have.  and Django is great!


@chuckwondo
Good summary!


@chuckwondo
Ok with Vim and PyCharm!


Seems like it's partly due to the way the tests were written and is probably OK. See [here](https://github.com/jbrantly/DefinitelyTyped/commit/07c4e447f11813939def8d1d8ca818fc89d32e27#diff-42e68854c119ed2d51909a9c8c365d1bL209)


@chuckwondo
good job!
I also like for command line:
> ls -Glp


这里你需要理解多进程的概念。实际上，在单一的Task
Worker进程内，这里的pdo并不会多次赋值，而是只会赋值一次。onWorkerStart虽然会被调用多次，但是每一次调用都是在不同进程内，而不同进程的变量是相互独立互不影响的。

2015-08-26 10:17 GMT+08:00 Chiao <notifications@github.com>:

> 这里 $this->pdo 可能被覆盖了吧，那不就是只保持了一个连接么，求解。
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LinkedDestiny/swoole-doc/commit/79c631e76b4dacef5c4ffbcb6a6c15af55782a61#commitcomment-12894000>
> .
>


@ItsAMysterious  see #2054


Is this supposed to be included? This looks like a relic from when I was trying to set up reporting (or are you?)


Is this all messages? Including direct messages, group messages, and channel messages?


Cool! I'll think about it 😃


Building in assets and stand ins


Will you include an update to the bib file that includes page numbers for these references?


Yes. We don't store the type of room a message was sent to. Maybe that
would be an improvement.

--
Marcelo Schmidt

On Thu, Aug 27, 2015 at 11:22 PM, graywolf336 <notifications@github.com>
wrote:

> Is this all messages? Including direct messages, group messages, and
> channel messages?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RocketChat/Rocket.Chat/commit/18f533415cb7ce006127ea074873310a5b56e926#commitcomment-12939825>
> .
>


there is no need for the PS3 controller ? testing the PS4 right away to see how it works :P

still no news of the guy with potentially a xbox one though.... ;( he just vanished!


@dperkus
OK, with vim and spyder!


@dperkus
Good job with all 3 parts!

I also like for command line:
> ls -Glp


I've been thinking about ways to spice up the statistics page and this would be a good thing to see the difference in, useful details to have..for me at least.


this made me sad today :(


It seems that -flto makes a good impact on math benchmarks. Below is whestone benchmark test ( http://www.netlib.org/benchmark/whetstone.c , found on http://forum.xda-developers.com/showpost.php?p=52736153&postcount=1 )
![screenshot_2015-08-28-05-25-34](https://cloud.githubusercontent.com/assets/7280845/9537787/8be8e4aa-4d45-11e5-91ba-4e46365a6a5e.png)


develop (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


added client.hset and client.hget


delect the file


@sintetizzatore
great job!
I also like for command line:

    ls -Glp


@sintetizzatore
Emacs all the way!


This line too needs that change...


辛苦~


細かいけれど、
```javascript
if(remainingSeconds > 60){
```
は
```javascript
if (remainingSeconds > 60) {
```
にして、
```javascript
}else{
```
は
```javascript
} else {
```
にした方が、他の場所と統一されたスペースの開け方になるので、その方が良いと思います


Helpful helper method:
```java
private IOpenableGUI getOpenableGUI(EntityPlayer player, World world, int x, int y, int z)
{
	Object object = world.getTileEntity(x, y, z);
	ItemStack itemStack = player.getHeldItem();
	return object instanceof IOpenableGUI ? (IOpenableGUI) object : itemStack != null && itemStack.getItem() instanceof IOpenableGUI ? (IOpenableGUI) itemStack.getItem() : null;
}
```


Not sure is we have CS for that but most of the existing code base use explicit `{}`


if it actually is significantly better than pyqt5 i'm not against switching, i'm always butting my head against it these days, but how much effort would be involved to make the switch?


Done, sorry about that. Not as familiar with genie/Make’s inner workings as I should be :)

On Aug 27, 2015, at 10:34 PM, Branimir Karadžić <notifications@github.com> wrote:

> This line too needs that change...
>
> —
> Reply to this email directly or view it on GitHub.
>


no idea why this got doubly committed :expressionless:


You show add other method to this class.


looks like `$differentapi` will be empty here, intended?


@21373colido Just fork the repository under your own Github account. As long as you provide the source code for any binaries you distribute you are compliant with the GPL.


well, this is really just testing that `"client respects --api flag even when daemon is on"` (i.e. it fails because the `--api <addr>` has nothing there)


still need to move this one


This should actually call `g_filename_to_utf8` as the return of `g_getenv` is the filename encoding: https://developer.gnome.org/glib/stable/glib-Miscellaneous-Utility-Functions.html#g-getenv


Thanks very much


This Revert was a mistake.


i think `test_launch_ipfs_daemon '--api "$ADDR_API"'` fails because the `'` dont evaluate the `$ADDR_API`. maybe one of

```
test_launch_ipfs_daemon "--api '$ADDR_API'"
test_launch_ipfs_daemon "--api \"$ADDR_API\""
```


should also test just:

```
ipfs id
```

(verify `ipfs id` is reading the api file correctly)


How did you come up with this versioning?


Thanks.  Can you also add a test in tests/tfilename.cxx ?


and, i think this _should not_ work, because `--api` should cause it to always try the remote endpoint, but in this case it is not there (this is before launching the daemon). so `test_must_fail` ? or is it not failing?


root@Gargoyle:~# swconfig dev switch0 port 3 get status
link: up, speed: 1000 Mbps, duplex: full
root@Gargoyle:~# swconfig dev switch0 port 3 get link
1000
root@Gargoyle:~# cat /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='Chaos Calmer'
DISTRIB_REVISION='r46419'
DISTRIB_CODENAME='chaos_calmer'
DISTRIB_TARGET='mvebu/generic'
DISTRIB_DESCRIPTION='OpenWrt Chaos Calmer 15.05'
DISTRIB_TAINTS='no-all'

Is it possible that swconfig's output is unstable between targets? I don't understand why they would do that. That defeats the purpose of a universal utility.
Easy fix with an IF statement, but i want to understand why first.

Eric do you have a device that is non ar71xx to check with?


simpifiying the tests == lgtm !


maybe test that

```
ipfs id
```
works correctly, as a control?


maybe also test the value of the file is correct?


maybe here test one more:

```
mv .ipfs/api api # move it out
echo "$differentapi" >.ipfs/api #chage it
test_must_fail ipfs id # doesnt work now
ipfs id --api "$differentapi" id # works still
mv api .ipfs/api # put it back
```


@rht sorry i'm being paranoid about this one, it can _fail so hard_ on users, so want to make sure all the semantics are super right and that we dont break them.


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


for all these tests, i think we need  to make sure:

1. the op takes effect before the tx is committed
2. the op still takes effect after the tx is committed


> LOCAL ONLY NO UPLOAD ANYWHERE

well that's a fun one


Thanks for quick fix :) this should make all travis run smoother also.


I am a nice comment


I actually was looking commit-by-commit, but the whitespace was still tripping me up. Check it out, github can ignore whitespace too with ?w=1 : https://github.com/code-dot-org/code-dot-org/commit/1bde3ebf852c77969d1c7cacf0c0b400f49154a9?w=1


Since the average is not necessarily an actual element in the `Collection`, I think it's worth being explicit.


Do you talk about the `_UserRepository.java` file? If yes, there is something strange because, this two method doesn't exist since the commit of the 1 august. I created two `findOneWithEagerRelationships` one for Java 7 and a other one for java 8.


This comment is kind of true, but doesn't really apply here.  It is true that command objects that are defined in the same source file as the controller in which they are used don't have to be marked `@Validateable` and Grails will make them validate able at compile time, but this isn't really a command object, at least not in the sense that is relevant here. Grails core considers the thing a command object if it is used as an argument to a controller action.  This class isn't used as an argument to a controller action.  It is used as an argument in a web flow, but that won't trigger anything special in Grails core.  That would really need to be handled by the web flow plugin.


done


If the constant values change in future libarary upgrades, hard coded values like that are hard to maintain.

const (
	AV_CODEC_ID_PCM_S24BE = int(C.AV_CODEC_ID_PCM_S24BE)
        AV_CODEC_ID_ADPCM_IMA_AMV = int (C.AV_CODEC_ID_ADPCM_IMA_AMV)
.... and so forth.
)


@indutny remember, we got around this by making sure all our NSStream operations happen from the same queue ? And, even in the run loop  thread of the NSStream thread, we dispatched onto the queue.
 dispatch_queues are so much faster than running on a thread because it would take long for that thread to be scheduled whereas queue can be drained from a running thread.


OK.


you are genies!


Hi @gbushell
Would you mind adding the `alt` and `image` tag to the other `img` tags please?


We'll discuss this later offline. Merging the change now.


@georgekola this is what happens now, when the socket notifies us about the event - we just switch to our queue and run stuff on it. However in many cases we must write to the socket without the event, this is when we need to switch to the socket's event loop's thread.

Considering that it is NSRunLoop that powers the socket, we can't really use dispatch_queue to get there. This is why I have used CFRunLoopSource.


7 is resultType that corresponds to the type of result XPathResult to return (as described in docs), so 7 is https://developer.mozilla.org/ru/docs/Web/API/Document/evaluate#Result_types - ORDERED_NODE_SNAPSHOT_TYPE, which means return ALL nodes in the order how it was found  :)


Noticed while running Ansible from the current build
Throws error "NameError: global name 'tself' is not defined" due to the fact that self is misspelled

EDIT: I have confirmed this fixes my error with the unarchive module after editing my local copy to reflect accordingly and thus this change should be good to go


7 is resultType that corresponds to the type of result XPathResult to return (as described in docs), so 7 is https://developer.mozilla.org/ru/docs/Web/API/Document/evaluate#Result_types - ORDERED_NODE_SNAPSHOT_TYPE, which means return ALL nodes in the order how it was found :)


r+


Thanks for spotting this @grammati

Fixed in https://github.com/clojure-emacs/cider/commit/19d022ad22a4d3124a25f797e51336837b8a06af


@indutny can you profile this on Voxer app on an iphone with live audio and make sure this works. In my previous company, we had a lot of jitter when we used nsrunloop. We ended up going to dispatch_source to fix it.
/cc @paulreilly


done, don't think there's a good reason


Nice! I'd go with the string format on steroids version too, thanks.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/abf4cb41a68575a5acff1b7e39fcaa4e51c8a2ab


merging MonsieurNicolas/stellar-core/metaImprovements = abf4cb41 into auto


MonsieurNicolas/stellar-core/metaImprovements = abf4cb41 merged ok, testing candidate = 5182572c


Cool, thanks.


Would that even be possible to ever occur?


test pull request


Yes! I've been wanting this!


Yay! Thanks!


@mikhailmikhaylov, can we have a version number as a variable?


@georgekola I already tested it on voxer/ios. I don't see any difference.


@jbest84 @CHenrie For INFORCRM-4675


@mikhailmikhaylov, why do we have a JAR added to version control?


@georgekola if you know a way to how to run things on NSRunLoop's event loop's thread with dispatch_source - let me know. AFAIK, they are completely different things and can't be really tied together.


we wont use git client, sucks a lot


@tlwalla1 Accept


GitHub complains about absence of the new line at the end of file.


@ahmadia I used Continuums' dockerfile as a base for this command: https://github.com/ContinuumIO/docker-images/blob/master/anaconda/Dockerfile I thought it was the better way for doing this.
I tried to install conda and run DDT as non-root user, but found some problems while installing the packages later, so I'm leaving this as it is for now.


added a check for existence of 0 and size >= 2


added the sort, good catch


I was thinking about another implementation for tests that generates a sequence of deterministic ids.


Yeah. When I saw your comment on FTB I was like DO NOT forget to revert this before committing. In the end I still forgot.


Do you have Git installed?
I don't really see a good solution for this... is it a problem?
(You can remove the SubtitleEdit pre-build after compiling once or renaming AssemblyInfo.cs.template to AssemblyInfo.cs... and set the version number manually.
Earlier I maintained the version number in the AssemblyInfo.cs.template manually and I would rather not do that)


next time I'll create pull :)


good question, yes a lot. In fact the white-list is known, the test should be improved.


also working with multiple crumb containers


You are right, returning the promise and nodeify it is a lot better.


4695_hpwh_equip_seq_num (nmerket) - x86_64-MacOS-10.9-clang: OK (1807 of 1807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


is this method a candidate for kebab casing? :)


@psiroky After a very long time, I felt like going back to this. :-)

Seems that if I start a new game through the GUI, the players aren't rendered at all in the window. However, when I start a replay of the same game, the players are rendered OK.

If by any chance you ever have 5 minutes to take a look why that is, I owe you a beer.


It's an internal method that's called by the compiler. I guess there's better ways to spend time.


The "case '2'" algorithm 2 and 3 (next commit) DO NOT mirror the calendar with regard to the problem below. I need to fix this.

For a recurrtype 2 appointment set under following conditions -

- In a location with a positive UTC offset
- On the 4th occurrence of a particular weekday that has a 5th occurrence that is the end of the month
- The "Last <weekday>" option is selected
- "From" date of report is <= pc_eventDate

Then a non existent appointment date will appear in the appointment report (with date equal to pc_eventDate), also the first date of the series (first (or only) last <weekday>) will be missing (Calendar does not have this problem).


can you remove this file? It is all commented out code


In my next PR, a cleanup up things I encountered, I deal with this class.


It is not meant to be public me thinks. So, no.


remove this line


Most definitely better ways, sorry to bother


Wtf?


optional: if you store this as []string, then below you can just append(args, waitFlags...) without testing for ""


You probably want to change this comment.


can you remove this function-- are you using it anywhere?


It's ok like it is now.


@indutny yes, they are different. We had to switch to regular socket as well.

Can you please time or collect packet trace of a live audio stream and measure the jitter -- the spacing between packets of live audio  ?  The concern is the time delay between the write and when the CFRunLoop thread actually runs. Please, do it on a real account which has data and activity (i.e.  send a photo to that account while the live audio is streaming) and you should see the jitter.
 The jitter happens when the CPU is loaded and does not happen if the 2 cores are idle and hence the need for a real-world test case. If the jitter is negligible, we need not worry. So, measurement is useful data for that.

@paulreilly is seeing jitter on iOS 9 and we had this commit in the build and we reverted. It would be great if you can work with @paulreilly and figure out the issue he is seeing and if both are related or not.


This commit should be a whole different PR, please - it's useful on its own.


changing to  `minGQ >= maxGQ`
I don't think `minGQ == maxGQ` is meaningful since it's used here

```
  public boolean withinBounds(final int GQ) {
        return GQ >= minGQ && GQ < maxGQ;
    }
```


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 447](https://teamcity.labkey.org/viewLog.html?buildId=269019&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:29
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


I also wonder if something like this could be used to code a distributed file system abstraction.


so do it please :smiley:


Try this hasm file (which works and parses correctly without `endOfInput`

```asm
3 3

mov r0 10
mov r1 10
mov r2 10
bne r1 r2 7
mul m0 r1 r2
mov r1 m0
jmp 3
mov m0 0
```


wtf


Did you mean -lnsl (same lib as before) ?


Its a new rule along with send maximum in path finding. If a send max is specified, dst amt must be -1. Before a dst amount would be considered malformed if it was zero or less.


It could be, I was thinking more about a temporal circular buffer (disk backed) that I think Is more appropriated for streaming of data.


Good catch - thanks.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 448](https://teamcity.labkey.org/viewLog.html?buildId=269026&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:07:31
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


@droazen any idea why these are initialized to this size?  I was afraid to remove it because it might be some optimization, but it seems sketchy.


Not new same logic although now we need to exclude the case where a -1 was passed in as the dst amount.


That's interesting. Are you able to drill down into the event and see what methods are taking the longest?


wohoo, that is a killer use.


Is this test actually _testing_ anything? It's building some json, but not doing anything with the result.


if such a thing could be done for a live stream... oh boy.


What do you think? I'm open to either, but the mozilla docs perhaps don't cover everything. OTOH they might be easier to understand, with more examples and such. I don't really mind either way, but consistency is good. As long as it doesn't point to outdated working drafts :)


Spent a day to find a bug in my years old C code)))


TeamCity pull requests :: netty [Build 146](https://garage.netty.io/teamcity/viewLog.html?buildId=936&buildTypeId=pulls_netty&guest=1) is now running


Hm interesting. At my side PlayerJoinEvent is greater than leave

```
 0.03%	  66.27%	  1.13 s	    33.13 ms	 0.0	       0.0k	    ListenPlayerJoin::onPlayerJoinEarly(PlayerJoinEvent)
       0.01%	  12.82%	  0.28 s	     6.41 ms	 0.0	       0.0k	    ListenPlayerOther::onPlayerQuit(PlayerQuitEvent)
       0.00%	   5.28%	  0.09 s	     2.64 ms	 0.0	       0.0k	    ListenPlayerJoin::onPlayerJoinLate(PlayerJoinEvent)
```


TeamCity pull requests :: netty [Build 147](https://garage.netty.io/teamcity/viewLog.html?buildId=937&buildTypeId=pulls_netty&guest=1) is now running


Pre-existing and outside this PR scope, but I'll clean it up.


Will do!


Better name! haha


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (759 of 759 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.27%25-green.svg)


eheheeh :-)


This should be removed already. Don't know why it shows up here.


Awesome thank you Sir!


start


com


Version 2 did much better in LTC...the reason is simple:
When we reach depth>22
In ver1, the entry was simply reset to 0.
In ver2, the entry was also rest to 0..but got updated by v*64.
At LTC we reach depth 22 more often and IMO it makes no sense to clear that entry out.


removed.


@cnaude That's as much information as the timings profile provides for VanishNoPacket.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/77742357


I'm confused. How was this creating problems before you made your code change, spopescu?


:-) fine


Ill have a look at the code and see what's going on.


First kwarg is rtol, second is atol. You're right that we should be explicit about what we are using, though...


Hm interesting. Are you using the normal GPS folder that's in the current
cm builds?

On Fri, Aug 28, 2015, 1:39 PM Zdrowy Gosciu <notifications@github.com>
wrote:

> You mean http://review.cyanogenmod.org/#/c/107672/?
> I didn't picked it yet [image: :smiley:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lg-devs/proprietary_vendor_lge/commit/0b5cd7428a5380ddf28d81bcd57ca9776394810e#commitcomment-12952793>
> .
>
--

Thanks,
Rashed Abdel-Tawab


Haha. I'm on a roll the last couple of days.

On Friday, August 28, 2015, Lars Andersen <notifications@github.com> wrote:

> Thanks for spotting this @grammati <https://github.com/grammati>
>
> Fixed in 19d022a
> <https://github.com/clojure-emacs/cider/commit/19d022ad22a4d3124a25f797e51336837b8a06af>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/clojure-emacs/cider/commit/41efdcaefdd6d9f37d545da5252bf5ee1c3f3fd2#commitcomment-12955534>
> .
>

--
Best Regards,
Bozhidar Batsov

http://www.batsov.com


Thanks. Any improvements to the Quit event would be great. :) I'll be here to help test too if needed.


wtf


Sorry, I didn't mean to come off as sassy.


Is there a reason to why this file is latin1?


Ecto, and now Phoenix. What an excellent week for Elixir. :)


We can possibly filter out moduleLauncherProperties/moudleResolverProperties from `parentArgs` (though it might get tricky) to avoid any possible overlap of any module specific properties. I think it very rare to have a module to have an option as `modules`, `remoteRepositories`. But the arg `aggregate` could be one possible victim for possible overlap with any module option. Having `prefix` on ModuleLauncher/ResolverProperties would help fixing this as long as it doesn't seem an overkill.


4695_hpwh_equip_seq_num (nmerket) - i386-Windows-7-VisualStudio-12: OK (1813 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fast-forwarding master to auto = 5182572c


Thank you!


I have a suspicion that it's the built in metrics that may be causing the issue.


gulp updatecommit --> шиш с маслом
Хм.


@jbest84 @CHenrie @stdowns Please review


Wouldn't it be better to replace `"` with `"` on the output instead of stripping the chars out?


Indeed. This `git diff` looked like it was missing something.


Compilation freezes if I uncomment the `get` function. Why?
``` Elm
get : (Ord c) -> Dict (Ord c) v -> Maybe v
get targetKey dict =
    case dict of
      RBEmpty_elm_builtin LBlack ->
          Nothing

      RBNode_elm_builtin _ key value left right ->
          case .compr targetKey key of
            LT -> get targetKey left
            EQ -> Just value
            GT -> get targetKey right
```
It must be something trivial, but I didn't find the error and the compiler simply does not terminate. I am using `elm make Graph.elm` to test the code.


raSrcAccount can never be empty here. ::parsejon and :isValid both verify that before ::doUpdate.


Yes https://github.com/CyanogenMod/android_device_lge_g2-common/tree/cm-12.1/gps + https://github.com/lg-devs/proprietary_vendor_lge/commit/0b5cd7428a5380ddf28d81bcd57ca9776394810e :+1:


This change broke webjars ability to convert this bower package into a maven package. Shouldn't the <= stay? It's not clear what it means without it.


No idea.


Refs https://github.com/atom/atom/issues/8551


ForceCommit is a wrapper around tx.Commit, so I don't bother to test it again.


ok


will do


Thats a good idea. I think Riak CS can handle the ". I'll give it a test.


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2305 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.38%25-yellow.svg)


Yeah, that makes sense. I think we should just restrict it to `spring.cloud.stream` properties (as it initially was), as the parent properties are only relevant for the parent channel adapter  (and will be bound only to the binder channel adapter properties). If we need more in the future, we can change this. WDYT?


I think this is leftover debugging code. If you want to keep it, t.Logf is better I think.


This will pull down sasl as one of the dependencies for Impyla. That way users don't have to do extra steps to satisfy this dependency.


This should be `== "ctypes" or startswith('ctypes.')` (mind the dot), otherwise `ctypesfoo` would match, too.


do you indicate to put it into a goroutine and wait for it outside?


It's fine.  Switching users can be a bit tricky.  I got it working in the Memex Explorer Dockerfile, just something to keep in mind for later.


will add comment


I don't think this makes much sense as a global variable. There won't be a "default" or "latest" group or anything.


Likewise for GroupVersion.


Fair enough, seems the guy in Temasek's thread was wrong when he said about that there only being performance improvement on initial boot.

I'm aware it's an issue with xposed, and it seems like it's known (see the bottom of romracer's post http://forum.xda-developers.com/xposed/super-alpha-posted-permission-xposed-t3072979) but no progress has been made on it. Shame, really. I guess it'll be done eventually, or xposed's reign will come to an end. Either way.

Seems I'll be forced to go without using any root-protected apps (RootCloak is a godsend), since that's the only thing I ever use xposed for, which is bloody annoying, but ah well. I think there are patched apks for those apps which remove the root protection, anyway (actually, os-level root cloaking might be handy. I wouldn't have a clue on how to implement it, though, and can hardly expect you to). I can put up with that.

Might be worth putting this paragraph or a more polished and condensed version of it into the OP somewhere just so that people don't carry on having a go at you for xposed not working. I sure would've have brought it up on this commit if that were the case. Thanks for taking the time to explain, at least, it clears it up a lot more than the other posts which could just be summarised down to "fuck xposed" (Fair enough for you as the developer to take that viewpoint though, must be a pain in the ass for you to deal with all these bug reports you can do fuck all about).


Awesome. I'll take a stab at the locking problem. I think I know what it is.

On Fri, Aug 28, 2015, 4:47 PM Zdrowy Gosciu <notifications@github.com>
wrote:

> Yes
> https://github.com/CyanogenMod/android_device_lge_g2-common/tree/cm-12.1/gps
> + 0b5cd74
> <https://github.com/lg-devs/proprietary_vendor_lge/commit/0b5cd7428a5380ddf28d81bcd57ca9776394810e> [image:
> :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lg-devs/proprietary_vendor_lge/commit/0b5cd7428a5380ddf28d81bcd57ca9776394810e#commitcomment-12956168>
> .
>
--

Thanks,
Rashed Abdel-Tawab


Oh, This won't work. At least not at this code point.

At this point the text hasn't been encoded into Entities yet. Golang's XML encoder is going to do that next. And when it does its going to do it wrong.

I haven't been able to figure out how to disable the entity encoding or fix the way golang is doing the encoding.

The proper thing to do would be to fix the bug in Riak CS so that it accepts the ". Which is, technically, valid. But thats beyond the scope for this task. My erlang is rusty, and building our own Riak CS might not be what we want to do. So I'm applying a monkey patch to the client code instead.


I would prefer taking all the properties that has `spring.*` prefix (such useful property would be spring.active.profiles or spring.boot.logging ) that way any spring framework/boot specific could be in the parent adapter.


i mean you need to test this behavior. that is why we have that method after all.


This data now needs to be in the form of map[group]struct{defaultVersion, oldestVersion, allSupportedVersions[]}.


4695_hpwh_equip_seq_num (mbadams5) - x86_64-MacOS-10.9-clang: OK (1807 of 1807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


No, I'll convert it to UTF-8, thanks!


isDefaultPath is MUCH cheaper.


Oops a typo


I wanted to write it but it wouldn't show and I couldn't figure out how to
not make it show was code, I wrapped it in a code tag but that didn't work
Any suggestions?

On Friday, August 28, 2015, Patrick Nolan <notifications@github.com> wrote:

> Any reason why you have a text based logo as an image? You could write
> your logo in HTML and style it with CSS and score a little bit of SEO
> brownie points.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rachadrienne/ga-syd-fewd-19-assignment-1/commit/ab72b72a038bb945ba1a0a3b96565a69a4a8b5c2#commitcomment-12946662>
> .
>


Added Intention and Purpose...


:satellite::+1:
:yum:


This is in my todo list. "factoring out default version, oldest version, storage version, etc. https://github.com/kubernetes/kubernetes/pull/12755#discussion_r37247918". Actually I already have a local branch fixed it. I will send it as another PR.


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1280 of 1280 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.99%25-green.svg)


Create the index.html


> `gulp updatecommit `

Его запускать отдельно не надо. Достаточно просто `gulp make`, а `updatecommit` запустится автоматически.


how to undo what this software did. I uninstalled it but my ping is stuck on higher than normal average.

I am now getting 133 instead of 80 on asian servers

tried re installed CS go but no effect.

Please help


I don't like camel case.


OK, that sounds reasonable.


Corrected it by [commit](https://github.com/BuZZ-dEE/language-svg/commit/7f07c43956500c9332840f057d95c668dc5d68ba).


The error can be seen if the internal `get` calls are commented:
```
The type annotation for `get` does not match its definition.

74| get : Ord c -> Dict (Ord c) v -> Maybe v
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Could not unify user provided type variable `c`. The most likely cases are:

  1. The type you wrote down is too general. It says any type can go through
     but in fact only a certain type can.
  2. A type variable is probably being shared between two type annotations.
     They are treated as different things in the current implementation, so
     Try commenting out some type annotations and see what happens.

As I infer the type of values flowing through your program, I see a conflict
between these two types:

    Ord c

    c

Detected errors in 1 module.
```

I will try to fix this.


This version includes (possible) fixes for random audit reboots..


create css


:smile:


Йоба, я протупил, у меня просто скрипт не содержал твои коммиты.


This commit introduced a surface bug, the page_content_title now says 'Term Page' for all terms


To clarify, this is just the latest for package api, currently we also have /pkg/expapi/latest/latest.go. I will make a subsequent PR to implement map[group]struct{defaultVersion, oldestVersion, allSupportedVersions[]}.


css create


Я уже понял. Просто говорю, чтобы лишний раз не запускал. Алсо, могу сделать `gulp upversion` для автоматического обновления версии во всех файлах. Надо?


Check this for reference: https://github.com/nodejs/nan/blob/master/appveyor.yml


TeamCity pull requests :: netty [Build 146](https://garage.netty.io/teamcity/viewLog.html?buildId=936&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4757, ignored: 21 Build time: 00:28:16


То бишь, я тут сделал гит пулл, но потом с флешки принес старый ес6-файл отдельно, де экспериментирвал кодом данного коммита.


Somehow this broke `-passthru`:
```
$ ./jtrts.pl rar-opencl -pass=-dev=2
Can't use string ("-dev=2") as an ARRAY ref while "strict refs" in use at ./jtrts.pl line 150.
```
I have no time to try to understand it right now, I'll just use an older commit


Как хочешь. Мне и руками удобно.


Thinking better, the code this is very specific in dealing with int seeds (the code doing the rand algorithm by hand too). I prefer to wait on trying to exposed that as a general size random buffer generator util/platform function. @lpereira, what do you say?


@tcompiegne Can you provide us with more information on the issue you're resolving with this commit ?
Why do we have a CORSFilter with the same behavior as the CORSResponseFilter ?


Теперь надо делать `git rebase` :smile:
Бывает. Я всегда проверяю `git diff HEAD^ HEAD` перед отправко


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 449](https://teamcity.labkey.org/viewLog.html?buildId=269038&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:09:58
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Fix docstring


Не надо. Я выпилил этот коммит из мастера.


Good point!

I'll update the PR soon.


@matysek, this seems a bit over-complicated. Would it be possible to remove the `def dummy`, instead using:

```
tct = CDLL(lib_filename)
assert tct.dummy(42) == 42
```


nice work. looks like it's finally worth putting some work into updating some stuff.
glad to see you still beeing active, mate!


¿por qué se ignoran estos eventos? ¿no vale la pena probarlos?


Here are the jitter results from my iphone:

```
0.00ms <= 144
0.18ms <= 86
0.37ms <= 30
0.56ms <= 33
0.75ms <= 27
0.93ms <= 18
1.12ms <= 13
1.31ms <= 11
1.50ms <= 13
1.68ms <= 11
1.87ms <= 1
2.06ms <= 1
2.25ms <= 2
2.43ms <= 1
2.62ms <= 2
2.81ms <= 0
3.00ms <= 0
3.18ms <= 0
3.37ms <= 0
3.56ms <= 0
3.75ms <= 0
3.93ms <= 0
4.12ms <= 0
4.31ms <= 1
4.50ms <= 0
4.68ms <= 0
4.87ms <= 0
5.06ms <= 1
5.25ms <= 1
5.43ms <= 0
5.62ms <= 0
5.81ms <= 0
```

I have used f3b1890 to collect them. The workflow on iphone was following:

* Send audio
* Send picture
* Send 15s video and audio in parallel


93651760-RowPerObjectReport (JasonGlazer) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-60.58%25-red.svg)


@georgekola @paulreilly most of the the jitter is within 1ms


Да епту....


`transHuman` has been around for quite a while. There's also a `transToken`, which I'd guess is why the `to_string` convention wasn't used.


@indutny can you please send me the packet trace (this chat is public, so you may just want to send it to me over email).


@indutny thanks


@georgekola I don't have the packet trace, do you want me to collect it from the simulator, or iphone itself?


I wouldn't recommend this.  This will cause the chef run to fail if both nodes come up at the same time.   I have a branch that addresses this  partially, that you're welcome to pilfer from. =)

https://github.com/jdblack/chef-gluster


I testd it just to be certain.


Here is the more informative version of distribution:

```
0.00ms <= 237
0.40ms <= 63
0.80ms <= 46
1.20ms <= 25
1.60ms <= 16
2.00ms <= 3
2.40ms <= 3
2.80ms <= 0
3.20ms <= 0
3.59ms <= 0
4.00ms <= 1
4.39ms <= 0
4.80ms <= 0
5.20ms <= 2
5.60ms <= 0
```


And this does not account writes that was happening without the thread signalling (there are many)


Nit: unnecessary change


@jdblack if 2 nodes come up at the same time then the search for bricks will not return anything for the other node and volume related operations will be skipped.


Any way to disable or remove it to make the plugin as lightweight as possible?


You just don't know hoe to use it you have to you can.make 100 commits into like 50 by committing multiple files at once search youtube


@indutny the packet trace would show the jitter on the audio being sent out  and that takes into account all thread signalling etc and hence that request.

you should collect it from iphone.

http://useyourloaf.com/blog/remote-packet-capture-for-ios-devices.html

https://developer.apple.com/library/mac/qa/qa1176/_index.html

search for rvictl


Is there a heading with tag missing before the EU conference, to match NA? Like this:
#### Europe

I'm also not sure about the headings overall, and Kelly had some good ideas about top level navigation that might represent more aggressive edits. Not sure -- hope this is helpful.


These will have to be dialed down.


Given the above if statement ("If this is Fedora, but less than version 22), it'll get set at 3.13.1-119. But that version is for Fedora 22.


Hmm Sry my Console Spam this

[ERROR] gamemodes/darkrp/gamemode/modules/fadmin/fadmin/cl_interface/cl_scoreboardserver.lua:209: attempt to index a nil value
  1. func - gamemodes/darkrp/gamemode/modules/fadmin/fadmin/cl_interface/cl_scoreboardserver.lua:209
   2. RefreshText - gamemodes/darkrp/gamemode/modules/fadmin/fadmin/cl_interface/cl_scoreboardserver.lua:144
    3. Show - gamemodes/darkrp/gamemode/modules/fadmin/fadmin/cl_interface/cl_scoreboardserver.lua:172
     4. ChangeView - gamemodes/darkrp/gamemode/modules/fadmin/fadmin/cl_interface/cl_scoreboard.lua:10
      5. DoClick - gamemodes/darkrp/gamemode/modules/fadmin/fadmin/cl_interface/cl_scoreboard.lua:102
       6. OnMouseReleased - lua/vgui/dlabel.lua:218
        7. unknown - lua/vgui/dimagebutton.lua:129

When i am Clicked of Server Settings by Tab


Nice work @pioul, this all looks great to me. Sorry for the delay :+1:


You should add the tests to your cmake file so you can catch those simple runtime errors more easily.

The static library fails when used because the dllmain isn't called to set things up. This block right after the DllMain in [dispatch_wgl.c](https://github.com/Nephatrine/libepoxy/blob/master/src/dispatch_wgl.c) is what I'm using now to make sure it's called. (I was using a different solution previously that had issues with threading.) I've got this while block wrapped in a ```#ifndef BUILD_SHARED_LIBS``` so it only applies to my static build.

	#ifdef __GNUC__
	PIMAGE_TLS_CALLBACK dllmain_callback __attribute__((section(".CRT$XLB"))) = (PIMAGE_TLS_CALLBACK)DllMain;
	#else
	#ifdef _WIN64
	#pragma comment(linker, "/INCLUDE:_tls_used")
	#pragma comment(linker, "/INCLUDE:dllmain_callback")
	#pragma const_seg(".CRT$XLB")
	extern const PIMAGE_TLS_CALLBACK dllmain_callback;
	const PIMAGE_TLS_CALLBACK dllmain_callback = DllMain;
	#pragma const_seg()
	#else
	#pragma comment(linker, "/INCLUDE:__tls_used")
	#pragma comment(linker, "/INCLUDE:_dllmain_callback")
	#pragma data_seg(".CRT$XLB")
	PIMAGE_TLS_CALLBACK dllmain_callback = DllMain;
	#pragma data_seg()
	#endif
	#endif


Solved in 1dbd4861a484f14129fb6dd8ba54c33d343c3a86.


why not just:

```ruby
task :publish => [:not_dirty, :prepare_git_remote_in_build_dir, :sync, 'build', 'deploy']
```

Is this one of those `Task#exec` vs `Task#invoke` kind of things?


Resolves #100.


Ты вручную исправляешь что-ли?
Вот так надо:
```
git checkout -b fixbranch
git reset --hard 6359368ee43bedd11fed86b5dab674c954a2e3d8
<копируешь файл>
git commit -am"My commit"
git rebase master
<исправляешь файл если нужно>
git checkout master
git merge fixbranch
git branch -D fixbranch
```


1787-OrphanedConnection (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


that's my text editor fixing style.      functioning as desired.


Not valid. These args are always instance args.

For instance:
ays install -n redis -i system --data 'redis.name:system redis.port:7766 redis.disk:0  redis.mem:100'
This data argument translates to args in the service. Prefixing it will result in double prefixing and corrupt services


Ah, that's a good idea! To be honest, it just slipped by me.


Ah, do you know if there's a way to stop the `:deploy` task from re-running `[:not_dirty, :prepare_git_remote_in_build_dir, :sync]`?


I mildly disagree. The parameter being populated is a documentary name. Keeping this inline prevents accidental misuse later.


there may be better method to achieve this... still exploring


These regexp are scary! Thanks for fixing the bug.


Paging an @cowofevil ... An @anodelman :rat:ed you out as someone who might know powershell... Wondering if you have any advice on how to `on host, powershell(...)` and assert that a hosts entry was actually added?


Well Done.


Yes, having a `sol_prng` would be a nice idea.


Heh, is he just referred to as Lal from now on :)


You should update the map too.


По этой кнопке будет превращение брюк в шорты. Окошки будут открепляться, и становиться плавающими, как быстрый ответ.


The title of this commit should have been: "Racket autograder: totalTests fixed, changed expected test format"


Some fix...


Great find, I was baning my head against this for some houers :). Any chanche that it could get backportet to 0.13? Clearly the bug is there too


what about ',,' ? …


Спасибо, буду знать. Привык руками конфликты править, тому що не смог разобраться.


This path is good for now I guess. Probably should be refactored


What exactly does this test add? Not certain an integration test makes sense here, plus rather keep core LibGDX free, even in tests.


Thanks for fixing the spelling!


We can't delete the file before it actually exists, and that doesn't happen until the resolver.commit() is called. What we can do is call resolver.commit() right away when we try to import, and if the import is successful, delete the file resource once we're finished with it. I think this is a good solution though. Import automatically if there's a receptive resource to pull the content into, but if not, leave the user with the option to import it later in case they need to specify a different path or create the resource themselves.


from __future__ import division


Awesome, glad to know it is all working! Thank you too and cheers. I'll check out and setup pi-timolo sometime soon :)


Thanks for correcting the format


Wrong branch--the issue was on an earlier commit (refactor page variable handling in WebApp.pm) and I just missed it.


I would rewrite the comment about the sort down to `// A better PathRank is lower, best are sorted to the beginning.`, and leave the comments inside the lambda function as-is. I like seeing the explanation corresponding to the operation.


This is old code. Check master for https://github.com/trustedanalytics/atk/pull/37/files


If it is in the dependency chain, then I'm pretty sure it will only run them 1 time.
In rails you have a bunch with `=> :environment` and I'm pretty sure environment is only loaded one time.

You can probably put those as symbols, or maybe try `%w(not_dirty prepare_git_remote_in_build_dir ...)`

Again, that is why I asked about `exec` and `invoke`. Task lets you choose your behavior. I'm pretty sure dependencies on the other hand only get called one time.


Awesome to see PCL coming to conda!


TeamCity pull requests :: netty [Build 147](https://garage.netty.io/teamcity/viewLog.html?buildId=937&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4757, ignored: 21 Build time: 00:55:27


Maybe by using file signature ?


Why is the dart version in browser_adapter.dart and the typescript version in lang.ts?


Woop, thanks @djfarrelly! :smiley:


Альзо, теперь все окна в каждом своем отдельном контейнере. Сейчас идет просто переключение между ними.


As currently written, `isDefaultPath` is only checking the `size`, so I'd guess that's cheaper.


thanks to @xycaleth for most of the code.


it looks like the unlock could be here.


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.54%25-red.svg)


Passing anything other than a string literal to printf functions usually generates a warning in gcc.


Create table with HBaseAdmin


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1251 of 1287 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.2%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.32%25-yellow.svg)


This is amazing. Never knew this existed.


ononn


Could we rename `tmp_size` to `size_without_bounds`?


+    val array = FrameRdd.schemaToHiveType(frameRdd.frameSchema).map(column => "{\"name\":\"" + column._1 + "\", \"type\":[\"null\",\"" + column._2 + "\"]}")


Not till we push it to master. It seems to be similing..Reverted the accidental removal :) +1


i do whatever i want, or make a pull request


:tada: pretty much what i did too


Nice!