agreed it should be consistent, and I suspect returning the full URL would be best/easiest for the frontend to digest. I'll make a note to check/change all of those in the future. For now, do what you need to do.


Checkmarx scan results 10 Aug 2015 14:22 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
4
77
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2f6608a18bc6fe16a3021885ca69e8f9b24cb080	@dortal

b82a152e075fd0f150dd1393c2caf08d66492de5	@dortal

bad0eb9213d6d3907804654182c8d8e99949ed75	@dortal


Originally authored by @dietzc. That information got lost during a rebase/amend.


update fireball-x/fireball#127


'Alert' for a generic channel?


Thanks!  I imported the list you sent through.  Many could not be imported because they were not git or the git had been deleted.  There was about 360 that were imported.


$scope.getQueryParam do this job :smile_cat:


이렇게 함수를 매번 만들기 보다는 상단에 선언하는게 좋을 것 같다.
만약, 상단에 노출되는게 부담스러워 그랬다면 함수를 감싸서 실행하면 좋을 것 같구나.
```js
(function(){
  function appendWithTemplateEngine(){...}
 var TODO = {
   addList : function(){
        appendWithTemplateEngine();
   }
 };
})();
```


Splendid choice of name.


이렇게 섞어 쓰면 나중에 관리하기 힘드니깐 가능하면 jQuery을 사용하고


Checkmarx scan results 10 Aug 2015 14:25 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

066faacc9ca52024f595658c479a6512664fec3f	@cxehud

819fa7d134597cf7a0a066783d202092186de793	@cxehud


What is the point of this variable?


Also, I added this page if you want to connect to the minetest-bower registry:
https://minetest-bower.herokuapp.com/docs/registry-curl


Latest Muffin versions supports `dependencies` for Plugins:
```python
from muffin_redis import Plugin as RPlugin

class Plugin():
    dependencies = {'redis', RPlugin}
```
That will check also for app.ps.redis (app.plugins.redis) is instance of muffin_redis.Plugin.


`$this->cursor = @mysqli_query($this->connection, $query);`
From the PHP manual: *mysqli_query*:
> Returns FALSE on failure. For successful SELECT, SHOW, DESCRIBE or EXPLAIN queries
> mysqli_query() will return a mysqli_result object. For other successful queries mysqli_query()
> will return TRUE.


This commit was reverted or not ? We don't need to reduce the uboot treasures !


ended up removing it. Looks like when you call `.onCompleted` the subject could stop emitting events, so only the first search works, the `subject` inside `LocalSearchEngine` is created only once as a final member on `MainApplication::create` which invokes `LocalSearchEngine::create()`


You can find the sample pdf in:
https://drive.google.com/file/d/0BxCtn0DDxN5WUEd5bXo3NGxRa00/view?usp=sharing

you can check the pdf with and without the code modification of this issue.


Checkmarx scan results 10 Aug 2015 14:28 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

828c968c0bc83f8dcfd1ac7510ebb8f99dc49e95	@cxehud

8519a07ef8bc18522be3b20f0edce9cb8b74da9d	@cxehud


I'm not sure why representation is part of the Channel?
Surely a single channel could be used for multiple representations?


Checkmarx scan results 10 Aug 2015 14:27 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

c9fe25f9884708c258e7020b958e7b510ecad620	@dudug


Checkmarx scan results 10 Aug 2015 14:28 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

075e70bf9cb753d7b2c805b96dc27e30d7b2994e	@cxehud


Checkmarx scan results 2015-08-10T11:24:35Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

4213c838a618ed238d1d57f49037a96664292cf2	@dortal


Doesn't this mean that each time `request.getBody()` is called, a new `Promise` is created and the body content is ready again? This is why I moved the promise creation into the constructor, so that we kept returning the same Promise to anyone who wants it along with the caching it so the body is never read a second time.


Too big commit. Each each modification should be commited separately.
For example I see here commits like:
* Role model added
* User model added (or 'User model added with devise fields' if is one migration)
* Devise basic configs
* Switch to postgresql

BTW, config/database.yml is usually not added to git because it may contain your personal credentials or db info. To help other developers write own database.yml you can add config/database.yml.example file


Thanks for understanding. I know you've done lots of OSS as well, so I'm glad that you care enough to reach out. I'm considering making a 1.0 release of django-configurations soon and then call it done and move on. Maybe that will be a good time to do another call of participation.


@dbolkensteyn The `CodeFixContext` is a context for one given diagnostic.
At the moment there's only one code fix provider (`RedundantParenthesesCodeFixProvider`), which registers a single code action. In the future we'll have issues that can be fixed in multiple ways, and the user will be able to select the action that needs to be executed. The current version of `VerifyCodeFix()` is not prepared for this use-case. We'll need to either pass in the index of the code action to be executed, or get this information from the test input files.


This seems to be notifying all FTP channels?
This seems the wrong approach, as we might have FTP channels for multiple purposes.
Can we not store this within the subscription table?
i.e. the subscription table links to a channel_id & has the representation


Note that here you print a message but then continue as if nothing had happened. I think that the algorithm is going to fail if the file is not found, is it? If so, then this print should be more like `raise RuntimeError('error message...')`


Checkmarx scan results 10 Aug 2015 14:27 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

075e70bf9cb753d7b2c805b96dc27e30d7b2994e	@cxehud


훌륭하네.
localForage을 사용하고 굿.


@madhuracj  this introduces a bug for me: error 500 when clicking on any db name in the navi panel


An api to get current version num  is convenient


Oh, you're right. Thank you!


Same as above?


Yeah it does, but both ways are broken.

Eventually, we have to not keep the body in memory longer than necessary. We have to release after the promise subscriber gets it. This means users will get one shot at the body.


Thanks, but I'm not sure if I like tackling with "timeout". Timeout meaning has gone long way from the initial implementation and now is a key element in building up frame sequence of projectiles hit time for following damage simulation. Anyway I'll take a look at the overall picture once I have a spare minute.


+1 for this, do you want to create a pr with this change?


What exactly is 'page_url' here?
/eden/module/resource/record_id ?

I am uinclear as to why the representation is separated...seems odd to me...why not include that here & then have everything built up at the higher level?


Cool, I will do tests and update the plugin.
Thank you @klen


I have just pushed the fix for the issue. You are right that the commit was not enough.


Got it. Ok. So we'd end up with some type of `AtomicBoolean` here that flips on the first read and subsequent reads throw an exception?


I cannot find the way to start the tinymce if i have the library.. where ```tinymce.init({..})``` should be?


Checkmarx scan results 10 Aug 2015 14:35 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1f430eded56cdc5e397909c2a630f38d305933eb	@cxehud


잘했다.
해당 로직은 상당히 많이 쓸만한 알고리즘인데 잘했다.


Authentication?
This will currently only work for Public Alerts yet people can subscribe to private ones.
See here to how to reuse current session for local requests:
https://github.com/flavour/eden/blob/master/modules/s3/s3gis.py#L378
Remote requests may well need HTTP 1.1 username/password adding, but maybe that can stay an @ToDo for now as not in-scope for this usecase


Checkmarx scan results 10 Aug 2015 14:35 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

c9fe25f9884708c258e7020b958e7b510ecad620	@dudug


Yep, but doesn't need to be atomic.


The rule is fuzzy - if it "fits" on one line then put it on one line.


q


Weird filename structure!
This seems very specific to the usecase so maybe pass the filename as a param & have this structure in the calling usecase?


Looks like you misspelled "canola"!


also, what exactly does this commit do?  I'm not familiar enough with mtpm, so its not making much sense to me.

It seems to allow searching the bower-minetest registry, is that right ?

Heres the script I used to import your registry:
https://github.com/cornernote/minetest-bower/blob/master/src/commands/PackageController.php#L24

Its a bit hacky (added manual mods to skip because I wanted to check the ones that didn't import).  I'll soon clean it up and it will try all mods and skip over any that no longer have repos, or ones it it cant validate.


thanks! now it works fine


Checkmarx scan results 10 Aug 2015 14:37 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1f430eded56cdc5e397909c2a630f38d305933eb	@cxehud


Is completely reasonable have only one shot for reading the body. In the rest of frameworks it behaves like file object that can be readed once ;)


I already reverted the change in EntityData.h to removed the const in all cases, it was not very useful anyway.


This is very usecase-specific
I think all of this file fetching & formatting should be in a separate function to the actual FTP channel send.
The FTP channel send function should be passed a StringIO as param


[Fixed on master](https://github.com/weaveworks/weave/commit/fd2a59417d1a0f7247f71a02dc25f0df08889758).

> should require this in my PR reviews

up to you


잘하긴 했는데 좀 더 세련되게 만들 수 있는데...
done부분을 좀 더 고민해보자.


I'm not convinced of the value of this deployment_setting
For this usecase the representation should be part of the subscription table I think (We'd like future usecases to allow people to subscribe to XLS or PDF representations via Email or FTP)


Checkmarx scan results 2015-08-10T11:37:20Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

4213c838a618ed238d1d57f49037a96664292cf2	@dortal


Checkmarx scan results 10 Aug 2015 14:42 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

06d957cdbe835b3afce0526a58c7effc6847b7b9	@cxehud

6bf1ed7f9e3f7d1da7182c2e5efe97700cc13317	@cxehud


Can't tell more than @Piedone said, but this is a critical piece of code - we need unit tests for this (some multi-threaded scenario).


Checkmarx scan results 10 Aug 2015 14:42 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3d67385fc72bb7477487505938706ebda9cf3ecb	@cxehud


for job no attachment


jquery - draw2d - HTML5


注意，虽然我们设置了body的宽高，不过浏览器显示的时候还是铺满了整个页面


Звідки це взялось?


Would be nice to have an example of how you can pass params in the README perhaps?


Thanks!


Checkmarx scan results 10 Aug 2015 14:44 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ffed6f3c148f23deaa2c4243cd21f3695a283534	@cxehud


이건 오류인 것 같은데...
수업시간에 물어보렴.


Just a testo


My preference is to not use `/etc/scaleway.conf` for init services (unlike I said before), and use standard init services configuration files, so `/etc/rc.conf` for *openrc* and `/etc/defaults` for *upstart*, etc.

I think we will use the `scaleway.conf` tool if we release daemons, like a daemon that populate our API with metrics, or another daemon which monitors NBD devices hot attach/detach requests


@dukesrg It's safer, that's all. If someone forgets to delete a file (that they manually copied), or if "make clean" fails to delete some files, well...
Anyway, the ZIP creation is not a bad idea :+1:  "make zip"?


Use error in capital letter


Checkmarx scan results 10 Aug 2015 14:42 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3d67385fc72bb7477487505938706ebda9cf3ecb	@cxehud

06d957cdbe835b3afce0526a58c7effc6847b7b9	@cxehud

6bf1ed7f9e3f7d1da7182c2e5efe97700cc13317	@cxehud


І відповідно шо за title?


Remove Unused spaces


Shouldn't this be an `ISingletonDependency`


ok, but I fear we will have an empty file of 4Gb.

We should test both solutions and choose the most appropriate one dependending on `QCow2` format behavior


Nice \ Kappa /


use string constant in place of hard-coded string


Because syntax `Class\Name: self` is deprecated for long time 48388d9f8259f11224d7e352d392f3e1422c00ef


Checkmarx scan results 10 Aug 2015 14:46 UTC +03:00

High
Medium
Low
Info

New
72
61
66
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

d5a07cb0b1744f15f637a4c7ffe8f2ac25f77bdd	@dudug


I haven't seen any real thread-safe boundaries here. At least in web-garden mode we have to assure the lock-acquiring process is atomic and thread-safe.


Just start TinyMCE on a different page

```javascript
tinymce.init({
           file_browser_callback : function(field_name, url, type, win) {
            // from http://andylangton.co.uk/blog/development/get-viewport-size-width-and-height-javascript
            var w = window,
                d = document,
                e = d.documentElement,
                g = d.getElementsByTagName('body')[0],
                x = w.innerWidth || e.clientWidth || g.clientWidth,
                y = w.innerHeight|| e.clientHeight|| g.clientHeight;
            // Url absolute
            var filemanagerURL = 'filemanager.html'+'?field_name='+field_name+'&lang='+tinymce.settings.language;
            if(type == 'image') {
                filemanagerURL = filemanagerURL + "&type=images";
            }
            tinyMCE.activeEditor.windowManager.open({
                file : filemanagerURL,
                title : 'Filemanager',
                width : x * 0.8,
                height : y * 0.8,
                resizable : "yes",
                close_previous : "no"
            });
        }
```


What would that bring?


State을 구현했다는게 무슨 말이냐?


kynang kn=db.kynangs.Find(x=>x.manv=="id" && x=>x.makn="idkn").tolist();


Checkmarx scan results 10 Aug 2015 14:48 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

9e190be85d4e370fa9f408b87545146350b5c394	@cxehud


내가 이해한게 맞다면 신영이 말대로 하는데?
수업시간에 물어볼래?


I think the PDF Mime type needs adding to http/request_handler.js
Line 482: RequestHandler.getMimeFromPath = function(resourcePath) {
        var map = {
...
pdf: 'application/pdf'
};


gfh


I guess we should rewrite this line to be more version agnostic.. atm you "need to" change this line for every version you release.


Checkmarx scan results 2015-08-10T11:51:02Z

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

4213c838a618ed238d1d57f49037a96664292cf2	@dortal


can we have `file_` instead of just `file`?


LOL. Just completely missed that one. ^_^


아마 저번 수업 전 인듯?
서버를 실행해야 한다,


Is there a good reason to use the `dict(...)` notation instead of `{...}` in this case?


Ahhh the joys of running a fork.

There's been some good bug fixes / additions since this went into the master branch :P


LGTM!


rubyのバージョンを2.2.2に変更


see https://github.com/kelunik/travis-php/pull/3


Checkmarx scan results 10 Aug 2015 14:53 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

a9c216b0b131b3eb48d30a044bf36b812215c8c8	@dudug


@Aaron1011 It's because @Zidane changed the place of the injection in https://github.com/SpongePowered/SpongeCommon/commit/088066eed2948d45013c0a4a40e10833ab17836e, from the invocation of `addChatComponent` to `addChatMessage`


Checkmarx scan results 10 Aug 2015 14:54 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

5036e2ca99e2863a443b2404ebbe984af70ee251	@dudug


이 로직은 탬플릿쪽에서 하는게 좋아.
왜 그러냐 하면 view단의 간단한 조건/반복문은 template쪽에서 관리하는게 좀 더 관리하기 좋기 때문이야.


できればgemのバージョンを指定するのが好ましい


Checkmarx scan results 10 Aug 2015 14:53 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ac5b8ed82cf1634aac7acd5eecf911841aad9300	@cxehud

1dc971f69bc3e9a864f66a99d1494db0e2e76f03	@cxehud


@arter97 @temasek this commit breaks building on 64bit..


디폴트 빼주세염


Checkmarx scan results 10 Aug 2015 14:56 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
72
61
66
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

5036e2ca99e2863a443b2404ebbe984af70ee251	@dudug


You are not updating libs :-1:
https://github.com/arter97/android_frameworks_webview/commits/cm-12.1
Please Refer This @noname55804


@ercanozkaya Would add a code comment here what the 'true' is for.


Would be cool if you posted that before the merge :P


하는 일을 명시적으로 적어야 한다고 생각함.


Improvements suggested. Need more learning in Core Data. UI changes and crashes should be handled.


Mistype in «возмжности» fixed in the next commit.


@pszmyd Why?


Dependencies are per work context. I just haven't seen anything that might prevent from same instance trying to acquire a lock on different threads.


i assume it's also needed on the other branches and not only on 3.4.x?


Ahh my bad! - got it mixed up with `$this->connection`


Checkmarx scan results 10 Aug 2015 14:57 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

875da3d9e14b9a3e638333905d3a3d5466b31fba	@cxehud

31d5c92c0ed61544fdff4a27b5a0590065337177	@cxehud

34b056fe5e0803360c7924ba4a189d43587513f1	@cxehud


testing something


test


Hi BaiYuan,
The syntax '[B<-s>] I<scan_method> [B<--range>]' looks not correct that -s is optional so it should be in [], but --range is mandatory, so it should be not in the [].

And for the description of '--range', you should add more information like switchdiscover command does.


Why the removal?


for testing


Log?


@hbun DWMR. press on.


요즘엔 엘리먼트에 data의 성격의 값은 data속성에 저장한다 attr, prop는 실제 엘리먼트의 속성 값을 변경할 때 사용하고


@flavour should this be okey?


@timgraham said that it doesn't need to be here, and I could just move out my media_root somewhere outside :)


总结：1.父子关系，设置上下相同方向的margin方向，如margin-top，取最大的值。父也会受到影响(向外挤压)。【ps：兄弟关系，设置上下不同方向的margin方向，如一个top，一个bottom，就取最大值。】
2.父子关系，设置左右相同方向的margin方向，如margin-left，不会有啥影响，类似外层设置了padding-left


Declared stream if topicAsStreamId flag is set


@hbun DWMR. Well done here. Good.


moved topicAsStreamId flag check outside for loop


You moved this line to *common/driver-linux.h* - is this wanted/needed?


오. indexeddb을 사용했구나.
잘했다.


@hbun DWMR. Continued success. Excellent. Press on.


I can do that but don't have a good idea how to do that. One way that would work is to add this to your init file:

```lisp
(require 'async-bytecomp)
(setq async-bytecomp-allowed-package (delq 'magit async-bytecomp-allowed-package))
```

But that probably won't make you happy because you have to load the library you don't want to use for it to work. The only alternative I see is doing this in both `magit-popup.el` and `with-editor.el`:

```lisp
(defvar magit-inhibit-async-bytecomp nil
  "Prevent loading of `async-bytecomp' and enabling of `async-bytecomp-package-mode'.
This variable is defined and used in both `with-editor.el' and `magit-popup.el'.")

(and (not magit-inhibit-async-bytecomp)
     (require 'async-bytecomp nil t)
     (fboundp 'async-bytecomp-package-mode)
     (async-bytecomp-package-mode 1))


Use logging.


TeamCity xBIM :: Xbim Essentials :: Release [Build 67](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2220&buildTypeId=XBIM_XbimEssentials_Release) is now running


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Checkmarx scan results 10 Aug 2015 15:06 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8ab4438b7ea7ee888b46b5d542b4a71408d35dbe	@cxehud


Why Try/Catch ?


@hbun DWMR. `return self.checkpointSuccess`


Checkmarx scan results 10 Aug 2015 15:06 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

58f110714e7b5393cc183275302da679cb709b08	@cxehud

c5094ae76ef9513c473eb624c1c2cea88d3bf89c	@cxehud


This will create a new lifetime scope and a new DB transaction with the `ReadCommitted` isolation level. I'll do some tests and see what gives and add unit tests as well. Thanks both.


OK。


uglavnom prije sifre nisu radile tj kad se radi update accounta jer nije radio onaj hash md5 kod upisa u bazu ja provjerava to kod logina i logicno ne radi osim onoh koje smo rucno unijeli u bazu hash-irane


TeamCity xBIM :: Xbim Essentials :: Release [Build 67](http://ncl-xbim.hq.4projects.com:8080/viewLog.html?buildId=2220&buildTypeId=XBIM_XbimEssentials_Release) outcome was **SUCCESS**
Summary: Running Build time: 00:01:26


ah, understood, moving on :)


Shouldn't this be indented within the permission check?


Great :+1:  way better then hard coded strings.
I think we should note this in the upgrade log since people can get upgrade issues while parsing the message?


Ah, you repeat it here? Indenting is better surely?


It is already applied on newer branches. Thing is that current Hibernate tools uses hibernatetools.jar 3.4  for  Hibernate 3.5 and this version still reference sourceforge.


I've been tinkering with the AutoIt code to get up to speed, but I haven't seen the source code posted for the DLL files, particularly, BrokenBot32.dll
Is there a place I can find a list of functions housed in the DLLs, their syntax, and perhaps even the source code?

All Source code (autoit and c++ source for dll): https://github.com/CodeSlinger69/ClAsHbOt


I'm not clear on why we have an assign_btn?
What does this do which the tab doesn't?
Seems redundant to me?


ok cool, i'll merge the pr


trunk fix with new LLVM header


Is that struct used for getting the benchmark port (PIO in FPGA) available in kernel stack dedicated for host?


it was for checking the input if user giving other then binary no in input
ie 1 or 0

On Mon, Aug 10, 2015 at 5:36 PM, nikhil-b <notifications@github.com> wrote:

> Why Try/Catch ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/meta-udit-nagar/get2015/commit/bef96238dcf132a7ca5ebc689a4fe457e409be58#commitcomment-12613103>
> .
>


동유 생각이 맞다.
indexeddb는 특정 범위에 맞는 행을 가져오는게 아니라 매번 continue을 호출해서 한행씩 가져온다.
추가하면 [index](http://code.tutsplus.com/tutorials/working-with-indexeddb--net-34673#highlighter_866011)을 만들 수 있고, sql의 where구문 같은 [bound](http://code.tutsplus.com/tutorials/working-with-indexeddb--net-34673#highlighter_142408)가 있으니 나중에 한번 같이 공부해보면 좋겠구나
그리고


It would be nice to extract authentication to its own method to improve readability.


Are you suggesting we should add thread synchronization code here? Maybe we should, since multiple threads can in theory access this code.


Done.


@nastys if make clean fails, why would make distclean not fail? :)


@richardmuscat we were purposely not committing grunt to this branch until it was 100% completed, as it causes merge conflicts and headaches when comparing to `master`.


Wouldn't have been better to remove these from constants.lua instead?


This doesn't work. This is the same as
```
If(!mUsingGBRForest) {
   std::lock_guard<std::mutex> lock(m_mutex);
}
```
So the lock is take and then immediately released.


図の差し替え，了解しました．意欲的にGITHUB使っていますね．すばらしい．


Checkmarx scan results 10 Aug 2015 15:13 UTC +03:00

High
Medium
Low
Info

New
4
1
3
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

7a089b44e1e3777c722a2d2d2e822ca9b3d268dd	@cxehud


OnePlus have fixed this bug.


Checkmarx scan results 10 Aug 2015 15:14 UTC +03:00

High
Medium
Low
Info

New
0
6
44
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

b1ed15301234f62420e598e68e51d2155a945f2b	@dortal


In commit da43bbf3078450daa90d508b3798b0f0084671a6 the inline macros (which were unused in stack) have been removed. In commit b28ed2b1448407301d251e3fb1add4b3cb5344c5 an empty define `INLINE` has been introduced. Please change winkernel.h accordingly!


What about this:

```C#
public bool TryAcquireLock(string name, TimeSpan maxLifetime, TimeSpan timeout, out IDistributedLock @lock) {
            var machineName = _machineNameProvider.GetMachineName();
            @lock = _lock.Value;

            if (Monitor.TryEnter(_sweepLock)) {
                try {
                    var waitedTime = TimeSpan.Zero;
                    var waitTime = TimeSpan.FromMilliseconds(timeout.TotalMilliseconds / 10);
                    bool acquired;

                    while (!(acquired = @lock.TryAcquire(name, maxLifetime)) && waitedTime < timeout) {
                        Task.Delay(timeout).ContinueWith(t => {
                            waitedTime += waitTime;
                        }).Wait();
                    }

                    if (acquired) {
                        Logger.Debug(String.Format("Successfully acquired a lock named {0} on machine {1}.", name, machineName));
                        return true;
                    }
                }
                catch (Exception ex) {
                    Logger.Error(ex, "Error during acquire lock.");
                    throw;
                }
                finally {
                    Monitor.Exit(_sweepLock);
                    Logger.Debug("Ending sweep.");
                }
            }

            Logger.Debug(String.Format("Failed to acquire a lock named {0} on machine {1}.", name, machineName));
            return false;
        }
```


@EugeneButusov, it's brilliant.
1. Does it need any special actions for developers to make it working?
2. Does it just replace the old functionality (via Safari), or developers are able to switch to it?
3. Do you know any pitfalls of your solution?


Humm... true


Checkmarx scan results 10 Aug 2015 15:15 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

7a089b44e1e3777c722a2d2d2e822ca9b3d268dd	@cxehud


Looks like aliasing in the logging. Work is under way to timestamp each message individually.


Nope I give it a try.


ArrayBuffer has length property. I'm not sure sending size is good examle.


@tarsius Mmh, I don't have any idea either, but I do not like that a package messes with byte compilation of packages merely because it's loaded, and I wish that as a community we could agree to leave the core of Emacs alone instead of advising core code to work around real or imagined shortcomings, or to cover up our own mistakes—which, no offense meant, is what async-bytecomp effectively does.


Remove comment `//((void)0)`


Just for me to clarify: The atomic ipcore support will be added later and/or in different file?


Hm, spinner shows for me.  Any console errors or anything?

> cool slide-up animation thingy
I don't remember one, but I _think_ I know what you are looking for.  I'll get something implemented


@marcelmoosbrugger you used "this.$find(constants.bankAccountAddId)" 5 lines above (line 519), maybe use it here too?


Checkmarx scan results 10 Aug 2015 15:18 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

7a089b44e1e3777c722a2d2d2e822ca9b3d268dd	@cxehud


Does it make sense adding own WIN64 DEV_- and TARGET_SYSTEM?


Checkmarx scan results 10 Aug 2015 15:19 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

681e31884bd5f6c5aee41cd2b992198654bbc4dc	@cxehud


denemeeeeee


Is "kernel mode" also working/tested with 32 bit?


Same as above, why not `{...}`?


I aggree with @johanw666.


If ``.url`` was called on a single page instance many times, I can see this being a massive improvement. But I don't think this is the case most of the time.

I'm a bit wary of adding extra layers of caching unless there's a clear performance benefit due to extra complexities (eg, invalidation).


a


Checkmarx scan results 10 Aug 2015 15:22 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
6
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

5bd99d0610c2b3920a65df7f3b6003c735687d89	@dortal


Skip my question, of course it is :)


I don't see in the test where exactly you add a new version of the document.


What does that store? Can you add a comment?


> AFAICT, the term "specialized overlaod" is used to describe a method in a synthetic specialized subclass that generically substitutes the specialized type args into the siganture of a generic method.

AFAIU, the specialized overload is 't$mcI$sp(t: Int)`, while `t(i: Int)` is a specialized override. @dragos?

Btw, @retronym, this is the diagram where I set up the miniboxing terminology: https://github.com/miniboxing/miniboxing-plugin/blob/wip/components/plugin/src/miniboxing/plugin/metadata/MiniboxMetadata.scala#L30-L57


Add empty line after line 48


I'd rather use normal `lock` on some object field, but making sure the `iLockService` is a singleton dependency first. For the sake of clarity.


Checkmarx scan results 10 Aug 2015 15:25 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

e7f7bf424b6aef41cdcb0c9694762e5eed7bf14e	@cxehud

c9f83677b10a482582ad2decf227a06c5059ea79	@cxehud


I'm using skype api for making a Skype CLI (Command Line Interface), i tried to get the all the contacts available using Skype.getAllChats but it throws this exception:

Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/commons/lang/SystemUtils
	at com.skype.connector.linux.SkypeFramework.init(SkypeFramework.java:54)
	at com.skype.connector.linux.LinuxConnector.initializeImpl(LinuxConnector.java:82)
	at com.skype.connector.Connector.initialize(Connector.java:485)
	at com.skype.connector.Connector.connect(Connector.java:433)
	at com.skype.connector.Connector.assureAttached(Connector.java:985)
	at com.skype.connector.Connector.execute(Connector.java:904)
	at com.skype.connector.Connector.execute(Connector.java:861)
	at com.skype.connector.Connector.execute(Connector.java:827)
	at com.skype.connector.Connector.execute(Connector.java:786)
	at com.skype.Skype.getAllChats(Skype.java:705)
	at com.skype.Skype.getAllChats(Skype.java:647)
	at skypecli.SkypeCli.getContactsList(SkypeCli.java:123)
	at skypecli.SkypeCli.updateScreen(SkypeCli.java:181)
	at skypecli.SkypeCli.main(SkypeCli.java:78)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.lang.SystemUtils
	at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
	... 14 more

by the way i'm running linux (Antergos i686).


Any good reason for have it `null=True, default=None`? A `CharField` in Django [shouldn't be null but empty string](https://docs.djangoproject.com/en/1.8/ref/models/fields/#null) (i know we have several of those already, but I'm not happy about them either).


@Dwar3xwar DWMR. `[UIColor greenColor]` go!


Usually we have here an empty line (after line 39)


add empty line after line 45


Приколисты  :(
С диапазоном портов тоже не все просто. Можно было бы использовать UINT16_MAX из stdint.h, но ядро со своими инклюдами собирается и не нашел в исходниках ядра, чтобы UINT16_MAX особо использовали. Так что видимо тоже литералом придется.


add empty line after line 54


Hmm it's not possible since the DX surface is not available. It might be possible but it'll take a fair bit of change.


```python
ValidationAnnotation.objects.filter(
    file_hash=instance.original_hash).delete()
```


the file name format for Linux and windows is different. so I have moved the Linux specific file name to *common/driver-linux.h* and windows specific to common/driver-windows.h


@Dwar3xwar `comment.from` needed to be `comment.from.userName`. As it was, it was showing the user object name/id.


... to the **PDO** address returned ...


Updated Netty to 3.10.4 --> should be "reverted to", right? :+1:


잘했다.
이렇게 하는 방법말고 좀 더 세련되게 할 순 없을까?


a


yes, this structure will used to get the HOST benchmark base address.
Ok, I will update it.


Thx for clarification!


thanks. I will make the change


okay


Wouldn't it be nicer to use [jquery's `.data()`](https://api.jquery.com/jquery.data/) here?


뭔가 이상한데?


s


`.append().prepend()`?


q


Kusha ridin :dancer:


The atomic IP core support is added as a separate change in the same file as follows:
````C
#ifdef CONFIG_PCIE
//TODO@gks: Retrieve the Atomic memory base address from PCIe headers
#define  ATOMIC_MEM_OFFSET      0x80000
#define OPLK_ATOMIC_T           UCHAR
#define OPLK_LOCK_T             UCHAR
#define OPLK_ATOMIC_INIT(base)
#define OPLK_ATOMIC_EXCHANGE(address, newval, oldval) \
                        OPLK_IO_WR8((address + ATOMIC_MEM_OFFSET), newval); \
                        oldval = OPLK_IO_RD8((address + ATOMIC_MEM_OFFSET))
#else
#define OPLK_LOCK_T      UINT8
#define OPLK_ATOMIC_T    ULONG
#define OPLK_ATOMIC_EXCHANGE(address, newval, oldval) \
            oldval = InterlockedExchange(address, newval);
#endif
```


This should be `has_many :answers`


version


version 2.0


For what is this macro used for?


I'm not sure we want to use the `lock` keyword, since I don't want to block until the semaphore becomes available again. If another thread has a lock on it then that's fine an I want to move one, not execute the code again on the same machine.

Also I still don't understand why it would be more clear to make `ILockService` a singletone. Could you elaborate on your reasoning for my understanding? Thank you


Update on RNIB including details of Online Today project.


@VladUreche That terminology makes more sense, thanks for the clarification.


add함수를 보면 아래와 같다(complete, remove도 같은 이슈)
```js
        if(navigator.onLine) {
            $.ajax({ type: "PUT", url: this.url, data: { todo: todo }, contentType: this.contentType,
            }).done(function(data){
                callback(data);
            });
        } else {
            callback({todo:todo, insertId:TODOSync.offlineID});
        }

        //ls에 저장
        var todoObj = { 'todo': todo, 'completed':null, 'sync': TODOSync.sync };
        localStorage.setItem(TODOSync.offlineID, JSON.stringify(todoObj));
        TODOSync.offlineID++;
```

이렇게 하면 online일 때 ajax의 결과에 따라서 UI을 변경해야 할 지 말 지를 결정해야 할 것 같은데 이 부분이 이상하지 않을까?


khodet gofti commit bezan


Ok, but it's not the same.

Let's say that I've got and interface Namespace\IFoo. So I create a service with name Namespace\IFoo and specify the default impementation by class option. When I need to overwrite it or add some setup in local config, I do not need to think about the name of service and simple use her class name. It's simple and efective.

Example:
**module.neon:**
```
services:
   Namespace\IFoo:
      class: Namespace\Foo
```
**config.local.neon:**
```
services:
   Namespace\IFoo:
      setup:
         - setBar('foo')
```


Checkmarx scan results 10 Aug 2015 15:33 UTC +03:00

High
Medium
Low
Info

New
0
6
44
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

5bd99d0610c2b3920a65df7f3b6003c735687d89	@dortal


Ok thx!


Thanks for testing that!


Checkmarx scan results 10 Aug 2015 15:34 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

53507e9f890bdf2fab532bcea011fd0fdc934109	@cxehud

a4a78a5797af3d9243b3102d3b2b1b4ad6039d1c	@cxehud

cd80550af937ef90abefa46eb6deaba462b19581	@cxehud


this all could be written much easier with something like

$last_module = array_pop( $module_name );
$jumpstart_module_list = implode( $module_name, ', ' ) . ', and ' . $last_module;


It would be great, to know what is the real security requirements for BA... I would prefer to review the functionality first then extract the real needs/requirements for BA then we can implement that and "polish" the code


Hi @tysonjhayes,

Please do not be offended. English is not my native language. I wonder if "Dependancies" is a dictionary word or a simple typo. I am only able to find "Dependencies" in American and British dictionaries.

Thanks,
Daniel


우와. $.when을 사용했네.
근데 동작하지 않지? 왜 그럴까?
수업시간에 물어보도록.


I understand and respect your argument but I simply see no other option. When you update from 1.4 to 2.1 without first uninstalling 1.4 then you do get a corrupted build (and it appears that does not get fixed when later updating to a post 2.1 snapshot).

I suppose I could reply to every bug report with "uninstall, restart, reinstall" instructions. But that would only help those users who report bugs (which turn out to be corrupted builds), it does not help the thousands of users who also have a corrupted build but don't report the issue. So I could address the issue by showing the "uninstall, restart, reinstall" message at startup until the user sets a variable (and hope that s/he actually read, understood, and followed the instructions). But, as you know, some users hate it when I such things.

So the only choice I have is between two evils and patching `package--compile` is in my eyes by far the lesser evil than thousands of users using a corrupted build of magit.


Checkmarx scan results 10 Aug 2015 15:36 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

73de1bd4609a9a608c3f07b007d78d3931d19a86	@cxehud

a879c4e606040110e9493cba5211ed2eea9c8f07	@cxehud


Why we need manually add trailing slashes here?


I'm not really a big guy in vimscript, so this code was "inspired" by stackoverflow :)
On the other hand, it works.


I've not been on my PC since the beginning of last week so I only just saw this :P


Should I just merge these into TestExtractTID() test? It didn't feel right, but leaving like this is quite unconventional, too.


Checkmarx scan results 10 Aug 2015 15:37 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

e8fd3702255de38f14159771e5ea0125dc6480f9	@cxehud

8730410bbcaa82372d4122cc10da7760403f638b	@cxehud

00c786c79bc5552a77efe39cd08ea7fa722a7cfb	@cxehud

76c3b41cd454301ef670ae496a23c500ed6634ed	@cxehud


Generally, I never noticed any major changes specific to the 64 bit windows system but for a longer run, I think we should separate them.


For #23


Checkmarx scan results 10 Aug 2015 15:38 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
6
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ea33e4d3e43590c6e640d2747674266d04cc1bc5	@dortal


@tarsius What kind of corruption?


꺄


Dynamic frameworks (shipped embedded in other frameworks, apps or bundles) have existed on OS X since 10.0. Is this just worded a little strangely?


I have not tested it on 32 bit system (no scope to change on APC2100) but I don't see a problem running the driver on 32 bit system.


Just noticed a typo here (`toplevel-funcitons`) - not sure if that has been fixed in `master`.


Is it heavy effort to separate WIN32 and WIN64?


Yep. Indeed.


Si, esto es lo que te menciono , es rails ,en sus primeras etapas xp
pero si es rails


Checkmarx scan results 10 Aug 2015 15:43 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

152ac2e82b735bf52bba99709a33f80fc4914ba8	@cxehud

847daf9e637e5708d28060d8e655009966b36a37	@cxehud

b46fab53738c0493b0744033bee3933f12deaec6	@cxehud

bfecafc2980fef3b9d8611d030dd8a2c90886c69	@cxehud

05acf2efa05f918823eb26f7ac8e8f3f101c3f4a	@cxehud


Okay fine, but for final release we should keep that in mind?


Signature of this method is not compatible with definition in the interface


@flavour is this good for merge?


Чуть симпатичнее, на мой взгляд, делать такие вещи вот так:
```java
if (!orderValidation(orderList))
    return null;

//все остальное
```

Позволяет поместить основной код на один уровень идентации ниже.


don't commit binaries


Лучше назвать `orderIsValid()`.


`standardOrder`?


that did it! Thanks!

On Mon, Aug 10, 2015 at 6:06 AM, Nicholas Buse <notifications@github.com>
wrote:

> Try: git reset 63d413a
> <https://github.com/opengapps/all/commit/63d413ac7e1f3521d5c212bf64b93eacac21e390>
> then git pull
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opengapps/all/commit/06c3d69c7db90ecdedfcec86815302f3a30d7ba3#commitcomment-12612047>
> .
>

--
<http://www.facebook.com/djalik>  <http://twitter.com/#!/DJAlik>
<http://www.linkedin.com/in/alexrusinov>
<http://plus.google.com/114580313768137070684>
<http://www.mixcloud.com/djalik/>
<http://psnprofiles.com/DJAlik>


For example it is not possible to change a struct - one cannot add or even just rename a slot without breaking the build. Then there have been several reports where the current code simply cannot be doing what the user insisted it was doing. I did not investigate why exactly the old code was still being used.


Git attributes makes git use * nix line endings.  That is
.  Windows normally is
\r.  I have my git check out to system defaults.  The change I made worked in both.  However that is dependent on git being installed without checkout as is.  Try installing git again it will prompt for selection.  Otherwise I am sure there is a setting to make local apply correctly.  That in turn guarantees system line separation works.  Github does create new repos with the line normalization.

Sent by Outlook for Android

On Sun, Aug 9, 2015 at 5:13 PM -0700, "Marvin Froeder" <notifications@github.com> wrote:
indeed. looks like you git configuration is changing the file and making it system dependent.

What configuration do you have and is it really necessary?

---
Reply to this email directly or view it on GitHub:
https://github.com/revelc/formatter-maven-plugin/commit/e0ae79082f4b415ee0fb84844dd3540d07175f7e#commitcomment-12606318


Tested that this behaves as I guessed. I have filed FLOC-2841 to fix it.


no newline at end of file


@opengapps/packagers, I manually removed API14 here and squashed my removal commit with this AP16 add. There is another Slides commit in arm (240) that I will do this for too.

For this one do:
```
git reset 3315ba56c3445a6b76ecdbe272fd7b8e36eec774
git pull
```


That's weird. I'll look into it.

On Mon, Aug 10, 2015 at 9:05 PM, Sanyam Jain <notifications@github.com>
wrote:

> http://hastebin.com/pelapoduxo.vhdl
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android_system_core/commit/fde032f93a0d32129c71aac9fd4ab584f8650847#commitcomment-12613076>
> .
>


It's just for clarity. We're speaking about locking here, which should be applicable per-tenant by default. Hence keeping it per-tenant (as in `SingletonDependency`) makes sense.

Monitors are ok, in fact, as would be the double-clocking scheme. I'm just used to using `lock` as it's more succint and less error-prone.


@everything @is @a @user


should be lowerUpperCammelCase


What's the reason behind adding the dots in NAMES array? Is your name wibbenz or is it wibbenz.?


Цвета в свт приходится диспозить вручную, поэтому стоит сделать их полями класса `TileButton` и пооверрайдить у него метод `dispose()`:
```java
@Override
public void dispose() {
    colorBlack.dispose();


"servie" -> "service"


`editorGrideData` -> `editorGridData`?


Мб формировать эту строку в ордер конфигураторе на основании размеров поля? И отсюда вызывать метод, который ее возвращает?


"definitionfor" -> "definition for"


Думаю, их стоит поместить в массив и заполнить его в цикле.


But really that's beside the point. I don't know why what specific old code leaked into the new build, but I know that is what happened, because doing the "uninstall, restart, reinstall" made those issues go away. I am not interested in, or have the time to, investigate which change for what reason caused old  code to leak into the new build. I shouldn't have to, don't want to, and don't have the time to, become an expert on such things.


besides minor typo comments, LGTM @marians


Стоит вынести эти цифры в константы класса (`width`, `height`, `borderWidth` и т.п.)


@opengapps/packagers, I manually removed API14 here and squashed my removal commit with this AP16 add.

For this one do:
```
git reset 0f4cb79
git pull
```


Hvorfor kommer menytittel og lenker som er opprettet under en meny frem på oversiden av oversikten over menyer, blokker og stort sett alle andre steder der de ikke skal være – se f.eks. menyer?

Innholdet i «body» er plassert (formatert) annerledes i D7 enn i D6. Kan dette redigeres i D7 uten at systemet endrer det tilbake ved neste migrasjon?

Hva gjør vi med de fire feltene på fremsiden? Blir det som før, at vi må ha innholdet på begge språk for at nodekøen skal virke? Dette må vi unngå. Det blir for tungvint. Må prøve å skille norsk og engelsk side, også tysk når den kommer.


Okay, but I did this before SMSplusVITA was released. I was too busy with more important things than to bother putting it in a fork. I'll try your way.


`manhattanDistanceHeuristic` лучше, наверное


So, is the first snippet above good enough for you, or do I have to do the second?


No reason at all, it was like that in the source code if you take the time to look.
It is also private so no need to change it since nothing else can access it.


1: M101 signature is missing
1: M190 line is too long (52 > 50)


Checkmarx scan results 10 Aug 2015 15:56 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

152ac2e82b735bf52bba99709a33f80fc4914ba8	@cxehud


Checkmarx scan results 10 Aug 2015 15:57 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ecbea1e72655807036d3a39187be4eb9f5b9b8c6	@cxehud


Checkmarx scan results 10 Aug 2015 15:58 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ecbea1e72655807036d3a39187be4eb9f5b9b8c6	@cxehud


Ah! Thank you for the correction. I was trying to use Google Translate to understand your commit but it obviously did not translate well ;-)

This looks like something I definitely want fixed in core MimeKit. I'll look into fixing this and adding a unit test.


I would add a "which"


## This is a markdown file


sd


Looks nice.. did you make sure all Windows version behave similarly? (check MSDN and stackoverflow?)


You can use
```
self.get_toplevel().add_alert(alert)
```
here and in __alert_response_cb, and the patch will be more clean because you on't need add window as a parameter in DocumentButton.


missing newline at end of file


What do these numbers mean?


You are only able to build the architecture you are running (x86_64).


What is the cause of the issue?


test


Added PHP as per #22


Да, думала об этом. Исправлю при добавлении анимации.


Duplicate a activity takes a time. Would be nice show a clock cursor while the activity is being copied. I think there are a GCI patch anywhere doing that.

Also, other could be a better authority than me, but probably 'Delete your copy before duplicating the activity again' could be 'Delete your copy before try duplicate the activity again'?


Don't use RX-S and RX-E, use RX3D for emunand and Ver. for sysnand ;)


All this mess below is caused by deleting ``if (openingBracket != null) {`` and shifting its body to left


Isn't that obsolete?


Can't see it though...


I understand, but this can lead to confusion, referencing via name `@Namespace\IFoo` will not work as expected:

```
services:
   Namespace\IFoo:
      class: stdClass

   - Application(@Namespace\IFoo)
```


Why?


@josh
Can you take a look at the question below and provide an answer!
I'm curious to know why 3000 ??

https://www.quora.com/What-is-the-reason-behind-having-3000-has-default-port-for-rails-instance


Это пока даже не окончательные цифры. Аналогично, хотела поправить это с добавлением анимации.


add empty line after line 88


Eu digo, a variável que o synfony busca e depois direciona à aplicação é %database.name%, e no trecho comentado está %database_name%


What does "Va" mean? Maybe simply call it *pKernelMem* and *pUserMem*?


Checkmarx scan results 10 Aug 2015 16:08 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
17
16
4
36

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

c67ba09aabcb0e44d4fdcbbfa9d66fa56366278e	@amitchen22


Checkmarx scan results 10 Aug 2015 16:08 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

ffed6f3c148f23deaa2c4243cd21f3695a283534	@cxehud


That's correct.


Fixed that.


No, I will.


I see. I suppose that makes sense, especially given the fact that I am currently storing the `_semaphore` field as a static object.


Checkmarx scan results 10 Aug 2015 16:10 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
4
1
3
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

6a577f8940e03ccba6cd0f140af031cd6b76e982	@cxehud


Static is ok, but it's for the whole app... I'd rather go singleton-way and store the lock as a non-static field. This way we'd have per-tenant locking.
Monitors, lock, whatever - it's the same thing under the hood. Just to make it work ok:)


Notice that according to the comment in this function, there are 2 cases when the corner should exist:

1. When the parent TLW has a resize handle under OS X < 10.7 (which, hence, doesn't make sense for wxOSX/Cocoa).
2. When both scrollbars are shown.

This patch also changes the return value in the second case, is this intentional? If so, the comment probably needs to be updated?


Only MSDN, which didn't have any version info. I'm fairly confident it'll work because FILE_ACTION_ADDED, REMOVED and MODIFIED cover the cases we're interested in - it's only filtering the modification of directories.


I’ve actually just copied the readme over from Alamofire as Interstellar uses the same build configurations. Therefore I don’t really know if it works on pre Mavericks.
> On 10 Aug 2015, at 14:40, Tony Arnold <notifications@github.com> wrote:
>
> Dynamic frameworks (shipped embedded in other frameworks, apps or bundles) have existed on OS X since 10.0. Is this just worded a little strangely?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/JensRavens/Interstellar/commit/aca9d879d08e4b879abe1207889c01720d870f0e#commitcomment-12613675>.
>


test


Please remove.


Then you'll probably like ab12e9e6309f8dc36638bd4205a8dff277c686a1 and b62939f850ed97c59a4fe96a1c9cf70855cb19e0 :)


Checkmarx scan results 10 Aug 2015 16:12 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
0
10
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

01ed4a57dfe456b1ffe14bc418fc5c9af3c77db4	@amitchen22


Roxas decided to move from RX-E to RX3D because many users had problems of updated sysnand: basically, noobs read RX-S as RX-E and update the sysnand ;)


Love and tits :3 :dancer:
Looks oks!


we require that


This is the behavior for when the SMP state is not correct - which means an existing SMP session is going. When an existing SMP session is going and the user asks to start an authentication, we should cancel the previous one and start a new one.


same sentence


I guess you are right. I'll send a PR to fix this.


Checkmarx scan results 10 Aug 2015 16:16 UTC +03:00

High
Medium
Low
Info

New
0
5
44
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

bceedcd333a9605165959e2f934ee1a4aafdb0a7	@dortal

ae5db9e2f19d60a0d3f513c9d57ced181cdc8725	@dortal

f9de4779b55586eb93f9584bcbd22b5f32922292	@dortal

ea33e4d3e43590c6e640d2747674266d04cc1bc5	@dortal


Checkmarx scan results 10 Aug 2015 16:15 UTC +03:00

High
Medium
Low
Info

New
4
1
3
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

6a577f8940e03ccba6cd0f140af031cd6b76e982	@cxehud


Does it make sense to exit the NDIS instances before that kernel stack has exit its instances? What if the kernel stack e.g. posts an event at the same moment?

Or is that order on purpose?


Looks good to me :)


You are right, I didn't regard the the second case.
So this commit should be discarded.


LOL. But I want to know I'm on rxMode even on sysNAND...
Anyway, we have no other choice, so I'll fix it later.


deleted ``case TokenTypes.LITERAL_SWITCH:`` block because it tries to check uncompilable code. For example:
```java
int r = 1;
switch (r) {
case r=1: break;
}
```
Error: **case expression must be constant expression**
https://docs.oracle.com/javase/specs/jls/se7/html/jls-14.html#jls-14.11


Got it. It means we should make sure we process the abort before the SMP1 (and makes me realize why libotr process the TLVs the way it do).


This conflicts with the ability to disable an individual sub project for an existing branch.  To keep existing functionality, you'll need to implement a way for users to mark permanently disabled projects in the parent project config and introduce a migration path for any projects already disabled.


translated


:cyclone: :zap: :zap:


Is there no general drv_init() and drv_exit() function?


I'm very confused about the function of ensureSMP. Since smp.state is not a pointer, it can never be nil, right? or can an interface be nil?

Also, setting smpStateExpect1 is _not_ the correct behavior in the beginning of StartAuthenticate.


AutoValue sees this abstract (since it's from the interface) method returning an int and thinks it's a value field, creating things like builder methods for it and adding it to the `toString()` and `hashCode()` methods.  This leaves it out of the AutoValue implementation.


Update


Is this the general init function? If so, can we rename it to drv_init() and move it upwards as first public function (usually I expect init and exit function as first public function).


It depends on which SMP state you are. It will likely send and abort msg and restart the state machine, but I agree we are missing to wipe a few things related to SMP.


You should avoid copying the list if player is undefined


Is this the general exit function? If so, can we rename it to drv_exit() and move it upwards as second public function (usually I expect init and exit function as first public function).


It tries to check uncompilable code:
```java
for (;;) int y = 1;
```
or
```java
while (condition) int a = 1;
```


Here is no check done with `drvInstance_l.fDriverActive` ?


instead of cloing the list as a side effect of slice and then removing the player with splice, just use filter; it copies the array using only the elements for which the provided callback returns true. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter


How do you handle schema migrations ?


I would change the comment to "not to rely on underlying store's cache" instead of "if leveldb cache does not work fine".  This should be seen as a way to not depend on leveldb or any other underlying store.


Uh.. maybe I shouldn't review code on monday mornings.


that restriction is gone, i think i forgot to update the docs. if you specify a global file and an image file, both get written out.


```
Create a copy of a cairo surface.
The surfaces returned by `surface.load` are cached and must not be modified to avoid unintended side-effects. This function allows to create a copy of a cairo surface. This copy can then be freely modified.
The surface returned will be as compatible as possible to the input surface. For example, it will likely be of the same surface type as the input. The details are explained in the `create_similar` function on a cairo surface.
```
Something like that? (This is just what came to my mind)


Checkmarx scan results 10 Aug 2015 16:23 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
5
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

bcba1052f0284e1e6b9d5b4cb148c1003eaa33f2	@dortal


I was wondering why is the default port set as 3000 ???


It probably because of the pointer. Not sure why `SMPSTATE_EXPECT1` is the initial state of the state machine. Why would't it be the state before starting the authentication?


Yes correct,  hbase assumes there are no bytes available and skips reading the file. INT_MAX, though not accurate ensures that it enters the while loop and hbase client anyway takes care of reading only as much as the filelength. (DistributedFileSystem implements this correctly)
This is how Hbase uses it : https://git-wip-us.apache.org/repos/asf?p=hbase.git;a=blob_plain;f=hbase-common/src/main/java/org/apache/hadoop/hbase/codec/BaseDecoder.java;hb=HEAD

SInce we use chunked encoding we will not know the filelength in advance (unless there is another request to getfilestatus). This is in the same class :

(isChunkedTransferEncoding(headers)) {
      // file length is not known
      fileLength = null;
    } else

But I can change the implementation to return filelength - pos if it is available, else return INT_max, would that work?


Hi
Thanks for you post, but I think that CPanel is just the frontend to Dovecot.
Regards


You should definitely go get started with bower and do not include legacy in your project:)


Checkmarx scan results 10 Aug 2015 16:24 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
5
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

bcba1052f0284e1e6b9d5b4cb148c1003eaa33f2	@dortal


oh dear!


Cool, thanks!


smpstate_expect1 is the starting point always, because smp message 1 starts the smp authentication. So everyone who is not in the middle of an smp will implicitly be in expect1


Ok... why?


ugh, sorry, meant to be doing this in my fork


Damn. Let me try again.

It *is* probably because of the pointer. SMPSTATE_EXPECT1 is the initial state of the state machine. Why would't it be the state before starting the authentication?


:+1: I see that I add one in the next days, although this code was not added recently (I just moved it)...


Checkmarx scan results 10 Aug 2015 16:26 UTC +03:00

High
Medium
Low
Info

New
6
30
291
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8b2f7e067465f391fdbfd2e0a507847de4486aae	@dortal

bcba1052f0284e1e6b9d5b4cb148c1003eaa33f2	@dortal

bceedcd333a9605165959e2f934ee1a4aafdb0a7	@dortal

ae5db9e2f19d60a0d3f513c9d57ced181cdc8725	@dortal

f9de4779b55586eb93f9584bcbd22b5f32922292	@dortal


Because the logic in smpstatebase.startAuthentication needs it to be in the right state, so it can send an abort if we are in the wrong state.


This was a mismerge on my behalf - merging.


I don't think that is the case right now, but I'll keep it in mind :)


I'm not sure why it's uploaded like this, it's fine on my local machine, might be a problem with github. Can you test in your own editor (btw, what editor do you use? I use Atom)


Checkmarx scan results 10 Aug 2015 16:27 UTC +03:00

High
Medium
Low
Info

New
6
30
291
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

140a91c2e2e9575aeff62f8b7369213d9a2067af	@dortal


It should be fine as long as we send the smp message abort TLV before the other TLVs, just like it's doing in this code. (and as long as you don't mess with the smp state..., like with the ensureSMP() function)


BE Filters noch nicht endgültig gepflegt / eingerichtet


Checkmarx scan results 10 Aug 2015 16:27 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
5
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

4fcef8b3ca0d9b2f513bb28abe7bce4360ec9d98	@dortal

8b2f7e067465f391fdbfd2e0a507847de4486aae	@dortal

bcba1052f0284e1e6b9d5b4cb148c1003eaa33f2	@dortal

bceedcd333a9605165959e2f934ee1a4aafdb0a7	@dortal


# Sort the pixel values so we always slice in the correct direction


We have really inconsistent naming here: `storagePath`, `storageFolder` and we have a `uploadsPath` in `Session`. And all what is for the same entity. Also, don't use `folder` here and anywhere in the code. Use platform independent `dir` term instead.


AC_SUBST doesn't seem to be working for this case.

That first line does the same thing that just using AC_CONFIG_FILES by itself did (doesn't fully expand bindir).

The second line doesn't work either. I end up with a line like the following in the resulting desktop file:

```
Exec=NONE/bin/armory
```

For those interested, [here is some info](http://lists.gnu.org/archive/html/autoconf/2007-03/msg00002.html) on the issue with the second line. Basically prefix and exec_prefix are set to NONE until the end of the configure script execution _unless_ you supply an explicit value to the configure script (in my case you could provide an explicit value for bindir instead, because bindir is the only thing we are using in this way). The linked page does provide a method for setting prefix so that it can be used in the configure script, but it uses an undocumented variable.

So it looks like the way this is done currently by this commit is the way to go, even though it unfortunately involved changes to Makefile.am.


Checkmarx scan results 10 Aug 2015 16:28 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
5
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

140a91c2e2e9575aeff62f8b7369213d9a2067af	@dortal


Hi Alex,

A few improvements to the charts :
- pull_requests data is stored when build data is processed : build_trigger
property
- added a filter option to only show pull request build jobs

I've also imported a few builds (7020-7100) around the build where you
introduced the change :

https://travis-ci.org/angular/angular/builds/72039309 : build 7042 : 18 min

On first sight, it seems that the changes in that PR reduced the buildtime
to ~18min, for the following builds. Later today I'll import builds
7101-7551. Hopefully that will show in which build the improvement is
undone.

BTW : the builds between 7552 and about 8230 don't have build_trigger
property, so they don't show up if you filter on pull-request. This is
because they were imported before I introduced the feature to get
pull_request data.

2015-08-06 20:59 GMT+02:00 Dieter Adriaenssens <
dieter.adriaenssens@gmail.com>:

>
>
> 2015-08-05 19:46 GMT+02:00 Alex Eagle <notifications@github.com>:
>
>> On Wed, Aug 5, 2015 at 9:57 AM Dieter Adriaenssens <
>> notifications@github.com>
>> wrote:
>>
>> > > Thanks, I just noticed that on our big screen and was playing. I don't
>> > > understand why our dart stable build seems tri-modal (four if you
>> count
>> > > fast failures).
>> > >
>> >
>> > I've added a filter for build results, so now you can filter out the
>> > failures.
>> >
>> >
>> > > Bigger problem is the graph doesn't go back far enough in history to
>> show
>> > > me when the time increased.
>> > >
>> >
>> > Do you have a rough idea how long ago you were still seeing the 18
>> minute
>> > builds?
>> > I can manually import some older builds, if you like. But let me first
>> > change the code so it save if it is a PR.
>> >
>>
>> It was 15 days ago when I'm sure it was 18m
>> https://github.com/angular/angular/pull/3174
>> but we only started sending you the data 9 days ago:
>> https://github.com/angular/angular/pull/3302
>>
>> Actually I think it would be a really useful feature if you could use the
>> travis API to backfill data for the time period before the webhook was
>> added. Most users of this thing are probably adding it because they
>> already
>> have a problem, and you won't be able to solve that problem with the
>> current model, only subsequent ones.
>
>
>
> I have that in place already, but so far it's a manual process (entering
> every build ID by hand). It's on my todo list to allow to import data of
> multiple builds.
>
>
>>
>> > BTW : Any chance you could send me a picture of the Buildtime Trend
>> > dashboard on the big screen in your office? ;)
>> >
>> Photo of Victor Savkin with the screen hovering over his head :)
>> https://goo.gl/photos/qqUAXLixGnxWb5gU8
>
>
> Great! Thanks. :)
>

--
Kind regards,

Dieter Adriaenssens


Fixed, had copy pasted from old panel.xhtml


Why `U_BUFFER_OVERFLOW_ERROR` is ignored here? It appears to me that `_icu_str` should,  at this point, have enough space - if overflow happens, it should be an error? Or am I missing something?


DAB0mB could you explain how it works? I think there is no this.$on method.
@Urigo


This test fbf7c93 seems to be the real world example of how the SMP would be used.
`Conversation.StartAuthenticate` fails on this test because the state machine was not initialized, and initializing to `SMPSTATE_EXPECT1` seemed to be the right thing to do.

Not sure if it was the right place to do but initializing when the AKE is finished seemed wrong (AKE should not know about SMP).


If my previous comment about `U_BUFFER_OVERFLOW_ERROR` applies, it probably applies here as well.


Why we need additional closure here? Why `_createProcessTask` can't be async itself? `_createProcessTask` is a misleading name, `_createFileProcessingTask` or `_runFileProcessingTask` are more appropriate.


:) Thanks, now I understand how it work.

Just a few things (I was going to do a PR for these but some might require discussion):

1. There's a few more div's in that doc using mdl-layout-icon. Was it intentional to only change the one?

2. `<img>` is a void element, so it doesn't require that closing `</img>`

3. Now that I understand how it works I wonder if the example in the doc should be an icon like `<i class="mdl-layout-icon material-icons">whatshot</i>`. I just gave this a try and realised MDL doesn't vertically center the icon.

4. If an`<img>` is used it'd be great if it could include a `src=""` to ensure its valid HTML and it'd also be a good visual example.


It's completely fine to init to expect1 IF we don't have a previous smp state.


I stupidly made smp.state not a pointer because I assumed that would make it always initialized - but forgot that this doesn't work for interfaces. So, if smp.state == nil, then we init smp.state and set to EXPECT1


Cast to `char*`? Shouldn't/can it be `UINT8*`?


Actually, there is also a handle with the name "jets". So instead of using event.jets, you can simply set a default argument for collection to "jets" in the constructor.


I don't understand ☹


And that is exactly what `ensureSMP` does (just like `ensureAKE`).


Check text with @VasilyStrelyaev


<img src="https://github.trello.services/images/trello-icon.png" width="12" height="12"> [GIT](https://trello.com/c/ZHEpJVJg/40-git)


OK


`'A am already uploaded to the storage.'`

What? =)


`${host.ip}` can be very different from `${docker.host.address}` if you choose to bind to an ip that is something other then `${docker.host.address}`. i do this all the time for a bunch of deployments i have.

and yes, it would always be `1.2.3.4` in the last example, so you could get it from the properties but that potentially means you're writing out yet another props file w/ whatever the host's ip is. so, rather then do that, it can just be included in the same file as the port so now my tests, etc just need to load a single file for this information instead of loading 1 or more files and/or looking in `System` properties.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.895.18517f98af1f86de9b20fae25e378b279f1ea87d](http://build.palaso.org/viewLog.html?buildId=60867&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 397, ignored: 4 Build time: 00:03:56


TeamCity Jarvis Framework :: CI-GitFlow [Build 31](http://build.prxm.it:8811/viewLog.html?buildId=3666&buildTypeId=CqrsFramework_CiGitFlow) is now running


I don’t think `ObservablePath` is part of @harbalk’s liaison to decor move?


Ïa! Ïa! Cathuloo!


Ah, yes. I see that now. I read it inverted. Sorry - still not well.


BTW, separate variable assignment and method logic with the blank like


Thanks, @SeanBannister, you keep making good suggestions :)

I'll reopen the issue to track these, and I'll let you know once I have a PR ready so you can have a look over, if that's ok?


This flag is always FALSE and unused!?


That looks interesting. OK.


This is inside the while loop, so it will get executed twice if the protocol version is renegotiated. Why not do it at line 1254?


I believe this violates the style guide. Unnamed function.


Так как мы возвращает colorsService.getAllColors(); возвращает List, а не Set, то для прохождения теста, необходимо, чтобы в expectedAllCollors был тот же порядок, что и в возвращаемом списке цветов. Что вы думаете на этот счет? Стоит ли нам оставить тип возвращаемого значения List<Color>?
Абсолютно такая же ситуация и для других методов (getAllFlowers, getAllTempers, getAllMessages).


No but this method is needed in Core for reflection.


That still tries to create solv-@VERSION@.dylib in $solvdir, but it should be doing it in the build directory, i.e. without a prefix.


Add blank like here between fields, since current formatting is a little bit awkward.


Same here, this shouldn't contain $(solvdir).


Checkmarx scan results 10 Aug 2015 16:37 UTC +03:00

High
Medium
Low
Info

New
17
16
4
36

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3062de98b591bc78dcdd3d22807754280e63f097	@amitchen22


Dud dividierst durch nen bool und damit möglicherweise durch 0? :o


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.0-beta.1+0](http://build.prxm.it:8811/viewLog.html?buildId=3666&buildTypeId=CqrsFramework_CiGitFlow) outcome was **SUCCESS**
Summary: Tests passed: 113 Build time: 00:03:30


Sounds great :) cheers!

Just noticed one more thing:
5. The example `mdl-layout-icon` is used on wouldn't actually show the icon because it display a menu icon.


Нет возражений, что я убрал эти строки из @Before и @After? Прохождение тестов заметно ускорилось после этого.


Checkmarx scan results 10 Aug 2015 16:37 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
17
16
4
36

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3062de98b591bc78dcdd3d22807754280e63f097	@amitchen22


@Dgame guckst du hier


Why not use IDisposable?


I think trying to speak to the idea that unit tests can speed up the development of work would be useful. Many people that are inexperienced with testing view it as this 'add-on' that tends to take up time.

But being able to develop a feature and not get into 'F5-driven-development' can improve producitivty also.


Why note use IDisposable?


Do not create files in $(srcdir), that breaks automake's separation of build and source tree; instead, create the file in the current directory, i.e. just use `>solv.tm`. That will automatically install it in the right directory because solv.tm is listed in `solv_DATA` and `$solvdir` contains the right install location.


@arnova Should the EXTERNAL_NET autodetect be moved ahead of the EXT_NET_BCAST_ADDRESS autodetect since it can use EXTERNAL_NET in it's logic ?


I don't like this approach. Can we test it as we do it for e.g. service message - via HTTP requests, so test will affect the whole upload mechanism pipeline.


i also forgot to update this, sorry. looking at the docs it seems i only 1/2 corrected things.


It is possible to suppress error messages for a class by setting `dump_error_messages` to false, e.g., `Genome::WorkflowBuilder->dump_error_messages(0)` or `UR::ModuleBase->dump_error_messages(0)`.


I made the corresponding methods in controller call them in domain. So even though the method isn't used to produce the model, it will get called at runtime.


This requires using the ConventionalModelExtender. Actually we are considering to merge the conventions library into core so that there will not be two set of default implementations.


Checkmarx scan results 10 Aug 2015 16:40 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
17
16
4
36

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3062de98b591bc78dcdd3d22807754280e63f097	@amitchen22


oh, also, the commit message refers 'mon_cache_size' and it should instead be 'mon_osd_cache_size'


Line 119 says that the list can be empty.


Checkmarx scan results 10 Aug 2015 16:41 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
17
16
4
36

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

0749e546b108337b904c0c26ebdfdd627577014d	@amitchen22


Is there a typo here? `is_ignorable`?


Ah, ok, no, I understand now


Olá, quando você solicitou o pull request eu não havia habilitado a integracao continua com o travis. O seus testes não estão passando. Por favor pode corrigilos e enviar um pull request válido?


What is the `real file path`?


nevermind, I just saw the check in `deliverEvents`


Done, use "5.3.4 " and "5.7.1 "


Why `return` here? Since it's contains assertion it's not `compareFileContent` it's `assertFileContentsIdentical`


BTW, personally I like @ better than + (should both be save since both are illegal characters for maven prop names)


Same here


Why are you setting the port to busy here?


Check (assert) error for what?


Any specific reason for using `INT8*`? Usually argument pointers are `void*`.


Check(assert) file data for what?


yeah, but I couldn't find a way to get to that without an unreasonable amount of guesswork specific to their "forum" pages. The old xpath was broken across the board (i.e. they removed the DC.title metatag), so that was no option.


Better algorithm could be to use the summation algorithm for arithmetic progression, whose time complexity will be O(1).

This algorithm has a complexity of O(n), now.


Cool!!


ret is unused because the function has no return value.


Assertions within promises will never throw. So test will just hang up. See how it's done in other tests that uses promises.


Legas @silviakihara


Vermeide name clashes. ;)


Nice!


#NABS


because you are using a version control system


#1178 is ready for you!


In our last conversation we've decided what storage tests will be in `upload-test.js` or am I missing smth?


No need to create properties for textfields as we are not using those anywhere


Checkmarx scan results 10 Aug 2015 16:47 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
0
5
44
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

cf08f951d9b1cd3eb48c929b7fe80fc13c39a38e	@dortal

15b04f56e0ffa8fcff180931fd5883191ad46d42	@dortal


HostFileHandle should be defined differently:
- make it a platform-specific typedef, e.g. on Posix, it would be _typedef FILE* HostFileHandle_, on Windows it would be _typedef HANDLE HostFileHandle_ if the Win32 file functions are used


Ah, of course.  Makes sense.


@congysu This does not intend to test the functionality of the functions. It was just designed to test if RESTier or Web API supports them in the URL level. Thus I only checked if the returned context URL is correct but not want to check the returned entities.


so...


Checkmarx scan results 10 Aug 2015 16:47 UTC +03:00

High
Medium
Low
Info

New
17
16
4
36

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

f24b2dd4a3f5ecc958e3ed7ccf8ad14a7538a322	@amitchen22


Try to keep this as last method. It will not make any difference but used to follow this.


\r-


An application created by Qile Wang, Purnima Mehta, Akash Patel for Pebble in 36 hours at the University of Toronto Hackathon.


No need to create properties for labels as we are not using those anywhere


I was suggesting the name `BarcodeCount` instead of `BarcodeNumber`.  Or else `NumberOfBarcodes`, which is a bit of a mouthful.


you can't properly version binaries as they cannot be diff'ed. also, distributing binaries with source is frowned upon.


Checkmarx scan results 10 Aug 2015 16:48 UTC +03:00

High
Medium
Low
Info

New
0
5
44
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

cf08f951d9b1cd3eb48c929b7fe80fc13c39a38e	@dortal


Have you checked this? I suspect this is going to pick up several pages that are not necessary.  For example every ITSI activity consists of multiple pages, I suspect this approach will mean all of those pages will be exported (and they shouldn't be).


if you synthesized properties, no need to use self for it. Use it directly.


Thanks Brett.  Can you update this PR with an additional commit making the changes we agreed on?


Why is the function not returning any value (OK or error)? What happens if the event post fails?


Fine.


- the fileAccess interface methods shouldn't be virtual, instead use of compile-time 'diamond-shape class hierarchy' as in the renderer class of the Gfx module, or the urlLoader class of the HTTP module
- I think there should be no baseFileAccess class but only a posixFileAccess, winFileAccess, etc... class, and a frontend fileAccess class
- since the fileAccess classes are (ideally) stateless, all its methods should actually be static (IMHO)


also, you and @raehik are online simultaneously (much lol)


Why is the function not returning any value (OK or error)? Here at least the pSize_p is used to return if there is valid data read from the queue...


haha I commented something about the promotion and you found bug hehe
https://github.com/orts/server/issues/264
ty :)


This will create the same post over and over. Try

`Post.find_or_create_by!(`


I followed the URL to the troubleshooting page, and then followed the "already been fixed" link here. I don't understand how to fix the bug (If it needs fixing). This is what I got:

⚡ ⚡⚡ ⚡  app: $ brew update
Error: uninitialized constant Formulary::HOMEBREW_CORE_FORMULA_REGEX
Please report this bug:
    https://git.io/brew-troubleshooting
/usr/local/Library/Homebrew/formulary.rb:214:in `loader_for'
/usr/local/Library/Homebrew/formulary.rb:174:in `factory'
/usr/local/Library/Homebrew/cmd/update.rb:205:in `block in report'
/usr/local/Library/Homebrew/cmd/update.rb:190:in `each_line'
/usr/local/Library/Homebrew/cmd/update.rb:190:in `report'
/usr/local/Library/Homebrew/cmd/update.rb:24:in `update'
/usr/local/Library/brew.rb:127:in `<main>'

I was going to report an issue but it says it's "already been fixed" on the troubleshooting page.

I ran `brew update` again and it seems fine. Is there anything I need to do or am I good to go?


This one I believe will show to the end API user, so probably should be Node Link. You can test it by trying to add a Node Link with the API to the same node twice in a row.


'HostFileHandle*' should be 'HostFileHandle' (no pointer stuff involved), the native file handle behind the typedef doesn't have to be a pointer.


now i'll have to write instructions :(


Checkmarx scan results 10 Aug 2015 16:50 UTC +03:00

High
Medium
Low
Info

New
0
1
0
0

Recurrent
17
14
3
34

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3210ab404de4412ae659559bf0147e9d0b7b7ad7	@amitchen22


no you don't


Missing in comment: It returns the size of the read data.


Olá Thiago tudo bem? Qual foi o motivo por vocês tirarem o rack-timeout da aplicação?


ok


This commit simply allows multiple CCScrollView instances to be manipulated by the user on a single device.  Very useful if, for example, you have a two player game with distinct scrollable regions.


I enjoy copypasta, it's so tasty with failsauce


The open mode is platform specific, and is not always a string (for instance when using the Win32 file functions the CreateFile flags are completely different from the fopen() mode string. I think this must go into the platform-specific fileAccess classes.


LGTM


nitpicking: please always use { } (yes I need to write a coding style) ;)


BTW, @raehik has seen my laptop :)


Great Additions! I will merge.


That was the original design, but the problem with not having a wrapper is that we won't be able to unwind the stack at safepoints. Which is required by code that depends on unwinding other threads.


freakin huge screen lol


I see why `BeginLifetimeScope` fails here: whenever that's invoked when the class is being disposed because the IoC container is disposing it, the `ILifetimeScope` from which we're creating a new one is already disposed, so it can't actually create a new scope and throws an `ObjectDisposedExeption`. Perhaps we need to keep the child lifetime scope around until Dispose is invoked. So we _do_ commit the transaction immediately, but _don't_ dispose the life time scope by not using the *using* statement.


> I love my 17-inch laptop


'bufferSize' should be 'numBytes' (IMHO)


Hi Frank,

After this commit, I'm not able to upload a cert with pkcs15-init -X (1374 byte long cert in der format) on my card (cardos 4.4 T=1) using a Gemalto PC Twin Reader or an ACR38-CCID (both reader known to support extended APDU). My setup is an up-to-date Debian7. I can send you the complete log with this commit and with the previous working commit. Thanks. Jean-Pierre


ack


these tests should be asserts IMHO, the caller should have checked in Open whether the file was opened successfully


Checkmarx scan results 10 Aug 2015 16:55 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

b37c092cceb82e00dd089499f65ea3c4ebed884b	@cxehud


You are correct never mind.


Hi @KevinZinsmeister can you upload the revit file too?

Thanks.


From #9:

> Create your own ThrownExceptionFinder visitor class that is modeled after org.eclipse.jdt.internal.codeassist.ThrownExceptionFinder. Instead, though, use the normal AST classes that you have been using all along (i.e., the ones in the org.eclipse.jdt.core.dom package).

Hence, you should not be using internal compiler types, in general.


Why doesn't this simply call fread()? All this Length and Seek and feof looks complicated and behaves differently then fread()... why? :)


Checkmarx scan results 10 Aug 2015 16:57 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

15fd2784fea19799a60728308e60ec053c7d9b25	@cxehud


Can you delete the `calib_coeff` entries from the `info` dict once you are done with this? They are not a standard entry and thus should not be there if they don't have to be. In fact, would it be possible/reasonable to avoid storing them in `info` at all, and just pass them back from the function that currently puts them in there instead?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18863/testReport/) for this commit**


Checkmarx scan results 10 Aug 2015 16:57 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

15fd2784fea19799a60728308e60ec053c7d9b25	@cxehud


I'm fine with normal C-style casts (unless it's a const_cast).


@FrankDraws The bug is caused by different version of files are loaded during `brew update`. And this commit is used to prevent similar situation happening again in the future.

> Is there anything I need to do or am I good to go?

Yes, you are good to go.


Different spacing above and here - spaces are weird - would be nice to make this the same as all the others


We have a sufficient number of functional tests for this. In these tests, we check the interaction with the file system.


Yup, it was accidental :)


what's up with this loop? why not simply call fwrite() and return the number of bytes written? (also see the comments for Read below).


I have removed it,


/*#include<stdio.h>
void main()
{
	int b;

	int a [10]={0};
	for(b=0;b<=9;b++)
		printf("%d\n",a[b]);

	printf("\n");

	printf("%d\n",a);
}*/
/*#include<stdio.h>
void main()
{
	int a[10];
	int b=0;
	int i=0;
	for(i=0;i<=9;i++)
	{
		scanf("%d",&a[i]);
	}
	for(b=0;b<=9;b++)
		printf("%d\n",a[b]);
	printf("\n");
}*/
/*#include<stdio.h>
void main()
{
	int b=0;
	int c=0;
	int a[20]={0};
	a[0]=1;
	a[1]=1;
	printf("%d\n\n%d\n\n",a[0],a[1]);
	for(b=2;b<=19;b++)
	{
		a[b]=a[b-1]+a[b-2];
		printf("%d\n",a[b]);
		printf("\n");
	}
}*/
#include<stdio.h>
void main()
{
	int a[10];
	int i,j,t;
	printf("input ten numbers\n");
	for(i=0;i<=9;i++)
	{
		scanf("%d",&a[i]);
	}
	printf("\n");
	for(j=0;j<9;j++)
	{
		for(i=0;i<9-j;i++)
		{
			if(a[i]>a[i+1])
			{
				t=a[i];a[i]=a[i+1];a[i+1]=t;
			}
		}
		printf("the sorted numbers:\n");
		for(i=0;i<10;i++)
		{
			printf("%d",a[i]);
		}
		printf("\n");
	}
}


I would think that something like `containsUncaughtExceptions()` may be more appropriate. It's not clear what it means for `checkException()` to return `true`, for example. Does that mean it had exceptions?


I think you need a better variable name here.


I like the deleted line much better.


I think the Windows version should use the CreateFile Win32 function family. For now we can probably also use the posixFileAccess wrapper on Windows (although a truely native Windows version would be nice for testing)


WDYM? It tests on `0.10`, `0.12` and `iojs`

FYI: I also use v0.12


The comment/name and the value conflict here.


Is the additional `Games.update(game._id, {$set: {scrollTop: true}});` really necessary?


Finally: a simple unit test would be nice to test all functions of HostFileSystem (probably using the existing files under oryol/data).


Added in 11854d9269e291c7b89169c1f950499ece2f6860


- They are arrays of pointers **apE**ventQueueInst and **apD**llQueueInst
- NR_OF_CIRC_BUFFERS creates an array of 20 elements, but only a subset is used of the array. Maybe you can find a proper way? e.g. combine circbuffer instances to a single instance array holding DLL and event queues?


Is it worth including some sample code for a safe alternative approach, do you think?


Class names normally don't have `.` in them. I don't think this is a realistic example.


No, we haven't. In this case we really can test whole system as black box, and I don't see the reason why we can't do that.


We appreciate your help, but rank is a unique id so there is no need for better sorting as there is no way two people can have the same rank :)


In Java, package names must match the location of the java file in the file system.


Isn't that also a pointer (hidden in the typedef) **p**DualProcDrvInst ?


ack


>'A am already uploaded to the storage.'

>What? =)

I will merge two tests (storing and getting) to get rid of this file.


- Any reason for not having a return value?
- What if pCtrlCmd_p is equal to NULL?


FYI: @mlocati This broke all the subclasses that call parent::save() because none of them were updated. So I reverted this commit. See this: https://github.com/concrete5/concrete5/issues/2896


- Any reason for not having a return value?
- What if pInitParam_p is equal to NULL?


Doesn't completely solve the problem.


Checkmarx scan results 10 Aug 2015 17:03 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

4050e012defb20cd5d9801018199e23244fea113	@cxehud


The website (http://nats.io/download/) points v0.6.0 that's why... I'll change it to v0.6.4 now...


Seems to me this error should be logged.


Hi! I'm ready to be uploaded through Hammerhead and I'm so excited!


`error` is both a severity and a type?


My first repository on GitHub


nop


I agree


- Any reason for not having a return value?
- NULL check of pStatus_p in dualprocshm_readDataCommon(), right?


Good idea - updated.


- Any reason for not having a return value?
- NULL check of pHeartbeat_p in dualprocshm_readDataCommon(), right?


(not me, actually)


BTW, even if we will test just the upload storage (like it's actually done here), why we need to call session's service message handlers then we can just call upload storage methods directly?


@vmarquesdev https://github.com/heroku/rack-timeout/issues/73#issuecomment-89170627


asd


but just removing `(load "package://jskpointcloud/euslisp/jskpointcloud.l")` does not work
```
roseus ;; loading roseus("c1aac9c") on euslisp((9.12 kokada-t440s Thu May 14 16:54:25 JST 2015 bb29754 1.0.2))
eustf roseus_c_util /home/k-okada/ros/indigo_parent/devel/share/euslisp/jskeus/eus/Linux64/bin/irteusgl: ERROR th=0 unbound variable 3dpointcloud3dpointcloud in (defmethod 3dpointcloud (:hs-hist (&key (h-step 3) (s-step 3)) (let ((col (send self :carray)) (hist (make-array (list h-step s-step) :element-type float-vector))) (dotimes (i (send self :size)) (let* ((his (rgb2his (scale 255 (matrix-row col i)))) (h-bin (get-bin (elt his 0) :step h-step :max-num 360.0)) (s-bin (get-bin (elt his 2) :step s-step))) (incf (aref hist h-bin s-bin)))) (scale-matrix (/ 1.0 (send self :size)) hist))))E:
```


:like:


@jiaofeng huobi 靠譜嗎？


@godong9 동현이 뭐해~


@scytacki We found 13 pages with publication status as 'private' on itsi aws staging server. Do you want us to ignore these pages and revert this change to export only published pages?


Checkmarx scan results 10 Aug 2015 17:08 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

837da1d3c63696e54895ee92bc631b58e450c381	@cxehud


I guess in theory you could import and p2pkh address as p2sh, by importing the p2pkh script as redeemscript. But that's probably pointless and confusing.


@shalabhc Yeah, but this one handles the case of no project being opened. I moved it out so `build-exec` could use it, too.


@simon816

This mixin literally could NOT have worked before. Try reading the code and you'll see that addChatComponent never was called in tryExecute...

We already have resolved this issue.


i had noticed that and thought i had changed it. ill fix it now and go through everything again.


this is from EnhancedForStatementVisitor, we could definitely create a method containsException() in ThrownExceptionFinderVisitor


I set it to busy because `EAGAIN` means the file descriptor is temporarily unavailable for writing, and so I'd like any callers trying to do more writing to the port to temporarily hold off as well. Since when we hit this condition we still have data to write and we immediately re-register `fd_async` to try writing again, once the `EAGAIN` condition abates and a write succeeds, busy is cleared (sys.c line 2569).


Matt is this "fixed" value for the ":position" essentially what keeps the GUI buttons in place during editing?


- Any reason for not having a return value?
- In my view this function could already get a `tIoctlDllCalAsync*` as parameter instead of a general IOCTL buffer pointer. What do you think?


Checkmarx scan results 10 Aug 2015 17:08 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

837da1d3c63696e54895ee92bc631b58e450c381	@cxehud


Creating symbolic link in `/usr/local/bin/gnatsd` requires `sudo`. We wouldn't need it if https://github.com/cmfatih/node-nats/blob/master/test/support/nats_server_control.js#L7 uses relative/full path. Let me try a few things...


I wonder why you opted for a div with an "onClick" vs a button?  Just wondering...


I don't think you want to import this class. My suggestion was to create your own `ThrownExceptionFinder` that works with general statements (like `Block`s) and the JDT DOM classes (as opposed to the internal compiler ones). Please review the suggestion in #9 for more information.


- Any reason for not having a return value?
- NULL check?


It's sometimes sooo hard to make concrete5 compatible with PHP7 :disappointed:


Line 193 of jquery.pjax.js

xhr.setRequestHeader('X-PJAX', 'true')

Sent from my iPad

> On Aug 10, 2015, at 2:09 AM, weiChen <notifications@github.com> wrote:
>
> how this global variable generated?
>
> —
> Reply to this email directly or view it on GitHub.
>


Кажется это лишнее, потому что ты и так находишься в `benchpy`.


OK


Для совместимости с Python2 полезно наследоваться от `object`.


- NULL check?


ack


I suggest only using the classes [`org.eclipse.jdt.core.dom`](http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fcore%2Fdom%2FIMethodBinding.html).


What about using 4.x already?


parameters are checked in dualprocshm_getMemory() right?


reack


So, this change works for pkvm2.x too, right?


Что-то это не то. Я имел в виду [`cached_property`](https://pypi.python.org/pypi/cached-property/0.1.5).


Same can be done in ```OMEXMLModelObject_XMLAnnotation_update_Value.template```


That looks like the only thing left. It was changed to Node_link and, instead of being changed to Node Link, it was changed to Pointer.


memSize_p is unused


saw approval from jonmeredith
at https://github.com/basho/riak_kv/commit/8b87c940075dc9af65c457930c0153cd899e22a9


merging basho/riak_kv/bugfix/handling-undefind-objsize-on-kv-stats-2.0 = 8b87c940 into borshop-integration-1167-bugfix/handling-undefind-objsize-on-kv-stats-2.0


basho/riak_kv/bugfix/handling-undefind-objsize-on-kv-stats-2.0 = 8b87c940 merged ok, testing candidate = 6a131e8c


@mlocati what about just doing `public function save($args = array())` ?


This is not done if dualprocshm_freeMemory() fails, does it matter?


Good catch, the overflow ignore is just for the 1st call. Thanks.


Yeppers.


Linked to #525


I changed it, keep the package name p


Точно xor?


Yes website is being updated..


@scytacki We found 13 pages with publication status as 'private' on itsi aws staging server. Do you want us to ignore these pages and revert this change to export only published pages?


raise?


Checkmarx scan results 10 Aug 2015 17:13 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

f71263f0b6ada476d6611d94330185f72dcd77c9	@cxehud


Checkmarx scan results 10 Aug 2015 17:14 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

f71263f0b6ada476d6611d94330185f72dcd77c9	@cxehud


Oh  my, how did that slip past me...


Может не сработать: `is` проверяет равенство адресов в памяти, а не значений.


It's not advisable to add code directly in manifest file


C# console menu


Apologies, mis-read the diff.. ;)


dynamicDictIsNotNullAndContainsKey


I've been doing it alphabetically, but I've been considering ordering it more by preference. For example Prose is listed at the bottom of the editors, but is't probably the most popular.


I will use .equal(), in line 144 would that resolve the issue


It should be valid to inherit directly from `dict`.


Working on it!  Thanks!  :+1:


Nice !


Стоит передавать сюда `name`, сформированный ранее, а метод `getName()` удалить (ну и сам `name` тоже уже не нужно будет делать полем класса).


Could you just update PATH to include / or another non root privileged path?


TeamCity Ybackend :: AnnaPonomareva/ybackend [Build 379](http://192.168.30.225:8111/viewLog.html?buildId=2006&buildTypeId=Ybackend_AnnaPonomarevaYbackend&guest=1) is now running


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18864/testReport/) for this commit**


Right.  And it's not just during editing, it's any time the sidebar wouldn't normally be fully visible.


distatcher? isn't it a typo?


For those files doesn't matter since they are for tests. In general there is not too much performance difference. But if you have OCD for micro benchmarking ( like me :) ) single quote is slightly faster. ( See http://jsperf.com/single-or-double-quotes/5 and https://jsperf.com/single-quote-vs-double-quote-in-javascript )


sure, go ahaid! use pastebin or paste it here


Well done! This abstraction was missing since long!


Either way we'd probably have to change the method signatures on all the
subclasses – as I imagine the mismatch is what PHP7 is crowing about.

On Mon, Aug 10, 2015 at 7:14 AM, Joe Meyer <notifications@github.com> wrote:

> @mlocati <https://github.com/mlocati> what about just doing public
> function save($args = array()) ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/concrete5/concrete5/commit/d560ab24ac84ddda6dc3185b32340c589c95e9c2#commitcomment-12615867>
> .
>


Are you actually 100% sure it works now? As in, did you actually test it? I actually did make all humans have #adjustmentcommand #mor 50 and it worked on the commit where I released the feature. I'm talking about line 869/867 change.

Unhandled commands are read as tags with the # dropped from front and that's what it is.


Or you can add the method to the `EnhancedForStatementVisitor` instead of creating a new visitor.


ack


Our button component can't be styled to this degree.


TeamCity DNN JavaScript Libraries :: CI [Build 66](http://teamcity.engagesoftware.com/viewLog.html?buildId=334&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


But also doesn't solve your problem, right? Because the counter example I gave does not use package `p`.


This will be a BC breaking change, you'll have to keep operations and can add versions as well and catch the case.


TeamCity DNN JavaScript Libraries :: CI [Build 66](http://teamcity.engagesoftware.com/viewLog.html?buildId=334&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:10


@mlocati heh, no worries ;) Since 5.7.5 is about to come out I wanted to make sure that we pushed this back to the next release. I'm sure it's something we can take care of quickly.


Yes, you need to use `equals()`.


I will add this api when 1.0 release :) maybe in this year.


:weary:


Thanks, so I guess it is similar, the vm will look inside double quotes and
not single..

On Mon, Aug 10, 2015 at 7:18 AM, Fatih Cetinkaya <notifications@github.com>
wrote:

> For those files doesn't matter since they are for tests. In general there
> is not too much performance difference. But if you have OCD for micro
> benchmarking ( like me :) ) single quote is slightly faster. ( See
> http://jsperf.com/single-or-double-quotes/5 and
> https://jsperf.com/single-quote-vs-double-quote-in-javascript )
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cmfatih/node-nats/commit/a3c448a4f03b6ad4785a926fd4b68425f879f6e7#commitcomment-12616009>
> .
>


@szikora please try initializing the card with #515 applied.