Gemfile.lock:

```
GIT
  remote: git://github.com/middleman/middleman-sprockets.git
  revision: 55fe2ee8a260bc72553b4abcbd211c52a2e19cab
  branch: v3-stable
  specs:
    middleman-sprockets (3.4.1)
      middleman-core (>= 3.3)
      sprockets (~> 2.12)
      sprockets-helpers (~> 1.2)
      sprockets-sass (~> 1.3)

PATH
  remote: middleman
  specs:
    middleman (3.4.0)
      coffee-script (~> 2.2)
      compass (>= 1.0.0, < 2.0.0)
      compass-import-once (= 1.0.5)
      execjs (~> 2.0)
      haml (>= 4.0.5)
      kramdown (~> 1.2)
      middleman-core (= 3.4.0)
      middleman-sprockets (>= 3.1.2)
      sass (>= 3.4.0, < 4.0)
      uglifier (~> 2.5)

PATH
  remote: middleman-core
  specs:
    middleman-core (3.4.0)
      activesupport (~> 4.1)
      bundler (~> 1.1)
      capybara (~> 2.4.4)
      erubis
      hooks (~> 0.3)
      i18n (~> 0.7.0)
      listen (~> 3.0.3)
      padrino-helpers (~> 0.12.3)
      rack (>= 1.4.5, < 2.0)
      thor (>= 0.15.2, < 2.0)
      tilt (~> 1.4.1, < 2.0)

GEM
  remote: https://rubygems.org/
  specs:
    activesupport (4.2.3)
      i18n (~> 0.7)
      json (~> 1.7, >= 1.7.7)
      minitest (~> 5.1)
      thread_safe (~> 0.3, >= 0.3.4)
      tzinfo (~> 1.1)
    aruba (0.7.4)
      childprocess (>= 0.3.6)
      cucumber (>= 1.1.1)
      rspec-expectations (>= 2.7.0)
    asciidoctor (0.1.4)
    ast (2.1.0)
    astrolabe (1.3.1)
      parser (~> 2.2)
    builder (3.2.2)
    capybara (2.4.4)
      mime-types (>= 1.16)
      nokogiri (>= 1.3.3)
      rack (>= 1.0.0)
      rack-test (>= 0.5.4)
      xpath (~> 2.0)
    celluloid (0.16.1)
      timers (~> 4.0.0)
    celluloid-io (0.16.2)
      celluloid (>= 0.16.0)
      nio4r (>= 1.1.0)
    childprocess (0.5.6)
      ffi (~> 1.0, >= 1.0.11)
    chunky_png (1.3.4)
    cliver (0.3.2)
    coderay (1.1.0)
    coffee-script (2.4.1)
      coffee-script-source
      execjs
    coffee-script-source (1.9.1.1)
    commonjs (0.2.7)
    compass (1.0.3)
      chunky_png (~> 1.2)
      compass-core (~> 1.0.2)
      compass-import-once (~> 1.0.5)
      rb-fsevent (>= 0.9.3)
      rb-inotify (>= 0.9)
      sass (>= 3.3.13, < 3.5)
    compass-core (1.0.3)
      multi_json (~> 1.0)
      sass (>= 3.3.0, < 3.5)
    compass-import-once (1.0.5)
      sass (>= 3.2, < 3.5)
    coveralls (0.8.2)
      json (~> 1.8)
      rest-client (>= 1.6.8, < 2)
      simplecov (~> 0.10.0)
      term-ansicolor (~> 1.3)
      thor (~> 0.19.1)
    cucumber (2.0.2)
      builder (>= 2.1.2)
      cucumber-core (~> 1.2.0)
      diff-lcs (>= 1.1.3)
      gherkin (~> 2.12)
      multi_json (>= 1.7.5, < 2.0)
      multi_test (>= 0.1.2)
    cucumber-core (1.2.0)
      gherkin (~> 2.12.0)
    diff-lcs (1.2.5)
    docile (1.1.5)
    domain_name (0.5.24)
      unf (>= 0.0.5, < 1.0.0)
    erubis (2.7.0)
    execjs (2.5.2)
    ffi (1.9.10)
    gherkin (2.12.2)
      multi_json (~> 1.3)
    haml (4.0.7)
      tilt
    hike (1.2.3)
    hitimes (1.2.2)
    hooks (0.4.0)
      uber (~> 0.0.4)
    http-cookie (1.0.2)
      domain_name (~> 0.5)
    i18n (0.7.0)
    json (1.8.3)
    kramdown (1.8.0)
    less (2.3.0)
      commonjs (~> 0.2.6)
    libv8 (3.16.14.11)
    liquid (3.0.6)
    listen (3.0.3)
      rb-fsevent (>= 0.9.3)
      rb-inotify (>= 0.9)
    method_source (0.8.2)
    mime-types (2.6.1)
    mini_portile (0.6.2)
    minitest (5.8.0)
    multi_json (1.11.2)
    multi_test (0.1.2)
    netrc (0.10.3)
    nio4r (1.1.1)
    nokogiri (1.6.6.2)
      mini_portile (~> 0.6.0)
    padrino-helpers (0.12.5)
      i18n (~> 0.6, >= 0.6.7)
      padrino-support (= 0.12.5)
      tilt (~> 1.4.1)
    padrino-support (0.12.5)
      activesupport (>= 3.1)
    parser (2.2.2.6)
      ast (>= 1.1, < 3.0)
    poltergeist (1.6.0)
      capybara (~> 2.1)
      cliver (~> 0.3.1)
      multi_json (~> 1.0)
      websocket-driver (>= 0.2.0)
    powerpack (0.1.1)
    pry (0.10.1)
      coderay (~> 1.1.0)
      method_source (~> 0.8.1)
      slop (~> 3.4)
    rack (1.6.4)
    rack-protection (1.5.3)
      rack
    rack-test (0.6.3)
      rack (>= 1.0)
    rainbow (2.0.0)
    rake (10.4.2)
    rb-fsevent (0.9.5)
    rb-inotify (0.9.5)
      ffi (>= 0.5.0)
    redcarpet (3.3.2)
    ref (2.0.0)
    rest-client (1.8.0)
      http-cookie (>= 1.0.2, < 2.0)
      mime-types (>= 1.16, < 3.0)
      netrc (~> 0.7)
    rspec (3.3.0)
      rspec-core (~> 3.3.0)
      rspec-expectations (~> 3.3.0)
      rspec-mocks (~> 3.3.0)
    rspec-core (3.3.2)
      rspec-support (~> 3.3.0)
    rspec-expectations (3.3.1)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.3.0)
    rspec-mocks (3.3.2)
      diff-lcs (>= 1.2.0, < 2.0)
      rspec-support (~> 3.3.0)
    rspec-support (3.3.0)
    rubocop (0.33.0)
      astrolabe (~> 1.3)
      parser (>= 2.2.2.5, < 3.0)
      powerpack (~> 0.1)
      rainbow (>= 1.99.1, < 3.0)
      ruby-progressbar (~> 1.4)
    ruby-progressbar (1.7.5)
    rubydns (1.0.1)
      celluloid (~> 0.16.0)
      celluloid-io (~> 0.16.2)
      timers (~> 4.0.1)
    sass (3.4.16)
    simplecov (0.10.0)
      docile (~> 1.1.0)
      json (~> 1.8)
      simplecov-html (~> 0.10.0)
    simplecov-html (0.10.0)
    sinatra (1.4.6)
      rack (~> 1.4)
      rack-protection (~> 1.4)
      tilt (>= 1.3, < 3)
    slim (3.0.6)
      temple (~> 0.7.3)
      tilt (>= 1.3.3, < 2.1)
    slop (3.6.0)
    sprockets (2.12.4)
      hike (~> 1.2)
      multi_json (~> 1.0)
      rack (~> 1.0)
      tilt (~> 1.1, != 1.3.0)
    sprockets-helpers (1.2.1)
      sprockets (>= 2.2)
    sprockets-sass (1.3.1)
      sprockets (~> 2.0)
      tilt (~> 1.1)
    stylus (1.0.1)
      execjs
      stylus-source
    stylus-source (0.49.3)
    temple (0.7.6)
    term-ansicolor (1.3.2)
      tins (~> 1.0)
    therubyracer (0.12.2)
      libv8 (~> 3.16.14.0)
      ref
    thor (0.19.1)
    thread_safe (0.3.5)
    tilt (1.4.1)
    timers (4.0.1)
      hitimes
    tins (1.5.4)
    tzinfo (1.2.2)
      thread_safe (~> 0.1)
    uber (0.0.13)
    uglifier (2.7.1)
      execjs (>= 0.3.0)
      json (>= 1.8.0)
    unf (0.1.4)
      unf_ext
    unf_ext (0.0.7.1)
    websocket-driver (0.6.2)
      websocket-extensions (>= 0.1.0)
    websocket-extensions (0.1.2)
    xpath (2.0.0)
      nokogiri (~> 1.3)
    yard (0.8.7.6)

PLATFORMS
  ruby

DEPENDENCIES
  aruba (~> 0.7.4)
  asciidoctor (~> 0.1)
  coveralls (~> 0.8)
  cucumber (~> 2.0)
  less (= 2.3)
  liquid (>= 2.6)
  middleman!
  middleman-core!
  middleman-sprockets!
  poltergeist (~> 1.6.0)
  pry (~> 0.10)
  rake (~> 10.3)
  redcarpet (>= 3.1)
  rspec (~> 3.0)
  rubocop (~> 0.24)
  rubydns (~> 1.0.1)
  simplecov (~> 0.10)
  sinatra (>= 1.4)
  slim (>= 2.0)
  stylus (>= 1.0)
  therubyracer (>= 0.12)
  therubyrhino (>= 2.0)
  yard (~> 0.8)

BUNDLED WITH
   1.10.6
```

Logs:

```
Scenario: Start the server with bind address 127.0.0.5                           # features/cli/preview_server.feature:118

  This will have no hostname attached because the hosts file, the DNS server
  and the MDNS-server do not know anything about 127.0.0.5
  When I run `middleman server --verbose --bind-address 127.0.0.5` interactively # aruba-0.7.4/lib/aruba/cucumber.rb:139
  And I stop middleman if the output contains:                                   # lib/middleman-core/step_definitions/commandline_steps.rb:1
    """
    Inspect your site configuration
    """
  Then the output should contain:                                                # aruba-0.7.4/lib/aruba/cucumber.rb:182
    """
    The Middleman preview server is bind to "127.0.0.5:4567"
    """
    expected "== The Middleman is loading\n== Reading:  Local config\nLoaded extensions:\n== Extension: frontmatter\n== File Change: config-complications.rb\n== File Change: config-empty.rb\n== File Change: config.rb\n== File Change: source/index.html.erb\n== File Change: source/layout.erb\n== File Change: source/layouts/custom.erb\n== File Change: source/real/index.html.erb\n== File Change: source/real.html\n== File Change: source/should_be_ignored.html\n== File Change: source/should_be_ignored2.html\n== File Change: source/should_be_ignored3.html\n== File Change: source/static.html\n== Rebuilding resource list\n[2015-08-11 10:20:02] INFO  WEBrick 1.3.1\n[2015-08-11 10:20:02] INFO  ruby 2.2.1 (2015-02-26) [x86_64-darwin14]\n/Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:206:in `bind': Can't assign requested address - bind(2) for 127.0.0.5:4567 (Errno::EADDRNOTAVAIL)\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:206:in `listen'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:461:in `block in tcp_server_sockets'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:232:in `each'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:232:in `foreach'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:459:in `tcp_server_sockets'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/utils.rb:70:in `create_listeners'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/ssl.rb:152:in `listen'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/server.rb:114:in `initialize'\n\tfrom /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/httpserver.rb:45:in `initialize'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:249:in `new'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:249:in `setup_webrick'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:295:in `mount_instance'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:41:in `start'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/cli/server.rb:89:in `server'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/cli.rb:72:in `method_missing'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/command.rb:29:in `run'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/command.rb:126:in `run'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'\n\tfrom /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/cli.rb:20:in `start'\n\tfrom /Users/thomasreynolds/Sites/middleman/middleman-core/bin/middleman:18:in `<main>'\n" to include "The Middleman preview server is bind to \"127.0.0.5:4567\""
    Diff:
    @@ -1,2 +1,47 @@
    -The Middleman preview server is bind to "127.0.0.5:4567"
    +== The Middleman is loading
    +== Reading:  Local config
    +Loaded extensions:
    +== Extension: frontmatter
    +== File Change: config-complications.rb
    +== File Change: config-empty.rb
    +== File Change: config.rb
    +== File Change: source/index.html.erb
    +== File Change: source/layout.erb
    +== File Change: source/layouts/custom.erb
    +== File Change: source/real/index.html.erb
    +== File Change: source/real.html
    +== File Change: source/should_be_ignored.html
    +== File Change: source/should_be_ignored2.html
    +== File Change: source/should_be_ignored3.html
    +== File Change: source/static.html
    +== Rebuilding resource list
    +[2015-08-11 10:20:02] INFO  WEBrick 1.3.1
    +[2015-08-11 10:20:02] INFO  ruby 2.2.1 (2015-02-26) [x86_64-darwin14]
    +/Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:206:in `bind': Can't assign requested address - bind(2) for 127.0.0.5:4567 (Errno::EADDRNOTAVAIL)
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:206:in `listen'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:461:in `block in tcp_server_sockets'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:232:in `each'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:232:in `foreach'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:459:in `tcp_server_sockets'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/utils.rb:70:in `create_listeners'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/ssl.rb:152:in `listen'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/server.rb:114:in `initialize'
    +	from /Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/webrick/httpserver.rb:45:in `initialize'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:249:in `new'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:249:in `setup_webrick'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:295:in `mount_instance'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/preview_server.rb:41:in `start'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/cli/server.rb:89:in `server'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/cli.rb:72:in `method_missing'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/command.rb:29:in `run'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/command.rb:126:in `run'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
    +	from /Users/thomasreynolds/.rvm/gems/ruby-2.2.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/lib/middleman-core/cli.rb:20:in `start'
    +	from /Users/thomasreynolds/Sites/middleman/middleman-core/bin/middleman:18:in `<main>'
     (RSpec::Expectations::ExpectationNotMetError)
    features/cli/preview_server.feature:128:in `Then the output should contain:'
  And the output should contain:                                                 # aruba-0.7.4/lib/aruba/cucumber.rb:182
    """
    View your site at "http://127.0.0.5:4567"
    """
  And the output should contain:                                                 # aruba-0.7.4/lib/aruba/cucumber.rb:182
    """
    Inspect your site configuration at "http://127.0.0.5:4567/__middleman"
    """
```

But the main part is:

```
/Users/thomasreynolds/.rvm/rubies/ruby-2.2.1/lib/ruby/2.2.0/socket.rb:206:in `bind': Can't assign requested address - bind(2) for 127.0.0.5:4567 (Errno::EADDRNOTAVAIL)
```


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.424.1b11b9dce9b64d7a748201e52a4d3cbc61a0ec07](http://build.palaso.org/viewLog.html?buildId=60925&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 859, ignored: 54 Build time: 00:22:00


Sure.


Putting constraints on variables - like `const` makes code easier to read. When you leave off `const` - especially in a codebase like ours that is already const correct - it's a signal that the variable can change. The person reading the code has to read to end of the functions scope (not just the next three lines) to see the value doesn't change. In this case, I can easily read and understand the code. However, if it was a conscious decision to leave out the `const` and not a simple oversight then this is not longer just a nit. I'm strongly against moving away from const correctness in our codebase, including local variables.


@rec I'll just briefly stick my nose in here.  While I respect your opinion, you and I have different experiences with `const` on locals.  Adding `const` to locals has allowed the compiler to find a number of bugs for me.  This is particularly true when I'm modifying code, as opposed to writing fresh code.  Personally, I never consider `const` to be cruft.  But YMMV.


As above, I suggest calling that filter something like `asMinutesAndSeconds` or something more descriptive.


Is this a duplicate?


thanx to  AndreiLux


Ah you're right, I totally missed that.


To edit something in the sql db all it needs is an update / alter / replace statement, which could be committed in a new file in sql-files/upgrades just like we do for current misc sql updates (maybe in a new folder for item/mob db) is what I meant and in addition to this update the main item_db(_re).sql, so I don't see the need to erase the entire db unless doing a fresh install. And it being the main item/mob database why would it be considered discardable? What was the original intent? I'm unclear on understanding. Although I get that there were 2 dbs and we were only using the text versions for a long period,  I still think going the sql way is far more beneficial on this so i figure we'll need a plugin to go with, unnecessarily. For the web based edits, I meant it would leave that option possible without having to give them access to the server files, but yes revisions would be a better way making it possible to revert if exploited.

I appreciate what you're doing and where you're taking hercules don't get me wrong, I'm just expressing my opinion and my intention is probably the same as everyone else's here.


@ataffard @amete @gerbaudo So I've moved 95% of what was in SusyNtTools into what I am currently calling SusyKin. I've moved all of the kinematic calculation functions and the event cleaning flag functions to SusyKin.  This change will most likely break some of your existing analysis code that was based on the post-xAOD merge, but the fix is easy. Just add the new include
``` #include "SusyNtuple/SusyKin.h"```
to whatever source file you have and remove the SusyNtTools object "getter" from the function and replace it with ```SusyKin::``` since SusyKin is not a class, just methods in a namespace.

The idea is to have remain in SusyNtTools anything that depends on the AnalysisType (such as the counting of signal & bjets, whether a lepton is of signal quaility, etc...) and these will use directly the object selectors (ElectronSelector, MuonSelector, etc...) that are data members of SusyNtTools. What is in SusyKin is everything else that manipulates the objects that does not depend on the AnalysisType.

Sound kosher?


You defeated enough -> You defeated


daniel


Defeated -> defeated


Collimencia -> Colimencia


Couple typos in this.

34/5 => 30/5

shift right by 2 is:

multiple=1
twoPower=5


Hey, Ryan. Looks great. Works fine.


I meant that we don't need the flag if use the comparison directly so we could get rid of this code block for setting the flag.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/18949/testReport/) for this commit**


`are you crazy?` ou é internetês que eu não conheço :P


Should be `return callback(err)` -- so that execution stops there.


Scusa,  piccola svista , questo è il corretto pinout:

```
//** DAC for motor vfref current
#define DAC0_SYNC   53 // PB14
#define DAC1_SYNC    6 // PC24
```


Or, actually, it could just be `licenseAPI.get(callback)`


This whole block is the same as not having a catch at all -- instead of returning a rejected promise, it catches that and returns a rejected promise.


I thought about that, but I think I'd need to combine ngClick and ngMousemove somehow. I wouldn't want it to scroll just because someone's mouse rolls over the bar. They'd need to intentionally drag it. Is there a way to combine those or otherwise achieve that without jQuery?


Was it supposed to be this way?


Did you tested this? Cause I think there's a typo, but even fixed it will not work since File.open attempts to read local file, and we are trying to read a remote one


Oho thanks for catching me there :)


There's also this in a later test "Start the server with server name "host" and the link local name server is used to resolve the server name"

```
      +== Running Middleman failed: Bind address "198.105.244.11" is not available on your system. Please use one of "127.0.0.1", "10.0.2.55", "10.0.1.211", "::1", "fe80::1", "fe80::a299:9bff:fe11:2a39", "fe80::7416:45ff:fe60:142d", "fe80::3e07:54ff:fe57:7ed6". Please fix that and try again.
      +Found dns db
      +I, [2015-08-11T10:22:24.444001 #4362]  INFO -- : Starting RubyDNS server (v1.0.1)...
      +I, [2015-08-11T10:22:24.444059 #4362]  INFO -- : <> Listening on udp:0.0.0.0:53
      +E, [2015-08-11T10:22:24.444490 #4362] ERROR -- : Actor crashed!
      +Errno::EACCES: Permission denied - bind(2) for "0.0.0.0" port 53
```


Last two nitpicks, 'glusterfs' should be in single quotes because there's no variable interpolation, and the arrow alignment isn't done in this project, so please remove it.


Not giving up


Daniel


The last one (the tertiary to if) was done because VC was giving compile error with the () around the comma list, while gcc gives warnings without the ().  But in this situation, the tertiary is not needed, and produces no better code than the if/else.  If we were returning something, then the tertiary can help a bit in this case.

Using the tertiary in the way done, as a work around for an if/else, should be considered a breakage of the coding guidelines, where you have this if statement:

expr ? do_1 : do_2;

if (expr) { do_1: } else { do_2; }

If we are going to enforce the layout of the above if as being 'bad form', then the equivalent tertiary should not be a valid work around to 'allow' it.


It probably makes sense to add coverage for all the ``addToExpression`` methods...


The manoto installers are now at the QA URLs, @xiam, for integration into the update server.


you probably want #underscore instead of #downcase to support classes with > 1 name (e.g. OfferPlayer -> offer_player_id)


Consolidated some functionality here with some Meta programming neater


Anything that doesn't include `for-print` or `.print-only` should've been left in `_type.scss`.
https://github.com/zurb/foundation/issues/6835


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.4.1b11b9dce9b64d7a748201e52a4d3cbc61a0ec07](http://build.palaso.org/viewLog.html?buildId=60924&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:34:23


This removal also removes some tests from the parent class, but we woudl like them to run with our code.


Reaverpedes -> Reaverpede


Added references


I'm strongly in favor of const correctness for methods and members and _some_ local variables.  For something that's an intermediate variable in a calculation that spans two or three lines, I want the process of extracting that intermediate variable to be as light as possible.

Consider that one of our chief uses of local variables is function parameters passed by value - and we almost never declare those as `const`.  Imagine how bulky the code would get if we enforced that!

Remember, not using `auto` will catch issues too sometimes when you have a mistaken idea of the type you're getting.  But we use `auto` in non-generic code because it's an easier read.


Validação para o usuário não alterar post que não seja dele mesmo


Yeah, I fixed four errors already. I linted and found this one on my own. All should be fixed now.


No problem!  Thanks for the example.  I'm unable to use the solution you have right now, but I'm doing something very similar.  Your code saved me a ton of time!


@cppforlife `fog-aws >0.1.1` had problems with the way it required files.

https://github.com/cloudfoundry/bosh/pull/834 has description of this problem.


I personally like it more if it's called `_sync_lock`, instead. :-) This is not an important comment.


This is simple enough to drop the tmpfile and use [`RuntimeDirectory`][1] instead:

    RuntimeDirectory=opensips
    RuntimeDirectoryMode=775

`/var/run` can be replaced by `%t` too (see [systemd.unit(5)][4]).

It exists since [systemd 211][2] which is sufficient for Jessie (ships with [systemd 215][3]).

 [1]: http://www.freedesktop.org/software/systemd/man/systemd.exec.html#RuntimeDirectory=
 [2]: http://cgit.freedesktop.org/systemd/systemd/tree/NEWS?id=v211
 [3]: https://packages.debian.org/jessie/systemd
 [4]: http://www.freedesktop.org/software/systemd/man/systemd.unit.html#Specifiers


Duplicated classes: https://github.com/zurb/foundation/issues/6836


I used 34 intentionally (the correct answer is the same as with 30), but I don't think any of the presented details differ when changing it to 30, so using a case with positive remainder didn't turn out to matter.

I also don't think the right-shifting values are wrong (they're only shifted one from the prior numbers, two from the set before that), though I did get the labels wrong. I'll fix that.


Looks lovely.

As a comment as to why you didn't need the local variable:

The optimizer will completely get rid of the double access to the member variable just as if you'd had the local variable...

and also, unlike Javascript, the cost of accessing a member of a `struct` is incredibly tiny - basically, a single machine instruction - whereas in JS you have to do a hash table lookup with a string, likely hundreds of times slower!


Test


WindowComplexManager_Speedup (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1796 of 1796 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Vertex Shader is incomplete


Probably want a better message; something that is more meaningful in context:
```comment.save
> <123412341: error "user_id does not exist in the system">```
vs
```comment.save
> <123412341: error "orphan Comment: this comment is not referenced by any User">


Maybe instead of "This method is atomic" we could replace by a phrase that explains the problem. Something like this:

    Important: there should not be more than one sync process running for the same
    database file, otherwise database consistency can not be guaranteed. Despite
    that, the atomicity of this method is not ensured here. Each caller should
    implement a locking mechanism to ensure atomicity.


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2194 of 2232 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.3%25-yellow.svg)


não caberia um `local` aqui?


Merged


I mentioned this one in person


Same issue with the other method I mentioned in person. I think there's a cleaner way of writing this.


Discarding fragment is not the right way to do this.


I like this one! But, is there a better way to detect if the branch is merged or not?
Checking the textual output seems error prone and not future proof...


WindowComplexManager_Speedup (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


You might also add some checks - max(abs(euler_error)), recourse constraint check


It's not clear how we can get here. But somehow it has happened..
Should we insert warning message here, for debugging?


```(err: Error, collection: any)=>void```


I am aware of this.
Anyway we need to change the behavior of the MoveTargetedHome() function to use the local coordinates for the npcs which are on transport.

But, as you said, let's do that first, then we can change this to something proper.


Ah. Ya, sorry I read it was shifting right res/total.


mentioned over slack. this is just a reminder comment


I haven't released a gem with this commit yet.  @FooBarWidget had already alerted me that it should be reverted.


I know this is not the right place for this, but I can't seem to find another way to contact you.  The adobe reader munki repo has stopped updated since 11.0.10.  I can not get 11.0.12 deployed.


Generally foreign key constraints are not built into Rails apps.

I've worked with projects that use the [foreigner gem](https://github.com/matthuhiggins/foreigner), but in general I've seen programmer diligence and tests maintain referential integrity instead of strict constraints.


first


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


On 08/11/2015 01:15 PM, Deyan Ginev wrote:
> The only cases where we're binding STDERR away from the terminal is when
> the log is passed back via some channel, and in those cases it should
> never be colored anyway. Possibly accidentally good design, but good
> design nevertheless.

Good to hear; was going to say, it probably is avoidable to rebind
it in such cases, but sounds like we're already there.


Project Added


* Increase number of repetition.
* Options for grid size.
* Trade off bar of k anonymity and clustering.
* Probabilities should add up to 1.
* Support multiple users at the same time.


@shreyasp can you email the mongodb-user user group? This is probably not a great venue for troubleshooting your problem.

https://groups.google.com/forum/#!forum/mongodb-user


Perfect


da hora! :+1:


I added `no_cdata_fields: ['title', 'author']` while creating the rss feed, but these fields still have cdata in them. What could I be doing wrong?


@rpg777 this CMakeCache.txt file shouldn't be here, I don't see the file in git but it must be in your local directory.  Can you clean it up?


........what


Good catch, I knew there had to be a couple of these sneaking through! To avoid the `try/except`, you could add `from past.builtins import basestring` to the file imports. The `past` and `future` libraries automatically pick the correct use (so the imported `basestring` will be `basestring` under Python 2 and resolve to `str` under Python 3.)


Ok, got it. you are referring to code block which does flag=0. Agreed, that will not be needed any more. Will remove it.


Just so we are on the same page, we have decided to use `class` binding rather then `@Attribute('class')` since we are saying that we will be rename `class` to `className` regardless if `ng-class` is present.


I always get $this->getServer()


should check for APIMinorVersion being valid as well


Could use Cluster.timeSince for this


olivr or olive?


Shouldn't this be just "dhparam" instead of "./dhparam"?


Funny... the first thing I see when following the link:
> Note: Turbolinks 3 isn't production-ready yet. Expect breaking changes before the new version is released.


would it make more sense to default these to the 2.1 we had - then there's no change in default behavior.


I think it's best to terminate if dhparam is not there. Without it, MiTM attempts which could've succeeded will fail, thus hiding security issues.


que onda con esto?


@QuLogic good catch, I made it public. I was getting the same message as you but now it looks okay.

I added this week's event, let me know if you can't see it still.


could we just put
```
option.label,
option.tag && this.renderOptionSpan(option)
```
here instead of making a new function?  since no additional props are being passed to the div itself?


Perfect!


On 08/11/2015 01:12 PM, Deyan Ginev wrote:
> That being said, given that there is theoretical desire to move towards
> latexmlc as a default executable, we should find a way to make it work.

As an aside: I think after the configuration experiments, not to mention
the, um,
decentralized algorithms of latexmlc, LaTeXML.pm & Config.pm I encountered
adding JATS, I suspect that a program *like* latexmlc is the target, if
not necessarily exactly latexmlc.

Somehow the server oriented functionality and the basic conversion
stuff need to be teased apart in such a way as to leave the
conversion transparent, but supportive of server usage --- which is
important and needs to be supported.   It currently
seems too opaque to me.  But that's a debate for another day.


How did that go a week without anyone noticing?


Any reason to we `setCategories` twice?


@jcorbin what versioning scheme is this... semver?


Não da para fazer isso uma vez só antes do case juntamente com o `read`?


This isn't a netbeans project... was this line committed by accident?

Please forgive my ignorance -- I don't really know anything about netbeans.  If it makes sense to add this to our .gitignore then I have no problem with it... but I would prefer to do it in a separate patch.  I always prefer small atomic patches that only change one thing.


The plugin must be initialized before you can use it


ta me zuando que isso é o `tee`! Faz total sentido agora! o.O


On 08/11/2015 12:49 PM, kpj wrote:
> Yup, that works. Is it enough to only check STDERR, or does LaTeXML also
> do some STDOUT related stuff?

So it seems to work nicely now....
But while I was wanting to avoid the christmas tree effect,
I'm wondering if the effect is a touch too subtle?
Especially the yellow?  How does it look if you add BOLD
to Error and Warning ?  And maybe also in the status line?


Oops. Seems like I have accidentally changed this line. Thanks for pointing this out! I have pushed a fix.


The correct formula here is `(core::usize::BITS/4)+2` (== 6 on a 16-bit target).


WindowComplexManager_Speedup (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (748 of 748 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.2%25-green.svg)


let's change the parameter to a const char *


Even it's true. I think it's worth to show zero row in that case.


@karan-kapoor90, Can you paste the relevant parts of your code in here?


Yes; semver.


Can you do something like "value.length" against the text field instead of hard-coding "99999"


Typo. s/contraint/constraint/


Yes, I think so. I will change it on both rva2ofs.c and ofs2rva.c. Thanks!


You have some good ideas with the logic here but there are still a few mistakes that will trip you up in trying to execute this program.
```
function getPlayerMove(move) {
    // Write an expression that operates on a variable called `move`
    // If a `move` has a value, your expression should evaluate to that value.
    // However, if `move` is not specified / is null, your expression should equal `getInput()`.
    var move;
    if (move != null) {
        move = move;
    } else {
        move = getInput();
    }
    return move;
}
```
In this code block your variable `move` is already being passed to you through the functions parameters so creating a variable of the same name doesn't really make sense. The if statements below it have some good logic, but in the case of JS `null` objects actually have a value of `false`, so you can actually write this entire function as
```
var getPlayerMove = function(move){
  return move || getInput();
}
```
This is essentially the same for the getComputerMove() function as well...

This is a great start and you'll learn more of these tricks down the road. Keep up the good work!


going forward, this won't be hard coded into the campaign page form, will it? it should only ask if the template has a thermometer, right? and I imagine we'd want to put the activate/deactivate in the form for that plugin on the page


Actually, do we want to pull build status from your repo here? Currently it says we're failing


Unfortunately IOS does not support value.length


I still think that live updating is an anti-feature. can we just make the UI element changing change the state, and submit the state with the button?


why not just call output_stream::close_file() here?


this is the report creation so that URL can't be in the API response. in this case and only this i think i have to create it.


So this fixes being able to launch purchase from another extension? I only currently launch purchases from my main app.


here it should use the link created above, no need to create it again


@Diego-F-Aguirre DWMR. Thank goodness for friends with skills! You'll be doing the same for others soon. Really soon given your tremendous progress lately. It's impressive. :+1:


Con esto cierro #20


One way is using `trap_SendServerCommand( -1, "blueWins" );` and handling "blueWins" in `CG_ServerCommand()` in cg_servercmds.c.


Nice spotting, has been fixed.


this is fine, but it makes me want to refactor the common code out of output_stream::add(char* target, map_pidtype &pids)  I'll probably do that after your patches are merged (unless you want to do it yourself)

I find the whitespace to be a bit awkward, though.   I'd prefer to see:
if ((sock = expression) < 0)
on a single line.  (bear with me, I know I have some whitespace hangups ;-) )


is this auto-generated or did you realize how sweetly succinct coffeescript is?


I'm guessing the former  :P


I didn't have a chance to test this. I'll have a look tomorrow and see if I can work out an alternate solution


@belucid you are right, this needs to be fixed


The Haxe code and Java code run on different threads, I haven't followed when and how this method is called, but if it's called from one to access the other, without going through a handler like this, you will randomly have crashes based on bad threading calls


@belucid same as below


@hbun DWMR. Thank you for the efficient work. Keep it up!


FYI, you misspelled 'initialize' as 'initilialize' in a couple of places.


so does this auto-generate a react form for each plugin? if so that's kinda tight


also rename this file


what is ZeroClipboard?


I don't like this change that `os.path.join` and `os.environ` were refactored away here, because after that, search paths must come from an environment variable. That refactor doesn't seem to be pertinent to the fix.


Alright, if that's the case the rest of this looks good then.


No. The reason is that some computer don't parse the § symbol correctly. Instead of displaying the color, you will display an empty rectangle plus the color text.
If you see the PocketMine source, the § character is not written directly but is written its binary code


This is actually only a problem when the glibc header is included, which declares malloc with the malloc function attribute... which implies among other things, no side-effects unlike this malloc.


We can probably use `merge: true` here instead of resetting the collection each time.


I just built the project as it is now on master and this is the contents of the top of the output file:
```javascript
(function webpackUniversalModuleDefinition(root, factory) {
	if(typeof exports === 'object' && typeof module === 'object')
		module.exports = factory();
	else if(typeof define === 'function' && define.amd)
		define(factory);
	else if(typeof exports === 'object')
		exports["clappr"] = factory();
	else
		root["clappr"] = factory();
})(this, function() {
...
```
The
```javascript
root["clappr"] = factory();
```
line should do it.


fair enough :)


I would prefer to see the name_index padded with some leading zeros, so that the resulting files can be sorted more easily.  I'm not sure how many digits we should pad for.  Perhaps choose a sane default and provide an API for the caller to specify how many digits to use for zero-padding.


You may want to put some kind of timeout guard on this (or see if the existing one is actually timing out). It looks like you could have some of these block indefinitely here.

I *think* the timeout on the NewSSHClient is just timeout to successful connection, not for the entire session.


Lol


I am already using BOLD to distinguish "error" from "fatal" (both are red). Should I additionally underline "fatal" instead?

Also, this does probably also depend on the used font, terminal, etc. (in my terminal I can not see a difference between with and without BOLD due to my weird font setup :( )

[Here's](https://github.com/kpj/LaTeXML/commit/4449faa628cd9f216bf2486770faa8502ff7826d) how it looks with bold everywhere.


yrdy


nice cleanup


This isn't simply about restoring dependencies which I know could be done with a build dependency. This creates the project.lock.json files which is necessary for the follow command to execute.

It would be nice if adding a build dependency did this automatically, but this was the fix that @lodejard suggested.


didn't we use a dynamic_cast for areatriggers? (just asking, not sure here)


While it's pedantic, the usual way to do this is just `var output bytes.Buffer`


nope; never lol


Ok cool, it already looks pretty compressed.


It was written much earlier.

It also was built initially this way to be able to plug in named time zone parsing later.

I would have actually liked to write the state machine for other parsers as well -- cos it's kind of fun -- but finally decided that the end result would be awfully unwieldy...

Ah well -- this can easily be "simplified" ...


spawntype is likely DEAD_DESPAWN - this way the npc will respawn after a short time


r+


test


saw approval from graydon
at https://github.com/jedmccaleb/stellar-core/commit/f59900125348d840696edc0c68b3e8c3c642ed49


merging jedmccaleb/stellar-core/master = f5990012 into auto


jedmccaleb/stellar-core/master = f5990012 merged ok, testing candidate = 345a3bba


Why did you choose not to put this in a React component? they seem like a nice way to handle front end facing JS too


Ah, okay.


Great, tnx


You are right, there is no more use of glib just the glib.h include, I will send a patch doing this.
Thanks


I had a little bug where permissions would only work if they were the 0th element in the array. They can be anywhere now.


We usually use BBPromise, lets stay consistent


Regarding the busy port case, that is already handled by output. i.e. if the user tries to put more data into the queue and it is not consumed fast enough it will set it self to busy.

Yes, ERRNO_BLOCK would probably be better. I don't know if any systems we run on today uses ewouldblock instead, but better safe than sorry.

As for the non-blocking stuff, what you suggest sounds about right. My main concern is that we might screw something else up when doing that. If only I knew what that might be...


converts 0 -> 1?  (might be ok, just asking)


clarify: Is this the meeting point (middle of bridge, compare to comment above) or just near the first npc?

Also: Where is the area-trigger spawned, maybe you can use something like 20y in direction 5/4*Pi


I suppose so. The whole user-defined ```_id``` was borne out of an actual use-case here at Stanford, where most labs simply go by their PI's UNIX ID. The desire to have a ```name``` came much later. I'll make the change, but we need to account for the possibility of ```name``` being undefined.


This source formatting commit fix the alphabetical order from aui-form-builder.js


I understand you do not want to do extra overhead, but why not use GetData(DATA_BRIDGE_EVENT) and SetData(TYPE_BRIDGE_EVENT)


Oh, with normal use-case? So everyone should take this PR ASAP?


This source formatting commit change the name of component form-builder-pages to form-builder-page-manager.


Yupp, Inkscape optimized output + svgo.


Yes! Congrats!


Println...


This needs to be resolved by the updating actual link to the other KB


94006714-MultipleTowers (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1796 of 1796 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This looks strange - this is an object that one creates with a new HtcpPurge(...), which means the constructor returns "this" (implicitly or explicitly). If you do open(), which IMHO should be an async operation, it should return a promise. Thus, don't open it in constructor, but instead caller should explicitly call open(), expecting a promise back.


I was going by https://docs.python.org/2/glossary.html#term-eafp but I am flexible.


97204612_MultiSpeedFan (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1803 of 1804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


That's right. This whole view is dead.


I'm thinking to add a pengine property  like "concurrent-fencing" (or "concurrent-stonith"?) for this, which defaults to false. Besides the ordering you mentioned, I think we'd also need to create ordering between every stonith op and dc_fence. I'll take care of these and then take a look at adding a per-device option as Lars suggested.

But first, I think we need this:
https://github.com/ClusterLabs/pacemaker/pull/773


This will add the plugins twice since: dir containing plugins and plugins.


Although, it is still showing at `campaign_pages/:id/edit`


did you add this line to your config.xml?
`<access origin="cdvfile://*"/>`
It is necessary for Android to use cdvfile as a path.


Thanks :+1:


This will prompt the user for a connection, right?
If so, it should just use the one just created.


Initial coding


Actually it wont but because the copyIf function is very specific and does'nt list the directories.


Here was a bug


lol I was just working on this


@NealJMD it was, but I stopped with this idea... this should also go! Start looking at `campaign_pages/edit.slim` - that's where all the action is. I've used vanilla rails forms, with `remote: true`. It's the quickest way to implement components.


I was using orange for error and red for Fatal in CorTeX, but that was also experimental. And not sure you can emulate orange here.


@kylog good call. The `gem` package is an alias for the `rubygems` package but is not aliased on all the platforms in scope. I will update this to `rubygems`. I have validated that these are available on fedora-22, centos-6, redhat-7, redhat-5


LGTM


We could talk about implementing a react lib for dynamically building components, but that's a job for another day.


# Level 1 Title
## Second level markdown
### more
#### is this valid


I prefer extending from Selector.selectorlist_cls instead but just a my preference.


nit: API will be more user friendly if we implement boolean  flag  to differentiate failure (i.e. the lock exists) from error (i.e. etcd is down).


This is the substantive change; the rest is all formatting.


Canola is strange


No need to import SelectorList from parsel and you can be sure it will use the same class used by Selector.


I was trying to use it for js clipboard management. I want the campaigner to click on stuff in the edit view and have a liquid tag pasted to their clipboard for pasting into a template. It was feature overkill, and so it's no more!


so does your system use react at all or no? we added it to be able to dynamically add and remove forms, so that I guess doesn't happen in the new vision


@wtachau weird, i don't see blue_arrow.png inside my xcode navigation pane, but I see the file in the repo.


```expected filetype to be indicated in zip file comment```


^ please remove this line


sounds sweet but glad we're not using it right now.


this comment is wrong?   i guess you can just remove it.


On Tue, 11 Aug 2015 11:16:43 -0700, José Roberto de Souza wrote:
> You are right, there is no more use of glib just the glib.h include, I will send a patch doing this.
> Thanks

There's a PR from @barbieri taking care of that and other things


haha! It was kindly generated for me by rails scaffold - I was in too much of a rush to switch to `js`. It was nice, though. Anyhow, aren't we supposed to be using sprockets with es6?


`this.track` is unused so this line can be removed?


:tangerine: sweet!


Oh sorry, I missed this one. Thanks!


@tjenkinson I already checked, and the problem was indeed the library output name in lowercase. There were some other problems in the main exports that broke after changing this, but it's already fixed (check 7f4f2575c056edbc05496a33c589d6c0c4201353).


where does this stand now?


@horton1 @mbougie
Pull changes from Crossvalidation for last week's changes.


add  BBPromise.promisifyAll(dgram.Socket.prototype); at the very top, right after require('dgram'), and than use return socket.sendAsync(...);


94006714-MultipleTowers (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1796 of 1796 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Nice catch for the types! :)


@thenickcox If we warm the cache before the daily update (as here) does that mean we're warming the cache with yesterday's data?


I understand your point about providing upgrades for the SQL tables, please remember that there are two types of upgrades that would happen. The item/mob database tables are essentially data, while all other tables we provide, are empty containers for data generates by the server.

Most of (if not all) the sql upgrade scripts we have, are upgrades to the table structures, setting default values for the new and existing records (as well as altering the original creation script).

Item and mob databases would require a much more complicated approach. In the case of an update to the data, we could offer a script that updates the changed values (but that would overwrite any customizations you made, without you even noticing, whereas an upgrade to the libconfig database would generate a one-line conflict, easy to solve, for the affected line or lines).
If, in order to detect this kind of changes, you keep up to date your main item_db.sql, such a chance would easily generate a file-wide conflict (like it used to happen with the former csv version of those databases), making it almost impossible to track the conflicting line.
An example of this that you can easily reproduce is, if you edit the name field for several monsters in the mob_db (.txt or .sql, the effect is the same), and then we release an update that edits the atk for a few monsters, or adds new entries: the almost entirety of the file will be marked as conflicting, and you'll have to manually verify the changes in each and every line -- or rather, restart from scratch. If you do the same with the item db (libconfig format), chance is it will generate absolutely no conflicts, since the lines you edited and the lines we edited are separate and easily detectable by git.

An even worse case would be the update of the database structure to add a new field. That would require an upgrade script to alter the table structure, as well as a script to enter the new value for all the items that don't use the default value (think of what would have happened when, for example, we merged the item_trade_restrictions into the main item_db).
Additionally, the main sql file would need to be updated, causing the havoc described above.

Regardless of this, the rationale behind this update is that, any data generated by the server goes to sql, while any other data goes to a configuration file. As a bonus, sql backups will also be smaller, and won't need to contain megabytes of static data.


I suppose you can reduce this code a bit by leveraging `bind()` more, i.e.:

```js
this.data.on("add", this.emit.bind(this, "add"));
this.data.on("delete", this.emit.bind(this, "delete"));
this.data.on("update", this.emit.bind(this, "update"));
```


would be nice to actually have throw new BlaException here.


¿Por qué no asignas algunas partes para que las vaya traduciendo @amorag ? O revisando lo traducido...


On 08/11/2015 02:12 PM, kpj wrote:
> I am already using BOLD to distinguish "error" from "fatal" (both are
> red). Should I additionally underline "fatal" instead?

Could do; might as well.

> Also, this does probably also depend on the used font, terminal, etc.
> (in my terminal I can not see a difference between with and without BOLD
> due to my weird font setup :( )

Yeah. I hate to fine tune this stuff based simply on what some
particular terminal program shows, but...

So, the bold red for Error looks good.

Curiously, the Warning with non-bold "yellow" was more orange
and the bold yellow is actually yellow and even *less* readable!
I think it's better w/o bold, although I wish it could stand out
a bit more.

I'm indifferent to the bold vs. non-bold Info

Hmmmm...

Maybe best is adding bold *only* on Error & Fatal
(and underline Fatal if you'd like).

Could probably do more with background colors, but that's
probably a bit too loud.


Perhaps return as an enumeration, since life happens and we often need to accommodate more than a binary state?


same here


test


I know it was in a previous commit, but why is there a leading underscore here? This function is not internal to the module, right?


Not sure I see this.  If a process can't acquire the lock, does it matter why?  If etcd is down you can't become master any more than if some other process already holds the lock.  Am I missing something?


right now sprockets es6 is turned off and we're just running babel as a pre-processor cause it handles JSX out of the box. right now it only runs on files with extension `.js.jsx`, but that's trivial to change.


No problem! :+1:


I wanted to keep a low bar for component building. I think we need to establish a strict pattern for this. Really this should be inside `plugins/thermometer/application.js` - the namespacing is important, and it's what we'll recommend to the community for engine development.

Using a react component here would kill the liquid partial for the thermometer, but also, the behaviour required here is so simple, using react would be an over doing it.


Instead of simple statements, maybe you could clarify that by saying 'only single statements', because I think once you write more than 1 statement you will need to introduce the curly brackets.


Bravo! Sorry, I looked at the fist commit first :)


"due wrap"?


I would just say ```    UIButton* accessoryButton = [[UIButton alloc] initWithFrame:
                                  CGRectMake(0, 0, 40.0f, 40.0f)];``` for readability sake, compiler optimizes for this already though I think. I assume there is something else I may not understand, feel free to leave it.


Great, thanks!


cool story bro


Hier könnte man als Rückgabetyp `ConfigOption[]` verwenden. Dann kriegen IDEs die Auto-Completion hin.


Please add the doc - not sure what each of these means


Awesome work Joy! You were *crazy* close to getting it! I was curious what was breaking myself so I went and fixed it the way I would have done it.
```
////////////////////////////////////////////////
/*   Provided Code - Please Don't Edit   */
////////////////////////////////////////////////
'use strict';

function getInput() {
    console.log("Please choose either 'rock', 'paper', or 'scissors'.");
    return prompt();
}
function randomPlay() {
    var randomNumber = Math.random();
    if (randomNumber < 0.33) {
        return "rock";
    } else if (randomNumber < 0.66) {
        return "paper";
    } else {
        return "scissors";
    }
}
////////////////////////////////////////////////
/*           Write Your Code Below            */
////////////////////////////////////////////////

function getPlayerMove(move) {
    // Write an expression that operates on a variable called `move`
    // If a `move` has a value, your expression should evaluate to that value.
    // However, if `move` is not specified / is null, your expression should equal `getInput()`.
    return move || getInput();
}

function getComputerMove(move) {
    // Write an expression that operates on a variable called `move`
    // If a `move` has a value, your expression should evaluate to that value.
    // However, if `move` is not specified / is null, your expression should equal `randomPlay()`.
    return move || randomPlay();
}

function getWinner() {
    var winner;
    var playerMove = getPlayerMove();
    var computerMove = getComputerMove();
    if ((playerMove === 'rock' && computerMove === 'scissors')
        || (playerMove === 'paper' && computerMove === 'rock')
        || (playerMove === 'scissors' && computerMove === 'paper')) {
        winner = 'player';
    } else if ((playerMove === 'rock' && computerMove === 'paper')
        || (playerMove === 'paper' && computerMove === 'scissors')
        || (playerMove === 'scissors' && computerMove === 'rock')) {
        winner = 'computer';
    } else  {
        winner = 'tie';
    }
    return winner;
}

function playToFive() {
    var playerWins = 0;
    var computerWins = 0;
    // Write code that plays 'Rock, Paper, Scissors' until either the player or the computer has won five times.
    /* YOUR CODE HERE */

    while (playerWins < 5 && computerWins < 5) {
        if (getWinner() === 'player') {
            playerWins += 1;
        } else if (getWinner() === 'computer') {
            computerWins += 1;
        }
    }
    console.log('Player has won ' + playerWins + ' games.');
    console.log('Computer has won ' + computerWins + ' games.');

    if(playerWins === 5) {
        console.log('Congratulations! You won!');
    } else if (computerWins === 5) {
        console.log('Computer won. Sorry, play again.');
    } else {
        console.log('Keep playing.');
    }
    return [playerWins, computerWins];
}
```


caber-lo-ia.

Vou fazer


All of my sass additions were rushed, and are awful and disorganised. We should think how we're going to organise our css components. https://smacss.com/ is quite interesting, for e.g.


I've never heard about any abstract that's placed before the title, and it changes the first page quite severely in both `article` and `scrartcl`. What motivated this change?


I would test for the negative of that and throw an error right away.  Reduces nestedness


this block removes the need for actual `div` separator elements


On second thought, instead of `DstoreToStoreAdapter ` extending `Evented` and then forwarding events from `this` to `this.data`, could you just define an `on()` method?

```js
on: function (type, listener) {
    return this.data.on(type, listener);
}
```


We could make fun bits, like successful math parses, green :-)


TTL=0 is not valid :)


`__DIR__` spart den Funktionsaufruf von `dirname()`


I guess I'm confused by your constant references to the file's size relative to the rest of the project. Are you on a host with extraordinarily limited space?

The file is not served to visitors, so that's not a concern. And in my opinion it's a good idea to have all the source files under version control if you're going to also include the compiled binary. For example, see https://github.com/nprapps/lunchbox, which includes all the source as well as the installable .dmg and .exe files.


The comment and type should be dstore/Collection, not dstore/Store, right?


"File not found "


thanks for the info. It is strange that you can specify this only inside shader on iOS, so you lose the ability to specify other parameters with the API.


I'm fine with this for now, but if we start building more complicated stuff (a recent signers plugin for example) I could see react as a way to add some important structure to the JS.


I noticed that the test result changed.  What is the net effect of the ngram change?


patch looks good, apart from some whitespace issues.


`Illuminate\Foundation\Application` will almost certainly be present, but `Aws\Laravel\AwsServiceProvider::boot` will fail if it is not present. ([The bundled config is merged with the published one](https://github.com/aws/aws-sdk-php-laravel/blob/master/src/AwsServiceProvider.php#L27).)

This way, if there is a use case where someone was using the Laravel Service Provider outside of a Laravel application (maybe in a Lumen app), they could use this package.


AH! Fantastic. Thanks. I just saw the Travis error float by. Apologies for the interruption then :)


Sure, just created PR #240.


Open is not async and dgram doesn't support async socket creation (and why should it?)


haha, show o/


Look at this abomination. These lines fill me with self loathing. I am sorry.

Really what should be happening is the template is associated via a select at `campaign_pages/:id/edit` and here we can just ask for it:

```ruby
  layout = if @campaign_page.liquid_template
```


That's not true though. If you have a lumen all, you publish this config file and remove the call to that constant.


Yeah, this should be improved, of course. I've been doing all the connection changes in a hurry because of my pretty busy schedule. I'll eventually get back to this (or someone else might do it in the meantime).


This package worked just fine on lumen before you reverted this.


Mainly happy with it, but it doesn't belong here. I'll think some more on it tomorrow.


should it return `out,true,err` in this case?


Just building up all the necessary data required for the liquid template to render.


I suppose it does. We could just move it after that. Is there a reason 4:30am was chosen for the daily update?


ok.


The config publishing in the boot method has nothing to do with the config loading btw.


This is a little bit nitpicky, but I think this should be renamed to `TGNetworkManagerCommissionerStateDisconnected`

"Not Connecting" is a little ambiguous -- i.e. are we not connecting because we're disconnected, or because we're already connected?


On 08/11/2015 02:35 PM, Deyan Ginev wrote:
> We could make fun bits, like successful math parses, green :-)

Oh, like in the summary. Yeah. good idea.
And symbol "assumptions" should be yellow...


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.425.cd60ab56e289c4dc6f1c4912738b8e85d6503fc5](http://build.palaso.org/viewLog.html?buildId=60929&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 859, ignored: 54 Build time: 00:18:49


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/75136300


s/MathJaX/MathJax


> This way, if there is a use case where someone was using the Laravel Service Provider outside of a Laravel application (maybe in a Lumen app), they could use this package.

My point is that that worked just fine even with this reverted again.


But this is a light-background colorscheme...


make this `(nonatomic, readonly)` ... We don't want outside classes being able to change the state directly. Inside the implementation of the class, you'll need to refer to the iVar, i.e `_viewState`


hahahaha this is awful.


this is sending back html to an ajax request. Quick and dirty app feel


Yeah. It was only added to OS X after [someone filed](https://twitter.com/hoserama99/status/613872192581832704) a radar report requesting it though – hopefully that means they'll also add it to iOS soon, to keep Metal on each platform as close to feature-parity as possible...


Because it's a) likely to be after the view data on stats.grok.se has been updated for the previous day, and b) it's likely to be a time when no one in US / Canada is using our system.


this change breaks build on Debian 8.0 Jessie, please fix lua to use newer lib


So many helper files! They can all go.


If we did something like this http://stackoverflow.com/questions/3716633/passing-parameters-on-button-actionselector , then we could avoid the touch position look up to get the row. What do you think?


@Falavius12 That's why you code on a phone like me


Thanks for the heads up.  Will add it tomorrow

On Tue, Aug 11, 2015, 06:10 Tim Klein <notifications@github.com> wrote:

> You want this too, That icon was terrible:
>
> CandyRoms/frameworks_base@359287f
> <https://github.com/CandyRoms/frameworks_base/commit/359287f24c1268aa049418f8d653e91c686e8285>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AICP/frameworks_base/commit/dbb697d19db7318da4445c6089427a5d313d5f4f#commitcomment-12630637>
> .
>


can we call these something else than split and split2?


This was my rushed stab at creating our `action` model. When a user performs an action, it gets persisted here.


Alert tag is pointless instead try using console.log(" ")


We never had replace replace inputs. So it is normal that it don't work
without modification.

Ideally, we should fix this, but if you have no idea how to do this, a work
around is ok, but make an issue to fix this.

On Tue, Aug 11, 2015 at 4:02 AM, Chienli Ma(马千里) <notifications@github.com>
wrote:

> I think there's a problem in FounctionGraph.replace() method.
> If we replace an input of a fgraph, the function doesn't modify
> fgraph.inputs, so the replace process will fail when it checks for unused
> inputs later -- new variable isn't in fgraph.inputs.
>
> Currently I have to call this method like
>
> fg.inputs[fg.inputs.index(old_input)] = new_input
> fg.replace(old_input, new_input)
>
> ------------------------------
>
> I try to put the first line into FunctionGraph.replace() but that will
> cause error in 3 tests in test_function_module.py:
>
>    - test_deepcopy_shared_container(self)
>    - test_borrow_output(self)
>    - test_extra_inputs(self)
>
> I have no idea why this happened. I just cancel my fix and use that two
> line above to call fgraph.replace()
> ------------------------------
>
> Just a simple to let you know this situation. I think you can notice I
> fixed and then removed the fix in my commit history.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ChienliMa/Theano/commit/4d063ff3650e458888f7d30b4735cc9be309d672#commitcomment-12634492>
> .
>


A service class for handling actions. Shouldn't be here


The sane way is to use `m_worker.join();` there (and remove detach() above). So you don't need m_isThreadAlive variable at all. Recommended solution for the destructor:

```C++
std::unique_lock<std::mutex> lock(m_mutex);
m_queue.emplace(nullptr); // push empty element as a termination request which will be processed after all other requests
lock.unlock(); // must be unlocked before joining
cv.notify_one(); // notify condition variable
m_worked.join();
```


WindowComplexManager_Speedup (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.95%25-green.svg)


Looks much better!


Even Bluebird docs use "Promise": https://github.com/petkaantonov/bluebird ;) And that's for a reason - in this case, the code will need just one line change to switch to native promises;)


This should  be `did you fill in the fields` or ` have you filled in the fields?`


+++ Benjamin Kästner [Aug 11 15 11:34 ]:
>I've never heard about any abstract that's placed before the title, and it changes the first page quite severely in both `article` and `scrartcl`. What motivated this change?

Sorry.  I didn't realize the change would cause the abstract
to be placed before the title.  I thought it just defined
it and it would be placed by `\maketitle`. But clearly
that's wrong.

I was guilty here of accepting someone's recommendation
without looking into the matter myself.  Will revert.


following on the comment above, this doesn't need to a field of the campaign_page, does it?


@Daveguido, are you sure all your networking code is off the main thread? Could you provide a link to your forked github code that contains our project (assuming you have that up)


IMPORTANT - when creating a new campaign page, use this

`CampaignPage.create_with_plugins(clean_params)`

It'll build all of the registered plugins. It might not be what we want right now, but it works. It might be that a plugin is lazily created, when campaigner activates it.


Supposedly, there should be code for standard-compliant implementations later:)


No.
pkg/registry/generic/etcd/etcd.go:
// A bool is returned along with the object and any errors, to indicate object creation.
func (e *Etcd) Update(ctx api.Context, obj runtime.Object) (runtime.Object, bool, error) {

yes, it is confusing


Ow it's not that, I just don't like tagging requiring dev versions in general. I don't doubt Sebastian's work at at all. Will see, it's either going to be a small patch tag is included in the planned tag :smile: . Thanks again :+1:


Can this be moved into the handlebars template?


especially since the association appears to exist here


What? Either explain why there is a error here or dont mention it.


fast-forwarding master to auto = 345a3bba


platest => extra t


@superterran the memory_limit is being interpreted differently on other computers. What was the purpose of it?


Woot! You guys rock!


@sebersole, note this change to TemporaryTableBulkIdStrategy#shouldTransactIsolatedTemporaryTableDDL.

Is this correct in general?


How does the cache become invalidated? We pull new revision data with each 'update constantly', so if the cache is automatically purged each time the revision numbers change, then maybe we should add this cache warming to the end of the update_constantly batch.


@jonleung?


Checking emu status is probably not applicable here because it does "emergency" exit and leaves all work unfinished. I suspect all the "garbage collection" work must be completed at any price.


no it doesn't. that should go.


Is that test not working for you?


to be clear, `clean_params` have no information about plugins, right? it just creates default ones based on tags in the selected template?


right, one less dependency, will update in a jiffy


plugins should be dynamically registered, and the campaign page table should not reference them.


Yes, I think it should. Flexbox is relatively uncommon on the Web and if you use `Box` it'll regress common Web content.


These specs were auto generated.


I'll clean up this spec mess tomorrow.


But now you don't have to open a published file and delete a line that by default causes your application to crash. That's not an ideal user experience.

I'd rather not rely on a dev dependency inside the package's public-facing code.


It would be better to move & rename this file into lib/htcppurge.js, and the index.js file should contain one line:  module.exports = require('./lib/htcppurge.js');  ... or should it be simply called purge.js for simplicity?  (since you won't be able to add any other classes easily. Or you could rename it to "htcp" library, and have a htcp.Purge() class...


nit: no need for `{}`


The semantics seem fine here.


That message is better!


i agree this just is a nit  :)


This is better than the current behaviour, but the problem is that this also skips detection of NaN in the sample, not only in the random state.
One way would be to make `do_check_on` aware of the index of the variable among the inputs/outputs of `nd`. Another way, which would allow for more flexibility, would be to implement #2826.


You're welcome :P


So for the moment, I'm OK with that change.


Oops this should be dec.radian


No need for `as style_structs`


What? addnewtask only takes a name


nevermind, i see it now, thanks!


You could use `catch( InvalidUserNameException | UserNameAlreadyInUseException e) {
 client.sendToClient(new WelcomeMessage(0, false, ex.getMessage()));` and just create the message with the exception. It would remove the if construct.


No need for `{}` (all three lines surrounding this comment) and combine with the line below


Dobre :dancers: Ale udało Ci się. Gratulacje!


uhm... it explains why it was working fine with make alldefconfig and failing with make allmodconfig =)


I think the motive behind the alert tag is to give a visual indicator that
something happened (especially considering some hackers don't check the
console). That said, I can see `console.log`  being more effective because
it sets the precedent of checking the console when doing things with
JavaScript (this'll also cause them to notice JavaScript errors more often).

On Tue, Aug 11, 2015 at 11:42 AM, GaryFrederick16 <notifications@github.com>
wrote:

> Alert tag is pointless instead try using console.log(" ")
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hackedu/hack-camp/commit/f65e97556a2061fec87c6cebd8f8c07a5a81382b#commitcomment-12647806>
> .
>

--
Zach Latta
hackEDU | zach@hackedu.us


This is not a fix for issue #1225. This code is wrapped in a if statement:
                if (_read.Count > 0 || _write.Count > 0)
Both a counts are 0, causing the select to be called over and over again in a tight loop.


I think we may have a disconnect over the intention of the identifiers then.

1. An ID/primary_key in a data base is usually controlled by the DB, and set using auto-increment or creating a uuid.
2. I think the `_id` is used as the document's identifier, it's also a public-facing unique identifier.
3. The `name` doesn't have to be unique, it's a friendly name to further help identify the group.

Maybe I'm way off, but I'm seeing the relationship between `_id` and `name` here kind of like a SKU/Model Number and Product Name in an ecommerce app. For example, [this Mr. Coffee machine](http://www.amazon.com/Mr-Coffee-BVMC-SJX33GT-Programmable-Coffeemaker/dp/B0047Y0UQO/ref=sr_1_1?ie=UTF8&qid=1439318441&sr=8-1&keywords=coffee+makers)'s `_id` would be 'BVMC-SJX33GT' and it's `name` would be "Mr. Coffee 12-Cup Programmable Coffeemaker". It also probably has a separate ID in the database.

Am I on the right path with that understanding?

In practical terms though, maybe the relationship between `_id` and `name` should be that one or the other is required, and both is ok too. If so, then maybe there should be a separate id added as well.


On L70 with ril blobs from L90 5.0 stock this works with two sim.


nit: remove space before `:` and newline after this


Right now, the cache key is just `rows-#{Date.today.to_s}`, so it gets invalidated daily. If we ran the cache warmer after the `update_constantly` task, we'd have to get clever about how to invalidate the cache. But it depends on how granular and exact you want the concept of "revisions in the past week." As a user, I don't immediately assume that that's this exact minute - 168 hours. It's currently checking the `date` of the revision, which is a date anyway (as opposed to datetime), so in some ways, I think it makes sense to check it against the date before today (i.e., yesterday). Does that make sense?


> We could make fun bits, like successful math parses, green :-)

The `Math parsing succeeded:` part, or the individual elements?

> And symbol "assumptions" should be yellow...

Again, the whole `Symbols assumed as simple identifiers (with # of occurences):`, or each individual symbol?


@jonleung?


Could you add a comment here saying what "mode" is? I assume this is the direction that the flex flow lays its kids out in?


nit: no space before `:`


okidoki well i guess we should add a comment to this method on what this 3-tuple means .


I see no present need to expose any other class.


/cc @josevalim: This is how a process transforms a throw/exit/error into its exit reason. Previously we did not handle an exit that wasn't `:normal`, `:shutdown`, or `{;shutdown, _}`.


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2173 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.1%25-yellow.svg)


@VoyagerOne : Yes I did. I've to the string for fishttest from marco's TUNE macro and then on the web page I deleted the first and the last coeff. Btw, I was referring to some other tuning session going miserably wrong with that nodestime stuff.


nelsonab:

Please see https://groups.google.com/forum/#!searchin/autopkg-discuss/Reader$2011.0.11/autopkg-discuss/Lja65cohkZc/SP82PXFWNw8J

(autopkg-discuss would be the right place to discuss this sort of thing)


It looks like the hiking preference is then no longer working (instead it is using the shortcut)


I think that `sudo: false` at the top, along with `sudo pip install`, is a contradiction. This may work OK if we do `pip install` not `sudo pip install` here.


Wait a sec…what is `flex-done.rs` as opposed to `flex.rs`? Is this just a copy of this file that was mistakenly included?

If so, then apply all comments in here to `flex.rs` and remove this file.


That's exactly what the function does.


Yes, that's fine. I just wanted to make sure we weren't unintentionally invalidating the cache multiple times per day and then hitting multiple users with the 15 second load time. No need to give more granular data than once per day.


> missing `if vctx is not None:`

Fixed as of 13fbc711a.

> BTW, will there be warning messages in Sandbox mode?

Yes, as of c6908419.


I don't want to duplicate the explanation provided already, but probably a good idea to provide some kind of link to where the tuple definition is so some poor soul can try to figure this out.


I have asked them on devforums about the state of this feature on iOS.


Hay que revisar los permisos para poder acceder a la carpeta


Not exactly correct IMO - native promise library might not have the same core functions as bluebird - it has a [huge list of funcs](https://github.com/petkaantonov/bluebird/blob/master/API.md). So the switch might not be a drop-in replacement.


Hmmmm. I'd argue that if you're using a custom framework based on laravel components, you should probably know what you're doing enough to realise you need to publish the config file though.


Ok, perfect.


Meh, I guess it doesn't matter that much, lol. :)


Many thanks for finding that!  I've now fixed it.  The code there redefines a delimited-argument auxiliary `\@@_rescan:w` to have the delimiter `'` (in fact the first delimiter that can be found having current catcode 11, 12, or 13), but the delimiter was taken to have catcode 12, when it should itself have its current catcode.  Now fixed by rescanning the delimiter itself.


Sure. :)


I don't think that I'm actually using that line of code anymore


Great. Then it works out of the box! :tada:


Awesome job Victoria! Really smooth code, keep it up!


Also, shouldn't ruby-devel come first?


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.5.cd60ab56e289c4dc6f1c4912738b8e85d6503fc5](http://build.palaso.org/viewLog.html?buildId=60928&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 871, ignored: 50 Build time: 00:33:50


nit: This `TODO` is really a `FIXME`, I think


bleh - i am not a fan of unchecked params by a lib Throw an error if its not valid, or use default if its undefined.


Should poll be used in addition to select? Or perhaps thread sleep for 1ms if read and write count are both 0? I don't know the implications of this method so these are just shot-in-the-dark suggestions


I assume these are just to silence the unused variable warning. Rather than doing it this way, you can just put underscores before the variable names to silence that warning (e.g. `_layout_context`).


Every time I use a <br/> tag, Bill Gates gives a skateboard to a chimpanzee.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1273 of 1273 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


oops, a "<br/>" tag


Ditto above.


LGTM


Dunno, I copied the libertine fonts recipe.


Well that's a period not just a dot,but that's just me nick-picking(spelled right?)


I guess this depends on the used documentclass. I also thought that it would set some kind of value behind the scenes when I used it the first time.

Apparently it's [just a stylized paragraph](http://tug.ctan.org/macros/latex209/contrib/xarticle/article.sty) in `article.sty` (the `article.cls` variant is similar):

```tex
\def\abstract{\if@twocolumn
\section*{\abstractname}%
\else \small
\begin{center}%
{\bf \abstractname\vspace{-.5em}\vspace{\z@}}%
\end{center}%
\quotation
\fi}

\def\endabstract{\if@twocolumn\else\endquotation\fi}
```
So the recommender could have use a documentclass where `abstract` actually did some magic. Either way, thanks for the fast response and revert.


The change is just restoring the check that had been disabled and replaced with "return false". I was having test failures against Teradata without the change.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@fommil I'm hopefully in sight of being "in sight". ETA Thursday for a snapshot release of Rapture XML.


Why caveats are removed?
To do `emacs -f trr` I need these in emacs.d/init.el.
```
(add-to-list 'load-path "/usr/local/share/emacs/site-lisp/trr")
(add-to-list 'load-path "/usr/local/share/emacs/site-lisp/apel/emu")
(autoload 'trr "/usr/local/share/emacs/site-lisp/trr/trr" nil t)
```


ok


It's possible that this is not causing in issue in other projects depending on how you're calling into the IAP methods. But the documentation states that this MUST be called on the main activity's UI thread and the code did not previously guarantee this. My project calls IAP methods through event callbacks and other listeners, and we're seeing occasional JNI exceptions as a result of calling `IAP.purchase()`.


On 08/11/2015 02:50 PM, kpj wrote:
>     We could make fun bits, like successful math parses, green :-)
>
> The |Math parsing succeeded:| part, or the individual elements?
>
>     And symbol "assumptions" should be yellow...
>
> Again, the whole |Symbols assumed as simple identifiers (with # of
> occurences):|, or each individual symbol?

Probably just the numbers/symbols, rather than the whole statement,
I think.


Shall the __version__ in lmdb/__init__.py be updated to 0.87 to reflect the API change?


@propensive cool, this is merged to ensime master now, so feel free to submit a PR. It doesn't pull in all of rapture does it? Because this is literally (ho ho ho) all we need.


RadianceRefactor (rpg777) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


it was copy pasted from views and didn't change it. i ll now


Fine with that apart from the WeakAuras => Internal rename, we don't need to do that.


I know this pattern with `fillVertexTemplate()` is much nicer, but I had it unrolled for performance. We can benchmark but I am pretty sure all these function calls (plus destructuring in the arguments, though that can be simplified) will cause a lot of overhead in the geometry build time. Need to be careful about using ES6 features in hot code paths, but we can try!


Fixed :-)


It is - https://nodejs.org/docs/v0.10.40/api/all.html#all_dgram_createsocket_type_callback


Will it be okay if I find the IP address of the machine that host the server by doing
HOSTNAME = socket.gethostbyname(socket.gethostname())
and then connect to Redis the same way as before?


This test name didn't get updated.  I updated it.


+1 to leaving it inlined, I've seen this take a second to load and it's ugly and the page shifts after it finishes when it's not inlined.


Do we not also document the exception types that might be raised?  Another thing we could/should consider is documenting the types expected by each argument in addition to the description.  If those things are not part of our current doc string standards then carry on!


а это разве нужно? то


yep :)


Yeah I was gonna ask you if that was a pattern you'd like to follow for other styles. I was just spending time reordering  reordering/adding attribute and finding out what was wrong and thought it would be much simpler for like that. I guess for small geometry like here it shouldn't be so bad.


I traditionally put the ``__init__.py`` version increment in a separate commit with a known message that I can quickly grep for.. they're usually the last commit prior to a release :)


Like this for example?
![2015-08-11-210536_1128x213_scrot](https://cloud.githubusercontent.com/assets/645279/9207250/b9b08b76-406c-11e5-8da8-70339d9e1595.png)


скорее всего здесь нужно Human.prototype


sigh, wishful thinking you are :)


check your code in preview as the image is wrapping incorrectly with the text


Something like this?
![2015-08-11-210659_1119x210_scrot](https://cloud.githubusercontent.com/assets/645279/9207288/eac80248-406c-11e5-9865-3078c57d0ebb.png)


Closes #2


same wrapper error here


Awesome job Pam, this looks great! Only thing I would possibly change are adding `{}`'s for your if/else code blocks. This will help others and yourself debug your code as it makes these block statements more readable.


я думаю, что эту строчку стоит разместить на 11 строке, а типизацию убрать


The following change may break other dialects. TeradataDialect.getForUpdateString(LickOptions) should be overridden instead.


@flavour How do I link subscription table to channel_id?
I added self.super_link("channel_id", "msg_channel") in the tablename = "pr_subscription" and then self.configure(tablename, super_entity = "msg_channel",) ?

Do we need all channel_id of msg_channel in the channel id of subscription? I couldn't get it


you need to include another line enter on FAQs as the text is wrapping


I'll move the modifications to mi_lttng.xsd to another patch from this PR:
Mi: track/untrack: validation


стоит указать и типизировать аргументы


Ingresar mejor la ventana de analisis.


Looks good to me, I am a little preoccupied at the moment with work but I will try to merge this in either tonight or tomorrow sometime.


Comentario sobre el completo commit


On 08/11/2015 03:07 PM, kpj wrote:
> Something like this?
> 2015-08-11-210659_1119x210_scrot
> <https://cloud.githubusercontent.com/assets/645279/9207288/eac80248-406c-11e5-9865-3078c57d0ebb.png>

yeah; looks good to me.  Whadya think @dginev?


probably should not be linking to external image services for our own KB.  push images into our repository


Not #33, should be #31


Hi Guys -

There's a bug in this code and you can't create a new extension from scratch anymore.  I'll issue a pull request.

-Steve


Oh it's definitely annoying. We should only keep it if we need to. We can
benchmark.

On Tue, Aug 11, 2015 at 3:05 PM, Karim Naaji <notifications@github.com>
wrote:

> Yeah I was gonna ask you if that was a pattern you'd like to follow for
> other styles. I was just spending time reordering reordering/adding
> attribute and finding out what was wrong and thought it would be much
> simpler for like that. I guess for small geometry like here it shouldn't be
> so bad.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tangrams/tangram/commit/55d41822a10eb6fdfbe46daa5cc05c1f80c824fd#commitcomment-12648324>
> .
>


follow line numbering:  https://help.github.com/articles/markdown-basics/


[frau-jwt/host available on the CDN](https://s.brightspace.com/lib/frau-jwt/1.0.4/host.js)


Need two equal signs in version spec (to match what pip does)


@karan-kapoor90, I took the `examples/simple.js` example and ran it and got
```xml
...
        <description><![CDATA[description]]></description>
...
```
Then I changed this line
```js
    no_cdata_fields: ['title', 'category'],
```
to
```js
    no_cdata_fields: ['title', 'category', 'description'],
```
And got this output:
```xml
...
        <description>description</description>
...
```
Does that clarify anything for you?


all KB's generally use ### in terms of sizing for headers


:rage1: :rage2: :rage3: :rage4:


incorrect bullet model.  https://help.github.com/articles/markdown-basics/


hey can u help ?

http://rektee.site40.net/

i put ur site on , with database and edit default , i create some passwords.php with " {"default-password":"********","steamAPIKey":"***************************"} "
 and dont work if u can help :+1:
http://steamcommunity.com/id/ezgamesz


same issue on bullets


I'm not so sure this should be added. I don't think hibernate should make columns non-nullable unless mapped that way.

@sebersole, wdyt?


Looks Good! thank you!


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 22](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=49&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: MSTest runner exits with not zero code. (new) Build time: 03:00:03


should not be linking to external repository for images.  your description on the text reader should not be the file name either.  it should be a handy text that describes what the image is showing for a text reader.  see the readme in github


Awesome!  Glad it may be useful


Indents in this function are adjusted to "Add-Content ********" lines. I kept these indents similar to indents in JSON file. Once all deployment types are supported with ARM mode, I'll fix indents in this function.


We don't configure the super_entity no, since the Subscription isn't itself an instance of a Channel Entity.
All we need is an FK to channel_id.


spacing issue in this


в статье написано что желательно


коммит-мессадж что то не очень))


using proper markdown for nested lists.
https://help.github.com/articles/markdown-basics/


в следующем комите будет, уже сделал!


Enabled ARM execution mode for NETWORK and BVT Tests. (Beta)


initialize and eval are using different semantic returns for JSFunctors


Do we need this? I made it just `tags: post.tags` and everything seems to be working fine.


improper bullet model.  see https://help.github.com/articles/markdown-basics/


The [yellow](https://www.youtube.com/watch?v=e_cwWP5Qf1k) is somehow interesting. But I have seen it used for warnings, so Kim's screenshot looks pretty neat.

And indeed, it would be quite cool to have the final summary colored.


no links to external locations, keep in our repository


the point is that you won't be able to add more generic classes because the default one is a class itself:
var HtcpPurge = require('htcppurge');
var p = new HtcpPurge(...);
I guess this is ok for this lib.


glad you came to check it out.


RadianceRefactor (rpg777) - i386-Windows-7-VisualStudio-12: OK (2195 of 2215 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.1%25-yellow.svg)


Get rid of the capitalized "R" in wildBerRy


Where is the steps to execute this via the execute package feature?  so people can run this in mass via API or group, not 1 at a time.


Did you get any warning without this?

I'm asking/wondering because this is rather pointless: your base class, InstanceData, already provides a virtual default destructor so there is no need to have this. In fact, this is what the compiler already generates for you. Well, almost, because an implicitly-declared destructor is always declared as an inline public member by the compiler (which has its consequences when you export the class in a shared library). But in this case, there's practically speaking no difference.

Then again, it's not wrong either, so just pointing this out in case you didn't know (for sure) :smile:


Hola Gustavo,
cuando comencé no estaba seguro de dónde trabajar y por eso quedó en esa carpeta, pero coincido con vos en que debería ir en examples. Por ahora voy a tener que seguir trabajando así porque mañana tengo que presentar algo funcionando en la facultad y estoy muy corto de tiempo, pero en unos dias lo muevo de carpeta.
Diagrama UML lamentablemente tampoco tuve tiempo de hacer.


why did you comment this out? was it broken?


on all these text followed by images you may want to add spaces and indent the images for better viewing.  also need to fix your text reader on all image links.  ![text that describes the image...not the file name](..images/image_file.png)


Excellent catch of the out-of-bounds access in m_auiEncounter! :+1:


ok, good idea


oops, will remove


One more comment, this time separate from this PR - while you're at it can you check whether there is an easy way to use coloring for the output of MakeMaker? I had checked some time back but couldn't find anything. I am quite used to colored test results from tool such as cmake or crate, would love to see that in LaTeXML.


I am wondering whether I should make the 'ltx:..' stuff colored as well.

Does the yellow look different for you?


Does this really need a conditional? I think it could all be handled with `settings[name] = value.split(", ")`. My evidence:

```
In [1]: "dog".split(", ")
Out[1]: ['dog']

In [2]: "dog, cat".split(", ")
Out[2]: ['dog', 'cat']
```


From the [MongoDB docs](http://docs.mongodb.org/manual/core/document/#the-id-field):
[For _id,] use a natural unique identifier, if available. This saves space and avoids an additional index.

We do have a "natural unique identifier," which is the group PI's user ID. That's how we ended up here.

I understand that it's uncommon for a UI to provide the primary key when requesting a new object, but I'm sticking to my story: We have a human-readable primary key, so that's what we should use. I don't want any more opaque identifiers in the API than absolutely necessary.

My preference would be to go back to having the ```_id``` required and the ```name``` optional.


Awesome job Toti! Nice clean and commented code is what I live for!


I feel like handing out a jolly rancher for every `something_complicated[0]` we remove  :)


I understand by "the general approach technically makes sense to me" that these comments don't preclude merging this PR.

(In any case, we can introduce additional changes to this part after you look the details after August 17th in a new PR).

NTC


And now for the most embarrassingly picky code review comment of all time, forgot an underscore under `Arguments`.


thanks will do it tomorrow


Ok I understand the intention now, that clears up my doubt. Thanks man, and kudos on the latest commits.


> Would it not make more sense to add a rule like
> >PM.stamp: $(makfile)
> >      make -C .. perl/PM.stamp
> (it might not work out of the box, but the intention is to start a
> sub-make using the top-level
> Makefile to re-generate the PM.stamp file)?

I don't think so (but I could easily be wrong). The problem was that
this is a dry-run but the code expects that stamping code is actually
run.

It took me a long time to realise what was going wrong (it has to be a
cleaned repo without the PM.stamp file to trigger the fault for the
dry-run)

I'd be happy if this worked and I understood why ;-)

--
Philip


If you want to make the functions local... then why don't you make them actually local? Get rid of the Internal table entirely, imho.


Nice.


sadly, yes. It'll need to be refactored around our new content structure.


Ok. Then the UI for that should get worked out with Elisa.

In the mean time, if both are present, do you have a preference for which one takes precedence when displaying a list of groups?


nice


Is polling even needed? Why do not use something like:
```csharp
listener = new System.Net.Sockets.TcpListener(IPAddress.Any, settings.Port);
 var acceptClientTask = Task.Factory.FromAsync<TcpClient>(listener.BeginAcceptTcpClient, listener.EndAcceptTcpClient, null);
```


There still needs to be a way to remove unused references if the id for a position changes, that'll cause memory leaks. There should be a way for the adapter to clear its references when that happens.

If this gets applied to the team activity adapter, we'll need to clear them all in setYear


como respondí en el comentario de Gustavo, por ahora tengo que dejarlo así por una cuestión de tiempo, pero en unos días voy a adecuarlo.

te parece usar el namespace "Rec_Habla", o mejor algo similar al nombre del branch "speechrec"?


Hi,

Thanks for making the pull request. I think it's a bit more tricky though. I'd like a user to be able to return true or false to abort the operation before it has started.

The preparations for the mode and any actions so far will have to be reverted and overridden triggers fired.

If the user specified this method I would like true and undefined to be return values for which the action is NOT aborted.

What do you think?

Regards